From 5897294fa97e17002fd8d847abd97a81cc420971 Mon Sep 17 00:00:00 2001 From: Dmitri Iouchtchenko Date: Mon, 9 Oct 2017 11:56:52 -0700 Subject: [PATCH] Add spelling TODOs Summary: Ref T13005. Added reminders not to copy/paste. Test Plan: None. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T13005 Differential Revision: https://secure.phabricator.com/D18695 --- src/applications/auth/provider/PhabricatorLDAPAuthProvider.php | 1 + .../capability/HarbormasterBuildPlanDefaultViewCapability.php | 1 + .../legalpad/xaction/LegalpadDocumentPreambleTransaction.php | 1 + 3 files changed, 3 insertions(+) diff --git a/src/applications/auth/provider/PhabricatorLDAPAuthProvider.php b/src/applications/auth/provider/PhabricatorLDAPAuthProvider.php index 7c2bf38618..44b58b85ff 100644 --- a/src/applications/auth/provider/PhabricatorLDAPAuthProvider.php +++ b/src/applications/auth/provider/PhabricatorLDAPAuthProvider.php @@ -192,6 +192,7 @@ final class PhabricatorLDAPAuthProvider extends PhabricatorAuthProvider { const KEY_VERSION = 'ldap:version'; const KEY_REFERRALS = 'ldap:referrals'; const KEY_START_TLS = 'ldap:start-tls'; + // TODO: This is misspelled! See T13005. const KEY_ANONYMOUS_USERNAME = 'ldap:anoynmous-username'; const KEY_ANONYMOUS_PASSWORD = 'ldap:anonymous-password'; const KEY_ALWAYS_SEARCH = 'ldap:always-search'; diff --git a/src/applications/harbormaster/capability/HarbormasterBuildPlanDefaultViewCapability.php b/src/applications/harbormaster/capability/HarbormasterBuildPlanDefaultViewCapability.php index 5d3d46caa0..d9ebbb2f0d 100644 --- a/src/applications/harbormaster/capability/HarbormasterBuildPlanDefaultViewCapability.php +++ b/src/applications/harbormaster/capability/HarbormasterBuildPlanDefaultViewCapability.php @@ -3,6 +3,7 @@ final class HarbormasterBuildPlanDefaultViewCapability extends PhabricatorPolicyCapability { + // TODO: This is misspelled! See T13005. const CAPABILITY = 'harbomaster.plan.default.view'; public function getCapabilityName() { diff --git a/src/applications/legalpad/xaction/LegalpadDocumentPreambleTransaction.php b/src/applications/legalpad/xaction/LegalpadDocumentPreambleTransaction.php index a2b5e1f5cd..7ccb03c95b 100644 --- a/src/applications/legalpad/xaction/LegalpadDocumentPreambleTransaction.php +++ b/src/applications/legalpad/xaction/LegalpadDocumentPreambleTransaction.php @@ -3,6 +3,7 @@ final class LegalpadDocumentPreambleTransaction extends LegalpadDocumentTransactionType { + // TODO: This is misspelled! See T13005. const TRANSACTIONTYPE = 'legalpad:premable'; public function generateOldValue($object) {