From 63443cef58b0aece1f59da618d95b63aa71e45ef Mon Sep 17 00:00:00 2001 From: Sergey Sharybin Date: Sun, 22 Jan 2023 15:39:58 +0100 Subject: [PATCH] Correct links to the ghost comment navigation --- .../diff/engine/PhabricatorInlineCommentAdjustmentEngine.php | 2 +- .../diff/view/PHUIDiffInlineCommentDetailView.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php b/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php index 095a44c221..064b1dad64 100644 --- a/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php +++ b/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php @@ -229,7 +229,7 @@ final class PhabricatorInlineCommentAdjustmentEngine $diff_id = $changeset->getDiffID(); $inline_id = $inline->getID(); $revision_id = $revision->getID(); - $href = "/D{$revision_id}?id={$diff_id}#inline-{$inline_id}"; + $href = "D{$revision_id}.id{$diff_id}#inline-{$inline_id}"; $inline ->makeEphemeral(true) diff --git a/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php b/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php index 7ebe8e8c5f..765024e8eb 100644 --- a/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php +++ b/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php @@ -141,7 +141,7 @@ final class PHUIDiffInlineCommentDetailView array( 'class' => 'ghost-icon', 'href' => $ghost['href'], - 'target' => '_blank', + // 'target' => '_blank', ), $ghost_icon); $classes[] = 'inline-comment-ghost';