From 69940f2b9ee4dfb37b17b711e5e8c05aa3490d23 Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@joshuaspence.com>
Date: Wed, 20 May 2015 09:37:39 +1000
Subject: [PATCH] Replace ArcanistPhutilTestCase refs with PhutilTestCase

Summary: Ref T7977. Remove the `PhabricatorTestCase::getLink` method. Depends on D12665.

Test Plan: `arc unit`.

Reviewers: avivey, #blessed_reviewers, epriestley

Reviewed By: avivey, #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7977

Differential Revision: https://secure.phabricator.com/D12667
---
 src/__phutil_library_map__.php                         | 10 +++++-----
 .../__tests__/DifferentialAdjustmentMapTestCase.php    |  2 +-
 .../storage/__tests__/DifferentialDiffTestCase.php     |  2 +-
 .../storage/__tests__/DifferentialHunkTestCase.php     |  2 +-
 .../request/__tests__/DiffusionURITestCase.php         |  2 +-
 src/docs/contributor/unit_tests.diviner                |  4 ++--
 src/docs/user/userguide/arcanist_coverage.diviner      |  2 +-
 src/infrastructure/testing/PhabricatorTestCase.php     | 10 +---------
 8 files changed, 13 insertions(+), 21 deletions(-)

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index 39cc7a3751..cbc2e27de1 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -3532,7 +3532,7 @@ phutil_register_library_map(array(
     'DifferentialActionEmailCommand' => 'MetaMTAEmailTransactionCommand',
     'DifferentialActionMenuEventListener' => 'PhabricatorEventListener',
     'DifferentialAddCommentView' => 'AphrontView',
-    'DifferentialAdjustmentMapTestCase' => 'ArcanistPhutilTestCase',
+    'DifferentialAdjustmentMapTestCase' => 'PhutilTestCase',
     'DifferentialAffectedPath' => 'DifferentialDAO',
     'DifferentialApplyPatchField' => 'DifferentialCustomField',
     'DifferentialAsanaRepresentationField' => 'DifferentialCustomField',
@@ -3597,7 +3597,7 @@ phutil_register_library_map(array(
     'DifferentialDiffProperty' => 'DifferentialDAO',
     'DifferentialDiffQuery' => 'PhabricatorCursorPagedPolicyAwareQuery',
     'DifferentialDiffTableOfContentsView' => 'AphrontView',
-    'DifferentialDiffTestCase' => 'ArcanistPhutilTestCase',
+    'DifferentialDiffTestCase' => 'PhutilTestCase',
     'DifferentialDiffTransaction' => 'PhabricatorApplicationTransaction',
     'DifferentialDiffViewController' => 'DifferentialController',
     'DifferentialDoorkeeperRevisionFeedStoryPublisher' => 'DoorkeeperFeedStoryPublisher',
@@ -3626,7 +3626,7 @@ phutil_register_library_map(array(
     ),
     'DifferentialHunkParserTestCase' => 'PhabricatorTestCase',
     'DifferentialHunkQuery' => 'PhabricatorCursorPagedPolicyAwareQuery',
-    'DifferentialHunkTestCase' => 'ArcanistPhutilTestCase',
+    'DifferentialHunkTestCase' => 'PhutilTestCase',
     'DifferentialInlineComment' => 'PhabricatorInlineCommentInterface',
     'DifferentialInlineCommentEditController' => 'PhabricatorInlineCommentController',
     'DifferentialInlineCommentPreviewController' => 'PhabricatorInlineCommentPreviewController',
@@ -3861,7 +3861,7 @@ phutil_register_library_map(array(
     'DiffusionTagListController' => 'DiffusionController',
     'DiffusionTagListView' => 'DiffusionView',
     'DiffusionTagsQueryConduitAPIMethod' => 'DiffusionQueryConduitAPIMethod',
-    'DiffusionURITestCase' => 'ArcanistPhutilTestCase',
+    'DiffusionURITestCase' => 'PhutilTestCase',
     'DiffusionUpdateCoverageConduitAPIMethod' => 'DiffusionConduitAPIMethod',
     'DiffusionView' => 'AphrontView',
     'DivinerArticleAtomizer' => 'DivinerAtomizer',
@@ -6083,7 +6083,7 @@ phutil_register_library_map(array(
     'PhabricatorTOTPAuthFactorTestCase' => 'PhabricatorTestCase',
     'PhabricatorTaskmasterDaemon' => 'PhabricatorDaemon',
     'PhabricatorTestApplication' => 'PhabricatorApplication',
-    'PhabricatorTestCase' => 'ArcanistPhutilTestCase',
+    'PhabricatorTestCase' => 'PhutilTestCase',
     'PhabricatorTestController' => 'PhabricatorController',
     'PhabricatorTestNoCycleEdgeType' => 'PhabricatorEdgeType',
     'PhabricatorTestStorageEngine' => 'PhabricatorFileStorageEngine',
diff --git a/src/applications/differential/storage/__tests__/DifferentialAdjustmentMapTestCase.php b/src/applications/differential/storage/__tests__/DifferentialAdjustmentMapTestCase.php
index 8fc28953fc..1146afec4f 100644
--- a/src/applications/differential/storage/__tests__/DifferentialAdjustmentMapTestCase.php
+++ b/src/applications/differential/storage/__tests__/DifferentialAdjustmentMapTestCase.php
@@ -1,6 +1,6 @@
 <?php
 
-final class DifferentialAdjustmentMapTestCase extends ArcanistPhutilTestCase {
+final class DifferentialAdjustmentMapTestCase extends PhutilTestCase {
 
   public function testBasicMaps() {
     $change_map = array(
diff --git a/src/applications/differential/storage/__tests__/DifferentialDiffTestCase.php b/src/applications/differential/storage/__tests__/DifferentialDiffTestCase.php
index dbab3768f9..45547aed42 100644
--- a/src/applications/differential/storage/__tests__/DifferentialDiffTestCase.php
+++ b/src/applications/differential/storage/__tests__/DifferentialDiffTestCase.php
@@ -1,6 +1,6 @@
 <?php
 
-final class DifferentialDiffTestCase extends ArcanistPhutilTestCase {
+final class DifferentialDiffTestCase extends PhutilTestCase {
 
   public function testDetectCopiedCode() {
     $copies = $this->detectCopiesIn('lint_engine.diff');
diff --git a/src/applications/differential/storage/__tests__/DifferentialHunkTestCase.php b/src/applications/differential/storage/__tests__/DifferentialHunkTestCase.php
index 2fcd7a9427..49866ac038 100644
--- a/src/applications/differential/storage/__tests__/DifferentialHunkTestCase.php
+++ b/src/applications/differential/storage/__tests__/DifferentialHunkTestCase.php
@@ -1,6 +1,6 @@
 <?php
 
-final class DifferentialHunkTestCase extends ArcanistPhutilTestCase {
+final class DifferentialHunkTestCase extends PhutilTestCase {
 
   public function testMakeChanges() {
     $root = dirname(__FILE__).'/hunk/';
diff --git a/src/applications/diffusion/request/__tests__/DiffusionURITestCase.php b/src/applications/diffusion/request/__tests__/DiffusionURITestCase.php
index 9ffafd9360..a6c9eeb27d 100644
--- a/src/applications/diffusion/request/__tests__/DiffusionURITestCase.php
+++ b/src/applications/diffusion/request/__tests__/DiffusionURITestCase.php
@@ -1,6 +1,6 @@
 <?php
 
-final class DiffusionURITestCase extends ArcanistPhutilTestCase {
+final class DiffusionURITestCase extends PhutilTestCase {
 
   public function testBlobDecode() {
     $map = array(
diff --git a/src/docs/contributor/unit_tests.diviner b/src/docs/contributor/unit_tests.diviner
index 6aeaaab225..ac0d57e44d 100644
--- a/src/docs/contributor/unit_tests.diviner
+++ b/src/docs/contributor/unit_tests.diviner
@@ -21,7 +21,7 @@ To add new tests to a libphutil, Arcanist or Phabricator module:
   - Create a ##__tests__/## directory in the module if it doesn't exist yet.
   - Add classes to the ##__tests__/## directory which extend from
     @{class:PhabricatorTestCase} (in Phabricator) or
-    @{class@arcanist:ArcanistPhutilTestCase} (elsewhere).
+    @{class@arcanist:PhutilTestCase} (elsewhere).
   - Run ##arc liberate## on the library root so your classes are loadable.
 
 = Running Tests =
@@ -60,7 +60,7 @@ You can see this class at @{class:PhabricatorTrivialTestCase} and run it with:
    PASS   <1ms*  testAllIsRightWithTheWorld
 
 For more information on writing tests, see
-@{class@arcanist:ArcanistPhutilTestCase} and @{class:PhabricatorTestCase}.
+@{class@arcanist:PhutilTestCase} and @{class:PhabricatorTestCase}.
 
 = Database Isolation =
 
diff --git a/src/docs/user/userguide/arcanist_coverage.diviner b/src/docs/user/userguide/arcanist_coverage.diviner
index 18339c7b05..af7d29d373 100644
--- a/src/docs/user/userguide/arcanist_coverage.diviner
+++ b/src/docs/user/userguide/arcanist_coverage.diviner
@@ -64,6 +64,6 @@ might look like this:
   );
 
 You may also want to filter coverage information to the paths passed to the
-unit test engine. See @{class@arcanist:ArcanistPhutilTestCase} and
+unit test engine. See @{class@arcanist:PhutilTestCase} and
 @{class@arcanist:PhutilUnitTestEngine} for an example of coverage integration
 in PHP using Xdebug.
diff --git a/src/infrastructure/testing/PhabricatorTestCase.php b/src/infrastructure/testing/PhabricatorTestCase.php
index 2a2834c93f..2545413de9 100644
--- a/src/infrastructure/testing/PhabricatorTestCase.php
+++ b/src/infrastructure/testing/PhabricatorTestCase.php
@@ -1,6 +1,6 @@
 <?php
 
-abstract class PhabricatorTestCase extends ArcanistPhutilTestCase {
+abstract class PhabricatorTestCase extends PhutilTestCase {
 
   const NAMESPACE_PREFIX = 'phabricator_unittest_';
 
@@ -166,14 +166,6 @@ abstract class PhabricatorTestCase extends ArcanistPhutilTestCase {
     return new PhabricatorStorageFixtureScopeGuard($name);
   }
 
-  protected function getLink($method) {
-    $phabricator_project = 'PHID-APRJ-3f1fc779edeab89b2171';
-    return
-      'https://secure.phabricator.com/diffusion/symbol/'.$method.
-      '/?lang=php&projects='.$phabricator_project.
-      '&jump=true&context='.get_class($this);
-  }
-
   /**
    * Returns an integer seed to use when building unique identifiers (e.g.,
    * non-colliding usernames). The seed is unstable and its value will change