Allowing Closing of questions

Summary:
Fixes T3579

As a basic overview, this enables the author of a question to open/close a question.

Other bits;

- Add "Open" filter to the builtin queries
- Add "Status" to search form
- Refactor ponder constants
- Add coloured bars for different question statuses

Test Plan:
- Open/Close questions
- Search for some bits
- Use filters

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T3579

Differential Revision: https://secure.phabricator.com/D6590

Conflicts:
	src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php
This commit is contained in:
Gareth Evans
2013-07-27 18:37:17 -07:00
committed by epriestley
parent 91c08ca629
commit 70a5ec600d
21 changed files with 222 additions and 24 deletions

View File

@@ -92,10 +92,34 @@ final class PonderQuestionViewController extends PonderController {
private function buildActionListView(PonderQuestion $question) {
$request = $this->getRequest();
return id(new PhabricatorActionListView())
->setUser($request->getUser())
$user = $request->getUser();
$action_list = id(new PhabricatorActionListView())
->setUser($user)
->setObject($question)
->setObjectURI($request->getRequestURI());
if ($user->getPhid() === $question->getAuthorPhid()) {
if ($question->getStatus() == PonderQuestionStatus::STATUS_OPEN) {
$name = pht("Close Question");
$icon = "delete";
$href = "close";
} else {
$name = pht("Open Question");
$icon = "enable";
$href = "open";
}
$action_list->addAction(
id(new PhabricatorActionView())
->setName($name)
->setIcon($icon)
->setRenderAsForm(true)
->setHref(
$this->getApplicationURI(
"/question/{$href}/{$this->questionID}/")));
}
return $action_list;
}
private function buildPropertyListView(
@@ -105,6 +129,11 @@ final class PonderQuestionViewController extends PonderController {
$view = id(new PhabricatorPropertyListView())
->setUser($viewer)
->setObject($question);
$view->addProperty(
pht('Status'),
PonderQuestionStatus::getQuestionStatusFullName($question->getStatus()));
$view->addProperty(
pht('Author'),
$this->getHandle($question->getAuthorPHID())->renderLink());