From 71118f8e8860f546ecd552a0617f54aa49988f67 Mon Sep 17 00:00:00 2001 From: Bryan Cuccioli Date: Mon, 3 Jun 2013 13:01:04 -0700 Subject: [PATCH] Fixed Pholio stories in feed. Summary: Pholio stories now reference the mock they're talking about. Test Plan: Generate each type of story and check that they make sense in feed/inline. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2988 Differential Revision: https://secure.phabricator.com/D6117 --- .../pholio/storage/PholioTransaction.php | 41 +++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/src/applications/pholio/storage/PholioTransaction.php b/src/applications/pholio/storage/PholioTransaction.php index ba355c4f63..25b998ef76 100644 --- a/src/applications/pholio/storage/PholioTransaction.php +++ b/src/applications/pholio/storage/PholioTransaction.php @@ -82,6 +82,47 @@ final class PholioTransaction extends PhabricatorApplicationTransaction { return parent::getTitle(); } + public function getTitleForFeed() { + $author_phid = $this->getAuthorPHID(); + $object_phid = $this->getObjectPHID(); + + $old = $this->getOldValue(); + $new = $this->getNewValue(); + + $type = $this->getTransactionType(); + switch ($type) { + case PholioTransactionType::TYPE_NAME: + if ($old === null) { + return pht( + '%s created %s.', + $this->renderHandleLink($author_phid), + $this->renderHandleLink($object_phid)); + } else { + return pht( + '%s renamed %s from "%s" to "%s".', + $this->renderHandleLink($author_phid), + $this->renderHandleLink($object_phid), + $old, + $new); + } + break; + case PholioTransactionType::TYPE_DESCRIPTION: + return pht( + '%s updated the description for %s.', + $this->renderHandleLink($author_phid), + $this->renderHandleLink($object_phid)); + break; + case PholioTransactionType::TYPE_INLINE: + return pht( + '%s added an inline comment to %s.', + $this->renderHandleLink($author_phid), + $this->renderHandleLink($object_phid)); + break; + } + + return parent::getTitleForFeed(); + } + public function hasChangeDetails() { switch ($this->getTransactionType()) { case PholioTransactionType::TYPE_DESCRIPTION: