From 73b68bc2a61910b6e6fc291a9109eb492f9dfaec Mon Sep 17 00:00:00 2001 From: Tino Breddin Date: Wed, 21 Mar 2018 07:39:34 -0700 Subject: [PATCH] Fix a possible `count(null)` in DifferentialRevisionActionTransaction Summary: This change prevents the following error when using PHP 7.2: ``` ERROR 2: count(): Parameter must be an array or an object that implements Countable at [/usr/local/lib/php/phabricator/src/applications/differential/xaction/DifferentialRevisionActionTransaction.php:132] ``` A similar issue was fixed in D18964 Test Plan: Tested in a live system. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D19242 --- .../xaction/DifferentialRevisionActionTransaction.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/differential/xaction/DifferentialRevisionActionTransaction.php b/src/applications/differential/xaction/DifferentialRevisionActionTransaction.php index a1e66379f7..07809dca59 100644 --- a/src/applications/differential/xaction/DifferentialRevisionActionTransaction.php +++ b/src/applications/differential/xaction/DifferentialRevisionActionTransaction.php @@ -80,7 +80,7 @@ abstract class DifferentialRevisionActionTransaction DifferentialRevision $revision) { return array( array(), - null, + array(), ); }