From 7a19cf5a55960ee03e9fb9233eb704cd9f9f5cef Mon Sep 17 00:00:00 2001 From: Bob Trahan Date: Tue, 15 May 2012 12:37:34 -0700 Subject: [PATCH] Fix lines of a large include path Summary: D2457 and D2459 made some changes here. This little guy just needed to be touched so it could be arc lint'd to have the proper updated include paths Sorry to spam reviewers; Evan is in Diablo 3 somewhere. :D Test Plan: no more fatal on test everything implemented (arc unit src/infrastructure/__tests__/) Reviewers: epriestley, jungejason, nh, csilvers CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2474 --- .../PhabricatorRepositorySvnCommitChangeParserWorker.php | 7 +++---- .../repository/worker/commitchangeparser/svn/__init__.php | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/applications/repository/worker/commitchangeparser/svn/PhabricatorRepositorySvnCommitChangeParserWorker.php b/src/applications/repository/worker/commitchangeparser/svn/PhabricatorRepositorySvnCommitChangeParserWorker.php index a1f20f4bfb..a85ca0c25c 100644 --- a/src/applications/repository/worker/commitchangeparser/svn/PhabricatorRepositorySvnCommitChangeParserWorker.php +++ b/src/applications/repository/worker/commitchangeparser/svn/PhabricatorRepositorySvnCommitChangeParserWorker.php @@ -701,10 +701,9 @@ class PhabricatorRepositorySvnCommitChangeParserWorker } private function parseRecursiveListFileData($file_path) { - $map = array(); - - $mode = 'xml'; - $done = false; + $map = array(); + $mode = 'xml'; + $done = false; $entry = null; foreach (new LinesOfALargeFile($file_path) as $lno => $line) { switch ($mode) { diff --git a/src/applications/repository/worker/commitchangeparser/svn/__init__.php b/src/applications/repository/worker/commitchangeparser/svn/__init__.php index 88eb272294..12c5c8dd93 100644 --- a/src/applications/repository/worker/commitchangeparser/svn/__init__.php +++ b/src/applications/repository/worker/commitchangeparser/svn/__init__.php @@ -15,7 +15,7 @@ phutil_require_module('phabricator', 'storage/qsprintf'); phutil_require_module('phabricator', 'storage/queryfx'); phutil_require_module('phutil', 'filesystem'); -phutil_require_module('phutil', 'filesystem/linesofalargefile'); +phutil_require_module('phutil', 'filesystem/linesofalarge/file'); phutil_require_module('phutil', 'filesystem/tempfile'); phutil_require_module('phutil', 'future/exec'); phutil_require_module('phutil', 'utils');