From 7fc8e19786752c0244ad687f45f35c8fb0a78dbb Mon Sep 17 00:00:00 2001
From: Chad Little <chad@phacility.com>
Date: Tue, 31 Jan 2017 19:47:57 -0800
Subject: [PATCH] Add some style to label in Favorites Menu

Summary: Ref T12174. Always sets the correct type when converting to ActionList, adds a type to Divider.

Test Plan:
Add a Label, 2 applications to the personal favorites menu, see nice styles.

{F2554901}

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T12174

Differential Revision: https://secure.phabricator.com/D17285
---
 .../PhabricatorFavoritesMainMenuBarExtension.php            | 6 +-----
 .../search/menuitem/PhabricatorDividerProfileMenuItem.php   | 1 +
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php b/src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php
index 63d8726857..9afb836b94 100644
--- a/src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php
+++ b/src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php
@@ -61,14 +61,10 @@ final class PhabricatorFavoritesMainMenuBarExtension
     $view = id(new PhabricatorActionListView())
       ->setViewer($viewer);
     foreach ($item_views as $item) {
-      $type = null;
-      if (!strlen($item->getName())) {
-        $type = PhabricatorActionView::TYPE_DIVIDER;
-      }
       $action = id(new PhabricatorActionView())
         ->setName($item->getName())
         ->setHref($item->getHref())
-        ->setType($type);
+        ->setType($item->getType());
       $view->addAction($action);
     }
 
diff --git a/src/applications/search/menuitem/PhabricatorDividerProfileMenuItem.php b/src/applications/search/menuitem/PhabricatorDividerProfileMenuItem.php
index 255e0d4b72..e6a6e608e6 100644
--- a/src/applications/search/menuitem/PhabricatorDividerProfileMenuItem.php
+++ b/src/applications/search/menuitem/PhabricatorDividerProfileMenuItem.php
@@ -38,6 +38,7 @@ final class PhabricatorDividerProfileMenuItem
     PhabricatorProfileMenuItemConfiguration $config) {
 
     $item = $this->newItem()
+      ->setType(PHUIListItemView::TYPE_DIVIDER)
       ->addClass('phui-divider');
 
     return array(