From 87f878ec8a774e3de0f4f596304bebf8f44c0d30 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Fri, 2 Aug 2019 10:44:24 -0700
Subject: [PATCH] Stop trying to CC merchants on invoices/receipts

Summary:
Fixes T13341. Currently, cart emails (invoices/receipts) are sent to members of the associated merchant account. This was just a simple way to keep an eye on things when this was first written.

The system works fine, and recent changes (almost certainly D20525) stopped these emails from working (presumably because of the slightly weird merchant permissions model).

This could be sorted out in more detail, but it looks like the path forward is to introduce a side channel for email anyway (via T8389), and that's a better way to implement this behavior since it means the normal recipients won't see a bunch of random staff/merchant email addresses on their receipts.

Test Plan: Grepped for `merchant` in this editor.

Maniphest Tasks: T13341

Differential Revision: https://secure.phabricator.com/D20696
---
 src/applications/phortune/editor/PhortuneCartEditor.php | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/applications/phortune/editor/PhortuneCartEditor.php b/src/applications/phortune/editor/PhortuneCartEditor.php
index dcf1f2d0e0..854c4ab9c7 100644
--- a/src/applications/phortune/editor/PhortuneCartEditor.php
+++ b/src/applications/phortune/editor/PhortuneCartEditor.php
@@ -188,8 +188,8 @@ final class PhortuneCartEditor
   protected function getMailTo(PhabricatorLiskDAO $object) {
     $phids = array();
 
-    // Reload the cart to pull merchant and account information, in case we
-    // just created the object.
+    // Reload the cart to pull account information, in case we just created the
+    // object.
     $cart = id(new PhortuneCartQuery())
       ->setViewer($this->requireActor())
       ->withPHIDs(array($object->getPHID()))
@@ -199,10 +199,6 @@ final class PhortuneCartEditor
       $phids[] = $account_member;
     }
 
-    foreach ($cart->getMerchant()->getMemberPHIDs() as $merchant_member) {
-      $phids[] = $merchant_member;
-    }
-
     return $phids;
   }