Improve design of PhabricatorObjectListView

Summary: See discussion in T2014. Aligns this element more closely with @chad's `frame_v3.psd` mock, and implements the icon/label element. Removes "details".

Test Plan: {F27062} {F27063} {F27064} {F27065}

Reviewers: btrahan, chad

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2014

Differential Revision: https://secure.phabricator.com/D4179

src/applications/phame/controller/PhameController.php

@@ -41,30 +41,40 @@ abstract class PhameController extends PhabricatorController {
     assert_instances_of($posts, 'PhamePost');
 
     $list = id(new PhabricatorObjectItemListView())
+      ->setViewer($user)
       ->setNoDataString($nodata);
 
     foreach ($posts as $post) {
-      $item = id(new PhabricatorObjectItemView())
-        ->setHeader($post->getTitle())
-        ->setHref($this->getApplicationURI('post/view/'.$post->getID().'/'))
-        ->addDetail(
-          pht('Blogger'),
-          $this->getHandle($post->getBloggerPHID())->renderLink())
-        ->addDetail(
-          pht('Blog'),
-          $post->getBlog()
-            ? $this->getHandle($post->getBlog()->getPHID())->renderLink()
-            : '-');
+      $blogger = $this->getHandle($post->getBloggerPHID())->renderLink();
 
-      if ($post->isDraft()) {
-        $item->addAttribute(pht('Draft'));
-      } else {
-        $date_published = phabricator_datetime(
-          $post->getDatePublished(),
-          $user);
-        $item->addAttribute(pht('Published on %s', $date_published));
+      $blog = null;
+      if ($post->getBlog()) {
+        $blog = $this->getHandle($post->getBlog()->getPHID())->renderLink();
       }
 
+      $published = null;
+      if ($post->getDatePublished()) {
+        $published = phabricator_date($post->getDatePublished(), $user);
+      }
+
+      $draft = $post->isDraft();
+
+      $item = id(new PhabricatorObjectItemView())
+        ->setObject($post)
+        ->setHeader($post->getTitle())
+        ->setHref($this->getApplicationURI('post/view/'.$post->getID().'/'));
+
+      if ($blog) {
+        $item->addAttribute($blog);
+      }
+
+      if ($draft) {
+        $desc = pht('Draft by %s', $blogger);
+      } else {
+        $desc = pht('Published on %s by %s', $published, $blogger);
+      }
+      $item->addAttribute($desc);
+
       $list->addItem($item);
     }