From 88d15ce79910e78ea94df53dda4ca2fc9f3dc9cd Mon Sep 17 00:00:00 2001 From: lkassianik Date: Sat, 2 Apr 2016 19:17:36 -0700 Subject: [PATCH] Adding awarder info to recipient list on badge view Summary: Closes T8940, recipient list in badge view should show awarder and date info. Took a first stab at how we want to make the date look, but not sure. Looks odd as it is. Test Plan: Open badge that has awards. Each recipient in list should have a subheader such as "Awarded by ... on ..." Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin Maniphest Tasks: T8940 Differential Revision: https://secure.phabricator.com/D15590 --- .../view/PhabricatorBadgesRecipientsListView.php | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/applications/badges/view/PhabricatorBadgesRecipientsListView.php b/src/applications/badges/view/PhabricatorBadgesRecipientsListView.php index 20fe2a0b3d..7b2ceaa38b 100644 --- a/src/applications/badges/view/PhabricatorBadgesRecipientsListView.php +++ b/src/applications/badges/view/PhabricatorBadgesRecipientsListView.php @@ -20,6 +20,7 @@ final class PhabricatorBadgesRecipientsListView extends AphrontView { $badge = $this->badge; $handles = $this->handles; + $awards = mpull($badge->getAwards(), null, 'getRecipientPHID'); $can_edit = PhabricatorPolicyFilter::hasCapability( $viewer, @@ -34,8 +35,17 @@ final class PhabricatorBadgesRecipientsListView extends AphrontView { $remove_uri = '/badges/recipients/'. $badge->getID().'/remove/?phid='.$handle->getPHID(); + $award = $awards[$handle->getPHID()]; + $awarder_handle = $viewer->renderHandle($award->getAwarderPHID()); + $award_date = phabricator_date($award->getDateCreated(), $viewer); + $awarder_info = pht( + 'Awarded by %s on %s', + $awarder_handle->render(), + $award_date); + $item = id(new PHUIObjectItemView()) ->setHeader($handle->getFullName()) + ->setSubhead($awarder_info) ->setHref($handle->getURI()) ->setImageURI($handle->getImageURI());