From 8a8a48cc8fa7f821738e0d328f0d2d014bafdeed Mon Sep 17 00:00:00 2001
From: vrana <jakubv@fb.com>
Date: Mon, 18 Jun 2012 18:05:06 -0700
Subject: [PATCH] Fix displaying of inlines related both to visible and hidden
 diff

Summary: I tried also filling the column by empty space but this looks better.

Test Plan: Displayed a comment both with visible and hidden inlines.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T1216

Differential Revision: https://secure.phabricator.com/D2789
---
 .../diff/view/PhabricatorInlineSummaryView.php             | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/infrastructure/diff/view/PhabricatorInlineSummaryView.php b/src/infrastructure/diff/view/PhabricatorInlineSummaryView.php
index 5ea443c2da..bc7b40c120 100644
--- a/src/infrastructure/diff/view/PhabricatorInlineSummaryView.php
+++ b/src/infrastructure/diff/view/PhabricatorInlineSummaryView.php
@@ -78,11 +78,9 @@ final class PhabricatorInlineSummaryView extends AphrontView {
         }
       }
 
-      $cols = $has_where ? 3 : 2;
-
       $rows[] =
         '<tr>'.
-          '<th colspan="'.$cols.'">'.
+          '<th colspan="3">'.
             phutil_escape_html($group).
           '</th>'.
         '</tr>';
@@ -123,6 +121,7 @@ final class PhabricatorInlineSummaryView extends AphrontView {
 
         $where = idx($item, 'where');
 
+        $colspan = ($has_where ? '' : ' colspan="2"');
         $rows[] =
           '<tr>'.
             '<td class="inline-line-number">'.$lines.'</td>'.
@@ -131,7 +130,7 @@ final class PhabricatorInlineSummaryView extends AphrontView {
                 phutil_escape_html($where).
               '</td>'
               : null).
-            '<td class="inline-summary-content">'.
+            '<td class="inline-summary-content"'.$colspan.'>'.
               '<div class="phabricator-remarkup">'.
                 $item['content'].
               '</div>'.