From 8b7e99f68c977c98f699134dba5da16ad27fca4a Mon Sep 17 00:00:00 2001
From: Aviv Eyal <avivey@gmail.com>
Date: Fri, 16 Dec 2016 00:52:05 +0000
Subject: [PATCH] Introduce ModularTransactionType::isRenderingTargetExternal

Summary: This is just some housekeeping - see note in D16287. Basically, "isTextMode" doesn't convey enough information.

Test Plan: `git grep isTextMode | grep -v Remarkup`, and visit all callsites; There are 4 of them left.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D17063
---
 .../storage/PhabricatorModularTransactionType.php  | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/applications/transactions/storage/PhabricatorModularTransactionType.php b/src/applications/transactions/storage/PhabricatorModularTransactionType.php
index 2ae06131f4..2606264778 100644
--- a/src/applications/transactions/storage/PhabricatorModularTransactionType.php
+++ b/src/applications/transactions/storage/PhabricatorModularTransactionType.php
@@ -227,7 +227,7 @@ abstract class PhabricatorModularTransactionType
       // server's settings, or the user may later refer back to it after
       // changing timezones.
 
-      if ($this->isTextMode()) {
+      if ($this->isRenderingTargetExternal()) {
         $offset = $viewer->getTimeZoneOffsetInHours();
         if ($offset >= 0) {
           $display = pht('%s (UTC+%d)', $display, $offset);
@@ -277,7 +277,17 @@ abstract class PhabricatorModularTransactionType
     return !strlen($value);
   }
 
-  protected function isTextMode() {
+  /**
+   * When rendering to external targets (Email/Asana/etc), we need to include
+   * more information that users can't obtain later.
+   */
+  final protected function isRenderingTargetExternal() {
+    // Right now, this is our best proxy for this:
+    return $this->isTextMode();
+    // "TARGET_TEXT" means "EMail" and "TARGET_HTML" means "Web".
+  }
+
+  final protected function isTextMode() {
     $target = $this->getStorage()->getRenderingTarget();
     return ($target == PhabricatorApplicationTransaction::TARGET_TEXT);
   }