From 8bed2f43876bb4140918c2baa4719c27e0fa469d Mon Sep 17 00:00:00 2001 From: vrana Date: Mon, 16 Jan 2012 16:42:14 -0800 Subject: [PATCH] Utilize phutil_render_tag() Test Plan: Display diff with lint error. Reviewers: pad, epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D1428 --- .../lint/DifferentialLintFieldSpecification.php | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/applications/differential/field/specification/lint/DifferentialLintFieldSpecification.php b/src/applications/differential/field/specification/lint/DifferentialLintFieldSpecification.php index 88b102304a..3935556422 100644 --- a/src/applications/differential/field/specification/lint/DifferentialLintFieldSpecification.php +++ b/src/applications/differential/field/specification/lint/DifferentialLintFieldSpecification.php @@ -56,10 +56,12 @@ final class DifferentialLintFieldSpecification $line_link = phutil_escape_html($line); if (isset($path_changesets[$path])) { - $href = '#C'.$path_changesets[$path].'NL'.$line; - $line_link = ''. - $line_link. - ''; + $line_link = phutil_render_tag( + 'a', + array( + 'href' => '#C'.$path_changesets[$path].'NL'.$line, + ), + $line_link); } $message_markup[] = '
  • '.