From 8d6209b7011336fee24eceeb53f9bb448da3290c Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 10 Jun 2015 15:34:02 -0700 Subject: [PATCH] Don't require users be activated in order to establish Web sessions Summary: Ref T8496. In D13123, the condition for establishing a web session was made too strict: we need to let non-activated users establish web sessions in order to see "you are a bad disabled person" or "your account needs approval" messages. The previous behavior let them in, the new behavior incorrectly locks them out. Test Plan: Enabled login approvals and registered a new account with username/password auth. Reviewers: btrahan Reviewed By: btrahan Subscribers: joshuaspence, epriestley Maniphest Tasks: T8496 Differential Revision: https://secure.phabricator.com/D13239 --- src/applications/people/storage/PhabricatorUser.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/applications/people/storage/PhabricatorUser.php b/src/applications/people/storage/PhabricatorUser.php index 1d1d3316c0..d86f5e380d 100644 --- a/src/applications/people/storage/PhabricatorUser.php +++ b/src/applications/people/storage/PhabricatorUser.php @@ -118,10 +118,6 @@ final class PhabricatorUser } public function canEstablishWebSessions() { - if (!$this->isUserActivated()) { - return false; - } - if ($this->getIsMailingList()) { return false; }