From 8fc5977b9afbc46b90636edc5ceea274abe58a6b Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Sat, 26 Apr 2014 12:31:55 -0700
Subject: [PATCH] Fix quick create on mobile

Summary: Fixes T4903. At some point maybe-soonish we should maybe go make `"device" => true` the default, and put `"device" => "hella-busted"` on the remaining bad pages.

Test Plan: L@@K @ W/ iOS Simulator

Reviewers: chad

Reviewed By: chad

Subscribers: epriestley, k

Maniphest Tasks: T4903

Differential Revision: https://secure.phabricator.com/D8863
---
 .../home/controller/PhabricatorHomeQuickCreateController.php | 1 +
 .../people/remarkup/PhabricatorRemarkupRuleMention.php       | 5 ++++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/applications/home/controller/PhabricatorHomeQuickCreateController.php b/src/applications/home/controller/PhabricatorHomeQuickCreateController.php
index 82b39cb688..cf4394daad 100644
--- a/src/applications/home/controller/PhabricatorHomeQuickCreateController.php
+++ b/src/applications/home/controller/PhabricatorHomeQuickCreateController.php
@@ -29,6 +29,7 @@ final class PhabricatorHomeQuickCreateController
       ),
       array(
         'title' => pht('Quick Create'),
+        'device' => true,
       ));
   }
 
diff --git a/src/applications/people/remarkup/PhabricatorRemarkupRuleMention.php b/src/applications/people/remarkup/PhabricatorRemarkupRuleMention.php
index be35114892..7e6fb237ef 100644
--- a/src/applications/people/remarkup/PhabricatorRemarkupRuleMention.php
+++ b/src/applications/people/remarkup/PhabricatorRemarkupRuleMention.php
@@ -18,7 +18,10 @@ final class PhabricatorRemarkupRuleMention
   // username, so we'll incorrectly pick it up, but there's little to be done
   // about that. We forbid terminal periods so that we can correctly capture
   // "@joe" instead of "@joe." in "Hey, @joe.".
-  const REGEX = '/(?<!\w)@([a-zA-Z0-9._-]*[a-zA-Z0-9_-])/';
+  //
+  // We disallow "@@joe" because it creates a false positive in the common
+  // construction "l@@k", made popular by eBay.
+  const REGEX = '/(?<!\w|@)@([a-zA-Z0-9._-]*[a-zA-Z0-9_-])/';
 
   public function apply($text) {
     return preg_replace_callback(