Make Differential inline comment rendering more consistent and somewhat more modern

Summary: Ref T2222. Ref T1790. I partially modernized this recently, but bring it to the mail version too.

Test Plan: See screenshots.

Reviewers: btrahan

Reviewed By: btrahan

CC: zeeg, aran

Maniphest Tasks: T1790, T2222

Differential Revision: https://secure.phabricator.com/D8294
This commit is contained in:
epriestley
2014-02-21 11:52:03 -08:00
parent 9384c9e36b
commit 92ac8b5ad9
11 changed files with 145 additions and 108 deletions

View File

@@ -173,7 +173,7 @@ abstract class PhabricatorInlineCommentController
// application identifier for the changeset. In Diffusion, it's a Path ID.
$this->changesetID = $request->getInt('changeset');
$this->isNewFile = $request->getBool('is_new');
$this->isNewFile = (int)$request->getBool('is_new');
$this->isOnRight = $request->getBool('on_right');
$this->lineNumber = $request->getInt('number');
$this->lineLength = $request->getInt('length');