From 9469e3d6ac7a231a654d03696b667b7f2d355c4f Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 7 Jun 2016 14:52:38 -0700 Subject: [PATCH] Embed videos in Remarkup at actual size Summary: Ref T6916. Current rules tend to make videos gigantic. Just embed them at actual size, scaling them down if they're too big to fit. Browsers generally provide some kind of "expand / fullscreen" element automatically anyway. Test Plan: Viewed videos locally, saw them sized a little more reasonably. Reviewers: chad Reviewed By: chad Maniphest Tasks: T6916 Differential Revision: https://secure.phabricator.com/D16076 --- resources/celerity/map.php | 10 +++++----- webroot/rsrc/css/core/remarkup.css | 3 +-- webroot/rsrc/css/phui/phui-property-list-view.css | 3 +-- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index e6f372b2ca..593aad51bd 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -7,7 +7,7 @@ */ return array( 'names' => array( - 'core.pkg.css' => '0e3b60db', + 'core.pkg.css' => 'c076c614', 'core.pkg.js' => '3f2c120d', 'darkconsole.pkg.js' => 'e7393ebb', 'differential.pkg.css' => 'f3fb8324', @@ -104,7 +104,7 @@ return array( 'rsrc/css/application/tokens/tokens.css' => '3d0f239e', 'rsrc/css/application/uiexample/example.css' => '528b19de', 'rsrc/css/core/core.css' => 'd0801452', - 'rsrc/css/core/remarkup.css' => '845a390d', + 'rsrc/css/core/remarkup.css' => '523d34bb', 'rsrc/css/core/syntax.css' => '9fc496d5', 'rsrc/css/core/z-index.css' => '5b6fcf3f', 'rsrc/css/diviner/diviner-shared.css' => 'aa3656aa', @@ -149,7 +149,7 @@ return array( 'rsrc/css/phui/phui-pager.css' => 'bea33d23', 'rsrc/css/phui/phui-pinboard-view.css' => '2495140e', 'rsrc/css/phui/phui-profile-menu.css' => 'c8557f33', - 'rsrc/css/phui/phui-property-list-view.css' => '6458f614', + 'rsrc/css/phui/phui-property-list-view.css' => 'e7b212a0', 'rsrc/css/phui/phui-remarkup-preview.css' => '1a8f2591', 'rsrc/css/phui/phui-segment-bar-view.css' => '46342871', 'rsrc/css/phui/phui-spacing.css' => '042804d6', @@ -786,7 +786,7 @@ return array( 'phabricator-object-selector-css' => '85ee8ce6', 'phabricator-phtize' => 'd254d646', 'phabricator-prefab' => 'e67df814', - 'phabricator-remarkup-css' => '845a390d', + 'phabricator-remarkup-css' => '523d34bb', 'phabricator-search-results-css' => '7dea472c', 'phabricator-shaped-request' => '7cbe244b', 'phabricator-side-menu-view-css' => 'dd849797', @@ -853,7 +853,7 @@ return array( 'phui-pager-css' => 'bea33d23', 'phui-pinboard-view-css' => '2495140e', 'phui-profile-menu-css' => 'c8557f33', - 'phui-property-list-view-css' => '6458f614', + 'phui-property-list-view-css' => 'e7b212a0', 'phui-remarkup-preview-css' => '1a8f2591', 'phui-segment-bar-view-css' => '46342871', 'phui-spacing-css' => '042804d6', diff --git a/webroot/rsrc/css/core/remarkup.css b/webroot/rsrc/css/core/remarkup.css index 085fddf876..034c5a83c6 100644 --- a/webroot/rsrc/css/core/remarkup.css +++ b/webroot/rsrc/css/core/remarkup.css @@ -225,8 +225,7 @@ video.phabricator-media { .phabricator-remarkup video { display: block; margin: 0 auto; - min-width: 240px; - width: 90%; + max-width: 95%; } .phabricator-remarkup-mention-exists { diff --git a/webroot/rsrc/css/phui/phui-property-list-view.css b/webroot/rsrc/css/phui/phui-property-list-view.css index da6ff63dff..c401a18ef2 100644 --- a/webroot/rsrc/css/phui/phui-property-list-view.css +++ b/webroot/rsrc/css/phui/phui-property-list-view.css @@ -163,8 +163,7 @@ .phui-property-list-video { display: block; margin: 0 auto; - width: 90%; - min-width: 240px; + max-width: 95%; } /* When tags appear in property lists, give them a little more vertical