Revamp Projects with new navigation

Summary:
A refresh of Projects including a new navigations UI.

 - New Navigation UI.
 - Auto switch default page if Workboard has been initialized
 - Move Feed to it's own page
 - Increase 'tasks' on Project Home to 50 over 10
 - Fix various display bugs on Workboards
 - Remove 'crumbs' from Project portal (unneeded).

Test Plan:
- clicked a link for a project with no workboard and saw the profile
- clicked a link for a project with a workboard and saw the workboard
- navigated around the various edit pages, inspecting links and making sure things linked back to the new profile uri

{F266460}

{F266461}

{F266462}

{F266463}

{F266464}

Reviewers: epriestley, btrahan

Reviewed By: epriestley, btrahan

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11272

src/applications/project/controller/PhabricatorProjectMembersEditController.php

@@ -12,15 +12,16 @@ final class PhabricatorProjectMembersEditController
   public function processRequest() {
     $request = $this->getRequest();
     $user = $request->getUser();
+    $id = $request->getURIData('id');
 
     $project = id(new PhabricatorProjectQuery())
       ->setViewer($user)
       ->withIDs(array($this->id))
       ->needMembers(true)
+      ->needImages(true)
       ->requireCapabilities(
         array(
           PhabricatorPolicyCapability::CAN_VIEW,
-          PhabricatorPolicyCapability::CAN_EDIT,
         ))
       ->executeOne();
     if (!$project) {
@@ -73,39 +74,44 @@ final class PhabricatorProjectMembersEditController
       );
     }
 
-    $header_name = pht('Edit Members');
-    $title = pht('Edit Members');
+    $can_edit = PhabricatorPolicyFilter::hasCapability(
+      $user,
+      $project,
+      PhabricatorPolicyCapability::CAN_EDIT);
 
-    $form = new AphrontFormView();
-    $form
-      ->setUser($user)
-      ->appendChild(
-        id(new AphrontFormTokenizerControl())
-          ->setName('phids')
-          ->setLabel(pht('Add Members'))
-          ->setDatasource(new PhabricatorPeopleDatasource()))
-      ->appendChild(
-        id(new AphrontFormSubmitControl())
-          ->addCancelButton('/project/view/'.$project->getID().'/')
-          ->setValue(pht('Add Members')));
+    $form_box = null;
+    $title = pht('Add Members');
+    if ($can_edit) {
+      $header_name = pht('Edit Members');
+      $view_uri = $this->getApplicationURI('profile/'.$project->getID().'/');
+
+      $form = new AphrontFormView();
+      $form
+        ->setUser($user)
+        ->appendChild(
+          id(new AphrontFormTokenizerControl())
+            ->setName('phids')
+            ->setLabel(pht('Add Members'))
+            ->setDatasource(new PhabricatorPeopleDatasource()))
+        ->appendChild(
+          id(new AphrontFormSubmitControl())
+            ->addCancelButton($view_uri)
+            ->setValue(pht('Add Members')));
+      $form_box = id(new PHUIObjectBoxView())
+        ->setHeaderText($title)
+        ->setForm($form);
+    }
 
     $member_list = $this->renderMemberList($project, $handles);
 
-    $form_box = id(new PHUIObjectBoxView())
-      ->setHeaderText($title)
-      ->setForm($form);
-
-    $crumbs = $this->buildApplicationCrumbs($this->buildSideNavView())
-      ->addTextCrumb(
-        $project->getName(),
-        '/project/view/'.$project->getID().'/')
-      ->addTextCrumb(pht('Edit Members'), $this->getApplicationURI());
+    $nav = $this->buildIconNavView($project);
+    $nav->selectFilter("members/{$id}/");
+    $nav->appendChild($form_box);
+    $nav->appendChild($member_list);
 
     return $this->buildApplicationPage(
       array(
-        $crumbs,
-        $form_box,
-        $member_list,
+        $nav,
       ),
       array(
         'title' => $title,
@@ -119,8 +125,14 @@ final class PhabricatorProjectMembersEditController
     $request = $this->getRequest();
     $viewer = $request->getUser();
 
+    $can_edit = PhabricatorPolicyFilter::hasCapability(
+      $viewer,
+      $project,
+      PhabricatorPolicyCapability::CAN_EDIT);
+
     $list = id(new PHUIObjectItemListView())
-      ->setNoDataString(pht('This project does not have any members.'));
+      ->setNoDataString(pht('This project does not have any members.'))
+      ->setStackable(true);
 
     foreach ($handles as $handle) {
       $remove_uri = $this->getApplicationURI(
@@ -131,16 +143,22 @@ final class PhabricatorProjectMembersEditController
         ->setHref($handle->getURI())
         ->setImageURI($handle->getImageURI());
 
-      $item->addAction(
-        id(new PHUIListItemView())
-          ->setIcon('fa-times')
-          ->setName(pht('Remove'))
-          ->setHref($remove_uri)
-          ->setWorkflow(true));
+      if ($can_edit) {
+        $item->addAction(
+          id(new PHUIListItemView())
+            ->setIcon('fa-times')
+            ->setName(pht('Remove'))
+            ->setHref($remove_uri)
+            ->setWorkflow(true));
+      }
 
       $list->addItem($item);
     }
 
-    return $list;
+    $box = id(new PHUIObjectBoxView())
+      ->setHeaderText(pht('Members'))
+      ->appendChild($list);
+
+    return $box;
   }
 }