From 9540ed7ec2ee180dc6edd9bada92c0b18b9ead7b Mon Sep 17 00:00:00 2001 From: Chad Little Date: Sun, 18 Jun 2017 08:50:50 +0200 Subject: [PATCH] Use visibility hidden on remarkup checkboxes Summary: Fixes T12850, marks it hidden with zero width so the element still exists in the DOM Test Plan: T12850 code, locally Reviewers: epriestley, amckinley, avivey Reviewed By: avivey Subscribers: Korvin Maniphest Tasks: T12850 Differential Revision: https://secure.phabricator.com/D18130 --- resources/celerity/map.php | 6 +++--- webroot/rsrc/css/core/remarkup.css | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 98d677d53c..3e80c99baa 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -9,7 +9,7 @@ return array( 'names' => array( 'conpherence.pkg.css' => 'ff161f2d', 'conpherence.pkg.js' => 'b5b51108', - 'core.pkg.css' => 'ab24402f', + 'core.pkg.css' => '6d40b714', 'core.pkg.js' => '5d80e0db', 'darkconsole.pkg.js' => '1f9a31bc', 'differential.pkg.css' => '4ec4a37a', @@ -115,7 +115,7 @@ return array( 'rsrc/css/application/tokens/tokens.css' => '3d0f239e', 'rsrc/css/application/uiexample/example.css' => '528b19de', 'rsrc/css/core/core.css' => '23beb330', - 'rsrc/css/core/remarkup.css' => '509fb36e', + 'rsrc/css/core/remarkup.css' => 'eb37bd0d', 'rsrc/css/core/syntax.css' => 'cae95e89', 'rsrc/css/core/z-index.css' => '9d8f7c4b', 'rsrc/css/diviner/diviner-shared.css' => '896f1d43', @@ -795,7 +795,7 @@ return array( 'phabricator-object-selector-css' => '85ee8ce6', 'phabricator-phtize' => 'd254d646', 'phabricator-prefab' => 'c5af80a2', - 'phabricator-remarkup-css' => '509fb36e', + 'phabricator-remarkup-css' => 'eb37bd0d', 'phabricator-search-results-css' => '8f8e08ed', 'phabricator-shaped-request' => '7cbe244b', 'phabricator-slowvote-css' => 'a94b7230', diff --git a/webroot/rsrc/css/core/remarkup.css b/webroot/rsrc/css/core/remarkup.css index 98529b9434..1de7ccf85a 100644 --- a/webroot/rsrc/css/core/remarkup.css +++ b/webroot/rsrc/css/core/remarkup.css @@ -128,7 +128,8 @@ } .phabricator-remarkup .remarkup-list-with-checkmarks input { - display: none; + visibility: hidden; + width: 0; } .phabricator-remarkup .remarkup-list-with-checkmarks