From 980f06f3da66572fdaf1fedcd318b72acdc031cc Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 5 Feb 2014 11:03:00 -0800 Subject: [PATCH] Disallow "{", "}" and "#" in Project monograms Summary: Currently, mentioning two projects in a block (`{#a} {#b}`) produces an overzealous parse. Forbid these characters in project monograms. Test Plan: Got correct markup. Reviewers: btrahan, dctrwatson, chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D8141 --- .../project/phid/PhabricatorProjectPHIDTypeProject.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/project/phid/PhabricatorProjectPHIDTypeProject.php b/src/applications/project/phid/PhabricatorProjectPHIDTypeProject.php index 56165dd3cf..312ead52ea 100644 --- a/src/applications/project/phid/PhabricatorProjectPHIDTypeProject.php +++ b/src/applications/project/phid/PhabricatorProjectPHIDTypeProject.php @@ -45,7 +45,7 @@ final class PhabricatorProjectPHIDTypeProject extends PhabricatorPHIDType { // NOTE: This explicitly does not match strings which contain only // digits, because digit strings like "#123" are used to reference tasks at // Facebook and are somewhat conventional in general. - return '[^\s.!,:;]*[^\s\d.!,:;]+[^\s.!,:;]*'; + return '[^\s.!,:;{}#]*[^\s\d.!,:;{}#]+[^\s.!,:;{}#]*'; } public function canLoadNamedObject($name) {