Rename "needReviewerStatus()" into "needReviewers()"
Summary: Ref T10967. The old name was because we had a `getReviewers()` tied to `needRelationships()`, rename this method to use a simpler and more clear name. Test Plan: `grep`, browsed around. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10967 Differential Revision: https://secure.phabricator.com/D17519
This commit is contained in:
@@ -1765,7 +1765,7 @@ final class DiffusionBrowseController extends DiffusionController {
|
||||
->withUpdatedEpochBetween($recent, null)
|
||||
->setOrder(DifferentialRevisionQuery::ORDER_MODIFIED)
|
||||
->setLimit(10)
|
||||
->needReviewerStatus(true)
|
||||
->needReviewers(true)
|
||||
->needFlags(true)
|
||||
->needDrafts(true)
|
||||
->execute();
|
||||
|
||||
@@ -190,7 +190,7 @@ final class HeraldCommitAdapter
|
||||
$revision = id(new DifferentialRevisionQuery())
|
||||
->withIDs(array($revision_id))
|
||||
->setViewer(PhabricatorUser::getOmnipotentUser())
|
||||
->needReviewerStatus(true)
|
||||
->needReviewers(true)
|
||||
->executeOne();
|
||||
if ($revision) {
|
||||
$this->affectedRevision = $revision;
|
||||
|
||||
@@ -190,7 +190,7 @@ final class HeraldPreCommitContentAdapter extends HeraldPreCommitAdapter {
|
||||
$this->revision = id(new DifferentialRevisionQuery())
|
||||
->setViewer(PhabricatorUser::getOmnipotentUser())
|
||||
->withIDs(array($revision_id))
|
||||
->needReviewerStatus(true)
|
||||
->needReviewers(true)
|
||||
->executeOne();
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user