From a20ba85b75eb5fc78906befba0f4d6eb0265cbe5 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 4 Mar 2013 12:54:20 -0800 Subject: [PATCH] Fix a missing viewer after D5152 I think this one got mucked up in a merge or I didn't grep properly. Auditors: vrana --- .../config/storage/PhabricatorConfigTransaction.php | 3 ++- .../transactions/storage/PhabricatorApplicationTransaction.php | 2 +- .../view/PhabricatorApplicationTransactionView.php | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/applications/config/storage/PhabricatorConfigTransaction.php b/src/applications/config/storage/PhabricatorConfigTransaction.php index c02c65859b..a0428a73d7 100644 --- a/src/applications/config/storage/PhabricatorConfigTransaction.php +++ b/src/applications/config/storage/PhabricatorConfigTransaction.php @@ -78,7 +78,7 @@ final class PhabricatorConfigTransaction return parent::hasChangeDetails(); } - public function renderChangeDetails() { + public function renderChangeDetails(PhabricatorUser $viewer) { $old = $this->getOldValue(); $new = $this->getNewValue(); @@ -97,6 +97,7 @@ final class PhabricatorConfigTransaction } $view = id(new PhabricatorApplicationTransactionTextDiffDetailView()) + ->setUser($viewer) ->setOldText($old_text) ->setNewText($new_text); diff --git a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php index 7779f3313c..782e6d8b8d 100644 --- a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php +++ b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php @@ -325,7 +325,7 @@ abstract class PhabricatorApplicationTransaction return false; } - public function renderChangeDetails() { + public function renderChangeDetails(PhabricatorUser $viewer) { return null; } diff --git a/src/applications/transactions/view/PhabricatorApplicationTransactionView.php b/src/applications/transactions/view/PhabricatorApplicationTransactionView.php index c77941a458..8f9c5f6eb8 100644 --- a/src/applications/transactions/view/PhabricatorApplicationTransactionView.php +++ b/src/applications/transactions/view/PhabricatorApplicationTransactionView.php @@ -206,7 +206,7 @@ class PhabricatorApplicationTransactionView extends AphrontView { 'style' => 'display: none', 'class' => 'phabricator-timeline-change-details', ), - $xaction->renderChangeDetails()); + $xaction->renderChangeDetails($this->getUser())); return array( $show_more,