diff --git a/src/aphront/console/DarkConsoleController.php b/src/aphront/console/DarkConsoleController.php index 6f46716312..cb11db7b5c 100644 --- a/src/aphront/console/DarkConsoleController.php +++ b/src/aphront/console/DarkConsoleController.php @@ -8,22 +8,31 @@ final class DarkConsoleController extends PhabricatorController { protected $op; protected $data; + public function shouldRequireLogin() { + return !PhabricatorEnv::getEnvConfig('darkconsole.always-on'); + } + public function processRequest() { $request = $this->getRequest(); $user = $request->getUser(); + $response = id(new AphrontAjaxResponse())->setDisableConsole(true); + + if (!$user->isLoggedIn()) { + return $response; + } $visible = $request->getStr('visible'); if (strlen($visible)) { $user->setConsoleVisible((int)$visible); $user->save(); - return id(new AphrontAjaxResponse())->setDisableConsole(true); + return $response; } $tab = $request->getStr('tab'); if (strlen($tab)) { $user->setConsoleTab($tab); $user->save(); - return id(new AphrontAjaxResponse())->setDisableConsole(true); + return $response; } return new Aphront404Response(); diff --git a/src/aphront/console/DarkConsoleDataController.php b/src/aphront/console/DarkConsoleDataController.php index af5364fea6..f761308ada 100644 --- a/src/aphront/console/DarkConsoleDataController.php +++ b/src/aphront/console/DarkConsoleDataController.php @@ -7,6 +7,10 @@ final class DarkConsoleDataController extends PhabricatorController { private $key; + public function shouldRequireLogin() { + return !PhabricatorEnv::getEnvConfig('darkconsole.always-on'); + } + public function willProcessRequest(array $data) { $this->key = $data['key']; }