Make setup check groups more robust against fataling existing subclasses
Auditors: chad
This commit is contained in:
@@ -19,7 +19,10 @@ abstract class PhabricatorSetupCheck {
|
||||
$issue = id(new PhabricatorSetupIssue())
|
||||
->setIssueKey($key);
|
||||
$this->issues[$key] = $issue;
|
||||
$issue->setGroup($this->getDefaultGroup());
|
||||
|
||||
if ($this->getDefaultGroup()) {
|
||||
$issue->setGroup($this->getDefaultGroup());
|
||||
}
|
||||
|
||||
return $issue;
|
||||
}
|
||||
@@ -28,6 +31,10 @@ abstract class PhabricatorSetupCheck {
|
||||
return $this->issues;
|
||||
}
|
||||
|
||||
public function getDefaultGroup() {
|
||||
return null;
|
||||
}
|
||||
|
||||
final public function runSetupChecks() {
|
||||
$this->issues = array();
|
||||
$this->executeChecks();
|
||||
|
||||
Reference in New Issue
Block a user