archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Revert audit queries back to original behavior

Browse Source 
Test Plan:
/ - didn't see all my commits
/owners/package/1/ - didn't see all package commits in Needs Attention

Reviewers: AnhNhan, epriestley

Reviewed By: epriestley

CC: aran, epriestley

Maniphest Tasks: T2582

Differential Revision: https://secure.phabricator.com/D5186
This commit is contained in:
vrana
2013-03-01 16:42:03 -08:00
parent c9838d81e2
commit a56810283a
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/applications/audit/query/PhabricatorAuditCommitQuery.php
View File

@@ -181,13 +181,13 @@ final class PhabricatorAuditCommitQuery {
case self::STATUS_CONCERN: case self::STATUS_CONCERN:
$where[] = qsprintf( $where[] = qsprintf(
$conn_r, $conn_r,
'c.auditStatus = %s', 'c.auditStatus = %d',
PhabricatorAuditCommitStatusConstants::CONCERN_RAISED); PhabricatorAuditCommitStatusConstants::CONCERN_RAISED);
break; break;
case self::STATUS_OPEN: case self::STATUS_OPEN:
$where[] = qsprintf( $where[] = qsprintf(
$conn_r, $conn_r,
'c.auditStatus IN (%Ls)', 'c.auditStatus IN (%Ld)',
PhabricatorAuditCommitStatusConstants::getOpenStatusConstants()); PhabricatorAuditCommitStatusConstants::getOpenStatusConstants());
break; break;
case self::STATUS_ANY: case self::STATUS_ANY:

2
src/applications/directory/controller/PhabricatorDirectoryMainController.php
View File

@@ -409,7 +409,7 @@ final class PhabricatorDirectoryMainController
$query = new PhabricatorAuditCommitQuery(); $query = new PhabricatorAuditCommitQuery();
$query->withAuthorPHIDs($phids); $query->withAuthorPHIDs($phids);
$query->withStatus(PhabricatorAuditQuery::STATUS_OPEN); $query->withStatus(PhabricatorAuditCommitQuery::STATUS_CONCERN);
$query->needCommitData(true); $query->needCommitData(true);
$query->setLimit(10); $query->setLimit(10);

2
src/applications/owners/controller/PhabricatorOwnersDetailController.php
View File

@@ -142,7 +142,7 @@ final class PhabricatorOwnersDetailController
$attention_query = id(new PhabricatorAuditCommitQuery()) $attention_query = id(new PhabricatorAuditCommitQuery())
->withPackagePHIDs(array($package->getPHID())) ->withPackagePHIDs(array($package->getPHID()))
->withStatus(PhabricatorAuditCommitQuery::STATUS_OPEN) ->withStatus(PhabricatorAuditCommitQuery::STATUS_CONCERN)
->needCommitData(true) ->needCommitData(true)
->needAudits(true) ->needAudits(true)
->setLimit(10); ->setLimit(10);