From a5c7286df70f92fa2657d745ee45fa999ac8992d Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Wed, 2 Jan 2013 14:03:36 -0800
Subject: [PATCH] Don't issue unnecssary query when loading user profile images

Summary: Fixes T2264.

Test Plan: Loaded profile.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2264

Differential Revision: https://secure.phabricator.com/D4324
---
 src/applications/people/storage/PhabricatorUser.php | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/applications/people/storage/PhabricatorUser.php b/src/applications/people/storage/PhabricatorUser.php
index 07bf892360..3710267a3d 100644
--- a/src/applications/people/storage/PhabricatorUser.php
+++ b/src/applications/people/storage/PhabricatorUser.php
@@ -630,9 +630,11 @@ EOBODY;
   public function loadProfileImageURI() {
     $src_phid = $this->getProfileImagePHID();
 
-    $file = id(new PhabricatorFile())->loadOneWhere('phid = %s', $src_phid);
-    if ($file) {
-      return $file->getBestURI();
+    if ($src_phid) {
+      $file = id(new PhabricatorFile())->loadOneWhere('phid = %s', $src_phid);
+      if ($file) {
+        return $file->getBestURI();
+      }
     }
 
     return self::getDefaultProfileImageURI();