Provide convenience method addTextCrumb() to PhabricatorCrumbsView

Summary: We currently have a lot of calls to `addCrumb(id(new PhabricatorCrumbView())->...)` which can be expressed much more simply with a convenience method. Nearly all crumbs are only textual.

Test Plan:
  - This was mostly automated, then I cleaned up a few unusual sites manually.
  - Bunch of grep / randomly clicking around.

Reviewers: btrahan, chad

Reviewed By: btrahan

CC: hach-que, aran

Differential Revision: https://secure.phabricator.com/D7787

src/applications/diffusion/controller/DiffusionLintController.php

@@ -139,9 +139,7 @@ final class DiffusionLintController extends DiffusionController {
     if ($this->diffusionRequest) {
       $title[] = $drequest->getCallsign();
     } else {
-      $crumbs->addCrumb(
-        id(new PhabricatorCrumbView())
-          ->setName(pht('All Lint')));
+      $crumbs->addTextCrumb(pht('All Lint'));
     }
 
     if ($this->diffusionRequest) {

src/applications/diffusion/controller/DiffusionRepositoryCreateController.php

@@ -181,9 +181,7 @@ final class DiffusionRepositoryCreateController
     }
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName($title));
+    $crumbs->addTextCrumb($title);
 
     return $this->buildApplicationPage(
       array(

src/applications/diffusion/controller/DiffusionRepositoryEditActionsController.php

@@ -59,9 +59,7 @@ final class DiffusionRepositoryEditActionsController
     $content = array();
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Edit Actions')));
+    $crumbs->addTextCrumb(pht('Edit Actions'));
 
     $title = pht('Edit Actions (%s)', $repository->getName());
 

src/applications/diffusion/controller/DiffusionRepositoryEditBasicController.php

@@ -67,9 +67,7 @@ final class DiffusionRepositoryEditBasicController
     }
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Edit Basics')));
+    $crumbs->addTextCrumb(pht('Edit Basics'));
 
     $title = pht('Edit %s', $repository->getName());
 

src/applications/diffusion/controller/DiffusionRepositoryEditBranchesController.php

@@ -88,9 +88,7 @@ final class DiffusionRepositoryEditBranchesController
     $content = array();
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Edit Branches')));
+    $crumbs->addTextCrumb(pht('Edit Branches'));
 
     $title = pht('Edit Branches (%s)', $repository->getName());
 

src/applications/diffusion/controller/DiffusionRepositoryEditController.php

@@ -11,20 +11,12 @@ abstract class DiffusionRepositoryEditController
       $repo_uri = $this->getRepositoryControllerURI($repository, '');
       $edit_uri = $this->getRepositoryControllerURI($repository, 'edit/');
 
-      $crumbs->addCrumb(
-        id(new PhabricatorCrumbView())
-          ->setName('r'.$repository->getCallsign())
-          ->setHref($repo_uri));
+      $crumbs->addTextCrumb('r'.$repository->getCallsign(), $repo_uri);
 
       if ($is_main) {
-        $crumbs->addCrumb(
-          id(new PhabricatorCrumbView())
-            ->setName(pht('Edit Repository')));
+        $crumbs->addTextCrumb(pht('Edit Repository'));
       } else {
-        $crumbs->addCrumb(
-          id(new PhabricatorCrumbView())
-            ->setName(pht('Edit'))
-            ->setHref($edit_uri));
+        $crumbs->addTextCrumb(pht('Edit'), $edit_uri);
       }
     }
 

src/applications/diffusion/controller/DiffusionRepositoryEditEncodingController.php

@@ -57,9 +57,7 @@ final class DiffusionRepositoryEditEncodingController
     }
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Edit Encoding')));
+    $crumbs->addTextCrumb(pht('Edit Encoding'));
 
     $title = pht('Edit %s', $repository->getName());
 

src/applications/diffusion/controller/DiffusionRepositoryEditHostingController.php

@@ -67,9 +67,7 @@ final class DiffusionRepositoryEditHostingController
     }
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Edit Hosting')));
+    $crumbs->addTextCrumb(pht('Edit Hosting'));
 
     $title = pht('Edit Hosting (%s)', $repository->getName());
 
@@ -172,9 +170,7 @@ final class DiffusionRepositoryEditHostingController
     }
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Edit Protocols')));
+    $crumbs->addTextCrumb(pht('Edit Protocols'));
 
     $title = pht('Edit Protocols (%s)', $repository->getName());
 

src/applications/diffusion/controller/DiffusionRepositoryEditLocalController.php

@@ -29,9 +29,7 @@ final class DiffusionRepositoryEditLocalController
     $errors = array();
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Edit Local')));
+    $crumbs->addTextCrumb(pht('Edit Local'));
 
     $title = pht('Edit %s', $repository->getName());
 

src/applications/diffusion/controller/DiffusionRepositoryEditPolicyController.php

@@ -67,9 +67,7 @@ final class DiffusionRepositoryEditPolicyController
     $content = array();
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Edit Policies')));
+    $crumbs->addTextCrumb(pht('Edit Policies'));
 
     $title = pht('Edit Policies (%s)', $repository->getName());
 

src/applications/diffusion/controller/DiffusionRepositoryEditSubversionController.php

@@ -70,9 +70,7 @@ final class DiffusionRepositoryEditSubversionController
     $content = array();
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Edit Subversion Info')));
+    $crumbs->addTextCrumb(pht('Edit Subversion Info'));
 
     $title = pht('Edit Subversion Info (%s)', $repository->getName());
 

src/applications/diffusion/controller/DiffusionRepositoryNewController.php

@@ -67,9 +67,7 @@ final class DiffusionRepositoryNewController
           ->addCancelButton($this->getApplicationURI()));
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName(pht('New Repository')));
+    $crumbs->addTextCrumb(pht('New Repository'));
 
     $form_box = id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Create or Import Repository'))