From abd880e30f6e18d1ff9e14c19be2665d7da31d74 Mon Sep 17 00:00:00 2001 From: vrana Date: Mon, 12 Nov 2012 16:35:26 -0800 Subject: [PATCH] Display correct size of binary files in Diffusion Test Plan: https://secure.phabricator.com/diffusion/P/browse/master/webroot/rsrc/image/header_logo.png Reviewers: btrahan, epriestley Reviewed By: btrahan CC: aran, Korvin Maniphest Tasks: T1139 Differential Revision: https://secure.phabricator.com/D3961 --- .../diffusion/controller/DiffusionBrowseFileController.php | 6 ++++-- .../PhabricatorBaseEnglishTranslation.php | 5 +++++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/applications/diffusion/controller/DiffusionBrowseFileController.php b/src/applications/diffusion/controller/DiffusionBrowseFileController.php index 274f268fbe..a62b62d7b0 100644 --- a/src/applications/diffusion/controller/DiffusionBrowseFileController.php +++ b/src/applications/diffusion/controller/DiffusionBrowseFileController.php @@ -885,9 +885,11 @@ final class DiffusionBrowseFileController extends DiffusionController { private function buildBinaryCorpus($file_uri, $data) { $properties = new PhabricatorPropertyListView(); + $size = strlen($data); $properties->addTextContent( - pht('This is a binary file. It is %d bytes in length.', - number_format(strlen($data))) + pht('This is a binary file. It is %2$s byte(s) in length.', + $size, + PhutilTranslator::getInstance()->formatNumber($size)) ); $actions = id(new PhabricatorActionListView()) diff --git a/src/infrastructure/internationalization/PhabricatorBaseEnglishTranslation.php b/src/infrastructure/internationalization/PhabricatorBaseEnglishTranslation.php index 21fe6fd640..f074aec819 100644 --- a/src/infrastructure/internationalization/PhabricatorBaseEnglishTranslation.php +++ b/src/infrastructure/internationalization/PhabricatorBaseEnglishTranslation.php @@ -167,6 +167,11 @@ abstract class PhabricatorBaseEnglishTranslation '%d Lint Messages', ), + 'This is a binary file. It is %2$s byte(s) in length.' => array( + 'This is a binary file. It is %2$s byte in length.', + 'This is a binary file. It is %2$s bytes in length.', + ), + ); }