Remove 'full-display' setting from Conpherence, spruce up search results

Summary: This removes 'full-display', 'minimal-display' from Conpherence, which I recall was because we had 2 UIs for column and regular chat. I'm also tossing in slightly nicer search results, with a link to the actual message and the full date shown for context.

Test Plan: Post a message in mobile, tablet, full conpherence, and in durable column. Clean up UI in durable column. Do a search in Full UI, click on result date, get taken to the message... usually. My test data is a little wonky, but I think this works most of the time.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D16710

src/applications/conpherence/controller/ConpherenceUpdateController.php

@@ -335,9 +335,6 @@ final class ConpherenceUpdateController
         $request->getInt('latest_transaction_id'))
       ->appendForm($form);
 
-    if ($request->getExists('minimal_display')) {
-      $view->addHiddenInput('minimal_display', true);
-    }
     return $view;
   }
 
@@ -477,9 +474,6 @@ final class ConpherenceUpdateController
       ->addHiddenInput('__continue__', true)
       ->appendChild($form);
 
-    if ($request->getExists('minimal_display')) {
-      $view->addHiddenInput('minimal_display', true);
-    }
     if ($request->getExists('force_ajax')) {
       $view->addHiddenInput('force_ajax', true);
     }
@@ -492,7 +486,6 @@ final class ConpherenceUpdateController
     $conpherence_id,
     $latest_transaction_id) {
 
-    $minimal_display = $this->getRequest()->getExists('minimal_display');
     $need_transactions = false;
     $need_participant_cache = true;
     switch ($action) {
@@ -525,8 +518,7 @@ final class ConpherenceUpdateController
     if ($need_transactions && $conpherence->getTransactions()) {
       $data = ConpherenceTransactionRenderer::renderTransactions(
         $user,
-        $conpherence,
-        !$minimal_display);
+        $conpherence);
       $key = PhabricatorConpherenceColumnMinimizeSetting::SETTINGKEY;
       $minimized = $user->getUserSetting($key);
       if (!$minimized) {
@@ -547,35 +539,33 @@ final class ConpherenceUpdateController
     $nav_item = null;
     $header = null;
     $people_widget = null;
-    if (!$minimal_display) {
-      switch ($action) {
-        case ConpherenceUpdateActions::METADATA:
-          $policy_objects = id(new PhabricatorPolicyQuery())
-            ->setViewer($user)
-            ->setObject($conpherence)
-            ->execute();
-          $header = $this->buildHeaderPaneContent(
-            $conpherence,
-            $policy_objects);
-          $header = hsprintf('%s', $header);
-          $nav_item = id(new ConpherenceThreadListView())
-            ->setUser($user)
-            ->setBaseURI($this->getApplicationURI())
-            ->renderSingleThread($conpherence, $policy_objects);
-          $nav_item = hsprintf('%s', $nav_item);
-          break;
-        case ConpherenceUpdateActions::ADD_PERSON:
-          $people_widget = id(new ConpherenceParticipantView())
-            ->setUser($user)
-            ->setConpherence($conpherence)
-            ->setUpdateURI($update_uri);
-          $people_widget = hsprintf('%s', $people_widget->render());
-          break;
-        case ConpherenceUpdateActions::REMOVE_PERSON:
-        case ConpherenceUpdateActions::NOTIFICATIONS:
-        default:
-          break;
-      }
+    switch ($action) {
+      case ConpherenceUpdateActions::METADATA:
+        $policy_objects = id(new PhabricatorPolicyQuery())
+          ->setViewer($user)
+          ->setObject($conpherence)
+          ->execute();
+        $header = $this->buildHeaderPaneContent(
+          $conpherence,
+          $policy_objects);
+        $header = hsprintf('%s', $header);
+        $nav_item = id(new ConpherenceThreadListView())
+          ->setUser($user)
+          ->setBaseURI($this->getApplicationURI())
+          ->renderSingleThread($conpherence, $policy_objects);
+        $nav_item = hsprintf('%s', $nav_item);
+        break;
+      case ConpherenceUpdateActions::ADD_PERSON:
+        $people_widget = id(new ConpherenceParticipantView())
+          ->setUser($user)
+          ->setConpherence($conpherence)
+          ->setUpdateURI($update_uri);
+        $people_widget = hsprintf('%s', $people_widget->render());
+        break;
+      case ConpherenceUpdateActions::REMOVE_PERSON:
+      case ConpherenceUpdateActions::NOTIFICATIONS:
+      default:
+        break;
     }
     $data = $conpherence->getDisplayData($user);
     $dropdown_query = id(new AphlictDropdownDataQuery())