From ad38252c68114f229a07ced60c3a8aa263e719b3 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 16 Jul 2013 13:54:14 -0700 Subject: [PATCH] Fix fatal on setting default profile picture Summary: I thought I fixed this but must have not saved in my editor or something. Fixes T3552. Test Plan: Set profile image to default. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3552 Differential Revision: https://secure.phabricator.com/D6477 --- .../PhabricatorPeopleProfilePictureController.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/applications/people/controller/PhabricatorPeopleProfilePictureController.php b/src/applications/people/controller/PhabricatorPeopleProfilePictureController.php index 732010f2ba..bd899961d2 100644 --- a/src/applications/people/controller/PhabricatorPeopleProfilePictureController.php +++ b/src/applications/people/controller/PhabricatorPeopleProfilePictureController.php @@ -78,7 +78,11 @@ final class PhabricatorPeopleProfilePictureController } if (!$errors) { - $user->setProfileImagePHID($xformed->getPHID()); + if ($is_default) { + $user->setProfileImagePHID(null); + } else { + $user->setProfileImagePHID($xformed->getPHID()); + } $user->save(); return id(new AphrontRedirectResponse())->setURI($profile_uri); }