archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Break profiles less after D4376

Browse Source 
Summary: This won't win any awards, but makes User and Project profile pages significantly less broken in the wake of D4376.

Test Plan:
{F28858}
{F28859}

Reviewers: btrahan, chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D4382
This commit is contained in:
epriestley
2013-01-09 13:57:31 -08:00
parent f1d7c8fbf8
commit ad4c4acafc
2 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/applications/people/controller/PhabricatorPeopleProfileController.php
View File

@@ -130,9 +130,10 @@ final class PhabricatorPeopleProfileController
} }
} }
$header->appendChild($nav); $nav->appendChild($header);
$nav->appendChild(
'<div style="padding: 1em;">'.$content.'</div>'); $content = '<div style="padding: 1em;">'.$content.'</div>';
$header->appendChild($content);
if ($user->getPHID() == $viewer->getPHID()) { if ($user->getPHID() == $viewer->getPHID()) {
$nav->addSpacer(); $nav->addSpacer();
@@ -148,7 +149,7 @@ final class PhabricatorPeopleProfileController
} }
return $this->buildApplicationPage( return $this->buildApplicationPage(
$header, $nav,
array( array(
'title' => $user->getUsername(), 'title' => $user->getUsername(),
)); ));

9
src/applications/project/controller/PhabricatorProjectProfileController.php
View File

@@ -68,8 +68,6 @@ final class PhabricatorProjectProfileController
throw new Exception("Unimplemented filter '{$this->page}'."); throw new Exception("Unimplemented filter '{$this->page}'.");
} }
$content = '<div style="padding: 1em;">'.$content.'</div>';
$nav_view->appendChild($content);
$header = new PhabricatorProfileHeaderView(); $header = new PhabricatorProfileHeaderView();
$header->setName($project->getName()); $header->setName($project->getName());
@@ -112,10 +110,13 @@ final class PhabricatorProjectProfileController
$header->addAction($action); $header->addAction($action);
$header->appendChild($nav_view); $nav_view->appendChild($header);
$content = '<div style="padding: 1em;">'.$content.'</div>';
$header->appendChild($content);
return $this->buildStandardPageResponse( return $this->buildStandardPageResponse(
$header, $nav_view,
array( array(
'title' => $project->getName().' Project', 'title' => $project->getName().' Project',
)); ));