From b1097e9c611a85f6912542428b8df6e7cdd39233 Mon Sep 17 00:00:00 2001 From: Sergey Sharybin Date: Wed, 27 Nov 2013 22:14:07 +0600 Subject: [PATCH] Fix for crash when pushable project have unknown users Apparently we've got Unknown Object (Phabricator User) in translation project now. Not sure how it became invalid, but automated scripts better be robust for this. --- scripts/gitadmin/rebuild_gitadmin.php | 3 +++ scripts/svnauth/rebuild_svnauth.php | 3 +++ 2 files changed, 6 insertions(+) diff --git a/scripts/gitadmin/rebuild_gitadmin.php b/scripts/gitadmin/rebuild_gitadmin.php index f76ad77d73..e158304abc 100755 --- a/scripts/gitadmin/rebuild_gitadmin.php +++ b/scripts/gitadmin/rebuild_gitadmin.php @@ -41,6 +41,9 @@ function handleSingleUserPHID( ->setViewer($viewer) ->withPHIDs(array($userPHID)) ->executeOne(); + if (!$user) { + return; + } $keys = id(new PhabricatorUserSSHKey())->loadAllWhere( 'userPHID = %s', diff --git a/scripts/svnauth/rebuild_svnauth.php b/scripts/svnauth/rebuild_svnauth.php index 9b2c644e58..8f861dc4b5 100755 --- a/scripts/svnauth/rebuild_svnauth.php +++ b/scripts/svnauth/rebuild_svnauth.php @@ -17,6 +17,9 @@ function handleSingleUserPHID( ->setViewer($viewer) ->withPHIDs(array($userPHID)) ->executeOne(); + if (!$user) { + return; + } $user_name = $user->getUserName(); if (!array_key_exists($user_name, $authfile)) {