Extend from Phobject

Summary: All classes should extend from some other class. See D13275 for some explanation.

Test Plan: `arc unit`

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D13283
This commit is contained in:
Joshua Spence
2015-06-15 18:02:26 +10:00
parent 2d5f3d9e5a
commit b6d745b666
197 changed files with 422 additions and 199 deletions

View File

@@ -1,6 +1,7 @@
<?php
final class PhabricatorObjectHandle
extends Phobject
implements PhabricatorPolicyInterface {
const AVAILABILITY_FULL = 'full';

View File

@@ -1,6 +1,6 @@
<?php
final class PhabricatorPHIDConstants {
final class PhabricatorPHIDConstants extends Phobject {
const PHID_TYPE_UNKNOWN = '????';
const PHID_TYPE_MAGIC = '!!!!';

View File

@@ -1,6 +1,6 @@
<?php
final class PhabricatorHandleObjectSelectorDataView {
final class PhabricatorHandleObjectSelectorDataView extends Phobject {
private $handle;

View File

@@ -1,6 +1,6 @@
<?php
final class PhabricatorObjectListQuery {
final class PhabricatorObjectListQuery extends Phobject {
private $viewer;
private $objectList;

View File

@@ -1,6 +1,6 @@
<?php
final class PhabricatorPHID {
final class PhabricatorPHID extends Phobject {
protected $phid;
protected $phidType;

View File

@@ -1,6 +1,6 @@
<?php
abstract class PhabricatorPHIDType {
abstract class PhabricatorPHIDType extends Phobject {
final public function getTypeConstant() {
$class = new ReflectionClass($this);