Extend from Phobject
Summary: All classes should extend from some other class. See D13275 for some explanation. Test Plan: `arc unit` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D13283
This commit is contained in:
@@ -1,6 +1,7 @@
|
||||
<?php
|
||||
|
||||
final class PhabricatorObjectHandle
|
||||
extends Phobject
|
||||
implements PhabricatorPolicyInterface {
|
||||
|
||||
const AVAILABILITY_FULL = 'full';
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
<?php
|
||||
|
||||
final class PhabricatorPHIDConstants {
|
||||
final class PhabricatorPHIDConstants extends Phobject {
|
||||
|
||||
const PHID_TYPE_UNKNOWN = '????';
|
||||
const PHID_TYPE_MAGIC = '!!!!';
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
<?php
|
||||
|
||||
final class PhabricatorHandleObjectSelectorDataView {
|
||||
final class PhabricatorHandleObjectSelectorDataView extends Phobject {
|
||||
|
||||
private $handle;
|
||||
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
<?php
|
||||
|
||||
final class PhabricatorObjectListQuery {
|
||||
final class PhabricatorObjectListQuery extends Phobject {
|
||||
|
||||
private $viewer;
|
||||
private $objectList;
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
<?php
|
||||
|
||||
final class PhabricatorPHID {
|
||||
final class PhabricatorPHID extends Phobject {
|
||||
|
||||
protected $phid;
|
||||
protected $phidType;
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
<?php
|
||||
|
||||
abstract class PhabricatorPHIDType {
|
||||
abstract class PhabricatorPHIDType extends Phobject {
|
||||
|
||||
final public function getTypeConstant() {
|
||||
$class = new ReflectionClass($this);
|
||||
|
||||
Reference in New Issue
Block a user