archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Stop reads and writes to projectPHIDs property on ManiphestTask

Browse Source 
Summary: Ref T5245. This property predates edges and is unusual in modern applications. Stop writes to it and populate it implicitly from edges when querying.

Test Plan:
  - Viewed task list.
  - Created a task.
  - Added and removed projects from tasks.

Reviewers: joshuaspence, chad, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5245

Differential Revision: https://secure.phabricator.com/D9851
This commit is contained in:
epriestley
2014-07-17 15:42:53 -07:00
parent aa79539789
commit b8b59895ee
5 changed files with 39 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/applications/maniphest/controller/ManiphestTaskEditController.php
View File

@@ -81,7 +81,7 @@ final class ManiphestTaskEditController extends ManiphestController {
$default_projects = mpull($default_projects, 'getPHID');
if ($default_projects) {
$task->setProjectPHIDs($default_projects);
$task->attachProjectPHIDs($default_projects);
}
}
}
@@ -215,7 +215,7 @@ final class ManiphestTaskEditController extends ManiphestController {
$task->setPriority($request->getInt('priority'));
$task->setOwnerPHID($owner_phid);
$task->setCCPHIDs($request->getArr('cc'));
$task->setProjectPHIDs($request->getArr('projects'));
$task->attachProjectPHIDs($request->getArr('projects'));
} else {
if ($can_edit_priority) {
@@ -438,7 +438,7 @@ final class ManiphestTaskEditController extends ManiphestController {
->executeOne();
if ($template_task) {
$task->setCCPHIDs($template_task->getCCPHIDs());
$task->setProjectPHIDs($template_task->getProjectPHIDs());
$task->attachProjectPHIDs($template_task->getProjectPHIDs());
$task->setOwnerPHID($template_task->getOwnerPHID());
$task->setPriority($template_task->getPriority());
$task->setViewPolicy($template_task->getViewPolicy());