From ba5b32f5bb37c0db2e623332437d65ab0f332b69 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Thu, 3 Mar 2016 22:08:00 +0000 Subject: [PATCH] Add headericons a little more consistently Summary: I kinda like these to differentiate the headers and different object types. Somethings duplicitive, but helps orient the clean header a bit. Test Plan: Review each in sandbox. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15394 --- .../controller/PhabricatorCountdownViewController.php | 3 ++- .../ponder/controller/PonderQuestionViewController.php | 1 + .../slowvote/controller/PhabricatorSlowvotePollController.php | 3 ++- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/applications/countdown/controller/PhabricatorCountdownViewController.php b/src/applications/countdown/controller/PhabricatorCountdownViewController.php index 423bfe5207..9a983f0ed9 100644 --- a/src/applications/countdown/controller/PhabricatorCountdownViewController.php +++ b/src/applications/countdown/controller/PhabricatorCountdownViewController.php @@ -46,7 +46,8 @@ final class PhabricatorCountdownViewController ->setHeader($title) ->setUser($viewer) ->setPolicyObject($countdown) - ->setStatus($icon, $color, $status); + ->setStatus($icon, $color, $status) + ->setHeaderIcon('fa-rocket'); $actions = $this->buildActionListView($countdown); $properties = $this->buildPropertyListView($countdown); diff --git a/src/applications/ponder/controller/PonderQuestionViewController.php b/src/applications/ponder/controller/PonderQuestionViewController.php index 3a1a210075..439119512b 100644 --- a/src/applications/ponder/controller/PonderQuestionViewController.php +++ b/src/applications/ponder/controller/PonderQuestionViewController.php @@ -31,6 +31,7 @@ final class PonderQuestionViewController extends PonderController { $header->setHeader($question->getTitle()); $header->setUser($viewer); $header->setPolicyObject($question); + $header->setHeaderIcon('fa-university'); if ($question->getStatus() == PonderQuestionStatus::STATUS_OPEN) { $header->setStatus('fa-square-o', 'bluegrey', pht('Open')); diff --git a/src/applications/slowvote/controller/PhabricatorSlowvotePollController.php b/src/applications/slowvote/controller/PhabricatorSlowvotePollController.php index 8603185c73..2eb2c08c75 100644 --- a/src/applications/slowvote/controller/PhabricatorSlowvotePollController.php +++ b/src/applications/slowvote/controller/PhabricatorSlowvotePollController.php @@ -43,7 +43,8 @@ final class PhabricatorSlowvotePollController ->setHeader($poll->getQuestion()) ->setUser($viewer) ->setStatus($header_icon, $header_color, $header_name) - ->setPolicyObject($poll); + ->setPolicyObject($poll) + ->setHeaderIcon('fa-bar-chart'); $actions = $this->buildActionView($poll); $properties = $this->buildPropertyView($poll);