From baf4d451aabbc347398db7d0f60def66ff9308f3 Mon Sep 17 00:00:00 2001
From: Toby Hughes <hughes.toby@gmail.com>
Date: Thu, 19 Jun 2014 14:19:55 -0700
Subject: [PATCH] Fix invalid submit_uri when creating dashboard panels

Summary: When creating dashboard panels, the `submit_uri` is invalid since the panel has not been saved to the database yet (and therefore doesn't have an ID). This resulted in a 404 when trying to submit the form to `/dashboard/panel/edit//`

Test Plan: Created a dashboard panel and the panel was created successfully

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9629
---
 .../controller/PhabricatorDashboardPanelEditController.php  | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/applications/dashboard/controller/PhabricatorDashboardPanelEditController.php b/src/applications/dashboard/controller/PhabricatorDashboardPanelEditController.php
index bdd576fb1d..088a86919e 100644
--- a/src/applications/dashboard/controller/PhabricatorDashboardPanelEditController.php
+++ b/src/applications/dashboard/controller/PhabricatorDashboardPanelEditController.php
@@ -196,7 +196,11 @@ final class PhabricatorDashboardPanelEditController
 
     // NOTE: We're setting the submit URI explicitly because we need to edit
     // a different panel if we just cloned the original panel.
-    $submit_uri = $this->getApplicationURI('panel/edit/'.$panel->getID().'/');
+    if ($is_create) {
+      $submit_uri = $this->getApplicationURI('panel/edit/');
+    } else {
+      $submit_uri = $this->getApplicationURI('panel/edit/'.$panel->getID().'/');
+    }
 
     $policies = id(new PhabricatorPolicyQuery())
       ->setViewer($viewer)