From bc6522dbca07610f5948c46d067fad1bb47d99f2 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Fri, 16 Dec 2016 06:56:18 -0800
Subject: [PATCH] Remove "DifferentialConflictsField" custom field

Summary: Ref T11114. This is a pure paring field and now entirely handled by `DifferentialConflictsCommitMessageField`.

Test Plan: Grepped for removed class name.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114

Differential Revision: https://secure.phabricator.com/D17073
---
 src/__phutil_library_map__.php                |  2 -
 .../DifferentialConflictsField.php            | 45 -------------------
 2 files changed, 47 deletions(-)
 delete mode 100644 src/applications/differential/customfield/DifferentialConflictsField.php

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index 0defc96858..16a49b364b 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -389,7 +389,6 @@ phutil_register_library_map(array(
     'DifferentialCommitsField' => 'applications/differential/customfield/DifferentialCommitsField.php',
     'DifferentialConduitAPIMethod' => 'applications/differential/conduit/DifferentialConduitAPIMethod.php',
     'DifferentialConflictsCommitMessageField' => 'applications/differential/field/DifferentialConflictsCommitMessageField.php',
-    'DifferentialConflictsField' => 'applications/differential/customfield/DifferentialConflictsField.php',
     'DifferentialController' => 'applications/differential/controller/DifferentialController.php',
     'DifferentialCoreCustomField' => 'applications/differential/customfield/DifferentialCoreCustomField.php',
     'DifferentialCreateCommentConduitAPIMethod' => 'applications/differential/conduit/DifferentialCreateCommentConduitAPIMethod.php',
@@ -5034,7 +5033,6 @@ phutil_register_library_map(array(
     'DifferentialCommitsField' => 'DifferentialCustomField',
     'DifferentialConduitAPIMethod' => 'ConduitAPIMethod',
     'DifferentialConflictsCommitMessageField' => 'DifferentialCommitMessageField',
-    'DifferentialConflictsField' => 'DifferentialCustomField',
     'DifferentialController' => 'PhabricatorController',
     'DifferentialCoreCustomField' => 'DifferentialCustomField',
     'DifferentialCreateCommentConduitAPIMethod' => 'DifferentialConduitAPIMethod',
diff --git a/src/applications/differential/customfield/DifferentialConflictsField.php b/src/applications/differential/customfield/DifferentialConflictsField.php
deleted file mode 100644
index 590d9fd3a7..0000000000
--- a/src/applications/differential/customfield/DifferentialConflictsField.php
+++ /dev/null
@@ -1,45 +0,0 @@
-<?php
-
-/**
- * This field doesn't do anything, it just parses the "Conflicts:" field which
- * `git` can insert after a merge, so we don't squish the field value into
- * some other field.
- */
-final class DifferentialConflictsField
-  extends DifferentialCustomField {
-
-  public function getFieldKey() {
-    return 'differential:conflicts';
-  }
-
-  public function getFieldKeyForConduit() {
-    return 'conflicts';
-  }
-
-  public function getFieldName() {
-    return pht('Conflicts');
-  }
-
-  public function getFieldDescription() {
-    return pht(
-      'Parses the "%s" field which Git can inject into commit messages.',
-      'Conflicts');
-  }
-
-  public function canDisableField() {
-    return false;
-  }
-
-  public function shouldAppearInCommitMessage() {
-    return true;
-  }
-
-  public function shouldAllowEditInCommitMessage() {
-    return false;
-  }
-
-  public function renderCommitMessageValue(array $handles) {
-    return null;
-  }
-
-}