From db1cd6586609b53029c45d1aecd7598e942266f1 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 14 May 2015 10:39:28 -0700
Subject: [PATCH 01/86] Allow setup checks to perform writes

Summary:
Fixes T8198. Currently, if the `policy.locked` configuration setting includes a value which is a user PHID, we may perform a cache fill during setup as a side effect of validating it.

Right now, there is no WriteGuard active during setup, because we don't have a Request object yet so we can't actually perform CSRF validation.

Two possible approaches are:

  # Prevent the write from occuring.
  # Change the code to allow the write.

In the past, I think we've hit similar cases and done (1). However, IIRC those writes were sketchier, more isolated, and easy to remove (I think there was one with PKCS8 keys). This one is pretty legit and not very easy to remove without making a bit of a mess.

There's no techncial reason we can't do (2), we just have to create a no-op WriteGuard for the setup phase.

Test Plan:
  - To reproduce this issue: set some value in `policy.locked` to a user PHID, then wipe out profile caches in the database, then restart the webserver.
  - Reproduced the issue.
  - Added the new dummy write guard, fixed a minor issue with disposal semantics (see D12841).
  - Verified this fixed the issue.
  - Added a `throw` to the real CSRF validator and performed a real write. Verified I got CSRF-blocked.
  - Removed a CSRF token from a form and double-checked that CSRF protection still works.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8198

Differential Revision: https://secure.phabricator.com/D12842
---
 .../AphrontApplicationConfiguration.php              | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/src/aphront/configuration/AphrontApplicationConfiguration.php b/src/aphront/configuration/AphrontApplicationConfiguration.php
index 3e7abe6a9d..d828b9a8ce 100644
--- a/src/aphront/configuration/AphrontApplicationConfiguration.php
+++ b/src/aphront/configuration/AphrontApplicationConfiguration.php
@@ -62,6 +62,11 @@ abstract class AphrontApplicationConfiguration {
     $multimeter->setEventContext('<http-init>');
     $multimeter->setEventViewer('<none>');
 
+    // Build a no-op write guard for the setup phase. We'll replace this with a
+    // real write guard later on, but we need to survive setup and build a
+    // request object first.
+    $write_guard = new AphrontWriteGuard('id');
+
     PhabricatorEnv::initializeWebEnvironment();
 
     $multimeter->setSampleRate(
@@ -108,6 +113,11 @@ abstract class AphrontApplicationConfiguration {
     $application->willBuildRequest();
     $request = $application->buildRequest();
 
+    // Now that we have a request, convert the write guard into one which
+    // actually checks CSRF tokens.
+    $write_guard->dispose();
+    $write_guard = new AphrontWriteGuard(array($request, 'validateCSRF'));
+
     // Build the server URI implied by the request headers. If an administrator
     // has not configured "phabricator.base-uri" yet, we'll use this to generate
     // links.
@@ -121,8 +131,6 @@ abstract class AphrontApplicationConfiguration {
         'U' => (string)$request->getRequestURI()->getPath(),
       ));
 
-    $write_guard = new AphrontWriteGuard(array($request, 'validateCSRF'));
-
     $processing_exception = null;
     try {
       $response = $application->processRequest(

From bc101e7c734b95d8eeb67ea7593b926bdb8ac06a Mon Sep 17 00:00:00 2001
From: Bob Trahan <btrahan@phacility.com>
Date: Thu, 14 May 2015 11:14:07 -0700
Subject: [PATCH 02/86] Conpherence - fix disappearing older messages bug

Summary:
Fixes T8194. If you loaded a conpherence directly via a URI like /Z1 or /conpherence/1/ we didn't correctly cache the loaded transactions such that sending a message would only show that message and subsequent messages.

Fix is to build the cache properly in this case. Note this codepath is different because the server sends back more of the thread data in the initial request.

Test Plan: loaded a conpherence directly, sent messages, paged back, everything kept showing!

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8194

Differential Revision: https://secure.phabricator.com/D12844
---
 resources/celerity/map.php                    | 60 +++++++++----------
 .../conpherence/ConpherenceThreadManager.js   | 18 +++---
 .../application/conpherence/behavior-menu.js  |  1 +
 3 files changed, 42 insertions(+), 37 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index c4bb78b856..6b31b64958 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -8,7 +8,7 @@
 return array(
   'names' => array(
     'core.pkg.css' => '7ac320f1',
-    'core.pkg.js' => 'ac41c400',
+    'core.pkg.js' => 'a2f2598e',
     'darkconsole.pkg.js' => 'e7393ebb',
     'differential.pkg.css' => 'bb338e4b',
     'differential.pkg.js' => '895b8d62',
@@ -332,10 +332,10 @@ return array(
     'rsrc/js/application/auth/behavior-persona-login.js' => '9414ff18',
     'rsrc/js/application/calendar/event-all-day.js' => 'ca5fa62a',
     'rsrc/js/application/config/behavior-reorder-fields.js' => '14a827de',
-    'rsrc/js/application/conpherence/ConpherenceThreadManager.js' => 'b7342ddb',
+    'rsrc/js/application/conpherence/ConpherenceThreadManager.js' => '10246726',
     'rsrc/js/application/conpherence/behavior-drag-and-drop-photo.js' => 'cf86d16a',
     'rsrc/js/application/conpherence/behavior-durable-column.js' => '16c695bf',
-    'rsrc/js/application/conpherence/behavior-menu.js' => '4351c4a0',
+    'rsrc/js/application/conpherence/behavior-menu.js' => 'c0348cac',
     'rsrc/js/application/conpherence/behavior-pontificate.js' => '21ba5861',
     'rsrc/js/application/conpherence/behavior-quicksand-blacklist.js' => '7927a7d3',
     'rsrc/js/application/conpherence/behavior-widget-pane.js' => '93568464',
@@ -500,7 +500,7 @@ return array(
     'conpherence-menu-css' => 'f389e048',
     'conpherence-message-pane-css' => '5bb4b76d',
     'conpherence-notification-css' => '919974b6',
-    'conpherence-thread-manager' => 'b7342ddb',
+    'conpherence-thread-manager' => '10246726',
     'conpherence-transaction-css' => '42a457f6',
     'conpherence-update-css' => '1099a660',
     'conpherence-widget-pane-css' => '2af42ebe',
@@ -541,7 +541,7 @@ return array(
     'javelin-behavior-choose-control' => '6153c708',
     'javelin-behavior-config-reorder-fields' => '14a827de',
     'javelin-behavior-conpherence-drag-and-drop-photo' => 'cf86d16a',
-    'javelin-behavior-conpherence-menu' => '4351c4a0',
+    'javelin-behavior-conpherence-menu' => 'c0348cac',
     'javelin-behavior-conpherence-pontificate' => '21ba5861',
     'javelin-behavior-conpherence-widget-pane' => '93568464',
     'javelin-behavior-countdown-timer' => 'e4cc26b3',
@@ -876,6 +876,17 @@ return array(
       'javelin-install',
       'javelin-util',
     ),
+    10246726 => array(
+      'javelin-dom',
+      'javelin-util',
+      'javelin-stratcom',
+      'javelin-install',
+      'javelin-aphlict',
+      'javelin-workflow',
+      'javelin-router',
+      'javelin-behavior-device',
+      'javelin-vector',
+    ),
     '13c739ea' => array(
       'javelin-behavior',
       'javelin-stratcom',
@@ -1067,20 +1078,6 @@ return array(
       'javelin-dom',
       'javelin-request',
     ),
-    '4351c4a0' => array(
-      'javelin-behavior',
-      'javelin-dom',
-      'javelin-util',
-      'javelin-stratcom',
-      'javelin-workflow',
-      'javelin-behavior-device',
-      'javelin-history',
-      'javelin-vector',
-      'javelin-scrollbar',
-      'phabricator-title',
-      'phabricator-shaped-request',
-      'conpherence-thread-manager',
-    ),
     '44168bad' => array(
       'javelin-behavior',
       'javelin-dom',
@@ -1703,17 +1700,6 @@ return array(
       'javelin-dom',
       'javelin-util',
     ),
-    'b7342ddb' => array(
-      'javelin-dom',
-      'javelin-util',
-      'javelin-stratcom',
-      'javelin-install',
-      'javelin-aphlict',
-      'javelin-workflow',
-      'javelin-router',
-      'javelin-behavior-device',
-      'javelin-vector',
-    ),
     'ba4fa35c' => array(
       'javelin-behavior',
       'javelin-dom',
@@ -1747,6 +1733,20 @@ return array(
       'javelin-util',
       'phabricator-shaped-request',
     ),
+    'c0348cac' => array(
+      'javelin-behavior',
+      'javelin-dom',
+      'javelin-util',
+      'javelin-stratcom',
+      'javelin-workflow',
+      'javelin-behavior-device',
+      'javelin-history',
+      'javelin-vector',
+      'javelin-scrollbar',
+      'phabricator-title',
+      'phabricator-shaped-request',
+      'conpherence-thread-manager',
+    ),
     'c1700f6f' => array(
       'javelin-install',
       'javelin-util',
diff --git a/webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js b/webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js
index c1c47c5c78..71c1af139b 100644
--- a/webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js
+++ b/webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js
@@ -330,6 +330,16 @@ JX.install('ConpherenceThreadManager', {
       JX.DOM.setContent(this._messagesRootCallback(), transactions);
     },
 
+    cacheCurrentTransactions: function() {
+      var root = this._messagesRootCallback();
+      var transactions = JX.DOM.scry(
+        root ,
+        'div',
+        'conpherence-transaction-view');
+      this._updateTransactionIDMap(transactions);
+      this._updateTransactionCache(transactions);
+    },
+
     _updateThread: function() {
       var params = this._getParams({
         action: 'load',
@@ -422,13 +432,7 @@ JX.install('ConpherenceThreadManager', {
           r.aphlictDropdownData);
 
         this._didLoadThreadCallback(r);
-        var messages_root = this._messagesRootCallback();
-        var messages = JX.DOM.scry(
-          messages_root,
-          'div',
-          'conpherence-transaction-view');
-        this._updateTransactionIDMap(messages);
-        this._updateTransactionCache(messages);
+        this.cacheCurrentTransactions();
 
         if (force_reload) {
           JX.Stratcom.invoke('hashchange');
diff --git a/webroot/rsrc/js/application/conpherence/behavior-menu.js b/webroot/rsrc/js/application/conpherence/behavior-menu.js
index 2233b3ff28..5dcbffaed8 100644
--- a/webroot/rsrc/js/application/conpherence/behavior-menu.js
+++ b/webroot/rsrc/js/application/conpherence/behavior-menu.js
@@ -191,6 +191,7 @@ JX.behavior('conpherence-menu', function(config) {
       threadManager.setLoadedThreadPHID(config.selectedThreadPHID);
       threadManager.setLatestTransactionID(config.latestTransactionID);
       threadManager.setCanEditLoadedThread(config.canEditSelectedThread);
+      threadManager.cacheCurrentTransactions();
       _scrollMessageWindow();
       _focusTextarea();
     } else {

From 04186e02cfd8949468e49e8f5eba4514efbdc43f Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 14 May 2015 11:14:44 -0700
Subject: [PATCH 03/86] Separate handle "status" and "availability"

Summary:
Ref T7707. Handles currently have a "status" field and a "disabled" field.

The "status" field has these possible values: "open", "closed", "1", "2". durp durp durp

Instead, do:

  - status = <open, closed>
  - availability = <full, partial, none, disabled>

I think these make more sense? And are a bit more general? And use the same kind of constants for all values!

Test Plan: Looked at all affected handles in all states (probably).

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7707

Differential Revision: https://secure.phabricator.com/D12832
---
 resources/celerity/map.php                    |  6 +-
 src/__phutil_library_map__.php                |  2 -
 .../phid/PhabricatorCalendarEventPHIDType.php |  2 +-
 .../PhabricatorDashboardPanelPHIDType.php     |  2 +-
 .../phid/DifferentialRevisionPHIDType.php     |  2 +-
 .../query/PhabricatorFlagSearchEngine.php     |  2 +-
 .../fund/phid/FundInitiativePHIDType.php      |  2 +-
 .../maniphest/phid/ManiphestTaskPHIDType.php  |  2 +-
 .../phid/PassphraseCredentialPHIDType.php     |  2 +-
 .../phid/PhabricatorPeopleUserPHIDType.php    | 27 +++++++--
 .../phid/PhabricatorObjectHandle.php          | 60 ++++++++-----------
 .../const/PhabricatorObjectHandleStatus.php   |  9 ---
 .../pholio/phid/PholioMockPHIDType.php        |  2 +-
 .../phid/PhrictionDocumentPHIDType.php        |  2 +-
 .../phid/PhabricatorProjectColumnPHIDType.php |  5 +-
 .../PhabricatorProjectProjectPHIDType.php     |  2 +-
 .../view/PhabricatorSearchResultView.php      |  2 +-
 .../view/PhabricatorTypeaheadTokenView.php    |  2 +-
 .../rule/PhabricatorObjectRemarkupRule.php    |  6 +-
 .../application/base/standard-page-view.css   | 12 ++--
 20 files changed, 76 insertions(+), 75 deletions(-)
 delete mode 100644 src/applications/phid/handle/const/PhabricatorObjectHandleStatus.php

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 6b31b64958..0372651ba5 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => '7ac320f1',
+    'core.pkg.css' => '9990f46d',
     'core.pkg.js' => 'a2f2598e',
     'darkconsole.pkg.js' => 'e7393ebb',
     'differential.pkg.css' => 'bb338e4b',
@@ -37,7 +37,7 @@ return array(
     'rsrc/css/application/base/main-menu-view.css' => '663e3810',
     'rsrc/css/application/base/notification-menu.css' => '3c9d8aa1',
     'rsrc/css/application/base/phabricator-application-launch-view.css' => '16ca323f',
-    'rsrc/css/application/base/standard-page-view.css' => '2acd4611',
+    'rsrc/css/application/base/standard-page-view.css' => '61e68a55',
     'rsrc/css/application/chatlog/chatlog.css' => '852140ff',
     'rsrc/css/application/conduit/conduit-api.css' => '7bc725c4',
     'rsrc/css/application/config/config-options.css' => '7fedf08b',
@@ -731,7 +731,7 @@ return array(
     'phabricator-side-menu-view-css' => 'c1db9e9c',
     'phabricator-slowvote-css' => '266df6a1',
     'phabricator-source-code-view-css' => '2ceee894',
-    'phabricator-standard-page-view' => '2acd4611',
+    'phabricator-standard-page-view' => '61e68a55',
     'phabricator-textareautils' => '5c93c52c',
     'phabricator-title' => 'df5e11d2',
     'phabricator-tooltip' => '1d298e3a',
diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index 0fa277df27..638674126b 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -2143,7 +2143,6 @@ phutil_register_library_map(array(
     'PhabricatorOAuthServerTokenController' => 'applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php',
     'PhabricatorObjectHandle' => 'applications/phid/PhabricatorObjectHandle.php',
     'PhabricatorObjectHandleConstants' => 'applications/phid/handle/const/PhabricatorObjectHandleConstants.php',
-    'PhabricatorObjectHandleStatus' => 'applications/phid/handle/const/PhabricatorObjectHandleStatus.php',
     'PhabricatorObjectHasAsanaSubtaskEdgeType' => 'applications/doorkeeper/edge/PhabricatorObjectHasAsanaSubtaskEdgeType.php',
     'PhabricatorObjectHasAsanaTaskEdgeType' => 'applications/doorkeeper/edge/PhabricatorObjectHasAsanaTaskEdgeType.php',
     'PhabricatorObjectHasContributorEdgeType' => 'applications/transactions/edges/PhabricatorObjectHasContributorEdgeType.php',
@@ -5549,7 +5548,6 @@ phutil_register_library_map(array(
     'PhabricatorOAuthServerTestController' => 'PhabricatorOAuthServerController',
     'PhabricatorOAuthServerTokenController' => 'PhabricatorAuthController',
     'PhabricatorObjectHandle' => 'PhabricatorPolicyInterface',
-    'PhabricatorObjectHandleStatus' => 'PhabricatorObjectHandleConstants',
     'PhabricatorObjectHasAsanaSubtaskEdgeType' => 'PhabricatorEdgeType',
     'PhabricatorObjectHasAsanaTaskEdgeType' => 'PhabricatorEdgeType',
     'PhabricatorObjectHasContributorEdgeType' => 'PhabricatorEdgeType',
diff --git a/src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php b/src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php
index 0486474dcd..7acc968f21 100644
--- a/src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php
+++ b/src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php
@@ -42,7 +42,7 @@ final class PhabricatorCalendarEventPHIDType extends PhabricatorPHIDType {
         ->setURI('/E'.$id);
 
       if ($is_cancelled) {
-        $handle->setStatus(PhabricatorObjectHandleStatus::STATUS_CLOSED);
+        $handle->setStatus(PhabricatorObjectHandle::STATUS_CLOSED);
       }
     }
   }
diff --git a/src/applications/dashboard/phid/PhabricatorDashboardPanelPHIDType.php b/src/applications/dashboard/phid/PhabricatorDashboardPanelPHIDType.php
index 725945f407..c4aec82b8e 100644
--- a/src/applications/dashboard/phid/PhabricatorDashboardPanelPHIDType.php
+++ b/src/applications/dashboard/phid/PhabricatorDashboardPanelPHIDType.php
@@ -36,7 +36,7 @@ final class PhabricatorDashboardPanelPHIDType extends PhabricatorPHIDType {
       $handle->setURI("/{$monogram}");
 
       if ($panel->getIsArchived()) {
-        $handle->setStatus(PhabricatorObjectHandleStatus::STATUS_CLOSED);
+        $handle->setStatus(PhabricatorObjectHandle::STATUS_CLOSED);
       }
     }
   }
diff --git a/src/applications/differential/phid/DifferentialRevisionPHIDType.php b/src/applications/differential/phid/DifferentialRevisionPHIDType.php
index d65d2d601c..a46dc71c65 100644
--- a/src/applications/differential/phid/DifferentialRevisionPHIDType.php
+++ b/src/applications/differential/phid/DifferentialRevisionPHIDType.php
@@ -41,7 +41,7 @@ final class DifferentialRevisionPHIDType extends PhabricatorPHIDType {
       $handle->setFullName("D{$id}: {$title}");
 
       if ($revision->isClosed()) {
-        $handle->setStatus(PhabricatorObjectHandleStatus::STATUS_CLOSED);
+        $handle->setStatus(PhabricatorObjectHandle::STATUS_CLOSED);
       }
     }
   }
diff --git a/src/applications/flag/query/PhabricatorFlagSearchEngine.php b/src/applications/flag/query/PhabricatorFlagSearchEngine.php
index eec7027fa1..0e56fbf0e0 100644
--- a/src/applications/flag/query/PhabricatorFlagSearchEngine.php
+++ b/src/applications/flag/query/PhabricatorFlagSearchEngine.php
@@ -152,7 +152,7 @@ final class PhabricatorFlagSearchEngine
         ->setHeader($flag->getHandle()->getFullName())
         ->setHref($flag->getHandle()->getURI());
 
-      $status_open = PhabricatorObjectHandleStatus::STATUS_OPEN;
+      $status_open = PhabricatorObjectHandle::STATUS_OPEN;
       if ($flag->getHandle()->getStatus() != $status_open) {
         $item->setDisabled(true);
       }
diff --git a/src/applications/fund/phid/FundInitiativePHIDType.php b/src/applications/fund/phid/FundInitiativePHIDType.php
index cd2d0c83da..3399dc0a3f 100644
--- a/src/applications/fund/phid/FundInitiativePHIDType.php
+++ b/src/applications/fund/phid/FundInitiativePHIDType.php
@@ -37,7 +37,7 @@ final class FundInitiativePHIDType extends PhabricatorPHIDType {
       $name = $initiative->getName();
 
       if ($initiative->isClosed()) {
-        $handle->setStatus(PhabricatorObjectHandleStatus::STATUS_CLOSED);
+        $handle->setStatus(PhabricatorObjectHandle::STATUS_CLOSED);
       }
 
       $handle->setName($name);
diff --git a/src/applications/maniphest/phid/ManiphestTaskPHIDType.php b/src/applications/maniphest/phid/ManiphestTaskPHIDType.php
index 8c1b3c0d8e..719b4a8446 100644
--- a/src/applications/maniphest/phid/ManiphestTaskPHIDType.php
+++ b/src/applications/maniphest/phid/ManiphestTaskPHIDType.php
@@ -39,7 +39,7 @@ final class ManiphestTaskPHIDType extends PhabricatorPHIDType {
       $handle->setURI("/T{$id}");
 
       if ($task->isClosed()) {
-        $handle->setStatus(PhabricatorObjectHandleStatus::STATUS_CLOSED);
+        $handle->setStatus(PhabricatorObjectHandle::STATUS_CLOSED);
       }
     }
   }
diff --git a/src/applications/passphrase/phid/PassphraseCredentialPHIDType.php b/src/applications/passphrase/phid/PassphraseCredentialPHIDType.php
index 63105fd010..25681906e3 100644
--- a/src/applications/passphrase/phid/PassphraseCredentialPHIDType.php
+++ b/src/applications/passphrase/phid/PassphraseCredentialPHIDType.php
@@ -39,7 +39,7 @@ final class PassphraseCredentialPHIDType extends PhabricatorPHIDType {
       $handle->setURI("/K{$id}");
 
       if ($credential->getIsDestroyed()) {
-        $handle->setStatus(PhabricatorObjectHandleStatus::STATUS_CLOSED);
+        $handle->setStatus(PhabricatorObjectHandle::STATUS_CLOSED);
       }
     }
   }
diff --git a/src/applications/people/phid/PhabricatorPeopleUserPHIDType.php b/src/applications/people/phid/PhabricatorPeopleUserPHIDType.php
index 7f089b4be5..16453987c9 100644
--- a/src/applications/people/phid/PhabricatorPeopleUserPHIDType.php
+++ b/src/applications/people/phid/PhabricatorPeopleUserPHIDType.php
@@ -43,11 +43,28 @@ final class PhabricatorPeopleUserPHIDType extends PhabricatorPHIDType {
       $handle->setURI('/p/'.$user->getUsername().'/');
       $handle->setFullName($user->getFullName());
       $handle->setImageURI($user->getProfileImageURI());
-      $handle->setDisabled(!$user->isUserActivated());
-      if ($user->hasStatus()) {
-        $status = $user->getStatus();
-        $handle->setStatus($status->getTextStatus());
-        $handle->setTitle($status->getTerseSummary($query->getViewer()));
+
+      $availability = null;
+      if (!$user->isUserActivated()) {
+        $availability = PhabricatorObjectHandle::AVAILABILITY_DISABLED;
+      } else {
+        if ($user->hasStatus()) {
+          // NOTE: This first call returns an event; then we get the event
+          // status.
+          $status = $user->getStatus()->getStatus();
+          switch ($status) {
+            case PhabricatorCalendarEvent::STATUS_AWAY:
+              $availability = PhabricatorObjectHandle::AVAILABILITY_NONE;
+              break;
+            case PhabricatorCalendarEvent::STATUS_SPORADIC:
+              $availability = PhabricatorObjectHandle::AVAILABILITY_PARTIAL;
+              break;
+          }
+        }
+      }
+
+      if ($availability) {
+        $handle->setAvailability($availability);
       }
     }
   }
diff --git a/src/applications/phid/PhabricatorObjectHandle.php b/src/applications/phid/PhabricatorObjectHandle.php
index f36c21516a..2f7cda8377 100644
--- a/src/applications/phid/PhabricatorObjectHandle.php
+++ b/src/applications/phid/PhabricatorObjectHandle.php
@@ -3,6 +3,14 @@
 final class PhabricatorObjectHandle
   implements PhabricatorPolicyInterface {
 
+  const AVAILABILITY_FULL = 'full';
+  const AVAILABILITY_NONE = 'none';
+  const AVAILABILITY_PARTIAL = 'partial';
+  const AVAILABILITY_DISABLED = 'disabled';
+
+  const STATUS_OPEN = 'open';
+  const STATUS_CLOSED = 'closed';
+
   private $uri;
   private $phid;
   private $type;
@@ -13,9 +21,9 @@ final class PhabricatorObjectHandle
   private $icon;
   private $tagColor;
   private $timestamp;
-  private $status = PhabricatorObjectHandleStatus::STATUS_OPEN;
+  private $status = self::STATUS_OPEN;
+  private $availability = self::AVAILABILITY_FULL;
   private $complete;
-  private $disabled;
   private $objectName;
   private $policyFiltered;
 
@@ -129,6 +137,19 @@ final class PhabricatorObjectHandle
     return $this->name;
   }
 
+  public function setAvailability($availability) {
+    $this->availability = $availability;
+    return $this;
+  }
+
+  public function getAvailability() {
+    return $this->availability;
+  }
+
+  public function isDisabled() {
+    return ($this->getAvailability() == self::AVAILABILITY_DISABLED);
+  }
+
   public function setStatus($status) {
     $this->status = $status;
     return $this;
@@ -225,33 +246,6 @@ final class PhabricatorObjectHandle
   }
 
 
-  /**
-   * Set whether or not the underlying object is disabled. See
-   * @{method:isDisabled} for an explanation of what it means to be disabled.
-   *
-   * @param bool True if the handle represents a disabled object.
-   * @return this
-   */
-  public function setDisabled($disabled) {
-    $this->disabled = $disabled;
-    return $this;
-  }
-
-
-  /**
-   * Determine if the handle represents an object which has been disabled --
-   * for example, disabled users, archived projects, etc. These objects are
-   * complete and exist, but should be excluded from some system interactions
-   * (for instance, they usually should not appear in typeaheads, and should
-   * not have mail/notifications delivered to or about them).
-   *
-   * @return bool True if the handle represents a disabled object.
-   */
-  public function isDisabled() {
-    return $this->disabled;
-  }
-
-
   public function renderLink($name = null) {
     if ($name === null) {
       $name = $this->getLinkName();
@@ -260,14 +254,12 @@ final class PhabricatorObjectHandle
     $classes[] = 'phui-handle';
     $title = $this->title;
 
-    if ($this->status != PhabricatorObjectHandleStatus::STATUS_OPEN) {
+    if ($this->status != self::STATUS_OPEN) {
       $classes[] = 'handle-status-'.$this->status;
-      $title = $title ? $title : $this->status;
     }
 
-    if ($this->disabled) {
-      $classes[] = 'handle-disabled';
-      $title = pht('Disabled'); // Overwrite status.
+    if ($this->availability != self::AVAILABILITY_FULL) {
+      $classes[] = 'handle-availability-'.$this->availability;
     }
 
     if ($this->getType() == PhabricatorPeopleUserPHIDType::TYPECONST) {
diff --git a/src/applications/phid/handle/const/PhabricatorObjectHandleStatus.php b/src/applications/phid/handle/const/PhabricatorObjectHandleStatus.php
deleted file mode 100644
index 37407428b4..0000000000
--- a/src/applications/phid/handle/const/PhabricatorObjectHandleStatus.php
+++ /dev/null
@@ -1,9 +0,0 @@
-<?php
-
-final class PhabricatorObjectHandleStatus
-  extends PhabricatorObjectHandleConstants {
-
-  const STATUS_OPEN   = 'open';
-  const STATUS_CLOSED = 'closed';
-
-}
diff --git a/src/applications/pholio/phid/PholioMockPHIDType.php b/src/applications/pholio/phid/PholioMockPHIDType.php
index 65d80a5e5a..e41f326e94 100644
--- a/src/applications/pholio/phid/PholioMockPHIDType.php
+++ b/src/applications/pholio/phid/PholioMockPHIDType.php
@@ -40,7 +40,7 @@ final class PholioMockPHIDType extends PhabricatorPHIDType {
       $handle->setFullName("M{$id}: {$name}");
 
       if ($mock->isClosed()) {
-        $handle->setStatus(PhabricatorObjectHandleStatus::STATUS_CLOSED);
+        $handle->setStatus(PhabricatorObjectHandle::STATUS_CLOSED);
       }
     }
   }
diff --git a/src/applications/phriction/phid/PhrictionDocumentPHIDType.php b/src/applications/phriction/phid/PhrictionDocumentPHIDType.php
index 4166263946..934dc73b30 100644
--- a/src/applications/phriction/phid/PhrictionDocumentPHIDType.php
+++ b/src/applications/phriction/phid/PhrictionDocumentPHIDType.php
@@ -42,7 +42,7 @@ final class PhrictionDocumentPHIDType extends PhabricatorPHIDType {
       $handle->setURI(PhrictionDocument::getSlugURI($slug));
 
       if ($status != PhrictionDocumentStatus::STATUS_EXISTS) {
-        $handle->setStatus(PhabricatorObjectHandleStatus::STATUS_CLOSED);
+        $handle->setStatus(PhabricatorObjectHandle::STATUS_CLOSED);
       }
     }
   }
diff --git a/src/applications/project/phid/PhabricatorProjectColumnPHIDType.php b/src/applications/project/phid/PhabricatorProjectColumnPHIDType.php
index a78939e4f7..4ac0399cf7 100644
--- a/src/applications/project/phid/PhabricatorProjectColumnPHIDType.php
+++ b/src/applications/project/phid/PhabricatorProjectColumnPHIDType.php
@@ -34,7 +34,10 @@ final class PhabricatorProjectColumnPHIDType extends PhabricatorPHIDType {
 
       $handle->setName($column->getDisplayName());
       $handle->setURI('/project/board/'.$column->getProject()->getID().'/');
-      $handle->setDisabled($column->isHidden());
+
+      if ($column->isHidden()) {
+        $handle->setStatus(PhabricatorObjectHandle::STATUS_CLOSED);
+      }
     }
   }
 
diff --git a/src/applications/project/phid/PhabricatorProjectProjectPHIDType.php b/src/applications/project/phid/PhabricatorProjectProjectPHIDType.php
index ae74610dcc..5689be49ce 100644
--- a/src/applications/project/phid/PhabricatorProjectProjectPHIDType.php
+++ b/src/applications/project/phid/PhabricatorProjectProjectPHIDType.php
@@ -49,7 +49,7 @@ final class PhabricatorProjectProjectPHIDType extends PhabricatorPHIDType {
       $handle->setTagColor($project->getColor());
 
       if ($project->isArchived()) {
-        $handle->setStatus(PhabricatorObjectHandleStatus::STATUS_CLOSED);
+        $handle->setStatus(PhabricatorObjectHandle::STATUS_CLOSED);
       }
     }
   }
diff --git a/src/applications/search/view/PhabricatorSearchResultView.php b/src/applications/search/view/PhabricatorSearchResultView.php
index 978e1b41ed..63219b3252 100644
--- a/src/applications/search/view/PhabricatorSearchResultView.php
+++ b/src/applications/search/view/PhabricatorSearchResultView.php
@@ -41,7 +41,7 @@ final class PhabricatorSearchResultView extends AphrontView {
       ->setImageURI($handle->getImageURI())
       ->addAttribute($type_name);
 
-    if ($handle->getStatus() == PhabricatorObjectHandleStatus::STATUS_CLOSED) {
+    if ($handle->getStatus() == PhabricatorObjectHandle::STATUS_CLOSED) {
       $item->setDisabled(true);
       $item->addAttribute(pht('Closed'));
     }
diff --git a/src/applications/typeahead/view/PhabricatorTypeaheadTokenView.php b/src/applications/typeahead/view/PhabricatorTypeaheadTokenView.php
index d08b1b406d..2dacd84022 100644
--- a/src/applications/typeahead/view/PhabricatorTypeaheadTokenView.php
+++ b/src/applications/typeahead/view/PhabricatorTypeaheadTokenView.php
@@ -35,7 +35,7 @@ final class PhabricatorTypeaheadTokenView
       ->setIcon($handle->getIcon());
 
     if ($handle->isDisabled() ||
-        $handle->getStatus() == PhabricatorObjectHandleStatus::STATUS_CLOSED) {
+        $handle->getStatus() == PhabricatorObjectHandle::STATUS_CLOSED) {
       $token->setTokenType(self::TYPE_DISABLED);
     } else {
       $token->setColor($handle->getTagColor());
diff --git a/src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php b/src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php
index 8f776716ea..f5c936539e 100644
--- a/src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php
+++ b/src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php
@@ -86,7 +86,7 @@ abstract class PhabricatorObjectRemarkupRule extends PhutilRemarkupRule {
 
     $href = $this->getObjectHref($object, $handle, $id);
     $text = $this->getObjectNamePrefix().$id;
-    $status_closed = PhabricatorObjectHandleStatus::STATUS_CLOSED;
+    $status_closed = PhabricatorObjectHandle::STATUS_CLOSED;
 
     if ($anchor) {
       $href = $href.'#'.$anchor;
@@ -126,7 +126,7 @@ abstract class PhabricatorObjectRemarkupRule extends PhutilRemarkupRule {
 
     $name = $handle->getFullName();
     $href = $handle->getURI();
-    $status_closed = PhabricatorObjectHandleStatus::STATUS_CLOSED;
+    $status_closed = PhabricatorObjectHandle::STATUS_CLOSED;
     $attr = array(
       'phid' => $handle->getPHID(),
       'closed'  => ($handle->getStatus() == $status_closed),
@@ -140,7 +140,7 @@ abstract class PhabricatorObjectRemarkupRule extends PhutilRemarkupRule {
     $href,
     PhabricatorObjectHandle $handle) {
 
-    $status_closed = PhabricatorObjectHandleStatus::STATUS_CLOSED;
+    $status_closed = PhabricatorObjectHandle::STATUS_CLOSED;
     $strikethrough = $handle->getStatus() == $status_closed ?
       'text-decoration: line-through;' :
       'text-decoration: none;';
diff --git a/webroot/rsrc/css/application/base/standard-page-view.css b/webroot/rsrc/css/application/base/standard-page-view.css
index 69725e14e6..5c33af7bcb 100644
--- a/webroot/rsrc/css/application/base/standard-page-view.css
+++ b/webroot/rsrc/css/application/base/standard-page-view.css
@@ -80,23 +80,23 @@ a.handle-status-closed:hover {
   color: #19558D;
 }
 
-a.handle-disabled,
-a.handle-status-away,
-a.handle-status-sporadic {
+a.handle-availability-disabled,
+a.handle-availability-none,
+a.handle-availability-partial {
   padding-left: 11px;
   background-repeat: no-repeat;
   background-position: -4px center;
 }
 
-a.handle-status-away {
+a.handle-availability-none {
   background-image: url(/rsrc/image/icon/fatcow/bullet_red.png);
 }
 
-a.handle-status-sporadic {
+a.handle-availability-partial {
   background-image: url(/rsrc/image/icon/fatcow/bullet_orange.png);
 }
 
-a.handle-disabled {
+a.handle-availability-disabled {
   background-image: url(/rsrc/image/icon/fatcow/bullet_black.png);
 }
 

From fef3c778fd4560275787551ceeab8e61aa4ebe58 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 14 May 2015 11:15:04 -0700
Subject: [PATCH 04/86] Replace user "status" with "availability"

Summary:
Ref T7707. Ref T8183.

  - Currently, user status is derived by looking at events they //created//. Instead, look at non-cancelled invites they are attending.
  - Prepare for on-user caching.
  - Mostly remove "Sporradic" as a status, although I left room for adding more information later.

Test Plan:
- Called user.query.
- Viewed profile.
- Viewed hovercard.
- Used mentions.
- Saw status immediately update when attending/leaving/cancelling a current event.
- Created an event ending at 6 PM and an event from 6:10PM - 7PM, saw "Away until 7PM".

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8183, T7707

Differential Revision: https://secure.phabricator.com/D12833
---
 resources/celerity/map.php                    |  4 +-
 .../storage/PhabricatorCalendarEvent.php      | 12 ---
 .../PhabricatorCalendarEventInvitee.php       |  4 +
 .../people/conduit/UserConduitAPIMethod.php   | 13 +--
 .../conduit/UserQueryConduitAPIMethod.php     | 10 +-
 .../PhabricatorPeopleProfileController.php    |  1 +
 .../PhabricatorUserStatusField.php            | 11 +--
 ...habricatorPeopleHovercardEventListener.php | 38 +++-----
 .../markup/PhabricatorMentionRemarkupRule.php | 19 +---
 .../phid/PhabricatorPeopleUserPHIDType.php    | 17 +---
 .../people/query/PhabricatorPeopleQuery.php   | 97 ++++++++++++++++---
 .../people/storage/PhabricatorUser.php        | 63 +++++++++---
 .../css/layout/phabricator-hovercard-view.css |  1 +
 13 files changed, 173 insertions(+), 117 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 0372651ba5..36b773434a 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -117,7 +117,7 @@ return array(
     'rsrc/css/font/font-source-sans-pro.css' => '8906c07b',
     'rsrc/css/font/phui-font-icon-base.css' => '3dad2ae3',
     'rsrc/css/layout/phabricator-filetree-view.css' => 'fccf9f82',
-    'rsrc/css/layout/phabricator-hovercard-view.css' => '44394670',
+    'rsrc/css/layout/phabricator-hovercard-view.css' => 'dd9121a9',
     'rsrc/css/layout/phabricator-side-menu-view.css' => 'c1db9e9c',
     'rsrc/css/layout/phabricator-source-code-view.css' => '2ceee894',
     'rsrc/css/phui/calendar/phui-calendar-day.css' => '38891735',
@@ -713,7 +713,7 @@ return array(
     'phabricator-filetree-view-css' => 'fccf9f82',
     'phabricator-flag-css' => '5337623f',
     'phabricator-hovercard' => '14ac66f5',
-    'phabricator-hovercard-view-css' => '44394670',
+    'phabricator-hovercard-view-css' => 'dd9121a9',
     'phabricator-keyboard-shortcut' => '1ae869f2',
     'phabricator-keyboard-shortcut-manager' => 'c1700f6f',
     'phabricator-main-menu-view' => '663e3810',
diff --git a/src/applications/calendar/storage/PhabricatorCalendarEvent.php b/src/applications/calendar/storage/PhabricatorCalendarEvent.php
index 3dd984ef7d..c476911ff3 100644
--- a/src/applications/calendar/storage/PhabricatorCalendarEvent.php
+++ b/src/applications/calendar/storage/PhabricatorCalendarEvent.php
@@ -218,18 +218,6 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO
     }
   }
 
-  public function loadCurrentStatuses($user_phids) {
-    if (!$user_phids) {
-      return array();
-    }
-
-    $statuses = $this->loadAllWhere(
-      'userPHID IN (%Ls) AND UNIX_TIMESTAMP() BETWEEN dateFrom AND dateTo',
-      $user_phids);
-
-    return mpull($statuses, null, 'getUserPHID');
-  }
-
   public function getInvitees() {
     return $this->assertAttached($this->invitees);
   }
diff --git a/src/applications/calendar/storage/PhabricatorCalendarEventInvitee.php b/src/applications/calendar/storage/PhabricatorCalendarEventInvitee.php
index 9701a782e7..b1d2b2d34c 100644
--- a/src/applications/calendar/storage/PhabricatorCalendarEventInvitee.php
+++ b/src/applications/calendar/storage/PhabricatorCalendarEventInvitee.php
@@ -38,6 +38,10 @@ final class PhabricatorCalendarEventInvitee extends PhabricatorCalendarDAO
     ) + parent::getConfiguration();
   }
 
+  public function isAttending() {
+    return ($this->getStatus() == self::STATUS_ATTENDING);
+  }
+
   public function isUninvited() {
     if ($this->getStatus() == self::STATUS_UNINVITED) {
       return true;
diff --git a/src/applications/people/conduit/UserConduitAPIMethod.php b/src/applications/people/conduit/UserConduitAPIMethod.php
index 7a30ee84dd..82da171f43 100644
--- a/src/applications/people/conduit/UserConduitAPIMethod.php
+++ b/src/applications/people/conduit/UserConduitAPIMethod.php
@@ -6,9 +6,7 @@ abstract class UserConduitAPIMethod extends ConduitAPIMethod {
     return PhabricatorApplication::getByClass('PhabricatorPeopleApplication');
   }
 
-  protected function buildUserInformationDictionary(
-    PhabricatorUser $user,
-    PhabricatorCalendarEvent $current_status = null) {
+  protected function buildUserInformationDictionary(PhabricatorUser $user) {
 
     $roles = array();
     if ($user->getIsDisabled()) {
@@ -48,9 +46,12 @@ abstract class UserConduitAPIMethod extends ConduitAPIMethod {
       'roles'        => $roles,
     );
 
-    if ($current_status) {
-      $return['currentStatus'] = $current_status->getTextStatus();
-      $return['currentStatusUntil'] = $current_status->getDateTo();
+    // TODO: Modernize this once we have a more long-term view of what the
+    // data looks like.
+    $until = $user->getAwayUntil();
+    if ($until) {
+      $return['currentStatus'] = 'away';
+      $return['currentStatusUntil'] = $until;
     }
 
     return $return;
diff --git a/src/applications/people/conduit/UserQueryConduitAPIMethod.php b/src/applications/people/conduit/UserQueryConduitAPIMethod.php
index 5c81fd5d4f..c480ae0c73 100644
--- a/src/applications/people/conduit/UserQueryConduitAPIMethod.php
+++ b/src/applications/people/conduit/UserQueryConduitAPIMethod.php
@@ -43,7 +43,8 @@ final class UserQueryConduitAPIMethod extends UserConduitAPIMethod {
 
     $query = id(new PhabricatorPeopleQuery())
       ->setViewer($request->getUser())
-      ->needProfileImage(true);
+      ->needProfileImage(true)
+      ->needAvailability(true);
 
     if ($usernames) {
       $query->withUsernames($usernames);
@@ -68,14 +69,9 @@ final class UserQueryConduitAPIMethod extends UserConduitAPIMethod {
     }
     $users = $query->execute();
 
-    $statuses = id(new PhabricatorCalendarEvent())->loadCurrentStatuses(
-      mpull($users, 'getPHID'));
-
     $results = array();
     foreach ($users as $user) {
-      $results[] = $this->buildUserInformationDictionary(
-        $user,
-        idx($statuses, $user->getPHID()));
+      $results[] = $this->buildUserInformationDictionary($user);
     }
     return $results;
   }
diff --git a/src/applications/people/controller/PhabricatorPeopleProfileController.php b/src/applications/people/controller/PhabricatorPeopleProfileController.php
index 688d798fbf..8404e56d91 100644
--- a/src/applications/people/controller/PhabricatorPeopleProfileController.php
+++ b/src/applications/people/controller/PhabricatorPeopleProfileController.php
@@ -20,6 +20,7 @@ final class PhabricatorPeopleProfileController
       ->setViewer($viewer)
       ->withUsernames(array($this->username))
       ->needProfileImage(true)
+      ->needAvailability(true)
       ->executeOne();
     if (!$user) {
       return new Aphront404Response();
diff --git a/src/applications/people/customfield/PhabricatorUserStatusField.php b/src/applications/people/customfield/PhabricatorUserStatusField.php
index 9ff97054c3..69e16d83db 100644
--- a/src/applications/people/customfield/PhabricatorUserStatusField.php
+++ b/src/applications/people/customfield/PhabricatorUserStatusField.php
@@ -29,16 +29,7 @@ final class PhabricatorUserStatusField
   public function renderPropertyViewValue(array $handles) {
     $user = $this->getObject();
     $viewer = $this->requireViewer();
-
-    $statuses = id(new PhabricatorCalendarEvent())
-      ->loadCurrentStatuses(array($user->getPHID()));
-    if (!$statuses) {
-      return pht('Available');
-    }
-
-    $status = head($statuses);
-
-    return $status->getTerseSummary($viewer);
+    return $user->getAvailabilityDescription($viewer);
   }
 
 }
diff --git a/src/applications/people/event/PhabricatorPeopleHovercardEventListener.php b/src/applications/people/event/PhabricatorPeopleHovercardEventListener.php
index 3bb955cf42..f2b957f363 100644
--- a/src/applications/people/event/PhabricatorPeopleHovercardEventListener.php
+++ b/src/applications/people/event/PhabricatorPeopleHovercardEventListener.php
@@ -26,12 +26,15 @@ final class PhabricatorPeopleHovercardEventListener
       return;
     }
 
-    $profile = $user->loadUserProfile();
+    // Reload to get availability.
+    $user = id(new PhabricatorPeopleQuery())
+      ->setViewer($viewer)
+      ->withIDs(array($user->getID()))
+      ->needAvailability(true)
+      ->executeOne();
 
     $hovercard->setTitle($user->getUsername());
-    $hovercard->setDetail(pht('%s - %s.', $user->getRealname(),
-      nonempty($profile->getTitle(),
-        pht('No title was found befitting of this rare specimen'))));
+    $hovercard->setDetail($user->getRealName());
 
     if ($user->getIsDisabled()) {
       $hovercard->addField(pht('Account'), pht('Disabled'));
@@ -40,29 +43,14 @@ final class PhabricatorPeopleHovercardEventListener
     } else if (PhabricatorApplication::isClassInstalledForViewer(
         'PhabricatorCalendarApplication',
         $viewer)) {
-      $statuses = id(new PhabricatorCalendarEvent())->loadCurrentStatuses(
-        array($user->getPHID()));
-      if ($statuses) {
-        $current_status = reset($statuses);
-        $dateto = phabricator_datetime($current_status->getDateTo(), $user);
-        $hovercard->addField(pht('Status'),
-          $current_status->getDescription());
-        $hovercard->addField(pht('Until'),
-          $dateto);
-      } else {
-        $hovercard->addField(pht('Status'), pht('Available'));
-      }
+      $hovercard->addField(
+        pht('Status'),
+        $user->getAvailabilityDescription($viewer));
     }
 
-    $hovercard->addField(pht('User since'),
-      phabricator_date($user->getDateCreated(), $user));
-
-    if ($profile->getBlurb()) {
-      $hovercard->addField(pht('Blurb'),
-        id(new PhutilUTF8StringTruncator())
-        ->setMaximumGlyphs(120)
-        ->truncateString($profile->getBlurb()));
-    }
+    $hovercard->addField(
+      pht('User Since'),
+      phabricator_date($user->getDateCreated(), $viewer));
 
     $event->setValue('hovercard', $hovercard);
   }
diff --git a/src/applications/people/markup/PhabricatorMentionRemarkupRule.php b/src/applications/people/markup/PhabricatorMentionRemarkupRule.php
index 0451e29312..eb224aae48 100644
--- a/src/applications/people/markup/PhabricatorMentionRemarkupRule.php
+++ b/src/applications/people/markup/PhabricatorMentionRemarkupRule.php
@@ -72,16 +72,9 @@ final class PhabricatorMentionRemarkupRule extends PhutilRemarkupRule {
     $users = id(new PhabricatorPeopleQuery())
       ->setViewer($this->getEngine()->getConfig('viewer'))
       ->withUsernames($usernames)
+      ->needAvailability(true)
       ->execute();
 
-    if ($users) {
-      $user_statuses = id(new PhabricatorCalendarEvent())
-        ->loadCurrentStatuses(mpull($users, 'getPHID'));
-      $user_statuses = mpull($user_statuses, null, 'getUserPHID');
-    } else {
-      $user_statuses = array();
-    }
-
     $actual_users = array();
 
     $mentioned_key = self::KEY_MENTIONED;
@@ -156,14 +149,8 @@ final class PhabricatorMentionRemarkupRule extends PhutilRemarkupRule {
           if (!$user->isUserActivated()) {
             $tag->setDotColor(PHUITagView::COLOR_GREY);
           } else {
-            $status = idx($user_statuses, $user->getPHID());
-            if ($status) {
-              $status = $status->getStatus();
-              if ($status == PhabricatorCalendarEvent::STATUS_AWAY) {
-                $tag->setDotColor(PHUITagView::COLOR_RED);
-              } else if ($status == PhabricatorCalendarEvent::STATUS_AWAY) {
-                $tag->setDotColor(PHUITagView::COLOR_ORANGE);
-              }
+            if ($user->getAwayUntil()) {
+              $tag->setDotColor(PHUITagView::COLOR_RED);
             }
           }
         }
diff --git a/src/applications/people/phid/PhabricatorPeopleUserPHIDType.php b/src/applications/people/phid/PhabricatorPeopleUserPHIDType.php
index 16453987c9..ba271e6d92 100644
--- a/src/applications/people/phid/PhabricatorPeopleUserPHIDType.php
+++ b/src/applications/people/phid/PhabricatorPeopleUserPHIDType.php
@@ -27,7 +27,7 @@ final class PhabricatorPeopleUserPHIDType extends PhabricatorPHIDType {
     return id(new PhabricatorPeopleQuery())
       ->withPHIDs($phids)
       ->needProfileImage(true)
-      ->needStatus(true);
+      ->needAvailability(true);
   }
 
   public function loadHandles(
@@ -48,18 +48,9 @@ final class PhabricatorPeopleUserPHIDType extends PhabricatorPHIDType {
       if (!$user->isUserActivated()) {
         $availability = PhabricatorObjectHandle::AVAILABILITY_DISABLED;
       } else {
-        if ($user->hasStatus()) {
-          // NOTE: This first call returns an event; then we get the event
-          // status.
-          $status = $user->getStatus()->getStatus();
-          switch ($status) {
-            case PhabricatorCalendarEvent::STATUS_AWAY:
-              $availability = PhabricatorObjectHandle::AVAILABILITY_NONE;
-              break;
-            case PhabricatorCalendarEvent::STATUS_SPORADIC:
-              $availability = PhabricatorObjectHandle::AVAILABILITY_PARTIAL;
-              break;
-          }
+        $until = $user->getAwayUntil();
+        if ($until) {
+          $availability = PhabricatorObjectHandle::AVAILABILITY_NONE;
         }
       }
 
diff --git a/src/applications/people/query/PhabricatorPeopleQuery.php b/src/applications/people/query/PhabricatorPeopleQuery.php
index b8b7ad1e29..2bcb62c2bb 100644
--- a/src/applications/people/query/PhabricatorPeopleQuery.php
+++ b/src/applications/people/query/PhabricatorPeopleQuery.php
@@ -20,7 +20,7 @@ final class PhabricatorPeopleQuery
   private $needPrimaryEmail;
   private $needProfile;
   private $needProfileImage;
-  private $needStatus;
+  private $needAvailability;
 
   public function withIDs(array $ids) {
     $this->ids = $ids;
@@ -102,8 +102,8 @@ final class PhabricatorPeopleQuery
     return $this;
   }
 
-  public function needStatus($need) {
-    $this->needStatus = $need;
+  public function needAvailability($need) {
+    $this->needAvailability = $need;
     return $this;
   }
 
@@ -200,15 +200,11 @@ final class PhabricatorPeopleQuery
       }
     }
 
-    if ($this->needStatus) {
-      $user_list = mpull($users, null, 'getPHID');
-      $statuses = id(new PhabricatorCalendarEvent())->loadCurrentStatuses(
-        array_keys($user_list));
-      foreach ($user_list as $phid => $user) {
-        $status = idx($statuses, $phid);
-        if ($status) {
-          $user->attachStatus($status);
-        }
+    if ($this->needAvailability) {
+      // TODO: Add caching.
+      $rebuild = $users;
+      if ($rebuild) {
+        $this->rebuildAvailabilityCache($rebuild);
       }
     }
 
@@ -375,5 +371,82 @@ final class PhabricatorPeopleQuery
     );
   }
 
+  private function rebuildAvailabilityCache(array $rebuild) {
+    $rebuild = mpull($rebuild, null, 'getPHID');
+
+    // Limit the window we look at because far-future events are largely
+    // irrelevant and this makes the cache cheaper to build and allows it to
+    // self-heal over time.
+    $min_range = PhabricatorTime::getNow();
+    $max_range = $min_range + phutil_units('72 hours in seconds');
+
+    $events = id(new PhabricatorCalendarEventQuery())
+      ->setViewer(PhabricatorUser::getOmnipotentUser())
+      ->withInvitedPHIDs(array_keys($rebuild))
+      ->withIsCancelled(false)
+      ->withDateRange($min_range, $max_range)
+      ->execute();
+
+    // Group all the events by invited user. Only examine events that users
+    // are actually attending.
+    $map = array();
+    foreach ($events as $event) {
+      foreach ($event->getInvitees() as $invitee) {
+        if (!$invitee->isAttending()) {
+          continue;
+        }
+
+        $invitee_phid = $invitee->getInviteePHID();
+        if (!isset($rebuild[$invitee_phid])) {
+          continue;
+        }
+
+        $map[$invitee_phid][] = $event;
+      }
+    }
+
+    // Margin between meetings: pretend meetings start earlier than they do
+    // so we mark you away for the entire time if you have a series of
+    // back-to-back meetings, even if they don't strictly overlap.
+    $margin = phutil_units('15 minutes in seconds');
+
+    foreach ($rebuild as $phid => $user) {
+      $events = idx($map, $phid, array());
+
+      $cursor = $min_range;
+      if ($events) {
+        // Find the next time when the user has no meetings. If we move forward
+        // because of an event, we check again for events after that one ends.
+        while (true) {
+          foreach ($events as $event) {
+            $from = ($event->getDateFrom() - $margin);
+            $to = $event->getDateTo();
+            if (($from <= $cursor) && ($to > $cursor)) {
+              $cursor = $to;
+              continue 2;
+            }
+          }
+          break;
+        }
+      }
+
+      if ($cursor > $min_range) {
+        $availability = array(
+          'until' => $cursor,
+        );
+        $availability_ttl = $cursor;
+      } else {
+        $availability = null;
+        $availability_ttl = $max_range;
+      }
+
+      // Never TTL the cache to longer than the maximum range we examined.
+      $availability_ttl = min($availability_ttl, $max_range);
+
+      // TODO: Write the cache.
+
+      $user->attachAvailability($availability);
+    }
+  }
 
 }
diff --git a/src/applications/people/storage/PhabricatorUser.php b/src/applications/people/storage/PhabricatorUser.php
index 3fbfac062f..89de29747b 100644
--- a/src/applications/people/storage/PhabricatorUser.php
+++ b/src/applications/people/storage/PhabricatorUser.php
@@ -1,6 +1,7 @@
 <?php
 
 /**
+ * @task availability Availability
  * @task image-cache Profile Image Cache
  * @task factors Multi-Factor Authentication
  * @task handles Managing Handles
@@ -45,7 +46,7 @@ final class PhabricatorUser
 
   private $profileImage = self::ATTACHABLE;
   private $profile = null;
-  private $status = self::ATTACHABLE;
+  private $availability = self::ATTACHABLE;
   private $preferences = null;
   private $omnipotent = false;
   private $customFields = self::ATTACHABLE;
@@ -658,19 +659,6 @@ EOBODY;
     return celerity_get_resource_uri('/rsrc/image/avatar.png');
   }
 
-  public function attachStatus(PhabricatorCalendarEvent $status) {
-    $this->status = $status;
-    return $this;
-  }
-
-  public function getStatus() {
-    return $this->assertAttached($this->status);
-  }
-
-  public function hasStatus() {
-    return $this->status !== self::ATTACHABLE;
-  }
-
   public function attachProfileImageURI($uri) {
     $this->profileImage = $uri;
     return $this;
@@ -727,6 +715,53 @@ EOBODY;
   }
 
 
+/* -(  Availability  )------------------------------------------------------- */
+
+
+  /**
+   * @task availability
+   */
+  public function attachAvailability($availability) {
+    $this->availability = $availability;
+    return $this;
+  }
+
+
+  /**
+   * Get the timestamp the user is away until, if they are currently away.
+   *
+   * @return int|null Epoch timestamp, or `null` if the user is not away.
+   * @task availability
+   */
+  public function getAwayUntil() {
+    $availability = $this->availability;
+
+    $this->assertAttached($availability);
+    if (!$availability) {
+      return null;
+    }
+
+    return idx($availability, 'until');
+  }
+
+
+  /**
+   * Describe the user's availability.
+   *
+   * @param PhabricatorUser Viewing user.
+   * @return string Human-readable description of away status.
+   * @task availability
+   */
+  public function getAvailabilityDescription(PhabricatorUser $viewer) {
+    $until = $this->getAwayUntil();
+    if ($until) {
+      return pht('Away until %s', phabricator_datetime($until, $viewer));
+    } else {
+      return pht('Available');
+    }
+  }
+
+
 /* -(  Profile Image Cache  )------------------------------------------------ */
 
 
diff --git a/webroot/rsrc/css/layout/phabricator-hovercard-view.css b/webroot/rsrc/css/layout/phabricator-hovercard-view.css
index 05d520fb97..54cd365019 100644
--- a/webroot/rsrc/css/layout/phabricator-hovercard-view.css
+++ b/webroot/rsrc/css/layout/phabricator-hovercard-view.css
@@ -77,6 +77,7 @@
   height: 50px;
   background-position: center;
   background-repeat: no-repeat;
+  background-size: 100%;
 }
 .phabricator-hovercard-tail {
   width: 396px;

From aa550189c7886faeae87fd244b8c485511a15a6d Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 14 May 2015 11:15:22 -0700
Subject: [PATCH 05/86] Add an availability cache for users

Summary: Ref T7707. Caches availability on users to reduce the cost of loading handles. This cache is very slightly tricky to dirty properly.

Test Plan:
  - Use DarkConsole to examine queries; saw cache hits, miss+fill, dirty.
  - Saw availability change correctly after canceling, joining, declining events.
  - Saw no queries to Calendar for pages with only availability data.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7707

Differential Revision: https://secure.phabricator.com/D12838
---
 .../sql/autopatches/20150514.user.cache.2.sql |  5 ++
 .../editor/PhabricatorCalendarEventEditor.php | 58 +++++++++++++++----
 .../storage/PhabricatorCalendarEvent.php      | 13 +++++
 .../people/query/PhabricatorPeopleQuery.php   | 26 +++++----
 .../people/storage/PhabricatorUser.php        | 52 ++++++++++++++++-
 5 files changed, 132 insertions(+), 22 deletions(-)
 create mode 100644 resources/sql/autopatches/20150514.user.cache.2.sql

diff --git a/resources/sql/autopatches/20150514.user.cache.2.sql b/resources/sql/autopatches/20150514.user.cache.2.sql
new file mode 100644
index 0000000000..fc53324dc3
--- /dev/null
+++ b/resources/sql/autopatches/20150514.user.cache.2.sql
@@ -0,0 +1,5 @@
+ALTER TABLE {$NAMESPACE}_user.user
+  ADD availabilityCache VARCHAR(255) COLLATE {$COLLATE_TEXT};
+
+ALTER TABLE {$NAMESPACE}_user.user
+  ADD availabilityCacheTTL INT UNSIGNED;
diff --git a/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php b/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
index 6e80d19236..947098ff28 100644
--- a/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
+++ b/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
@@ -55,16 +55,7 @@ final class PhabricatorCalendarEventEditor
       case PhabricatorCalendarEventTransaction::TYPE_INVITE:
         $map = $xaction->getNewValue();
         $phids = array_keys($map);
-        $invitees = array();
-
-        if ($map && !$this->getIsNewObject()) {
-          $invitees = id(new PhabricatorCalendarEventInviteeQuery())
-            ->setViewer($this->getActor())
-            ->withEventPHIDs(array($object->getPHID()))
-            ->withInviteePHIDs($phids)
-            ->execute();
-          $invitees = mpull($invitees, null, 'getInviteePHID');
-        }
+        $invitees = mpull($object->getInvitees(), null, 'getInviteePHID');
 
         $old = array();
         foreach ($phids as $phid) {
@@ -193,6 +184,53 @@ final class PhabricatorCalendarEventEditor
     return $xactions;
   }
 
+  protected function applyFinalEffects($object, array $xactions) {
+
+    // Clear the availability caches for users whose availability is affected
+    // by this edit.
+
+    $invalidate_all = false;
+    $invalidate_phids = array();
+    foreach ($xactions as $xaction) {
+      switch ($xaction->getTransactionType()) {
+        case PhabricatorCalendarEventTransaction::TYPE_START_DATE:
+        case PhabricatorCalendarEventTransaction::TYPE_END_DATE:
+        case PhabricatorCalendarEventTransaction::TYPE_CANCEL:
+        case PhabricatorCalendarEventTransaction::TYPE_ALL_DAY:
+          // For these kinds of changes, we need to invalidate the availabilty
+          // caches for all attendees.
+          $invalidate_all = true;
+          break;
+        case PhabricatorCalendarEventTransaction::TYPE_INVITE:
+          foreach ($xaction->getNewValue() as $phid => $ignored) {
+            $invalidate_phids[$phid] = $phid;
+          }
+          break;
+      }
+    }
+
+    $phids = mpull($object->getInvitees(), 'getInviteePHID');
+    $phids = array_fuse($phids);
+
+    if (!$invalidate_all) {
+      $phids = array_select_keys($phids, $invalidate_phids);
+    }
+
+    if ($phids) {
+      $user = new PhabricatorUser();
+      $conn_w = $user->establishConnection('w');
+      queryfx(
+        $conn_w,
+        'UPDATE %T SET availabilityCacheTTL = NULL
+          WHERE phid IN (%Ls) AND availabilityCacheTTL >= %d',
+        $user->getTableName(),
+        $phids,
+        $object->getDateFromForCache());
+    }
+
+    return $xactions;
+  }
+
 
   protected function validateAllTransactions(
     PhabricatorLiskDAO $object,
diff --git a/src/applications/calendar/storage/PhabricatorCalendarEvent.php b/src/applications/calendar/storage/PhabricatorCalendarEvent.php
index c476911ff3..d68c207371 100644
--- a/src/applications/calendar/storage/PhabricatorCalendarEvent.php
+++ b/src/applications/calendar/storage/PhabricatorCalendarEvent.php
@@ -147,6 +147,19 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO
     return parent::save();
   }
 
+  /**
+   * Get the event start epoch for evaluating invitee availability.
+   *
+   * When assessing availability, we pretend events start earlier than they
+   * really. This allows us to mark users away for the entire duration of a
+   * series of back-to-back meetings, even if they don't strictly overlap.
+   *
+   * @return int Event start date for availability caches.
+   */
+  public function getDateFromForCache() {
+    return ($this->getDateFrom() - phutil_units('15 minutes in seconds'));
+  }
+
   private static $statusTexts = array(
     self::STATUS_AWAY => 'away',
     self::STATUS_SPORADIC => 'sporadic',
diff --git a/src/applications/people/query/PhabricatorPeopleQuery.php b/src/applications/people/query/PhabricatorPeopleQuery.php
index 2bcb62c2bb..1b4c7c5450 100644
--- a/src/applications/people/query/PhabricatorPeopleQuery.php
+++ b/src/applications/people/query/PhabricatorPeopleQuery.php
@@ -201,8 +201,16 @@ final class PhabricatorPeopleQuery
     }
 
     if ($this->needAvailability) {
-      // TODO: Add caching.
-      $rebuild = $users;
+      $rebuild = array();
+      foreach ($users as $user) {
+        $cache = $user->getAvailabilityCache();
+        if ($cache !== null) {
+          $user->attachAvailability($cache);
+        } else {
+          $rebuild[] = $user;
+        }
+      }
+
       if ($rebuild) {
         $this->rebuildAvailabilityCache($rebuild);
       }
@@ -405,11 +413,6 @@ final class PhabricatorPeopleQuery
       }
     }
 
-    // Margin between meetings: pretend meetings start earlier than they do
-    // so we mark you away for the entire time if you have a series of
-    // back-to-back meetings, even if they don't strictly overlap.
-    $margin = phutil_units('15 minutes in seconds');
-
     foreach ($rebuild as $phid => $user) {
       $events = idx($map, $phid, array());
 
@@ -419,7 +422,7 @@ final class PhabricatorPeopleQuery
         // because of an event, we check again for events after that one ends.
         while (true) {
           foreach ($events as $event) {
-            $from = ($event->getDateFrom() - $margin);
+            $from = $event->getDateFromForCache();
             $to = $event->getDateTo();
             if (($from <= $cursor) && ($to > $cursor)) {
               $cursor = $to;
@@ -436,15 +439,16 @@ final class PhabricatorPeopleQuery
         );
         $availability_ttl = $cursor;
       } else {
-        $availability = null;
+        $availability = array(
+          'until' => null,
+        );
         $availability_ttl = $max_range;
       }
 
       // Never TTL the cache to longer than the maximum range we examined.
       $availability_ttl = min($availability_ttl, $max_range);
 
-      // TODO: Write the cache.
-
+      $user->writeAvailabilityCache($availability, $availability_ttl);
       $user->attachAvailability($availability);
     }
   }
diff --git a/src/applications/people/storage/PhabricatorUser.php b/src/applications/people/storage/PhabricatorUser.php
index 89de29747b..0c7ef73b0e 100644
--- a/src/applications/people/storage/PhabricatorUser.php
+++ b/src/applications/people/storage/PhabricatorUser.php
@@ -27,6 +27,8 @@ final class PhabricatorUser
   protected $passwordHash;
   protected $profileImagePHID;
   protected $profileImageCache;
+  protected $availabilityCache;
+  protected $availabilityCacheTTL;
   protected $timezoneIdentifier = '';
 
   protected $consoleEnabled = 0;
@@ -146,6 +148,8 @@ final class PhabricatorUser
         'accountSecret' => 'bytes64',
         'isEnrolledInMultiFactor' => 'bool',
         'profileImageCache' => 'text255?',
+        'availabilityCache' => 'text255?',
+        'availabilityCacheTTL' => 'uint32?',
       ),
       self::CONFIG_KEY_SCHEMA => array(
         'key_phid' => null,
@@ -166,6 +170,8 @@ final class PhabricatorUser
       ),
       self::CONFIG_NO_MUTATE => array(
         'profileImageCache' => true,
+        'availabilityCache' => true,
+        'availabilityCacheTTL' => true,
       ),
     ) + parent::getConfiguration();
   }
@@ -721,7 +727,7 @@ EOBODY;
   /**
    * @task availability
    */
-  public function attachAvailability($availability) {
+  public function attachAvailability(array $availability) {
     $this->availability = $availability;
     return $this;
   }
@@ -762,6 +768,50 @@ EOBODY;
   }
 
 
+  /**
+   * Get cached availability, if present.
+   *
+   * @return wild|null Cache data, or null if no cache is available.
+   * @task availability
+   */
+  public function getAvailabilityCache() {
+    $now = PhabricatorTime::getNow();
+    if ($this->availabilityCacheTTL <= $now) {
+      return null;
+    }
+
+    try {
+      return phutil_json_decode($this->availabilityCache);
+    } catch (Exception $ex) {
+      return null;
+    }
+  }
+
+
+  /**
+   * Write to the availability cache.
+   *
+   * @param wild Availability cache data.
+   * @param int|null Cache TTL.
+   * @return this
+   * @task availability
+   */
+  public function writeAvailabilityCache(array $availability, $ttl) {
+    $unguarded = AphrontWriteGuard::beginScopedUnguardedWrites();
+    queryfx(
+      $this->establishConnection('w'),
+      'UPDATE %T SET availabilityCache = %s, availabilityCacheTTL = %nd
+        WHERE id = %d',
+      $this->getTableName(),
+      json_encode($availability),
+      $ttl,
+      $this->getID());
+    unset($unguarded);
+
+    return $this;
+  }
+
+
 /* -(  Profile Image Cache  )------------------------------------------------ */
 
 

From 2bc9dec85f038c99788eb2a2c23de0285441505d Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 14 May 2015 11:15:44 -0700
Subject: [PATCH 06/86] Remove "status" field from events

Summary:
Ref T8183. See that task for discussion.

  - For now, events always mark users as "Away".
  - In the future, we may reintroduce "sporradic" or other more complicated availability states, but they would be properties of the invitee, not of the event itself.
  - This also removes the long-deprecated `user.addstatus` and `user.removestatus` Conduit calls.

Test Plan:
  - Created, edited, viewed events.
  - Grepped for removed symbols.
  - Viewed profile calendar.
  - Viewed Conpherence calendar.
  - Load Conduit console.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8183

Differential Revision: https://secure.phabricator.com/D12840
---
 .../autopatches/20150514.calendar.status.sql  |  2 +
 src/__phutil_library_map__.php                |  4 -
 ...PhabricatorCalendarEventEditController.php | 14 ---
 .../editor/PhabricatorCalendarEventEditor.php | 17 +---
 .../storage/PhabricatorCalendarEvent.php      | 46 ----------
 .../PhabricatorCalendarEventTransaction.php   | 23 -----
 .../ConpherenceWidgetController.php           | 14 +--
 .../query/ConpherenceThreadQuery.php          | 41 ++++++---
 .../conduit/UserAddStatusConduitAPIMethod.php | 62 --------------
 .../UserRemoveStatusConduitAPIMethod.php      | 85 -------------------
 10 files changed, 43 insertions(+), 265 deletions(-)
 create mode 100644 resources/sql/autopatches/20150514.calendar.status.sql
 delete mode 100644 src/applications/people/conduit/UserAddStatusConduitAPIMethod.php
 delete mode 100644 src/applications/people/conduit/UserRemoveStatusConduitAPIMethod.php

diff --git a/resources/sql/autopatches/20150514.calendar.status.sql b/resources/sql/autopatches/20150514.calendar.status.sql
new file mode 100644
index 0000000000..984205d99e
--- /dev/null
+++ b/resources/sql/autopatches/20150514.calendar.status.sql
@@ -0,0 +1,2 @@
+ALTER TABLE {$NAMESPACE}_calendar.calendar_event
+  DROP status;
diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index 638674126b..903aaf8a44 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -3200,13 +3200,11 @@ phutil_register_library_map(array(
     'TokenGiveConduitAPIMethod' => 'applications/tokens/conduit/TokenGiveConduitAPIMethod.php',
     'TokenGivenConduitAPIMethod' => 'applications/tokens/conduit/TokenGivenConduitAPIMethod.php',
     'TokenQueryConduitAPIMethod' => 'applications/tokens/conduit/TokenQueryConduitAPIMethod.php',
-    'UserAddStatusConduitAPIMethod' => 'applications/people/conduit/UserAddStatusConduitAPIMethod.php',
     'UserConduitAPIMethod' => 'applications/people/conduit/UserConduitAPIMethod.php',
     'UserDisableConduitAPIMethod' => 'applications/people/conduit/UserDisableConduitAPIMethod.php',
     'UserEnableConduitAPIMethod' => 'applications/people/conduit/UserEnableConduitAPIMethod.php',
     'UserFindConduitAPIMethod' => 'applications/people/conduit/UserFindConduitAPIMethod.php',
     'UserQueryConduitAPIMethod' => 'applications/people/conduit/UserQueryConduitAPIMethod.php',
-    'UserRemoveStatusConduitAPIMethod' => 'applications/people/conduit/UserRemoveStatusConduitAPIMethod.php',
     'UserWhoAmIConduitAPIMethod' => 'applications/people/conduit/UserWhoAmIConduitAPIMethod.php',
   ),
   'function' => array(
@@ -6781,13 +6779,11 @@ phutil_register_library_map(array(
     'TokenGiveConduitAPIMethod' => 'TokenConduitAPIMethod',
     'TokenGivenConduitAPIMethod' => 'TokenConduitAPIMethod',
     'TokenQueryConduitAPIMethod' => 'TokenConduitAPIMethod',
-    'UserAddStatusConduitAPIMethod' => 'UserConduitAPIMethod',
     'UserConduitAPIMethod' => 'ConduitAPIMethod',
     'UserDisableConduitAPIMethod' => 'UserConduitAPIMethod',
     'UserEnableConduitAPIMethod' => 'UserConduitAPIMethod',
     'UserFindConduitAPIMethod' => 'UserConduitAPIMethod',
     'UserQueryConduitAPIMethod' => 'UserConduitAPIMethod',
-    'UserRemoveStatusConduitAPIMethod' => 'UserConduitAPIMethod',
     'UserWhoAmIConduitAPIMethod' => 'UserConduitAPIMethod',
   ),
 ));
diff --git a/src/applications/calendar/controller/PhabricatorCalendarEventEditController.php b/src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
index e31b9bdf0e..900b3ad56b 100644
--- a/src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
+++ b/src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
@@ -73,7 +73,6 @@ final class PhabricatorCalendarEventEditController
 
     $name = $event->getName();
     $description = $event->getDescription();
-    $type = $event->getStatus();
     $is_all_day = $event->getIsAllDay();
 
     $current_policies = id(new PhabricatorPolicyQuery())
@@ -84,7 +83,6 @@ final class PhabricatorCalendarEventEditController
     if ($request->isFormPost()) {
       $xactions = array();
       $name = $request->getStr('name');
-      $type = $request->getInt('status');
 
       $start_value = AphrontFormDateControlValue::newFromRequest(
         $request,
@@ -128,11 +126,6 @@ final class PhabricatorCalendarEventEditController
           PhabricatorCalendarEventTransaction::TYPE_END_DATE)
         ->setNewValue($end_value);
 
-      $xactions[] = id(new PhabricatorCalendarEventTransaction())
-        ->setTransactionType(
-          PhabricatorCalendarEventTransaction::TYPE_STATUS)
-        ->setNewValue($type);
-
       $xactions[] = id(new PhabricatorCalendarEventTransaction())
         ->setTransactionType(
           PhabricatorTransactions::TYPE_SUBSCRIBERS)
@@ -195,12 +188,6 @@ final class PhabricatorCalendarEventEditController
       ->setValue($name)
       ->setError($error_name);
 
-    $status_select = id(new AphrontFormSelectControl())
-      ->setLabel(pht('Status'))
-      ->setName('status')
-      ->setValue($type)
-      ->setOptions($event->getStatusOptions());
-
     $all_day_checkbox = id(new AphrontFormCheckboxControl())
       ->addCheckbox(
         'isAllDay',
@@ -262,7 +249,6 @@ final class PhabricatorCalendarEventEditController
     $form = id(new AphrontFormView())
       ->setUser($user)
       ->appendChild($name)
-      ->appendChild($status_select)
       ->appendChild($all_day_checkbox)
       ->appendChild($start_control)
       ->appendChild($end_control)
diff --git a/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php b/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
index 947098ff28..727c33958f 100644
--- a/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
+++ b/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
@@ -17,7 +17,6 @@ final class PhabricatorCalendarEventEditor
     $types[] = PhabricatorCalendarEventTransaction::TYPE_NAME;
     $types[] = PhabricatorCalendarEventTransaction::TYPE_START_DATE;
     $types[] = PhabricatorCalendarEventTransaction::TYPE_END_DATE;
-    $types[] = PhabricatorCalendarEventTransaction::TYPE_STATUS;
     $types[] = PhabricatorCalendarEventTransaction::TYPE_DESCRIPTION;
     $types[] = PhabricatorCalendarEventTransaction::TYPE_CANCEL;
     $types[] = PhabricatorCalendarEventTransaction::TYPE_INVITE;
@@ -40,12 +39,6 @@ final class PhabricatorCalendarEventEditor
         return $object->getDateFrom();
       case PhabricatorCalendarEventTransaction::TYPE_END_DATE:
         return $object->getDateTo();
-      case PhabricatorCalendarEventTransaction::TYPE_STATUS:
-        $status = $object->getStatus();
-        if ($status === null) {
-          return null;
-        }
-        return (int)$status;
       case PhabricatorCalendarEventTransaction::TYPE_DESCRIPTION:
         return $object->getDescription();
       case PhabricatorCalendarEventTransaction::TYPE_CANCEL:
@@ -83,8 +76,6 @@ final class PhabricatorCalendarEventEditor
         return $xaction->getNewValue();
       case PhabricatorCalendarEventTransaction::TYPE_ALL_DAY:
         return (int)$xaction->getNewValue();
-      case PhabricatorCalendarEventTransaction::TYPE_STATUS:
-        return (int)$xaction->getNewValue();
       case PhabricatorCalendarEventTransaction::TYPE_START_DATE:
       case PhabricatorCalendarEventTransaction::TYPE_END_DATE:
         return $xaction->getNewValue()->getEpoch();
@@ -107,9 +98,6 @@ final class PhabricatorCalendarEventEditor
       case PhabricatorCalendarEventTransaction::TYPE_END_DATE:
         $object->setDateTo($xaction->getNewValue());
         return;
-      case PhabricatorCalendarEventTransaction::TYPE_STATUS:
-        $object->setStatus($xaction->getNewValue());
-        return;
       case PhabricatorCalendarEventTransaction::TYPE_DESCRIPTION:
         $object->setDescription($xaction->getNewValue());
         return;
@@ -139,7 +127,6 @@ final class PhabricatorCalendarEventEditor
       case PhabricatorCalendarEventTransaction::TYPE_NAME:
       case PhabricatorCalendarEventTransaction::TYPE_START_DATE:
       case PhabricatorCalendarEventTransaction::TYPE_END_DATE:
-      case PhabricatorCalendarEventTransaction::TYPE_STATUS:
       case PhabricatorCalendarEventTransaction::TYPE_DESCRIPTION:
       case PhabricatorCalendarEventTransaction::TYPE_CANCEL:
       case PhabricatorCalendarEventTransaction::TYPE_ALL_DAY:
@@ -184,7 +171,9 @@ final class PhabricatorCalendarEventEditor
     return $xactions;
   }
 
-  protected function applyFinalEffects($object, array $xactions) {
+  protected function applyFinalEffects(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
 
     // Clear the availability caches for users whose availability is affected
     // by this edit.
diff --git a/src/applications/calendar/storage/PhabricatorCalendarEvent.php b/src/applications/calendar/storage/PhabricatorCalendarEvent.php
index d68c207371..044bc9fc78 100644
--- a/src/applications/calendar/storage/PhabricatorCalendarEvent.php
+++ b/src/applications/calendar/storage/PhabricatorCalendarEvent.php
@@ -14,7 +14,6 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO
   protected $userPHID;
   protected $dateFrom;
   protected $dateTo;
-  protected $status;
   protected $description;
   protected $isCancelled;
   protected $isAllDay;
@@ -26,9 +25,6 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO
   private $invitees = self::ATTACHABLE;
   private $appliedViewer;
 
-  const STATUS_AWAY = 1;
-  const STATUS_SPORADIC = 2;
-
   public static function initializeNewCalendarEvent(PhabricatorUser $actor) {
     $app = id(new PhabricatorApplicationQuery())
       ->setViewer($actor)
@@ -160,27 +156,6 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO
     return ($this->getDateFrom() - phutil_units('15 minutes in seconds'));
   }
 
-  private static $statusTexts = array(
-    self::STATUS_AWAY => 'away',
-    self::STATUS_SPORADIC => 'sporadic',
-  );
-
-  public function setTextStatus($status) {
-    $statuses = array_flip(self::$statusTexts);
-    return $this->setStatus($statuses[$status]);
-  }
-
-  public function getTextStatus() {
-    return self::$statusTexts[$this->status];
-  }
-
-  public function getStatusOptions() {
-    return array(
-      self::STATUS_AWAY     => pht('Away'),
-      self::STATUS_SPORADIC => pht('Sporadic'),
-    );
-  }
-
   protected function getConfiguration() {
     return array(
       self::CONFIG_AUX_PHID => true,
@@ -188,7 +163,6 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO
         'name' => 'text',
         'dateFrom' => 'epoch',
         'dateTo' => 'epoch',
-        'status' => 'uint32',
         'description' => 'text',
         'isCancelled' => 'bool',
         'isAllDay' => 'bool',
@@ -211,26 +185,6 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO
     return 'E'.$this->getID();
   }
 
-  public function getTerseSummary(PhabricatorUser $viewer) {
-    $until = phabricator_date($this->dateTo, $viewer);
-    if ($this->status == self::STATUS_SPORADIC) {
-      return pht('Sporadic until %s', $until);
-    } else {
-      return pht('Away until %s', $until);
-    }
-  }
-
-  public static function getNameForStatus($value) {
-    switch ($value) {
-      case self::STATUS_AWAY:
-        return pht('Away');
-      case self::STATUS_SPORADIC:
-        return pht('Sporadic');
-      default:
-        return pht('Unknown');
-    }
-  }
-
   public function getInvitees() {
     return $this->assertAttached($this->invitees);
   }
diff --git a/src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php b/src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php
index d3e7a25efd..91b5d5231f 100644
--- a/src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php
+++ b/src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php
@@ -6,7 +6,6 @@ final class PhabricatorCalendarEventTransaction
   const TYPE_NAME = 'calendar.name';
   const TYPE_START_DATE = 'calendar.startdate';
   const TYPE_END_DATE = 'calendar.enddate';
-  const TYPE_STATUS = 'calendar.status';
   const TYPE_DESCRIPTION = 'calendar.description';
   const TYPE_CANCEL = 'calendar.cancel';
   const TYPE_ALL_DAY = 'calendar.allday';
@@ -35,7 +34,6 @@ final class PhabricatorCalendarEventTransaction
       case self::TYPE_NAME:
       case self::TYPE_START_DATE:
       case self::TYPE_END_DATE:
-      case self::TYPE_STATUS:
       case self::TYPE_DESCRIPTION:
       case self::TYPE_CANCEL:
       case self::TYPE_ALL_DAY:
@@ -57,7 +55,6 @@ final class PhabricatorCalendarEventTransaction
     switch ($this->getTransactionType()) {
       case self::TYPE_START_DATE:
       case self::TYPE_END_DATE:
-      case self::TYPE_STATUS:
       case self::TYPE_DESCRIPTION:
       case self::TYPE_CANCEL:
       case self::TYPE_ALL_DAY:
@@ -72,7 +69,6 @@ final class PhabricatorCalendarEventTransaction
       case self::TYPE_NAME:
       case self::TYPE_START_DATE:
       case self::TYPE_END_DATE:
-      case self::TYPE_STATUS:
       case self::TYPE_DESCRIPTION:
       case self::TYPE_ALL_DAY:
       case self::TYPE_CANCEL:
@@ -120,14 +116,6 @@ final class PhabricatorCalendarEventTransaction
             $this->renderHandleLink($author_phid));
         }
         break;
-      case self::TYPE_STATUS:
-        $old_name = PhabricatorCalendarEvent::getNameForStatus($old);
-        $new_name = PhabricatorCalendarEvent::getNameForStatus($new);
-        return pht(
-          '%s updated the event status from %s to %s.',
-          $this->renderHandleLink($author_phid),
-          $old_name,
-          $new_name);
       case self::TYPE_DESCRIPTION:
         return pht(
           "%s updated the event's description.",
@@ -287,15 +275,6 @@ final class PhabricatorCalendarEventTransaction
             $new);
         }
         break;
-      case self::TYPE_STATUS:
-        $old_name = PhabricatorCalendarEvent::getNameForStatus($old);
-        $new_name = PhabricatorCalendarEvent::getNameForStatus($new);
-        return pht(
-          '%s updated the status of %s from %s to %s.',
-          $this->renderHandleLink($author_phid),
-          $this->renderHandleLink($object_phid),
-          $old_name,
-          $new_name);
       case self::TYPE_DESCRIPTION:
         return pht(
           '%s updated the description of %s.',
@@ -430,7 +409,6 @@ final class PhabricatorCalendarEventTransaction
       case self::TYPE_NAME:
       case self::TYPE_START_DATE:
       case self::TYPE_END_DATE:
-      case self::TYPE_STATUS:
       case self::TYPE_DESCRIPTION:
       case self::TYPE_CANCEL:
       case self::TYPE_INVITE:
@@ -469,7 +447,6 @@ final class PhabricatorCalendarEventTransaction
     $tags = array();
     switch ($this->getTransactionType()) {
       case self::TYPE_NAME:
-      case self::TYPE_STATUS:
       case self::TYPE_DESCRIPTION:
       case self::TYPE_INVITE:
         $tags[] = self::MAILTAG_CONTENT;
diff --git a/src/applications/conpherence/controller/ConpherenceWidgetController.php b/src/applications/conpherence/controller/ConpherenceWidgetController.php
index 9a06f0dcf9..01a36f6ea1 100644
--- a/src/applications/conpherence/controller/ConpherenceWidgetController.php
+++ b/src/applications/conpherence/controller/ConpherenceWidgetController.php
@@ -218,7 +218,11 @@ final class ConpherenceWidgetController extends ConpherenceController {
     $conpherence = $this->getConpherence();
     $participants = $conpherence->getParticipants();
     $widget_data = $conpherence->getWidgetData();
-    $statuses = $widget_data['statuses'];
+
+    // TODO: This panel is built around an outdated notion of events and isn't
+    // invitee-aware.
+
+    $statuses = $widget_data['events'];
     $handles = $conpherence->getHandles();
     $content = array();
     $layout = id(new AphrontMultiColumnView())
@@ -312,7 +316,7 @@ final class ConpherenceWidgetController extends ConpherenceController {
             $content[] = phutil_tag(
               'div',
               array(
-                'class' => 'user-status '.$status->getTextStatus().$top_border,
+                'class' => 'user-status '.$top_border,
               ),
               array(
                 phutil_tag(
@@ -327,7 +331,7 @@ final class ConpherenceWidgetController extends ConpherenceController {
                     'class' => 'description',
                   ),
                   array(
-                    $status->getTerseSummary($user),
+                    $status->getName(),
                     phutil_tag(
                       'div',
                       array(
@@ -359,9 +363,7 @@ final class ConpherenceWidgetController extends ConpherenceController {
           if ($status) {
             $inner_layout[] = phutil_tag(
               'div',
-              array(
-                'class' => $status->getTextStatus(),
-              ),
+              array(),
               '');
           } else {
             $inner_layout[] = phutil_tag(
diff --git a/src/applications/conpherence/query/ConpherenceThreadQuery.php b/src/applications/conpherence/query/ConpherenceThreadQuery.php
index b17044ead0..1b311516f8 100644
--- a/src/applications/conpherence/query/ConpherenceThreadQuery.php
+++ b/src/applications/conpherence/query/ConpherenceThreadQuery.php
@@ -354,13 +354,25 @@ final class ConpherenceThreadQuery
       $this->getViewer());
     $start_epoch = $epochs['start_epoch'];
     $end_epoch = $epochs['end_epoch'];
-    $statuses = id(new PhabricatorCalendarEventQuery())
-      ->setViewer($this->getViewer())
-      ->withInvitedPHIDs($participant_phids)
-      ->withDateRange($start_epoch, $end_epoch)
-      ->execute();
 
-    $statuses = mgroup($statuses, 'getUserPHID');
+    if ($participant_phids) {
+      $events = id(new PhabricatorCalendarEventQuery())
+        ->setViewer($this->getViewer())
+        ->withInvitedPHIDs($participant_phids)
+        ->withIsCancelled(false)
+        ->withDateRange($start_epoch, $end_epoch)
+        ->execute();
+      $events = mpull($events, null, 'getPHID');
+    } else {
+      $events = null;
+    }
+
+    $invitees = array();
+    foreach ($events as $event_phid => $event) {
+      foreach ($event->getInvitees() as $invitee) {
+        $invitees[$invitee->getInviteePHID()][$event_phid] = true;
+      }
+    }
 
     // attached files
     $files = array();
@@ -382,9 +394,16 @@ final class ConpherenceThreadQuery
 
     foreach ($conpherences as $phid => $conpherence) {
       $participant_phids = array_keys($conpherence->getParticipants());
-      $statuses = array_select_keys($statuses, $participant_phids);
-      $statuses = array_mergev($statuses);
-      $statuses = msort($statuses, 'getDateFrom');
+      $widget_data = array();
+
+      $event_phids = array();
+      $participant_invites = array_select_keys($invitees, $participant_phids);
+      foreach ($participant_invites as $invite_set) {
+        $event_phids += $invite_set;
+      }
+      $thread_events = array_select_keys($events, array_keys($event_phids));
+      $thread_events = msort($thread_events, 'getDateFrom');
+      $widget_data['events'] = $thread_events;
 
       $conpherence_files = array();
       $files_authors = array();
@@ -404,11 +423,11 @@ final class ConpherenceThreadQuery
         }
         $files_authors[$curr_phid] = $current_author;
       }
-      $widget_data = array(
-        'statuses' => $statuses,
+      $widget_data += array(
         'files' => $conpherence_files,
         'files_authors' => $files_authors,
       );
+
       $conpherence->attachWidgetData($widget_data);
     }
 
diff --git a/src/applications/people/conduit/UserAddStatusConduitAPIMethod.php b/src/applications/people/conduit/UserAddStatusConduitAPIMethod.php
deleted file mode 100644
index 39403d9503..0000000000
--- a/src/applications/people/conduit/UserAddStatusConduitAPIMethod.php
+++ /dev/null
@@ -1,62 +0,0 @@
-<?php
-
-final class UserAddStatusConduitAPIMethod extends UserConduitAPIMethod {
-
-  public function getAPIMethodName() {
-    return 'user.addstatus';
-  }
-
-  public function getMethodStatus() {
-    return self::METHOD_STATUS_DEPRECATED;
-  }
-
-  public function getMethodDescription() {
-    return pht('Add status information to the logged-in user.');
-  }
-
-  public function getMethodStatusDescription() {
-    return pht(
-      'Statuses are becoming full-fledged events as part of the '.
-      'Calendar application.');
-  }
-
-  protected function defineParamTypes() {
-    $status_const = $this->formatStringConstants(array('away', 'sporadic'));
-
-    return array(
-      'fromEpoch'   => 'required int',
-      'toEpoch'     => 'required int',
-      'status'      => 'required '.$status_const,
-      'description' => 'optional string',
-    );
-  }
-
-  protected function defineReturnType() {
-    return 'void';
-  }
-
-  protected function defineErrorTypes() {
-    return array(
-      'ERR-BAD-EPOCH' => "'toEpoch' must be bigger than 'fromEpoch'.",
-      'ERR-OVERLAP'   =>
-        'There must be no status in any part of the specified epoch.',
-    );
-  }
-
-  protected function execute(ConduitAPIRequest $request) {
-    $user_phid   = $request->getUser()->getPHID();
-    $from        = $request->getValue('fromEpoch');
-    $to          = $request->getValue('toEpoch');
-    $status      = $request->getValue('status');
-    $description = $request->getValue('description', '');
-
-    id(new PhabricatorCalendarEvent())
-      ->setUserPHID($user_phid)
-      ->setDateFrom($from)
-      ->setDateTo($to)
-      ->setTextStatus($status)
-      ->setDescription($description)
-      ->save();
-  }
-
-}
diff --git a/src/applications/people/conduit/UserRemoveStatusConduitAPIMethod.php b/src/applications/people/conduit/UserRemoveStatusConduitAPIMethod.php
deleted file mode 100644
index 9cb83db1c1..0000000000
--- a/src/applications/people/conduit/UserRemoveStatusConduitAPIMethod.php
+++ /dev/null
@@ -1,85 +0,0 @@
-<?php
-
-final class UserRemoveStatusConduitAPIMethod extends UserConduitAPIMethod {
-
-  public function getAPIMethodName() {
-    return 'user.removestatus';
-  }
-
-  public function getMethodStatus() {
-    return self::METHOD_STATUS_DEPRECATED;
-  }
-
-  public function getMethodDescription() {
-    return pht('Delete status information of the logged-in user.');
-  }
-
-  public function getMethodStatusDescription() {
-    return pht(
-      'Statuses are becoming full-fledged events as part of the '.
-      'Calendar application.');
-  }
-
-  protected function defineParamTypes() {
-    return array(
-      'fromEpoch' => 'required int',
-      'toEpoch' => 'required int',
-    );
-  }
-
-  protected function defineReturnType() {
-    return 'int';
-  }
-
-  protected function defineErrorTypes() {
-    return array(
-      'ERR-BAD-EPOCH' => "'toEpoch' must be bigger than 'fromEpoch'.",
-    );
-  }
-
-  protected function execute(ConduitAPIRequest $request) {
-    $user_phid = $request->getUser()->getPHID();
-    $from = $request->getValue('fromEpoch');
-    $to = $request->getValue('toEpoch');
-
-    if ($to <= $from) {
-      throw new ConduitException('ERR-BAD-EPOCH');
-    }
-
-    $table = new PhabricatorCalendarEvent();
-    $table->openTransaction();
-    $table->beginReadLocking();
-
-    $overlap = $table->loadAllWhere(
-      'userPHID = %s AND dateFrom < %d AND dateTo > %d',
-      $user_phid,
-      $to,
-      $from);
-    foreach ($overlap as $status) {
-      if ($status->getDateFrom() < $from) {
-        if ($status->getDateTo() > $to) {
-          // Split the interval.
-          id(new PhabricatorCalendarEvent())
-            ->setUserPHID($user_phid)
-            ->setDateFrom($to)
-            ->setDateTo($status->getDateTo())
-            ->setStatus($status->getStatus())
-            ->setDescription($status->getDescription())
-            ->save();
-        }
-        $status->setDateTo($from);
-        $status->save();
-      } else if ($status->getDateTo() > $to) {
-        $status->setDateFrom($to);
-        $status->save();
-      } else {
-        $status->delete();
-      }
-    }
-
-    $table->endReadLocking();
-    $table->saveTransaction();
-    return count($overlap);
-  }
-
-}

From 87bf532c4146f7bd8c51a73712290f370993616d Mon Sep 17 00:00:00 2001
From: lkassianik <lyubakassianik@gmail.com>
Date: Thu, 14 May 2015 12:35:34 -0700
Subject: [PATCH 07/86] Calendar tooltips should always show start and end time
 of events.

Summary: Closes T8191, Calendar tooltips should always show start and end time of events.

Test Plan: Open month view, hover over, All day events, multi-day all day events, multi-day non-all-day events, and regular events. Tooltips should be "All day", "All day, <start> - <end>", "<start>-<end>", and "<start>-<end>", respectively.

Reviewers: epriestley, #blessed_reviewers, chad

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T8191

Differential Revision: https://secure.phabricator.com/D12846
---
 resources/celerity/map.php                    |  4 +--
 .../control/AphrontFormDateControlValue.php   |  7 ++++
 .../phui/calendar/PHUICalendarListView.php    | 34 ++++++++++++++++---
 .../css/phui/calendar/phui-calendar-month.css |  4 ---
 4 files changed, 38 insertions(+), 11 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 36b773434a..2c92f74300 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -122,7 +122,7 @@ return array(
     'rsrc/css/layout/phabricator-source-code-view.css' => '2ceee894',
     'rsrc/css/phui/calendar/phui-calendar-day.css' => '38891735',
     'rsrc/css/phui/calendar/phui-calendar-list.css' => 'c1d0ca59',
-    'rsrc/css/phui/calendar/phui-calendar-month.css' => '75e6a2ee',
+    'rsrc/css/phui/calendar/phui-calendar-month.css' => 'e7ee38c6',
     'rsrc/css/phui/calendar/phui-calendar.css' => '8675968e',
     'rsrc/css/phui/phui-action-header-view.css' => '89c497e7',
     'rsrc/css/phui/phui-action-list.css' => '4f4d09f2',
@@ -763,7 +763,7 @@ return array(
     'phui-calendar-css' => '8675968e',
     'phui-calendar-day-css' => '38891735',
     'phui-calendar-list-css' => 'c1d0ca59',
-    'phui-calendar-month-css' => '75e6a2ee',
+    'phui-calendar-month-css' => 'e7ee38c6',
     'phui-crumbs-view-css' => '594d719e',
     'phui-document-view-css' => '94d5dcd8',
     'phui-feed-story-css' => 'c9f3a0b5',
diff --git a/src/view/form/control/AphrontFormDateControlValue.php b/src/view/form/control/AphrontFormDateControlValue.php
index 58a7b754b1..3fb6a07fb4 100644
--- a/src/view/form/control/AphrontFormDateControlValue.php
+++ b/src/view/form/control/AphrontFormDateControlValue.php
@@ -157,6 +157,13 @@ final class AphrontFormDateControlValue extends Phobject {
     );
   }
 
+  public function getValueAsFormat($format) {
+    return phabricator_format_local_time(
+      $this->getEpoch(),
+      $this->viewer,
+      $format);
+  }
+
   private function formatTime($epoch, $format) {
     return phabricator_format_local_time(
       $epoch,
diff --git a/src/view/phui/calendar/PHUICalendarListView.php b/src/view/phui/calendar/PHUICalendarListView.php
index fc40d87745..c2d33b8469 100644
--- a/src/view/phui/calendar/PHUICalendarListView.php
+++ b/src/view/phui/calendar/PHUICalendarListView.php
@@ -105,12 +105,36 @@ final class PHUICalendarListView extends AphrontTagView {
 
     Javelin::initBehavior('phabricator-tooltips');
 
-    if ($event->getMultiDay()) {
-      $tip = pht('%s, Until: %s', $event->getName(),
-        phabricator_date($event->getEpochEnd(), $this->getUser()));
+    $start = id(AphrontFormDateControlValue::newFromEpoch(
+      $this->getUser(),
+      $event->getEpochStart()));
+    $end = id(AphrontFormDateControlValue::newFromEpoch(
+      $this->getUser(),
+      $event->getEpochEnd()));
+
+    if ($event->getIsAllDay()) {
+      if ($start->getValueDay() == $end->getValueDay()) {
+        $tip = pht('All day');
+      } else {
+        $tip = pht(
+          'All day, %s - %s',
+          $start->getValueAsFormat('M j, Y'),
+          $end->getValueAsFormat('M j, Y'));
+      }
     } else {
-      $tip = pht('%s, Until: %s', $event->getName(),
-        phabricator_time($event->getEpochEnd(), $this->getUser()));
+      if ($start->getValueDay() == $end->getValueDay() &&
+        $start->getValueMonth() == $end->getValueMonth() &&
+        $start->getValueYear() == $end->getValueYear()) {
+        $tip = pht(
+          '%s - %s',
+          $start->getValueAsFormat('g:i A'),
+          $end->getValueAsFormat('g:i A'));
+      } else {
+        $tip = pht(
+          '%s - %s',
+          $start->getValueAsFormat('M j, Y, g:i A'),
+          $end->getValueAsFormat('M j, Y, g:i A'));
+      }
     }
 
     $description = $event->getDescription();
diff --git a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
index 3f53e89b25..284937f1a9 100644
--- a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
+++ b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
@@ -88,10 +88,6 @@ table.phui-calendar-view td.phui-calendar-date-number-container {
   text-align: right;
 }
 
-.phui-calendar-not-work-day {
-  background-color: {$lightgreybackground};
-}
-
 .phui-calendar-today-slot {
   display: block;
   width: 100%;

From 0228cdb7e2122d962c27c3b16d6d928b1c5becd3 Mon Sep 17 00:00:00 2001
From: lkassianik <lyubakassianik@gmail.com>
Date: Thu, 14 May 2015 13:02:19 -0700
Subject: [PATCH 08/86] Day min-height on mobile month calendar should be
 shorter.

Summary: Closes T8190, Day min-height on mobile month calendar should be shorter.

Test Plan: Mobile view of month view should fit on a mobile screen.

Reviewers: chad, #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8190

Differential Revision: https://secure.phabricator.com/D12847
---
 resources/celerity/map.php                             | 4 ++--
 webroot/rsrc/css/phui/calendar/phui-calendar-month.css | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 2c92f74300..27c94b3b30 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -122,7 +122,7 @@ return array(
     'rsrc/css/layout/phabricator-source-code-view.css' => '2ceee894',
     'rsrc/css/phui/calendar/phui-calendar-day.css' => '38891735',
     'rsrc/css/phui/calendar/phui-calendar-list.css' => 'c1d0ca59',
-    'rsrc/css/phui/calendar/phui-calendar-month.css' => 'e7ee38c6',
+    'rsrc/css/phui/calendar/phui-calendar-month.css' => '3150cfbf',
     'rsrc/css/phui/calendar/phui-calendar.css' => '8675968e',
     'rsrc/css/phui/phui-action-header-view.css' => '89c497e7',
     'rsrc/css/phui/phui-action-list.css' => '4f4d09f2',
@@ -763,7 +763,7 @@ return array(
     'phui-calendar-css' => '8675968e',
     'phui-calendar-day-css' => '38891735',
     'phui-calendar-list-css' => 'c1d0ca59',
-    'phui-calendar-month-css' => 'e7ee38c6',
+    'phui-calendar-month-css' => '3150cfbf',
     'phui-crumbs-view-css' => '594d719e',
     'phui-document-view-css' => '94d5dcd8',
     'phui-feed-story-css' => 'c9f3a0b5',
diff --git a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
index 284937f1a9..a231b452a2 100644
--- a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
+++ b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
@@ -31,7 +31,7 @@ table.phui-calendar-view td {
 }
 
 .device .phui-calendar-month-event-list .phui-calendar-month-cell-div {
-  min-height: 60px;
+  min-height: 32px;
 }
 
 a.phui-calendar-month-secret-link {
@@ -58,7 +58,7 @@ table.phui-calendar-view tr td:first-child {
 .device .phui-calendar-month-event-count {
   display: block;
   text-align: center;
-  padding-top: 12px;
+  padding-top: 8px;
 }
 
 .phui-calendar-month-event-count .phui-calendar-month-count-badge {
@@ -69,7 +69,7 @@ table.phui-calendar-view tr td:first-child {
   border-radius: 50%;
   text-align: center;
   vertical-align: middle;
-  padding: 5px 3px 0px 3px;
+  padding: 4px 2px 0px 2px;
   margin: 0 auto;
 }
 

From b34d5bf44ba96b7b11d7a72e1056a979406b3e93 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 14 May 2015 13:04:44 -0700
Subject: [PATCH 09/86] Strip GMail French quote header

Summary: Ref T8199. Add pattern matching for GMail French.

Test Plan:
  - Switched Gmail to french.
  - Replied to some mail.
  - Extracted quoted text header.
  - Added and executed unit test.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: tycho.tatitscheff, epriestley

Maniphest Tasks: T8199

Differential Revision: https://secure.phabricator.com/D12845
---
 .../metamta/parser/PhabricatorMetaMTAEmailBodyParser.php   | 6 ++++++
 .../PhabricatorMetaMTAEmailBodyParserTestCase.php          | 7 +++++++
 2 files changed, 13 insertions(+)

diff --git a/src/applications/metamta/parser/PhabricatorMetaMTAEmailBodyParser.php b/src/applications/metamta/parser/PhabricatorMetaMTAEmailBodyParser.php
index 5138c1a2bd..07770600e6 100644
--- a/src/applications/metamta/parser/PhabricatorMetaMTAEmailBodyParser.php
+++ b/src/applications/metamta/parser/PhabricatorMetaMTAEmailBodyParser.php
@@ -123,6 +123,12 @@ final class PhabricatorMetaMTAEmailBodyParser {
       '',
       $body);
 
+    // French GMail quoted text. See T8199.
+    $body = preg_replace(
+      '/^\s*\d{4}-\d{2}-\d{2} \d+:\d+ GMT.*:.*?/imsU',
+      '',
+      $body);
+
     return rtrim($body);
   }
 
diff --git a/src/applications/metamta/parser/__tests__/PhabricatorMetaMTAEmailBodyParserTestCase.php b/src/applications/metamta/parser/__tests__/PhabricatorMetaMTAEmailBodyParserTestCase.php
index 6a124e30f4..d8ad49956d 100644
--- a/src/applications/metamta/parser/__tests__/PhabricatorMetaMTAEmailBodyParserTestCase.php
+++ b/src/applications/metamta/parser/__tests__/PhabricatorMetaMTAEmailBodyParserTestCase.php
@@ -253,6 +253,13 @@ OKAY
 
 {$emdash}
 Sent from Mailbox
+EOMAIL
+,
+<<<EOMAIL
+OKAY
+
+2015-05-06 11:21 GMT-07:00 Someone <someone@somewhere.com>:
+> ...
 EOMAIL
     );
   }

From 705c1e6498725c19d9817b3450e644023dbbe126 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 14 May 2015 16:48:45 -0700
Subject: [PATCH 10/86] Fix an issue with user.whoami

Summary:
Both user.whoami and user.query call the same wire formatting code, but expect different data.

Don't try to add availability data to user.whoami.

Stop adding email data to user.query. We've added it since D11791, but my intent was for it to be exposed //only// via user.whoami (i.e., expose your address, not others').

Test Plan:
  - Called both methods.
  - Saw emails on user.whoami.
  - Saw availability on user.query.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D12848
---
 .../people/conduit/UserConduitAPIMethod.php   | 24 ++++++++++++-------
 .../conduit/UserQueryConduitAPIMethod.php     |  5 +++-
 .../conduit/UserWhoAmIConduitAPIMethod.php    |  5 +++-
 3 files changed, 24 insertions(+), 10 deletions(-)

diff --git a/src/applications/people/conduit/UserConduitAPIMethod.php b/src/applications/people/conduit/UserConduitAPIMethod.php
index 82da171f43..187e28b9b3 100644
--- a/src/applications/people/conduit/UserConduitAPIMethod.php
+++ b/src/applications/people/conduit/UserConduitAPIMethod.php
@@ -6,7 +6,10 @@ abstract class UserConduitAPIMethod extends ConduitAPIMethod {
     return PhabricatorApplication::getByClass('PhabricatorPeopleApplication');
   }
 
-  protected function buildUserInformationDictionary(PhabricatorUser $user) {
+  protected function buildUserInformationDictionary(
+    PhabricatorUser $user,
+    $with_email = false,
+    $with_availability = false) {
 
     $roles = array();
     if ($user->getIsDisabled()) {
@@ -40,18 +43,23 @@ abstract class UserConduitAPIMethod extends ConduitAPIMethod {
       'phid'         => $user->getPHID(),
       'userName'     => $user->getUserName(),
       'realName'     => $user->getRealName(),
-      'primaryEmail' => $email,
       'image'        => $user->getProfileImageURI(),
       'uri'          => PhabricatorEnv::getURI('/p/'.$user->getUsername().'/'),
       'roles'        => $roles,
     );
 
-    // TODO: Modernize this once we have a more long-term view of what the
-    // data looks like.
-    $until = $user->getAwayUntil();
-    if ($until) {
-      $return['currentStatus'] = 'away';
-      $return['currentStatusUntil'] = $until;
+    if ($with_email) {
+      $return['primaryEmail'] = $email;
+    }
+
+    if ($with_availability) {
+      // TODO: Modernize this once we have a more long-term view of what the
+      // data looks like.
+      $until = $user->getAwayUntil();
+      if ($until) {
+        $return['currentStatus'] = 'away';
+        $return['currentStatusUntil'] = $until;
+      }
     }
 
     return $return;
diff --git a/src/applications/people/conduit/UserQueryConduitAPIMethod.php b/src/applications/people/conduit/UserQueryConduitAPIMethod.php
index c480ae0c73..4a567a0158 100644
--- a/src/applications/people/conduit/UserQueryConduitAPIMethod.php
+++ b/src/applications/people/conduit/UserQueryConduitAPIMethod.php
@@ -71,7 +71,10 @@ final class UserQueryConduitAPIMethod extends UserConduitAPIMethod {
 
     $results = array();
     foreach ($users as $user) {
-      $results[] = $this->buildUserInformationDictionary($user);
+      $results[] = $this->buildUserInformationDictionary(
+        $user,
+        $with_email = false,
+        $with_availability = true);
     }
     return $results;
   }
diff --git a/src/applications/people/conduit/UserWhoAmIConduitAPIMethod.php b/src/applications/people/conduit/UserWhoAmIConduitAPIMethod.php
index aa7e3e7f26..b646246c5d 100644
--- a/src/applications/people/conduit/UserWhoAmIConduitAPIMethod.php
+++ b/src/applications/people/conduit/UserWhoAmIConduitAPIMethod.php
@@ -29,7 +29,10 @@ final class UserWhoAmIConduitAPIMethod extends UserConduitAPIMethod {
       ->withPHIDs(array($request->getUser()->getPHID()))
       ->executeOne();
 
-    return $this->buildUserInformationDictionary($person);
+    return $this->buildUserInformationDictionary(
+      $person,
+      $with_email = true,
+      $with_availability = false);
   }
 
 }

From f16dda288d0cfb2214ec710270944d26c13fc03f Mon Sep 17 00:00:00 2001
From: Bob Trahan <btrahan@phacility.com>
Date: Thu, 14 May 2015 17:05:58 -0700
Subject: [PATCH 11/86] Phame - move over blog create + edit to transactions +
 editor

Summary: Ref T7626. Modernizes the code a bit here so we can eventually make progress on T7626 and other stuff.

Test Plan: made a blog, edited a blog, made errors - stuff looked good

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7626

Differential Revision: https://secure.phabricator.com/D12849
---
 .../20150514.phame.blog.xaction.sql           |  19 ++
 src/__phutil_library_map__.php                |   4 +
 .../blog/PhameBlogDeleteController.php        |  12 +-
 .../blog/PhameBlogEditController.php          | 141 +++++++------
 .../blog/PhameBlogFeedController.php          |  12 +-
 .../blog/PhameBlogListController.php          |  12 +-
 .../blog/PhameBlogLiveController.php          |  17 +-
 .../blog/PhameBlogViewController.php          |  12 +-
 .../phame/editor/PhameBlogEditor.php          | 189 ++++++++++++++++++
 src/applications/phame/storage/PhameBlog.php  |  28 +--
 .../phame/storage/PhameBlogTransaction.php    | 174 ++++++++++++++++
 11 files changed, 481 insertions(+), 139 deletions(-)
 create mode 100644 resources/sql/autopatches/20150514.phame.blog.xaction.sql
 create mode 100644 src/applications/phame/editor/PhameBlogEditor.php
 create mode 100644 src/applications/phame/storage/PhameBlogTransaction.php

diff --git a/resources/sql/autopatches/20150514.phame.blog.xaction.sql b/resources/sql/autopatches/20150514.phame.blog.xaction.sql
new file mode 100644
index 0000000000..7d85c98082
--- /dev/null
+++ b/resources/sql/autopatches/20150514.phame.blog.xaction.sql
@@ -0,0 +1,19 @@
+CREATE TABLE {$NAMESPACE}_phame.phame_blogtransaction (
+  id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY,
+  phid VARBINARY(64) NOT NULL,
+  authorPHID VARBINARY(64) NOT NULL,
+  objectPHID VARBINARY(64) NOT NULL,
+  viewPolicy VARBINARY(64) NOT NULL,
+  editPolicy VARBINARY(64) NOT NULL,
+  commentPHID VARBINARY(64) DEFAULT NULL,
+  commentVersion INT UNSIGNED NOT NULL,
+  transactionType VARCHAR(32) COLLATE {$COLLATE_TEXT} NOT NULL,
+  oldValue LONGTEXT COLLATE {$COLLATE_TEXT} NOT NULL,
+  newValue LONGTEXT COLLATE {$COLLATE_TEXT} NOT NULL,
+  contentSource LONGTEXT COLLATE {$COLLATE_TEXT} NOT NULL,
+  metadata LONGTEXT COLLATE {$COLLATE_TEXT} NOT NULL,
+  dateCreated INT UNSIGNED NOT NULL,
+  dateModified INT UNSIGNED NOT NULL,
+  UNIQUE KEY `key_phid` (`phid`),
+  KEY `key_object` (`objectPHID`)
+) ENGINE=InnoDB, COLLATE {$COLLATE_TEXT};
diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index 903aaf8a44..f574caf682 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -2775,11 +2775,13 @@ phutil_register_library_map(array(
     'PhameBlog' => 'applications/phame/storage/PhameBlog.php',
     'PhameBlogDeleteController' => 'applications/phame/controller/blog/PhameBlogDeleteController.php',
     'PhameBlogEditController' => 'applications/phame/controller/blog/PhameBlogEditController.php',
+    'PhameBlogEditor' => 'applications/phame/editor/PhameBlogEditor.php',
     'PhameBlogFeedController' => 'applications/phame/controller/blog/PhameBlogFeedController.php',
     'PhameBlogListController' => 'applications/phame/controller/blog/PhameBlogListController.php',
     'PhameBlogLiveController' => 'applications/phame/controller/blog/PhameBlogLiveController.php',
     'PhameBlogQuery' => 'applications/phame/query/PhameBlogQuery.php',
     'PhameBlogSkin' => 'applications/phame/skins/PhameBlogSkin.php',
+    'PhameBlogTransaction' => 'applications/phame/storage/PhameBlogTransaction.php',
     'PhameBlogViewController' => 'applications/phame/controller/blog/PhameBlogViewController.php',
     'PhameCelerityResources' => 'applications/phame/celerity/PhameCelerityResources.php',
     'PhameConduitAPIMethod' => 'applications/phame/conduit/PhameConduitAPIMethod.php',
@@ -6250,11 +6252,13 @@ phutil_register_library_map(array(
     ),
     'PhameBlogDeleteController' => 'PhameController',
     'PhameBlogEditController' => 'PhameController',
+    'PhameBlogEditor' => 'PhabricatorApplicationTransactionEditor',
     'PhameBlogFeedController' => 'PhameController',
     'PhameBlogListController' => 'PhameController',
     'PhameBlogLiveController' => 'PhameController',
     'PhameBlogQuery' => 'PhabricatorCursorPagedPolicyAwareQuery',
     'PhameBlogSkin' => 'PhabricatorController',
+    'PhameBlogTransaction' => 'PhabricatorApplicationTransaction',
     'PhameBlogViewController' => 'PhameController',
     'PhameCelerityResources' => 'CelerityResources',
     'PhameConduitAPIMethod' => 'ConduitAPIMethod',
diff --git a/src/applications/phame/controller/blog/PhameBlogDeleteController.php b/src/applications/phame/controller/blog/PhameBlogDeleteController.php
index 82770b2877..33282582ae 100644
--- a/src/applications/phame/controller/blog/PhameBlogDeleteController.php
+++ b/src/applications/phame/controller/blog/PhameBlogDeleteController.php
@@ -2,19 +2,13 @@
 
 final class PhameBlogDeleteController extends PhameController {
 
-  private $id;
-
-  public function willProcessRequest(array $data) {
-    $this->id = $data['id'];
-  }
-
-  public function processRequest() {
-    $request = $this->getRequest();
+  public function handleRequest(AphrontRequest $request) {
     $user = $request->getUser();
+    $id = $request->getURIData('id');
 
     $blog = id(new PhameBlogQuery())
       ->setViewer($user)
-      ->withIDs(array($this->id))
+      ->withIDs(array($id))
       ->requireCapabilities(
         array(
           PhabricatorPolicyCapability::CAN_EDIT,
diff --git a/src/applications/phame/controller/blog/PhameBlogEditController.php b/src/applications/phame/controller/blog/PhameBlogEditController.php
index 1363cf8343..8b1b3b81e1 100644
--- a/src/applications/phame/controller/blog/PhameBlogEditController.php
+++ b/src/applications/phame/controller/blog/PhameBlogEditController.php
@@ -3,20 +3,14 @@
 final class PhameBlogEditController
   extends PhameController {
 
-  private $id;
-
-  public function willProcessRequest(array $data) {
-    $this->id = idx($data, 'id');
-  }
-
-  public function processRequest() {
-    $request = $this->getRequest();
+  public function handleRequest(AphrontRequest $request) {
     $user = $request->getUser();
 
-    if ($this->id) {
+    $id = $request->getURIData('id');
+    if ($id) {
       $blog = id(new PhameBlogQuery())
         ->setViewer($user)
-        ->withIDs(array($this->id))
+        ->withIDs(array($id))
         ->requireCapabilities(
           array(
             PhabricatorPolicyCapability::CAN_EDIT,
@@ -30,76 +24,75 @@ final class PhameBlogEditController
       $page_title = pht('Edit Blog');
       $cancel_uri = $this->getApplicationURI('blog/view/'.$blog->getID().'/');
     } else {
-      $blog = id(new PhameBlog())
-        ->setCreatorPHID($user->getPHID());
-
-      $blog->setViewPolicy(PhabricatorPolicies::POLICY_USER);
-      $blog->setEditPolicy(PhabricatorPolicies::POLICY_USER);
-      $blog->setJoinPolicy(PhabricatorPolicies::POLICY_USER);
+      $blog = PhameBlog::initializeNewBlog($user);
 
       $submit_button = pht('Create Blog');
       $page_title = pht('Create Blog');
       $cancel_uri = $this->getApplicationURI();
     }
+    $name          = $blog->getName();
+    $description   = $blog->getDescription();
+    $custom_domain = $blog->getDomain();
+    $skin          = $blog->getSkin();
+    $can_view      = $blog->getViewPolicy();
+    $can_edit      = $blog->getEditPolicy();
+    $can_join      = $blog->getJoinPolicy();
 
-    $e_name          = true;
-    $e_custom_domain = null;
-    $errors          = array();
-
+    $e_name               = true;
+    $e_custom_domain      = null;
+    $e_view_policy        = null;
+    $validation_exception = null;
     if ($request->isFormPost()) {
       $name          = $request->getStr('name');
       $description   = $request->getStr('description');
-      $custom_domain = $request->getStr('custom_domain');
+      $custom_domain = nonempty($request->getStr('custom_domain'), null);
       $skin          = $request->getStr('skin');
+      $can_view      = $request->getStr('can_view');
+      $can_edit      = $request->getStr('can_edit');
+      $can_join      = $request->getStr('can_join');
 
-      if (empty($name)) {
-        $errors[] = pht('You must give the blog a name.');
-        $e_name = pht('Required');
-      } else {
-        $e_name = null;
-      }
+      $xactions = array(
+        id(new PhameBlogTransaction())
+          ->setTransactionType(PhameBlogTransaction::TYPE_NAME)
+          ->setNewValue($name),
+        id(new PhameBlogTransaction())
+          ->setTransactionType(PhameBlogTransaction::TYPE_DESCRIPTION)
+          ->setNewValue($description),
+        id(new PhameBlogTransaction())
+          ->setTransactionType(PhameBlogTransaction::TYPE_DOMAIN)
+          ->setNewValue($custom_domain),
+        id(new PhameBlogTransaction())
+          ->setTransactionType(PhameBlogTransaction::TYPE_SKIN)
+          ->setNewValue($skin),
+        id(new PhameBlogTransaction())
+          ->setTransactionType(PhabricatorTransactions::TYPE_VIEW_POLICY)
+          ->setNewValue($can_view),
+        id(new PhameBlogTransaction())
+          ->setTransactionType(PhabricatorTransactions::TYPE_EDIT_POLICY)
+          ->setNewValue($can_edit),
+        id(new PhameBlogTransaction())
+          ->setTransactionType(PhabricatorTransactions::TYPE_JOIN_POLICY)
+          ->setNewValue($can_join),
+      );
 
-      $blog->setName($name);
-      $blog->setDescription($description);
-      $blog->setDomain(nonempty($custom_domain, null));
-      $blog->setSkin($skin);
-      $blog->setViewPolicy($request->getStr('can_view'));
-      $blog->setEditPolicy($request->getStr('can_edit'));
-      $blog->setJoinPolicy($request->getStr('can_join'));
+      $editor = id(new PhameBlogEditor())
+        ->setActor($user)
+        ->setContentSourceFromRequest($request)
+        ->setContinueOnNoEffect(true);
 
-      if (!empty($custom_domain)) {
-        list($error_label, $error_text) =
-          $blog->validateCustomDomain($custom_domain);
-        if ($error_label) {
-          $errors[] = $error_text;
-          $e_custom_domain = $error_label;
-        }
-        if ($blog->getViewPolicy() != PhabricatorPolicies::POLICY_PUBLIC) {
-          $errors[] = pht(
-            'For custom domains to work, the blog must have a view policy of '.
-            'public.');
-          // Prefer earlier labels for the multiple error scenario.
-          if (!$e_custom_domain) {
-            $e_custom_domain = pht('Invalid Policy');
-          }
-        }
-      }
+      try {
+        $editor->applyTransactions($blog, $xactions);
+        return id(new AphrontRedirectResponse())
+          ->setURI($this->getApplicationURI('blog/view/'.$blog->getID().'/'));
+      } catch (PhabricatorApplicationTransactionValidationException $ex) {
+        $validation_exception = $ex;
 
-      // Don't let users remove their ability to edit blogs.
-      PhabricatorPolicyFilter::mustRetainCapability(
-        $user,
-        $blog,
-        PhabricatorPolicyCapability::CAN_EDIT);
-
-      if (!$errors) {
-        try {
-          $blog->save();
-          return id(new AphrontRedirectResponse())
-            ->setURI($this->getApplicationURI('blog/view/'.$blog->getID().'/'));
-        } catch (AphrontDuplicateKeyQueryException $ex) {
-          $errors[] = pht('Domain must be unique.');
-          $e_custom_domain = pht('Not Unique');
-        }
+        $e_name = $validation_exception->getShortMessage(
+          PhameBlogTransaction::TYPE_NAME);
+        $e_custom_domain = $validation_exception->getShortMessage(
+          PhameBlogTransaction::TYPE_DOMAIN);
+        $e_view_policy = $validation_exception->getShortMessage(
+          PhabricatorTransactions::TYPE_VIEW_POLICY);
       }
     }
 
@@ -117,7 +110,7 @@ final class PhameBlogEditController
         id(new AphrontFormTextControl())
         ->setLabel(pht('Name'))
         ->setName('name')
-        ->setValue($blog->getName())
+        ->setValue($name)
         ->setID('blog-name')
         ->setError($e_name))
       ->appendChild(
@@ -125,7 +118,7 @@ final class PhameBlogEditController
           ->setUser($user)
           ->setLabel(pht('Description'))
           ->setName('description')
-          ->setValue($blog->getDescription())
+          ->setValue($description)
           ->setID('blog-description')
           ->setUser($user)
           ->setDisableMacros(true))
@@ -135,6 +128,8 @@ final class PhameBlogEditController
           ->setCapability(PhabricatorPolicyCapability::CAN_VIEW)
           ->setPolicyObject($blog)
           ->setPolicies($policies)
+          ->setError($e_view_policy)
+          ->setValue($can_view)
           ->setName('can_view'))
       ->appendChild(
         id(new AphrontFormPolicyControl())
@@ -142,6 +137,7 @@ final class PhameBlogEditController
           ->setCapability(PhabricatorPolicyCapability::CAN_EDIT)
           ->setPolicyObject($blog)
           ->setPolicies($policies)
+          ->setValue($can_edit)
           ->setName('can_edit'))
       ->appendChild(
         id(new AphrontFormPolicyControl())
@@ -149,12 +145,13 @@ final class PhameBlogEditController
           ->setCapability(PhabricatorPolicyCapability::CAN_JOIN)
           ->setPolicyObject($blog)
           ->setPolicies($policies)
+          ->setValue($can_join)
           ->setName('can_join'))
       ->appendChild(
         id(new AphrontFormTextControl())
         ->setLabel(pht('Custom Domain'))
         ->setName('custom_domain')
-        ->setValue($blog->getDomain())
+        ->setValue($custom_domain)
         ->setCaption(
           pht('Must include at least one dot (.), e.g. blog.example.com'))
         ->setError($e_custom_domain))
@@ -162,7 +159,7 @@ final class PhameBlogEditController
         id(new AphrontFormSelectControl())
         ->setLabel(pht('Skin'))
         ->setName('skin')
-        ->setValue($blog->getSkin())
+        ->setValue($skin)
         ->setOptions($skins))
       ->appendChild(
         id(new AphrontFormSubmitControl())
@@ -171,14 +168,14 @@ final class PhameBlogEditController
 
     $form_box = id(new PHUIObjectBoxView())
       ->setHeaderText($page_title)
-      ->setFormErrors($errors)
+      ->setValidationException($validation_exception)
       ->setForm($form);
 
     $crumbs = $this->buildApplicationCrumbs();
     $crumbs->addTextCrumb($page_title, $this->getApplicationURI('blog/new'));
 
     $nav = $this->renderSideNavFilterView();
-    $nav->selectFilter($this->id ? null : 'blog/new');
+    $nav->selectFilter($id ? null : 'blog/new');
     $nav->appendChild(
       array(
         $crumbs,
diff --git a/src/applications/phame/controller/blog/PhameBlogFeedController.php b/src/applications/phame/controller/blog/PhameBlogFeedController.php
index 68b197a17b..fc8c1c48da 100644
--- a/src/applications/phame/controller/blog/PhameBlogFeedController.php
+++ b/src/applications/phame/controller/blog/PhameBlogFeedController.php
@@ -2,23 +2,17 @@
 
 final class PhameBlogFeedController extends PhameController {
 
-  private $id;
-
   public function shouldRequireLogin() {
     return false;
   }
 
-  public function willProcessRequest(array $data) {
-    $this->id = $data['id'];
-  }
-
-  public function processRequest() {
-    $request = $this->getRequest();
+  public function handleRequest(AphrontRequest $request) {
     $user = $request->getUser();
+    $id = $request->getURIData('id');
 
     $blog = id(new PhameBlogQuery())
       ->setViewer($user)
-      ->withIDs(array($this->id))
+      ->withIDs(array($id))
       ->executeOne();
     if (!$blog) {
       return new Aphront404Response();
diff --git a/src/applications/phame/controller/blog/PhameBlogListController.php b/src/applications/phame/controller/blog/PhameBlogListController.php
index 70fc5307a3..f9a4aeb2d9 100644
--- a/src/applications/phame/controller/blog/PhameBlogListController.php
+++ b/src/applications/phame/controller/blog/PhameBlogListController.php
@@ -2,18 +2,12 @@
 
 final class PhameBlogListController extends PhameController {
 
-  private $filter;
-
-  public function willProcessRequest(array $data) {
-    $this->filter = idx($data, 'filter');
-  }
-
-  public function processRequest() {
-    $request = $this->getRequest();
+  public function handleRequest(AphrontRequest $request) {
     $user = $request->getUser();
 
     $nav = $this->renderSideNavFilterView(null);
-    $filter = $nav->selectFilter('blog/'.$this->filter, 'blog/user');
+    $filter = $request->getURIData('filter');
+    $filter = $nav->selectFilter('blog/'.$filter, 'blog/user');
 
     $query = id(new PhameBlogQuery())
       ->setViewer($user);
diff --git a/src/applications/phame/controller/blog/PhameBlogLiveController.php b/src/applications/phame/controller/blog/PhameBlogLiveController.php
index e55b2e0f35..1ac4486183 100644
--- a/src/applications/phame/controller/blog/PhameBlogLiveController.php
+++ b/src/applications/phame/controller/blog/PhameBlogLiveController.php
@@ -2,25 +2,17 @@
 
 final class PhameBlogLiveController extends PhameController {
 
-  private $id;
-  private $more;
-
   public function shouldAllowPublic() {
     return true;
   }
 
-  public function willProcessRequest(array $data) {
-    $this->id = idx($data, 'id');
-    $this->more = idx($data, 'more', '');
-  }
-
-  public function processRequest() {
-    $request = $this->getRequest();
+  public function handleRequest(AphrontRequest $request) {
     $user = $request->getUser();
+    $id = $request->getURIData('id');
 
     $blog = id(new PhameBlogQuery())
       ->setViewer($user)
-      ->withIDs(array($this->id))
+      ->withIDs(array($id))
       ->executeOne();
     if (!$blog) {
       return new Aphront404Response();
@@ -55,7 +47,8 @@ final class PhameBlogLiveController extends PhameController {
     }
 
     $phame_request = clone $request;
-    $phame_request->setPath('/'.ltrim($this->more, '/'));
+    $more = $phame_request->getURIData('more', '');
+    $phame_request->setPath('/'.ltrim($more, '/'));
 
     $uri = $blog->getLiveURI();
 
diff --git a/src/applications/phame/controller/blog/PhameBlogViewController.php b/src/applications/phame/controller/blog/PhameBlogViewController.php
index b8399f2513..76491278b5 100644
--- a/src/applications/phame/controller/blog/PhameBlogViewController.php
+++ b/src/applications/phame/controller/blog/PhameBlogViewController.php
@@ -2,19 +2,13 @@
 
 final class PhameBlogViewController extends PhameController {
 
-  private $id;
-
-  public function willProcessRequest(array $data) {
-    $this->id = $data['id'];
-  }
-
-  public function processRequest() {
-    $request = $this->getRequest();
+  public function handleRequest(AphrontRequest $request) {
     $user = $request->getUser();
+    $id = $request->getURIData('id');
 
     $blog = id(new PhameBlogQuery())
       ->setViewer($user)
-      ->withIDs(array($this->id))
+      ->withIDs(array($id))
       ->executeOne();
     if (!$blog) {
       return new Aphront404Response();
diff --git a/src/applications/phame/editor/PhameBlogEditor.php b/src/applications/phame/editor/PhameBlogEditor.php
new file mode 100644
index 0000000000..5b837038b7
--- /dev/null
+++ b/src/applications/phame/editor/PhameBlogEditor.php
@@ -0,0 +1,189 @@
+<?php
+
+final class PhameBlogEditor
+  extends PhabricatorApplicationTransactionEditor {
+
+  public function getEditorApplicationClass() {
+    return 'PhabricatorPhameApplication';
+  }
+
+  public function getEditorObjectsDescription() {
+    return pht('Blogs');
+  }
+
+  public function getTransactionTypes() {
+    $types = parent::getTransactionTypes();
+
+    $types[] = PhameBlogTransaction::TYPE_NAME;
+    $types[] = PhameBlogTransaction::TYPE_DESCRIPTION;
+    $types[] = PhameBlogTransaction::TYPE_DOMAIN;
+    $types[] = PhameBlogTransaction::TYPE_SKIN;
+    $types[] = PhabricatorTransactions::TYPE_VIEW_POLICY;
+    $types[] = PhabricatorTransactions::TYPE_EDIT_POLICY;
+    $types[] = PhabricatorTransactions::TYPE_JOIN_POLICY;
+
+    return $types;
+  }
+
+  protected function getCustomTransactionOldValue(
+    PhabricatorLiskDAO $object,
+    PhabricatorApplicationTransaction $xaction) {
+
+    switch ($xaction->getTransactionType()) {
+      case PhameBlogTransaction::TYPE_NAME:
+        return $object->getName();
+      case PhameBlogTransaction::TYPE_DESCRIPTION:
+        return $object->getDescription();
+      case PhameBlogTransaction::TYPE_DOMAIN:
+        return $object->getDomain();
+      case PhameBlogTransaction::TYPE_SKIN:
+        return $object->getSkin();
+    }
+  }
+
+  protected function getCustomTransactionNewValue(
+    PhabricatorLiskDAO $object,
+    PhabricatorApplicationTransaction $xaction) {
+
+    switch ($xaction->getTransactionType()) {
+      case PhameBlogTransaction::TYPE_NAME:
+      case PhameBlogTransaction::TYPE_DESCRIPTION:
+      case PhameBlogTransaction::TYPE_DOMAIN:
+      case PhameBlogTransaction::TYPE_SKIN:
+        return $xaction->getNewValue();
+    }
+  }
+
+  protected function applyCustomInternalTransaction(
+    PhabricatorLiskDAO $object,
+    PhabricatorApplicationTransaction $xaction) {
+
+    switch ($xaction->getTransactionType()) {
+      case PhameBlogTransaction::TYPE_NAME:
+        return $object->setName($xaction->getNewValue());
+      case PhameBlogTransaction::TYPE_DESCRIPTION:
+        return $object->setDescription($xaction->getNewValue());
+      case PhameBlogTransaction::TYPE_DOMAIN:
+        return $object->setDomain($xaction->getNewValue());
+      case PhameBlogTransaction::TYPE_SKIN:
+        return $object->setSkin($xaction->getNewValue());
+      case PhabricatorTransactions::TYPE_VIEW_POLICY:
+        $object->setViewPolicy($xaction->getNewValue());
+        return;
+      case PhabricatorTransactions::TYPE_EDIT_POLICY:
+        $object->setEditPolicy($xaction->getNewValue());
+        return;
+      case PhabricatorTransactions::TYPE_JOIN_POLICY:
+        $object->setJoinPolicy($xaction->getNewValue());
+        return;
+      case PhabricatorTransactions::TYPE_COMMENT:
+        return;
+    }
+
+    return parent::applyCustomInternalTransaction($object, $xaction);
+  }
+
+  protected function applyCustomExternalTransaction(
+    PhabricatorLiskDAO $object,
+    PhabricatorApplicationTransaction $xaction) {
+
+    switch ($xaction->getTransactionType()) {
+      case PhameBlogTransaction::TYPE_NAME:
+      case PhameBlogTransaction::TYPE_DESCRIPTION:
+      case PhameBlogTransaction::TYPE_DOMAIN:
+      case PhameBlogTransaction::TYPE_SKIN:
+      case PhabricatorTransactions::TYPE_VIEW_POLICY:
+      case PhabricatorTransactions::TYPE_EDIT_POLICY:
+      case PhabricatorTransactions::TYPE_JOIN_POLICY:
+      case PhabricatorTransactions::TYPE_COMMENT:
+        return;
+    }
+
+    return parent::applyCustomExternalTransaction($object, $xaction);
+  }
+
+  protected function validateTransaction(
+    PhabricatorLiskDAO $object,
+    $type,
+    array $xactions) {
+
+    $errors = parent::validateTransaction($object, $type, $xactions);
+
+    switch ($type) {
+      case PhameBlogTransaction::TYPE_NAME:
+        $missing = $this->validateIsEmptyTextField(
+          $object->getName(),
+          $xactions);
+
+        if ($missing) {
+          $error = new PhabricatorApplicationTransactionValidationError(
+            $type,
+            pht('Required'),
+            pht('Name is required.'),
+            nonempty(last($xactions), null));
+
+          $error->setIsMissingFieldError(true);
+          $errors[] = $error;
+        }
+        break;
+      case PhameBlogTransaction::TYPE_DOMAIN:
+        $custom_domain = last($xactions)->getNewValue();
+        if (empty($custom_domain)) {
+          continue;
+        }
+        list($error_label, $error_text) =
+          $object->validateCustomDomain($custom_domain);
+        if ($error_label) {
+          $error = new PhabricatorApplicationTransactionValidationError(
+            $type,
+            $error_label,
+            $error_text,
+            nonempty(last($xactions), null));
+          $errors[] = $error;
+        }
+        if ($object->getViewPolicy() != PhabricatorPolicies::POLICY_PUBLIC) {
+          $error_text = pht(
+            'For custom domains to work, the blog must have a view policy of '.
+            'public.');
+          $error = new PhabricatorApplicationTransactionValidationError(
+            PhabricatorTransactions::TYPE_VIEW_POLICY,
+            pht('Invalid Policy'),
+            $error_text,
+            nonempty(last($xactions), null));
+          $errors[] = $error;
+        }
+        $duplicate_blog = id(new PhameBlogQuery())
+          ->setViewer(PhabricatorUser::getOmnipotentUser())
+          ->withDomain($custom_domain)
+          ->executeOne();
+        if ($duplicate_blog && $duplicate_blog->getID() != $object->getID()) {
+          $error = new PhabricatorApplicationTransactionValidationError(
+            $type,
+            pht('Not Unique'),
+            pht('Domain must be unique; another blog already has this domain.'),
+            nonempty(last($xactions), null));
+          $errors[] = $error;
+        }
+
+        break;
+    }
+    return $errors;
+  }
+
+  protected function shouldSendMail(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
+    return false;
+  }
+
+  protected function shouldPublishFeedStory(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
+    return false;
+  }
+
+  protected function supportsSearch() {
+    return false;
+  }
+
+}
diff --git a/src/applications/phame/storage/PhameBlog.php b/src/applications/phame/storage/PhameBlog.php
index e8eba5582b..1c4017fbd1 100644
--- a/src/applications/phame/storage/PhameBlog.php
+++ b/src/applications/phame/storage/PhameBlog.php
@@ -16,9 +16,6 @@ final class PhameBlog extends PhameDAO
   protected $editPolicy;
   protected $joinPolicy;
 
-  private $bloggerPHIDs = self::ATTACHABLE;
-  private $bloggers = self::ATTACHABLE;
-
   static private $requestBlog;
 
   protected function getConfiguration() {
@@ -57,6 +54,15 @@ final class PhameBlog extends PhameDAO
       PhabricatorPhameBlogPHIDType::TYPECONST);
   }
 
+  public static function initializeNewBlog(PhabricatorUser $actor) {
+    $blog = id(new PhameBlog())
+      ->setCreatorPHID($actor->getPHID())
+      ->setViewPolicy(PhabricatorPolicies::getMostOpenPolicy())
+      ->setEditPolicy(PhabricatorPolicies::POLICY_USER)
+      ->setJoinPolicy(PhabricatorPolicies::POLICY_USER);
+    return $blog;
+  }
+
   public function getSkinRenderer(AphrontRequest $request) {
     $spec = PhameSkinSpecification::loadOneSkinSpecification(
       $this->getSkin());
@@ -157,22 +163,6 @@ final class PhameBlog extends PhameDAO
     return null;
   }
 
-  public function getBloggerPHIDs() {
-    return $this->assertAttached($this->bloggerPHIDs);
-  }
-
-  public function attachBloggers(array $bloggers) {
-    assert_instances_of($bloggers, 'PhabricatorObjectHandle');
-
-    $this->bloggers = $bloggers;
-
-    return $this;
-  }
-
-  public function getBloggers() {
-    return $this->assertAttached($this->bloggers);
-  }
-
   public function getSkin() {
     $config = coalesce($this->getConfigData(), array());
     return idx($config, 'skin', self::SKIN_DEFAULT);
diff --git a/src/applications/phame/storage/PhameBlogTransaction.php b/src/applications/phame/storage/PhameBlogTransaction.php
new file mode 100644
index 0000000000..f1e558e240
--- /dev/null
+++ b/src/applications/phame/storage/PhameBlogTransaction.php
@@ -0,0 +1,174 @@
+<?php
+
+final class PhameBlogTransaction
+  extends PhabricatorApplicationTransaction {
+
+  const TYPE_NAME        = 'phame.blog.name';
+  const TYPE_DESCRIPTION = 'phame.blog.description';
+  const TYPE_DOMAIN      = 'phame.blog.domain';
+  const TYPE_SKIN        = 'phame.blog.skin';
+
+  public function getApplicationName() {
+    return 'phame';
+  }
+
+  public function getApplicationTransactionType() {
+    return PhabricatorPhameBlogPHIDType::TYPECONST;
+  }
+
+  public function shouldHide() {
+    $old = $this->getOldValue();
+    switch ($this->getTransactionType()) {
+      case self::TYPE_DESCRIPTION:
+        return ($old === null);
+    }
+    return parent::shouldHide();
+  }
+
+  public function getIcon() {
+    $old = $this->getOldValue();
+    switch ($this->getTransactionType()) {
+      case self::TYPE_NAME:
+        if ($old === null) {
+          return 'fa-plus';
+        } else {
+          return 'fa-pencil';
+        }
+        break;
+      case self::TYPE_DESCRIPTION:
+      case self::TYPE_DOMAIN:
+      case self::TYPE_SKIN:
+        return 'fa-pencil';
+        break;
+    }
+    return parent::getIcon();
+  }
+
+  public function getTitle() {
+    $author_phid = $this->getAuthorPHID();
+    $object_phid = $this->getObjectPHID();
+
+    $old = $this->getOldValue();
+    $new = $this->getNewValue();
+
+    $type = $this->getTransactionType();
+    switch ($type) {
+      case self:TYPE_NAME:
+        if ($old === null) {
+          return pht(
+            '%s created this blog.',
+            $this->renderHandleLink($author_phid));
+        } else {
+          return pht(
+            '%s updated the blog\'s name to "%s".',
+            $this->renderHandleLink($author_phid),
+            $new);
+        }
+        break;
+      case self::TYPE_DESCRIPTION:
+        return pht(
+          '%s updated the blog\'s description.',
+          $this->renderHandleLink($author_phid));
+        break;
+      case self::TYPE_DOMAIN:
+        return pht(
+          '%s updated the blog\'s domain to "%s".',
+          $this->renderHandleLink($author_phid),
+          $new);
+        break;
+      case self::TYPE_SKIN:
+        return pht(
+          '%s updated the blog\'s skin to "%s".',
+          $this->renderHandleLink($author_phid),
+          $new);
+        break;
+    }
+
+    return parent::getTitle();
+  }
+
+  public function getTitleForFeed() {
+    $author_phid = $this->getAuthorPHID();
+    $object_phid = $this->getObjectPHID();
+
+    $old = $this->getOldValue();
+    $new = $this->getNewValue();
+
+    $type = $this->getTransactionType();
+    switch ($type) {
+      case self::TYPE_NAME:
+        if ($old === null) {
+          return pht(
+            '%s created %s.',
+            $this->renderHandleLink($author_phid),
+            $this->renderHandleLink($object_phid));
+        } else {
+          return pht(
+            '%s updated the name for %s.',
+            $this->renderHandleLink($author_phid),
+            $this->renderHandleLink($object_phid));
+        }
+        break;
+      case self::TYPE_DESCRIPTION:
+        return pht(
+          '%s updated the description for %s.',
+          $this->renderHandleLink($author_phid),
+          $this->renderHandleLink($object_phid));
+        break;
+      case self::TYPE_DOMAIN:
+        return pht(
+          '%s updated the domain for %s.',
+          $this->renderHandleLink($author_phid),
+          $this->renderHandleLink($object_phid));
+        break;
+      case self::TYPE_SKIN:
+        return pht(
+          '%s updated the skin for %s.',
+          $this->renderHandleLink($author_phid),
+          $this->renderHandleLink($object_phid));
+        break;
+    }
+
+    return parent::getTitleForFeed();
+  }
+
+  public function getColor() {
+    $old = $this->getOldValue();
+
+    switch ($this->getTransactionType()) {
+      case self::TYPE_NAME:
+        if ($old === null) {
+          return PhabricatorTransactions::COLOR_GREEN;
+        }
+        break;
+    }
+
+    return parent::getColor();
+  }
+
+
+  public function hasChangeDetails() {
+    switch ($this->getTransactionType()) {
+      case self::TYPE_DESCRIPTION:
+        return ($this->getOldValue() !== null);
+    }
+
+    return parent::hasChangeDetails();
+  }
+
+  public function renderChangeDetails(PhabricatorUser $viewer) {
+    switch ($this->getTransactionType()) {
+      case self::TYPE_DESCRIPTION:
+        $old = $this->getOldValue();
+        $new = $this->getNewValue();
+
+        return $this->renderTextCorpusChangeDetails(
+          $viewer,
+          $old,
+          $new);
+    }
+
+    return parent::renderChangeDetails($viewer);
+  }
+
+}

From 4016107411c12d8658a2cfeefeef19b7c12fa6cb Mon Sep 17 00:00:00 2001
From: lkassianik <lyubakassianik@gmail.com>
Date: Thu, 14 May 2015 19:20:44 -0700
Subject: [PATCH 12/86] Calendar events should be green if viewer is invited,
 and grey if not.

Summary: Closes T8189, Calendar events should be green if viewer is invited, and grey if not.

Test Plan: Check that month and day views display events that viewer is invited to as green and grey otherwise, including month day badges on mobile monthly view.

Reviewers: chad, #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8189

Differential Revision: https://secure.phabricator.com/D12850
---
 resources/celerity/map.php                    | 12 +++---
 .../calendar/constants/CalendarColors.php     |  2 +
 .../PhabricatorCalendarEventSearchEngine.php  | 25 +++---------
 .../storage/PhabricatorCalendarEvent.php      | 10 +++++
 .../view/AphrontCalendarEventView.php         | 22 +++++------
 .../phui/calendar/PHUICalendarDayView.php     | 15 +++++++-
 .../phui/calendar/PHUICalendarListView.php    | 17 +++++++--
 .../phui/calendar/PHUICalendarMonthView.php   | 14 +++++--
 .../css/phui/calendar/phui-calendar-day.css   | 20 ++++++++--
 .../css/phui/calendar/phui-calendar-month.css | 21 ++++++++--
 .../rsrc/css/phui/calendar/phui-calendar.css  | 38 ++++++++++++++++++-
 11 files changed, 142 insertions(+), 54 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 27c94b3b30..4572955492 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -120,10 +120,10 @@ return array(
     'rsrc/css/layout/phabricator-hovercard-view.css' => 'dd9121a9',
     'rsrc/css/layout/phabricator-side-menu-view.css' => 'c1db9e9c',
     'rsrc/css/layout/phabricator-source-code-view.css' => '2ceee894',
-    'rsrc/css/phui/calendar/phui-calendar-day.css' => '38891735',
+    'rsrc/css/phui/calendar/phui-calendar-day.css' => '3b4a65d8',
     'rsrc/css/phui/calendar/phui-calendar-list.css' => 'c1d0ca59',
-    'rsrc/css/phui/calendar/phui-calendar-month.css' => '3150cfbf',
-    'rsrc/css/phui/calendar/phui-calendar.css' => '8675968e',
+    'rsrc/css/phui/calendar/phui-calendar-month.css' => '3e42c803',
+    'rsrc/css/phui/calendar/phui-calendar.css' => '8345be98',
     'rsrc/css/phui/phui-action-header-view.css' => '89c497e7',
     'rsrc/css/phui/phui-action-list.css' => '4f4d09f2',
     'rsrc/css/phui/phui-action-panel.css' => '3ee9afd5',
@@ -760,10 +760,10 @@ return array(
     'phui-action-panel-css' => '3ee9afd5',
     'phui-box-css' => '7b3a2eed',
     'phui-button-css' => 'de610129',
-    'phui-calendar-css' => '8675968e',
-    'phui-calendar-day-css' => '38891735',
+    'phui-calendar-css' => '8345be98',
+    'phui-calendar-day-css' => '3b4a65d8',
     'phui-calendar-list-css' => 'c1d0ca59',
-    'phui-calendar-month-css' => '3150cfbf',
+    'phui-calendar-month-css' => '3e42c803',
     'phui-crumbs-view-css' => '594d719e',
     'phui-document-view-css' => '94d5dcd8',
     'phui-feed-story-css' => 'c9f3a0b5',
diff --git a/src/applications/calendar/constants/CalendarColors.php b/src/applications/calendar/constants/CalendarColors.php
index d5f4f7501c..e7bd792e0b 100644
--- a/src/applications/calendar/constants/CalendarColors.php
+++ b/src/applications/calendar/constants/CalendarColors.php
@@ -10,6 +10,7 @@ final class CalendarColors extends CalendarConstants {
   const COLOR_SKY = 'sky';
   const COLOR_INDIGO = 'indigo';
   const COLOR_VIOLET = 'violet';
+  const COLOR_GREY = 'grey';
 
   public static function getColors() {
     return array(
@@ -21,6 +22,7 @@ final class CalendarColors extends CalendarConstants {
       self::COLOR_INDIGO,
       self::COLOR_RED,
       self::COLOR_YELLOW,
+      self::COLOR_GREY,
     );
   }
 
diff --git a/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php b/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
index c8a788adb8..3e020895f3 100644
--- a/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
+++ b/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
@@ -359,25 +359,9 @@ final class PhabricatorCalendarEventSearchEngine
 
     $phids = mpull($statuses, 'getUserPHID');
 
-    /* Assign Colors */
-    $unique = array_unique($phids);
-    $allblue = false;
-    $calcolors = CalendarColors::getColors();
-    if (count($unique) > count($calcolors)) {
-      $allblue = true;
-    }
-    $i = 0;
-    $eventcolor = array();
-    foreach ($unique as $phid) {
-      if ($allblue) {
-        $eventcolor[$phid] = CalendarColors::COLOR_SKY;
-      } else {
-        $eventcolor[$phid] = $calcolors[$i];
-      }
-      $i++;
-    }
-
     foreach ($statuses as $status) {
+      $viewer_is_invited = $status->getIsUserInvited($viewer->getPHID());
+
       $event = new AphrontCalendarEventView();
       $event->setEpochRange($status->getDateFrom(), $status->getDateTo());
       $event->setIsAllDay($status->getIsAllDay());
@@ -388,7 +372,7 @@ final class PhabricatorCalendarEventSearchEngine
       $event->setDescription(pht('%s (%s)', $name_text, $status_text));
       $event->setName($status_text);
       $event->setEventID($status->getID());
-      $event->setColor($eventcolor[$status->getUserPHID()]);
+      $event->setViewerIsInvited($viewer_is_invited);
       $month_view->addEvent($event);
     }
 
@@ -422,10 +406,13 @@ final class PhabricatorCalendarEventSearchEngine
         continue;
       }
 
+      $viewer_is_invited = $status->getIsUserInvited($viewer->getPHID());
+
       $event = new AphrontCalendarEventView();
       $event->setEventID($status->getID());
       $event->setEpochRange($status->getDateFrom(), $status->getDateTo());
       $event->setIsAllDay($status->getIsAllDay());
+      $event->setViewerIsInvited($viewer_is_invited);
 
       $event->setName($status->getName());
       $event->setURI('/'.$status->getMonogram());
diff --git a/src/applications/calendar/storage/PhabricatorCalendarEvent.php b/src/applications/calendar/storage/PhabricatorCalendarEvent.php
index 044bc9fc78..42bf5f9e05 100644
--- a/src/applications/calendar/storage/PhabricatorCalendarEvent.php
+++ b/src/applications/calendar/storage/PhabricatorCalendarEvent.php
@@ -215,6 +215,16 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO
     return $is_attending;
   }
 
+  public function getIsUserInvited($phid) {
+    $uninvited_status = PhabricatorCalendarEventInvitee::STATUS_UNINVITED;
+    $declined_status = PhabricatorCalendarEventInvitee::STATUS_DECLINED;
+    $status = $this->getUserInviteStatus($phid);
+    if ($status == $uninvited_status || $status == $declined_status) {
+      return false;
+    }
+    return true;
+  }
+
 /* -(  Markup Interface  )--------------------------------------------------- */
 
 
diff --git a/src/applications/calendar/view/AphrontCalendarEventView.php b/src/applications/calendar/view/AphrontCalendarEventView.php
index 11dbff3847..669844290f 100644
--- a/src/applications/calendar/view/AphrontCalendarEventView.php
+++ b/src/applications/calendar/view/AphrontCalendarEventView.php
@@ -8,7 +8,7 @@ final class AphrontCalendarEventView extends AphrontView {
   private $epochEnd;
   private $description;
   private $eventID;
-  private $color;
+  private $viewerIsInvited;
   private $uri;
   private $isAllDay;
 
@@ -29,6 +29,14 @@ final class AphrontCalendarEventView extends AphrontView {
     return $this->eventID;
   }
 
+  public function setViewerIsInvited($viewer_is_invited) {
+    $this->viewerIsInvited = $viewer_is_invited;
+    return $this;
+  }
+  public function getViewerIsInvited() {
+    return $this->viewerIsInvited;
+  }
+
   public function setUserPHID($user_phid) {
     $this->userPHID = $user_phid;
     return $this;
@@ -70,18 +78,6 @@ final class AphrontCalendarEventView extends AphrontView {
     return $this->description;
   }
 
-  public function setColor($color) {
-    $this->color = $color;
-    return $this;
-  }
-  public function getColor() {
-    if ($this->color) {
-      return $this->color;
-    } else {
-      return CalendarColors::COLOR_SKY;
-    }
-  }
-
   public function setIsAllDay($is_all_day) {
     $this->isAllDay = $is_all_day;
     return $this;
diff --git a/src/view/phui/calendar/PHUICalendarDayView.php b/src/view/phui/calendar/PHUICalendarDayView.php
index 21c893125d..5afff57d3b 100644
--- a/src/view/phui/calendar/PHUICalendarDayView.php
+++ b/src/view/phui/calendar/PHUICalendarDayView.php
@@ -391,10 +391,15 @@ final class PHUICalendarDayView extends AphrontView {
   }
 
   private function drawAllDayEvent(AphrontCalendarEventView $event) {
+    $class = 'day-view-all-day';
+    if ($event->getViewerIsInvited()) {
+      $class = $class.' viewer-invited-day-event';
+    }
+
     $name = phutil_tag(
       'a',
       array(
-        'class' => 'day-view-all-day',
+        'class' => $class,
         'href' => $event->getURI(),
       ),
       $event->getName());
@@ -425,10 +430,16 @@ final class PHUICalendarDayView extends AphrontView {
     $width,
     $top,
     $height) {
+
+    $class = 'phui-calendar-day-event-link';
+    if ($event->getViewerIsInvited()) {
+      $class =  $class.' viewer-invited-day-event';
+    }
+
     $name = phutil_tag(
       'a',
       array(
-        'class' => 'phui-calendar-day-event-link',
+        'class' => $class,
         'href' => $event->getURI(),
       ),
       $event->getName());
diff --git a/src/view/phui/calendar/PHUICalendarListView.php b/src/view/phui/calendar/PHUICalendarListView.php
index c2d33b8469..e315aa93d1 100644
--- a/src/view/phui/calendar/PHUICalendarListView.php
+++ b/src/view/phui/calendar/PHUICalendarListView.php
@@ -33,7 +33,6 @@ final class PHUICalendarListView extends AphrontTagView {
     $singletons = array();
     $allday = false;
     foreach ($this->events as $event) {
-      $color = $event->getColor();
       $start_epoch = $event->getEpochStart();
 
       if ($event->getIsAllDay()) {
@@ -65,7 +64,10 @@ final class PHUICalendarListView extends AphrontTagView {
         ),
         $timelabel);
 
-      $class = 'phui-calendar-list-item phui-calendar-'.$color;
+      $class = 'phui-calendar-list-item';
+      if ($event->getViewerIsInvited()) {
+        $class = $class.' phui-calendar-viewer-invited';
+      }
       if ($event->getIsAllDay()) {
         $class = $class.' all-day';
       }
@@ -142,7 +144,7 @@ final class PHUICalendarListView extends AphrontTagView {
       $description = pht('(%s)', $event->getName());
     }
 
-    $class = 'phui-calendar-item-link';
+    $class = 'phui-calendar-item';
 
     $anchor = javelin_tag(
       'a',
@@ -159,4 +161,13 @@ final class PHUICalendarListView extends AphrontTagView {
 
     return $anchor;
   }
+
+  public function getIsViewerInvitedOnList() {
+    foreach ($this->events as $event) {
+      if ($event->getViewerIsInvited()) {
+        return true;
+      }
+    }
+    return false;
+  }
 }
diff --git a/src/view/phui/calendar/PHUICalendarMonthView.php b/src/view/phui/calendar/PHUICalendarMonthView.php
index 7eb35f76a5..08a4731598 100644
--- a/src/view/phui/calendar/PHUICalendarMonthView.php
+++ b/src/view/phui/calendar/PHUICalendarMonthView.php
@@ -178,7 +178,9 @@ final class PHUICalendarMonthView extends AphrontView {
     $uri = $event_list['uri'];
     $count = $event_list['count'];
 
-    $event_count_badge = $this->getEventCountBadge($count);
+    $viewer_is_invited = $list->getIsViewerInvitedOnList();
+
+    $event_count_badge = $this->getEventCountBadge($count, $viewer_is_invited);
     $cell_day_secret_link = $this->getHiddenDayLink($uri);
 
     $cell_data_div = phutil_tag(
@@ -252,13 +254,19 @@ final class PHUICalendarMonthView extends AphrontView {
       $cell_div);
   }
 
-  private function getEventCountBadge($count) {
+  private function getEventCountBadge($count, $viewer_is_invited) {
+    $class = 'phui-calendar-month-count-badge';
+
+    if ($viewer_is_invited) {
+      $class = $class.' viewer-invited-day-badge';
+    }
+
     $event_count = null;
     if ($count > 0) {
       $event_count = phutil_tag(
         'div',
         array(
-          'class' => 'phui-calendar-month-count-badge',
+          'class' => $class,
         ),
         $count);
     }
diff --git a/webroot/rsrc/css/phui/calendar/phui-calendar-day.css b/webroot/rsrc/css/phui/calendar/phui-calendar-day.css
index 11f4045fe1..4f2c8a9e3d 100644
--- a/webroot/rsrc/css/phui/calendar/phui-calendar-day.css
+++ b/webroot/rsrc/css/phui/calendar/phui-calendar-day.css
@@ -37,8 +37,8 @@
 
 .phui-calendar-day-event-link {
   padding: 8px;
-  border: 1px solid {$blueborder};
-  background-color: {$bluebackground};
+  border: 1px solid {$greyborder};
+  background-color: {$darkgreybackground};
   margin: 0 4px;
   position: absolute;
   left: 0;
@@ -49,17 +49,29 @@
   color: {$greytext};
 }
 
+.phui-calendar-day-event-link.viewer-invited-day-event {
+  border-color: {$green};
+  background-color: {$lightgreen};
+  color: {$green};
+}
+
 .day-view-all-day {
-  border: 1px solid {$blueborder};
+  border: 1px solid {$greyborder};
   height: 12px;
   margin: 0;
   display: block;
   padding: 8px;
-  background-color: {$bluebackground};
+  background-color: {$darkgreybackground};
   text-decoration: none;
   color: {$greytext};
 }
 
+.day-view-all-day.viewer-invited-day-event {
+  border-color: {$green};
+  background-color: {$lightgreen};
+  color: {$green};
+}
+
 .phui-calendar-day-event + .phui-calendar-day-event .day-view-all-day {
   border-top-style: none;
   border-top-width: 0;
diff --git a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
index a231b452a2..9fc1e8c52d 100644
--- a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
+++ b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
@@ -73,6 +73,11 @@ table.phui-calendar-view tr td:first-child {
   margin: 0 auto;
 }
 
+.phui-calendar-month-count-badge.viewer-invited-day-badge {
+  border-color: {$green};
+  color: {$green};
+}
+
 table.phui-calendar-view a.phui-calendar-date-number {
   color: {$lightgreytext};
   padding: 0 4px;
@@ -116,12 +121,18 @@ table.phui-calendar-view td.phui-calendar-date-number-container {
 
 .phui-calendar-view .phui-calendar-list li.phui-calendar-list-item.all-day {
   margin: 0;
-  padding: 4px 8px;
-  background-color: {$lightpink};
+  padding: 4px 4px 0px 4px;
+  background-color: {$darkgreybackground};
   display: block;
   float: none;
 }
 
+.phui-calendar-view
+.phui-calendar-list
+li.phui-calendar-viewer-invited.all-day {
+  background-color: {$lightgreen};
+}
+
 li.phui-calendar-list-item.all-day:first-child {
   margin-top: 0;
 }
@@ -155,7 +166,11 @@ li.phui-calendar-list-item.all-day:first-child {
 }
 
 li.phui-calendar-list-item.all-day .phui-calendar-list-title a{
-  color: {$pink};
+  color: {$greytext};
+}
+
+li.phui-calendar-viewer-invited.all-day .phui-calendar-list-title a{
+  color: {$green};
 }
 
 .phui-calendar-view .phui-calendar-list-time {
diff --git a/webroot/rsrc/css/phui/calendar/phui-calendar.css b/webroot/rsrc/css/phui/calendar/phui-calendar.css
index e338366b3d..e3f67c2162 100644
--- a/webroot/rsrc/css/phui/calendar/phui-calendar.css
+++ b/webroot/rsrc/css/phui/calendar/phui-calendar.css
@@ -2,6 +2,15 @@
  * @provides phui-calendar-css
  */
 
+ .phui-calendar-list a {
+  color: {$lightgreytext};
+ }
+
+.phui-calendar-viewer-invited a {
+  color: {$green};
+  font-weight: bold;
+}
+
 .phui-calendar-red a {
   color: {$red};
 }
@@ -34,6 +43,14 @@
   color: {$violet};
 }
 
+.phui-calendar-grey a {
+  color: {$lightgreytext};
+}
+
+.phui-calendar-bg-viewer-invited {
+  background-color: {$lightgreen};
+}
+
 .phui-calendar-bg-red {
   background-color: {$lightred};
 }
@@ -47,7 +64,7 @@
 }
 
 .phui-calendar-bg-green {
-  background-color: {$lightgreen}
+  background-color: {$lightgreen};
 }
 
 .phui-calendar-bg-blue {
@@ -66,6 +83,20 @@
   background-color: {$lightviolet};
 }
 
+.phui-calendar-bg-grey {
+  background-color: {$darkgreybackground};
+}
+
+.phui-calendar-list-dot {
+  background-color: {$lightgreytext};
+  border-color: {$lightgreytext};
+}
+
+.phui-calendar-viewer-invited .phui-calendar-list-dot {
+  background-color: {$green};
+  border-color: {$green};
+}
+
 .phui-calendar-red .phui-calendar-list-dot {
   background-color: {$red};
   border-color: {$red};
@@ -105,3 +136,8 @@
   background-color: {$violet};
   border-color: {$violet};
 }
+
+.phui-calendar-grey .phui-calendar-list-dot {
+  background-color: {$lightgreytext};
+  border-color: {$lightgreytext};
+}

From e185d8fe0234726c38d1d2e1808472ebc389ddc6 Mon Sep 17 00:00:00 2001
From: lkassianik <lyubakassianik@gmail.com>
Date: Thu, 14 May 2015 20:51:41 -0700
Subject: [PATCH 13/86] Event lists in days of month view should also specify
 the time of the event.

Summary: Ref T8188, Event lists in days of month view should also specify the time of the event.

Test Plan: Time start should be display on event links in month view. Note: not handling the case where an event starts on a previous day - always displaying just start time, with no disgression.

Reviewers: chad, #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8188

Differential Revision: https://secure.phabricator.com/D12852
---
 resources/celerity/map.php                    |  8 +++---
 .../css/phui/calendar/phui-calendar-list.css  |  1 +
 .../css/phui/calendar/phui-calendar-month.css | 28 +++++++++++++++----
 3 files changed, 27 insertions(+), 10 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 4572955492..cf96220e2e 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -121,8 +121,8 @@ return array(
     'rsrc/css/layout/phabricator-side-menu-view.css' => 'c1db9e9c',
     'rsrc/css/layout/phabricator-source-code-view.css' => '2ceee894',
     'rsrc/css/phui/calendar/phui-calendar-day.css' => '3b4a65d8',
-    'rsrc/css/phui/calendar/phui-calendar-list.css' => 'c1d0ca59',
-    'rsrc/css/phui/calendar/phui-calendar-month.css' => '3e42c803',
+    'rsrc/css/phui/calendar/phui-calendar-list.css' => '840baa8d',
+    'rsrc/css/phui/calendar/phui-calendar-month.css' => '450c37ea',
     'rsrc/css/phui/calendar/phui-calendar.css' => '8345be98',
     'rsrc/css/phui/phui-action-header-view.css' => '89c497e7',
     'rsrc/css/phui/phui-action-list.css' => '4f4d09f2',
@@ -762,8 +762,8 @@ return array(
     'phui-button-css' => 'de610129',
     'phui-calendar-css' => '8345be98',
     'phui-calendar-day-css' => '3b4a65d8',
-    'phui-calendar-list-css' => 'c1d0ca59',
-    'phui-calendar-month-css' => '3e42c803',
+    'phui-calendar-list-css' => '840baa8d',
+    'phui-calendar-month-css' => '450c37ea',
     'phui-crumbs-view-css' => '594d719e',
     'phui-document-view-css' => '94d5dcd8',
     'phui-feed-story-css' => 'c9f3a0b5',
diff --git a/webroot/rsrc/css/phui/calendar/phui-calendar-list.css b/webroot/rsrc/css/phui/calendar/phui-calendar-list.css
index bf92ee4b09..db69c78d03 100644
--- a/webroot/rsrc/css/phui/calendar/phui-calendar-list.css
+++ b/webroot/rsrc/css/phui/calendar/phui-calendar-list.css
@@ -52,6 +52,7 @@
 
 .phui-calendar-list-item .phui-calendar-list-time {
   position: absolute;
+  top: 0;
   width: 60px;
   right: 0;
   top: 0;
diff --git a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
index 9fc1e8c52d..2e9f30a4c1 100644
--- a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
+++ b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
@@ -139,9 +139,6 @@ li.phui-calendar-list-item.all-day:first-child {
 
 .phui-calendar-view .phui-calendar-list li {
   margin: 0 8px;
-  display: inline-block;
-  float: left;
-  clear: both;
 }
 
 .phui-calendar-view .phui-calendar-list li:first-child {
@@ -160,11 +157,18 @@ li.phui-calendar-list-item.all-day:first-child {
 
 .phui-calendar-view .phui-calendar-list-title {
   width: auto;
-  margin-left: 10px;
   white-space: normal;
   word-break: break-word;
 }
 
+li.phui-calendar-list-item .phui-calendar-list-title a {
+  text-align: left;
+  padding-left: 8px;
+  overflow: hidden;
+  text-overflow: ellipsis;
+  white-space: nowrap;
+}
+
 li.phui-calendar-list-item.all-day .phui-calendar-list-title a{
   color: {$greytext};
 }
@@ -173,6 +177,18 @@ li.phui-calendar-viewer-invited.all-day .phui-calendar-list-title a{
   color: {$green};
 }
 
-.phui-calendar-view .phui-calendar-list-time {
-  display: none;
+.phui-calendar-view li.phui-calendar-list-item .phui-calendar-list-time {
+  position: absolute;
+  width: 60px;
+  right: 0;
+  top: 1px;
+  color: {$lightgreytext};
+  text-align: right;
+}
+
+.phui-calendar-view
+li.phui-calendar-list-item.all-day
+.phui-calendar-list-time  {
+  top: 4px;
+  right: 8px;
 }

From 6620ebe553a0ca803311e56ec9eb72262235838a Mon Sep 17 00:00:00 2001
From: lkassianik <lyubakassianik@gmail.com>
Date: Fri, 15 May 2015 10:32:47 -0700
Subject: [PATCH 14/86] Week day names in Calendar month view should be full
 names on desktop and short names on device

Summary: Ref T8186, Week day names in Calendar month view should be full names on desktop and short names on device

Test Plan: Open month view, desktop view should display Monday, Tuesday, etc. Shrink browser, days should be Mon, Tue, etc.

Reviewers: chad, epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T8186

Differential Revision: https://secure.phabricator.com/D12859
---
 resources/celerity/map.php                    |  4 +--
 .../phui/calendar/PHUICalendarMonthView.php   | 34 +++++++++++++++----
 .../css/phui/calendar/phui-calendar-month.css | 14 +++++++-
 3 files changed, 42 insertions(+), 10 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index cf96220e2e..4c3c1b87ac 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -122,7 +122,7 @@ return array(
     'rsrc/css/layout/phabricator-source-code-view.css' => '2ceee894',
     'rsrc/css/phui/calendar/phui-calendar-day.css' => '3b4a65d8',
     'rsrc/css/phui/calendar/phui-calendar-list.css' => '840baa8d',
-    'rsrc/css/phui/calendar/phui-calendar-month.css' => '450c37ea',
+    'rsrc/css/phui/calendar/phui-calendar-month.css' => '9fde32d1',
     'rsrc/css/phui/calendar/phui-calendar.css' => '8345be98',
     'rsrc/css/phui/phui-action-header-view.css' => '89c497e7',
     'rsrc/css/phui/phui-action-list.css' => '4f4d09f2',
@@ -763,7 +763,7 @@ return array(
     'phui-calendar-css' => '8345be98',
     'phui-calendar-day-css' => '3b4a65d8',
     'phui-calendar-list-css' => '840baa8d',
-    'phui-calendar-month-css' => '450c37ea',
+    'phui-calendar-month-css' => '9fde32d1',
     'phui-crumbs-view-css' => '594d719e',
     'phui-document-view-css' => '94d5dcd8',
     'phui-feed-story-css' => 'c9f3a0b5',
diff --git a/src/view/phui/calendar/PHUICalendarMonthView.php b/src/view/phui/calendar/PHUICalendarMonthView.php
index 08a4731598..80fe049dc3 100644
--- a/src/view/phui/calendar/PHUICalendarMonthView.php
+++ b/src/view/phui/calendar/PHUICalendarMonthView.php
@@ -294,16 +294,36 @@ final class PHUICalendarMonthView extends AphrontView {
       'tr',
       array('class' => 'phui-calendar-day-of-week-header'),
       array(
-        phutil_tag('th', array(), pht('Sun')),
-        phutil_tag('th', array(), pht('Mon')),
-        phutil_tag('th', array(), pht('Tue')),
-        phutil_tag('th', array(), pht('Wed')),
-        phutil_tag('th', array(), pht('Thu')),
-        phutil_tag('th', array(), pht('Fri')),
-        phutil_tag('th', array(), pht('Sat')),
+        $this->getDayHeader(pht('Sun'), pht('Sunday')),
+        $this->getDayHeader(pht('Mon'), pht('Monday')),
+        $this->getDayHeader(pht('Tue'), pht('Tuesday')),
+        $this->getDayHeader(pht('Wed'), pht('Wednesday')),
+        $this->getDayHeader(pht('Thu'), pht('Thursday')),
+        $this->getDayHeader(pht('Fri'), pht('Friday')),
+        $this->getDayHeader(pht('Sat'), pht('Saturday')),
       ));
   }
 
+  private function getDayHeader($short, $long) {
+    $day = array();
+    $day[] = phutil_tag(
+      'span',
+      array(
+        'class' => 'long-weekday-name',
+      ),
+      $long);
+    $day[] = phutil_tag(
+      'span',
+      array(
+        'class' => 'short-weekday-name',
+      ),
+      $short);
+    return phutil_tag(
+      'th',
+      array(),
+      $day);
+  }
+
   private function renderCalendarHeader(DateTime $date) {
     $button_bar = null;
 
diff --git a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
index 2e9f30a4c1..cd7a0e4712 100644
--- a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
+++ b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
@@ -10,12 +10,24 @@
 
 tr.phui-calendar-day-of-week-header th {
   text-align: center;
-  font-size: 11px;
+  font-size: 13px;
   padding: 3px;
   color: {$lightbluetext};
   background: {$lightgreybackground};
 }
 
+.device tr.phui-calendar-day-of-week-header th .long-weekday-name {
+  display: none;
+}
+
+tr.phui-calendar-day-of-week-header th .short-weekday-name {
+  display: none;
+}
+
+.device tr.phui-calendar-day-of-week-header th .short-weekday-name {
+  display: inline;
+}
+
 table.phui-calendar-view td {
   border: solid #dfdfdf;
   border-width: 1px 1px 0 1px;

From 27c75357be847496f548522eebbeb02ffbebeb34 Mon Sep 17 00:00:00 2001
From: lkassianik <lyubakassianik@gmail.com>
Date: Fri, 15 May 2015 10:42:54 -0700
Subject: [PATCH 15/86] Weekend header labels in month view should have darker
 backgrounds instead of dark actual weekend days.

Summary: Closes T8186, Weekend header labels in month view should have darker backgrounds instead of dark actual weekend days.

Test Plan: open month view, observe weekend labels having a darker background.

Reviewers: chad, epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T8186

Differential Revision: https://secure.phabricator.com/D12860
---
 resources/celerity/map.php                         |  4 ++--
 src/view/phui/calendar/PHUICalendarMonthView.php   | 14 ++++++++++----
 .../rsrc/css/phui/calendar/phui-calendar-month.css |  4 ++++
 3 files changed, 16 insertions(+), 6 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 4c3c1b87ac..1b82da2ae9 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -122,7 +122,7 @@ return array(
     'rsrc/css/layout/phabricator-source-code-view.css' => '2ceee894',
     'rsrc/css/phui/calendar/phui-calendar-day.css' => '3b4a65d8',
     'rsrc/css/phui/calendar/phui-calendar-list.css' => '840baa8d',
-    'rsrc/css/phui/calendar/phui-calendar-month.css' => '9fde32d1',
+    'rsrc/css/phui/calendar/phui-calendar-month.css' => '7819a8b1',
     'rsrc/css/phui/calendar/phui-calendar.css' => '8345be98',
     'rsrc/css/phui/phui-action-header-view.css' => '89c497e7',
     'rsrc/css/phui/phui-action-list.css' => '4f4d09f2',
@@ -763,7 +763,7 @@ return array(
     'phui-calendar-css' => '8345be98',
     'phui-calendar-day-css' => '3b4a65d8',
     'phui-calendar-list-css' => '840baa8d',
-    'phui-calendar-month-css' => '9fde32d1',
+    'phui-calendar-month-css' => '7819a8b1',
     'phui-crumbs-view-css' => '594d719e',
     'phui-document-view-css' => '94d5dcd8',
     'phui-feed-story-css' => 'c9f3a0b5',
diff --git a/src/view/phui/calendar/PHUICalendarMonthView.php b/src/view/phui/calendar/PHUICalendarMonthView.php
index 80fe049dc3..16e58e3203 100644
--- a/src/view/phui/calendar/PHUICalendarMonthView.php
+++ b/src/view/phui/calendar/PHUICalendarMonthView.php
@@ -294,17 +294,21 @@ final class PHUICalendarMonthView extends AphrontView {
       'tr',
       array('class' => 'phui-calendar-day-of-week-header'),
       array(
-        $this->getDayHeader(pht('Sun'), pht('Sunday')),
+        $this->getDayHeader(pht('Sun'), pht('Sunday'), true),
         $this->getDayHeader(pht('Mon'), pht('Monday')),
         $this->getDayHeader(pht('Tue'), pht('Tuesday')),
         $this->getDayHeader(pht('Wed'), pht('Wednesday')),
         $this->getDayHeader(pht('Thu'), pht('Thursday')),
         $this->getDayHeader(pht('Fri'), pht('Friday')),
-        $this->getDayHeader(pht('Sat'), pht('Saturday')),
+        $this->getDayHeader(pht('Sat'), pht('Saturday'), true),
       ));
   }
 
-  private function getDayHeader($short, $long) {
+  private function getDayHeader($short, $long, $is_weekend = false) {
+    $class = null;
+    if ($is_weekend) {
+      $class = 'weekend-day-header';
+    }
     $day = array();
     $day[] = phutil_tag(
       'span',
@@ -320,7 +324,9 @@ final class PHUICalendarMonthView extends AphrontView {
       $short);
     return phutil_tag(
       'th',
-      array(),
+      array(
+        'class' => $class,
+      ),
       $day);
   }
 
diff --git a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
index cd7a0e4712..ba268f332f 100644
--- a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
+++ b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
@@ -16,6 +16,10 @@ tr.phui-calendar-day-of-week-header th {
   background: {$lightgreybackground};
 }
 
+tr.phui-calendar-day-of-week-header th.weekend-day-header {
+  background: {$greybackground};
+}
+
 .device tr.phui-calendar-day-of-week-header th .long-weekday-name {
   display: none;
 }

From 7179def064a3881cb42f79e1ec2e0b8155b55f7b Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Fri, 15 May 2015 11:54:51 -0700
Subject: [PATCH 16/86] Clean up a missed access to Calendar status

Summary: Ref T8183. The list view still used this field to choose a red/orange bar color.

Test Plan: Viewed event list view.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8183

Differential Revision: https://secure.phabricator.com/D12857
---
 .../query/PhabricatorCalendarEventSearchEngine.php         | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php b/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
index 3e020895f3..7added162f 100644
--- a/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
+++ b/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
@@ -303,17 +303,12 @@ final class PhabricatorCalendarEventSearchEngine
     foreach ($events as $event) {
       $href = '/E'.$event->getID();
       $from = phabricator_datetime($event->getDateFrom(), $viewer);
-      $to   = phabricator_datetime($event->getDateTo(), $viewer);
+      $to = phabricator_datetime($event->getDateTo(), $viewer);
       $creator_handle = $handles[$event->getUserPHID()];
 
-      $color = ($event->getStatus() == PhabricatorCalendarEvent::STATUS_AWAY)
-        ? 'red'
-        : 'yellow';
-
       $item = id(new PHUIObjectItemView())
         ->setHeader($event->getName())
         ->setHref($href)
-        ->setBarColor($color)
         ->addByline(pht('Creator: %s', $creator_handle->renderLink()))
         ->addAttribute(pht('From %s to %s', $from, $to))
         ->addAttribute(id(new PhutilUTF8StringTruncator())

From 27b78d2147900f8b6406ff3c04c20e61f92bb210 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Fri, 15 May 2015 11:55:04 -0700
Subject: [PATCH 17/86] Don't use handles in the Calendar event name migration

Summary:
Fixes T8209. Using handles can now cause cache fills as a side effect of T7707. Use a raw query instead.

I'll follow up on T8209 with some context and ideas for longer-term fixes.

Test Plan:
  - Set event names to `''`.
  - Reran migration with `--apply ... --trace`.
  - Saw migration work correctly without executing cache fills.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8209

Differential Revision: https://secure.phabricator.com/D12858
---
 .../autopatches/20150506.calendarunnamedevents.1.php  | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/resources/sql/autopatches/20150506.calendarunnamedevents.1.php b/resources/sql/autopatches/20150506.calendarunnamedevents.1.php
index d6bdb1ab48..0b8c029584 100644
--- a/resources/sql/autopatches/20150506.calendarunnamedevents.1.php
+++ b/resources/sql/autopatches/20150506.calendarunnamedevents.1.php
@@ -11,12 +11,17 @@ foreach ($iterator as $event) {
   if (strlen($event->getName()) == 0) {
     echo "Renaming event {$id}...\n";
     $viewer = PhabricatorUser::getOmnipotentUser();
-    $handle = id(new PhabricatorHandleQuery())
+
+    // NOTE: This uses PeopleQuery directly, instead of HandleQuery, to avoid
+    // performing cache fills as a side effect; the caches were added by a
+    // later patch. See T8209.
+    $user = id(new PhabricatorPeopleQuery())
       ->setViewer($viewer)
       ->withPHIDs(array($event->getUserPHID()))
       ->executeOne();
-    if ($handle->isComplete()) {
-      $new_name = $handle->getName();
+
+    if ($user) {
+      $new_name = $user->getUsername();
     } else {
       $new_name = pht('Unnamed Event');
     }

From e3134a1d478e649df86761acb53a3822fb9409bd Mon Sep 17 00:00:00 2001
From: lkassianik <lyubakassianik@gmail.com>
Date: Fri, 15 May 2015 12:17:34 -0700
Subject: [PATCH 18/86] This week should be marked with a bottom blue
 horizontal bar in Calendar month view.

Summary: Closes T8185, This week should be marked with a bottom blue horizontal bar in Calendar month view.

Test Plan: Open calendar month view, "this week" should show a dark blue bar under it and a lighter blue bar on "today".

Reviewers: chad, #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8185

Differential Revision: https://secure.phabricator.com/D12862
---
 resources/celerity/map.php                    |  4 +-
 .../phui/calendar/PHUICalendarMonthView.php   | 47 +++++++++++++++++++
 .../css/phui/calendar/phui-calendar-month.css | 17 +++++--
 3 files changed, 62 insertions(+), 6 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 1b82da2ae9..a6a4fecbae 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -122,7 +122,7 @@ return array(
     'rsrc/css/layout/phabricator-source-code-view.css' => '2ceee894',
     'rsrc/css/phui/calendar/phui-calendar-day.css' => '3b4a65d8',
     'rsrc/css/phui/calendar/phui-calendar-list.css' => '840baa8d',
-    'rsrc/css/phui/calendar/phui-calendar-month.css' => '7819a8b1',
+    'rsrc/css/phui/calendar/phui-calendar-month.css' => '4fba442e',
     'rsrc/css/phui/calendar/phui-calendar.css' => '8345be98',
     'rsrc/css/phui/phui-action-header-view.css' => '89c497e7',
     'rsrc/css/phui/phui-action-list.css' => '4f4d09f2',
@@ -763,7 +763,7 @@ return array(
     'phui-calendar-css' => '8345be98',
     'phui-calendar-day-css' => '3b4a65d8',
     'phui-calendar-list-css' => '840baa8d',
-    'phui-calendar-month-css' => '7819a8b1',
+    'phui-calendar-month-css' => '4fba442e',
     'phui-crumbs-view-css' => '594d719e',
     'phui-document-view-css' => '94d5dcd8',
     'phui-feed-story-css' => 'c9f3a0b5',
diff --git a/src/view/phui/calendar/PHUICalendarMonthView.php b/src/view/phui/calendar/PHUICalendarMonthView.php
index 16e58e3203..fd2ca4e458 100644
--- a/src/view/phui/calendar/PHUICalendarMonthView.php
+++ b/src/view/phui/calendar/PHUICalendarMonthView.php
@@ -228,6 +228,15 @@ final class PHUICalendarMonthView extends AphrontView {
       $today_class = 'phui-calendar-today-slot';
     }
 
+    if ($this->isDateInCurrentWeek($date)) {
+      $today_class .= ' phui-calendar-this-week';
+    }
+
+    $last_week_day = 6;
+    if ($date->format('w') == $last_week_day) {
+      $today_class .= ' last-weekday';
+    }
+
     $today_slot = phutil_tag (
       'div',
       array(
@@ -254,6 +263,16 @@ final class PHUICalendarMonthView extends AphrontView {
       $cell_div);
   }
 
+  private function isDateInCurrentWeek($date) {
+    list($week_start_date, $week_end_date) = $this->getThisWeekRange();
+
+    if ($date->format('U') < $week_end_date->format('U') &&
+      $date->format('U') >= $week_start_date->format('U')) {
+      return true;
+    }
+    return false;
+  }
+
   private function getEventCountBadge($count, $viewer_is_invited) {
     $class = 'phui-calendar-month-count-badge';
 
@@ -484,6 +503,34 @@ final class PHUICalendarMonthView extends AphrontView {
     return $days;
   }
 
+  private function getTodayMidnight() {
+    $viewer = $this->getUser();
+    $today = new DateTime('@'.time());
+    $today->setTimeZone($viewer->getTimeZone());
+    $today->setTime(0, 0, 0);
+
+    return $today;
+  }
+
+  private function getThisWeekRange() {
+    $week_start = 0;
+    $week_end = 6;
+
+    $today = $this->getTodayMidnight();
+    $date_weekday = $today->format('w');
+
+    $days_from_week_start = $date_weekday - $week_start;
+    $days_to_week_end = $week_end - $date_weekday + 1;
+
+    $modify = '-'.$days_from_week_start.' days';
+    $week_start_date = id(clone $today)->modify($modify);
+
+    $modify = '+'.$days_to_week_end.' days';
+    $week_end_date = id(clone $today)->modify($modify);
+
+    return array($week_start_date, $week_end_date);
+  }
+
   private function getDateTime() {
     $user = $this->user;
     $timezone = new DateTimeZone($user->getTimezoneIdentifier());
diff --git a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
index ba268f332f..14d25e7f67 100644
--- a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
+++ b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
@@ -96,7 +96,7 @@ table.phui-calendar-view tr td:first-child {
 
 table.phui-calendar-view a.phui-calendar-date-number {
   color: {$lightgreytext};
-  padding: 0 4px;
+  padding: 4px;
   display: inline-block;
   min-width: 16px;
   text-align: center;
@@ -111,10 +111,19 @@ table.phui-calendar-view td.phui-calendar-date-number-container {
 
 .phui-calendar-today-slot {
   display: block;
-  width: 100%;
   height: 4px;
-  padding: 0;
-  margin: 0;
+  position: absolute;
+  left: 0;
+  right: -1px;
+  bottom: 0;
+}
+
+.phui-calendar-today-slot.last-weekday {
+  right: 0px;
+}
+
+.phui-calendar-today-slot.phui-calendar-this-week {
+  background-color: {$blueborder};
 }
 
 .phui-calendar-today-slot.phui-calendar-today {

From b6733e4a8643dd755c5d4ca5d32f805fecb43408 Mon Sep 17 00:00:00 2001
From: Bob Trahan <btrahan@phacility.com>
Date: Fri, 15 May 2015 13:07:45 -0700
Subject: [PATCH 19/86] Phame - move over post creation and edit to use an
 editor

Summary: This adds the bare minimum transaction set for editing posts. Fixes T7626 because now files will be correctly attached to phame posts on subsequent edits. Future work here should be adding transaction types like `TYPE_BLOG` for when posts are moved between blogs, `TYPE_VISIBILITY` for when posts are moved to published, etc. Nothing too tricky there but keeping this diff relatively small seems prudent.

Test Plan: made posts successfully. also made errors like no title, no phame title, and duplicate phame title and got correct errors. added a file to a post and verified file has phame post in "attached" tab, which should fix T7626.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7626

Differential Revision: https://secure.phabricator.com/D12864
---
 resources/celerity/map.php                    |   4 +-
 .../20150515.phame.post.xaction.sql           |  19 ++
 src/__phutil_library_map__.php                |   7 +
 .../post/PhamePostDeleteController.php        |  11 +-
 .../post/PhamePostEditController.php          | 102 +++++-----
 .../post/PhamePostNewController.php           |  14 +-
 .../post/PhamePostViewController.php          |  24 +--
 .../phame/editor/PhameBlogEditor.php          |   3 -
 .../phame/editor/PhamePostEditor.php          | 165 ++++++++++++++++
 .../phame/query/PhamePostTransactionQuery.php |  10 +
 src/applications/phame/storage/PhamePost.php  |  38 +++-
 .../phame/storage/PhamePostTransaction.php    | 187 ++++++++++++++++++
 12 files changed, 490 insertions(+), 94 deletions(-)
 create mode 100644 resources/sql/autopatches/20150515.phame.post.xaction.sql
 create mode 100644 src/applications/phame/editor/PhamePostEditor.php
 create mode 100644 src/applications/phame/query/PhamePostTransactionQuery.php
 create mode 100644 src/applications/phame/storage/PhamePostTransaction.php

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index a6a4fecbae..9d0c4f7014 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -122,7 +122,7 @@ return array(
     'rsrc/css/layout/phabricator-source-code-view.css' => '2ceee894',
     'rsrc/css/phui/calendar/phui-calendar-day.css' => '3b4a65d8',
     'rsrc/css/phui/calendar/phui-calendar-list.css' => '840baa8d',
-    'rsrc/css/phui/calendar/phui-calendar-month.css' => '4fba442e',
+    'rsrc/css/phui/calendar/phui-calendar-month.css' => 'a6993b38',
     'rsrc/css/phui/calendar/phui-calendar.css' => '8345be98',
     'rsrc/css/phui/phui-action-header-view.css' => '89c497e7',
     'rsrc/css/phui/phui-action-list.css' => '4f4d09f2',
@@ -763,7 +763,7 @@ return array(
     'phui-calendar-css' => '8345be98',
     'phui-calendar-day-css' => '3b4a65d8',
     'phui-calendar-list-css' => '840baa8d',
-    'phui-calendar-month-css' => '4fba442e',
+    'phui-calendar-month-css' => 'a6993b38',
     'phui-crumbs-view-css' => '594d719e',
     'phui-document-view-css' => '94d5dcd8',
     'phui-feed-story-css' => 'c9f3a0b5',
diff --git a/resources/sql/autopatches/20150515.phame.post.xaction.sql b/resources/sql/autopatches/20150515.phame.post.xaction.sql
new file mode 100644
index 0000000000..a39bf52fb7
--- /dev/null
+++ b/resources/sql/autopatches/20150515.phame.post.xaction.sql
@@ -0,0 +1,19 @@
+CREATE TABLE {$NAMESPACE}_phame.phame_posttransaction (
+  id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY,
+  phid VARBINARY(64) NOT NULL,
+  authorPHID VARBINARY(64) NOT NULL,
+  objectPHID VARBINARY(64) NOT NULL,
+  viewPolicy VARBINARY(64) NOT NULL,
+  editPolicy VARBINARY(64) NOT NULL,
+  commentPHID VARBINARY(64) DEFAULT NULL,
+  commentVersion INT UNSIGNED NOT NULL,
+  transactionType VARCHAR(32) COLLATE {$COLLATE_TEXT} NOT NULL,
+  oldValue LONGTEXT COLLATE {$COLLATE_TEXT} NOT NULL,
+  newValue LONGTEXT COLLATE {$COLLATE_TEXT} NOT NULL,
+  contentSource LONGTEXT COLLATE {$COLLATE_TEXT} NOT NULL,
+  metadata LONGTEXT COLLATE {$COLLATE_TEXT} NOT NULL,
+  dateCreated INT UNSIGNED NOT NULL,
+  dateModified INT UNSIGNED NOT NULL,
+  UNIQUE KEY `key_phid` (`phid`),
+  KEY `key_object` (`objectPHID`)
+) ENGINE=InnoDB, COLLATE {$COLLATE_TEXT};
diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index f574caf682..94512f3abd 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -2791,6 +2791,7 @@ phutil_register_library_map(array(
     'PhamePost' => 'applications/phame/storage/PhamePost.php',
     'PhamePostDeleteController' => 'applications/phame/controller/post/PhamePostDeleteController.php',
     'PhamePostEditController' => 'applications/phame/controller/post/PhamePostEditController.php',
+    'PhamePostEditor' => 'applications/phame/editor/PhamePostEditor.php',
     'PhamePostFramedController' => 'applications/phame/controller/post/PhamePostFramedController.php',
     'PhamePostListController' => 'applications/phame/controller/post/PhamePostListController.php',
     'PhamePostNewController' => 'applications/phame/controller/post/PhamePostNewController.php',
@@ -2798,6 +2799,8 @@ phutil_register_library_map(array(
     'PhamePostPreviewController' => 'applications/phame/controller/post/PhamePostPreviewController.php',
     'PhamePostPublishController' => 'applications/phame/controller/post/PhamePostPublishController.php',
     'PhamePostQuery' => 'applications/phame/query/PhamePostQuery.php',
+    'PhamePostTransaction' => 'applications/phame/storage/PhamePostTransaction.php',
+    'PhamePostTransactionQuery' => 'applications/phame/query/PhamePostTransactionQuery.php',
     'PhamePostUnpublishController' => 'applications/phame/controller/post/PhamePostUnpublishController.php',
     'PhamePostView' => 'applications/phame/view/PhamePostView.php',
     'PhamePostViewController' => 'applications/phame/controller/post/PhamePostViewController.php',
@@ -6269,10 +6272,12 @@ phutil_register_library_map(array(
       'PhameDAO',
       'PhabricatorPolicyInterface',
       'PhabricatorMarkupInterface',
+      'PhabricatorApplicationTransactionInterface',
       'PhabricatorTokenReceiverInterface',
     ),
     'PhamePostDeleteController' => 'PhameController',
     'PhamePostEditController' => 'PhameController',
+    'PhamePostEditor' => 'PhabricatorApplicationTransactionEditor',
     'PhamePostFramedController' => 'PhameController',
     'PhamePostListController' => 'PhameController',
     'PhamePostNewController' => 'PhameController',
@@ -6280,6 +6285,8 @@ phutil_register_library_map(array(
     'PhamePostPreviewController' => 'PhameController',
     'PhamePostPublishController' => 'PhameController',
     'PhamePostQuery' => 'PhabricatorCursorPagedPolicyAwareQuery',
+    'PhamePostTransaction' => 'PhabricatorApplicationTransaction',
+    'PhamePostTransactionQuery' => 'PhabricatorApplicationTransactionQuery',
     'PhamePostUnpublishController' => 'PhameController',
     'PhamePostView' => 'AphrontView',
     'PhamePostViewController' => 'PhameController',
diff --git a/src/applications/phame/controller/post/PhamePostDeleteController.php b/src/applications/phame/controller/post/PhamePostDeleteController.php
index a02c0e1cff..80038edd1d 100644
--- a/src/applications/phame/controller/post/PhamePostDeleteController.php
+++ b/src/applications/phame/controller/post/PhamePostDeleteController.php
@@ -2,19 +2,12 @@
 
 final class PhamePostDeleteController extends PhameController {
 
-  private $id;
-
-  public function willProcessRequest(array $data) {
-    $this->id = $data['id'];
-  }
-
-  public function processRequest() {
-    $request = $this->getRequest();
+  public function handleRequest(AphrontRequest $request) {
     $user = $request->getUser();
 
     $post = id(new PhamePostQuery())
       ->setViewer($user)
-      ->withIDs(array($this->id))
+      ->withIDs(array($request->getURIData('id')))
       ->requireCapabilities(
         array(
           PhabricatorPolicyCapability::CAN_EDIT,
diff --git a/src/applications/phame/controller/post/PhamePostEditController.php b/src/applications/phame/controller/post/PhamePostEditController.php
index 6483ae6136..80735f0ad5 100644
--- a/src/applications/phame/controller/post/PhamePostEditController.php
+++ b/src/applications/phame/controller/post/PhamePostEditController.php
@@ -2,20 +2,14 @@
 
 final class PhamePostEditController extends PhameController {
 
-  private $id;
+  public function handleRequest(AphrontRequest $request) {
+    $user = $request->getUser();
+    $id = $request->getURIData('id');
 
-  public function willProcessRequest(array $data) {
-    $this->id = idx($data, 'id');
-  }
-
-  public function processRequest() {
-    $request       = $this->getRequest();
-    $user          = $request->getUser();
-
-    if ($this->id) {
+    if ($id) {
       $post = id(new PhamePostQuery())
         ->setViewer($user)
-        ->withIDs(array($this->id))
+        ->withIDs(array($id))
         ->requireCapabilities(
           array(
             PhabricatorPolicyCapability::CAN_EDIT,
@@ -25,7 +19,7 @@ final class PhamePostEditController extends PhameController {
         return new Aphront404Response();
       }
 
-      $cancel_uri = $this->getApplicationURI('/post/view/'.$this->id.'/');
+      $cancel_uri = $this->getApplicationURI('/post/view/'.$id.'/');
       $submit_button = pht('Save Changes');
       $page_title = pht('Edit Post');
     } else {
@@ -49,44 +43,52 @@ final class PhamePostEditController extends PhameController {
       $page_title    = pht('Create Post');
     }
 
-    $e_phame_title = null;
+    $title           = $post->getTitle();
+    $phame_title     = $post->getPhameTitle();
+    $body            = $post->getBody();
+    $comments_widget = $post->getCommentsWidget();
+
     $e_title       = true;
-    $errors        = array();
-
+    $e_phame_title = true;
+    $validation_exception = null;
     if ($request->isFormPost()) {
-      $comments    = $request->getStr('comments_widget');
-      $data        = array('comments_widget' => $comments);
-      $phame_title = $request->getStr('phame_title');
-      $phame_title = PhabricatorSlug::normalize($phame_title);
-      $title       = $request->getStr('title');
-      $post->setTitle($title);
-      $post->setPhameTitle($phame_title);
-      $post->setBody($request->getStr('body'));
-      $post->setConfigData($data);
+      $title           = $request->getStr('title');
+      $phame_title     = $request->getStr('phame_title');
+      $phame_title     = PhabricatorSlug::normalize($phame_title);
+      $body            = $request->getStr('body');
+      $comments_widget = $request->getStr('comments_widget');
 
-      if ($phame_title == '/') {
-        $errors[]      = pht('Phame title must be nonempty.');
-        $e_phame_title = pht('Required');
-      }
+      $xactions = array(
+        id(new PhamePostTransaction())
+          ->setTransactionType(PhamePostTransaction::TYPE_TITLE)
+          ->setNewValue($title),
+        id(new PhamePostTransaction())
+          ->setTransactionType(PhamePostTransaction::TYPE_PHAME_TITLE)
+          ->setNewValue($phame_title),
+        id(new PhamePostTransaction())
+          ->setTransactionType(PhamePostTransaction::TYPE_BODY)
+          ->setNewValue($body),
+        id(new PhamePostTransaction())
+          ->setTransactionType(PhamePostTransaction::TYPE_COMMENTS_WIDGET)
+          ->setNewValue($comments_widget),
+      );
 
-      if (!strlen($title)) {
-        $errors[] = pht('Title must be nonempty.');
-        $e_title  = pht('Required');
-      } else {
-        $e_title = null;
-      }
+      $editor = id(new PhamePostEditor())
+        ->setActor($user)
+        ->setContentSourceFromRequest($request)
+        ->setContinueOnNoEffect(true);
 
-      if (!$errors) {
-        try {
-          $post->save();
+      try {
+        $editor->applyTransactions($post, $xactions);
 
-          $uri = $this->getApplicationURI('/post/view/'.$post->getID().'/');
-          return id(new AphrontRedirectResponse())->setURI($uri);
-        } catch (AphrontDuplicateKeyQueryException $e) {
-          $e_phame_title = pht('Not Unique');
-          $errors[]      = pht('Another post already uses this slug. '.
-                           'Each post must have a unique slug.');
-        }
+        $uri = $this->getApplicationURI('/post/view/'.$post->getID().'/');
+        return id(new AphrontRedirectResponse())->setURI($uri);
+      } catch (PhabricatorApplicationTransactionValidationException $ex) {
+        $validation_exception = $ex;
+        $e_title = $validation_exception->getShortMessage(
+          PhamePostTransaction::TYPE_TITLE);
+        $e_phame_title = $validation_exception->getShortMessage(
+          PhamePostTransaction::TYPE_PHAME_TITLE);
       }
     }
 
@@ -106,14 +108,14 @@ final class PhamePostEditController extends PhameController {
         id(new AphrontFormTextControl())
         ->setLabel(pht('Title'))
         ->setName('title')
-        ->setValue($post->getTitle())
+        ->setValue($title)
         ->setID('post-title')
         ->setError($e_title))
       ->appendChild(
         id(new AphrontFormTextControl())
         ->setLabel(pht('Phame Title'))
         ->setName('phame_title')
-        ->setValue(rtrim($post->getPhameTitle(), '/'))
+        ->setValue(rtrim($phame_title, '/'))
         ->setID('post-phame-title')
         ->setCaption(pht('Up to 64 alphanumeric characters '.
                      'with underscores for spaces. '.
@@ -123,7 +125,7 @@ final class PhamePostEditController extends PhameController {
         id(new PhabricatorRemarkupControl())
         ->setLabel(pht('Body'))
         ->setName('body')
-        ->setValue($post->getBody())
+        ->setValue($body)
         ->setHeight(AphrontFormTextAreaControl::HEIGHT_VERY_TALL)
         ->setID('post-body')
         ->setUser($user)
@@ -132,7 +134,7 @@ final class PhamePostEditController extends PhameController {
         id(new AphrontFormSelectControl())
         ->setLabel(pht('Comments Widget'))
         ->setName('comments_widget')
-        ->setvalue($post->getCommentsWidget())
+        ->setvalue($comments_widget)
         ->setOptions($post->getCommentsWidgetOptionsForSelect()))
       ->appendChild(
         id(new AphrontFormSubmitControl())
@@ -161,13 +163,13 @@ final class PhamePostEditController extends PhameController {
 
     $form_box = id(new PHUIObjectBoxView())
       ->setHeaderText($page_title)
-      ->setFormErrors($errors)
+      ->setValidationException($validation_exception)
       ->setForm($form);
 
     $crumbs = $this->buildApplicationCrumbs();
     $crumbs->addTextCrumb(
       $page_title,
-      $this->getApplicationURI('/post/view/'.$this->id.'/'));
+      $this->getApplicationURI('/post/view/'.$id.'/'));
 
     $nav = $this->renderSideNavFilterView(null);
     $nav->appendChild(
diff --git a/src/applications/phame/controller/post/PhamePostNewController.php b/src/applications/phame/controller/post/PhamePostNewController.php
index fd1ae47e89..94d8651f27 100644
--- a/src/applications/phame/controller/post/PhamePostNewController.php
+++ b/src/applications/phame/controller/post/PhamePostNewController.php
@@ -2,22 +2,16 @@
 
 final class PhamePostNewController extends PhameController {
 
-  private $id;
-
-  public function willProcessRequest(array $data) {
-    $this->id = idx($data, 'id');
-  }
-
-  public function processRequest() {
-    $request = $this->getRequest();
+  public function handleRequest(AphrontRequest $request) {
     $user = $request->getUser();
+    $id = $request->getURIData('id');
 
     $post = null;
     $view_uri = null;
-    if ($this->id) {
+    if ($id) {
       $post = id(new PhamePostQuery())
         ->setViewer($user)
-        ->withIDs(array($this->id))
+        ->withIDs(array($id))
         ->requireCapabilities(
           array(
             PhabricatorPolicyCapability::CAN_EDIT,
diff --git a/src/applications/phame/controller/post/PhamePostViewController.php b/src/applications/phame/controller/post/PhamePostViewController.php
index c451167e3b..c1f6405377 100644
--- a/src/applications/phame/controller/post/PhamePostViewController.php
+++ b/src/applications/phame/controller/post/PhamePostViewController.php
@@ -2,19 +2,12 @@
 
 final class PhamePostViewController extends PhameController {
 
-  private $id;
-
-  public function willProcessRequest(array $data) {
-    $this->id = $data['id'];
-  }
-
-  public function processRequest() {
-    $request = $this->getRequest();
+  public function handleRequest(AphrontRequest $request) {
     $user = $request->getUser();
 
     $post = id(new PhamePostQuery())
       ->setViewer($user)
-      ->withIDs(array($this->id))
+      ->withIDs(array($request->getURIData('id')))
       ->executeOne();
 
     if (!$post) {
@@ -65,7 +58,10 @@ final class PhamePostViewController extends PhameController {
     $nav->appendChild(
       array(
         $object_box,
-      ));
+        $this->buildTransactionTimeline(
+          $post,
+          new PhamePostTransactionQuery()),
+        ));
 
     return $this->buildApplicationPage(
       $nav,
@@ -78,10 +74,10 @@ final class PhamePostViewController extends PhameController {
     PhamePost $post,
     PhabricatorUser $user) {
 
-    $actions = id(new PhabricatorActionListView())
-      ->setObject($post)
-      ->setObjectURI($this->getRequest()->getRequestURI())
-      ->setUser($user);
+      $actions = id(new PhabricatorActionListView())
+        ->setObject($post)
+        ->setObjectURI($this->getRequest()->getRequestURI())
+        ->setUser($user);
 
     $can_edit = PhabricatorPolicyFilter::hasCapability(
       $user,
diff --git a/src/applications/phame/editor/PhameBlogEditor.php b/src/applications/phame/editor/PhameBlogEditor.php
index 5b837038b7..f44be159c8 100644
--- a/src/applications/phame/editor/PhameBlogEditor.php
+++ b/src/applications/phame/editor/PhameBlogEditor.php
@@ -76,8 +76,6 @@ final class PhameBlogEditor
       case PhabricatorTransactions::TYPE_JOIN_POLICY:
         $object->setJoinPolicy($xaction->getNewValue());
         return;
-      case PhabricatorTransactions::TYPE_COMMENT:
-        return;
     }
 
     return parent::applyCustomInternalTransaction($object, $xaction);
@@ -95,7 +93,6 @@ final class PhameBlogEditor
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
       case PhabricatorTransactions::TYPE_JOIN_POLICY:
-      case PhabricatorTransactions::TYPE_COMMENT:
         return;
     }
 
diff --git a/src/applications/phame/editor/PhamePostEditor.php b/src/applications/phame/editor/PhamePostEditor.php
new file mode 100644
index 0000000000..ef6cd21307
--- /dev/null
+++ b/src/applications/phame/editor/PhamePostEditor.php
@@ -0,0 +1,165 @@
+<?php
+
+final class PhamePostEditor
+  extends PhabricatorApplicationTransactionEditor {
+
+  public function getEditorApplicationClass() {
+    return 'PhabricatorPhameApplication';
+  }
+
+  public function getEditorObjectsDescription() {
+    return pht('Blog Posts');
+  }
+
+  public function getTransactionTypes() {
+    $types = parent::getTransactionTypes();
+
+    $types[] = PhamePostTransaction::TYPE_TITLE;
+    $types[] = PhamePostTransaction::TYPE_PHAME_TITLE;
+    $types[] = PhamePostTransaction::TYPE_BODY;
+    $types[] = PhamePostTransaction::TYPE_COMMENTS_WIDGET;
+
+    return $types;
+  }
+
+  protected function getCustomTransactionOldValue(
+    PhabricatorLiskDAO $object,
+    PhabricatorApplicationTransaction $xaction) {
+
+    switch ($xaction->getTransactionType()) {
+      case PhamePostTransaction::TYPE_TITLE:
+        return $object->getTitle();
+      case PhamePostTransaction::TYPE_PHAME_TITLE:
+        return $object->getPhameTitle();
+      case PhamePostTransaction::TYPE_BODY:
+        return $object->getBody();
+      case PhamePostTransaction::TYPE_COMMENTS_WIDGET:
+        return $object->getCommentsWidget();
+    }
+  }
+
+  protected function getCustomTransactionNewValue(
+    PhabricatorLiskDAO $object,
+    PhabricatorApplicationTransaction $xaction) {
+
+    switch ($xaction->getTransactionType()) {
+      case PhamePostTransaction::TYPE_TITLE:
+      case PhamePostTransaction::TYPE_PHAME_TITLE:
+      case PhamePostTransaction::TYPE_BODY:
+      case PhamePostTransaction::TYPE_COMMENTS_WIDGET:
+        return $xaction->getNewValue();
+    }
+  }
+
+  protected function applyCustomInternalTransaction(
+    PhabricatorLiskDAO $object,
+    PhabricatorApplicationTransaction $xaction) {
+
+    switch ($xaction->getTransactionType()) {
+      case PhamePostTransaction::TYPE_TITLE:
+        return $object->setTitle($xaction->getNewValue());
+      case PhamePostTransaction::TYPE_PHAME_TITLE:
+        return $object->setPhameTitle($xaction->getNewValue());
+      case PhamePostTransaction::TYPE_BODY:
+        return $object->setBody($xaction->getNewValue());
+      case PhamePostTransaction::TYPE_COMMENTS_WIDGET:
+        return $object->setCommentsWidget($xaction->getNewValue());
+    }
+
+    return parent::applyCustomInternalTransaction($object, $xaction);
+  }
+
+  protected function applyCustomExternalTransaction(
+    PhabricatorLiskDAO $object,
+    PhabricatorApplicationTransaction $xaction) {
+
+    switch ($xaction->getTransactionType()) {
+      case PhamePostTransaction::TYPE_TITLE:
+      case PhamePostTransaction::TYPE_PHAME_TITLE:
+      case PhamePostTransaction::TYPE_BODY:
+      case PhamePostTransaction::TYPE_COMMENTS_WIDGET:
+        return;
+    }
+
+    return parent::applyCustomExternalTransaction($object, $xaction);
+  }
+
+  protected function validateTransaction(
+    PhabricatorLiskDAO $object,
+    $type,
+    array $xactions) {
+
+    $errors = parent::validateTransaction($object, $type, $xactions);
+
+    switch ($type) {
+      case PhamePostTransaction::TYPE_TITLE:
+        $missing = $this->validateIsEmptyTextField(
+          $object->getTitle(),
+          $xactions);
+
+        if ($missing) {
+          $error = new PhabricatorApplicationTransactionValidationError(
+            $type,
+            pht('Required'),
+            pht('Title is required.'),
+            nonempty(last($xactions), null));
+
+          $error->setIsMissingFieldError(true);
+          $errors[] = $error;
+        }
+        break;
+      case PhamePostTransaction::TYPE_PHAME_TITLE:
+        $missing = $this->validateIsEmptyTextField(
+          $object->getPhameTitle(),
+          $xactions);
+        $phame_title = last($xactions)->getNewValue();
+
+        if ($missing || $phame_title == '/') {
+          $error = new PhabricatorApplicationTransactionValidationError(
+            $type,
+            pht('Required'),
+            pht('Phame title is required.'),
+            nonempty(last($xactions), null));
+
+          $error->setIsMissingFieldError(true);
+          $errors[] = $error;
+        }
+
+        $duplicate_post = id(new PhamePostQuery())
+          ->setViewer(PhabricatorUser::getOmnipotentUser())
+          ->withPhameTitles(array($phame_title))
+          ->executeOne();
+        if ($duplicate_post && $duplicate_post->getID() != $object->getID()) {
+          $error_text = pht(
+            'Phame title must be unique; another post already has this phame '.
+            'title.');
+          $error = new PhabricatorApplicationTransactionValidationError(
+            $type,
+            pht('Not Unique'),
+            $error_text,
+            nonempty(last($xactions), null));
+          $errors[] = $error;
+        }
+
+        break;
+    }
+    return $errors;
+  }
+
+  protected function shouldSendMail(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
+    return false;
+  }
+
+  protected function shouldPublishFeedStory(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
+    return false;
+  }
+
+  protected function supportsSearch() {
+    return false;
+  }
+
+}
diff --git a/src/applications/phame/query/PhamePostTransactionQuery.php b/src/applications/phame/query/PhamePostTransactionQuery.php
new file mode 100644
index 0000000000..879b6363e3
--- /dev/null
+++ b/src/applications/phame/query/PhamePostTransactionQuery.php
@@ -0,0 +1,10 @@
+<?php
+
+final class PhamePostTransactionQuery
+  extends PhabricatorApplicationTransactionQuery {
+
+  public function getTemplateApplicationTransaction() {
+    return new PhamePostTransaction();
+  }
+
+}
diff --git a/src/applications/phame/storage/PhamePost.php b/src/applications/phame/storage/PhamePost.php
index f99c1bda97..8a02a7c564 100644
--- a/src/applications/phame/storage/PhamePost.php
+++ b/src/applications/phame/storage/PhamePost.php
@@ -4,6 +4,7 @@ final class PhamePost extends PhameDAO
   implements
     PhabricatorPolicyInterface,
     PhabricatorMarkupInterface,
+    PhabricatorApplicationTransactionInterface,
     PhabricatorTokenReceiverInterface {
 
   const MARKUP_FIELD_BODY    = 'markup:body';
@@ -74,6 +75,12 @@ final class PhamePost extends PhameDAO
     return $name;
   }
 
+  public function setCommentsWidget($widget) {
+    $config_data = $this->getConfigData();
+    $config_data['comments_widget'] = $widget;
+    return $this;
+  }
+
   public function getCommentsWidget() {
     $config_data = $this->getConfigData();
     if (empty($config_data)) {
@@ -181,7 +188,6 @@ final class PhamePost extends PhameDAO
     );
   }
 
-
   public function getPolicy($capability) {
     // Draft posts are visible only to the author. Published posts are visible
     // to whoever the blog is visible to.
@@ -199,7 +205,6 @@ final class PhamePost extends PhameDAO
     }
   }
 
-
   public function hasAutomaticCapability($capability, PhabricatorUser $user) {
     // A blog post's author can always view it, and is the only user allowed
     // to edit it.
@@ -211,7 +216,6 @@ final class PhamePost extends PhameDAO
     }
   }
 
-
   public function describeAutomaticCapability($capability) {
     return pht(
       'The author of a blog post can always view and edit it.');
@@ -226,12 +230,10 @@ final class PhamePost extends PhameDAO
     return $this->getPHID().':'.$field.':'.$hash;
   }
 
-
   public function newMarkupEngine($field) {
     return PhabricatorMarkupEngine::newPhameMarkupEngine();
   }
 
-
   public function getMarkupText($field) {
     switch ($field) {
       case self::MARKUP_FIELD_BODY:
@@ -248,13 +250,37 @@ final class PhamePost extends PhameDAO
     return $output;
   }
 
-
   public function shouldUseMarkupCache($field) {
     return (bool)$this->getPHID();
   }
 
+
+/* -(  PhabricatorApplicationTransactionInterface  )------------------------- */
+
+
+  public function getApplicationTransactionEditor() {
+    return new PhamePostEditor();
+  }
+
+  public function getApplicationTransactionObject() {
+    return $this;
+  }
+
+  public function getApplicationTransactionTemplate() {
+    return new PhamePostTransaction();
+  }
+
+  public function willRenderTimeline(
+    PhabricatorApplicationTransactionView $timeline,
+    AphrontRequest $request) {
+
+    return $timeline;
+  }
+
+
 /* -(  PhabricatorTokenReceiverInterface  )---------------------------------- */
 
+
   public function getUsersToNotifyOfTokenGiven() {
     return array(
       $this->getBloggerPHID(),
diff --git a/src/applications/phame/storage/PhamePostTransaction.php b/src/applications/phame/storage/PhamePostTransaction.php
new file mode 100644
index 0000000000..04841cda9f
--- /dev/null
+++ b/src/applications/phame/storage/PhamePostTransaction.php
@@ -0,0 +1,187 @@
+<?php
+
+final class PhamePostTransaction
+  extends PhabricatorApplicationTransaction {
+
+  const TYPE_TITLE           = 'phame.post.title';
+  const TYPE_PHAME_TITLE     = 'phame.post.phame.title';
+  const TYPE_BODY            = 'phame.post.body';
+  const TYPE_COMMENTS_WIDGET = 'phame.post.comments.widget';
+
+  public function getApplicationName() {
+    return 'phame';
+  }
+
+  public function getApplicationTransactionType() {
+    return PhabricatorPhamePostPHIDType::TYPECONST;
+  }
+
+  public function getRemarkupBlocks() {
+    $blocks = parent::getRemarkupBlocks();
+
+    switch ($this->getTransactionType()) {
+      case self::TYPE_BODY:
+        $blocks[] = $this->getNewValue();
+        break;
+    }
+
+    return $blocks;
+  }
+
+  public function shouldHide() {
+    $old = $this->getOldValue();
+    switch ($this->getTransactionType()) {
+      case self::TYPE_PHAME_TITLE:
+      case self::TYPE_BODY:
+        return ($old === null);
+    }
+    return parent::shouldHide();
+  }
+
+  public function getIcon() {
+    $old = $this->getOldValue();
+    switch ($this->getTransactionType()) {
+      case self::TYPE_TITLE:
+        if ($old === null) {
+          return 'fa-plus';
+        } else {
+          return 'fa-pencil';
+        }
+        break;
+      case self::TYPE_PHAME_TITLE:
+      case self::TYPE_BODY:
+      case self::TYPE_COMMENTS_WIDGET:
+        return 'fa-pencil';
+        break;
+    }
+    return parent::getIcon();
+  }
+
+  public function getTitle() {
+    $author_phid = $this->getAuthorPHID();
+    $object_phid = $this->getObjectPHID();
+
+    $old = $this->getOldValue();
+    $new = $this->getNewValue();
+
+    $type = $this->getTransactionType();
+    switch ($type) {
+      case self::TYPE_TITLE:
+        if ($old === null) {
+          return pht(
+            '%s created this post.',
+            $this->renderHandleLink($author_phid));
+        } else {
+          return pht(
+            '%s updated the post\'s name to "%s".',
+            $this->renderHandleLink($author_phid),
+            $new);
+        }
+        break;
+      case self::TYPE_BODY:
+        return pht(
+          '%s updated the post\'s body.',
+          $this->renderHandleLink($author_phid));
+        break;
+      case self::TYPE_PHAME_TITLE:
+        return pht(
+          '%s updated the post\'s phame title to "%s".',
+          $this->renderHandleLink($author_phid),
+          rtrim($new, '/'));
+        break;
+      case self::TYPE_COMMENTS_WIDGET:
+        return pht(
+          '%s updated the post\'s comment widget to "%s".',
+          $this->renderHandleLink($author_phid),
+          $new);
+        break;
+    }
+
+    return parent::getTitle();
+  }
+
+  public function getTitleForFeed() {
+    $author_phid = $this->getAuthorPHID();
+    $object_phid = $this->getObjectPHID();
+
+    $old = $this->getOldValue();
+    $new = $this->getNewValue();
+
+    $type = $this->getTransactionType();
+    switch ($type) {
+      case self::TYPE_TITLE:
+        if ($old === null) {
+          return pht(
+            '%s created %s.',
+            $this->renderHandleLink($author_phid),
+            $this->renderHandleLink($object_phid));
+        } else {
+          return pht(
+            '%s updated the name for %s.',
+            $this->renderHandleLink($author_phid),
+            $this->renderHandleLink($object_phid));
+        }
+        break;
+      case self::TYPE_BODY:
+        return pht(
+          '%s updated the body for %s.',
+          $this->renderHandleLink($author_phid),
+          $this->renderHandleLink($object_phid));
+        break;
+      case self::TYPE_PHAME_TITLE:
+        return pht(
+          '%s updated the phame title for %s.',
+          $this->renderHandleLink($author_phid),
+          $this->renderHandleLink($object_phid));
+        break;
+      case self::TYPE_COMMENTS_WIDGET:
+        return pht(
+          '%s updated the comments widget for %s.',
+          $this->renderHandleLink($author_phid),
+          $this->renderHandleLink($object_phid));
+        break;
+    }
+
+    return parent::getTitleForFeed();
+  }
+
+  public function getColor() {
+    $old = $this->getOldValue();
+
+    switch ($this->getTransactionType()) {
+      case self::TYPE_TITLE:
+        if ($old === null) {
+          return PhabricatorTransactions::COLOR_GREEN;
+        }
+        break;
+    }
+
+    return parent::getColor();
+  }
+
+
+  public function hasChangeDetails() {
+    switch ($this->getTransactionType()) {
+      case self::TYPE_BODY:
+        return ($this->getOldValue() !== null);
+    }
+
+    return parent::hasChangeDetails();
+  }
+
+  public function renderChangeDetails(PhabricatorUser $viewer) {
+    switch ($this->getTransactionType()) {
+      case self::TYPE_BODY:
+        $old = $this->getOldValue();
+        $new = $this->getNewValue();
+
+        return $this->renderTextCorpusChangeDetails(
+          $viewer,
+          $old,
+          $new);
+    }
+
+    return parent::renderChangeDetails($viewer);
+  }
+
+}

From 3ef0721adacce6e94eb855bb2a97b70733a6a3b2 Mon Sep 17 00:00:00 2001
From: Bob Trahan <btrahan@phacility.com>
Date: Fri, 15 May 2015 14:07:17 -0700
Subject: [PATCH 20/86] Reduce PhabricatorUser::getOmnipotentUser calls by
 adding a getViewer method to PhbaricatorDestructionEngine

Summary:
Fixes T6956. Before this change, we called PhabricatorUser::getOmnipotentUser in the various delete methods to query the data. Now, we use $engine->getViewer(), since its always a good thing to have less calls to PhabricatorUser::getOmnipotentUser thrown around the codebase.

I used the "codemod" tool to audit the existing calls to PhabricatorDestructorEngine (all of them) so ostensibly this gets all the spots. If I missed something though, its still going to work, so this change is very low risk.

Test Plan: ./bin/remove destroy P1; visit P1 and get a 404

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6956

Differential Revision: https://secure.phabricator.com/D12866
---
 src/applications/almanac/storage/AlmanacDevice.php            | 2 +-
 src/applications/almanac/storage/AlmanacInterface.php         | 2 +-
 src/applications/almanac/storage/AlmanacNetwork.php           | 2 +-
 src/applications/almanac/storage/AlmanacService.php           | 2 +-
 .../differential/storage/DifferentialRevision.php             | 2 +-
 src/applications/diviner/storage/DivinerLiveBook.php          | 2 +-
 .../files/controller/PhabricatorFileTransformController.php   | 4 ++--
 src/applications/files/storage/PhabricatorFileChunk.php       | 2 +-
 src/applications/paste/storage/PhabricatorPaste.php           | 2 +-
 .../system/engine/PhabricatorDestructionEngine.php            | 4 ++++
 10 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/src/applications/almanac/storage/AlmanacDevice.php b/src/applications/almanac/storage/AlmanacDevice.php
index 19ee3f89ff..d0994174b3 100644
--- a/src/applications/almanac/storage/AlmanacDevice.php
+++ b/src/applications/almanac/storage/AlmanacDevice.php
@@ -240,7 +240,7 @@ final class AlmanacDevice
     PhabricatorDestructionEngine $engine) {
 
     $interfaces = id(new AlmanacInterfaceQuery())
-      ->setViewer(PhabricatorUser::getOmnipotentUser())
+      ->setViewer($engine->getViewer())
       ->withDevicePHIDs(array($this->getPHID()))
       ->execute();
     foreach ($interfaces as $interface) {
diff --git a/src/applications/almanac/storage/AlmanacInterface.php b/src/applications/almanac/storage/AlmanacInterface.php
index 5ab892cef7..729e95aa9a 100644
--- a/src/applications/almanac/storage/AlmanacInterface.php
+++ b/src/applications/almanac/storage/AlmanacInterface.php
@@ -119,7 +119,7 @@ final class AlmanacInterface
     PhabricatorDestructionEngine $engine) {
 
     $bindings = id(new AlmanacBindingQuery())
-      ->setViewer($this->getViewer())
+      ->setViewer($engine->getViewer())
       ->withInterfacePHIDs(array($this->getPHID()))
       ->execute();
     foreach ($bindings as $binding) {
diff --git a/src/applications/almanac/storage/AlmanacNetwork.php b/src/applications/almanac/storage/AlmanacNetwork.php
index 92d4b8fa47..a623248fd9 100644
--- a/src/applications/almanac/storage/AlmanacNetwork.php
+++ b/src/applications/almanac/storage/AlmanacNetwork.php
@@ -103,7 +103,7 @@ final class AlmanacNetwork
     PhabricatorDestructionEngine $engine) {
 
     $interfaces = id(new AlmanacInterfaceQuery())
-      ->setViewer(PhabricatorUser::getOmnipotentUser())
+      ->setViewer($engine->getViewer())
       ->withNetworkPHIDs(array($this->getPHID()))
       ->execute();
 
diff --git a/src/applications/almanac/storage/AlmanacService.php b/src/applications/almanac/storage/AlmanacService.php
index 36c7761e22..b351f0d3fc 100644
--- a/src/applications/almanac/storage/AlmanacService.php
+++ b/src/applications/almanac/storage/AlmanacService.php
@@ -221,7 +221,7 @@ final class AlmanacService
     PhabricatorDestructionEngine $engine) {
 
     $bindings = id(new AlmanacBindingQuery())
-      ->setViewer(PhabricatorUser::getOmnipotentUser())
+      ->setViewer($engine->getViewer())
       ->withServicePHIDs(array($this->getPHID()))
       ->execute();
     foreach ($bindings as $binding) {
diff --git a/src/applications/differential/storage/DifferentialRevision.php b/src/applications/differential/storage/DifferentialRevision.php
index 74f3ff34d7..e6baa678e9 100644
--- a/src/applications/differential/storage/DifferentialRevision.php
+++ b/src/applications/differential/storage/DifferentialRevision.php
@@ -550,7 +550,7 @@ final class DifferentialRevision extends DifferentialDAO
 
     $this->openTransaction();
       $diffs = id(new DifferentialDiffQuery())
-        ->setViewer(PhabricatorUser::getOmnipotentUser())
+        ->setViewer($engine->getViewer())
         ->withRevisionIDs(array($this->getID()))
         ->execute();
       foreach ($diffs as $diff) {
diff --git a/src/applications/diviner/storage/DivinerLiveBook.php b/src/applications/diviner/storage/DivinerLiveBook.php
index 68a6f8a0ec..ef7a9bb277 100644
--- a/src/applications/diviner/storage/DivinerLiveBook.php
+++ b/src/applications/diviner/storage/DivinerLiveBook.php
@@ -91,7 +91,7 @@ final class DivinerLiveBook extends DivinerDAO
 
     $this->openTransaction();
       $atoms = id(new DivinerAtomQuery())
-        ->setViewer(PhabricatorUser::getOmnipotentUser())
+        ->setViewer($engine->getViewer())
         ->withBookPHIDs(array($this->getPHID()))
         ->withIncludeGhosts(true)
         ->withIncludeUndocumentable(true)
diff --git a/src/applications/files/controller/PhabricatorFileTransformController.php b/src/applications/files/controller/PhabricatorFileTransformController.php
index 5062fe76fc..0e7e2b73d7 100644
--- a/src/applications/files/controller/PhabricatorFileTransformController.php
+++ b/src/applications/files/controller/PhabricatorFileTransformController.php
@@ -104,8 +104,9 @@ final class PhabricatorFileTransformController
   }
 
   private function destroyTransform(PhabricatorTransformedFile $xform) {
+    $engine = new PhabricatorDestructionEngine();
     $file = id(new PhabricatorFileQuery())
-      ->setViewer(PhabricatorUser::getOmnipotentUser())
+      ->setViewer($engine->getViewer())
       ->withPHIDs(array($xform->getTransformedPHID()))
       ->executeOne();
 
@@ -114,7 +115,6 @@ final class PhabricatorFileTransformController
     if (!$file) {
       $xform->delete();
     } else {
-      $engine = new PhabricatorDestructionEngine();
       $engine->destroyObject($file);
     }
 
diff --git a/src/applications/files/storage/PhabricatorFileChunk.php b/src/applications/files/storage/PhabricatorFileChunk.php
index b69a421fed..eaa10acd63 100644
--- a/src/applications/files/storage/PhabricatorFileChunk.php
+++ b/src/applications/files/storage/PhabricatorFileChunk.php
@@ -91,7 +91,7 @@ final class PhabricatorFileChunk extends PhabricatorFileDAO
     $data_phid = $this->getDataFilePHID();
     if ($data_phid) {
       $data_file = id(new PhabricatorFileQuery())
-        ->setViewer(PhabricatorUser::getOmnipotentUser())
+        ->setViewer($engine->getViewer())
         ->withPHIDs(array($data_phid))
         ->executeOne();
       if ($data_file) {
diff --git a/src/applications/paste/storage/PhabricatorPaste.php b/src/applications/paste/storage/PhabricatorPaste.php
index 9eb88a77b4..3a0ae754e7 100644
--- a/src/applications/paste/storage/PhabricatorPaste.php
+++ b/src/applications/paste/storage/PhabricatorPaste.php
@@ -172,7 +172,7 @@ final class PhabricatorPaste extends PhabricatorPasteDAO
 
     if ($this->filePHID) {
       $file = id(new PhabricatorFileQuery())
-        ->setViewer(PhabricatorUser::getOmnipotentUser())
+        ->setViewer($engine->getViewer())
         ->withPHIDs(array($this->filePHID))
         ->executeOne();
       if ($file) {
diff --git a/src/applications/system/engine/PhabricatorDestructionEngine.php b/src/applications/system/engine/PhabricatorDestructionEngine.php
index b55b336052..c5b813169c 100644
--- a/src/applications/system/engine/PhabricatorDestructionEngine.php
+++ b/src/applications/system/engine/PhabricatorDestructionEngine.php
@@ -4,6 +4,10 @@ final class PhabricatorDestructionEngine extends Phobject {
 
   private $rootLogID;
 
+  public function getViewer() {
+    return PhabricatorUser::getOmnipotentUser();
+  }
+
   public function destroyObject(PhabricatorDestructibleInterface $object) {
     $log = id(new PhabricatorSystemDestructionLog())
       ->setEpoch(time())

From fa82c17079de3639e438643ffb85485edd2643e5 Mon Sep 17 00:00:00 2001
From: Bob Trahan <btrahan@phacility.com>
Date: Fri, 15 May 2015 16:33:31 -0700
Subject: [PATCH 21/86] Projects - add mail to project updates

Summary:
...which lets all the fancy settings for Email | Notify | Off be possible. Fixes T8164. Wasn't too sure the best way to break things up but members vs watchers felt meaningful to break out to me.

Also fixes a small bug where we were generating bad slug updated stories by messing with the signature of the slug data. Perhaps this fix isn't even good enough (the array_keys()) call and instead we'll need to implement transaction has effect and do a sort?

Test Plan: used ./bin/mail list-outbound and ./bin/mail show-outbound --id XX to verify reasonable emails were being generated. saw new preferences in settings.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8164

Differential Revision: https://secure.phabricator.com/D12868
---
 src/__phutil_library_map__.php                |  2 +
 .../PhabricatorProjectTransactionEditor.php   | 73 +++++++++++++++++--
 .../project/mail/ProjectReplyHandler.php      | 20 +++++
 .../storage/PhabricatorProjectTransaction.php | 48 +++++++++++-
 ...habricatorApplicationTransactionEditor.php |  8 ++
 5 files changed, 145 insertions(+), 6 deletions(-)
 create mode 100644 src/applications/project/mail/ProjectReplyHandler.php

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index 94512f3abd..3ccb046634 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -3101,6 +3101,7 @@ phutil_register_library_map(array(
     'ProjectQueryConduitAPIMethod' => 'applications/project/conduit/ProjectQueryConduitAPIMethod.php',
     'ProjectRemarkupRule' => 'applications/project/remarkup/ProjectRemarkupRule.php',
     'ProjectRemarkupRuleTestCase' => 'applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php',
+    'ProjectReplyHandler' => 'applications/project/mail/ProjectReplyHandler.php',
     'QueryFormattingTestCase' => 'infrastructure/storage/__tests__/QueryFormattingTestCase.php',
     'ReleephAuthorFieldSpecification' => 'applications/releeph/field/specification/ReleephAuthorFieldSpecification.php',
     'ReleephBranch' => 'applications/releeph/storage/ReleephBranch.php',
@@ -6670,6 +6671,7 @@ phutil_register_library_map(array(
     'ProjectQueryConduitAPIMethod' => 'ProjectConduitAPIMethod',
     'ProjectRemarkupRule' => 'PhabricatorObjectRemarkupRule',
     'ProjectRemarkupRuleTestCase' => 'PhabricatorTestCase',
+    'ProjectReplyHandler' => 'PhabricatorApplicationTransactionReplyHandler',
     'QueryFormattingTestCase' => 'PhabricatorTestCase',
     'ReleephAuthorFieldSpecification' => 'ReleephFieldSpecification',
     'ReleephBranch' => array(
diff --git a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
index 98c4ad1797..502623685c 100644
--- a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
+++ b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
@@ -41,7 +41,7 @@ final class PhabricatorProjectTransactionEditor
         $slugs = $object->getSlugs();
         $slugs = mpull($slugs, 'getSlug', 'getSlug');
         unset($slugs[$object->getPrimarySlug()]);
-        return $slugs;
+        return array_keys($slugs);
       case PhabricatorProjectTransaction::TYPE_STATUS:
         return $object->getStatus();
       case PhabricatorProjectTransaction::TYPE_IMAGE:
@@ -403,11 +403,74 @@ final class PhabricatorProjectTransactionEditor
     return parent::requireCapabilities($object, $xaction);
   }
 
-  /**
-   * Note: this is implemented for Feed purposes.
-   */
+  protected function loadEdges(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
+
+    $member_phids = PhabricatorEdgeQuery::loadDestinationPHIDs(
+      $object->getPHID(),
+      PhabricatorProjectProjectHasMemberEdgeType::EDGECONST);
+    $object->attachMemberPHIDs($member_phids);
+  }
+
+  protected function shouldSendMail(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
+    return true;
+  }
+
+  protected function getMailSubjectPrefix() {
+    return pht('[Project]');
+  }
+
   protected function getMailTo(PhabricatorLiskDAO $object) {
-    return array();
+    return $object->getMemberPHIDs();
+  }
+
+  protected function getMailCC(PhabricatorLiskDAO $object) {
+    $all = parent::getMailCC($object);
+    return array_diff($all, $object->getMemberPHIDs());
+  }
+
+  public function getMailTagsMap() {
+    return array(
+      PhabricatorProjectTransaction::MAILTAG_METADATA =>
+        pht('Project name, hashtags, icon, image, or color changes.'),
+      PhabricatorProjectTransaction::MAILTAG_MEMBERS =>
+        pht('Project membership changes.'),
+      PhabricatorProjectTransaction::MAILTAG_WATCHERS =>
+        pht('Project watcher list changes.'),
+      PhabricatorProjectTransaction::MAILTAG_OTHER =>
+        pht('Other project activity not listed above occurs.'),
+    );
+  }
+
+  protected function buildReplyHandler(PhabricatorLiskDAO $object) {
+    return id(new ProjectReplyHandler())
+      ->setMailReceiver($object);
+  }
+
+  protected function buildMailTemplate(PhabricatorLiskDAO $object) {
+    $id = $object->getID();
+    $name = $object->getName();
+
+    return id(new PhabricatorMetaMTAMail())
+      ->setSubject("{$name}")
+      ->addHeader('Thread-Topic', "Project {$id}");
+  }
+
+  protected function buildMailBody(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
+
+    $body = parent::buildMailBody($object, $xactions);
+
+    $uri = '/project/profile/'.$object->getID().'/';
+    $body->addLinkSection(
+      pht('PROJECT DETAIL'),
+      PhabricatorEnv::getProductionURI($uri));
+
+    return $body;
   }
 
   protected function shouldPublishFeedStory(
diff --git a/src/applications/project/mail/ProjectReplyHandler.php b/src/applications/project/mail/ProjectReplyHandler.php
new file mode 100644
index 0000000000..ac2cf2b6eb
--- /dev/null
+++ b/src/applications/project/mail/ProjectReplyHandler.php
@@ -0,0 +1,20 @@
+<?php
+
+final class ProjectReplyHandler
+  extends PhabricatorApplicationTransactionReplyHandler {
+
+  public function validateMailReceiver($mail_receiver) {
+    if (!($mail_receiver instanceof PhabricatorProject)) {
+      throw new Exception('Mail receiver is not a PhabricatorProject.');
+    }
+  }
+
+  public function getObjectPrefix() {
+    return PhabricatorProjectProjectPHIDType::TYPECONST;
+  }
+
+  protected function shouldCreateCommentFromMailBody() {
+    return false;
+  }
+
+}
diff --git a/src/applications/project/storage/PhabricatorProjectTransaction.php b/src/applications/project/storage/PhabricatorProjectTransaction.php
index 3dceb0934c..692c41d736 100644
--- a/src/applications/project/storage/PhabricatorProjectTransaction.php
+++ b/src/applications/project/storage/PhabricatorProjectTransaction.php
@@ -14,6 +14,11 @@ final class PhabricatorProjectTransaction
   // NOTE: This is deprecated, members are just a normal edge now.
   const TYPE_MEMBERS    = 'project:members';
 
+  const MAILTAG_METADATA = 'project-metadata';
+  const MAILTAG_MEMBERS  = 'project-members';
+  const MAILTAG_WATCHERS = 'project-watchers';
+  const MAILTAG_OTHER    = 'project-other';
+
   public function getApplicationName() {
     return 'project';
   }
@@ -106,6 +111,8 @@ final class PhabricatorProjectTransaction
             $old,
             $new);
         }
+        break;
+
       case self::TYPE_STATUS:
         if ($old == 0) {
           return pht(
@@ -116,6 +123,8 @@ final class PhabricatorProjectTransaction
             '%s activated this project.',
             $author_handle);
         }
+        break;
+
       case self::TYPE_IMAGE:
         // TODO: Some day, it would be nice to show the images.
         if (!$old) {
@@ -134,18 +143,21 @@ final class PhabricatorProjectTransaction
             $this->renderHandleLink($old),
             $this->renderHandleLink($new));
         }
+        break;
 
       case self::TYPE_ICON:
         return pht(
           '%s set this project\'s icon to %s.',
           $author_handle,
           PhabricatorProjectIcon::getLabel($new));
+        break;
 
       case self::TYPE_COLOR:
         return pht(
           '%s set this project\'s color to %s.',
           $author_handle,
           PHUITagView::getShadeName($new));
+        break;
 
       case self::TYPE_LOCKED:
         if ($new) {
@@ -157,6 +169,7 @@ final class PhabricatorProjectTransaction
             '%s unlocked this project\'s membership.',
             $author_handle);
         }
+        break;
 
       case self::TYPE_SLUGS:
         $add = array_diff($new, $old);
@@ -183,6 +196,7 @@ final class PhabricatorProjectTransaction
               count($rem),
               $this->renderSlugList($rem));
         }
+        break;
 
       case self::TYPE_MEMBERS:
         $add = array_diff($new, $old);
@@ -221,6 +235,7 @@ final class PhabricatorProjectTransaction
               $this->renderHandleList($rem));
           }
         }
+        break;
     }
 
     return parent::getTitle();
@@ -339,12 +354,43 @@ final class PhabricatorProjectTransaction
             $object_handle,
             $this->renderSlugList($rem));
         }
-
     }
 
     return parent::getTitleForFeed();
   }
 
+  public function getMailTags() {
+    $tags = array();
+    switch ($this->getTransactionType()) {
+      case self::TYPE_NAME:
+      case self::TYPE_SLUGS:
+      case self::TYPE_IMAGE:
+      case self::TYPE_ICON:
+      case self::TYPE_COLOR:
+        $tags[] = self::MAILTAG_METADATA;
+        break;
+      case PhabricatorTransactions::TYPE_EDGE:
+        $type = $this->getMetadata('edge:type');
+        $type = head($type);
+        $type_member = PhabricatorProjectProjectHasMemberEdgeType::EDGECONST;
+        $type_watcher = PhabricatorObjectHasWatcherEdgeType::EDGECONST;
+        if ($type == $type_member) {
+          $tags[] = self::MAILTAG_MEMBERS;
+        } else if ($type == $type_watcher) {
+          $tags[] = self::MAILTAG_WATCHERS;
+        } else {
+          $tags[] = self::MAILTAG_OTHER;
+        }
+        break;
+      case self::TYPE_STATUS:
+      case self::TYPE_LOCKED:
+      default:
+        $tags[] = self::MAILTAG_OTHER;
+        break;
+    }
+    return $tags;
+  }
+
   private function renderSlugList($slugs) {
     return implode(', ', $slugs);
   }
diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
index dfd4bba286..6b070efaf9 100644
--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
@@ -840,6 +840,8 @@ abstract class PhabricatorApplicationTransactionEditor
     // subscribers to pick up changes caused by Herald (or by other side effects
     // in various transaction phases).
     $this->loadSubscribers($object);
+    // Hook for other edges that may need (re-)loading
+    $this->loadEdges($object, $xactions);
 
     $this->loadHandles($xactions);
 
@@ -965,6 +967,12 @@ abstract class PhabricatorApplicationTransactionEditor
     }
   }
 
+  protected function loadEdges(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
+    return;
+  }
+
   private function validateEditParameters(
     PhabricatorLiskDAO $object,
     array $xactions) {

From 72a896f772b7e925b08f8cc5a69bef38f358b2db Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Sat, 16 May 2015 06:13:27 -0700
Subject: [PATCH 22/86] Add missing mail keys to Projects

Ref T8216.

Auditors: btrahan
---
 .../autopatches/20150515.project.mailkey.1.sql |  2 ++
 .../autopatches/20150515.project.mailkey.2.php | 18 ++++++++++++++++++
 .../project/storage/PhabricatorProject.php     |  2 ++
 3 files changed, 22 insertions(+)
 create mode 100644 resources/sql/autopatches/20150515.project.mailkey.1.sql
 create mode 100644 resources/sql/autopatches/20150515.project.mailkey.2.php

diff --git a/resources/sql/autopatches/20150515.project.mailkey.1.sql b/resources/sql/autopatches/20150515.project.mailkey.1.sql
new file mode 100644
index 0000000000..277fbdafda
--- /dev/null
+++ b/resources/sql/autopatches/20150515.project.mailkey.1.sql
@@ -0,0 +1,2 @@
+ALTER TABLE {$NAMESPACE}_project.project
+  ADD mailKey binary(20) NOT NULL;
diff --git a/resources/sql/autopatches/20150515.project.mailkey.2.php b/resources/sql/autopatches/20150515.project.mailkey.2.php
new file mode 100644
index 0000000000..358c57d96d
--- /dev/null
+++ b/resources/sql/autopatches/20150515.project.mailkey.2.php
@@ -0,0 +1,18 @@
+<?php
+
+$table = new PhabricatorProject();
+$conn_w = $table->establishConnection('w');
+$iterator = new LiskMigrationIterator($table);
+foreach ($iterator as $project) {
+  $id = $project->getID();
+
+  echo pht('Adding mail key for project %d...', $id);
+  echo "\n";
+
+  queryfx(
+    $conn_w,
+    'UPDATE %T SET mailKey = %s WHERE id = %d',
+    $table->getTableName(),
+    Filesystem::readRandomCharacters(20),
+    $id);
+}
diff --git a/src/applications/project/storage/PhabricatorProject.php b/src/applications/project/storage/PhabricatorProject.php
index df013e1616..de3b00c4b6 100644
--- a/src/applications/project/storage/PhabricatorProject.php
+++ b/src/applications/project/storage/PhabricatorProject.php
@@ -17,6 +17,7 @@ final class PhabricatorProject extends PhabricatorProjectDAO
   protected $profileImagePHID;
   protected $icon;
   protected $color;
+  protected $mailKey;
 
   protected $viewPolicy;
   protected $editPolicy;
@@ -142,6 +143,7 @@ final class PhabricatorProject extends PhabricatorProjectDAO
         'profileImagePHID' => 'phid?',
         'icon' => 'text32',
         'color' => 'text32',
+        'mailKey' => 'bytes20',
 
         // T6203/NULLABILITY
         // These are definitely wrong and should always exist.

From dbac6580257094323056a8c48b9d02ee0dabb7e5 Mon Sep 17 00:00:00 2001
From: lkassianik <lyubakassianik@gmail.com>
Date: Sat, 16 May 2015 17:21:37 -0700
Subject: [PATCH 23/86] Split up settings into "Date and Time Settings" and
 everything else.

Summary: Ref T8176, Split up settings into "Date and Time Settings" and everything else.

Test Plan: Open /settings, Account Settings should now have two tabs: "Account" and "Date and Time"

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8176

Differential Revision: https://secure.phabricator.com/D12881
---
 src/__phutil_library_map__.php                |  2 +
 .../panel/PhabricatorAccountSettingsPanel.php | 50 +----------
 .../PhabricatorDateTimeSettingsPanel.php      | 89 +++++++++++++++++++
 3 files changed, 95 insertions(+), 46 deletions(-)
 create mode 100644 src/applications/settings/panel/PhabricatorDateTimeSettingsPanel.php

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index 3ccb046634..edadae1253 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -1742,6 +1742,7 @@ phutil_register_library_map(array(
     'PhabricatorDataCacheSpec' => 'applications/cache/spec/PhabricatorDataCacheSpec.php',
     'PhabricatorDataNotAttachedException' => 'infrastructure/storage/lisk/PhabricatorDataNotAttachedException.php',
     'PhabricatorDatabaseSetupCheck' => 'applications/config/check/PhabricatorDatabaseSetupCheck.php',
+    'PhabricatorDateTimeSettingsPanel' => 'applications/settings/panel/PhabricatorDateTimeSettingsPanel.php',
     'PhabricatorDebugController' => 'applications/system/controller/PhabricatorDebugController.php',
     'PhabricatorDefaultSearchEngineSelector' => 'applications/search/selector/PhabricatorDefaultSearchEngineSelector.php',
     'PhabricatorDestructibleInterface' => 'applications/system/interface/PhabricatorDestructibleInterface.php',
@@ -5134,6 +5135,7 @@ phutil_register_library_map(array(
     'PhabricatorDataCacheSpec' => 'PhabricatorCacheSpec',
     'PhabricatorDataNotAttachedException' => 'Exception',
     'PhabricatorDatabaseSetupCheck' => 'PhabricatorSetupCheck',
+    'PhabricatorDateTimeSettingsPanel' => 'PhabricatorSettingsPanel',
     'PhabricatorDebugController' => 'PhabricatorController',
     'PhabricatorDefaultSearchEngineSelector' => 'PhabricatorSearchEngineSelector',
     'PhabricatorDestructionEngine' => 'Phobject',
diff --git a/src/applications/settings/panel/PhabricatorAccountSettingsPanel.php b/src/applications/settings/panel/PhabricatorAccountSettingsPanel.php
index 9353d9523f..7acd5e0a54 100644
--- a/src/applications/settings/panel/PhabricatorAccountSettingsPanel.php
+++ b/src/applications/settings/panel/PhabricatorAccountSettingsPanel.php
@@ -18,18 +18,8 @@ final class PhabricatorAccountSettingsPanel extends PhabricatorSettingsPanel {
     $user = $request->getUser();
     $username = $user->getUsername();
 
-    $pref_time = PhabricatorUserPreferences::PREFERENCE_TIME_FORMAT;
-    $preferences = $user->loadPreferences();
-
     $errors = array();
     if ($request->isFormPost()) {
-      $new_timezone = $request->getStr('timezone');
-      if (in_array($new_timezone, DateTimeZone::listIdentifiers(), true)) {
-        $user->setTimezoneIdentifier($new_timezone);
-      } else {
-        $errors[] = pht('The selected timezone is not a valid timezone.');
-      }
-
       $sex = $request->getStr('sex');
       $sexes = array(PhutilPerson::SEX_MALE, PhutilPerson::SEX_FEMALE);
       if (in_array($sex, $sexes)) {
@@ -41,19 +31,13 @@ final class PhabricatorAccountSettingsPanel extends PhabricatorSettingsPanel {
       // Checked in runtime.
       $user->setTranslation($request->getStr('translation'));
 
-      $preferences->setPreference($pref_time, $request->getStr($pref_time));
-
       if (!$errors) {
-        $preferences->save();
         $user->save();
         return id(new AphrontRedirectResponse())
           ->setURI($this->getPanelURI('?saved=true'));
       }
     }
 
-    $timezone_ids = DateTimeZone::listIdentifiers();
-    $timezone_id_map = array_fuse($timezone_ids);
-
     $label_unknown = pht('%s updated their profile', $username);
     $label_her = pht('%s updated her profile', $username);
     $label_his = pht('%s updated his profile', $username);
@@ -93,10 +77,10 @@ final class PhabricatorAccountSettingsPanel extends PhabricatorSettingsPanel {
       ->setUser($user)
       ->appendChild(
         id(new AphrontFormSelectControl())
-          ->setLabel(pht('Timezone'))
-          ->setName('timezone')
-          ->setOptions($timezone_id_map)
-          ->setValue($user->getTimezoneIdentifier()))
+          ->setOptions($translations)
+          ->setLabel(pht('Translation'))
+          ->setName('translation')
+          ->setValue($user->getTranslation()))
       ->appendRemarkupInstructions(pht('**Choose the pronoun you prefer:**'))
       ->appendChild(
         id(new AphrontFormSelectControl())
@@ -104,32 +88,6 @@ final class PhabricatorAccountSettingsPanel extends PhabricatorSettingsPanel {
           ->setLabel(pht('Pronoun'))
           ->setName('sex')
           ->setValue($user->getSex()))
-      ->appendChild(
-        id(new AphrontFormSelectControl())
-          ->setOptions($translations)
-          ->setLabel(pht('Translation'))
-          ->setName('translation')
-          ->setValue($user->getTranslation()))
-      ->appendRemarkupInstructions(
-        pht(
-          "**Custom Date and Time Formats**\n\n".
-          "You can specify custom formats which will be used when ".
-          "rendering dates and times of day. Examples:\n\n".
-          "| Format  | Example  | Notes |\n".
-          "| ------  | -------- | ----- |\n".
-          "| `g:i A` | 2:34 PM  | Default 12-hour time. |\n".
-          "| `G.i a` | 02.34 pm | Alternate 12-hour time. |\n".
-          "| `H:i`   | 14:34    | 24-hour time. |\n".
-          "\n\n".
-          "You can find a [[%s | full reference in the PHP manual]].",
-          'http://www.php.net/manual/en/function.date.php'))
-      ->appendChild(
-        id(new AphrontFormTextControl())
-          ->setLabel(pht('Time-of-Day Format'))
-          ->setName($pref_time)
-          ->setCaption(
-            pht('Format used when rendering a time of day.'))
-          ->setValue($preferences->getPreference($pref_time)))
       ->appendChild(
         id(new AphrontFormSubmitControl())
           ->setValue(pht('Save Account Settings')));
diff --git a/src/applications/settings/panel/PhabricatorDateTimeSettingsPanel.php b/src/applications/settings/panel/PhabricatorDateTimeSettingsPanel.php
new file mode 100644
index 0000000000..661a1172b7
--- /dev/null
+++ b/src/applications/settings/panel/PhabricatorDateTimeSettingsPanel.php
@@ -0,0 +1,89 @@
+<?php
+
+final class PhabricatorDateTimeSettingsPanel extends PhabricatorSettingsPanel {
+
+  public function getPanelKey() {
+    return 'datetime';
+  }
+
+  public function getPanelName() {
+    return pht('Date and Time');
+  }
+
+  public function getPanelGroup() {
+    return pht('Account Information');
+  }
+
+  public function processRequest(AphrontRequest $request) {
+    $user = $request->getUser();
+    $username = $user->getUsername();
+
+    $pref_time = PhabricatorUserPreferences::PREFERENCE_TIME_FORMAT;
+    $preferences = $user->loadPreferences();
+
+    $errors = array();
+    if ($request->isFormPost()) {
+      $new_timezone = $request->getStr('timezone');
+      if (in_array($new_timezone, DateTimeZone::listIdentifiers(), true)) {
+        $user->setTimezoneIdentifier($new_timezone);
+      } else {
+        $errors[] = pht('The selected timezone is not a valid timezone.');
+      }
+
+      $preferences->setPreference($pref_time, $request->getStr($pref_time));
+
+      if (!$errors) {
+        $preferences->save();
+        $user->save();
+        return id(new AphrontRedirectResponse())
+          ->setURI($this->getPanelURI('?saved=true'));
+      }
+    }
+
+    $timezone_ids = DateTimeZone::listIdentifiers();
+    $timezone_id_map = array_fuse($timezone_ids);
+
+    $form = new AphrontFormView();
+    $form
+      ->setUser($user)
+      ->appendChild(
+        id(new AphrontFormSelectControl())
+          ->setLabel(pht('Timezone'))
+          ->setName('timezone')
+          ->setOptions($timezone_id_map)
+          ->setValue($user->getTimezoneIdentifier()))
+      ->appendRemarkupInstructions(
+        pht(
+          "**Custom Date and Time Formats**\n\n".
+          "You can specify custom formats which will be used when ".
+          "rendering dates and times of day. Examples:\n\n".
+          "| Format  | Example  | Notes |\n".
+          "| ------  | -------- | ----- |\n".
+          "| `g:i A` | 2:34 PM  | Default 12-hour time. |\n".
+          "| `G.i a` | 02.34 pm | Alternate 12-hour time. |\n".
+          "| `H:i`   | 14:34    | 24-hour time. |\n".
+          "\n\n".
+          "You can find a [[%s | full reference in the PHP manual]].",
+          'http://www.php.net/manual/en/function.date.php'))
+      ->appendChild(
+        id(new AphrontFormTextControl())
+          ->setLabel(pht('Time-of-Day Format'))
+          ->setName($pref_time)
+          ->setCaption(
+            pht('Format used when rendering a time of day.'))
+          ->setValue($preferences->getPreference($pref_time)))
+      ->appendChild(
+        id(new AphrontFormSubmitControl())
+          ->setValue(pht('Save Account Settings')));
+
+    $form_box = id(new PHUIObjectBoxView())
+      ->setHeaderText(pht('Date and Time Settings'))
+      ->setFormSaved($request->getStr('saved'))
+      ->setFormErrors($errors)
+      ->setForm($form);
+
+    return array(
+      $form_box,
+    );
+  }
+}

From 1f6b53be0e0d25af16b25236e6ccb58cc7a645ac Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Sat, 16 May 2015 19:39:22 -0700
Subject: [PATCH 24/86] Populate mail keys for new projects

Ref T8216.

Auditors: btrahan
---
 src/applications/project/storage/PhabricatorProject.php | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/applications/project/storage/PhabricatorProject.php b/src/applications/project/storage/PhabricatorProject.php
index de3b00c4b6..e5e6e19554 100644
--- a/src/applications/project/storage/PhabricatorProject.php
+++ b/src/applications/project/storage/PhabricatorProject.php
@@ -275,6 +275,10 @@ final class PhabricatorProject extends PhabricatorProjectDAO
   }
 
   public function save() {
+    if (!$this->getMailKey()) {
+      $this->setMailKey(Filesystem::readRandomCharacters(20));
+    }
+
     $this->openTransaction();
       $result = parent::save();
       $this->updateDatasourceTokens();

From 31988e74d1ff99dbf6e868358b4d2409ab4007f7 Mon Sep 17 00:00:00 2001
From: lkassianik <lyubakassianik@gmail.com>
Date: Sat, 16 May 2015 20:13:25 -0700
Subject: [PATCH 25/86] Add a setting so user can choose when Calendar weeks
 start

Summary: Closes T8176, Add a setting so user can choose when Calendar weeks start

Test Plan: Open account settings, go to "Date and Time", change week start day, open Calendar, observe that month view responds to new week start day.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8176

Differential Revision: https://secure.phabricator.com/D12884
---
 .../PhabricatorCalendarEventSearchEngine.php  | 18 ++--
 .../PhabricatorDateTimeSettingsPanel.php      | 28 ++++++-
 .../storage/PhabricatorUserPreferences.php    |  1 +
 .../phui/calendar/PHUICalendarMonthView.php   | 82 ++++++++++---------
 4 files changed, 82 insertions(+), 47 deletions(-)

diff --git a/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php b/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
index 7added162f..4f65202a2c 100644
--- a/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
+++ b/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
@@ -76,9 +76,11 @@ final class PhabricatorCalendarEventSearchEngine
       $display_start = $start_day->format('U');
       $display_end = $next->format('U');
 
-      // 0 = Sunday is always the start of the week, for now
-      $start_of_week = 0;
-      $end_of_week = 6 - $start_of_week;
+      $preferences = $viewer->loadPreferences();
+      $pref_week_day = PhabricatorUserPreferences::PREFERENCE_WEEK_START_DAY;
+
+      $start_of_week = $preferences->getPreference($pref_week_day, 0);
+      $end_of_week = ($start_of_week + 6) % 7;
 
       $first_of_month = $start_day->format('w');
       $last_of_month = id(clone $next)->modify('-1 day')->format('w');
@@ -87,9 +89,10 @@ final class PhabricatorCalendarEventSearchEngine
         $min_range = $display_start;
 
         if ($this->isMonthView($saved) &&
-          $first_of_month > $start_of_week) {
+          $first_of_month !== $start_of_week) {
+          $interim_day_num = ($first_of_month + 7 - $start_of_week) % 7;
           $min_range = id(clone $start_day)
-            ->modify('-'.$first_of_month.' days')
+            ->modify('-'.$interim_day_num.' days')
             ->format('U');
         }
       }
@@ -97,9 +100,10 @@ final class PhabricatorCalendarEventSearchEngine
         $max_range = $display_end;
 
         if ($this->isMonthView($saved) &&
-          $last_of_month < $end_of_week) {
+          $last_of_month !== $end_of_week) {
+          $interim_day_num = ($end_of_week + 7 - $last_of_month) % 7;
           $max_range = id(clone $next)
-            ->modify('+'.(6 - $first_of_month).' days')
+            ->modify('+'.$interim_day_num.' days')
             ->format('U');
         }
 
diff --git a/src/applications/settings/panel/PhabricatorDateTimeSettingsPanel.php b/src/applications/settings/panel/PhabricatorDateTimeSettingsPanel.php
index 661a1172b7..5fbf825d22 100644
--- a/src/applications/settings/panel/PhabricatorDateTimeSettingsPanel.php
+++ b/src/applications/settings/panel/PhabricatorDateTimeSettingsPanel.php
@@ -19,6 +19,7 @@ final class PhabricatorDateTimeSettingsPanel extends PhabricatorSettingsPanel {
     $username = $user->getUsername();
 
     $pref_time = PhabricatorUserPreferences::PREFERENCE_TIME_FORMAT;
+    $pref_week_start = PhabricatorUserPreferences::PREFERENCE_WEEK_START_DAY;
     $preferences = $user->loadPreferences();
 
     $errors = array();
@@ -30,7 +31,12 @@ final class PhabricatorDateTimeSettingsPanel extends PhabricatorSettingsPanel {
         $errors[] = pht('The selected timezone is not a valid timezone.');
       }
 
-      $preferences->setPreference($pref_time, $request->getStr($pref_time));
+      $preferences->setPreference(
+        $pref_time,
+        $request->getStr($pref_time));
+      $preferences->setPreference(
+        $pref_week_start,
+        $request->getStr($pref_week_start));
 
       if (!$errors) {
         $preferences->save();
@@ -72,6 +78,14 @@ final class PhabricatorDateTimeSettingsPanel extends PhabricatorSettingsPanel {
           ->setCaption(
             pht('Format used when rendering a time of day.'))
           ->setValue($preferences->getPreference($pref_time)))
+      ->appendChild(
+        id(new AphrontFormSelectControl())
+          ->setLabel(pht('Week Starts On'))
+          ->setOptions($this->getWeekDays())
+          ->setName($pref_week_start)
+          ->setCaption(
+            pht('Calendar weeks will start with this day.'))
+          ->setValue($preferences->getPreference($pref_week_start, 0)))
       ->appendChild(
         id(new AphrontFormSubmitControl())
           ->setValue(pht('Save Account Settings')));
@@ -86,4 +100,16 @@ final class PhabricatorDateTimeSettingsPanel extends PhabricatorSettingsPanel {
       $form_box,
     );
   }
+
+  private function getWeekDays() {
+    return array(
+      pht('Sunday'),
+      pht('Monday'),
+      pht('Tuesday'),
+      pht('Wednesday'),
+      pht('Thursday'),
+      pht('Friday'),
+      pht('Saturday'),
+    );
+  }
 }
diff --git a/src/applications/settings/storage/PhabricatorUserPreferences.php b/src/applications/settings/storage/PhabricatorUserPreferences.php
index 3248dc8b2a..7732df5568 100644
--- a/src/applications/settings/storage/PhabricatorUserPreferences.php
+++ b/src/applications/settings/storage/PhabricatorUserPreferences.php
@@ -9,6 +9,7 @@ final class PhabricatorUserPreferences extends PhabricatorUserDAO {
   const PREFERENCE_TITLES               = 'titles';
   const PREFERENCE_MONOSPACED_TEXTAREAS = 'monospaced-textareas';
   const PREFERENCE_TIME_FORMAT          = 'time-format';
+  const PREFERENCE_WEEK_START_DAY       = 'week-start-day';
 
   const PREFERENCE_RE_PREFIX            = 're-prefix';
   const PREFERENCE_NO_SELF_MAIL         = 'self-mail';
diff --git a/src/view/phui/calendar/PHUICalendarMonthView.php b/src/view/phui/calendar/PHUICalendarMonthView.php
index fd2ca4e458..d6bb7d1a32 100644
--- a/src/view/phui/calendar/PHUICalendarMonthView.php
+++ b/src/view/phui/calendar/PHUICalendarMonthView.php
@@ -59,24 +59,10 @@ final class PHUICalendarMonthView extends AphrontView {
     $days = $this->getDatesInMonth();
 
     $cell_lists = array();
-    $empty_cell = array(
-        'list' => null,
-        'date' => null,
-        'uri' => null,
-        'count' => 0,
-        'class' => null,
-      );
 
     require_celerity_resource('phui-calendar-month-css');
 
     $first = reset($days);
-    $start_of_week = 0;
-
-    $empty = $first->format('w');
-
-    for ($ii = 0; $ii < $empty; $ii++) {
-      $cell_lists[] = $empty_cell;
-    }
 
     foreach ($days as $day) {
       $day_number = $day->format('j');
@@ -133,9 +119,6 @@ final class PHUICalendarMonthView extends AphrontView {
 
     foreach ($cell_lists_by_week as $week_of_cell_lists) {
       $cells = array();
-      while (count($week_of_cell_lists) < 7) {
-        $week_of_cell_lists[] = $empty_cell;
-      }
       foreach ($week_of_cell_lists as $cell_list) {
         $cells[] = $this->getEventListCell($cell_list);
       }
@@ -309,18 +292,28 @@ final class PHUICalendarMonthView extends AphrontView {
   }
 
   private function getDayNamesHeader() {
+    list($week_start, $week_end) = $this->getWeekStartAndEnd();
+
+    $weekday_names = array(
+      $this->getDayHeader(pht('Sun'), pht('Sunday'), true),
+      $this->getDayHeader(pht('Mon'), pht('Monday')),
+      $this->getDayHeader(pht('Tue'), pht('Tuesday')),
+      $this->getDayHeader(pht('Wed'), pht('Wednesday')),
+      $this->getDayHeader(pht('Thu'), pht('Thursday')),
+      $this->getDayHeader(pht('Fri'), pht('Friday')),
+      $this->getDayHeader(pht('Sat'), pht('Saturday'), true),
+    );
+
+    $sorted_weekday_names = array();
+
+    for ($i = $week_start; $i < ($week_start + 7); $i++) {
+      $sorted_weekday_names[] = $weekday_names[$i % 7];
+    }
+
     return phutil_tag(
       'tr',
       array('class' => 'phui-calendar-day-of-week-header'),
-      array(
-        $this->getDayHeader(pht('Sun'), pht('Sunday'), true),
-        $this->getDayHeader(pht('Mon'), pht('Monday')),
-        $this->getDayHeader(pht('Tue'), pht('Tuesday')),
-        $this->getDayHeader(pht('Wed'), pht('Wednesday')),
-        $this->getDayHeader(pht('Thu'), pht('Thursday')),
-        $this->getDayHeader(pht('Fri'), pht('Friday')),
-        $this->getDayHeader(pht('Sat'), pht('Saturday'), true),
-      ));
+      $sorted_weekday_names);
   }
 
   private function getDayHeader($short, $long, $is_weekend = false) {
@@ -466,8 +459,8 @@ final class PHUICalendarMonthView extends AphrontView {
     list($next_year, $next_month) = $this->getNextYearAndMonth();
     $end_date = new DateTime("{$next_year}-{$next_month}-01", $timezone);
 
-    $start_of_week = 0;
-    $end_of_week = 6 - $start_of_week;
+    list($start_of_week, $end_of_week) = $this->getWeekStartAndEnd();
+
     $days_in_month = id(clone $end_date)->modify('-1 day')->format('d');
 
     $first_month_day_date = new DateTime("{$year}-{$month}-01", $timezone);
@@ -477,17 +470,19 @@ final class PHUICalendarMonthView extends AphrontView {
     $last_weekday_of_month = $last_month_day_date->format('w');
 
     $num_days_display = $days_in_month;
-    if ($start_of_week < $first_weekday_of_month) {
-      $num_days_display += $first_weekday_of_month;
+    if ($start_of_week !== $first_weekday_of_month) {
+      $interim_start_num = ($first_weekday_of_month + 7 - $start_of_week) % 7;
+      $num_days_display += $interim_start_num;
+      $day_date = id(clone $first_month_day_date)
+        ->modify('-'.$interim_start_num.' days');
     }
-    if ($end_of_week > $last_weekday_of_month) {
-      $num_days_display += (6 - $last_weekday_of_month);
-      $end_date->modify('+'.(6 - $last_weekday_of_month).' days');
+    if ($end_of_week !== $last_weekday_of_month) {
+      $interim_end_day_num = ($end_of_week - $last_weekday_of_month + 7) % 7;
+      $num_days_display += $interim_end_day_num;
+      $end_date->modify('+'.$interim_end_day_num.' days');
     }
 
     $days = array();
-    $day_date = id(clone $first_month_day_date)
-      ->modify('-'.$first_weekday_of_month.' days');
 
     for ($day = 1; $day <= $num_days_display; $day++) {
       $day_epoch = $day_date->format('U');
@@ -513,14 +508,13 @@ final class PHUICalendarMonthView extends AphrontView {
   }
 
   private function getThisWeekRange() {
-    $week_start = 0;
-    $week_end = 6;
+    list($week_start, $week_end) = $this->getWeekStartAndEnd();
 
     $today = $this->getTodayMidnight();
     $date_weekday = $today->format('w');
 
-    $days_from_week_start = $date_weekday - $week_start;
-    $days_to_week_end = $week_end - $date_weekday + 1;
+    $days_from_week_start = ($date_weekday + 7 - $week_start) % 7;
+    $days_to_week_end = 7 - $days_from_week_start;
 
     $modify = '-'.$days_from_week_start.' days';
     $week_start_date = id(clone $today)->modify($modify);
@@ -531,6 +525,16 @@ final class PHUICalendarMonthView extends AphrontView {
     return array($week_start_date, $week_end_date);
   }
 
+  private function getWeekStartAndEnd() {
+    $preferences = $this->user->loadPreferences();
+    $pref_week_start = PhabricatorUserPreferences::PREFERENCE_WEEK_START_DAY;
+
+    $week_start = $preferences->getPreference($pref_week_start, 0);
+    $week_end = ($week_start + 6) % 7;
+
+    return array($week_start, $week_end);
+  }
+
   private function getDateTime() {
     $user = $this->user;
     $timezone = new DateTimeZone($user->getTimezoneIdentifier());

From 00136f05dd6d3e2bbc8772b12dacaa23ea805307 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Sun, 17 May 2015 07:18:44 -0700
Subject: [PATCH 26/86] Allow adding Auditors with the singular noun.

Summary: Currently adding auditors in commit message only works with the plural. Make "Auditor: bla" work.

Test Plan: Unit tests. I don't know if I am supposed to add a test.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: joshuaspence, epriestley

Differential Revision: https://secure.phabricator.com/D10636
---
 src/applications/audit/editor/PhabricatorAuditEditor.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/applications/audit/editor/PhabricatorAuditEditor.php b/src/applications/audit/editor/PhabricatorAuditEditor.php
index 587af71850..d30a4061b7 100644
--- a/src/applications/audit/editor/PhabricatorAuditEditor.php
+++ b/src/applications/audit/editor/PhabricatorAuditEditor.php
@@ -418,7 +418,7 @@ final class PhabricatorAuditEditor
     $message = $data->getCommitMessage();
 
     $matches = null;
-    if (!preg_match('/^Auditors:\s*(.*)$/im', $message, $matches)) {
+    if (!preg_match('/^Auditors?:\s*(.*)$/im', $message, $matches)) {
       return array();
     }
 

From 5f797b4d478b6ab657f7e71d90cac4c611f8ae8f Mon Sep 17 00:00:00 2001
From: Arturas Moskvinas <arturas@uber.com>
Date: Sun, 17 May 2015 07:25:03 -0700
Subject: [PATCH 27/86] Recover from repositories becoming unpullable

Test Plan: If a repository's tracking flag is toggled while it's in queue, we may loop indefinitely.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11296
---
 .../repository/daemon/PhabricatorRepositoryPullLocalDaemon.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php b/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php
index 0dd2041316..ff96dced3c 100644
--- a/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php
+++ b/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php
@@ -150,7 +150,8 @@ final class PhabricatorRepositoryPullLocalDaemon
           if (!$repository) {
             $this->log(
               pht('Repository %s is no longer pullable; skipping.', $id));
-            break;
+            unset($queue[$id]);
+            continue;
           }
 
           $monogram = $repository->getMonogram();

From f087d7c08a02348aa84c0aa0efbfe4a53ef77222 Mon Sep 17 00:00:00 2001
From: lkassianik <lyubakassianik@gmail.com>
Date: Sun, 17 May 2015 12:31:26 -0700
Subject: [PATCH 28/86] Add week numbers to Calendar month view.

Summary: Closes T8184, Add week numbers to Calendar month view.

Test Plan: Calendar month view should now show week numbers, incrementing on Mondays, regardless of week start day.

Reviewers: chad, #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8184

Differential Revision: https://secure.phabricator.com/D12886
---
 resources/celerity/map.php                           |  4 ++--
 src/view/phui/calendar/PHUICalendarMonthView.php     | 12 ++++++++++++
 .../rsrc/css/phui/calendar/phui-calendar-month.css   |  9 +++++++++
 3 files changed, 23 insertions(+), 2 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 9d0c4f7014..3aecd78dfc 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -122,7 +122,7 @@ return array(
     'rsrc/css/layout/phabricator-source-code-view.css' => '2ceee894',
     'rsrc/css/phui/calendar/phui-calendar-day.css' => '3b4a65d8',
     'rsrc/css/phui/calendar/phui-calendar-list.css' => '840baa8d',
-    'rsrc/css/phui/calendar/phui-calendar-month.css' => 'a6993b38',
+    'rsrc/css/phui/calendar/phui-calendar-month.css' => '5b213ea0',
     'rsrc/css/phui/calendar/phui-calendar.css' => '8345be98',
     'rsrc/css/phui/phui-action-header-view.css' => '89c497e7',
     'rsrc/css/phui/phui-action-list.css' => '4f4d09f2',
@@ -763,7 +763,7 @@ return array(
     'phui-calendar-css' => '8345be98',
     'phui-calendar-day-css' => '3b4a65d8',
     'phui-calendar-list-css' => '840baa8d',
-    'phui-calendar-month-css' => 'a6993b38',
+    'phui-calendar-month-css' => '5b213ea0',
     'phui-crumbs-view-css' => '594d719e',
     'phui-document-view-css' => '94d5dcd8',
     'phui-feed-story-css' => 'c9f3a0b5',
diff --git a/src/view/phui/calendar/PHUICalendarMonthView.php b/src/view/phui/calendar/PHUICalendarMonthView.php
index d6bb7d1a32..df692d271d 100644
--- a/src/view/phui/calendar/PHUICalendarMonthView.php
+++ b/src/view/phui/calendar/PHUICalendarMonthView.php
@@ -189,6 +189,7 @@ final class PHUICalendarMonthView extends AphrontView {
     $class = $event_list['class'];
     $date = $event_list['date'];
     $cell_day_secret_link = null;
+    $week_number = null;
 
     if ($date) {
       $uri = $event_list['uri'];
@@ -201,6 +202,16 @@ final class PHUICalendarMonthView extends AphrontView {
           'href' => $uri,
         ),
         $date->format('j'));
+
+      if ($date->format('w') == 1) {
+        $week_number = phutil_tag(
+          'a',
+          array(
+            'class' => 'phui-calendar-week-number',
+            'href' => $uri,
+          ),
+          $date->format('W'));
+      }
     } else {
       $cell_day = null;
     }
@@ -234,6 +245,7 @@ final class PHUICalendarMonthView extends AphrontView {
       ),
       array(
         $cell_day_secret_link,
+        $week_number,
         $cell_day,
         $today_slot,
       ));
diff --git a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
index 14d25e7f67..6b5c0aeb86 100644
--- a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
+++ b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
@@ -94,6 +94,15 @@ table.phui-calendar-view tr td:first-child {
   color: {$green};
 }
 
+table.phui-calendar-view a.phui-calendar-week-number {
+  color: {$lightgreyborder};
+  padding: 4px;
+  display: inline-block;
+  min-width: 16px;
+  text-align: center;
+  float: left;
+}
+
 table.phui-calendar-view a.phui-calendar-date-number {
   color: {$lightgreytext};
   padding: 4px;

From 427cc221499d38807ab50d22bd4c927a24354c20 Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@joshuaspence.com>
Date: Mon, 18 May 2015 08:20:11 +1000
Subject: [PATCH 29/86] Rename protocol adapter classes

Summary: Ref T5655. Rename protocol adapter classes to remove `Base` from the class name.

Test Plan: Unit tests still pass.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T5655

Differential Revision: https://secure.phabricator.com/D12563
---
 src/__phutil_library_map__.php                       | 12 ++++++------
 .../PhabricatorBotFlowdockProtocolAdapter.php        |  2 +-
 .../adapter/PhabricatorCampfireProtocolAdapter.php   |  2 +-
 .../bot/adapter/PhabricatorIRCProtocolAdapter.php    |  3 +--
 ...colAdapter.php => PhabricatorProtocolAdapter.php} |  2 +-
 ...r.php => PhabricatorStreamingProtocolAdapter.php} |  4 ++--
 6 files changed, 12 insertions(+), 13 deletions(-)
 rename src/infrastructure/daemon/bot/adapter/{PhabricatorBaseProtocolAdapter.php => PhabricatorProtocolAdapter.php} (97%)
 rename src/infrastructure/daemon/bot/adapter/{PhabricatorBotBaseStreamingProtocolAdapter.php => PhabricatorStreamingProtocolAdapter.php} (97%)

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index edadae1253..2f07a0670b 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -1461,13 +1461,11 @@ phutil_register_library_map(array(
     'PhabricatorAutoEventListener' => 'infrastructure/events/PhabricatorAutoEventListener.php',
     'PhabricatorBarePageUIExample' => 'applications/uiexample/examples/PhabricatorBarePageUIExample.php',
     'PhabricatorBarePageView' => 'view/page/PhabricatorBarePageView.php',
-    'PhabricatorBaseProtocolAdapter' => 'infrastructure/daemon/bot/adapter/PhabricatorBaseProtocolAdapter.php',
     'PhabricatorBaseURISetupCheck' => 'applications/config/check/PhabricatorBaseURISetupCheck.php',
     'PhabricatorBcryptPasswordHasher' => 'infrastructure/util/password/PhabricatorBcryptPasswordHasher.php',
     'PhabricatorBinariesSetupCheck' => 'applications/config/check/PhabricatorBinariesSetupCheck.php',
     'PhabricatorBitbucketAuthProvider' => 'applications/auth/provider/PhabricatorBitbucketAuthProvider.php',
     'PhabricatorBot' => 'infrastructure/daemon/bot/PhabricatorBot.php',
-    'PhabricatorBotBaseStreamingProtocolAdapter' => 'infrastructure/daemon/bot/adapter/PhabricatorBotBaseStreamingProtocolAdapter.php',
     'PhabricatorBotChannel' => 'infrastructure/daemon/bot/target/PhabricatorBotChannel.php',
     'PhabricatorBotDebugLogHandler' => 'infrastructure/daemon/bot/handler/PhabricatorBotDebugLogHandler.php',
     'PhabricatorBotFeedNotificationHandler' => 'infrastructure/daemon/bot/handler/PhabricatorBotFeedNotificationHandler.php',
@@ -2369,6 +2367,7 @@ phutil_register_library_map(array(
     'PhabricatorProjectViewController' => 'applications/project/controller/PhabricatorProjectViewController.php',
     'PhabricatorProjectWatchController' => 'applications/project/controller/PhabricatorProjectWatchController.php',
     'PhabricatorProjectsPolicyRule' => 'applications/policy/rule/PhabricatorProjectsPolicyRule.php',
+    'PhabricatorProtocolAdapter' => 'infrastructure/daemon/bot/adapter/PhabricatorProtocolAdapter.php',
     'PhabricatorPygmentSetupCheck' => 'applications/config/check/PhabricatorPygmentSetupCheck.php',
     'PhabricatorQuery' => 'infrastructure/query/PhabricatorQuery.php',
     'PhabricatorQueryConstraint' => 'infrastructure/query/constraint/PhabricatorQueryConstraint.php',
@@ -2598,6 +2597,7 @@ phutil_register_library_map(array(
     'PhabricatorStoragePatch' => 'infrastructure/storage/management/PhabricatorStoragePatch.php',
     'PhabricatorStorageSchemaSpec' => 'infrastructure/storage/schema/PhabricatorStorageSchemaSpec.php',
     'PhabricatorStorageSetupCheck' => 'applications/config/check/PhabricatorStorageSetupCheck.php',
+    'PhabricatorStreamingProtocolAdapter' => 'infrastructure/daemon/bot/adapter/PhabricatorStreamingProtocolAdapter.php',
     'PhabricatorSubscribableInterface' => 'applications/subscriptions/interface/PhabricatorSubscribableInterface.php',
     'PhabricatorSubscribedToObjectEdgeType' => 'applications/transactions/edges/PhabricatorSubscribedToObjectEdgeType.php',
     'PhabricatorSubscribersQuery' => 'applications/subscriptions/query/PhabricatorSubscribersQuery.php',
@@ -4821,11 +4821,10 @@ phutil_register_library_map(array(
     'PhabricatorBinariesSetupCheck' => 'PhabricatorSetupCheck',
     'PhabricatorBitbucketAuthProvider' => 'PhabricatorOAuth1AuthProvider',
     'PhabricatorBot' => 'PhabricatorDaemon',
-    'PhabricatorBotBaseStreamingProtocolAdapter' => 'PhabricatorBaseProtocolAdapter',
     'PhabricatorBotChannel' => 'PhabricatorBotTarget',
     'PhabricatorBotDebugLogHandler' => 'PhabricatorBotHandler',
     'PhabricatorBotFeedNotificationHandler' => 'PhabricatorBotHandler',
-    'PhabricatorBotFlowdockProtocolAdapter' => 'PhabricatorBotBaseStreamingProtocolAdapter',
+    'PhabricatorBotFlowdockProtocolAdapter' => 'PhabricatorStreamingProtocolAdapter',
     'PhabricatorBotLogHandler' => 'PhabricatorBotHandler',
     'PhabricatorBotMacroHandler' => 'PhabricatorBotHandler',
     'PhabricatorBotObjectNameHandler' => 'PhabricatorBotHandler',
@@ -4885,7 +4884,7 @@ phutil_register_library_map(array(
     'PhabricatorCalendarRemarkupRule' => 'PhabricatorObjectRemarkupRule',
     'PhabricatorCalendarReplyHandler' => 'PhabricatorApplicationTransactionReplyHandler',
     'PhabricatorCalendarSchemaSpec' => 'PhabricatorConfigSchemaSpec',
-    'PhabricatorCampfireProtocolAdapter' => 'PhabricatorBotBaseStreamingProtocolAdapter',
+    'PhabricatorCampfireProtocolAdapter' => 'PhabricatorStreamingProtocolAdapter',
     'PhabricatorCelerityApplication' => 'PhabricatorApplication',
     'PhabricatorCelerityTestCase' => 'PhabricatorTestCase',
     'PhabricatorChangeParserTestCase' => 'PhabricatorWorkingCopyTestCase',
@@ -5360,7 +5359,7 @@ phutil_register_library_map(array(
     'PhabricatorHovercardView' => 'AphrontView',
     'PhabricatorHunksManagementMigrateWorkflow' => 'PhabricatorHunksManagementWorkflow',
     'PhabricatorHunksManagementWorkflow' => 'PhabricatorManagementWorkflow',
-    'PhabricatorIRCProtocolAdapter' => 'PhabricatorBaseProtocolAdapter',
+    'PhabricatorIRCProtocolAdapter' => 'PhabricatorProtocolAdapter',
     'PhabricatorIconRemarkupRule' => 'PhutilRemarkupRule',
     'PhabricatorImageMacroRemarkupRule' => 'PhutilRemarkupRule',
     'PhabricatorImagemagickSetupCheck' => 'PhabricatorSetupCheck',
@@ -6064,6 +6063,7 @@ phutil_register_library_map(array(
     'PhabricatorStorageManagementWorkflow' => 'PhabricatorManagementWorkflow',
     'PhabricatorStorageSchemaSpec' => 'PhabricatorConfigSchemaSpec',
     'PhabricatorStorageSetupCheck' => 'PhabricatorSetupCheck',
+    'PhabricatorStreamingProtocolAdapter' => 'PhabricatorProtocolAdapter',
     'PhabricatorSubscribedToObjectEdgeType' => 'PhabricatorEdgeType',
     'PhabricatorSubscribersQuery' => 'PhabricatorQuery',
     'PhabricatorSubscriptionTriggerClock' => 'PhabricatorTriggerClock',
diff --git a/src/infrastructure/daemon/bot/adapter/PhabricatorBotFlowdockProtocolAdapter.php b/src/infrastructure/daemon/bot/adapter/PhabricatorBotFlowdockProtocolAdapter.php
index 050377dc77..eede9d5142 100644
--- a/src/infrastructure/daemon/bot/adapter/PhabricatorBotFlowdockProtocolAdapter.php
+++ b/src/infrastructure/daemon/bot/adapter/PhabricatorBotFlowdockProtocolAdapter.php
@@ -1,7 +1,7 @@
 <?php
 
 final class PhabricatorBotFlowdockProtocolAdapter
-  extends PhabricatorBotBaseStreamingProtocolAdapter {
+  extends PhabricatorStreamingProtocolAdapter {
 
   public function getServiceType() {
     return 'Flowdock';
diff --git a/src/infrastructure/daemon/bot/adapter/PhabricatorCampfireProtocolAdapter.php b/src/infrastructure/daemon/bot/adapter/PhabricatorCampfireProtocolAdapter.php
index 3f07a7e7a0..eee257880b 100644
--- a/src/infrastructure/daemon/bot/adapter/PhabricatorCampfireProtocolAdapter.php
+++ b/src/infrastructure/daemon/bot/adapter/PhabricatorCampfireProtocolAdapter.php
@@ -1,7 +1,7 @@
 <?php
 
 final class PhabricatorCampfireProtocolAdapter
-  extends PhabricatorBotBaseStreamingProtocolAdapter {
+  extends PhabricatorStreamingProtocolAdapter {
 
   public function getServiceType() {
     return 'Campfire';
diff --git a/src/infrastructure/daemon/bot/adapter/PhabricatorIRCProtocolAdapter.php b/src/infrastructure/daemon/bot/adapter/PhabricatorIRCProtocolAdapter.php
index c5c711593f..eab9c4b8fa 100644
--- a/src/infrastructure/daemon/bot/adapter/PhabricatorIRCProtocolAdapter.php
+++ b/src/infrastructure/daemon/bot/adapter/PhabricatorIRCProtocolAdapter.php
@@ -1,7 +1,6 @@
 <?php
 
-final class PhabricatorIRCProtocolAdapter
-  extends PhabricatorBaseProtocolAdapter {
+final class PhabricatorIRCProtocolAdapter extends PhabricatorProtocolAdapter {
 
   private $socket;
 
diff --git a/src/infrastructure/daemon/bot/adapter/PhabricatorBaseProtocolAdapter.php b/src/infrastructure/daemon/bot/adapter/PhabricatorProtocolAdapter.php
similarity index 97%
rename from src/infrastructure/daemon/bot/adapter/PhabricatorBaseProtocolAdapter.php
rename to src/infrastructure/daemon/bot/adapter/PhabricatorProtocolAdapter.php
index e50edea7be..c12c62b44c 100644
--- a/src/infrastructure/daemon/bot/adapter/PhabricatorBaseProtocolAdapter.php
+++ b/src/infrastructure/daemon/bot/adapter/PhabricatorProtocolAdapter.php
@@ -3,7 +3,7 @@
 /**
  * Defines the api for protocol adapters for @{class:PhabricatorBot}
  */
-abstract class PhabricatorBaseProtocolAdapter {
+abstract class PhabricatorProtocolAdapter {
 
   private $config;
 
diff --git a/src/infrastructure/daemon/bot/adapter/PhabricatorBotBaseStreamingProtocolAdapter.php b/src/infrastructure/daemon/bot/adapter/PhabricatorStreamingProtocolAdapter.php
similarity index 97%
rename from src/infrastructure/daemon/bot/adapter/PhabricatorBotBaseStreamingProtocolAdapter.php
rename to src/infrastructure/daemon/bot/adapter/PhabricatorStreamingProtocolAdapter.php
index fc2cce4796..6863880c54 100644
--- a/src/infrastructure/daemon/bot/adapter/PhabricatorBotBaseStreamingProtocolAdapter.php
+++ b/src/infrastructure/daemon/bot/adapter/PhabricatorStreamingProtocolAdapter.php
@@ -1,7 +1,7 @@
 <?php
 
-abstract class PhabricatorBotBaseStreamingProtocolAdapter
-  extends PhabricatorBaseProtocolAdapter {
+abstract class PhabricatorStreamingProtocolAdapter
+  extends PhabricatorProtocolAdapter {
 
   protected $readHandles;
   protected $multiHandle;

From a527d6c340d0d30e1df1271181bd90c2db2217cf Mon Sep 17 00:00:00 2001
From: lkassianik <lyubakassianik@gmail.com>
Date: Sun, 17 May 2015 16:37:21 -0700
Subject: [PATCH 30/86] Month view header should display month name of the
 month completely shown, not leading or trailing month.

Summary: Fixes T8229, Month view header should display month name of the month completely shown, not leading or trailing month.

Test Plan: Open month view for May. Month view header should be May, not April.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8229

Differential Revision: https://secure.phabricator.com/D12887
---
 src/view/phui/calendar/PHUICalendarMonthView.php | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/view/phui/calendar/PHUICalendarMonthView.php b/src/view/phui/calendar/PHUICalendarMonthView.php
index df692d271d..806ecad719 100644
--- a/src/view/phui/calendar/PHUICalendarMonthView.php
+++ b/src/view/phui/calendar/PHUICalendarMonthView.php
@@ -62,8 +62,6 @@ final class PHUICalendarMonthView extends AphrontView {
 
     require_celerity_resource('phui-calendar-month-css');
 
-    $first = reset($days);
-
     foreach ($days as $day) {
       $day_number = $day->format('j');
 
@@ -144,7 +142,7 @@ final class PHUICalendarMonthView extends AphrontView {
     $warnings = $this->getQueryRangeWarning();
 
     $box = id(new PHUIObjectBoxView())
-      ->setHeader($this->renderCalendarHeader($first))
+      ->setHeader($this->renderCalendarHeader($this->getDateTime()))
       ->appendChild($table)
       ->setFormErrors($warnings);
     if ($this->error) {
@@ -469,6 +467,7 @@ final class PHUICalendarMonthView extends AphrontView {
     $year = $this->year;
 
     list($next_year, $next_month) = $this->getNextYearAndMonth();
+
     $end_date = new DateTime("{$next_year}-{$next_month}-01", $timezone);
 
     list($start_of_week, $end_of_week) = $this->getWeekStartAndEnd();
@@ -481,12 +480,14 @@ final class PHUICalendarMonthView extends AphrontView {
     $first_weekday_of_month = $first_month_day_date->format('w');
     $last_weekday_of_month = $last_month_day_date->format('w');
 
+    $day_date = id(clone $first_month_day_date);
+
     $num_days_display = $days_in_month;
     if ($start_of_week !== $first_weekday_of_month) {
       $interim_start_num = ($first_weekday_of_month + 7 - $start_of_week) % 7;
       $num_days_display += $interim_start_num;
-      $day_date = id(clone $first_month_day_date)
-        ->modify('-'.$interim_start_num.' days');
+
+      $day_date->modify('-'.$interim_start_num.' days');
     }
     if ($end_of_week !== $last_weekday_of_month) {
       $interim_end_day_num = ($end_of_week - $last_weekday_of_month + 7) % 7;

From 79e8d9fc2db1e870fa8890a23a8f90ffa6a7f7b6 Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@joshuaspence.com>
Date: Mon, 18 May 2015 09:09:44 +1000
Subject: [PATCH 31/86] Only revert commits in the same repository

Summary: Fixes T8215. When adding a revert edge, only consider commits within the same repository.

Test Plan: Imported the arcanist repository three times and inspected the reverts relationships on rARC490984936bb7ddfc589ef3d376ec2ac2365f070d.

Reviewers: hach-que, epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T8215

Differential Revision: https://secure.phabricator.com/D12875
---
 .../worker/PhabricatorRepositoryCommitHeraldWorker.php           | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php b/src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php
index b1361c4b4a..0aa4dad187 100644
--- a/src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php
+++ b/src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php
@@ -68,6 +68,7 @@ final class PhabricatorRepositoryCommitHeraldWorker
     if ($reverts) {
       $reverted_commits = id(new DiffusionCommitQuery())
         ->setViewer(PhabricatorUser::getOmnipotentUser())
+        ->withRepository($repository)
         ->withIdentifiers($reverts)
         ->execute();
       $reverted_commit_phids = mpull($reverted_commits, 'getPHID', 'getPHID');

From 898ce6bace59dbe77dd28b190cdc540a32b411ad Mon Sep 17 00:00:00 2001
From: Aviv Eyal <avivey@gmail.com>
Date: Mon, 18 May 2015 06:29:47 -0700
Subject: [PATCH 32/86] Search Symbols by Repository, not Project

Summary:
Fixes T7977.
- Move Indexed Languages and See Symbols From config to Repository
- Make symbol search skip projects

This also makes the default languages to Everything instead of Nothing.

Test Plan:
- Browse files, click symbols.
- Use quick search to find symbols
- Browse revision, click symbols

Reviewers: joshuaspence, epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T7977

Differential Revision: https://secure.phabricator.com/D12687
---
 .../autopatches/20150504.symbolsproject.1.php |  68 ++++++++++
 .../autopatches/20150504.symbolsproject.2.sql |   3 +
 src/__phutil_library_map__.php                |   2 +
 .../DifferentialRevisionViewController.php    |  36 +++--
 .../PhabricatorDiffusionApplication.php       |   1 +
 .../DiffusionBrowseFileController.php         |  26 +---
 .../DiffusionRepositoryEditMainController.php |  55 ++++++++
 .../DiffusionRepositorySymbolsController.php  | 123 ++++++++++++++++++
 .../controller/DiffusionSymbolController.php  |   2 +-
 .../diffusion/query/DiffusionSymbolQuery.php  |  11 +-
 ...epositoryArcanistProjectEditController.php |  34 -----
 .../editor/PhabricatorRepositoryEditor.php    |  16 +++
 .../storage/PhabricatorRepository.php         |  11 ++
 .../PhabricatorRepositoryArcanistProject.php  |   7 -
 .../PhabricatorRepositoryTransaction.php      |  22 ++++
 .../repository/repository-crossreference.js   |   2 +-
 16 files changed, 336 insertions(+), 83 deletions(-)
 create mode 100644 resources/sql/autopatches/20150504.symbolsproject.1.php
 create mode 100644 resources/sql/autopatches/20150504.symbolsproject.2.sql
 create mode 100644 src/applications/diffusion/controller/DiffusionRepositorySymbolsController.php

diff --git a/resources/sql/autopatches/20150504.symbolsproject.1.php b/resources/sql/autopatches/20150504.symbolsproject.1.php
new file mode 100644
index 0000000000..e3c3db66e1
--- /dev/null
+++ b/resources/sql/autopatches/20150504.symbolsproject.1.php
@@ -0,0 +1,68 @@
+<?php
+
+$table_w = new PhabricatorRepository();
+$conn_w = $table_w->establishConnection('w');
+
+// Repository and Project share a database.
+$conn_r = $table_w->establishConnection('r');
+$projects_table = 'repository_arcanistproject';
+
+$raw_projects_data = queryfx_all($conn_r, 'SELECT * FROM %T', $projects_table);
+$raw_projects_data = ipull($raw_projects_data, null, 'id');
+
+$repository_ids = ipull($raw_projects_data, 'repositoryID');
+$repositories = id(new PhabricatorRepositoryQuery())
+  ->setViewer(PhabricatorUser::getOmnipotentUser())
+  ->withIDs($repository_ids)
+  ->execute();
+
+$projects_to_repo_ids_map = ipull($raw_projects_data, 'repositoryID', 'phid');
+$projects_to_repos_map = array();
+foreach ($projects_to_repo_ids_map as $projectPHID => $repositoryID) {
+  $repo = idx($repositories, $repositoryID);
+  if ($repo) {
+    $projects_to_repos_map[$projectPHID] = $repo->getPHID();
+  }
+}
+
+foreach ($raw_projects_data as $project_row) {
+  $repositoryID = idx($project_row, 'repositoryID');
+  $repo = idx($repositories, $repositoryID);
+
+  if (!$repo) {
+    continue;
+  }
+
+  echo pht(
+    "Migrating symbols configuration for '%s' project...\n",
+    idx($project_row, 'name', '???'));
+
+  $symbol_index_projects = $project_row['symbolIndexProjects'];
+  $symbol_index_projects = phutil_json_decode($symbol_index_projects);
+
+  $sources = $repo->getDetail('symbol-sources', array());
+  foreach ($symbol_index_projects as $index_project) {
+    $sources[] = idx($projects_to_repos_map, $index_project);
+  }
+  $sources = array_filter($sources);
+  $sources = array_unique($sources);
+
+  $repo->setDetail('symbol-sources', $sources);
+
+  $languages = $project_row['symbolIndexLanguages'];
+  $languages = phutil_json_decode($languages);
+
+  $languages = array_merge(
+    $repo->getDetail('symbol-languages', array()),
+    $languages);
+  $languages = array_unique($languages);
+
+  $repo->setDetail('symbol-languages', $languages);
+
+  queryfx(
+    $conn_w,
+    'UPDATE %T SET details = %s WHERE id = %d',
+    $table_w->getTableName(),
+    json_encode($repo->getDetails()),
+    $repo->getID());
+}
diff --git a/resources/sql/autopatches/20150504.symbolsproject.2.sql b/resources/sql/autopatches/20150504.symbolsproject.2.sql
new file mode 100644
index 0000000000..f963f46c77
--- /dev/null
+++ b/resources/sql/autopatches/20150504.symbolsproject.2.sql
@@ -0,0 +1,3 @@
+ALTER TABLE {$NAMESPACE}_repository.repository_arcanistproject
+  DROP COLUMN symbolIndexLanguages,
+  DROP COLUMN symbolIndexProjects;
diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index 2f07a0670b..be579679c5 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -605,6 +605,7 @@ phutil_register_library_map(array(
     'DiffusionRepositoryPath' => 'applications/diffusion/data/DiffusionRepositoryPath.php',
     'DiffusionRepositoryRef' => 'applications/diffusion/data/DiffusionRepositoryRef.php',
     'DiffusionRepositoryRemarkupRule' => 'applications/diffusion/remarkup/DiffusionRepositoryRemarkupRule.php',
+    'DiffusionRepositorySymbolsController' => 'applications/diffusion/controller/DiffusionRepositorySymbolsController.php',
     'DiffusionRepositoryTag' => 'applications/diffusion/data/DiffusionRepositoryTag.php',
     'DiffusionRequest' => 'applications/diffusion/request/DiffusionRequest.php',
     'DiffusionResolveRefsConduitAPIMethod' => 'applications/diffusion/conduit/DiffusionResolveRefsConduitAPIMethod.php',
@@ -3847,6 +3848,7 @@ phutil_register_library_map(array(
     'DiffusionRepositoryNewController' => 'DiffusionController',
     'DiffusionRepositoryRef' => 'Phobject',
     'DiffusionRepositoryRemarkupRule' => 'PhabricatorObjectRemarkupRule',
+    'DiffusionRepositorySymbolsController' => 'DiffusionRepositoryEditController',
     'DiffusionResolveRefsConduitAPIMethod' => 'DiffusionQueryConduitAPIMethod',
     'DiffusionResolveUserQuery' => 'Phobject',
     'DiffusionSSHWorkflow' => 'PhabricatorSSHWorkflow',
diff --git a/src/applications/differential/controller/DifferentialRevisionViewController.php b/src/applications/differential/controller/DifferentialRevisionViewController.php
index 5f93b1b0ad..d1b021b8d0 100644
--- a/src/applications/differential/controller/DifferentialRevisionViewController.php
+++ b/src/applications/differential/controller/DifferentialRevisionViewController.php
@@ -260,14 +260,14 @@ final class DifferentialRevisionViewController extends DifferentialController {
       'whitespace',
       DifferentialChangesetParser::WHITESPACE_IGNORE_MOST);
 
-    $arc_project = $target->getArcanistProject();
-    if ($arc_project) {
-      list($symbol_indexes, $project_phids) = $this->buildSymbolIndexes(
-        $arc_project,
+    $repository = $revision->getRepository();
+    if ($repository) {
+      list($symbol_indexes, $repository_phids) = $this->buildSymbolIndexes(
+        $repository,
         $visible_changesets);
     } else {
       $symbol_indexes = array();
-      $project_phids = null;
+      $repository_phids = null;
     }
 
     $revision_detail->setActions($actions);
@@ -307,12 +307,12 @@ final class DifferentialRevisionViewController extends DifferentialController {
       ),
       $comment_view);
 
-    if ($arc_project) {
+    if ($repository) {
       Javelin::initBehavior(
         'repository-crossreference',
         array(
           'section' => $wrap_id,
-          'projects' => $project_phids,
+          'repositories' => $repository_phids,
         ));
     }
 
@@ -750,35 +750,33 @@ final class DifferentialRevisionViewController extends DifferentialController {
   }
 
   private function buildSymbolIndexes(
-    PhabricatorRepositoryArcanistProject $arc_project,
+    PhabricatorRepository $repository,
     array $visible_changesets) {
     assert_instances_of($visible_changesets, 'DifferentialChangeset');
 
     $engine = PhabricatorSyntaxHighlighter::newEngine();
 
-    $langs = $arc_project->getSymbolIndexLanguages();
-    if (!$langs) {
-      return array(array(), array());
-    }
+    $langs = $repository->getSymbolLanguages();
+    $langs = nonempty($langs, array());
 
     $symbol_indexes = array();
 
-    $project_phids = array_merge(
-      array($arc_project->getPHID()),
-      nonempty($arc_project->getSymbolIndexProjects(), array()));
+    $repository_phids = array_merge(
+      array($repository->getPHID()),
+      nonempty($repository->getSymbolSources(), array()));
 
     $indexed_langs = array_fill_keys($langs, true);
     foreach ($visible_changesets as $key => $changeset) {
       $lang = $engine->getLanguageFromFilename($changeset->getFilename());
-      if (isset($indexed_langs[$lang])) {
+      if (empty($indexed_langs) || isset($indexed_langs[$lang])) {
         $symbol_indexes[$key] = array(
-          'lang'      => $lang,
-          'projects'  => $project_phids,
+          'lang'         => $lang,
+          'repositories' => $repository_phids,
         );
       }
     }
 
-    return array($symbol_indexes, $project_phids);
+    return array($symbol_indexes, $repository_phids);
   }
 
   private function loadOtherRevisions(
diff --git a/src/applications/diffusion/application/PhabricatorDiffusionApplication.php b/src/applications/diffusion/application/PhabricatorDiffusionApplication.php
index 7771b8a03d..14a3338f5e 100644
--- a/src/applications/diffusion/application/PhabricatorDiffusionApplication.php
+++ b/src/applications/diffusion/application/PhabricatorDiffusionApplication.php
@@ -100,6 +100,7 @@ final class PhabricatorDiffusionApplication extends PhabricatorApplication {
             'hosting/' => 'DiffusionRepositoryEditHostingController',
             '(?P<serve>serve)/' => 'DiffusionRepositoryEditHostingController',
             'update/' => 'DiffusionRepositoryEditUpdateController',
+            'symbol/' => 'DiffusionRepositorySymbolsController',
           ),
           'pathtree/(?P<dblob>.*)' => 'DiffusionPathTreeController',
           'mirror/' => array(
diff --git a/src/applications/diffusion/controller/DiffusionBrowseFileController.php b/src/applications/diffusion/controller/DiffusionBrowseFileController.php
index 46f3af59cc..731906943c 100644
--- a/src/applications/diffusion/controller/DiffusionBrowseFileController.php
+++ b/src/applications/diffusion/controller/DiffusionBrowseFileController.php
@@ -266,32 +266,20 @@ final class DiffusionBrowseFileController extends DiffusionBrowseController {
 
       $id = celerity_generate_unique_node_id();
 
-      $projects = $drequest->loadArcanistProjects();
-      $langs = array();
-      foreach ($projects as $project) {
-        $ls = $project->getSymbolIndexLanguages();
-        if (!$ls) {
-          continue;
-        }
-        $dep_projects = $project->getSymbolIndexProjects();
-        $dep_projects[] = $project->getPHID();
-        foreach ($ls as $lang) {
-          if (!isset($langs[$lang])) {
-            $langs[$lang] = array();
-          }
-          $langs[$lang] += $dep_projects + array($project);
-        }
-      }
+      $repo = $drequest->getRepository();
+      $symbol_repos = $repo->getSymbolSources();
+      $symbol_repos[] = $repo;
 
       $lang = last(explode('.', $drequest->getPath()));
-
-      if (isset($langs[$lang])) {
+      $repo_languages = $repo->getSymbolLanguages();
+      $repo_languages = array_fill_keys($repo_languages, true);
+      if (empty($repo_languages) || isset($repo_languages[$lang])) {
         Javelin::initBehavior(
           'repository-crossreference',
           array(
             'container' => $id,
             'lang' => $lang,
-            'projects' => $langs[$lang],
+            'repositories' => $symbol_repos,
           ));
       }
 
diff --git a/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php b/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
index d19a7ebeb8..a5ad77f87e 100644
--- a/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
@@ -62,6 +62,10 @@ final class DiffusionRepositoryEditMainController
     $encoding_properties =
       $this->buildEncodingProperties($repository, $encoding_actions);
 
+    $symbols_actions = $this->buildSymbolsActions($repository);
+    $symbols_properties =
+      $this->buildSymbolsProperties($repository, $symbols_actions);
+
     $hosting_properties = $this->buildHostingProperties(
       $repository,
       $this->buildHostingActions($repository));
@@ -157,6 +161,10 @@ final class DiffusionRepositoryEditMainController
       ->setHeaderText(pht('Text Encoding'))
       ->addPropertyList($encoding_properties);
 
+    $boxes[] = id(new PHUIObjectBoxView())
+      ->setHeaderText(pht('Symbols'))
+      ->addPropertyList($symbols_properties);
+
     if ($branches_properties) {
       $boxes[] = id(new PHUIObjectBoxView())
         ->setHeaderText(pht('Branches'))
@@ -1187,6 +1195,53 @@ final class DiffusionRepositoryEditMainController
     return $mirror_list;
   }
 
+  private function buildSymbolsActions(PhabricatorRepository $repository) {
+    $viewer = $this->getRequest()->getUser();
+
+    $view = id(new PhabricatorActionListView())
+      ->setObjectURI($this->getRequest()->getRequestURI())
+      ->setUser($viewer);
+
+    $edit = id(new PhabricatorActionView())
+      ->setIcon('fa-pencil')
+      ->setName(pht('Edit Symbols'))
+      ->setHref(
+        $this->getRepositoryControllerURI($repository, 'edit/symbol/'));
+    $view->addAction($edit);
+
+    return $view;
+  }
+
+  private function buildSymbolsProperties(
+    PhabricatorRepository $repository,
+    PhabricatorActionListView $actions) {
+
+    $viewer = $this->getRequest()->getUser();
+
+    $view = id(new PHUIPropertyListView())
+      ->setUser($viewer)
+      ->setActionList($actions);
+
+    $languages = $repository->getSymbolLanguages();
+
+    if ($languages) {
+      $languages = implode(', ', $languages);
+    } else {
+      $languages = phutil_tag('em', array(), pht('Any'));
+    }
+    $view->addProperty(pht('Languages'), $languages);
+
+    $sources = $repository->getSymbolSources();
+    if ($sources) {
+      $handles = $viewer->loadHandles($sources);
+      $sources = $handles->renderList();
+    } else {
+      $sources = phutil_tag('em', array(), pht('This Repository Only'));
+    }
+    $view->addProperty(pht('Use Symbols From'), $sources);
+    return $view;
+  }
+
   private function getEnvConfigLink() {
     $config_href = '/config/edit/environment.append-paths/';
     return phutil_tag(
diff --git a/src/applications/diffusion/controller/DiffusionRepositorySymbolsController.php b/src/applications/diffusion/controller/DiffusionRepositorySymbolsController.php
new file mode 100644
index 0000000000..133ee38813
--- /dev/null
+++ b/src/applications/diffusion/controller/DiffusionRepositorySymbolsController.php
@@ -0,0 +1,123 @@
+<?php
+
+final class DiffusionRepositorySymbolsController
+  extends DiffusionRepositoryEditController {
+
+  protected function processDiffusionRequest(AphrontRequest $request) {
+    $user = $request->getUser();
+    $drequest = $this->diffusionRequest;
+    $repository = $drequest->getRepository();
+
+    $repository = id(new PhabricatorRepositoryQuery())
+      ->setViewer($user)
+      ->requireCapabilities(
+        array(
+          PhabricatorPolicyCapability::CAN_VIEW,
+          PhabricatorPolicyCapability::CAN_EDIT,
+        ))
+      ->withIDs(array($repository->getID()))
+      ->executeOne();
+
+    if (!$repository) {
+      return new Aphront404Response();
+    }
+
+    $edit_uri = $this->getRepositoryControllerURI($repository, 'edit/');
+
+    $v_sources = $repository->getSymbolSources();
+    $v_languages = $repository->getSymbolLanguages();
+    if ($v_languages) {
+      $v_languages = implode(', ', $v_languages);
+    }
+    $errors = array();
+
+    if ($request->isFormPost()) {
+      $v_sources = $request->getArr('sources');
+      $v_languages = $request->getStrList('languages');
+      $v_languages = array_map('phutil_utf8_strtolower', $v_languages);
+
+      if (!$errors) {
+        $xactions = array();
+        $template = id(new PhabricatorRepositoryTransaction());
+
+        $type_sources = PhabricatorRepositoryTransaction::TYPE_SYMBOLS_SOURCES;
+        $type_lang = PhabricatorRepositoryTransaction::TYPE_SYMBOLS_LANGUAGE;
+
+        $xactions[] = id(clone $template)
+          ->setTransactionType($type_sources)
+          ->setNewValue($v_sources);
+
+        $xactions[] = id(clone $template)
+          ->setTransactionType($type_lang)
+          ->setNewValue($v_languages);
+
+        try {
+          id(new PhabricatorRepositoryEditor())
+            ->setContinueOnNoEffect(true)
+            ->setContentSourceFromRequest($request)
+            ->setActor($user)
+            ->applyTransactions($repository, $xactions);
+
+          return id(new AphrontRedirectResponse())->setURI($edit_uri);
+        } catch (Exception $ex) {
+          $errors[] = $ex->getMessage();
+        }
+      }
+    }
+
+    $crumbs = $this->buildApplicationCrumbs();
+    $crumbs->addTextCrumb(pht('Edit Symbols'));
+
+    $title = pht('Edit %s', $repository->getName());
+
+    $form = id(new AphrontFormView())
+      ->setUser($user)
+      ->appendRemarkupInstructions($this->getInstructions())
+      ->appendChild(
+        id(new AphrontFormTextControl())
+          ->setName('languages')
+          ->setLabel(pht('Indexed Languages'))
+          ->setCaption(pht(
+            'File extensions, separate with commas, for example: php, py. '.
+            'Leave blank for "any".'))
+          ->setValue($v_languages))
+
+      ->appendControl(
+        id(new AphrontFormTokenizerControl())
+          ->setName('sources')
+          ->setLabel(pht('Uses Symbols From'))
+          ->setDatasource(new DiffusionRepositoryDatasource())
+          ->setValue($v_sources))
+
+      ->appendChild(
+        id(new AphrontFormSubmitControl())
+          ->setValue(pht('Save'))
+          ->addCancelButton($edit_uri));
+
+    $object_box = id(new PHUIObjectBoxView())
+      ->setHeaderText($title)
+      ->setForm($form)
+      ->setFormErrors($errors);
+
+    return $this->buildApplicationPage(
+      array(
+        $crumbs,
+        $object_box,
+      ),
+      array(
+        'title' => $title,
+      ));
+  }
+
+  private function getInstructions() {
+    return pht(<<<EOT
+Configure Symbols for this repository.
+
+See [[%s | Symbol Indexes]] for more information on using symbols.
+EOT
+    ,
+    PhabricatorEnv::getDoclink(
+      'Diffusion User Guide: Symbol Indexes'));
+  }
+
+}
diff --git a/src/applications/diffusion/controller/DiffusionSymbolController.php b/src/applications/diffusion/controller/DiffusionSymbolController.php
index 6e521a27af..ed1788115e 100644
--- a/src/applications/diffusion/controller/DiffusionSymbolController.php
+++ b/src/applications/diffusion/controller/DiffusionSymbolController.php
@@ -128,7 +128,7 @@ final class DiffusionSymbolController extends DiffusionController {
         '',
       ));
     $table->setNoDataString(
-      pht('No matching symbol could be found in any indexed project.'));
+      pht('No matching symbol could be found in any indexed repository.'));
 
     $panel = new PHUIObjectBoxView();
     $panel->setHeaderText(pht('Similar Symbols'));
diff --git a/src/applications/diffusion/query/DiffusionSymbolQuery.php b/src/applications/diffusion/query/DiffusionSymbolQuery.php
index 2748639360..6017c45f6f 100644
--- a/src/applications/diffusion/query/DiffusionSymbolQuery.php
+++ b/src/applications/diffusion/query/DiffusionSymbolQuery.php
@@ -146,11 +146,12 @@ final class DiffusionSymbolQuery extends PhabricatorOffsetPagedQuery {
         $this->loadPaths($symbols);
       }
       if ($this->needRepositories) {
-        $this->loadRepositories($symbols);
+        $symbols = $this->loadRepositories($symbols);
       }
 
     }
 
+
     return $symbols;
   }
 
@@ -249,10 +250,16 @@ final class DiffusionSymbolQuery extends PhabricatorOffsetPagedQuery {
       ->execute();
     $repos = mpull($repos, null, 'getPHID');
 
+    $visible = array();
     foreach ($symbols as $symbol) {
       $repository = idx($repos, $symbol->getRepositoryPHID());
-      $symbol->attachRepository($repository);
+      // repository is null mean "user can't view repo", so hide the symbol
+      if ($repository) {
+        $symbol->attachRepository($repository);
+        $visible[] = $symbol;
+      }
     }
+    return $visible;
   }
 
 }
diff --git a/src/applications/repository/controller/PhabricatorRepositoryArcanistProjectEditController.php b/src/applications/repository/controller/PhabricatorRepositoryArcanistProjectEditController.php
index b3928b94ef..a439179034 100644
--- a/src/applications/repository/controller/PhabricatorRepositoryArcanistProjectEditController.php
+++ b/src/applications/repository/controller/PhabricatorRepositoryArcanistProjectEditController.php
@@ -34,13 +34,6 @@ final class PhabricatorRepositoryArcanistProjectEditController
     asort($repos);
 
     if ($request->isFormPost()) {
-
-      $indexed = $request->getStrList('symbolIndexLanguages');
-      $indexed = array_map('strtolower', $indexed);
-      $project->setSymbolIndexLanguages($indexed);
-
-      $project->setSymbolIndexProjects($request->getArr('symbolIndexProjects'));
-
       $repo_id = $request->getInt('repository', 0);
       if (isset($repos[$repo_id])) {
         $project->setRepositoryID($repo_id);
@@ -51,19 +44,6 @@ final class PhabricatorRepositoryArcanistProjectEditController
       }
     }
 
-    $langs = $project->getSymbolIndexLanguages();
-    if ($langs) {
-      $langs = implode(', ', $langs);
-    } else {
-      $langs = null;
-    }
-
-    if ($project->getSymbolIndexProjects()) {
-      $uses = $project->getSymbolIndexProjects();
-    } else {
-      $uses = array();
-    }
-
     $form = id(new AphrontFormView())
       ->setUser($user)
       ->appendChild(
@@ -80,20 +60,6 @@ final class PhabricatorRepositoryArcanistProjectEditController
           ->setOptions($repos)
           ->setName('repository')
           ->setValue($project->getRepositoryID()))
-      ->appendChild(
-        id(new AphrontFormTextControl())
-          ->setLabel(pht('Indexed Languages'))
-          ->setName('symbolIndexLanguages')
-          ->setCaption(pht(
-            'Separate with commas, for example: %s',
-            phutil_tag('tt', array(), 'php, py')))
-          ->setValue($langs))
-      ->appendControl(
-        id(new AphrontFormTokenizerControl())
-          ->setLabel(pht('Uses Symbols From'))
-          ->setName('symbolIndexProjects')
-          ->setDatasource(new DiffusionArcanistProjectDatasource())
-          ->setValue($uses))
       ->appendChild(
         id(new AphrontFormSubmitControl())
           ->addCancelButton('/repository/')
diff --git a/src/applications/repository/editor/PhabricatorRepositoryEditor.php b/src/applications/repository/editor/PhabricatorRepositoryEditor.php
index 49c57d81b4..69012bdcd2 100644
--- a/src/applications/repository/editor/PhabricatorRepositoryEditor.php
+++ b/src/applications/repository/editor/PhabricatorRepositoryEditor.php
@@ -41,6 +41,8 @@ final class PhabricatorRepositoryEditor
     $types[] = PhabricatorRepositoryTransaction::TYPE_DANGEROUS;
     $types[] = PhabricatorRepositoryTransaction::TYPE_CLONE_NAME;
     $types[] = PhabricatorRepositoryTransaction::TYPE_SERVICE;
+    $types[] = PhabricatorRepositoryTransaction::TYPE_SYMBOLS_LANGUAGE;
+    $types[] = PhabricatorRepositoryTransaction::TYPE_SYMBOLS_SOURCES;
 
     $types[] = PhabricatorTransactions::TYPE_EDGE;
     $types[] = PhabricatorTransactions::TYPE_VIEW_POLICY;
@@ -98,6 +100,10 @@ final class PhabricatorRepositoryEditor
         return $object->getDetail('clone-name');
       case PhabricatorRepositoryTransaction::TYPE_SERVICE:
         return $object->getAlmanacServicePHID();
+      case PhabricatorRepositoryTransaction::TYPE_SYMBOLS_LANGUAGE:
+        return $object->getSymbolLanguages();
+      case PhabricatorRepositoryTransaction::TYPE_SYMBOLS_SOURCES:
+        return $object->getSymbolSources();
     }
   }
 
@@ -131,6 +137,8 @@ final class PhabricatorRepositoryEditor
       case PhabricatorRepositoryTransaction::TYPE_DANGEROUS:
       case PhabricatorRepositoryTransaction::TYPE_CLONE_NAME:
       case PhabricatorRepositoryTransaction::TYPE_SERVICE:
+      case PhabricatorRepositoryTransaction::TYPE_SYMBOLS_LANGUAGE:
+      case PhabricatorRepositoryTransaction::TYPE_SYMBOLS_SOURCES:
         return $xaction->getNewValue();
       case PhabricatorRepositoryTransaction::TYPE_NOTIFY:
       case PhabricatorRepositoryTransaction::TYPE_AUTOCLOSE:
@@ -205,6 +213,12 @@ final class PhabricatorRepositoryEditor
       case PhabricatorRepositoryTransaction::TYPE_SERVICE:
         $object->setAlmanacServicePHID($xaction->getNewValue());
         return;
+      case PhabricatorRepositoryTransaction::TYPE_SYMBOLS_LANGUAGE:
+        $object->setDetail('symbol-languages', $xaction->getNewValue());
+        return;
+      case PhabricatorRepositoryTransaction::TYPE_SYMBOLS_SOURCES:
+        $object->setDetail('symbol-sources', $xaction->getNewValue());
+        return;
       case PhabricatorRepositoryTransaction::TYPE_ENCODING:
         // Make sure the encoding is valid by converting to UTF-8. This tests
         // that the user has mbstring installed, and also that they didn't type
@@ -314,6 +328,8 @@ final class PhabricatorRepositoryEditor
       case PhabricatorRepositoryTransaction::TYPE_DANGEROUS:
       case PhabricatorRepositoryTransaction::TYPE_CLONE_NAME:
       case PhabricatorRepositoryTransaction::TYPE_SERVICE:
+      case PhabricatorRepositoryTransaction::TYPE_SYMBOLS_SOURCES:
+      case PhabricatorRepositoryTransaction::TYPE_SYMBOLS_LANGUAGE:
         PhabricatorPolicyFilter::requireCapability(
           $this->requireActor(),
           $object,
diff --git a/src/applications/repository/storage/PhabricatorRepository.php b/src/applications/repository/storage/PhabricatorRepository.php
index 4ab2828949..8108051282 100644
--- a/src/applications/repository/storage/PhabricatorRepository.php
+++ b/src/applications/repository/storage/PhabricatorRepository.php
@@ -1778,6 +1778,17 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
   }
 
 
+/* -(  Symbols  )-------------------------------------------------------------*/
+
+  public function getSymbolSources() {
+    return $this->getDetail('symbol-sources');
+  }
+
+  public function getSymbolLanguages() {
+    return $this->getDetail('symbol-languages');
+  }
+
+
 /* -(  PhabricatorApplicationTransactionInterface  )------------------------- */
 
 
diff --git a/src/applications/repository/storage/PhabricatorRepositoryArcanistProject.php b/src/applications/repository/storage/PhabricatorRepositoryArcanistProject.php
index 2c7f403a37..a1ac747bbf 100644
--- a/src/applications/repository/storage/PhabricatorRepositoryArcanistProject.php
+++ b/src/applications/repository/storage/PhabricatorRepositoryArcanistProject.php
@@ -9,19 +9,12 @@ final class PhabricatorRepositoryArcanistProject
   protected $name;
   protected $repositoryID;
 
-  protected $symbolIndexLanguages = array();
-  protected $symbolIndexProjects  = array();
-
   private $repository = self::ATTACHABLE;
 
   protected function getConfiguration() {
     return array(
       self::CONFIG_AUX_PHID   => true,
       self::CONFIG_TIMESTAMPS => false,
-      self::CONFIG_SERIALIZATION => array(
-        'symbolIndexLanguages' => self::SERIALIZATION_JSON,
-        'symbolIndexProjects'  => self::SERIALIZATION_JSON,
-      ),
       self::CONFIG_COLUMN_SCHEMA => array(
         'name' => 'text128',
         'repositoryID' => 'id?',
diff --git a/src/applications/repository/storage/PhabricatorRepositoryTransaction.php b/src/applications/repository/storage/PhabricatorRepositoryTransaction.php
index ff162a4ad0..9907cb0a01 100644
--- a/src/applications/repository/storage/PhabricatorRepositoryTransaction.php
+++ b/src/applications/repository/storage/PhabricatorRepositoryTransaction.php
@@ -25,6 +25,8 @@ final class PhabricatorRepositoryTransaction
   const TYPE_DANGEROUS = 'repo:dangerous';
   const TYPE_CLONE_NAME = 'repo:clone-name';
   const TYPE_SERVICE = 'repo:service';
+  const TYPE_SYMBOLS_SOURCES = 'repo:symbol-source';
+  const TYPE_SYMBOLS_LANGUAGE = 'repo:symbol-language';
 
   // TODO: Clean up these legacy transaction types.
   const TYPE_SSH_LOGIN = 'repo:ssh-login';
@@ -61,6 +63,14 @@ final class PhabricatorRepositoryTransaction
           $phids[] = $new;
         }
         break;
+      case self::TYPE_SYMBOLS_SOURCES:
+        if ($old) {
+          $phids = array_merge($phids, $old);
+        }
+        if ($new) {
+          $phids = array_merge($phids, $new);
+        }
+        break;
     }
 
     return $phids;
@@ -393,6 +403,18 @@ final class PhabricatorRepositoryTransaction
             $this->renderHandleLink($old),
             $this->renderHandleLink($new));
         }
+      case self::TYPE_SYMBOLS_SOURCES:
+        return pht(
+          '%s changed symbol sources from %s to %s.',
+          $this->renderHandleLink($author_phid),
+          empty($old) ? pht('None') : $this->renderHandleList($old),
+          empty($new) ? pht('None') : $this->renderHandleList($new));
+
+      case self::TYPE_SYMBOLS_LANGUAGE:
+        return pht('%s changed indexed languages from %s to %s.',
+            $this->renderHandleLink($author_phid),
+            $old ? implode(', ', $old) : pht('Any'),
+            $new ? implode(', ', $new) : pht('Any'));
     }
 
     return parent::getTitle();
diff --git a/webroot/rsrc/js/application/repository/repository-crossreference.js b/webroot/rsrc/js/application/repository/repository-crossreference.js
index 1cb9b347ef..d2339dc131 100644
--- a/webroot/rsrc/js/application/repository/repository-crossreference.js
+++ b/webroot/rsrc/js/application/repository/repository-crossreference.js
@@ -29,7 +29,7 @@ JX.behavior('repository-crossreference', function(config) {
               var symbol = target.textContent || target.innerText;
               var query = {
                 lang : lang,
-                projects : config.projects.join(','),
+                repositories : config.repositories.join(','),
                 jump : true
               };
               if (map[target.className]) {

From f8b7f031459851145ffe2111b0b63587e8d7ad66 Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@joshuaspence.com>
Date: Tue, 19 May 2015 00:07:46 +1000
Subject: [PATCH 33/86] Change "lint save" to not use Arcanist Projects

Summary: Ref T7604. Change `DiffusionLintSaveRunner` to use repositories instead of Arcanist Projects.

Test Plan: Ran the `save_lint.php` script and queried results using the `diffusion.getlintmessages` Conduit endpoint.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T7604

Differential Revision: https://secure.phabricator.com/D12893
---
 scripts/repository/save_lint.php              | 19 +++++++-----
 .../diffusion/DiffusionLintSaveRunner.php     | 26 ++++++++++++----
 ...ffusionGetLintMessagesConduitAPIMethod.php | 30 +++++++++++--------
 3 files changed, 49 insertions(+), 26 deletions(-)

diff --git a/scripts/repository/save_lint.php b/scripts/repository/save_lint.php
index 6cd0664133..d9bf921e9c 100755
--- a/scripts/repository/save_lint.php
+++ b/scripts/repository/save_lint.php
@@ -17,35 +17,38 @@ $args = id(new PhutilArgumentParser($argv))
   ->parse(array(
     array(
       'name' => 'all',
-      'help' =>
+      'help' => pht(
         'Discover problems in the whole repository instead of just changes '.
-        'since the last run.',
+        'since the last run.'),
     ),
     array(
       'name' => 'arc',
       'param' => 'path',
       'default' => 'arc',
-      'help' => 'Path to Arcanist executable.',
+      'help' => pht('Path to Arcanist executable.'),
     ),
     array(
       'name' => 'severity',
       'param' => 'string',
       'default' => ArcanistLintSeverity::SEVERITY_ADVICE,
-      'help' => 'Minimum severity, one of ArcanistLintSeverity constants.',
+      'help' => pht(
+        'Minimum severity, one of %s constants.',
+        'ArcanistLintSeverity'),
     ),
     array(
       'name' => 'chunk-size',
       'param' => 'number',
       'default' => 256,
-      'help' => 'Number of paths passed to `arc` at once.',
+      'help' => pht('Number of paths passed to `%s` at once.', 'arc'),
     ),
     array(
       'name' => 'blame',
-      'help' => 'Assign lint errors to authors who last modified the line.',
+      'help' => pht(
+        'Assign lint errors to authors who last modified the line.'),
     ),
   ));
 
-echo "Saving lint errors to database...\n";
+echo pht('Saving lint errors to database...')."\n";
 
 $count = id(new DiffusionLintSaveRunner())
   ->setAll($args->getArg('all', false))
@@ -55,4 +58,4 @@ $count = id(new DiffusionLintSaveRunner())
   ->setNeedsBlame($args->getArg('blame'))
   ->run('.');
 
-echo "\nProcessed {$count} files.\n";
+echo "\n".pht('Processed %d files.', $count)."\n";
diff --git a/src/applications/diffusion/DiffusionLintSaveRunner.php b/src/applications/diffusion/DiffusionLintSaveRunner.php
index 26a98a0232..629c887924 100644
--- a/src/applications/diffusion/DiffusionLintSaveRunner.php
+++ b/src/applications/diffusion/DiffusionLintSaveRunner.php
@@ -58,17 +58,31 @@ final class DiffusionLintSaveRunner {
       }
     }
 
-    $project_id = $working_copy->getProjectID();
-    $project = id(new PhabricatorRepositoryArcanistProject())
-      ->loadOneWhere('name = %s', $project_id);
-    if (!$project || !$project->getRepositoryID()) {
-      throw new Exception("Couldn't find repository for {$project_id}.");
+    $callsign = $configuration_manager->getConfigFromAnySource(
+      'repository.callsign');
+    $uuid = $api->getRepositoryUUID();
+    $remote_uri = $api->getRemoteURI();
+
+    $repository_query = id(new PhabricatorRepositoryQuery())
+      ->setViewer(PhabricatorUser::getOmnipotentUser());
+
+    if ($callsign) {
+      $repository_query->withCallsigns(array($callsign));
+    } else if ($uuid) {
+      $repository_query->withUUIDs(array($uuid));
+    } else if ($remote_uri) {
+      $repository_query->withRemoteURIs(array($remote_uri));
     }
 
+    $repository = $repository_query->executeOne();
     $branch_name = $api->getBranchName();
 
+    if (!$repository) {
+      throw new Exception(pht('No repository was found.'));
+    }
+
     $this->branch = PhabricatorRepositoryBranch::loadOrCreateBranch(
-      $project->getRepositoryID(),
+      $repository->getID(),
       $branch_name);
     $this->conn = $this->branch->establishConnection('w');
 
diff --git a/src/applications/diffusion/conduit/DiffusionGetLintMessagesConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionGetLintMessagesConduitAPIMethod.php
index d73213b148..cc7cb4a095 100644
--- a/src/applications/diffusion/conduit/DiffusionGetLintMessagesConduitAPIMethod.php
+++ b/src/applications/diffusion/conduit/DiffusionGetLintMessagesConduitAPIMethod.php
@@ -12,15 +12,15 @@ final class DiffusionGetLintMessagesConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Get lint messages for existing code.';
+    return pht('Get lint messages for existing code.');
   }
 
   protected function defineParamTypes() {
     return array(
-      'arcanistProject' => 'required string',
-      'branch'          => 'optional string',
-      'commit'          => 'optional string',
-      'files'           => 'required list<string>',
+      'repositoryPHID' => 'required phid',
+      'branch'         => 'required string',
+      'commit'         => 'optional string',
+      'files'          => 'required list<string>',
     );
   }
 
@@ -29,25 +29,31 @@ final class DiffusionGetLintMessagesConduitAPIMethod
   }
 
   protected function execute(ConduitAPIRequest $request) {
-    $project = id(new PhabricatorRepositoryArcanistProject())->loadOneWhere(
-      'name = %s',
-      $request->getValue('arcanistProject'));
-    if (!$project || !$project->getRepositoryID()) {
-      return array();
+    $viewer = $request->getUser();
+
+    $repository_phid = $request->getValue('repositoryPHID');
+    $repository = id(new PhabricatorRepositoryQuery())
+      ->setViewer($viewer)
+      ->withPHIDs(array($repository_phid))
+      ->executeOne();
+
+    if (!$repository) {
+      throw new Exception(
+        pht('No repository exists with PHID "%s".', $repository_phid));
     }
 
     $branch_name = $request->getValue('branch');
     if ($branch_name == '') {
       $repository = id(new PhabricatorRepositoryQuery())
         ->setViewer($request->getUser())
-        ->withIDs(array($project->getRepositoryID()))
+        ->withIDs(array($repository->getID()))
         ->executeOne();
       $branch_name = $repository->getDefaultArcanistBranch();
     }
 
     $branch = id(new PhabricatorRepositoryBranch())->loadOneWhere(
       'repositoryID = %d AND name = %s',
-      $project->getRepositoryID(),
+      $repository->getID(),
       $branch_name);
     if (!$branch || !$branch->getLintCommit()) {
       return array();

From 021223907dfd267f6d4f08d2dfc01597afb8d341 Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@joshuaspence.com>
Date: Tue, 19 May 2015 00:36:52 +1000
Subject: [PATCH 34/86] Remove arcanist projects from differential

Summary: Ref T7604. Remove arcanist projects from differential. Depends on D12687 and D12893.

Test Plan: Submitted a diff. Patched the diff with `arc patch`.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T7604

Differential Revision: https://secure.phabricator.com/D12894
---
 resources/celerity/map.php                    | 18 ++++----
 src/__phutil_library_map__.php                |  2 -
 ...DifferentialCreateDiffConduitAPIMethod.php | 19 +--------
 .../DifferentialGetDiffConduitAPIMethod.php   |  9 ++--
 ...ifferentialGetRevisionConduitAPIMethod.php |  7 ++--
 .../DifferentialQueryConduitAPIMethod.php     | 16 -------
 ...DifferentialQueryDiffsConduitAPIMethod.php |  1 -
 .../DifferentialRevisionViewController.php    |  1 -
 .../DifferentialArcanistProjectField.php      | 42 -------------------
 .../editor/DifferentialDiffEditor.php         |  3 +-
 .../editor/DifferentialTransactionEditor.php  |  1 -
 .../query/DifferentialDiffQuery.php           | 33 ---------------
 .../query/DifferentialRepositoryLookup.php    | 16 -------
 .../query/DifferentialRevisionQuery.php       | 21 ----------
 .../differential/storage/DifferentialDiff.php |  1 -
 ...torRepositoryCommitMessageParserWorker.php |  8 ----
 16 files changed, 19 insertions(+), 179 deletions(-)
 delete mode 100644 src/applications/differential/customfield/DifferentialArcanistProjectField.php

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 3aecd78dfc..5b985f4de7 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -11,7 +11,7 @@ return array(
     'core.pkg.js' => 'a2f2598e',
     'darkconsole.pkg.js' => 'e7393ebb',
     'differential.pkg.css' => 'bb338e4b',
-    'differential.pkg.js' => '895b8d62',
+    'differential.pkg.js' => '45b3b51d',
     'diffusion.pkg.css' => '591664fa',
     'diffusion.pkg.js' => '0115b37c',
     'maniphest.pkg.css' => '68d4dd3d',
@@ -397,7 +397,7 @@ return array(
     'rsrc/js/application/releeph/releeph-preview-branch.js' => 'b2b4fbaf',
     'rsrc/js/application/releeph/releeph-request-state-change.js' => 'a0b57eb8',
     'rsrc/js/application/releeph/releeph-request-typeahead.js' => 'de2e896f',
-    'rsrc/js/application/repository/repository-crossreference.js' => 'f9539603',
+    'rsrc/js/application/repository/repository-crossreference.js' => '3975b470',
     'rsrc/js/application/search/behavior-reorder-queries.js' => 'e9581f08',
     'rsrc/js/application/slowvote/behavior-slowvote-embed.js' => '887ad43f',
     'rsrc/js/application/transactions/behavior-show-older-transactions.js' => 'dbbf48b6',
@@ -631,7 +631,7 @@ return array(
     'javelin-behavior-remarkup-preview' => 'f7379f45',
     'javelin-behavior-reorder-applications' => '76b9fc3e',
     'javelin-behavior-reorder-columns' => 'e1d25dfb',
-    'javelin-behavior-repository-crossreference' => 'f9539603',
+    'javelin-behavior-repository-crossreference' => '3975b470',
     'javelin-behavior-scrollbar' => '834a1173',
     'javelin-behavior-search-reorder-queries' => 'e9581f08',
     'javelin-behavior-select-on-click' => '4e3e79a6',
@@ -1041,6 +1041,12 @@ return array(
     '331b1611' => array(
       'javelin-install',
     ),
+    '3975b470' => array(
+      'javelin-behavior',
+      'javelin-dom',
+      'javelin-stratcom',
+      'javelin-uri',
+    ),
     '3ab51e2c' => array(
       'javelin-behavior',
       'javelin-behavior-device',
@@ -1986,12 +1992,6 @@ return array(
       'javelin-util',
       'phabricator-busy',
     ),
-    'f9539603' => array(
-      'javelin-behavior',
-      'javelin-dom',
-      'javelin-stratcom',
-      'javelin-uri',
-    ),
     'fa0f4fc2' => array(
       'javelin-behavior',
       'javelin-dom',
diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index be579679c5..96d2502491 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -296,7 +296,6 @@ phutil_register_library_map(array(
     'DifferentialAdjustmentMapTestCase' => 'applications/differential/storage/__tests__/DifferentialAdjustmentMapTestCase.php',
     'DifferentialAffectedPath' => 'applications/differential/storage/DifferentialAffectedPath.php',
     'DifferentialApplyPatchField' => 'applications/differential/customfield/DifferentialApplyPatchField.php',
-    'DifferentialArcanistProjectField' => 'applications/differential/customfield/DifferentialArcanistProjectField.php',
     'DifferentialAsanaRepresentationField' => 'applications/differential/customfield/DifferentialAsanaRepresentationField.php',
     'DifferentialAuditorsField' => 'applications/differential/customfield/DifferentialAuditorsField.php',
     'DifferentialAuthorField' => 'applications/differential/customfield/DifferentialAuthorField.php',
@@ -3542,7 +3541,6 @@ phutil_register_library_map(array(
     'DifferentialAdjustmentMapTestCase' => 'ArcanistPhutilTestCase',
     'DifferentialAffectedPath' => 'DifferentialDAO',
     'DifferentialApplyPatchField' => 'DifferentialCustomField',
-    'DifferentialArcanistProjectField' => 'DifferentialCustomField',
     'DifferentialAsanaRepresentationField' => 'DifferentialCustomField',
     'DifferentialAuditorsField' => 'DifferentialStoredCustomField',
     'DifferentialAuthorField' => 'DifferentialCustomField',
diff --git a/src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php
index 6db5bc6cb4..8839eee6d7 100644
--- a/src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php
@@ -12,7 +12,6 @@ final class DifferentialCreateDiffConduitAPIMethod
   }
 
   protected function defineParamTypes() {
-
     $vcs_const = $this->formatStringConstants(
       array(
         'svn',
@@ -40,7 +39,7 @@ final class DifferentialCreateDiffConduitAPIMethod
       'sourceControlPath'         => 'required string',
       'sourceControlBaseRevision' => 'required string',
       'creationMethod'            => 'optional string',
-      'arcanistProject'           => 'optional string',
+      'arcanistProject'           => 'deprecated',
       'lintStatus'                => 'required '.$status_const,
       'unitStatus'                => 'required '.$status_const,
       'repositoryPHID'            => 'optional phid',
@@ -84,21 +83,6 @@ final class DifferentialCreateDiffConduitAPIMethod
       }
     }
 
-    $project_name = $request->getValue('arcanistProject');
-    $project_phid = null;
-    if ($project_name) {
-      $arcanist_project = id(new PhabricatorRepositoryArcanistProject())
-        ->loadOneWhere(
-          'name = %s',
-          $project_name);
-      if (!$arcanist_project) {
-        $arcanist_project = new PhabricatorRepositoryArcanistProject();
-        $arcanist_project->setName($project_name);
-        $arcanist_project->save();
-      }
-      $project_phid = $arcanist_project->getPHID();
-    }
-
     switch ($request->getValue('lintStatus')) {
       case 'skip':
         $lint_status = DifferentialLintStatus::LINT_SKIP;
@@ -156,7 +140,6 @@ final class DifferentialCreateDiffConduitAPIMethod
       'sourceControlPath' => $request->getValue('sourceControlPath'),
       'sourceControlBaseRevision' =>
         $request->getValue('sourceControlBaseRevision'),
-      'arcanistProjectPHID' => $project_phid,
       'lintStatus' => $lint_status,
       'unitStatus' => $unit_status,
     );
diff --git a/src/applications/differential/conduit/DifferentialGetDiffConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialGetDiffConduitAPIMethod.php
index 4770821f78..92d9807dda 100644
--- a/src/applications/differential/conduit/DifferentialGetDiffConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialGetDiffConduitAPIMethod.php
@@ -17,13 +17,15 @@ final class DifferentialGetDiffConduitAPIMethod
 
   public function getMethodStatusDescription() {
     return pht(
-      'This method has been deprecated in favor of differential.querydiffs.');
+      'This method has been deprecated in favor of %s.',
+      'differential.querydiffs');
   }
 
 
   public function getMethodDescription() {
-    return pht('Load the content of a diff from Differential by revision id '.
-               'or diff id.');
+    return pht(
+      'Load the content of a diff from Differential by revision id '.
+      'or diff id.');
   }
 
   protected function defineParamTypes() {
@@ -67,7 +69,6 @@ final class DifferentialGetDiffConduitAPIMethod
         ->setViewer($request->getUser())
         ->withIDs(array($diff_id))
         ->needChangesets(true)
-        ->needArcanistProjects(true)
         ->executeOne();
     }
 
diff --git a/src/applications/differential/conduit/DifferentialGetRevisionConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialGetRevisionConduitAPIMethod.php
index db0aeae83f..a158d86d9f 100644
--- a/src/applications/differential/conduit/DifferentialGetRevisionConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialGetRevisionConduitAPIMethod.php
@@ -12,11 +12,11 @@ final class DifferentialGetRevisionConduitAPIMethod
   }
 
   public function getMethodStatusDescription() {
-    return "Replaced by 'differential.query'.";
+    return pht("Replaced by '%s'.", 'differential.query');
   }
 
   public function getMethodDescription() {
-    return 'Load the content of a revision from Differential.';
+    return pht('Load the content of a revision from Differential.');
   }
 
   protected function defineParamTypes() {
@@ -31,7 +31,7 @@ final class DifferentialGetRevisionConduitAPIMethod
 
   protected function defineErrorTypes() {
     return array(
-      'ERR_BAD_REVISION'    => 'No such revision exists.',
+      'ERR_BAD_REVISION' => pht('No such revision exists.'),
     );
   }
 
@@ -56,7 +56,6 @@ final class DifferentialGetRevisionConduitAPIMethod
       ->setViewer($request->getUser())
       ->withRevisionIDs(array($revision_id))
       ->needChangesets(true)
-      ->needArcanistProjects(true)
       ->execute();
     $diff_dicts = mpull($diffs, 'getDiffDict');
 
diff --git a/src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php
index 04af9ff234..305b071be8 100644
--- a/src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php
@@ -44,7 +44,6 @@ final class DifferentialQueryConduitAPIMethod
       'subscribers'       => 'optional list<phid>',
       'responsibleUsers'  => 'optional list<phid>',
       'branches'          => 'optional list<string>',
-      'arcanistProjects'  => 'optional list<string>',
     );
   }
 
@@ -73,7 +72,6 @@ final class DifferentialQueryConduitAPIMethod
     $subscribers        = $request->getValue('subscribers');
     $responsible_users  = $request->getValue('responsibleUsers');
     $branches           = $request->getValue('branches');
-    $arc_projects       = $request->getValue('arcanistProjects');
 
     $query = id(new DifferentialRevisionQuery())
       ->setViewer($request->getUser());
@@ -169,19 +167,6 @@ final class DifferentialQueryConduitAPIMethod
     if ($branches) {
       $query->withBranches($branches);
     }
-    if ($arc_projects) {
-      // This is sort of special-cased, but don't make arc do an extra round
-      // trip.
-      $projects = id(new PhabricatorRepositoryArcanistProject())
-        ->loadAllWhere(
-          'name in (%Ls)',
-          $arc_projects);
-      if (!$projects) {
-        return array();
-      }
-
-      $query->withArcanistProjectPHIDs(mpull($projects, 'getPHID'));
-    }
 
     $query->needRelationships(true);
     $query->needCommitPHIDs(true);
@@ -228,7 +213,6 @@ final class DifferentialQueryConduitAPIMethod
         'ccs'                 => array_values($revision->getCCPHIDs()),
         'hashes'              => $revision->getHashes(),
         'auxiliary'           => idx($field_data, $phid, array()),
-        'arcanistProjectPHID' => $diff->getArcanistProjectPHID(),
         'repositoryPHID'      => $diff->getRepositoryPHID(),
       );
 
diff --git a/src/applications/differential/conduit/DifferentialQueryDiffsConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialQueryDiffsConduitAPIMethod.php
index 630f07da2b..836181d1df 100644
--- a/src/applications/differential/conduit/DifferentialQueryDiffsConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialQueryDiffsConduitAPIMethod.php
@@ -33,7 +33,6 @@ final class DifferentialQueryDiffsConduitAPIMethod
         ->withIDs($ids)
         ->withRevisionIDs($revision_ids)
         ->needChangesets(true)
-        ->needArcanistProjects(true)
         ->execute();
     }
 
diff --git a/src/applications/differential/controller/DifferentialRevisionViewController.php b/src/applications/differential/controller/DifferentialRevisionViewController.php
index d1b021b8d0..849ef056aa 100644
--- a/src/applications/differential/controller/DifferentialRevisionViewController.php
+++ b/src/applications/differential/controller/DifferentialRevisionViewController.php
@@ -33,7 +33,6 @@ final class DifferentialRevisionViewController extends DifferentialController {
     $diffs = id(new DifferentialDiffQuery())
       ->setViewer($request->getUser())
       ->withRevisionIDs(array($this->revisionID))
-      ->needArcanistProjects(true)
       ->execute();
     $diffs = array_reverse($diffs, $preserve_keys = true);
 
diff --git a/src/applications/differential/customfield/DifferentialArcanistProjectField.php b/src/applications/differential/customfield/DifferentialArcanistProjectField.php
deleted file mode 100644
index f884e701a6..0000000000
--- a/src/applications/differential/customfield/DifferentialArcanistProjectField.php
+++ /dev/null
@@ -1,42 +0,0 @@
-<?php
-
-final class DifferentialArcanistProjectField
-  extends DifferentialCustomField {
-
-  public function getFieldKey() {
-    return 'differential:arcanist-project';
-  }
-
-  public function getFieldName() {
-    return pht('Arcanist Project');
-  }
-
-  public function getFieldDescription() {
-    return pht('Shows arcanist project name.');
-  }
-
-  public function shouldAppearInPropertyView() {
-    return true;
-  }
-
-  public function renderPropertyViewLabel() {
-    return $this->getFieldName();
-  }
-
-  public function getRequiredHandlePHIDsForPropertyView() {
-    $phid = $this->getArcanistProjectPHID();
-    if ($phid) {
-      return array($phid);
-    }
-    return array();
-  }
-
-  public function renderPropertyViewValue(array $handles) {
-    return $this->renderHandleList($handles);
-  }
-
-  private function getArcanistProjectPHID() {
-    return $this->getObject()->getActiveDiff()->getArcanistProjectPHID();
-  }
-
-}
diff --git a/src/applications/differential/editor/DifferentialDiffEditor.php b/src/applications/differential/editor/DifferentialDiffEditor.php
index 9d4fa0767c..25385899b1 100644
--- a/src/applications/differential/editor/DifferentialDiffEditor.php
+++ b/src/applications/differential/editor/DifferentialDiffEditor.php
@@ -234,8 +234,7 @@ final class DifferentialDiffEditor
       ->setSourceControlPath(idx($dict, 'sourceControlPath'))
       ->setSourceControlBaseRevision(idx($dict, 'sourceControlBaseRevision'))
       ->setLintStatus(idx($dict, 'lintStatus'))
-      ->setUnitStatus(idx($dict, 'unitStatus'))
-      ->setArcanistProjectPHID(idx($dict, 'arcanistProjectPHID'));
+      ->setUnitStatus(idx($dict, 'unitStatus'));
 
     return $diff;
   }
diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php
index 113d6924f3..94889213ba 100644
--- a/src/applications/differential/editor/DifferentialTransactionEditor.php
+++ b/src/applications/differential/editor/DifferentialTransactionEditor.php
@@ -220,7 +220,6 @@ final class DifferentialTransactionEditor
         } else {
           $object->setRepositoryPHID($diff->getRepositoryPHID());
         }
-        $object->setArcanistProjectPHID($diff->getArcanistProjectPHID());
         $object->attachActiveDiff($diff);
 
         // TODO: Update the `diffPHID` once we add that.
diff --git a/src/applications/differential/query/DifferentialDiffQuery.php b/src/applications/differential/query/DifferentialDiffQuery.php
index 15ddc9c46b..1616d58ac8 100644
--- a/src/applications/differential/query/DifferentialDiffQuery.php
+++ b/src/applications/differential/query/DifferentialDiffQuery.php
@@ -7,7 +7,6 @@ final class DifferentialDiffQuery
   private $phids;
   private $revisionIDs;
   private $needChangesets = false;
-  private $needArcanistProjects = false;
 
   public function withIDs(array $ids) {
     $this->ids = $ids;
@@ -29,11 +28,6 @@ final class DifferentialDiffQuery
     return $this;
   }
 
-  public function needArcanistProjects($bool) {
-    $this->needArcanistProjects = $bool;
-    return $this;
-  }
-
   protected function loadPage() {
     $table = new DifferentialDiff();
     $conn_r = $table->establishConnection('r');
@@ -79,10 +73,6 @@ final class DifferentialDiffQuery
       $diffs = $this->loadChangesets($diffs);
     }
 
-    if ($diffs && $this->needArcanistProjects) {
-      $diffs = $this->loadArcanistProjects($diffs);
-    }
-
     return $diffs;
   }
 
@@ -98,29 +88,6 @@ final class DifferentialDiffQuery
     return $diffs;
   }
 
-  private function loadArcanistProjects(array $diffs) {
-    $phids = array_filter(mpull($diffs, 'getArcanistProjectPHID'));
-    $projects = array();
-    $project_map = array();
-    if ($phids) {
-      $projects = id(new PhabricatorRepositoryArcanistProject())
-        ->loadAllWhere(
-          'phid IN (%Ls)',
-          $phids);
-      $project_map = mpull($projects, null, 'getPHID');
-    }
-
-    foreach ($diffs as $diff) {
-      $project = null;
-      if ($diff->getArcanistProjectPHID()) {
-        $project = idx($project_map, $diff->getArcanistProjectPHID());
-      }
-      $diff->attachArcanistProject($project);
-    }
-
-    return $diffs;
-  }
-
   protected function buildWhereClause(AphrontDatabaseConnection $conn_r) {
     $where = array();
 
diff --git a/src/applications/differential/query/DifferentialRepositoryLookup.php b/src/applications/differential/query/DifferentialRepositoryLookup.php
index c964bf4580..4a498edb55 100644
--- a/src/applications/differential/query/DifferentialRepositoryLookup.php
+++ b/src/applications/differential/query/DifferentialRepositoryLookup.php
@@ -22,22 +22,6 @@ final class DifferentialRepositoryLookup extends Phobject {
     $viewer = $this->viewer;
     $diff = $this->diff;
 
-    // Look for an explicit Arcanist project.
-    if ($diff->getArcanistProjectPHID()) {
-      $project = id(new PhabricatorRepositoryArcanistProject())->loadOneWhere(
-        'phid = %s',
-        $diff->getArcanistProjectPHID());
-      if ($project && $project->getRepositoryID()) {
-        $repositories = id(new PhabricatorRepositoryQuery())
-          ->setViewer($viewer)
-          ->withIDs(array($project->getRepositoryID()))
-          ->execute();
-        if ($repositories) {
-          return head($repositories);
-        }
-      }
-    }
-
     // Look for a repository UUID.
     if ($diff->getRepositoryUUID()) {
       $repositories = id(new PhabricatorRepositoryQuery())
diff --git a/src/applications/differential/query/DifferentialRevisionQuery.php b/src/applications/differential/query/DifferentialRevisionQuery.php
index 2ac7289853..d49ef34887 100644
--- a/src/applications/differential/query/DifferentialRevisionQuery.php
+++ b/src/applications/differential/query/DifferentialRevisionQuery.php
@@ -36,7 +36,6 @@ final class DifferentialRevisionQuery
   private $phids = array();
   private $responsibles = array();
   private $branches = array();
-  private $arcanistProjectPHIDs = array();
   private $repositoryPHIDs;
   private $updatedEpochMin;
   private $updatedEpochMax;
@@ -228,19 +227,6 @@ final class DifferentialRevisionQuery
   }
 
 
-  /**
-   * Filter results to only return revisions with a given set of arcanist
-   * projects.
-   *
-   * @param array List of project PHIDs.
-   * @return this
-   * @task config
-   */
-  public function withArcanistProjectPHIDs(array $arc_project_phids) {
-    $this->arcanistProjectPHIDs = $arc_project_phids;
-    return $this;
-  }
-
   public function withRepositoryPHIDs(array $repository_phids) {
     $this->repositoryPHIDs = $repository_phids;
     return $this;
@@ -771,13 +757,6 @@ final class DifferentialRevisionQuery
         $this->branches);
     }
 
-    if ($this->arcanistProjectPHIDs) {
-      $where[] = qsprintf(
-        $conn_r,
-        'r.arcanistProjectPHID in (%Ls)',
-        $this->arcanistProjectPHIDs);
-    }
-
     if ($this->updatedEpochMin !== null) {
       $where[] = qsprintf(
         $conn_r,
diff --git a/src/applications/differential/storage/DifferentialDiff.php b/src/applications/differential/storage/DifferentialDiff.php
index 9092f365bc..6c67cff51e 100644
--- a/src/applications/differential/storage/DifferentialDiff.php
+++ b/src/applications/differential/storage/DifferentialDiff.php
@@ -262,7 +262,6 @@ final class DifferentialDiff
       'lintStatus' => $this->getLintStatus(),
       'changes' => array(),
       'properties' => array(),
-      'projectName' => $this->getArcanistProjectName(),
     );
 
     $dict['changes'] = $this->buildChangesList();
diff --git a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
index 25272ca940..89fa5f34f4 100644
--- a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
+++ b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
@@ -321,14 +321,6 @@ abstract class PhabricatorRepositoryCommitMessageParserWorker
         $this->repository->getCallsign().
         $this->commit->getCommitIdentifier());
 
-    // TODO: This is not correct in SVN where one repository can have multiple
-    // Arcanist projects.
-    $arcanist_project = id(new PhabricatorRepositoryArcanistProject())
-      ->loadOneWhere('repositoryID = %d LIMIT 1', $this->repository->getID());
-    if ($arcanist_project) {
-      $diff->setArcanistProjectPHID($arcanist_project->getPHID());
-    }
-
     $parents = DiffusionQuery::callConduitWithDiffusionRequest(
       $viewer,
       $drequest,

From 44cf60dfd2f641008d0d3d26f141c5b7b75ee7c4 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Mon, 18 May 2015 10:26:53 -0700
Subject: [PATCH 35/86] Fail more softly on funky arcanist project / symbol
 data

Summary: Fixes T8240, probably?

Test Plan: This is hard to test locally post-migration -- @btrahan, does it fix things for you?

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: btrahan, epriestley

Maniphest Tasks: T8240

Differential Revision: https://secure.phabricator.com/D12903
---
 .../sql/autopatches/20150504.symbolsproject.1.php  | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/resources/sql/autopatches/20150504.symbolsproject.1.php b/resources/sql/autopatches/20150504.symbolsproject.1.php
index e3c3db66e1..8ab77bbef4 100644
--- a/resources/sql/autopatches/20150504.symbolsproject.1.php
+++ b/resources/sql/autopatches/20150504.symbolsproject.1.php
@@ -38,7 +38,12 @@ foreach ($raw_projects_data as $project_row) {
     idx($project_row, 'name', '???'));
 
   $symbol_index_projects = $project_row['symbolIndexProjects'];
-  $symbol_index_projects = phutil_json_decode($symbol_index_projects);
+  $symbol_index_projects = nonempty($symbol_index_projects, '[]');
+  try {
+    $symbol_index_projects = phutil_json_decode($symbol_index_projects);
+  } catch (PhutilJSONParserException $ex) {
+    continue;
+  }
 
   $sources = $repo->getDetail('symbol-sources', array());
   foreach ($symbol_index_projects as $index_project) {
@@ -50,7 +55,12 @@ foreach ($raw_projects_data as $project_row) {
   $repo->setDetail('symbol-sources', $sources);
 
   $languages = $project_row['symbolIndexLanguages'];
-  $languages = phutil_json_decode($languages);
+  $languages = nonempty($languages, '[]');
+  try {
+    $languages = phutil_json_decode($languages);
+  } catch (PhutilJSONParserException $ex) {
+    continue;
+  }
 
   $languages = array_merge(
     $repo->getDetail('symbol-languages', array()),

From 1970ebcd7b732768eb81df7df9f875ea60ed47e7 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Mon, 18 May 2015 10:28:19 -0700
Subject: [PATCH 36/86] Never generate $0.00 invoices

Summary: Ref T7769. It might possibly make sense to generate these some day, but for now they aren't payable and we have no use for them.

Test Plan:
  - Generated $0.00 invoices, saw code decline to invoice.
  - Generated a $7.99 invoice, got an invoice.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7769

Differential Revision: https://secure.phabricator.com/D12878
---
 .../phortune/worker/PhortuneSubscriptionWorker.php    | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/applications/phortune/worker/PhortuneSubscriptionWorker.php b/src/applications/phortune/worker/PhortuneSubscriptionWorker.php
index a3235d464f..747b4b3889 100644
--- a/src/applications/phortune/worker/PhortuneSubscriptionWorker.php
+++ b/src/applications/phortune/worker/PhortuneSubscriptionWorker.php
@@ -15,6 +15,13 @@ final class PhortuneSubscriptionWorker extends PhabricatorWorker {
       return;
     }
 
+    $currency = $subscription->getCostForBillingPeriodAsCurrency(
+      $last_epoch,
+      $next_epoch);
+    if (!$currency->isPositive()) {
+      return;
+    }
+
     $account = $subscription->getAccount();
     $merchant = $subscription->getMerchant();
 
@@ -48,10 +55,6 @@ final class PhortuneSubscriptionWorker extends PhabricatorWorker {
 
     $purchase = $cart->newPurchase($actor, $product);
 
-    $currency = $subscription->getCostForBillingPeriodAsCurrency(
-      $last_epoch,
-      $next_epoch);
-
     $purchase
       ->setBasePriceAsCurrency($currency)
       ->setMetadataValue('subscriptionPHID', $subscription->getPHID())

From 107d6db1e8f638f40e3f7489a380480f1c9869ef Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Mon, 18 May 2015 12:18:10 -0700
Subject: [PATCH 37/86] Don't put a spacer line on the bottom of previews

Summary: Fixes T8182. See screenshot in that task. We currently render a line to nowhere at the bottom of these previews. Instead, only render a line at the top.

Test Plan:
{F409078}

Also looked at a couple other applications that use this and they looked correct.

Reviewers: btrahan, lpriestley, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T8182

Differential Revision: https://secure.phabricator.com/D12905
---
 resources/celerity/map.php                     | 18 +++++++++---------
 .../behavior-transaction-comment-form.js       |  3 +--
 2 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 5b985f4de7..10b67a500e 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -401,7 +401,7 @@ return array(
     'rsrc/js/application/search/behavior-reorder-queries.js' => 'e9581f08',
     'rsrc/js/application/slowvote/behavior-slowvote-embed.js' => '887ad43f',
     'rsrc/js/application/transactions/behavior-show-older-transactions.js' => 'dbbf48b6',
-    'rsrc/js/application/transactions/behavior-transaction-comment-form.js' => '9f7309fb',
+    'rsrc/js/application/transactions/behavior-transaction-comment-form.js' => 'b23b49e6',
     'rsrc/js/application/transactions/behavior-transaction-list.js' => '13c739ea',
     'rsrc/js/application/typeahead/behavior-typeahead-browse.js' => '635de1ec',
     'rsrc/js/application/typeahead/behavior-typeahead-search.js' => '93d0c9e3',
@@ -610,7 +610,7 @@ return array(
     'javelin-behavior-phabricator-search-typeahead' => '048330fa',
     'javelin-behavior-phabricator-show-older-transactions' => 'dbbf48b6',
     'javelin-behavior-phabricator-tooltips' => '3ee3408b',
-    'javelin-behavior-phabricator-transaction-comment-form' => '9f7309fb',
+    'javelin-behavior-phabricator-transaction-comment-form' => 'b23b49e6',
     'javelin-behavior-phabricator-transaction-list' => '13c739ea',
     'javelin-behavior-phabricator-watch-anchor' => '9f36c42d',
     'javelin-behavior-phame-post-preview' => 'be807912',
@@ -1581,13 +1581,6 @@ return array(
       'javelin-dom',
       'javelin-vector',
     ),
-    '9f7309fb' => array(
-      'javelin-behavior',
-      'javelin-dom',
-      'javelin-util',
-      'javelin-request',
-      'phabricator-shaped-request',
-    ),
     'a0b57eb8' => array(
       'javelin-behavior',
       'javelin-dom',
@@ -1677,6 +1670,13 @@ return array(
       'javelin-dom',
       'javelin-reactor-dom',
     ),
+    'b23b49e6' => array(
+      'javelin-behavior',
+      'javelin-dom',
+      'javelin-util',
+      'javelin-request',
+      'phabricator-shaped-request',
+    ),
     'b2b4fbaf' => array(
       'javelin-behavior',
       'javelin-dom',
diff --git a/webroot/rsrc/js/application/transactions/behavior-transaction-comment-form.js b/webroot/rsrc/js/application/transactions/behavior-transaction-comment-form.js
index 119ec02d21..935116c3b3 100644
--- a/webroot/rsrc/js/application/transactions/behavior-transaction-comment-form.js
+++ b/webroot/rsrc/js/application/transactions/behavior-transaction-comment-form.js
@@ -26,8 +26,7 @@ JX.behavior('phabricator-transaction-comment-form', function(config) {
         JX.$(config.timelineID),
         [
           JX.$H(response.spacer),
-          JX.$H(response.xactions.join(response.spacer)),
-          JX.$H(response.spacer)
+          JX.$H(response.xactions.join(response.spacer))
         ]);
       JX.DOM.show(panel);
     }

From 4250719d100814b996b9e0000f608005b1a4508b Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Mon, 18 May 2015 12:29:32 -0700
Subject: [PATCH 38/86] Destroy notifications properly from `bin/remove
 destroy`

Summary: Fixes T8237. This table is unusual and doesn't have an `id` column, so `delete()` doesn't actually know how to delete records and fails.

Test Plan:
  - Used `bin/remove destroy` to destroy an object with notifications, as per T8237.
  - Applied patch.
  - Used `bin/remove destroy` to get a clean delete.
  - Verified related notifications vanished from notification menu.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8237

Differential Revision: https://secure.phabricator.com/D12907
---
 .../system/engine/PhabricatorDestructionEngine.php  | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/applications/system/engine/PhabricatorDestructionEngine.php b/src/applications/system/engine/PhabricatorDestructionEngine.php
index c5b813169c..eddc2f73fb 100644
--- a/src/applications/system/engine/PhabricatorDestructionEngine.php
+++ b/src/applications/system/engine/PhabricatorDestructionEngine.php
@@ -116,13 +116,14 @@ final class PhabricatorDestructionEngine extends Phobject {
   }
 
   private function destroyNotifications($object_phid) {
-    $notifications = id(new PhabricatorFeedStoryNotification())->loadAllWhere(
-      'primaryObjectPHID = %s',
-      $object_phid);
+    $table = id(new PhabricatorFeedStoryNotification());
+    $conn_w = $table->establishConnection('w');
 
-    foreach ($notifications as $notification) {
-      $notification->delete();
-    }
+    queryfx(
+      $conn_w,
+      'DELETE FROM %T WHERE primaryObjectPHID = %s',
+      $table->getTableName(),
+      $object_phid);
   }
 
 }

From 22ed02a549f78fb604e950af4bc87dde12174c1a Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Mon, 18 May 2015 12:51:06 -0700
Subject: [PATCH 39/86] Make workboard CSS aware of the durable column

Summary: Fixes T8246. Workboards needed a tweak after the native-scrollbar compromise.

Test Plan: Viewed workboards with column open/closed, saw workspace size correctly.

Reviewers: chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T8246

Differential Revision: https://secure.phabricator.com/D12906
---
 resources/celerity/map.php                    | 4 ++--
 webroot/rsrc/css/phui/phui-workboard-view.css | 8 ++++++++
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 10b67a500e..608cf808c6 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -151,7 +151,7 @@ return array(
     'rsrc/css/phui/phui-tag-view.css' => '402691cc',
     'rsrc/css/phui/phui-text.css' => 'cf019f54',
     'rsrc/css/phui/phui-timeline-view.css' => 'a85542c8',
-    'rsrc/css/phui/phui-workboard-view.css' => '3279cbbf',
+    'rsrc/css/phui/phui-workboard-view.css' => '5c4c53e9',
     'rsrc/css/phui/phui-workpanel-view.css' => 'e495a5cc',
     'rsrc/css/sprite-gradient.css' => '4bdb98a7',
     'rsrc/css/sprite-login.css' => 'a3526809',
@@ -788,7 +788,7 @@ return array(
     'phui-tag-view-css' => '402691cc',
     'phui-text-css' => 'cf019f54',
     'phui-timeline-view-css' => 'a85542c8',
-    'phui-workboard-view-css' => '3279cbbf',
+    'phui-workboard-view-css' => '5c4c53e9',
     'phui-workpanel-view-css' => 'e495a5cc',
     'phuix-action-list-view' => 'b5c256b8',
     'phuix-action-view' => '8cf6d262',
diff --git a/webroot/rsrc/css/phui/phui-workboard-view.css b/webroot/rsrc/css/phui/phui-workboard-view.css
index 796fbc6fe5..40f3d0d2b9 100644
--- a/webroot/rsrc/css/phui/phui-workboard-view.css
+++ b/webroot/rsrc/css/phui/phui-workboard-view.css
@@ -19,6 +19,14 @@
   top: 148px;
 }
 
+.device-desktop.with-durable-column .phui-workboard-view-shadow {
+  right: 300px;
+}
+
+.device-desktop.with-durable-margin .phui-workboard-view-shadow {
+  right: 312px;
+}
+
 .phui-workboard-view-shadow::-webkit-scrollbar {
   height: 12px;
   width: 12px;

From 3167b5526470d2620e1ac82d252b53829b512dbf Mon Sep 17 00:00:00 2001
From: lkassianik <lyubakassianik@gmail.com>
Date: Mon, 18 May 2015 12:54:46 -0700
Subject: [PATCH 40/86] A temporary css cleanup to hold us over till a proper
 css overhaul.

Summary: Ref T8187, A temporary css cleanup to hold us over till a proper css overhaul.

Test Plan: Mostly, confirm that long event names don't break the calendar month view.

Reviewers: chad, #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8187

Differential Revision: https://secure.phabricator.com/D12908
---
 resources/celerity/map.php                    |  8 ++--
 .../phui/calendar/PHUICalendarListView.php    |  2 +-
 .../css/phui/calendar/phui-calendar-list.css  |  1 -
 .../css/phui/calendar/phui-calendar-month.css | 46 ++++++++++++-------
 4 files changed, 35 insertions(+), 22 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 608cf808c6..54000b66cf 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -121,8 +121,8 @@ return array(
     'rsrc/css/layout/phabricator-side-menu-view.css' => 'c1db9e9c',
     'rsrc/css/layout/phabricator-source-code-view.css' => '2ceee894',
     'rsrc/css/phui/calendar/phui-calendar-day.css' => '3b4a65d8',
-    'rsrc/css/phui/calendar/phui-calendar-list.css' => '840baa8d',
-    'rsrc/css/phui/calendar/phui-calendar-month.css' => '5b213ea0',
+    'rsrc/css/phui/calendar/phui-calendar-list.css' => '3e713fc7',
+    'rsrc/css/phui/calendar/phui-calendar-month.css' => '7cf00f61',
     'rsrc/css/phui/calendar/phui-calendar.css' => '8345be98',
     'rsrc/css/phui/phui-action-header-view.css' => '89c497e7',
     'rsrc/css/phui/phui-action-list.css' => '4f4d09f2',
@@ -762,8 +762,8 @@ return array(
     'phui-button-css' => 'de610129',
     'phui-calendar-css' => '8345be98',
     'phui-calendar-day-css' => '3b4a65d8',
-    'phui-calendar-list-css' => '840baa8d',
-    'phui-calendar-month-css' => '5b213ea0',
+    'phui-calendar-list-css' => '3e713fc7',
+    'phui-calendar-month-css' => '7cf00f61',
     'phui-crumbs-view-css' => '594d719e',
     'phui-document-view-css' => '94d5dcd8',
     'phui-feed-story-css' => 'c9f3a0b5',
diff --git a/src/view/phui/calendar/PHUICalendarListView.php b/src/view/phui/calendar/PHUICalendarListView.php
index e315aa93d1..3356d5d0fb 100644
--- a/src/view/phui/calendar/PHUICalendarListView.php
+++ b/src/view/phui/calendar/PHUICalendarListView.php
@@ -79,8 +79,8 @@ final class PHUICalendarListView extends AphrontTagView {
           ),
         array(
           $dot,
-          $title,
           $time,
+          $title,
         ));
     }
 
diff --git a/webroot/rsrc/css/phui/calendar/phui-calendar-list.css b/webroot/rsrc/css/phui/calendar/phui-calendar-list.css
index db69c78d03..80d34d2f5a 100644
--- a/webroot/rsrc/css/phui/calendar/phui-calendar-list.css
+++ b/webroot/rsrc/css/phui/calendar/phui-calendar-list.css
@@ -55,7 +55,6 @@
   top: 0;
   width: 60px;
   right: 0;
-  top: 0;
   color: {$lightgreytext};
   text-align: right;
 }
diff --git a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
index 6b5c0aeb86..bb02c4c54d 100644
--- a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
+++ b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
@@ -154,6 +154,7 @@ table.phui-calendar-view td.phui-calendar-date-number-container {
 }
 
 .phui-calendar-view .phui-calendar-list li.phui-calendar-list-item.all-day {
+  height: 20px;
   margin: 0;
   padding: 4px 4px 0px 4px;
   background-color: {$darkgreybackground};
@@ -180,24 +181,36 @@ li.phui-calendar-list-item.all-day:first-child {
 }
 
 .phui-calendar-view .phui-calendar-list-dot {
+  position: relative;
+  display: inline-block;
+  float: left;
   width: 3px;
   height: 3px;
   margin-right: 4px;
   border-radius: 10px;
-  position: absolute;
   top: 5px;
   left: 0;
+  display: none;
 }
 
-.phui-calendar-view .phui-calendar-list-title {
-  width: auto;
-  white-space: normal;
-  word-break: break-word;
+.phui-calendar-view li.phui-calendar-list-item {
+  padding: 0;
+}
+
+.phui-calendar-view li.phui-calendar-list-item .phui-calendar-list-title {
+  position: relative;
+  /*float: right;*/
+  display: inline-block;
+  width: 120px;
+  padding: 0;
+  line-height: 18px;
+  vertical-align: center;
 }
 
 li.phui-calendar-list-item .phui-calendar-list-title a {
-  text-align: left;
-  padding-left: 8px;
+  padding: 0;
+  vertical-align: top;
+  line-height: 16px;
   overflow: hidden;
   text-overflow: ellipsis;
   white-space: nowrap;
@@ -205,6 +218,8 @@ li.phui-calendar-list-item .phui-calendar-list-title a {
 
 li.phui-calendar-list-item.all-day .phui-calendar-list-title a{
   color: {$greytext};
+  margin: 0;
+  padding: 0;
 }
 
 li.phui-calendar-viewer-invited.all-day .phui-calendar-list-title a{
@@ -212,17 +227,16 @@ li.phui-calendar-viewer-invited.all-day .phui-calendar-list-title a{
 }
 
 .phui-calendar-view li.phui-calendar-list-item .phui-calendar-list-time {
-  position: absolute;
+  position: relative;
+  display: inline-block;
+  float: left;
+  padding: 0;
+  line-height: 18px;
   width: 60px;
-  right: 0;
-  top: 1px;
   color: {$lightgreytext};
-  text-align: right;
+  text-align: left;
 }
 
-.phui-calendar-view
-li.phui-calendar-list-item.all-day
-.phui-calendar-list-time  {
-  top: 4px;
-  right: 8px;
+li.phui-calendar-list-item.all-day .phui-calendar-list-time{
+  margin: 0 0 0 4px;
 }

From 78dddf39ba7200cb71303b167278161747fb6d1a Mon Sep 17 00:00:00 2001
From: Bob Trahan <btrahan@phacility.com>
Date: Mon, 18 May 2015 13:07:05 -0700
Subject: [PATCH 41/86] Maniphest - prevent uneditable tasks from being able to
 be closed as duplicates

Summary:
Fixes T7923.

Prevent the user from finding tasks that they can't edit in merge workflows. Also ensure that we query properly on final merge action just in case.

Test Plan: Tried to find a task I couldn't edit in various searches under the "merge" dialogue and couldn't find the task. Removed this big of code and tried to merge in a task and after hitting "merge" observed the page reloaded with no task merged in.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7923

Differential Revision: https://secure.phabricator.com/D12872
---
 .../phid/query/PhabricatorHandleQuery.php     | 14 +++++
 .../PhabricatorSearchApplication.php          |  2 +-
 .../PhabricatorSearchAttachController.php     | 59 ++++++++-----------
 .../PhabricatorSearchBaseController.php       |  6 ++
 .../PhabricatorSearchSelectController.php     | 35 ++++++-----
 .../query/PhabricatorSearchDocumentQuery.php  | 14 +++++
 6 files changed, 80 insertions(+), 50 deletions(-)

diff --git a/src/applications/phid/query/PhabricatorHandleQuery.php b/src/applications/phid/query/PhabricatorHandleQuery.php
index 296116312b..2635b84298 100644
--- a/src/applications/phid/query/PhabricatorHandleQuery.php
+++ b/src/applications/phid/query/PhabricatorHandleQuery.php
@@ -3,6 +3,7 @@
 final class PhabricatorHandleQuery
   extends PhabricatorCursorPagedPolicyAwareQuery {
 
+  private $objectCapabilities;
   private $phids = array();
 
   public function withPHIDs(array $phids) {
@@ -10,6 +11,18 @@ final class PhabricatorHandleQuery
     return $this;
   }
 
+  public function requireObjectCapabilities(array $capabilities) {
+    $this->objectCapabilities = $capabilities;
+    return $this;
+  }
+
+  protected function getRequiredObjectCapabilities() {
+    if ($this->objectCapabilities) {
+      return $this->objectCapabilities;
+    }
+    return $this->getRequiredCapabilities();
+  }
+
   protected function loadPage() {
     $types = PhabricatorPHIDType::getAllTypes();
 
@@ -20,6 +33,7 @@ final class PhabricatorHandleQuery
 
     $object_query = id(new PhabricatorObjectQuery())
       ->withPHIDs($phids)
+      ->requireCapabilities($this->getRequiredObjectCapabilities())
       ->setViewer($this->getViewer());
 
     $objects = $object_query->execute();
diff --git a/src/applications/search/application/PhabricatorSearchApplication.php b/src/applications/search/application/PhabricatorSearchApplication.php
index 51d5e9780c..f350438616 100644
--- a/src/applications/search/application/PhabricatorSearchApplication.php
+++ b/src/applications/search/application/PhabricatorSearchApplication.php
@@ -32,7 +32,7 @@ final class PhabricatorSearchApplication extends PhabricatorApplication {
         '(?:query/(?P<queryKey>[^/]+)/)?' => 'PhabricatorSearchController',
         'attach/(?P<phid>[^/]+)/(?P<type>\w+)/(?:(?P<action>\w+)/)?'
           => 'PhabricatorSearchAttachController',
-        'select/(?P<type>\w+)/'
+        'select/(?P<type>\w+)/(?:(?P<action>\w+)/)?'
           => 'PhabricatorSearchSelectController',
         'index/(?P<phid>[^/]+)/' => 'PhabricatorSearchIndexController',
         'hovercard/(?P<mode>retrieve|test)/'
diff --git a/src/applications/search/controller/PhabricatorSearchAttachController.php b/src/applications/search/controller/PhabricatorSearchAttachController.php
index e08fd7734c..b2e0a92b9d 100644
--- a/src/applications/search/controller/PhabricatorSearchAttachController.php
+++ b/src/applications/search/controller/PhabricatorSearchAttachController.php
@@ -3,38 +3,22 @@
 final class PhabricatorSearchAttachController
   extends PhabricatorSearchBaseController {
 
-  private $phid;
-  private $type;
-  private $action;
-
-  const ACTION_ATTACH       = 'attach';
-  const ACTION_MERGE        = 'merge';
-  const ACTION_DEPENDENCIES = 'dependencies';
-  const ACTION_BLOCKS       = 'blocks';
-  const ACTION_EDGE         = 'edge';
-
-  public function willProcessRequest(array $data) {
-    $this->phid = $data['phid'];
-    $this->type = $data['type'];
-    $this->action = idx($data, 'action', self::ACTION_ATTACH);
-  }
-
-  public function processRequest() {
-
-    $request = $this->getRequest();
-    $user = $request->getUser();
+  public function handleRequest(AphrontRequest $request) {
+    $user        = $request->getUser();
+    $phid        = $request->getURIData('phid');
+    $attach_type = $request->getURIData('type');
+    $action      = $request->getURIData('action', self::ACTION_ATTACH);
 
     $handle = id(new PhabricatorHandleQuery())
       ->setViewer($user)
-      ->withPHIDs(array($this->phid))
+      ->withPHIDs(array($phid))
       ->executeOne();
 
     $object_type = $handle->getType();
-    $attach_type = $this->type;
 
     $object = id(new PhabricatorObjectQuery())
       ->setViewer($user)
-      ->withPHIDs(array($this->phid))
+      ->withPHIDs(array($phid))
       ->executeOne();
 
     if (!$object) {
@@ -42,7 +26,7 @@ final class PhabricatorSearchAttachController
     }
 
     $edge_type = null;
-    switch ($this->action) {
+    switch ($action) {
       case self::ACTION_EDGE:
       case self::ACTION_DEPENDENCIES:
       case self::ACTION_BLOCKS:
@@ -66,7 +50,7 @@ final class PhabricatorSearchAttachController
         }
 
         $old_phids = PhabricatorEdgeQuery::loadDestinationPHIDs(
-          $this->phid,
+          $phid,
           $edge_type);
         $add_phids = $phids;
         $rem_phids = array_diff($old_phids, $add_phids);
@@ -100,7 +84,7 @@ final class PhabricatorSearchAttachController
     } else {
       if ($edge_type) {
         $phids = PhabricatorEdgeQuery::loadDestinationPHIDs(
-          $this->phid,
+          $phid,
           $edge_type);
       } else {
         // This is a merge.
@@ -108,7 +92,7 @@ final class PhabricatorSearchAttachController
       }
     }
 
-    $strings = $this->getStrings();
+    $strings = $this->getStrings($attach_type, $action);
 
     $handles = $this->loadViewerHandles($phids);
 
@@ -116,11 +100,11 @@ final class PhabricatorSearchAttachController
     $obj_dialog
       ->setUser($user)
       ->setHandles($handles)
-      ->setFilters($this->getFilters($strings))
+      ->setFilters($this->getFilters($strings, $attach_type))
       ->setSelectedFilter($strings['selected'])
-      ->setExcluded($this->phid)
+      ->setExcluded($phid)
       ->setCancelURI($handle->getURI())
-      ->setSearchURI('/search/select/'.$attach_type.'/')
+      ->setSearchURI('/search/select/'.$attach_type.'/'.$action.'/')
       ->setTitle($strings['title'])
       ->setHeader($strings['header'])
       ->setButtonText($strings['button'])
@@ -148,6 +132,11 @@ final class PhabricatorSearchAttachController
 
     $targets = id(new ManiphestTaskQuery())
       ->setViewer($user)
+      ->requireCapabilities(
+        array(
+          PhabricatorPolicyCapability::CAN_VIEW,
+          PhabricatorPolicyCapability::CAN_EDIT,
+        ))
       ->withPHIDs(array_keys($phids))
       ->needSubscriberPHIDs(true)
       ->needProjectPHIDs(true)
@@ -208,8 +197,8 @@ final class PhabricatorSearchAttachController
     return $response;
   }
 
-  private function getStrings() {
-    switch ($this->type) {
+  private function getStrings($attach_type, $action) {
+    switch ($attach_type) {
       case DifferentialRevisionPHIDType::TYPECONST:
         $noun = 'Revisions';
         $selected = 'created';
@@ -228,7 +217,7 @@ final class PhabricatorSearchAttachController
         break;
     }
 
-    switch ($this->action) {
+    switch ($action) {
       case self::ACTION_EDGE:
       case self::ACTION_ATTACH:
         $dialog_title = "Manage Attached {$noun}";
@@ -268,8 +257,8 @@ final class PhabricatorSearchAttachController
     );
   }
 
-  private function getFilters(array $strings) {
-    if ($this->type == PholioMockPHIDType::TYPECONST) {
+  private function getFilters(array $strings, $attach_type) {
+    if ($attach_type == PholioMockPHIDType::TYPECONST) {
       $filters = array(
         'created' => 'Created By Me',
         'all' => 'All '.$strings['target_plural_noun'],
diff --git a/src/applications/search/controller/PhabricatorSearchBaseController.php b/src/applications/search/controller/PhabricatorSearchBaseController.php
index 446406dfea..86573b38bd 100644
--- a/src/applications/search/controller/PhabricatorSearchBaseController.php
+++ b/src/applications/search/controller/PhabricatorSearchBaseController.php
@@ -2,6 +2,12 @@
 
 abstract class PhabricatorSearchBaseController extends PhabricatorController {
 
+  const ACTION_ATTACH       = 'attach';
+  const ACTION_MERGE        = 'merge';
+  const ACTION_DEPENDENCIES = 'dependencies';
+  const ACTION_BLOCKS       = 'blocks';
+  const ACTION_EDGE         = 'edge';
+
   public function buildStandardPageResponse($view, array $data) {
     $page = $this->buildStandardPageView();
 
diff --git a/src/applications/search/controller/PhabricatorSearchSelectController.php b/src/applications/search/controller/PhabricatorSearchSelectController.php
index 03d3ca4c69..f663cd03d7 100644
--- a/src/applications/search/controller/PhabricatorSearchSelectController.php
+++ b/src/applications/search/controller/PhabricatorSearchSelectController.php
@@ -3,22 +3,17 @@
 final class PhabricatorSearchSelectController
   extends PhabricatorSearchBaseController {
 
-  private $type;
-
-  public function willProcessRequest(array $data) {
-    $this->type = $data['type'];
-  }
-
-  public function processRequest() {
-    $request = $this->getRequest();
+  public function handleRequest(AphrontRequest $request) {
     $user = $request->getUser();
+    $type = $request->getURIData('type');
+    $action = $request->getURIData('action');
 
     $query = new PhabricatorSavedQuery();
     $query_str = $request->getStr('query');
 
     $query->setEngineClassName('PhabricatorSearchApplicationSearchEngine');
     $query->setParameter('query', $query_str);
-    $query->setParameter('types', array($this->type));
+    $query->setParameter('types', array($type));
 
     $status_open = PhabricatorSearchRelationship::RELATIONSHIP_OPEN;
 
@@ -31,7 +26,7 @@ final class PhabricatorSearchSelectController
         $query->setParameter('authorPHIDs', array($user->getPHID()));
         // TODO - if / when we allow pholio mocks to be archived, etc
         // update this
-        if ($this->type != PholioMockPHIDType::TYPECONST) {
+        if ($type != PholioMockPHIDType::TYPECONST) {
           $query->setParameter('statuses', array($status_open));
         }
         break;
@@ -42,15 +37,25 @@ final class PhabricatorSearchSelectController
 
     $query->setParameter('excludePHIDs', array($request->getStr('exclude')));
 
+    $capabilities = array(PhabricatorPolicyCapability::CAN_VIEW);
+    switch ($action) {
+      case self::ACTION_MERGE:
+        $capabilities[] = PhabricatorPolicyCapability::CAN_EDIT;
+        break;
+      default:
+        break;
+    }
+
     $results = id(new PhabricatorSearchDocumentQuery())
       ->setViewer($user)
+      ->requireObjectCapabilities($capabilities)
       ->withSavedQuery($query)
       ->setOffset(0)
       ->setLimit(100)
       ->execute();
 
     $phids = array_fill_keys(mpull($results, 'getPHID'), true);
-    $phids += $this->queryObjectNames($query_str);
+    $phids += $this->queryObjectNames($query_str, $capabilities);
 
     $phids = array_keys($phids);
     $handles = $this->loadViewerHandles($phids);
@@ -64,12 +69,14 @@ final class PhabricatorSearchSelectController
     return id(new AphrontAjaxResponse())->setContent($data);
   }
 
-  private function queryObjectNames($query) {
-    $viewer = $this->getRequest()->getUser();
+  private function queryObjectNames($query, $capabilities) {
+    $request = $this->getRequest();
+    $viewer = $request->getUser();
 
     $objects = id(new PhabricatorObjectQuery())
       ->setViewer($viewer)
-      ->withTypes(array($this->type))
+      ->requireCapabilities($capabilities)
+      ->withTypes(array($request->getURIData('type')))
       ->withNames(array($query))
       ->execute();
 
diff --git a/src/applications/search/query/PhabricatorSearchDocumentQuery.php b/src/applications/search/query/PhabricatorSearchDocumentQuery.php
index b5591d8eca..903d40dd5a 100644
--- a/src/applications/search/query/PhabricatorSearchDocumentQuery.php
+++ b/src/applications/search/query/PhabricatorSearchDocumentQuery.php
@@ -4,17 +4,31 @@ final class PhabricatorSearchDocumentQuery
   extends PhabricatorCursorPagedPolicyAwareQuery {
 
   private $savedQuery;
+  private $objectCapabilities;
 
   public function withSavedQuery(PhabricatorSavedQuery $query) {
     $this->savedQuery = $query;
     return $this;
   }
 
+  public function requireObjectCapabilities(array $capabilities) {
+    $this->objectCapabilities = $capabilities;
+    return $this;
+  }
+
+  protected function getRequiredObjectCapabilities() {
+    if ($this->objectCapabilities) {
+      return $this->objectCapabilities;
+    }
+    return $this->getRequiredCapabilities();
+  }
+
   protected function loadPage() {
     $phids = $this->loadDocumentPHIDsWithoutPolicyChecks();
 
     $handles = id(new PhabricatorHandleQuery())
       ->setViewer($this->getViewer())
+      ->requireObjectCapabilities($this->getRequiredObjectCapabilities())
       ->withPHIDs($phids)
       ->execute();
 

From b0862a81760d60d8de61545d65a4ce9efab2b90e Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Mon, 18 May 2015 13:57:20 -0700
Subject: [PATCH 42/86] Filter pastes at the query level if we're unable to
 load their content

Summary:
Fixes T8230. I think I broke this in D12354 since I missed the fact that this could filter results, because it's constructed in a sort of weird way. Try to make the logic a little more clear, while retaining the relevant properties:

  - Pastes with unloadable content should be discarded;
  - the input order should be retained in the result set.

Test Plan: Faked content misses and saw things work instead of fatal.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8230

Differential Revision: https://secure.phabricator.com/D12909
---
 .../paste/query/PhabricatorPasteQuery.php     | 29 +++++++++++++++----
 1 file changed, 23 insertions(+), 6 deletions(-)

diff --git a/src/applications/paste/query/PhabricatorPasteQuery.php b/src/applications/paste/query/PhabricatorPasteQuery.php
index ae74978510..d5a5daf9e3 100644
--- a/src/applications/paste/query/PhabricatorPasteQuery.php
+++ b/src/applications/paste/query/PhabricatorPasteQuery.php
@@ -90,7 +90,7 @@ final class PhabricatorPasteQuery
     }
 
     if ($this->needContent) {
-      $this->loadContent($pastes);
+      $pastes = $this->loadContent($pastes);
     }
 
     return $pastes;
@@ -205,29 +205,46 @@ final class PhabricatorPasteQuery
     $caches = $cache->getKeys($keys);
 
     $need_raw = array();
-    foreach ($pastes as $key => $paste) {
+    $have_cache = array();
+    foreach ($pastes as $paste) {
       $key = $this->getContentCacheKey($paste);
       if (isset($caches[$key])) {
         $paste->attachContent(phutil_safe_html($caches[$key]));
+        $have_cache[$paste->getPHID()] = true;
       } else {
         $need_raw[$key] = $paste;
       }
     }
 
     if (!$need_raw) {
-      return;
+      return $pastes;
     }
 
     $write_data = array();
 
-    $need_raw = $this->loadRawContent($need_raw);
-    foreach ($need_raw as $key => $paste) {
+    $have_raw = $this->loadRawContent($need_raw);
+    $have_raw = mpull($have_raw, null, 'getPHID');
+    foreach ($pastes as $key => $paste) {
+      $paste_phid = $paste->getPHID();
+      if (isset($have_cache[$paste_phid])) {
+        continue;
+      }
+
+      if (empty($have_raw[$paste_phid])) {
+        unset($pastes[$key]);
+        continue;
+      }
+
       $content = $this->buildContent($paste);
       $paste->attachContent($content);
       $write_data[$this->getContentCacheKey($paste)] = (string)$content;
     }
 
-    $cache->setKeys($write_data);
+    if ($write_data) {
+      $cache->setKeys($write_data);
+    }
+
+    return $pastes;
   }
 
   private function buildContent(PhabricatorPaste $paste) {

From f3d382cec4d3cf1e9e5ca3ae681fbff17db8aaeb Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@joshuaspence.com>
Date: Tue, 19 May 2015 06:57:21 +1000
Subject: [PATCH 43/86] Fix some method signatures

Summary: Fix some method signatures so that arguments with default values are at the end of the argument list (see D12418).

Test Plan: Eyeballed the callsites.

Reviewers: epriestley, #blessed_reviewers, hach-que

Reviewed By: epriestley, #blessed_reviewers, hach-que

Subscribers: hach-que, Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D12782
---
 .../celerity/CelerityStaticResourceResponse.php        | 10 ++++++----
 .../blueprint/DrydockBlueprintImplementation.php       |  2 +-
 src/applications/people/storage/PhabricatorUserLog.php |  4 ++--
 .../phragment/storage/PhragmentFragment.php            |  6 +++---
 src/view/layout/AphrontSideNavFilterView.php           |  7 +------
 5 files changed, 13 insertions(+), 16 deletions(-)

diff --git a/src/applications/celerity/CelerityStaticResourceResponse.php b/src/applications/celerity/CelerityStaticResourceResponse.php
index 3f34b7634f..7864515e11 100644
--- a/src/applications/celerity/CelerityStaticResourceResponse.php
+++ b/src/applications/celerity/CelerityStaticResourceResponse.php
@@ -33,14 +33,16 @@ final class CelerityStaticResourceResponse {
   }
 
   /**
-   * Register a behavior for initialization. NOTE: if $config is empty,
-   * a behavior will execute only once even if it is initialized multiple times.
-   * If $config is nonempty, the behavior will be invoked once for each config.
+   * Register a behavior for initialization.
+   *
+   * NOTE: If `$config` is empty, a behavior will execute only once even if it
+   * is initialized multiple times. If `$config` is nonempty, the behavior will
+   * be invoked once for each configuration.
    */
   public function initBehavior(
     $behavior,
     array $config = array(),
-    $source_name) {
+    $source_name = null) {
 
     $this->requireResource('javelin-behavior-'.$behavior, $source_name);
 
diff --git a/src/applications/drydock/blueprint/DrydockBlueprintImplementation.php b/src/applications/drydock/blueprint/DrydockBlueprintImplementation.php
index 43891d0d07..223d974541 100644
--- a/src/applications/drydock/blueprint/DrydockBlueprintImplementation.php
+++ b/src/applications/drydock/blueprint/DrydockBlueprintImplementation.php
@@ -353,7 +353,7 @@ abstract class DrydockBlueprintImplementation {
   public static function writeLog(
     DrydockResource $resource = null,
     DrydockLease $lease = null,
-    $message) {
+    $message = null) {
 
     $log = id(new DrydockLog())
       ->setEpoch(time())
diff --git a/src/applications/people/storage/PhabricatorUserLog.php b/src/applications/people/storage/PhabricatorUserLog.php
index acdd7b1efe..1f14a27e4c 100644
--- a/src/applications/people/storage/PhabricatorUserLog.php
+++ b/src/applications/people/storage/PhabricatorUserLog.php
@@ -87,8 +87,8 @@ final class PhabricatorUserLog extends PhabricatorUserDAO
 
   public static function initializeNewLog(
     PhabricatorUser $actor = null,
-    $object_phid,
-    $action) {
+    $object_phid = null,
+    $action = null) {
 
     $log = new PhabricatorUserLog();
 
diff --git a/src/applications/phragment/storage/PhragmentFragment.php b/src/applications/phragment/storage/PhragmentFragment.php
index 574283d7a7..d58be033c0 100644
--- a/src/applications/phragment/storage/PhragmentFragment.php
+++ b/src/applications/phragment/storage/PhragmentFragment.php
@@ -78,9 +78,9 @@ final class PhragmentFragment extends PhragmentDAO
   public static function createFromFile(
     PhabricatorUser $viewer,
     PhabricatorFile $file = null,
-    $path,
-    $view_policy,
-    $edit_policy) {
+    $path = null,
+    $view_policy = null,
+    $edit_policy = null) {
 
     $fragment = id(new PhragmentFragment());
     $fragment->setPath($path);
diff --git a/src/view/layout/AphrontSideNavFilterView.php b/src/view/layout/AphrontSideNavFilterView.php
index 4f4c0803b8..fe8025026b 100644
--- a/src/view/layout/AphrontSideNavFilterView.php
+++ b/src/view/layout/AphrontSideNavFilterView.php
@@ -125,12 +125,7 @@ final class AphrontSideNavFilterView extends AphrontView {
       $key, $name, $uri, PHUIListItemView::TYPE_BUTTON);
   }
 
-  private function addThing(
-    $key,
-    $name,
-    $uri = null,
-    $type) {
-
+  private function addThing($key, $name, $uri, $type) {
     $item = id(new PHUIListItemView())
       ->setName($name)
       ->setType($type);

From c006ef628948abbf2fedd9e2d78e737a479050f6 Mon Sep 17 00:00:00 2001
From: lkassianik <lyubakassianik@gmail.com>
Date: Mon, 18 May 2015 13:59:23 -0700
Subject: [PATCH 44/86] Tweaking css to better accomodate month view week
 numbers on mobile.

Summary: Fixes T8249, Tweaking css to better accomodate month view week numbers on mobile.

Test Plan: Open month view on mobile and observe that week and day numbers are aligned.

Reviewers: chad, epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T8249

Differential Revision: https://secure.phabricator.com/D12910
---
 resources/celerity/map.php                             | 4 ++--
 webroot/rsrc/css/phui/calendar/phui-calendar-month.css | 9 +++++++--
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 54000b66cf..3f58140cad 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -122,7 +122,7 @@ return array(
     'rsrc/css/layout/phabricator-source-code-view.css' => '2ceee894',
     'rsrc/css/phui/calendar/phui-calendar-day.css' => '3b4a65d8',
     'rsrc/css/phui/calendar/phui-calendar-list.css' => '3e713fc7',
-    'rsrc/css/phui/calendar/phui-calendar-month.css' => '7cf00f61',
+    'rsrc/css/phui/calendar/phui-calendar-month.css' => '017a953b',
     'rsrc/css/phui/calendar/phui-calendar.css' => '8345be98',
     'rsrc/css/phui/phui-action-header-view.css' => '89c497e7',
     'rsrc/css/phui/phui-action-list.css' => '4f4d09f2',
@@ -763,7 +763,7 @@ return array(
     'phui-calendar-css' => '8345be98',
     'phui-calendar-day-css' => '3b4a65d8',
     'phui-calendar-list-css' => '3e713fc7',
-    'phui-calendar-month-css' => '7cf00f61',
+    'phui-calendar-month-css' => '017a953b',
     'phui-crumbs-view-css' => '594d719e',
     'phui-document-view-css' => '94d5dcd8',
     'phui-feed-story-css' => 'c9f3a0b5',
diff --git a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
index bb02c4c54d..43c9af18cf 100644
--- a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
+++ b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
@@ -98,7 +98,7 @@ table.phui-calendar-view a.phui-calendar-week-number {
   color: {$lightgreyborder};
   padding: 4px;
   display: inline-block;
-  min-width: 16px;
+  width: 16px;
   text-align: center;
   float: left;
 }
@@ -107,10 +107,15 @@ table.phui-calendar-view a.phui-calendar-date-number {
   color: {$lightgreytext};
   padding: 4px;
   display: inline-block;
-  min-width: 16px;
+  width: 16px;
   text-align: center;
 }
 
+.device table.phui-calendar-view a.phui-calendar-week-number,
+.device table.phui-calendar-view a.phui-calendar-date-number {
+  width: 12px;
+}
+
 table.phui-calendar-view td.phui-calendar-date-number-container {
   font-weight: normal;
   color: {$lightgreytext};

From da4617aabd3fde757335a5149eabcba8239724ae Mon Sep 17 00:00:00 2001
From: Bob Trahan <btrahan@phacility.com>
Date: Mon, 18 May 2015 14:10:47 -0700
Subject: [PATCH 45/86] Conpherence - fix widget updates from main view

Summary: Fixes T8217. Broken circa D12760. Some browsers rendered nothing while others rendered a ",".

Test Plan: added folks to conpherences and saw people widget update correctly. added files to conpherence and saw file widget update correctly. Tested on Chrome and Firefox.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8217

Differential Revision: https://secure.phabricator.com/D12912
---
 .../conpherence/controller/ConpherenceUpdateController.php    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/applications/conpherence/controller/ConpherenceUpdateController.php b/src/applications/conpherence/controller/ConpherenceUpdateController.php
index eea1d1dc8a..d37fefdf14 100644
--- a/src/applications/conpherence/controller/ConpherenceUpdateController.php
+++ b/src/applications/conpherence/controller/ConpherenceUpdateController.php
@@ -528,14 +528,14 @@ final class ConpherenceUpdateController
             ->setUser($this->getRequest()->getUser())
             ->setConpherence($conpherence)
             ->setUpdateURI($widget_uri);
-          $file_widget = $file_widget->render();
+          $file_widget = hsprintf('%s', $file_widget->render());
           break;
         case ConpherenceUpdateActions::ADD_PERSON:
           $people_widget = id(new ConpherencePeopleWidgetView())
             ->setUser($user)
             ->setConpherence($conpherence)
             ->setUpdateURI($widget_uri);
-          $people_widget = $people_widget->render();
+          $people_widget = hsprintf('%s', $people_widget->render());
           break;
         case ConpherenceUpdateActions::REMOVE_PERSON:
         case ConpherenceUpdateActions::NOTIFICATIONS:

From 189c55d1d332eeb805b4536f206bffe76111d6d6 Mon Sep 17 00:00:00 2001
From: Bob Trahan <btrahan@phacility.com>
Date: Mon, 18 May 2015 15:39:34 -0700
Subject: [PATCH 46/86] People - fix hovercards for people

Summary: Fixes T8242. D12833 removed the title as well as the blurb from people hovercards. When re-adding the title don't bother throwing things through pht since that seems like not something you translate exactly and also lose the flavor text which most users end up having since title is rarely set (at least on this install).

Test Plan: viewed hovercards and saw title and blurb again as appropos relative to the data being set

Reviewers: chad, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8242

Differential Revision: https://secure.phabricator.com/D12915
---
 .../PhabricatorPeopleHovercardEventListener.php   | 15 ++++++++++++++-
 .../people/storage/PhabricatorUser.php            |  4 ++++
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/src/applications/people/event/PhabricatorPeopleHovercardEventListener.php b/src/applications/people/event/PhabricatorPeopleHovercardEventListener.php
index f2b957f363..6ecf0a9bd9 100644
--- a/src/applications/people/event/PhabricatorPeopleHovercardEventListener.php
+++ b/src/applications/people/event/PhabricatorPeopleHovercardEventListener.php
@@ -31,10 +31,16 @@ final class PhabricatorPeopleHovercardEventListener
       ->setViewer($viewer)
       ->withIDs(array($user->getID()))
       ->needAvailability(true)
+      ->needProfile(true)
       ->executeOne();
 
     $hovercard->setTitle($user->getUsername());
-    $hovercard->setDetail($user->getRealName());
+    $profile = $user->getUserProfile();
+    $detail = $user->getRealName();
+    if ($profile->getTitle()) {
+      $detail .= ' - '.$profile->getTitle().'.';
+    }
+    $hovercard->setDetail($detail);
 
     if ($user->getIsDisabled()) {
       $hovercard->addField(pht('Account'), pht('Disabled'));
@@ -52,6 +58,13 @@ final class PhabricatorPeopleHovercardEventListener
       pht('User Since'),
       phabricator_date($user->getDateCreated(), $viewer));
 
+    if ($profile->getBlurb()) {
+      $hovercard->addField(pht('Blurb'),
+        id(new PhutilUTF8StringTruncator())
+        ->setMaximumGlyphs(120)
+        ->truncateString($profile->getBlurb()));
+    }
+
     $event->setValue('hovercard', $hovercard);
   }
 
diff --git a/src/applications/people/storage/PhabricatorUser.php b/src/applications/people/storage/PhabricatorUser.php
index 0c7ef73b0e..e66a34d9a1 100644
--- a/src/applications/people/storage/PhabricatorUser.php
+++ b/src/applications/people/storage/PhabricatorUser.php
@@ -396,6 +396,10 @@ final class PhabricatorUser
     return substr(PhabricatorHash::digest($vec), 0, $len);
   }
 
+  public function getUserProfile() {
+    return $this->assertAttached($this->profile);
+  }
+
   public function attachUserProfile(PhabricatorUserProfile $profile) {
     $this->profile = $profile;
     return $this;

From ec759ef46f17d6f782808e3d32061e4c5368c45d Mon Sep 17 00:00:00 2001
From: lkassianik <lyubakassianik@gmail.com>
Date: Mon, 18 May 2015 16:04:35 -0700
Subject: [PATCH 47/86] Mobile day view should display event list, not day
 table

Summary: Closes T8178, Mobile day view should display event list, not day table

Test Plan: Open day view on a device, observe that day table is hidden.

Reviewers: chad, #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8178

Differential Revision: https://secure.phabricator.com/D12916
---
 resources/celerity/map.php                           | 4 ++--
 src/view/phui/calendar/PHUICalendarDayView.php       | 2 +-
 webroot/rsrc/css/phui/calendar/phui-calendar-day.css | 8 ++++++++
 3 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 3f58140cad..a7670beff0 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -120,7 +120,7 @@ return array(
     'rsrc/css/layout/phabricator-hovercard-view.css' => 'dd9121a9',
     'rsrc/css/layout/phabricator-side-menu-view.css' => 'c1db9e9c',
     'rsrc/css/layout/phabricator-source-code-view.css' => '2ceee894',
-    'rsrc/css/phui/calendar/phui-calendar-day.css' => '3b4a65d8',
+    'rsrc/css/phui/calendar/phui-calendar-day.css' => 'c0cf782a',
     'rsrc/css/phui/calendar/phui-calendar-list.css' => '3e713fc7',
     'rsrc/css/phui/calendar/phui-calendar-month.css' => '017a953b',
     'rsrc/css/phui/calendar/phui-calendar.css' => '8345be98',
@@ -761,7 +761,7 @@ return array(
     'phui-box-css' => '7b3a2eed',
     'phui-button-css' => 'de610129',
     'phui-calendar-css' => '8345be98',
-    'phui-calendar-day-css' => '3b4a65d8',
+    'phui-calendar-day-css' => 'c0cf782a',
     'phui-calendar-list-css' => '3e713fc7',
     'phui-calendar-month-css' => '017a953b',
     'phui-crumbs-view-css' => '594d719e',
diff --git a/src/view/phui/calendar/PHUICalendarDayView.php b/src/view/phui/calendar/PHUICalendarDayView.php
index 5afff57d3b..45a4f6d1bc 100644
--- a/src/view/phui/calendar/PHUICalendarDayView.php
+++ b/src/view/phui/calendar/PHUICalendarDayView.php
@@ -185,7 +185,7 @@ final class PHUICalendarDayView extends AphrontView {
 
     $layout = id(new AphrontMultiColumnView())
       ->addColumn($sidebar, 'third')
-      ->addColumn($table_box, 'thirds')
+      ->addColumn($table_box, 'thirds phui-day-view-column')
       ->setFluidLayout(true)
       ->setGutter(AphrontMultiColumnView::GUTTER_MEDIUM);
 
diff --git a/webroot/rsrc/css/phui/calendar/phui-calendar-day.css b/webroot/rsrc/css/phui/calendar/phui-calendar-day.css
index 4f2c8a9e3d..715bd6fd3b 100644
--- a/webroot/rsrc/css/phui/calendar/phui-calendar-day.css
+++ b/webroot/rsrc/css/phui/calendar/phui-calendar-day.css
@@ -2,6 +2,14 @@
  * @provides phui-calendar-day-css
  */
 
+.device .phui-day-view-column {
+  display: none;
+}
+
+.device .phui-calendar-list-container {
+  width: 100%;
+}
+
 .phui-calendar-day-view {
   overflow: scroll;
   width: 100%;

From 27930e8b25e1181c48cab9148974c5c9ece3555d Mon Sep 17 00:00:00 2001
From: lkassianik <lyubakassianik@gmail.com>
Date: Tue, 19 May 2015 09:57:14 -0700
Subject: [PATCH 48/86] Calendar list event items should be entirely clickable

Summary: Ref T8248, Calendar list event items should be entirely clickable

Test Plan: Open month view, verify that adjusting screen correctly adjust widths of event links, and that entire event row links are clickable.

Reviewers: chad, epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T8248

Differential Revision: https://secure.phabricator.com/D12925
---
 resources/celerity/map.php                    | 12 ++--
 .../phui/calendar/PHUICalendarListView.php    | 18 ++++--
 .../css/phui/calendar/phui-calendar-list.css  | 14 +++--
 .../css/phui/calendar/phui-calendar-month.css | 59 ++++++-------------
 .../rsrc/css/phui/calendar/phui-calendar.css  |  1 -
 5 files changed, 46 insertions(+), 58 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index a7670beff0..00f7142bd8 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -121,9 +121,9 @@ return array(
     'rsrc/css/layout/phabricator-side-menu-view.css' => 'c1db9e9c',
     'rsrc/css/layout/phabricator-source-code-view.css' => '2ceee894',
     'rsrc/css/phui/calendar/phui-calendar-day.css' => 'c0cf782a',
-    'rsrc/css/phui/calendar/phui-calendar-list.css' => '3e713fc7',
-    'rsrc/css/phui/calendar/phui-calendar-month.css' => '017a953b',
-    'rsrc/css/phui/calendar/phui-calendar.css' => '8345be98',
+    'rsrc/css/phui/calendar/phui-calendar-list.css' => '857a0d83',
+    'rsrc/css/phui/calendar/phui-calendar-month.css' => '32e3bee4',
+    'rsrc/css/phui/calendar/phui-calendar.css' => 'ccabe893',
     'rsrc/css/phui/phui-action-header-view.css' => '89c497e7',
     'rsrc/css/phui/phui-action-list.css' => '4f4d09f2',
     'rsrc/css/phui/phui-action-panel.css' => '3ee9afd5',
@@ -760,10 +760,10 @@ return array(
     'phui-action-panel-css' => '3ee9afd5',
     'phui-box-css' => '7b3a2eed',
     'phui-button-css' => 'de610129',
-    'phui-calendar-css' => '8345be98',
+    'phui-calendar-css' => 'ccabe893',
     'phui-calendar-day-css' => 'c0cf782a',
-    'phui-calendar-list-css' => '3e713fc7',
-    'phui-calendar-month-css' => '017a953b',
+    'phui-calendar-list-css' => '857a0d83',
+    'phui-calendar-month-css' => '32e3bee4',
     'phui-crumbs-view-css' => '594d719e',
     'phui-document-view-css' => '94d5dcd8',
     'phui-feed-story-css' => 'c9f3a0b5',
diff --git a/src/view/phui/calendar/PHUICalendarListView.php b/src/view/phui/calendar/PHUICalendarListView.php
index 3356d5d0fb..dd4bf34848 100644
--- a/src/view/phui/calendar/PHUICalendarListView.php
+++ b/src/view/phui/calendar/PHUICalendarListView.php
@@ -72,16 +72,23 @@ final class PHUICalendarListView extends AphrontTagView {
         $class = $class.' all-day';
       }
 
-      $singletons[] = phutil_tag(
-        'li',
+      $content = phutil_tag(
+        'a',
         array(
-          'class' => $class,
-          ),
+          'href' => '/E'.$event->getEventID(),
+        ),
         array(
           $dot,
           $time,
           $title,
         ));
+
+      $singletons[] = phutil_tag(
+        'li',
+        array(
+          'class' => $class,
+        ),
+        $content);
     }
 
     if (empty($singletons)) {
@@ -147,11 +154,10 @@ final class PHUICalendarListView extends AphrontTagView {
     $class = 'phui-calendar-item';
 
     $anchor = javelin_tag(
-      'a',
+      'span',
       array(
         'sigil' => 'has-tooltip',
         'class' => $class,
-        'href' => '/E'.$event->getEventID(),
         'meta'  => array(
           'tip'  => $tip,
           'size' => 200,
diff --git a/webroot/rsrc/css/phui/calendar/phui-calendar-list.css b/webroot/rsrc/css/phui/calendar/phui-calendar-list.css
index 80d34d2f5a..0155f730a4 100644
--- a/webroot/rsrc/css/phui/calendar/phui-calendar-list.css
+++ b/webroot/rsrc/css/phui/calendar/phui-calendar-list.css
@@ -43,11 +43,15 @@
 }
 
 .phui-calendar-list-title {
-  width: 200px;
-  display: inline-block;
-  overflow: hidden;
-  text-overflow: ellipsis;
-  white-space: nowrap;
+ width: 200px;
+ display: inline-block;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ white-space: nowrap;
+}
+
+.phui-calendar-viewer-invited .phui-calendar-list-title {
+  font-weight: bold;
 }
 
 .phui-calendar-list-item .phui-calendar-list-time {
diff --git a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
index 43c9af18cf..6c0e20a2f6 100644
--- a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
+++ b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
@@ -151,6 +151,7 @@ table.phui-calendar-view td.phui-calendar-date-number-container {
 
 .phui-calendar-view .phui-calendar-list {
   padding: 1px;
+  width: auto;
 }
 
 .phui-calendar-list-item.all-day span {
@@ -160,8 +161,6 @@ table.phui-calendar-view td.phui-calendar-date-number-container {
 
 .phui-calendar-view .phui-calendar-list li.phui-calendar-list-item.all-day {
   height: 20px;
-  margin: 0;
-  padding: 4px 4px 0px 4px;
   background-color: {$darkgreybackground};
   display: block;
   float: none;
@@ -173,21 +172,24 @@ li.phui-calendar-viewer-invited.all-day {
   background-color: {$lightgreen};
 }
 
-li.phui-calendar-list-item.all-day:first-child {
-  margin-top: 0;
-}
-
 .phui-calendar-view .phui-calendar-list li {
-  margin: 0 8px;
+  padding: 0px 4px;
 }
 
-.phui-calendar-view .phui-calendar-list li:first-child {
-  margin-top: 8px;
+.phui-calendar-view .phui-calendar-list li a {
+  display: block;
+  overflow: hidden;
+  position: relative;
+}
+
+.phui-calendar-view li.phui-calendar-list-item {
+  white-space: nowrap;
+  width: auto;
 }
 
 .phui-calendar-view .phui-calendar-list-dot {
   position: relative;
-  display: inline-block;
+  display: block;
   float: left;
   width: 3px;
   height: 3px;
@@ -198,37 +200,18 @@ li.phui-calendar-list-item.all-day:first-child {
   display: none;
 }
 
-.phui-calendar-view li.phui-calendar-list-item {
-  padding: 0;
-}
-
 .phui-calendar-view li.phui-calendar-list-item .phui-calendar-list-title {
-  position: relative;
-  /*float: right;*/
-  display: inline-block;
-  width: 120px;
-  padding: 0;
-  line-height: 18px;
-  vertical-align: center;
-}
-
-li.phui-calendar-list-item .phui-calendar-list-title a {
-  padding: 0;
-  vertical-align: top;
-  line-height: 16px;
-  overflow: hidden;
+  width: auto;
+  position: absolute;
+  right: 0;
+  left: 60px;
   text-overflow: ellipsis;
+  overflow: hidden;
   white-space: nowrap;
 }
 
-li.phui-calendar-list-item.all-day .phui-calendar-list-title a{
-  color: {$greytext};
-  margin: 0;
-  padding: 0;
-}
-
-li.phui-calendar-viewer-invited.all-day .phui-calendar-list-title a{
-  color: {$green};
+li.all-day {
+  line-height: 18px;
 }
 
 .phui-calendar-view li.phui-calendar-list-item .phui-calendar-list-time {
@@ -241,7 +224,3 @@ li.phui-calendar-viewer-invited.all-day .phui-calendar-list-title a{
   color: {$lightgreytext};
   text-align: left;
 }
-
-li.phui-calendar-list-item.all-day .phui-calendar-list-time{
-  margin: 0 0 0 4px;
-}
diff --git a/webroot/rsrc/css/phui/calendar/phui-calendar.css b/webroot/rsrc/css/phui/calendar/phui-calendar.css
index e3f67c2162..d2a094c65a 100644
--- a/webroot/rsrc/css/phui/calendar/phui-calendar.css
+++ b/webroot/rsrc/css/phui/calendar/phui-calendar.css
@@ -8,7 +8,6 @@
 
 .phui-calendar-viewer-invited a {
   color: {$green};
-  font-weight: bold;
 }
 
 .phui-calendar-red a {

From 1f54b95324ebb078ca0fc340745adfe1a22886dc Mon Sep 17 00:00:00 2001
From: CodeMouse92 <jcmcdonald@mousepawgames.com>
Date: Tue, 19 May 2015 10:04:51 -0700
Subject: [PATCH 49/86] Fixed typo on Releeph product query dropdown.

Summary:
Changed "Active Prodcuts" to "Active Products" on Releeph Product Query dropdown.

(Incidentally, this is my first diff on Phabricator proper, so I hope I got it right. I'm used to SVN, not Git.)

Test Plan: Make sure the change is there and didn't bork anything else.

Reviewers: chad, #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D12904
---
 src/applications/releeph/query/ReleephProductSearchEngine.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/applications/releeph/query/ReleephProductSearchEngine.php b/src/applications/releeph/query/ReleephProductSearchEngine.php
index 51f1bcb560..37aecea858 100644
--- a/src/applications/releeph/query/ReleephProductSearchEngine.php
+++ b/src/applications/releeph/query/ReleephProductSearchEngine.php
@@ -74,7 +74,7 @@ final class ReleephProductSearchEngine
   private function getActiveOptions() {
     return array(
       'all'       => pht('Active and Inactive Products'),
-      'active'    => pht('Active Prodcuts'),
+      'active'    => pht('Active Products'),
       'inactive'  => pht('Inactive Products'),
     );
   }

From 8ff7222d0e018ed66461b32764e9088787bb5585 Mon Sep 17 00:00:00 2001
From: Bob Trahan <btrahan@phacility.com>
Date: Tue, 19 May 2015 10:46:28 -0700
Subject: [PATCH 50/86] Phame - add edge transaction implementations.

Summary: Fixes T8252. See T6403 for longer term fix.

Test Plan: made a post with a task mention in it and it worked

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8252

Differential Revision: https://secure.phabricator.com/D12926
---
 src/applications/phame/editor/PhamePostEditor.php | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/applications/phame/editor/PhamePostEditor.php b/src/applications/phame/editor/PhamePostEditor.php
index ef6cd21307..c08ad2b155 100644
--- a/src/applications/phame/editor/PhamePostEditor.php
+++ b/src/applications/phame/editor/PhamePostEditor.php
@@ -64,6 +64,8 @@ final class PhamePostEditor
         return $object->setBody($xaction->getNewValue());
       case PhamePostTransaction::TYPE_COMMENTS_WIDGET:
         return $object->setCommentsWidget($xaction->getNewValue());
+      case PhabricatorTransactions::TYPE_EDGE:
+        return;
     }
 
     return parent::applyCustomInternalTransaction($object, $xaction);
@@ -78,6 +80,7 @@ final class PhamePostEditor
       case PhamePostTransaction::TYPE_PHAME_TITLE:
       case PhamePostTransaction::TYPE_BODY:
       case PhamePostTransaction::TYPE_COMMENTS_WIDGET:
+      case PhabricatorTransactions::TYPE_EDGE:
         return;
     }
 

From 1e128a24b84c78d9522ed84327a639ea8279efc9 Mon Sep 17 00:00:00 2001
From: Bob Trahan <btrahan@phacility.com>
Date: Tue, 19 May 2015 10:48:48 -0700
Subject: [PATCH 51/86] Conpherence - override some device specific styles so
 menu dropdown always present

Summary:
Fixes T7684. I am not sure if this is simple or not in CSS terms but I just blasted a bunch of css classes to make sure they have the proper "device-desktop" values for the conpherence durable column.

One small visual oddity is the main menu dropdowns (for conpherence and the actual page) should have a hover state css, but we add device-tablet too early relative to the actual page width. This is no big deal probably.

Test Plan: made the screen table sized. used the dropdown menu with great success!

Reviewers: chad, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7684

Differential Revision: https://secure.phabricator.com/D12914
---
 resources/celerity/map.php                    | 10 ++--
 .../conpherence/durable-column.css            | 58 +++++++++++++++++++
 2 files changed, 63 insertions(+), 5 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 00f7142bd8..90b615594b 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => '9990f46d',
+    'core.pkg.css' => '65288546',
     'core.pkg.js' => 'a2f2598e',
     'darkconsole.pkg.js' => 'e7393ebb',
     'differential.pkg.css' => 'bb338e4b',
@@ -45,7 +45,7 @@ return array(
     'rsrc/css/application/config/config-welcome.css' => '6abd79be',
     'rsrc/css/application/config/setup-issue.css' => '22270af2',
     'rsrc/css/application/config/unhandled-exception.css' => '37d4f9a2',
-    'rsrc/css/application/conpherence/durable-column.css' => '8c43d6ac',
+    'rsrc/css/application/conpherence/durable-column.css' => '4331cbe9',
     'rsrc/css/application/conpherence/menu.css' => 'f389e048',
     'rsrc/css/application/conpherence/message-pane.css' => '5bb4b76d',
     'rsrc/css/application/conpherence/notification.css' => '919974b6',
@@ -122,7 +122,7 @@ return array(
     'rsrc/css/layout/phabricator-source-code-view.css' => '2ceee894',
     'rsrc/css/phui/calendar/phui-calendar-day.css' => 'c0cf782a',
     'rsrc/css/phui/calendar/phui-calendar-list.css' => '857a0d83',
-    'rsrc/css/phui/calendar/phui-calendar-month.css' => '32e3bee4',
+    'rsrc/css/phui/calendar/phui-calendar-month.css' => '1d0e1e9b',
     'rsrc/css/phui/calendar/phui-calendar.css' => 'ccabe893',
     'rsrc/css/phui/phui-action-header-view.css' => '89c497e7',
     'rsrc/css/phui/phui-action-list.css' => '4f4d09f2',
@@ -496,7 +496,7 @@ return array(
     'conduit-api-css' => '7bc725c4',
     'config-options-css' => '7fedf08b',
     'config-welcome-css' => '6abd79be',
-    'conpherence-durable-column-view' => '8c43d6ac',
+    'conpherence-durable-column-view' => '4331cbe9',
     'conpherence-menu-css' => 'f389e048',
     'conpherence-message-pane-css' => '5bb4b76d',
     'conpherence-notification-css' => '919974b6',
@@ -763,7 +763,7 @@ return array(
     'phui-calendar-css' => 'ccabe893',
     'phui-calendar-day-css' => 'c0cf782a',
     'phui-calendar-list-css' => '857a0d83',
-    'phui-calendar-month-css' => '32e3bee4',
+    'phui-calendar-month-css' => '1d0e1e9b',
     'phui-crumbs-view-css' => '594d719e',
     'phui-document-view-css' => '94d5dcd8',
     'phui-feed-story-css' => 'c9f3a0b5',
diff --git a/webroot/rsrc/css/application/conpherence/durable-column.css b/webroot/rsrc/css/application/conpherence/durable-column.css
index 1dbb829565..e0cdf7b5e9 100644
--- a/webroot/rsrc/css/application/conpherence/durable-column.css
+++ b/webroot/rsrc/css/application/conpherence/durable-column.css
@@ -75,7 +75,65 @@
 }
 
 .conpherence-durable-column-header .phabricator-application-menu {
+  display: block;
+  float: right;
   padding-right: 4px;
+  width: 36px;
+}
+.conpherence-durable-column-header
+.phabricator-application-menu .phui-list-item-view.core-menu-item {
+  display: block;
+}
+.conpherence-durable-column-header
+.phabricator-application-menu .phui-list-item-name {
+  display: none;
+}
+.conpherence-durable-column-header
+.phabricator-application-menu .phui-list-item-view {
+  float: left;
+  position: relative;
+  width: 36px;
+  height: 36px;
+  margin-top: 4px;
+}
+.conpherence-durable-column-header
+.phabricator-application-menu .phui-list-item-href {
+  background: transparent;
+  border: none;
+  padding: 0;
+}
+.conpherence-durable-column-header
+.phabricator-dark-menu .phui-list-item-type-link {
+  background: transparent;
+}
+.device-desktop
+.conpherence-durable-column-header
+.phabricator-application-menu
+.core-menu-item.phui-list-item-view:hover
+.phui-list-item-icon.phui-font-fa {
+  color: #fff;
+}
+.conpherence-durable-column-header
+.phabricator-application-menu
+.phui-list-item-view.core-menu-item {
+  display: block;
+}
+.device-desktop
+.conpherence-durable-column-header
+.phabricator-application-menu
+.core-menu-item.phui-list-item-view:hover {
+  background-color: rgba(0,0,0,.33);
+  border-radius: 3px;
+}
+.conpherence-durable-column-header
+.phabricator-application-menu .phui-list-item-icon.phui-font-fa {
+  font-size: 20px;
+  height: 20px;
+  width: 20px;
+  color: rgba(255,255,255,.8);
+  margin: 8px;
+  text-align: center;
+  vertical-align: middle;
 }
 
 .conpherence-durable-column-header-text {

From e47b4f5b67e3f7f2fa92fcf80bb499e5460423e6 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Tue, 19 May 2015 11:08:07 -0700
Subject: [PATCH 52/86] Fix "size=full" issue for images in Firefox

Summary: Fixes T8221.

Test Plan: {F410522}

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8221

Differential Revision: https://secure.phabricator.com/D12927
---
 resources/celerity/map.php         | 10 +++++-----
 webroot/rsrc/css/core/remarkup.css |  1 +
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 90b615594b..c683052bae 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => '65288546',
+    'core.pkg.css' => '79e995d7',
     'core.pkg.js' => 'a2f2598e',
     'darkconsole.pkg.js' => 'e7393ebb',
     'differential.pkg.css' => 'bb338e4b',
@@ -45,7 +45,7 @@ return array(
     'rsrc/css/application/config/config-welcome.css' => '6abd79be',
     'rsrc/css/application/config/setup-issue.css' => '22270af2',
     'rsrc/css/application/config/unhandled-exception.css' => '37d4f9a2',
-    'rsrc/css/application/conpherence/durable-column.css' => '4331cbe9',
+    'rsrc/css/application/conpherence/durable-column.css' => '8c43d6ac',
     'rsrc/css/application/conpherence/menu.css' => 'f389e048',
     'rsrc/css/application/conpherence/message-pane.css' => '5bb4b76d',
     'rsrc/css/application/conpherence/notification.css' => '919974b6',
@@ -109,7 +109,7 @@ return array(
     'rsrc/css/application/tokens/tokens.css' => '3d0f239e',
     'rsrc/css/application/uiexample/example.css' => '528b19de',
     'rsrc/css/core/core.css' => 'aaea7a7a',
-    'rsrc/css/core/remarkup.css' => '0037bdbf',
+    'rsrc/css/core/remarkup.css' => '07b7dc54',
     'rsrc/css/core/syntax.css' => '6b7b24d9',
     'rsrc/css/core/z-index.css' => '8414a09b',
     'rsrc/css/diviner/diviner-shared.css' => '38813222',
@@ -496,7 +496,7 @@ return array(
     'conduit-api-css' => '7bc725c4',
     'config-options-css' => '7fedf08b',
     'config-welcome-css' => '6abd79be',
-    'conpherence-durable-column-view' => '4331cbe9',
+    'conpherence-durable-column-view' => '8c43d6ac',
     'conpherence-menu-css' => 'f389e048',
     'conpherence-message-pane-css' => '5bb4b76d',
     'conpherence-notification-css' => '919974b6',
@@ -725,7 +725,7 @@ return array(
     'phabricator-phtize' => 'd254d646',
     'phabricator-prefab' => '6920d200',
     'phabricator-profile-css' => '1a20dcbf',
-    'phabricator-remarkup-css' => '0037bdbf',
+    'phabricator-remarkup-css' => '07b7dc54',
     'phabricator-search-results-css' => '15c71110',
     'phabricator-shaped-request' => '7cbe244b',
     'phabricator-side-menu-view-css' => 'c1db9e9c',
diff --git a/webroot/rsrc/css/core/remarkup.css b/webroot/rsrc/css/core/remarkup.css
index 63e4224ba3..faf7bda893 100644
--- a/webroot/rsrc/css/core/remarkup.css
+++ b/webroot/rsrc/css/core/remarkup.css
@@ -317,6 +317,7 @@
 
 .phabricator-remarkup-embed-image-full {
   display: inline-block;
+  max-width: 100%;
 }
 
 .phabricator-remarkup-embed-image-full img {

From 7bc008d0e2cc6ce74f3d231dac14e79c00c3f215 Mon Sep 17 00:00:00 2001
From: lkassianik <lyubakassianik@gmail.com>
Date: Tue, 19 May 2015 11:13:20 -0700
Subject: [PATCH 53/86] Skeleton of calendar icon infrastructure

Summary: Ref T7936, Skeleton of calendar icon infrastructure

Test Plan: Navigate to install/calendar/icon/, observe temporary calendar icons

Reviewers: epriestley, #blessed_reviewers, chad

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T7936

Differential Revision: https://secure.phabricator.com/D12928
---
 resources/celerity/map.php                    |   2 +
 src/__phutil_library_map__.php                |   4 +
 .../PhabricatorCalendarApplication.php        |   4 +
 ...ricatorCalendarEventEditIconController.php | 102 ++++++++++++++++++
 .../calendar/icon/PhabricatorCalendarIcon.php |  49 +++++++++
 .../application/calendar/calendar-icon.css    |  28 +++++
 6 files changed, 189 insertions(+)
 create mode 100644 src/applications/calendar/controller/PhabricatorCalendarEventEditIconController.php
 create mode 100644 src/applications/calendar/icon/PhabricatorCalendarIcon.php
 create mode 100644 webroot/rsrc/css/application/calendar/calendar-icon.css

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index c683052bae..862bf22145 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -38,6 +38,7 @@ return array(
     'rsrc/css/application/base/notification-menu.css' => '3c9d8aa1',
     'rsrc/css/application/base/phabricator-application-launch-view.css' => '16ca323f',
     'rsrc/css/application/base/standard-page-view.css' => '61e68a55',
+    'rsrc/css/application/calendar/calendar-icon.css' => '98ce946d',
     'rsrc/css/application/chatlog/chatlog.css' => '852140ff',
     'rsrc/css/application/conduit/conduit-api.css' => '7bc725c4',
     'rsrc/css/application/config/config-options.css' => '7fedf08b',
@@ -492,6 +493,7 @@ return array(
     'aphront-two-column-view-css' => '16ab3ad2',
     'aphront-typeahead-control-css' => '0e403212',
     'auth-css' => '44975d4b',
+    'calendar-icon-css' => '98ce946d',
     'changeset-view-manager' => '58562350',
     'conduit-api-css' => '7bc725c4',
     'config-options-css' => '7fedf08b',
diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index 96d2502491..0c4b286fe7 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -1499,6 +1499,7 @@ phutil_register_library_map(array(
     'PhabricatorCalendarEventCancelController' => 'applications/calendar/controller/PhabricatorCalendarEventCancelController.php',
     'PhabricatorCalendarEventCommentController' => 'applications/calendar/controller/PhabricatorCalendarEventCommentController.php',
     'PhabricatorCalendarEventEditController' => 'applications/calendar/controller/PhabricatorCalendarEventEditController.php',
+    'PhabricatorCalendarEventEditIconController' => 'applications/calendar/controller/PhabricatorCalendarEventEditIconController.php',
     'PhabricatorCalendarEventEditor' => 'applications/calendar/editor/PhabricatorCalendarEventEditor.php',
     'PhabricatorCalendarEventEmailCommand' => 'applications/calendar/command/PhabricatorCalendarEventEmailCommand.php',
     'PhabricatorCalendarEventInvitee' => 'applications/calendar/storage/PhabricatorCalendarEventInvitee.php',
@@ -1517,6 +1518,7 @@ phutil_register_library_map(array(
     'PhabricatorCalendarEventViewController' => 'applications/calendar/controller/PhabricatorCalendarEventViewController.php',
     'PhabricatorCalendarHoliday' => 'applications/calendar/storage/PhabricatorCalendarHoliday.php',
     'PhabricatorCalendarHolidayTestCase' => 'applications/calendar/storage/__tests__/PhabricatorCalendarHolidayTestCase.php',
+    'PhabricatorCalendarIcon' => 'applications/calendar/icon/PhabricatorCalendarIcon.php',
     'PhabricatorCalendarRemarkupRule' => 'applications/calendar/remarkup/PhabricatorCalendarRemarkupRule.php',
     'PhabricatorCalendarReplyHandler' => 'applications/calendar/mail/PhabricatorCalendarReplyHandler.php',
     'PhabricatorCalendarSchemaSpec' => 'applications/calendar/storage/PhabricatorCalendarSchemaSpec.php',
@@ -4860,6 +4862,7 @@ phutil_register_library_map(array(
     'PhabricatorCalendarEventCancelController' => 'PhabricatorCalendarController',
     'PhabricatorCalendarEventCommentController' => 'PhabricatorCalendarController',
     'PhabricatorCalendarEventEditController' => 'PhabricatorCalendarController',
+    'PhabricatorCalendarEventEditIconController' => 'PhabricatorCalendarController',
     'PhabricatorCalendarEventEditor' => 'PhabricatorApplicationTransactionEditor',
     'PhabricatorCalendarEventEmailCommand' => 'MetaMTAEmailTransactionCommand',
     'PhabricatorCalendarEventInvitee' => array(
@@ -4881,6 +4884,7 @@ phutil_register_library_map(array(
     'PhabricatorCalendarEventViewController' => 'PhabricatorCalendarController',
     'PhabricatorCalendarHoliday' => 'PhabricatorCalendarDAO',
     'PhabricatorCalendarHolidayTestCase' => 'PhabricatorTestCase',
+    'PhabricatorCalendarIcon' => 'Phobject',
     'PhabricatorCalendarRemarkupRule' => 'PhabricatorObjectRemarkupRule',
     'PhabricatorCalendarReplyHandler' => 'PhabricatorApplicationTransactionReplyHandler',
     'PhabricatorCalendarSchemaSpec' => 'PhabricatorConfigSchemaSpec',
diff --git a/src/applications/calendar/application/PhabricatorCalendarApplication.php b/src/applications/calendar/application/PhabricatorCalendarApplication.php
index aeeaa68d2b..534b11d2e8 100644
--- a/src/applications/calendar/application/PhabricatorCalendarApplication.php
+++ b/src/applications/calendar/application/PhabricatorCalendarApplication.php
@@ -45,6 +45,10 @@ final class PhabricatorCalendarApplication extends PhabricatorApplication {
         '(?:query/(?P<queryKey>[^/]+)/(?:(?P<year>\d+)/'.
           '(?P<month>\d+)/)?(?:(?P<day>\d+)/)?)?'
           => 'PhabricatorCalendarEventListController',
+        'icon/(?P<id>[1-9]\d*)/'
+          => 'PhabricatorCalendarEventEditIconController',
+        'icon/'
+          => 'PhabricatorCalendarEventEditIconController',
         'event/' => array(
           'create/'
             => 'PhabricatorCalendarEventEditController',
diff --git a/src/applications/calendar/controller/PhabricatorCalendarEventEditIconController.php b/src/applications/calendar/controller/PhabricatorCalendarEventEditIconController.php
new file mode 100644
index 0000000000..a8c9af97fb
--- /dev/null
+++ b/src/applications/calendar/controller/PhabricatorCalendarEventEditIconController.php
@@ -0,0 +1,102 @@
+<?php
+
+final class PhabricatorCalendarEventEditIconController
+  extends PhabricatorCalendarController {
+
+  private $id;
+
+  public function willProcessRequest(array $data) {
+    $this->id = idx($data, 'id');
+  }
+
+  public function handleRequest(AphrontRequest $request) {
+    $viewer = $request->getUser();
+
+    if ($this->id) {
+      $event = id(new PhabricatorCalendarEventQuery())
+        ->setViewer($viewer)
+        ->withIDs(array($this->id))
+        ->requireCapabilities(
+          array(
+            PhabricatorPolicyCapability::CAN_VIEW,
+            PhabricatorPolicyCapability::CAN_EDIT,
+          ))
+          ->executeOne();
+      if (!$event) {
+        return new Aphront404Response();
+      }
+      $cancel_uri = $this->getApplicationURI('/E'.$event->getID());
+      $event_icon = $event->getIcon();
+    } else {
+      $cancel_uri = '/calendar/';
+      $event_icon = $request->getStr('value');
+    }
+
+    require_celerity_resource('calendar-icon-css');
+    Javelin::initBehavior('phabricator-tooltips');
+
+    $calendar_icons = PhabricatorCalendarIcon::getIconMap();
+
+    if ($request->isFormPost()) {
+      $v_icon = $request->getStr('icon');
+
+      return id(new AphrontAjaxResponse())->setContent(
+        array(
+          'value' => $v_icon,
+          'display' => PhabricatorCalendarIcon::renderIconForChooser($v_icon),
+        ));
+    }
+
+    $ii = 0;
+    $buttons = array();
+    foreach ($calendar_icons as $icon => $label) {
+      $view = id(new PHUIIconView())
+        ->setIconFont($icon);
+
+      $aural = javelin_tag(
+        'span',
+        array(
+          'aural' => true,
+        ),
+        pht('Choose "%s" Icon', $label));
+
+      if ($icon == $event_icon) {
+        $class_extra = ' selected';
+      } else {
+        $class_extra = null;
+      }
+
+      $buttons[] = javelin_tag(
+        'button',
+        array(
+          'class' => 'icon-button'.$class_extra,
+          'name' => 'icon',
+          'value' => $icon,
+          'type' => 'submit',
+          'sigil' => 'has-tooltip',
+          'meta' => array(
+            'tip' => $label,
+          ),
+        ),
+        array(
+          $aural,
+          $view,
+        ));
+      if ((++$ii % 4) == 0) {
+        $buttons[] = phutil_tag('br');
+      }
+    }
+
+    $buttons = phutil_tag(
+      'div',
+      array(
+        'class' => 'icon-grid',
+      ),
+      $buttons);
+
+    return $this->newDialog()
+      ->setTitle(pht('Choose Calendar Event Icon'))
+      ->appendChild($buttons)
+      ->addCancelButton($cancel_uri);
+  }
+}
diff --git a/src/applications/calendar/icon/PhabricatorCalendarIcon.php b/src/applications/calendar/icon/PhabricatorCalendarIcon.php
new file mode 100644
index 0000000000..904ffee761
--- /dev/null
+++ b/src/applications/calendar/icon/PhabricatorCalendarIcon.php
@@ -0,0 +1,49 @@
+<?php
+
+final class PhabricatorCalendarIcon extends Phobject {
+
+  public static function getIconMap() {
+    return
+      array(
+        'fa-briefcase' => pht('Briefcase'),
+        'fa-tags' => pht('Tag'),
+        'fa-folder' => pht('Folder'),
+        'fa-users' => pht('Team'),
+        'fa-bug' => pht('Bug'),
+        'fa-trash-o' => pht('Garbage'),
+        'fa-calendar' => pht('Deadline'),
+        'fa-flag-checkered' => pht('Goal'),
+        'fa-envelope' => pht('Communication'),
+        'fa-truck' => pht('Release'),
+        'fa-lock' => pht('Policy'),
+        'fa-umbrella' => pht('An Umbrella'),
+        'fa-cloud' => pht('The Cloud'),
+        'fa-building' => pht('Company'),
+        'fa-credit-card' => pht('Accounting'),
+        'fa-flask' => pht('Experimental'),
+      );
+  }
+
+  public static function getLabel($key) {
+    $map = self::getIconMap();
+    return $map[$key];
+  }
+
+  public static function getAPIName($key) {
+    return substr($key, 3);
+  }
+
+  public static function renderIconForChooser($icon) {
+    $calendar_icons = self::getIconMap();
+
+    return phutil_tag(
+      'span',
+      array(),
+      array(
+        id(new PHUIIconView())->setIconFont($icon),
+        ' ',
+        idx($calendar_icons, $icon, pht('Unknown Icon')),
+      ));
+  }
+
+}
diff --git a/webroot/rsrc/css/application/calendar/calendar-icon.css b/webroot/rsrc/css/application/calendar/calendar-icon.css
new file mode 100644
index 0000000000..96aa1c42e0
--- /dev/null
+++ b/webroot/rsrc/css/application/calendar/calendar-icon.css
@@ -0,0 +1,28 @@
+/**
+ * @provides calendar-icon-css
+ */
+
+button.icon-button {
+  background: #f7f7f7;
+  border: 1px solid {$lightblueborder};
+  position: relative;
+  width: 16px;
+  height: 16px;
+  padding: 12px;
+  margin: 4px;
+  text-shadow: none;
+  box-shadow: none;
+  box-sizing: content-box;
+}
+
+.icon-grid {
+  text-align: center;
+}
+
+.icon-icon + .icon-icon {
+  margin-left: 4px;
+}
+
+button.icon-button.selected {
+  background: {$bluebackground};
+}

From 16c8d44c37c964fcd4041aa08544385e2b4d234a Mon Sep 17 00:00:00 2001
From: Bob Trahan <btrahan@phacility.com>
Date: Tue, 19 May 2015 11:26:53 -0700
Subject: [PATCH 54/86] Transactions - make customization of TYPE_EDGE optional

Summary: Ref T6403. This does TYPE_EDGE since I just had to deal with T8252. Look like this fixes a few editors (maybe) that would have had fatals with mentions like slowvote and ponder.

Test Plan: made a phame post mentioning a task and it worked! joined / left a project, watched / unwatched a project and that worked! blind faith for other sites.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6403

Differential Revision: https://secure.phabricator.com/D12929
---
 .../almanac/editor/AlmanacDeviceEditor.php      |  2 --
 .../almanac/editor/AlmanacServiceEditor.php     |  2 --
 .../audit/editor/PhabricatorAuditEditor.php     |  2 --
 .../editor/PhabricatorCalendarEventEditor.php   |  2 --
 ...abricatorDashboardPanelTransactionEditor.php |  3 ---
 .../PhabricatorDashboardTransactionEditor.php   |  4 ----
 .../editor/DifferentialTransactionEditor.php    |  3 ---
 .../fund/editor/FundInitiativeEditor.php        |  2 --
 .../paste/editor/PhabricatorPasteEditor.php     |  2 --
 .../phame/editor/PhamePostEditor.php            |  3 ---
 .../pholio/editor/PholioMockEditor.php          |  4 ----
 .../phortune/editor/PhortuneAccountEditor.php   |  4 ----
 .../phortune/editor/PhortuneMerchantEditor.php  |  2 --
 .../ponder/editor/PonderQuestionEditor.php      |  2 --
 .../PhabricatorProjectTransactionEditor.php     | 17 +++++++++++++++--
 .../editor/PhabricatorSlowvoteEditor.php        |  2 --
 .../PhabricatorApplicationTransactionEditor.php |  3 ++-
 17 files changed, 17 insertions(+), 42 deletions(-)

diff --git a/src/applications/almanac/editor/AlmanacDeviceEditor.php b/src/applications/almanac/editor/AlmanacDeviceEditor.php
index 98f7604fb4..211788e441 100644
--- a/src/applications/almanac/editor/AlmanacDeviceEditor.php
+++ b/src/applications/almanac/editor/AlmanacDeviceEditor.php
@@ -57,7 +57,6 @@ final class AlmanacDeviceEditor
       case AlmanacDeviceTransaction::TYPE_INTERFACE:
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
-      case PhabricatorTransactions::TYPE_EDGE:
         return;
     }
 
@@ -72,7 +71,6 @@ final class AlmanacDeviceEditor
       case AlmanacDeviceTransaction::TYPE_NAME:
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
-      case PhabricatorTransactions::TYPE_EDGE:
         return;
       case AlmanacDeviceTransaction::TYPE_INTERFACE:
         $old = $xaction->getOldValue();
diff --git a/src/applications/almanac/editor/AlmanacServiceEditor.php b/src/applications/almanac/editor/AlmanacServiceEditor.php
index 65d4d03c55..928696dbcd 100644
--- a/src/applications/almanac/editor/AlmanacServiceEditor.php
+++ b/src/applications/almanac/editor/AlmanacServiceEditor.php
@@ -63,7 +63,6 @@ final class AlmanacServiceEditor
         return;
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
-      case PhabricatorTransactions::TYPE_EDGE:
         return;
     }
 
@@ -78,7 +77,6 @@ final class AlmanacServiceEditor
       case AlmanacServiceTransaction::TYPE_NAME:
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
-      case PhabricatorTransactions::TYPE_EDGE:
         return;
       case AlmanacServiceTransaction::TYPE_LOCK:
         $service = id(new AlmanacServiceQuery())
diff --git a/src/applications/audit/editor/PhabricatorAuditEditor.php b/src/applications/audit/editor/PhabricatorAuditEditor.php
index d30a4061b7..77d1d0a23a 100644
--- a/src/applications/audit/editor/PhabricatorAuditEditor.php
+++ b/src/applications/audit/editor/PhabricatorAuditEditor.php
@@ -117,7 +117,6 @@ final class PhabricatorAuditEditor
     switch ($xaction->getTransactionType()) {
       case PhabricatorTransactions::TYPE_COMMENT:
       case PhabricatorTransactions::TYPE_SUBSCRIBERS:
-      case PhabricatorTransactions::TYPE_EDGE:
       case PhabricatorAuditActionConstants::ACTION:
       case PhabricatorAuditActionConstants::INLINE:
       case PhabricatorAuditActionConstants::ADD_AUDITORS:
@@ -135,7 +134,6 @@ final class PhabricatorAuditEditor
     switch ($xaction->getTransactionType()) {
       case PhabricatorTransactions::TYPE_COMMENT:
       case PhabricatorTransactions::TYPE_SUBSCRIBERS:
-      case PhabricatorTransactions::TYPE_EDGE:
       case PhabricatorAuditActionConstants::ACTION:
       case PhabricatorAuditTransaction::TYPE_COMMIT:
         return;
diff --git a/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php b/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
index 727c33958f..cf6fc5936e 100644
--- a/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
+++ b/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
@@ -111,7 +111,6 @@ final class PhabricatorCalendarEventEditor
       case PhabricatorTransactions::TYPE_COMMENT:
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
-      case PhabricatorTransactions::TYPE_EDGE:
       case PhabricatorTransactions::TYPE_SUBSCRIBERS:
         return;
     }
@@ -154,7 +153,6 @@ final class PhabricatorCalendarEventEditor
       case PhabricatorTransactions::TYPE_COMMENT:
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
-      case PhabricatorTransactions::TYPE_EDGE:
       case PhabricatorTransactions::TYPE_SUBSCRIBERS:
         return;
     }
diff --git a/src/applications/dashboard/editor/PhabricatorDashboardPanelTransactionEditor.php b/src/applications/dashboard/editor/PhabricatorDashboardPanelTransactionEditor.php
index 4b1ddde899..6f76e2618e 100644
--- a/src/applications/dashboard/editor/PhabricatorDashboardPanelTransactionEditor.php
+++ b/src/applications/dashboard/editor/PhabricatorDashboardPanelTransactionEditor.php
@@ -68,8 +68,6 @@ final class PhabricatorDashboardPanelTransactionEditor
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
         $object->setEditPolicy($xaction->getNewValue());
         return;
-      case PhabricatorTransactions::TYPE_EDGE:
-        return;
     }
 
     return parent::applyCustomInternalTransaction($object, $xaction);
@@ -84,7 +82,6 @@ final class PhabricatorDashboardPanelTransactionEditor
       case PhabricatorDashboardPanelTransaction::TYPE_ARCHIVE:
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
-      case PhabricatorTransactions::TYPE_EDGE:
         return;
     }
 
diff --git a/src/applications/dashboard/editor/PhabricatorDashboardTransactionEditor.php b/src/applications/dashboard/editor/PhabricatorDashboardTransactionEditor.php
index 6942a5f89e..ed16a22a9c 100644
--- a/src/applications/dashboard/editor/PhabricatorDashboardTransactionEditor.php
+++ b/src/applications/dashboard/editor/PhabricatorDashboardTransactionEditor.php
@@ -115,8 +115,6 @@ final class PhabricatorDashboardTransactionEditor
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
         $object->setEditPolicy($xaction->getNewValue());
         return;
-      case PhabricatorTransactions::TYPE_EDGE:
-        return;
     }
 
     return parent::applyCustomInternalTransaction($object, $xaction);
@@ -132,8 +130,6 @@ final class PhabricatorDashboardTransactionEditor
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
         return;
-      case PhabricatorTransactions::TYPE_EDGE:
-        return;
     }
 
     return parent::applyCustomExternalTransaction($object, $xaction);
diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php
index 94889213ba..a9084093f6 100644
--- a/src/applications/differential/editor/DifferentialTransactionEditor.php
+++ b/src/applications/differential/editor/DifferentialTransactionEditor.php
@@ -199,8 +199,6 @@ final class DifferentialTransactionEditor
       case PhabricatorTransactions::TYPE_COMMENT:
       case DifferentialTransaction::TYPE_INLINE:
         return;
-      case PhabricatorTransactions::TYPE_EDGE:
-        return;
       case DifferentialTransaction::TYPE_UPDATE:
         if (!$this->getIsCloseByCommit()) {
           switch ($object->getStatus()) {
@@ -581,7 +579,6 @@ final class DifferentialTransactionEditor
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
         return;
       case PhabricatorTransactions::TYPE_SUBSCRIBERS:
-      case PhabricatorTransactions::TYPE_EDGE:
       case PhabricatorTransactions::TYPE_COMMENT:
       case DifferentialTransaction::TYPE_ACTION:
         return;
diff --git a/src/applications/fund/editor/FundInitiativeEditor.php b/src/applications/fund/editor/FundInitiativeEditor.php
index 05041ba119..33ad1017d0 100644
--- a/src/applications/fund/editor/FundInitiativeEditor.php
+++ b/src/applications/fund/editor/FundInitiativeEditor.php
@@ -103,7 +103,6 @@ final class FundInitiativeEditor
         $object->setTotalAsCurrency($total);
         return;
       case PhabricatorTransactions::TYPE_SUBSCRIBERS:
-      case PhabricatorTransactions::TYPE_EDGE:
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
         return;
@@ -157,7 +156,6 @@ final class FundInitiativeEditor
         $editor->applyTransactions($backer, $subx);
         return;
       case PhabricatorTransactions::TYPE_SUBSCRIBERS:
-      case PhabricatorTransactions::TYPE_EDGE:
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
         return;
diff --git a/src/applications/paste/editor/PhabricatorPasteEditor.php b/src/applications/paste/editor/PhabricatorPasteEditor.php
index 45e4998d99..86f2eea393 100644
--- a/src/applications/paste/editor/PhabricatorPasteEditor.php
+++ b/src/applications/paste/editor/PhabricatorPasteEditor.php
@@ -90,7 +90,6 @@ final class PhabricatorPasteEditor
         return;
       case PhabricatorTransactions::TYPE_COMMENT:
       case PhabricatorTransactions::TYPE_SUBSCRIBERS:
-      case PhabricatorTransactions::TYPE_EDGE:
         return;
     }
 
@@ -109,7 +108,6 @@ final class PhabricatorPasteEditor
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
       case PhabricatorTransactions::TYPE_COMMENT:
       case PhabricatorTransactions::TYPE_SUBSCRIBERS:
-      case PhabricatorTransactions::TYPE_EDGE:
         return;
     }
 
diff --git a/src/applications/phame/editor/PhamePostEditor.php b/src/applications/phame/editor/PhamePostEditor.php
index c08ad2b155..ef6cd21307 100644
--- a/src/applications/phame/editor/PhamePostEditor.php
+++ b/src/applications/phame/editor/PhamePostEditor.php
@@ -64,8 +64,6 @@ final class PhamePostEditor
         return $object->setBody($xaction->getNewValue());
       case PhamePostTransaction::TYPE_COMMENTS_WIDGET:
         return $object->setCommentsWidget($xaction->getNewValue());
-      case PhabricatorTransactions::TYPE_EDGE:
-        return;
     }
 
     return parent::applyCustomInternalTransaction($object, $xaction);
@@ -80,7 +78,6 @@ final class PhamePostEditor
       case PhamePostTransaction::TYPE_PHAME_TITLE:
       case PhamePostTransaction::TYPE_BODY:
       case PhamePostTransaction::TYPE_COMMENTS_WIDGET:
-      case PhabricatorTransactions::TYPE_EDGE:
         return;
     }
 
diff --git a/src/applications/pholio/editor/PholioMockEditor.php b/src/applications/pholio/editor/PholioMockEditor.php
index 7ba95455b5..cd36b563b3 100644
--- a/src/applications/pholio/editor/PholioMockEditor.php
+++ b/src/applications/pholio/editor/PholioMockEditor.php
@@ -209,8 +209,6 @@ final class PholioMockEditor extends PhabricatorApplicationTransactionEditor {
       case PholioTransactionType::TYPE_STATUS:
         $object->setStatus($xaction->getNewValue());
         break;
-      case PhabricatorTransactions::TYPE_EDGE:
-        return;
     }
   }
 
@@ -278,8 +276,6 @@ final class PholioMockEditor extends PhabricatorApplicationTransactionEditor {
         $image->setSequence($value);
         $image->save();
         break;
-      case PhabricatorTransactions::TYPE_EDGE:
-        return;
     }
   }
 
diff --git a/src/applications/phortune/editor/PhortuneAccountEditor.php b/src/applications/phortune/editor/PhortuneAccountEditor.php
index 2c1186dafb..556df99fbf 100644
--- a/src/applications/phortune/editor/PhortuneAccountEditor.php
+++ b/src/applications/phortune/editor/PhortuneAccountEditor.php
@@ -49,8 +49,6 @@ final class PhortuneAccountEditor
       case PhortuneAccountTransaction::TYPE_NAME:
         $object->setName($xaction->getNewValue());
         return;
-      case PhabricatorTransactions::TYPE_EDGE:
-        return;
     }
     return parent::applyCustomInternalTransaction($object, $xaction);
   }
@@ -61,8 +59,6 @@ final class PhortuneAccountEditor
     switch ($xaction->getTransactionType()) {
       case PhortuneAccountTransaction::TYPE_NAME:
         return;
-      case PhabricatorTransactions::TYPE_EDGE:
-        return;
     }
     return parent::applyCustomExternalTransaction($object, $xaction);
   }
diff --git a/src/applications/phortune/editor/PhortuneMerchantEditor.php b/src/applications/phortune/editor/PhortuneMerchantEditor.php
index 432efe0886..ae8c1fda54 100644
--- a/src/applications/phortune/editor/PhortuneMerchantEditor.php
+++ b/src/applications/phortune/editor/PhortuneMerchantEditor.php
@@ -59,7 +59,6 @@ final class PhortuneMerchantEditor
       case PhortuneMerchantTransaction::TYPE_DESCRIPTION:
         $object->setDescription($xaction->getNewValue());
         return;
-      case PhabricatorTransactions::TYPE_EDGE:
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
         return;
     }
@@ -74,7 +73,6 @@ final class PhortuneMerchantEditor
     switch ($xaction->getTransactionType()) {
       case PhortuneMerchantTransaction::TYPE_NAME:
       case PhortuneMerchantTransaction::TYPE_DESCRIPTION:
-      case PhabricatorTransactions::TYPE_EDGE:
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
         return;
     }
diff --git a/src/applications/ponder/editor/PonderQuestionEditor.php b/src/applications/ponder/editor/PonderQuestionEditor.php
index 5505e751de..9dbe58cb0e 100644
--- a/src/applications/ponder/editor/PonderQuestionEditor.php
+++ b/src/applications/ponder/editor/PonderQuestionEditor.php
@@ -145,8 +145,6 @@ final class PonderQuestionEditor
 
         $object->setAnswerCount($count);
         break;
-      case PhabricatorTransactions::TYPE_EDGE:
-        return;
     }
   }
 
diff --git a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
index 502623685c..84ca63a358 100644
--- a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
+++ b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
@@ -103,7 +103,6 @@ final class PhabricatorProjectTransactionEditor
         $object->setIsMembershipLocked($xaction->getNewValue());
         return;
       case PhabricatorTransactions::TYPE_SUBSCRIBERS:
-      case PhabricatorTransactions::TYPE_EDGE:
         return;
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
         $object->setViewPolicy($xaction->getNewValue());
@@ -170,6 +169,20 @@ final class PhabricatorProjectTransactionEditor
       case PhabricatorProjectTransaction::TYPE_COLOR:
       case PhabricatorProjectTransaction::TYPE_LOCKED:
         return;
+     }
+
+    return parent::applyCustomExternalTransaction($object, $xaction);
+  }
+
+  protected function applyBuiltinExternalTransaction(
+    PhabricatorLiskDAO $object,
+    PhabricatorApplicationTransaction $xaction) {
+
+    $old = $xaction->getOldValue();
+    $new = $xaction->getNewValue();
+
+    switch ($xaction->getTransactionType()) {
+
       case PhabricatorTransactions::TYPE_EDGE:
         $edge_type = $xaction->getMetadataValue('edge:type');
         switch ($edge_type) {
@@ -225,7 +238,7 @@ final class PhabricatorProjectTransactionEditor
         return;
     }
 
-    return parent::applyCustomExternalTransaction($object, $xaction);
+    return parent::applyBuiltinExternalTransaction($object, $xaction);
   }
 
   protected function validateTransaction(
diff --git a/src/applications/slowvote/editor/PhabricatorSlowvoteEditor.php b/src/applications/slowvote/editor/PhabricatorSlowvoteEditor.php
index 1ca1361436..d1bd6c18f0 100644
--- a/src/applications/slowvote/editor/PhabricatorSlowvoteEditor.php
+++ b/src/applications/slowvote/editor/PhabricatorSlowvoteEditor.php
@@ -102,8 +102,6 @@ final class PhabricatorSlowvoteEditor
       case PhabricatorSlowvoteTransaction::TYPE_CLOSE:
         $object->setIsClosed((int)$xaction->getNewValue());
         break;
-      case PhabricatorTransactions::TYPE_EDGE:
-        return;
     }
   }
 
diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
index 6b070efaf9..406aaeac4a 100644
--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
@@ -402,6 +402,7 @@ abstract class PhabricatorApplicationTransactionEditor
         $field = $this->getCustomFieldForTransaction($object, $xaction);
         return $field->applyApplicationTransactionInternalEffects($xaction);
       case PhabricatorTransactions::TYPE_INLINESTATE:
+      case PhabricatorTransactions::TYPE_EDGE:
         return $this->applyBuiltinInternalTransaction($object, $xaction);
     }
 
@@ -493,7 +494,7 @@ abstract class PhabricatorApplicationTransactionEditor
         }
 
         $editor->save();
-        break;
+        return $this->applyBuiltinExternalTransaction($object, $xaction);
       case PhabricatorTransactions::TYPE_CUSTOMFIELD:
         $field = $this->getCustomFieldForTransaction($object, $xaction);
         return $field->applyApplicationTransactionExternalEffects($xaction);

From 18e0ee079132d1a63464db817109f17b1347ce5e Mon Sep 17 00:00:00 2001
From: Bob Trahan <btrahan@phacility.com>
Date: Tue, 19 May 2015 11:48:02 -0700
Subject: [PATCH 55/86] Transactions - move TYPE_SUBSCRIBERS to require
 optional implementation

Summary: Ref T6403. This one was pretty easy since no one does anything custom with subscribers.

Test Plan: subscribed / unscribed to a random commit ("audit"). joined / left, watched / unwatched a project

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6403

Differential Revision: https://secure.phabricator.com/D12930
---
 src/applications/audit/editor/PhabricatorAuditEditor.php       | 2 --
 .../calendar/editor/PhabricatorCalendarEventEditor.php         | 2 --
 .../differential/editor/DifferentialTransactionEditor.php      | 2 --
 src/applications/fund/editor/FundInitiativeEditor.php          | 2 --
 src/applications/paste/editor/PhabricatorPasteEditor.php       | 2 --
 .../project/editor/PhabricatorProjectTransactionEditor.php     | 3 ---
 .../editor/PhabricatorApplicationTransactionEditor.php         | 3 ++-
 7 files changed, 2 insertions(+), 14 deletions(-)

diff --git a/src/applications/audit/editor/PhabricatorAuditEditor.php b/src/applications/audit/editor/PhabricatorAuditEditor.php
index 77d1d0a23a..f3e7bdebb0 100644
--- a/src/applications/audit/editor/PhabricatorAuditEditor.php
+++ b/src/applications/audit/editor/PhabricatorAuditEditor.php
@@ -116,7 +116,6 @@ final class PhabricatorAuditEditor
 
     switch ($xaction->getTransactionType()) {
       case PhabricatorTransactions::TYPE_COMMENT:
-      case PhabricatorTransactions::TYPE_SUBSCRIBERS:
       case PhabricatorAuditActionConstants::ACTION:
       case PhabricatorAuditActionConstants::INLINE:
       case PhabricatorAuditActionConstants::ADD_AUDITORS:
@@ -133,7 +132,6 @@ final class PhabricatorAuditEditor
 
     switch ($xaction->getTransactionType()) {
       case PhabricatorTransactions::TYPE_COMMENT:
-      case PhabricatorTransactions::TYPE_SUBSCRIBERS:
       case PhabricatorAuditActionConstants::ACTION:
       case PhabricatorAuditTransaction::TYPE_COMMIT:
         return;
diff --git a/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php b/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
index cf6fc5936e..3e3b68d08f 100644
--- a/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
+++ b/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
@@ -111,7 +111,6 @@ final class PhabricatorCalendarEventEditor
       case PhabricatorTransactions::TYPE_COMMENT:
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
-      case PhabricatorTransactions::TYPE_SUBSCRIBERS:
         return;
     }
 
@@ -153,7 +152,6 @@ final class PhabricatorCalendarEventEditor
       case PhabricatorTransactions::TYPE_COMMENT:
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
-      case PhabricatorTransactions::TYPE_SUBSCRIBERS:
         return;
     }
 
diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php
index a9084093f6..24ffbb9031 100644
--- a/src/applications/differential/editor/DifferentialTransactionEditor.php
+++ b/src/applications/differential/editor/DifferentialTransactionEditor.php
@@ -195,7 +195,6 @@ final class DifferentialTransactionEditor
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
         $object->setEditPolicy($xaction->getNewValue());
         return;
-      case PhabricatorTransactions::TYPE_SUBSCRIBERS:
       case PhabricatorTransactions::TYPE_COMMENT:
       case DifferentialTransaction::TYPE_INLINE:
         return;
@@ -578,7 +577,6 @@ final class DifferentialTransactionEditor
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
         return;
-      case PhabricatorTransactions::TYPE_SUBSCRIBERS:
       case PhabricatorTransactions::TYPE_COMMENT:
       case DifferentialTransaction::TYPE_ACTION:
         return;
diff --git a/src/applications/fund/editor/FundInitiativeEditor.php b/src/applications/fund/editor/FundInitiativeEditor.php
index 33ad1017d0..13296be13f 100644
--- a/src/applications/fund/editor/FundInitiativeEditor.php
+++ b/src/applications/fund/editor/FundInitiativeEditor.php
@@ -102,7 +102,6 @@ final class FundInitiativeEditor
 
         $object->setTotalAsCurrency($total);
         return;
-      case PhabricatorTransactions::TYPE_SUBSCRIBERS:
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
         return;
@@ -155,7 +154,6 @@ final class FundInitiativeEditor
 
         $editor->applyTransactions($backer, $subx);
         return;
-      case PhabricatorTransactions::TYPE_SUBSCRIBERS:
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
         return;
diff --git a/src/applications/paste/editor/PhabricatorPasteEditor.php b/src/applications/paste/editor/PhabricatorPasteEditor.php
index 86f2eea393..0d64017421 100644
--- a/src/applications/paste/editor/PhabricatorPasteEditor.php
+++ b/src/applications/paste/editor/PhabricatorPasteEditor.php
@@ -89,7 +89,6 @@ final class PhabricatorPasteEditor
         $object->setEditPolicy($xaction->getNewValue());
         return;
       case PhabricatorTransactions::TYPE_COMMENT:
-      case PhabricatorTransactions::TYPE_SUBSCRIBERS:
         return;
     }
 
@@ -107,7 +106,6 @@ final class PhabricatorPasteEditor
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
       case PhabricatorTransactions::TYPE_COMMENT:
-      case PhabricatorTransactions::TYPE_SUBSCRIBERS:
         return;
     }
 
diff --git a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
index 84ca63a358..348ba53c4d 100644
--- a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
+++ b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
@@ -102,8 +102,6 @@ final class PhabricatorProjectTransactionEditor
       case PhabricatorProjectTransaction::TYPE_LOCKED:
         $object->setIsMembershipLocked($xaction->getNewValue());
         return;
-      case PhabricatorTransactions::TYPE_SUBSCRIBERS:
-        return;
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
         $object->setViewPolicy($xaction->getNewValue());
         return;
@@ -159,7 +157,6 @@ final class PhabricatorProjectTransactionEditor
         }
 
         return;
-      case PhabricatorTransactions::TYPE_SUBSCRIBERS:
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
       case PhabricatorTransactions::TYPE_JOIN_POLICY:
diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
index 406aaeac4a..11c11e1cc9 100644
--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
@@ -401,6 +401,7 @@ abstract class PhabricatorApplicationTransactionEditor
       case PhabricatorTransactions::TYPE_CUSTOMFIELD:
         $field = $this->getCustomFieldForTransaction($object, $xaction);
         return $field->applyApplicationTransactionInternalEffects($xaction);
+      case PhabricatorTransactions::TYPE_SUBSCRIBERS:
       case PhabricatorTransactions::TYPE_INLINESTATE:
       case PhabricatorTransactions::TYPE_EDGE:
         return $this->applyBuiltinInternalTransaction($object, $xaction);
@@ -441,8 +442,8 @@ abstract class PhabricatorApplicationTransactionEditor
           $xaction->getOldValue(),
           $xaction->getNewValue()));
         $this->subscribers = $subscribers;
+        return $this->applyBuiltinExternalTransaction($object, $xaction);
 
-        break;
       case PhabricatorTransactions::TYPE_EDGE:
         if ($this->getIsInverseEdgeEditor()) {
           // If we're writing an inverse edge transaction, don't actually

From 4622993885666fab98e9cba881b123daf3461f16 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Tue, 19 May 2015 12:14:44 -0700
Subject: [PATCH 56/86] Give Phriction a real dropdown

Summary:
Fixes T8150. Small generalization:

  - Timeline has a dropdown with no special logic; make that generic.
  - Use it in Phriction.

Test Plan:
  - Used Phriction dropdown on desktop and mobile.
  - Used timeline dropdown.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8150

Differential Revision: https://secure.phabricator.com/D12931
---
 resources/celerity/map.php                    | 28 +++++++++----------
 resources/celerity/packages.php               |  2 +-
 .../PhrictionDocumentController.php           | 15 ++++++----
 src/view/phui/PHUIButtonView.php              | 12 ++++++++
 src/view/phui/PHUIDocumentView.php            | 28 -------------------
 src/view/phui/PHUITimelineEventView.php       |  4 +--
 ...menu.js => behavior-phui-dropdown-menu.js} | 10 +++----
 7 files changed, 43 insertions(+), 56 deletions(-)
 rename webroot/rsrc/js/phui/{behavior-phui-timeline-dropdown-menu.js => behavior-phui-dropdown-menu.js} (64%)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 862bf22145..1769c81f76 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,8 +7,8 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => '79e995d7',
-    'core.pkg.js' => 'a2f2598e',
+    'core.pkg.css' => 'e3ba62e8',
+    'core.pkg.js' => '328799d0',
     'darkconsole.pkg.js' => 'e7393ebb',
     'differential.pkg.css' => 'bb338e4b',
     'differential.pkg.js' => '45b3b51d',
@@ -38,7 +38,6 @@ return array(
     'rsrc/css/application/base/notification-menu.css' => '3c9d8aa1',
     'rsrc/css/application/base/phabricator-application-launch-view.css' => '16ca323f',
     'rsrc/css/application/base/standard-page-view.css' => '61e68a55',
-    'rsrc/css/application/calendar/calendar-icon.css' => '98ce946d',
     'rsrc/css/application/chatlog/chatlog.css' => '852140ff',
     'rsrc/css/application/conduit/conduit-api.css' => '7bc725c4',
     'rsrc/css/application/config/config-options.css' => '7fedf08b',
@@ -46,7 +45,7 @@ return array(
     'rsrc/css/application/config/config-welcome.css' => '6abd79be',
     'rsrc/css/application/config/setup-issue.css' => '22270af2',
     'rsrc/css/application/config/unhandled-exception.css' => '37d4f9a2',
-    'rsrc/css/application/conpherence/durable-column.css' => '8c43d6ac',
+    'rsrc/css/application/conpherence/durable-column.css' => '4331cbe9',
     'rsrc/css/application/conpherence/menu.css' => 'f389e048',
     'rsrc/css/application/conpherence/message-pane.css' => '5bb4b76d',
     'rsrc/css/application/conpherence/notification.css' => '919974b6',
@@ -472,8 +471,8 @@ return array(
     'rsrc/js/core/behavior-watch-anchor.js' => '9f36c42d',
     'rsrc/js/core/behavior-workflow.js' => '0a3f3021',
     'rsrc/js/core/phtize.js' => 'd254d646',
+    'rsrc/js/phui/behavior-phui-dropdown-menu.js' => '54733475',
     'rsrc/js/phui/behavior-phui-object-box-tabs.js' => '2bfa2836',
-    'rsrc/js/phui/behavior-phui-timeline-dropdown-menu.js' => '4d94d9c3',
     'rsrc/js/phuix/PHUIXActionListView.js' => 'b5c256b8',
     'rsrc/js/phuix/PHUIXActionView.js' => '8cf6d262',
     'rsrc/js/phuix/PHUIXDropdownMenu.js' => 'bd4c8dca',
@@ -493,12 +492,11 @@ return array(
     'aphront-two-column-view-css' => '16ab3ad2',
     'aphront-typeahead-control-css' => '0e403212',
     'auth-css' => '44975d4b',
-    'calendar-icon-css' => '98ce946d',
     'changeset-view-manager' => '58562350',
     'conduit-api-css' => '7bc725c4',
     'config-options-css' => '7fedf08b',
     'config-welcome-css' => '6abd79be',
-    'conpherence-durable-column-view' => '8c43d6ac',
+    'conpherence-durable-column-view' => '4331cbe9',
     'conpherence-menu-css' => 'f389e048',
     'conpherence-message-pane-css' => '5bb4b76d',
     'conpherence-notification-css' => '919974b6',
@@ -618,8 +616,8 @@ return array(
     'javelin-behavior-phame-post-preview' => 'be807912',
     'javelin-behavior-pholio-mock-edit' => '246dc085',
     'javelin-behavior-pholio-mock-view' => 'fbe497e7',
+    'javelin-behavior-phui-dropdown-menu' => '54733475',
     'javelin-behavior-phui-object-box-tabs' => '2bfa2836',
-    'javelin-behavior-phui-timeline-dropdown-menu' => '4d94d9c3',
     'javelin-behavior-policy-control' => '9a340b3d',
     'javelin-behavior-policy-rule-editor' => '5e9f347c',
     'javelin-behavior-ponder-votebox' => '4e9b766b',
@@ -1135,12 +1133,6 @@ return array(
     '4cebc641' => array(
       'javelin-install',
     ),
-    '4d94d9c3' => array(
-      'javelin-behavior',
-      'javelin-stratcom',
-      'javelin-dom',
-      'phuix-dropdown-menu',
-    ),
     '4e3e79a6' => array(
       'javelin-behavior',
       'javelin-stratcom',
@@ -1175,6 +1167,12 @@ return array(
       'javelin-leader',
       'javelin-json',
     ),
+    54733475 => array(
+      'javelin-behavior',
+      'javelin-stratcom',
+      'javelin-dom',
+      'phuix-dropdown-menu',
+    ),
     '54b612ba' => array(
       'javelin-color',
       'javelin-install',
@@ -2147,7 +2145,7 @@ return array(
       'phabricator-draggable-list',
       'javelin-behavior-phabricator-transaction-list',
       'javelin-behavior-phabricator-show-older-transactions',
-      'javelin-behavior-phui-timeline-dropdown-menu',
+      'javelin-behavior-phui-dropdown-menu',
       'javelin-behavior-doorkeeper-tag',
       'phabricator-title',
       'javelin-leader',
diff --git a/resources/celerity/packages.php b/resources/celerity/packages.php
index 8e40e24b3d..7a7fc2a1bd 100644
--- a/resources/celerity/packages.php
+++ b/resources/celerity/packages.php
@@ -66,7 +66,7 @@ return array(
     'phabricator-draggable-list',
     'javelin-behavior-phabricator-transaction-list',
     'javelin-behavior-phabricator-show-older-transactions',
-    'javelin-behavior-phui-timeline-dropdown-menu',
+    'javelin-behavior-phui-dropdown-menu',
     'javelin-behavior-doorkeeper-tag',
     'phabricator-title',
     'javelin-leader',
diff --git a/src/applications/phriction/controller/PhrictionDocumentController.php b/src/applications/phriction/controller/PhrictionDocumentController.php
index 95666874ef..1031a2a059 100644
--- a/src/applications/phriction/controller/PhrictionDocumentController.php
+++ b/src/applications/phriction/controller/PhrictionDocumentController.php
@@ -192,10 +192,19 @@ final class PhrictionDocumentController
       $crumbs->addCrumb($view);
     }
 
+    $action_button = id(new PHUIButtonView())
+      ->setTag('a')
+      ->setText(pht('Actions'))
+      ->setHref('#')
+      ->setIconFont('fa-bars')
+      ->addClass('phui-mobile-menu')
+      ->setDropdownMenu($actions);
+
     $header = id(new PHUIHeaderView())
       ->setUser($user)
       ->setPolicyObject($document)
-      ->setHeader($page_title);
+      ->setHeader($page_title)
+      ->addActionLink($action_button);
 
     if ($content) {
       $header->setEpoch($content->getDateCreated());
@@ -206,16 +215,12 @@ final class PhrictionDocumentController
       $prop_list = new PHUIPropertyGroupView();
       $prop_list->addPropertyList($properties);
     }
-    $action_id = celerity_generate_unique_node_id();
-    $actions->setID($action_id);
 
     $page_content = id(new PHUIDocumentView())
       ->setFontKit(PHUIDocumentView::FONT_SOURCE_SANS)
       ->setHeader($header)
-      ->setActionListID($action_id)
       ->appendChild(
         array(
-          $actions,
           $prop_list,
           $version_note,
           $move_notice,
diff --git a/src/view/phui/PHUIButtonView.php b/src/view/phui/PHUIButtonView.php
index 26d1c59f46..8dc5392966 100644
--- a/src/view/phui/PHUIButtonView.php
+++ b/src/view/phui/PHUIButtonView.php
@@ -103,6 +103,18 @@ final class PHUIButtonView extends AphrontTagView {
     return $this->tag;
   }
 
+  public function setDropdownMenu(PhabricatorActionListView $actions) {
+    Javelin::initBehavior('phui-dropdown-menu');
+
+    $this->addSigil('phui-dropdown-menu');
+    $this->setMetadata(
+      array(
+        'items' => $actions,
+      ));
+
+    return $this;
+  }
+
   protected function getTagAttributes() {
 
     require_celerity_resource('phui-button-css');
diff --git a/src/view/phui/PHUIDocumentView.php b/src/view/phui/PHUIDocumentView.php
index a27805e1c7..50749f2bb9 100644
--- a/src/view/phui/PHUIDocumentView.php
+++ b/src/view/phui/PHUIDocumentView.php
@@ -16,7 +16,6 @@ final class PHUIDocumentView extends AphrontTagView {
   private $bookdescription;
   private $mobileview;
   private $fontKit;
-  private $actionListID;
   private $fluid;
 
   public function setOffset($offset) {
@@ -59,11 +58,6 @@ final class PHUIDocumentView extends AphrontTagView {
     return $this;
   }
 
-  public function setActionListID($id) {
-    $this->actionListID = $id;
-    return $this;
-  }
-
   public function setFluid($fluid) {
     $this->fluid = $fluid;
     return $this;
@@ -166,28 +160,6 @@ final class PHUIDocumentView extends AphrontTagView {
       $main_content = $this->renderChildren();
     }
 
-    if ($this->actionListID) {
-      $icon_id = celerity_generate_unique_node_id();
-      $icon = id(new PHUIIconView())
-        ->setIconFont('fa-bars');
-      $meta = array(
-        'map' => array(
-          $this->actionListID => 'phabricator-action-list-toggle',
-          $icon_id => 'phuix-dropdown-open',
-        ),
-      );
-      $mobile_menu = id(new PHUIButtonView())
-        ->setTag('a')
-        ->setText(pht('Actions'))
-        ->setHref('#')
-        ->setIcon($icon)
-        ->addClass('phui-mobile-menu')
-        ->setID($icon_id)
-        ->addSigil('jx-toggle-class')
-        ->setMetadata($meta);
-      $this->header->addActionLink($mobile_menu);
-    }
-
     $content_inner = phutil_tag(
         'div',
         array(
diff --git a/src/view/phui/PHUITimelineEventView.php b/src/view/phui/PHUITimelineEventView.php
index bc14f5776b..541f9098dd 100644
--- a/src/view/phui/PHUITimelineEventView.php
+++ b/src/view/phui/PHUITimelineEventView.php
@@ -290,8 +290,8 @@ final class PHUITimelineEventView extends AphrontView {
         pht('Comment Actions'));
 
       if ($items) {
-        $sigil = 'phui-timeline-menu';
-        Javelin::initBehavior('phui-timeline-dropdown-menu');
+        $sigil = 'phui-dropdown-menu';
+        Javelin::initBehavior('phui-dropdown-menu');
       } else {
         $sigil = null;
       }
diff --git a/webroot/rsrc/js/phui/behavior-phui-timeline-dropdown-menu.js b/webroot/rsrc/js/phui/behavior-phui-dropdown-menu.js
similarity index 64%
rename from webroot/rsrc/js/phui/behavior-phui-timeline-dropdown-menu.js
rename to webroot/rsrc/js/phui/behavior-phui-dropdown-menu.js
index 2c3e3ded9b..d841c87670 100644
--- a/webroot/rsrc/js/phui/behavior-phui-timeline-dropdown-menu.js
+++ b/webroot/rsrc/js/phui/behavior-phui-dropdown-menu.js
@@ -1,15 +1,15 @@
 /**
- * @provides javelin-behavior-phui-timeline-dropdown-menu
+ * @provides javelin-behavior-phui-dropdown-menu
  * @requires javelin-behavior
  *           javelin-stratcom
  *           javelin-dom
  *           phuix-dropdown-menu
  */
 
-JX.behavior('phui-timeline-dropdown-menu', function() {
+JX.behavior('phui-dropdown-menu', function() {
 
-  JX.Stratcom.listen('click', 'phui-timeline-menu', function(e) {
-    var data = e.getNodeData('phui-timeline-menu');
+  JX.Stratcom.listen('click', 'phui-dropdown-menu', function(e) {
+    var data = e.getNodeData('phui-dropdown-menu');
     if (data.menu) {
       return;
     }
@@ -18,7 +18,7 @@ JX.behavior('phui-timeline-dropdown-menu', function() {
 
     var list = JX.$H(data.items).getFragment().firstChild;
 
-    var icon = e.getNode('phui-timeline-menu');
+    var icon = e.getNode('phui-dropdown-menu');
     data.menu = new JX.PHUIXDropdownMenu(icon);
     data.menu.setContent(list);
     data.menu.open();

From 01a8ba5a9798fcf7f1136885da388e97b8653fdb Mon Sep 17 00:00:00 2001
From: Bob Trahan <btrahan@phacility.com>
Date: Tue, 19 May 2015 12:33:55 -0700
Subject: [PATCH 57/86] Transactions - make TYPE_COMMENT implementation
 optional

Summary: Ref T6403. Conpherence keeps track of comments for message counts so we needed some special attention there. Otherwise, straight-forward.

Test Plan: left a comment on a diff with inline comments. sent messages in conpherence successfully. verified unread count incremented correctly for sent messages for users.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6403

Differential Revision: https://secure.phabricator.com/D12932
---
 .../audit/editor/PhabricatorAuditEditor.php      |  2 --
 .../editor/PhabricatorCalendarEventEditor.php    |  2 --
 .../conpherence/editor/ConpherenceEditor.php     | 16 +++++++++++++---
 .../editor/DifferentialTransactionEditor.php     |  2 --
 .../paste/editor/PhabricatorPasteEditor.php      |  3 ---
 .../PhabricatorApplicationTransactionEditor.php  |  2 ++
 6 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/src/applications/audit/editor/PhabricatorAuditEditor.php b/src/applications/audit/editor/PhabricatorAuditEditor.php
index f3e7bdebb0..c628286a92 100644
--- a/src/applications/audit/editor/PhabricatorAuditEditor.php
+++ b/src/applications/audit/editor/PhabricatorAuditEditor.php
@@ -115,7 +115,6 @@ final class PhabricatorAuditEditor
     PhabricatorApplicationTransaction $xaction) {
 
     switch ($xaction->getTransactionType()) {
-      case PhabricatorTransactions::TYPE_COMMENT:
       case PhabricatorAuditActionConstants::ACTION:
       case PhabricatorAuditActionConstants::INLINE:
       case PhabricatorAuditActionConstants::ADD_AUDITORS:
@@ -131,7 +130,6 @@ final class PhabricatorAuditEditor
     PhabricatorApplicationTransaction $xaction) {
 
     switch ($xaction->getTransactionType()) {
-      case PhabricatorTransactions::TYPE_COMMENT:
       case PhabricatorAuditActionConstants::ACTION:
       case PhabricatorAuditTransaction::TYPE_COMMIT:
         return;
diff --git a/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php b/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
index 3e3b68d08f..bb4c772012 100644
--- a/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
+++ b/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
@@ -108,7 +108,6 @@ final class PhabricatorCalendarEventEditor
         $object->setIsAllDay((int)$xaction->getNewValue());
         return;
       case PhabricatorCalendarEventTransaction::TYPE_INVITE:
-      case PhabricatorTransactions::TYPE_COMMENT:
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
         return;
@@ -149,7 +148,6 @@ final class PhabricatorCalendarEventEditor
         }
         $object->attachInvitees($invitees);
         return;
-      case PhabricatorTransactions::TYPE_COMMENT:
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
         return;
diff --git a/src/applications/conpherence/editor/ConpherenceEditor.php b/src/applications/conpherence/editor/ConpherenceEditor.php
index ef68c2cff8..d44ebf912b 100644
--- a/src/applications/conpherence/editor/ConpherenceEditor.php
+++ b/src/applications/conpherence/editor/ConpherenceEditor.php
@@ -247,9 +247,6 @@ final class ConpherenceEditor extends PhabricatorApplicationTransactionEditor {
 
     $make_author_recent_participant = true;
     switch ($xaction->getTransactionType()) {
-      case PhabricatorTransactions::TYPE_COMMENT:
-        $object->setMessageCount((int)$object->getMessageCount() + 1);
-        break;
       case ConpherenceTransactionType::TYPE_TITLE:
         $object->setTitle($xaction->getNewValue());
         break;
@@ -296,6 +293,19 @@ final class ConpherenceEditor extends PhabricatorApplicationTransactionEditor {
     }
   }
 
+  protected function applyBuiltinInternalTransaction(
+    PhabricatorLiskDAO $object,
+    PhabricatorApplicationTransaction $xaction) {
+
+    switch ($xaction->getTransactionType()) {
+      case PhabricatorTransactions::TYPE_COMMENT:
+        $object->setMessageCount((int)$object->getMessageCount() + 1);
+        break;
+    }
+
+    return parent::applyBuiltinInternalTransaction($object, $xaction);
+  }
+
   private function makeAuthorMostRecentParticipant(
     PhabricatorLiskDAO $object,
     PhabricatorApplicationTransaction $xaction) {
diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php
index 24ffbb9031..4534123b24 100644
--- a/src/applications/differential/editor/DifferentialTransactionEditor.php
+++ b/src/applications/differential/editor/DifferentialTransactionEditor.php
@@ -195,7 +195,6 @@ final class DifferentialTransactionEditor
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
         $object->setEditPolicy($xaction->getNewValue());
         return;
-      case PhabricatorTransactions::TYPE_COMMENT:
       case DifferentialTransaction::TYPE_INLINE:
         return;
       case DifferentialTransaction::TYPE_UPDATE:
@@ -577,7 +576,6 @@ final class DifferentialTransactionEditor
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
         return;
-      case PhabricatorTransactions::TYPE_COMMENT:
       case DifferentialTransaction::TYPE_ACTION:
         return;
       case DifferentialTransaction::TYPE_INLINE:
diff --git a/src/applications/paste/editor/PhabricatorPasteEditor.php b/src/applications/paste/editor/PhabricatorPasteEditor.php
index 0d64017421..7e6a18db44 100644
--- a/src/applications/paste/editor/PhabricatorPasteEditor.php
+++ b/src/applications/paste/editor/PhabricatorPasteEditor.php
@@ -88,8 +88,6 @@ final class PhabricatorPasteEditor
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
         $object->setEditPolicy($xaction->getNewValue());
         return;
-      case PhabricatorTransactions::TYPE_COMMENT:
-        return;
     }
 
     return parent::applyCustomInternalTransaction($object, $xaction);
@@ -105,7 +103,6 @@ final class PhabricatorPasteEditor
       case PhabricatorPasteTransaction::TYPE_LANGUAGE:
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
-      case PhabricatorTransactions::TYPE_COMMENT:
         return;
     }
 
diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
index 11c11e1cc9..486a20a918 100644
--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
@@ -404,6 +404,7 @@ abstract class PhabricatorApplicationTransactionEditor
       case PhabricatorTransactions::TYPE_SUBSCRIBERS:
       case PhabricatorTransactions::TYPE_INLINESTATE:
       case PhabricatorTransactions::TYPE_EDGE:
+      case PhabricatorTransactions::TYPE_COMMENT:
         return $this->applyBuiltinInternalTransaction($object, $xaction);
     }
 
@@ -500,6 +501,7 @@ abstract class PhabricatorApplicationTransactionEditor
         $field = $this->getCustomFieldForTransaction($object, $xaction);
         return $field->applyApplicationTransactionExternalEffects($xaction);
       case PhabricatorTransactions::TYPE_INLINESTATE:
+      case PhabricatorTransactions::TYPE_COMMENT:
         return $this->applyBuiltinExternalTransaction($object, $xaction);
     }
 

From 81a475d5a6b48661ee518d0c30ddeed4e78142a0 Mon Sep 17 00:00:00 2001
From: Bob Trahan <btrahan@phacility.com>
Date: Tue, 19 May 2015 12:58:18 -0700
Subject: [PATCH 58/86] Transactions - make implementing TYPE_XXXX_POLICY
 transactions optional

Summary: Ref T6403. This was actually simple stuff.

Test Plan: changed the edit policy of a paste. changed the edit and join policy of a phame blog.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6403

Differential Revision: https://secure.phabricator.com/D12933
---
 .../almanac/editor/AlmanacDeviceEditor.php    |  5 ----
 .../almanac/editor/AlmanacNetworkEditor.php   |  5 ----
 .../almanac/editor/AlmanacServiceEditor.php   |  5 ----
 .../editor/PhabricatorCalendarEventEditor.php |  5 ----
 ...ricatorDashboardPanelTransactionEditor.php |  8 -----
 .../PhabricatorDashboardTransactionEditor.php |  8 -----
 .../editor/DifferentialDiffEditor.php         |  4 ---
 .../editor/DifferentialTransactionEditor.php  | 15 ----------
 .../files/editor/PhabricatorFileEditor.php    |  3 --
 .../fund/editor/FundInitiativeEditor.php      |  6 ----
 .../PassphraseCredentialTransactionEditor.php |  8 -----
 .../paste/editor/PhabricatorPasteEditor.php   |  8 -----
 .../phame/editor/PhameBlogEditor.php          | 12 --------
 .../phlux/editor/PhluxVariableEditor.php      |  8 -----
 .../editor/PhortuneMerchantEditor.php         |  3 --
 .../PhabricatorProjectTransactionEditor.php   | 12 --------
 ...habricatorApplicationTransactionEditor.php | 29 ++++++++++++-------
 17 files changed, 18 insertions(+), 126 deletions(-)

diff --git a/src/applications/almanac/editor/AlmanacDeviceEditor.php b/src/applications/almanac/editor/AlmanacDeviceEditor.php
index 211788e441..82263e66c4 100644
--- a/src/applications/almanac/editor/AlmanacDeviceEditor.php
+++ b/src/applications/almanac/editor/AlmanacDeviceEditor.php
@@ -55,8 +55,6 @@ final class AlmanacDeviceEditor
         $object->setName($xaction->getNewValue());
         return;
       case AlmanacDeviceTransaction::TYPE_INTERFACE:
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
         return;
     }
 
@@ -69,9 +67,6 @@ final class AlmanacDeviceEditor
 
     switch ($xaction->getTransactionType()) {
       case AlmanacDeviceTransaction::TYPE_NAME:
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
-        return;
       case AlmanacDeviceTransaction::TYPE_INTERFACE:
         $old = $xaction->getOldValue();
         if ($old) {
diff --git a/src/applications/almanac/editor/AlmanacNetworkEditor.php b/src/applications/almanac/editor/AlmanacNetworkEditor.php
index 81f0e63d46..4e49cce163 100644
--- a/src/applications/almanac/editor/AlmanacNetworkEditor.php
+++ b/src/applications/almanac/editor/AlmanacNetworkEditor.php
@@ -52,9 +52,6 @@ final class AlmanacNetworkEditor
       case AlmanacNetworkTransaction::TYPE_NAME:
         $object->setName($xaction->getNewValue());
         return;
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
-        return;
     }
 
     return parent::applyCustomInternalTransaction($object, $xaction);
@@ -66,8 +63,6 @@ final class AlmanacNetworkEditor
 
     switch ($xaction->getTransactionType()) {
       case AlmanacNetworkTransaction::TYPE_NAME:
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
         return;
     }
 
diff --git a/src/applications/almanac/editor/AlmanacServiceEditor.php b/src/applications/almanac/editor/AlmanacServiceEditor.php
index 928696dbcd..868f31d026 100644
--- a/src/applications/almanac/editor/AlmanacServiceEditor.php
+++ b/src/applications/almanac/editor/AlmanacServiceEditor.php
@@ -61,9 +61,6 @@ final class AlmanacServiceEditor
       case AlmanacServiceTransaction::TYPE_LOCK:
         $object->setIsLocked((int)$xaction->getNewValue());
         return;
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
-        return;
     }
 
     return parent::applyCustomInternalTransaction($object, $xaction);
@@ -75,8 +72,6 @@ final class AlmanacServiceEditor
 
     switch ($xaction->getTransactionType()) {
       case AlmanacServiceTransaction::TYPE_NAME:
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
         return;
       case AlmanacServiceTransaction::TYPE_LOCK:
         $service = id(new AlmanacServiceQuery())
diff --git a/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php b/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
index bb4c772012..203f29222b 100644
--- a/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
+++ b/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
@@ -108,8 +108,6 @@ final class PhabricatorCalendarEventEditor
         $object->setIsAllDay((int)$xaction->getNewValue());
         return;
       case PhabricatorCalendarEventTransaction::TYPE_INVITE:
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
         return;
     }
 
@@ -148,9 +146,6 @@ final class PhabricatorCalendarEventEditor
         }
         $object->attachInvitees($invitees);
         return;
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
-        return;
     }
 
     return parent::applyCustomExternalTransaction($object, $xaction);
diff --git a/src/applications/dashboard/editor/PhabricatorDashboardPanelTransactionEditor.php b/src/applications/dashboard/editor/PhabricatorDashboardPanelTransactionEditor.php
index 6f76e2618e..2a56721442 100644
--- a/src/applications/dashboard/editor/PhabricatorDashboardPanelTransactionEditor.php
+++ b/src/applications/dashboard/editor/PhabricatorDashboardPanelTransactionEditor.php
@@ -62,12 +62,6 @@ final class PhabricatorDashboardPanelTransactionEditor
       case PhabricatorDashboardPanelTransaction::TYPE_ARCHIVE:
         $object->setIsArchived((int)$xaction->getNewValue());
         return;
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-        $object->setViewPolicy($xaction->getNewValue());
-        return;
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
-        $object->setEditPolicy($xaction->getNewValue());
-        return;
     }
 
     return parent::applyCustomInternalTransaction($object, $xaction);
@@ -80,8 +74,6 @@ final class PhabricatorDashboardPanelTransactionEditor
     switch ($xaction->getTransactionType()) {
       case PhabricatorDashboardPanelTransaction::TYPE_NAME:
       case PhabricatorDashboardPanelTransaction::TYPE_ARCHIVE:
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
         return;
     }
 
diff --git a/src/applications/dashboard/editor/PhabricatorDashboardTransactionEditor.php b/src/applications/dashboard/editor/PhabricatorDashboardTransactionEditor.php
index ed16a22a9c..4b1b6533d6 100644
--- a/src/applications/dashboard/editor/PhabricatorDashboardTransactionEditor.php
+++ b/src/applications/dashboard/editor/PhabricatorDashboardTransactionEditor.php
@@ -109,12 +109,6 @@ final class PhabricatorDashboardTransactionEditor
         }
         $object->setLayoutConfigFromObject($new_layout);
         return;
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-        $object->setViewPolicy($xaction->getNewValue());
-        return;
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
-        $object->setEditPolicy($xaction->getNewValue());
-        return;
     }
 
     return parent::applyCustomInternalTransaction($object, $xaction);
@@ -127,8 +121,6 @@ final class PhabricatorDashboardTransactionEditor
     switch ($xaction->getTransactionType()) {
       case PhabricatorDashboardTransaction::TYPE_NAME:
       case PhabricatorDashboardTransaction::TYPE_LAYOUT_MODE:
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
         return;
     }
 
diff --git a/src/applications/differential/editor/DifferentialDiffEditor.php b/src/applications/differential/editor/DifferentialDiffEditor.php
index 25385899b1..235ab84c21 100644
--- a/src/applications/differential/editor/DifferentialDiffEditor.php
+++ b/src/applications/differential/editor/DifferentialDiffEditor.php
@@ -62,9 +62,6 @@ final class DifferentialDiffEditor
         $dict = $this->diffDataDict;
         $this->updateDiffFromDict($object, $dict);
         return;
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-        $object->setViewPolicy($xaction->getNewValue());
-        return;
     }
 
     return parent::applyCustomInternalTransaction($object, $xaction);
@@ -76,7 +73,6 @@ final class DifferentialDiffEditor
 
     switch ($xaction->getTransactionType()) {
       case DifferentialDiffTransaction::TYPE_DIFF_CREATE:
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
         return;
     }
 
diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php
index 4534123b24..d195d91833 100644
--- a/src/applications/differential/editor/DifferentialTransactionEditor.php
+++ b/src/applications/differential/editor/DifferentialTransactionEditor.php
@@ -71,10 +71,6 @@ final class DifferentialTransactionEditor
     PhabricatorApplicationTransaction $xaction) {
 
     switch ($xaction->getTransactionType()) {
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-        return $object->getViewPolicy();
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
-        return $object->getEditPolicy();
       case DifferentialTransaction::TYPE_ACTION:
         return null;
       case DifferentialTransaction::TYPE_INLINE:
@@ -95,8 +91,6 @@ final class DifferentialTransactionEditor
     PhabricatorApplicationTransaction $xaction) {
 
     switch ($xaction->getTransactionType()) {
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
       case DifferentialTransaction::TYPE_ACTION:
       case DifferentialTransaction::TYPE_UPDATE:
         return $xaction->getNewValue();
@@ -189,12 +183,6 @@ final class DifferentialTransactionEditor
     $status_abandoned = ArcanistDifferentialRevisionStatus::ABANDONED;
 
     switch ($xaction->getTransactionType()) {
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-        $object->setViewPolicy($xaction->getNewValue());
-        return;
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
-        $object->setEditPolicy($xaction->getNewValue());
-        return;
       case DifferentialTransaction::TYPE_INLINE:
         return;
       case DifferentialTransaction::TYPE_UPDATE:
@@ -573,9 +561,6 @@ final class DifferentialTransactionEditor
     PhabricatorApplicationTransaction $xaction) {
 
     switch ($xaction->getTransactionType()) {
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
-        return;
       case DifferentialTransaction::TYPE_ACTION:
         return;
       case DifferentialTransaction::TYPE_INLINE:
diff --git a/src/applications/files/editor/PhabricatorFileEditor.php b/src/applications/files/editor/PhabricatorFileEditor.php
index a611e3da3f..9cd81a4c1e 100644
--- a/src/applications/files/editor/PhabricatorFileEditor.php
+++ b/src/applications/files/editor/PhabricatorFileEditor.php
@@ -47,9 +47,6 @@ final class PhabricatorFileEditor
     PhabricatorApplicationTransaction $xaction) {
 
     switch ($xaction->getTransactionType()) {
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-        $object->setViewPolicy($xaction->getNewValue());
-        break;
       case PhabricatorFileTransaction::TYPE_NAME:
         $object->setName($xaction->getNewValue());
         break;
diff --git a/src/applications/fund/editor/FundInitiativeEditor.php b/src/applications/fund/editor/FundInitiativeEditor.php
index 13296be13f..679e1b5771 100644
--- a/src/applications/fund/editor/FundInitiativeEditor.php
+++ b/src/applications/fund/editor/FundInitiativeEditor.php
@@ -102,9 +102,6 @@ final class FundInitiativeEditor
 
         $object->setTotalAsCurrency($total);
         return;
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
-        return;
     }
 
     return parent::applyCustomInternalTransaction($object, $xaction);
@@ -154,9 +151,6 @@ final class FundInitiativeEditor
 
         $editor->applyTransactions($backer, $subx);
         return;
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
-        return;
     }
 
     return parent::applyCustomExternalTransaction($object, $xaction);
diff --git a/src/applications/passphrase/editor/PassphraseCredentialTransactionEditor.php b/src/applications/passphrase/editor/PassphraseCredentialTransactionEditor.php
index 3fbe35c249..aacc89c027 100644
--- a/src/applications/passphrase/editor/PassphraseCredentialTransactionEditor.php
+++ b/src/applications/passphrase/editor/PassphraseCredentialTransactionEditor.php
@@ -108,12 +108,6 @@ final class PassphraseCredentialTransactionEditor
           }
         }
         return;
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-        $object->setViewPolicy($xaction->getNewValue());
-        return;
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
-        $object->setEditPolicy($xaction->getNewValue());
-        return;
       case PassphraseCredentialTransaction::TYPE_LOOKEDATSECRET:
         return;
       case PassphraseCredentialTransaction::TYPE_LOCK:
@@ -140,8 +134,6 @@ final class PassphraseCredentialTransactionEditor
       case PassphraseCredentialTransaction::TYPE_LOOKEDATSECRET:
       case PassphraseCredentialTransaction::TYPE_LOCK:
       case PassphraseCredentialTransaction::TYPE_CONDUIT:
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
         return;
     }
 
diff --git a/src/applications/paste/editor/PhabricatorPasteEditor.php b/src/applications/paste/editor/PhabricatorPasteEditor.php
index 7e6a18db44..9c966bf724 100644
--- a/src/applications/paste/editor/PhabricatorPasteEditor.php
+++ b/src/applications/paste/editor/PhabricatorPasteEditor.php
@@ -82,12 +82,6 @@ final class PhabricatorPasteEditor
       case PhabricatorPasteTransaction::TYPE_LANGUAGE:
         $object->setLanguage($xaction->getNewValue());
         return;
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-        $object->setViewPolicy($xaction->getNewValue());
-        return;
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
-        $object->setEditPolicy($xaction->getNewValue());
-        return;
     }
 
     return parent::applyCustomInternalTransaction($object, $xaction);
@@ -101,8 +95,6 @@ final class PhabricatorPasteEditor
       case PhabricatorPasteTransaction::TYPE_CONTENT:
       case PhabricatorPasteTransaction::TYPE_TITLE:
       case PhabricatorPasteTransaction::TYPE_LANGUAGE:
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
         return;
     }
 
diff --git a/src/applications/phame/editor/PhameBlogEditor.php b/src/applications/phame/editor/PhameBlogEditor.php
index f44be159c8..289b55cf57 100644
--- a/src/applications/phame/editor/PhameBlogEditor.php
+++ b/src/applications/phame/editor/PhameBlogEditor.php
@@ -67,15 +67,6 @@ final class PhameBlogEditor
         return $object->setDomain($xaction->getNewValue());
       case PhameBlogTransaction::TYPE_SKIN:
         return $object->setSkin($xaction->getNewValue());
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-        $object->setViewPolicy($xaction->getNewValue());
-        return;
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
-        $object->setEditPolicy($xaction->getNewValue());
-        return;
-      case PhabricatorTransactions::TYPE_JOIN_POLICY:
-        $object->setJoinPolicy($xaction->getNewValue());
-        return;
     }
 
     return parent::applyCustomInternalTransaction($object, $xaction);
@@ -90,9 +81,6 @@ final class PhameBlogEditor
       case PhameBlogTransaction::TYPE_DESCRIPTION:
       case PhameBlogTransaction::TYPE_DOMAIN:
       case PhameBlogTransaction::TYPE_SKIN:
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
-      case PhabricatorTransactions::TYPE_JOIN_POLICY:
         return;
     }
 
diff --git a/src/applications/phlux/editor/PhluxVariableEditor.php b/src/applications/phlux/editor/PhluxVariableEditor.php
index 9745ee50c8..2e36ba8162 100644
--- a/src/applications/phlux/editor/PhluxVariableEditor.php
+++ b/src/applications/phlux/editor/PhluxVariableEditor.php
@@ -54,12 +54,6 @@ final class PhluxVariableEditor
       case PhluxTransaction::TYPE_EDIT_VALUE:
         $object->setVariableValue($xaction->getNewValue());
         return;
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-        $object->setViewPolicy($xaction->getNewValue());
-        return;
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
-        $object->setEditPolicy($xaction->getNewValue());
-        return;
     }
     return parent::applyCustomInternalTransaction($object, $xaction);
   }
@@ -70,8 +64,6 @@ final class PhluxVariableEditor
     switch ($xaction->getTransactionType()) {
       case PhluxTransaction::TYPE_EDIT_KEY:
       case PhluxTransaction::TYPE_EDIT_VALUE:
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
         return;
     }
     return parent::applyCustomExternalTransaction($object, $xaction);
diff --git a/src/applications/phortune/editor/PhortuneMerchantEditor.php b/src/applications/phortune/editor/PhortuneMerchantEditor.php
index ae8c1fda54..1c659c0d5f 100644
--- a/src/applications/phortune/editor/PhortuneMerchantEditor.php
+++ b/src/applications/phortune/editor/PhortuneMerchantEditor.php
@@ -59,8 +59,6 @@ final class PhortuneMerchantEditor
       case PhortuneMerchantTransaction::TYPE_DESCRIPTION:
         $object->setDescription($xaction->getNewValue());
         return;
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-        return;
     }
 
     return parent::applyCustomInternalTransaction($object, $xaction);
@@ -73,7 +71,6 @@ final class PhortuneMerchantEditor
     switch ($xaction->getTransactionType()) {
       case PhortuneMerchantTransaction::TYPE_NAME:
       case PhortuneMerchantTransaction::TYPE_DESCRIPTION:
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
         return;
     }
 
diff --git a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
index 348ba53c4d..307e186dbd 100644
--- a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
+++ b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
@@ -102,15 +102,6 @@ final class PhabricatorProjectTransactionEditor
       case PhabricatorProjectTransaction::TYPE_LOCKED:
         $object->setIsMembershipLocked($xaction->getNewValue());
         return;
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-        $object->setViewPolicy($xaction->getNewValue());
-        return;
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
-        $object->setEditPolicy($xaction->getNewValue());
-        return;
-      case PhabricatorTransactions::TYPE_JOIN_POLICY:
-        $object->setJoinPolicy($xaction->getNewValue());
-        return;
     }
 
     return parent::applyCustomInternalTransaction($object, $xaction);
@@ -157,9 +148,6 @@ final class PhabricatorProjectTransactionEditor
         }
 
         return;
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
-      case PhabricatorTransactions::TYPE_JOIN_POLICY:
       case PhabricatorProjectTransaction::TYPE_STATUS:
       case PhabricatorProjectTransaction::TYPE_IMAGE:
       case PhabricatorProjectTransaction::TYPE_ICON:
diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
index 486a20a918..0329613b0e 100644
--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
@@ -388,19 +388,12 @@ abstract class PhabricatorApplicationTransactionEditor
       case PhabricatorTransactions::TYPE_BUILDABLE:
       case PhabricatorTransactions::TYPE_TOKEN:
         return;
-      case PhabricatorTransactions::TYPE_VIEW_POLICY:
-        $object->setViewPolicy($xaction->getNewValue());
-        break;
-      case PhabricatorTransactions::TYPE_EDIT_POLICY:
-        $object->setEditPolicy($xaction->getNewValue());
-        break;
-      case PhabricatorTransactions::TYPE_JOIN_POLICY:
-        $object->setJoinPolicy($xaction->getNewValue());
-        break;
-
       case PhabricatorTransactions::TYPE_CUSTOMFIELD:
         $field = $this->getCustomFieldForTransaction($object, $xaction);
         return $field->applyApplicationTransactionInternalEffects($xaction);
+      case PhabricatorTransactions::TYPE_VIEW_POLICY:
+      case PhabricatorTransactions::TYPE_EDIT_POLICY:
+      case PhabricatorTransactions::TYPE_JOIN_POLICY:
       case PhabricatorTransactions::TYPE_SUBSCRIBERS:
       case PhabricatorTransactions::TYPE_INLINESTATE:
       case PhabricatorTransactions::TYPE_EDGE:
@@ -500,6 +493,9 @@ abstract class PhabricatorApplicationTransactionEditor
       case PhabricatorTransactions::TYPE_CUSTOMFIELD:
         $field = $this->getCustomFieldForTransaction($object, $xaction);
         return $field->applyApplicationTransactionExternalEffects($xaction);
+      case PhabricatorTransactions::TYPE_VIEW_POLICY:
+      case PhabricatorTransactions::TYPE_EDIT_POLICY:
+      case PhabricatorTransactions::TYPE_JOIN_POLICY:
       case PhabricatorTransactions::TYPE_INLINESTATE:
       case PhabricatorTransactions::TYPE_COMMENT:
         return $this->applyBuiltinExternalTransaction($object, $xaction);
@@ -534,7 +530,18 @@ abstract class PhabricatorApplicationTransactionEditor
   protected function applyBuiltinInternalTransaction(
     PhabricatorLiskDAO $object,
     PhabricatorApplicationTransaction $xaction) {
-    return;
+
+    switch ($xaction->getTransactionType()) {
+      case PhabricatorTransactions::TYPE_VIEW_POLICY:
+        $object->setViewPolicy($xaction->getNewValue());
+        break;
+      case PhabricatorTransactions::TYPE_EDIT_POLICY:
+        $object->setEditPolicy($xaction->getNewValue());
+        break;
+      case PhabricatorTransactions::TYPE_JOIN_POLICY:
+        $object->setJoinPolicy($xaction->getNewValue());
+        break;
+    }
   }
 
   protected function applyBuiltinExternalTransaction(

From 3845057efb8b8e7edd5984e8ca525f6f592c3e0f Mon Sep 17 00:00:00 2001
From: lkassianik <lyubakassianik@gmail.com>
Date: Tue, 19 May 2015 13:09:28 -0700
Subject: [PATCH 59/86] Calendar events should actually have an icon now.

Summary: Ref T7936, Calendar events should actually have an icon now.

Test Plan: Edit event, edit icon, save, observe transaction feed.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T7936

Differential Revision: https://secure.phabricator.com/D12934
---
 resources/celerity/map.php                    |  2 ++
 .../20150519.calendar.calendaricon.sql        |  5 +++
 ...PhabricatorCalendarEventEditController.php | 27 ++++++++++++++--
 ...PhabricatorCalendarEventViewController.php |  6 ++++
 .../editor/PhabricatorCalendarEventEditor.php | 12 ++++++-
 .../calendar/icon/PhabricatorCalendarIcon.php | 32 +++++++++----------
 .../storage/PhabricatorCalendarEvent.php      |  5 +++
 .../PhabricatorCalendarEventTransaction.php   | 16 ++++++++++
 8 files changed, 85 insertions(+), 20 deletions(-)
 create mode 100644 resources/sql/autopatches/20150519.calendar.calendaricon.sql

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 1769c81f76..c2b79e7a10 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -38,6 +38,7 @@ return array(
     'rsrc/css/application/base/notification-menu.css' => '3c9d8aa1',
     'rsrc/css/application/base/phabricator-application-launch-view.css' => '16ca323f',
     'rsrc/css/application/base/standard-page-view.css' => '61e68a55',
+    'rsrc/css/application/calendar/calendar-icon.css' => '98ce946d',
     'rsrc/css/application/chatlog/chatlog.css' => '852140ff',
     'rsrc/css/application/conduit/conduit-api.css' => '7bc725c4',
     'rsrc/css/application/config/config-options.css' => '7fedf08b',
@@ -492,6 +493,7 @@ return array(
     'aphront-two-column-view-css' => '16ab3ad2',
     'aphront-typeahead-control-css' => '0e403212',
     'auth-css' => '44975d4b',
+    'calendar-icon-css' => '98ce946d',
     'changeset-view-manager' => '58562350',
     'conduit-api-css' => '7bc725c4',
     'config-options-css' => '7fedf08b',
diff --git a/resources/sql/autopatches/20150519.calendar.calendaricon.sql b/resources/sql/autopatches/20150519.calendar.calendaricon.sql
new file mode 100644
index 0000000000..d91520df0a
--- /dev/null
+++ b/resources/sql/autopatches/20150519.calendar.calendaricon.sql
@@ -0,0 +1,5 @@
+ALTER TABLE {$NAMESPACE}_calendar.calendar_event
+  ADD COLUMN icon VARCHAR(32) COLLATE {$COLLATE_TEXT} NOT NULL;
+
+UPDATE {$NAMESPACE}_calendar.calendar_event
+  SET icon = "fa-calendar" WHERE icon = "";
diff --git a/src/applications/calendar/controller/PhabricatorCalendarEventEditController.php b/src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
index 900b3ad56b..cf9797da45 100644
--- a/src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
+++ b/src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
@@ -13,8 +13,7 @@ final class PhabricatorCalendarEventEditController
     return !$this->id;
   }
 
-  public function processRequest() {
-    $request = $this->getRequest();
+  public function handleRequest(AphrontRequest $request) {
     $user = $request->getUser();
     $user_phid = $user->getPHID();
     $error_name = true;
@@ -74,6 +73,7 @@ final class PhabricatorCalendarEventEditController
     $name = $event->getName();
     $description = $event->getDescription();
     $is_all_day = $event->getIsAllDay();
+    $icon = $event->getIcon();
 
     $current_policies = id(new PhabricatorPolicyQuery())
       ->setViewer($user)
@@ -95,6 +95,7 @@ final class PhabricatorCalendarEventEditController
       $edit_policy = $request->getStr('editPolicy');
       $view_policy = $request->getStr('viewPolicy');
       $is_all_day = $request->getStr('isAllDay');
+      $icon = $request->getStr('icon');
 
       $invitees = $request->getArr('invitees');
       $new_invitees = $this->getNewInviteeList($invitees, $event);
@@ -116,6 +117,11 @@ final class PhabricatorCalendarEventEditController
           PhabricatorCalendarEventTransaction::TYPE_ALL_DAY)
         ->setNewValue($is_all_day);
 
+      $xactions[] = id(new PhabricatorCalendarEventTransaction())
+        ->setTransactionType(
+          PhabricatorCalendarEventTransaction::TYPE_ICON)
+        ->setNewValue($icon);
+
       $xactions[] = id(new PhabricatorCalendarEventTransaction())
         ->setTransactionType(
           PhabricatorCalendarEventTransaction::TYPE_START_DATE)
@@ -246,6 +252,20 @@ final class PhabricatorCalendarEventEditController
       ->setUser($user)
       ->setDatasource(new PhabricatorMetaMTAMailableDatasource());
 
+    if ($this->isCreate()) {
+      $icon_uri = $this->getApplicationURI('icon/');
+    } else {
+      $icon_uri = $this->getApplicationURI('icon/'.$event->getID().'/');
+    }
+    $icon_display = PhabricatorCalendarIcon::renderIconForChooser($icon);
+    $icon = id(new AphrontFormChooseButtonControl())
+      ->setLabel(pht('Icon'))
+      ->setName('icon')
+      ->setDisplayValue($icon_display)
+      ->setButtonText(pht('Choose Icon...'))
+      ->setChooseURI($icon_uri)
+      ->setValue($icon);
+
     $form = id(new AphrontFormView())
       ->setUser($user)
       ->appendChild($name)
@@ -256,7 +276,8 @@ final class PhabricatorCalendarEventEditController
       ->appendControl($edit_policies)
       ->appendControl($subscribers)
       ->appendControl($invitees)
-      ->appendChild($description);
+      ->appendChild($description)
+      ->appendChild($icon);
 
 
     if ($request->isAjax()) {
diff --git a/src/applications/calendar/controller/PhabricatorCalendarEventViewController.php b/src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
index 742ec95e3f..656446c2a3 100644
--- a/src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
+++ b/src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
@@ -264,6 +264,12 @@ final class PhabricatorCalendarEventViewController
 
     $properties->invokeWillRenderEvent();
 
+    $icon_display = PhabricatorCalendarIcon::renderIconForChooser(
+      $event->getIcon());
+    $properties->addProperty(
+      pht('Icon'),
+      $icon_display);
+
     $properties->addSectionHeader(
       pht('Description'),
       PHUIPropertyListView::ICON_SUMMARY);
diff --git a/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php b/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
index 203f29222b..291f6c1865 100644
--- a/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
+++ b/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
@@ -21,6 +21,7 @@ final class PhabricatorCalendarEventEditor
     $types[] = PhabricatorCalendarEventTransaction::TYPE_CANCEL;
     $types[] = PhabricatorCalendarEventTransaction::TYPE_INVITE;
     $types[] = PhabricatorCalendarEventTransaction::TYPE_ALL_DAY;
+    $types[] = PhabricatorCalendarEventTransaction::TYPE_ICON;
 
     $types[] = PhabricatorTransactions::TYPE_COMMENT;
     $types[] = PhabricatorTransactions::TYPE_VIEW_POLICY;
@@ -45,6 +46,8 @@ final class PhabricatorCalendarEventEditor
         return $object->getIsCancelled();
       case PhabricatorCalendarEventTransaction::TYPE_ALL_DAY:
         return (int)$object->getIsAllDay();
+      case PhabricatorCalendarEventTransaction::TYPE_ICON:
+        return $object->getIcon();
       case PhabricatorCalendarEventTransaction::TYPE_INVITE:
         $map = $xaction->getNewValue();
         $phids = array_keys($map);
@@ -73,6 +76,7 @@ final class PhabricatorCalendarEventEditor
       case PhabricatorCalendarEventTransaction::TYPE_DESCRIPTION:
       case PhabricatorCalendarEventTransaction::TYPE_CANCEL:
       case PhabricatorCalendarEventTransaction::TYPE_INVITE:
+      case PhabricatorCalendarEventTransaction::TYPE_ICON:
         return $xaction->getNewValue();
       case PhabricatorCalendarEventTransaction::TYPE_ALL_DAY:
         return (int)$xaction->getNewValue();
@@ -107,6 +111,9 @@ final class PhabricatorCalendarEventEditor
       case PhabricatorCalendarEventTransaction::TYPE_ALL_DAY:
         $object->setIsAllDay((int)$xaction->getNewValue());
         return;
+      case PhabricatorCalendarEventTransaction::TYPE_ICON:
+        $object->setIcon($xaction->getNewValue());
+        return;
       case PhabricatorCalendarEventTransaction::TYPE_INVITE:
         return;
     }
@@ -125,6 +132,7 @@ final class PhabricatorCalendarEventEditor
       case PhabricatorCalendarEventTransaction::TYPE_DESCRIPTION:
       case PhabricatorCalendarEventTransaction::TYPE_CANCEL:
       case PhabricatorCalendarEventTransaction::TYPE_ALL_DAY:
+      case PhabricatorCalendarEventTransaction::TYPE_ICON:
         return;
       case PhabricatorCalendarEventTransaction::TYPE_INVITE:
         $map = $xaction->getNewValue();
@@ -171,6 +179,8 @@ final class PhabricatorCalendarEventEditor
     $invalidate_phids = array();
     foreach ($xactions as $xaction) {
       switch ($xaction->getTransactionType()) {
+        case PhabricatorCalendarEventTransaction::TYPE_ICON:
+          break;
         case PhabricatorCalendarEventTransaction::TYPE_START_DATE:
         case PhabricatorCalendarEventTransaction::TYPE_END_DATE:
         case PhabricatorCalendarEventTransaction::TYPE_CANCEL:
@@ -329,7 +339,7 @@ final class PhabricatorCalendarEventEditor
       PhabricatorCalendarEventTransaction::MAILTAG_CONTENT =>
         pht(
           "An event's name, status, invite list, ".
-          "and description changes."),
+          "icon, and description changes."),
       PhabricatorCalendarEventTransaction::MAILTAG_RESCHEDULE =>
         pht(
           "An event's start and end date ".
diff --git a/src/applications/calendar/icon/PhabricatorCalendarIcon.php b/src/applications/calendar/icon/PhabricatorCalendarIcon.php
index 904ffee761..9ba4b00c01 100644
--- a/src/applications/calendar/icon/PhabricatorCalendarIcon.php
+++ b/src/applications/calendar/icon/PhabricatorCalendarIcon.php
@@ -5,22 +5,22 @@ final class PhabricatorCalendarIcon extends Phobject {
   public static function getIconMap() {
     return
       array(
-        'fa-briefcase' => pht('Briefcase'),
-        'fa-tags' => pht('Tag'),
-        'fa-folder' => pht('Folder'),
-        'fa-users' => pht('Team'),
-        'fa-bug' => pht('Bug'),
-        'fa-trash-o' => pht('Garbage'),
-        'fa-calendar' => pht('Deadline'),
-        'fa-flag-checkered' => pht('Goal'),
-        'fa-envelope' => pht('Communication'),
-        'fa-truck' => pht('Release'),
-        'fa-lock' => pht('Policy'),
-        'fa-umbrella' => pht('An Umbrella'),
-        'fa-cloud' => pht('The Cloud'),
-        'fa-building' => pht('Company'),
-        'fa-credit-card' => pht('Accounting'),
-        'fa-flask' => pht('Experimental'),
+        'fa-calendar' => pht('Default'),
+        'fa-glass' => pht('Party'),
+        'fa-plane' => pht('Travel'),
+        'fa-plus-square' => pht('Health / Appointment'),
+        'fa-rocket' => pht('Sabatical / Leave'),
+        'fa-home' => pht('Working From Home'),
+        'fa-tree' => pht('Holiday'),
+        'fa-gamepad' => pht('Staycation'),
+        'fa-coffee' => pht('Coffee Meeting'),
+        'fa-film' => pht('Movie'),
+        'fa-users' => pht('Meeting'),
+        'fa-cutlery' => pht('Meal'),
+        'fa-paw' => pht('Pet Activity'),
+        'fa-institution' => pht('Official Business'),
+        'fa-bus' => pht('Field Trip'),
+        'fa-microphone' => pht('Conference'),
       );
   }
 
diff --git a/src/applications/calendar/storage/PhabricatorCalendarEvent.php b/src/applications/calendar/storage/PhabricatorCalendarEvent.php
index 42bf5f9e05..3055e5e4e6 100644
--- a/src/applications/calendar/storage/PhabricatorCalendarEvent.php
+++ b/src/applications/calendar/storage/PhabricatorCalendarEvent.php
@@ -17,11 +17,14 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO
   protected $description;
   protected $isCancelled;
   protected $isAllDay;
+  protected $icon;
   protected $mailKey;
 
   protected $viewPolicy;
   protected $editPolicy;
 
+  const DEFAULT_ICON = 'fa-calendar';
+
   private $invitees = self::ATTACHABLE;
   private $appliedViewer;
 
@@ -35,6 +38,7 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO
       ->setUserPHID($actor->getPHID())
       ->setIsCancelled(0)
       ->setIsAllDay(0)
+      ->setIcon(self::DEFAULT_ICON)
       ->setViewPolicy($actor->getPHID())
       ->setEditPolicy($actor->getPHID())
       ->attachInvitees(array())
@@ -166,6 +170,7 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO
         'description' => 'text',
         'isCancelled' => 'bool',
         'isAllDay' => 'bool',
+        'icon' => 'text32',
         'mailKey' => 'bytes20',
       ),
       self::CONFIG_KEY_SCHEMA => array(
diff --git a/src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php b/src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php
index 91b5d5231f..767208648e 100644
--- a/src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php
+++ b/src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php
@@ -9,6 +9,7 @@ final class PhabricatorCalendarEventTransaction
   const TYPE_DESCRIPTION = 'calendar.description';
   const TYPE_CANCEL = 'calendar.cancel';
   const TYPE_ALL_DAY = 'calendar.allday';
+  const TYPE_ICON = 'calendar.icon';
   const TYPE_INVITE = 'calendar.invite';
 
   const MAILTAG_RESCHEDULE = 'calendar-reschedule';
@@ -66,6 +67,8 @@ final class PhabricatorCalendarEventTransaction
 
   public function getIcon() {
     switch ($this->getTransactionType()) {
+      case self::TYPE_ICON:
+        return $this->getNewValue();
       case self::TYPE_NAME:
       case self::TYPE_START_DATE:
       case self::TYPE_END_DATE:
@@ -130,6 +133,12 @@ final class PhabricatorCalendarEventTransaction
             '%s converted this from an all day event.',
             $this->renderHandleLink($author_phid));
         }
+      case self::TYPE_ICON:
+        return pht(
+          '%s set this event\'s icon to %s.',
+          $this->renderHandleLink($author_phid),
+          PhabricatorCalendarIcon::getLabel($new));
+        break;
       case self::TYPE_CANCEL:
         if ($new) {
           return pht(
@@ -292,6 +301,12 @@ final class PhabricatorCalendarEventTransaction
             $this->renderHandleLink($author_phid),
             $this->renderHandleLink($object_phid));
         }
+      case self::TYPE_ICON:
+        return pht(
+          '%s set the icon for %s to %s.',
+          $this->renderHandleLink($author_phid),
+          $this->renderHandleLink($object_phid),
+          PhabricatorCalendarIcon::getLabel($new));
       case self::TYPE_CANCEL:
         if ($new) {
           return pht(
@@ -449,6 +464,7 @@ final class PhabricatorCalendarEventTransaction
       case self::TYPE_NAME:
       case self::TYPE_DESCRIPTION:
       case self::TYPE_INVITE:
+      case self::TYPE_ICON:
         $tags[] = self::MAILTAG_CONTENT;
         break;
       case self::TYPE_START_DATE:

From 596db64ee62c645af77270ac8e95ecbe565e5eac Mon Sep 17 00:00:00 2001
From: Bob Trahan <btrahan@phacility.com>
Date: Tue, 19 May 2015 13:20:04 -0700
Subject: [PATCH 60/86] Conpherence - make solo conversations be titled with
 viewer's name

Summary: Fixes T8251. I think this used to be "lucky handle" when it was all one giant terrible function, so restore previous functionality and have the title be the viewer's name in this case.

Test Plan: rocked a solo conpherence and saw my username as the title

Reviewers: chad, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8251

Differential Revision: https://secure.phabricator.com/D12935
---
 .../conpherence/storage/ConpherenceThread.php         | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/applications/conpherence/storage/ConpherenceThread.php b/src/applications/conpherence/storage/ConpherenceThread.php
index 8ed0e4fd18..36654713d5 100644
--- a/src/applications/conpherence/storage/ConpherenceThread.php
+++ b/src/applications/conpherence/storage/ConpherenceThread.php
@@ -231,9 +231,14 @@ final class ConpherenceThread extends ConpherenceDAO
     $handles = $this->getHandles();
     $phids = $this->getOtherRecentParticipantPHIDs($viewer);
 
-    $limit = 3;
-    $more = (count($phids) > $limit);
-    $phids = array_slice($phids, 0, $limit);
+    if (count($phids) == 0) {
+      $phids[] = $viewer->getPHID();
+      $more = false;
+    } else {
+      $limit = 3;
+      $more = (count($phids) > $limit);
+      $phids = array_slice($phids, 0, $limit);
+    }
 
     $names = array_select_keys($handles, $phids);
     $names = mpull($names, 'getName');

From 2f80c01236726b9266b180cde75b70206ea8751c Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@joshuaspence.com>
Date: Wed, 20 May 2015 06:58:25 +1000
Subject: [PATCH 61/86] Remove arcanist projects from DiffusionRequest

Summary: Ref T7604. This data is no longer used. Depends on D12894.

Test Plan: `grep`

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7604

Differential Revision: https://secure.phabricator.com/D12895
---
 .../diffusion/request/DiffusionRequest.php            | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/src/applications/diffusion/request/DiffusionRequest.php b/src/applications/diffusion/request/DiffusionRequest.php
index 69ea4938af..e7296e9cc1 100644
--- a/src/applications/diffusion/request/DiffusionRequest.php
+++ b/src/applications/diffusion/request/DiffusionRequest.php
@@ -22,7 +22,6 @@ abstract class DiffusionRequest {
   protected $repository;
   protected $repositoryCommit;
   protected $repositoryCommitData;
-  protected $arcanistProjects;
 
   private $isClusterRequest = false;
   private $initFromConduit = true;
@@ -401,16 +400,6 @@ abstract class DiffusionRequest {
     return $this->repositoryCommit;
   }
 
-  public function loadArcanistProjects() {
-    if (empty($this->arcanistProjects)) {
-      $projects = id(new PhabricatorRepositoryArcanistProject())->loadAllWhere(
-        'repositoryID = %d',
-        $this->getRepository()->getID());
-      $this->arcanistProjects = $projects;
-    }
-    return $this->arcanistProjects;
-  }
-
   public function loadCommitData() {
     if (empty($this->repositoryCommitData)) {
       $commit = $this->loadCommit();

From 16a8ed72bddaf459a02ee7cd95f232ad0045c05c Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@joshuaspence.com>
Date: Wed, 20 May 2015 06:59:58 +1000
Subject: [PATCH 62/86] Modernize search engine selection

Summary: Remove the `PhabricatorDefaultSearchEngineSelector` class. This is quite similar to D12053.

Test Plan: Went to `/view/PhabricatorSearchApplication/` and saw the storage engine configuration. Set `search.elastic.host` and saw the highlighted storage engine change.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D12670
---
 src/__phutil_library_map__.php                |   9 +-
 ...=> PhabricatorElasticSearchSetupCheck.php} |  13 ++-
 .../PhabricatorExtraConfigSetupCheck.php      |   4 +
 .../check/PhabricatorMySQLSetupCheck.php      |  13 ++-
 ...atorFilesApplicationStorageEnginePanel.php |   2 -
 .../maniphest/query/ManiphestTaskQuery.php    |   2 +-
 ...torSearchApplicationStorageEnginePanel.php |  82 +++++++++++++
 .../config/PhabricatorSearchConfigOptions.php |  15 ---
 .../engine/PhabricatorElasticSearchEngine.php |  30 ++++-
 .../engine/PhabricatorMySQLSearchEngine.php   |  22 +++-
 .../search/engine/PhabricatorSearchEngine.php | 109 +++++++++++++++++-
 .../PhabricatorSearchDocumentIndexer.php      |   2 +-
 ...habricatorSearchManagementInitWorkflow.php |   2 +-
 .../query/PhabricatorSearchDocumentQuery.php  |   2 +-
 ...PhabricatorDefaultSearchEngineSelector.php |  19 ---
 .../PhabricatorSearchEngineSelector.php       |  15 ---
 16 files changed, 263 insertions(+), 78 deletions(-)
 rename src/applications/config/check/{PhabricatorElasticSetupCheck.php => PhabricatorElasticSearchSetupCheck.php} (76%)
 create mode 100644 src/applications/search/applicationpanel/PhabricatorSearchApplicationStorageEnginePanel.php
 delete mode 100644 src/applications/search/selector/PhabricatorDefaultSearchEngineSelector.php
 delete mode 100644 src/applications/search/selector/PhabricatorSearchEngineSelector.php

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index 0c4b286fe7..79e98ed18a 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -1744,7 +1744,6 @@ phutil_register_library_map(array(
     'PhabricatorDatabaseSetupCheck' => 'applications/config/check/PhabricatorDatabaseSetupCheck.php',
     'PhabricatorDateTimeSettingsPanel' => 'applications/settings/panel/PhabricatorDateTimeSettingsPanel.php',
     'PhabricatorDebugController' => 'applications/system/controller/PhabricatorDebugController.php',
-    'PhabricatorDefaultSearchEngineSelector' => 'applications/search/selector/PhabricatorDefaultSearchEngineSelector.php',
     'PhabricatorDestructibleInterface' => 'applications/system/interface/PhabricatorDestructibleInterface.php',
     'PhabricatorDestructionEngine' => 'applications/system/engine/PhabricatorDestructionEngine.php',
     'PhabricatorDeveloperConfigOptions' => 'applications/config/option/PhabricatorDeveloperConfigOptions.php',
@@ -1776,7 +1775,7 @@ phutil_register_library_map(array(
     'PhabricatorEdgeType' => 'infrastructure/edges/type/PhabricatorEdgeType.php',
     'PhabricatorEditor' => 'infrastructure/PhabricatorEditor.php',
     'PhabricatorElasticSearchEngine' => 'applications/search/engine/PhabricatorElasticSearchEngine.php',
-    'PhabricatorElasticSetupCheck' => 'applications/config/check/PhabricatorElasticSetupCheck.php',
+    'PhabricatorElasticSearchSetupCheck' => 'applications/config/check/PhabricatorElasticSearchSetupCheck.php',
     'PhabricatorEmailAddressesSettingsPanel' => 'applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php',
     'PhabricatorEmailFormatSettingsPanel' => 'applications/settings/panel/PhabricatorEmailFormatSettingsPanel.php',
     'PhabricatorEmailLoginController' => 'applications/auth/controller/PhabricatorEmailLoginController.php',
@@ -2501,6 +2500,7 @@ phutil_register_library_map(array(
     'PhabricatorSearchAbstractDocument' => 'applications/search/index/PhabricatorSearchAbstractDocument.php',
     'PhabricatorSearchApplication' => 'applications/search/application/PhabricatorSearchApplication.php',
     'PhabricatorSearchApplicationSearchEngine' => 'applications/search/query/PhabricatorSearchApplicationSearchEngine.php',
+    'PhabricatorSearchApplicationStorageEnginePanel' => 'applications/search/applicationpanel/PhabricatorSearchApplicationStorageEnginePanel.php',
     'PhabricatorSearchAttachController' => 'applications/search/controller/PhabricatorSearchAttachController.php',
     'PhabricatorSearchBaseController' => 'applications/search/controller/PhabricatorSearchBaseController.php',
     'PhabricatorSearchConfigOptions' => 'applications/search/config/PhabricatorSearchConfigOptions.php',
@@ -2516,7 +2516,6 @@ phutil_register_library_map(array(
     'PhabricatorSearchDocumentTypeDatasource' => 'applications/search/typeahead/PhabricatorSearchDocumentTypeDatasource.php',
     'PhabricatorSearchEditController' => 'applications/search/controller/PhabricatorSearchEditController.php',
     'PhabricatorSearchEngine' => 'applications/search/engine/PhabricatorSearchEngine.php',
-    'PhabricatorSearchEngineSelector' => 'applications/search/selector/PhabricatorSearchEngineSelector.php',
     'PhabricatorSearchField' => 'applications/search/constants/PhabricatorSearchField.php',
     'PhabricatorSearchHovercardController' => 'applications/search/controller/PhabricatorSearchHovercardController.php',
     'PhabricatorSearchIndexer' => 'applications/search/index/PhabricatorSearchIndexer.php',
@@ -5140,7 +5139,6 @@ phutil_register_library_map(array(
     'PhabricatorDatabaseSetupCheck' => 'PhabricatorSetupCheck',
     'PhabricatorDateTimeSettingsPanel' => 'PhabricatorSettingsPanel',
     'PhabricatorDebugController' => 'PhabricatorController',
-    'PhabricatorDefaultSearchEngineSelector' => 'PhabricatorSearchEngineSelector',
     'PhabricatorDestructionEngine' => 'Phobject',
     'PhabricatorDeveloperConfigOptions' => 'PhabricatorApplicationConfigOptions',
     'PhabricatorDeveloperPreferencesSettingsPanel' => 'PhabricatorSettingsPanel',
@@ -5169,7 +5167,7 @@ phutil_register_library_map(array(
     'PhabricatorEdgeType' => 'Phobject',
     'PhabricatorEditor' => 'Phobject',
     'PhabricatorElasticSearchEngine' => 'PhabricatorSearchEngine',
-    'PhabricatorElasticSetupCheck' => 'PhabricatorSetupCheck',
+    'PhabricatorElasticSearchSetupCheck' => 'PhabricatorSetupCheck',
     'PhabricatorEmailAddressesSettingsPanel' => 'PhabricatorSettingsPanel',
     'PhabricatorEmailFormatSettingsPanel' => 'PhabricatorSettingsPanel',
     'PhabricatorEmailLoginController' => 'PhabricatorAuthController',
@@ -5973,6 +5971,7 @@ phutil_register_library_map(array(
     'PhabricatorScheduleTaskTriggerAction' => 'PhabricatorTriggerAction',
     'PhabricatorSearchApplication' => 'PhabricatorApplication',
     'PhabricatorSearchApplicationSearchEngine' => 'PhabricatorApplicationSearchEngine',
+    'PhabricatorSearchApplicationStorageEnginePanel' => 'PhabricatorApplicationConfigurationPanel',
     'PhabricatorSearchAttachController' => 'PhabricatorSearchBaseController',
     'PhabricatorSearchBaseController' => 'PhabricatorController',
     'PhabricatorSearchConfigOptions' => 'PhabricatorApplicationConfigOptions',
diff --git a/src/applications/config/check/PhabricatorElasticSetupCheck.php b/src/applications/config/check/PhabricatorElasticSearchSetupCheck.php
similarity index 76%
rename from src/applications/config/check/PhabricatorElasticSetupCheck.php
rename to src/applications/config/check/PhabricatorElasticSearchSetupCheck.php
index 7b60444a88..a573c14490 100644
--- a/src/applications/config/check/PhabricatorElasticSetupCheck.php
+++ b/src/applications/config/check/PhabricatorElasticSearchSetupCheck.php
@@ -1,14 +1,15 @@
 <?php
 
-final class PhabricatorElasticSetupCheck extends PhabricatorSetupCheck {
+final class PhabricatorElasticSearchSetupCheck extends PhabricatorSetupCheck {
 
   public function getDefaultGroup() {
     return self::GROUP_OTHER;
   }
 
   protected function executeChecks() {
-    if (PhabricatorDefaultSearchEngineSelector::shouldUseElasticSearch()) {
-      $engine = PhabricatorSearchEngineSelector::newSelector()->newEngine();
+    if ($this->shouldUseElasticSearchEngine()) {
+      $engine = new PhabricatorElasticSearchEngine();
+
       if (!$engine->indexExists()) {
         $summary = pht(
           'You enabled Elasticsearch but the index does not exist.');
@@ -40,4 +41,10 @@ final class PhabricatorElasticSetupCheck extends PhabricatorSetupCheck {
       }
     }
   }
+
+  protected function shouldUseElasticSearchEngine() {
+    $search_engine = PhabricatorSearchEngine::loadEngine();
+    return $search_engine instanceof PhabricatorElasticSearchEngine;
+  }
+
 }
diff --git a/src/applications/config/check/PhabricatorExtraConfigSetupCheck.php b/src/applications/config/check/PhabricatorExtraConfigSetupCheck.php
index a95ec0e1c9..2d69334c47 100644
--- a/src/applications/config/check/PhabricatorExtraConfigSetupCheck.php
+++ b/src/applications/config/check/PhabricatorExtraConfigSetupCheck.php
@@ -252,6 +252,10 @@ final class PhabricatorExtraConfigSetupCheck extends PhabricatorSetupCheck {
 
       'style.monospace' => $monospace_reason,
       'style.monospace.windows' => $monospace_reason,
+
+      'search.engine-selector' => pht(
+        'Phabricator now automatically discovers available search engines '.
+        'at runtime.'),
     );
 
     return $ancient_config;
diff --git a/src/applications/config/check/PhabricatorMySQLSetupCheck.php b/src/applications/config/check/PhabricatorMySQLSetupCheck.php
index 6747158b85..a5178cc9ed 100644
--- a/src/applications/config/check/PhabricatorMySQLSetupCheck.php
+++ b/src/applications/config/check/PhabricatorMySQLSetupCheck.php
@@ -116,7 +116,8 @@ final class PhabricatorMySQLSetupCheck extends PhabricatorSetupCheck {
     }
 
     $stopword_file = self::loadRawConfigValue('ft_stopword_file');
-    if (!PhabricatorDefaultSearchEngineSelector::shouldUseElasticSearch()) {
+
+    if ($this->shouldUseMySQLSearchEngine()) {
       if ($stopword_file === null) {
         $summary = pht(
           'Your version of MySQL does not support configuration of a '.
@@ -190,7 +191,7 @@ final class PhabricatorMySQLSetupCheck extends PhabricatorSetupCheck {
 
     $min_len = self::loadRawConfigValue('ft_min_word_len');
     if ($min_len >= 4) {
-      if (!PhabricatorDefaultSearchEngineSelector::shouldUseElasticSearch()) {
+      if ($this->shouldUseMySQLSearchEngine()) {
         $namespace = PhabricatorEnv::getEnvConfig('storage.default-namespace');
 
         $summary = pht(
@@ -235,8 +236,7 @@ final class PhabricatorMySQLSetupCheck extends PhabricatorSetupCheck {
 
     $bool_syntax = self::loadRawConfigValue('ft_boolean_syntax');
     if ($bool_syntax != ' |-><()~*:""&^') {
-      if (!PhabricatorDefaultSearchEngineSelector::shouldUseElasticSearch()) {
-
+      if ($this->shouldUseMySQLSearchEngine()) {
         $summary = pht(
           'MySQL is configured to search on fulltext indexes using "OR" by '.
           'default. Using "AND" is usually the desired behaviour.');
@@ -340,4 +340,9 @@ final class PhabricatorMySQLSetupCheck extends PhabricatorSetupCheck {
 
   }
 
+  protected function shouldUseMySQLSearchEngine() {
+    $search_engine = PhabricatorSearchEngine::loadEngine();
+    return $search_engine instanceof PhabricatorMySQLSearchEngine;
+  }
+
 }
diff --git a/src/applications/files/applicationpanel/PhabricatorFilesApplicationStorageEnginePanel.php b/src/applications/files/applicationpanel/PhabricatorFilesApplicationStorageEnginePanel.php
index a174102c18..a92f3cf763 100644
--- a/src/applications/files/applicationpanel/PhabricatorFilesApplicationStorageEnginePanel.php
+++ b/src/applications/files/applicationpanel/PhabricatorFilesApplicationStorageEnginePanel.php
@@ -61,8 +61,6 @@ final class PhabricatorFilesApplicationStorageEnginePanel
       );
     }
 
-    $table =
-
     $table = id(new AphrontTableView($rows))
       ->setNoDataString(pht('No storage engines available.'))
       ->setHeaders(
diff --git a/src/applications/maniphest/query/ManiphestTaskQuery.php b/src/applications/maniphest/query/ManiphestTaskQuery.php
index 4a6381581b..4da078c004 100644
--- a/src/applications/maniphest/query/ManiphestTaskQuery.php
+++ b/src/applications/maniphest/query/ManiphestTaskQuery.php
@@ -563,7 +563,7 @@ final class ManiphestTaskQuery extends PhabricatorCursorPagedPolicyAwareQuery {
     $fulltext_query->setParameter('types',
       array(ManiphestTaskPHIDType::TYPECONST));
 
-    $engine = PhabricatorSearchEngineSelector::newSelector()->newEngine();
+    $engine = PhabricatorSearchEngine::loadEngine();
     $fulltext_results = $engine->executeSearch($fulltext_query);
 
     if (empty($fulltext_results)) {
diff --git a/src/applications/search/applicationpanel/PhabricatorSearchApplicationStorageEnginePanel.php b/src/applications/search/applicationpanel/PhabricatorSearchApplicationStorageEnginePanel.php
new file mode 100644
index 0000000000..b54a818398
--- /dev/null
+++ b/src/applications/search/applicationpanel/PhabricatorSearchApplicationStorageEnginePanel.php
@@ -0,0 +1,82 @@
+<?php
+
+final class PhabricatorSearchApplicationStorageEnginePanel
+  extends PhabricatorApplicationConfigurationPanel {
+
+  public function getPanelKey() {
+    return 'search';
+  }
+
+  public function shouldShowForApplication(
+    PhabricatorApplication $application) {
+    return $application instanceof PhabricatorSearchApplication;
+  }
+
+  public function buildConfigurationPagePanel() {
+    $viewer = $this->getViewer();
+    $application = $this->getApplication();
+
+    $active_engine = PhabricatorSearchEngine::loadEngine();
+    $engines = PhabricatorSearchEngine::loadAllEngines();
+
+    $rows = array();
+    $rowc = array();
+
+    foreach ($engines as $key => $engine) {
+      try {
+        $index_exists = $engine->indexExists() ? pht('Yes') : pht('No');
+      } catch (Exception $ex) {
+        $index_exists = pht('N/A');
+      }
+
+      try {
+        $index_is_sane = $engine->indexIsSane() ? pht('Yes') : pht('No');
+      } catch (Exception $ex) {
+        $index_is_sane = pht('N/A');
+      }
+
+      if ($engine == $active_engine) {
+        $rowc[] = 'highlighted';
+      } else {
+        $rowc[] = null;
+      }
+
+      $rows[] = array(
+        $key,
+        get_class($engine),
+        $index_exists,
+        $index_is_sane,
+      );
+    }
+
+    $table = id(new AphrontTableView($rows))
+      ->setNoDataString(pht('No search engines available.'))
+      ->setHeaders(
+        array(
+          pht('Key'),
+          pht('Class'),
+          pht('Index Exists'),
+          pht('Index Is Sane'),
+        ))
+      ->setRowClasses($rowc)
+      ->setColumnClasses(
+        array(
+          '',
+          'wide',
+          '',
+        ));
+
+    $box = id(new PHUIObjectBoxView())
+      ->setHeaderText(pht('Search Engines'))
+      ->appendChild($table);
+
+    return $box;
+  }
+
+  public function handlePanelRequest(
+    AphrontRequest $request,
+    PhabricatorController $controller) {
+    return new Aphront404Response();
+  }
+
+}
diff --git a/src/applications/search/config/PhabricatorSearchConfigOptions.php b/src/applications/search/config/PhabricatorSearchConfigOptions.php
index f8cb143b94..453821bc49 100644
--- a/src/applications/search/config/PhabricatorSearchConfigOptions.php
+++ b/src/applications/search/config/PhabricatorSearchConfigOptions.php
@@ -21,21 +21,6 @@ final class PhabricatorSearchConfigOptions
 
   public function getOptions() {
     return array(
-      $this->newOption(
-        'search.engine-selector',
-        'class',
-        'PhabricatorDefaultSearchEngineSelector')
-        ->setBaseClass('PhabricatorSearchEngineSelector')
-        ->setSummary(pht('Search engine selector.'))
-        ->setDescription(
-          pht(
-            'Phabricator uses a search engine selector to choose which '.
-            'search engine to use when indexing and reconstructing '.
-            'documents, and when executing queries. You can override the '.
-            'engine selector to provide a new selector class which can '.
-            'select some custom engine you implement, if you want to store '.
-            'your documents in some search engine which does not have '.
-            'default support.')),
       $this->newOption('search.elastic.host', 'string', null)
         ->setLocked(true)
         ->setDescription(pht('Elastic Search host.'))
diff --git a/src/applications/search/engine/PhabricatorElasticSearchEngine.php b/src/applications/search/engine/PhabricatorElasticSearchEngine.php
index 4b30fb4c66..f6efc17044 100644
--- a/src/applications/search/engine/PhabricatorElasticSearchEngine.php
+++ b/src/applications/search/engine/PhabricatorElasticSearchEngine.php
@@ -1,13 +1,31 @@
 <?php
 
 final class PhabricatorElasticSearchEngine extends PhabricatorSearchEngine {
+
   private $uri;
   private $index;
   private $timeout;
 
-  public function __construct($uri, $index) {
+  public function getEngineIdentifier() {
+    return 'elasticsearch';
+  }
+
+  public function getEnginePriority() {
+    return 10;
+  }
+
+  public function isEnabled() {
+    return (bool)PhabricatorEnv::getEnvConfig('search.elastic.host');
+  }
+
+  public function setURI($uri) {
     $this->uri = $uri;
+    return $this;
+  }
+
+  public function setIndex($index) {
     $this->index = $index;
+    return $this;
   }
 
   public function setTimeout($timeout) {
@@ -15,6 +33,14 @@ final class PhabricatorElasticSearchEngine extends PhabricatorSearchEngine {
     return $this;
   }
 
+  public function getURI() {
+    return $this->uri;
+  }
+
+  public function getIndex() {
+    return $this->index;
+  }
+
   public function getTimeout() {
     return $this->timeout;
   }
@@ -99,7 +125,7 @@ final class PhabricatorElasticSearchEngine extends PhabricatorSearchEngine {
       $spec[] = array(
         'simple_query_string' => array(
           'query'  => $query->getParameter('query'),
-          'fields' => array( 'field.corpus' ),
+          'fields' => array('field.corpus'),
         ),
       );
 
diff --git a/src/applications/search/engine/PhabricatorMySQLSearchEngine.php b/src/applications/search/engine/PhabricatorMySQLSearchEngine.php
index 42ed21d2e8..3e006399ea 100644
--- a/src/applications/search/engine/PhabricatorMySQLSearchEngine.php
+++ b/src/applications/search/engine/PhabricatorMySQLSearchEngine.php
@@ -2,12 +2,24 @@
 
 final class PhabricatorMySQLSearchEngine extends PhabricatorSearchEngine {
 
+  public function getEngineIdentifier() {
+    return 'mysql';
+  }
+
+  public function getEnginePriority() {
+    return 100;
+  }
+
+  public function isEnabled() {
+    return true;
+  }
+
   public function reindexAbstractDocument(
     PhabricatorSearchAbstractDocument $doc) {
 
     $phid = $doc->getPHID();
     if (!$phid) {
-      throw new Exception('Document has no PHID!');
+      throw new Exception(pht('Document has no PHID!'));
     }
 
     $store = new PhabricatorSearchDocument();
@@ -31,7 +43,7 @@ final class PhabricatorMySQLSearchEngine extends PhabricatorSearchEngine {
       queryfx(
         $conn_w,
         'INSERT INTO %T (phid, phidType, field, auxPHID, corpus) '.
-        ' VALUES (%s, %s, %s, %ns, %s)',
+        'VALUES (%s, %s, %s, %ns, %s)',
         $field_dao->getTableName(),
         $phid,
         $doc->getDocumentType(),
@@ -63,9 +75,9 @@ final class PhabricatorMySQLSearchEngine extends PhabricatorSearchEngine {
     if ($sql) {
       queryfx(
         $conn_w,
-        'INSERT INTO %T'.
-        ' (phid, relatedPHID, relation, relatedType, relatedTime) '.
-        ' VALUES %Q',
+        'INSERT INTO %T '.
+        '(phid, relatedPHID, relation, relatedType, relatedTime) '.
+        'VALUES %Q',
         $rship_dao->getTableName(),
         implode(', ', $sql));
     }
diff --git a/src/applications/search/engine/PhabricatorSearchEngine.php b/src/applications/search/engine/PhabricatorSearchEngine.php
index 1521294b13..0ba8e321d8 100644
--- a/src/applications/search/engine/PhabricatorSearchEngine.php
+++ b/src/applications/search/engine/PhabricatorSearchEngine.php
@@ -1,6 +1,5 @@
 <?php
 
-
 /**
  * Base class for Phabricator search engine providers. Each engine must offer
  * three capabilities: indexing, searching, and reconstruction (this can be
@@ -8,6 +7,49 @@
  */
 abstract class PhabricatorSearchEngine {
 
+/* -(  Engine Metadata  )---------------------------------------------------- */
+
+  /**
+   * Return a unique, nonempty string which identifies this storage engine.
+   *
+   * @return string Unique string for this engine, max length 32.
+   * @task meta
+   */
+  abstract public function getEngineIdentifier();
+
+  /**
+   * Prioritize this engine relative to other engines.
+   *
+   * Engines with a smaller priority number get an opportunity to write files
+   * first. Generally, lower-latency filestores should have lower priority
+   * numbers, and higher-latency filestores should have higher priority
+   * numbers. Setting priority to approximately the number of milliseconds of
+   * read latency will generally produce reasonable results.
+   *
+   * In conjunction with filesize limits, the goal is to store small files like
+   * profile images, thumbnails, and text snippets in lower-latency engines,
+   * and store large files in higher-capacity engines.
+   *
+   * @return float Engine priority.
+   * @task meta
+   */
+  abstract public function getEnginePriority();
+
+  /**
+   * Return `true` if the engine is currently writable.
+   *
+   * Engines that are disabled or missing configuration should return `false`
+   * to prevent new writes. If writes were made with this engine in the past,
+   * the application may still try to perform reads.
+   *
+   * @return bool True if this engine can support new writes.
+   * @task meta
+   */
+  abstract public function isEnabled();
+
+
+/* -(  Managing Documents  )------------------------------------------------- */
+
   /**
    * Update the index for an abstract document.
    *
@@ -17,7 +59,6 @@ abstract class PhabricatorSearchEngine {
   abstract public function reindexAbstractDocument(
     PhabricatorSearchAbstractDocument $document);
 
-
   /**
    * Reconstruct the document for a given PHID. This is used for debugging
    * and does not need to be perfect if it is unreasonable to implement it.
@@ -27,7 +68,6 @@ abstract class PhabricatorSearchEngine {
    */
   abstract public function reconstructDocument($phid);
 
-
   /**
    * Execute a search query.
    *
@@ -53,9 +93,70 @@ abstract class PhabricatorSearchEngine {
   }
 
   /**
-   * Do any sort of setup for the search index
+   * Do any sort of setup for the search index.
    *
    * @return void
    */
   public function initIndex() {}
+
+
+/* -(  Loading Storage Engines  )-------------------------------------------- */
+
+  /**
+   * @task load
+   */
+  public static function loadAllEngines() {
+    static $engines;
+
+    if ($engines === null) {
+      $objects = id(new PhutilSymbolLoader())
+        ->setAncestorClass(__CLASS__)
+        ->loadObjects();
+
+      $map = array();
+      foreach ($objects as $engine) {
+        $key = $engine->getEngineIdentifier();
+        if (empty($map[$key])) {
+          $map[$key] = $engine;
+        } else {
+          throw new Exception(
+            pht(
+              'Search engines "%s" and "%s" have the same engine identifier '.
+              '"%s". Each storage engine must have a unique identifier.',
+              get_class($engine),
+              get_class($map[$key]),
+              $key));
+        }
+      }
+
+      $map = msort($map, 'getEnginePriority');
+
+      $engines = $map;
+    }
+
+    return $engines;
+  }
+
+  /**
+   * @task load
+   */
+  public static function loadActiveEngines() {
+    $engines = self::loadAllEngines();
+
+    $active = array();
+    foreach ($engines as $key => $engine) {
+      if (!$engine->isEnabled()) {
+        continue;
+      }
+
+      $active[$key] = $engine;
+    }
+
+    return $active;
+  }
+
+  public static function loadEngine() {
+    return head(self::loadActiveEngines());
+  }
+
 }
diff --git a/src/applications/search/index/PhabricatorSearchDocumentIndexer.php b/src/applications/search/index/PhabricatorSearchDocumentIndexer.php
index 4e5089aa8c..18d07765ad 100644
--- a/src/applications/search/index/PhabricatorSearchDocumentIndexer.php
+++ b/src/applications/search/index/PhabricatorSearchDocumentIndexer.php
@@ -69,7 +69,7 @@ abstract class PhabricatorSearchDocumentIndexer extends Phobject {
         $this->indexProjects($document, $object);
       }
 
-      $engine = PhabricatorSearchEngineSelector::newSelector()->newEngine();
+      $engine = PhabricatorSearchEngine::loadEngine();
       try {
         $engine->reindexAbstractDocument($document);
       } catch (Exception $ex) {
diff --git a/src/applications/search/management/PhabricatorSearchManagementInitWorkflow.php b/src/applications/search/management/PhabricatorSearchManagementInitWorkflow.php
index 6e4811dd7f..e4a8ddb693 100644
--- a/src/applications/search/management/PhabricatorSearchManagementInitWorkflow.php
+++ b/src/applications/search/management/PhabricatorSearchManagementInitWorkflow.php
@@ -13,7 +13,7 @@ final class PhabricatorSearchManagementInitWorkflow
   public function execute(PhutilArgumentParser $args) {
     $console = PhutilConsole::getConsole();
 
-    $engine = PhabricatorSearchEngineSelector::newSelector()->newEngine();
+    $engine = PhabricatorSearchEngine::loadEngine();
 
     $work_done = false;
     if (!$engine->indexExists()) {
diff --git a/src/applications/search/query/PhabricatorSearchDocumentQuery.php b/src/applications/search/query/PhabricatorSearchDocumentQuery.php
index 903d40dd5a..1770f4b046 100644
--- a/src/applications/search/query/PhabricatorSearchDocumentQuery.php
+++ b/src/applications/search/query/PhabricatorSearchDocumentQuery.php
@@ -74,7 +74,7 @@ final class PhabricatorSearchDocumentQuery
       ->setParameter('offset', $this->getOffset())
       ->setParameter('limit', $this->getRawResultLimit());
 
-    $engine = PhabricatorSearchEngineSelector::newSelector()->newEngine();
+    $engine = PhabricatorSearchEngine::loadEngine();
 
     return $engine->executeSearch($query);
   }
diff --git a/src/applications/search/selector/PhabricatorDefaultSearchEngineSelector.php b/src/applications/search/selector/PhabricatorDefaultSearchEngineSelector.php
deleted file mode 100644
index 9e06b1182a..0000000000
--- a/src/applications/search/selector/PhabricatorDefaultSearchEngineSelector.php
+++ /dev/null
@@ -1,19 +0,0 @@
-<?php
-
-final class PhabricatorDefaultSearchEngineSelector
-  extends PhabricatorSearchEngineSelector {
-
-  public function newEngine() {
-    if (self::shouldUseElasticSearch()) {
-      $elastic_host = PhabricatorEnv::getEnvConfig('search.elastic.host');
-      $elastic_index = PhabricatorEnv::getEnvConfig('search.elastic.namespace');
-      return new PhabricatorElasticSearchEngine($elastic_host, $elastic_index);
-    }
-    return new PhabricatorMySQLSearchEngine();
-  }
-
-  public static function shouldUseElasticSearch() {
-    return (bool)PhabricatorEnv::getEnvConfig('search.elastic.host');
-  }
-
-}
diff --git a/src/applications/search/selector/PhabricatorSearchEngineSelector.php b/src/applications/search/selector/PhabricatorSearchEngineSelector.php
deleted file mode 100644
index 41219c61a9..0000000000
--- a/src/applications/search/selector/PhabricatorSearchEngineSelector.php
+++ /dev/null
@@ -1,15 +0,0 @@
-<?php
-
-abstract class PhabricatorSearchEngineSelector {
-
-  final public function __construct() {
-    // <empty>
-  }
-
-  abstract public function newEngine();
-
-  final public static function newSelector() {
-    return PhabricatorEnv::newObjectFromConfig('search.engine-selector');
-  }
-
-}

From b5bf8e998d5340a04d9f7dd6b8fe68eb51b82e4f Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@joshuaspence.com>
Date: Wed, 20 May 2015 07:02:08 +1000
Subject: [PATCH 63/86] Remove unused PhabricatorFeedStory subclasses

Summary: Remove a bunch of unused `PhabricatorFeedStory` subclasses.

Test Plan: `grep`

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: btrahan, Korvin, epriestley

Maniphest Tasks: T5655

Differential Revision: https://secure.phabricator.com/D11674
---
 src/__phutil_library_map__.php                |  14 --
 .../story/PhabricatorFeedStoryAggregate.php   |  74 ------
 .../feed/story/PhabricatorFeedStoryAudit.php  |  49 ----
 .../feed/story/PhabricatorFeedStoryCommit.php | 107 --------
 .../PhabricatorFeedStoryDifferential.php      | 237 ------------------
 ...bricatorFeedStoryDifferentialAggregate.php |  66 -----
 ...PhabricatorFeedStoryManiphestAggregate.php |  66 -----
 .../story/PhabricatorFeedStoryPhriction.php   |  95 -------
 .../PhabricatorNotificationBuilder.php        |  26 --
 9 files changed, 734 deletions(-)
 delete mode 100644 src/applications/feed/story/PhabricatorFeedStoryAggregate.php
 delete mode 100644 src/applications/feed/story/PhabricatorFeedStoryAudit.php
 delete mode 100644 src/applications/feed/story/PhabricatorFeedStoryCommit.php
 delete mode 100644 src/applications/feed/story/PhabricatorFeedStoryDifferential.php
 delete mode 100644 src/applications/feed/story/PhabricatorFeedStoryDifferentialAggregate.php
 delete mode 100644 src/applications/feed/story/PhabricatorFeedStoryManiphestAggregate.php
 delete mode 100644 src/applications/feed/story/PhabricatorFeedStoryPhriction.php

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index 79e98ed18a..39cc7a3751 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -1832,15 +1832,8 @@ phutil_register_library_map(array(
     'PhabricatorFeedQuery' => 'applications/feed/query/PhabricatorFeedQuery.php',
     'PhabricatorFeedSearchEngine' => 'applications/feed/query/PhabricatorFeedSearchEngine.php',
     'PhabricatorFeedStory' => 'applications/feed/story/PhabricatorFeedStory.php',
-    'PhabricatorFeedStoryAggregate' => 'applications/feed/story/PhabricatorFeedStoryAggregate.php',
-    'PhabricatorFeedStoryAudit' => 'applications/feed/story/PhabricatorFeedStoryAudit.php',
-    'PhabricatorFeedStoryCommit' => 'applications/feed/story/PhabricatorFeedStoryCommit.php',
     'PhabricatorFeedStoryData' => 'applications/feed/storage/PhabricatorFeedStoryData.php',
-    'PhabricatorFeedStoryDifferential' => 'applications/feed/story/PhabricatorFeedStoryDifferential.php',
-    'PhabricatorFeedStoryDifferentialAggregate' => 'applications/feed/story/PhabricatorFeedStoryDifferentialAggregate.php',
-    'PhabricatorFeedStoryManiphestAggregate' => 'applications/feed/story/PhabricatorFeedStoryManiphestAggregate.php',
     'PhabricatorFeedStoryNotification' => 'applications/notification/storage/PhabricatorFeedStoryNotification.php',
-    'PhabricatorFeedStoryPhriction' => 'applications/feed/story/PhabricatorFeedStoryPhriction.php',
     'PhabricatorFeedStoryPublisher' => 'applications/feed/PhabricatorFeedStoryPublisher.php',
     'PhabricatorFeedStoryReference' => 'applications/feed/storage/PhabricatorFeedStoryReference.php',
     'PhabricatorFile' => 'applications/files/storage/PhabricatorFile.php',
@@ -5225,15 +5218,8 @@ phutil_register_library_map(array(
       'PhabricatorPolicyInterface',
       'PhabricatorMarkupInterface',
     ),
-    'PhabricatorFeedStoryAggregate' => 'PhabricatorFeedStory',
-    'PhabricatorFeedStoryAudit' => 'PhabricatorFeedStory',
-    'PhabricatorFeedStoryCommit' => 'PhabricatorFeedStory',
     'PhabricatorFeedStoryData' => 'PhabricatorFeedDAO',
-    'PhabricatorFeedStoryDifferential' => 'PhabricatorFeedStory',
-    'PhabricatorFeedStoryDifferentialAggregate' => 'PhabricatorFeedStoryAggregate',
-    'PhabricatorFeedStoryManiphestAggregate' => 'PhabricatorFeedStoryAggregate',
     'PhabricatorFeedStoryNotification' => 'PhabricatorFeedDAO',
-    'PhabricatorFeedStoryPhriction' => 'PhabricatorFeedStory',
     'PhabricatorFeedStoryReference' => 'PhabricatorFeedDAO',
     'PhabricatorFile' => array(
       'PhabricatorFileDAO',
diff --git a/src/applications/feed/story/PhabricatorFeedStoryAggregate.php b/src/applications/feed/story/PhabricatorFeedStoryAggregate.php
deleted file mode 100644
index c37a39e53d..0000000000
--- a/src/applications/feed/story/PhabricatorFeedStoryAggregate.php
+++ /dev/null
@@ -1,74 +0,0 @@
-<?php
-
-abstract class PhabricatorFeedStoryAggregate extends PhabricatorFeedStory {
-
-  private $aggregateStories = array();
-
-  public function getHasViewed() {
-    return head($this->getAggregateStories())->getHasViewed();
-  }
-
-  public function getPrimaryObjectPHID() {
-    return head($this->getAggregateStories())->getPrimaryObjectPHID();
-  }
-
-  public function getRequiredHandlePHIDs() {
-    $phids = array();
-    foreach ($this->getAggregateStories() as $story) {
-      $phids[] = $story->getRequiredHandlePHIDs();
-    }
-    return array_mergev($phids);
-  }
-
-  public function getRequiredObjectPHIDs() {
-    $phids = array();
-    foreach ($this->getAggregateStories() as $story) {
-      $phids[] = $story->getRequiredObjectPHIDs();
-    }
-    return array_mergev($phids);
-  }
-
-  protected function getAuthorPHIDs() {
-    $authors = array();
-    foreach ($this->getAggregateStories() as $story) {
-      $authors[] = $story->getStoryData()->getAuthorPHID();
-    }
-    return array_unique(array_filter($authors));
-  }
-
-  protected function getDataValues($key, $default) {
-    $result = array();
-    foreach ($this->getAggregateStories() as $key => $story) {
-      $result[$key] = $story->getStoryData()->getValue($key, $default);
-    }
-    return $result;
-  }
-
-  final public function setAggregateStories(array $aggregate_stories) {
-    assert_instances_of($aggregate_stories, 'PhabricatorFeedStory');
-    $this->aggregateStories = $aggregate_stories;
-
-    $objects = array();
-    $handles = array();
-
-    foreach ($this->aggregateStories as $story) {
-      $objects += $story->getObjects();
-      $handles += $story->getHandles();
-    }
-
-    $this->setObjects($objects);
-    $this->setHandles($handles);
-
-    return $this;
-  }
-
-  final public function getAggregateStories() {
-    return $this->aggregateStories;
-  }
-
-  final public function getNotificationAggregations() {
-    throw new Exception(
-      'You can not get aggregations for an aggregate story.');
-  }
-
-}
diff --git a/src/applications/feed/story/PhabricatorFeedStoryAudit.php b/src/applications/feed/story/PhabricatorFeedStoryAudit.php
deleted file mode 100644
index 04e1af0d7c..0000000000
--- a/src/applications/feed/story/PhabricatorFeedStoryAudit.php
+++ /dev/null
@@ -1,49 +0,0 @@
-<?php
-
-final class PhabricatorFeedStoryAudit extends PhabricatorFeedStory {
-
-  public function getPrimaryObjectPHID() {
-    return $this->getStoryData()->getValue('commitPHID');
-  }
-
-  public function renderView() {
-    $author_phid = $this->getAuthorPHID();
-    $commit_phid = $this->getPrimaryObjectPHID();
-
-    $view = $this->newStoryView();
-
-    $action = $this->getValue('action');
-    $verb = PhabricatorAuditActionConstants::getActionPastTenseVerb($action);
-
-    $view->setTitle(hsprintf(
-      '%s %s commit %s.',
-      $this->linkTo($author_phid),
-      $verb,
-      $this->linkTo($commit_phid)));
-
-    $comments = $this->getValue('content');
-    $view->setImage($this->getHandle($author_phid)->getImageURI());
-
-    if ($comments) {
-      $content = $this->renderSummary($this->getValue('content'));
-      $view->appendChild($content);
-    }
-
-    return $view;
-  }
-
-  public function renderText() {
-    $author_name = $this->getHandle($this->getAuthorPHID())->getLinkName();
-
-    $commit_path = $this->getHandle($this->getPrimaryObjectPHID())->getURI();
-    $commit_uri = PhabricatorEnv::getURI($commit_path);
-
-    $action = $this->getValue('action');
-    $verb = PhabricatorAuditActionConstants::getActionPastTenseVerb($action);
-
-    $text = "{$author_name} {$verb} commit {$commit_uri}";
-
-    return $text;
-  }
-
-}
diff --git a/src/applications/feed/story/PhabricatorFeedStoryCommit.php b/src/applications/feed/story/PhabricatorFeedStoryCommit.php
deleted file mode 100644
index 72fa9cc126..0000000000
--- a/src/applications/feed/story/PhabricatorFeedStoryCommit.php
+++ /dev/null
@@ -1,107 +0,0 @@
-<?php
-
-final class PhabricatorFeedStoryCommit extends PhabricatorFeedStory {
-
-  public function getPrimaryObjectPHID() {
-    return $this->getValue('commitPHID');
-  }
-
-  public function getRequiredHandlePHIDs() {
-    return array(
-      $this->getValue('committerPHID'),
-    );
-  }
-
-  public function renderView() {
-    $data = $this->getStoryData();
-
-    $author = null;
-    if ($data->getValue('authorPHID')) {
-      $author = $this->linkTo($data->getValue('authorPHID'));
-    } else {
-      $author = $data->getValue('authorName');
-    }
-
-    $committer = null;
-    if ($data->getValue('committerPHID')) {
-      $committer = $this->linkTo($data->getValue('committerPHID'));
-    } else if ($data->getValue('committerName')) {
-      $committer = $data->getValue('committerName');
-    }
-
-    $commit = $this->linkTo($data->getValue('commitPHID'));
-
-    if (!$committer) {
-      $committer = $author;
-      $author = null;
-    }
-
-    if ($author) {
-      $title = pht(
-        '%s committed %s (authored by %s)',
-        $committer,
-        $commit,
-        $author);
-    } else {
-      $title = pht(
-        '%s committed %s',
-        $committer,
-        $commit);
-    }
-
-    $view = $this->newStoryView();
-
-    $view->setTitle($title);
-
-    if ($data->getValue('authorPHID')) {
-      $view->setImage($this->getHandle($data->getAuthorPHID())->getImageURI());
-    }
-
-    $content = $this->renderSummary($data->getValue('summary'));
-    $view->appendChild($content);
-
-    return $view;
-  }
-
-  public function renderText() {
-    $author = null;
-    if ($this->getAuthorPHID()) {
-      $author = $this->getHandle($this->getAuthorPHID())->getLinkName();
-    } else {
-      $author = $this->getValue('authorName');
-    }
-
-    $committer = null;
-    if ($this->getValue('committerPHID')) {
-      $committer_handle = $this->getHandle($this->getValue('committerPHID'));
-      $committer = $committer_handle->getLinkName();
-    } else if ($this->getValue('committerName')) {
-      $committer = $this->getValue('committerName');
-    }
-
-    $commit_handle = $this->getHandle($this->getPrimaryObjectPHID());
-    $commit_uri = PhabricatorEnv::getURI($commit_handle->getURI());
-    $commit_name = $commit_handle->getLinkName();
-
-    if (!$committer) {
-      $committer = $author;
-      $author = null;
-    }
-
-    if ($author) {
-      $text = pht(
-        '%s committed %s (authored by %s).',
-        $committer,
-        $commit_name,
-        $author);
-    } else {
-      $text = pht(
-        '%s committed %s.',
-        $committer,
-        $commit_name);
-    }
-
-    return $text;
-  }
-
-}
diff --git a/src/applications/feed/story/PhabricatorFeedStoryDifferential.php b/src/applications/feed/story/PhabricatorFeedStoryDifferential.php
deleted file mode 100644
index 8d7b98b928..0000000000
--- a/src/applications/feed/story/PhabricatorFeedStoryDifferential.php
+++ /dev/null
@@ -1,237 +0,0 @@
-<?php
-
-final class PhabricatorFeedStoryDifferential extends PhabricatorFeedStory {
-
-  public function getPrimaryObjectPHID() {
-    return $this->getValue('revision_phid');
-  }
-
-  public function renderView() {
-    $data = $this->getStoryData();
-
-    $view = $this->newStoryView();
-
-    $line = $this->getLineForData($data);
-    $view->setTitle($line);
-
-    $href = $this->getHandle($data->getValue('revision_phid'))->getURI();
-    $view->setHref($href);
-
-    $action = $data->getValue('action');
-
-    switch ($action) {
-      case DifferentialAction::ACTION_CREATE:
-      case DifferentialAction::ACTION_CLOSE:
-      case DifferentialAction::ACTION_COMMENT:
-        $full_size = true;
-        break;
-      default:
-        $full_size = false;
-        break;
-    }
-
-    $view->setImage($this->getHandle($data->getAuthorPHID())->getImageURI());
-    if ($full_size) {
-      $content = $this->renderSummary($data->getValue('feedback_content'));
-      $view->appendChild($content);
-    }
-
-    return $view;
-  }
-
-  private function getLineForData($data) {
-    $actor_phid = $data->getAuthorPHID();
-    $revision_phid = $data->getValue('revision_phid');
-    $action = $data->getValue('action');
-
-    $actor_link = $this->linkTo($actor_phid);
-    $revision_link = $this->linkTo($revision_phid);
-
-    switch ($action) {
-      case DifferentialAction::ACTION_COMMENT:
-        $one_line = pht('%s commented on revision %s',
-          $actor_link, $revision_link);
-      break;
-      case DifferentialAction::ACTION_ACCEPT:
-        $one_line = pht('%s accepted revision %s',
-          $actor_link, $revision_link);
-      break;
-      case DifferentialAction::ACTION_REJECT:
-        $one_line = pht('%s requested changes to revision %s',
-          $actor_link, $revision_link);
-      break;
-      case DifferentialAction::ACTION_RETHINK:
-        $one_line = pht('%s planned changes to revision %s',
-          $actor_link, $revision_link);
-      break;
-      case DifferentialAction::ACTION_ABANDON:
-        $one_line = pht('%s abandoned revision %s',
-          $actor_link, $revision_link);
-      break;
-      case DifferentialAction::ACTION_CLOSE:
-        $one_line = pht('%s closed revision %s',
-          $actor_link, $revision_link);
-      break;
-      case DifferentialAction::ACTION_REQUEST:
-        $one_line = pht('%s requested a review of revision %s',
-          $actor_link, $revision_link);
-      break;
-      case DifferentialAction::ACTION_RECLAIM:
-        $one_line = pht('%s reclaimed revision %s',
-          $actor_link, $revision_link);
-      break;
-      case DifferentialAction::ACTION_UPDATE:
-        $one_line = pht('%s updated revision %s',
-          $actor_link, $revision_link);
-      break;
-      case DifferentialAction::ACTION_RESIGN:
-        $one_line = pht('%s resigned from revision %s',
-          $actor_link, $revision_link);
-      break;
-      case DifferentialAction::ACTION_SUMMARIZE:
-        $one_line = pht('%s summarized revision %s',
-          $actor_link, $revision_link);
-      break;
-      case DifferentialAction::ACTION_TESTPLAN:
-        $one_line = pht('%s explained the test plan for revision %s',
-          $actor_link, $revision_link);
-      break;
-      case DifferentialAction::ACTION_CREATE:
-        $one_line = pht('%s created revision %s',
-          $actor_link, $revision_link);
-      break;
-      case DifferentialAction::ACTION_ADDREVIEWERS:
-        $one_line = pht('%s added reviewers to revision %s',
-          $actor_link, $revision_link);
-      break;
-      case DifferentialAction::ACTION_ADDCCS:
-        $one_line = pht('%s added CCs to revision %s',
-          $actor_link, $revision_link);
-      break;
-      case DifferentialAction::ACTION_CLAIM:
-        $one_line = pht('%s commandeered revision %s',
-          $actor_link, $revision_link);
-      break;
-      case DifferentialAction::ACTION_REOPEN:
-        $one_line = pht('%s reopened revision %s',
-        $actor_link, $revision_link);
-      break;
-      case DifferentialTransaction::TYPE_INLINE:
-        $one_line = pht('%s added inline comments to %s',
-        $actor_link, $revision_link);
-      break;
-      default:
-        $one_line = pht('%s edited %s',
-        $actor_link, $revision_link);
-      break;
-    }
-
-    return $one_line;
-  }
-
-  public function renderText() {
-    $author_name = $this->getHandle($this->getAuthorPHID())->getLinkName();
-
-    $revision_handle = $this->getHandle($this->getPrimaryObjectPHID());
-    $revision_title = $revision_handle->getLinkName();
-    $revision_uri = PhabricatorEnv::getURI($revision_handle->getURI());
-
-    $action = $this->getValue('action');
-
-    switch ($action) {
-      case DifferentialAction::ACTION_COMMENT:
-        $one_line = pht('%s commented on revision %s %s',
-          $author_name, $revision_title, $revision_uri);
-      break;
-      case DifferentialAction::ACTION_ACCEPT:
-        $one_line = pht('%s accepted revision %s %s',
-          $author_name, $revision_title, $revision_uri);
-      break;
-      case DifferentialAction::ACTION_REJECT:
-        $one_line = pht('%s requested changes to revision %s %s',
-          $author_name, $revision_title, $revision_uri);
-      break;
-      case DifferentialAction::ACTION_RETHINK:
-        $one_line = pht('%s planned changes to revision %s %s',
-          $author_name, $revision_title, $revision_uri);
-      break;
-      case DifferentialAction::ACTION_ABANDON:
-        $one_line = pht('%s abandoned revision %s %s',
-          $author_name, $revision_title, $revision_uri);
-      break;
-      case DifferentialAction::ACTION_CLOSE:
-        $one_line = pht('%s closed revision %s %s',
-          $author_name, $revision_title, $revision_uri);
-      break;
-      case DifferentialAction::ACTION_REQUEST:
-        $one_line = pht('%s requested a review of revision %s %s',
-          $author_name, $revision_title, $revision_uri);
-      break;
-      case DifferentialAction::ACTION_RECLAIM:
-        $one_line = pht('%s reclaimed revision %s %s',
-          $author_name, $revision_title, $revision_uri);
-      break;
-      case DifferentialAction::ACTION_UPDATE:
-        $one_line = pht('%s updated revision %s %s',
-          $author_name, $revision_title, $revision_uri);
-      break;
-      case DifferentialAction::ACTION_RESIGN:
-        $one_line = pht('%s resigned from revision %s %s',
-          $author_name, $revision_title, $revision_uri);
-      break;
-      case DifferentialAction::ACTION_SUMMARIZE:
-        $one_line = pht('%s summarized revision %s %s',
-          $author_name, $revision_title, $revision_uri);
-      break;
-      case DifferentialAction::ACTION_TESTPLAN:
-        $one_line = pht('%s explained the test plan for revision %s %s',
-          $author_name, $revision_title, $revision_uri);
-      break;
-      case DifferentialAction::ACTION_CREATE:
-        $one_line = pht('%s created revision %s %s',
-          $author_name, $revision_title, $revision_uri);
-      break;
-      case DifferentialAction::ACTION_ADDREVIEWERS:
-        $one_line = pht('%s added reviewers to revision %s %s',
-          $author_name, $revision_title, $revision_uri);
-      break;
-      case DifferentialAction::ACTION_ADDCCS:
-        $one_line = pht('%s added CCs to revision %s %s',
-          $author_name, $revision_title, $revision_uri);
-      break;
-      case DifferentialAction::ACTION_CLAIM:
-        $one_line = pht('%s commandeered revision %s %s',
-          $author_name, $revision_title, $revision_uri);
-      break;
-      case DifferentialAction::ACTION_REOPEN:
-        $one_line = pht('%s reopened revision %s %s',
-          $author_name, $revision_title, $revision_uri);
-      break;
-      case DifferentialTransaction::TYPE_INLINE:
-        $one_line = pht('%s added inline comments to %s %s',
-          $author_name, $revision_title, $revision_uri);
-        break;
-      default:
-        $one_line = pht('%s edited %s %s',
-          $author_name, $revision_title, $revision_uri);
-        break;
-    }
-
-    return $one_line;
-  }
-
-  public function getNotificationAggregations() {
-    $class = get_class($this);
-    $phid  = $this->getStoryData()->getValue('revision_phid');
-    $read  = (int)$this->getHasViewed();
-
-    // Don't aggregate updates separated by more than 2 hours.
-    $block = (int)($this->getEpoch() / (60 * 60 * 2));
-
-    return array(
-      "{$class}:{$phid}:{$read}:{$block}"
-        => 'PhabricatorFeedStoryDifferentialAggregate',
-    );
-  }
-
-}
diff --git a/src/applications/feed/story/PhabricatorFeedStoryDifferentialAggregate.php b/src/applications/feed/story/PhabricatorFeedStoryDifferentialAggregate.php
deleted file mode 100644
index 5b0d5661d9..0000000000
--- a/src/applications/feed/story/PhabricatorFeedStoryDifferentialAggregate.php
+++ /dev/null
@@ -1,66 +0,0 @@
-<?php
-
-final class PhabricatorFeedStoryDifferentialAggregate
-  extends PhabricatorFeedStoryAggregate {
-
-  public function renderView() {
-    $data = $this->getStoryData();
-
-    $task_link = $this->linkTo($data->getValue('revision_phid'));
-
-    $authors = $this->getAuthorPHIDs();
-
-    // TODO: These aren't really translatable because linkTo() returns a
-    // string, not an object with a gender.
-
-    switch (count($authors)) {
-      case 1:
-        $author = $this->linkTo(array_shift($authors));
-        $title = pht(
-          '%s made multiple updates to %s',
-          $author,
-          $task_link);
-        break;
-      case 2:
-        $author1 = $this->linkTo(array_shift($authors));
-        $author2 = $this->linkTo(array_shift($authors));
-        $title = pht(
-          '%s and %s made multiple updates to %s',
-          $author1,
-          $author2,
-          $task_link);
-        break;
-      case 3:
-        $author1 = $this->linkTo(array_shift($authors));
-        $author2 = $this->linkTo(array_shift($authors));
-        $author3 = $this->linkTo(array_shift($authors));
-        $title = pht(
-          '%s, %s, and %s made multiple updates to %s',
-          $author1,
-          $author2,
-          $author3,
-          $task_link);
-        break;
-      default:
-        $author1 = $this->linkTo(array_shift($authors));
-        $author2 = $this->linkTo(array_shift($authors));
-        $others  = count($authors);
-        $title = pht(
-          '%s, %s, and %d others made multiple updates to %s',
-          $author1,
-          $author2,
-          $others,
-          $task_link);
-        break;
-    }
-
-    $view = $this->newStoryView();
-    $view->setTitle($title);
-
-    $href = $this->getHandle($data->getValue('revision_phid'))->getURI();
-    $view->setHref($href);
-
-    return $view;
-  }
-
-}
diff --git a/src/applications/feed/story/PhabricatorFeedStoryManiphestAggregate.php b/src/applications/feed/story/PhabricatorFeedStoryManiphestAggregate.php
deleted file mode 100644
index 22a1d8156a..0000000000
--- a/src/applications/feed/story/PhabricatorFeedStoryManiphestAggregate.php
+++ /dev/null
@@ -1,66 +0,0 @@
-<?php
-
-final class PhabricatorFeedStoryManiphestAggregate
-  extends PhabricatorFeedStoryAggregate {
-
-  public function renderView() {
-    $data = $this->getStoryData();
-
-    $task_link = $this->linkTo($data->getValue('taskPHID'));
-
-    $authors = $this->getAuthorPHIDs();
-
-    // TODO: These aren't really translatable because linkTo() returns a
-    // string, not an object with a gender.
-
-    switch (count($authors)) {
-      case 1:
-        $author = $this->linkTo(array_shift($authors));
-        $title = pht(
-          '%s made multiple updates to %s',
-          $author,
-          $task_link);
-        break;
-      case 2:
-        $author1 = $this->linkTo(array_shift($authors));
-        $author2 = $this->linkTo(array_shift($authors));
-        $title = pht(
-          '%s and %s made multiple updates to %s',
-          $author1,
-          $author2,
-          $task_link);
-        break;
-      case 3:
-        $author1 = $this->linkTo(array_shift($authors));
-        $author2 = $this->linkTo(array_shift($authors));
-        $author3 = $this->linkTo(array_shift($authors));
-        $title = pht(
-          '%s, %s, and %s made multiple updates to %s',
-          $author1,
-          $author2,
-          $author3,
-          $task_link);
-        break;
-      default:
-        $author1 = $this->linkTo(array_shift($authors));
-        $author2 = $this->linkTo(array_shift($authors));
-        $others  = count($authors);
-        $title = pht(
-          '%s, %s, and %d others made multiple updates to %s',
-          $author1,
-          $author2,
-          $others,
-          $task_link);
-        break;
-    }
-
-    $view = $this->newStoryView();
-    $view->setTitle($title);
-
-    $href = $this->getHandle($data->getValue('taskPHID'))->getURI();
-    $view->setHref($href);
-
-    return $view;
-  }
-
-}
diff --git a/src/applications/feed/story/PhabricatorFeedStoryPhriction.php b/src/applications/feed/story/PhabricatorFeedStoryPhriction.php
deleted file mode 100644
index 7a91d12ec6..0000000000
--- a/src/applications/feed/story/PhabricatorFeedStoryPhriction.php
+++ /dev/null
@@ -1,95 +0,0 @@
-<?php
-
-final class PhabricatorFeedStoryPhriction extends PhabricatorFeedStory {
-
-  public function getPrimaryObjectPHID() {
-    return $this->getValue('phid');
-  }
-
-  public function getRequiredHandlePHIDs() {
-    $required_phids = parent::getRequiredHandlePHIDs();
-    $from_phid = $this->getStoryData()->getValue('movedFromPHID');
-    if ($from_phid) {
-      $required_phids[] = $from_phid;
-    }
-    return $required_phids;
-  }
-
-  public function renderView() {
-    $data = $this->getStoryData();
-
-    $author_phid = $data->getAuthorPHID();
-    $author_link = $this->linkTo($author_phid);
-    $document_phid = $data->getValue('phid');
-
-    $view = $this->newStoryView();
-
-    $action = $data->getValue('action');
-    $verb = PhrictionActionConstants::getActionPastTenseVerb($action);
-
-    switch ($action) {
-      case PhrictionActionConstants::ACTION_MOVE_HERE:
-        $from_phid = $data->getValue('movedFromPHID');
-
-        // Older feed stories may not have 'moved_from_phid', in that case
-        // we fall back to the default behaviour (hence the fallthrough)
-        if ($from_phid) {
-          $document_handle = $this->getHandle($document_phid);
-          $from_handle = $this->getHandle($from_phid);
-          $view->setTitle(pht(
-            '%s moved the document %s from %s to %s.',
-            $author_link,
-            $document_handle->renderLink(),
-            phutil_tag(
-              'a',
-              array(
-                'href'    => $from_handle->getURI(),
-              ),
-              $from_handle->getURI()),
-            phutil_tag(
-              'a',
-              array(
-                'href'    => $document_handle->getURI(),
-              ),
-              $document_handle->getURI())));
-          break;
-        }
-        /* Fallthrough */
-      default:
-        $view->setTitle(pht(
-          '%s %s the document %s.',
-          $author_link,
-          $verb,
-          $this->linkTo($document_phid)));
-        break;
-    }
-
-    $view->setImage($this->getHandle($author_phid)->getImageURI());
-    switch ($action) {
-      case PhrictionActionConstants::ACTION_CREATE:
-        $content = $this->renderSummary($data->getValue('content'));
-        $view->appendChild($content);
-        break;
-      }
-
-    return $view;
-  }
-
-  public function renderText() {
-    $author_handle = $this->getHandle($this->getAuthorPHID());
-    $author_name = $author_handle->getName();
-
-    $document_handle = $this->getHandle($this->getPrimaryObjectPHID());
-    $document_title = $document_handle->getLinkName();
-    $document_uri = PhabricatorEnv::getURI($document_handle->getURI());
-
-    $action = $this->getValue('action');
-    $verb = PhrictionActionConstants::getActionPastTenseVerb($action);
-
-    $text = "{$author_name} {$verb} the document".
-            " {$document_title} {$document_uri}";
-
-    return $text;
-  }
-
-}
diff --git a/src/applications/notification/builder/PhabricatorNotificationBuilder.php b/src/applications/notification/builder/PhabricatorNotificationBuilder.php
index 46c73003ea..b39baf4561 100644
--- a/src/applications/notification/builder/PhabricatorNotificationBuilder.php
+++ b/src/applications/notification/builder/PhabricatorNotificationBuilder.php
@@ -26,32 +26,6 @@ final class PhabricatorNotificationBuilder {
     // nowhere sensible for the notification to link to, and no reasonable way
     // to unambiguously clear it.
 
-    // Each notification emits keys it can aggregate on. For instance, if this
-    // story is "a updated T123", it might emit a key like this:
-    //
-    //   task:phid123:unread => PhabricatorFeedStoryManiphestAggregate
-    //
-    // All the unread notifications about the task with PHID "phid123" will
-    // emit the same key, telling us we can aggregate them into a single
-    // story of type "PhabricatorFeedStoryManiphestAggregate", which could
-    // read like "a and b updated T123".
-    //
-    // A story might be able to aggregate in multiple ways. Although this is
-    // unlikely for stories in a notification context, stories in a feed context
-    // can also aggregate by actor:
-    //
-    //   task:phid123   => PhabricatorFeedStoryManiphestAggregate
-    //   actor:user123  => PhabricatorFeedStoryActorAggregate
-    //
-    // This means the story can either become "a and b updated T123" or
-    // "a updated T123 and T456". When faced with multiple possibilities, it's
-    // our job to choose the best aggregation.
-    //
-    // For now, we use a simple greedy algorithm and repeatedly select the
-    // aggregate story which consumes the largest number of individual stories
-    // until no aggregate story exists that consumes more than one story.
-
-
     // Build up a map of all the possible aggregations.
 
     $chronokey_map = array();

From f05a7ed7b56ab2b37b5e483794c1d199581134d6 Mon Sep 17 00:00:00 2001
From: Bob Trahan <btrahan@phacility.com>
Date: Tue, 19 May 2015 14:27:47 -0700
Subject: [PATCH 64/86] Transactions - fix inverse edge transaction writes

Summary: Ref XXXXX. I broke things a bit in XXXXX in that if the TYPE_EDGE had an inverse transaction, we weren't correctly "doing nothing" and instead were falling back to our old every editor has to implement a no-op ways... Fix things by putting the TYPE_EDGE code in the handle external builtin function like it belongs.

Test Plan: made a comment on a task referencng a commit successfully

Reviewers: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6403

Differential Revision: https://secure.phabricator.com/D12939
---
 ...habricatorApplicationTransactionEditor.php | 109 +++++++++---------
 1 file changed, 56 insertions(+), 53 deletions(-)

diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
index 0329613b0e..8c9c26bfe9 100644
--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
@@ -438,61 +438,10 @@ abstract class PhabricatorApplicationTransactionEditor
         $this->subscribers = $subscribers;
         return $this->applyBuiltinExternalTransaction($object, $xaction);
 
-      case PhabricatorTransactions::TYPE_EDGE:
-        if ($this->getIsInverseEdgeEditor()) {
-          // If we're writing an inverse edge transaction, don't actually
-          // do anything. The initiating editor on the other side of the
-          // transaction will take care of the edge writes.
-          break;
-        }
-
-        $old = $xaction->getOldValue();
-        $new = $xaction->getNewValue();
-        $src = $object->getPHID();
-        $const = $xaction->getMetadataValue('edge:type');
-
-        $type = PhabricatorEdgeType::getByConstant($const);
-        if ($type->shouldWriteInverseTransactions()) {
-          $this->applyInverseEdgeTransactions(
-            $object,
-            $xaction,
-            $type->getInverseEdgeConstant());
-        }
-
-        foreach ($new as $dst_phid => $edge) {
-          $new[$dst_phid]['src'] = $src;
-        }
-
-        $editor = new PhabricatorEdgeEditor();
-
-        foreach ($old as $dst_phid => $edge) {
-          if (!empty($new[$dst_phid])) {
-            if ($old[$dst_phid]['data'] === $new[$dst_phid]['data']) {
-              continue;
-            }
-          }
-          $editor->removeEdge($src, $const, $dst_phid);
-        }
-
-        foreach ($new as $dst_phid => $edge) {
-          if (!empty($old[$dst_phid])) {
-            if ($old[$dst_phid]['data'] === $new[$dst_phid]['data']) {
-              continue;
-            }
-          }
-
-          $data = array(
-            'data' => $edge['data'],
-          );
-
-          $editor->addEdge($src, $const, $dst_phid, $data);
-        }
-
-        $editor->save();
-        return $this->applyBuiltinExternalTransaction($object, $xaction);
       case PhabricatorTransactions::TYPE_CUSTOMFIELD:
         $field = $this->getCustomFieldForTransaction($object, $xaction);
         return $field->applyApplicationTransactionExternalEffects($xaction);
+      case PhabricatorTransactions::TYPE_EDGE:
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
       case PhabricatorTransactions::TYPE_JOIN_POLICY:
@@ -547,7 +496,61 @@ abstract class PhabricatorApplicationTransactionEditor
   protected function applyBuiltinExternalTransaction(
     PhabricatorLiskDAO $object,
     PhabricatorApplicationTransaction $xaction) {
-    return;
+
+    switch ($xaction->getTransactionType()) {
+      case PhabricatorTransactions::TYPE_EDGE:
+        if ($this->getIsInverseEdgeEditor()) {
+          // If we're writing an inverse edge transaction, don't actually
+          // do anything. The initiating editor on the other side of the
+          // transaction will take care of the edge writes.
+          break;
+        }
+
+        $old = $xaction->getOldValue();
+        $new = $xaction->getNewValue();
+        $src = $object->getPHID();
+        $const = $xaction->getMetadataValue('edge:type');
+
+        $type = PhabricatorEdgeType::getByConstant($const);
+        if ($type->shouldWriteInverseTransactions()) {
+          $this->applyInverseEdgeTransactions(
+            $object,
+            $xaction,
+            $type->getInverseEdgeConstant());
+        }
+
+        foreach ($new as $dst_phid => $edge) {
+          $new[$dst_phid]['src'] = $src;
+        }
+
+        $editor = new PhabricatorEdgeEditor();
+
+        foreach ($old as $dst_phid => $edge) {
+          if (!empty($new[$dst_phid])) {
+            if ($old[$dst_phid]['data'] === $new[$dst_phid]['data']) {
+              continue;
+            }
+          }
+          $editor->removeEdge($src, $const, $dst_phid);
+        }
+
+        foreach ($new as $dst_phid => $edge) {
+          if (!empty($old[$dst_phid])) {
+            if ($old[$dst_phid]['data'] === $new[$dst_phid]['data']) {
+              continue;
+            }
+          }
+
+          $data = array(
+            'data' => $edge['data'],
+          );
+
+          $editor->addEdge($src, $const, $dst_phid, $data);
+        }
+
+        $editor->save();
+        break;
+    }
   }
 
   /**

From c896aeb62ed94dfd5d778d0faa294d04275b0de1 Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@joshuaspence.com>
Date: Wed, 20 May 2015 07:06:07 +1000
Subject: [PATCH 65/86] Various linter fixes

Summary: Apply various linter fixes.

Test Plan: Unit tests + eyeballing.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: hach-que, Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D12390
---
 src/aphront/AphrontRequest.php                | 82 +++++++++----------
 src/aphront/AphrontURIMapper.php              |  6 +-
 src/aphront/response/AphrontJSONResponse.php  |  2 +-
 .../celerity/CelerityResourceGraph.php        |  2 +-
 .../ConpherenceUpdateController.php           |  2 +-
 ...abricatorDashboardPanelRenderingEngine.php |  4 +-
 .../diffusion/data/DiffusionPathChange.php    | 30 +++----
 .../query/DiffusionRenameHistoryQuery.php     |  2 +-
 .../pathchange/DiffusionPathChangeQuery.php   |  8 +-
 .../files/storage/PhabricatorFile.php         |  2 +-
 .../herald/adapter/HeraldAdapter.php          |  6 +-
 .../LegalpadDocumentSignController.php        |  2 +-
 .../PhabricatorMetaMTAReceivedMail.php        |  2 +-
 ...PhabricatorNotificationPanelController.php |  2 +-
 .../oauthserver/PhabricatorOAuthServer.php    |  2 +-
 .../PhabricatorOwnersDetailController.php     |  2 +-
 .../PhabricatorOwnersListController.php       |  2 +-
 .../PhabricatorPeopleController.php           |  4 -
 .../pholio/editor/PholioMockEditor.php        |  6 +-
 .../pholio/view/PholioMockImagesView.php      |  4 +-
 .../PhabricatorProjectTransactionEditor.php   |  2 +-
 ...ReleephWorkNextRequestConduitAPIMethod.php |  2 +-
 ...entialReleephRequestFieldSpecification.php |  2 +-
 .../ReleephRequestTransactionalEditor.php     |  2 +-
 .../releeph/storage/ReleephRequest.php        |  7 --
 .../storage/ReleephRequestTransaction.php     |  4 -
 .../query/PhabricatorTokenCountQuery.php      |  2 +-
 ...catorApplicationTransactionCommentView.php |  2 +-
 .../events/PhabricatorEvent.php               |  4 -
 .../DefaultDatabaseConfigurationProvider.php  |  2 +-
 .../storage/lisk/LiskDAOSet.php               |  2 +-
 src/view/AphrontDialogView.php                |  2 +-
 src/view/AphrontJavelinView.php               |  6 +-
 src/view/control/AphrontCursorPagerView.php   | 28 +++----
 src/view/control/AphrontPagerView.php         | 20 ++---
 src/view/form/PHUIInfoView.php                |  2 +-
 src/view/layout/PhabricatorSourceCodeView.php |  2 +-
 src/view/phui/PHUITimelineView.php            |  2 +-
 38 files changed, 123 insertions(+), 142 deletions(-)

diff --git a/src/aphront/AphrontRequest.php b/src/aphront/AphrontRequest.php
index ab6e0d9820..4aa52c1fcb 100644
--- a/src/aphront/AphrontRequest.php
+++ b/src/aphront/AphrontRequest.php
@@ -28,44 +28,44 @@ final class AphrontRequest {
   private $applicationConfiguration;
   private $uriData;
 
-  final public function __construct($host, $path) {
+  public function __construct($host, $path) {
     $this->host = $host;
     $this->path = $path;
   }
 
-  final public function setURIMap(array $uri_data) {
+  public function setURIMap(array $uri_data) {
     $this->uriData = $uri_data;
     return $this;
   }
 
-  final public function getURIMap() {
+  public function getURIMap() {
     return $this->uriData;
   }
 
-  final public function getURIData($key, $default = null) {
+  public function getURIData($key, $default = null) {
     return idx($this->uriData, $key, $default);
   }
 
-  final public function setApplicationConfiguration(
+  public function setApplicationConfiguration(
     $application_configuration) {
     $this->applicationConfiguration = $application_configuration;
     return $this;
   }
 
-  final public function getApplicationConfiguration() {
+  public function getApplicationConfiguration() {
     return $this->applicationConfiguration;
   }
 
-  final public function setPath($path) {
+  public function setPath($path) {
     $this->path = $path;
     return $this;
   }
 
-  final public function getPath() {
+  public function getPath() {
     return $this->path;
   }
 
-  final public function getHost() {
+  public function getHost() {
     // The "Host" header may include a port number, or may be a malicious
     // header in the form "realdomain.com:ignored@evil.com". Invoke the full
     // parser to extract the real domain correctly. See here for coverage of
@@ -83,7 +83,7 @@ final class AphrontRequest {
   /**
    * @task data
    */
-  final public function setRequestData(array $request_data) {
+  public function setRequestData(array $request_data) {
     $this->requestData = $request_data;
     return $this;
   }
@@ -92,7 +92,7 @@ final class AphrontRequest {
   /**
    * @task data
    */
-  final public function getRequestData() {
+  public function getRequestData() {
     return $this->requestData;
   }
 
@@ -100,7 +100,7 @@ final class AphrontRequest {
   /**
    * @task data
    */
-  final public function getInt($name, $default = null) {
+  public function getInt($name, $default = null) {
     if (isset($this->requestData[$name])) {
       return (int)$this->requestData[$name];
     } else {
@@ -112,7 +112,7 @@ final class AphrontRequest {
   /**
    * @task data
    */
-  final public function getBool($name, $default = null) {
+  public function getBool($name, $default = null) {
     if (isset($this->requestData[$name])) {
       if ($this->requestData[$name] === 'true') {
         return true;
@@ -130,7 +130,7 @@ final class AphrontRequest {
   /**
    * @task data
    */
-  final public function getStr($name, $default = null) {
+  public function getStr($name, $default = null) {
     if (isset($this->requestData[$name])) {
       $str = (string)$this->requestData[$name];
       // Normalize newline craziness.
@@ -148,7 +148,7 @@ final class AphrontRequest {
   /**
    * @task data
    */
-  final public function getArr($name, $default = array()) {
+  public function getArr($name, $default = array()) {
     if (isset($this->requestData[$name]) &&
         is_array($this->requestData[$name])) {
       return $this->requestData[$name];
@@ -161,7 +161,7 @@ final class AphrontRequest {
   /**
    * @task data
    */
-  final public function getStrList($name, $default = array()) {
+  public function getStrList($name, $default = array()) {
     if (!isset($this->requestData[$name])) {
       return $default;
     }
@@ -174,36 +174,36 @@ final class AphrontRequest {
   /**
    * @task data
    */
-  final public function getExists($name) {
+  public function getExists($name) {
     return array_key_exists($name, $this->requestData);
   }
 
-  final public function getFileExists($name) {
+  public function getFileExists($name) {
     return isset($_FILES[$name]) &&
            (idx($_FILES[$name], 'error') !== UPLOAD_ERR_NO_FILE);
   }
 
-  final public function isHTTPGet() {
+  public function isHTTPGet() {
     return ($_SERVER['REQUEST_METHOD'] == 'GET');
   }
 
-  final public function isHTTPPost() {
+  public function isHTTPPost() {
     return ($_SERVER['REQUEST_METHOD'] == 'POST');
   }
 
-  final public function isAjax() {
+  public function isAjax() {
     return $this->getExists(self::TYPE_AJAX) && !$this->isQuicksand();
   }
 
-  final public function isWorkflow() {
+  public function isWorkflow() {
     return $this->getExists(self::TYPE_WORKFLOW) && !$this->isQuicksand();
   }
 
-  final public function isQuicksand() {
+  public function isQuicksand() {
     return $this->getExists(self::TYPE_QUICKSAND);
   }
 
-  final public function isConduit() {
+  public function isConduit() {
     return $this->getExists(self::TYPE_CONDUIT);
   }
 
@@ -215,7 +215,7 @@ final class AphrontRequest {
     return 'X-Phabricator-Csrf';
   }
 
-  final public function validateCSRF() {
+  public function validateCSRF() {
     $token_name = self::getCSRFTokenName();
     $token = $this->getStr($token_name);
 
@@ -281,7 +281,7 @@ final class AphrontRequest {
     return true;
   }
 
-  final public function isFormPost() {
+  public function isFormPost() {
     $post = $this->getExists(self::TYPE_FORM) &&
             !$this->getExists(self::TYPE_HISEC) &&
             $this->isHTTPPost();
@@ -293,7 +293,7 @@ final class AphrontRequest {
     return $this->validateCSRF();
   }
 
-  final public function isFormOrHisecPost() {
+  public function isFormOrHisecPost() {
     $post = $this->getExists(self::TYPE_FORM) &&
             $this->isHTTPPost();
 
@@ -305,12 +305,12 @@ final class AphrontRequest {
   }
 
 
-  final public function setCookiePrefix($prefix) {
+  public function setCookiePrefix($prefix) {
     $this->cookiePrefix = $prefix;
     return $this;
   }
 
-  final private function getPrefixedCookieName($name) {
+  private function getPrefixedCookieName($name) {
     if (strlen($this->cookiePrefix)) {
       return $this->cookiePrefix.'_'.$name;
     } else {
@@ -318,7 +318,7 @@ final class AphrontRequest {
     }
   }
 
-  final public function getCookie($name, $default = null) {
+  public function getCookie($name, $default = null) {
     $name = $this->getPrefixedCookieName($name);
     $value = idx($_COOKIE, $name, $default);
 
@@ -337,7 +337,7 @@ final class AphrontRequest {
     return $value;
   }
 
-  final public function clearCookie($name) {
+  public function clearCookie($name) {
     $this->setCookieWithExpiration($name, '', time() - (60 * 60 * 24 * 30));
     unset($_COOKIE[$name]);
   }
@@ -390,7 +390,7 @@ final class AphrontRequest {
    *
    * @task cookie
    */
-  final public function canSetCookies() {
+  public function canSetCookies() {
     return (bool)$this->getCookieDomainURI();
   }
 
@@ -405,7 +405,7 @@ final class AphrontRequest {
    * @return this
    * @task cookie
    */
-  final public function setCookie($name, $value) {
+  public function setCookie($name, $value) {
     $far_future = time() + (60 * 60 * 24 * 365 * 5);
     return $this->setCookieWithExpiration($name, $value, $far_future);
   }
@@ -421,7 +421,7 @@ final class AphrontRequest {
    * @return this
    * @task cookie
    */
-  final public function setTemporaryCookie($name, $value) {
+  public function setTemporaryCookie($name, $value) {
     return $this->setCookieWithExpiration($name, $value, 0);
   }
 
@@ -435,7 +435,7 @@ final class AphrontRequest {
    * @return this
    * @task cookie
    */
-  final private function setCookieWithExpiration(
+  private function setCookieWithExpiration(
     $name,
     $value,
     $expire) {
@@ -485,31 +485,31 @@ final class AphrontRequest {
     return $this;
   }
 
-  final public function setUser($user) {
+  public function setUser($user) {
     $this->user = $user;
     return $this;
   }
 
-  final public function getUser() {
+  public function getUser() {
     return $this->user;
   }
 
-  final public function getViewer() {
+  public function getViewer() {
     return $this->user;
   }
 
-  final public function getRequestURI() {
+  public function getRequestURI() {
     $get = $_GET;
     unset($get['__path__']);
     $path = phutil_escape_uri($this->getPath());
     return id(new PhutilURI($path))->setQueryParams($get);
   }
 
-  final public function isDialogFormPost() {
+  public function isDialogFormPost() {
     return $this->isFormPost() && $this->getStr('__dialog__');
   }
 
-  final public function getRemoteAddr() {
+  public function getRemoteAddr() {
     return $_SERVER['REMOTE_ADDR'];
   }
 
diff --git a/src/aphront/AphrontURIMapper.php b/src/aphront/AphrontURIMapper.php
index 9c68f2485f..32f464911a 100644
--- a/src/aphront/AphrontURIMapper.php
+++ b/src/aphront/AphrontURIMapper.php
@@ -4,11 +4,11 @@ final class AphrontURIMapper {
 
   private $map;
 
-  final public function __construct(array $map) {
+  public function __construct(array $map) {
     $this->map = $map;
   }
 
-  final public function mapPath($path) {
+  public function mapPath($path) {
     $map = $this->map;
     foreach ($map as $rule => $value) {
       list($controller, $data) = $this->tryRule($rule, $value, $path);
@@ -25,7 +25,7 @@ final class AphrontURIMapper {
     return array(null, null);
   }
 
-  final private function tryRule($rule, $value, $path) {
+  private function tryRule($rule, $value, $path) {
     $match = null;
     $pattern = '#^'.$rule.(is_array($value) ? '' : '$').'#';
     if (!preg_match($pattern, $path, $match)) {
diff --git a/src/aphront/response/AphrontJSONResponse.php b/src/aphront/response/AphrontJSONResponse.php
index a9493a6282..3d1c429d41 100644
--- a/src/aphront/response/AphrontJSONResponse.php
+++ b/src/aphront/response/AphrontJSONResponse.php
@@ -19,7 +19,7 @@ final class AphrontJSONResponse extends AphrontResponse {
     if ($this->addJSONShield === null) {
       return true;
     }
-    return (bool) $this->addJSONShield;
+    return (bool)$this->addJSONShield;
   }
 
   public function buildResponseString() {
diff --git a/src/applications/celerity/CelerityResourceGraph.php b/src/applications/celerity/CelerityResourceGraph.php
index 715a64c35c..3aa5c12497 100644
--- a/src/applications/celerity/CelerityResourceGraph.php
+++ b/src/applications/celerity/CelerityResourceGraph.php
@@ -18,7 +18,7 @@ final class CelerityResourceGraph extends AbstractDirectedGraph {
     return $edges;
   }
 
-  final public function setResourceGraph(array $graph) {
+  public function setResourceGraph(array $graph) {
     $this->resourceGraph = $graph;
     $this->graphSet = true;
     return $this;
diff --git a/src/applications/conpherence/controller/ConpherenceUpdateController.php b/src/applications/conpherence/controller/ConpherenceUpdateController.php
index d37fefdf14..8d7db7691c 100644
--- a/src/applications/conpherence/controller/ConpherenceUpdateController.php
+++ b/src/applications/conpherence/controller/ConpherenceUpdateController.php
@@ -550,7 +550,7 @@ final class ConpherenceUpdateController
     $content = array(
       'non_update' => $non_update,
       'transactions' => hsprintf('%s', $rendered_transactions),
-      'conpherence_title' => (string) $data['title'],
+      'conpherence_title' => (string)$data['title'],
       'latest_transaction_id' => $new_latest_transaction_id,
       'nav_item' => $nav_item,
       'conpherence_phid' => $conpherence->getPHID(),
diff --git a/src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php b/src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php
index e8f796fa59..dfba37eaa5 100644
--- a/src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php
+++ b/src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php
@@ -246,7 +246,7 @@ final class PhabricatorDashboardPanelRenderingEngine extends Phobject {
     $action_edit = id(new PHUIIconView())
       ->setIconFont('fa-pencil')
       ->setWorkflow(true)
-      ->setHref((string) $edit_uri);
+      ->setHref((string)$edit_uri);
     $header->addAction($action_edit);
 
     if ($dashboard_id) {
@@ -255,7 +255,7 @@ final class PhabricatorDashboardPanelRenderingEngine extends Phobject {
         ->setQueryParam('panelPHID', $panel->getPHID());
       $action_remove = id(new PHUIIconView())
         ->setIconFont('fa-trash-o')
-        ->setHref((string) $uri)
+        ->setHref((string)$uri)
         ->setWorkflow(true);
       $header->addAction($action_remove);
     }
diff --git a/src/applications/diffusion/data/DiffusionPathChange.php b/src/applications/diffusion/data/DiffusionPathChange.php
index 6f96057014..939fea9449 100644
--- a/src/applications/diffusion/data/DiffusionPathChange.php
+++ b/src/applications/diffusion/data/DiffusionPathChange.php
@@ -13,12 +13,12 @@ final class DiffusionPathChange {
   private $targetCommitIdentifier;
   private $awayPaths = array();
 
-  final public function setPath($path) {
+  public function setPath($path) {
     $this->path = $path;
     return $this;
   }
 
-  final public function getPath() {
+  public function getPath() {
     return $this->path;
   }
 
@@ -58,58 +58,58 @@ final class DiffusionPathChange {
     return $this->awayPaths;
   }
 
-  final public function setCommitIdentifier($commit) {
+  public function setCommitIdentifier($commit) {
     $this->commitIdentifier = $commit;
     return $this;
   }
 
-  final public function getCommitIdentifier() {
+  public function getCommitIdentifier() {
     return $this->commitIdentifier;
   }
 
-  final public function setTargetCommitIdentifier($target_commit_identifier) {
+  public function setTargetCommitIdentifier($target_commit_identifier) {
     $this->targetCommitIdentifier = $target_commit_identifier;
     return $this;
   }
 
-  final public function getTargetCommitIdentifier() {
+  public function getTargetCommitIdentifier() {
     return $this->targetCommitIdentifier;
   }
 
-  final public function setCommit($commit) {
+  public function setCommit($commit) {
     $this->commit = $commit;
     return $this;
   }
 
-  final public function getCommit() {
+  public function getCommit() {
     return $this->commit;
   }
 
-  final public function setCommitData($commit_data) {
+  public function setCommitData($commit_data) {
     $this->commitData = $commit_data;
     return $this;
   }
 
-  final public function getCommitData() {
+  public function getCommitData() {
     return $this->commitData;
   }
 
 
-  final public function getEpoch() {
+  public function getEpoch() {
     if ($this->getCommit()) {
       return $this->getCommit()->getEpoch();
     }
     return null;
   }
 
-  final public function getAuthorName() {
+  public function getAuthorName() {
     if ($this->getCommitData()) {
       return $this->getCommitData()->getAuthorName();
     }
     return null;
   }
 
-  final public function getSummary() {
+  public function getSummary() {
     if (!$this->getCommitData()) {
       return null;
     }
@@ -118,7 +118,7 @@ final class DiffusionPathChange {
     return substr($first, 0, 80);
   }
 
-  final public static function convertToArcanistChanges(array $changes) {
+  public static function convertToArcanistChanges(array $changes) {
     assert_instances_of($changes, __CLASS__);
     $direct = array();
     $result = array();
@@ -142,7 +142,7 @@ final class DiffusionPathChange {
     return array_select_keys($result, $direct);
   }
 
-  final public static function convertToDifferentialChangesets(
+  public static function convertToDifferentialChangesets(
     PhabricatorUser $user,
     array $changes) {
     assert_instances_of($changes, __CLASS__);
diff --git a/src/applications/diffusion/query/DiffusionRenameHistoryQuery.php b/src/applications/diffusion/query/DiffusionRenameHistoryQuery.php
index 537364b0ce..a8f5615192 100644
--- a/src/applications/diffusion/query/DiffusionRenameHistoryQuery.php
+++ b/src/applications/diffusion/query/DiffusionRenameHistoryQuery.php
@@ -30,7 +30,7 @@ final class DiffusionRenameHistoryQuery {
     return $this->oldCommit;
   }
 
-  final public function loadOldFilename() {
+  public function loadOldFilename() {
     $drequest = $this->request;
     $repository_id = $drequest->getRepository()->getID();
     $conn_r = id(new PhabricatorRepository())->establishConnection('r');
diff --git a/src/applications/diffusion/query/pathchange/DiffusionPathChangeQuery.php b/src/applications/diffusion/query/pathchange/DiffusionPathChangeQuery.php
index c661e55226..d2f4a2b690 100644
--- a/src/applications/diffusion/query/pathchange/DiffusionPathChangeQuery.php
+++ b/src/applications/diffusion/query/pathchange/DiffusionPathChangeQuery.php
@@ -14,11 +14,11 @@ final class DiffusionPathChangeQuery {
     return $this->limit;
   }
 
-  final private function __construct() {
+  private function __construct() {
     // <private>
   }
 
-  final public static function newFromDiffusionRequest(
+  public static function newFromDiffusionRequest(
     DiffusionRequest $request) {
     $query = new DiffusionPathChangeQuery();
     $query->request = $request;
@@ -26,11 +26,11 @@ final class DiffusionPathChangeQuery {
     return $query;
   }
 
-  final protected function getRequest() {
+  protected function getRequest() {
     return $this->request;
   }
 
-  final public function loadChanges() {
+  public function loadChanges() {
     return $this->executeQuery();
   }
 
diff --git a/src/applications/files/storage/PhabricatorFile.php b/src/applications/files/storage/PhabricatorFile.php
index f8e99bc965..c236a2368e 100644
--- a/src/applications/files/storage/PhabricatorFile.php
+++ b/src/applications/files/storage/PhabricatorFile.php
@@ -758,7 +758,7 @@ final class PhabricatorFile extends PhabricatorFileDAO
   public function getDownloadURI() {
     $uri = id(new PhutilURI($this->getViewURI()))
       ->setQueryParam('download', true);
-    return (string) $uri;
+    return (string)$uri;
   }
 
   public function getURIForTransform(PhabricatorFileTransform $transform) {
diff --git a/src/applications/herald/adapter/HeraldAdapter.php b/src/applications/herald/adapter/HeraldAdapter.php
index f56572a398..ca52b8da15 100644
--- a/src/applications/herald/adapter/HeraldAdapter.php
+++ b/src/applications/herald/adapter/HeraldAdapter.php
@@ -166,7 +166,7 @@ abstract class HeraldAdapter {
     throw new Exception(pht('You must setIsNewObject to a boolean first!'));
   }
   public function setIsNewObject($new) {
-    $this->isNewObject = (bool) $new;
+    $this->isNewObject = (bool)$new;
     return $this;
   }
 
@@ -681,9 +681,9 @@ abstract class HeraldAdapter {
         }
         return $result;
       case self::CONDITION_HAS_BIT:
-        return (($condition_value & $field_value) === (int) $condition_value);
+        return (($condition_value & $field_value) === (int)$condition_value);
       case self::CONDITION_NOT_BIT:
-        return (($condition_value & $field_value) !== (int) $condition_value);
+        return (($condition_value & $field_value) !== (int)$condition_value);
       default:
         throw new HeraldInvalidConditionException(
           "Unknown condition '{$condition_type}'.");
diff --git a/src/applications/legalpad/controller/LegalpadDocumentSignController.php b/src/applications/legalpad/controller/LegalpadDocumentSignController.php
index b1c23f5d9a..4cd2f59b4c 100644
--- a/src/applications/legalpad/controller/LegalpadDocumentSignController.php
+++ b/src/applications/legalpad/controller/LegalpadDocumentSignController.php
@@ -199,7 +199,7 @@ final class LegalpadDocumentSignController extends LegalpadController {
           $next_uri = '/'.$document->getMonogram();
           if ($document->getRequireSignature()) {
             $request_uri = $request->getRequestURI();
-            $next_uri = (string) $request_uri;
+            $next_uri = (string)$request_uri;
           }
         } else {
           $this->sendVerifySignatureEmail(
diff --git a/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php b/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php
index fa5ad7f752..91634fe577 100644
--- a/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php
+++ b/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php
@@ -90,7 +90,7 @@ final class PhabricatorMetaMTAReceivedMail extends PhabricatorMetaMTADAO {
     return $this->loadPHIDsFromAddresses($addresses);
   }
 
-  final public function loadCCPHIDs() {
+  public function loadCCPHIDs() {
     return $this->loadPHIDsFromAddresses($this->getCCAddresses());
   }
 
diff --git a/src/applications/notification/controller/PhabricatorNotificationPanelController.php b/src/applications/notification/controller/PhabricatorNotificationPanelController.php
index 850bfe7392..3e8f16b07a 100644
--- a/src/applications/notification/controller/PhabricatorNotificationPanelController.php
+++ b/src/applications/notification/controller/PhabricatorNotificationPanelController.php
@@ -34,7 +34,7 @@ final class PhabricatorNotificationPanelController
       'a',
       array(
         'sigil' => 'workflow',
-        'href' => (string) $clear_uri,
+        'href' => (string)$clear_uri,
         'class' => $clear_ui_class,
       ),
       pht('Mark All Read'));
diff --git a/src/applications/oauthserver/PhabricatorOAuthServer.php b/src/applications/oauthserver/PhabricatorOAuthServer.php
index 228ea8e61e..b7dc0d6301 100644
--- a/src/applications/oauthserver/PhabricatorOAuthServer.php
+++ b/src/applications/oauthserver/PhabricatorOAuthServer.php
@@ -112,7 +112,7 @@ final class PhabricatorOAuthServer {
     $authorization_code->setClientPHID($client->getPHID());
     $authorization_code->setClientSecret($client->getSecret());
     $authorization_code->setUserPHID($this->getUser()->getPHID());
-    $authorization_code->setRedirectURI((string) $redirect_uri);
+    $authorization_code->setRedirectURI((string)$redirect_uri);
     $authorization_code->save();
 
     return $authorization_code;
diff --git a/src/applications/owners/controller/PhabricatorOwnersDetailController.php b/src/applications/owners/controller/PhabricatorOwnersDetailController.php
index 1db98f14aa..0b50db02d5 100644
--- a/src/applications/owners/controller/PhabricatorOwnersDetailController.php
+++ b/src/applications/owners/controller/PhabricatorOwnersDetailController.php
@@ -92,7 +92,7 @@ final class PhabricatorOwnersDetailController
       $path_link = phutil_tag(
         'a',
         array(
-          'href' => (string) $href,
+          'href' => (string)$href,
         ),
         $path->getPath());
       $path_links[] = hsprintf(
diff --git a/src/applications/owners/controller/PhabricatorOwnersListController.php b/src/applications/owners/controller/PhabricatorOwnersListController.php
index ef7b01ebfb..2a206616e6 100644
--- a/src/applications/owners/controller/PhabricatorOwnersListController.php
+++ b/src/applications/owners/controller/PhabricatorOwnersListController.php
@@ -285,7 +285,7 @@ final class PhabricatorOwnersListController
             phutil_tag(
               'a',
               array(
-                'href' => (string) $href,
+                'href' => (string)$href,
               ),
               $path->getPath()));
         } else {
diff --git a/src/applications/people/controller/PhabricatorPeopleController.php b/src/applications/people/controller/PhabricatorPeopleController.php
index 5b06364bbd..4366c39758 100644
--- a/src/applications/people/controller/PhabricatorPeopleController.php
+++ b/src/applications/people/controller/PhabricatorPeopleController.php
@@ -45,10 +45,6 @@ abstract class PhabricatorPeopleController extends PhabricatorController {
     return $this->buildSideNavView(true)->getMenu();
   }
 
-  protected function buildApplicationCrumbs() {
-    return parent::buildApplicationCrumbs();
-  }
-
   public function buildIconNavView(PhabricatorUser $user) {
     $viewer = $this->getViewer();
     $picture = $user->getProfileImageURI();
diff --git a/src/applications/pholio/editor/PholioMockEditor.php b/src/applications/pholio/editor/PholioMockEditor.php
index cd36b563b3..87d8d51167 100644
--- a/src/applications/pholio/editor/PholioMockEditor.php
+++ b/src/applications/pholio/editor/PholioMockEditor.php
@@ -260,19 +260,19 @@ final class PholioMockEditor extends PhabricatorApplicationTransactionEditor {
         break;
       case PholioTransactionType::TYPE_IMAGE_NAME:
         $image = $this->getImageForXaction($object, $xaction);
-        $value = (string) head($xaction->getNewValue());
+        $value = (string)head($xaction->getNewValue());
         $image->setName($value);
         $image->save();
         break;
       case PholioTransactionType::TYPE_IMAGE_DESCRIPTION:
         $image = $this->getImageForXaction($object, $xaction);
-        $value = (string) head($xaction->getNewValue());
+        $value = (string)head($xaction->getNewValue());
         $image->setDescription($value);
         $image->save();
         break;
       case PholioTransactionType::TYPE_IMAGE_SEQUENCE:
         $image = $this->getImageForXaction($object, $xaction);
-        $value = (int) head($xaction->getNewValue());
+        $value = (int)head($xaction->getNewValue());
         $image->setSequence($value);
         $image->save();
         break;
diff --git a/src/applications/pholio/view/PholioMockImagesView.php b/src/applications/pholio/view/PholioMockImagesView.php
index d59e701579..c1bcb46230 100644
--- a/src/applications/pholio/view/PholioMockImagesView.php
+++ b/src/applications/pholio/view/PholioMockImagesView.php
@@ -137,7 +137,7 @@ final class PholioMockImagesView extends AphrontView {
     );
 
     $login_uri = id(new PhutilURI('/login/'))
-      ->setQueryParam('next', (string) $this->getRequestURI());
+      ->setQueryParam('next', (string)$this->getRequestURI());
 
     $config = array(
       'mockID' => $mock->getID(),
@@ -147,7 +147,7 @@ final class PholioMockImagesView extends AphrontView {
       'images' => $images,
       'selectedID' => $selected_id,
       'loggedIn' => $this->getUser()->isLoggedIn(),
-      'logInLink' => (string) $login_uri,
+      'logInLink' => (string)$login_uri,
       'navsequence' => $navsequence,
       'fullIcon' => hsprintf('%s', $full_icon),
       'downloadIcon' => hsprintf('%s', $download_icon),
diff --git a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
index 307e186dbd..b85c127241 100644
--- a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
+++ b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
@@ -51,7 +51,7 @@ final class PhabricatorProjectTransactionEditor
       case PhabricatorProjectTransaction::TYPE_COLOR:
         return $object->getColor();
       case PhabricatorProjectTransaction::TYPE_LOCKED:
-        return (int) $object->getIsMembershipLocked();
+        return (int)$object->getIsMembershipLocked();
     }
 
     return parent::getCustomTransactionOldValue($object, $xaction);
diff --git a/src/applications/releeph/conduit/work/ReleephWorkNextRequestConduitAPIMethod.php b/src/applications/releeph/conduit/work/ReleephWorkNextRequestConduitAPIMethod.php
index 5e3d004ce6..e161faf082 100644
--- a/src/applications/releeph/conduit/work/ReleephWorkNextRequestConduitAPIMethod.php
+++ b/src/applications/releeph/conduit/work/ReleephWorkNextRequestConduitAPIMethod.php
@@ -177,7 +177,7 @@ final class ReleephWorkNextRequestConduitAPIMethod
     foreach ($releeph_requests as $rq) {
       // TODO: it's likely that relying on the `id` column to provide
       // trunk-commit-order is thoroughly broken.
-      $ordinal = (int) $rq->loadPhabricatorRepositoryCommit()->getID();
+      $ordinal = (int)$rq->loadPhabricatorRepositoryCommit()->getID();
       $surrogate[$ordinal] = $rq;
     }
     ksort($surrogate);
diff --git a/src/applications/releeph/differential/DifferentialReleephRequestFieldSpecification.php b/src/applications/releeph/differential/DifferentialReleephRequestFieldSpecification.php
index 1c2a10eace..6e635ee4b3 100644
--- a/src/applications/releeph/differential/DifferentialReleephRequestFieldSpecification.php
+++ b/src/applications/releeph/differential/DifferentialReleephRequestFieldSpecification.php
@@ -180,7 +180,7 @@ final class DifferentialReleephRequestFieldSpecification {
           "Releeph request token '{$token}'!");
       }
 
-      $id = (int) $match[1];
+      $id = (int)$match[1];
       $releeph_request = id(new ReleephRequest())->load($id);
 
       if (!$releeph_request) {
diff --git a/src/applications/releeph/editor/ReleephRequestTransactionalEditor.php b/src/applications/releeph/editor/ReleephRequestTransactionalEditor.php
index 9e4c0083d2..993079c506 100644
--- a/src/applications/releeph/editor/ReleephRequestTransactionalEditor.php
+++ b/src/applications/releeph/editor/ReleephRequestTransactionalEditor.php
@@ -114,7 +114,7 @@ final class ReleephRequestTransactionalEditor
         break;
 
       case ReleephRequestTransaction::TYPE_MANUAL_IN_BRANCH:
-        $object->setInBranch((int) $new);
+        $object->setInBranch((int)$new);
         break;
     }
   }
diff --git a/src/applications/releeph/storage/ReleephRequest.php b/src/applications/releeph/storage/ReleephRequest.php
index 7f2487107a..f2b51b6d89 100644
--- a/src/applications/releeph/storage/ReleephRequest.php
+++ b/src/applications/releeph/storage/ReleephRequest.php
@@ -293,13 +293,6 @@ final class ReleephRequest extends ReleephDAO
     throw new Exception('`status` is now deprecated!');
   }
 
-/* -(  Make magic Lisk methods private  )------------------------------------ */
-
-  private function setUserIntents(array $ar) {
-    return parent::setUserIntents($ar);
-  }
-
-
 /* -(  PhabricatorApplicationTransactionInterface  )------------------------- */
 
 
diff --git a/src/applications/releeph/storage/ReleephRequestTransaction.php b/src/applications/releeph/storage/ReleephRequestTransaction.php
index f4a4720c78..b12ed6ad8c 100644
--- a/src/applications/releeph/storage/ReleephRequestTransaction.php
+++ b/src/applications/releeph/storage/ReleephRequestTransaction.php
@@ -146,10 +146,6 @@ final class ReleephRequestTransaction
     }
   }
 
-  public function getActionStrength() {
-    return parent::getActionStrength();
-  }
-
   public function getActionName() {
     switch ($this->getTransactionType()) {
       case self::TYPE_REQUEST:
diff --git a/src/applications/tokens/query/PhabricatorTokenCountQuery.php b/src/applications/tokens/query/PhabricatorTokenCountQuery.php
index d942f22ce4..64333715fd 100644
--- a/src/applications/tokens/query/PhabricatorTokenCountQuery.php
+++ b/src/applications/tokens/query/PhabricatorTokenCountQuery.php
@@ -10,7 +10,7 @@ final class PhabricatorTokenCountQuery
     return $this;
   }
 
-  final public function execute() {
+  public function execute() {
     $table = new PhabricatorTokenCount();
     $conn_r = $table->establishConnection('r');
 
diff --git a/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php b/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
index 311c7e8b9f..cbc3739cfb 100644
--- a/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
+++ b/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
@@ -83,7 +83,7 @@ class PhabricatorApplicationTransactionCommentView extends AphrontView {
     $user = $this->getUser();
     if (!$user->isLoggedIn()) {
       $uri = id(new PhutilURI('/login/'))
-        ->setQueryParam('next', (string) $this->getRequestURI());
+        ->setQueryParam('next', (string)$this->getRequestURI());
       return id(new PHUIObjectBoxView())
         ->setFlush(true)
         ->setHeaderText(pht('Add Comment'))
diff --git a/src/infrastructure/events/PhabricatorEvent.php b/src/infrastructure/events/PhabricatorEvent.php
index bfb08b203b..b0e8b28ebd 100644
--- a/src/infrastructure/events/PhabricatorEvent.php
+++ b/src/infrastructure/events/PhabricatorEvent.php
@@ -6,10 +6,6 @@ final class PhabricatorEvent extends PhutilEvent {
   private $aphrontRequest;
   private $conduitRequest;
 
-  public function __construct($type, array $data = array()) {
-    parent::__construct($type, $data);
-  }
-
   public function setUser(PhabricatorUser $user) {
     $this->user = $user;
     return $this;
diff --git a/src/infrastructure/storage/configuration/DefaultDatabaseConfigurationProvider.php b/src/infrastructure/storage/configuration/DefaultDatabaseConfigurationProvider.php
index 839fa2816b..ea83209b43 100644
--- a/src/infrastructure/storage/configuration/DefaultDatabaseConfigurationProvider.php
+++ b/src/infrastructure/storage/configuration/DefaultDatabaseConfigurationProvider.php
@@ -40,7 +40,7 @@ final class DefaultDatabaseConfigurationProvider
     return $this->namespace.'_'.$this->getDao()->getApplicationName();
   }
 
-  final protected function getDao() {
+  protected function getDao() {
     return $this->dao;
   }
 
diff --git a/src/infrastructure/storage/lisk/LiskDAOSet.php b/src/infrastructure/storage/lisk/LiskDAOSet.php
index a554a19b62..399aef3687 100644
--- a/src/infrastructure/storage/lisk/LiskDAOSet.php
+++ b/src/infrastructure/storage/lisk/LiskDAOSet.php
@@ -38,7 +38,7 @@ final class LiskDAOSet {
    * The main purpose of this method is to break cyclic dependency.
    * It removes all objects from this set and all subsets created by it.
    */
-  final public function clearSet() {
+  public function clearSet() {
     $this->daos = array();
     $this->relatives = array();
     foreach ($this->subsets as $set) {
diff --git a/src/view/AphrontDialogView.php b/src/view/AphrontDialogView.php
index 925d76a565..b551c14f35 100644
--- a/src/view/AphrontDialogView.php
+++ b/src/view/AphrontDialogView.php
@@ -174,7 +174,7 @@ final class AphrontDialogView extends AphrontView {
     return $this;
   }
 
-  final public function render() {
+  public function render() {
     require_celerity_resource('aphront-dialog-view-css');
 
     $buttons = array();
diff --git a/src/view/AphrontJavelinView.php b/src/view/AphrontJavelinView.php
index 6471f1f951..7a2954eee3 100644
--- a/src/view/AphrontJavelinView.php
+++ b/src/view/AphrontJavelinView.php
@@ -46,7 +46,7 @@ final class AphrontJavelinView extends AphrontView {
     return $this->name;
   }
 
-  final public function setName($template_name) {
+  public function setName($template_name) {
     $this->name = $template_name;
     return $this;
   }
@@ -55,7 +55,7 @@ final class AphrontJavelinView extends AphrontView {
     return $this->parameters;
   }
 
-  final public function setParameters($template_parameters) {
+  public function setParameters($template_parameters) {
     $this->parameters = $template_parameters;
     return $this;
   }
@@ -64,7 +64,7 @@ final class AphrontJavelinView extends AphrontView {
     return $this->celerityResource;
   }
 
-  final public function setCelerityResource($celerity_resource) {
+  public function setCelerityResource($celerity_resource) {
     $this->celerityResource = $celerity_resource;
     return $this;
   }
diff --git a/src/view/control/AphrontCursorPagerView.php b/src/view/control/AphrontCursorPagerView.php
index 81ab33df81..bc1e872103 100644
--- a/src/view/control/AphrontCursorPagerView.php
+++ b/src/view/control/AphrontCursorPagerView.php
@@ -13,64 +13,64 @@ final class AphrontCursorPagerView extends AphrontView {
 
   private $uri;
 
-  final public function setPageSize($page_size) {
+  public function setPageSize($page_size) {
     $this->pageSize = max(1, $page_size);
     return $this;
   }
 
-  final public function getPageSize() {
+  public function getPageSize() {
     return $this->pageSize;
   }
 
-  final public function setURI(PhutilURI $uri) {
+  public function setURI(PhutilURI $uri) {
     $this->uri = $uri;
     return $this;
   }
 
-  final public function readFromRequest(AphrontRequest $request) {
+  public function readFromRequest(AphrontRequest $request) {
     $this->uri = $request->getRequestURI();
     $this->afterID = $request->getStr('after');
     $this->beforeID = $request->getStr('before');
     return $this;
   }
 
-  final public function setAfterID($after_id) {
+  public function setAfterID($after_id) {
     $this->afterID = $after_id;
     return $this;
   }
 
-  final public function getAfterID() {
+  public function getAfterID() {
     return $this->afterID;
   }
 
-  final public function setBeforeID($before_id) {
+  public function setBeforeID($before_id) {
     $this->beforeID = $before_id;
     return $this;
   }
 
-  final public function getBeforeID() {
+  public function getBeforeID() {
     return $this->beforeID;
   }
 
-  final public function setNextPageID($next_page_id) {
+  public function setNextPageID($next_page_id) {
     $this->nextPageID = $next_page_id;
     return $this;
   }
 
-  final public function getNextPageID() {
+  public function getNextPageID() {
     return $this->nextPageID;
   }
 
-  final public function setPrevPageID($prev_page_id) {
+  public function setPrevPageID($prev_page_id) {
     $this->prevPageID = $prev_page_id;
     return $this;
   }
 
-  final public function getPrevPageID() {
+  public function getPrevPageID() {
     return $this->prevPageID;
   }
 
-  final public function sliceResults(array $results) {
+  public function sliceResults(array $results) {
     if (count($results) > $this->getPageSize()) {
       $offset = ($this->beforeID ? count($results) - $this->getPageSize() : 0);
       $results = array_slice($results, $offset, $this->getPageSize(), true);
@@ -79,7 +79,7 @@ final class AphrontCursorPagerView extends AphrontView {
     return $results;
   }
 
-  final public function getHasMoreResults() {
+  public function getHasMoreResults() {
     return $this->moreResults;
   }
 
diff --git a/src/view/control/AphrontPagerView.php b/src/view/control/AphrontPagerView.php
index 8b08b15c5a..82314454f3 100644
--- a/src/view/control/AphrontPagerView.php
+++ b/src/view/control/AphrontPagerView.php
@@ -13,52 +13,52 @@ final class AphrontPagerView extends AphrontView {
   private $surroundingPages = 2;
   private $enableKeyboardShortcuts;
 
-  final public function setPageSize($page_size) {
+  public function setPageSize($page_size) {
     $this->pageSize = max(1, $page_size);
     return $this;
   }
 
-  final public function setOffset($offset) {
+  public function setOffset($offset) {
     $this->offset = max(0, $offset);
     return $this;
   }
 
-  final public function getOffset() {
+  public function getOffset() {
     return $this->offset;
   }
 
-  final public function getPageSize() {
+  public function getPageSize() {
     return $this->pageSize;
   }
 
-  final public function setCount($count) {
+  public function setCount($count) {
     $this->count = $count;
     return $this;
   }
 
-  final public function setHasMorePages($has_more) {
+  public function setHasMorePages($has_more) {
     $this->hasMorePages = $has_more;
     return $this;
   }
 
-  final public function setURI(PhutilURI $uri, $paging_parameter) {
+  public function setURI(PhutilURI $uri, $paging_parameter) {
     $this->uri = $uri;
     $this->pagingParameter = $paging_parameter;
     return $this;
   }
 
-  final public function readFromRequest(AphrontRequest $request) {
+  public function readFromRequest(AphrontRequest $request) {
     $this->uri = $request->getRequestURI();
     $this->pagingParameter = 'offset';
     $this->offset = $request->getInt($this->pagingParameter);
     return $this;
   }
 
-  final public function willShowPagingControls() {
+  public function willShowPagingControls() {
     return $this->hasMorePages;
   }
 
-  final public function setSurroundingPages($pages) {
+  public function setSurroundingPages($pages) {
     $this->surroundingPages = max(0, $pages);
     return $this;
   }
diff --git a/src/view/form/PHUIInfoView.php b/src/view/form/PHUIInfoView.php
index 497fcf3f78..f6e6f9b054 100644
--- a/src/view/form/PHUIInfoView.php
+++ b/src/view/form/PHUIInfoView.php
@@ -40,7 +40,7 @@ final class PHUIInfoView extends AphrontView {
     return $this;
   }
 
-  final public function render() {
+  public function render() {
     require_celerity_resource('phui-info-view-css');
 
     $errors = $this->errors;
diff --git a/src/view/layout/PhabricatorSourceCodeView.php b/src/view/layout/PhabricatorSourceCodeView.php
index 9a9454cbfa..7fb3f2ca66 100644
--- a/src/view/layout/PhabricatorSourceCodeView.php
+++ b/src/view/layout/PhabricatorSourceCodeView.php
@@ -72,7 +72,7 @@ final class PhabricatorSourceCodeView extends AphrontView {
 
       if ($this->canClickHighlight) {
         $line_uri = $this->uri.'$'.$line_number;
-        $line_href = (string) new PhutilURI($line_uri);
+        $line_href = (string)new PhutilURI($line_uri);
 
         $tag_number = javelin_tag(
           'a',
diff --git a/src/view/phui/PHUITimelineView.php b/src/view/phui/PHUITimelineView.php
index fe8cdc5971..b17e075711 100644
--- a/src/view/phui/PHUITimelineView.php
+++ b/src/view/phui/PHUITimelineView.php
@@ -132,7 +132,7 @@ final class PHUITimelineView extends AphrontView {
           javelin_tag(
             'a',
             array(
-              'href' => (string) $uri,
+              'href' => (string)$uri,
               'mustcapture' => true,
               'sigil' => 'show-older-link',
             ),

From 2154f17b3d7b7c4a47aee4ec49669f9a952f2e7c Mon Sep 17 00:00:00 2001
From: Bob Trahan <btrahan@phacility.com>
Date: Tue, 19 May 2015 15:22:41 -0700
Subject: [PATCH 66/86] Transactions - fix bug adding people to projects

Summary: Fixes T8264. Broken in D12929. Sweep all the applyBuiltin implementations and always break; rather than return

Test Plan: added myself to a project successfully (showed up as a member)

Reviewers: epriestley, chad

Subscribers: Korvin, epriestley

Maniphest Tasks: T6403, T8264

Differential Revision: https://secure.phabricator.com/D12940
---
 src/applications/audit/editor/PhabricatorAuditEditor.php    | 2 +-
 .../differential/editor/DifferentialTransactionEditor.php   | 2 +-
 .../project/editor/PhabricatorProjectTransactionEditor.php  | 6 +-----
 3 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/src/applications/audit/editor/PhabricatorAuditEditor.php b/src/applications/audit/editor/PhabricatorAuditEditor.php
index c628286a92..b2fd9d84b2 100644
--- a/src/applications/audit/editor/PhabricatorAuditEditor.php
+++ b/src/applications/audit/editor/PhabricatorAuditEditor.php
@@ -200,7 +200,7 @@ final class PhabricatorAuditEditor
             $state,
             $phid);
         }
-        return;
+        break;
     }
 
     return parent::applyBuiltinExternalTransaction($object, $xaction);
diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php
index d195d91833..0a02dec209 100644
--- a/src/applications/differential/editor/DifferentialTransactionEditor.php
+++ b/src/applications/differential/editor/DifferentialTransactionEditor.php
@@ -609,7 +609,7 @@ final class DifferentialTransactionEditor
             $state,
             $phid);
         }
-        return;
+        break;
     }
 
     return parent::applyBuiltinExternalTransaction($object, $xaction);
diff --git a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
index b85c127241..d449b62801 100644
--- a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
+++ b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
@@ -163,11 +163,7 @@ final class PhabricatorProjectTransactionEditor
     PhabricatorLiskDAO $object,
     PhabricatorApplicationTransaction $xaction) {
 
-    $old = $xaction->getOldValue();
-    $new = $xaction->getNewValue();
-
     switch ($xaction->getTransactionType()) {
-
       case PhabricatorTransactions::TYPE_EDGE:
         $edge_type = $xaction->getMetadataValue('edge:type');
         switch ($edge_type) {
@@ -220,7 +216,7 @@ final class PhabricatorProjectTransactionEditor
             }
             break;
         }
-        return;
+        break;
     }
 
     return parent::applyBuiltinExternalTransaction($object, $xaction);

From 69940f2b9ee4dfb37b17b711e5e8c05aa3490d23 Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@joshuaspence.com>
Date: Wed, 20 May 2015 09:37:39 +1000
Subject: [PATCH 67/86] Replace ArcanistPhutilTestCase refs with PhutilTestCase

Summary: Ref T7977. Remove the `PhabricatorTestCase::getLink` method. Depends on D12665.

Test Plan: `arc unit`.

Reviewers: avivey, #blessed_reviewers, epriestley

Reviewed By: avivey, #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7977

Differential Revision: https://secure.phabricator.com/D12667
---
 src/__phutil_library_map__.php                         | 10 +++++-----
 .../__tests__/DifferentialAdjustmentMapTestCase.php    |  2 +-
 .../storage/__tests__/DifferentialDiffTestCase.php     |  2 +-
 .../storage/__tests__/DifferentialHunkTestCase.php     |  2 +-
 .../request/__tests__/DiffusionURITestCase.php         |  2 +-
 src/docs/contributor/unit_tests.diviner                |  4 ++--
 src/docs/user/userguide/arcanist_coverage.diviner      |  2 +-
 src/infrastructure/testing/PhabricatorTestCase.php     | 10 +---------
 8 files changed, 13 insertions(+), 21 deletions(-)

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index 39cc7a3751..cbc2e27de1 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -3532,7 +3532,7 @@ phutil_register_library_map(array(
     'DifferentialActionEmailCommand' => 'MetaMTAEmailTransactionCommand',
     'DifferentialActionMenuEventListener' => 'PhabricatorEventListener',
     'DifferentialAddCommentView' => 'AphrontView',
-    'DifferentialAdjustmentMapTestCase' => 'ArcanistPhutilTestCase',
+    'DifferentialAdjustmentMapTestCase' => 'PhutilTestCase',
     'DifferentialAffectedPath' => 'DifferentialDAO',
     'DifferentialApplyPatchField' => 'DifferentialCustomField',
     'DifferentialAsanaRepresentationField' => 'DifferentialCustomField',
@@ -3597,7 +3597,7 @@ phutil_register_library_map(array(
     'DifferentialDiffProperty' => 'DifferentialDAO',
     'DifferentialDiffQuery' => 'PhabricatorCursorPagedPolicyAwareQuery',
     'DifferentialDiffTableOfContentsView' => 'AphrontView',
-    'DifferentialDiffTestCase' => 'ArcanistPhutilTestCase',
+    'DifferentialDiffTestCase' => 'PhutilTestCase',
     'DifferentialDiffTransaction' => 'PhabricatorApplicationTransaction',
     'DifferentialDiffViewController' => 'DifferentialController',
     'DifferentialDoorkeeperRevisionFeedStoryPublisher' => 'DoorkeeperFeedStoryPublisher',
@@ -3626,7 +3626,7 @@ phutil_register_library_map(array(
     ),
     'DifferentialHunkParserTestCase' => 'PhabricatorTestCase',
     'DifferentialHunkQuery' => 'PhabricatorCursorPagedPolicyAwareQuery',
-    'DifferentialHunkTestCase' => 'ArcanistPhutilTestCase',
+    'DifferentialHunkTestCase' => 'PhutilTestCase',
     'DifferentialInlineComment' => 'PhabricatorInlineCommentInterface',
     'DifferentialInlineCommentEditController' => 'PhabricatorInlineCommentController',
     'DifferentialInlineCommentPreviewController' => 'PhabricatorInlineCommentPreviewController',
@@ -3861,7 +3861,7 @@ phutil_register_library_map(array(
     'DiffusionTagListController' => 'DiffusionController',
     'DiffusionTagListView' => 'DiffusionView',
     'DiffusionTagsQueryConduitAPIMethod' => 'DiffusionQueryConduitAPIMethod',
-    'DiffusionURITestCase' => 'ArcanistPhutilTestCase',
+    'DiffusionURITestCase' => 'PhutilTestCase',
     'DiffusionUpdateCoverageConduitAPIMethod' => 'DiffusionConduitAPIMethod',
     'DiffusionView' => 'AphrontView',
     'DivinerArticleAtomizer' => 'DivinerAtomizer',
@@ -6083,7 +6083,7 @@ phutil_register_library_map(array(
     'PhabricatorTOTPAuthFactorTestCase' => 'PhabricatorTestCase',
     'PhabricatorTaskmasterDaemon' => 'PhabricatorDaemon',
     'PhabricatorTestApplication' => 'PhabricatorApplication',
-    'PhabricatorTestCase' => 'ArcanistPhutilTestCase',
+    'PhabricatorTestCase' => 'PhutilTestCase',
     'PhabricatorTestController' => 'PhabricatorController',
     'PhabricatorTestNoCycleEdgeType' => 'PhabricatorEdgeType',
     'PhabricatorTestStorageEngine' => 'PhabricatorFileStorageEngine',
diff --git a/src/applications/differential/storage/__tests__/DifferentialAdjustmentMapTestCase.php b/src/applications/differential/storage/__tests__/DifferentialAdjustmentMapTestCase.php
index 8fc28953fc..1146afec4f 100644
--- a/src/applications/differential/storage/__tests__/DifferentialAdjustmentMapTestCase.php
+++ b/src/applications/differential/storage/__tests__/DifferentialAdjustmentMapTestCase.php
@@ -1,6 +1,6 @@
 <?php
 
-final class DifferentialAdjustmentMapTestCase extends ArcanistPhutilTestCase {
+final class DifferentialAdjustmentMapTestCase extends PhutilTestCase {
 
   public function testBasicMaps() {
     $change_map = array(
diff --git a/src/applications/differential/storage/__tests__/DifferentialDiffTestCase.php b/src/applications/differential/storage/__tests__/DifferentialDiffTestCase.php
index dbab3768f9..45547aed42 100644
--- a/src/applications/differential/storage/__tests__/DifferentialDiffTestCase.php
+++ b/src/applications/differential/storage/__tests__/DifferentialDiffTestCase.php
@@ -1,6 +1,6 @@
 <?php
 
-final class DifferentialDiffTestCase extends ArcanistPhutilTestCase {
+final class DifferentialDiffTestCase extends PhutilTestCase {
 
   public function testDetectCopiedCode() {
     $copies = $this->detectCopiesIn('lint_engine.diff');
diff --git a/src/applications/differential/storage/__tests__/DifferentialHunkTestCase.php b/src/applications/differential/storage/__tests__/DifferentialHunkTestCase.php
index 2fcd7a9427..49866ac038 100644
--- a/src/applications/differential/storage/__tests__/DifferentialHunkTestCase.php
+++ b/src/applications/differential/storage/__tests__/DifferentialHunkTestCase.php
@@ -1,6 +1,6 @@
 <?php
 
-final class DifferentialHunkTestCase extends ArcanistPhutilTestCase {
+final class DifferentialHunkTestCase extends PhutilTestCase {
 
   public function testMakeChanges() {
     $root = dirname(__FILE__).'/hunk/';
diff --git a/src/applications/diffusion/request/__tests__/DiffusionURITestCase.php b/src/applications/diffusion/request/__tests__/DiffusionURITestCase.php
index 9ffafd9360..a6c9eeb27d 100644
--- a/src/applications/diffusion/request/__tests__/DiffusionURITestCase.php
+++ b/src/applications/diffusion/request/__tests__/DiffusionURITestCase.php
@@ -1,6 +1,6 @@
 <?php
 
-final class DiffusionURITestCase extends ArcanistPhutilTestCase {
+final class DiffusionURITestCase extends PhutilTestCase {
 
   public function testBlobDecode() {
     $map = array(
diff --git a/src/docs/contributor/unit_tests.diviner b/src/docs/contributor/unit_tests.diviner
index 6aeaaab225..ac0d57e44d 100644
--- a/src/docs/contributor/unit_tests.diviner
+++ b/src/docs/contributor/unit_tests.diviner
@@ -21,7 +21,7 @@ To add new tests to a libphutil, Arcanist or Phabricator module:
   - Create a ##__tests__/## directory in the module if it doesn't exist yet.
   - Add classes to the ##__tests__/## directory which extend from
     @{class:PhabricatorTestCase} (in Phabricator) or
-    @{class@arcanist:ArcanistPhutilTestCase} (elsewhere).
+    @{class@arcanist:PhutilTestCase} (elsewhere).
   - Run ##arc liberate## on the library root so your classes are loadable.
 
 = Running Tests =
@@ -60,7 +60,7 @@ You can see this class at @{class:PhabricatorTrivialTestCase} and run it with:
    PASS   <1ms*  testAllIsRightWithTheWorld
 
 For more information on writing tests, see
-@{class@arcanist:ArcanistPhutilTestCase} and @{class:PhabricatorTestCase}.
+@{class@arcanist:PhutilTestCase} and @{class:PhabricatorTestCase}.
 
 = Database Isolation =
 
diff --git a/src/docs/user/userguide/arcanist_coverage.diviner b/src/docs/user/userguide/arcanist_coverage.diviner
index 18339c7b05..af7d29d373 100644
--- a/src/docs/user/userguide/arcanist_coverage.diviner
+++ b/src/docs/user/userguide/arcanist_coverage.diviner
@@ -64,6 +64,6 @@ might look like this:
   );
 
 You may also want to filter coverage information to the paths passed to the
-unit test engine. See @{class@arcanist:ArcanistPhutilTestCase} and
+unit test engine. See @{class@arcanist:PhutilTestCase} and
 @{class@arcanist:PhutilUnitTestEngine} for an example of coverage integration
 in PHP using Xdebug.
diff --git a/src/infrastructure/testing/PhabricatorTestCase.php b/src/infrastructure/testing/PhabricatorTestCase.php
index 2a2834c93f..2545413de9 100644
--- a/src/infrastructure/testing/PhabricatorTestCase.php
+++ b/src/infrastructure/testing/PhabricatorTestCase.php
@@ -1,6 +1,6 @@
 <?php
 
-abstract class PhabricatorTestCase extends ArcanistPhutilTestCase {
+abstract class PhabricatorTestCase extends PhutilTestCase {
 
   const NAMESPACE_PREFIX = 'phabricator_unittest_';
 
@@ -166,14 +166,6 @@ abstract class PhabricatorTestCase extends ArcanistPhutilTestCase {
     return new PhabricatorStorageFixtureScopeGuard($name);
   }
 
-  protected function getLink($method) {
-    $phabricator_project = 'PHID-APRJ-3f1fc779edeab89b2171';
-    return
-      'https://secure.phabricator.com/diffusion/symbol/'.$method.
-      '/?lang=php&projects='.$phabricator_project.
-      '&jump=true&context='.get_class($this);
-  }
-
   /**
    * Returns an integer seed to use when building unique identifiers (e.g.,
    * non-colliding usernames). The seed is unstable and its value will change

From f7c48acf446b42b40e83764293980bd254748ade Mon Sep 17 00:00:00 2001
From: lkassianik <lyubakassianik@gmail.com>
Date: Tue, 19 May 2015 16:55:36 -0700
Subject: [PATCH 68/86] Calendar event icons show up on month and day views

Summary: Closes T7936, Calendar event icons show up on month and day views

Test Plan: Calendar month and day views should show event icons

Reviewers: chad, #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7936

Differential Revision: https://secure.phabricator.com/D12943
---
 resources/celerity/map.php                    |  8 +-
 .../PhabricatorCalendarEventSearchEngine.php  |  2 +
 .../view/AphrontCalendarEventView.php         | 10 +++
 .../phui/calendar/PHUICalendarDayView.php     |  3 +-
 .../phui/calendar/PHUICalendarListView.php    | 73 +++++++++++--------
 .../css/phui/calendar/phui-calendar-list.css  | 26 ++++---
 .../css/phui/calendar/phui-calendar-month.css | 30 +++-----
 7 files changed, 84 insertions(+), 68 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index c2b79e7a10..e150725a0e 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -122,8 +122,8 @@ return array(
     'rsrc/css/layout/phabricator-side-menu-view.css' => 'c1db9e9c',
     'rsrc/css/layout/phabricator-source-code-view.css' => '2ceee894',
     'rsrc/css/phui/calendar/phui-calendar-day.css' => 'c0cf782a',
-    'rsrc/css/phui/calendar/phui-calendar-list.css' => '857a0d83',
-    'rsrc/css/phui/calendar/phui-calendar-month.css' => '1d0e1e9b',
+    'rsrc/css/phui/calendar/phui-calendar-list.css' => 'c1c7f338',
+    'rsrc/css/phui/calendar/phui-calendar-month.css' => '94b1750a',
     'rsrc/css/phui/calendar/phui-calendar.css' => 'ccabe893',
     'rsrc/css/phui/phui-action-header-view.css' => '89c497e7',
     'rsrc/css/phui/phui-action-list.css' => '4f4d09f2',
@@ -764,8 +764,8 @@ return array(
     'phui-button-css' => 'de610129',
     'phui-calendar-css' => 'ccabe893',
     'phui-calendar-day-css' => 'c0cf782a',
-    'phui-calendar-list-css' => '857a0d83',
-    'phui-calendar-month-css' => '1d0e1e9b',
+    'phui-calendar-list-css' => 'c1c7f338',
+    'phui-calendar-month-css' => '94b1750a',
     'phui-crumbs-view-css' => '594d719e',
     'phui-document-view-css' => '94d5dcd8',
     'phui-feed-story-css' => 'c9f3a0b5',
diff --git a/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php b/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
index 4f65202a2c..b9ca2b81bf 100644
--- a/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
+++ b/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
@@ -364,6 +364,7 @@ final class PhabricatorCalendarEventSearchEngine
       $event = new AphrontCalendarEventView();
       $event->setEpochRange($status->getDateFrom(), $status->getDateTo());
       $event->setIsAllDay($status->getIsAllDay());
+      $event->setIcon($status->getIcon());
 
       $name_text = $handles[$status->getUserPHID()]->getName();
       $status_text = $status->getName();
@@ -411,6 +412,7 @@ final class PhabricatorCalendarEventSearchEngine
       $event->setEventID($status->getID());
       $event->setEpochRange($status->getDateFrom(), $status->getDateTo());
       $event->setIsAllDay($status->getIsAllDay());
+      $event->setIcon($status->getIcon());
       $event->setViewerIsInvited($viewer_is_invited);
 
       $event->setName($status->getName());
diff --git a/src/applications/calendar/view/AphrontCalendarEventView.php b/src/applications/calendar/view/AphrontCalendarEventView.php
index 669844290f..eb80a3ce49 100644
--- a/src/applications/calendar/view/AphrontCalendarEventView.php
+++ b/src/applications/calendar/view/AphrontCalendarEventView.php
@@ -11,6 +11,7 @@ final class AphrontCalendarEventView extends AphrontView {
   private $viewerIsInvited;
   private $uri;
   private $isAllDay;
+  private $icon;
 
   public function setURI($uri) {
     $this->uri = $uri;
@@ -87,6 +88,15 @@ final class AphrontCalendarEventView extends AphrontView {
     return $this->isAllDay;
   }
 
+  public function setIcon($icon) {
+    $this->icon = $icon;
+    return $this;
+  }
+
+  public function getIcon() {
+    return $this->icon;
+  }
+
 
   public function getMultiDay() {
     $nextday = strtotime('12:00 AM Tomorrow', $this->getEpochStart());
diff --git a/src/view/phui/calendar/PHUICalendarDayView.php b/src/view/phui/calendar/PHUICalendarDayView.php
index 45a4f6d1bc..337ef50738 100644
--- a/src/view/phui/calendar/PHUICalendarDayView.php
+++ b/src/view/phui/calendar/PHUICalendarDayView.php
@@ -276,7 +276,8 @@ final class PHUICalendarDayView extends AphrontView {
       ->addClass('calendar-day-view-sidebar');
 
     $list = id(new PHUICalendarListView())
-      ->setUser($this->user);
+      ->setUser($this->user)
+      ->setView('day');
 
     if (count($events) == 0) {
       $list->showBlankState(true);
diff --git a/src/view/phui/calendar/PHUICalendarListView.php b/src/view/phui/calendar/PHUICalendarListView.php
index dd4bf34848..e1f37fa1ae 100644
--- a/src/view/phui/calendar/PHUICalendarListView.php
+++ b/src/view/phui/calendar/PHUICalendarListView.php
@@ -4,6 +4,16 @@ final class PHUICalendarListView extends AphrontTagView {
 
   private $events = array();
   private $blankState;
+  private $view;
+
+  private function getView() {
+    return $this->view;
+  }
+
+  public function setView($view) {
+    $this->view = $view;
+    return $this;
+  }
 
   public function addEvent(AphrontCalendarEventView $event) {
     $this->events[] = $event;
@@ -37,26 +47,28 @@ final class PHUICalendarListView extends AphrontTagView {
 
       if ($event->getIsAllDay()) {
         $timelabel = pht('All Day');
-        $dot = null;
       } else {
         $timelabel = phabricator_time(
           $event->getEpochStart(),
           $this->getUser());
-
-        $dot = phutil_tag(
-          'span',
-          array(
-            'class' => 'phui-calendar-list-dot',
-          ),
-          '');
       }
 
+      if ($event->getViewerIsInvited()) {
+        $icon_color = 'green';
+      } else {
+        $icon_color = null;
+      }
+
+      $dot = id(new PHUIIconView())
+        ->setIconFont($event->getIcon(), $icon_color)
+        ->addClass('phui-calendar-list-item-icon');
+
       $title = phutil_tag(
         'span',
         array(
           'class' => 'phui-calendar-list-title',
         ),
-        $this->renderEventLink($event, $allday));
+        $this->getEventTitle($event, $allday));
       $time = phutil_tag(
         'span',
         array(
@@ -72,10 +84,18 @@ final class PHUICalendarListView extends AphrontTagView {
         $class = $class.' all-day';
       }
 
-      $content = phutil_tag(
+      $tip = $this->getEventTooltip($event);
+      $tip_align = ($this->getView() == 'day') ? 'E' : 'N';
+      $content = javelin_tag(
         'a',
         array(
           'href' => '/E'.$event->getEventID(),
+          'sigil' => 'has-tooltip',
+          'meta'  => array(
+            'tip'  => $tip,
+            'size' => 200,
+            'align' => $tip_align,
+          ),
         ),
         array(
           $dot,
@@ -110,8 +130,17 @@ final class PHUICalendarListView extends AphrontTagView {
     return $list;
   }
 
-  private function renderEventLink($event) {
+  private function getEventTitle($event) {
+    $class = 'phui-calendar-item';
+    return phutil_tag(
+      'span',
+      array(
+        'class' => $class,
+      ),
+      $event->getName());
+  }
 
+  private function getEventTooltip(AphrontCalendarEventView $event) {
     Javelin::initBehavior('phabricator-tooltips');
 
     $start = id(AphrontFormDateControlValue::newFromEpoch(
@@ -145,27 +174,7 @@ final class PHUICalendarListView extends AphrontTagView {
           $end->getValueAsFormat('M j, Y, g:i A'));
       }
     }
-
-    $description = $event->getDescription();
-    if (strlen($description) == 0) {
-      $description = pht('(%s)', $event->getName());
-    }
-
-    $class = 'phui-calendar-item';
-
-    $anchor = javelin_tag(
-      'span',
-      array(
-        'sigil' => 'has-tooltip',
-        'class' => $class,
-        'meta'  => array(
-          'tip'  => $tip,
-          'size' => 200,
-        ),
-      ),
-      $event->getName());
-
-    return $anchor;
+    return $tip;
   }
 
   public function getIsViewerInvitedOnList() {
diff --git a/webroot/rsrc/css/phui/calendar/phui-calendar-list.css b/webroot/rsrc/css/phui/calendar/phui-calendar-list.css
index 0155f730a4..c9bf7023d1 100644
--- a/webroot/rsrc/css/phui/calendar/phui-calendar-list.css
+++ b/webroot/rsrc/css/phui/calendar/phui-calendar-list.css
@@ -29,25 +29,30 @@
 
 .phui-calendar-list-item {
   position: relative;
+  line-height: 18px;
+  height: 18px;
 }
 
-.phui-calendar-list-dot {
-  position: relative;
-  display: inline-block;
-  width: 5px;
-  height: 5px;
-  margin-right: 6px;
-  top: -5px;
-  border-radius: 10px;
-  border: 1px solid transparent;
+.phui-calendar-list-item a {
+  display: block;
+  width: auto;
+  min-height: 18px;
+}
+
+.phui-calendar-list-item-icon {
+  position: absolute;
+  left: 0;
+  top: 3px;
 }
 
 .phui-calendar-list-title {
  width: 200px;
- display: inline-block;
  overflow: hidden;
  text-overflow: ellipsis;
  white-space: nowrap;
+ position: absolute;
+ left: 20px;
+ top: 0;
 }
 
 .phui-calendar-viewer-invited .phui-calendar-list-title {
@@ -61,6 +66,7 @@
   right: 0;
   color: {$lightgreytext};
   text-align: right;
+  line-height: 20px;
 }
 
 .phui-calendar-list-item-empty {
diff --git a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
index 6c0e20a2f6..d528c260f1 100644
--- a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
+++ b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
@@ -180,6 +180,7 @@ li.phui-calendar-viewer-invited.all-day {
   display: block;
   overflow: hidden;
   position: relative;
+  height: 18px;
 }
 
 .phui-calendar-view li.phui-calendar-list-item {
@@ -187,40 +188,27 @@ li.phui-calendar-viewer-invited.all-day {
   width: auto;
 }
 
-.phui-calendar-view .phui-calendar-list-dot {
-  position: relative;
+.phui-calendar-list-item-icon {
   display: block;
-  float: left;
-  width: 3px;
-  height: 3px;
-  margin-right: 4px;
-  border-radius: 10px;
-  top: 5px;
-  left: 0;
-  display: none;
+  left: 0px;
 }
 
 .phui-calendar-view li.phui-calendar-list-item .phui-calendar-list-title {
   width: auto;
   position: absolute;
-  right: 0;
-  left: 60px;
+  left: 20px;
+  right: 60px;
   text-overflow: ellipsis;
   overflow: hidden;
   white-space: nowrap;
 }
 
-li.all-day {
-  line-height: 18px;
-}
-
 .phui-calendar-view li.phui-calendar-list-item .phui-calendar-list-time {
-  position: relative;
-  display: inline-block;
-  float: left;
+  position: absolute;
+  top: 0;
+  right: 0px;
   padding: 0;
-  line-height: 18px;
   width: 60px;
   color: {$lightgreytext};
-  text-align: left;
+  text-align: right;
 }

From cbc5ad1604d02c805c899faefe75794add8bfa6b Mon Sep 17 00:00:00 2001
From: cburroughs <chris.burroughs@gmail.com>
Date: Wed, 20 May 2015 07:19:01 -0700
Subject: [PATCH 69/86] fix trvial space typo in user guide

Test Plan: Read.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D12950
---
 src/docs/user/userguide/users.diviner | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/docs/user/userguide/users.diviner b/src/docs/user/userguide/users.diviner
index 8d1e28aedb..83ceefac46 100644
--- a/src/docs/user/userguide/users.diviner
+++ b/src/docs/user/userguide/users.diviner
@@ -52,7 +52,7 @@ would allow administrators to gain other users' credentials).
   - administrators can access them, edit settings, and retrieve credentials;
   - they do not receive email;
   - they appear with lower precedence in the UI when selecting users, with
-    a "Bot" note (because i t usually does not make sense to, for example,
+    a "Bot" note (because it usually does not make sense to, for example,
     assign a task to a bot).
 
 = Disabled Users =

From 953983983362fbba2d5e21b9399678435dae30f9 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Wed, 20 May 2015 09:08:39 -0700
Subject: [PATCH 70/86] Show authors as usernames when they're linked

Summary: This data is available and loaded, just not used.

Test Plan: {F411442}

Reviewers: chad

Reviewed By: chad

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D12951
---
 src/applications/audit/view/PhabricatorAuditListView.php | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/applications/audit/view/PhabricatorAuditListView.php b/src/applications/audit/view/PhabricatorAuditListView.php
index 6fc54f2e5f..96844c5b48 100644
--- a/src/applications/audit/view/PhabricatorAuditListView.php
+++ b/src/applications/audit/view/PhabricatorAuditListView.php
@@ -142,7 +142,12 @@ final class PhabricatorAuditListView extends AphrontView {
         $status_text = null;
         $status_color = null;
       }
-      $author_name = $commit->getCommitData()->getAuthorName();
+      $author_phid = $commit->getAuthorPHID();
+      if ($author_phid) {
+        $author_name = $this->getHandle($author_phid)->renderLink();
+      } else {
+        $author_name = $commit->getCommitData()->getAuthorName();
+      }
 
       $item = id(new PHUIObjectItemView())
         ->setObjectName($commit_name)

From 6b1d13bfaf3dec8bfc1957dddeb45a965011b79e Mon Sep 17 00:00:00 2001
From: lkassianik <lyubakassianik@gmail.com>
Date: Wed, 20 May 2015 09:51:26 -0700
Subject: [PATCH 71/86] Time control typeaheads.

Summary: Ref T8031, Time control typeaheads

Test Plan: Edit an event, type '3', typeahead should suggest, '3:00 AM', '3:30 AM', '3:00 PM', '3:30 PM'.

Reviewers: chad, epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T8031

Differential Revision: https://secure.phabricator.com/D12953
---
 resources/celerity/map.php                    | 28 +++++++++-----
 .../form/control/AphrontFormDateControl.php   | 38 ++++++++++++++++++-
 webroot/rsrc/css/phui/phui-form-view.css      | 15 +++++++-
 .../typeahead/source/TypeaheadStaticSource.js |  8 ++--
 .../rsrc/js/core/behavior-time-typeahead.js   | 36 ++++++++++++++++++
 5 files changed, 110 insertions(+), 15 deletions(-)
 create mode 100644 webroot/rsrc/js/core/behavior-time-typeahead.js

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index e150725a0e..1502be2eac 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => 'e3ba62e8',
+    'core.pkg.css' => '36142bff',
     'core.pkg.js' => '328799d0',
     'darkconsole.pkg.js' => 'e7393ebb',
     'differential.pkg.css' => 'bb338e4b',
@@ -134,7 +134,7 @@ return array(
     'rsrc/css/phui/phui-document.css' => '94d5dcd8',
     'rsrc/css/phui/phui-feed-story.css' => 'c9f3a0b5',
     'rsrc/css/phui/phui-fontkit.css' => 'dd8ddf27',
-    'rsrc/css/phui/phui-form-view.css' => '94ae3032',
+    'rsrc/css/phui/phui-form-view.css' => '79793450',
     'rsrc/css/phui/phui-form.css' => 'f535f938',
     'rsrc/css/phui/phui-header-view.css' => '75aaf372',
     'rsrc/css/phui/phui-icon.css' => 'bc766998',
@@ -231,7 +231,7 @@ return array(
     'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js' => '8b3fd187',
     'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js' => '54f314a0',
     'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js' => '2818f5ce',
-    'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js' => '316b8fa1',
+    'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js' => '6c0e62fa',
     'rsrc/externals/raphael/g.raphael.js' => '40dde778',
     'rsrc/externals/raphael/g.raphael.line.js' => '40da039e',
     'rsrc/externals/raphael/raphael.js' => '51ee6b43',
@@ -466,6 +466,7 @@ return array(
     'rsrc/js/core/behavior-scrollbar.js' => '834a1173',
     'rsrc/js/core/behavior-search-typeahead.js' => '048330fa',
     'rsrc/js/core/behavior-select-on-click.js' => '4e3e79a6',
+    'rsrc/js/core/behavior-time-typeahead.js' => '8cf340fd',
     'rsrc/js/core/behavior-toggle-class.js' => '5d7c9f33',
     'rsrc/js/core/behavior-tokenizer.js' => 'b3a4b884',
     'rsrc/js/core/behavior-tooltip.js' => '3ee3408b',
@@ -640,6 +641,7 @@ return array(
     'javelin-behavior-slowvote-embed' => '887ad43f',
     'javelin-behavior-stripe-payment-form' => '3f5d6dbf',
     'javelin-behavior-test-payment-form' => 'fc91ab6c',
+    'javelin-behavior-time-typeahead' => '8cf340fd',
     'javelin-behavior-toggle-class' => '5d7c9f33',
     'javelin-behavior-typeahead-browse' => '635de1ec',
     'javelin-behavior-typeahead-search' => '93d0c9e3',
@@ -677,7 +679,7 @@ return array(
     'javelin-typeahead-ondemand-source' => '8b3fd187',
     'javelin-typeahead-preloaded-source' => '54f314a0',
     'javelin-typeahead-source' => '2818f5ce',
-    'javelin-typeahead-static-source' => '316b8fa1',
+    'javelin-typeahead-static-source' => '6c0e62fa',
     'javelin-uri' => '6eff08aa',
     'javelin-util' => '93cc50d6',
     'javelin-vector' => '2caa8fb8',
@@ -772,7 +774,7 @@ return array(
     'phui-font-icon-base-css' => '3dad2ae3',
     'phui-fontkit-css' => 'dd8ddf27',
     'phui-form-css' => 'f535f938',
-    'phui-form-view-css' => '94ae3032',
+    'phui-form-view-css' => '79793450',
     'phui-header-view-css' => '75aaf372',
     'phui-icon-view-css' => 'bc766998',
     'phui-image-mask-css' => '5a8b09c8',
@@ -1036,10 +1038,6 @@ return array(
       'javelin-install',
       'javelin-event',
     ),
-    '316b8fa1' => array(
-      'javelin-install',
-      'javelin-typeahead-source',
-    ),
     '331b1611' => array(
       'javelin-install',
     ),
@@ -1307,6 +1305,10 @@ return array(
     '69adf288' => array(
       'javelin-install',
     ),
+    '6c0e62fa' => array(
+      'javelin-install',
+      'javelin-typeahead-source',
+    ),
     '6c2b09a2' => array(
       'javelin-install',
       'javelin-util',
@@ -1482,6 +1484,14 @@ return array(
       'javelin-stratcom',
       'javelin-behavior',
     ),
+    '8cf340fd' => array(
+      'javelin-behavior',
+      'javelin-util',
+      'javelin-dom',
+      'javelin-stratcom',
+      'javelin-vector',
+      'javelin-typeahead-static-source',
+    ),
     '8cf6d262' => array(
       'javelin-install',
       'javelin-dom',
diff --git a/src/view/form/control/AphrontFormDateControl.php b/src/view/form/control/AphrontFormDateControl.php
index 84de3b3215..df0efe2c4a 100644
--- a/src/view/form/control/AphrontFormDateControl.php
+++ b/src/view/form/control/AphrontFormDateControl.php
@@ -270,9 +270,19 @@ final class AphrontFormDateControl extends AphrontFormControl {
       ),
       $cicon);
 
+    $values = $this->getTimeTypeaheadValues();
+
+    $time_id = celerity_generate_unique_node_id();
+    Javelin::initBehavior('time-typeahead', array(
+      'timeID' => $time_id,
+      'timeValues' => $values,
+      ));
+
+
     $time_sel = javelin_tag(
       'input',
       array(
+        'autocomplete' => 'off',
         'name'  => $this->getTimeInputName(),
         'sigil' => 'time-input',
         'value' => $this->getTimeInputValue(),
@@ -281,6 +291,14 @@ final class AphrontFormDateControl extends AphrontFormControl {
       ),
       '');
 
+    $time_div = javelin_tag(
+      'div',
+      array(
+        'id' => $time_id,
+        'class' => 'aphront-form-date-time-input-container',
+      ),
+      $time_sel);
+
     Javelin::initBehavior('fancy-datepicker', array());
 
     $classes = array();
@@ -308,7 +326,7 @@ final class AphrontFormDateControl extends AphrontFormControl {
         $months_sel,
         $years_sel,
         $cal_icon,
-        $time_sel,
+        $time_div,
       ));
   }
 
@@ -359,4 +377,22 @@ final class AphrontFormDateControl extends AphrontFormControl {
     return $value;
   }
 
+  private function getTimeTypeaheadValues() {
+    $times = array();
+    $am_pm_list = array('AM', 'PM');
+
+    foreach ($am_pm_list as $am_pm) {
+      for ($hour = 0; $hour < 12; $hour++) {
+        $actual_hour = ($hour == 0) ? 12 : $hour;
+        $times[] = $actual_hour.':00 '.$am_pm;
+        $times[] = $actual_hour.':30 '.$am_pm;
+      }
+    }
+
+    foreach ($times as $key => $time) {
+      $times[$key] = array($key, $time);
+    }
+    return $times;
+  }
+
 }
diff --git a/webroot/rsrc/css/phui/phui-form-view.css b/webroot/rsrc/css/phui/phui-form-view.css
index 5a3180d8b0..2600de81ac 100644
--- a/webroot/rsrc/css/phui/phui-form-view.css
+++ b/webroot/rsrc/css/phui/phui-form-view.css
@@ -334,9 +334,22 @@ table.aphront-form-control-checkbox-layout th {
   font-size: 16px;
 }
 
+.aphront-form-date-container .aphront-form-date-time-input-container {
+  position: relative;
+  display: inline-block;
+  width: 7em;
+}
+
 .aphront-form-date-container input.aphront-form-date-time-input {
   width: 7em;
-  display: inline;
+}
+
+.aphront-form-date-time-input-container div.jx-typeahead-results a.jx-result {
+  border: none;
+}
+
+.phui-time-typeahead-value {
+  padding: 4px;
 }
 
 .fancy-datepicker {
diff --git a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js
index 765074ff27..9bd6bff8f4 100644
--- a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js
+++ b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js
@@ -16,19 +16,19 @@ JX.install('TypeaheadStaticSource', {
 
   construct : function(data) {
     JX.TypeaheadSource.call(this);
-    this._data = data;
+    this.data = data;
   },
 
   members : {
-    _data : null,
+    data : null,
 
     didChange : function(value) {
       this.matchResults(value);
     },
 
     didStart : function() {
-      for (var ii = 0; ii < this._data.length; ii++) {
-        this.addResult(this._data[ii]);
+      for (var ii = 0; ii < this.data.length; ii++) {
+        this.addResult(this.data[ii]);
       }
     }
   }
diff --git a/webroot/rsrc/js/core/behavior-time-typeahead.js b/webroot/rsrc/js/core/behavior-time-typeahead.js
new file mode 100644
index 0000000000..158b8fbd4b
--- /dev/null
+++ b/webroot/rsrc/js/core/behavior-time-typeahead.js
@@ -0,0 +1,36 @@
+/**
+ * @provides javelin-behavior-time-typeahead
+ * @requires javelin-behavior
+ *           javelin-util
+ *           javelin-dom
+ *           javelin-stratcom
+ *           javelin-vector
+ *           javelin-typeahead-static-source
+ */
+
+JX.behavior('time-typeahead', function(config) {
+  var root = JX.$(config.timeID);
+  var datasource = new JX.TypeaheadStaticSource(config.timeValues);
+  datasource.setTransformer(function(v) {
+    var attributes = {'className' : 'phui-time-typeahead-value'};
+    var display = JX.$N('div', attributes, v[1]);
+    var object = {
+      'id' : v[0],
+      'name' : v[1],
+      'display' : display,
+      'uri' : null
+    };
+    return object;
+  });
+  datasource.setSortHandler(function(value, list) {
+    list.sort(function(u,v){
+      return (u.id > v.id) ? 1 : -1;
+    });
+  });
+  datasource.setMaximumResultCount(24);
+  var typeahead = new JX.Typeahead(
+    root,
+    JX.DOM.find(root, 'input', null));
+  typeahead.setDatasource(datasource);
+  typeahead.start();
+});

From bb0004fd41bcec661940cbaf09d00792499cb769 Mon Sep 17 00:00:00 2001
From: lkassianik <lyubakassianik@gmail.com>
Date: Wed, 20 May 2015 10:59:41 -0700
Subject: [PATCH 72/86] Make default start value of new events to be the next
 whole hour and the end value to be the next whole hour after that.

Summary: Ref T8031, Make default start value of new events to be the next whole hour and the end value to be the next whole hour after that.

Test Plan: Create new event at, say, 10:30am. Event default times should be 11:00 AM - 12:00 PM

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T8031

Differential Revision: https://secure.phabricator.com/D12954
---
 ...PhabricatorCalendarEventEditController.php | 22 +++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/src/applications/calendar/controller/PhabricatorCalendarEventEditController.php b/src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
index cf9797da45..f77846dd21 100644
--- a/src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
+++ b/src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
@@ -23,8 +23,8 @@ final class PhabricatorCalendarEventEditController
 
     if ($this->isCreate()) {
       $event = PhabricatorCalendarEvent::initializeNewCalendarEvent($user);
-      $end_value = AphrontFormDateControlValue::newFromEpoch($user, time());
-      $start_value = AphrontFormDateControlValue::newFromEpoch($user, time());
+      list($start_value, $end_value) = $this->getDefaultTimeValues($user);
+
       $submit_label = pht('Create');
       $page_title = pht('Create Event');
       $redirect = 'created';
@@ -349,4 +349,22 @@ final class PhabricatorCalendarEventEditController
     return $new;
   }
 
+  private function getDefaultTimeValues($user) {
+    $start = new DateTime('@'.time());
+    $start->setTimeZone($user->getTimeZone());
+
+    $start->setTime($start->format('H'), 0, 0);
+    $start->modify('+1 hour');
+    $end = id(clone $start)->modify('+1 hour');
+
+    $start_value = AphrontFormDateControlValue::newFromEpoch(
+      $user,
+      $start->format('U'));
+    $end_value = AphrontFormDateControlValue::newFromEpoch(
+      $user,
+      $end->format('U'));
+
+    return array($start_value, $end_value);
+  }
+
 }

From 9de39c12a2b48195f282abe4d930543d4bf24530 Mon Sep 17 00:00:00 2001
From: Bob Trahan <btrahan@phacility.com>
Date: Wed, 20 May 2015 13:54:22 -0700
Subject: [PATCH 73/86] Maniphest + Differential - don't show transaction
 preview until user interacts with the form.

Summary: Fixes T4846. These are one off (for now) since they have various crazy actions with them. I think this will get unified and more cleaned up when we refine the UI for taking multiple actions at once, etc.

Test Plan: noted no "commented on x" in either maniphest or differential. starting making a comment and noted prevew showed. started adding a subscriber (added to tokenizer) and preview showed.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T4846

Differential Revision: https://secure.phabricator.com/D12936
---
 resources/celerity/map.php                    | 64 +++++++++----------
 .../differential/behavior-comment-preview.js  | 23 +++++--
 .../maniphest/behavior-transaction-preview.js | 18 +++++-
 3 files changed, 68 insertions(+), 37 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 1502be2eac..85e21f4a12 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -11,11 +11,11 @@ return array(
     'core.pkg.js' => '328799d0',
     'darkconsole.pkg.js' => 'e7393ebb',
     'differential.pkg.css' => 'bb338e4b',
-    'differential.pkg.js' => '45b3b51d',
+    'differential.pkg.js' => '63a77807',
     'diffusion.pkg.css' => '591664fa',
     'diffusion.pkg.js' => '0115b37c',
     'maniphest.pkg.css' => '68d4dd3d',
-    'maniphest.pkg.js' => 'df4aa49f',
+    'maniphest.pkg.js' => '2f4f52c2',
     'rsrc/css/aphront/aphront-bars.css' => '231ac33c',
     'rsrc/css/aphront/dark-console.css' => '6378ef3d',
     'rsrc/css/aphront/dialog-view.css' => '9b32db0a',
@@ -349,7 +349,7 @@ return array(
     'rsrc/js/application/differential/DifferentialInlineCommentEditor.js' => 'd4c87bf4',
     'rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js' => 'e10f8e18',
     'rsrc/js/application/differential/behavior-comment-jump.js' => '4fdb476d',
-    'rsrc/js/application/differential/behavior-comment-preview.js' => '8e1389b5',
+    'rsrc/js/application/differential/behavior-comment-preview.js' => 'b064af76',
     'rsrc/js/application/differential/behavior-diff-radios.js' => 'e1ff79b1',
     'rsrc/js/application/differential/behavior-dropdown-menus.js' => '2035b9cb',
     'rsrc/js/application/differential/behavior-edit-inline-comments.js' => 'e723c323',
@@ -379,7 +379,7 @@ return array(
     'rsrc/js/application/maniphest/behavior-subpriorityeditor.js' => '84845b5b',
     'rsrc/js/application/maniphest/behavior-transaction-controls.js' => '44168bad',
     'rsrc/js/application/maniphest/behavior-transaction-expand.js' => '5fefb143',
-    'rsrc/js/application/maniphest/behavior-transaction-preview.js' => 'f8248bc5',
+    'rsrc/js/application/maniphest/behavior-transaction-preview.js' => '4c95d29e',
     'rsrc/js/application/owners/OwnersPathEditor.js' => 'aa1733d0',
     'rsrc/js/application/owners/owners-path-editor.js' => '7a68dda3',
     'rsrc/js/application/passphrase/passphrase-credential-control.js' => '3cb0b2fc',
@@ -466,7 +466,7 @@ return array(
     'rsrc/js/core/behavior-scrollbar.js' => '834a1173',
     'rsrc/js/core/behavior-search-typeahead.js' => '048330fa',
     'rsrc/js/core/behavior-select-on-click.js' => '4e3e79a6',
-    'rsrc/js/core/behavior-time-typeahead.js' => '8cf340fd',
+    'rsrc/js/core/behavior-time-typeahead.js' => '3416cef7',
     'rsrc/js/core/behavior-toggle-class.js' => '5d7c9f33',
     'rsrc/js/core/behavior-tokenizer.js' => 'b3a4b884',
     'rsrc/js/core/behavior-tooltip.js' => '3ee3408b',
@@ -559,7 +559,7 @@ return array(
     'javelin-behavior-differential-diff-radios' => 'e1ff79b1',
     'javelin-behavior-differential-dropdown-menus' => '2035b9cb',
     'javelin-behavior-differential-edit-inline-comments' => 'e723c323',
-    'javelin-behavior-differential-feedback-preview' => '8e1389b5',
+    'javelin-behavior-differential-feedback-preview' => 'b064af76',
     'javelin-behavior-differential-keyboard-navigation' => '2c426492',
     'javelin-behavior-differential-populate' => '8694b1df',
     'javelin-behavior-differential-show-field-details' => 'bba9eedf',
@@ -590,7 +590,7 @@ return array(
     'javelin-behavior-maniphest-subpriority-editor' => '84845b5b',
     'javelin-behavior-maniphest-transaction-controls' => '44168bad',
     'javelin-behavior-maniphest-transaction-expand' => '5fefb143',
-    'javelin-behavior-maniphest-transaction-preview' => 'f8248bc5',
+    'javelin-behavior-maniphest-transaction-preview' => '4c95d29e',
     'javelin-behavior-owners-path-editor' => '7a68dda3',
     'javelin-behavior-passphrase-credential-control' => '3cb0b2fc',
     'javelin-behavior-persona-login' => '9414ff18',
@@ -641,7 +641,7 @@ return array(
     'javelin-behavior-slowvote-embed' => '887ad43f',
     'javelin-behavior-stripe-payment-form' => '3f5d6dbf',
     'javelin-behavior-test-payment-form' => 'fc91ab6c',
-    'javelin-behavior-time-typeahead' => '8cf340fd',
+    'javelin-behavior-time-typeahead' => '3416cef7',
     'javelin-behavior-toggle-class' => '5d7c9f33',
     'javelin-behavior-typeahead-browse' => '635de1ec',
     'javelin-behavior-typeahead-search' => '93d0c9e3',
@@ -1041,6 +1041,14 @@ return array(
     '331b1611' => array(
       'javelin-install',
     ),
+    '3416cef7' => array(
+      'javelin-behavior',
+      'javelin-util',
+      'javelin-dom',
+      'javelin-stratcom',
+      'javelin-vector',
+      'javelin-typeahead-static-source',
+    ),
     '3975b470' => array(
       'javelin-behavior',
       'javelin-dom',
@@ -1130,6 +1138,14 @@ return array(
       'javelin-request',
       'javelin-util',
     ),
+    '4c95d29e' => array(
+      'javelin-behavior',
+      'javelin-dom',
+      'javelin-util',
+      'javelin-json',
+      'javelin-stratcom',
+      'phabricator-shaped-request',
+    ),
     '4cebc641' => array(
       'javelin-install',
     ),
@@ -1484,27 +1500,11 @@ return array(
       'javelin-stratcom',
       'javelin-behavior',
     ),
-    '8cf340fd' => array(
-      'javelin-behavior',
-      'javelin-util',
-      'javelin-dom',
-      'javelin-stratcom',
-      'javelin-vector',
-      'javelin-typeahead-static-source',
-    ),
     '8cf6d262' => array(
       'javelin-install',
       'javelin-dom',
       'javelin-util',
     ),
-    '8e1389b5' => array(
-      'javelin-behavior',
-      'javelin-stratcom',
-      'javelin-dom',
-      'javelin-request',
-      'javelin-util',
-      'phabricator-shaped-request',
-    ),
     '8ef9ab58' => array(
       'javelin-behavior',
       'javelin-dom',
@@ -1663,6 +1663,14 @@ return array(
       'javelin-stratcom',
       'javelin-install',
     ),
+    'b064af76' => array(
+      'javelin-behavior',
+      'javelin-stratcom',
+      'javelin-dom',
+      'javelin-request',
+      'javelin-util',
+      'phabricator-shaped-request',
+    ),
     'b1a59974' => array(
       'javelin-behavior',
       'javelin-aphlict',
@@ -1983,14 +1991,6 @@ return array(
       'javelin-typeahead-ondemand-source',
       'javelin-util',
     ),
-    'f8248bc5' => array(
-      'javelin-behavior',
-      'javelin-dom',
-      'javelin-util',
-      'javelin-json',
-      'javelin-stratcom',
-      'phabricator-shaped-request',
-    ),
     'f829edb3' => array(
       'javelin-view',
       'javelin-install',
diff --git a/webroot/rsrc/js/application/differential/behavior-comment-preview.js b/webroot/rsrc/js/application/differential/behavior-comment-preview.js
index 3cf50535fd..283e6ea12c 100644
--- a/webroot/rsrc/js/application/differential/behavior-comment-preview.js
+++ b/webroot/rsrc/js/application/differential/behavior-comment-preview.js
@@ -21,10 +21,25 @@ JX.behavior('differential-feedback-preview', function(config) {
 
   var callback = function(r) {
     var preview = JX.$(config.preview);
-    JX.DOM.setContent(preview, JX.$H(r));
-    JX.Stratcom.invoke('differential-preview-update', null, {
-      container: preview
-    });
+    var data = getdata();
+    var hide = true;
+    for (var field in data) {
+      if (field == 'action') {
+        continue;
+      }
+      if (data[field]) {
+        hide = false;
+      }
+    }
+    if (hide) {
+      JX.DOM.hide(preview);
+    } else {
+      JX.DOM.setContent(preview, JX.$H(r));
+      JX.Stratcom.invoke('differential-preview-update', null, {
+        container: preview
+      });
+      JX.DOM.show(preview);
+    }
   };
 
   var getdata = function() {
diff --git a/webroot/rsrc/js/application/maniphest/behavior-transaction-preview.js b/webroot/rsrc/js/application/maniphest/behavior-transaction-preview.js
index ca18eb69d4..66b58b1f4b 100644
--- a/webroot/rsrc/js/application/maniphest/behavior-transaction-preview.js
+++ b/webroot/rsrc/js/application/maniphest/behavior-transaction-preview.js
@@ -14,7 +14,23 @@ JX.behavior('maniphest-transaction-preview', function(config) {
   var action = JX.$(config.action);
 
   var callback = function(r) {
-    JX.DOM.setContent(JX.$(config.preview), JX.$H(r));
+    var panel = JX.$(config.preview);
+    var data = getdata();
+    var hide = true;
+    for (var field in data) {
+      if (field == 'action') {
+        continue;
+      }
+      if (data[field]) {
+        hide = false;
+      }
+    }
+    if (hide) {
+      JX.DOM.hide(panel);
+    } else {
+      JX.DOM.setContent(panel, JX.$H(r));
+      JX.DOM.show(panel);
+    }
   };
 
   var getdata = function() {

From 4787069e96fb8b664713d1c2c838139a74394151 Mon Sep 17 00:00:00 2001
From: Bob Trahan <btrahan@phacility.com>
Date: Wed, 20 May 2015 13:55:23 -0700
Subject: [PATCH 74/86] Transactions - finish making built-in transaction types
 implementation optional

Summary: Fixes T6403. Remaining built-ins were already built-in effectively so this is a small re-factor plus some docs. I probably wouldn't have written anything if not for the TODO so please feel free to tell me to write something else or what have you.

Test Plan: NA since this didn't actually change anything.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6403

Differential Revision: https://secure.phabricator.com/D12937
---
 ...habricatorApplicationTransactionEditor.php | 29 ++++++++++++-------
 1 file changed, 18 insertions(+), 11 deletions(-)

diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
index 8c9c26bfe9..57a3e4bde8 100644
--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
@@ -385,12 +385,11 @@ abstract class PhabricatorApplicationTransactionEditor
     PhabricatorApplicationTransaction $xaction) {
 
     switch ($xaction->getTransactionType()) {
-      case PhabricatorTransactions::TYPE_BUILDABLE:
-      case PhabricatorTransactions::TYPE_TOKEN:
-        return;
       case PhabricatorTransactions::TYPE_CUSTOMFIELD:
         $field = $this->getCustomFieldForTransaction($object, $xaction);
         return $field->applyApplicationTransactionInternalEffects($xaction);
+      case PhabricatorTransactions::TYPE_BUILDABLE:
+      case PhabricatorTransactions::TYPE_TOKEN:
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
       case PhabricatorTransactions::TYPE_JOIN_POLICY:
@@ -408,9 +407,6 @@ abstract class PhabricatorApplicationTransactionEditor
     PhabricatorLiskDAO $object,
     PhabricatorApplicationTransaction $xaction) {
     switch ($xaction->getTransactionType()) {
-      case PhabricatorTransactions::TYPE_BUILDABLE:
-      case PhabricatorTransactions::TYPE_TOKEN:
-        return;
       case PhabricatorTransactions::TYPE_SUBSCRIBERS:
         $subeditor = id(new PhabricatorSubscriptionsEditor())
           ->setObject($object)
@@ -442,6 +438,8 @@ abstract class PhabricatorApplicationTransactionEditor
         $field = $this->getCustomFieldForTransaction($object, $xaction);
         return $field->applyApplicationTransactionExternalEffects($xaction);
       case PhabricatorTransactions::TYPE_EDGE:
+      case PhabricatorTransactions::TYPE_BUILDABLE:
+      case PhabricatorTransactions::TYPE_TOKEN:
       case PhabricatorTransactions::TYPE_VIEW_POLICY:
       case PhabricatorTransactions::TYPE_EDIT_POLICY:
       case PhabricatorTransactions::TYPE_JOIN_POLICY:
@@ -471,11 +469,17 @@ abstract class PhabricatorApplicationTransactionEditor
       "implementation!");
   }
 
-  // TODO: Write proper documentation for these hooks. These are like the
-  // "applyCustom" hooks, except that implementation is optional, so you do
-  // not need to handle all of the builtin transaction types. See T6403. These
-  // are not completely implemented.
-
+  /**
+   * @{class:PhabricatorTransactions} provides many built-in transactions
+   * which should not require much - if any - code in specific applications.
+   *
+   * This method is a hook for the exceedingly-rare cases where you may need
+   * to do **additional** work for built-in transactions. Developers should
+   * extend this method, making sure to return the parent implementation
+   * regardless of handling any transactions.
+   *
+   * See also @{method:applyBuiltinExternalTransaction}.
+   */
   protected function applyBuiltinInternalTransaction(
     PhabricatorLiskDAO $object,
     PhabricatorApplicationTransaction $xaction) {
@@ -493,6 +497,9 @@ abstract class PhabricatorApplicationTransactionEditor
     }
   }
 
+  /**
+   * See @{method::applyBuiltinInternalTransaction}.
+   */
   protected function applyBuiltinExternalTransaction(
     PhabricatorLiskDAO $object,
     PhabricatorApplicationTransaction $xaction) {

From 985eb26c7e32cdc19536769def6ab037645100fb Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Wed, 20 May 2015 14:20:53 -0700
Subject: [PATCH 75/86] Increase severity of bin/remove destroy warning

Summary:
Make sure we're 100% clear that this is really, truly not recommended.

Also improve the text itself, and show the objects which are being destroyed more clearly.

Test Plan: Removed objects with `bin/remove destroy`.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D12952
---
 ...PhabricatorSystemRemoveDestroyWorkflow.php | 76 ++++++++++++++++---
 .../PhabricatorUSEnglishTranslation.php       | 11 +++
 2 files changed, 78 insertions(+), 9 deletions(-)

diff --git a/src/applications/system/management/PhabricatorSystemRemoveDestroyWorkflow.php b/src/applications/system/management/PhabricatorSystemRemoveDestroyWorkflow.php
index 2a4244e97f..2abbc52691 100644
--- a/src/applications/system/management/PhabricatorSystemRemoveDestroyWorkflow.php
+++ b/src/applications/system/management/PhabricatorSystemRemoveDestroyWorkflow.php
@@ -54,23 +54,81 @@ final class PhabricatorSystemRemoveDestroyWorkflow
       }
     }
 
+    $banner = <<<EOBANNER
+                                  uuuuuuu
+                               uu###########uu
+                            uu#################uu
+                           u#####################u
+                          u#######################u
+                         u#########################u
+                         u#########################u
+                         u######"   "###"   "######u
+                         "####"      u#u       ####"
+                          ###u       u#u       u###
+                          ###u      u###u      u###
+                           "####uu###   ###uu####"
+                            "#######"   "#######"
+                              u#######u#######u
+                               u#"#"#"#"#"#"#u
+                    uuu        ##u# # # # #u##       uuu
+                   u####        #####u#u#u###       u####
+                    #####uu      "#########"     uu######
+                  u###########uu    """""    uuuu##########
+                  ####"""##########uuu   uu#########"""###"
+                   """      ""###########uu ""#"""
+                             uuuu ""##########uuu
+                    u###uuu#########uu ""###########uuu###
+                    ##########""""           ""###########"
+                     "#####"                      ""####""
+                       ###"                         ####"
+
+EOBANNER;
+
+
+    $console->writeOut("\n\n<fg:red>%s</fg>\n\n", $banner);
+
     $console->writeOut(
-      "<bg:red>**%s**</bg>\n\n",
-      pht(' IMPORTANT: OBJECTS WILL BE PERMANENTLY DESTROYED! '));
+      "<bg:red>** %s **</bg> %s\n\n%s\n\n".
+      "<bg:red>** %s **</bg> %s\n\n%s\n\n",
+      pht('IMPORTANT'),
+      pht('DATA WILL BE PERMANENTLY DESTROYED'),
+      phutil_console_wrap(
+        pht(
+          'Objects will be permanently destroyed. There is no way to '.
+          'undo this operation or ever retrieve this data unless you '.
+          'maintain external backups.')),
+      pht('IMPORTANT'),
+      pht('DELETING OBJECTS OFTEN BREAKS THINGS'),
+      phutil_console_wrap(
+        pht(
+          'Destroying objects may cause related objects to stop working, '.
+          'and may leave scattered references to objects which no longer '.
+          'exist. In most cases, it is much better to disable or archive '.
+          'objects instead of destroying them. This risk is greatest when '.
+          'deleting complex or highly connected objects like repositories, '.
+          'projects and users.'.
+          "\n\n".
+          'These tattered edges are an expected consquence of destroying '.
+          'objects, and the Phabricator upstream will not help you fix '.
+          'them. We strongly recomend disabling or archiving objects '.
+          'instead.')));
+
+    $phids = mpull($named_objects, 'getPHID');
+    $handles = PhabricatorUser::getOmnipotentUser()->loadHandles($phids);
 
     $console->writeOut(
       pht(
-        "There is no way to undo this operation or ever retrieve this data.".
-        "\n\n".
-        "These %s object(s) will be **completely destroyed forever**:".
-        "\n\n",
-        new PhutilNumber(count($named_objects))));
+        'These %s object(s) will be destroyed forever:',
+        new PhutilNumber(count($named_objects)))."\n\n");
 
     foreach ($named_objects as $object_name => $object) {
+      $phid = $object->getPHID();
+
       $console->writeOut(
-        "    - %s (%s)\n",
+        "    - %s (%s) %s\n",
         $object_name,
-        get_class($object));
+        get_class($object),
+        $handles[$phid]->getFullName());
     }
 
     $force = $args->getArg('force');
diff --git a/src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php b/src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
index a1e0433b2c..61dd34fbe2 100644
--- a/src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
+++ b/src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
@@ -1067,6 +1067,17 @@ final class PhabricatorUSEnglishTranslation
         ),
       ),
 
+      'These %s object(s) will be destroyed forever:' => array(
+        'This object will be destroyed forever:',
+        'These objects will be destroyed forever:',
+      ),
+
+      'Are you absolutely certain you want to destroy these %s '.
+      'object(s)?' => array(
+        'Are you absolutely certain you want to destroy this object?',
+        'Are you absolutely certain you want to destroy these objects?',
+      ),
+
     );
   }
 

From f99c7beb90fd20f2be51598032c89179bc12fab1 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Wed, 20 May 2015 14:21:33 -0700
Subject: [PATCH 76/86] Fully remove all the public-create-mail settings

Summary: Fixes T5703. These have been unused in production for a while and the new stuff seems good.

Test Plan: Mostly `grep`.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5703

Differential Revision: https://secure.phabricator.com/D12949
---
 .../PhabricatorExtraConfigSetupCheck.php      |  9 ++++
 .../config/PhabricatorFilesConfigOptions.php  | 14 -----
 .../PhabricatorManiphestConfigOptions.php     | 51 -------------------
 .../ManiphestTaskEditController.php           | 15 +-----
 .../config/PhabricatorPasteConfigOptions.php  | 14 -----
 5 files changed, 10 insertions(+), 93 deletions(-)

diff --git a/src/applications/config/check/PhabricatorExtraConfigSetupCheck.php b/src/applications/config/check/PhabricatorExtraConfigSetupCheck.php
index 2d69334c47..a88dff0f22 100644
--- a/src/applications/config/check/PhabricatorExtraConfigSetupCheck.php
+++ b/src/applications/config/check/PhabricatorExtraConfigSetupCheck.php
@@ -171,6 +171,10 @@ final class PhabricatorExtraConfigSetupCheck extends PhabricatorSetupCheck {
       'Phabricator no longer supports global customization of monospaced '.
       'fonts.');
 
+    $public_mail_reason = pht(
+      'Inbound mail addresses are now configured for each application '.
+      'in the Applications tool.');
+
     $ancient_config += array(
       'phid.external-loaders' =>
         pht(
@@ -256,6 +260,11 @@ final class PhabricatorExtraConfigSetupCheck extends PhabricatorSetupCheck {
       'search.engine-selector' => pht(
         'Phabricator now automatically discovers available search engines '.
         'at runtime.'),
+
+      'metamta.files.public-create-email' => $public_mail_reason,
+      'metamta.maniphest.public-create-email' => $public_mail_reason,
+      'metamta.maniphest.default-public-author' => $public_mail_reason,
+      'metamta.paste.public-create-email' => $public_mail_reason,
     );
 
     return $ancient_config;
diff --git a/src/applications/files/config/PhabricatorFilesConfigOptions.php b/src/applications/files/config/PhabricatorFilesConfigOptions.php
index 7f18da3e99..ac62d410fe 100644
--- a/src/applications/files/config/PhabricatorFilesConfigOptions.php
+++ b/src/applications/files/config/PhabricatorFilesConfigOptions.php
@@ -156,20 +156,6 @@ final class PhabricatorFilesConfigOptions
             "Set this to a valid Amazon S3 bucket to store files there. You ".
             "must also configure S3 access keys in the 'Amazon Web Services' ".
             "group.")),
-     $this->newOption(
-        'metamta.files.public-create-email',
-        'string',
-        null)
-        ->setLocked(true)
-        ->setLockedMessage(pht(
-          'This configuration is deprecated. See description for details.'))
-        ->setSummary(pht('DEPRECATED - Allow uploaded files via email.'))
-        ->setDescription(
-          pht(
-            'This config has been deprecated in favor of [[ '.
-            '/applications/view/PhabricatorFilesApplication/ | '.
-            'application settings ]], which allow for multiple email '.
-            'addresses and other functionality.')),
      $this->newOption(
         'metamta.files.subject-prefix',
         'string',
diff --git a/src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php b/src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php
index c2b87629f0..04d59c9966 100644
--- a/src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php
+++ b/src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php
@@ -296,57 +296,6 @@ EOTEXT
         'string',
         '[Maniphest]')
         ->setDescription(pht('Subject prefix for Maniphest mail.')),
-      $this->newOption(
-        'metamta.maniphest.public-create-email',
-        'string',
-        null)
-        ->setLocked(true)
-        ->setLockedMessage(pht(
-          'This configuration is deprecated. See description for details.'))
-        ->setSummary(pht('DEPRECATED - Allow filing bugs via email.'))
-        ->setDescription(
-          pht(
-            'This config has been deprecated in favor of [[ '.
-            '/applications/view/PhabricatorManiphestApplication/ | '.
-            'application settings ]], which allow for multiple email '.
-            'addresses and other functionality.'."\n\n".
-            'You can configure an email address like '.
-            '"bugs@phabricator.example.com" which will automatically create '.
-            'Maniphest tasks when users send email to it. This relies on the '.
-            '"From" address to authenticate users, so it is is not completely '.
-            'secure. To set this up, enter a complete email address like '.
-            '"bugs@phabricator.example.com" and then configure mail to that '.
-            'address so it routed to Phabricator (if you\'ve already '.
-            'configured reply handlers, you\'re probably already done). See '.
-            '"Configuring Inbound Email" in the documentation for more '.
-            'information.')),
-      $this->newOption(
-        'metamta.maniphest.default-public-author',
-        'string',
-        null)
-        ->setLocked(true)
-        ->setLockedMessage(pht(
-          'This configuration is deprecated. See description for details.'))
-        ->setSummary(pht(
-          'DEPRECATED - Username anonymous bugs are filed under.'))
-        ->setDescription(
-          pht(
-            'This config has been deprecated in favor of [[ '.
-            '/applications/view/PhabricatorManiphestApplication/ | '.
-            'application settings ]], which allow for multiple email '.
-            'addresses each with its own default author, and other '.
-            'functionality.'."\n\n".
-            'If you enable `metamta.maniphest.public-create-email` and create '.
-            'an email address like "bugs@phabricator.example.com", it will '.
-            'default to rejecting mail which doesn\'t come from a known user. '.
-            'However, you might want to let anyone send email to this '.
-            'address; to do so, set a default author here (a Phabricator '.
-            'username). A typical use of this might be to create a "System '.
-            'Agent" user called "bugs" and use that name here. If you specify '.
-            'a valid username, mail will always be accepted and used to '.
-            'create a task, even if the sender is not a system user. The '.
-            'original email address will be stored in an `From Email` field '.
-            'on the task.')),
       $this->newOption(
         'maniphest.priorities.unbreak-now',
         'int',
diff --git a/src/applications/maniphest/controller/ManiphestTaskEditController.php b/src/applications/maniphest/controller/ManiphestTaskEditController.php
index 915ea6c33a..d9a4e44381 100644
--- a/src/applications/maniphest/controller/ManiphestTaskEditController.php
+++ b/src/applications/maniphest/controller/ManiphestTaskEditController.php
@@ -684,19 +684,7 @@ final class ManiphestTaskEditController extends ManiphestController {
       'tokenizerID' => $project_tokenizer_id,
     ));
 
-    $description_control = new PhabricatorRemarkupControl();
-    // "Upsell" creating tasks via email in create flows if the instance is
-    // configured for this awesomeness.
-    $email_create = PhabricatorEnv::getEnvConfig(
-      'metamta.maniphest.public-create-email');
-    if (!$task->getID() && $email_create) {
-      $email_hint = pht(
-        'You can also create tasks by sending an email to: %s',
-        phutil_tag('tt', array(), $email_create));
-      $description_control->setCaption($email_hint);
-    }
-
-    $description_control
+    $description_control = id(new PhabricatorRemarkupControl())
       ->setLabel(pht('Description'))
       ->setName('description')
       ->setID('description-textarea')
@@ -706,7 +694,6 @@ final class ManiphestTaskEditController extends ManiphestController {
     $form
       ->appendChild($description_control);
 
-
     if ($request->isAjax()) {
       $dialog = id(new AphrontDialogView())
         ->setUser($user)
diff --git a/src/applications/paste/config/PhabricatorPasteConfigOptions.php b/src/applications/paste/config/PhabricatorPasteConfigOptions.php
index e12fdc954d..bb970905c4 100644
--- a/src/applications/paste/config/PhabricatorPasteConfigOptions.php
+++ b/src/applications/paste/config/PhabricatorPasteConfigOptions.php
@@ -21,20 +21,6 @@ final class PhabricatorPasteConfigOptions
 
   public function getOptions() {
     return array(
-      $this->newOption(
-        'metamta.paste.public-create-email',
-        'string',
-        null)
-        ->setLocked(true)
-        ->setLockedMessage(pht(
-          'This configuration is deprecated. See description for details.'))
-        ->setSummary(pht('DEPRECATED - Allow creating pastes via email.'))
-        ->setDescription(
-          pht(
-            'This config has been deprecated in favor of [[ '.
-            '/applications/view/PhabricatorPasteApplication/ | '.
-            'application settings ]], which allow for multiple email '.
-            'addresses and other functionality.')),
       $this->newOption(
         'metamta.paste.subject-prefix',
         'string',

From f5a9d1f8d47bff1b5ba5e59a7b096fd0746a83cc Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Wed, 20 May 2015 14:21:46 -0700
Subject: [PATCH 77/86] Raise a setup issue for misconfigured Elasticsearch

Summary: Fixes T8274. That report is very light on details, but I think the issue is that their Elasticsearch is misconfigured and the new setup warning dies a little too hard if the server is just completely dead.

Test Plan: Set `search.elastic.host` to an invalid server, got a similar-looking exception (?), applied patch, got a setup warning instead.

Reviewers: btrahan, joshuaspence

Reviewed By: btrahan, joshuaspence

Subscribers: epriestley

Maniphest Tasks: T8274

Differential Revision: https://secure.phabricator.com/D12948
---
 .../PhabricatorElasticSearchSetupCheck.php    | 87 ++++++++++++-------
 1 file changed, 57 insertions(+), 30 deletions(-)

diff --git a/src/applications/config/check/PhabricatorElasticSearchSetupCheck.php b/src/applications/config/check/PhabricatorElasticSearchSetupCheck.php
index a573c14490..47a3cb4b18 100644
--- a/src/applications/config/check/PhabricatorElasticSearchSetupCheck.php
+++ b/src/applications/config/check/PhabricatorElasticSearchSetupCheck.php
@@ -7,44 +7,71 @@ final class PhabricatorElasticSearchSetupCheck extends PhabricatorSetupCheck {
   }
 
   protected function executeChecks() {
-    if ($this->shouldUseElasticSearchEngine()) {
-      $engine = new PhabricatorElasticSearchEngine();
+    if (!$this->shouldUseElasticSearchEngine()) {
+      return;
+    }
 
-      if (!$engine->indexExists()) {
-        $summary = pht(
-          'You enabled Elasticsearch but the index does not exist.');
+    $engine = new PhabricatorElasticSearchEngine();
 
-        $message = pht(
-          'You likely enabled search.elastic.host without creating the '.
-          'index. Run `./bin/search init` to correct the index.');
-
-        $this
-          ->newIssue('elastic.missing-index')
-          ->setName(pht('Elasticsearch index Not Found'))
-          ->setSummary($summary)
-          ->setMessage($message)
-          ->addRelatedPhabricatorConfig('search.elastic.host');
-      } else if (!$engine->indexIsSane()) {
-        $summary = pht(
-          'Elasticsearch index exists but needs correction.');
-
-        $message = pht(
-          'Either the Phabricator schema for Elasticsearch has changed '.
-          'or Elasticsearch created the index automatically. Run '.
-          '`./bin/search init` to correct the index.');
-
-        $this
-          ->newIssue('elastic.broken-index')
-          ->setName(pht('Elasticsearch index Incorrect'))
-          ->setSummary($summary)
-          ->setMessage($message);
+    $index_exists = null;
+    $index_sane = null;
+    try {
+      $index_exists = $engine->indexExists();
+      if ($index_exists) {
+        $index_sane = $engine->indexIsSane();
       }
+    } catch (Exception $ex) {
+      $summary = pht('Elasticsearch is not reachable as configured.');
+      $message = pht(
+        'Elasticsearch is configured (with the %s setting) but Phabricator '.
+        'encountered an exception when trying to test the index.'.
+        "\n\n".
+        '%s',
+        phutil_tag('tt', array(), 'search.elastic.host'),
+        phutil_tag('pre', array(), $ex->getMessage()));
+
+      $this->newIssue('elastic.misconfigured')
+        ->setName(pht('Elasticsearch Misconfigured'))
+        ->setSummary($summary)
+        ->setMessage($message)
+        ->addRelatedPhabricatorConfig('search.elastic.host');
+      return;
+    }
+
+    if (!$index_exists) {
+      $summary = pht(
+        'You enabled Elasticsearch but the index does not exist.');
+
+      $message = pht(
+        'You likely enabled search.elastic.host without creating the '.
+        'index. Run `./bin/search init` to correct the index.');
+
+      $this
+        ->newIssue('elastic.missing-index')
+        ->setName(pht('Elasticsearch index Not Found'))
+        ->setSummary($summary)
+        ->setMessage($message)
+        ->addRelatedPhabricatorConfig('search.elastic.host');
+    } else if (!$index_sane) {
+      $summary = pht(
+        'Elasticsearch index exists but needs correction.');
+
+      $message = pht(
+        'Either the Phabricator schema for Elasticsearch has changed '.
+        'or Elasticsearch created the index automatically. Run '.
+        '`./bin/search init` to correct the index.');
+
+      $this
+        ->newIssue('elastic.broken-index')
+        ->setName(pht('Elasticsearch index Incorrect'))
+        ->setSummary($summary)
+        ->setMessage($message);
     }
   }
 
   protected function shouldUseElasticSearchEngine() {
     $search_engine = PhabricatorSearchEngine::loadEngine();
-    return $search_engine instanceof PhabricatorElasticSearchEngine;
+    return ($search_engine instanceof PhabricatorElasticSearchEngine);
   }
 
 }

From a04af2a9eeee8269656bdaf61119cccace3a4ebd Mon Sep 17 00:00:00 2001
From: lkassianik <lyubakassianik@gmail.com>
Date: Wed, 20 May 2015 17:10:12 -0700
Subject: [PATCH 78/86] Calendar event datepicker should auto-complete end time
 to be an hour from start time unless end time has been edited.

Summary: Ref T8031, Calendar event datepicker should auto-complete end time to be an hour from start time unless end time has been edited

Test Plan: Create event, edit start time, end time should adjust to an hour from start time.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T8031

Differential Revision: https://secure.phabricator.com/D12960
---
 resources/celerity/map.php                    | 20 ++--
 ...PhabricatorCalendarEventEditController.php | 12 ++-
 .../form/control/AphrontFormDateControl.php   |  9 +-
 .../rsrc/js/core/behavior-time-typeahead.js   | 93 ++++++++++++++++++-
 4 files changed, 115 insertions(+), 19 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 85e21f4a12..3f062c9513 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -466,7 +466,7 @@ return array(
     'rsrc/js/core/behavior-scrollbar.js' => '834a1173',
     'rsrc/js/core/behavior-search-typeahead.js' => '048330fa',
     'rsrc/js/core/behavior-select-on-click.js' => '4e3e79a6',
-    'rsrc/js/core/behavior-time-typeahead.js' => '3416cef7',
+    'rsrc/js/core/behavior-time-typeahead.js' => '8bfbb401',
     'rsrc/js/core/behavior-toggle-class.js' => '5d7c9f33',
     'rsrc/js/core/behavior-tokenizer.js' => 'b3a4b884',
     'rsrc/js/core/behavior-tooltip.js' => '3ee3408b',
@@ -641,7 +641,7 @@ return array(
     'javelin-behavior-slowvote-embed' => '887ad43f',
     'javelin-behavior-stripe-payment-form' => '3f5d6dbf',
     'javelin-behavior-test-payment-form' => 'fc91ab6c',
-    'javelin-behavior-time-typeahead' => '3416cef7',
+    'javelin-behavior-time-typeahead' => '8bfbb401',
     'javelin-behavior-toggle-class' => '5d7c9f33',
     'javelin-behavior-typeahead-browse' => '635de1ec',
     'javelin-behavior-typeahead-search' => '93d0c9e3',
@@ -1041,14 +1041,6 @@ return array(
     '331b1611' => array(
       'javelin-install',
     ),
-    '3416cef7' => array(
-      'javelin-behavior',
-      'javelin-util',
-      'javelin-dom',
-      'javelin-stratcom',
-      'javelin-vector',
-      'javelin-typeahead-static-source',
-    ),
     '3975b470' => array(
       'javelin-behavior',
       'javelin-dom',
@@ -1495,6 +1487,14 @@ return array(
       'javelin-request',
       'javelin-typeahead-source',
     ),
+    '8bfbb401' => array(
+      'javelin-behavior',
+      'javelin-util',
+      'javelin-dom',
+      'javelin-stratcom',
+      'javelin-vector',
+      'javelin-typeahead-static-source',
+    ),
     '8ce821c5' => array(
       'phabricator-notification',
       'javelin-stratcom',
diff --git a/src/applications/calendar/controller/PhabricatorCalendarEventEditController.php b/src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
index f77846dd21..41744edecf 100644
--- a/src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
+++ b/src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
@@ -21,6 +21,10 @@ final class PhabricatorCalendarEventEditController
     $error_end_date = true;
     $validation_exception = null;
 
+    $all_day_id = celerity_generate_unique_node_id();
+    $start_date_id = celerity_generate_unique_node_id();
+    $end_date_id = null;
+
     if ($this->isCreate()) {
       $event = PhabricatorCalendarEvent::initializeNewCalendarEvent($user);
       list($start_value, $end_value) = $this->getDefaultTimeValues($user);
@@ -31,6 +35,7 @@ final class PhabricatorCalendarEventEditController
       $subscribers = array();
       $invitees = array($user_phid);
       $cancel_uri = $this->getApplicationURI();
+      $end_date_id = celerity_generate_unique_node_id();
     } else {
       $event = id(new PhabricatorCalendarEventQuery())
         ->setViewer($user)
@@ -178,10 +183,6 @@ final class PhabricatorCalendarEventEditController
       }
     }
 
-    $all_day_id = celerity_generate_unique_node_id();
-    $start_date_id = celerity_generate_unique_node_id();
-    $end_date_id = celerity_generate_unique_node_id();
-
     Javelin::initBehavior('event-all-day', array(
       'allDayID' => $all_day_id,
       'startDateID' => $start_date_id,
@@ -209,7 +210,8 @@ final class PhabricatorCalendarEventEditController
       ->setError($error_start_date)
       ->setValue($start_value)
       ->setID($start_date_id)
-      ->setIsTimeDisabled($is_all_day);
+      ->setIsTimeDisabled($is_all_day)
+      ->setEndDateID($end_date_id);
 
     $end_control = id(new AphrontFormDateControl())
       ->setUser($user)
diff --git a/src/view/form/control/AphrontFormDateControl.php b/src/view/form/control/AphrontFormDateControl.php
index df0efe2c4a..2615c1c5ee 100644
--- a/src/view/form/control/AphrontFormDateControl.php
+++ b/src/view/form/control/AphrontFormDateControl.php
@@ -13,6 +13,7 @@ final class AphrontFormDateControl extends AphrontFormControl {
   private $continueOnInvalidDate = false;
   private $isTimeDisabled;
   private $isDisabled;
+  private $endDateID;
 
   public function setAllowNull($allow_null) {
     $this->allowNull = $allow_null;
@@ -24,6 +25,11 @@ final class AphrontFormDateControl extends AphrontFormControl {
     return $this;
   }
 
+  public function setEndDateID($value) {
+    $this->endDateID = $value;
+    return $this;
+  }
+
   const TIME_START_OF_DAY         = 'start-of-day';
   const TIME_END_OF_DAY           = 'end-of-day';
   const TIME_START_OF_BUSINESS    = 'start-of-business';
@@ -274,7 +280,8 @@ final class AphrontFormDateControl extends AphrontFormControl {
 
     $time_id = celerity_generate_unique_node_id();
     Javelin::initBehavior('time-typeahead', array(
-      'timeID' => $time_id,
+      'startTimeID' => $time_id,
+      'endTimeID' => $this->endDateID,
       'timeValues' => $values,
       ));
 
diff --git a/webroot/rsrc/js/core/behavior-time-typeahead.js b/webroot/rsrc/js/core/behavior-time-typeahead.js
index 158b8fbd4b..381eea7f36 100644
--- a/webroot/rsrc/js/core/behavior-time-typeahead.js
+++ b/webroot/rsrc/js/core/behavior-time-typeahead.js
@@ -9,7 +9,11 @@
  */
 
 JX.behavior('time-typeahead', function(config) {
-  var root = JX.$(config.timeID);
+  var start_date_control = JX.$(config.startTimeID);
+  var end_date_control = config.endTimeID ? JX.$(config.endTimeID) : null;
+
+  var end_date_tampered = false;
+
   var datasource = new JX.TypeaheadStaticSource(config.timeValues);
   datasource.setTransformer(function(v) {
     var attributes = {'className' : 'phui-time-typeahead-value'};
@@ -29,8 +33,91 @@ JX.behavior('time-typeahead', function(config) {
   });
   datasource.setMaximumResultCount(24);
   var typeahead = new JX.Typeahead(
-    root,
-    JX.DOM.find(root, 'input', null));
+    start_date_control,
+    JX.DOM.find(start_date_control, 'input', null));
   typeahead.setDatasource(datasource);
+
+  if (!end_date_control) {
+    typeahead.start();
+    return;
+  }
+
+  var start_time_control = JX.DOM.find(
+    start_date_control,
+    'input',
+    'time-input');
+  var end_time_control = JX.DOM.find(
+    end_date_control,
+    'input',
+    'time-input');
+
+  JX.DOM.listen(start_time_control, 'input', null, function() {
+    if (end_date_tampered) {
+      return;
+    }
+    var time = start_time_control.value;
+    var end_value = getNewValue(time);
+    if (end_value) {
+      end_time_control.value = end_value;
+    }
+  });
+
+  typeahead.listen('choose', function(e) {
+    if (end_date_tampered) {
+      return;
+    }
+    var time = e.name;
+    var end_value = getNewValue(time);
+    if (end_value) {
+      end_time_control.value = end_value;
+    }
+  });
+
+  JX.DOM.listen(end_date_control, 'input', null, function() {
+    end_date_tampered = true;
+  });
+
+
+  function getNewValue(time) {
+    var regex = /^([01]?\d)(?::([0-5]\d))?\s*((am|pm))?$/i;
+
+    if (!regex.test(time)) {
+      return null;
+    }
+
+    var results = regex.exec(time);
+    var hours = parseInt(results[1], 10);
+    var minutes = parseInt(results[2], 10) ? parseInt(results[2], 10) : 0;
+
+    var real_time = 0;
+
+    if (/pm/i.test(results[3])) {
+      real_time = 12*60;
+    } else if (/am/i.test(results[3]) && hours == 12) {
+      hours = 0;
+    }
+
+    real_time = real_time + (hours * 60) + minutes;
+
+    var end_time = real_time + 60;
+
+    var end_meridian = 'AM';
+    var end_hours = Math.floor(end_time / 60);
+
+    if (end_hours == 12) {
+      end_meridian = 'PM';
+    } else if (end_hours > 12 && end_hours < 24) {
+      end_hours = end_hours - 12;
+      end_meridian = 'PM';
+    } else if (end_hours == 24) {
+      end_hours = end_hours - 12;
+    }
+
+    var end_minutes = end_time%60;
+    end_minutes = (end_minutes > 9) ? end_minutes : ('0' + end_minutes);
+    var end_value = end_hours + ':' + end_minutes + ' ' + end_meridian;
+    return end_value;
+  }
+
   typeahead.start();
 });

From f21972a01f1a67c335812017db1abea05b5be7d9 Mon Sep 17 00:00:00 2001
From: Aviv Eyal <avivey@gmail.com>
Date: Thu, 21 May 2015 08:25:34 -0700
Subject: [PATCH 79/86] Only link symbols if there might be any

Summary:
fixes T8260. Only turn on symbol links if:
- The repository has any configuration about symbols, or
- There actually are symbols in the repository.

Test Plan: Look at revisions and files in various states of configurations and having symbols.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: joshuaspence, Korvin, epriestley

Maniphest Tasks: T8260

Differential Revision: https://secure.phabricator.com/D12946
---
 .../DifferentialRevisionViewController.php    | 27 ++++++++++---------
 .../DiffusionBrowseFileController.php         | 19 +++++++++++--
 .../diffusion/query/DiffusionSymbolQuery.php  | 20 ++++++++++++++
 3 files changed, 51 insertions(+), 15 deletions(-)

diff --git a/src/applications/differential/controller/DifferentialRevisionViewController.php b/src/applications/differential/controller/DifferentialRevisionViewController.php
index 849ef056aa..cdefdd65d7 100644
--- a/src/applications/differential/controller/DifferentialRevisionViewController.php
+++ b/src/applications/differential/controller/DifferentialRevisionViewController.php
@@ -261,12 +261,11 @@ final class DifferentialRevisionViewController extends DifferentialController {
 
     $repository = $revision->getRepository();
     if ($repository) {
-      list($symbol_indexes, $repository_phids) = $this->buildSymbolIndexes(
+      $symbol_indexes = $this->buildSymbolIndexes(
         $repository,
         $visible_changesets);
     } else {
       $symbol_indexes = array();
-      $repository_phids = null;
     }
 
     $revision_detail->setActions($actions);
@@ -306,15 +305,6 @@ final class DifferentialRevisionViewController extends DifferentialController {
       ),
       $comment_view);
 
-    if ($repository) {
-      Javelin::initBehavior(
-        'repository-crossreference',
-        array(
-          'section' => $wrap_id,
-          'repositories' => $repository_phids,
-        ));
-    }
-
     $changeset_view = new DifferentialChangesetListView();
     $changeset_view->setChangesets($changesets);
     $changeset_view->setVisibleChangesets($visible_changesets);
@@ -758,11 +748,22 @@ final class DifferentialRevisionViewController extends DifferentialController {
     $langs = $repository->getSymbolLanguages();
     $langs = nonempty($langs, array());
 
+    $sources = $repository->getSymbolSources();
+    $sources = nonempty($sources, array());
+
     $symbol_indexes = array();
 
+    if ($langs && $sources) {
+      $have_symbols = id(new DiffusionSymbolQuery())
+          ->existsSymbolsInRepository($repository->getPHID());
+      if (!$have_symbols) {
+        return $symbol_indexes;
+      }
+    }
+
     $repository_phids = array_merge(
       array($repository->getPHID()),
-      nonempty($repository->getSymbolSources(), array()));
+      $sources);
 
     $indexed_langs = array_fill_keys($langs, true);
     foreach ($visible_changesets as $key => $changeset) {
@@ -775,7 +776,7 @@ final class DifferentialRevisionViewController extends DifferentialController {
       }
     }
 
-    return array($symbol_indexes, $repository_phids);
+    return $symbol_indexes;
   }
 
   private function loadOtherRevisions(
diff --git a/src/applications/diffusion/controller/DiffusionBrowseFileController.php b/src/applications/diffusion/controller/DiffusionBrowseFileController.php
index 731906943c..6fcda177a5 100644
--- a/src/applications/diffusion/controller/DiffusionBrowseFileController.php
+++ b/src/applications/diffusion/controller/DiffusionBrowseFileController.php
@@ -267,13 +267,28 @@ final class DiffusionBrowseFileController extends DiffusionBrowseController {
       $id = celerity_generate_unique_node_id();
 
       $repo = $drequest->getRepository();
-      $symbol_repos = $repo->getSymbolSources();
+      $symbol_repos = nonempty($repo->getSymbolSources(), array());
       $symbol_repos[] = $repo;
 
       $lang = last(explode('.', $drequest->getPath()));
       $repo_languages = $repo->getSymbolLanguages();
+      $repo_languages = nonempty($repo_languages, array());
       $repo_languages = array_fill_keys($repo_languages, true);
-      if (empty($repo_languages) || isset($repo_languages[$lang])) {
+
+      $needs_symbols = true;
+      if ($repo_languages && $symbol_repos) {
+        $have_symbols = id(new DiffusionSymbolQuery())
+            ->existsSymbolsInRepository($repo->getPHID());
+        if (!$have_symbols) {
+          $needs_symbols = false;
+        }
+      }
+
+      if ($needs_symbols && $repo_languages) {
+        $needs_symbols = isset($repo_languages[$lang]);
+      }
+
+      if ($needs_symbols) {
         Javelin::initBehavior(
           'repository-crossreference',
           array(
diff --git a/src/applications/diffusion/query/DiffusionSymbolQuery.php b/src/applications/diffusion/query/DiffusionSymbolQuery.php
index 6017c45f6f..0e08b7b32d 100644
--- a/src/applications/diffusion/query/DiffusionSymbolQuery.php
+++ b/src/applications/diffusion/query/DiffusionSymbolQuery.php
@@ -113,6 +113,26 @@ final class DiffusionSymbolQuery extends PhabricatorOffsetPagedQuery {
   }
 
 
+/* -(  Specialized Query  )-------------------------------------------------- */
+
+  public function existsSymbolsInRepository($repository_phid) {
+    $this
+      ->withRepositoryPHIDs(array($repository_phid))
+      ->setLimit(1);
+
+    $symbol = new PhabricatorRepositorySymbol();
+    $conn_r = $symbol->establishConnection('r');
+
+    $data = queryfx_all(
+      $conn_r,
+      'SELECT * FROM %T %Q %Q',
+      $symbol->getTableName(),
+      $this->buildWhereClause($conn_r),
+      $this->buildLimitClause($conn_r));
+
+    return (!empty($data));
+  }
+
 /* -(  Executing the Query  )------------------------------------------------ */
 
 

From 7ecd5155e52fd7810610f2c6a936cd8efebe7cf9 Mon Sep 17 00:00:00 2001
From: Fabian Stelzer <fs@campoint.net>
Date: Thu, 21 May 2015 09:01:17 -0700
Subject: [PATCH 80/86] elasticsearch host quick fix

Summary: Quick fix for the elasticsearch search engine Ref T8274

Test Plan: Did a couple of searches

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8274

Differential Revision: https://secure.phabricator.com/D12967
---
 .../search/engine/PhabricatorElasticSearchEngine.php       | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/applications/search/engine/PhabricatorElasticSearchEngine.php b/src/applications/search/engine/PhabricatorElasticSearchEngine.php
index f6efc17044..fa09e64a9c 100644
--- a/src/applications/search/engine/PhabricatorElasticSearchEngine.php
+++ b/src/applications/search/engine/PhabricatorElasticSearchEngine.php
@@ -6,6 +6,11 @@ final class PhabricatorElasticSearchEngine extends PhabricatorSearchEngine {
   private $index;
   private $timeout;
 
+  public function __construct() {
+    $this->uri = PhabricatorEnv::getEnvConfig('search.elastic.host');
+    $this->index = PhabricatorEnv::getEnvConfig('search.elastic.namespace');
+  }
+
   public function getEngineIdentifier() {
     return 'elasticsearch';
   }
@@ -15,7 +20,7 @@ final class PhabricatorElasticSearchEngine extends PhabricatorSearchEngine {
   }
 
   public function isEnabled() {
-    return (bool)PhabricatorEnv::getEnvConfig('search.elastic.host');
+    return (bool)$this->uri;
   }
 
   public function setURI($uri) {

From a50de8958efbb678173043f6b74bb5f3ea5d21e0 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 21 May 2015 09:27:57 -0700
Subject: [PATCH 81/86] Return empty array as a default value for repository
 symbol languages

Summary: Fixes T8283. The code in `FileController` assumes this value is an array.

Test Plan: Loaded any file in Diffusion in unconfigured repository, no more warning.

Reviewers: avivey, joshuaspence, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8283

Differential Revision: https://secure.phabricator.com/D12964
---
 src/applications/repository/storage/PhabricatorRepository.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/applications/repository/storage/PhabricatorRepository.php b/src/applications/repository/storage/PhabricatorRepository.php
index 8108051282..70387edec8 100644
--- a/src/applications/repository/storage/PhabricatorRepository.php
+++ b/src/applications/repository/storage/PhabricatorRepository.php
@@ -1781,11 +1781,11 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
 /* -(  Symbols  )-------------------------------------------------------------*/
 
   public function getSymbolSources() {
-    return $this->getDetail('symbol-sources');
+    return $this->getDetail('symbol-sources', array());
   }
 
   public function getSymbolLanguages() {
-    return $this->getDetail('symbol-languages');
+    return $this->getDetail('symbol-languages', array());
   }
 
 

From d70ca6b7c8b55b3b2ed294550303d7b051ef90c6 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 21 May 2015 09:42:20 -0700
Subject: [PATCH 82/86] When file transforms race and lose, accept defeat
 gracefully

Summary: Fixes T8277. Transforming files can race; resolve the race after we lose.

Test Plan:
  - Added `sleep(10)` near the bottom of the transform controller.
  - Transformed a file in two browser windows at the same time; got something like this (exception corresponds to the loser of the race):

{F412526}

  - Applied patch.
  - Repeated process, got this:

{F412527}

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8277

Differential Revision: https://secure.phabricator.com/D12965
---
 .../PhabricatorFileTransformController.php    | 33 ++++++++++++++-----
 1 file changed, 25 insertions(+), 8 deletions(-)

diff --git a/src/applications/files/controller/PhabricatorFileTransformController.php b/src/applications/files/controller/PhabricatorFileTransformController.php
index 0e7e2b73d7..77676c1b55 100644
--- a/src/applications/files/controller/PhabricatorFileTransformController.php
+++ b/src/applications/files/controller/PhabricatorFileTransformController.php
@@ -30,11 +30,7 @@ final class PhabricatorFileTransformController
     }
 
     $transform = $request->getURIData('transform');
-    $xform = id(new PhabricatorTransformedFile())
-      ->loadOneWhere(
-        'originalPHID = %s AND transform = %s',
-        $source_phid,
-        $transform);
+    $xform = $this->loadTransform($source_phid, $transform);
 
     if ($xform) {
       if ($is_regenerate) {
@@ -80,8 +76,20 @@ final class PhabricatorFileTransformController
     $xform = id(new PhabricatorTransformedFile())
       ->setOriginalPHID($source_phid)
       ->setTransform($transform)
-      ->setTransformedPHID($xformed_file->getPHID())
-      ->save();
+      ->setTransformedPHID($xformed_file->getPHID());
+
+    try {
+      $xform->save();
+    } catch (AphrontDuplicateKeyQueryException $ex) {
+      // If we collide when saving, we've raced another endpoint which was
+      // transforming the same file. Just throw our work away and use that
+      // transform instead.
+      $this->destroyTransform($xform);
+      $xform = $this->loadTransform($source_phid, $transform);
+      if (!$xform) {
+        return new Aphront404Response();
+      }
+    }
 
     return $this->buildTransformedFileResponse($xform);
   }
@@ -113,7 +121,9 @@ final class PhabricatorFileTransformController
     $unguarded = AphrontWriteGuard::beginScopedUnguardedWrites();
 
     if (!$file) {
-      $xform->delete();
+      if ($xform->getID()) {
+        $xform->delete();
+      }
     } else {
       $engine->destroyObject($file);
     }
@@ -121,4 +131,11 @@ final class PhabricatorFileTransformController
     unset($unguarded);
   }
 
+  private function loadTransform($source_phid, $transform) {
+    return id(new PhabricatorTransformedFile())->loadOneWhere(
+      'originalPHID = %s AND transform = %s',
+      $source_phid,
+      $transform);
+  }
+
 }

From df1522088452e5e9edac6ec92fcd00dc7df809c6 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 21 May 2015 16:10:53 -0700
Subject: [PATCH 83/86] Adjust CloudFront configuration instructions to allow
 POST

Summary: Ref T8293. We may submit POST requests to the alternate file domain, and CloudFront should be configured to route them.

Test Plan: See T8293.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8293

Differential Revision: https://secure.phabricator.com/D12973
---
 src/docs/user/configuration/configuring_file_domain.diviner | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/docs/user/configuration/configuring_file_domain.diviner b/src/docs/user/configuration/configuring_file_domain.diviner
index 5724bc3536..98576e5ae3 100644
--- a/src/docs/user/configuration/configuring_file_domain.diviner
+++ b/src/docs/user/configuration/configuring_file_domain.diviner
@@ -52,6 +52,10 @@ your Phabricator install as an origin (make sure you point it at the primary
 domain name of your install, not just a load balancer or instance). You do not
 need to set up a new domain name, which makes setup a bit more straightforward.
 
+Most settings can be left at their default values, but you should change
+the **Allowed HTTP Methods** setting from `GET, HEAD` to
+`GET, HEAD, OPTIONS, PUT, POST, PATCH, DELETE`.
+
 Once configured, accessing the distribution's domain name should return a
 Phabricator error page indicating that Phabricator does not recognize the
 domain. If you see this page, it means you've configured things correctly.

From 680e8fdfdb482072fd7134443b13c4b34191ed3f Mon Sep 17 00:00:00 2001
From: lkassianik <lyubakassianik@gmail.com>
Date: Thu, 21 May 2015 17:10:27 -0700
Subject: [PATCH 84/86] Calendar query results should be ordered from first
 start date to last start date

Summary: Closes T8041, Calendar query results should be ordered from first start date to last start date

Test Plan: Open "Upcoming Events" in Calendar, verify that the event with the first start date is first and that events are ordered in ascending start dates.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8041

Differential Revision: https://secure.phabricator.com/D12968
---
 .../query/PhabricatorCalendarEventQuery.php   | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/src/applications/calendar/query/PhabricatorCalendarEventQuery.php b/src/applications/calendar/query/PhabricatorCalendarEventQuery.php
index c66e367793..474ac49a46 100644
--- a/src/applications/calendar/query/PhabricatorCalendarEventQuery.php
+++ b/src/applications/calendar/query/PhabricatorCalendarEventQuery.php
@@ -42,6 +42,30 @@ final class PhabricatorCalendarEventQuery
     return $this;
   }
 
+  protected function getDefaultOrderVector() {
+    return array('start', 'id');
+  }
+
+  public function getOrderableColumns() {
+    return array(
+      'start' => array(
+        'table' => $this->getPrimaryTableAlias(),
+        'column' => 'dateFrom',
+        'reverse' => true,
+        'type' => 'int',
+        'unique' => false,
+      ),
+    ) + parent::getOrderableColumns();
+  }
+
+  protected function getPagingValueMap($cursor, array $keys) {
+    $event = $this->loadCursorObject($cursor);
+    return array(
+      'start' => $event->getDateFrom(),
+      'id' => $event->getID(),
+    );
+  }
+
   protected function loadPage() {
     $table = new PhabricatorCalendarEvent();
     $conn_r = $table->establishConnection('r');

From d3268aecc226397a09e47b8b24aebe48f226fe9c Mon Sep 17 00:00:00 2001
From: lkassianik <lyubakassianik@gmail.com>
Date: Thu, 21 May 2015 17:11:26 -0700
Subject: [PATCH 85/86] Possible fix for month view day deadzone

Summary: Ref T8193, Possible fix for month view day deadzone

Test Plan: Open Calendar month view in Chrome, Firefox, or Safari. Verify that days with many events still link to the day views of those days.

Reviewers: chad, epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T8193

Differential Revision: https://secure.phabricator.com/D12969
---
 resources/celerity/map.php                    |  4 +--
 .../phui/calendar/PHUICalendarMonthView.php   | 29 +++++++++++++++----
 .../css/phui/calendar/phui-calendar-month.css |  6 ++--
 3 files changed, 28 insertions(+), 11 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 3f062c9513..ad88264ee5 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -123,7 +123,7 @@ return array(
     'rsrc/css/layout/phabricator-source-code-view.css' => '2ceee894',
     'rsrc/css/phui/calendar/phui-calendar-day.css' => 'c0cf782a',
     'rsrc/css/phui/calendar/phui-calendar-list.css' => 'c1c7f338',
-    'rsrc/css/phui/calendar/phui-calendar-month.css' => '94b1750a',
+    'rsrc/css/phui/calendar/phui-calendar-month.css' => '476be7e0',
     'rsrc/css/phui/calendar/phui-calendar.css' => 'ccabe893',
     'rsrc/css/phui/phui-action-header-view.css' => '89c497e7',
     'rsrc/css/phui/phui-action-list.css' => '4f4d09f2',
@@ -767,7 +767,7 @@ return array(
     'phui-calendar-css' => 'ccabe893',
     'phui-calendar-day-css' => 'c0cf782a',
     'phui-calendar-list-css' => 'c1c7f338',
-    'phui-calendar-month-css' => '94b1750a',
+    'phui-calendar-month-css' => '476be7e0',
     'phui-crumbs-view-css' => '594d719e',
     'phui-document-view-css' => '94d5dcd8',
     'phui-feed-story-css' => 'c9f3a0b5',
diff --git a/src/view/phui/calendar/PHUICalendarMonthView.php b/src/view/phui/calendar/PHUICalendarMonthView.php
index 806ecad719..3adbe5eae7 100644
--- a/src/view/phui/calendar/PHUICalendarMonthView.php
+++ b/src/view/phui/calendar/PHUICalendarMonthView.php
@@ -117,8 +117,10 @@ final class PHUICalendarMonthView extends AphrontView {
 
     foreach ($cell_lists_by_week as $week_of_cell_lists) {
       $cells = array();
+      $max_count = $this->getMaxDailyEventsForWeek($week_of_cell_lists);
+
       foreach ($week_of_cell_lists as $cell_list) {
-        $cells[] = $this->getEventListCell($cell_list);
+        $cells[] = $this->getEventListCell($cell_list, $max_count);
       }
       $rows[] = phutil_tag('tr', array(), $cells);
 
@@ -153,7 +155,19 @@ final class PHUICalendarMonthView extends AphrontView {
     return $box;
   }
 
-  private function getEventListCell($event_list) {
+  private function getMaxDailyEventsForWeek($week_of_cell_lists) {
+    $max_count = 0;
+
+    foreach ($week_of_cell_lists as $cell_list) {
+      if ($cell_list['count'] > $max_count) {
+        $max_count = $cell_list['count'];
+      }
+    }
+
+    return $max_count;
+  }
+
+  private function getEventListCell($event_list, $max_count = 0) {
     $list = $event_list['list'];
     $class = $event_list['class'];
     $uri = $event_list['uri'];
@@ -162,7 +176,7 @@ final class PHUICalendarMonthView extends AphrontView {
     $viewer_is_invited = $list->getIsViewerInvitedOnList();
 
     $event_count_badge = $this->getEventCountBadge($count, $viewer_is_invited);
-    $cell_day_secret_link = $this->getHiddenDayLink($uri);
+    $cell_day_secret_link = $this->getHiddenDayLink($uri, $max_count, 125);
 
     $cell_data_div = phutil_tag(
       'div',
@@ -191,7 +205,7 @@ final class PHUICalendarMonthView extends AphrontView {
 
     if ($date) {
       $uri = $event_list['uri'];
-      $cell_day_secret_link = $this->getHiddenDayLink($uri);
+      $cell_day_secret_link = $this->getHiddenDayLink($uri, 0, 25);
 
       $cell_day = phutil_tag(
         'a',
@@ -291,11 +305,16 @@ final class PHUICalendarMonthView extends AphrontView {
       $event_count);
   }
 
-  private function getHiddenDayLink($uri) {
+  private function getHiddenDayLink($uri, $count, $max_height) {
+    // approximately the height of the tallest cell
+    $height = 18 * $count + 5;
+    $height = ($height > $max_height) ? $height : $max_height;
+    $height_style = 'height: '.$height.'px';
     return phutil_tag(
       'a',
       array(
         'class' => 'phui-calendar-month-secret-link',
+        'style' => $height_style,
         'href' => $uri,
       ),
       null);
diff --git a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
index d528c260f1..a219e49cf7 100644
--- a/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
+++ b/webroot/rsrc/css/phui/calendar/phui-calendar-month.css
@@ -54,9 +54,6 @@ a.phui-calendar-month-secret-link {
   position: absolute;
   left: 0;
   right: 0;
-  top: 0;
-  bottom: 0;
-  outline: 0;
 }
 
 table.phui-calendar-view tr td:first-child {
@@ -149,7 +146,8 @@ table.phui-calendar-view td.phui-calendar-date-number-container {
   background: transparent;
 }
 
-.phui-calendar-view .phui-calendar-list {
+.phui-calendar-view .phui-calendar-list,
+.phui-calendar-view .phui-calendar-month-list {
   padding: 1px;
   width: auto;
 }

From 36e2d02d6ec5db26f4dfc813a4f02238d18cc8a5 Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@joshuaspence.com>
Date: Fri, 22 May 2015 17:27:56 +1000
Subject: [PATCH 86/86] phtize all the things

Summary: `pht`ize a whole bunch of strings in rP.

Test Plan: Intense eyeballing.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: hach-que, Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D12797
---
 .arclint                                      |   1 -
 .../autopatches/20140106.macromailkey.2.php   |   6 +-
 .../sql/autopatches/20140108.ddbpname.2.php   |   6 +-
 .../autopatches/20140113.legalpadsig.2.php    |   6 +-
 .../autopatches/20140115.auth.3.unlimit.php   |   4 +-
 .../autopatches/20140205.cal.3.phid-mig.php   |   6 +-
 .../20140210.herald.rule-condition-mig.php    |   7 +-
 .../20140210.projcfield.1.blurb.php           |   5 +-
 .../20140211.dx.2.migcommenttext.php          |  10 +-
 .../autopatches/20140212.dx.1.armageddon.php  |   8 +-
 .../autopatches/20140218.passwords.4.vcs.php  |   6 +-
 .../20140226.dxcustom.1.fielddata.php         |   6 +-
 .../autopatches/20140321.mstatus.2.mig.php    |  18 +--
 .../autopatches/20140323.harbor.1.renames.php |   6 +-
 .../autopatches/20140325.push.3.groups.php    |   6 +-
 .../autopatches/20140410.accountsecret.2.php  |   8 +-
 .../autopatches/20140420.rel.2.objectmig.php  |   6 +-
 .../20140521.projectslug.2.mig.php            |  10 +-
 .../sql/autopatches/20140711.pnames.2.php     |   6 +-
 .../sql/autopatches/20140722.appname.php      |   8 +-
 .../20140722.audit.3.miginlines.php           |   6 +-
 .../autopatches/20140722.audit.4.migtext.php  |   8 +-
 .../sql/autopatches/20140722.renameauth.php   |   2 +-
 .../20140725.audit.1.migxactions.php          |   6 +-
 .../20140731.audit.1.subscribers.php          |   6 +-
 resources/sql/autopatches/20140731.cancdn.php |   2 +-
 .../sql/autopatches/20140805.boardcol.2.php   |   8 +-
 .../sql/autopatches/20140808.boardprop.3.php  |   4 +-
 .../sql/autopatches/20140815.cancdncase.php   |   5 +-
 .../sql/autopatches/20140904.macroattach.php  |   6 +-
 .../sql/autopatches/20140914.betaproto.php    |   8 +-
 .../20141107.phriction.policy.2.php           |  13 +-
 .../20141107.phriction.popkeys.php            |   8 +-
 .../sql/autopatches/20141107.ssh.4.keymig.php |  10 +-
 .../sql/autopatches/20141113.auditdupes.php   |   4 +-
 .../autopatches/20141218.maniphestcctxn.php   |   7 +-
 .../autopatches/20141222.maniphestprojtxn.php |   6 +-
 .../sql/autopatches/20150102.policyname.php   |   2 +-
 .../20150116.maniphestapplicationemails.php   |   6 +-
 .../20150120.maniphestdefaultauthor.php       |   4 +-
 .../20150129.pastefileapplicationemails.php   |  12 +-
 .../autopatches/20150501.calendar.2.reply.php |   6 +-
 .../20150506.calendarunnamedevents.1.php      |   6 +-
 resources/sql/patches/059.engines.php         |  11 +-
 resources/sql/patches/079.nametokenindex.php  |   6 +-
 resources/sql/patches/081.filekeys.php        |   6 +-
 .../patches/090.forceuniqueprojectnames.php   |  30 ++--
 resources/sql/patches/093.gitremotes.php      |  13 +-
 .../patches/098.heraldruletypemigration.php   |   6 +-
 resources/sql/patches/102.heraldcleanup.php   |   6 +-
 .../sql/patches/111.commitauditmigration.php  |   8 +-
 .../sql/patches/131.migraterevisionquery.php  |   4 +-
 .../sql/patches/20121209.xmacromigrate.php    |   4 +-
 .../patches/20130201.revisionunsubscribed.php |   4 +-
 .../sql/patches/20130218.updatechannelid.php  |   4 +-
 .../sql/patches/20130219.commitsummarymig.php |   6 +-
 .../patches/20130403.conpherencecachemig.php  |   7 +-
 resources/sql/patches/20130409.commitdrev.php |   4 +-
 .../sql/patches/20130502.countdownrevamp2.php |   4 +-
 .../patches/20130507.releephrqmailkeypop.php  |   6 +-
 .../sql/patches/20130529.macroauthormig.php   |   6 +-
 .../sql/patches/20130611.migrateoauth.php     |  10 +-
 resources/sql/patches/20130611.nukeldap.php   |   8 +-
 resources/sql/patches/20130619.authconf.php   |   6 +-
 .../patches/20130703.legalpaddocdenorm.php    |  16 +-
 .../patches/20130711.pholioimageobsolete.php  |   4 +-
 .../sql/patches/20130711.trimrealnames.php    |   8 +-
 .../sql/patches/20130715.votecomments.php     |  10 +-
 .../20130716.archivememberlessprojects.php    |  11 +-
 .../sql/patches/20130728.ponderunique.php     |  10 +-
 .../sql/patches/20130728.ponderxcomment.php   |   6 +-
 .../sql/patches/20130801.pastexactions.php    |   6 +-
 .../sql/patches/20130802.heraldphids.php      |   6 +-
 .../sql/patches/20130805.pastemailkeypop.php  |   6 +-
 .../20130820.file-mailkey-populate.php        |   4 +-
 .../sql/patches/20130915.maniphestmigrate.php |   6 +-
 resources/sql/patches/20130919.mfieldconf.php |   8 +-
 .../patches/20130921.xmigratemaniphest.php    |   6 +-
 resources/sql/patches/20130926.dinline.php    |   6 +-
 .../sql/patches/20131004.dxreviewers.php      |   4 +-
 .../sql/patches/20131020.pxactionmig.php      |   6 +-
 .../sql/patches/20131106.diffphid.2.mig.php   |   4 +-
 .../patches/20131112.userverified.2.mig.php   |   4 +-
 resources/sql/patches/20131118.ownerorder.php |   4 +-
 .../20131121.repocredentials.2.mig.php        |  14 +-
 .../patches/20131205.buildstepordermig.php    |   8 +-
 .../patches/20131217.pushlogphid.2.mig.php    |   6 +-
 resources/sql/patches/emailtableport.php      |   6 +-
 .../sql/patches/legalpad-mailkey-populate.php |   8 +-
 resources/sql/patches/liskcounters.php        |   2 +-
 .../migrate-differential-dependencies.php     |   8 +-
 .../migrate-maniphest-dependencies.php        |   8 +-
 .../patches/migrate-maniphest-revisions.php   |   8 +-
 .../sql/patches/migrate-project-edges.php     |   8 +-
 .../sql/patches/ponder-mailkey-populate.php   |   8 +-
 scripts/__init_script__.php                   |   2 +-
 scripts/almanac/manage_almanac.php            |   2 +-
 scripts/aphront/aphrontpath.php               |   6 +-
 scripts/cache/manage_cache.php                |   2 +-
 scripts/celerity/generate_sprites.php         |  14 +-
 scripts/daemon/manage_daemons.php             |   2 +-
 scripts/diviner/diviner.php                   |   2 +-
 scripts/drydock/drydock_control.php           |   2 +-
 scripts/fact/manage_facts.php                 |   2 +-
 scripts/files/manage_files.php                |   2 +-
 scripts/lipsum/manage_lipsum.php              |   2 +-
 scripts/mail/mail_handler.php                 |   2 +-
 scripts/mail/manage_mail.php                  |   2 +-
 scripts/repository/commit_hook.php            |   4 +-
 scripts/repository/manage_repositories.php    |   2 +-
 scripts/repository/rebuild_summaries.php      |   4 +-
 scripts/repository/save_lint.php              |   2 +-
 scripts/search/manage_search.php              |   2 +-
 scripts/setup/manage_audit.php                |   2 +-
 scripts/setup/manage_auth.php                 |   2 +-
 scripts/setup/manage_celerity.php             |   2 +-
 scripts/setup/manage_config.php               |   2 +-
 scripts/setup/manage_feed.php                 |   2 +-
 scripts/setup/manage_harbormaster.php         |   2 +-
 scripts/setup/manage_hunks.php                |   2 +-
 scripts/setup/manage_i18n.php                 |   2 +-
 scripts/setup/manage_phortune.php             |   2 +-
 scripts/setup/manage_policy.php               |   2 +-
 scripts/setup/manage_remove.php               |   2 +-
 scripts/setup/manage_trigger.php              |   2 +-
 scripts/setup/manage_worker.php               |   2 +-
 scripts/sms/manage_sms.php                    |   2 +-
 scripts/sql/manage_storage.php                |  73 ++++-----
 scripts/ssh/ssh-exec.php                      |  35 +++--
 scripts/symbols/import_repository_symbols.php |  12 +-
 scripts/user/account_admin.php                |  88 +++++------
 scripts/user/add_user.php                     |  23 ++-
 scripts/util/add_macro.php                    |  10 +-
 scripts/util/emit_test_event.php              |   8 +-
 src/__tests__/PhabricatorCelerityTestCase.php |   3 +-
 .../PhabricatorInfrastructureTestCase.php     |   2 +-
 src/aphront/AphrontRequest.php                |  39 ++---
 .../__tests__/AphrontRequestTestCase.php      |   2 +-
 .../AphrontApplicationConfiguration.php       |  28 ++--
 ...AphrontDefaultApplicationConfiguration.php |  11 +-
 src/aphront/response/Aphront404Response.php   |   9 +-
 src/aphront/sink/AphrontHTTPSink.php          |  14 +-
 .../controller/AlmanacConsoleController.php   |  12 +-
 .../AlmanacServiceEditController.php          |   4 -
 ...ricatorAphlictManagementStatusWorkflow.php |   4 +-
 .../PhabricatorAphlictManagementWorkflow.php  |  46 ++++--
 .../query/AphlictDropdownDataQuery.php        |   4 +-
 .../ArcanistProjectInfoConduitAPIMethod.php   |   4 +-
 .../conduit/AuditQueryConduitAPIMethod.php    |   2 +-
 .../PhabricatorAuditActionConstants.php       |  32 ++--
 .../PhabricatorAuditCommitStatusConstants.php |   2 +-
 .../audit/editor/PhabricatorAuditEditor.php   |   4 +-
 .../mail/PhabricatorAuditMailReceiver.php     |   4 +-
 .../mail/PhabricatorAuditReplyHandler.php     |   5 +-
 ...abricatorAuditManagementDeleteWorkflow.php |  36 +++--
 .../audit/view/PhabricatorAuditListView.php   |   8 +-
 .../view/PhabricatorAuditTransactionView.php  |   2 +-
 .../PhabricatorAuthConduitAPIMethod.php       |   6 +-
 .../PhabricatorAuthLoginController.php        |   6 +-
 ...bricatorAuthNeedsMultiFactorController.php |   2 +-
 .../PhabricatorAuthRegisterController.php     |   3 +-
 ...habricatorAuthSSHKeyGenerateController.php |   9 +-
 .../PhabricatorAuthStartController.php        |   4 +-
 .../PhabricatorEmailLoginController.php       |  38 ++---
 .../PhabricatorTOTPAuthFactorTestCase.php     |   2 -
 ...icatorAuthManagementCachePKCS8Workflow.php |  10 +-
 .../PhabricatorAuthManagementLDAPWorkflow.php |   8 +-
 ...abricatorAuthManagementRecoverWorkflow.php |  13 +-
 ...abricatorAuthManagementRefreshWorkflow.php |   6 +-
 ...PhabricatorAuthManagementStripWorkflow.php |  16 +-
 ...AuthManagementTrustOAuthClientWorkflow.php |   3 +-
 ...thManagementUntrustOAuthClientWorkflow.php |   5 +-
 .../auth/provider/PhabricatorAuthProvider.php |  14 +-
 .../provider/PhabricatorLDAPAuthProvider.php  |  11 +-
 .../PhabricatorOAuth1AuthProvider.php         |   4 +-
 .../PhabricatorOAuth2AuthProvider.php         |   5 +-
 .../provider/PhabricatorOAuthAuthProvider.php |   5 +-
 .../PhabricatorPasswordAuthProvider.php       |  14 +-
 .../PhabricatorPersonaAuthProvider.php        |   7 +-
 .../PhabricatorPhabricatorAuthProvider.php    |   3 +-
 .../PhabricatorAuthProviderConfigQuery.php    |   2 +-
 .../sshkey/PhabricatorAuthSSHPublicKey.php    |   3 +-
 .../base/PhabricatorApplication.php           |   8 +-
 .../base/controller/PhabricatorController.php |   6 +-
 .../PhabricatorAccessControlTestCase.php      |  24 +--
 src/applications/cache/PhabricatorCaches.php  |   4 +-
 .../PhabricatorKeyValueDatabaseCache.php      |   4 +-
 ...habricatorCacheManagementPurgeWorkflow.php |  31 ++--
 .../cache/spec/PhabricatorCacheSpec.php       |   4 +-
 .../cache/spec/PhabricatorOpcodeCacheSpec.php |  57 +++----
 .../mail/PhabricatorCalendarReplyHandler.php  |   5 +-
 .../PhabricatorCalendarHolidayTestCase.php    |   4 +-
 .../view/AphrontCalendarEventView.php         |   2 +-
 .../celerity/CelerityResourceMap.php          |   3 +-
 .../celerity/CelerityResourceMapGenerator.php |  14 +-
 .../celerity/CelerityResourceTransformer.php  |   5 +-
 .../celerity/CeleritySpriteGenerator.php      |   7 +-
 .../CelerityStaticResourceResponse.php        |   9 +-
 .../controller/CelerityResourceController.php |   2 +-
 .../conduit/ChatLogQueryConduitAPIMethod.php  |   2 +-
 .../conduit/ChatLogRecordConduitAPIMethod.php |   2 +-
 ...habricatorChatLogChannelListController.php |   4 +-
 ...PhabricatorChatLogChannelLogController.php |   6 +-
 .../call/__tests__/ConduitCallTestCase.php    |   4 +-
 .../PhabricatorConduitAPIController.php       |  58 ++++----
 .../PhabricatorConduitConsoleController.php   |   9 +-
 .../PhabricatorConduitLogController.php       |   4 +-
 .../conduit/method/ConduitAPIMethod.php       |  11 +-
 .../method/ConduitConnectConduitAPIMethod.php |  46 +++---
 .../ConduitGetCertificateConduitAPIMethod.php |  10 +-
 .../method/ConduitPingConduitAPIMethod.php    |   2 +-
 .../method/ConduitQueryConduitAPIMethod.php   |   2 +-
 .../conduit/protocol/ConduitAPIRequest.php    |   7 +-
 .../query/PhabricatorConduitSearchEngine.php  |  11 +-
 .../conduit/ssh/ConduitSSHWorkflow.php        |   4 +-
 .../check/PhabricatorAuthSetupCheck.php       |   9 +-
 .../check/PhabricatorBinariesSetupCheck.php   |  17 ++-
 .../check/PhabricatorDaemonsSetupCheck.php    |  26 ++--
 .../check/PhabricatorDatabaseSetupCheck.php   |  25 ++--
 .../PhabricatorExtraConfigSetupCheck.php      |  42 +++---
 .../check/PhabricatorFileinfoSetupCheck.php   |   8 +-
 .../config/check/PhabricatorGDSetupCheck.php  |  17 ++-
 .../PhabricatorImagemagickSetupCheck.php      |  10 +-
 .../check/PhabricatorMySQLSetupCheck.php      |  11 +-
 .../check/PhabricatorPHPConfigSetupCheck.php  |  39 +++--
 .../check/PhabricatorPathSetupCheck.php       |  27 ++--
 .../check/PhabricatorPygmentSetupCheck.php    |  36 +++--
 .../config/check/PhabricatorSetupCheck.php    |   8 +-
 .../check/PhabricatorTimezoneSetupCheck.php   |   6 +-
 .../PhabricatorConfigIgnoreController.php     |   2 +-
 .../PhabricatorCustomHeaderConfigType.php     |  30 ++--
 ...bricatorConfigManagementDeleteWorkflow.php |  25 ++--
 ...PhabricatorConfigManagementGetWorkflow.php |  12 +-
 ...habricatorConfigManagementListWorkflow.php |   2 +-
 ...ricatorConfigManagementMigrateWorkflow.php |  36 +++--
 ...PhabricatorConfigManagementSetWorkflow.php |  93 +++++++-----
 .../option/PhabricatorAWSConfigOptions.php    |   4 +-
 .../PhabricatorAccessLogConfigOptions.php     |  11 +-
 .../PhabricatorApplicationConfigOptions.php   |   2 +-
 ...PhabricatorAuthenticationConfigOptions.php |   7 +-
 .../PhabricatorClusterConfigOptions.php       |   7 +-
 .../config/option/PhabricatorConfigOption.php |   6 +-
 .../option/PhabricatorCoreConfigOptions.php   |  83 ++++++-----
 .../PhabricatorDeveloperConfigOptions.php     |  12 +-
 .../PhabricatorMailgunConfigOptions.php       |   5 +-
 .../PhabricatorMetaMTAConfigOptions.php       |  29 ++--
 .../option/PhabricatorMySQLConfigOptions.php  |   4 +-
 .../option/PhabricatorPHDConfigOptions.php    |  18 ++-
 .../PhabricatorPHPMailerConfigOptions.php     |   9 +-
 .../option/PhabricatorSMSConfigOptions.php    |  12 +-
 .../PhabricatorSecurityConfigOptions.php      |  35 +++--
 ...ricatorSyntaxHighlightingConfigOptions.php |   6 +-
 .../PhabricatorTranslationsConfigOptions.php  |   8 +-
 .../option/PhabricatorUIConfigOptions.php     |   3 +-
 ...ConpherenceQueryThreadConduitAPIMethod.php |   8 +-
 ...erenceQueryTransactionConduitAPIMethod.php |   6 +-
 .../ConpherenceUpdateController.php           |   2 +-
 .../mail/ConpherenceReplyHandler.php          |   5 +-
 .../plugin/DarkConsoleErrorLogPlugin.php      |   4 +-
 .../console/plugin/DarkConsoleEventPlugin.php |  14 +-
 .../plugin/DarkConsoleRequestPlugin.php       |   9 +-
 .../plugin/DarkConsoleServicesPlugin.php      |  42 +++---
 .../plugin/DarkConsoleXHProfPlugin.php        |  14 +-
 .../errorlog/DarkConsoleErrorLogPluginAPI.php |   2 +-
 .../PhabricatorCountdownDeleteController.php  |   5 +-
 .../PhabricatorDaemonConsoleController.php    |   2 +-
 .../PhabricatorDaemonLogViewController.php    |   6 +-
 .../PhabricatorWorkerTaskDetailController.php |   4 +-
 ...abricatorDaemonManagementDebugWorkflow.php |   6 +-
 ...PhabricatorDaemonManagementLogWorkflow.php |   8 +-
 ...bricatorDaemonManagementReloadWorkflow.php |   3 +-
 ...ricatorDaemonManagementRestartWorkflow.php |   4 +-
 ...abricatorDaemonManagementStartWorkflow.php |  13 +-
 ...bricatorDaemonManagementStatusWorkflow.php |   2 +-
 ...habricatorDaemonManagementStopWorkflow.php |   3 +-
 .../PhabricatorDaemonManagementWorkflow.php   | 100 ++++++++-----
 .../view/PhabricatorDaemonLogEventsView.php   |   2 +-
 .../PhabricatorDashboardEditController.php    |   8 +-
 .../PhabricatorDashboardLayoutConfig.php      |   4 +-
 .../DifferentialParseRenderTestCase.php       |   3 +-
 .../PhabricatorDifferentialApplication.php    |   8 +-
 .../DifferentialCloseConduitAPIMethod.php     |   2 +-
 ...ferentialCreateCommentConduitAPIMethod.php |   2 +-
 ...DifferentialCreateDiffConduitAPIMethod.php |   2 +-
 ...fferentialCreateInlineConduitAPIMethod.php |  17 ++-
 ...erentialCreateRevisionConduitAPIMethod.php |   2 +-
 .../DifferentialFindConduitAPIMethod.php      |   4 +-
 ...FinishPostponedLintersConduitAPIMethod.php |  12 +-
 ...ifferentialGetAllDiffsConduitAPIMethod.php |   5 +-
 ...entialGetCommitMessageConduitAPIMethod.php |   4 +-
 ...erentialGetCommitPathsConduitAPIMethod.php |   7 +-
 .../DifferentialGetDiffConduitAPIMethod.php   |   6 +-
 ...ialGetRevisionCommentsConduitAPIMethod.php |   2 +-
 .../DifferentialQueryConduitAPIMethod.php     |  12 +-
 ...rentialSetDiffPropertyConduitAPIMethod.php |   4 +-
 ...erentialUpdateRevisionConduitAPIMethod.php |   8 +-
 ...ntialUpdateUnitResultsConduitAPIMethod.php |   7 +-
 .../PhabricatorDifferentialConfigOptions.php  |  16 +-
 .../constants/DifferentialAction.php          |  53 ++++---
 .../constants/DifferentialChangeType.php      |   2 +-
 .../DifferentialChangesetViewController.php   |   2 +-
 .../DifferentialDiffCreateController.php      |   2 +-
 ...ifferentialInlineCommentEditController.php |   4 +-
 ...erentialRevisionCloseDetailsController.php |  16 +-
 .../DifferentialRevisionEditController.php    |   3 +-
 .../DifferentialRevisionLandController.php    |  16 +-
 .../DifferentialRevisionViewController.php    |   6 +-
 .../customfield/DifferentialBranchField.php   |   5 +-
 .../DifferentialConflictsField.php            |   4 +-
 .../DifferentialDependsOnField.php            |   3 +-
 .../customfield/DifferentialGitSVNIDField.php |   4 +-
 .../customfield/DifferentialLintField.php     |  10 +-
 .../DifferentialManiphestTasksField.php       |   5 +-
 .../DifferentialProjectReviewersField.php     |   3 +-
 .../DifferentialRepositoryField.php           |   3 +-
 .../DifferentialRevisionIDField.php           |   3 +-
 .../customfield/DifferentialUnitField.php     |  22 +--
 .../editor/DifferentialTransactionEditor.php  |  21 ++-
 .../DifferentialGitHubLandingStrategy.php     |  20 ++-
 .../DifferentialHostedGitLandingStrategy.php  |  10 +-
 ...erentialHostedMercurialLandingStrategy.php |   6 +-
 .../landing/DifferentialLandingStrategy.php   |   8 +-
 ...rDifferentialRevisionTestDataGenerator.php |   8 +-
 .../mail/DifferentialCreateMailReceiver.php   |   4 +-
 .../mail/DifferentialReplyHandler.php         |   2 +-
 .../mail/DifferentialRevisionMailReceiver.php |   4 +-
 .../parser/DifferentialChangesetParser.php    |  11 +-
 .../DifferentialCommitMessageParser.php       |   6 +-
 .../parser/DifferentialHunkParser.php         |  23 +--
 ...ifferentialCommitMessageParserTestCase.php |   5 +-
 .../DifferentialHunkParserTestCase.php        | 140 +++++++++---------
 .../query/DifferentialHunkQuery.php           |   4 +-
 .../query/DifferentialRevisionQuery.php       |   4 +-
 .../DifferentialChangesetHTMLRenderer.php     |  11 +-
 .../render/DifferentialChangesetRenderer.php  |   2 +-
 .../DifferentialChangesetTwoUpRenderer.php    |  10 +-
 .../search/DifferentialSearchIndexer.php      |   2 +-
 .../storage/DifferentialReviewer.php          |   2 +-
 .../storage/DifferentialRevision.php          |   3 +-
 .../storage/DifferentialTransaction.php       |  15 +-
 .../DifferentialDiffTableOfContentsView.php   |  10 +-
 .../DifferentialRevisionUpdateHistoryView.php |   4 +-
 .../view/DifferentialTransactionView.php      |   2 +-
 .../diffusion/DiffusionLintSaveRunner.php     |   2 +-
 .../DiffusionBrowseQueryConduitAPIMethod.php  |   4 +-
 ...DiffusionCreateCommentConduitAPIMethod.php |  18 ++-
 .../DiffusionDiffQueryConduitAPIMethod.php    |   4 +-
 .../DiffusionExistsQueryConduitAPIMethod.php  |   4 +-
 ...fusionFileContentQueryConduitAPIMethod.php |   2 +-
 .../DiffusionGetCommitsConduitAPIMethod.php   |   2 +-
 ...GetRecentCommitsByPathConduitAPIMethod.php |   3 +-
 .../DiffusionHistoryQueryConduitAPIMethod.php |   5 +-
 ...sionMergedCommitsQueryConduitAPIMethod.php |   4 +-
 .../DiffusionQueryConduitAPIMethod.php        |   2 +-
 .../DiffusionRawDiffQueryConduitAPIMethod.php |   4 +-
 .../DiffusionRefsQueryConduitAPIMethod.php    |   4 +-
 .../DiffusionSearchQueryConduitAPIMethod.php  |   4 +-
 .../PhabricatorDiffusionConfigOptions.php     |  19 ++-
 .../DiffusionBrowseDirectoryController.php    |   4 +-
 .../DiffusionBrowseFileController.php         |  13 +-
 .../DiffusionBrowseSearchController.php       |   4 +-
 .../DiffusionCommitBranchesController.php     |   2 +-
 .../controller/DiffusionCommitController.php  |  20 +--
 .../controller/DiffusionController.php        |   2 +-
 .../DiffusionExternalController.php           |   8 +-
 .../controller/DiffusionHistoryController.php |   2 -
 .../DiffusionInlineCommentController.php      |   4 +-
 .../DiffusionPathValidateController.php       |   2 +-
 .../DiffusionRepositoryController.php         |   9 +-
 .../DiffusionRepositoryCreateController.php   |  11 +-
 ...ffusionRepositoryEditActionsController.php |   3 +-
 ...DiffusionRepositoryEditBasicController.php |  24 +--
 ...fusionRepositoryEditBranchesController.php |  12 +-
 ...iffusionRepositoryEditDeleteController.php |   5 +-
 ...fusionRepositoryEditEncodingController.php |   3 +-
 .../DiffusionRepositoryEditMainController.php |   3 +-
 ...ffusionRepositoryEditStorageController.php |   9 +-
 ...sionRepositoryEditSubversionController.php |   6 +-
 .../DiffusionRepositoryNewController.php      |  10 +-
 .../controller/DiffusionServeController.php   |  12 +-
 .../diffusion/data/DiffusionGitBranch.php     |  14 +-
 .../diffusion/data/DiffusionRepositoryTag.php |   2 +-
 .../engine/DiffusionCommitHookEngine.php      |   5 +-
 .../exception/DiffusionSetupException.php     |   2 +-
 .../DiffusionMercurialWireProtocol.php        |   4 +-
 .../DiffusionSubversionWireProtocol.php       |  11 +-
 .../query/DiffusionCachedResolveRefsQuery.php |   2 +-
 .../diffusion/query/DiffusionCommitQuery.php  |  10 +-
 .../diffusion/query/DiffusionQuery.php        |   2 +-
 .../DiffusionGitFileContentQuery.php          |   6 +-
 .../DiffusionSvnFileContentQuery.php          |   7 +-
 .../lowlevel/DiffusionLowLevelCommitQuery.php |   3 +-
 .../DiffusionLowLevelParentsQuery.php         |   3 +-
 .../DiffusionLowLevelResolveRefsQuery.php     |  23 ++-
 .../__tests__/DiffusionPathQueryTestCase.php  |   8 +-
 .../diffusion/request/DiffusionGitRequest.php |   2 +-
 .../request/DiffusionMercurialRequest.php     |   2 +-
 .../diffusion/request/DiffusionRequest.php    |  61 +++++---
 .../__tests__/DiffusionURITestCase.php        |   2 +-
 .../DiffusionMercurialServeSSHWorkflow.php    |   4 +-
 ...nMercurialWireClientSSHProtocolChannel.php |   2 +-
 .../diffusion/ssh/DiffusionSSHWorkflow.php    |   3 +-
 .../DiffusionSubversionServeSSHWorkflow.php   |  13 +-
 .../DiffusionMercurialWireSSHTestCase.php     |   2 +-
 .../view/DiffusionEmptyResultView.php         |  13 +-
 .../diffusion/view/DiffusionView.php          |   7 +-
 src/applications/diviner/atom/DivinerAtom.php |   4 +-
 .../atomizer/DivinerArticleAtomizer.php       |   2 +-
 .../worker/DoorkeeperAsanaFeedWorker.php      |  44 +++---
 .../worker/DoorkeeperFeedWorker.php           |  10 +-
 .../worker/DoorkeeperJIRAFeedWorker.php       |  22 ++-
 .../DrydockBlueprintImplementation.php        |  37 +++--
 ...reallocatedHostBlueprintImplementation.php |   9 +-
 ...dockWorkingCopyBlueprintImplementation.php |  12 +-
 .../constants/DrydockResourceStatus.php       |   2 +-
 .../controller/DrydockConsoleController.php   |  11 +-
 .../DrydockLeaseReleaseController.php         |  19 ++-
 .../DrydockResourceViewController.php         |   2 +-
 .../command/DrydockSSHCommandInterface.php    |   9 +-
 .../DrydockSFTPFilesystemInterface.php        |   2 +-
 .../DrydockManagementCloseWorkflow.php        |  10 +-
 ...rydockManagementCreateResourceWorkflow.php |  20 ++-
 .../DrydockManagementLeaseWorkflow.php        |  12 +-
 .../DrydockManagementReleaseWorkflow.php      |  10 +-
 .../drydock/storage/DrydockBlueprint.php      |   5 +-
 .../drydock/storage/DrydockLease.php          |  15 +-
 .../drydock/worker/DrydockAllocatorWorker.php |  10 +-
 .../PhabricatorFactChartController.php        |   2 +-
 .../fact/daemon/PhabricatorFactDaemon.php     |   8 +-
 .../engine/PhabricatorFactCountEngine.php     |   8 +-
 .../PhabricatorFactLastUpdatedEngine.php      |   2 +-
 .../extract/PhabricatorFactUpdateIterator.php |   2 +-
 ...abricatorFactManagementAnalyzeWorkflow.php |   6 +-
 ...abricatorFactManagementCursorsWorkflow.php |   2 +-
 .../fact/spec/PhabricatorFactSpec.php         |   5 +-
 .../feed/PhabricatorFeedStoryPublisher.php    |  27 +++-
 .../feed/builder/PhabricatorFeedBuilder.php   |   2 +-
 .../conduit/FeedPublishConduitAPIMethod.php   |   2 +-
 .../conduit/FeedQueryConduitAPIMethod.php     |  14 +-
 .../feed/query/PhabricatorFeedQuery.php       |   3 +-
 .../feed/story/PhabricatorFeedStory.php       |  10 +-
 .../feed/worker/FeedPushWorker.php            |   2 +-
 .../PhabricatorFilesApplication.php           |   3 +-
 .../files/conduit/FileConduitAPIMethod.php    |   3 +-
 .../conduit/FileDownloadConduitAPIMethod.php  |   4 +-
 .../conduit/FileInfoConduitAPIMethod.php      |   4 +-
 .../conduit/FileUploadConduitAPIMethod.php    |   2 +-
 .../FileUploadHashConduitAPIMethod.php        |   2 +-
 .../config/PhabricatorFilesConfigOptions.php  |  31 ++--
 .../PhabricatorFileDeleteController.php       |  10 +-
 .../PhabricatorLocalDiskFileStorageEngine.php |  10 +-
 .../PhabricatorMySQLFileStorageEngine.php     |   2 +-
 .../engine/PhabricatorS3FileStorageEngine.php |   9 +-
 .../engine/PhabricatorTestStorageEngine.php   |   2 +-
 .../PhabricatorFileUploadException.php        |  35 ++---
 .../files/mail/FileCreateMailReceiver.php     |   3 +-
 .../files/mail/FileMailReceiver.php           |   4 +-
 .../files/mail/FileReplyHandler.php           |   2 +-
 .../PhabricatorFilesManagementCatWorkflow.php |   7 +-
 ...bricatorFilesManagementCompactWorkflow.php |   5 +-
 ...bricatorFilesManagementEnginesWorkflow.php |   4 +-
 ...bricatorFilesManagementMigrateWorkflow.php |  57 ++++---
 ...habricatorFilesManagementPurgeWorkflow.php |  24 +--
 ...bricatorFilesManagementRebuildWorkflow.php |  67 +++++----
 .../PhabricatorFilesManagementWorkflow.php    |   8 +-
 .../PhabricatorEmbedFileRemarkupRule.php      |   6 +-
 .../files/query/PhabricatorFileQuery.php      |   7 +-
 .../files/storage/PhabricatorFile.php         |  56 +++----
 .../PhabricatorGlobalUploadTargetView.php     |   2 +-
 .../conduit/FlagDeleteConduitAPIMethod.php    |   8 +-
 .../flag/conduit/FlagEditConduitAPIMethod.php |   2 +-
 .../conduit/FlagQueryConduitAPIMethod.php     |   2 +-
 .../flag/query/PhabricatorFlagQuery.php       |   3 +-
 .../fund/editor/FundInitiativeEditor.php      |   2 +-
 .../fund/mail/FundInitiativeReplyHandler.php  |   2 +-
 .../fund/phortune/FundBackerProduct.php       |   4 +-
 .../fund/search/FundInitiativeIndexer.php     |   5 +-
 .../fund/storage/FundInitiative.php           |   3 +-
 .../HarbormasterBuildActionController.php     |   3 +-
 .../HarbormasterBuildViewController.php       |   4 +-
 .../HarbormasterPlanEditController.php        |   2 +-
 .../HarbormasterPlanViewController.php        |   2 +-
 .../HarbormasterStepDeleteController.php      |   6 +-
 .../HarbormasterStepEditController.php        |   5 +-
 .../HarbormasterBuildTransactionEditor.php    |   2 +-
 .../HarbormasterManagementBuildWorkflow.php   |  10 +-
 ...ormasterCommandBuildStepImplementation.php |   4 +-
 ...WaitForPreviousBuildStepImplementation.php |   2 +-
 .../storage/build/HarbormasterBuild.php       |   2 +-
 .../build/HarbormasterBuildArtifact.php       |  17 ++-
 .../storage/build/HarbormasterBuildLog.php    |  10 +-
 .../herald/adapter/HeraldAdapter.php          |  42 +++---
 .../herald/adapter/HeraldCommitAdapter.php    |   2 +-
 .../HeraldDifferentialRevisionAdapter.php     |   8 +-
 .../controller/HeraldRuleController.php       |   2 +-
 .../HeraldTestConsoleController.php           |   2 +-
 .../controller/HeraldTranscriptController.php |  11 +-
 .../herald/engine/HeraldEngine.php            |  21 +--
 .../query/HeraldTranscriptSearchEngine.php    |   2 +-
 .../herald/storage/HeraldRule.php             |   2 +-
 .../PhabricatorHomeMainController.php         |  26 ++--
 .../LegalpadDocumentEditController.php        |   3 +-
 .../LegalpadDocumentSignController.php        |  41 +++--
 ...ocumentSignatureVerificationController.php |   4 +-
 .../legalpad/mail/LegalpadMailReceiver.php    |   4 +-
 .../legalpad/mail/LegalpadReplyHandler.php    |   2 +-
 .../query/LegalpadDocumentSearchEngine.php    |   1 -
 .../legalpad/storage/LegalpadDocument.php     |   3 +-
 .../legalpad/storage/LegalpadDocumentBody.php |   2 +-
 .../PhabricatorTestDataGenerator.php          |   4 +-
 .../MacroCreateMemeConduitAPIMethod.php       |   2 +-
 .../conduit/MacroQueryConduitAPIMethod.php    |   2 +-
 .../PhabricatorMacroDisableController.php     |  12 +-
 .../mail/PhabricatorMacroMailReceiver.php     |   4 +-
 .../mail/PhabricatorMacroReplyHandler.php     |   3 +-
 .../macro/query/PhabricatorMacroQuery.php     |   4 +-
 .../PhabricatorMailingListsApplication.php    |   4 +-
 .../__tests__/ManiphestTaskTestCase.php       |  10 +-
 .../command/ManiphestAssignEmailCommand.php   |  12 +-
 .../command/ManiphestPriorityEmailCommand.php |  10 +-
 .../command/ManiphestStatusEmailCommand.php   |  10 +-
 .../conduit/ManiphestConduitAPIMethod.php     |  11 +-
 .../ManiphestCreateTaskConduitAPIMethod.php   |   4 +-
 ...estGetTaskTransactionsConduitAPIMethod.php |   2 +-
 .../conduit/ManiphestInfoConduitAPIMethod.php |   4 +-
 .../ManiphestQueryConduitAPIMethod.php        |   2 +-
 ...ManiphestQueryStatusesConduitAPIMethod.php |   3 +-
 .../ManiphestUpdateConduitAPIMethod.php       |  14 +-
 .../PhabricatorManiphestConfigOptions.php     |  14 +-
 .../ManiphestBatchEditController.php          |   2 +-
 .../controller/ManiphestExportController.php  |  14 +-
 .../controller/ManiphestReportController.php  |   6 +-
 .../ManiphestTransactionSaveController.php    |   2 +-
 .../editor/ManiphestTransactionEditor.php     |   8 +-
 .../mail/ManiphestCreateMailReceiver.php      |   4 +-
 .../maniphest/mail/ManiphestReplyHandler.php  |   2 +-
 .../mail/ManiphestTaskMailReceiver.php        |   4 +-
 .../maniphest/query/ManiphestTaskQuery.php    |   2 +-
 ...atorApplicationEmailCommandsController.php |  25 +---
 ...bricatorApplicationUninstallController.php |  30 ++--
 ...icatorMailImplementationMailgunAdapter.php |   5 +-
 ...abricatorMailImplementationTestAdapter.php |   4 +-
 .../PhabricatorContentSourceView.php          |   2 +-
 ...icatorMetaMTASendGridReceiveController.php |   2 +-
 ...catorMailManagementListInboundWorkflow.php |  13 +-
 ...atorMailManagementListOutboundWorkflow.php |  11 +-
 ...catorMailManagementReceiveTestWorkflow.php |  19 ++-
 ...habricatorMailManagementResendWorkflow.php |  19 ++-
 ...bricatorMailManagementSendTestWorkflow.php |  30 ++--
 ...catorMailManagementShowInboundWorkflow.php |  13 +-
 ...atorMailManagementShowOutboundWorkflow.php |  13 +-
 .../PhabricatorMailReceiverTestCase.php       |   2 +-
 .../storage/PhabricatorMetaMTAMail.php        |  22 +--
 .../PhabricatorMetaMTAReceivedMail.php        |   4 +-
 .../PhabricatorMetaMTAMailTestCase.php        |  32 ++--
 ...PhabricatorNotificationClearController.php |   7 +-
 ...habricatorNotificationStatusController.php |  10 +-
 .../setup/PhabricatorAphlictSetupCheck.php    |  10 +-
 .../controller/NuanceQueueViewController.php  |   2 +-
 .../NuanceRequestorEditController.php         |   2 +-
 .../NuancePhabricatorFormSourceDefinition.php |   2 +-
 .../nuance/source/NuanceSourceDefinition.php  |  15 +-
 .../oauthserver/PhabricatorOAuthServer.php    |  22 +--
 .../PhabricatorOAuthServerScope.php           |   4 +-
 .../PhabricatorOAuthServerTestCase.php        |  18 ++-
 .../PhabricatorOAuthServerController.php      |  16 +-
 .../PhabricatorOAuthServerTokenController.php |  56 ++++---
 .../PhabricatorOAuthClientEditController.php  |   4 +-
 ...PhabricatorOAuthClientSecretController.php |   4 +-
 ...OAuthServerAuthorizationsSettingsPanel.php |   7 +-
 .../conduit/OwnersQueryConduitAPIMethod.php   |  21 ++-
 .../PhabricatorOwnersDeleteController.php     |   8 +-
 .../PhabricatorOwnersEditController.php       |  14 +-
 .../owners/mail/OwnersPackageReplyHandler.php |   5 +-
 .../owners/mail/PackageCreateMail.php         |   2 +-
 .../owners/mail/PackageDeleteMail.php         |   2 +-
 src/applications/owners/mail/PackageMail.php  |  27 ++--
 .../owners/mail/PackageModifyMail.php         |  26 ++--
 .../PassphraseCredentialConduitController.php |   6 +-
 ...sphraseCredentialTypeSSHPrivateKeyText.php |   8 +-
 .../conduit/PasteCreateConduitAPIMethod.php   |   6 +-
 .../conduit/PasteInfoConduitAPIMethod.php     |   6 +-
 .../conduit/PasteQueryConduitAPIMethod.php    |   2 +-
 .../paste/mail/PasteReplyHandler.php          |   3 +-
 .../conduit/UserDisableConduitAPIMethod.php   |   6 +-
 .../conduit/UserEnableConduitAPIMethod.php    |   6 +-
 .../conduit/UserFindConduitAPIMethod.php      |   4 +-
 .../conduit/UserQueryConduitAPIMethod.php     |   4 +-
 .../conduit/UserWhoAmIConduitAPIMethod.php    |   2 +-
 .../PhabricatorPeopleApproveController.php    |  12 +-
 .../PhabricatorPeopleDeleteController.php     |   7 +-
 .../PhabricatorPeopleDisableController.php    |   3 +-
 .../PhabricatorPeopleFeedController.php       |   5 +-
 .../PhabricatorPeopleLdapController.php       |   4 +-
 .../PhabricatorPeopleNewController.php        |   6 +-
 .../PhabricatorPeopleWelcomeController.php    |   4 +-
 .../people/editor/PhabricatorUserEditor.php   |  58 ++++----
 .../PhabricatorUserEditorTestCase.php         |   4 +-
 .../people/storage/PhabricatorUser.php        |  93 ++++++------
 .../people/storage/PhabricatorUserEmail.php   |  73 +++++----
 .../__tests__/PhabricatorUserTestCase.php     |   2 +-
 .../PhabricatorPeopleNoOwnerDatasource.php    |  18 +--
 .../typeahead/PhabricatorViewerDatasource.php |  19 ++-
 .../conduit/PhameQueryConduitAPIMethod.php    |   2 +-
 .../PhameQueryPostsConduitAPIMethod.php       |   2 +-
 .../phame/controller/PhameController.php      |  12 +-
 .../blog/PhameBlogEditController.php          |   2 +-
 .../blog/PhameBlogListController.php          |   2 +-
 .../blog/PhameBlogViewController.php          |   4 +-
 .../post/PhamePostListController.php          |   2 +-
 .../post/PhamePostViewController.php          |  10 +-
 .../phame/skins/PhameSkinSpecification.php    |  12 +-
 src/applications/phame/storage/PhameBlog.php  |   5 +-
 src/applications/phame/storage/PhamePost.php  |   8 +-
 .../phid/conduit/PHIDInfoConduitAPIMethod.php |   6 +-
 .../conduit/PHIDLookupConduitAPIMethod.php    |   2 +-
 .../conduit/PHIDQueryConduitAPIMethod.php     |   2 +-
 .../phid/storage/PhabricatorPHID.php          |   2 +-
 .../phid/type/PhabricatorPHIDType.php         |  12 +-
 .../controller/PholioInlineController.php     |   2 +-
 .../controller/PholioMockEditController.php   |   2 +-
 .../pholio/mail/PholioReplyHandler.php        |   2 +-
 .../pholio/view/PholioMockImagesView.php      |   4 +-
 .../pholio/view/PholioTransactionView.php     |   6 +-
 .../PhortuneMonthYearExpiryControl.php        |   2 +-
 .../PhortuneCartCancelController.php          |   6 +-
 .../PhortuneCartCheckoutController.php        |   2 +-
 .../PhortuneMerchantViewController.php        |   1 -
 .../PhortunePaymentMethodCreateController.php |   5 +-
 .../PhortuneProviderEditController.php        |   3 +-
 .../phortune/currency/PhortuneCurrency.php    |   4 +-
 .../currency/PhortuneCurrencySerializer.php   |   3 +-
 .../PhortuneNotImplementedException.php       |   5 +-
 .../mail/PhortuneCartReplyHandler.php         |   2 +-
 ...catorPhortuneManagementInvoiceWorkflow.php |  27 ++--
 .../PhortunePayPalPaymentProvider.php         |   3 +-
 .../PhortuneStripePaymentProvider.php         |   5 +-
 .../phortune/storage/PhortuneCart.php         |  35 +++--
 .../phortune/view/PhortuneCreditCardForm.php  |   6 +-
 .../worker/PhortuneSubscriptionWorker.php     |   3 +-
 .../PhabricatorPHPASTApplication.php          |   2 +-
 .../PhabricatorXHPASTViewFrameController.php  |   2 +-
 .../PhabricatorXHPASTViewPanelController.php  |   2 +-
 .../PhabricatorXHPASTViewRunController.php    |   2 +-
 .../PhabricatorXHPASTViewStreamController.php |   2 +-
 .../PhragmentGetPatchConduitAPIMethod.php     |   2 +-
 ...hragmentQueryFragmentsConduitAPIMethod.php |   2 +-
 .../controller/PhragmentController.php        |  16 +-
 .../controller/PhragmentCreateController.php  |   6 +-
 .../controller/PhragmentHistoryController.php |   2 +-
 .../controller/PhragmentRevertController.php  |   2 +-
 .../controller/PhragmentVersionController.php |   6 +-
 .../phragment/storage/PhragmentFragment.php   |   5 +-
 .../PhrequentTrackingConduitAPIMethod.php     |   3 +-
 .../controller/PhrequentTrackController.php   |   6 +-
 .../query/PhrequentUserTimeQuery.php          |   2 +-
 .../PhrictionHistoryConduitAPIMethod.php      |   2 +-
 .../conduit/PhrictionInfoConduitAPIMethod.php |   2 +-
 .../constants/PhrictionActionConstants.php    |  14 +-
 .../constants/PhrictionChangeType.php         |  14 +-
 .../PhrictionDocumentController.php           |   2 +-
 .../controller/PhrictionEditController.php    |  11 +-
 .../controller/PhrictionHistoryController.php |   2 +-
 .../phriction/mail/PhrictionReplyHandler.php  |   3 +-
 .../query/PhrictionDocumentQuery.php          |   2 +-
 .../phriction/storage/PhrictionDocument.php   |   2 +-
 .../__tests__/PhabricatorPolicyTestCase.php   |  35 +++--
 .../PhabricatorPolicyCapability.php           |  14 +-
 .../config/PhabricatorPolicyConfigOptions.php |   5 +-
 .../policy/config/PolicyLockOptionType.php    |  33 +++--
 .../PhabricatorPolicyEditController.php       |   7 +-
 .../policy/filter/PhabricatorPolicyFilter.php |  15 +-
 ...habricatorPolicyManagementShowWorkflow.php |   8 +-
 ...bricatorPolicyManagementUnlockWorkflow.php |  18 +--
 .../policy/query/PhabricatorPolicyQuery.php   |   8 +-
 .../policy/storage/PhabricatorPolicy.php      |  16 +-
 .../PhabricatorPonderApplication.php          |   4 +-
 .../ponder/constants/PonderQuestionStatus.php |   2 +-
 .../controller/PonderAnswerSaveController.php |   3 +-
 .../ponder/editor/PonderVoteEditor.php        |   4 +-
 .../mail/PonderQuestionReplyHandler.php       |   2 +-
 .../ponder/phid/PonderAnswerPHIDType.php      |   2 +-
 .../ponder/query/PonderQuestionQuery.php      |   2 +-
 .../ponder/storage/PonderQuestion.php         |   3 +-
 .../storage/PonderQuestionTransaction.php     |   4 +-
 .../conduit/ProjectQueryConduitAPIMethod.php  |   2 +-
 .../PhabricatorProjectEditorTestCase.php      |  20 +--
 .../project/mail/ProjectReplyHandler.php      |   3 +-
 .../project/query/PhabricatorProjectQuery.php |   4 +-
 .../__tests__/ProjectRemarkupRuleTestCase.php |   2 +-
 .../storage/PhabricatorProjectTransaction.php |  14 +-
 ...habricatorProjectLogicalUserDatasource.php |  13 +-
 ...PhabricatorProjectNoProjectsDatasource.php |  11 +-
 .../commitfinder/ReleephCommitFinder.php      |  26 +++-
 .../ReleephGetBranchesConduitAPIMethod.php    |   2 +-
 .../ReleephProjectInfoConduitAPIMethod.php    |  14 +-
 .../ReleephQueryRequestsConduitAPIMethod.php  |   4 +-
 .../ReleephRequestConduitAPIMethod.php        |  11 +-
 .../ReleephWorkCanPushConduitAPIMethod.php    |   2 +-
 ...leephWorkGetAuthorInfoConduitAPIMethod.php |   2 +-
 ...GetBranchCommitMessageConduitAPIMethod.php |  14 +-
 .../ReleephWorkGetBranchConduitAPIMethod.php  |   2 +-
 ...phWorkGetCommitMessageConduitAPIMethod.php |   6 +-
 ...ReleephWorkNextRequestConduitAPIMethod.php |  10 +-
 .../ReleephWorkRecordConduitAPIMethod.php     |   5 +-
 ...phWorkRecordPickStatusConduitAPIMethod.php |   4 +-
 .../branch/ReleephBranchCreateController.php  |   9 +-
 .../branch/ReleephBranchEditController.php    |   4 +-
 .../ReleephProductCreateController.php        |   6 +-
 .../product/ReleephProductEditController.php  |   4 +-
 .../ReleephRequestActionController.php        |   8 +-
 ...ephRequestDifferentialCreateController.php |  24 +--
 .../request/ReleephRequestEditController.php  |  30 ++--
 ...entialReleephRequestFieldSpecification.php |  65 ++++----
 .../releeph/editor/ReleephBranchEditor.php    |   7 +-
 .../ReleephRequestTransactionalEditor.php     |  11 +-
 .../field/selector/ReleephFieldSelector.php   |  11 +-
 .../ReleephDependsOnFieldSpecification.php    |   1 +
 .../ReleephDiffChurnFieldSpecification.php    |   6 +-
 .../ReleephDiffSizeFieldSpecification.php     |  18 ++-
 .../ReleephFieldSpecification.php             |   3 +-
 .../ReleephIntentFieldSpecification.php       |   8 +-
 .../ReleephLevelFieldSpecification.php        |  14 +-
 .../ReleephReasonFieldSpecification.php       |  12 +-
 .../ReleephRequestorFieldSpecification.php    |   4 +-
 .../ReleephRevisionFieldSpecification.php     |   2 +-
 .../ReleephSeverityFieldSpecification.php     |  15 +-
 .../ReleephSummaryFieldSpecification.php      |  12 +-
 .../mail/ReleephRequestReplyHandler.php       |   2 +-
 .../releeph/query/ReleephBranchQuery.php      |   2 +-
 .../releeph/query/ReleephRequestQuery.php     |   2 +-
 .../releeph/storage/ReleephRequest.php        |   2 +-
 .../view/branch/ReleephBranchPreviewView.php  |   4 +-
 .../view/branch/ReleephBranchTemplate.php     |  23 +--
 .../RemarkupProcessConduitAPIMethod.php       |   6 +-
 .../RepositoryCreateConduitAPIMethod.php      |  12 +-
 ...ositoryArcanistProjectDeleteController.php |   7 +-
 ...epositoryArcanistProjectEditController.php |   2 +-
 .../PhabricatorRepositoryListController.php   |   2 +-
 .../daemon/PhabricatorGitGraphStream.php      |   5 +-
 .../PhabricatorRepositoryPullLocalDaemon.php  |  10 +-
 .../PhabricatorRepositoryDiscoveryEngine.php  |   4 +-
 .../engine/PhabricatorRepositoryEngine.php    |   2 +-
 .../PhabricatorRepositoryPullEngine.php       |  57 ++++---
 .../engine/PhabricatorRepositoryRefEngine.php |   2 +-
 ...habricatorWorkingCopyDiscoveryTestCase.php |   2 +-
 .../PhabricatorWorkingCopyTestCase.php        |  15 +-
 .../PhabricatorRepositoryGraphCache.php       |   2 +-
 ...catorRepositoryManagementCacheWorkflow.php |  12 +-
 ...orRepositoryManagementDiscoverWorkflow.php |  16 +-
 ...icatorRepositoryManagementEditWorkflow.php |  16 +-
 ...rRepositoryManagementImportingWorkflow.php |  12 +-
 ...icatorRepositoryManagementListWorkflow.php |   4 +-
 ...epositoryManagementLookupUsersWorkflow.php |   5 +-
 ...positoryManagementMarkImportedWorkflow.php |   8 +-
 ...atorRepositoryManagementMirrorWorkflow.php |   5 +-
 ...icatorRepositoryManagementPullWorkflow.php |  16 +-
 ...icatorRepositoryManagementRefsWorkflow.php |  10 +-
 ...torRepositoryManagementReparseWorkflow.php |  69 +++++----
 ...atorRepositoryManagementUpdateWorkflow.php |   4 +-
 ...habricatorRepositoryManagementWorkflow.php |   2 +-
 .../query/PhabricatorRepositoryQuery.php      |   5 +-
 ...abricatorRepositoryCommitSearchIndexer.php |   2 +-
 .../storage/PhabricatorRepository.php         |  49 +++---
 .../PhabricatorRepositoryVCSPassword.php      |   2 +-
 .../PhabricatorRepositoryTestCase.php         |   8 +-
 ...habricatorRepositoryCommitOwnersWorker.php |  12 +-
 .../PhabricatorChangeParserTestCase.php       |   2 +-
 ...atorRepositoryCommitChangeParserWorker.php |   4 +-
 ...rRepositoryGitCommitChangeParserWorker.php |   2 +-
 ...rRepositorySvnCommitChangeParserWorker.php |  46 ++++--
 ...torRepositoryCommitMessageParserWorker.php |   7 +-
 .../PhabricatorSearchAttachController.php     |  57 +++----
 .../PhabricatorApplicationSearchEngine.php    |   4 +-
 .../engine/PhabricatorJumpNavHandler.php      |   2 +-
 .../PhabricatorSearchDocumentIndexer.php      |  18 ++-
 ...abricatorSearchManagementIndexWorkflow.php |  34 +++--
 ...habricatorSearchManagementInitWorkflow.php |   9 +-
 ...abricatorSearchApplicationSearchEngine.php |  10 +-
 .../query/PhabricatorSearchDocumentQuery.php  |   3 +-
 ...ricatorConduitCertificateSettingsPanel.php |   9 +-
 ...torConpherencePreferencesSettingsPanel.php |   7 +-
 ...catorDeveloperPreferencesSettingsPanel.php |  18 ++-
 ...habricatorDiffPreferencesSettingsPanel.php |   9 +-
 ...ricatorDisplayPreferencesSettingsPanel.php |  14 +-
 ...PhabricatorEmailAddressesSettingsPanel.php |   2 +-
 .../PhabricatorEmailFormatSettingsPanel.php   |   8 +-
 .../panel/PhabricatorSSHKeysSettingsPanel.php |   2 +-
 ...bricatorSearchPreferencesSettingsPanel.php |   2 +-
 .../storage/PhabricatorUserPreferences.php    |   6 +-
 .../conduit/SlowvoteInfoConduitAPIMethod.php  |   4 +-
 ...atorSubscriptionsSubscribeEmailCommand.php |  11 +-
 ...bricatorSystemSelectEncodingController.php |   8 +-
 .../phid/PhabricatorTokenTokenPHIDType.php    |   2 +-
 ...torApplicationTransactionCommentEditor.php |   6 +-
 ...habricatorApplicationTransactionEditor.php | 124 ++++++++++------
 ...licationTransactionValidationException.php |   2 +-
 .../PhabricatorApplicationTransaction.php     |   5 +-
 .../PhabricatorApplicationTransactionView.php |   5 +-
 ...ricatorTypeaheadFunctionHelpController.php |  34 ++---
 .../examples/JavelinReactorUIExample.php      |  26 ++--
 .../uiexample/examples/JavelinUIExample.php   |   8 +-
 .../examples/JavelinViewUIExample.php         |   6 +-
 .../examples/PHUIActionHeaderExample.php      |  44 +++---
 .../examples/PHUIActionPanelExample.php       |   6 +-
 .../uiexample/examples/PHUIBoxExample.php     |  12 +-
 .../examples/PHUIButtonBarExample.php         |   2 +-
 .../uiexample/examples/PHUIButtonExample.php  |  37 +++--
 .../examples/PHUIColorPalletteExample.php     |   6 +-
 .../examples/PHUIDocumentExample.php          |  36 ++---
 .../examples/PHUIFeedStoryExample.php         |  30 ++--
 .../uiexample/examples/PHUIIconExample.php    |   4 +-
 .../examples/PHUIImageMaskExample.php         |   5 +-
 .../uiexample/examples/PHUIInfoExample.php    |  35 ++---
 .../examples/PHUIInfoPanelExample.php         |  67 +++++----
 .../uiexample/examples/PHUIListExample.php    |  58 ++++----
 .../examples/PHUIObjectItemListExample.php    |  16 +-
 .../examples/PHUIPropertyListExample.php      |  61 ++++----
 .../uiexample/examples/PHUITagExample.php     |  32 ++--
 .../uiexample/examples/PHUITextExample.php    |  30 ++--
 .../examples/PHUITimelineExample.php          |  37 ++---
 .../examples/PHUITypeaheadExample.php         |   4 +-
 .../PhabricatorAphrontBarUIExample.php        |   4 +-
 .../examples/PhabricatorBarePageUIExample.php |   4 +-
 .../examples/PhabricatorBusyUIExample.php     |   4 +-
 .../examples/PhabricatorGestureUIExample.php  |  10 +-
 .../PhabricatorHovercardUIExample.php         |  21 +--
 .../PhabricatorListFilterUIExample.php        |  13 +-
 .../PhabricatorMultiColumnUIExample.php       |  27 ++--
 .../PhabricatorNotificationUIExample.php      |   9 +-
 .../examples/PhabricatorPagerUIExample.php    |  29 ++--
 .../PhabricatorSetupIssueUIExample.php        |   4 +-
 .../PhabricatorSortTableUIExample.php         |  16 +-
 .../examples/PhabricatorStatusUIExample.php   |   8 +-
 .../examples/PhabricatorTooltipUIExample.php  |   6 +-
 .../PhabricatorTwoColumnUIExample.php         |   4 +-
 .../examples/PhabricatorUIExample.php         |   9 +-
 .../PhabricatorXHProfProfileTopLevelView.php  |  20 +--
 ...orCustomFieldDataNotAvailableException.php |  15 +-
 ...habricatorCustomFieldNotProxyException.php |  19 +--
 .../field/PhabricatorCustomFieldList.php      |   8 +-
 .../PhabricatorCustomFieldIndexStorage.php    |   3 +-
 .../daemon/bot/PhabricatorBot.php             |   8 +-
 .../adapter/PhabricatorIRCProtocolAdapter.php |  18 ++-
 .../PhabricatorStreamingProtocolAdapter.php   |   6 +-
 .../handler/PhabricatorBotDebugLogHandler.php |   2 +-
 .../bot/handler/PhabricatorBotHandler.php     |   2 +-
 .../handler/PhabricatorBotSymbolHandler.php   |   7 +-
 .../handler/PhabricatorBotWhatsNewHandler.php |   2 +-
 .../workers/PhabricatorTaskmasterDaemon.php   |   4 +-
 .../__tests__/PhabricatorTestWorker.php       |   4 +-
 .../__tests__/PhabricatorWorkerTestCase.php   |  19 ++-
 .../PhabricatorMetronomicTriggerClock.php     |   3 +-
 .../clock/PhabricatorNeverTriggerClock.php    |   3 +-
 ...ricatorWorkerTriggerManagementWorkflow.php |   2 +-
 .../query/PhabricatorWorkerLeaseQuery.php     |  14 +-
 .../storage/PhabricatorWorkerActiveTask.php   |  22 +--
 .../storage/PhabricatorWorkerArchiveTask.php  |   2 +-
 .../workers/storage/PhabricatorWorkerTask.php |   9 +-
 .../view/PHUIDiffInlineCommentUndoView.php    |   2 +-
 .../edges/constants/PhabricatorEdgeConfig.php |   4 +-
 .../PhabricatorEdgeCycleException.php         |   5 +-
 .../edges/query/PhabricatorEdgeQuery.php      |   7 +-
 .../edges/type/PhabricatorEdgeType.php        |  14 +-
 .../edges/util/PhabricatorEdgeGraph.php       |   2 +-
 .../env/PhabricatorConfigFileSource.php       |   5 +-
 .../env/PhabricatorConfigLocalSource.php      |   3 +-
 .../env/PhabricatorConfigProxySource.php      |   2 +-
 .../env/PhabricatorConfigSource.php           |   6 +-
 .../env/PhabricatorConfigStackSource.php      |   2 +-
 src/infrastructure/env/PhabricatorEnv.php     |  14 +-
 .../env/__tests__/PhabricatorEnvTestCase.php  |  11 +-
 .../events/PhabricatorEventEngine.php         |   2 +-
 .../events/PhabricatorEventListener.php       |   2 +-
 .../PhabricatorExampleEventListener.php       |   2 +-
 .../PhabricatorBritishEnglishTranslation.php  |   4 +-
 .../lint/linter/PhabricatorJavelinLinter.php  |  56 ++++---
 .../markup/PhabricatorMarkupEngine.php        |  12 +-
 ...bricatorRemarkupCowsayBlockInterpreter.php |   4 +-
 .../query/order/PhabricatorQueryOrderItem.php |   3 +-
 .../policy/PhabricatorPolicyAwareQuery.php    |   4 +-
 ...catorSMSManagementListOutboundWorkflow.php |  17 +--
 ...abricatorSMSManagementSendTestWorkflow.php |  11 +-
 ...catorSMSManagementShowOutboundWorkflow.php |  13 +-
 .../PhabricatorSMSDemultiplexWorker.php       |   3 +-
 .../sms/worker/PhabricatorSMSSendWorker.php   |   8 +-
 .../ssh/PhabricatorSSHPassthruCommand.php     |  15 +-
 ...rontIsolatedDatabaseConnectionTestCase.php |   8 +-
 .../__tests__/QueryFormattingTestCase.php     |   2 +-
 src/infrastructure/storage/lisk/LiskDAO.php   |  60 +++++---
 .../storage/lisk/LiskDAOSet.php               |   5 +-
 .../PhabricatorDataNotAttachedException.php   |  24 +--
 .../storage/lisk/PhabricatorLiskDAO.php       |   2 +-
 .../lisk/__tests__/LiskFixtureTestCase.php    |   2 +-
 .../lisk/__tests__/LiskIsolationTestCase.php  |  30 ++--
 .../lisk/__tests__/LiskIsolationTestDAO.php   |   5 +-
 ...ricatorStorageManagementAdjustWorkflow.php |  10 +-
 ...atorStorageManagementDatabasesWorkflow.php |   2 +-
 ...icatorStorageManagementDestroyWorkflow.php |  29 ++--
 ...abricatorStorageManagementDumpWorkflow.php |   7 +-
 ...bricatorStorageManagementProbeWorkflow.php |   2 +-
 ...torStorageManagementQuickstartWorkflow.php |   7 +-
 ...bricatorStorageManagementShellWorkflow.php |   2 +-
 ...ricatorStorageManagementStatusWorkflow.php |  19 +--
 ...icatorStorageManagementUpgradeWorkflow.php |  63 +++++---
 .../storage/patch/PhabricatorSQLPatchList.php |  88 +++++++----
 .../testing/PhabricatorTestCase.php           |  11 +-
 src/infrastructure/time/PhabricatorTime.php   |   2 +-
 src/infrastructure/util/PhabricatorHash.php   |   9 +-
 .../__tests__/PhabricatorHashTestCase.php     |   4 +-
 .../__tests__/PhabricatorSlugTestCase.php     |   6 +-
 .../PhabricatorLocalTimeTestCase.php          |  10 +-
 src/view/form/PHUIFormPageView.php            |   8 +-
 src/view/form/PHUIPagedFormView.php           |  10 +-
 .../control/AphrontFormCheckboxControl.php    |   2 +-
 src/view/form/control/AphrontFormControl.php  |   4 +-
 .../form/control/AphrontFormDateControl.php   |   2 +-
 .../control/AphrontFormPasswordControl.php    |  10 +-
 .../control/PHUIFormMultiSubmitControl.php    |   2 +-
 src/view/layout/AphrontMoreView.php           |   2 +-
 src/view/layout/AphrontMultiColumnView.php    |   2 +-
 src/view/layout/PhabricatorActionView.php     |   6 +-
 src/view/page/PhabricatorStandardPageView.php |   3 +-
 src/view/phui/PHUIHeaderView.php              |   2 +-
 src/view/phui/PHUIObjectItemView.php          |   6 +-
 .../hovercard/PhabricatorHovercardView.php    |   2 +-
 support/aphlict/server/aphlict_launcher.php   |   2 +-
 webroot/index.php                             |   1 -
 928 files changed, 5267 insertions(+), 4239 deletions(-)

diff --git a/.arclint b/.arclint
index 0077bdf518..e8b804fedb 100644
--- a/.arclint
+++ b/.arclint
@@ -74,7 +74,6 @@
       "type": "xhpast",
       "include": "(\\.php$)",
       "severity": {
-        "16": "advice",
         "34": "error"
       },
       "xhpast.blacklisted.function": {
diff --git a/resources/sql/autopatches/20140106.macromailkey.2.php b/resources/sql/autopatches/20140106.macromailkey.2.php
index fdca4e4d59..a91e5a2c20 100644
--- a/resources/sql/autopatches/20140106.macromailkey.2.php
+++ b/resources/sql/autopatches/20140106.macromailkey.2.php
@@ -1,6 +1,6 @@
 <?php
 
-echo "Adding mailkeys to macros.\n";
+echo pht('Adding mailkeys to macros.')."\n";
 
 $table = new PhabricatorFileImageMacro();
 $conn_w = $table->establishConnection('w');
@@ -8,7 +8,7 @@ $iterator = new LiskMigrationIterator($table);
 foreach ($iterator as $macro) {
   $id = $macro->getID();
 
-  echo "Populating macro {$id}...\n";
+  echo pht('Populating macro %d...', $id)."\n";
 
   if (!$macro->getMailKey()) {
     queryfx(
@@ -20,4 +20,4 @@ foreach ($iterator as $macro) {
   }
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140108.ddbpname.2.php b/resources/sql/autopatches/20140108.ddbpname.2.php
index ca7e3ef8b2..3316f3df1d 100644
--- a/resources/sql/autopatches/20140108.ddbpname.2.php
+++ b/resources/sql/autopatches/20140108.ddbpname.2.php
@@ -1,6 +1,6 @@
 <?php
 
-echo "Adding names to Drydock blueprints.\n";
+echo pht('Adding names to Drydock blueprints.')."\n";
 
 $table = new DrydockBlueprint();
 $conn_w = $table->establishConnection('w');
@@ -8,7 +8,7 @@ $iterator = new LiskMigrationIterator($table);
 foreach ($iterator as $blueprint) {
   $id = $blueprint->getID();
 
-  echo "Populating blueprint {$id}...\n";
+  echo pht('Populating blueprint %d...', $id)."\n";
 
   if (!strlen($blueprint->getBlueprintName())) {
     queryfx(
@@ -20,4 +20,4 @@ foreach ($iterator as $blueprint) {
   }
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140113.legalpadsig.2.php b/resources/sql/autopatches/20140113.legalpadsig.2.php
index 8b244e2480..6c7b0131b2 100644
--- a/resources/sql/autopatches/20140113.legalpadsig.2.php
+++ b/resources/sql/autopatches/20140113.legalpadsig.2.php
@@ -1,6 +1,6 @@
 <?php
 
-echo "Adding secretkeys to legalpad document signatures.\n";
+echo pht('Adding secretkeys to legalpad document signatures.')."\n";
 
 $table = new LegalpadDocumentSignature();
 $conn_w = $table->establishConnection('w');
@@ -8,7 +8,7 @@ $iterator = new LiskMigrationIterator($table);
 foreach ($iterator as $sig) {
   $id = $sig->getID();
 
-  echo "Populating signature {$id}...\n";
+  echo pht('Populating signature %d...', $id)."\n";
 
   if (!$sig->getSecretKey()) {
     queryfx(
@@ -20,4 +20,4 @@ foreach ($iterator as $sig) {
   }
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140115.auth.3.unlimit.php b/resources/sql/autopatches/20140115.auth.3.unlimit.php
index 80c316f64a..9e5bc7fed3 100644
--- a/resources/sql/autopatches/20140115.auth.3.unlimit.php
+++ b/resources/sql/autopatches/20140115.auth.3.unlimit.php
@@ -9,7 +9,7 @@ $conn_w = $session_table->establishConnection('w');
 foreach (new LiskMigrationIterator($session_table) as $session) {
   $id = $session->getID();
 
-  echo "Migrating session {$id}...\n";
+  echo pht('Migrating session %d...', $id)."\n";
   $old_type = $session->getType();
   $new_type = preg_replace('/-.*$/', '', $old_type);
 
@@ -23,4 +23,4 @@ foreach (new LiskMigrationIterator($session_table) as $session) {
   }
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140205.cal.3.phid-mig.php b/resources/sql/autopatches/20140205.cal.3.phid-mig.php
index 6ba4ff7c5c..7aff389d17 100644
--- a/resources/sql/autopatches/20140205.cal.3.phid-mig.php
+++ b/resources/sql/autopatches/20140205.cal.3.phid-mig.php
@@ -3,11 +3,11 @@
 $table = new PhabricatorCalendarEvent();
 $conn_w = $table->establishConnection('w');
 
-echo "Assigning PHIDs to events...\n";
+echo pht('Assigning PHIDs to events...')."\n";
 foreach (new LiskMigrationIterator($table) as $event) {
   $id = $event->getID();
 
-  echo "Updating event {$id}...\n";
+  echo pht('Updating event %d...', $id)."\n";
   if ($event->getPHID()) {
     continue;
   }
@@ -19,4 +19,4 @@ foreach (new LiskMigrationIterator($table) as $event) {
     $table->generatePHID(),
     $id);
 }
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140210.herald.rule-condition-mig.php b/resources/sql/autopatches/20140210.herald.rule-condition-mig.php
index c653fa9d50..90f8aa0b3e 100644
--- a/resources/sql/autopatches/20140210.herald.rule-condition-mig.php
+++ b/resources/sql/autopatches/20140210.herald.rule-condition-mig.php
@@ -3,7 +3,8 @@
 $table = new HeraldCondition();
 $conn_w = $table->establishConnection('w');
 
-echo "Migrating Herald conditions of type Herald rule from IDs to PHIDs...\n";
+echo pht(
+  "Migrating Herald conditions of type Herald rule from IDs to PHIDs...\n");
 foreach (new LiskMigrationIterator($table) as $condition) {
   if ($condition->getFieldName() != HeraldAdapter::FIELD_RULE) {
     continue;
@@ -14,7 +15,7 @@ foreach (new LiskMigrationIterator($table) as $condition) {
     continue;
   }
   $id = $condition->getID();
-  echo "Updating condition {$id}...\n";
+  echo pht('Updating condition %s...', $id)."\n";
 
   $rule = id(new HeraldRuleQuery())
     ->setViewer(PhabricatorUser::getOmnipotentUser())
@@ -28,4 +29,4 @@ foreach (new LiskMigrationIterator($table) as $condition) {
     json_encode($rule->getPHID()),
     $id);
 }
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140210.projcfield.1.blurb.php b/resources/sql/autopatches/20140210.projcfield.1.blurb.php
index 3cb39c5dc1..90c4242e8d 100644
--- a/resources/sql/autopatches/20140210.projcfield.1.blurb.php
+++ b/resources/sql/autopatches/20140210.projcfield.1.blurb.php
@@ -5,10 +5,9 @@ $table_name = id(new PhabricatorProjectCustomFieldStorage())->getTableName();
 
 $rows = new LiskRawMigrationIterator($conn_w, 'project_profile');
 
-echo "Migrating project descriptions to custom storage...\n";
+echo pht('Migrating project descriptions to custom storage...')."\n";
 foreach ($rows as $row) {
   $phid = $row['projectPHID'];
-  echo "Migrating {$phid}...\n";
 
   $desc = $row['blurb'];
   if (strlen($desc)) {
@@ -23,4 +22,4 @@ foreach ($rows as $row) {
   }
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140211.dx.2.migcommenttext.php b/resources/sql/autopatches/20140211.dx.2.migcommenttext.php
index 8a76690ec5..705e858069 100644
--- a/resources/sql/autopatches/20140211.dx.2.migcommenttext.php
+++ b/resources/sql/autopatches/20140211.dx.2.migcommenttext.php
@@ -7,18 +7,18 @@ $content_source = PhabricatorContentSource::newForSource(
   PhabricatorContentSource::SOURCE_LEGACY,
   array())->serialize();
 
-echo "Migrating Differential comment text to modern storage...\n";
+echo pht('Migrating Differential comment text to modern storage...')."\n";
 foreach ($rows as $row) {
   $id = $row['id'];
-  echo "Migrating Differential comment {$id}...\n";
+  echo pht('Migrating Differential comment %d...', $id)."\n";
   if (!strlen($row['content'])) {
-    echo "Comment has no text, continuing.\n";
+    echo pht('Comment has no text, continuing.')."\n";
     continue;
   }
 
   $revision = id(new DifferentialRevision())->load($row['revisionID']);
   if (!$revision) {
-    echo "Comment has no valid revision, continuing.\n";
+    echo pht('Comment has no valid revision, continuing.')."\n";
     continue;
   }
 
@@ -68,4 +68,4 @@ foreach ($rows as $row) {
     $row['id']);
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140212.dx.1.armageddon.php b/resources/sql/autopatches/20140212.dx.1.armageddon.php
index 525bf78318..d2749bd5cf 100644
--- a/resources/sql/autopatches/20140212.dx.1.armageddon.php
+++ b/resources/sql/autopatches/20140212.dx.1.armageddon.php
@@ -7,14 +7,14 @@ $content_source = PhabricatorContentSource::newForSource(
   PhabricatorContentSource::SOURCE_LEGACY,
   array())->serialize();
 
-echo "Migrating Differential comments to modern storage...\n";
+echo pht('Migrating Differential comments to modern storage...')."\n";
 foreach ($rows as $row) {
   $id = $row['id'];
-  echo "Migrating comment {$id}...\n";
+  echo pht('Migrating comment %d...', $id)."\n";
 
   $revision = id(new DifferentialRevision())->load($row['revisionID']);
   if (!$revision) {
-    echo "No revision, continuing.\n";
+    echo pht('No revision, continuing.')."\n";
     continue;
   }
 
@@ -219,4 +219,4 @@ foreach ($rows as $row) {
   }
 
 }
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140218.passwords.4.vcs.php b/resources/sql/autopatches/20140218.passwords.4.vcs.php
index 5e58c63e86..1030775326 100644
--- a/resources/sql/autopatches/20140218.passwords.4.vcs.php
+++ b/resources/sql/autopatches/20140218.passwords.4.vcs.php
@@ -3,13 +3,13 @@
 $table = new PhabricatorRepositoryVCSPassword();
 $conn_w = $table->establishConnection('w');
 
-echo "Upgrading password hashing for VCS passwords.\n";
+echo pht('Upgrading password hashing for VCS passwords.')."\n";
 
 $best_hasher = PhabricatorPasswordHasher::getBestHasher();
 foreach (new LiskMigrationIterator($table) as $password) {
   $id = $password->getID();
 
-  echo "Migrating VCS password {$id}...\n";
+  echo pht('Migrating VCS password %d...', $id)."\n";
 
   $input_hash = $password->getPasswordHash();
   $input_envelope = new PhutilOpaqueEnvelope($input_hash);
@@ -24,4 +24,4 @@ foreach (new LiskMigrationIterator($table) as $password) {
     $id);
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140226.dxcustom.1.fielddata.php b/resources/sql/autopatches/20140226.dxcustom.1.fielddata.php
index aa1adf41be..9b1382f5b9 100644
--- a/resources/sql/autopatches/20140226.dxcustom.1.fielddata.php
+++ b/resources/sql/autopatches/20140226.dxcustom.1.fielddata.php
@@ -3,12 +3,12 @@
 $conn_w = id(new DifferentialRevision())->establishConnection('w');
 $rows = new LiskRawMigrationIterator($conn_w, 'differential_auxiliaryfield');
 
-echo "Modernizing Differential auxiliary field storage...\n";
+echo pht('Modernizing Differential auxiliary field storage...')."\n";
 
 $table_name = id(new DifferentialCustomFieldStorage())->getTableName();
 foreach ($rows as $row) {
   $id = $row['id'];
-  echo "Migrating row {$id}...\n";
+  echo pht('Migrating row %d...', $id)."\n";
   queryfx(
     $conn_w,
     'INSERT IGNORE INTO %T (objectPHID, fieldIndex, fieldValue)
@@ -19,4 +19,4 @@ foreach ($rows as $row) {
     $row['value']);
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140321.mstatus.2.mig.php b/resources/sql/autopatches/20140321.mstatus.2.mig.php
index 66c13844c3..7f91e00e1b 100644
--- a/resources/sql/autopatches/20140321.mstatus.2.mig.php
+++ b/resources/sql/autopatches/20140321.mstatus.2.mig.php
@@ -11,10 +11,10 @@ $status_map = array(
 
 $conn_w = id(new ManiphestTask())->establishConnection('w');
 
-echo "Migrating tasks to new status constants...\n";
+echo pht('Migrating tasks to new status constants...')."\n";
 foreach (new LiskMigrationIterator(new ManiphestTask()) as $task) {
   $id = $task->getID();
-  echo "Migrating T{$id}...\n";
+  echo pht('Migrating %s...', "T{$id}")."\n";
 
   $status = $task->getStatus();
   if (isset($status_map[$status])) {
@@ -27,13 +27,13 @@ foreach (new LiskMigrationIterator(new ManiphestTask()) as $task) {
   }
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
 
 
-echo "Migrating task transactions to new status constants...\n";
+echo pht('Migrating task transactions to new status constants...')."\n";
 foreach (new LiskMigrationIterator(new ManiphestTransaction()) as $xaction) {
   $id = $xaction->getID();
-  echo "Migrating {$id}...\n";
+  echo pht('Migrating %d...', $id)."\n";
 
   if ($xaction->getTransactionType() == ManiphestTransaction::TYPE_STATUS) {
     $old = $xaction->getOldValue();
@@ -55,14 +55,14 @@ foreach (new LiskMigrationIterator(new ManiphestTransaction()) as $xaction) {
       $id);
   }
 }
-echo "Done.\n";
+echo pht('Done.')."\n";
 
 $conn_w = id(new PhabricatorSavedQuery())->establishConnection('w');
 
-echo "Migrating searches to new status constants...\n";
+echo pht('Migrating searches to new status constants...')."\n";
 foreach (new LiskMigrationIterator(new PhabricatorSavedQuery()) as $query) {
   $id = $query->getID();
-  echo "Migrating {$id}...\n";
+  echo pht('Migrating %d...', $id)."\n";
 
   if ($query->getEngineClassName() !== 'ManiphestTaskSearchEngine') {
     continue;
@@ -91,4 +91,4 @@ foreach (new LiskMigrationIterator(new PhabricatorSavedQuery()) as $query) {
     }
   }
 }
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140323.harbor.1.renames.php b/resources/sql/autopatches/20140323.harbor.1.renames.php
index 892402bf80..8aab25d876 100644
--- a/resources/sql/autopatches/20140323.harbor.1.renames.php
+++ b/resources/sql/autopatches/20140323.harbor.1.renames.php
@@ -14,14 +14,14 @@ $tables = array(
   id(new HarbormasterBuildTarget())->getTableName(),
 );
 
-echo "Renaming Harbormaster classes...\n";
+echo pht('Renaming Harbormaster classes...')."\n";
 
 $conn_w = id(new HarbormasterBuildStep())->establishConnection('w');
 foreach ($names as $name) {
   $old = $name;
   $new = 'Harbormaster'.$name;
 
-  echo "Renaming {$old} -> {$new}...\n";
+  echo pht('Renaming %s -> %s...', $old, $new)."\n";
   foreach ($tables as $table) {
     queryfx(
       $conn_w,
@@ -32,4 +32,4 @@ foreach ($names as $name) {
   }
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140325.push.3.groups.php b/resources/sql/autopatches/20140325.push.3.groups.php
index b6a33ad4d8..8706da306a 100644
--- a/resources/sql/autopatches/20140325.push.3.groups.php
+++ b/resources/sql/autopatches/20140325.push.3.groups.php
@@ -2,7 +2,7 @@
 
 $conn_w = id(new PhabricatorRepository())->establishConnection('w');
 
-echo "Adding transaction log event groups...\n";
+echo pht('Adding transaction log event groups...')."\n";
 
 $logs = queryfx_all(
   $conn_w,
@@ -10,7 +10,7 @@ $logs = queryfx_all(
   'repository_pushlog');
 foreach ($logs as $log) {
   $id = $log['id'];
-  echo "Migrating log {$id}...\n";
+  echo pht('Migrating log %d...', $id)."\n";
   if ($log['pushEventPHID']) {
     continue;
   }
@@ -40,4 +40,4 @@ foreach ($logs as $log) {
     $log['transactionKey']);
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140410.accountsecret.2.php b/resources/sql/autopatches/20140410.accountsecret.2.php
index bd8fd3968a..7d0cf7ad88 100644
--- a/resources/sql/autopatches/20140410.accountsecret.2.php
+++ b/resources/sql/autopatches/20140410.accountsecret.2.php
@@ -1,12 +1,10 @@
 <?php
 
-echo "Updating users...\n";
-
+echo pht('Updating users...')."\n";
 
 foreach (new LiskMigrationIterator(new PhabricatorUser()) as $user) {
-
   $id = $user->getID();
-  echo "Updating {$id}...\n";
+  echo pht('Updating %d...', $id)."\n";
 
   if (strlen($user->getAccountSecret())) {
     continue;
@@ -20,4 +18,4 @@ foreach (new LiskMigrationIterator(new PhabricatorUser()) as $user) {
     $id);
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140420.rel.2.objectmig.php b/resources/sql/autopatches/20140420.rel.2.objectmig.php
index 6441f7c009..f54416a5b0 100644
--- a/resources/sql/autopatches/20140420.rel.2.objectmig.php
+++ b/resources/sql/autopatches/20140420.rel.2.objectmig.php
@@ -4,11 +4,11 @@ $pull_table = new ReleephRequest();
 $table_name = $pull_table->getTableName();
 $conn_w = $pull_table->establishConnection('w');
 
-echo "Setting object PHIDs for requests...\n";
+echo pht('Setting object PHIDs for requests...')."\n";
 foreach (new LiskMigrationIterator($pull_table) as $pull) {
   $id = $pull->getID();
 
-  echo "Migrating pull request {$id}...\n";
+  echo pht('Migrating pull request %d...', $id)."\n";
   if ($pull->getRequestedObjectPHID()) {
     // We already have a valid PHID, so skip this request.
     continue;
@@ -42,4 +42,4 @@ foreach (new LiskMigrationIterator($pull_table) as $pull) {
     $id);
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140521.projectslug.2.mig.php b/resources/sql/autopatches/20140521.projectslug.2.mig.php
index ad086e10bc..ca6ccf886a 100644
--- a/resources/sql/autopatches/20140521.projectslug.2.mig.php
+++ b/resources/sql/autopatches/20140521.projectslug.2.mig.php
@@ -6,16 +6,16 @@ $conn_w = $project_table->establishConnection('w');
 $slug_table_name = id(new PhabricatorProjectSlug())->getTableName();
 $time = time();
 
-echo "Migrating project phriction slugs...\n";
+echo pht('Migrating project phriction slugs...')."\n";
 foreach (new LiskMigrationIterator($project_table) as $project) {
   $id = $project->getID();
 
-  echo "Migrating project {$id}...\n";
+  echo pht('Migrating project %d...', $id)."\n";
   $phriction_slug = rtrim($project->getPhrictionSlug(), '/');
   $slug = id(new PhabricatorProjectSlug())
     ->loadOneWhere('slug = %s', $phriction_slug);
   if ($slug) {
-    echo "Already migrated {$id}... Continuing.\n";
+    echo pht('Already migrated %d... Continuing.', $id)."\n";
     continue;
   }
   queryfx(
@@ -27,7 +27,7 @@ foreach (new LiskMigrationIterator($project_table) as $project) {
     $phriction_slug,
     $time,
     $time);
-  echo "Migrated {$id}.\n";
+  echo pht('Migrated %d.', $id)."\n";
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140711.pnames.2.php b/resources/sql/autopatches/20140711.pnames.2.php
index ee3658384f..16030b5853 100644
--- a/resources/sql/autopatches/20140711.pnames.2.php
+++ b/resources/sql/autopatches/20140711.pnames.2.php
@@ -1,11 +1,11 @@
 <?php
 
-echo "Updating project datasource tokens...\n";
+echo pht('Updating project datasource tokens...')."\n";
 
 foreach (new LiskMigrationIterator(new PhabricatorProject()) as $project) {
   $name = $project->getName();
-  echo "Updating project '{$name}'...\n";
+  echo pht("Updating project '%d'...", $name)."\n";
   $project->updateDatasourceTokens();
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140722.appname.php b/resources/sql/autopatches/20140722.appname.php
index fca11bb4b5..8c3e5918b2 100644
--- a/resources/sql/autopatches/20140722.appname.php
+++ b/resources/sql/autopatches/20140722.appname.php
@@ -74,7 +74,7 @@ foreach ($applications as $application) {
 
 /* -(  User preferences  )--------------------------------------------------- */
 
-echo "Migrating user preferences...\n";
+echo pht('Migrating user preferences...')."\n";
 $table = new PhabricatorUserPreferences();
 $conn_w = $table->establishConnection('w');
 $pref_pinned = PhabricatorUserPreferences::PREFERENCE_APP_PINNED;
@@ -107,7 +107,7 @@ foreach (new LiskMigrationIterator(new PhabricatorUser()) as $user) {
 
 /* -(  Dashboard installs  )------------------------------------------------- */
 
-echo "Migrating dashboard installs...\n";
+echo pht('Migrating dashboard installs...')."\n";
 $table = new PhabricatorDashboardInstall();
 $conn_w = $table->establishConnection('w');
 
@@ -126,7 +126,7 @@ foreach (new LiskMigrationIterator($table) as $dashboard_install) {
 /* -(  Phabricator configuration  )------------------------------------------ */
 
 $config_key = 'phabricator.uninstalled-applications';
-echo "Migrating `{$config_key}` config...\n";
+echo pht('Migrating `%s` config...', $config_key)."\n";
 
 $config = PhabricatorConfigEntry::loadConfigEntry($config_key);
 $old_config = $config->getValue();
@@ -147,7 +147,7 @@ if ($old_config) {
 /* -(  phabricator.application-settings  )----------------------------------- */
 
 $config_key = 'phabricator.application-settings';
-echo "Migrating `{$config_key}` config...\n";
+echo pht('Migrating `%s` config...', $config_key)."\n";
 
 $config = PhabricatorConfigEntry::loadConfigEntry($config_key);
 $old_config = $config->getValue();
diff --git a/resources/sql/autopatches/20140722.audit.3.miginlines.php b/resources/sql/autopatches/20140722.audit.3.miginlines.php
index 30d9b1c797..c6778fa659 100644
--- a/resources/sql/autopatches/20140722.audit.3.miginlines.php
+++ b/resources/sql/autopatches/20140722.audit.3.miginlines.php
@@ -7,7 +7,7 @@ $conn_w->openTransaction();
 $src_table = 'audit_inlinecomment';
 $dst_table = 'audit_transaction_comment';
 
-echo "Migrating Audit inline comments to new format...\n";
+echo pht('Migrating Audit inline comments to new format...')."\n";
 
 $content_source = PhabricatorContentSource::newForSource(
   PhabricatorContentSource::SOURCE_LEGACY,
@@ -17,7 +17,7 @@ $rows = new LiskRawMigrationIterator($conn_w, $src_table);
 foreach ($rows as $row) {
   $id = $row['id'];
 
-  echo "Migrating inline #{$id}...\n";
+  echo pht('Migrating inline #%d...', $id);
 
   if ($row['auditCommentID']) {
     $xaction_phid = PhabricatorPHID::generateNewPHID(
@@ -74,4 +74,4 @@ foreach ($rows as $row) {
 }
 
 $conn_w->saveTransaction();
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140722.audit.4.migtext.php b/resources/sql/autopatches/20140722.audit.4.migtext.php
index 1bcd3d36b8..2da4e2683e 100644
--- a/resources/sql/autopatches/20140722.audit.4.migtext.php
+++ b/resources/sql/autopatches/20140722.audit.4.migtext.php
@@ -7,12 +7,12 @@ $content_source = PhabricatorContentSource::newForSource(
   PhabricatorContentSource::SOURCE_LEGACY,
   array())->serialize();
 
-echo "Migrating Audit comment text to modern storage...\n";
+echo pht('Migrating Audit comment text to modern storage...')."\n";
 foreach ($rows as $row) {
   $id = $row['id'];
-  echo "Migrating Audit comment {$id}...\n";
+  echo pht('Migrating Audit comment %d...', $id)."\n";
   if (!strlen($row['content'])) {
-    echo "Comment has no text, continuing.\n";
+    echo pht('Comment has no text, continuing.')."\n";
     continue;
   }
 
@@ -58,4 +58,4 @@ foreach ($rows as $row) {
     $row['id']);
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140722.renameauth.php b/resources/sql/autopatches/20140722.renameauth.php
index 8a021c834d..225031d2f1 100644
--- a/resources/sql/autopatches/20140722.renameauth.php
+++ b/resources/sql/autopatches/20140722.renameauth.php
@@ -18,7 +18,7 @@ $map = array(
   'PhabricatorAuthProviderOAuthWordPress' => 'PhabricatorWordPressAuthProvider',
 );
 
-echo "Migrating auth providers...\n";
+echo pht('Migrating auth providers...')."\n";
 $table = new PhabricatorAuthProviderConfig();
 $conn_w = $table->establishConnection('w');
 
diff --git a/resources/sql/autopatches/20140725.audit.1.migxactions.php b/resources/sql/autopatches/20140725.audit.1.migxactions.php
index 064ac92202..e0e14e439b 100644
--- a/resources/sql/autopatches/20140725.audit.1.migxactions.php
+++ b/resources/sql/autopatches/20140725.audit.1.migxactions.php
@@ -7,10 +7,10 @@ $content_source = PhabricatorContentSource::newForSource(
   PhabricatorContentSource::SOURCE_LEGACY,
   array())->serialize();
 
-echo "Migrating Audit comments to modern storage...\n";
+echo pht('Migrating Audit comments to modern storage...')."\n";
 foreach ($rows as $row) {
   $id = $row['id'];
-  echo "Migrating comment {$id}...\n";
+  echo pht('Migrating comment %d...', $id)."\n";
 
   $comments = queryfx_all(
     $conn_w,
@@ -147,4 +147,4 @@ foreach ($rows as $row) {
 
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140731.audit.1.subscribers.php b/resources/sql/autopatches/20140731.audit.1.subscribers.php
index c648ce3c00..b452275295 100644
--- a/resources/sql/autopatches/20140731.audit.1.subscribers.php
+++ b/resources/sql/autopatches/20140731.audit.1.subscribers.php
@@ -3,11 +3,11 @@
 $table = new PhabricatorRepositoryAuditRequest();
 $conn_w = $table->establishConnection('w');
 
-echo "Migrating Audit subscribers to subscriptions...\n";
+echo pht('Migrating Audit subscribers to subscriptions...')."\n";
 foreach (new LiskMigrationIterator($table) as $request) {
   $id = $request->getID();
 
-  echo "Migrating auditor {$id}...\n";
+  echo pht("Migrating audit %d...\n", $id);
 
   if ($request->getAuditStatus() != 'cc') {
     // This isn't a "subscriber", so skip it.
@@ -27,4 +27,4 @@ foreach (new LiskMigrationIterator($table) as $request) {
   $request->delete();
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140731.cancdn.php b/resources/sql/autopatches/20140731.cancdn.php
index 7994d88abf..f4090b092c 100644
--- a/resources/sql/autopatches/20140731.cancdn.php
+++ b/resources/sql/autopatches/20140731.cancdn.php
@@ -4,7 +4,7 @@ $table = new PhabricatorFile();
 $conn_w = $table->establishConnection('w');
 foreach (new LiskMigrationIterator($table) as $file) {
   $id = $file->getID();
-  echo "Updating flags for file {$id}...\n";
+  echo pht('Updating flags for file %d...', $id)."\n";
   $meta = $file->getMetadata();
   if (!idx($meta, 'canCDN')) {
 
diff --git a/resources/sql/autopatches/20140805.boardcol.2.php b/resources/sql/autopatches/20140805.boardcol.2.php
index b8a78278d8..317de4e370 100644
--- a/resources/sql/autopatches/20140805.boardcol.2.php
+++ b/resources/sql/autopatches/20140805.boardcol.2.php
@@ -19,12 +19,12 @@ foreach ($rows as $row) {
 
 $sql = array();
 foreach ($cols as $col_phid => $obj_phids) {
-  echo "Migrating column '{$col_phid}'...\n";
+  echo pht("Migrating column '%s'...", $col_phid)."\n";
   $column = id(new PhabricatorProjectColumn())->loadOneWhere(
     'phid = %s',
     $col_phid);
   if (!$column) {
-    echo "Column '{$col_phid}' does not exist.\n";
+    echo pht("Column '%s' does not exist.", $col_phid)."\n";
     continue;
   }
 
@@ -40,7 +40,7 @@ foreach ($cols as $col_phid => $obj_phids) {
   }
 }
 
-echo "Inserting rows...\n";
+echo pht('Inserting rows...')."\n";
 foreach (PhabricatorLiskDAO::chunkSQL($sql) as $chunk) {
   queryfx(
     $conn_w,
@@ -50,4 +50,4 @@ foreach (PhabricatorLiskDAO::chunkSQL($sql) as $chunk) {
     $chunk);
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140808.boardprop.3.php b/resources/sql/autopatches/20140808.boardprop.3.php
index 116cc773a3..947ce85f60 100644
--- a/resources/sql/autopatches/20140808.boardprop.3.php
+++ b/resources/sql/autopatches/20140808.boardprop.3.php
@@ -6,7 +6,7 @@ $conn_w = $table->establishConnection('w');
 foreach (new LiskMigrationIterator($table) as $column) {
   $id = $column->getID();
 
-  echo "Adjusting column {$id}...\n";
+  echo pht('Adjusting column %d...', $id)."\n";
   if ($column->getSequence() == 0) {
 
     $properties = $column->getProperties();
@@ -21,4 +21,4 @@ foreach (new LiskMigrationIterator($table) as $column) {
   }
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140815.cancdncase.php b/resources/sql/autopatches/20140815.cancdncase.php
index 400fdbb01a..0e9cafaabd 100644
--- a/resources/sql/autopatches/20140815.cancdncase.php
+++ b/resources/sql/autopatches/20140815.cancdncase.php
@@ -7,7 +7,10 @@ $table = new PhabricatorFile();
 $conn_w = $table->establishConnection('w');
 foreach (new LiskMigrationIterator($table) as $file) {
   $id = $file->getID();
-  echo "Updating capitalization of canCDN property for file {$id}...\n";
+  echo pht(
+    "Updating capitalization of %s property for file %d...\n",
+    'canCDN',
+    $id);
   $meta = $file->getMetadata();
 
   if (isset($meta['cancdn'])) {
diff --git a/resources/sql/autopatches/20140904.macroattach.php b/resources/sql/autopatches/20140904.macroattach.php
index 5e82f3aa5f..4761964758 100644
--- a/resources/sql/autopatches/20140904.macroattach.php
+++ b/resources/sql/autopatches/20140904.macroattach.php
@@ -4,7 +4,7 @@ $table = new PhabricatorFileImageMacro();
 foreach (new LiskMigrationIterator($table) as $macro) {
   $name = $macro->getName();
 
-  echo "Linking macro '{$name}'...\n";
+  echo pht("Linking macro '%s'...", $name)."\n";
 
   $editor = new PhabricatorEdgeEditor();
 
@@ -16,11 +16,11 @@ foreach (new LiskMigrationIterator($table) as $macro) {
     foreach ($phids as $phid) {
       $editor->addEdge(
         $macro->getPHID(),
-        PhabricatorObjectHasFileEdgeType::EDGECONST ,
+        PhabricatorObjectHasFileEdgeType::EDGECONST,
         $phid);
     }
     $editor->save();
   }
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20140914.betaproto.php b/resources/sql/autopatches/20140914.betaproto.php
index 4471d47fee..849c5acb3b 100644
--- a/resources/sql/autopatches/20140914.betaproto.php
+++ b/resources/sql/autopatches/20140914.betaproto.php
@@ -3,16 +3,16 @@
 $old_key = 'phabricator.show-beta-applications';
 $new_key = 'phabricator.show-prototypes';
 
-echo "Migrating '{$old_key}' to '{$new_key}'...\n";
+echo pht("Migrating '%s' to '%s'...", $old_key, $new_key)."\n";
 
 if (PhabricatorEnv::getEnvConfig($new_key)) {
-  echo "Skipping migration, new data is already set.\n";
+  echo pht('Skipping migration, new data is already set.')."\n";
   return;
 }
 
 $old = PhabricatorEnv::getEnvConfigIfExists($old_key);
 if (!$old) {
-  echo "Skipping migration, old data does not exist.\n";
+  echo pht('Skipping migration, old data does not exist.')."\n";
   return;
 }
 
@@ -21,4 +21,4 @@ PhabricatorConfigEntry::loadConfigEntry($new_key)
   ->setValue($old)
   ->save();
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20141107.phriction.policy.2.php b/resources/sql/autopatches/20141107.phriction.policy.2.php
index 9391173c6a..a7cc6ca3e4 100644
--- a/resources/sql/autopatches/20141107.phriction.policy.2.php
+++ b/resources/sql/autopatches/20141107.phriction.policy.2.php
@@ -3,7 +3,7 @@
 $table = new PhrictionDocument();
 $conn_w = $table->establishConnection('w');
 
-echo "Populating Phriction policies.\n";
+echo pht('Populating Phriction policies.')."\n";
 
 $default_view_policy = PhabricatorPolicies::POLICY_USER;
 $default_edit_policy = PhabricatorPolicies::POLICY_USER;
@@ -12,7 +12,7 @@ foreach (new LiskMigrationIterator($table) as $doc) {
   $id = $doc->getID();
 
   if ($doc->getViewPolicy() && $doc->getEditPolicy()) {
-    echo "Skipping doc $id; already has policy set.\n";
+    echo pht('Skipping document %d; already has policy set.', $id)."\n";
     continue;
   }
 
@@ -38,7 +38,10 @@ foreach (new LiskMigrationIterator($table) as $doc) {
       $edit_policy = nonempty($project->getEditPolicy(), $default_edit_policy);
 
       $project_name = $project->getName();
-      echo "Migrating doc $id to project policy $project_name...\n";
+      echo pht(
+        "Migrating document %d to project policy %s...\n",
+        $id,
+        $project_name);
       $doc->setViewPolicy($view_policy);
       $doc->setEditPolicy($edit_policy);
       $doc->save();
@@ -46,10 +49,10 @@ foreach (new LiskMigrationIterator($table) as $doc) {
     }
   }
 
-  echo "Migrating doc $id to default install policy...\n";
+  echo pht('Migrating document %d to default install policy...', $id)."\n";
   $doc->setViewPolicy($default_view_policy);
   $doc->setEditPolicy($default_edit_policy);
   $doc->save();
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20141107.phriction.popkeys.php b/resources/sql/autopatches/20141107.phriction.popkeys.php
index 9af7e3a952..31629c7fea 100644
--- a/resources/sql/autopatches/20141107.phriction.popkeys.php
+++ b/resources/sql/autopatches/20141107.phriction.popkeys.php
@@ -3,7 +3,7 @@
 $table = new PhrictionDocument();
 $conn_w = $table->establishConnection('w');
 
-echo "Populating Phriction mailkeys.\n";
+echo pht('Populating Phriction mailkeys.')."\n";
 
 foreach (new LiskMigrationIterator($table) as $doc) {
   $id = $doc->getID();
@@ -12,10 +12,10 @@ foreach (new LiskMigrationIterator($table) as $doc) {
   if ((strlen($key) == 20) && (strpos($key, "\0") === false)) {
     // To be valid, keys must have length 20 and not contain any null bytes.
     // See T6487.
-    echo "Document has valid mailkey.\n";
+    echo pht('Document has valid mailkey.')."\n";
     continue;
   } else {
-    echo "Populating mailkey for document {$id}...\n";
+    echo pht('Populating mailkey for document %d...', $id)."\n";
     $mail_key = Filesystem::readRandomCharacters(20);
     queryfx(
       $conn_w,
@@ -26,4 +26,4 @@ foreach (new LiskMigrationIterator($table) as $doc) {
   }
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20141107.ssh.4.keymig.php b/resources/sql/autopatches/20141107.ssh.4.keymig.php
index 2388a282cc..f3e2d3f098 100644
--- a/resources/sql/autopatches/20141107.ssh.4.keymig.php
+++ b/resources/sql/autopatches/20141107.ssh.4.keymig.php
@@ -3,18 +3,18 @@
 $table = new PhabricatorAuthSSHKey();
 $conn_w = $table->establishConnection('w');
 
-echo "Updating SSH public key indexes...\n";
+echo pht('Updating SSH public key indexes...')."\n";
 
 $keys = new LiskMigrationIterator($table);
 foreach ($keys as $key) {
   $id = $key->getID();
 
-  echo "Updating key {$id}...\n";
+  echo pht('Updating key %d...', $id)."\n";
 
   try {
     $hash = $key->toPublicKey()->getHash();
   } catch (Exception $ex) {
-    echo "Key has bad format! Removing key.\n";
+    echo pht('Key has bad format! Removing key.')."\n";
     queryfx(
       $conn_w,
       'DELETE FROM %T WHERE id = %d',
@@ -30,7 +30,7 @@ foreach ($keys as $key) {
     $hash,
     $key->getID());
   if ($collision) {
-    echo "Key is a duplicate! Removing key.\n";
+    echo pht('Key is a duplicate! Removing key.')."\n";
     queryfx(
       $conn_w,
       'DELETE FROM %T WHERE id = %d',
@@ -47,4 +47,4 @@ foreach ($keys as $key) {
     $key->getID());
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20141113.auditdupes.php b/resources/sql/autopatches/20141113.auditdupes.php
index 2cc7b9bab4..32a6586ca5 100644
--- a/resources/sql/autopatches/20141113.auditdupes.php
+++ b/resources/sql/autopatches/20141113.auditdupes.php
@@ -3,7 +3,7 @@
 $table = new PhabricatorRepositoryAuditRequest();
 $conn_w = $table->establishConnection('w');
 
-echo "Removing duplicate Audit requests...\n";
+echo pht('Removing duplicate Audit requests...')."\n";
 $seen_audit_map = array();
 foreach (new LiskMigrationIterator($table) as $request) {
   $commit_phid = $request->getCommitPHID();
@@ -19,4 +19,4 @@ foreach (new LiskMigrationIterator($table) as $request) {
   $seen_audit_map[$commit_phid][$auditor_phid] = 1;
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20141218.maniphestcctxn.php b/resources/sql/autopatches/20141218.maniphestcctxn.php
index fb1a67a41d..4ac3c62101 100644
--- a/resources/sql/autopatches/20141218.maniphestcctxn.php
+++ b/resources/sql/autopatches/20141218.maniphestcctxn.php
@@ -3,8 +3,9 @@
 $table = new ManiphestTransaction();
 $conn_w = $table->establishConnection('w');
 
-echo "Converting Maniphest CC transactions to modern SUBSCRIBER ".
-  "transactions...\n";
+echo pht(
+  "Converting Maniphest CC transactions to modern ".
+  "subscriber transactions...\n");
 foreach (new LiskMigrationIterator($table) as $txn) {
   // ManiphestTransaction::TYPE_CCS
   if ($txn->getTransactionType() == 'ccs') {
@@ -17,4 +18,4 @@ foreach (new LiskMigrationIterator($table) as $txn) {
   }
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20141222.maniphestprojtxn.php b/resources/sql/autopatches/20141222.maniphestprojtxn.php
index 1fa5726fa4..ba7a8f2f1f 100644
--- a/resources/sql/autopatches/20141222.maniphestprojtxn.php
+++ b/resources/sql/autopatches/20141222.maniphestprojtxn.php
@@ -3,8 +3,8 @@
 $table = new ManiphestTransaction();
 $conn_w = $table->establishConnection('w');
 
-echo "Converting Maniphest project transactions to modern EDGE ".
-  "transactions...\n";
+echo pht(
+  "Converting Maniphest project transactions to modern edge transactions...\n");
 $metadata = array(
   'edge:type' => PhabricatorProjectObjectHasProjectEdgeType::EDGECONST,
 );
@@ -31,7 +31,7 @@ foreach (new LiskMigrationIterator($table) as $txn) {
   }
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
 
 function mig20141222_build_edge_data(array $project_phids, $task_phid) {
   $edge_data = array();
diff --git a/resources/sql/autopatches/20150102.policyname.php b/resources/sql/autopatches/20150102.policyname.php
index a76143527e..cf94b918e7 100644
--- a/resources/sql/autopatches/20150102.policyname.php
+++ b/resources/sql/autopatches/20150102.policyname.php
@@ -15,7 +15,7 @@ foreach ($policies as $policy) {
   $map[$old_name] = $new_name;
 }
 
-echo "Migrating policies...\n";
+echo pht('Migrating policies...')."\n";
 $table = new PhabricatorPolicy();
 $conn_w = $table->establishConnection('w');
 
diff --git a/resources/sql/autopatches/20150116.maniphestapplicationemails.php b/resources/sql/autopatches/20150116.maniphestapplicationemails.php
index c3e1f53eee..91430568ca 100644
--- a/resources/sql/autopatches/20150116.maniphestapplicationemails.php
+++ b/resources/sql/autopatches/20150116.maniphestapplicationemails.php
@@ -1,7 +1,7 @@
 <?php
 
 $key = 'metamta.maniphest.public-create-email';
-echo "Migrating `$key` to new application email infrastructure...\n";
+echo pht("Migrating `%s` to new application email infrastructure...\n", $key);
 $value = PhabricatorEnv::getEnvConfigIfExists($key);
 $maniphest = new PhabricatorManiphestApplication();
 
@@ -13,8 +13,8 @@ if ($value) {
       ->setApplicationPHID($maniphest->getPHID())
       ->save();
   } catch (AphrontDuplicateKeyQueryException $ex) {
-    // already migrated?
+    // Already migrated?
   }
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20150120.maniphestdefaultauthor.php b/resources/sql/autopatches/20150120.maniphestdefaultauthor.php
index ae064544f2..352dd4cbbd 100644
--- a/resources/sql/autopatches/20150120.maniphestdefaultauthor.php
+++ b/resources/sql/autopatches/20150120.maniphestdefaultauthor.php
@@ -1,7 +1,7 @@
 <?php
 
 $key = 'metamta.maniphest.default-public-author';
-echo "Migrating `$key` to new application email infrastructure...\n";
+echo pht("Migrating `%s` to new application email infrastructure...\n", $key);
 $value = PhabricatorEnv::getEnvConfigIfExists($key);
 $maniphest = new PhabricatorManiphestApplication();
 $config_key =
@@ -19,4 +19,4 @@ if ($value) {
   }
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20150129.pastefileapplicationemails.php b/resources/sql/autopatches/20150129.pastefileapplicationemails.php
index 68c3dd2381..80e92fb307 100644
--- a/resources/sql/autopatches/20150129.pastefileapplicationemails.php
+++ b/resources/sql/autopatches/20150129.pastefileapplicationemails.php
@@ -2,8 +2,10 @@
 
 $key_files = 'metamta.files.public-create-email';
 $key_paste = 'metamta.paste.public-create-email';
-echo "Migrating `$key_files` and `$key_paste` to new application email ".
-  "infrastructure...\n";
+echo pht(
+  "Migrating `%s` and `%s` to new application email infrastructure...\n",
+  $key_files,
+  $key_paste);
 
 $value_files = PhabricatorEnv::getEnvConfigIfExists($key_files);
 $files_app = new PhabricatorFilesApplication();
@@ -16,7 +18,7 @@ if ($value_files) {
       ->setApplicationPHID($files_app->getPHID())
       ->save();
   } catch (AphrontDuplicateKeyQueryException $ex) {
-    // already migrated?
+    // Already migrated?
   }
 }
 
@@ -31,8 +33,8 @@ if ($value_paste) {
       ->setApplicationPHID($paste_app->getPHID())
       ->save();
   } catch (AphrontDuplicateKeyQueryException $ex) {
-    // already migrated?
+    // Already migrated?
   }
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20150501.calendar.2.reply.php b/resources/sql/autopatches/20150501.calendar.2.reply.php
index 0b448e79cf..2dab8268a6 100644
--- a/resources/sql/autopatches/20150501.calendar.2.reply.php
+++ b/resources/sql/autopatches/20150501.calendar.2.reply.php
@@ -1,6 +1,6 @@
 <?php
 
-echo "Adding mailkeys to events.\n";
+echo pht('Adding %s to events.', 'mailkeys')."\n";
 
 $table = new PhabricatorCalendarEvent();
 $conn_w = $table->establishConnection('w');
@@ -8,7 +8,7 @@ $iterator = new LiskMigrationIterator($table);
 foreach ($iterator as $event) {
   $id = $event->getID();
 
-  echo "Populating event {$id}...\n";
+  echo pht('Populating event %d...', $id)."\n";
 
   queryfx(
     $conn_w,
@@ -18,4 +18,4 @@ foreach ($iterator as $event) {
     $id);
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/autopatches/20150506.calendarunnamedevents.1.php b/resources/sql/autopatches/20150506.calendarunnamedevents.1.php
index 0b8c029584..00512de9ed 100644
--- a/resources/sql/autopatches/20150506.calendarunnamedevents.1.php
+++ b/resources/sql/autopatches/20150506.calendarunnamedevents.1.php
@@ -1,6 +1,6 @@
 <?php
 
-echo "Retro-naming unnamed events.\n";
+echo pht('Retro-naming unnamed events.')."\n";
 
 $table = new PhabricatorCalendarEvent();
 $conn_w = $table->establishConnection('w');
@@ -9,7 +9,7 @@ foreach ($iterator as $event) {
   $id = $event->getID();
 
   if (strlen($event->getName()) == 0) {
-    echo "Renaming event {$id}...\n";
+    echo pht('Renaming event %d...', $id)."\n";
     $viewer = PhabricatorUser::getOmnipotentUser();
 
     // NOTE: This uses PeopleQuery directly, instead of HandleQuery, to avoid
@@ -35,4 +35,4 @@ foreach ($iterator as $event) {
   }
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/059.engines.php b/resources/sql/patches/059.engines.php
index 8c1c7bc8e3..96e28b7a31 100644
--- a/resources/sql/patches/059.engines.php
+++ b/resources/sql/patches/059.engines.php
@@ -15,17 +15,18 @@ if (!$tables) {
   return;
 }
 
-echo "There are ".count($tables)." tables using the MyISAM engine. These will ".
-     "now be converted to InnoDB. This process may take a few minutes, please ".
-     "be patient.\n";
+echo pht(
+  "There are %d tables using the MyISAM engine. These will now be converted ".
+  "to InnoDB. This process may take a few minutes, please be patient.\n",
+  count($tables));
 
 foreach ($tables as $table) {
   $name = $table['db'].'.'.$table['tbl'];
-  echo "Converting {$name}...\n";
+  echo pht('Converting %s...', $name)."\n";
   queryfx(
     $conn,
     'ALTER TABLE %T.%T ENGINE=InnoDB',
     $table['db'],
     $table['tbl']);
 }
-echo "Done!\n";
+echo pht('Done!')."\n";
diff --git a/resources/sql/patches/079.nametokenindex.php b/resources/sql/patches/079.nametokenindex.php
index 931a850bf0..e0f607e0b7 100644
--- a/resources/sql/patches/079.nametokenindex.php
+++ b/resources/sql/patches/079.nametokenindex.php
@@ -1,13 +1,13 @@
 <?php
 
-echo "Indexing username tokens for typeaheads...\n";
+echo pht('Indexing username tokens for typeaheads...')."\n";
 
 $table = new PhabricatorUser();
 $table->openTransaction();
 $table->beginReadLocking();
 
 $users = $table->loadAll();
-echo count($users).' users to index';
+echo pht('%d users to index', count($users));
 foreach ($users as $user) {
   $user->updateNameTokens();
   echo '.';
@@ -15,4 +15,4 @@ foreach ($users as $user) {
 
 $table->endReadLocking();
 $table->saveTransaction();
-echo "\nDone.\n";
+echo "\n".pht('Done.')."\n";
diff --git a/resources/sql/patches/081.filekeys.php b/resources/sql/patches/081.filekeys.php
index 1a4a3851fe..c129e80918 100644
--- a/resources/sql/patches/081.filekeys.php
+++ b/resources/sql/patches/081.filekeys.php
@@ -1,12 +1,12 @@
 <?php
 
-echo "Generating file keys...\n";
+echo pht('Generating file keys...')."\n";
 $table = new PhabricatorFile();
 $table->openTransaction();
 $table->beginReadLocking();
 
 $files = $table->loadAllWhere('secretKey IS NULL');
-echo count($files).' files to generate keys for';
+echo pht('%d files to generate keys for', count($files));
 foreach ($files as $file) {
   queryfx(
     $file->establishConnection('w'),
@@ -19,4 +19,4 @@ foreach ($files as $file) {
 
 $table->endReadLocking();
 $table->saveTransaction();
-echo "\nDone.\n";
+echo "\n".pht('Done.')."\n";
diff --git a/resources/sql/patches/090.forceuniqueprojectnames.php b/resources/sql/patches/090.forceuniqueprojectnames.php
index c3881ad011..a12de8ecfd 100644
--- a/resources/sql/patches/090.forceuniqueprojectnames.php
+++ b/resources/sql/patches/090.forceuniqueprojectnames.php
@@ -1,6 +1,6 @@
 <?php
 
-echo "Ensuring project names are unique enough...\n";
+echo pht('Ensuring project names are unique enough...')."\n";
 $table = new PhabricatorProject();
 $table->openTransaction();
 $table->beginReadLocking();
@@ -14,8 +14,8 @@ foreach ($projects as $project) {
   $slug = $project->getPhrictionSlug();
   if ($slug == '/') {
     $project_id = $project->getID();
-    echo "Project #{$project_id} doesn't have a meaningful name...\n";
-    $project->setName(trim('Unnamed Project '.$project->getName()));
+    echo pht("Project #%d doesn't have a meaningful name...", $project_id)."\n";
+    $project->setName(trim(pht('Unnamed Project %s', $project->getName())));
   }
   $slug_map[$slug][] = $project->getID();
 }
@@ -25,15 +25,18 @@ foreach ($slug_map as $slug => $similar) {
   if (count($similar) <= 1) {
     continue;
   }
-  echo "Too many projects are similar to '{$slug}'...\n";
+  echo pht("Too many projects are similar to '%s'...", $slug)."\n";
 
   foreach (array_slice($similar, 1, null, true) as $key => $project_id) {
     $project = $projects[$project_id];
     $old_name = $project->getName();
     $new_name = rename_project($project, $projects);
 
-    echo "Renaming project #{$project_id} ".
-         "from '{$old_name}' to '{$new_name}'.\n";
+    echo pht(
+      "Renaming project #%d from '%s' to '%s'.\n",
+      $project_id,
+      $old_name,
+      $new_name);
     $project->setName($new_name);
   }
 }
@@ -47,7 +50,7 @@ while ($update) {
     $project->setPhrictionSlug($name);
     $slug = $project->getPhrictionSlug();
 
-    echo "Updating project #{$id} '{$name}' ({$slug})...";
+    echo pht("Updating project #%d '%s' (%s)... ", $id, $name, $slug);
     try {
       queryfx(
         $project->establishConnection('w'),
@@ -57,22 +60,23 @@ while ($update) {
         $slug,
         $project->getID());
       unset($update[$key]);
-      echo "okay.\n";
+      echo pht('OKAY')."\n";
     } catch (AphrontDuplicateKeyQueryException $ex) {
-      echo "failed, will retry.\n";
+      echo pht('Failed, will retry.')."\n";
     }
   }
   if (count($update) == $size) {
     throw new Exception(
-      'Failed to make any progress while updating projects. Schema upgrade '.
-      'has failed. Go manually fix your project names to be unique (they are '.
-      'probably ridiculous?) and then try again.');
+      pht(
+        'Failed to make any progress while updating projects. Schema upgrade '.
+        'has failed. Go manually fix your project names to be unique '.
+        '(they are probably ridiculous?) and then try again.'));
   }
 }
 
 $table->endReadLocking();
 $table->saveTransaction();
-echo "Done.\n";
+echo pht('Done.')."\n";
 
 
 /**
diff --git a/resources/sql/patches/093.gitremotes.php b/resources/sql/patches/093.gitremotes.php
index 7af320bf89..5817919e24 100644
--- a/resources/sql/patches/093.gitremotes.php
+++ b/resources/sql/patches/093.gitremotes.php
@@ -1,6 +1,6 @@
 <?php
 
-echo "Stripping remotes from repository default branches...\n";
+echo pht('Stripping remotes from repository default branches...')."\n";
 
 $table = new PhabricatorRepository();
 $table->openTransaction();
@@ -30,8 +30,13 @@ foreach ($repos as $repo) {
   $id = $repo['id'];
   $name = $repo['name'];
 
-  echo "Updating default branch for repository #{$id} '{$name}' from ".
-       "'{$old}' to '{$new}' to remove the explicit remote.\n";
+  echo pht(
+    "Updating default branch for repository #%d '%s' from ".
+    "'%s' to '%s' to remove the explicit remote.\n",
+    $id,
+    $name,
+    $old,
+    $new);
   queryfx(
     $conn_w,
     'UPDATE %T SET details = %s WHERE id = %d',
@@ -41,4 +46,4 @@ foreach ($repos as $repo) {
 }
 
 $table->saveTransaction();
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/098.heraldruletypemigration.php b/resources/sql/patches/098.heraldruletypemigration.php
index 0efc8c7e94..896f2353f3 100644
--- a/resources/sql/patches/098.heraldruletypemigration.php
+++ b/resources/sql/patches/098.heraldruletypemigration.php
@@ -1,6 +1,6 @@
 <?php
 
-echo "Checking for rules that can be converted to 'personal'. ";
+echo pht("Checking for rules that can be converted to 'personal'.")."\n";
 $table = new HeraldRule();
 $table->openTransaction();
 $table->beginReadLocking();
@@ -41,11 +41,11 @@ foreach ($rules as $rule) {
         $rule->getRuleType(),
         $rule->getID());
 
-      echo "Setting rule '".$rule->getName()."' to personal. ";
+      echo pht("Setting rule '%s' to personal.", $rule->getName())."\n";
     }
   }
 }
 
 $table->endReadLocking();
 $table->saveTransaction();
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/102.heraldcleanup.php b/resources/sql/patches/102.heraldcleanup.php
index 24bf382c09..5b885bd670 100644
--- a/resources/sql/patches/102.heraldcleanup.php
+++ b/resources/sql/patches/102.heraldcleanup.php
@@ -1,6 +1,6 @@
 <?php
 
-echo "Cleaning up old Herald rule applied rows...\n";
+echo pht('Cleaning up old Herald rule applied rows...')."\n";
 $table = new HeraldRule();
 $table->openTransaction();
 $table->beginReadLocking();
@@ -24,7 +24,7 @@ if ($rules) {
     mpull($rules, 'getID'));
 }
 
-echo 'This may take a moment';
+echo pht('This may take a moment')."\n";
 do {
   queryfx(
     $conn_w,
@@ -36,4 +36,4 @@ do {
 
 $table->endReadLocking();
 $table->saveTransaction();
-echo "\nDone.\n";
+echo "\n".pht('Done.')."\n";
diff --git a/resources/sql/patches/111.commitauditmigration.php b/resources/sql/patches/111.commitauditmigration.php
index 489a07d789..935317b577 100644
--- a/resources/sql/patches/111.commitauditmigration.php
+++ b/resources/sql/patches/111.commitauditmigration.php
@@ -1,6 +1,6 @@
 <?php
 
-echo "Updating old commit authors...\n";
+echo pht('Updating old commit authors...')."\n";
 $table = new PhabricatorRepositoryCommit();
 $table->openTransaction();
 
@@ -31,10 +31,10 @@ foreach ($commits as $commit) {
 }
 
 $table->saveTransaction();
-echo "Done.\n";
+echo pht('Done.')."\n";
 
 
-echo "Updating old commit mailKeys...\n";
+echo pht('Updating old commit %s...', 'mailKeys')."\n";
 $table->openTransaction();
 
 $commits = queryfx_all(
@@ -55,4 +55,4 @@ foreach ($commits as $commit) {
 }
 
 $table->saveTransaction();
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/131.migraterevisionquery.php b/resources/sql/patches/131.migraterevisionquery.php
index cf505b6295..316c7cdee2 100644
--- a/resources/sql/patches/131.migraterevisionquery.php
+++ b/resources/sql/patches/131.migraterevisionquery.php
@@ -5,7 +5,7 @@ $table->openTransaction();
 $table->beginReadLocking();
 $conn_w = $table->establishConnection('w');
 
-echo 'Migrating revisions';
+echo pht('Migrating revisions')."\n";
 do {
   $revisions = $table->loadAllWhere('branchName IS NULL LIMIT 1000');
 
@@ -32,4 +32,4 @@ do {
 
 $table->endReadLocking();
 $table->saveTransaction();
-echo "\nDone.\n";
+echo "\n".pht('Done.')."\n";
diff --git a/resources/sql/patches/20121209.xmacromigrate.php b/resources/sql/patches/20121209.xmacromigrate.php
index df52cb317c..bdd9fc1276 100644
--- a/resources/sql/patches/20121209.xmacromigrate.php
+++ b/resources/sql/patches/20121209.xmacromigrate.php
@@ -1,6 +1,6 @@
 <?php
 
-echo 'Giving image macros PHIDs';
+echo pht('Giving image macros PHIDs');
 $table = new PhabricatorFileImageMacro();
 $table->openTransaction();
 
@@ -20,4 +20,4 @@ foreach (new LiskMigrationIterator($table) as $macro) {
 }
 
 $table->saveTransaction();
-echo "\nDone.\n";
+echo "\n".pht('Done.')."\n";
diff --git a/resources/sql/patches/20130201.revisionunsubscribed.php b/resources/sql/patches/20130201.revisionunsubscribed.php
index 0f01e1d129..904fe1cc86 100644
--- a/resources/sql/patches/20130201.revisionunsubscribed.php
+++ b/resources/sql/patches/20130201.revisionunsubscribed.php
@@ -1,6 +1,6 @@
 <?php
 
-echo "Migrating Differential unsubscribed users to edges...\n";
+echo pht('Migrating Differential unsubscribed users to edges...')."\n";
 $table = new DifferentialRevision();
 $table->openTransaction();
 
@@ -29,4 +29,4 @@ foreach ($revs as $rev) {
 }
 
 $table->saveTransaction();
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20130218.updatechannelid.php b/resources/sql/patches/20130218.updatechannelid.php
index b8b6d8c416..cf60544a3b 100644
--- a/resources/sql/patches/20130218.updatechannelid.php
+++ b/resources/sql/patches/20130218.updatechannelid.php
@@ -1,6 +1,6 @@
 <?php
 
-echo "Updating channel IDs of previous chatlog events...\n";
+echo pht('Updating channel IDs of previous chatlog events...')."\n";
 $event_table = new PhabricatorChatLogEvent();
 $channel_table = new PhabricatorChatLogChannel();
 
@@ -61,4 +61,4 @@ $channel_table->endReadLocking();
 $event_table->saveTransaction();
 $channel_table->saveTransaction();
 
-echo "\nDone.\n";
+echo "\n".pht('Done.')."\n";
diff --git a/resources/sql/patches/20130219.commitsummarymig.php b/resources/sql/patches/20130219.commitsummarymig.php
index 85ed6e34f4..60bdd1542c 100644
--- a/resources/sql/patches/20130219.commitsummarymig.php
+++ b/resources/sql/patches/20130219.commitsummarymig.php
@@ -1,12 +1,12 @@
 <?php
 
-echo "Backfilling commit summaries...\n";
+echo pht('Backfilling commit summaries...')."\n";
 
 $table = new PhabricatorRepositoryCommit();
 $conn_w = $table->establishConnection('w');
 $commits = new LiskMigrationIterator($table);
 foreach ($commits as $commit) {
-  echo 'Filling Commit #'.$commit->getID()."\n";
+  echo pht('Filling Commit #%d', $commit->getID())."\n";
 
   if (strlen($commit->getSummary())) {
     continue;
@@ -28,4 +28,4 @@ foreach ($commits as $commit) {
     $commit->getID());
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20130403.conpherencecachemig.php b/resources/sql/patches/20130403.conpherencecachemig.php
index ffc50006c0..cad9fc626d 100644
--- a/resources/sql/patches/20130403.conpherencecachemig.php
+++ b/resources/sql/patches/20130403.conpherencecachemig.php
@@ -1,6 +1,7 @@
 <?php
 
-echo "Migrating data from conpherence transactions to conpherence 'cache'...\n";
+echo pht(
+  "Migrating data from conpherence transactions to conpherence 'cache'...\n");
 
 $table = new ConpherenceThread();
 $table->openTransaction();
@@ -10,7 +11,7 @@ $participant_table = new ConpherenceParticipant();
 
 $conpherences = new LiskMigrationIterator($table);
 foreach ($conpherences as $conpherence) {
-  echo 'Migrating conpherence #'.$conpherence->getID()."\n";
+  echo pht('Migrating conpherence #%d', $conpherence->getID())."\n";
 
   $participants = id(new ConpherenceParticipant())
     ->loadAllWhere('conpherencePHID = %s', $conpherence->getPHID());
@@ -61,4 +62,4 @@ foreach ($conpherences as $conpherence) {
 }
 
 $table->saveTransaction();
-echo "\nDone.\n";
+echo "\n".pht('Done.')."\n";
diff --git a/resources/sql/patches/20130409.commitdrev.php b/resources/sql/patches/20130409.commitdrev.php
index d3a2faefbd..fb556f1846 100644
--- a/resources/sql/patches/20130409.commitdrev.php
+++ b/resources/sql/patches/20130409.commitdrev.php
@@ -1,6 +1,6 @@
 <?php
 
-echo "Migrating differential.revisionPHID to edges...\n";
+echo pht('Migrating %s to edges...', 'differential.revisionPHID')."\n";
 $commit_table = new PhabricatorRepositoryCommit();
 $data_table = new PhabricatorRepositoryCommitData();
 $editor = new PhabricatorEdgeEditor();
@@ -30,4 +30,4 @@ foreach (new LiskMigrationIterator($commit_table) as $commit) {
 
 echo '.';
 $editor->save();
-echo "\nDone.\n";
+echo "\n".pht('Done.')."\n";
diff --git a/resources/sql/patches/20130502.countdownrevamp2.php b/resources/sql/patches/20130502.countdownrevamp2.php
index 6f7e41e1d2..04d998dab9 100644
--- a/resources/sql/patches/20130502.countdownrevamp2.php
+++ b/resources/sql/patches/20130502.countdownrevamp2.php
@@ -1,6 +1,6 @@
 <?php
 
-echo 'Giving countdowns PHIDs';
+echo pht('Giving countdowns PHIDs');
 $table = new PhabricatorCountdown();
 $table->openTransaction();
 
@@ -20,4 +20,4 @@ foreach (new LiskMigrationIterator($table) as $countdown) {
 }
 
 $table->saveTransaction();
-echo "\nDone.\n";
+echo "\n".pht('Done.')."\n";
diff --git a/resources/sql/patches/20130507.releephrqmailkeypop.php b/resources/sql/patches/20130507.releephrqmailkeypop.php
index 4acf3a5383..016381dc58 100644
--- a/resources/sql/patches/20130507.releephrqmailkeypop.php
+++ b/resources/sql/patches/20130507.releephrqmailkeypop.php
@@ -1,6 +1,6 @@
 <?php
 
-echo "Populating Releeph requests with mail keys...\n";
+echo pht('Populating Releeph requests with mail keys...')."\n";
 
 $table = new ReleephRequest();
 $table->openTransaction();
@@ -17,11 +17,11 @@ foreach (new LiskMigrationIterator($table) as $rq) {
       $rq->getTableName(),
       Filesystem::readRandomCharacters(20),
       $id);
-    echo "Generated Key\n";
+    echo pht('Generated Key')."\n";
   } else {
     echo "-\n";
   }
 }
 
 $table->saveTransaction();
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20130529.macroauthormig.php b/resources/sql/patches/20130529.macroauthormig.php
index 89f10e29c8..f642f392c8 100644
--- a/resources/sql/patches/20130529.macroauthormig.php
+++ b/resources/sql/patches/20130529.macroauthormig.php
@@ -1,8 +1,8 @@
 <?php
 
-echo "Migrating macro authors...\n";
+echo pht('Migrating macro authors...')."\n";
 foreach (new LiskMigrationIterator(new PhabricatorFileImageMacro()) as $macro) {
-  echo "Macro #".$macro->getID()."\n";
+  echo pht('Macro #%d', $macro->getID())."\n";
 
   if ($macro->getAuthorPHID()) {
     // Already have an author; skip it.
@@ -36,4 +36,4 @@ foreach (new LiskMigrationIterator(new PhabricatorFileImageMacro()) as $macro) {
     $macro->getID());
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20130611.migrateoauth.php b/resources/sql/patches/20130611.migrateoauth.php
index 468ee78ff4..3622b2772e 100644
--- a/resources/sql/patches/20130611.migrateoauth.php
+++ b/resources/sql/patches/20130611.migrateoauth.php
@@ -9,7 +9,7 @@ $conn_w = $table->establishConnection('w');
 
 $xaccount = new PhabricatorExternalAccount();
 
-echo "Migrating OAuth to ExternalAccount...\n";
+echo pht('Migrating OAuth to %s...', 'ExternalAccount')."\n";
 
 $domain_map = array(
   'disqus'      => 'disqus.com',
@@ -31,18 +31,18 @@ $rows = queryfx_all(
   $conn_w,
   'SELECT * FROM user_oauthinfo');
 foreach ($rows as $row) {
-  echo "Migrating row ID #".$row['id'].".\n";
+  echo pht('Migrating row ID #%d.', $row['id'])."\n";
   $user = id(new PhabricatorUser())->loadOneWhere(
     'id = %d',
     $row['userID']);
   if (!$user) {
-    echo "Bad user ID!\n";
+    echo pht('Bad user ID!')."\n";
     continue;
   }
 
   $domain = idx($domain_map, $row['oauthProvider']);
   if (empty($domain)) {
-    echo "Unknown OAuth provider!\n";
+    echo pht('Unknown OAuth provider!')."\n";
     continue;
   }
 
@@ -63,4 +63,4 @@ foreach ($rows as $row) {
   }
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20130611.nukeldap.php b/resources/sql/patches/20130611.nukeldap.php
index ee97bb64ab..3f225cfa84 100644
--- a/resources/sql/patches/20130611.nukeldap.php
+++ b/resources/sql/patches/20130611.nukeldap.php
@@ -9,16 +9,16 @@ $conn_w = $table->establishConnection('w');
 
 $xaccount = new PhabricatorExternalAccount();
 
-echo "Migrating LDAP to ExternalAccount...\n";
+echo pht('Migrating LDAP to %s...', 'ExternalAccount')."\n";
 
 $rows = queryfx_all($conn_w, 'SELECT * FROM %T', $table_name);
 foreach ($rows as $row) {
-  echo "Migrating row ID #".$row['id'].".\n";
+  echo pht('Migrating row ID #%d.', $row['id'])."\n";
   $user = id(new PhabricatorUser())->loadOneWhere(
     'id = %d',
     $row['userID']);
   if (!$user) {
-    echo "Bad user ID!\n";
+    echo pht('Bad user ID!')."\n";
     continue;
   }
 
@@ -38,4 +38,4 @@ foreach ($rows as $row) {
   }
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20130619.authconf.php b/resources/sql/patches/20130619.authconf.php
index 0b56735521..ab0378ee64 100644
--- a/resources/sql/patches/20130619.authconf.php
+++ b/resources/sql/patches/20130619.authconf.php
@@ -60,11 +60,11 @@ foreach ($config_map as $provider_class => $spec) {
     $enabled_default);
 
   if (!$enabled) {
-    echo pht("Skipping %s (not enabled).\n", $provider_class);
+    echo pht('Skipping %s (not enabled).', $provider_class)."\n";
     // This provider was not previously enabled, so we can skip migrating it.
     continue;
   } else {
-    echo pht("Migrating %s...\n", $provider_class);
+    echo pht('Migrating %s...', $provider_class)."\n";
   }
 
   $registration_key = idx($spec, 'registration');
@@ -161,4 +161,4 @@ foreach ($config_map as $provider_class => $spec) {
   $config->save();
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20130703.legalpaddocdenorm.php b/resources/sql/patches/20130703.legalpaddocdenorm.php
index 9cb6ef1979..61056ceb23 100644
--- a/resources/sql/patches/20130703.legalpaddocdenorm.php
+++ b/resources/sql/patches/20130703.legalpaddocdenorm.php
@@ -1,7 +1,9 @@
 <?php
 
-echo 'Populating Legalpad Documents with ',
- "titles, recentContributorPHIDs, and contributorCounts...\n";
+echo pht(
+  "Populating Legalpad Documents with titles, %s, and %s...\n",
+  'recentContributorPHIDs',
+  'contributorCounts');
 $table = new LegalpadDocument();
 $table->openTransaction();
 
@@ -9,14 +11,14 @@ foreach (new LiskMigrationIterator($table) as $document) {
   $updated = false;
   $id = $document->getID();
 
-  echo "Document {$id}: ";
+  echo pht('Document %d: ', $id);
   if (!$document->getTitle()) {
     $document_body = id(new LegalpadDocumentBody())
       ->loadOneWhere('phid = %s', $document->getDocumentBodyPHID());
     $title = $document_body->getTitle();
     $document->setTitle($title);
     $updated = true;
-    echo "Added title: $title\n";
+    echo pht('Added title: %s', $title)."\n";
   } else {
     echo "-\n";
   }
@@ -29,9 +31,9 @@ foreach (new LiskMigrationIterator($table) as $document) {
       $document->getPHID(),
       $type);
     $document->setRecentContributorPHIDs(array_slice($contributors, 0, 3));
-    echo "Added recent contributor phids.\n";
+    echo pht('Added recent contributor PHIDs.')."\n";
     $document->setContributorCount(count($contributors));
-    echo "Added contributor count.\n";
+    echo pht('Added contributor count.')."\n";
   }
 
   if (!$updated) {
@@ -43,4 +45,4 @@ foreach (new LiskMigrationIterator($table) as $document) {
 }
 
 $table->saveTransaction();
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20130711.pholioimageobsolete.php b/resources/sql/patches/20130711.pholioimageobsolete.php
index eae9a479d8..a0f805c69b 100644
--- a/resources/sql/patches/20130711.pholioimageobsolete.php
+++ b/resources/sql/patches/20130711.pholioimageobsolete.php
@@ -1,6 +1,6 @@
 <?php
 
-echo 'Giving pholio images PHIDs';
+echo pht('Giving Pholio images PHIDs');
 $table = new PholioImage();
 $table->openTransaction();
 
@@ -20,4 +20,4 @@ foreach (new LiskMigrationIterator($table) as $image) {
 }
 
 $table->saveTransaction();
-echo "\nDone.\n";
+echo "\n".pht('Done.')."\n";
diff --git a/resources/sql/patches/20130711.trimrealnames.php b/resources/sql/patches/20130711.trimrealnames.php
index c422565b32..a5d2ef2c40 100644
--- a/resources/sql/patches/20130711.trimrealnames.php
+++ b/resources/sql/patches/20130711.trimrealnames.php
@@ -3,18 +3,18 @@
 $table = new PhabricatorUser();
 $conn_w = $table->establishConnection('w');
 
-echo "Trimming trailing whitespace from user real names...\n";
+echo pht('Trimming trailing whitespace from user real names...')."\n";
 foreach (new LiskMigrationIterator($table) as $user) {
   $id = $user->getID();
   $real = $user->getRealName();
   $trim = rtrim($real);
 
   if ($trim == $real) {
-    echo "User {$id} is already trim.\n";
+    echo pht('User %d is already trim.', $id)."\n";
     continue;
   }
 
-  echo "Trimming user {$id} from '{$real}' to '{$trim}'.\n";
+  echo pht("Trimming user %d from '%s' to '%s'.", $id, $real, $trim)."\n";
   qsprintf(
     $conn_w,
     'UPDATE %T SET realName = %s WHERE id = %d',
@@ -23,4 +23,4 @@ foreach (new LiskMigrationIterator($table) as $user) {
     $id);
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20130715.votecomments.php b/resources/sql/patches/20130715.votecomments.php
index c60b13bb37..0d540596b3 100644
--- a/resources/sql/patches/20130715.votecomments.php
+++ b/resources/sql/patches/20130715.votecomments.php
@@ -1,6 +1,6 @@
 <?php
 
-echo "Moving Slowvote comments to transactions...\n";
+echo pht('Moving Slowvote comments to transactions...')."\n";
 
 $viewer = PhabricatorUser::getOmnipotentUser();
 
@@ -20,14 +20,14 @@ foreach ($comments as $comment) {
   $date_created = $comment['dateCreated'];
   $date_modified = $comment['dateModified'];
 
-  echo "Migrating comment {$id}.\n";
+  echo pht('Migrating comment %d.', $id)."\n";
 
   $poll = id(new PhabricatorSlowvoteQuery())
     ->setViewer($viewer)
     ->withIDs(array($poll_id))
     ->executeOne();
   if (!$poll) {
-    echo "No poll.\n";
+    echo pht('No poll.')."\n";
     continue;
   }
 
@@ -36,7 +36,7 @@ foreach ($comments as $comment) {
     ->withPHIDs(array($author_phid))
     ->executeOne();
   if (!$user) {
-    echo "No user.\n";
+    echo pht('No user.')."\n";
     continue;
   }
 
@@ -98,4 +98,4 @@ foreach ($comments as $comment) {
 
 $conn_w->saveTransaction();
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20130716.archivememberlessprojects.php b/resources/sql/patches/20130716.archivememberlessprojects.php
index 259c564cec..bd5671cba3 100644
--- a/resources/sql/patches/20130716.archivememberlessprojects.php
+++ b/resources/sql/patches/20130716.archivememberlessprojects.php
@@ -1,18 +1,17 @@
 <?php
 
-echo "Archiving projects with no members...\n";
+echo pht('Archiving projects with no members...')."\n";
 
 $table = new PhabricatorProject();
 $table->openTransaction();
 
 foreach (new LiskMigrationIterator($table) as $project) {
-
   $members = PhabricatorEdgeQuery::loadDestinationPHIDs(
     $project->getPHID(),
     PhabricatorProjectProjectHasMemberEdgeType::EDGECONST);
 
   if (count($members)) {
-    echo sprintf(
+    echo pht(
       'Project "%s" has %d members; skipping.',
       $project->getName(),
       count($members)), "\n";
@@ -20,13 +19,13 @@ foreach (new LiskMigrationIterator($table) as $project) {
   }
 
   if ($project->getStatus() == PhabricatorProjectStatus::STATUS_ARCHIVED) {
-    echo sprintf(
+    echo pht(
       'Project "%s" already archived; skipping.',
       $project->getName()), "\n";
     continue;
   }
 
-  echo sprintf('Archiving project "%s"...', $project->getName()), "\n";
+  echo pht('Archiving project "%s"...', $project->getName())."\n";
   queryfx(
     $table->establishConnection('w'),
     'UPDATE %T SET status = %s WHERE id = %d',
@@ -36,4 +35,4 @@ foreach (new LiskMigrationIterator($table) as $project) {
 }
 
 $table->saveTransaction();
-echo "\nDone.\n";
+echo "\n".pht('Done.')."\n";
diff --git a/resources/sql/patches/20130728.ponderunique.php b/resources/sql/patches/20130728.ponderunique.php
index 94a45ae786..2facd4e3f0 100644
--- a/resources/sql/patches/20130728.ponderunique.php
+++ b/resources/sql/patches/20130728.ponderunique.php
@@ -2,7 +2,7 @@
 
 $map = array();
 
-echo "Merging duplicate answers by authors...\n";
+echo pht('Merging duplicate answers by authors...')."\n";
 
 $atable = new PonderAnswer();
 $conn_w = $atable->establishConnection('w');
@@ -14,14 +14,14 @@ foreach ($answers as $answer) {
   $qid = $answer->getQuestionID();
   $author_phid = $answer->getAuthorPHID();
 
-  echo "Processing answer ID #{$aid}...\n";
+  echo pht('Processing answer ID #%d...', $aid)."\n";
 
   if (empty($map[$qid][$author_phid])) {
-    echo "Answer is unique.\n";
+    echo pht('Answer is unique.')."\n";
     $map[$qid][$author_phid] = $answer;
     continue;
   } else {
-    echo "Merging answer.\n";
+    echo pht('Merging answer.')."\n";
     $target = $map[$qid][$author_phid];
     queryfx(
       $conn_w,
@@ -55,4 +55,4 @@ foreach ($answers as $answer) {
 }
 
 $conn_w->saveTransaction();
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20130728.ponderxcomment.php b/resources/sql/patches/20130728.ponderxcomment.php
index 1fb65ade76..92e858f95e 100644
--- a/resources/sql/patches/20130728.ponderxcomment.php
+++ b/resources/sql/patches/20130728.ponderxcomment.php
@@ -6,13 +6,13 @@ $atable = new PonderAnswerTransaction();
 $conn_w = $qtable->establishConnection('w');
 $conn_w->openTransaction();
 
-echo "Migrating Ponder comments to ApplicationTransactions...\n";
+echo pht('Migrating Ponder comments to %s...', 'ApplicationTransactions')."\n";
 
 $rows = new LiskRawMigrationIterator($conn_w, 'ponder_comment');
 foreach ($rows as $row) {
 
   $id = $row['id'];
-  echo "Migrating {$id}...\n";
+  echo pht('Migrating %d...', $id)."\n";
 
   $type = phid_get_type($row['targetPHID']);
   switch ($type) {
@@ -83,4 +83,4 @@ foreach ($rows as $row) {
 
 $conn_w->saveTransaction();
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20130801.pastexactions.php b/resources/sql/patches/20130801.pastexactions.php
index 52d5a081da..1977eb984e 100644
--- a/resources/sql/patches/20130801.pastexactions.php
+++ b/resources/sql/patches/20130801.pastexactions.php
@@ -6,13 +6,13 @@ $x_table = new PhabricatorPasteTransaction();
 $conn_w = $table->establishConnection('w');
 $conn_w->openTransaction();
 
-echo "Adding transactions for existing paste objects...\n";
+echo pht('Adding transactions for existing paste objects...')."\n";
 
 $rows = new LiskRawMigrationIterator($conn_w, 'pastebin_paste');
 foreach ($rows as $row) {
 
   $id = $row['id'];
-  echo "Adding transactions for paste id {$id}...\n";
+  echo pht('Adding transactions for paste id %d...', $id)."\n";
 
   $xaction_phid = PhabricatorPHID::generateNewPHID(
     PhabricatorApplicationTransactionTransactionPHIDType::TYPECONST);
@@ -45,4 +45,4 @@ foreach ($rows as $row) {
 
 $conn_w->saveTransaction();
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20130802.heraldphids.php b/resources/sql/patches/20130802.heraldphids.php
index 814bbddef1..726a335d1f 100644
--- a/resources/sql/patches/20130802.heraldphids.php
+++ b/resources/sql/patches/20130802.heraldphids.php
@@ -3,11 +3,11 @@
 $table = new HeraldRule();
 $conn_w = $table->establishConnection('w');
 
-echo "Assigning PHIDs to Herald Rules...\n";
+echo pht('Assigning PHIDs to Herald Rules...')."\n";
 
 foreach (new LiskMigrationIterator(new HeraldRule()) as $rule) {
   $id = $rule->getID();
-  echo "Rule {$id}.\n";
+  echo pht('Rule %d.', $id)."\n";
 
   if ($rule->getPHID()) {
     continue;
@@ -21,4 +21,4 @@ foreach (new LiskMigrationIterator(new HeraldRule()) as $rule) {
     $rule->getID());
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20130805.pastemailkeypop.php b/resources/sql/patches/20130805.pastemailkeypop.php
index 5354453b6d..bb2d51ded5 100644
--- a/resources/sql/patches/20130805.pastemailkeypop.php
+++ b/resources/sql/patches/20130805.pastemailkeypop.php
@@ -1,6 +1,6 @@
 <?php
 
-echo "Populating pastes with mail keys...\n";
+echo pht('Populating pastes with mail keys...')."\n";
 
 $table = new PhabricatorPaste();
 $table->openTransaction();
@@ -17,11 +17,11 @@ foreach (new LiskMigrationIterator($table) as $paste) {
       $paste->getTableName(),
       Filesystem::readRandomCharacters(20),
       $id);
-    echo "Generated Key\n";
+    echo pht('Generated Key')."\n";
   } else {
     echo "-\n";
   }
 }
 
 $table->saveTransaction();
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20130820.file-mailkey-populate.php b/resources/sql/patches/20130820.file-mailkey-populate.php
index de1a920d97..ba4d6d1606 100644
--- a/resources/sql/patches/20130820.file-mailkey-populate.php
+++ b/resources/sql/patches/20130820.file-mailkey-populate.php
@@ -1,6 +1,6 @@
 <?php
 
-echo "Populating Phabricator files with mail keys xactions...\n";
+echo pht('Populating Phabricator files with mail keys xactions...')."\n";
 
 $table = new PhabricatorFile();
 $table_name = $table->getTableName();
@@ -35,4 +35,4 @@ if ($sql) {
 }
 
 $table->saveTransaction();
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20130915.maniphestmigrate.php b/resources/sql/patches/20130915.maniphestmigrate.php
index a9013662e3..c1c4bcaf5d 100644
--- a/resources/sql/patches/20130915.maniphestmigrate.php
+++ b/resources/sql/patches/20130915.maniphestmigrate.php
@@ -5,12 +5,12 @@ $table_name = id(new ManiphestCustomFieldStorage())->getTableName();
 
 $rows = new LiskRawMigrationIterator($conn_w, 'maniphest_taskauxiliarystorage');
 
-echo "Migrating custom storage for Maniphest fields...\n";
+echo pht('Migrating custom storage for Maniphest fields...')."\n";
 foreach ($rows as $row) {
   $phid = $row['taskPHID'];
   $name = $row['name'];
 
-  echo "Migrating {$phid} / {$name}...\n";
+  echo pht('Migrating %s / %s...', $phid, $name)."\n";
 
   queryfx(
     $conn_w,
@@ -22,4 +22,4 @@ foreach ($rows as $row) {
     $row['value']);
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20130919.mfieldconf.php b/resources/sql/patches/20130919.mfieldconf.php
index 099e7c0813..c79521acbc 100644
--- a/resources/sql/patches/20130919.mfieldconf.php
+++ b/resources/sql/patches/20130919.mfieldconf.php
@@ -1,18 +1,18 @@
 <?php
 
-echo "Migrating Maniphest custom field configuration...\n";
+echo pht('Migrating Maniphest custom field configuration...')."\n";
 
 $old_key = 'maniphest.custom-fields';
 $new_key = 'maniphest.custom-field-definitions';
 
 if (PhabricatorEnv::getEnvConfig($new_key)) {
-  echo "Skipping migration, new data is already set.\n";
+  echo pht('Skipping migration, new data is already set.')."\n";
   return;
 }
 
 $old = PhabricatorEnv::getEnvConfigIfExists($old_key);
 if (!$old) {
-  echo "Skipping migration, old data does not exist.\n";
+  echo pht('Skipping migration, old data does not exist.')."\n";
   return;
 }
 
@@ -63,4 +63,4 @@ PhabricatorConfigEntry::loadConfigEntry($new_key)
   ->setValue($new)
   ->save();
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20130921.xmigratemaniphest.php b/resources/sql/patches/20130921.xmigratemaniphest.php
index 24614867f8..2f7f5952ce 100644
--- a/resources/sql/patches/20130921.xmigratemaniphest.php
+++ b/resources/sql/patches/20130921.xmigratemaniphest.php
@@ -14,7 +14,7 @@ foreach ($rows as $row) {
   $row_id = $row['id'];
   $task_id = $row['taskID'];
 
-  echo "Migrating row {$row_id} (T{$task_id})...\n";
+  echo pht('Migrating row %d (%s)...', $row_id, "T{$task_id}")."\n";
 
   $task_row = queryfx_one(
     $conn_w,
@@ -22,7 +22,7 @@ foreach ($rows as $row) {
     $task_table->getTableName(),
     $task_id);
   if (!$task_row) {
-    echo "Skipping, no such task.\n";
+    echo pht('Skipping, no such task.')."\n";
     continue;
   }
 
@@ -145,4 +145,4 @@ foreach ($rows as $row) {
 }
 
 $conn_w->saveTransaction();
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20130926.dinline.php b/resources/sql/patches/20130926.dinline.php
index 36632d9103..f2d9e9f205 100644
--- a/resources/sql/patches/20130926.dinline.php
+++ b/resources/sql/patches/20130926.dinline.php
@@ -7,7 +7,7 @@ $conn_w->openTransaction();
 $src_table = 'differential_inlinecomment';
 $dst_table = 'differential_transaction_comment';
 
-echo "Migrating Differential inline comments to new format...\n";
+echo pht('Migrating Differential inline comments to new format...')."\n";
 
 $content_source = PhabricatorContentSource::newForSource(
   PhabricatorContentSource::SOURCE_LEGACY,
@@ -19,7 +19,7 @@ foreach ($rows as $row) {
 
   $revision_id = $row['revisionID'];
 
-  echo "Migrating inline #{$id} (D{$revision_id})...\n";
+  echo pht('Migrating inline #%d (%s)...', $id, "D{$revision_id}")."\n";
 
   $revision_row = queryfx_one(
     $conn_w,
@@ -87,4 +87,4 @@ foreach ($rows as $row) {
 }
 
 $conn_w->saveTransaction();
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20131004.dxreviewers.php b/resources/sql/patches/20131004.dxreviewers.php
index b117048a1e..4f853f5ddc 100644
--- a/resources/sql/patches/20131004.dxreviewers.php
+++ b/resources/sql/patches/20131004.dxreviewers.php
@@ -10,7 +10,7 @@ foreach (new LiskMigrationIterator($table) as $revision) {
   $revision_id = $revision->getID();
   $revision_phid = $revision->getPHID();
 
-  echo "Migrating reviewers for D{$revision_id}...\n";
+  echo pht('Migrating reviewers for %s...', "D{$revision_id}")."\n";
 
   $reviewer_phids = queryfx_all(
     $conn_w,
@@ -48,4 +48,4 @@ foreach (new LiskMigrationIterator($table) as $revision) {
   $editor->save();
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20131020.pxactionmig.php b/resources/sql/patches/20131020.pxactionmig.php
index eb7c706e1f..7bf4416cd0 100644
--- a/resources/sql/patches/20131020.pxactionmig.php
+++ b/resources/sql/patches/20131020.pxactionmig.php
@@ -7,7 +7,7 @@ $conn_w->openTransaction();
 $src_table = 'project_legacytransaction';
 $dst_table = 'project_transaction';
 
-echo "Migrating Project transactions to new format...\n";
+echo pht('Migrating Project transactions to new format...')."\n";
 
 $content_source = PhabricatorContentSource::newForSource(
   PhabricatorContentSource::SOURCE_LEGACY,
@@ -19,7 +19,7 @@ foreach ($rows as $row) {
 
   $project_id = $row['projectID'];
 
-  echo "Migrating transaction #{$id} (Project {$project_id})...\n";
+  echo pht('Migrating transaction #%d (Project %d)...', $id, $project_id)."\n";
 
   $project_row = queryfx_one(
     $conn_w,
@@ -89,4 +89,4 @@ foreach ($rows as $row) {
 }
 
 $conn_w->saveTransaction();
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20131106.diffphid.2.mig.php b/resources/sql/patches/20131106.diffphid.2.mig.php
index b7f502f47a..67fd14aad0 100644
--- a/resources/sql/patches/20131106.diffphid.2.mig.php
+++ b/resources/sql/patches/20131106.diffphid.2.mig.php
@@ -13,7 +13,7 @@ foreach ($chunk_iter as $chunk) {
 
   foreach ($chunk as $diff) {
     $id = $diff->getID();
-    echo "Migrating diff ID {$id}...\n";
+    echo pht('Migrating diff ID %d...', $id)."\n";
 
     $phid = $diff->getPHID();
     if (strlen($phid)) {
@@ -44,4 +44,4 @@ foreach ($chunk_iter as $chunk) {
   }
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20131112.userverified.2.mig.php b/resources/sql/patches/20131112.userverified.2.mig.php
index 381fc966ab..a8c231ec20 100644
--- a/resources/sql/patches/20131112.userverified.2.mig.php
+++ b/resources/sql/patches/20131112.userverified.2.mig.php
@@ -5,7 +5,7 @@ $conn_w = $table->establishConnection('w');
 
 foreach (new LiskMigrationIterator($table) as $user) {
   $username = $user->getUsername();
-  echo "Migrating {$username}...\n";
+  echo pht('Migrating %s...', $username)."\n";
   if ($user->getIsEmailVerified()) {
     // Email already verified.
     continue;
@@ -30,4 +30,4 @@ foreach (new LiskMigrationIterator($table) as $user) {
     $user->getID());
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20131118.ownerorder.php b/resources/sql/patches/20131118.ownerorder.php
index 35433f8e12..a3a5659946 100644
--- a/resources/sql/patches/20131118.ownerorder.php
+++ b/resources/sql/patches/20131118.ownerorder.php
@@ -9,7 +9,7 @@ $user_conn = $user_table->establishConnection('r');
 foreach (new LiskMigrationIterator($table) as $task) {
   $id = $task->getID();
 
-  echo "Checking task T{$id}...\n";
+  echo pht('Checking task %s...', "T{$id}")."\n";
   $owner_phid = $task->getOwnerPHID();
 
   if (!$owner_phid && !$task->getOwnerOrdering()) {
@@ -39,4 +39,4 @@ foreach (new LiskMigrationIterator($table) as $task) {
   }
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20131121.repocredentials.2.mig.php b/resources/sql/patches/20131121.repocredentials.2.mig.php
index acb7f2f01d..3953b8416f 100644
--- a/resources/sql/patches/20131121.repocredentials.2.mig.php
+++ b/resources/sql/patches/20131121.repocredentials.2.mig.php
@@ -7,16 +7,16 @@ $viewer = PhabricatorUser::getOmnipotentUser();
 $map = array();
 foreach (new LiskMigrationIterator($table) as $repository) {
   $callsign = $repository->getCallsign();
-  echo "Examining repository {$callsign}...\n";
+  echo pht('Examining repository %s...', $callsign)."\n";
 
   if ($repository->getCredentialPHID()) {
-    echo "...already has a Credential.\n";
+    echo pht('...already has a Credential.')."\n";
     continue;
   }
 
   $raw_uri = $repository->getRemoteURI();
   if (!$raw_uri) {
-    echo "...no remote URI.\n";
+    echo pht('...no remote URI.')."\n";
     continue;
   }
 
@@ -50,12 +50,12 @@ foreach (new LiskMigrationIterator($table) as $repository) {
   }
 
   if (!$username || !$secret) {
-    echo "...no credentials set.\n";
+    echo pht('...no credentials set.')."\n";
     continue;
   }
 
   $map[$type][$username][$secret][] = $repository;
-  echo "...will migrate.\n";
+  echo pht('...will migrate.')."\n";
 }
 
 $passphrase = new PassphraseSecret();
@@ -76,7 +76,7 @@ foreach ($map as $credential_type => $credential_usernames) {
           ->setMaximumGlyphs(128)
           ->truncateString($signs));
 
-      echo "Creating: {$name}...\n";
+      echo pht('Creating: %s...', $name)."\n";
 
       $secret = id(new PassphraseSecret())
         ->setSecretData($secret_plaintext)
@@ -136,4 +136,4 @@ foreach ($map as $credential_type => $credential_usernames) {
 $table->saveTransaction();
 $passphrase->saveTransaction();
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20131205.buildstepordermig.php b/resources/sql/patches/20131205.buildstepordermig.php
index b17724252a..2216fe50b4 100644
--- a/resources/sql/patches/20131205.buildstepordermig.php
+++ b/resources/sql/patches/20131205.buildstepordermig.php
@@ -9,7 +9,7 @@ $viewer = PhabricatorUser::getOmnipotentUser();
 
 foreach (new LiskMigrationIterator($table) as $plan) {
   $planname = $plan->getName();
-  echo "Migrating steps in {$planname}...\n";
+  echo pht('Migrating steps in %s...', $planname)."\n";
 
   $rows = queryfx_all(
     $conn_w,
@@ -23,10 +23,10 @@ foreach (new LiskMigrationIterator($table) as $plan) {
     $id = $row['id'];
     $existing = $row['sequence'];
     if ($existing != 0) {
-      echo "  - {$id} (already migrated)...\n";
+      echo "  - ".pht('%d (already migrated)...', $id)."\n";
       continue;
     }
-    echo "  - {$id} to position {$sequence}...\n";
+    echo "  - ".pht('%d to position %s...', $id, $sequence)."\n";
     queryfx(
       $conn_w,
       'UPDATE harbormaster_buildstep '.
@@ -38,4 +38,4 @@ foreach (new LiskMigrationIterator($table) as $plan) {
   }
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/20131217.pushlogphid.2.mig.php b/resources/sql/patches/20131217.pushlogphid.2.mig.php
index edda8d346d..5b253e2289 100644
--- a/resources/sql/patches/20131217.pushlogphid.2.mig.php
+++ b/resources/sql/patches/20131217.pushlogphid.2.mig.php
@@ -3,12 +3,12 @@
 $table = new PhabricatorRepositoryPushLog();
 $conn_w = $table->establishConnection('w');
 
-echo "Assigning PHIDs to push logs...\n";
+echo pht('Assigning PHIDs to push logs...')."\n";
 
 $logs = new LiskMigrationIterator($table);
 foreach ($logs as $log) {
   $id = $log->getID();
-  echo "Updating {$id}...\n";
+  echo pht('Updating %s...', $id)."\n";
   queryfx(
     $conn_w,
     'UPDATE %T SET phid = %s WHERE id = %d',
@@ -17,4 +17,4 @@ foreach ($logs as $log) {
     $id);
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/emailtableport.php b/resources/sql/patches/emailtableport.php
index ba46e70916..d70f3341ff 100644
--- a/resources/sql/patches/emailtableport.php
+++ b/resources/sql/patches/emailtableport.php
@@ -1,6 +1,6 @@
 <?php
 
-echo "Migrating user emails...\n";
+echo pht('Migrating user emails...')."\n";
 
 $table  = new PhabricatorUser();
 $table->openTransaction();
@@ -19,7 +19,7 @@ foreach ($emails as $phid => $email) {
   // NOTE: Grandfather all existing email in as primary / verified. We generate
   // verification codes because they are used for password resets, etc.
 
-  echo "Migrating '{$phid}'...\n";
+  echo pht("Migrating '%s'...", $phid)."\n";
   queryfx(
     $conn,
     'INSERT INTO %T (userPHID, address, verificationCode, isVerified, isPrimary)
@@ -31,4 +31,4 @@ foreach ($emails as $phid => $email) {
 }
 
 $table->saveTransaction();
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/legalpad-mailkey-populate.php b/resources/sql/patches/legalpad-mailkey-populate.php
index e754ab2757..8aa2c593df 100644
--- a/resources/sql/patches/legalpad-mailkey-populate.php
+++ b/resources/sql/patches/legalpad-mailkey-populate.php
@@ -1,13 +1,13 @@
 <?php
 
-echo "Populating Legalpad Documents with mail keys...\n";
+echo pht('Populating Legalpad Documents with mail keys...')."\n";
 $table = new LegalpadDocument();
 $table->openTransaction();
 
 foreach (new LiskMigrationIterator($table) as $document) {
   $id = $document->getID();
 
-  echo "Document {$id}: ";
+  echo pht('Document %s: ', $id);
   if (!$document->getMailKey()) {
     queryfx(
       $document->establishConnection('w'),
@@ -15,11 +15,11 @@ foreach (new LiskMigrationIterator($table) as $document) {
       $document->getTableName(),
       Filesystem::readRandomCharacters(20),
       $id);
-    echo "Generated Key\n";
+    echo pht('Generated Key')."\n";
   } else {
     echo "-\n";
   }
 }
 
 $table->saveTransaction();
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/liskcounters.php b/resources/sql/patches/liskcounters.php
index 489747575f..198ed13742 100644
--- a/resources/sql/patches/liskcounters.php
+++ b/resources/sql/patches/liskcounters.php
@@ -1,6 +1,6 @@
 <?php
 
-// Switch PhabricatorWorkerActiveTask from autoincrement IDs to counter IDs.
+// Switch PhabricatorWorkerActiveTask from auto-increment IDs to counter IDs.
 // Set the initial counter ID to be larger than any known task ID.
 
 $active_table = new PhabricatorWorkerActiveTask();
diff --git a/resources/sql/patches/migrate-differential-dependencies.php b/resources/sql/patches/migrate-differential-dependencies.php
index e84a7755ab..c65165f9e4 100644
--- a/resources/sql/patches/migrate-differential-dependencies.php
+++ b/resources/sql/patches/migrate-differential-dependencies.php
@@ -1,12 +1,12 @@
 <?php
 
-echo "Migrating differential dependencies to edges...\n";
+echo pht('Migrating differential dependencies to edges...')."\n";
 $table = new DifferentialRevision();
 $table->openTransaction();
 
 foreach (new LiskMigrationIterator($table) as $rev) {
   $id = $rev->getID();
-  echo "Revision {$id}: ";
+  echo pht('Revision %d: ', $id);
 
   $deps = $rev->getAttachedPHIDs(DifferentialRevisionPHIDType::TYPECONST);
   if (!$deps) {
@@ -22,8 +22,8 @@ foreach (new LiskMigrationIterator($table) as $rev) {
       $dep);
   }
   $editor->save();
-  echo "OKAY\n";
+  echo pht('OKAY')."\n";
 }
 
 $table->saveTransaction();
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/migrate-maniphest-dependencies.php b/resources/sql/patches/migrate-maniphest-dependencies.php
index 394c98a95f..074018264c 100644
--- a/resources/sql/patches/migrate-maniphest-dependencies.php
+++ b/resources/sql/patches/migrate-maniphest-dependencies.php
@@ -1,12 +1,12 @@
 <?php
 
-echo "Migrating task dependencies to edges...\n";
+echo pht('Migrating task dependencies to edges...')."\n";
 $table = new ManiphestTask();
 $table->openTransaction();
 
 foreach (new LiskMigrationIterator($table) as $task) {
   $id = $task->getID();
-  echo "Task {$id}: ";
+  echo pht('Task %d: ', $id);
 
   $deps = $task->getAttachedPHIDs(ManiphestTaskPHIDType::TYPECONST);
   if (!$deps) {
@@ -22,8 +22,8 @@ foreach (new LiskMigrationIterator($table) as $task) {
       $dep);
   }
   $editor->save();
-  echo "OKAY\n";
+  echo pht('OKAY')."\n";
 }
 
 $table->saveTransaction();
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/migrate-maniphest-revisions.php b/resources/sql/patches/migrate-maniphest-revisions.php
index 0658cfda69..2a8f8061b4 100644
--- a/resources/sql/patches/migrate-maniphest-revisions.php
+++ b/resources/sql/patches/migrate-maniphest-revisions.php
@@ -1,12 +1,12 @@
 <?php
 
-echo "Migrating task revisions to edges...\n";
+echo pht('Migrating task revisions to edges...')."\n";
 $table = new ManiphestTask();
 $table->establishConnection('w');
 
 foreach (new LiskMigrationIterator($table) as $task) {
   $id = $task->getID();
-  echo "Task {$id}: ";
+  echo pht('Task %d: ', $id);
 
   $revs = $task->getAttachedPHIDs(DifferentialRevisionPHIDType::TYPECONST);
   if (!$revs) {
@@ -22,7 +22,7 @@ foreach (new LiskMigrationIterator($table) as $task) {
       $rev);
   }
   $editor->save();
-  echo "OKAY\n";
+  echo pht('OKAY')."\n";
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/migrate-project-edges.php b/resources/sql/patches/migrate-project-edges.php
index 855b52b14b..277cf8b155 100644
--- a/resources/sql/patches/migrate-project-edges.php
+++ b/resources/sql/patches/migrate-project-edges.php
@@ -1,12 +1,12 @@
 <?php
 
-echo "Migrating project members to edges...\n";
+echo pht('Migrating project members to edges...')."\n";
 $table = new PhabricatorProject();
 $table->establishConnection('w');
 
 foreach (new LiskMigrationIterator($table) as $proj) {
   $id = $proj->getID();
-  echo "Project {$id}: ";
+  echo pht('Project %d: ', $id);
 
   $members = queryfx_all(
     $proj->establishConnection('w'),
@@ -29,7 +29,7 @@ foreach (new LiskMigrationIterator($table) as $proj) {
       $user_phid);
   }
   $editor->save();
-  echo "OKAY\n";
+  echo pht('OKAY')."\n";
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/resources/sql/patches/ponder-mailkey-populate.php b/resources/sql/patches/ponder-mailkey-populate.php
index bdae8f83a0..5d2c77fff4 100644
--- a/resources/sql/patches/ponder-mailkey-populate.php
+++ b/resources/sql/patches/ponder-mailkey-populate.php
@@ -1,13 +1,13 @@
 <?php
 
-echo "Populating Questions with mail keys...\n";
+echo pht('Populating Questions with mail keys...')."\n";
 $table = new PonderQuestion();
 $table->openTransaction();
 
 foreach (new LiskMigrationIterator($table) as $question) {
   $id = $question->getID();
 
-  echo "Question {$id}: ";
+  echo pht('Question %d: ', $id);
   if (!$question->getMailKey()) {
     queryfx(
       $question->establishConnection('w'),
@@ -15,11 +15,11 @@ foreach (new LiskMigrationIterator($table) as $question) {
       $question->getTableName(),
       Filesystem::readRandomCharacters(20),
       $id);
-    echo "Generated Key\n";
+    echo pht('Generated Key')."\n";
   } else {
     echo "-\n";
   }
 }
 
 $table->saveTransaction();
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/scripts/__init_script__.php b/scripts/__init_script__.php
index c0a198a145..57ada96e64 100644
--- a/scripts/__init_script__.php
+++ b/scripts/__init_script__.php
@@ -11,7 +11,7 @@ function init_phabricator_script() {
   @include_once 'libphutil/scripts/__init_script__.php';
   if (!@constant('__LIBPHUTIL__')) {
     echo "ERROR: Unable to load libphutil. Update your PHP 'include_path' to ".
-         "include the parent directory of libphutil/.\n";
+      "include the parent directory of libphutil/.\n";
     exit(1);
   }
 
diff --git a/scripts/almanac/manage_almanac.php b/scripts/almanac/manage_almanac.php
index e18b67d74a..933d1b7229 100755
--- a/scripts/almanac/manage_almanac.php
+++ b/scripts/almanac/manage_almanac.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage host directory');
+$args->setTagline(pht('manage host directory'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **almanac** __commmand__ [__options__]
     Manage Almanac stuff. NEW AND EXPERIMENTAL.
diff --git a/scripts/aphront/aphrontpath.php b/scripts/aphront/aphrontpath.php
index 04a051212c..09cc04eeea 100755
--- a/scripts/aphront/aphrontpath.php
+++ b/scripts/aphront/aphrontpath.php
@@ -5,8 +5,10 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 if ($argc !== 2 || $argv[1] === '--help') {
-  echo "Usage: aphrontpath.php <url>\n";
-  echo "Purpose: Print controller which will process passed <url>.\n";
+  echo pht('Usage: %s', 'aphrontpath.php <url>')."\n";
+  echo pht(
+    "Purpose: Print controller which will process passed %s.\n",
+    '<url>');
   exit(1);
 }
 
diff --git a/scripts/cache/manage_cache.php b/scripts/cache/manage_cache.php
index c50efca606..80e8e80819 100755
--- a/scripts/cache/manage_cache.php
+++ b/scripts/cache/manage_cache.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage cache');
+$args->setTagline(pht('manage cache'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **cache** __command__ [__options__]
     Manage Phabricator caches.
diff --git a/scripts/celerity/generate_sprites.php b/scripts/celerity/generate_sprites.php
index 31ad4684c2..836167cfa5 100755
--- a/scripts/celerity/generate_sprites.php
+++ b/scripts/celerity/generate_sprites.php
@@ -4,7 +4,7 @@
 require_once dirname(dirname(__FILE__)).'/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('regenerate CSS sprite sheets');
+$args->setTagline(pht('regenerate CSS sprite sheets'));
 $args->setSynopsis(<<<EOHELP
 **sprites**
     Rebuild CSS sprite sheets.
@@ -16,7 +16,7 @@ $args->parse(
   array(
     array(
       'name'  => 'force',
-      'help'  => 'Force regeneration even if sources have not changed.',
+      'help'  => pht('Force regeneration even if sources have not changed.'),
     ),
   ));
 
@@ -39,8 +39,10 @@ list($err) = exec_manual('optipng');
 if ($err) {
   $have_optipng = false;
   echo phutil_console_format(
-    "<bg:red> WARNING </bg> `optipng` not found in PATH.\n".
-    "Sprites will not be optimized! Install `optipng`!\n");
+    "<bg:red> %s </bg> %s\n%s\n",
+    pht('WARNING'),
+    pht('`%s` not found in PATH.', 'optipng'),
+    pht('Sprites will not be optimized! Install `%s`!', 'optipng'));
 } else {
   $have_optipng = true;
 }
@@ -75,10 +77,10 @@ foreach ($sheets as $name => $sheet) {
     $sheet->generateImage($full_path, $scale);
 
     if ($have_optipng) {
-      echo "Optimizing...\n";
+      echo pht('Optimizing...')."\n";
       phutil_passthru('optipng -o7 -clobber %s', $full_path);
     }
   }
 }
 
-echo "Done.\n";
+echo pht('Done.')."\n";
diff --git a/scripts/daemon/manage_daemons.php b/scripts/daemon/manage_daemons.php
index 2d4b58dbb2..087c925b81 100755
--- a/scripts/daemon/manage_daemons.php
+++ b/scripts/daemon/manage_daemons.php
@@ -7,7 +7,7 @@ require_once $root.'/scripts/__init_script__.php';
 PhabricatorDaemonManagementWorkflow::requireExtensions();
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage daemons');
+$args->setTagline(pht('manage daemons'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **phd** __command__ [__options__]
     Manage Phabricator daemons.
diff --git a/scripts/diviner/diviner.php b/scripts/diviner/diviner.php
index fe9c4e1ded..03d15274f4 100755
--- a/scripts/diviner/diviner.php
+++ b/scripts/diviner/diviner.php
@@ -6,7 +6,7 @@ require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
 
-$args->setTagline('documentation generator');
+$args->setTagline(pht('documentation generator'));
 $args->setSynopsis(<<<EOHELP
 **diviner** __command__ [__options__]
   Generate documentation.
diff --git a/scripts/drydock/drydock_control.php b/scripts/drydock/drydock_control.php
index 0a01b91fa3..57ad877586 100755
--- a/scripts/drydock/drydock_control.php
+++ b/scripts/drydock/drydock_control.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage drydock software resources');
+$args->setTagline(pht('manage drydock software resources'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **drydock** __commmand__ [__options__]
     Manage Drydock stuff. NEW AND EXPERIMENTAL.
diff --git a/scripts/fact/manage_facts.php b/scripts/fact/manage_facts.php
index 973e5bfa21..8a351dd1a8 100755
--- a/scripts/fact/manage_facts.php
+++ b/scripts/fact/manage_facts.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage fact configuration');
+$args->setTagline(pht('manage fact configuration'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **fact** __command__ [__options__]
     Manage and debug Phabricator data extraction, storage and
diff --git a/scripts/files/manage_files.php b/scripts/files/manage_files.php
index 661d65ea3f..edd947467c 100755
--- a/scripts/files/manage_files.php
+++ b/scripts/files/manage_files.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage files');
+$args->setTagline(pht('manage files'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **files** __command__ [__options__]
     Manage Phabricator file storage.
diff --git a/scripts/lipsum/manage_lipsum.php b/scripts/lipsum/manage_lipsum.php
index 3a7c0a23a8..610e6e9aa3 100755
--- a/scripts/lipsum/manage_lipsum.php
+++ b/scripts/lipsum/manage_lipsum.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage lipsum');
+$args->setTagline(pht('manage lipsum'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **lipsum** __command__ [__options__]
     Manage Phabricator Test Data Generator.
diff --git a/scripts/mail/mail_handler.php b/scripts/mail/mail_handler.php
index 0341a0e464..2ff23adb0f 100755
--- a/scripts/mail/mail_handler.php
+++ b/scripts/mail/mail_handler.php
@@ -88,7 +88,7 @@ try {
   $received->processReceivedMail();
 } catch (Exception $e) {
   $received
-    ->setMessage('EXCEPTION: '.$e->getMessage())
+    ->setMessage(pht('EXCEPTION: %s', $e->getMessage()))
     ->save();
 
   throw $e;
diff --git a/scripts/mail/manage_mail.php b/scripts/mail/manage_mail.php
index 9822565175..7f73303fdb 100755
--- a/scripts/mail/manage_mail.php
+++ b/scripts/mail/manage_mail.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage mail');
+$args->setTagline(pht('manage mail'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **mail** __command__ [__options__]
     Manage Phabricator mail stuff.
diff --git a/scripts/repository/commit_hook.php b/scripts/repository/commit_hook.php
index 6d756dddd2..56e828ab7a 100755
--- a/scripts/repository/commit_hook.php
+++ b/scripts/repository/commit_hook.php
@@ -61,7 +61,9 @@ if ($repository->isGit() || $repository->isHg()) {
   $username = getenv(DiffusionCommitHookEngine::ENV_USER);
   if (!strlen($username)) {
     throw new Exception(
-      pht('usage: %s should be defined!', DiffusionCommitHookEngine::ENV_USER));
+      pht(
+        'Usage: %s should be defined!',
+        DiffusionCommitHookEngine::ENV_USER));
   }
 
   if ($repository->isHg()) {
diff --git a/scripts/repository/manage_repositories.php b/scripts/repository/manage_repositories.php
index b3ebac0842..ae0395e663 100755
--- a/scripts/repository/manage_repositories.php
+++ b/scripts/repository/manage_repositories.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage repositories');
+$args->setTagline(pht('manage repositories'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **repository** __command__ [__options__]
     Manage and debug Phabricator repository configuration, tracking,
diff --git a/scripts/repository/rebuild_summaries.php b/scripts/repository/rebuild_summaries.php
index a98a6f01b4..de3d5acca0 100755
--- a/scripts/repository/rebuild_summaries.php
+++ b/scripts/repository/rebuild_summaries.php
@@ -22,7 +22,7 @@ $maxes = ipull($maxes, 'maxEpoch', 'repositoryID');
 
 $repository_ids = array_keys($sizes + $maxes);
 
-echo 'Updating '.count($repository_ids).' repositories';
+echo pht('Updating %d repositories', count($repository_ids));
 
 foreach ($repository_ids as $repository_id) {
   $last_commit = queryfx_one(
@@ -50,4 +50,4 @@ foreach ($repository_ids as $repository_id) {
     idx($maxes, $repository_id, 0));
   echo '.';
 }
-echo "\ndone.\n";
+echo "\n".pht('Done.')."\n";
diff --git a/scripts/repository/save_lint.php b/scripts/repository/save_lint.php
index d9bf921e9c..fde2ab8fed 100755
--- a/scripts/repository/save_lint.php
+++ b/scripts/repository/save_lint.php
@@ -11,7 +11,7 @@ $synopsis = <<<EOT
 EOT;
 
 $args = id(new PhutilArgumentParser($argv))
-  ->setTagline('save lint errors to database')
+  ->setTagline(pht('save lint errors to database'))
   ->setSynopsis($synopsis)
   ->parseStandardArguments()
   ->parse(array(
diff --git a/scripts/search/manage_search.php b/scripts/search/manage_search.php
index b07ff54bad..4b119f28cc 100755
--- a/scripts/search/manage_search.php
+++ b/scripts/search/manage_search.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage search');
+$args->setTagline(pht('manage search'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **search** __command__ [__options__]
     Manage Phabricator search index.
diff --git a/scripts/setup/manage_audit.php b/scripts/setup/manage_audit.php
index 9a085c6947..26bd3044e6 100755
--- a/scripts/setup/manage_audit.php
+++ b/scripts/setup/manage_audit.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage audits');
+$args->setTagline(pht('manage audits'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **audit** __command__ [__options__]
     Manage Phabricator audits.
diff --git a/scripts/setup/manage_auth.php b/scripts/setup/manage_auth.php
index a674c92b01..cdd1fe377f 100755
--- a/scripts/setup/manage_auth.php
+++ b/scripts/setup/manage_auth.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage authentication');
+$args->setTagline(pht('manage authentication'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **auth** __command__ [__options__]
     Manage Phabricator authentication configuration.
diff --git a/scripts/setup/manage_celerity.php b/scripts/setup/manage_celerity.php
index 4a559711c2..268a7abaa8 100755
--- a/scripts/setup/manage_celerity.php
+++ b/scripts/setup/manage_celerity.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage celerity');
+$args->setTagline(pht('manage celerity'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **celerity** __command__ [__options__]
     Manage static resources.
diff --git a/scripts/setup/manage_config.php b/scripts/setup/manage_config.php
index 5c07e7293f..996c851a32 100755
--- a/scripts/setup/manage_config.php
+++ b/scripts/setup/manage_config.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage configuration');
+$args->setTagline(pht('manage configuration'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **config** __command__ [__options__]
     Manage Phabricator configuration.
diff --git a/scripts/setup/manage_feed.php b/scripts/setup/manage_feed.php
index 81d2cb502b..0afea5d01c 100755
--- a/scripts/setup/manage_feed.php
+++ b/scripts/setup/manage_feed.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage feed');
+$args->setTagline(pht('manage feed'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **feed** __command__ [__options__]
     Test and debug feed events.
diff --git a/scripts/setup/manage_harbormaster.php b/scripts/setup/manage_harbormaster.php
index 1903bdd907..1c86838937 100755
--- a/scripts/setup/manage_harbormaster.php
+++ b/scripts/setup/manage_harbormaster.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage Harbormaster');
+$args->setTagline(pht('manage Harbormaster'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **harbormaster** __command__ [__options__]
   Manage and debug Harbormaster.
diff --git a/scripts/setup/manage_hunks.php b/scripts/setup/manage_hunks.php
index c4750ece73..bff11ca72b 100755
--- a/scripts/setup/manage_hunks.php
+++ b/scripts/setup/manage_hunks.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage hunks');
+$args->setTagline(pht('manage hunks'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **hunks** __command__ [__options__]
     Manage Differential hunk storage.
diff --git a/scripts/setup/manage_i18n.php b/scripts/setup/manage_i18n.php
index 77a76728b6..bbbbdcb294 100755
--- a/scripts/setup/manage_i18n.php
+++ b/scripts/setup/manage_i18n.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage internationalization');
+$args->setTagline(pht('manage internationalization'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **i18n** __command__ [__options__]
     Manage translations and internationalization.
diff --git a/scripts/setup/manage_phortune.php b/scripts/setup/manage_phortune.php
index 45d8c62573..81eacd4dca 100755
--- a/scripts/setup/manage_phortune.php
+++ b/scripts/setup/manage_phortune.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage billing');
+$args->setTagline(pht('manage billing'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **phortune** __command__ [__options__]
     Manage billing.
diff --git a/scripts/setup/manage_policy.php b/scripts/setup/manage_policy.php
index a9ab27731a..034f498c0a 100755
--- a/scripts/setup/manage_policy.php
+++ b/scripts/setup/manage_policy.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage policies');
+$args->setTagline(pht('manage policies'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **policy** __command__ [__options__]
     Administrative tool for reviewing and editing policies.
diff --git a/scripts/setup/manage_remove.php b/scripts/setup/manage_remove.php
index db7dd19269..581cae2383 100755
--- a/scripts/setup/manage_remove.php
+++ b/scripts/setup/manage_remove.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('remove objects');
+$args->setTagline(pht('remove objects'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **remove** __command__ [__options__]
     Administrative tool for destroying objects permanently.
diff --git a/scripts/setup/manage_trigger.php b/scripts/setup/manage_trigger.php
index 7624c1f1de..558015fb32 100755
--- a/scripts/setup/manage_trigger.php
+++ b/scripts/setup/manage_trigger.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage triggers');
+$args->setTagline(pht('manage triggers'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **trigger** __command__ [__options__]
     Manage event triggers.
diff --git a/scripts/setup/manage_worker.php b/scripts/setup/manage_worker.php
index 05dcf085b8..111c66d3e2 100755
--- a/scripts/setup/manage_worker.php
+++ b/scripts/setup/manage_worker.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage task queue');
+$args->setTagline(pht('manage task queue'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **worker** __command__ [__options__]
     Manage the task queue.
diff --git a/scripts/sms/manage_sms.php b/scripts/sms/manage_sms.php
index 6e0539a1a0..a66f66040a 100755
--- a/scripts/sms/manage_sms.php
+++ b/scripts/sms/manage_sms.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage SMS');
+$args->setTagline(pht('manage SMS'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **sms** __command__ [__options__]
     Manage Phabricator SMS stuff.
diff --git a/scripts/sql/manage_storage.php b/scripts/sql/manage_storage.php
index 32c3bd3f12..1225e21a82 100755
--- a/scripts/sql/manage_storage.php
+++ b/scripts/sql/manage_storage.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage Phabricator storage and schemata');
+$args->setTagline(pht('manage Phabricator storage and schemata'));
 $args->setSynopsis(<<<EOHELP
 **storage** __workflow__ [__options__]
 Manage Phabricator database storage and schema versioning.
@@ -34,35 +34,38 @@ try {
       array(
         'name'    => 'force',
         'short'   => 'f',
-        'help'    => 'Do not prompt before performing dangerous operations.',
+        'help'    => pht(
+          'Do not prompt before performing dangerous operations.'),
       ),
       array(
         'name'    => 'user',
         'short'   => 'u',
         'param'   => 'username',
         'default' => $default_user,
-        'help'    => "Connect with __username__ instead of the configured ".
-                     "default ('{$default_user}').",
+        'help'    => pht(
+          "Connect with __username__ instead of the configured default ('%s').",
+          $default_user),
       ),
       array(
         'name'    => 'password',
         'short'   => 'p',
         'param'   => 'password',
-        'help'    => 'Use __password__ instead of the configured default.',
+        'help'    => pht('Use __password__ instead of the configured default.'),
       ),
       array(
         'name'    => 'namespace',
         'param'   => 'name',
         'default' => $default_namespace,
-        'help'    => "Use namespace __namespace__ instead of the configured ".
-                     "default ('{$default_namespace}'). This is an advanced ".
-                     "feature used by unit tests; you should not normally ".
-                     "use this flag.",
+        'help'    => pht(
+          "Use namespace __namespace__ instead of the configured ".
+          "default ('%s'). This is an advanced feature used by unit tests; ".
+          "you should not normally use this flag.",
+          $default_namespace),
       ),
       array(
         'name'  => 'dryrun',
-        'help'  => 'Do not actually change anything, just show what would be '.
-                   'changed.',
+        'help'  => pht(
+          'Do not actually change anything, just show what would be changed.'),
       ),
       array(
         'name' => 'disable-utf8mb4',
@@ -93,23 +96,23 @@ try {
     'SELECT 1');
 } catch (AphrontQueryException $ex) {
   $message = phutil_console_format(
+    "**%s**\n\n%s\n\n%s\n\n%s\n\n**%s**: %s\n",
+    pht('MySQL Credentials Not Configured'),
     pht(
-      "**MySQL Credentials Not Configured**\n\n".
-      "Unable to connect to MySQL using the configured credentials. ".
-      "You must configure standard credentials before you can upgrade ".
-      "storage. Run these commands to set up credentials:\n".
-      "\n".
-      "  phabricator/ $ ./bin/config set mysql.host __host__\n".
-      "  phabricator/ $ ./bin/config set mysql.user __username__\n".
-      "  phabricator/ $ ./bin/config set mysql.pass __password__\n".
-      "\n".
-      "These standard credentials are separate from any administrative ".
-      "credentials provided to this command with __--user__ or ".
-      "__--password__, and must be configured correctly before you can ".
-      "proceed.\n".
-      "\n".
-      "**Raw MySQL Error**: %s\n",
-      $ex->getMessage()));
+      'Unable to connect to MySQL using the configured credentials. '.
+      'You must configure standard credentials before you can upgrade '.
+      'storage. Run these commands to set up credentials:'),
+    "  phabricator/ $ ./bin/config set mysql.host __host__\n".
+    "  phabricator/ $ ./bin/config set mysql.user __username__\n".
+    "  phabricator/ $ ./bin/config set mysql.pass __password__",
+    pht(
+      'These standard credentials are separate from any administrative '.
+      'credentials provided to this command with __%s__ or '.
+      '__%s__, and must be configured correctly before you can proceed.',
+      '--user',
+      '--password'),
+    pht('Raw MySQL Error'),
+    $ex->getMessage());
 
   echo phutil_console_wrap($message);
 
@@ -141,14 +144,16 @@ try {
     'SELECT 1');
 } catch (AphrontQueryException $ex) {
   $message = phutil_console_format(
+    "**%s**\n\n%s\n\n**%s**: %s\n",
+    pht('Bad Administrative Credentials'),
     pht(
-      "**Bad Administrative Credentials**\n\n".
-      "Unable to connnect to MySQL using the administrative credentials ".
-      "provided with the __--user__ and __--password__ flags. Check that ".
-      "you have entered them correctly.\n".
-      "\n".
-      "**Raw MySQL Error**: %s\n",
-      $ex->getMessage()));
+      'Unable to connect to MySQL using the administrative credentials '.
+      'provided with the __%s__ and __%s__ flags. Check that '.
+      'you have entered them correctly.',
+      '--user',
+      '--password'),
+    pht('Raw MySQL Error'),
+    $ex->getMessage());
 
   echo phutil_console_wrap($message);
 
diff --git a/scripts/ssh/ssh-exec.php b/scripts/ssh/ssh-exec.php
index 93b808be92..0eb9b4a3ad 100755
--- a/scripts/ssh/ssh-exec.php
+++ b/scripts/ssh/ssh-exec.php
@@ -9,7 +9,7 @@ require_once $root.'/scripts/__init_script__.php';
 $ssh_log = PhabricatorSSHLog::getLog();
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('execute SSH requests');
+$args->setTagline(pht('execute SSH requests'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **ssh-exec** --phabricator-ssh-user __user__ [--ssh-command __commmand__]
 **ssh-exec** --phabricator-ssh-device __device__ [--ssh-command __commmand__]
@@ -50,7 +50,8 @@ $args->parse(
       'help' => pht(
         'Provide a command to execute. This makes testing this script '.
         'easier. When running normally, the command is read from the '.
-        'environment (SSH_ORIGINAL_COMMAND), which is populated by sshd.'),
+        'environment (%s), which is populated by sshd.',
+        'SSH_ORIGINAL_COMMAND'),
     ),
   ));
 
@@ -84,9 +85,11 @@ try {
   if ($user_name && $device_name) {
     throw new Exception(
       pht(
-        'The --phabricator-ssh-user and --phabricator-ssh-device flags are '.
-        'mutually exclusive. You can not authenticate as both a user ("%s") '.
-        'and a device ("%s"). Specify one or the other, but not both.',
+        'The %s and %s flags are mutually exclusive. You can not '.
+        'authenticate as both a user ("%s") and a device ("%s"). '.
+        'Specify one or the other, but not both.',
+        '--phabricator-ssh-user',
+        '--phabricator-ssh-device',
         $user_name,
         $device_name));
   } else if (strlen($user_name)) {
@@ -104,9 +107,10 @@ try {
     if (!$remote_address) {
       throw new Exception(
         pht(
-          'Unable to identify remote address from the SSH_CLIENT environment '.
+          'Unable to identify remote address from the %s environment '.
           'variable. Device authentication is accepted only from trusted '.
-          'sources.'));
+          'sources.',
+          'SSH_CLIENT'));
     }
 
     if (!PhabricatorEnv::isClusterAddress($remote_address)) {
@@ -134,8 +138,9 @@ try {
   } else {
     throw new Exception(
       pht(
-        'This script must be invoked with either the --phabricator-ssh-user '.
-        'or --phabricator-ssh-device flag.'));
+        'This script must be invoked with either the %s or %s flag.',
+        '--phabricator-ssh-user',
+        '--phabricator-ssh-device'));
   }
 
   if ($args->getArg('ssh-command')) {
@@ -199,10 +204,12 @@ try {
         "You haven't specified a command to run. This means you're requesting ".
         "an interactive shell, but Phabricator does not provide an ".
         "interactive shell over SSH.\n\n".
-        "Usually, you should run a command like `git clone` or `hg push` ".
+        "Usually, you should run a command like `%s` or `%s` ".
         "rather than connecting directly with SSH.\n\n".
         "Supported commands are: %s.",
         $user->getUsername(),
+        'git clone',
+        'hg push',
         implode(', ', $workflow_names)));
   }
 
@@ -225,7 +232,7 @@ try {
   $parsed_args = new PhutilArgumentParser($parseable_argv);
 
   if (empty($workflow_names[$command])) {
-    throw new Exception('Invalid command.');
+    throw new Exception(pht('Invalid command.'));
   }
 
   $workflow = $parsed_args->parseWorkflows($workflows);
@@ -235,17 +242,17 @@ try {
 
   $sock_stdin = fopen('php://stdin', 'r');
   if (!$sock_stdin) {
-    throw new Exception('Unable to open stdin.');
+    throw new Exception(pht('Unable to open stdin.'));
   }
 
   $sock_stdout = fopen('php://stdout', 'w');
   if (!$sock_stdout) {
-    throw new Exception('Unable to open stdout.');
+    throw new Exception(pht('Unable to open stdout.'));
   }
 
   $sock_stderr = fopen('php://stderr', 'w');
   if (!$sock_stderr) {
-    throw new Exception('Unable to open stderr.');
+    throw new Exception(pht('Unable to open stderr.'));
   }
 
   $socket_channel = new PhutilSocketChannel(
diff --git a/scripts/symbols/import_repository_symbols.php b/scripts/symbols/import_repository_symbols.php
index 14a83dda0c..94cf601a34 100755
--- a/scripts/symbols/import_repository_symbols.php
+++ b/scripts/symbols/import_repository_symbols.php
@@ -170,11 +170,11 @@ foreach ($input as $key => $line) {
     $line_number = $matches['line'];
     $path        = $matches['path'];
 
-    check_string_value($context, 'Symbol context', $line_no, 128);
-    check_string_value($name, 'Symbol name', $line_no, 128);
-    check_string_value($type, 'Symbol type', $line_no, 12);
-    check_string_value($lang, 'Symbol language', $line_no, 32);
-    check_string_value($path, 'Path', $line_no, 512);
+    check_string_value($context, pht('Symbol context'), $line_no, 128);
+    check_string_value($name, pht('Symbol name'), $line_no, 128);
+    check_string_value($type, pht('Symbol type'), $line_no, 12);
+    check_string_value($lang, pht('Symbol language'), $line_no, 32);
+    check_string_value($path, pht('Path'), $line_no, 512);
 
     if (!strlen($path) || $path[0] != '/') {
       throw new Exception(
@@ -226,4 +226,4 @@ if (count($symbols)) {
   commit_symbols($symbols, $repository, $no_purge);
 }
 
-echo pht('Done.'), "\n";
+echo pht('Done.')."\n";
diff --git a/scripts/user/account_admin.php b/scripts/user/account_admin.php
index 3d18c16ac7..dc1cb50190 100755
--- a/scripts/user/account_admin.php
+++ b/scripts/user/account_admin.php
@@ -13,31 +13,32 @@ $is_first_user = (!$any_user);
 
 if ($is_first_user) {
   echo pht(
-    "WARNING\n\n".
-    "You're about to create the first account on this install. Normally, you ".
-    "should use the web interface to create the first account, not this ".
-    "script.\n\n".
-    "If you use the web interface, it will drop you into a nice UI workflow ".
-    "which gives you more help setting up your install. If you create an ".
-    "account with this script instead, you will skip the setup help and you ".
-    "will not be able to access it later.");
+      "WARNING\n\n".
+      "You're about to create the first account on this install. Normally, ".
+      "you should use the web interface to create the first account, not ".
+      "this script.\n\n".
+      "If you use the web interface, it will drop you into a nice UI workflow ".
+      "which gives you more help setting up your install. If you create an ".
+      "account with this script instead, you will skip the setup help and you ".
+      "will not be able to access it later.");
   if (!phutil_console_confirm(pht('Skip easy setup and create account?'))) {
     echo pht('Cancelled.')."\n";
     exit(1);
   }
 }
 
-echo 'Enter a username to create a new account or edit an existing account.';
+echo pht(
+  'Enter a username to create a new account or edit an existing account.');
 
-$username = phutil_console_prompt('Enter a username:');
+$username = phutil_console_prompt(pht('Enter a username:'));
 if (!strlen($username)) {
-  echo "Cancelled.\n";
+  echo pht('Cancelled.')."\n";
   exit(1);
 }
 
 if (!PhabricatorUser::validateUsername($username)) {
   $valid = PhabricatorUser::describeValidUsername();
-  echo "The username '{$username}' is invalid. {$valid}\n";
+  echo pht("The username '%s' is invalid. %s", $username, $valid)."\n";
   exit(1);
 }
 
@@ -49,12 +50,12 @@ $user = id(new PhabricatorUser())->loadOneWhere(
 if (!$user) {
   $original = new PhabricatorUser();
 
-  echo "There is no existing user account '{$username}'.\n";
+  echo pht("There is no existing user account '%s'.", $username)."\n";
   $ok = phutil_console_confirm(
-    "Do you want to create a new '{$username}' account?",
+    pht("Do you want to create a new '%s' account?", $username),
     $default_no = false);
   if (!$ok) {
-    echo "Cancelled.\n";
+    echo pht('Cancelled.')."\n";
     exit(1);
   }
   $user = new PhabricatorUser();
@@ -64,12 +65,12 @@ if (!$user) {
 } else {
   $original = clone $user;
 
-  echo "There is an existing user account '{$username}'.\n";
+  echo pht("There is an existing user account '%s'.", $username)."\n";
   $ok = phutil_console_confirm(
-    "Do you want to edit the existing '{$username}' account?",
+    pht("Do you want to edit the existing '%s' account?", $username),
     $default_no = false);
   if (!$ok) {
-    echo "Cancelled.\n";
+    echo pht('Cancelled.')."\n";
     exit(1);
   }
 
@@ -78,12 +79,12 @@ if (!$user) {
 
 $user_realname = $user->getRealName();
 if (strlen($user_realname)) {
-  $realname_prompt = ' ['.$user_realname.']';
+  $realname_prompt = ' ['.$user_realname.']:';
 } else {
-  $realname_prompt = '';
+  $realname_prompt = ':';
 }
 $realname = nonempty(
-  phutil_console_prompt("Enter user real name{$realname_prompt}:"),
+  phutil_console_prompt(pht('Enter user real name').$realname_prompt),
   $user_realname);
 $user->setRealName($realname);
 
@@ -95,13 +96,14 @@ $user->setRealName($realname);
 $create_email = null;
 if ($is_new) {
   do {
-    $email = phutil_console_prompt('Enter user email address:');
+    $email = phutil_console_prompt(pht('Enter user email address:'));
     $duplicate = id(new PhabricatorUserEmail())->loadOneWhere(
       'address = %s',
       $email);
     if ($duplicate) {
-      echo "ERROR: There is already a user with that email address. ".
-           "Each user must have a unique email address.\n";
+      echo pht(
+        "ERROR: There is already a user with that email address. ".
+        "Each user must have a unique email address.\n");
     } else {
       break;
     }
@@ -115,7 +117,7 @@ $changed_pass = false;
 // it.
 phutil_passthru('stty -echo');
 $password = phutil_console_prompt(
-  'Enter a password for this user [blank to leave unchanged]:');
+  pht('Enter a password for this user [blank to leave unchanged]:'));
 phutil_passthru('stty echo');
 if (strlen($password)) {
   $changed_pass = $password;
@@ -123,7 +125,7 @@ if (strlen($password)) {
 
 $is_system_agent = $user->getIsSystemAgent();
 $set_system_agent = phutil_console_confirm(
-  'Is this user a bot/script?',
+  pht('Is this user a bot/script?'),
   $default_no = !$is_system_agent);
 
 $verify_email = null;
@@ -135,56 +137,56 @@ if (!$is_new) {
   $verify_email = $user->loadPrimaryEmail();
   if (!$verify_email->getIsVerified()) {
     $set_verified = phutil_console_confirm(
-      'Should the primary email address be verified?',
+      pht('Should the primary email address be verified?'),
       $default_no = true);
   } else {
-    // already verified so let's not make a fuss
+    // Already verified so let's not make a fuss.
     $verify_email = null;
   }
 }
 
 $is_admin = $user->getIsAdmin();
 $set_admin = phutil_console_confirm(
-  'Should this user be an administrator?',
+  pht('Should this user be an administrator?'),
   $default_no = !$is_admin);
 
-echo "\n\nACCOUNT SUMMARY\n\n";
+echo "\n\n".pht('ACCOUNT SUMMARY')."\n\n";
 $tpl = "%12s   %-30s   %-30s\n";
-printf($tpl, null, 'OLD VALUE', 'NEW VALUE');
-printf($tpl, 'Username', $original->getUsername(), $user->getUsername());
-printf($tpl, 'Real Name', $original->getRealName(), $user->getRealName());
+printf($tpl, null, pht('OLD VALUE'), pht('NEW VALUE'));
+printf($tpl, pht('Username'), $original->getUsername(), $user->getUsername());
+printf($tpl, pht('Real Name'), $original->getRealName(), $user->getRealName());
 if ($is_new) {
-  printf($tpl, 'Email', '', $create_email);
+  printf($tpl, pht('Email'), '', $create_email);
 }
-printf($tpl, 'Password', null,
+printf($tpl, pht('Password'), null,
   ($changed_pass !== false)
-    ? 'Updated'
-    : 'Unchanged');
+    ? pht('Updated')
+    : pht('Unchanged'));
 
 printf(
   $tpl,
-  'Bot/Script',
+  pht('Bot/Script'),
   $original->getIsSystemAgent() ? 'Y' : 'N',
   $set_system_agent ? 'Y' : 'N');
 
 if ($verify_email) {
   printf(
     $tpl,
-    'Verify Email',
+    pht('Verify Email'),
     $verify_email->getIsVerified() ? 'Y' : 'N',
     $set_verified ? 'Y' : 'N');
 }
 
 printf(
   $tpl,
-  'Admin',
+  pht('Admin'),
   $original->getIsAdmin() ? 'Y' : 'N',
   $set_admin ? 'Y' : 'N');
 
 echo "\n";
 
-if (!phutil_console_confirm('Save these changes?', $default_no = false)) {
-  echo "Cancelled.\n";
+if (!phutil_console_confirm(pht('Save these changes?'), $default_no = false)) {
+  echo pht('Cancelled.')."\n";
   exit(1);
 }
 
@@ -223,4 +225,4 @@ $user->openTransaction();
 
 $user->saveTransaction();
 
-echo "Saved changes.\n";
+echo pht('Saved changes.')."\n";
diff --git a/scripts/user/add_user.php b/scripts/user/add_user.php
index f2cdac396b..4c598e47e2 100755
--- a/scripts/user/add_user.php
+++ b/scripts/user/add_user.php
@@ -5,7 +5,9 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 if ($argc !== 5) {
-  echo "usage: add_user.php <username> <email> <realname> <admin_user>\n";
+  echo pht(
+    "Usage: %s\n",
+    'add_user.php <username> <email> <realname> <admin_user>');
   exit(1);
 }
 
@@ -19,8 +21,9 @@ $admin = id(new PhabricatorUser())->loadOneWhere(
   $argv[4]);
 if (!$admin) {
   throw new Exception(
-    'Admin user must be the username of a valid Phabricator account, used '.
-    'to send the new user a welcome email.');
+    pht(
+      'Admin user must be the username of a valid Phabricator account, used '.
+      'to send the new user a welcome email.'));
 }
 
 $existing_user = id(new PhabricatorUser())->loadOneWhere(
@@ -28,7 +31,9 @@ $existing_user = id(new PhabricatorUser())->loadOneWhere(
   $username);
 if ($existing_user) {
   throw new Exception(
-    "There is already a user with the username '{$username}'!");
+    pht(
+      "There is already a user with the username '%s'!",
+      $username));
 }
 
 $existing_email = id(new PhabricatorUserEmail())->loadOneWhere(
@@ -36,7 +41,9 @@ $existing_email = id(new PhabricatorUserEmail())->loadOneWhere(
   $email);
 if ($existing_email) {
   throw new Exception(
-    "There is already a user with the email '{$email}'!");
+    pht(
+      "There is already a user with the email '%s'!",
+      $email));
 }
 
 $user = new PhabricatorUser();
@@ -54,4 +61,8 @@ id(new PhabricatorUserEditor())
 
 $user->sendWelcomeEmail($admin);
 
-echo "Created user '{$username}' (realname='{$realname}', email='{$email}').\n";
+echo pht(
+  "Created user '%s' (realname='%s', email='%s').\n",
+  $username,
+  $realname,
+  $email);
diff --git a/scripts/util/add_macro.php b/scripts/util/add_macro.php
index cbfe8480f6..03566cfb76 100755
--- a/scripts/util/add_macro.php
+++ b/scripts/util/add_macro.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('load files as image macros');
+$args->setTagline(pht('load files as image macros'));
 $args->setSynopsis(<<<EOHELP
 **add_macro.php** __image__ [--as __name__]
     Add an image macro. This can be useful for importing a large number
@@ -19,8 +19,8 @@ $args->parse(
     array(
       'name'  => 'as',
       'param' => 'name',
-      'help'  => 'Use a specific name instead of the first part of the image '.
-                 'name.',
+      'help'  => pht(
+        'Use a specific name instead of the first part of the image name.'),
     ),
     array(
       'name'      => 'more',
@@ -45,7 +45,7 @@ $existing = id(new PhabricatorFileImageMacro())->loadOneWhere(
   'name = %s',
   $name);
 if ($existing) {
-  throw new Exception("A macro already exists with the name '{$name}'!");
+  throw new Exception(pht("A macro already exists with the name '%s'!", $name));
 }
 
 $file = PhabricatorFile::newFromFileData(
@@ -62,4 +62,4 @@ $macro = id(new PhabricatorFileImageMacro())
 
 $id = $file->getID();
 
-echo "Added macro '{$name}' (F{$id}).\n";
+echo pht("Added macro '%s' (%s).", $name, "F{$id}")."\n";
diff --git a/scripts/util/emit_test_event.php b/scripts/util/emit_test_event.php
index 500e8390e4..c8502d0fe6 100755
--- a/scripts/util/emit_test_event.php
+++ b/scripts/util/emit_test_event.php
@@ -5,7 +5,7 @@ $root = dirname(dirname(dirname(__FILE__)));
 require_once $root.'/scripts/__init_script__.php';
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('emit a test event');
+$args->setTagline(pht('emit a test event'));
 $args->setSynopsis(<<<EOHELP
 **emit_test_event.php** [--listen listener] ...
   Emit a test event after installing any specified __listener__s.
@@ -23,12 +23,12 @@ $args->parse(
 
 $console = PhutilConsole::getConsole();
 foreach ($args->getArg('listen') as $listener) {
-  $console->writeOut("Installing '%s'...\n", $listener);
+  $console->writeOut("%s\n", pht("Installing '%s'...", $listener));
   newv($listener, array())->register();
 }
 
 
-$console->writeOut("Emitting event...\n");
+$console->writeOut("%s\n", pht('Emitting event...'));
 
 PhutilEventEngine::dispatchEvent(
   new PhabricatorEvent(
@@ -37,5 +37,5 @@ PhutilEventEngine::dispatchEvent(
       'time' => time(),
     )));
 
-$console->writeOut("Done.\n");
+$console->writeOut("%s\n", pht('Done.'));
 exit(0);
diff --git a/src/__tests__/PhabricatorCelerityTestCase.php b/src/__tests__/PhabricatorCelerityTestCase.php
index 957664f009..a91b214502 100644
--- a/src/__tests__/PhabricatorCelerityTestCase.php
+++ b/src/__tests__/PhabricatorCelerityTestCase.php
@@ -28,7 +28,8 @@ final class PhabricatorCelerityTestCase extends PhabricatorTestCase {
         $maps_are_identical,
         pht(
           'When this test fails, it means the Celerity resource map is out '.
-          'of date. Run `bin/celerity map` to rebuild it.'));
+          'of date. Run `%s` to rebuild it.',
+          'bin/celerity map'));
     }
   }
 
diff --git a/src/__tests__/PhabricatorInfrastructureTestCase.php b/src/__tests__/PhabricatorInfrastructureTestCase.php
index 896a506ed3..19d034eb34 100644
--- a/src/__tests__/PhabricatorInfrastructureTestCase.php
+++ b/src/__tests__/PhabricatorInfrastructureTestCase.php
@@ -15,7 +15,7 @@ final class PhabricatorInfrastructureTestCase extends PhabricatorTestCase {
     $this->assertEqual(
       count($all),
       count($installed),
-      'In test cases, all applications should default to installed.');
+      pht('In test cases, all applications should default to installed.'));
   }
 
   public function testRejectMySQLNonUTF8Queries() {
diff --git a/src/aphront/AphrontRequest.php b/src/aphront/AphrontRequest.php
index 4aa52c1fcb..f4a1ee2cff 100644
--- a/src/aphront/AphrontRequest.php
+++ b/src/aphront/AphrontRequest.php
@@ -249,21 +249,24 @@ final class AphrontRequest {
       // in developer mode.
       if (PhabricatorEnv::getEnvConfig('phabricator.developer-mode')) {
         // TODO: Clean this up, see T1921.
-        $more_info[] =
-          "To avoid this error, use phabricator_form() to construct forms. ".
-          "If you are already using phabricator_form(), make sure the form ".
-          "'action' uses a relative URI (i.e., begins with a '/'). Forms ".
-          "using absolute URIs do not include CSRF tokens, to prevent ".
-          "leaking tokens to external sites.\n\n".
-          "If this page performs writes which do not require CSRF ".
-          "protection (usually, filling caches or logging), you can use ".
-          "AphrontWriteGuard::beginScopedUnguardedWrites() to temporarily ".
-          "bypass CSRF protection while writing. You should use this only ".
-          "for writes which can not be protected with normal CSRF ".
+        $more_info[] = pht(
+          "To avoid this error, use %s to construct forms. If you are already ".
+          "using %s, make sure the form 'action' uses a relative URI (i.e., ".
+          "begins with a '%s'). Forms using absolute URIs do not include CSRF ".
+          "tokens, to prevent leaking tokens to external sites.\n\n".
+          "If this page performs writes which do not require CSRF protection ".
+          "(usually, filling caches or logging), you can use %s to ".
+          "temporarily bypass CSRF protection while writing. You should use ".
+          "this only for writes which can not be protected with normal CSRF ".
           "mechanisms.\n\n".
-          "Some UI elements (like PhabricatorActionListView) also have ".
-          "methods which will allow you to render links as forms (like ".
-          "setRenderAsForm(true)).";
+          "Some UI elements (like %s) also have methods which will allow you ".
+          "to render links as forms (like %s).",
+          'phabricator_form()',
+          'phabricator_form()',
+          '/',
+          'AphrontWriteGuard::beginScopedUnguardedWrites()',
+          'PhabricatorActionListView',
+          'setRenderAsForm(true)');
       }
 
       // This should only be able to happen if you load a form, pull your
@@ -272,10 +275,10 @@ final class AphrontRequest {
       // is incredibly confusing otherwise.
       throw new AphrontCSRFException(
         pht(
-          "You are trying to save some data to Phabricator, but the request ".
-          "your browser made included an incorrect token. Reload the page ".
-          "and try again. You may need to clear your cookies.\n\n%s",
-          implode("\n", $more_info)));
+          'You are trying to save some data to Phabricator, but the request '.
+          'your browser made included an incorrect token. Reload the page '.
+          'and try again. You may need to clear your cookies.')."\n\n".
+          implode("\n", $more_info));
     }
 
     return true;
diff --git a/src/aphront/__tests__/AphrontRequestTestCase.php b/src/aphront/__tests__/AphrontRequestTestCase.php
index 151343ef0b..88fe97761f 100644
--- a/src/aphront/__tests__/AphrontRequestTestCase.php
+++ b/src/aphront/__tests__/AphrontRequestTestCase.php
@@ -75,7 +75,7 @@ final class AphrontRequestTestCase extends PhabricatorTestCase {
       $this->assertEqual(
         $expect,
         $r->getHost(),
-        'Host: '.$input);
+        pht('Host: %s', $input));
     }
   }
 
diff --git a/src/aphront/configuration/AphrontApplicationConfiguration.php b/src/aphront/configuration/AphrontApplicationConfiguration.php
index d828b9a8ce..a3821f18b5 100644
--- a/src/aphront/configuration/AphrontApplicationConfiguration.php
+++ b/src/aphront/configuration/AphrontApplicationConfiguration.php
@@ -328,13 +328,14 @@ abstract class AphrontApplicationConfiguration {
           // test) so it's fine that we don't have SERVER_ADDR defined.
         } else {
           throw new AphrontUsageException(
-            pht('No SERVER_ADDR'),
+            pht('No %s', 'SERVER_ADDR'),
             pht(
               'Phabricator is configured to operate in cluster mode, but '.
-              'SERVER_ADDR is not defined in the request context. Your '.
-              'webserver configuration needs to forward SERVER_ADDR to '.
-              'PHP so Phabricator can reject requests received on '.
-              'external interfaces.'));
+              '%s is not defined in the request context. Your webserver '.
+              'configuration needs to forward %s to PHP so Phabricator can '.
+              'reject requests received on external interfaces.',
+              'SERVER_ADDR',
+              'SERVER_ADDR'));
         }
       } else {
         if (!PhabricatorEnv::isClusterAddress($server_addr)) {
@@ -413,20 +414,23 @@ abstract class AphrontApplicationConfiguration {
           ->executeOne();
       } catch (PhabricatorPolicyException $ex) {
         throw new Exception(
-          'This blog is not visible to logged out users, so it can not be '.
-          'visited from a custom domain.');
+          pht(
+            'This blog is not visible to logged out users, so it can not be '.
+            'visited from a custom domain.'));
       }
 
       if (!$blog) {
         if ($prod_uri && $prod_uri != $base_uri) {
-          $prod_str = ' or '.$prod_uri;
+          $prod_str = pht('%s or %s', $base_uri, $prod_uri);
         } else {
-          $prod_str = '';
+          $prod_str = $base_uri;
         }
         throw new Exception(
-          'Specified domain '.$host.' is not configured for Phabricator '.
-          'requests. Please use '.$base_uri.$prod_str.' to visit this instance.'
-        );
+          pht(
+            'Specified domain %s is not configured for Phabricator '.
+            'requests. Please use %s to visit this instance.',
+            $host,
+            $prod_str));
       }
 
       // TODO: Make this more flexible and modular so any application can
diff --git a/src/aphront/configuration/AphrontDefaultApplicationConfiguration.php b/src/aphront/configuration/AphrontDefaultApplicationConfiguration.php
index 063ee365d6..3d5bfffd2d 100644
--- a/src/aphront/configuration/AphrontDefaultApplicationConfiguration.php
+++ b/src/aphront/configuration/AphrontDefaultApplicationConfiguration.php
@@ -229,11 +229,10 @@ class AphrontDefaultApplicationConfiguration
     $message  = $ex->getMessage();
 
     if ($ex instanceof AphrontSchemaQueryException) {
-      $message .=
-        "\n\n".
+      $message .= "\n\n".pht(
         "NOTE: This usually indicates that the MySQL schema has not been ".
-        "properly upgraded. Run 'bin/storage upgrade' to ensure your ".
-        "schema is up to date.";
+        "properly upgraded. Run '%s' to ensure your schema is up to date.",
+        'bin/storage upgrade');
     }
 
     if (PhabricatorEnv::getEnvConfig('phabricator.developer-mode')) {
@@ -254,13 +253,13 @@ class AphrontDefaultApplicationConfiguration
 
     $dialog = new AphrontDialogView();
     $dialog
-      ->setTitle('Unhandled Exception ("'.$class.'")')
+      ->setTitle(pht('Unhandled Exception ("%s")', $class))
       ->setClass('aphront-exception-dialog')
       ->setUser($user)
       ->appendChild($content);
 
     if ($this->getRequest()->isAjax()) {
-      $dialog->addCancelButton('/', 'Close');
+      $dialog->addCancelButton('/', pht('Close'));
     }
 
     $response = new AphrontDialogResponse();
diff --git a/src/aphront/response/Aphront404Response.php b/src/aphront/response/Aphront404Response.php
index 85dec30555..1284cb62e6 100644
--- a/src/aphront/response/Aphront404Response.php
+++ b/src/aphront/response/Aphront404Response.php
@@ -14,12 +14,13 @@ final class Aphront404Response extends AphrontHTMLResponse {
       ->setUser($user)
       ->setTitle(pht('404 Not Found'))
       ->addCancelButton('/', pht('Focus'))
-      ->appendParagraph(pht(
-      'Do not dwell in the past, do not dream of the future, '.
-      'concentrate the mind on the present moment.'));
+      ->appendParagraph(
+        pht(
+          'Do not dwell in the past, do not dream of the future, '.
+          'concentrate the mind on the present moment.'));
 
     $view = id(new PhabricatorStandardPageView())
-      ->setTitle('404 Not Found')
+      ->setTitle(pht('404 Not Found'))
       ->setRequest($request)
       ->setDeviceReady(true)
       ->appendChild($dialog);
diff --git a/src/aphront/sink/AphrontHTTPSink.php b/src/aphront/sink/AphrontHTTPSink.php
index 72bf4244f9..6ed2edff9c 100644
--- a/src/aphront/sink/AphrontHTTPSink.php
+++ b/src/aphront/sink/AphrontHTTPSink.php
@@ -25,7 +25,7 @@ abstract class AphrontHTTPSink {
    */
   final public function writeHTTPStatus($code, $message = '') {
     if (!preg_match('/^\d{3}$/', $code)) {
-      throw new Exception("Malformed HTTP status code '{$code}'!");
+      throw new Exception(pht("Malformed HTTP status code '%s'!", $code));
     }
 
     $code = (int)$code;
@@ -42,14 +42,15 @@ abstract class AphrontHTTPSink {
   final public function writeHeaders(array $headers) {
     foreach ($headers as $header) {
       if (!is_array($header) || count($header) !== 2) {
-        throw new Exception('Malformed header.');
+        throw new Exception(pht('Malformed header.'));
       }
       list($name, $value) = $header;
 
       if (strpos($name, ':') !== false) {
         throw new Exception(
-          'Declining to emit response with malformed HTTP header name: '.
-          $name);
+          pht(
+            'Declining to emit response with malformed HTTP header name: %s',
+            $name));
       }
 
       // Attackers may perform an "HTTP response splitting" attack by making
@@ -64,8 +65,9 @@ abstract class AphrontHTTPSink {
 
       if (preg_match('/[\r\n\0]/', $name.$value)) {
         throw new Exception(
-          "Declining to emit response with unsafe HTTP header: ".
-          "<'".$name."', '".$value."'>.");
+          pht(
+            'Declining to emit response with unsafe HTTP header: %s',
+            "<'".$name."', '".$value."'>."));
       }
     }
 
diff --git a/src/applications/almanac/controller/AlmanacConsoleController.php b/src/applications/almanac/controller/AlmanacConsoleController.php
index 60fa4e010e..156bd14b78 100644
--- a/src/applications/almanac/controller/AlmanacConsoleController.php
+++ b/src/applications/almanac/controller/AlmanacConsoleController.php
@@ -18,27 +18,21 @@ final class AlmanacConsoleController extends AlmanacController {
         ->setHeader(pht('Services'))
         ->setHref($this->getApplicationURI('service/'))
         ->setFontIcon('fa-plug')
-        ->addAttribute(
-          pht(
-            'Manage Almanac services.')));
+        ->addAttribute(pht('Manage Almanac services.')));
 
     $menu->addItem(
       id(new PHUIObjectItemView())
         ->setHeader(pht('Devices'))
         ->setHref($this->getApplicationURI('device/'))
         ->setFontIcon('fa-server')
-        ->addAttribute(
-          pht(
-            'Manage Almanac devices.')));
+        ->addAttribute(pht('Manage Almanac devices.')));
 
     $menu->addItem(
       id(new PHUIObjectItemView())
         ->setHeader(pht('Networks'))
         ->setHref($this->getApplicationURI('network/'))
         ->setFontIcon('fa-globe')
-        ->addAttribute(
-          pht(
-            'Manage Almanac networks.')));
+        ->addAttribute(pht('Manage Almanac networks.')));
 
     $crumbs = $this->buildApplicationCrumbs();
     $crumbs->addTextCrumb(pht('Console'));
diff --git a/src/applications/almanac/controller/AlmanacServiceEditController.php b/src/applications/almanac/controller/AlmanacServiceEditController.php
index 13f31430e7..be3fe02009 100644
--- a/src/applications/almanac/controller/AlmanacServiceEditController.php
+++ b/src/applications/almanac/controller/AlmanacServiceEditController.php
@@ -250,8 +250,4 @@ final class AlmanacServiceEditController
       ));
   }
 
-
-
-
-
 }
diff --git a/src/applications/aphlict/management/PhabricatorAphlictManagementStatusWorkflow.php b/src/applications/aphlict/management/PhabricatorAphlictManagementStatusWorkflow.php
index 145a5fcff2..85f80bfad4 100644
--- a/src/applications/aphlict/management/PhabricatorAphlictManagementStatusWorkflow.php
+++ b/src/applications/aphlict/management/PhabricatorAphlictManagementStatusWorkflow.php
@@ -15,11 +15,11 @@ final class PhabricatorAphlictManagementStatusWorkflow
     $pid = $this->getPID();
 
     if (!$pid) {
-      $console->writeErr(pht("Aphlict is not running.\n"));
+      $console->writeErr("%s\n", pht('Aphlict is not running.'));
       return 1;
     }
 
-    $console->writeOut(pht("Aphlict (%s) is running.\n", $pid));
+    $console->writeOut("%s\n", pht('Aphlict (%s) is running.', $pid));
     return 0;
   }
 
diff --git a/src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php b/src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php
index 1c8d855a86..d5d751363b 100644
--- a/src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php
+++ b/src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php
@@ -97,8 +97,10 @@ abstract class PhabricatorAphlictManagementWorkflow
 
   private static function mustHaveExtension($ext) {
     if (!extension_loaded($ext)) {
-      echo "ERROR: The PHP extension '{$ext}' is not installed. You must ".
-           "install it to run aphlict on this machine.\n";
+      echo pht(
+        "ERROR: The PHP extension '%s' is not installed. You must ".
+        "install it to run Aphlict on this machine.",
+        $ext)."\n";
       exit(1);
     }
 
@@ -106,8 +108,10 @@ abstract class PhabricatorAphlictManagementWorkflow
     foreach ($extension->getFunctions() as $function) {
       $function = $function->name;
       if (!function_exists($function)) {
-        echo "ERROR: The PHP function {$function}() is disabled. You must ".
-             "enable it to run aphlict on this machine.\n";
+        echo pht(
+          'ERROR: The PHP function %s is disabled. You must '.
+          'enable it to run Aphlict on this machine.',
+          $function.'()')."\n";
         exit(1);
       }
     }
@@ -121,7 +125,8 @@ abstract class PhabricatorAphlictManagementWorkflow
       throw new PhutilArgumentUsageException(
         pht(
           'Unable to start notifications server because it is already '.
-          'running. Use `aphlict restart` to restart it.'));
+          'running. Use `%s` to restart it.',
+          'aphlict restart'));
     }
 
     if (posix_getuid() == 0) {
@@ -195,7 +200,9 @@ abstract class PhabricatorAphlictManagementWorkflow
     $console = PhutilConsole::getConsole();
 
     if ($this->debug) {
-      $console->writeOut(pht("Starting Aphlict server in foreground...\n"));
+      $console->writeOut(
+        "%s\n",
+        pht('Starting Aphlict server in foreground...'));
     } else {
       Filesystem::writeFile($this->getPIDPath(), getmypid());
     }
@@ -214,10 +221,13 @@ abstract class PhabricatorAphlictManagementWorkflow
     register_shutdown_function(array($this, 'cleanup'));
 
     if ($this->debug) {
-      $console->writeOut("Launching server:\n\n    $ ".$command."\n\n");
+      $console->writeOut(
+        "%s\n\n    $ %s\n\n",
+        pht('Launching server:'),
+        $command);
 
       $err = phutil_passthru('%C', $command);
-      $console->writeOut(">>> Server exited!\n");
+      $console->writeOut(">>> %s\n", pht('Server exited!'));
       exit($err);
     } else {
       while (true) {
@@ -242,9 +252,12 @@ abstract class PhabricatorAphlictManagementWorkflow
 
     $pid = pcntl_fork();
     if ($pid < 0) {
-      throw new Exception('Failed to fork()!');
+      throw new Exception(
+        pht(
+          'Failed to %s!',
+          'fork()'));
     } else if ($pid) {
-      $console->writeErr(pht("Aphlict Server started.\n"));
+      $console->writeErr("%s\n", pht('Aphlict Server started.'));
       exit(0);
     }
 
@@ -267,11 +280,11 @@ abstract class PhabricatorAphlictManagementWorkflow
 
     $pid = $this->getPID();
     if (!$pid) {
-      $console->writeErr(pht("Aphlict is not running.\n"));
+      $console->writeErr("%s\n", pht('Aphlict is not running.'));
       return 0;
     }
 
-    $console->writeErr(pht("Stopping Aphlict Server (%s)...\n", $pid));
+    $console->writeErr("%s\n", pht('Stopping Aphlict Server (%s)...', $pid));
     posix_kill($pid, SIGINT);
 
     $start = time();
@@ -287,7 +300,7 @@ abstract class PhabricatorAphlictManagementWorkflow
     } while (time() < $start + 5);
 
     if ($pid) {
-      $console->writeErr(pht('Sending %s a SIGKILL.', $pid)."\n");
+      $console->writeErr("%s\n", pht('Sending %s a SIGKILL.', $pid));
       posix_kill($pid, SIGKILL);
       unset($pid);
     }
@@ -307,8 +320,11 @@ abstract class PhabricatorAphlictManagementWorkflow
 
     throw new PhutilArgumentUsageException(
       pht(
-        'No `nodejs` or `node` binary was found in $PATH. You must install '.
-        'Node.js to start the Aphlict server.'));
+        'No `%s` or `%s` binary was found in %s. You must install '.
+        'Node.js to start the Aphlict server.',
+        'nodejs',
+        'node',
+        '$PATH'));
   }
 
 }
diff --git a/src/applications/aphlict/query/AphlictDropdownDataQuery.php b/src/applications/aphlict/query/AphlictDropdownDataQuery.php
index 91ce3ad41f..4f360f28cc 100644
--- a/src/applications/aphlict/query/AphlictDropdownDataQuery.php
+++ b/src/applications/aphlict/query/AphlictDropdownDataQuery.php
@@ -22,7 +22,7 @@ final class AphlictDropdownDataQuery {
 
   public function getNotificationData() {
     if ($this->notificationData === null) {
-      throw new Exception('You must execute() first!');
+      throw new Exception(pht('You must %s first!', 'execute()'));
     }
     return $this->notificationData;
   }
@@ -34,7 +34,7 @@ final class AphlictDropdownDataQuery {
 
   public function getConpherenceData() {
     if ($this->conpherenceData === null) {
-      throw new Exception('You must execute() first!');
+      throw new Exception(pht('You must %s first!', 'execute()'));
     }
     return $this->conpherenceData;
   }
diff --git a/src/applications/arcanist/conduit/ArcanistProjectInfoConduitAPIMethod.php b/src/applications/arcanist/conduit/ArcanistProjectInfoConduitAPIMethod.php
index 677c4985aa..ee5cbbff2b 100644
--- a/src/applications/arcanist/conduit/ArcanistProjectInfoConduitAPIMethod.php
+++ b/src/applications/arcanist/conduit/ArcanistProjectInfoConduitAPIMethod.php
@@ -8,7 +8,7 @@ final class ArcanistProjectInfoConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Get information about Arcanist projects.';
+    return pht('Get information about Arcanist projects.');
   }
 
   protected function defineParamTypes() {
@@ -23,7 +23,7 @@ final class ArcanistProjectInfoConduitAPIMethod
 
   protected function defineErrorTypes() {
     return array(
-      'ERR-BAD-ARCANIST-PROJECT' => 'No such project exists.',
+      'ERR-BAD-ARCANIST-PROJECT' => pht('No such project exists.'),
     );
   }
 
diff --git a/src/applications/audit/conduit/AuditQueryConduitAPIMethod.php b/src/applications/audit/conduit/AuditQueryConduitAPIMethod.php
index d5a02810f8..2fc9ca47ee 100644
--- a/src/applications/audit/conduit/AuditQueryConduitAPIMethod.php
+++ b/src/applications/audit/conduit/AuditQueryConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class AuditQueryConduitAPIMethod extends AuditConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Query audit requests.';
+    return pht('Query audit requests.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/audit/constants/PhabricatorAuditActionConstants.php b/src/applications/audit/constants/PhabricatorAuditActionConstants.php
index 95dd8cdbf0..afecd0bf8f 100644
--- a/src/applications/audit/constants/PhabricatorAuditActionConstants.php
+++ b/src/applications/audit/constants/PhabricatorAuditActionConstants.php
@@ -14,12 +14,12 @@ final class PhabricatorAuditActionConstants {
 
   public static function getActionNameMap() {
     $map = array(
-      self::COMMENT => pht('Comment'),
-      self::CONCERN => pht("Raise Concern \xE2\x9C\x98"),
-      self::ACCEPT  => pht("Accept Commit \xE2\x9C\x94"),
-      self::RESIGN  => pht('Resign from Audit'),
-      self::CLOSE   => pht('Close Audit'),
-      self::ADD_CCS => pht('Add CCs'),
+      self::COMMENT      => pht('Comment'),
+      self::CONCERN      => pht("Raise Concern \xE2\x9C\x98"),
+      self::ACCEPT       => pht("Accept Commit \xE2\x9C\x94"),
+      self::RESIGN       => pht('Resign from Audit'),
+      self::CLOSE        => pht('Close Audit'),
+      self::ADD_CCS      => pht('Add CCs'),
       self::ADD_AUDITORS => pht('Add Auditors'),
     );
 
@@ -28,20 +28,20 @@ final class PhabricatorAuditActionConstants {
 
   public static function getActionName($constant) {
     $map = self::getActionNameMap();
-    return idx($map, $constant, 'Unknown');
+    return idx($map, $constant, pht('Unknown'));
   }
 
   public static function getActionPastTenseVerb($action) {
-    static $map = array(
-      self::COMMENT => 'commented on',
-      self::CONCERN => 'raised a concern with',
-      self::ACCEPT  => 'accepted',
-      self::RESIGN  => 'resigned from',
-      self::CLOSE   => 'closed',
-      self::ADD_CCS => 'added CCs to',
-      self::ADD_AUDITORS => 'added auditors to',
+    $map = array(
+      self::COMMENT      => pht('commented on'),
+      self::CONCERN      => pht('raised a concern with'),
+      self::ACCEPT       => pht('accepted'),
+      self::RESIGN       => pht('resigned from'),
+      self::CLOSE        => pht('closed'),
+      self::ADD_CCS      => pht('added CCs to'),
+      self::ADD_AUDITORS => pht('added auditors to'),
     );
-    return idx($map, $action, 'updated');
+    return idx($map, $action, pht('updated'));
   }
 
 }
diff --git a/src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php b/src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php
index aef3c7e224..1bc07aaa56 100644
--- a/src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php
+++ b/src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php
@@ -21,7 +21,7 @@ final class PhabricatorAuditCommitStatusConstants {
   }
 
   public static function getStatusName($code) {
-    return idx(self::getStatusNameMap(), $code, 'Unknown');
+    return idx(self::getStatusNameMap(), $code, pht('Unknown'));
   }
 
   public static function getOpenStatusConstants() {
diff --git a/src/applications/audit/editor/PhabricatorAuditEditor.php b/src/applications/audit/editor/PhabricatorAuditEditor.php
index b2fd9d84b2..24bc342f05 100644
--- a/src/applications/audit/editor/PhabricatorAuditEditor.php
+++ b/src/applications/audit/editor/PhabricatorAuditEditor.php
@@ -28,7 +28,7 @@ final class PhabricatorAuditEditor
     } else {
       $name = $this->getActor()->getUsername();
     }
-    return array('Added by '.$name.'.');
+    return array(pht('Added by %s.', $name));
   }
 
   public function setRawPatch($patch) {
@@ -432,7 +432,7 @@ final class PhabricatorAuditEditor
     }
 
     foreach ($phids as $phid) {
-      $this->addAuditReason($phid, 'Requested by Author');
+      $this->addAuditReason($phid, pht('Requested by Author'));
     }
     return id(new PhabricatorAuditTransaction())
       ->setTransactionType(PhabricatorAuditActionConstants::ADD_AUDITORS)
diff --git a/src/applications/audit/mail/PhabricatorAuditMailReceiver.php b/src/applications/audit/mail/PhabricatorAuditMailReceiver.php
index 2e0a2725ab..29b1748264 100644
--- a/src/applications/audit/mail/PhabricatorAuditMailReceiver.php
+++ b/src/applications/audit/mail/PhabricatorAuditMailReceiver.php
@@ -3,8 +3,8 @@
 final class PhabricatorAuditMailReceiver extends PhabricatorObjectMailReceiver {
 
   public function isEnabled() {
-    $app_class = 'PhabricatorAuditApplication';
-    return PhabricatorApplication::isClassInstalled($app_class);
+    return PhabricatorApplication::isClassInstalled(
+      'PhabricatorAuditApplication');
   }
 
   protected function getObjectPattern() {
diff --git a/src/applications/audit/mail/PhabricatorAuditReplyHandler.php b/src/applications/audit/mail/PhabricatorAuditReplyHandler.php
index 6aafbd772a..c1eb562bfa 100644
--- a/src/applications/audit/mail/PhabricatorAuditReplyHandler.php
+++ b/src/applications/audit/mail/PhabricatorAuditReplyHandler.php
@@ -5,7 +5,10 @@ final class PhabricatorAuditReplyHandler
 
   public function validateMailReceiver($mail_receiver) {
     if (!($mail_receiver instanceof PhabricatorRepositoryCommit)) {
-      throw new Exception('Mail receiver is not a commit!');
+      throw new Exception(
+        pht(
+          'Mail receiver is not a %s!',
+          'PhabricatorRepositoryCommit'));
     }
   }
 
diff --git a/src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php b/src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php
index 2d9438dd4e..fa9dbff635 100644
--- a/src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php
+++ b/src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php
@@ -7,51 +7,54 @@ final class PhabricatorAuditManagementDeleteWorkflow
     $this
       ->setName('delete')
       ->setExamples('**delete** [--dry-run] ...')
-      ->setSynopsis('Delete audit requests matching parameters.')
+      ->setSynopsis(pht('Delete audit requests matching parameters.'))
       ->setArguments(
         array(
           array(
             'name' => 'dry-run',
-            'help' => 'Show what would be deleted, but do not actually delete '.
-                      'anything.',
+            'help' => pht(
+              'Show what would be deleted, but do not actually delete '.
+              'anything.'),
           ),
           array(
             'name' => 'users',
             'param' => 'names',
-            'help' => 'Select only audits by a given list of users.',
+            'help' => pht('Select only audits by a given list of users.'),
           ),
           array(
             'name' => 'repositories',
             'param' => 'repos',
-            'help' => 'Select only audits in a given list of repositories.',
+            'help' => pht(
+              'Select only audits in a given list of repositories.'),
           ),
           array(
             'name' => 'commits',
             'param' => 'commits',
-            'help' => 'Select only audits for the given commits.',
+            'help' => pht('Select only audits for the given commits.'),
           ),
           array(
             'name' => 'min-commit-date',
             'param' => 'date',
-            'help' => 'Select only audits for commits on or after the given '.
-                      'date.',
+            'help' => pht(
+              'Select only audits for commits on or after the given date.'),
           ),
           array(
             'name' => 'max-commit-date',
             'param' => 'date',
-            'help' => 'Select only audits for commits on or before the given '.
-                      'date.',
+            'help' => pht(
+              'Select only audits for commits on or before the given date.'),
           ),
           array(
             'name' => 'status',
             'param' => 'status',
-            'help' => 'Select only audits in the given status. By default, '.
-                      'only open audits are selected.',
+            'help' => pht(
+              'Select only audits in the given status. By default, '.
+              'only open audits are selected.'),
           ),
           array(
             'name' => 'ids',
             'param' => 'ids',
-            'help' => 'Select only audits with the given IDs.',
+            'help' => pht('Select only audits with the given IDs.'),
           ),
         ));
   }
@@ -72,7 +75,7 @@ final class PhabricatorAuditManagementDeleteWorkflow
     $max_date = $this->loadDate($args->getArg('max-commit-date'));
     if ($min_date && $max_date && ($min_date > $max_date)) {
       throw new PhutilArgumentUsageException(
-        'Specified max date must come after specified min date.');
+        pht('Specified maximum date must come after specified minimum date.'));
     }
 
     $is_dry_run = $args->getArg('dry-run');
@@ -250,8 +253,9 @@ final class PhabricatorAuditManagementDeleteWorkflow
     if (!$epoch || $epoch < 1) {
       throw new PhutilArgumentUsageException(
         pht(
-          'Unable to parse date "%s". Use a format like "2000-01-01".',
-          $date));
+          'Unable to parse date "%s". Use a format like "%s".',
+          $date,
+          '2000-01-01'));
     }
 
     return $epoch;
diff --git a/src/applications/audit/view/PhabricatorAuditListView.php b/src/applications/audit/view/PhabricatorAuditListView.php
index 96844c5b48..75aa58db53 100644
--- a/src/applications/audit/view/PhabricatorAuditListView.php
+++ b/src/applications/audit/view/PhabricatorAuditListView.php
@@ -59,7 +59,7 @@ final class PhabricatorAuditListView extends AphrontView {
   private function getHandle($phid) {
     $handle = idx($this->handles, $phid);
     if (!$handle) {
-      throw new Exception("No handle for '{$phid}'!");
+      throw new Exception(pht("No handle for '%s'!", $phid));
     }
     return $handle;
   }
@@ -98,7 +98,11 @@ final class PhabricatorAuditListView extends AphrontView {
   public function buildList() {
     $user = $this->getUser();
     if (!$user) {
-      throw new Exception('you must setUser() before buildList()!');
+      throw new Exception(
+        pht(
+          'You must %s before %s!',
+          'setUser()',
+          __FUNCTION__.'()'));
     }
     $rowc = array();
 
diff --git a/src/applications/audit/view/PhabricatorAuditTransactionView.php b/src/applications/audit/view/PhabricatorAuditTransactionView.php
index 64a2892ffd..305ea19c56 100644
--- a/src/applications/audit/view/PhabricatorAuditTransactionView.php
+++ b/src/applications/audit/view/PhabricatorAuditTransactionView.php
@@ -72,7 +72,7 @@ final class PhabricatorAuditTransactionView
           $inlines[] = $xaction;
           break;
         default:
-          throw new Exception('Unknown grouped transaction type!');
+          throw new Exception(pht('Unknown grouped transaction type!'));
       }
     }
 
diff --git a/src/applications/auth/conduit/PhabricatorAuthConduitAPIMethod.php b/src/applications/auth/conduit/PhabricatorAuthConduitAPIMethod.php
index 07d2a4b157..34bedec0bc 100644
--- a/src/applications/auth/conduit/PhabricatorAuthConduitAPIMethod.php
+++ b/src/applications/auth/conduit/PhabricatorAuthConduitAPIMethod.php
@@ -3,8 +3,7 @@
 abstract class PhabricatorAuthConduitAPIMethod extends ConduitAPIMethod {
 
   final public function getApplication() {
-    return PhabricatorApplication::getByClass(
-      'PhabricatorAuthApplication');
+    return PhabricatorApplication::getByClass('PhabricatorAuthApplication');
   }
 
   public function getMethodStatus() {
@@ -12,8 +11,7 @@ abstract class PhabricatorAuthConduitAPIMethod extends ConduitAPIMethod {
   }
 
   public function getMethodStatusDescription() {
-    return pht(
-      'These methods are recently introduced and subject to change.');
+    return pht('These methods are recently introduced and subject to change.');
   }
 
 }
diff --git a/src/applications/auth/controller/PhabricatorAuthLoginController.php b/src/applications/auth/controller/PhabricatorAuthLoginController.php
index f00eff32c5..e3cbeaa2c6 100644
--- a/src/applications/auth/controller/PhabricatorAuthLoginController.php
+++ b/src/applications/auth/controller/PhabricatorAuthLoginController.php
@@ -68,7 +68,9 @@ final class PhabricatorAuthLoginController
 
     if (!$account) {
       throw new Exception(
-        'Auth provider failed to load an account from processLoginRequest()!');
+        pht(
+          'Auth provider failed to load an account from %s!',
+          'processLoginRequest()'));
     }
 
     if ($account->getUserPHID()) {
@@ -164,7 +166,7 @@ final class PhabricatorAuthLoginController
     $next_uri) {
 
     if ($account->getUserPHID()) {
-      throw new Exception('Account is already registered or linked.');
+      throw new Exception(pht('Account is already registered or linked.'));
     }
 
     // Regenerate the registration secret key, set it on the external account,
diff --git a/src/applications/auth/controller/PhabricatorAuthNeedsMultiFactorController.php b/src/applications/auth/controller/PhabricatorAuthNeedsMultiFactorController.php
index 57516ac6b6..975355ec97 100644
--- a/src/applications/auth/controller/PhabricatorAuthNeedsMultiFactorController.php
+++ b/src/applications/auth/controller/PhabricatorAuthNeedsMultiFactorController.php
@@ -40,7 +40,7 @@ final class PhabricatorAuthNeedsMultiFactorController
             pht(
               'Multi-factor authentication helps secure your account by '.
               'making it more difficult for attackers to gain access or '.
-              'take senstive actions.'),
+              'take sensitive actions.'),
             pht(
               'To learn more about multi-factor authentication, click the '.
               '%s button below.',
diff --git a/src/applications/auth/controller/PhabricatorAuthRegisterController.php b/src/applications/auth/controller/PhabricatorAuthRegisterController.php
index d27a644480..9341345143 100644
--- a/src/applications/auth/controller/PhabricatorAuthRegisterController.php
+++ b/src/applications/auth/controller/PhabricatorAuthRegisterController.php
@@ -560,8 +560,7 @@ final class PhabricatorAuthRegisterController
       return array($account, $provider, $response);
     } else if (count($providers) > 1) {
       $response = $this->renderError(
-        pht(
-          'There are too many configured default registration providers.'));
+        pht('There are too many configured default registration providers.'));
       return array($account, $provider, $response);
     }
 
diff --git a/src/applications/auth/controller/PhabricatorAuthSSHKeyGenerateController.php b/src/applications/auth/controller/PhabricatorAuthSSHKeyGenerateController.php
index d055db514a..2cb6dc81ea 100644
--- a/src/applications/auth/controller/PhabricatorAuthSSHKeyGenerateController.php
+++ b/src/applications/auth/controller/PhabricatorAuthSSHKeyGenerateController.php
@@ -55,9 +55,9 @@ final class PhabricatorAuthSSHKeyGenerateController
         ->setSubmitURI($file->getDownloadURI())
         ->appendParagraph(
           pht(
-          'A keypair has been generated, and the public key has been '.
-          'added as a recognized key. Use the button below to download '.
-          'the private key.'))
+            'A keypair has been generated, and the public key has been '.
+            'added as a recognized key. Use the button below to download '.
+            'the private key.'))
         ->appendParagraph(
           pht(
             'After you download the private key, it will be destroyed. '.
@@ -77,8 +77,7 @@ final class PhabricatorAuthSSHKeyGenerateController
             'This workflow will generate a new SSH keypair, add the public '.
             'key, and let you download the private key.'))
         ->appendParagraph(
-          pht(
-            'Phabricator will not retain a copy of the private key.'))
+          pht('Phabricator will not retain a copy of the private key.'))
         ->addSubmitButton(pht('Generate New Keypair'))
         ->addCancelButton($cancel_uri);
     } catch (Exception $ex) {
diff --git a/src/applications/auth/controller/PhabricatorAuthStartController.php b/src/applications/auth/controller/PhabricatorAuthStartController.php
index 7ea10690e5..f9b9f7cb41 100644
--- a/src/applications/auth/controller/PhabricatorAuthStartController.php
+++ b/src/applications/auth/controller/PhabricatorAuthStartController.php
@@ -71,8 +71,8 @@ final class PhabricatorAuthStartController
           'This Phabricator install is not configured with any enabled '.
           'authentication providers which can be used to log in. If you '.
           'have accidentally locked yourself out by disabling all providers, '.
-          'you can use `phabricator/bin/auth recover <username>` to '.
-          'recover access to an administrative account.'));
+          'you can use `%s` to recover access to an administrative account.'.
+          'phabricator/bin/auth recover <username>'));
     }
 
     $next_uri = $request->getStr('next');
diff --git a/src/applications/auth/controller/PhabricatorEmailLoginController.php b/src/applications/auth/controller/PhabricatorEmailLoginController.php
index d21ec5a1bb..9db360d51d 100644
--- a/src/applications/auth/controller/PhabricatorEmailLoginController.php
+++ b/src/applications/auth/controller/PhabricatorEmailLoginController.php
@@ -72,7 +72,7 @@ final class PhabricatorEmailLoginController
             $target_email->getUserPHID());
           if ($verified_addresses) {
             $errors[] = pht(
-              'That email addess is not verified. You can only send '.
+              'That email address is not verified. You can only send '.
               'password reset links to a verified address.');
             $e_email = pht('Unverified');
           }
@@ -86,26 +86,22 @@ final class PhabricatorEmailLoginController
             PhabricatorAuthSessionEngine::ONETIME_RESET);
 
           if ($is_serious) {
-            $body = <<<EOBODY
-You can use this link to reset your Phabricator password:
-
-  {$uri}
-
-EOBODY;
+            $body = pht(
+              "You can use this link to reset your Phabricator password:".
+              "\n\n  %s\n",
+              $uri);
           } else {
-            $body = <<<EOBODY
-Condolences on forgetting your password. You can use this link to reset it:
+            $body = pht(
+              "Condolences on forgetting your password. You can use this ".
+              "link to reset it:\n\n".
+              "  %s\n\n".
+              "After you set a new password, consider writing it down on a ".
+              "sticky note and attaching it to your monitor so you don't ".
+              "forget again! Choosing a very short, easy-to-remember password ".
+              "like \"cat\" or \"1234\" might also help.\n\n".
+              "Best Wishes,\nPhabricator\n",
+              $uri);
 
-  {$uri}
-
-After you set a new password, consider writing it down on a sticky note and
-attaching it to your monitor so you don't forget again! Choosing a very short,
-easy-to-remember password like "cat" or "1234" might also help.
-
-Best Wishes,
-Phabricator
-
-EOBODY;
           }
 
           $mail = id(new PhabricatorMetaMTAMail())
@@ -123,7 +119,6 @@ EOBODY;
             ->addCancelButton('/', pht('Done'));
         }
       }
-
     }
 
     $error_view = null;
@@ -153,8 +148,7 @@ EOBODY;
 
     $dialog = new AphrontDialogView();
     $dialog->setUser($request->getUser());
-    $dialog->setTitle(pht(
-      'Forgot Password / Email Login'));
+    $dialog->setTitle(pht('Forgot Password / Email Login'));
     $dialog->appendChild($email_auth);
     $dialog->addSubmitButton(pht('Send Email'));
     $dialog->setSubmitURI('/login/email/');
diff --git a/src/applications/auth/factor/__tests__/PhabricatorTOTPAuthFactorTestCase.php b/src/applications/auth/factor/__tests__/PhabricatorTOTPAuthFactorTestCase.php
index 464c0b8e54..284db4cde1 100644
--- a/src/applications/auth/factor/__tests__/PhabricatorTOTPAuthFactorTestCase.php
+++ b/src/applications/auth/factor/__tests__/PhabricatorTOTPAuthFactorTestCase.php
@@ -39,6 +39,4 @@ final class PhabricatorTOTPAuthFactorTestCase extends PhabricatorTestCase {
 
   }
 
-
-
 }
diff --git a/src/applications/auth/management/PhabricatorAuthManagementCachePKCS8Workflow.php b/src/applications/auth/management/PhabricatorAuthManagementCachePKCS8Workflow.php
index a10b3ea64a..22f993cee5 100644
--- a/src/applications/auth/management/PhabricatorAuthManagementCachePKCS8Workflow.php
+++ b/src/applications/auth/management/PhabricatorAuthManagementCachePKCS8Workflow.php
@@ -11,8 +11,8 @@ final class PhabricatorAuthManagementCachePKCS8Workflow
         pht(
           'Cache the PKCS8 format of a public key. When developing on OSX, '.
           'this can be used to work around issues with ssh-keygen. Use '.
-          '`ssh-keygen -e -m PKCS8 -f key.pub` to generate a PKCS8 key to '.
-          'feed to this command.'))
+          '`%s` to generate a PKCS8 key to feed to this command.',
+          'ssh-keygen -e -m PKCS8 -f key.pub'))
       ->setArguments(
         array(
           array(
@@ -35,7 +35,8 @@ final class PhabricatorAuthManagementCachePKCS8Workflow
     if (!strlen($public_keyfile)) {
       throw new PhutilArgumentUsageException(
         pht(
-          'You must specify the path to a public keyfile with --public.'));
+          'You must specify the path to a public keyfile with %s.',
+          '--public'));
     }
 
     if (!Filesystem::pathExists($public_keyfile)) {
@@ -51,7 +52,8 @@ final class PhabricatorAuthManagementCachePKCS8Workflow
     if (!strlen($pkcs8_keyfile)) {
       throw new PhutilArgumentUsageException(
         pht(
-          'You must specify the path to a pkcs8 keyfile with --pkc8s.'));
+          'You must specify the path to a pkcs8 keyfile with %s.',
+          '--pkc8s'));
     }
 
     if (!Filesystem::pathExists($pkcs8_keyfile)) {
diff --git a/src/applications/auth/management/PhabricatorAuthManagementLDAPWorkflow.php b/src/applications/auth/management/PhabricatorAuthManagementLDAPWorkflow.php
index e7afcc48d1..725d2dfc49 100644
--- a/src/applications/auth/management/PhabricatorAuthManagementLDAPWorkflow.php
+++ b/src/applications/auth/management/PhabricatorAuthManagementLDAPWorkflow.php
@@ -21,28 +21,28 @@ final class PhabricatorAuthManagementLDAPWorkflow
     if (!$provider) {
       $console->writeOut(
         "%s\n",
-        'The LDAP authentication provider is not enabled.');
+        pht('The LDAP authentication provider is not enabled.'));
       exit(1);
     }
 
     if (!function_exists('ldap_connect')) {
       $console->writeOut(
         "%s\n",
-        'The LDAP extension is not enabled.');
+        pht('The LDAP extension is not enabled.'));
       exit(1);
     }
 
     $adapter = $provider->getAdapter();
 
     $console->writeOut("%s\n", pht('Enter LDAP Credentials'));
-    $username = phutil_console_prompt('LDAP Username: ');
+    $username = phutil_console_prompt(pht('LDAP Username: '));
     if (!strlen($username)) {
       throw new PhutilArgumentUsageException(
         pht('You must enter an LDAP username.'));
     }
 
     phutil_passthru('stty -echo');
-    $password = phutil_console_prompt('LDAP Password: ');
+    $password = phutil_console_prompt(pht('LDAP Password: '));
     phutil_passthru('stty echo');
 
     if (!strlen($password)) {
diff --git a/src/applications/auth/management/PhabricatorAuthManagementRecoverWorkflow.php b/src/applications/auth/management/PhabricatorAuthManagementRecoverWorkflow.php
index fe918adee4..ad843d56ce 100644
--- a/src/applications/auth/management/PhabricatorAuthManagementRecoverWorkflow.php
+++ b/src/applications/auth/management/PhabricatorAuthManagementRecoverWorkflow.php
@@ -8,8 +8,9 @@ final class PhabricatorAuthManagementRecoverWorkflow
       ->setName('recover')
       ->setExamples('**recover** __username__')
       ->setSynopsis(
-        'Recover access to an administrative account if you have locked '.
-        'yourself out of Phabricator.')
+        pht(
+          'Recover access to an administrative account if you have locked '.
+          'yourself out of Phabricator.'))
       ->setArguments(
         array(
           'username' => array(
@@ -29,8 +30,9 @@ final class PhabricatorAuthManagementRecoverWorkflow
       throw new PhutilArgumentUsageException(
         pht(
           'This Phabricator installation has no recoverable administrator '.
-          'accounts. You can use `bin/accountadmin` to create a new '.
-          'administrator account or make an existing user an administrator.'));
+          'accounts. You can use `%s` to create a new administrator '.
+          'account or make an existing user an administrator.',
+          'bin/accountadmin'));
     }
     $can_recover = mpull($can_recover, 'getUsername');
     sort($can_recover);
@@ -85,10 +87,11 @@ final class PhabricatorAuthManagementRecoverWorkflow
     $console->writeOut('    %s', $onetime_uri);
     $console->writeOut("\n\n");
     $console->writeOut(
+      "%s\n",
       pht(
         'After logging in, you can use the "Auth" application to add or '.
         'restore authentication providers and allow normal logins to '.
-        'succeed.')."\n");
+        'succeed.'));
 
     return 0;
   }
diff --git a/src/applications/auth/management/PhabricatorAuthManagementRefreshWorkflow.php b/src/applications/auth/management/PhabricatorAuthManagementRefreshWorkflow.php
index b05b87f5e8..23c0a109cb 100644
--- a/src/applications/auth/management/PhabricatorAuthManagementRefreshWorkflow.php
+++ b/src/applications/auth/management/PhabricatorAuthManagementRefreshWorkflow.php
@@ -16,17 +16,17 @@ final class PhabricatorAuthManagementRefreshWorkflow
           array(
             'name' => 'user',
             'param' => 'user',
-            'help' => 'Refresh tokens for a given user.',
+            'help' => pht('Refresh tokens for a given user.'),
           ),
           array(
             'name' => 'type',
             'param' => 'provider',
-            'help' => 'Refresh tokens for a given provider type.',
+            'help' => pht('Refresh tokens for a given provider type.'),
           ),
           array(
             'name' => 'domain',
             'param' => 'domain',
-            'help' => 'Refresh tokens for a given domain.',
+            'help' => pht('Refresh tokens for a given domain.'),
           ),
         ));
   }
diff --git a/src/applications/auth/management/PhabricatorAuthManagementStripWorkflow.php b/src/applications/auth/management/PhabricatorAuthManagementStripWorkflow.php
index f6d057b57a..f25d05301b 100644
--- a/src/applications/auth/management/PhabricatorAuthManagementStripWorkflow.php
+++ b/src/applications/auth/management/PhabricatorAuthManagementStripWorkflow.php
@@ -7,9 +7,7 @@ final class PhabricatorAuthManagementStripWorkflow
     $this
       ->setName('strip')
       ->setExamples('**strip** [--user username] [--type type]')
-      ->setSynopsis(
-        pht(
-          'Remove multi-factor authentication from an account.'))
+      ->setSynopsis(pht('Remove multi-factor authentication from an account.'))
       ->setArguments(
         array(
           array(
@@ -50,13 +48,17 @@ final class PhabricatorAuthManagementStripWorkflow
     if ($usernames && $all_users) {
       throw new PhutilArgumentUsageException(
         pht(
-          'Specify either specific users with --user, or all users with '.
-          '--all-users, but not both.'));
+          'Specify either specific users with %s, or all users with '.
+          '%s, but not both.',
+          '--user',
+          '--all-users'));
     } else if (!$usernames && !$all_users) {
       throw new PhutilArgumentUsageException(
         pht(
-          'Use --user to specify which user to strip factors from, or '.
-          '--all-users to strip factors from all users.'));
+          'Use %s to specify which user to strip factors from, or '.
+          '%s to strip factors from all users.',
+          '--user',
+          '--all-users'));
     } else if ($usernames) {
       $users = id(new PhabricatorPeopleQuery())
         ->setViewer($this->getViewer())
diff --git a/src/applications/auth/management/PhabricatorAuthManagementTrustOAuthClientWorkflow.php b/src/applications/auth/management/PhabricatorAuthManagementTrustOAuthClientWorkflow.php
index 229218d3b7..ee5e50b38e 100644
--- a/src/applications/auth/management/PhabricatorAuthManagementTrustOAuthClientWorkflow.php
+++ b/src/applications/auth/management/PhabricatorAuthManagementTrustOAuthClientWorkflow.php
@@ -28,7 +28,8 @@ final class PhabricatorAuthManagementTrustOAuthClientWorkflow
     if (!$id) {
       throw new PhutilArgumentUsageException(
         pht(
-          'Specify an OAuth client id with --id.'));
+          'Specify an OAuth client id with %s.',
+          '--id'));
     }
 
     $client = id(new PhabricatorOAuthServerClientQuery())
diff --git a/src/applications/auth/management/PhabricatorAuthManagementUntrustOAuthClientWorkflow.php b/src/applications/auth/management/PhabricatorAuthManagementUntrustOAuthClientWorkflow.php
index 344e4b8864..a0b3e02fa4 100644
--- a/src/applications/auth/management/PhabricatorAuthManagementUntrustOAuthClientWorkflow.php
+++ b/src/applications/auth/management/PhabricatorAuthManagementUntrustOAuthClientWorkflow.php
@@ -28,7 +28,8 @@ final class PhabricatorAuthManagementUntrustOAuthClientWorkflow
     if (!$id) {
       throw new PhutilArgumentUsageException(
         pht(
-          'Specify an OAuth client id with --id.'));
+          'Specify an OAuth client ID with %s.',
+          '--id'));
     }
 
     $client = id(new PhabricatorOAuthServerClientQuery())
@@ -39,7 +40,7 @@ final class PhabricatorAuthManagementUntrustOAuthClientWorkflow
     if (!$client) {
       throw new PhutilArgumentUsageException(
         pht(
-          'Failed to find an OAuth client with id %s.', $id));
+          'Failed to find an OAuth client with ID %s.', $id));
     }
 
     if (!$client->getIsTrusted()) {
diff --git a/src/applications/auth/provider/PhabricatorAuthProvider.php b/src/applications/auth/provider/PhabricatorAuthProvider.php
index 5ffb18b41a..d495a3091f 100644
--- a/src/applications/auth/provider/PhabricatorAuthProvider.php
+++ b/src/applications/auth/provider/PhabricatorAuthProvider.php
@@ -195,7 +195,7 @@ abstract class PhabricatorAuthProvider {
 
   protected function loadOrCreateAccount($account_id) {
     if (!strlen($account_id)) {
-      throw new Exception('loadOrCreateAccount(...): empty account ID!');
+      throw new Exception(pht('Empty account ID!'));
     }
 
     $adapter = $this->getAdapter();
@@ -203,14 +203,18 @@ abstract class PhabricatorAuthProvider {
 
     if (!strlen($adapter->getAdapterType())) {
       throw new Exception(
-        "AuthAdapter (of class '{$adapter_class}') has an invalid ".
-        "implementation: no adapter type.");
+        pht(
+          "AuthAdapter (of class '%s') has an invalid implementation: ".
+          "no adapter type.",
+          $adapter_class));
     }
 
     if (!strlen($adapter->getAdapterDomain())) {
       throw new Exception(
-        "AuthAdapter (of class '{$adapter_class}') has an invalid ".
-        "implementation: no adapter domain.");
+        pht(
+          "AuthAdapter (of class '%s') has an invalid implementation: ".
+          "no adapter domain.",
+          $adapter_class));
     }
 
     $account = id(new PhabricatorExternalAccount())->loadOneWhere(
diff --git a/src/applications/auth/provider/PhabricatorLDAPAuthProvider.php b/src/applications/auth/provider/PhabricatorLDAPAuthProvider.php
index 111d62601b..013cd21736 100644
--- a/src/applications/auth/provider/PhabricatorLDAPAuthProvider.php
+++ b/src/applications/auth/provider/PhabricatorLDAPAuthProvider.php
@@ -110,13 +110,13 @@ final class PhabricatorLDAPAuthProvider extends PhabricatorAuthProvider {
       ->setFullWidth(true)
       ->appendChild(
         id(new AphrontFormTextControl())
-          ->setLabel('LDAP Username')
+          ->setLabel(pht('LDAP Username'))
           ->setName('ldap_username')
           ->setValue($v_user)
           ->setError($e_user))
       ->appendChild(
         id(new AphrontFormPasswordControl())
-          ->setLabel('LDAP Password')
+          ->setLabel(pht('LDAP Password'))
           ->setName('ldap_password')
           ->setError($e_pass));
 
@@ -166,7 +166,7 @@ final class PhabricatorLDAPAuthProvider extends PhabricatorAuthProvider {
             $account_id = $adapter->getAccountID();
           DarkConsoleErrorLogPluginAPI::disableDiscardMode();
         } else {
-          throw new Exception('Username and password are required!');
+          throw new Exception(pht('Username and password are required!'));
         }
       } catch (PhutilAuthCredentialException $ex) {
         $response = $controller->buildProviderPageResponse(
@@ -258,8 +258,9 @@ final class PhabricatorLDAPAuthProvider extends PhabricatorAuthProvider {
           'Before you can set up or use LDAP, you need to install the PHP '.
           'LDAP extension. It is not currently installed, so PHP can not '.
           'talk to LDAP. Usually you can install it with '.
-          '`yum install php-ldap`, `apt-get install php5-ldap`, or a '.
-          'similar package manager command.'));
+          '`%s`, `%s`, or a similar package manager command.',
+          'yum install php-ldap',
+          'apt-get install php5-ldap'));
     }
   }
 
diff --git a/src/applications/auth/provider/PhabricatorOAuth1AuthProvider.php b/src/applications/auth/provider/PhabricatorOAuth1AuthProvider.php
index 745232a783..a22707b6cc 100644
--- a/src/applications/auth/provider/PhabricatorOAuth1AuthProvider.php
+++ b/src/applications/auth/provider/PhabricatorOAuth1AuthProvider.php
@@ -84,11 +84,11 @@ abstract class PhabricatorOAuth1AuthProvider
     $verifier = $request->getStr('oauth_verifier');
 
     if (!$token) {
-      throw new Exception("Expected 'oauth_token' in request!");
+      throw new Exception(pht("Expected '%s' in request!", 'oauth_token'));
     }
 
     if (!$verifier) {
-      throw new Exception("Expected 'oauth_verifier' in request!");
+      throw new Exception(pht("Expected '%s' in request!", 'oauth_verifier'));
     }
 
     $adapter->setToken($token);
diff --git a/src/applications/auth/provider/PhabricatorOAuth2AuthProvider.php b/src/applications/auth/provider/PhabricatorOAuth2AuthProvider.php
index 4f1f1e8fed..aff6367840 100644
--- a/src/applications/auth/provider/PhabricatorOAuth2AuthProvider.php
+++ b/src/applications/auth/provider/PhabricatorOAuth2AuthProvider.php
@@ -198,7 +198,7 @@ abstract class PhabricatorOAuth2AuthProvider
     $force_refresh = false) {
 
     if ($account->getProviderKey() !== $this->getProviderKey()) {
-      throw new Exception('Account does not match provider!');
+      throw new Exception(pht('Account does not match provider!'));
     }
 
     if (!$force_refresh) {
@@ -262,8 +262,7 @@ abstract class PhabricatorOAuth2AuthProvider
             phabricator_datetime($oauth_expires, $viewer)));
       } else {
         $item->addAttribute(
-          pht(
-            'Active OAuth Token'));
+          pht('Active OAuth Token'));
       }
     } else if ($is_invalid) {
       $item->addAttribute(pht('Invalid OAuth Access Token'));
diff --git a/src/applications/auth/provider/PhabricatorOAuthAuthProvider.php b/src/applications/auth/provider/PhabricatorOAuthAuthProvider.php
index 8f7eae8aac..df76c655f3 100644
--- a/src/applications/auth/provider/PhabricatorOAuthAuthProvider.php
+++ b/src/applications/auth/provider/PhabricatorOAuthAuthProvider.php
@@ -82,8 +82,9 @@ abstract class PhabricatorOAuthAuthProvider extends PhabricatorAuthProvider {
     $help = $this->getProviderConfigurationHelp();
 
     return $help."\n\n".
-      pht('Use the **OAuth App Notes** field to record details about which '.
-          'account the external application is registered under.');
+      pht(
+        'Use the **OAuth App Notes** field to record details about which '.
+        'account the external application is registered under.');
   }
 
   abstract protected function getProviderConfigurationHelp();
diff --git a/src/applications/auth/provider/PhabricatorPasswordAuthProvider.php b/src/applications/auth/provider/PhabricatorPasswordAuthProvider.php
index 6307446c88..dbe2203d83 100644
--- a/src/applications/auth/provider/PhabricatorPasswordAuthProvider.php
+++ b/src/applications/auth/provider/PhabricatorPasswordAuthProvider.php
@@ -13,7 +13,8 @@ final class PhabricatorPasswordAuthProvider extends PhabricatorAuthProvider {
       "(WARNING) Examine the table below for information on how password ".
       "hashes will be stored in the database.\n\n".
       "(NOTE) You can select a minimum password length by setting ".
-      "`account.minimum-password-length` in configuration.");
+      "`%s` in configuration.",
+      'account.minimum-password-length');
   }
 
   public function renderConfigurationFooter() {
@@ -160,7 +161,7 @@ final class PhabricatorPasswordAuthProvider extends PhabricatorAuthProvider {
 
   public function buildLinkForm(
     PhabricatorAuthLinkController $controller) {
-    throw new Exception("Password providers can't be linked.");
+    throw new Exception(pht("Password providers can't be linked."));
   }
 
   private function renderPasswordLoginForm(
@@ -205,8 +206,9 @@ final class PhabricatorPasswordAuthProvider extends PhabricatorAuthProvider {
         $errors[] = pht('CAPTCHA was not entered correctly.');
       } else {
         $e_captcha = pht('Required');
-        $errors[] = pht('Too many login failures recently. You must '.
-                    'submit a CAPTCHA with your login request.');
+        $errors[] = pht(
+          'Too many login failures recently. You must '.
+          'submit a CAPTCHA with your login request.');
       }
     } else if ($request->isHTTPPost()) {
       // NOTE: This is intentionally vague so as not to disclose whether a
@@ -225,13 +227,13 @@ final class PhabricatorPasswordAuthProvider extends PhabricatorAuthProvider {
       ->appendChild($errors)
       ->appendChild(
         id(new AphrontFormTextControl())
-          ->setLabel('Username or Email')
+          ->setLabel(pht('Username or Email'))
           ->setName('username')
           ->setValue($v_user)
           ->setError($e_user))
       ->appendChild(
         id(new AphrontFormPasswordControl())
-          ->setLabel('Password')
+          ->setLabel(pht('Password'))
           ->setName('password')
           ->setError($e_pass));
 
diff --git a/src/applications/auth/provider/PhabricatorPersonaAuthProvider.php b/src/applications/auth/provider/PhabricatorPersonaAuthProvider.php
index 843c55a365..e88b466872 100644
--- a/src/applications/auth/provider/PhabricatorPersonaAuthProvider.php
+++ b/src/applications/auth/provider/PhabricatorPersonaAuthProvider.php
@@ -9,8 +9,7 @@ final class PhabricatorPersonaAuthProvider extends PhabricatorAuthProvider {
   }
 
   public function getDescriptionForCreate() {
-    return pht(
-      'Allow users to login or register using Mozilla Persona.');
+    return pht('Allow users to login or register using Mozilla Persona.');
   }
 
   public function getAdapter() {
@@ -54,12 +53,12 @@ final class PhabricatorPersonaAuthProvider extends PhabricatorAuthProvider {
     $response = null;
 
     if (!$request->isAjax()) {
-      throw new Exception('Expected this request to come via Ajax.');
+      throw new Exception(pht('Expected this request to come via Ajax.'));
     }
 
     $assertion = $request->getStr('assertion');
     if (!$assertion) {
-      throw new Exception('Expected identity assertion.');
+      throw new Exception(pht('Expected identity assertion.'));
     }
 
     $adapter->setAssertion($assertion);
diff --git a/src/applications/auth/provider/PhabricatorPhabricatorAuthProvider.php b/src/applications/auth/provider/PhabricatorPhabricatorAuthProvider.php
index b27c895e82..8ea5e71f43 100644
--- a/src/applications/auth/provider/PhabricatorPhabricatorAuthProvider.php
+++ b/src/applications/auth/provider/PhabricatorPhabricatorAuthProvider.php
@@ -122,7 +122,8 @@ final class PhabricatorPhabricatorAuthProvider
       $uri = new PhutilURI($values[$key_uri]);
       if (!$uri->getProtocol()) {
         $errors[] = pht(
-          'Phabricator base URI should include protocol (like "https://").');
+          'Phabricator base URI should include protocol (like "%s").',
+          'https://');
         $issues[$key_uri] = pht('Invalid');
       }
     }
diff --git a/src/applications/auth/query/PhabricatorAuthProviderConfigQuery.php b/src/applications/auth/query/PhabricatorAuthProviderConfigQuery.php
index 028108c2cc..44e5913290 100644
--- a/src/applications/auth/query/PhabricatorAuthProviderConfigQuery.php
+++ b/src/applications/auth/query/PhabricatorAuthProviderConfigQuery.php
@@ -88,7 +88,7 @@ final class PhabricatorAuthProviderConfigQuery
           'isEnabled = 1');
         break;
       default:
-        throw new Exception("Unknown status '{$status}'!");
+        throw new Exception(pht("Unknown status '%s'!", $status));
     }
 
     $where[] = $this->buildPagingClause($conn_r);
diff --git a/src/applications/auth/sshkey/PhabricatorAuthSSHPublicKey.php b/src/applications/auth/sshkey/PhabricatorAuthSSHPublicKey.php
index b30e16db7d..d8660b1956 100644
--- a/src/applications/auth/sshkey/PhabricatorAuthSSHPublicKey.php
+++ b/src/applications/auth/sshkey/PhabricatorAuthSSHPublicKey.php
@@ -129,8 +129,9 @@ final class PhabricatorAuthSSHPublicKey extends Phobject {
       throw new PhutilProxyException(
         pht(
           'Failed to convert public key into PKCS8 format. If you are '.
-          'developing on OSX, you may be able to use `bin/auth cache-pkcs8` '.
+          'developing on OSX, you may be able to use `%s` '.
           'to work around this issue. %s',
+          'bin/auth cache-pkcs8',
           $ex->getMessage()),
         $ex);
     }
diff --git a/src/applications/base/PhabricatorApplication.php b/src/applications/base/PhabricatorApplication.php
index 295d4db180..e97e4d605f 100644
--- a/src/applications/base/PhabricatorApplication.php
+++ b/src/applications/base/PhabricatorApplication.php
@@ -32,7 +32,7 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
   public abstract function getName();
 
   public function getShortDescription() {
-    return $this->getName().' Application';
+    return pht('%s Application', $this->getName());
   }
 
   public function isInstalled() {
@@ -254,7 +254,7 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
   }
 
   public function getAppEmailBlurb() {
-    throw new Exception('Not Implemented.');
+    throw new PhutilMethodNotImplementedException();
   }
 
 
@@ -371,7 +371,7 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
     }
 
     if (!$selected) {
-      throw new Exception("No application '{$class_name}'!");
+      throw new Exception(pht("No application '%s'!", $class_name));
     }
 
     return $selected;
@@ -531,7 +531,7 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
   private function getCustomCapabilitySpecification($capability) {
     $custom = $this->getCustomCapabilities();
     if (!isset($custom[$capability])) {
-      throw new Exception("Unknown capability '{$capability}'!");
+      throw new Exception(pht("Unknown capability '%s'!", $capability));
     }
     return $custom[$capability];
   }
diff --git a/src/applications/base/controller/PhabricatorController.php b/src/applications/base/controller/PhabricatorController.php
index e2b899ab6e..04bb633d4e 100644
--- a/src/applications/base/controller/PhabricatorController.php
+++ b/src/applications/base/controller/PhabricatorController.php
@@ -316,7 +316,7 @@ abstract class PhabricatorController extends AphrontController {
 
   public function getApplicationURI($path = '') {
     if (!$this->getCurrentApplication()) {
-      throw new Exception('No application!');
+      throw new Exception(pht('No application!'));
     }
     return $this->getCurrentApplication()->getApplicationURI($path);
   }
@@ -388,8 +388,8 @@ abstract class PhabricatorController extends AphrontController {
       if (isset($seen[$hash])) {
         $seen[] = get_class($response);
         throw new Exception(
-          'Cycle while reducing proxy responses: '.
-          implode(' -> ', $seen));
+          pht('Cycle while reducing proxy responses: %s',
+          implode(' -> ', $seen)));
       }
       $seen[$hash] = get_class($response);
 
diff --git a/src/applications/base/controller/__tests__/PhabricatorAccessControlTestCase.php b/src/applications/base/controller/__tests__/PhabricatorAccessControlTestCase.php
index 3791d7462a..560e0c95c4 100644
--- a/src/applications/base/controller/__tests__/PhabricatorAccessControlTestCase.php
+++ b/src/applications/base/controller/__tests__/PhabricatorAccessControlTestCase.php
@@ -63,7 +63,7 @@ final class PhabricatorAccessControlTestCase extends PhabricatorTestCase {
     // Test standard defaults.
 
     $this->checkAccess(
-      'Default',
+      pht('Default'),
       id(clone $controller),
       $request,
       array(
@@ -82,7 +82,7 @@ final class PhabricatorAccessControlTestCase extends PhabricatorTestCase {
 
     $env->overrideEnvConfig('auth.require-email-verification', true);
     $this->checkAccess(
-      'Email Verification Required',
+      pht('Email Verification Required'),
       id(clone $controller),
       $request,
       array(
@@ -97,7 +97,7 @@ final class PhabricatorAccessControlTestCase extends PhabricatorTestCase {
       ));
 
     $this->checkAccess(
-      'Email Verification Required, With Exception',
+      pht('Email Verification Required, With Exception'),
       id(clone $controller)->setConfig('email', false),
       $request,
       array(
@@ -116,7 +116,7 @@ final class PhabricatorAccessControlTestCase extends PhabricatorTestCase {
     // Test admin access.
 
     $this->checkAccess(
-      'Admin Required',
+      pht('Admin Required'),
       id(clone $controller)->setConfig('admin', true),
       $request,
       array(
@@ -134,7 +134,7 @@ final class PhabricatorAccessControlTestCase extends PhabricatorTestCase {
     // Test disabled access.
 
     $this->checkAccess(
-      'Allow Disabled',
+      pht('Allow Disabled'),
       id(clone $controller)->setConfig('enabled', false),
       $request,
       array(
@@ -152,7 +152,7 @@ final class PhabricatorAccessControlTestCase extends PhabricatorTestCase {
     // Test no login required.
 
     $this->checkAccess(
-      'No Login Required',
+      pht('No Login Required'),
       id(clone $controller)->setConfig('login', false),
       $request,
       array(
@@ -170,7 +170,7 @@ final class PhabricatorAccessControlTestCase extends PhabricatorTestCase {
     // Test public access.
 
     $this->checkAccess(
-      'Public Access',
+      pht('Public Access'),
       id(clone $controller)->setConfig('public', true),
       $request,
       array(
@@ -185,7 +185,7 @@ final class PhabricatorAccessControlTestCase extends PhabricatorTestCase {
 
     $env->overrideEnvConfig('policy.allow-public', true);
     $this->checkAccess(
-      'Public + configured',
+      pht('Public + configured'),
       id(clone $controller)->setConfig('public', true),
       $request,
       array(
@@ -210,7 +210,7 @@ final class PhabricatorAccessControlTestCase extends PhabricatorTestCase {
     $app_controller = id(clone $controller)->setCurrentApplication($app);
 
     $this->checkAccess(
-      'Application Controller',
+      pht('Application Controller'),
       $app_controller,
       $request,
       array(
@@ -225,7 +225,7 @@ final class PhabricatorAccessControlTestCase extends PhabricatorTestCase {
       ));
 
     $this->checkAccess(
-      'Application Controller',
+      pht('Application Controller'),
       id(clone $app_controller)->setConfig('login', false),
       $request,
       array(
@@ -259,7 +259,7 @@ final class PhabricatorAccessControlTestCase extends PhabricatorTestCase {
 
       $this->assertTrue(
         ($result === null),
-        "Expect user '{$uname}' to be allowed access to '{$label}'.");
+        pht("Expect user '%s' to be allowed access to '%s'.", $uname, $label));
     }
 
     foreach ($no as $user) {
@@ -274,7 +274,7 @@ final class PhabricatorAccessControlTestCase extends PhabricatorTestCase {
 
       $this->assertFalse(
         ($result === null),
-        "Expect user '{$uname}' to be denied access to '{$label}'.");
+        pht("Expect user '%s' to be denied access to '%s'.", $uname, $label));
     }
   }
 
diff --git a/src/applications/cache/PhabricatorCaches.php b/src/applications/cache/PhabricatorCaches.php
index 4e3af7a6a4..1cddba9fb1 100644
--- a/src/applications/cache/PhabricatorCaches.php
+++ b/src/applications/cache/PhabricatorCaches.php
@@ -332,7 +332,9 @@ final class PhabricatorCaches {
   public static function inflateData($value) {
     if (!function_exists('gzinflate')) {
       throw new Exception(
-        pht('gzinflate() is not available; unable to read deflated data!'));
+        pht(
+          '%s is not available; unable to read deflated data!',
+          'gzinflate()'));
     }
 
     $value = gzinflate($value);
diff --git a/src/applications/cache/PhabricatorKeyValueDatabaseCache.php b/src/applications/cache/PhabricatorKeyValueDatabaseCache.php
index 5bdf60f660..85bc57f8b7 100644
--- a/src/applications/cache/PhabricatorKeyValueDatabaseCache.php
+++ b/src/applications/cache/PhabricatorKeyValueDatabaseCache.php
@@ -136,7 +136,7 @@ final class PhabricatorKeyValueDatabaseCache
 
   private function willWriteValue($key, $value) {
     if (!is_string($value)) {
-      throw new Exception('Only strings may be written to the DB cache!');
+      throw new Exception(pht('Only strings may be written to the DB cache!'));
     }
 
     static $can_deflate;
@@ -162,7 +162,7 @@ final class PhabricatorKeyValueDatabaseCache
       case self::CACHE_FORMAT_DEFLATE:
         return PhabricatorCaches::inflateData($value);
       default:
-        throw new Exception('Unknown cache format.');
+        throw new Exception(pht('Unknown cache format.'));
     }
   }
 
diff --git a/src/applications/cache/management/PhabricatorCacheManagementPurgeWorkflow.php b/src/applications/cache/management/PhabricatorCacheManagementPurgeWorkflow.php
index 2d6de653bc..2523a1e333 100644
--- a/src/applications/cache/management/PhabricatorCacheManagementPurgeWorkflow.php
+++ b/src/applications/cache/management/PhabricatorCacheManagementPurgeWorkflow.php
@@ -6,24 +6,24 @@ final class PhabricatorCacheManagementPurgeWorkflow
   protected function didConstruct() {
     $this
       ->setName('purge')
-      ->setSynopsis('Drop data from caches.')
+      ->setSynopsis(pht('Drop data from caches.'))
       ->setArguments(
         array(
           array(
             'name'    => 'purge-all',
-            'help'    => 'Purge all caches.',
+            'help'    => pht('Purge all caches.'),
           ),
           array(
             'name'    => 'purge-remarkup',
-            'help'    => 'Purge the remarkup cache.',
+            'help'    => pht('Purge the remarkup cache.'),
           ),
           array(
             'name'    => 'purge-changeset',
-            'help'    => 'Purge the Differential changeset cache.',
+            'help'    => pht('Purge the Differential changeset cache.'),
           ),
           array(
             'name'    => 'purge-general',
-            'help'    => 'Purge the general cache.',
+            'help'    => pht('Purge the general cache.'),
           ),
         ));
   }
@@ -46,27 +46,30 @@ final class PhabricatorCacheManagementPurgeWorkflow
       }
 
       throw new PhutilArgumentUsageException(
-        "Specify which cache or caches to purge, or use '--purge-all'. ".
-        "Available caches are: ".implode(', ', $list).". Use '--help' ".
-        "for more information.");
+        pht(
+          "Specify which cache or caches to purge, or use '%s'. Available ".
+          "caches are: %s. Use '%s' for more information.",
+          '--purge-all',
+          implode(', ', $list),
+          '--help'));
     }
 
     if ($purge['remarkup']) {
-      $console->writeOut('Purging remarkup cache...');
+      $console->writeOut(pht('Purging remarkup cache...'));
       $this->purgeRemarkupCache();
-      $console->writeOut("done.\n");
+      $console->writeOut("%s\n", pht('Done.'));
     }
 
     if ($purge['changeset']) {
-      $console->writeOut('Purging changeset cache...');
+      $console->writeOut(pht('Purging changeset cache...'));
       $this->purgeChangesetCache();
-      $console->writeOut("done.\n");
+      $console->writeOut("%s\n", pht('Done.'));
     }
 
     if ($purge['general']) {
-      $console->writeOut('Purging general cache...');
+      $console->writeOut(pht('Purging general cache...'));
       $this->purgeGeneralCache();
-      $console->writeOut("done.\n");
+      $console->writeOut("%s\n", pht('Done.'));
     }
   }
 
diff --git a/src/applications/cache/spec/PhabricatorCacheSpec.php b/src/applications/cache/spec/PhabricatorCacheSpec.php
index 31645ea97f..1688cb07fd 100644
--- a/src/applications/cache/spec/PhabricatorCacheSpec.php
+++ b/src/applications/cache/spec/PhabricatorCacheSpec.php
@@ -96,8 +96,8 @@ abstract class PhabricatorCacheSpec extends Phobject {
     $message = pht(
       'The APC or APCu PHP extensions are installed, but not enabled in your '.
       'PHP configuration. Enabling these extensions will improve Phabricator '.
-      'performance. Edit the "apc.enabled" setting to enable these '.
-      'extensions.');
+      'performance. Edit the "%s" setting to enable these extensions.',
+      'apc.enabled');
 
     return $this
       ->newIssue('extension.apc.enabled')
diff --git a/src/applications/cache/spec/PhabricatorOpcodeCacheSpec.php b/src/applications/cache/spec/PhabricatorOpcodeCacheSpec.php
index dd270fa2a0..c129fb0fa0 100644
--- a/src/applications/cache/spec/PhabricatorOpcodeCacheSpec.php
+++ b/src/applications/cache/spec/PhabricatorOpcodeCacheSpec.php
@@ -35,14 +35,14 @@ final class PhabricatorOpcodeCacheSpec extends PhabricatorCacheSpec {
       $slam_defense = ini_get('apc.slam_defense');
 
       if (!$write_lock || $slam_defense) {
-        $summary = pht(
-          'Adjust APC settings to quiet unnecessary errors.');
+        $summary = pht('Adjust APC settings to quiet unnecessary errors.');
 
         $message = pht(
           'Some versions of APC may emit unnecessary errors into the '.
           'error log under the current APC settings. To resolve this, '.
-          'enable "apc.write_lock" and disable "apc.slam_defense" in '.
-          'your PHP configuration.');
+          'enable "%s" and disable "%s" in your PHP configuration.',
+          'apc.write_lock',
+          'apc.slam_defense');
 
         $this
           ->newIssue('extension.apc.write-lock')
@@ -58,36 +58,40 @@ final class PhabricatorOpcodeCacheSpec extends PhabricatorCacheSpec {
       $is_stat_enabled = ini_get('apc.stat');
       if ($is_stat_enabled && !$is_dev) {
         $summary = pht(
-          '"apc.stat" is currently enabled, but should probably be disabled.');
+          '"%s" is currently enabled, but should probably be disabled.',
+          'apc.stat');
 
         $message = pht(
-          'The "apc.stat" setting is currently enabled in your PHP '.
-          'configuration. In production mode, "apc.stat" should be '.
-          'disabled. This will improve performance slightly.');
+          'The "%s" setting is currently enabled in your PHP configuration. '.
+          'In production mode, "%s" should be disabled. '.
+          'This will improve performance slightly.',
+          'apc.stat',
+          'apc.stat');
 
         $this
           ->newIssue('extension.apc.stat-enabled')
-          ->setShortName(pht('"apc.stat" Enabled'))
-          ->setName(pht('"apc.stat" Enabled in Production'))
+          ->setShortName(pht('"%s" Enabled', 'apc.stat'))
+          ->setName(pht('"%s" Enabled in Production', 'apc.stat'))
           ->setSummary($summary)
           ->setMessage($message)
           ->addPHPConfig('apc.stat')
           ->addPhabricatorConfig('phabricator.developer-mode');
       } else if (!$is_stat_enabled && $is_dev) {
         $summary = pht(
-          '"apc.stat" is currently disabled, but should probably be enabled.');
+          '"%s" is currently disabled, but should probably be enabled.',
+          'apc.stat');
 
         $message = pht(
-          'The "apc.stat" setting is currently disabled in your PHP '.
-          'configuration, but Phabricator is running in development mode. '.
-          'This option should normally be enabled in development so you do '.
-          'not need to restart your webserver after making changes to the '.
-          'code.');
+          'The "%s" setting is currently disabled in your PHP configuration, '.
+          'but Phabricator is running in development mode. This option should '.
+          'normally be enabled in development so you do not need to restart '.
+          'your webserver after making changes to the code.',
+          'apc.stat');
 
         $this
           ->newIssue('extension.apc.stat-disabled')
-          ->setShortName(pht('"apc.stat" Disabled'))
-          ->setName(pht('"apc.stat" Disabled in Development'))
+          ->setShortName(pht('"%s" Disabled', 'apc.stat'))
+          ->setName(pht('"%s" Disabled in Development', 'apc.stat'))
           ->setSummary($summary)
           ->setMessage($message)
           ->addPHPConfig('apc.stat')
@@ -128,8 +132,9 @@ final class PhabricatorOpcodeCacheSpec extends PhabricatorCacheSpec {
         $message = pht(
           'In development, OPcache should be configured to always reload '.
           'code so the webserver does not need to be restarted after making '.
-          'changes. To do this, enable "opcache.validate_timestamps" and '.
-          'set "opcache.revalidate_freq" to 0.');
+          'changes. To do this, enable "%s" and set "%s" to 0.',
+          'opcache.validate_timestamps',
+          'opcache.revalidate_freq');
 
         $this
           ->newIssue('extension.opcache.devmode')
@@ -141,14 +146,13 @@ final class PhabricatorOpcodeCacheSpec extends PhabricatorCacheSpec {
           ->addPHPConfig('opcache.revalidate_freq')
           ->addPhabricatorConfig('phabricator.developer-mode');
       } else if (!$is_dev && $validate) {
-        $summary = pht(
-          'OPcache is not configured ideally for production.');
+        $summary = pht('OPcache is not configured ideally for production.');
 
         $message = pht(
           'In production, OPcache should be configured to never '.
           'revalidate code. This will slightly improve performance. '.
-          'To do this, disable "opcache.validate_timestamps" in your PHP '.
-          'configuration.');
+          'To do this, disable "%s" in your PHP configuration.',
+          'opcache.validate_timestamps');
 
         $this
           ->newIssue('extension.opcache.production')
@@ -166,8 +170,9 @@ final class PhabricatorOpcodeCacheSpec extends PhabricatorCacheSpec {
       $message = pht(
         'The PHP "Zend OPcache" extension is installed, but not enabled in '.
         'your PHP configuration. Enabling it will dramatically improve '.
-        'Phabricator performance. Edit the "opcache.enable" setting to '.
-        'enable the extension.');
+        'Phabricator performance. Edit the "%s" setting to '.
+        'enable the extension.',
+        'opcache.enable');
 
       $this->newIssue('extension.opcache.enable')
         ->setShortName(pht('OPcache Disabled'))
diff --git a/src/applications/calendar/mail/PhabricatorCalendarReplyHandler.php b/src/applications/calendar/mail/PhabricatorCalendarReplyHandler.php
index 1d60e1294d..23639f1b89 100644
--- a/src/applications/calendar/mail/PhabricatorCalendarReplyHandler.php
+++ b/src/applications/calendar/mail/PhabricatorCalendarReplyHandler.php
@@ -5,7 +5,10 @@ final class PhabricatorCalendarReplyHandler
 
   public function validateMailReceiver($mail_receiver) {
     if (!($mail_receiver instanceof PhabricatorCalendarEvent)) {
-      throw new Exception('Mail receiver is not a PhabricatorCalendarEvent!');
+      throw new Exception(
+        pht(
+          'Mail receiver is not a %s!',
+          'PhabricatorCalendarEvent'));
     }
   }
 
diff --git a/src/applications/calendar/storage/__tests__/PhabricatorCalendarHolidayTestCase.php b/src/applications/calendar/storage/__tests__/PhabricatorCalendarHolidayTestCase.php
index 40ec7f0aac..3e92a19583 100644
--- a/src/applications/calendar/storage/__tests__/PhabricatorCalendarHolidayTestCase.php
+++ b/src/applications/calendar/storage/__tests__/PhabricatorCalendarHolidayTestCase.php
@@ -12,7 +12,7 @@ final class PhabricatorCalendarHolidayTestCase extends PhabricatorTestCase {
     parent::willRunTests();
     id(new PhabricatorCalendarHoliday())
       ->setDay('2012-01-02')
-      ->setName('International Testing Day')
+      ->setName(pht('International Testing Day'))
       ->save();
   }
 
@@ -32,7 +32,7 @@ final class PhabricatorCalendarHolidayTestCase extends PhabricatorTestCase {
       $this->assertEqual(
         $expect,
         date('Y-m-d', $actual),
-        "{$n} business days since '{$date}'");
+        pht("%d business days since '%s'", $n, $date));
     }
   }
 
diff --git a/src/applications/calendar/view/AphrontCalendarEventView.php b/src/applications/calendar/view/AphrontCalendarEventView.php
index eb80a3ce49..fadf5eb889 100644
--- a/src/applications/calendar/view/AphrontCalendarEventView.php
+++ b/src/applications/calendar/view/AphrontCalendarEventView.php
@@ -107,7 +107,7 @@ final class AphrontCalendarEventView extends AphrontView {
   }
 
   public function render() {
-    throw new Exception('Events are only rendered indirectly.');
+    throw new Exception(pht('Events are only rendered indirectly.'));
   }
 
 }
diff --git a/src/applications/celerity/CelerityResourceMap.php b/src/applications/celerity/CelerityResourceMap.php
index 5b0c374dab..7e5e00594b 100644
--- a/src/applications/celerity/CelerityResourceMap.php
+++ b/src/applications/celerity/CelerityResourceMap.php
@@ -43,7 +43,8 @@ final class CelerityResourceMap {
       if (empty($resources_list[$name])) {
         throw new Exception(
           pht(
-            'No resource source exists with name "%s"!', $name));
+            'No resource source exists with name "%s"!',
+            $name));
       }
 
       $instance = new CelerityResourceMap($resources_list[$name]);
diff --git a/src/applications/celerity/CelerityResourceMapGenerator.php b/src/applications/celerity/CelerityResourceMapGenerator.php
index 36092e497e..b9c4ddaa37 100644
--- a/src/applications/celerity/CelerityResourceMapGenerator.php
+++ b/src/applications/celerity/CelerityResourceMapGenerator.php
@@ -244,7 +244,10 @@ EOFILE;
 
     if (count($provides) > 1) {
       throw new Exception(
-        pht('Resource "%s" must @provide at most one Celerity target.', $name));
+        pht(
+          'Resource "%s" must %s at most one Celerity target.',
+          $name,
+          '@provide'));
     }
 
     return array(head($provides), $requires);
@@ -268,7 +271,9 @@ EOFILE;
       $cycle = $graph->detectCycles($provides);
       if ($cycle) {
         throw new Exception(
-          pht('Cycle detected in resource graph: %s', implode(' > ', $cycle)));
+          pht(
+            'Cycle detected in resource graph: %s',
+            implode(' > ', $cycle)));
       }
     }
   }
@@ -298,9 +303,10 @@ EOFILE;
           throw new Exception(
             pht(
               'Package specification for "%s" includes "%s", but that symbol '.
-              'is not @provided by any resource.',
+              'is not %s by any resource.',
               $package_name,
-              $symbol));
+              $symbol,
+              '@provided'));
         }
 
         $resource_name = $reverse_map[$symbol_hash];
diff --git a/src/applications/celerity/CelerityResourceTransformer.php b/src/applications/celerity/CelerityResourceTransformer.php
index 72880c8ce3..ebfae6a8d6 100644
--- a/src/applications/celerity/CelerityResourceTransformer.php
+++ b/src/applications/celerity/CelerityResourceTransformer.php
@@ -332,7 +332,10 @@ final class CelerityResourceTransformer {
     if (empty($map[$var_name])) {
       $path = $this->currentPath;
       throw new Exception(
-        "CSS file '{$path}' has unknown variable '{$var_name}'.");
+        pht(
+          "CSS file '%s' has unknown variable '%s'.",
+          $path,
+          $var_name));
     }
 
     return $map[$var_name];
diff --git a/src/applications/celerity/CeleritySpriteGenerator.php b/src/applications/celerity/CeleritySpriteGenerator.php
index a42fbfa4db..e25e1050a6 100644
--- a/src/applications/celerity/CeleritySpriteGenerator.php
+++ b/src/applications/celerity/CeleritySpriteGenerator.php
@@ -223,8 +223,11 @@ final class CeleritySpriteGenerator {
     foreach ($images as $image) {
       if (!preg_match('/\.png$/', $image)) {
         throw new Exception(
-          "Expected file '{$image}' in '{$path}' to be a sprite source ".
-          "ending in '.png'.");
+          pht(
+            "Expected file '%s' in '%s' to be a sprite source ending in '%s'.",
+            $image,
+            $path,
+            '.png'));
       }
       $result[] = substr($image, 0, -4);
     }
diff --git a/src/applications/celerity/CelerityStaticResourceResponse.php b/src/applications/celerity/CelerityStaticResourceResponse.php
index 7864515e11..cfb586602e 100644
--- a/src/applications/celerity/CelerityStaticResourceResponse.php
+++ b/src/applications/celerity/CelerityStaticResourceResponse.php
@@ -244,10 +244,15 @@ final class CelerityStaticResourceResponse {
   public static function renderInlineScript($data) {
     if (stripos($data, '</script>') !== false) {
       throw new Exception(
-        'Literal </script> is not allowed inside inline script.');
+        pht(
+          'Literal %s is not allowed inside inline script.',
+          '</script>'));
     }
     if (strpos($data, '<!') !== false) {
-      throw new Exception('Literal <! is not allowed inside inline script.');
+      throw new Exception(
+        pht(
+          'Literal %s is not allowed inside inline script.',
+          '<!'));
     }
     // We don't use <![CDATA[ ]]> because it is ignored by HTML parsers. We
     // would need to send the document with XHTML content type.
diff --git a/src/applications/celerity/controller/CelerityResourceController.php b/src/applications/celerity/controller/CelerityResourceController.php
index c91f9297c4..717e20f9f9 100644
--- a/src/applications/celerity/controller/CelerityResourceController.php
+++ b/src/applications/celerity/controller/CelerityResourceController.php
@@ -35,7 +35,7 @@ abstract class CelerityResourceController extends PhabricatorController {
     $type_map = self::getSupportedResourceTypes();
 
     if (empty($type_map[$type])) {
-      throw new Exception('Only static resources may be served.');
+      throw new Exception(pht('Only static resources may be served.'));
     }
 
     $dev_mode = PhabricatorEnv::getEnvConfig('phabricator.developer-mode');
diff --git a/src/applications/chatlog/conduit/ChatLogQueryConduitAPIMethod.php b/src/applications/chatlog/conduit/ChatLogQueryConduitAPIMethod.php
index 8270ced921..434a4671e6 100644
--- a/src/applications/chatlog/conduit/ChatLogQueryConduitAPIMethod.php
+++ b/src/applications/chatlog/conduit/ChatLogQueryConduitAPIMethod.php
@@ -11,7 +11,7 @@ final class ChatLogQueryConduitAPIMethod extends ChatLogConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Retrieve chatter.';
+    return pht('Retrieve chatter.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/chatlog/conduit/ChatLogRecordConduitAPIMethod.php b/src/applications/chatlog/conduit/ChatLogRecordConduitAPIMethod.php
index ca94b91dcc..fe972222ae 100644
--- a/src/applications/chatlog/conduit/ChatLogRecordConduitAPIMethod.php
+++ b/src/applications/chatlog/conduit/ChatLogRecordConduitAPIMethod.php
@@ -11,7 +11,7 @@ final class ChatLogRecordConduitAPIMethod extends ChatLogConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Record chatter.';
+    return pht('Record chatter.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/chatlog/controller/PhabricatorChatLogChannelListController.php b/src/applications/chatlog/controller/PhabricatorChatLogChannelListController.php
index c557b2bc2f..3b4892bfe8 100644
--- a/src/applications/chatlog/controller/PhabricatorChatLogChannelListController.php
+++ b/src/applications/chatlog/controller/PhabricatorChatLogChannelListController.php
@@ -12,8 +12,8 @@ final class PhabricatorChatLogChannelListController
     $user = $request->getUser();
 
     $channels = id(new PhabricatorChatLogChannelQuery())
-                ->setViewer($user)
-                ->execute();
+      ->setViewer($user)
+      ->execute();
 
     $list = new PHUIObjectItemListView();
     foreach ($channels as $channel) {
diff --git a/src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php b/src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php
index c7d2dc990e..327024562a 100644
--- a/src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php
+++ b/src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php
@@ -29,9 +29,9 @@ final class PhabricatorChatLogChannelLogController
       ->withChannelIDs(array($this->channelID));
 
     $channel = id(new PhabricatorChatLogChannelQuery())
-              ->setViewer($user)
-              ->withIDs(array($this->channelID))
-              ->executeOne();
+      ->setViewer($user)
+      ->withIDs(array($this->channelID))
+      ->executeOne();
 
     if (!$channel) {
       return new Aphront404Response();
diff --git a/src/applications/conduit/call/__tests__/ConduitCallTestCase.php b/src/applications/conduit/call/__tests__/ConduitCallTestCase.php
index a5cc190d68..b62ddcef1a 100644
--- a/src/applications/conduit/call/__tests__/ConduitCallTestCase.php
+++ b/src/applications/conduit/call/__tests__/ConduitCallTestCase.php
@@ -21,6 +21,8 @@ final class ConduitCallTestCase extends PhabricatorTestCase {
 
     $this->assertTrue(
       ($caught instanceof ConduitException),
-      'user.whoami should require authentication');
+      pht(
+        '%s should require authentication.',
+        'user.whoami'));
   }
 }
diff --git a/src/applications/conduit/controller/PhabricatorConduitAPIController.php b/src/applications/conduit/controller/PhabricatorConduitAPIController.php
index cdc14da27d..cee47949d2 100644
--- a/src/applications/conduit/controller/PhabricatorConduitAPIController.php
+++ b/src/applications/conduit/controller/PhabricatorConduitAPIController.php
@@ -176,11 +176,14 @@ final class PhabricatorConduitAPIController
 
     $config_key = 'security.allow-conduit-act-as-user';
     if (!PhabricatorEnv::getEnvConfig($config_key)) {
-      throw new Exception('security.allow-conduit-act-as-user is disabled');
+      throw new Exception(pht('%s is disabled.', $config_key));
     }
 
     if (!$api_request->getUser()->getIsAdmin()) {
-      throw new Exception('Only administrators can use actAsUser');
+      throw new Exception(
+        pht(
+          'Only administrators can use %s.',
+          __FUNCTION__));
     }
 
     $user = id(new PhabricatorUser())->loadOneWhere(
@@ -189,8 +192,10 @@ final class PhabricatorConduitAPIController
 
     if (!$user) {
       throw new Exception(
-        "The actAsUser username '{$user_name}' is not a valid user."
-      );
+        pht(
+          "The %s username '%s' is not a valid user.",
+          __FUNCTION__,
+          $user_name));
     }
 
     $api_request->setUser($user);
@@ -224,7 +229,8 @@ final class PhabricatorConduitAPIController
         return array(
           'ERR-INVALID-AUTH',
           pht(
-            'Request is missing required "auth.host" parameter.'),
+            'Request is missing required "%s" parameter.',
+            'auth.host'),
         );
       }
 
@@ -266,8 +272,7 @@ final class PhabricatorConduitAPIController
       if (!$stored_key) {
         return array(
           'ERR-INVALID-AUTH',
-          pht(
-            'No user or device is associated with that public key.'),
+          pht('No user or device is associated with that public key.'),
         );
       }
 
@@ -311,7 +316,8 @@ final class PhabricatorConduitAPIController
       return array(
         'ERR-INVALID-AUTH',
         pht(
-          'Provided "auth.type" ("%s") is not recognized.',
+          'Provided "%s" ("%s") is not recognized.',
+          'auth.type',
           $auth_type),
       );
     }
@@ -405,8 +411,7 @@ final class PhabricatorConduitAPIController
       if (!($user instanceof PhabricatorUser)) {
         return array(
           'ERR-INVALID-AUTH',
-          pht(
-            'API token is not associated with a valid user.'),
+          pht('API token is not associated with a valid user.'),
         );
       }
 
@@ -421,12 +426,11 @@ final class PhabricatorConduitAPIController
     if ($access_token &&
         $method_scope != PhabricatorOAuthServerScope::SCOPE_NOT_ACCESSIBLE) {
       $token = id(new PhabricatorOAuthServerAccessToken())
-        ->loadOneWhere('token = %s',
-                       $access_token);
+        ->loadOneWhere('token = %s', $access_token);
       if (!$token) {
         return array(
           'ERR-INVALID-AUTH',
-          'Access token does not exist.',
+          pht('Access token does not exist.'),
         );
       }
 
@@ -436,19 +440,18 @@ final class PhabricatorConduitAPIController
       if (!$valid) {
         return array(
           'ERR-INVALID-AUTH',
-          'Access token is invalid.',
+          pht('Access token is invalid.'),
         );
       }
 
       // valid token, so let's log in the user!
       $user_phid = $token->getUserPHID();
       $user = id(new PhabricatorUser())
-        ->loadOneWhere('phid = %s',
-                       $user_phid);
+        ->loadOneWhere('phid = %s', $user_phid);
       if (!$user) {
         return array(
           'ERR-INVALID-AUTH',
-          'Access token is for invalid user.',
+          pht('Access token is for invalid user.'),
         );
       }
       return $this->validateAuthenticatedUser(
@@ -467,7 +470,7 @@ final class PhabricatorConduitAPIController
       if (!$user) {
         return array(
           'ERR-INVALID-AUTH',
-          'Authentication is invalid.',
+          pht('Authentication is invalid.'),
         );
       }
       $token = idx($metadata, 'authToken');
@@ -476,7 +479,7 @@ final class PhabricatorConduitAPIController
       if (sha1($token.$certificate) !== $signature) {
         return array(
           'ERR-INVALID-AUTH',
-          'Authentication is invalid.',
+          pht('Authentication is invalid.'),
         );
       }
       return $this->validateAuthenticatedUser(
@@ -491,7 +494,7 @@ final class PhabricatorConduitAPIController
     if (!$session_key) {
       return array(
         'ERR-INVALID-SESSION',
-        'Session key is not present.',
+        pht('Session key is not present.'),
       );
     }
 
@@ -501,7 +504,7 @@ final class PhabricatorConduitAPIController
     if (!$user) {
       return array(
         'ERR-INVALID-SESSION',
-        'Session key is invalid.',
+        pht('Session key is invalid.'),
       );
     }
 
@@ -642,10 +645,13 @@ final class PhabricatorConduitAPIController
           // actually do type checking, it might be reasonable to treat it as
           // a string if the parameter type is string.
           throw new Exception(
-            "The value for parameter '{$key}' is not valid JSON. All ".
-            "parameters must be encoded as JSON values, including strings ".
-            "(which means you need to surround them in double quotes). ".
-            "Check your syntax. Value was: {$value}");
+            pht(
+              "The value for parameter '%s' is not valid JSON. All ".
+              "parameters must be encoded as JSON values, including strings ".
+              "(which means you need to surround them in double quotes). ".
+              "Check your syntax. Value was: %s.",
+              $key,
+              $value));
         }
         $params[$key] = $decoded_value;
       }
@@ -666,7 +672,7 @@ final class PhabricatorConduitAPIController
       } catch (PhutilJSONParserException $ex) {
         throw new PhutilProxyException(
           pht(
-            "Invalid parameter information was passed to method '%s'",
+            "Invalid parameter information was passed to method '%s'.",
             $method),
           $ex);
       }
diff --git a/src/applications/conduit/controller/PhabricatorConduitConsoleController.php b/src/applications/conduit/controller/PhabricatorConduitConsoleController.php
index 5c0ccfe6fb..73e32b49f3 100644
--- a/src/applications/conduit/controller/PhabricatorConduitConsoleController.php
+++ b/src/applications/conduit/controller/PhabricatorConduitConsoleController.php
@@ -46,7 +46,8 @@ final class PhabricatorConduitConsoleController
       ->appendRemarkupInstructions(
         pht(
           'Enter parameters using **JSON**. For instance, to enter a '.
-          'list, type: `["apple", "banana", "cherry"]`'));
+          'list, type: `%s`',
+          '["apple", "banana", "cherry"]'));
 
     $params = $method->getParamTypes();
     foreach ($params as $param => $desc) {
@@ -67,12 +68,12 @@ final class PhabricatorConduitConsoleController
       $form
         ->appendChild(
           id(new AphrontFormSelectControl())
-            ->setLabel('Output Format')
+            ->setLabel(pht('Output Format'))
             ->setName('output')
             ->setOptions(
               array(
-                'human' => 'Human Readable',
-                'json'  => 'JSON',
+                'human' => pht('Human Readable'),
+                'json'  => pht('JSON'),
               )))
         ->appendChild(
           id(new AphrontFormSubmitControl())
diff --git a/src/applications/conduit/controller/PhabricatorConduitLogController.php b/src/applications/conduit/controller/PhabricatorConduitLogController.php
index d8da592372..2effa1815b 100644
--- a/src/applications/conduit/controller/PhabricatorConduitLogController.php
+++ b/src/applications/conduit/controller/PhabricatorConduitLogController.php
@@ -69,7 +69,7 @@ final class PhabricatorConduitLogController
       $conn = idx($conns, $call->getConnectionID());
       if ($conn) {
         $name = $conn->getUserName();
-        $client = ' (via '.$conn->getClient().')';
+        $client = ' '.pht('(via %s)', $conn->getClient());
       } else {
         $name = null;
         $client = null;
@@ -98,7 +98,7 @@ final class PhabricatorConduitLogController
         array($call->getMethod(), $client),
         $status,
         $call->getError(),
-        number_format($call->getDuration()).' us',
+        pht('%d us', number_format($call->getDuration())),
         phabricator_datetime($call->getDateCreated(), $viewer),
       );
     }
diff --git a/src/applications/conduit/method/ConduitAPIMethod.php b/src/applications/conduit/method/ConduitAPIMethod.php
index f6d464cfc5..0643ca72d1 100644
--- a/src/applications/conduit/method/ConduitAPIMethod.php
+++ b/src/applications/conduit/method/ConduitAPIMethod.php
@@ -78,7 +78,7 @@ abstract class ConduitAPIMethod
   }
 
   public function getErrorDescription($error_code) {
-    return idx($this->getErrorTypes(), $error_code, 'Unknown Error');
+    return idx($this->getErrorTypes(), $error_code, pht('Unknown Error'));
   }
 
   public function getRequiredScope() {
@@ -134,9 +134,12 @@ abstract class ConduitAPIMethod
         $orig_class = get_class($method_map[$name]);
         $this_class = get_class($method);
         throw new Exception(
-          "Two Conduit API method classes ({$orig_class}, {$this_class}) ".
-          "both have the same method name ({$name}). API methods ".
-          "must have unique method names.");
+          pht(
+            'Two Conduit API method classes (%s, %s) both have the same '.
+            'method name (%s). API methods must have unique method names.',
+            $orig_class,
+            $this_class,
+            $name));
       }
     }
 
diff --git a/src/applications/conduit/method/ConduitConnectConduitAPIMethod.php b/src/applications/conduit/method/ConduitConnectConduitAPIMethod.php
index 12f08f8636..a6ec09ae09 100644
--- a/src/applications/conduit/method/ConduitConnectConduitAPIMethod.php
+++ b/src/applications/conduit/method/ConduitConnectConduitAPIMethod.php
@@ -15,7 +15,7 @@ final class ConduitConnectConduitAPIMethod extends ConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Connect a session-based client.';
+    return pht('Connect a session-based client.');
   }
 
   protected function defineParamTypes() {
@@ -36,22 +36,21 @@ final class ConduitConnectConduitAPIMethod extends ConduitAPIMethod {
 
   protected function defineErrorTypes() {
     return array(
-      'ERR-BAD-VERSION' =>
+      'ERR-BAD-VERSION' => pht(
         'Client/server version mismatch. Upgrade your server or downgrade '.
-        'your client.',
-      'NEW-ARC-VERSION' =>
-        'Client/server version mismatch. Upgrade your client.',
-      'ERR-UNKNOWN-CLIENT' =>
-        'Client is unknown.',
-      'ERR-INVALID-USER' =>
-        'The username you are attempting to authenticate with is not valid.',
-      'ERR-INVALID-CERTIFICATE' =>
-        'Your authentication certificate for this server is invalid.',
-      'ERR-INVALID-TOKEN' =>
+        'your client.'),
+      'NEW-ARC-VERSION' => pht(
+        'Client/server version mismatch. Upgrade your client.'),
+      'ERR-UNKNOWN-CLIENT' => pht('Client is unknown.'),
+      'ERR-INVALID-USER' => pht(
+        'The username you are attempting to authenticate with is not valid.'),
+      'ERR-INVALID-CERTIFICATE' => pht(
+        'Your authentication certificate for this server is invalid.'),
+      'ERR-INVALID-TOKEN' => pht(
         "The challenge token you are authenticating with is outside of the ".
         "allowed time range. Either your system clock is out of whack or ".
-        "you're executing a replay attack.",
-      'ERR-NO-CERTIFICATE' => 'This server requires authentication.',
+        "you're executing a replay attack."),
+      'ERR-NO-CERTIFICATE' => pht('This server requires authentication.'),
     );
   }
 
@@ -87,16 +86,21 @@ final class ConduitConnectConduitAPIMethod extends ConduitAPIMethod {
           if ($server_version < $client_version) {
             $ex = new ConduitException('ERR-BAD-VERSION');
             $ex->setErrorDescription(
-              "Your 'arc' client version is '{$client_version}', which ".
-              "is newer than the server version, '{$server_version}'. ".
-              "Upgrade your Phabricator install.");
+              pht(
+                "Your '%s' client version is '%d', which is newer than the ".
+                "server version, '%d'. Upgrade your Phabricator install.",
+                'arc',
+                $client_version,
+                $server_version));
           } else {
             $ex = new ConduitException('NEW-ARC-VERSION');
             $ex->setErrorDescription(
-              "A new version of arc is available! You need to upgrade ".
-              "to connect to this server (you are running version ".
-              "{$client_version}, the server is running version ".
-              "{$server_version}).");
+              pht(
+                'A new version of arc is available! You need to upgrade '.
+                'to connect to this server (you are running version '.
+                '%d, the server is running version %d).',
+                $client_version,
+                $server_version));
           }
           throw $ex;
         }
diff --git a/src/applications/conduit/method/ConduitGetCertificateConduitAPIMethod.php b/src/applications/conduit/method/ConduitGetCertificateConduitAPIMethod.php
index be14610796..6248b5a6ba 100644
--- a/src/applications/conduit/method/ConduitGetCertificateConduitAPIMethod.php
+++ b/src/applications/conduit/method/ConduitGetCertificateConduitAPIMethod.php
@@ -16,7 +16,7 @@ final class ConduitGetCertificateConduitAPIMethod extends ConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Retrieve certificate information for a user.';
+    return pht('Retrieve certificate information for a user.');
   }
 
   protected function defineParamTypes() {
@@ -32,10 +32,10 @@ final class ConduitGetCertificateConduitAPIMethod extends ConduitAPIMethod {
 
   protected function defineErrorTypes() {
     return array(
-      'ERR-BAD-TOKEN' => 'Token does not exist or has expired.',
-      'ERR-RATE-LIMIT' =>
+      'ERR-BAD-TOKEN' => pht('Token does not exist or has expired.'),
+      'ERR-RATE-LIMIT' => pht(
         'You have made too many invalid token requests recently. Wait before '.
-        'making more.',
+        'making more.'),
     );
   }
 
@@ -69,7 +69,7 @@ final class ConduitGetCertificateConduitAPIMethod extends ConduitAPIMethod {
       'phid = %s',
       $info->getUserPHID());
     if (!$user) {
-      throw new Exception('Certificate token points to an invalid user!');
+      throw new Exception(pht('Certificate token points to an invalid user!'));
     }
 
     return array(
diff --git a/src/applications/conduit/method/ConduitPingConduitAPIMethod.php b/src/applications/conduit/method/ConduitPingConduitAPIMethod.php
index f3c502defa..9e0c1d4ff5 100644
--- a/src/applications/conduit/method/ConduitPingConduitAPIMethod.php
+++ b/src/applications/conduit/method/ConduitPingConduitAPIMethod.php
@@ -11,7 +11,7 @@ final class ConduitPingConduitAPIMethod extends ConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Basic ping for monitoring or a health-check.';
+    return pht('Basic ping for monitoring or a health-check.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/conduit/method/ConduitQueryConduitAPIMethod.php b/src/applications/conduit/method/ConduitQueryConduitAPIMethod.php
index f5162a04fc..6cd9283b4c 100644
--- a/src/applications/conduit/method/ConduitQueryConduitAPIMethod.php
+++ b/src/applications/conduit/method/ConduitQueryConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class ConduitQueryConduitAPIMethod extends ConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Returns the parameters of the Conduit methods.';
+    return pht('Returns the parameters of the Conduit methods.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/conduit/protocol/ConduitAPIRequest.php b/src/applications/conduit/protocol/ConduitAPIRequest.php
index 7e5a8ae515..fe8af34b65 100644
--- a/src/applications/conduit/protocol/ConduitAPIRequest.php
+++ b/src/applications/conduit/protocol/ConduitAPIRequest.php
@@ -36,9 +36,10 @@ final class ConduitAPIRequest {
   public function getUser() {
     if (!$this->user) {
       throw new Exception(
-        'You can not access the user inside the implementation of a Conduit '.
-        'method which does not require authentication (as per '.
-        'shouldRequireAuthentication()).');
+        pht(
+          'You can not access the user inside the implementation of a Conduit '.
+          'method which does not require authentication (as per %s).',
+          'shouldRequireAuthentication()'));
     }
     return $this->user;
   }
diff --git a/src/applications/conduit/query/PhabricatorConduitSearchEngine.php b/src/applications/conduit/query/PhabricatorConduitSearchEngine.php
index 0ed7a95b44..eece3e5c17 100644
--- a/src/applications/conduit/query/PhabricatorConduitSearchEngine.php
+++ b/src/applications/conduit/query/PhabricatorConduitSearchEngine.php
@@ -58,7 +58,7 @@ final class PhabricatorConduitSearchEngine
     $form
       ->appendChild(
         id(new AphrontFormTextControl())
-          ->setLabel('Name Contains')
+          ->setLabel(pht('Name Contains'))
           ->setName('nameContains')
           ->setValue($saved->getParameter('nameContains')));
 
@@ -66,12 +66,13 @@ final class PhabricatorConduitSearchEngine
     $form
       ->appendChild(
         id(new AphrontFormTextControl())
-          ->setLabel('Applications')
+          ->setLabel(pht('Applications'))
           ->setName('applicationNames')
           ->setValue(implode(', ', $names))
-          ->setCaption(pht(
-            'Example: %s',
-            phutil_tag('tt', array(), 'differential, paste'))));
+          ->setCaption(
+            pht(
+              'Example: %s',
+              phutil_tag('tt', array(), 'differential, paste'))));
 
     $is_stable = $saved->getParameter('isStable');
     $is_unstable = $saved->getParameter('isUnstable');
diff --git a/src/applications/conduit/ssh/ConduitSSHWorkflow.php b/src/applications/conduit/ssh/ConduitSSHWorkflow.php
index aed7004d7e..6589fac324 100644
--- a/src/applications/conduit/ssh/ConduitSSHWorkflow.php
+++ b/src/applications/conduit/ssh/ConduitSSHWorkflow.php
@@ -18,9 +18,9 @@ final class ConduitSSHWorkflow extends PhabricatorSSHWorkflow {
 
     $methodv = $args->getArg('method');
     if (!$methodv) {
-      throw new Exception('No Conduit method provided.');
+      throw new Exception(pht('No Conduit method provided.'));
     } else if (count($methodv) > 1) {
-      throw new Exception('Too many Conduit methods provided.');
+      throw new Exception(pht('Too many Conduit methods provided.'));
     }
 
     $method = head($methodv);
diff --git a/src/applications/config/check/PhabricatorAuthSetupCheck.php b/src/applications/config/check/PhabricatorAuthSetupCheck.php
index 5d4f731867..0295a85b2d 100644
--- a/src/applications/config/check/PhabricatorAuthSetupCheck.php
+++ b/src/applications/config/check/PhabricatorAuthSetupCheck.php
@@ -27,13 +27,8 @@ final class PhabricatorAuthSetupCheck extends PhabricatorSetupCheck {
         'You have not configured any authentication providers yet. You '.
         'should add a provider (like username/password, LDAP, or GitHub '.
         'OAuth) so users can register and log in. You can add and configure '.
-        'providers %s.',
-        phutil_tag(
-          'a',
-          array(
-            'href' => '/auth/',
-          ),
-          pht('using the "Auth" application')));
+        'providers using the [[%s | "Auth" application]].',
+        '/auth/');
 
       $this
         ->newIssue('auth.noproviders')
diff --git a/src/applications/config/check/PhabricatorBinariesSetupCheck.php b/src/applications/config/check/PhabricatorBinariesSetupCheck.php
index 87887d4a96..59dc3a78ab 100644
--- a/src/applications/config/check/PhabricatorBinariesSetupCheck.php
+++ b/src/applications/config/check/PhabricatorBinariesSetupCheck.php
@@ -7,7 +7,6 @@ final class PhabricatorBinariesSetupCheck extends PhabricatorSetupCheck {
   }
 
   protected function executeChecks() {
-
     if (phutil_is_windows()) {
       $bin_name = 'where';
     } else {
@@ -28,8 +27,9 @@ final class PhabricatorBinariesSetupCheck extends PhabricatorSetupCheck {
 
     if (!Filesystem::binaryExists('diff')) {
       $message = pht(
-        "Without 'diff', Phabricator will not be able to generate or render ".
-        "diffs in multiple applications.");
+        "Without '%s', Phabricator will not be able to generate or render ".
+        "diffs in multiple applications.",
+        'diff');
       $this->raiseWarning('diff', $message);
     } else {
       $tmp_a = new TempFile();
@@ -43,12 +43,13 @@ final class PhabricatorBinariesSetupCheck extends PhabricatorSetupCheck {
       list($err) = exec_manual('diff %s %s', $tmp_a, $tmp_b);
       if ($err) {
         $this->newIssue('bin.diff.same')
-          ->setName(pht("Unexpected 'diff' Behavior"))
+          ->setName(pht("Unexpected '%s' Behavior", 'diff'))
           ->setMessage(
             pht(
-              "The 'diff' binary on this system has unexpected behavior: ".
+              "The '%s' binary on this system has unexpected behavior: ".
               "it was expected to exit without an error code when passed ".
               "identical files, but exited with code %d.",
+              'diff',
               $err));
       }
 
@@ -58,9 +59,10 @@ final class PhabricatorBinariesSetupCheck extends PhabricatorSetupCheck {
           ->setName(pht("Unexpected 'diff' Behavior"))
           ->setMessage(
             pht(
-              "The 'diff' binary on this system has unexpected behavior: ".
+              "The '%s' binary on this system has unexpected behavior: ".
               "it was expected to exit with a nonzero error code when passed ".
-              "differing files, but did not."));
+              "differing files, but did not.",
+              'diff'));
       }
     }
 
@@ -249,7 +251,6 @@ final class PhabricatorBinariesSetupCheck extends PhabricatorSetupCheck {
   }
 
   private function raiseBadVersionWarning($binary, $bad_version) {
-
     switch ($binary) {
       case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
         break;
diff --git a/src/applications/config/check/PhabricatorDaemonsSetupCheck.php b/src/applications/config/check/PhabricatorDaemonsSetupCheck.php
index a6b9ef8488..3b4b335134 100644
--- a/src/applications/config/check/PhabricatorDaemonsSetupCheck.php
+++ b/src/applications/config/check/PhabricatorDaemonsSetupCheck.php
@@ -16,8 +16,7 @@ final class PhabricatorDaemonsSetupCheck extends PhabricatorSetupCheck {
       ->execute();
 
     if (!$task_daemon) {
-      $doc_href = PhabricatorEnv::getDocLink(
-        'Managing Daemons with phd');
+      $doc_href = PhabricatorEnv::getDocLink('Managing Daemons with phd');
 
       $summary = pht(
         'You must start the Phabricator daemons to send email, rebuild '.
@@ -57,24 +56,29 @@ final class PhabricatorDaemonsSetupCheck extends PhabricatorSetupCheck {
 
       if ($phd_user) {
         if ($daemon->getRunningAsUser() != $phd_user) {
-          $doc_href = PhabricatorEnv::getDocLink(
-            'Managing Daemons with phd');
+          $doc_href = PhabricatorEnv::getDocLink('Managing Daemons with phd');
 
           $summary = pht(
             'At least one daemon is currently running as a different '.
-            'user than configured in the Phabricator phd.user setting');
+            'user than configured in the Phabricator %s setting',
+            'phd.user');
 
           $message = pht(
             'A daemon is running as user %s while the Phabricator config '.
-            'specifies phd.user to be %s.'.
+            'specifies %s to be %s.'.
             "\n\n".
-            'Either adjust phd.user to match %s or start '.
+            'Either adjust %s to match %s or start '.
             'the daemons as the correct user. '.
             "\n\n".
-            'phd Daemons will try to '.
-            'use sudo to start as the configured user. '.
-            'Make sure that the user who starts phd has the correct '.
-            'sudo permissions to start phd daemons as %s',
+            '%s Daemons will try to use %s to start as the configured user. '.
+            'Make sure that the user who starts %s has the correct '.
+            'sudo permissions to start %s daemons as %s',
+            'phd.user',
+            'phd.user',
+            'phd',
+            'sudo',
+            'phd',
+            'phd',
             phutil_tag('tt', array(), $daemon->getRunningAsUser()),
             phutil_tag('tt', array(), $phd_user),
             phutil_tag('tt', array(), $daemon->getRunningAsUser()),
diff --git a/src/applications/config/check/PhabricatorDatabaseSetupCheck.php b/src/applications/config/check/PhabricatorDatabaseSetupCheck.php
index 3f7af1bdb4..4ee0a75c6f 100644
--- a/src/applications/config/check/PhabricatorDatabaseSetupCheck.php
+++ b/src/applications/config/check/PhabricatorDatabaseSetupCheck.php
@@ -79,8 +79,8 @@ final class PhabricatorDatabaseSetupCheck extends PhabricatorSetupCheck {
 
     if (empty($databases[$namespace.'_meta_data'])) {
       $message = pht(
-        'Run the storage upgrade script to setup Phabricator\'s database '.
-        'schema.');
+        "Run the storage upgrade script to setup Phabricator's database ".
+        "schema.");
 
       $this->newIssue('storage.upgrade')
         ->setName(pht('Setup MySQL Schema'))
@@ -103,10 +103,11 @@ final class PhabricatorDatabaseSetupCheck extends PhabricatorSetupCheck {
       if ($diff) {
         $this->newIssue('storage.patch')
           ->setName(pht('Upgrade MySQL Schema'))
-          ->setMessage(pht(
-            "Run the storage upgrade script to upgrade Phabricator's database ".
-              "schema. Missing patches:<br />%s<br />",
-            phutil_implode_html(phutil_tag('br'), array_keys($diff))))
+          ->setMessage(
+            pht(
+              "Run the storage upgrade script to upgrade Phabricator's ".
+              "database schema. Missing patches:<br />%s<br />",
+              phutil_implode_html(phutil_tag('br'), array_keys($diff))))
           ->addCommand(
             hsprintf('<tt>phabricator/ $</tt> ./bin/storage upgrade'));
       }
@@ -123,13 +124,15 @@ final class PhabricatorDatabaseSetupCheck extends PhabricatorSetupCheck {
         ->setName(pht('Deprecated mysql.host Format'))
         ->setSummary(
           pht(
-            'Move port information from `mysql.host` to `mysql.port` in your '.
-            'config.'))
+            'Move port information from `%s` to `%s` in your config.',
+            'mysql.host',
+            'mysql.port'))
         ->setMessage(
           pht(
-            'Your `mysql.host` configuration contains a port number, but '.
-            'this usage is deprecated. Instead, put the port number in '.
-            '`mysql.port`.'))
+            'Your `%s` configuration contains a port number, but this usage '.
+            'is deprecated. Instead, put the port number in `%s`.',
+            'mysql.host',
+            'mysql.port'))
         ->addPhabricatorConfig('mysql.host')
         ->addPhabricatorConfig('mysql.port')
         ->addCommand(
diff --git a/src/applications/config/check/PhabricatorExtraConfigSetupCheck.php b/src/applications/config/check/PhabricatorExtraConfigSetupCheck.php
index a88dff0f22..b3c294b3e6 100644
--- a/src/applications/config/check/PhabricatorExtraConfigSetupCheck.php
+++ b/src/applications/config/check/PhabricatorExtraConfigSetupCheck.php
@@ -147,8 +147,9 @@ final class PhabricatorExtraConfigSetupCheck extends PhabricatorSetupCheck {
 
     $markup_reason = pht(
       'Custom remarkup rules are now added by subclassing '.
-      'PhabricatorRemarkupCustomInlineRule or '.
-      'PhabricatorRemarkupCustomBlockRule.');
+      '%s or %s.',
+      'PhabricatorRemarkupCustomInlineRule',
+      'PhabricatorRemarkupCustomBlockRule');
 
     $session_reason = pht(
       'Sessions now expire and are garbage collected rather than having an '.
@@ -178,24 +179,26 @@ final class PhabricatorExtraConfigSetupCheck extends PhabricatorSetupCheck {
     $ancient_config += array(
       'phid.external-loaders' =>
         pht(
-          'External loaders have been replaced. Extend `PhabricatorPHIDType` '.
-          'to implement new PHID and handle types.'),
+          'External loaders have been replaced. Extend `%s` '.
+          'to implement new PHID and handle types.',
+          'PhabricatorPHIDType'),
       'maniphest.custom-task-extensions-class' =>
         pht(
-          'Maniphest fields are now loaded automatically. You can configure '.
-          'them with `maniphest.fields`.'),
+          'Maniphest fields are now loaded automatically. '.
+          'You can configure them with `%s`.',
+          'maniphest.fields'),
       'maniphest.custom-fields' =>
         pht(
-          'Maniphest fields are now defined in '.
-          '`maniphest.custom-field-definitions`. Existing definitions have '.
-          'been migrated.'),
+          'Maniphest fields are now defined in `%s`. '.
+          'Existing definitions have been migrated.',
+          'maniphest.custom-field-definitions'),
       'differential.custom-remarkup-rules' => $markup_reason,
       'differential.custom-remarkup-block-rules' => $markup_reason,
       'auth.sshkeys.enabled' => pht(
         'SSH keys are now actually useful, so they are always enabled.'),
       'differential.anonymous-access' => pht(
-        'Phabricator now has meaningful global access controls. See '.
-        '`policy.allow-public`.'),
+        'Phabricator now has meaningful global access controls. See `%s`.',
+        'policy.allow-public'),
       'celerity.resource-path' => pht(
         'An alternate resource map is no longer supported. Instead, use '.
         'multiple maps. See T4222.'),
@@ -211,9 +214,10 @@ final class PhabricatorExtraConfigSetupCheck extends PhabricatorSetupCheck {
       'differential.show-test-plan-field' => $differential_field_reason,
       'differential.field-selector' => $differential_field_reason,
       'phabricator.show-beta-applications' => pht(
-        'This option has been renamed to `phabricator.show-prototypes` '.
-        'to emphasize the unfinished nature of many prototype applications. '.
-        'Your existing setting has been migrated.'),
+        'This option has been renamed to `%s` to emphasize the '.
+        'unfinished nature of many prototype applications. '.
+        'Your existing setting has been migrated.',
+        'phabricator.show-prototypes'),
       'notification.user' => pht(
         'The notification server no longer requires root permissions. Start '.
         'the server as the user you want it to run under.'),
@@ -223,10 +227,12 @@ final class PhabricatorExtraConfigSetupCheck extends PhabricatorSetupCheck {
         'The translation implementation has changed and providers are no '.
         'longer used or supported.'),
       'config.mask' => pht(
-        'Use `config.hide` instead of this option.'),
+        'Use `%s` instead of this option.',
+        'config.hide'),
       'phd.start-taskmasters' => pht(
         'Taskmasters now use an autoscaling pool. You can configure the '.
-        'pool size with `phd.taskmasters`.'),
+        'pool size with `%s`.',
+        'phd.taskmasters'),
       'storage.engine-selector' => pht(
         'Phabricator now automatically discovers available storage engines '.
         'at runtime.'),
@@ -234,8 +240,8 @@ final class PhabricatorExtraConfigSetupCheck extends PhabricatorSetupCheck {
         'Phabricator now supports arbitrarily large files. Consult the '.
         'documentation for configuration details.'),
       'security.allow-outbound-http' => pht(
-        'This option has been replaced with the more granular option '.
-        '`security.outbound-blacklist`.'),
+        'This option has been replaced with the more granular option `%s`.',
+        'security.outbound-blacklist'),
       'metamta.reply.show-hints' => pht(
         'Phabricator no longer shows reply hints in mail.'),
 
diff --git a/src/applications/config/check/PhabricatorFileinfoSetupCheck.php b/src/applications/config/check/PhabricatorFileinfoSetupCheck.php
index 4f5013c033..543fc4fb7c 100644
--- a/src/applications/config/check/PhabricatorFileinfoSetupCheck.php
+++ b/src/applications/config/check/PhabricatorFileinfoSetupCheck.php
@@ -9,12 +9,14 @@ final class PhabricatorFileinfoSetupCheck extends PhabricatorSetupCheck {
   protected function executeChecks() {
     if (!extension_loaded('fileinfo')) {
       $message = pht(
-        "The 'fileinfo' extension is not installed. Without 'fileinfo', ".
+        "The '%s' extension is not installed. Without '%s', ".
         "support, Phabricator may not be able to determine the MIME types ".
-        "of uploaded files.");
+        "of uploaded files.",
+        'fileinfo',
+        'fileinfo');
 
       $this->newIssue('extension.fileinfo')
-        ->setName(pht("Missing 'fileinfo' Extension"))
+        ->setName(pht("Missing '%s' Extension", 'fileinfo'))
         ->setMessage($message);
     }
   }
diff --git a/src/applications/config/check/PhabricatorGDSetupCheck.php b/src/applications/config/check/PhabricatorGDSetupCheck.php
index f738715bce..750702c706 100644
--- a/src/applications/config/check/PhabricatorGDSetupCheck.php
+++ b/src/applications/config/check/PhabricatorGDSetupCheck.php
@@ -9,12 +9,15 @@ final class PhabricatorGDSetupCheck extends PhabricatorSetupCheck {
   protected function executeChecks() {
     if (!extension_loaded('gd')) {
       $message = pht(
-        "The 'gd' extension is not installed. Without 'gd', support, ".
+        "The '%s' extension is not installed. Without '%s', support, ".
         "Phabricator will not be able to process or resize images ".
-        "(for example, to generate thumbnails). Install or enable 'gd'.");
+        "(for example, to generate thumbnails). Install or enable '%s'.",
+        'gd',
+        'gd',
+        'gd');
 
       $this->newIssue('extension.gd')
-        ->setName(pht("Missing 'gd' Extension"))
+        ->setName(pht("Missing '%s' Extension", 'gd'))
         ->setMessage($message);
     } else {
       $image_type_map = array(
@@ -36,15 +39,17 @@ final class PhabricatorGDSetupCheck extends PhabricatorSetupCheck {
         $have = implode(', ', $have);
 
         $message = pht(
-          "The 'gd' extension has support for only some image types. ".
+          "The '%s' extension has support for only some image types. ".
           "Phabricator will be unable to process images of the missing ".
-          "types until you build 'gd' with support for them. ".
+          "types until you build '%s' with support for them. ".
           "Supported types: %s. Missing types: %s.",
+          'gd',
+          'gd',
           $have,
           $missing);
 
         $this->newIssue('extension.gd.support')
-          ->setName(pht("Partial 'gd' Support"))
+          ->setName(pht("Partial '%s' Support", 'gd'))
           ->setMessage($message);
       }
     }
diff --git a/src/applications/config/check/PhabricatorImagemagickSetupCheck.php b/src/applications/config/check/PhabricatorImagemagickSetupCheck.php
index 55c538f3a2..a69781132e 100644
--- a/src/applications/config/check/PhabricatorImagemagickSetupCheck.php
+++ b/src/applications/config/check/PhabricatorImagemagickSetupCheck.php
@@ -11,13 +11,15 @@ final class PhabricatorImagemagickSetupCheck extends PhabricatorSetupCheck {
     if ($imagemagick) {
       if (!Filesystem::binaryExists('convert')) {
         $message = pht(
-          'You have enabled Imagemagick in your config, but the \'convert\' '.
-          'binary is not in the webserver\'s $PATH. Disable imagemagick '.
-          'or make it available to the webserver.');
+          "You have enabled Imagemagick in your config, but the '%s' ".
+          "binary is not in the webserver's %s. Disable imagemagick ".
+          "or make it available to the webserver.",
+          'convert',
+          '$PATH');
 
         $this->newIssue('files.enable-imagemagick')
         ->setName(pht(
-          "'convert' binary not found or Imagemagick is not installed."))
+          "'%s' binary not found or Imagemagick is not installed.", 'convert'))
         ->setMessage($message)
         ->addRelatedPhabricatorConfig('files.enable-imagemagick')
         ->addPhabricatorConfig('environment.append-paths');
diff --git a/src/applications/config/check/PhabricatorMySQLSetupCheck.php b/src/applications/config/check/PhabricatorMySQLSetupCheck.php
index a5178cc9ed..75ecc06239 100644
--- a/src/applications/config/check/PhabricatorMySQLSetupCheck.php
+++ b/src/applications/config/check/PhabricatorMySQLSetupCheck.php
@@ -27,14 +27,15 @@ final class PhabricatorMySQLSetupCheck extends PhabricatorSetupCheck {
     $recommended_minimum = (32 * 1024 * 1024);
     if ($max_allowed_packet < $recommended_minimum) {
       $message = pht(
-        "MySQL is configured with a small 'max_allowed_packet' (%d), ".
+        "MySQL is configured with a small '%s' (%d), ".
         "which may cause some large writes to fail. Strongly consider raising ".
         "this to at least %d in your MySQL configuration.",
+        'max_allowed_packet',
         $max_allowed_packet,
         $recommended_minimum);
 
       $this->newIssue('mysql.max_allowed_packet')
-        ->setName(pht('Small MySQL "max_allowed_packet"'))
+        ->setName(pht('Small MySQL "%s"', 'max_allowed_packet'))
         ->setMessage($message)
         ->addMySQLConfig('max_allowed_packet');
     }
@@ -70,7 +71,7 @@ final class PhabricatorMySQLSetupCheck extends PhabricatorSetupCheck {
         phutil_tag('pre', array(), 'sql_mode=STRICT_ALL_TABLES'));
 
       $this->newIssue('mysql.mode')
-        ->setName(pht('MySQL STRICT_ALL_TABLES Mode Not Set'))
+        ->setName(pht('MySQL %s Mode Not Set', 'STRICT_ALL_TABLES'))
         ->setSummary($summary)
         ->setMessage($message)
         ->addMySQLConfig('sql_mode');
@@ -109,7 +110,7 @@ final class PhabricatorMySQLSetupCheck extends PhabricatorSetupCheck {
         phutil_tag('tt', array(), 'ONLY_FULL_GROUP_BY'));
 
       $this->newIssue('mysql.mode')
-        ->setName(pht('MySQL ONLY_FULL_GROUP_BY Mode Set'))
+        ->setName(pht('MySQL %s Mode Set', 'ONLY_FULL_GROUP_BY'))
         ->setSummary($summary)
         ->setMessage($message)
         ->addMySQLConfig('sql_mode');
@@ -134,7 +135,7 @@ final class PhabricatorMySQLSetupCheck extends PhabricatorSetupCheck {
           phutil_tag('tt', array(), 'ft_stopword_file'));
 
         $this->newIssue('mysql.ft_stopword_file')
-          ->setName(pht('MySQL ft_stopword_file Not Supported'))
+          ->setName(pht('MySQL %s Not Supported', 'ft_stopword_file'))
           ->setSummary($summary)
           ->setMessage($message)
           ->addMySQLConfig('ft_stopword_file');
diff --git a/src/applications/config/check/PhabricatorPHPConfigSetupCheck.php b/src/applications/config/check/PhabricatorPHPConfigSetupCheck.php
index 57d97226a6..03bbb3c52d 100644
--- a/src/applications/config/check/PhabricatorPHPConfigSetupCheck.php
+++ b/src/applications/config/check/PhabricatorPHPConfigSetupCheck.php
@@ -14,15 +14,14 @@ final class PhabricatorPHPConfigSetupCheck extends PhabricatorSetupCheck {
     $safe_mode = ini_get('safe_mode');
     if ($safe_mode) {
       $message = pht(
-        "You have 'safe_mode' enabled in your PHP configuration, but ".
-        "Phabricator will not run in safe mode. Safe mode has been deprecated ".
-        "in PHP 5.3 and removed in PHP 5.4.".
-        "\n\n".
-        "Disable safe mode to continue.");
+        "You have '%s' enabled in your PHP configuration, but Phabricator ".
+        "will not run in safe mode. Safe mode has been deprecated in PHP 5.3 ".
+        "and removed in PHP 5.4.\n\nDisable safe mode to continue.",
+        'safe_mode');
 
       $this->newIssue('php.safe_mode')
         ->setIsFatal(true)
-        ->setName(pht('Disable PHP safe_mode'))
+        ->setName(pht('Disable PHP %s', 'safe_mode'))
         ->setMessage($message)
         ->addPHPConfig('safe_mode');
       return;
@@ -146,17 +145,15 @@ final class PhabricatorPHPConfigSetupCheck extends PhabricatorSetupCheck {
       }
 
       $issue = $this->newIssue('php.open_basedir')
-        ->setName(pht('Disable PHP open_basedir'))
+        ->setName(pht('Disable PHP %s', 'open_basedir'))
         ->addPHPConfig('open_basedir');
 
       if ($failures) {
         $message = pht(
-          "Your server is configured with 'open_basedir', which prevents ".
-          "Phabricator from opening files it requires access to.".
-          "\n\n".
-          "Disable this setting to continue.".
-          "\n\n".
-          "Failures:\n\n%s",
+          "Your server is configured with '%s', which prevents Phabricator ".
+          "from opening files it requires access to.\n\n".
+          "Disable this setting to continue.\n\nFailures:\n\n%s",
+          'open_basedir',
           implode("\n\n", $failures));
 
         $issue
@@ -166,15 +163,17 @@ final class PhabricatorPHPConfigSetupCheck extends PhabricatorSetupCheck {
         return;
       } else {
         $summary = pht(
-          "You have 'open_basedir' configured in your PHP settings, which ".
-          "may cause some features to fail.");
+          "You have '%s' configured in your PHP settings, which ".
+          "may cause some features to fail.",
+          'open_basedir');
 
         $message = pht(
-          "You have 'open_basedir' configured in your PHP settings. Although ".
-          "this setting appears permissive enough that Phabricator will ".
-          "work properly, you may still run into problems because of it.".
-          "\n\n".
-          "Consider disabling 'open_basedir'.");
+          "You have '%s' configured in your PHP settings. Although this ".
+          "setting appears permissive enough that Phabricator will work ".
+          "properly, you may still run into problems because of it.\n\n".
+          "Consider disabling '%s'.",
+          'open_basedir',
+          'open_basedir');
 
         $issue
           ->setSummary($summary)
diff --git a/src/applications/config/check/PhabricatorPathSetupCheck.php b/src/applications/config/check/PhabricatorPathSetupCheck.php
index 4833e4861a..618c81abb9 100644
--- a/src/applications/config/check/PhabricatorPathSetupCheck.php
+++ b/src/applications/config/check/PhabricatorPathSetupCheck.php
@@ -13,19 +13,25 @@ final class PhabricatorPathSetupCheck extends PhabricatorSetupCheck {
 
     if (!$path) {
       $summary = pht(
-        'The environmental variable $PATH is empty. Phabricator will not '.
-        'be able to execute some commands.');
+        'The environmental variable %s is empty. Phabricator will not '.
+        'be able to execute some commands.',
+        '$PATH');
 
       $message = pht(
-        'The environmental variable $PATH is empty. Phabricator needs to '.
-        'execute some system commands, like `svn`, `git`, `hg`, and `diff`. '.
-        'To execute these commands, the binaries must be available in the '.
-        'webserver\'s $PATH. You can set additional paths in Phabricator '.
-        'configuration.');
+        "The environmental variable %s is empty. Phabricator needs to execute ".
+        "some system commands, like `%s`, `%s`, `%s`, and `%s`. To execute ".
+        "these commands, the binaries must be available in the webserver's ".
+        "%s. You can set additional paths in Phabricator configuration.",
+        '$PATH',
+        'svn',
+        'git',
+        'hg',
+        'diff',
+        '$PATH');
 
       $this
         ->newIssue('config.environment.append-paths')
-        ->setName(pht('$PATH Not Set'))
+        ->setName(pht('%s Not Set', '$PATH'))
         ->setSummary($summary)
         ->setMessage($message)
         ->addPhabricatorConfig('environment.append-paths');
@@ -86,10 +92,11 @@ final class PhabricatorPathSetupCheck extends PhabricatorSetupCheck {
         if (!phutil_is_windows() && !@file_exists($path_part.'/.')) {
           $message = pht(
             "The PATH component '%s' (which resolves as the absolute path ".
-            "'%s') is not usable because it is not traversable (its '+x' ".
+            "'%s') is not usable because it is not traversable (its '%s' ".
             "permission bit is not set).",
             $path_part,
-            Filesystem::resolvePath($path_part));
+            Filesystem::resolvePath($path_part),
+            '+x');
         }
       }
 
diff --git a/src/applications/config/check/PhabricatorPygmentSetupCheck.php b/src/applications/config/check/PhabricatorPygmentSetupCheck.php
index 26f1f46332..228eb7a33b 100644
--- a/src/applications/config/check/PhabricatorPygmentSetupCheck.php
+++ b/src/applications/config/check/PhabricatorPygmentSetupCheck.php
@@ -12,17 +12,23 @@ final class PhabricatorPygmentSetupCheck extends PhabricatorSetupCheck {
     if ($pygment) {
       if (!Filesystem::binaryExists('pygmentize')) {
         $summary = pht(
-          'You enabled pygments but the pygmentize script is not '.
-          'actually available, your $PATH is probably broken.');
+          'You enabled pygments but the %s script is not '.
+          'actually available, your %s is probably broken.',
+          'pygmentize',
+          '$PATH');
 
         $message = pht(
-          'The environmental variable $PATH does not contain '.
-          'pygmentize. You have enabled pygments, which requires '.
-          'pygmentize to be available in your $PATH variable.');
+          'The environmental variable %s does not contain %s. '.
+          'You have enabled pygments, which requires '.
+          '%s to be available in your %s variable.',
+          '$PATH',
+          'pygmentize',
+          'pygmentize',
+          '$PATH');
 
         $this
           ->newIssue('pygments.enabled')
-          ->setName(pht('pygmentize Not Found'))
+          ->setName(pht('%s Not Found', 'pygmentize'))
           ->setSummary($summary)
           ->setMessage($message)
           ->addRelatedPhabricatorConfig('pygments.enabled')
@@ -31,19 +37,21 @@ final class PhabricatorPygmentSetupCheck extends PhabricatorSetupCheck {
         list($err) = exec_manual('pygmentize -h');
         if ($err) {
           $summary = pht(
-            'You have enabled pygments and the pygmentize script is '.
-            'available, but does not seem to work.');
+            'You have enabled pygments and the %s script is '.
+            'available, but does not seem to work.',
+            'pygmentize');
 
           $message = pht(
-            'Phabricator has %s available in $PATH, but the binary '.
+            'Phabricator has %s available in %s, but the binary '.
             'exited with an error code when run as %s. Check that it is '.
             'installed correctly.',
+            phutil_tag('tt', array(), '$PATH'),
             phutil_tag('tt', array(), 'pygmentize'),
             phutil_tag('tt', array(), 'pygmentize -h'));
 
           $this
             ->newIssue('pygments.failed')
-            ->setName(pht('pygmentize Not Working'))
+            ->setName(pht('%s Not Working', 'pygmentize'))
             ->setSummary($summary)
             ->setMessage($message)
             ->addRelatedPhabricatorConfig('pygments.enabled')
@@ -51,12 +59,14 @@ final class PhabricatorPygmentSetupCheck extends PhabricatorSetupCheck {
         }
       }
     } else {
-      $summary = pht('Pygments should be installed and enabled '.
+      $summary = pht(
+        'Pygments should be installed and enabled '.
         'to provide advanced syntax highlighting.');
 
-      $message = pht('Phabricator can highlight a few languages by default, '.
+      $message = pht(
+        'Phabricator can highlight a few languages by default, '.
         'but installing and enabling Pygments (a third-party highlighting '.
-        'tool) will add syntax highlighting for many more languages. '."\n\n".
+        "tool) will add syntax highlighting for many more languages. \n\n".
         'For instructions on installing and enabling Pygments, see the '.
         '%s configuration option.'."\n\n".
         'If you do not want to install Pygments, you can ignore this issue.',
diff --git a/src/applications/config/check/PhabricatorSetupCheck.php b/src/applications/config/check/PhabricatorSetupCheck.php
index a689d14943..beb52de4dd 100644
--- a/src/applications/config/check/PhabricatorSetupCheck.php
+++ b/src/applications/config/check/PhabricatorSetupCheck.php
@@ -130,7 +130,9 @@ abstract class PhabricatorSetupCheck {
       foreach ($check->getIssues() as $key => $issue) {
         if (isset($issues[$key])) {
           throw new Exception(
-            "Two setup checks raised an issue with key '{$key}'!");
+            pht(
+              "Two setup checks raised an issue with key '%s'!",
+              $key));
         }
         $issues[$key] = $issue;
         if ($issue->getIsFatal()) {
@@ -139,8 +141,8 @@ abstract class PhabricatorSetupCheck {
       }
     }
 
-    foreach (PhabricatorEnv::getEnvConfig('config.ignore-issues')
-              as $ignorable => $derp) {
+    $ignore_issues = PhabricatorEnv::getEnvConfig('config.ignore-issues');
+    foreach ($ignore_issues as $ignorable => $derp) {
       if (isset($issues[$ignorable])) {
         $issues[$ignorable]->setIsIgnored(true);
       }
diff --git a/src/applications/config/check/PhabricatorTimezoneSetupCheck.php b/src/applications/config/check/PhabricatorTimezoneSetupCheck.php
index 5fcf74a294..bf087c933a 100644
--- a/src/applications/config/check/PhabricatorTimezoneSetupCheck.php
+++ b/src/applications/config/check/PhabricatorTimezoneSetupCheck.php
@@ -40,8 +40,10 @@ final class PhabricatorTimezoneSetupCheck extends PhabricatorSetupCheck {
 
     $message = pht(
       "Your configuration fails to specify a server timezone. You can either ".
-      "set the PHP configuration value 'date.timezone' or the Phabricator ".
-      "configuration value 'phabricator.timezone' to specify one.");
+      "set the PHP configuration value '%s' or the Phabricator ".
+      "configuration value '%s' to specify one.",
+      'date.timezone',
+      'phabricator.timezone');
 
     $this
       ->newIssue('config.timezone')
diff --git a/src/applications/config/controller/PhabricatorConfigIgnoreController.php b/src/applications/config/controller/PhabricatorConfigIgnoreController.php
index a136035536..ba634dec1a 100644
--- a/src/applications/config/controller/PhabricatorConfigIgnoreController.php
+++ b/src/applications/config/controller/PhabricatorConfigIgnoreController.php
@@ -34,7 +34,7 @@ final class PhabricatorConfigIgnoreController
         'This issue will no longer be suppressed, and will return to its '.
         'rightful place as a global setup warning.');
     } else {
-      throw new Exception('Unrecognized verb: '.$this->verb);
+      throw new Exception(pht('Unrecognized verb: %s', $this->verb));
     }
 
     $dialog = id(new AphrontDialogView())
diff --git a/src/applications/config/custom/PhabricatorCustomHeaderConfigType.php b/src/applications/config/custom/PhabricatorCustomHeaderConfigType.php
index b738aa6aa2..fee8ba5a4c 100644
--- a/src/applications/config/custom/PhabricatorCustomHeaderConfigType.php
+++ b/src/applications/config/custom/PhabricatorCustomHeaderConfigType.php
@@ -5,8 +5,10 @@ final class PhabricatorCustomHeaderConfigType
 
   public function validateOption(PhabricatorConfigOption $option, $value) {
     if (phid_get_type($value) != PhabricatorFileFilePHIDType::TYPECONST) {
-      throw new Exception(pht(
-        '%s is not a valid file phid.', $value));
+      throw new Exception(
+        pht(
+          '%s is not a valid file PHID.',
+          $value));
     }
 
     $file = id(new PhabricatorFileQuery())
@@ -14,23 +16,27 @@ final class PhabricatorCustomHeaderConfigType
       ->withPHIDs(array($value))
       ->executeOne();
     if (!$file) {
-      throw new Exception(pht(
-        '%s is not a valid file phid.', $value));
+      throw new Exception(
+        pht(
+          '%s is not a valid file PHID.',
+          $value));
     }
 
     $most_open_policy = PhabricatorPolicies::getMostOpenPolicy();
     if ($file->getViewPolicy() != $most_open_policy) {
-      throw new Exception(pht(
-        'Specified file %s has policy "%s" but should have policy "%s".',
-        $value,
-        $file->getViewPolicy(),
-        $most_open_policy));
+      throw new Exception(
+        pht(
+          'Specified file %s has policy "%s" but should have policy "%s".',
+          $value,
+          $file->getViewPolicy(),
+          $most_open_policy));
     }
 
     if (!$file->isViewableImage()) {
-      throw new Exception(pht(
-        'Specified file %s is not a viewable image.',
-        $value));
+      throw new Exception(
+        pht(
+          'Specified file %s is not a viewable image.',
+          $value));
     }
   }
 
diff --git a/src/applications/config/management/PhabricatorConfigManagementDeleteWorkflow.php b/src/applications/config/management/PhabricatorConfigManagementDeleteWorkflow.php
index 8f8cea0838..24b0f48c26 100644
--- a/src/applications/config/management/PhabricatorConfigManagementDeleteWorkflow.php
+++ b/src/applications/config/management/PhabricatorConfigManagementDeleteWorkflow.php
@@ -12,8 +12,9 @@ final class PhabricatorConfigManagementDeleteWorkflow
         array(
           array(
             'name'  => 'database',
-            'help'  => pht('Delete configuration in the database instead of '.
-            'in local configuration.'),
+            'help'  => pht(
+              'Delete configuration in the database instead of '.
+              'in local configuration.'),
           ),
           array(
             'name'      => 'args',
@@ -27,15 +28,15 @@ final class PhabricatorConfigManagementDeleteWorkflow
 
     $argv = $args->getArg('args');
     if (count($argv) == 0) {
-      throw new PhutilArgumentUsageException(pht(
-        'Specify a configuration key to delete.'));
+      throw new PhutilArgumentUsageException(
+        pht('Specify a configuration key to delete.'));
     }
 
     $key = $argv[0];
 
     if (count($argv) > 1) {
-      throw new PhutilArgumentUsageException(pht(
-        'Too many arguments: expected one key.'));
+      throw new PhutilArgumentUsageException(
+        pht('Too many arguments: expected one key.'));
     }
 
 
@@ -49,10 +50,11 @@ final class PhabricatorConfigManagementDeleteWorkflow
     }
     $values = $config->getKeys(array($key));
     if (!$values) {
-      throw new PhutilArgumentUsageException(pht(
-        "Configuration key '%s' is not set in %s configuration!",
-        $key,
-        $config_type));
+      throw new PhutilArgumentUsageException(
+        pht(
+          "Configuration key '%s' is not set in %s configuration!",
+          $key,
+          $config_type));
     }
 
     if ($use_database) {
@@ -64,7 +66,8 @@ final class PhabricatorConfigManagementDeleteWorkflow
     }
 
     $console->writeOut(
-      pht("Deleted '%s' from %s configuration.", $key, $config_type)."\n");
+      "%s\n",
+      pht("Deleted '%s' from %s configuration.", $key, $config_type));
   }
 
 }
diff --git a/src/applications/config/management/PhabricatorConfigManagementGetWorkflow.php b/src/applications/config/management/PhabricatorConfigManagementGetWorkflow.php
index 1924cc4792..800ffe5942 100644
--- a/src/applications/config/management/PhabricatorConfigManagementGetWorkflow.php
+++ b/src/applications/config/management/PhabricatorConfigManagementGetWorkflow.php
@@ -7,7 +7,7 @@ final class PhabricatorConfigManagementGetWorkflow
     $this
       ->setName('get')
       ->setExamples('**get** __key__')
-      ->setSynopsis('Get a local configuration value.')
+      ->setSynopsis(pht('Get a local configuration value.'))
       ->setArguments(
         array(
           array(
@@ -23,21 +23,23 @@ final class PhabricatorConfigManagementGetWorkflow
     $argv = $args->getArg('args');
     if (count($argv) == 0) {
       throw new PhutilArgumentUsageException(
-        'Specify a configuration key to get.');
+        pht('Specify a configuration key to get.'));
     }
 
     $key = $argv[0];
 
     if (count($argv) > 1) {
       throw new PhutilArgumentUsageException(
-        'Too many arguments: expected one key.');
+        pht('Too many arguments: expected one key.'));
     }
 
     $options = PhabricatorApplicationConfigOptions::loadAllOptions();
     if (empty($options[$key])) {
       throw new PhutilArgumentUsageException(
-        "No such configuration key '{$key}'! Use `config list` to list all ".
-        "keys.");
+        pht(
+          "No such configuration key '%s'! Use `%s` to list all keys.",
+          $key,
+          'config list'));
     }
 
     $values = array();
diff --git a/src/applications/config/management/PhabricatorConfigManagementListWorkflow.php b/src/applications/config/management/PhabricatorConfigManagementListWorkflow.php
index 10bd6202b2..ea9922e4d7 100644
--- a/src/applications/config/management/PhabricatorConfigManagementListWorkflow.php
+++ b/src/applications/config/management/PhabricatorConfigManagementListWorkflow.php
@@ -7,7 +7,7 @@ final class PhabricatorConfigManagementListWorkflow
     $this
       ->setName('list')
       ->setExamples('**list**')
-      ->setSynopsis('List all configuration keys.');
+      ->setSynopsis(pht('List all configuration keys.'));
   }
 
   public function execute(PhutilArgumentParser $args) {
diff --git a/src/applications/config/management/PhabricatorConfigManagementMigrateWorkflow.php b/src/applications/config/management/PhabricatorConfigManagementMigrateWorkflow.php
index 1f992d003a..67b5733dc7 100644
--- a/src/applications/config/management/PhabricatorConfigManagementMigrateWorkflow.php
+++ b/src/applications/config/management/PhabricatorConfigManagementMigrateWorkflow.php
@@ -20,54 +20,60 @@ final class PhabricatorConfigManagementMigrateWorkflow
     $database_config = new PhabricatorConfigDatabaseSource('default');
     $config_sources = PhabricatorEnv::getConfigSourceStack()->getStack();
     $console->writeOut(
-      pht('Migrating file-based config to more modern config...')."\n");
+      "%s\n",
+      pht('Migrating file-based config to more modern config...'));
     foreach ($config_sources as $config_source) {
       if (!($config_source instanceof PhabricatorConfigFileSource)) {
         $console->writeOut(
-          pht('Skipping config of source type %s...',
-              get_class($config_source))."\n");
+          "%s\n",
+          pht(
+            'Skipping config of source type %s...',
+            get_class($config_source)));
         continue;
       }
-      $console->writeOut(pht('Migrating file source...')."\n");
+      $console->writeOut("%s\n", pht('Migrating file source...'));
       $all_keys = $config_source->getAllKeys();
       foreach ($all_keys as $key => $value) {
         $option = idx($options, $key);
         if (!$option) {
-          $console->writeOut(pht('Skipping obsolete option: %s', $key)."\n");
+          $console->writeOut("%s\n", pht('Skipping obsolete option: %s', $key));
           continue;
         }
         $in_local = $local_config->getKeys(array($option->getKey()));
         if ($in_local) {
-          $console->writeOut(pht(
-            'Skipping option "%s"; already in local config.', $key)."\n");
+          $console->writeOut(
+            "%s\n",
+            pht('Skipping option "%s"; already in local config.', $key));
           continue;
         }
         $is_locked = $option->getLocked();
         if ($is_locked) {
           $local_config->setKeys(array($option->getKey() => $value));
           $key_count++;
-          $console->writeOut(pht(
-            'Migrated option "%s" from file to local config.', $key)."\n");
+          $console->writeOut(
+            "%s\n",
+            pht('Migrated option "%s" from file to local config.', $key));
         } else {
           $in_database = $database_config->getKeys(array($option->getKey()));
           if ($in_database) {
-            $console->writeOut(pht(
-              'Skipping option "%s"; already in database config.', $key)."\n");
+            $console->writeOut(
+              "%s\n",
+              pht('Skipping option "%s"; already in database config.', $key));
             continue;
           } else {
             $config_entry = PhabricatorConfigEntry::loadConfigEntry($key);
             $config_entry->setValue($value);
             $config_entry->save();
             $key_count++;
-            $console->writeOut(pht(
-              'Migrated option "%s" from file to database config.', $key)."\n");
+            $console->writeOut(
+              "%s\n",
+              pht('Migrated option "%s" from file to database config.', $key));
           }
         }
       }
     }
 
-    $console->writeOut(pht(
-      'Done. Migrated %d keys.', $key_count)."\n");
+    $console->writeOut("%s\n", pht('Done. Migrated %d keys.', $key_count));
     return 0;
   }
 
diff --git a/src/applications/config/management/PhabricatorConfigManagementSetWorkflow.php b/src/applications/config/management/PhabricatorConfigManagementSetWorkflow.php
index 0da6332268..1da30408ee 100644
--- a/src/applications/config/management/PhabricatorConfigManagementSetWorkflow.php
+++ b/src/applications/config/management/PhabricatorConfigManagementSetWorkflow.php
@@ -12,8 +12,9 @@ final class PhabricatorConfigManagementSetWorkflow
         array(
           array(
             'name'  => 'database',
-            'help'  => pht('Update configuration in the database instead of '.
-            'in local configuration.'),
+            'help'  => pht(
+              'Update configuration in the database instead of '.
+              'in local configuration.'),
           ),
           array(
             'name'      => 'args',
@@ -26,31 +27,34 @@ final class PhabricatorConfigManagementSetWorkflow
     $console = PhutilConsole::getConsole();
     $argv = $args->getArg('args');
     if (count($argv) == 0) {
-      throw new PhutilArgumentUsageException(pht(
-        'Specify a configuration key and a value to set it to.'));
+      throw new PhutilArgumentUsageException(
+        pht('Specify a configuration key and a value to set it to.'));
     }
 
     $key = $argv[0];
 
     if (count($argv) == 1) {
-      throw new PhutilArgumentUsageException(pht(
-        "Specify a value to set the key '%s' to.",
-        $key));
+      throw new PhutilArgumentUsageException(
+        pht(
+          "Specify a value to set the key '%s' to.",
+          $key));
     }
 
     $value = $argv[1];
 
     if (count($argv) > 2) {
-      throw new PhutilArgumentUsageException(pht(
-        'Too many arguments: expected one key and one value.'));
+      throw new PhutilArgumentUsageException(
+        pht(
+          'Too many arguments: expected one key and one value.'));
     }
 
     $options = PhabricatorApplicationConfigOptions::loadAllOptions();
     if (empty($options[$key])) {
-      throw new PhutilArgumentUsageException(pht(
-        "No such configuration key '%s'! Use `config list` to list all ".
-        "keys.",
-        $key));
+      throw new PhutilArgumentUsageException(
+        pht(
+          "No such configuration key '%s'! Use `%s` to list all keys.",
+          $key,
+          'config list'));
     }
 
     $option = $options[$key];
@@ -64,10 +68,11 @@ final class PhabricatorConfigManagementSetWorkflow
         break;
       case 'int':
         if (!ctype_digit($value)) {
-          throw new PhutilArgumentUsageException(pht(
-            "Config key '%s' is of type '%s'. Specify an integer.",
-            $key,
-            $type));
+          throw new PhutilArgumentUsageException(
+            pht(
+              "Config key '%s' is of type '%s'. Specify an integer.",
+              $key,
+              $type));
         }
         $value = (int)$value;
         break;
@@ -77,11 +82,13 @@ final class PhabricatorConfigManagementSetWorkflow
         } else if ($value == 'false') {
           $value = false;
         } else {
-          throw new PhutilArgumentUsageException(pht(
-            "Config key '%s' is of type '%s'. ".
-            "Specify 'true' or 'false'.",
-            $key,
-            $type));
+          throw new PhutilArgumentUsageException(
+            pht(
+              "Config key '%s' is of type '%s'. Specify '%s' or '%s'.",
+              $key,
+              $type,
+              'true',
+              'false'));
         }
         break;
       default:
@@ -89,23 +96,25 @@ final class PhabricatorConfigManagementSetWorkflow
         if (!is_array($value)) {
           switch ($type) {
             case 'set':
-              $message = pht(
-                "Config key '%s' is of type '%s'. Specify it in JSON. ".
-                "For example:\n\n".
-                '    ./bin/config set \'{"value1": true, "value2": true}\''.
-                "\n",
-                $key,
-                $type);
+              $message = sprintf(
+                  "%s%s\n\n    %s\n",
+                  pht(
+                    "Config key '%s' is of type '%s'. Specify it in JSON.",
+                    $key,
+                    $type),
+                  pht('For example:'),
+                  './bin/config set \'{"value1": true, "value2": true}\'');
               break;
             default:
               if (preg_match('/^list</', $type)) {
-                $message = pht(
-                  "Config key '%s' is of type '%s'. Specify it in JSON. ".
-                  "For example:\n\n".
-                  '    ./bin/config set \'["a", "b", "c"]\''.
-                  "\n",
-                  $key,
-                  $type);
+                $message = sprintf(
+                  "%s%s\n\n    %s\n",
+                  pht(
+                    "Config key '%s' is of type '%s'. Specify it in JSON.",
+                    $key,
+                    $type),
+                  pht('For example:'),
+                  './bin/config set \'["a", "b", "c"]\'');
               } else {
                 $message = pht(
                   'Config key "%s" is of type "%s". Specify it in JSON.',
@@ -120,10 +129,11 @@ final class PhabricatorConfigManagementSetWorkflow
     }
     $use_database = $args->getArg('database');
     if ($option->getLocked() && $use_database) {
-      throw new PhutilArgumentUsageException(pht(
-        "Config key '%s' is locked and can only be set in local ".
-        'configuration.',
-        $key));
+      throw new PhutilArgumentUsageException(
+        pht(
+          "Config key '%s' is locked and can only be set in local ".
+          "configuration.",
+          $key));
     }
 
     try {
@@ -145,7 +155,8 @@ final class PhabricatorConfigManagementSetWorkflow
     }
 
     $console->writeOut(
-      pht("Set '%s' in %s configuration.", $key, $config_type)."\n");
+      "%s\n",
+      pht("Set '%s' in %s configuration.", $key, $config_type));
   }
 
 }
diff --git a/src/applications/config/option/PhabricatorAWSConfigOptions.php b/src/applications/config/option/PhabricatorAWSConfigOptions.php
index 1a360ffc16..b191e0e40e 100644
--- a/src/applications/config/option/PhabricatorAWSConfigOptions.php
+++ b/src/applications/config/option/PhabricatorAWSConfigOptions.php
@@ -39,8 +39,8 @@ final class PhabricatorAWSConfigOptions
           pht(
             'Explicit S3 endpoint to use. Leave empty to have Phabricator '.
             'select and endpoint. Normally, you do not need to set this.'))
-        ->addExample(null, 'Use default endpoint')
-        ->addExample('s3.amazon.com', 'Use specific endpoint'),
+        ->addExample(null, pht('Use default endpoint'))
+        ->addExample('s3.amazon.com', pht('Use specific endpoint')),
       $this->newOption('amazon-ec2.access-key', 'string', null)
         ->setLocked(true)
         ->setDescription(pht('Access key for Amazon EC2.')),
diff --git a/src/applications/config/option/PhabricatorAccessLogConfigOptions.php b/src/applications/config/option/PhabricatorAccessLogConfigOptions.php
index c186fc3557..5bc55f64a7 100644
--- a/src/applications/config/option/PhabricatorAccessLogConfigOptions.php
+++ b/src/applications/config/option/PhabricatorAccessLogConfigOptions.php
@@ -49,14 +49,16 @@ final class PhabricatorAccessLogConfigOptions
     );
 
     $http_desc = pht(
-      'Format for the HTTP access log. Use {{log.access.path}} to set the '.
-      'path. Available variables are:');
+      'Format for the HTTP access log. Use `%s` to set the path. '.
+      'Available variables are:',
+      'log.access.path');
     $http_desc .= "\n\n";
     $http_desc .= $this->renderMapHelp($http_map);
 
     $ssh_desc = pht(
-      'Format for the SSH access log. Use {{log.ssh.path}} to set the '.
-      'path. Available variables are:');
+      'Format for the SSH access log. Use %s to set the path. '.
+      'Available variables are:',
+      'log.ssh.path');
     $ssh_desc .= "\n\n";
     $ssh_desc .= $this->renderMapHelp($ssh_map);
 
@@ -67,7 +69,6 @@ final class PhabricatorAccessLogConfigOptions
         ->setDescription(
           pht(
             "To enable the Phabricator access log, specify a path. The ".
-            "access log can provide more detailed information about ".
             "Phabricator access than normal HTTP access logs (for instance, ".
             "it can show logged-in users, controllers, and other application ".
             "data).\n\n".
diff --git a/src/applications/config/option/PhabricatorApplicationConfigOptions.php b/src/applications/config/option/PhabricatorApplicationConfigOptions.php
index 7ac1df3e16..d99cdf3101 100644
--- a/src/applications/config/option/PhabricatorApplicationConfigOptions.php
+++ b/src/applications/config/option/PhabricatorApplicationConfigOptions.php
@@ -227,7 +227,7 @@ abstract class PhabricatorApplicationConfigOptions extends Phobject {
         if (isset($options[$key])) {
           throw new Exception(
             pht(
-              "Mulitple % subclasses contain an option named '%s'!",
+              "Mulitple %s subclasses contain an option named '%s'!",
               __CLASS__,
               $key));
         }
diff --git a/src/applications/config/option/PhabricatorAuthenticationConfigOptions.php b/src/applications/config/option/PhabricatorAuthenticationConfigOptions.php
index dc7996a3ee..a965d16f42 100644
--- a/src/applications/config/option/PhabricatorAuthenticationConfigOptions.php
+++ b/src/applications/config/option/PhabricatorAuthenticationConfigOptions.php
@@ -55,8 +55,8 @@ final class PhabricatorAuthenticationConfigOptions
             "registration, you can disable the queue to reduce administrative ".
             "overhead.\n\n".
             "NOTE: Before you disable the queue, make sure ".
-            "{{auth.email-domains}} is configured correctly for your ".
-            "install!")),
+            "{{auth.email-domains}} is configured correctly ".
+            "for your install!")),
       $this->newOption('auth.email-domains', 'list<string>', array())
         ->setSummary(pht('Only allow registration from particular domains.'))
         ->setDescription(
@@ -89,8 +89,7 @@ final class PhabricatorAuthenticationConfigOptions
           ))
         ->setSummary(
           pht(
-            'Determines whether or not basic account information is '.
-            'editable.'))
+            'Determines whether or not basic account information is editable.'))
         ->setDescription(
           pht(
             'Is basic account information (email, real name, profile '.
diff --git a/src/applications/config/option/PhabricatorClusterConfigOptions.php b/src/applications/config/option/PhabricatorClusterConfigOptions.php
index f6e2849e43..8684d98233 100644
--- a/src/applications/config/option/PhabricatorClusterConfigOptions.php
+++ b/src/applications/config/option/PhabricatorClusterConfigOptions.php
@@ -69,9 +69,10 @@ final class PhabricatorClusterConfigOptions
             'hosting providers running multi-tenant clusters.'.
             "\n\n".
             'If you provide an instance identifier here (normally by '.
-            'injecting it with a `PhabricatorConfigSiteSource`), Phabricator '.
-            'will pass it to subprocesses and commit hooks in the '.
-            '`PHABRICATOR_INSTANCE` environmental variable.')),
+            'injecting it with a `%s`), Phabricator will pass it to '.
+            'subprocesses and commit hooks in the `%s` environmental variable.',
+            'PhabricatorConfigSiteSource',
+            'PHABRICATOR_INSTANCE')),
     );
   }
 
diff --git a/src/applications/config/option/PhabricatorConfigOption.php b/src/applications/config/option/PhabricatorConfigOption.php
index e5c9773611..e1d71416e7 100644
--- a/src/applications/config/option/PhabricatorConfigOption.php
+++ b/src/applications/config/option/PhabricatorConfigOption.php
@@ -76,7 +76,9 @@ final class PhabricatorConfigOption
     }
     return pht(
       'This configuration is locked and can not be edited from the web '.
-      'interface. Use `./bin/config` in `phabricator/` to edit it.');
+      'interface. Use `%s` in `%s` to edit it.',
+      './bin/config',
+      'phabricator/');
   }
 
   public function addExample($value, $description) {
@@ -180,7 +182,7 @@ final class PhabricatorConfigOption
   public function getCustomObject() {
     if (!$this->customObject) {
       if (!$this->isCustomType()) {
-        throw new Exception('This option does not have a custom type!');
+        throw new Exception(pht('This option does not have a custom type!'));
       }
       $this->customObject = newv(substr($this->getType(), 7), array());
     }
diff --git a/src/applications/config/option/PhabricatorCoreConfigOptions.php b/src/applications/config/option/PhabricatorCoreConfigOptions.php
index b5df38633a..7477bae5b6 100644
--- a/src/applications/config/option/PhabricatorCoreConfigOptions.php
+++ b/src/applications/config/option/PhabricatorCoreConfigOptions.php
@@ -58,9 +58,9 @@ final class PhabricatorCoreConfigOptions
             'Phabricator, and a production environment for deploying it), '.
             'set the production environment URI here so that emails and other '.
             'durable URIs will always generate with links pointing at the '.
-            'production environment. If unset, defaults to '.
-            '{{phabricator.base-uri}}. Most installs do not need to set '.
-            'this option.'))
+            'production environment. If unset, defaults to `%s`. Most '.
+            'installs do not need to set this option.',
+            'phabricator.base-uri'))
         ->addExample('http://phabricator.example.com/', pht('Valid Setting')),
       $this->newOption('phabricator.allowed-uris', 'list<string>', array())
         ->setLocked(true)
@@ -68,9 +68,9 @@ final class PhabricatorCoreConfigOptions
         ->setDescription(
           pht(
             "These alternative URIs will be able to access 'normal' pages ".
-              "on your Phabricator install. Other features such as OAuth ".
-              "won't work. The major use case for this is moving installs ".
-              "across domains."))
+            "on your Phabricator install. Other features such as OAuth ".
+            "won't work. The major use case for this is moving installs ".
+            "across domains."))
         ->addExample(
           "http://phabricator2.example.com/\n".
           "http://phabricator3.example.com/",
@@ -83,8 +83,9 @@ final class PhabricatorCoreConfigOptions
             "PHP requires that you set a timezone in your php.ini before ".
             "using date functions, or it will emit a warning. If this isn't ".
             "possible (for instance, because you are using HPHP) you can set ".
-            "some valid constant for date_default_timezone_set() here and ".
-            "Phabricator will set it on your behalf, silencing the warning."))
+            "some valid constant for %s here and Phabricator will set it on ".
+            "your behalf, silencing the warning.",
+            'date_default_timezone_set()'))
         ->addExample('America/New_York', pht('US East (EDT)'))
         ->addExample('America/Chicago', pht('US Central (CDT)'))
         ->addExample('America/Boise', pht('US Mountain (MDT)'))
@@ -92,14 +93,14 @@ final class PhabricatorCoreConfigOptions
       $this->newOption('phabricator.cookie-prefix', 'string', null)
         ->setLocked(true)
         ->setSummary(
-          pht('Set a string Phabricator should use to prefix '.
-              'cookie names.'))
+          pht(
+            'Set a string Phabricator should use to prefix cookie names.'))
         ->setDescription(
           pht(
             'Cookies set for x.com are also sent for y.x.com. Assuming '.
             'Phabricator instances are running on both domains, this will '.
             'create a collision preventing you from logging in.'))
-        ->addExample('dev', pht('Prefix cookie with "dev"')),
+        ->addExample('dev', pht('Prefix cookie with "%s"', 'dev')),
       $this->newOption('phabricator.show-prototypes', 'bool', false)
         ->setLocked(true)
         ->setBoolOptions(
@@ -155,22 +156,29 @@ final class PhabricatorCoreConfigOptions
             'linked.')),
       $this->newOption('environment.append-paths', 'list<string>', $paths)
         ->setSummary(
-          pht('These paths get appended to your \$PATH envrionment variable.'))
+          pht(
+            'These paths get appended to your %s environment variable.',
+            '$PATH'))
         ->setDescription(
           pht(
             "Phabricator occasionally shells out to other binaries on the ".
-            "server. An example of this is the `pygmentize` command, used ".
-            "to syntax-highlight code written in languages other than PHP. ".
-            "By default, it is assumed that these binaries are in the \$PATH ".
-            "of the user running Phabricator (normally 'apache', 'httpd', or ".
-            "'nobody'). Here you can add extra directories to the \$PATH ".
+            "server. An example of this is the `%s` command, used to ".
+            "syntax-highlight code written in languages other than PHP. By ".
+            "default, it is assumed that these binaries are in the %s of the ".
+            "user running Phabricator (normally 'apache', 'httpd', or ".
+            "'nobody'). Here you can add extra directories to the %s ".
             "environment variable, for when these binaries are in ".
             "non-standard locations.\n\n".
-            "Note that you can also put binaries in ".
-            "`phabricator/support/bin/` (for example, by symlinking them).\n\n".
+            "Note that you can also put binaries in `%s` (for example, by ".
+            "symlinking them).\n\n".
             "The current value of PATH after configuration is applied is:\n\n".
             "  lang=text\n".
-            "  %s", $path))
+            "  %s",
+            '$PATH',
+            '$PATH',
+            'phabricator/support/bin/',
+            $path,
+            'pygmentize'))
         ->setLocked(true)
         ->addExample('/usr/local/bin', pht('Add One Path'))
         ->addExample("/usr/bin\n/usr/local/bin", pht('Add Multiple Paths')),
@@ -200,7 +208,7 @@ final class PhabricatorCoreConfigOptions
             ),
             pht('Applications application'))))
         ->setDescription(
-          pht('Array containing list of Uninstalled applications.')),
+          pht('Array containing list of uninstalled applications.')),
       $this->newOption('phabricator.application-settings', 'wild', array())
         ->setLocked(true)
         ->setDescription(
@@ -261,7 +269,9 @@ final class PhabricatorCoreConfigOptions
         throw new PhabricatorConfigValidationException(
           pht(
             "Config option '%s' is invalid. The URI must start with ".
-            "'http://' or 'https://'.",
+            "%s' or '%s'.",
+            'http://',
+            'https://',
             $key));
       }
 
@@ -269,10 +279,12 @@ final class PhabricatorCoreConfigOptions
       if (strpos($domain, '.') === false) {
         throw new PhabricatorConfigValidationException(
           pht(
-            "Config option '%s' is invalid. The URI must contain a dot ('.'), ".
-            "like 'http://example.com/', not just a bare name like ".
-            "'http://example/'. Some web browsers will not set cookies on ".
-            "domains with no TLD.",
+            "Config option '%s' is invalid. The URI must contain a dot ".
+            "('%s'), like '%s', not just a bare name like '%s'. Some web ".
+            "browsers will not set cookies on domains with no TLD.",
+            '.',
+            'http://example.com/',
+            'http://example/',
             $key));
       }
 
@@ -281,11 +293,11 @@ final class PhabricatorCoreConfigOptions
         throw new PhabricatorConfigValidationException(
           pht(
             "Config option '%s' is invalid. The URI must NOT have a path, ".
-            "e.g. 'http://phabricator.example.com/' is OK, but ".
-            "'http://example.com/phabricator/' is not. Phabricator must be ".
-            "installed on an entire domain; it can not be installed on a ".
-            "path.",
-            $key));
+            "e.g. '%s' is OK, but '%s' is not. Phabricator must be installed ".
+            "on an entire domain; it can not be installed on a path.",
+            $key,
+            'http://phabricator.example.com/',
+            'http://example.com/phabricator/'));
       }
     }
 
@@ -299,16 +311,13 @@ final class PhabricatorCoreConfigOptions
         throw new PhabricatorConfigValidationException(
           pht(
             "Config option '%s' is invalid. The timezone identifier must ".
-            "be a valid timezone identifier recognized by PHP, like ".
-            "'America/Los_Angeles'. You can find a list of valid identifiers ".
-            "here: %s",
+            "be a valid timezone identifier recognized by PHP, like '%s'. "."
+            You can find a list of valid identifiers here: %s",
             $key,
+            'America/Los_Angeles',
             'http://php.net/manual/timezones.php'));
       }
     }
-
-
-
   }
 
 
diff --git a/src/applications/config/option/PhabricatorDeveloperConfigOptions.php b/src/applications/config/option/PhabricatorDeveloperConfigOptions.php
index c2063ec87c..37cf752f68 100644
--- a/src/applications/config/option/PhabricatorDeveloperConfigOptions.php
+++ b/src/applications/config/option/PhabricatorDeveloperConfigOptions.php
@@ -52,8 +52,9 @@ final class PhabricatorDeveloperConfigOptions
             "even for logged-out users. This is only really useful if you ".
             "need to debug something on a logged-out page. You should not ".
             "enable this option in production.\n\n".
-            "You must enable DarkConsole by setting {{darkconsole.enabled}} ".
-            "before this option will have any effect.")),
+            "You must enable DarkConsole by setting '%s' ".
+            "before this option will have any effect.",
+            'darkconsole.enabled')),
       $this->newOption('debug.time-limit', 'int', null)
         ->setSummary(
           pht(
@@ -170,12 +171,13 @@ final class PhabricatorDeveloperConfigOptions
             pht('Disable deflate compression'),
           ))
         ->setSummary(
-          pht('Toggle gzdeflate()-based compression for some caches.'))
+          pht('Toggle %s-based compression for some caches.', 'gzdeflate()'))
         ->setDescription(
           pht(
-            'Set this to false to disable the use of gzdeflate()-based '.
+            'Set this to false to disable the use of %s-based '.
             'compression in some caches. This may give you less performant '.
-            '(but more debuggable) caching.')),
+            '(but more debuggable) caching.',
+            'gzdeflate()')),
     );
   }
 }
diff --git a/src/applications/config/option/PhabricatorMailgunConfigOptions.php b/src/applications/config/option/PhabricatorMailgunConfigOptions.php
index 3baf4e6798..aebcba6725 100644
--- a/src/applications/config/option/PhabricatorMailgunConfigOptions.php
+++ b/src/applications/config/option/PhabricatorMailgunConfigOptions.php
@@ -25,8 +25,9 @@ final class PhabricatorMailgunConfigOptions
         ->setLocked(true)
         ->setDescription(
           pht(
-            'Mailgun domain name. See https://mailgun.com/cp/domains'))
-        ->addExample('mycompany.com', 'Use specific domain'),
+            'Mailgun domain name. See %s.',
+            'https://mailgun.com/cp/domains'))
+        ->addExample('mycompany.com', pht('Use specific domain')),
       $this->newOption('mailgun.api-key', 'string', null)
         ->setHidden(true)
         ->setDescription(pht('Mailgun API key.')),
diff --git a/src/applications/config/option/PhabricatorMetaMTAConfigOptions.php b/src/applications/config/option/PhabricatorMetaMTAConfigOptions.php
index d190f1b393..55c8c5689c 100644
--- a/src/applications/config/option/PhabricatorMetaMTAConfigOptions.php
+++ b/src/applications/config/option/PhabricatorMetaMTAConfigOptions.php
@@ -24,7 +24,7 @@ final class PhabricatorMetaMTAConfigOptions
 When a user takes an action which generates an email notification (like
 commenting on a Differential revision), Phabricator can either send that mail
 "From" the user's email address (like "alincoln@logcabin.com") or "From" the
-'metamta.default-address' address.
+'%s' address.
 
 The user experience is generally better if Phabricator uses the user's real
 address as the "From" since the messages are easier to organize when they appear
@@ -43,7 +43,8 @@ email on behalf of the "From" domain. Practically, this means:
     initially, since the risk in turning it on is that your outgoing mail will
     never arrive.
 EODOC
-));
+  ,
+  'metamta.default-address'));
 
     $one_mail_per_recipient_desc = $this->deformat(pht(<<<EODOC
 When a message is sent to multiple recipients (for example, several reviewers on
@@ -126,21 +127,23 @@ EODOC
     $vary_subjects_description = $this->deformat(pht(<<<EODOC
 If true, allow MetaMTA to change mail subjects to put text like '[Accepted]' and
 '[Commented]' in them. This makes subjects more useful, but might break
-threading on some clients. If you've set 'metamta.one-mail-per-recipient', users
-can override this setting in their preferences.
+threading on some clients. If you've set '%s', users can override this setting
+in their preferences.
 EODOC
-));
+  ,
+  'metamta.one-mail-per-recipient'));
 
     $reply_to_description = $this->deformat(pht(<<<EODOC
-If you enable {{metamta.public-replies}}, Phabricator uses "From" to
-authenticate users. You can additionally enable this setting to try to
-authenticate with 'Reply-To'. Note that this is completely spoofable and
-insecure (any user can set any 'Reply-To' address) but depending on the nature
-of your install or other deliverability conditions this might be okay.
-Generally, you can't do much more by spoofing Reply-To than be annoying (you can
-write but not read content). But this is still **COMPLETELY INSECURE**.
+If you enable `%s`, Phabricator uses "From" to authenticate users. You can
+additionally enable this setting to try to authenticate with 'Reply-To'. Note
+that this is completely spoofable and insecure (any user can set any 'Reply-To'
+address) but depending on the nature of your install or other deliverability
+conditions this might be okay. Generally, you can't do much more by spoofing
+Reply-To than be annoying (you can write but not read content). But this is
+still **COMPLETELY INSECURE**.
 EODOC
-));
+  ,
+  'metamta.public-replies'));
 
     $adapter_description = $this->deformat(pht(<<<EODOC
 Adapter class to use to transmit mail to the MTA. The default uses
diff --git a/src/applications/config/option/PhabricatorMySQLConfigOptions.php b/src/applications/config/option/PhabricatorMySQLConfigOptions.php
index b1e25ab41c..e3cd480e21 100644
--- a/src/applications/config/option/PhabricatorMySQLConfigOptions.php
+++ b/src/applications/config/option/PhabricatorMySQLConfigOptions.php
@@ -63,8 +63,8 @@ final class PhabricatorMySQLConfigOptions
             'Phabricator connects to MySQL through a swappable abstraction '.
             'layer. You can choose an alternate implementation by setting '.
             'this option. To provide your own implementation, extend '.
-            '`AphrontMySQLDatabaseConnectionBase`. It is very unlikely that '.
-            'you need to change this.')),
+            '`%s`. It is very unlikely that you need to change this.',
+            'AphrontMySQLDatabaseConnectionBase')),
       $this->newOption('storage.default-namespace', 'string', 'phabricator')
         ->setLocked(true)
         ->setSummary(
diff --git a/src/applications/config/option/PhabricatorPHDConfigOptions.php b/src/applications/config/option/PhabricatorPHDConfigOptions.php
index b07e62244c..59cb8ea728 100644
--- a/src/applications/config/option/PhabricatorPHDConfigOptions.php
+++ b/src/applications/config/option/PhabricatorPHDConfigOptions.php
@@ -23,12 +23,10 @@ final class PhabricatorPHDConfigOptions
     return array(
       $this->newOption('phd.pid-directory', 'string', '/var/tmp/phd/pid')
         ->setDescription(
-          pht(
-            'Directory that phd should use to track running daemons.')),
+          pht('Directory that phd should use to track running daemons.')),
       $this->newOption('phd.log-directory', 'string', '/var/tmp/phd/log')
         ->setDescription(
-          pht(
-            'Directory that the daemons should use to store log files.')),
+          pht('Directory that the daemons should use to store log files.')),
       $this->newOption('phd.taskmasters', 'int', 4)
         ->setSummary(pht('Maximum taskmaster daemon pool size.'))
         ->setDescription(
@@ -47,8 +45,10 @@ final class PhabricatorPHDConfigOptions
           pht(
             "Launch daemons in 'verbose' mode by default. This creates a lot ".
             "of output, but can help debug issues. Daemons launched in debug ".
-            "mode with 'phd debug' are always launched in verbose mode. See ".
-            "also 'phd.trace'.")),
+            "mode with '%s' are always launched in verbose mode. ".
+            "See also '%s'.",
+            'phd debug',
+            'phd.trace')),
       $this->newOption('phd.user', 'string', null)
         ->setLocked(true)
         ->setSummary(pht('System user to run daemons as.'))
@@ -69,8 +69,10 @@ final class PhabricatorPHDConfigOptions
           pht(
             "Launch daemons in 'trace' mode by default. This creates an ".
             "ENORMOUS amount of output, but can help debug issues. Daemons ".
-            "launched in debug mode with 'phd debug' are always launched in ".
-            "trace mode. See also 'phd.verbose'.")),
+            "launched in debug mode with '%s' are always launched in ".
+            "trace mode. See also '%s'.",
+            'phd debug',
+            'phd.verbose')),
       $this->newOption('phd.variant-config', 'list<string>', array())
         ->setDescription(
           pht(
diff --git a/src/applications/config/option/PhabricatorPHPMailerConfigOptions.php b/src/applications/config/option/PhabricatorPHPMailerConfigOptions.php
index fbe98175d1..b2d5c91e91 100644
--- a/src/applications/config/option/PhabricatorPHPMailerConfigOptions.php
+++ b/src/applications/config/option/PhabricatorPHPMailerConfigOptions.php
@@ -43,9 +43,12 @@ final class PhabricatorPHPMailerConfigOptions
         ->setSummary(pht('Configure TLS or SSL for SMTP.'))
         ->setDescription(
           pht(
-            "Using PHPMailer with SMTP, you can set this to one of 'tls' or ".
-            "'ssl' to use TLS or SSL, respectively. Leave it blank for ".
-            "vanilla SMTP. If you're sending via Gmail, set it to 'ssl'.")),
+            "Using PHPMailer with SMTP, you can set this to one of '%s' or ".
+            "'%s' to use TLS or SSL, respectively. Leave it blank for ".
+            "vanilla SMTP. If you're sending via Gmail, set it to '%s'.",
+            'tls',
+            'ssl',
+            'ssl')),
       $this->newOption('phpmailer.smtp-user', 'string', null)
         ->setLocked(true)
         ->setDescription(pht('Username for SMTP.')),
diff --git a/src/applications/config/option/PhabricatorSMSConfigOptions.php b/src/applications/config/option/PhabricatorSMSConfigOptions.php
index 973f5db13e..33b75c263f 100644
--- a/src/applications/config/option/PhabricatorSMSConfigOptions.php
+++ b/src/applications/config/option/PhabricatorSMSConfigOptions.php
@@ -20,12 +20,10 @@ final class PhabricatorSMSConfigOptions
   }
 
   public function getOptions() {
-    $adapter_description = $this->deformat(pht(<<<EODOC
-Adapter class to use to transmit SMS to an external provider. A given external
-provider will most likely need more configuration which will most likely
-require registration and payment for the service.
-EODOC
-  ));
+    $adapter_description = pht(
+      'Adapter class to use to transmit SMS to an external provider. A given '.
+      'external provider will most likely need more configuration which will '.
+      'most likely require registration and payment for the service.');
 
     return array(
       $this->newOption(
@@ -40,7 +38,7 @@ EODOC
         'class',
         null)
         ->setBaseClass('PhabricatorSMSImplementationAdapter')
-        ->setSummary(pht('Control how sms is sent.'))
+        ->setSummary(pht('Control how SMS is sent.'))
         ->setDescription($adapter_description),
       $this->newOption(
         'twilio.account-sid',
diff --git a/src/applications/config/option/PhabricatorSecurityConfigOptions.php b/src/applications/config/option/PhabricatorSecurityConfigOptions.php
index d8a8c85a92..63e43b3081 100644
--- a/src/applications/config/option/PhabricatorSecurityConfigOptions.php
+++ b/src/applications/config/option/PhabricatorSecurityConfigOptions.php
@@ -92,12 +92,13 @@ final class PhabricatorSecurityConfigOptions
             "reasonably configure more granular behavior there.\n\n".
 
             "IMPORTANT: Phabricator determines if a request is HTTPS or not ".
-            "by examining the PHP \$_SERVER['HTTPS'] variable. If you run ".
+            "by examining the PHP `%s` variable. If you run ".
             "Apache/mod_php this will probably be set correctly for you ".
             "automatically, but if you run Phabricator as CGI/FCGI (e.g., ".
             "through nginx or lighttpd), you need to configure your web ".
             "server so that it passes the value correctly based on the ".
-            "connection type."))
+            "connection type.",
+            "\$_SERVER['HTTPS']"))
         ->setBoolOptions(
           array(
             pht('Force HTTPS'),
@@ -163,7 +164,8 @@ final class PhabricatorSecurityConfigOptions
             "When users write comments which have URIs, they'll be ".
             "automatically linked if the protocol appears in this set. This ".
             "whitelist is primarily to prevent security issues like ".
-            "javascript:// URIs."))
+            "%s URIs.",
+            'javascript://'))
         ->addExample("http\nhttps", pht('Valid Setting'))
         ->setLocked(true),
       $this->newOption(
@@ -226,7 +228,7 @@ final class PhabricatorSecurityConfigOptions
           pht('Determines whether or not YouTube videos get embedded.'))
         ->setDescription(
           pht(
-            "If you enable this, linked YouTube videos will be embeded ".
+            "If you enable this, linked YouTube videos will be embedded ".
             "inline. This has mild security implications (you'll leak ".
             "referrers to YouTube) and is pretty silly (but sort of ".
             "awesome).")),
@@ -308,8 +310,10 @@ final class PhabricatorSecurityConfigOptions
         throw new PhabricatorConfigValidationException(
           pht(
             "Config option '%s' is invalid. The URI must start with ".
-            "'http://' or 'https://'.",
-            $key));
+            "'%s' or '%s'.",
+            $key,
+            'http://',
+            'https://'));
       }
 
       $domain = $uri->getDomain();
@@ -317,10 +321,11 @@ final class PhabricatorSecurityConfigOptions
         throw new PhabricatorConfigValidationException(
           pht(
             "Config option '%s' is invalid. The URI must contain a dot ('.'), ".
-            "like 'http://example.com/', not just a bare name like ".
-            "'http://example/'. Some web browsers will not set cookies on ".
-            "domains with no TLD.",
-            $key));
+            "like '%s', not just a bare name like '%s'. ".
+            "Some web browsers will not set cookies on domains with no TLD.",
+            $key,
+            'http://example.com/',
+            'http://example/'));
       }
 
       $path = $uri->getPath();
@@ -328,11 +333,11 @@ final class PhabricatorSecurityConfigOptions
         throw new PhabricatorConfigValidationException(
           pht(
             "Config option '%s' is invalid. The URI must NOT have a path, ".
-            "e.g. 'http://phabricator.example.com/' is OK, but ".
-            "'http://example.com/phabricator/' is not. Phabricator must be ".
-            "installed on an entire domain; it can not be installed on a ".
-            "path.",
-            $key));
+            "e.g. '%s' is OK, but '%s' is not. Phabricator must be installed ".
+            "on an entire domain; it can not be installed on a path.",
+            $key,
+            'http://phabricator.example.com/',
+            'http://example.com/phabricator/'));
       }
     }
   }
diff --git a/src/applications/config/option/PhabricatorSyntaxHighlightingConfigOptions.php b/src/applications/config/option/PhabricatorSyntaxHighlightingConfigOptions.php
index 90c1e87906..c2511b0f8e 100644
--- a/src/applications/config/option/PhabricatorSyntaxHighlightingConfigOptions.php
+++ b/src/applications/config/option/PhabricatorSyntaxHighlightingConfigOptions.php
@@ -34,8 +34,8 @@ final class PhabricatorSyntaxHighlightingConfigOptions
           pht(
             'Phabricator can highlight PHP by default and use Pygments for '.
             'other languages if enabled. You can provide a custom '.
-            'highlighter engine by extending class '.
-            'PhutilSyntaxHighlighterEngine.')),
+            'highlighter engine by extending class %s.',
+            'PhutilSyntaxHighlighterEngine')),
       $this->newOption('pygments.enabled', 'bool', false)
         ->setSummary(
           pht('Should Phabricator use Pygments to highlight code?'))
@@ -128,7 +128,7 @@ final class PhabricatorSyntaxHighlightingConfigOptions
             'be tested against the filename. They should map to either an '.
             'explicit language as a string value, or a numeric index into '.
             'the captured groups as an integer.'))
-      ->addExample('{"@\\.xyz$@": "php"}', pht('Highlight *.xyz as PHP.'))
+      ->addExample('{"@\\.xyz$@": "php"}', pht('Highlight %s as PHP.', '*.xyz'))
       ->addExample(
         '{"@/httpd\\.conf@": "apacheconf"}',
         pht('Highlight httpd.conf as "apacheconf".'))
diff --git a/src/applications/config/option/PhabricatorTranslationsConfigOptions.php b/src/applications/config/option/PhabricatorTranslationsConfigOptions.php
index 007c61d197..aa7b9a2b32 100644
--- a/src/applications/config/option/PhabricatorTranslationsConfigOptions.php
+++ b/src/applications/config/option/PhabricatorTranslationsConfigOptions.php
@@ -25,10 +25,10 @@ final class PhabricatorTranslationsConfigOptions
         ->setSummary(pht('Override translations.'))
         ->setDescription(
           pht(
-            "You can use 'translation.override' if you don't want to create ".
-            "a full translation to give users an option for switching to it ".
-            "and you just want to override some strings in the default ".
-            "translation."))
+            "You can use '%s' if you don't want to create a full translation ".
+            "to give users an option for switching to it and you just want to ".
+            "override some strings in the default translation.",
+            'translation.override'))
         ->addExample(
           '{"some string": "my alternative"}',
           pht('Valid Setting')),
diff --git a/src/applications/config/option/PhabricatorUIConfigOptions.php b/src/applications/config/option/PhabricatorUIConfigOptions.php
index 04896e1a20..8b84a6b4b2 100644
--- a/src/applications/config/option/PhabricatorUIConfigOptions.php
+++ b/src/applications/config/option/PhabricatorUIConfigOptions.php
@@ -50,8 +50,7 @@ EOJSON;
     return array(
       $this->newOption('ui.header-color', 'enum', 'dark')
         ->setDescription(
-          pht(
-            'Sets the color of the main header.'))
+          pht('Sets the color of the main header.'))
         ->setEnumOptions($options),
       $this->newOption('ui.footer-items', 'list<wild>', array())
         ->setSummary(
diff --git a/src/applications/conpherence/conduit/ConpherenceQueryThreadConduitAPIMethod.php b/src/applications/conpherence/conduit/ConpherenceQueryThreadConduitAPIMethod.php
index 986e8e520c..cd5fa1bff7 100644
--- a/src/applications/conpherence/conduit/ConpherenceQueryThreadConduitAPIMethod.php
+++ b/src/applications/conpherence/conduit/ConpherenceQueryThreadConduitAPIMethod.php
@@ -9,10 +9,10 @@ final class ConpherenceQueryThreadConduitAPIMethod
 
   public function getMethodDescription() {
     return pht(
-      'Query for conpherence threads for the logged in user. '.
-      'You can query by ids or phids for specific conpherence threads. '.
-      'Otherwise, specify limit and offset to query the most recently '.
-      'updated conpherences for the logged in user.');
+      'Query for Conpherence threads for the logged in user. You can query '.
+      'by IDs or PHIDs for specific Conpherence threads. Otherwise, specify '.
+      'limit and offset to query the most recently updated Conpherences for '.
+      'the logged in user.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/conpherence/conduit/ConpherenceQueryTransactionConduitAPIMethod.php b/src/applications/conpherence/conduit/ConpherenceQueryTransactionConduitAPIMethod.php
index 958748a68e..e014dc742a 100644
--- a/src/applications/conpherence/conduit/ConpherenceQueryTransactionConduitAPIMethod.php
+++ b/src/applications/conpherence/conduit/ConpherenceQueryTransactionConduitAPIMethod.php
@@ -10,9 +10,9 @@ final class ConpherenceQueryTransactionConduitAPIMethod
   public function getMethodDescription() {
     return pht(
       'Query for transactions for the logged in user within a specific '.
-      'conpherence thread. You can specify the thread by id or phid. '.
+      'Conpherence thread. You can specify the thread by ID or PHID. '.
       'Otherwise, specify limit and offset to query the most recent '.
-      'transactions within the conpherence for the logged in user.');
+      'transactions within the Conpherence for the logged in user.');
   }
 
   protected function defineParamTypes() {
@@ -31,7 +31,7 @@ final class ConpherenceQueryTransactionConduitAPIMethod
   protected function defineErrorTypes() {
     return array(
       'ERR_USAGE_NO_THREAD_ID' => pht(
-        'You must specify a thread id or thread phid to query transactions '.
+        'You must specify a thread id or thread PHID to query transactions '.
         'from.'),
     );
   }
diff --git a/src/applications/conpherence/controller/ConpherenceUpdateController.php b/src/applications/conpherence/controller/ConpherenceUpdateController.php
index 8d7db7691c..57df50c828 100644
--- a/src/applications/conpherence/controller/ConpherenceUpdateController.php
+++ b/src/applications/conpherence/controller/ConpherenceUpdateController.php
@@ -208,7 +208,7 @@ final class ConpherenceUpdateController
           $response_mode = 'ajax';
           break;
         default:
-          throw new Exception('Unknown action: '.$action);
+          throw new Exception(pht('Unknown action: %s', $action));
           break;
       }
 
diff --git a/src/applications/conpherence/mail/ConpherenceReplyHandler.php b/src/applications/conpherence/mail/ConpherenceReplyHandler.php
index a26c9d3cc6..61f925e150 100644
--- a/src/applications/conpherence/mail/ConpherenceReplyHandler.php
+++ b/src/applications/conpherence/mail/ConpherenceReplyHandler.php
@@ -14,7 +14,10 @@ final class ConpherenceReplyHandler extends PhabricatorMailReplyHandler {
 
   public function validateMailReceiver($mail_receiver) {
     if (!($mail_receiver instanceof ConpherenceThread)) {
-      throw new Exception('Mail receiver is not a ConpherenceThread!');
+      throw new Exception(
+        pht(
+          'Mail receiver is not a %s!', '
+          ConpherenceThread'));
     }
   }
 
diff --git a/src/applications/console/plugin/DarkConsoleErrorLogPlugin.php b/src/applications/console/plugin/DarkConsoleErrorLogPlugin.php
index 513f4b9905..591904a85f 100644
--- a/src/applications/console/plugin/DarkConsoleErrorLogPlugin.php
+++ b/src/applications/console/plugin/DarkConsoleErrorLogPlugin.php
@@ -84,8 +84,8 @@ final class DarkConsoleErrorLogPlugin extends DarkConsolePlugin {
 
     $table = new AphrontTableView($rows);
     $table->setClassName('error-log');
-    $table->setHeaders(array('Error'));
-    $table->setNoDataString('No errors.');
+    $table->setHeaders(array(pht('Error')));
+    $table->setNoDataString(pht('No errors.'));
 
     return phutil_tag(
       'div',
diff --git a/src/applications/console/plugin/DarkConsoleEventPlugin.php b/src/applications/console/plugin/DarkConsoleEventPlugin.php
index 02dc4e8b78..070227c12d 100644
--- a/src/applications/console/plugin/DarkConsoleEventPlugin.php
+++ b/src/applications/console/plugin/DarkConsoleEventPlugin.php
@@ -3,11 +3,11 @@
 final class DarkConsoleEventPlugin extends DarkConsolePlugin {
 
   public function getName() {
-    return 'Events';
+    return pht('Events');
   }
 
   public function getDescription() {
-    return 'Information about Phabricator events and event listeners.';
+    return pht('Information about Phabricator events and event listeners.');
   }
 
   public function generateData() {
@@ -51,8 +51,8 @@ final class DarkConsoleEventPlugin extends DarkConsolePlugin {
     $table = new AphrontTableView($rows);
     $table->setHeaders(
       array(
-        'Internal ID',
-        'Listener Class',
+        pht('Internal ID'),
+        pht('Listener Class'),
       ));
     $table->setColumnClasses(
       array(
@@ -71,7 +71,7 @@ final class DarkConsoleEventPlugin extends DarkConsolePlugin {
     foreach ($data['events'] as $event) {
       $rows[] = array(
         $event['type'],
-        $event['stopped'] ? 'STOPPED' : null,
+        $event['stopped'] ? pht('STOPPED') : null,
       );
     }
 
@@ -82,8 +82,8 @@ final class DarkConsoleEventPlugin extends DarkConsolePlugin {
       ));
     $table->setHeaders(
       array(
-        'Event Type',
-        'Stopped',
+        pht('Event Type'),
+        pht('Stopped'),
       ));
 
     $out[] = $table->render();
diff --git a/src/applications/console/plugin/DarkConsoleRequestPlugin.php b/src/applications/console/plugin/DarkConsoleRequestPlugin.php
index b354b328c2..8333903131 100644
--- a/src/applications/console/plugin/DarkConsoleRequestPlugin.php
+++ b/src/applications/console/plugin/DarkConsoleRequestPlugin.php
@@ -3,11 +3,14 @@
 final class DarkConsoleRequestPlugin extends DarkConsolePlugin {
 
   public function getName() {
-    return 'Request';
+    return pht('Request');
   }
 
   public function getDescription() {
-    return 'Information about $_REQUEST and $_SERVER.';
+    return pht(
+      'Information about %s and %s.',
+      '$_REQUEST',
+      '$_SERVER');
   }
 
   public function generateData() {
@@ -47,7 +50,7 @@ final class DarkConsoleRequestPlugin extends DarkConsolePlugin {
         if (isset($mask[$key])) {
           $rows[] = array(
             $key,
-            phutil_tag('em', array(), '(Masked)'),
+            phutil_tag('em', array(), pht('(Masked)')),
           );
         } else {
           $rows[] = array(
diff --git a/src/applications/console/plugin/DarkConsoleServicesPlugin.php b/src/applications/console/plugin/DarkConsoleServicesPlugin.php
index 7f33f9ba6d..6a59c7e129 100644
--- a/src/applications/console/plugin/DarkConsoleServicesPlugin.php
+++ b/src/applications/console/plugin/DarkConsoleServicesPlugin.php
@@ -5,11 +5,11 @@ final class DarkConsoleServicesPlugin extends DarkConsolePlugin {
   protected $observations;
 
   public function getName() {
-    return 'Services';
+    return pht('Services');
   }
 
   public function getDescription() {
-    return 'Information about services.';
+    return pht('Information about services.');
   }
 
   public static function getQueryAnalyzerHeader() {
@@ -44,7 +44,7 @@ final class DarkConsoleServicesPlugin extends DarkConsolePlugin {
         $log[$key]['explain'] = array(
           'sev'     => 7,
           'size'    => null,
-          'reason'  => 'Disabled',
+          'reason'  => pht('Disabled'),
         );
         // Query analysis is disabled for this request, so don't do any of it.
         continue;
@@ -102,26 +102,26 @@ final class DarkConsoleServicesPlugin extends DarkConsolePlugin {
                 if (preg_match('/Using where/', $table['Extra'])) {
                   if ($table['rows'] < 256 && !empty($table['possible_keys'])) {
                     $cur_badness = 2;
-                    $cur_reason = 'Small Table Scan';
+                    $cur_reason = pht('Small Table Scan');
                   } else {
                     $cur_badness = 6;
-                    $cur_reason = 'TABLE SCAN!';
+                    $cur_reason = pht('TABLE SCAN!');
                   }
                 } else {
                   $cur_badness = 3;
-                  $cur_reason = 'Whole Table';
+                  $cur_reason = pht('Whole Table');
                 }
                 break;
               default:
                 if (preg_match('/No tables used/i', $table['Extra'])) {
                   $cur_badness = 1;
-                  $cur_reason = 'No Tables';
+                  $cur_reason = pht('No Tables');
                 } else if (preg_match('/Impossible/i', $table['Extra'])) {
                   $cur_badness = 1;
-                  $cur_reason = 'Empty';
+                  $cur_reason = pht('Empty');
                 } else {
                   $cur_badness = 4;
-                  $cur_reason = "Can't Analyze";
+                  $cur_reason = pht("Can't Analyze");
                 }
                 break;
             }
@@ -198,7 +198,7 @@ final class DarkConsoleServicesPlugin extends DarkConsolePlugin {
       $summary[] = array(
         $type,
         number_format($counts[$type]),
-        number_format((int)(1000000 * $totals[$type])).' us',
+        pht('%d us', number_format((int)(1000000 * $totals[$type]))),
         sprintf('%.1f%%', 100 * $totals[$type] / $page_total),
       );
     }
@@ -212,10 +212,10 @@ final class DarkConsoleServicesPlugin extends DarkConsolePlugin {
       ));
     $summary_table->setHeaders(
       array(
-        'Type',
-        'Count',
-        'Total Cost',
-        'Page Weight',
+        pht('Type'),
+        pht('Count'),
+        pht('Total Cost'),
+        pht('Page Weight'),
       ));
 
     $results[] = $summary_table->render();
@@ -260,8 +260,8 @@ final class DarkConsoleServicesPlugin extends DarkConsolePlugin {
 
       $rows[] = array(
         $row['type'],
-        '+'.number_format(1000 * ($row['begin'] - $data['start'])).' ms',
-        number_format(1000000 * $row['duration']).' us',
+        pht('+%d ms', number_format(1000 * ($row['begin'] - $data['start']))),
+        pht('%d us', number_format(1000000 * $row['duration'])),
         $info,
         $analysis,
       );
@@ -278,11 +278,11 @@ final class DarkConsoleServicesPlugin extends DarkConsolePlugin {
       ));
     $table->setHeaders(
       array(
-        'Event',
-        'Start',
-        'Duration',
-        'Details',
-        'Analysis',
+        pht('Event'),
+        pht('Start'),
+        pht('Duration'),
+        pht('Details'),
+        pht('Analysis'),
       ));
 
     $results[] = $table->render();
diff --git a/src/applications/console/plugin/DarkConsoleXHProfPlugin.php b/src/applications/console/plugin/DarkConsoleXHProfPlugin.php
index 2a0d22f775..f751cc31a5 100644
--- a/src/applications/console/plugin/DarkConsoleXHProfPlugin.php
+++ b/src/applications/console/plugin/DarkConsoleXHProfPlugin.php
@@ -5,7 +5,7 @@ final class DarkConsoleXHProfPlugin extends DarkConsolePlugin {
   protected $profileFilePHID;
 
   public function getName() {
-    return 'XHProf';
+    return pht('XHProf');
   }
 
   public function getColor() {
@@ -17,7 +17,7 @@ final class DarkConsoleXHProfPlugin extends DarkConsolePlugin {
   }
 
   public function getDescription() {
-    return 'Provides detailed PHP profiling information through XHProf.';
+    return pht('Provides detailed PHP profiling information through XHProf.');
   }
 
   public function generateData() {
@@ -47,14 +47,14 @@ final class DarkConsoleXHProfPlugin extends DarkConsolePlugin {
           'href' => $href,
           'class' => 'bright-link',
         ),
-        'Installation Guide');
+        pht('Installation Guide'));
       return hsprintf(
-        '<div class="dark-console-no-content">'.
+        '<div class="dark-console-no-content">%s</div>',
+        pht(
           'The "xhprof" PHP extension is not available. Install xhprof '.
           'to enable the XHProf console plugin. You can find instructions in '.
-          'the %s.'.
-        '</div>',
-        $install_guide);
+          'the %s.',
+          $install_guide));
     }
 
     $result = array();
diff --git a/src/applications/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php b/src/applications/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php
index 5d9723cc4b..3067472cf2 100644
--- a/src/applications/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php
+++ b/src/applications/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php
@@ -67,7 +67,7 @@ final class DarkConsoleErrorLogPluginAPI {
         );
         break;
       default:
-        error_log('Unknown event : '.$event);
+        error_log(pht('Unknown event: %s', $event));
         break;
     }
   }
diff --git a/src/applications/countdown/controller/PhabricatorCountdownDeleteController.php b/src/applications/countdown/controller/PhabricatorCountdownDeleteController.php
index d57534a420..5dfbd18146 100644
--- a/src/applications/countdown/controller/PhabricatorCountdownDeleteController.php
+++ b/src/applications/countdown/controller/PhabricatorCountdownDeleteController.php
@@ -33,8 +33,9 @@ final class PhabricatorCountdownDeleteController
         ->setURI('/countdown/');
     }
 
-    $inst = pht('Are you sure you want to delete the countdown %s?',
-            $countdown->getTitle());
+    $inst = pht(
+      'Are you sure you want to delete the countdown %s?',
+      $countdown->getTitle());
 
     $dialog = new AphrontDialogView();
     $dialog->setUser($request->getUser());
diff --git a/src/applications/daemon/controller/PhabricatorDaemonConsoleController.php b/src/applications/daemon/controller/PhabricatorDaemonConsoleController.php
index cd549a6844..76d98bda5c 100644
--- a/src/applications/daemon/controller/PhabricatorDaemonConsoleController.php
+++ b/src/applications/daemon/controller/PhabricatorDaemonConsoleController.php
@@ -50,7 +50,7 @@ final class PhabricatorDaemonConsoleController
       $rows[] = array(
         $class,
         number_format($info['n']),
-        number_format((int)($info['duration'] / $info['n'])).' us',
+        pht('%d us', number_format((int)($info['duration'] / $info['n']))),
       );
     }
 
diff --git a/src/applications/daemon/controller/PhabricatorDaemonLogViewController.php b/src/applications/daemon/controller/PhabricatorDaemonLogViewController.php
index 17d998fe7c..baab0528e3 100644
--- a/src/applications/daemon/controller/PhabricatorDaemonLogViewController.php
+++ b/src/applications/daemon/controller/PhabricatorDaemonLogViewController.php
@@ -148,12 +148,10 @@ final class PhabricatorDaemonLogViewController
           phutil_format_relative_time($wait_time));
         break;
       case PhabricatorDaemonLog::STATUS_EXITING:
-        $details = pht(
-          'This daemon is shutting down gracefully.');
+        $details = pht('This daemon is shutting down gracefully.');
         break;
       case PhabricatorDaemonLog::STATUS_EXITED:
-        $details = pht(
-          'This daemon exited normally and is no longer running.');
+        $details = pht('This daemon exited normally and is no longer running.');
         break;
     }
 
diff --git a/src/applications/daemon/controller/PhabricatorWorkerTaskDetailController.php b/src/applications/daemon/controller/PhabricatorWorkerTaskDetailController.php
index c7254de181..57951ccb91 100644
--- a/src/applications/daemon/controller/PhabricatorWorkerTaskDetailController.php
+++ b/src/applications/daemon/controller/PhabricatorWorkerTaskDetailController.php
@@ -95,7 +95,7 @@ final class PhabricatorWorkerTaskDetailController
           $status = pht('Cancelled');
           break;
         default:
-          throw new Exception('Unknown task status!');
+          throw new Exception(pht('Unknown task status!'));
       }
     } else {
       $status = pht('Queued');
@@ -141,7 +141,7 @@ final class PhabricatorWorkerTaskDetailController
       $expires);
 
     if ($task->isArchived()) {
-      $duration = number_format($task->getDuration()).' us';
+      $duration = pht('%d us', number_format($task->getDuration()));
     } else {
       $duration = phutil_tag('em', array(), pht('Not Completed'));
     }
diff --git a/src/applications/daemon/management/PhabricatorDaemonManagementDebugWorkflow.php b/src/applications/daemon/management/PhabricatorDaemonManagementDebugWorkflow.php
index 23d5a54eeb..e2023ae143 100644
--- a/src/applications/daemon/management/PhabricatorDaemonManagementDebugWorkflow.php
+++ b/src/applications/daemon/management/PhabricatorDaemonManagementDebugWorkflow.php
@@ -23,8 +23,10 @@ final class PhabricatorDaemonManagementDebugWorkflow
           ),
           array(
             'name' => 'as-current-user',
-            'help' => 'Run the daemon as the current user '.
-              'instead of the configured phd.user',
+            'help' => pht(
+              'Run the daemon as the current user '.
+              'instead of the configured %s',
+              'phd.user'),
           ),
           array(
             'name' => 'autoscale',
diff --git a/src/applications/daemon/management/PhabricatorDaemonManagementLogWorkflow.php b/src/applications/daemon/management/PhabricatorDaemonManagementLogWorkflow.php
index b32c1439f6..394b4735a5 100644
--- a/src/applications/daemon/management/PhabricatorDaemonManagementLogWorkflow.php
+++ b/src/applications/daemon/management/PhabricatorDaemonManagementLogWorkflow.php
@@ -17,15 +17,15 @@ final class PhabricatorDaemonManagementLogWorkflow
           array(
             'name'    => 'id',
             'param'   => 'id',
-            'help'    => 'Show logs for daemon(s) with given ID(s).',
+            'help'    => pht('Show logs for daemon(s) with given ID(s).'),
             'repeat'  => true,
           ),
           array(
             'name'    => 'limit',
             'param'   => 'N',
             'default' => 100,
-            'help'    => 'Show a specific number of log messages '.
-                         '(default 100).',
+            'help'    => pht(
+              'Show a specific number of log messages (default 100).'),
           ),
         ));
   }
@@ -87,7 +87,7 @@ final class PhabricatorDaemonManagementLogWorkflow
 
       $console->writeOut(
         "%s\n",
-        sprintf(
+        pht(
           'Daemon %d %s [%s] %s',
           $id,
           $type,
diff --git a/src/applications/daemon/management/PhabricatorDaemonManagementReloadWorkflow.php b/src/applications/daemon/management/PhabricatorDaemonManagementReloadWorkflow.php
index 4a7d9a764d..fa70231a0a 100644
--- a/src/applications/daemon/management/PhabricatorDaemonManagementReloadWorkflow.php
+++ b/src/applications/daemon/management/PhabricatorDaemonManagementReloadWorkflow.php
@@ -10,7 +10,8 @@ final class PhabricatorDaemonManagementReloadWorkflow
         pht(
           'Gracefully restart daemon processes in-place to pick up changes '.
           'to source. This will not disrupt running jobs. This is an '.
-          'advanced workflow; most installs should use __phd restart__.'))
+          'advanced workflow; most installs should use __%s__.',
+          'phd restart'))
       ->setArguments(
         array(
           array(
diff --git a/src/applications/daemon/management/PhabricatorDaemonManagementRestartWorkflow.php b/src/applications/daemon/management/PhabricatorDaemonManagementRestartWorkflow.php
index 5d8d6df89e..adb6490f08 100644
--- a/src/applications/daemon/management/PhabricatorDaemonManagementRestartWorkflow.php
+++ b/src/applications/daemon/management/PhabricatorDaemonManagementRestartWorkflow.php
@@ -6,9 +6,7 @@ final class PhabricatorDaemonManagementRestartWorkflow
   protected function didConstruct() {
     $this
       ->setName('restart')
-      ->setSynopsis(
-        pht(
-          'Stop, then start the standard daemon loadout.'))
+      ->setSynopsis(pht('Stop, then start the standard daemon loadout.'))
       ->setArguments(
         array(
           array(
diff --git a/src/applications/daemon/management/PhabricatorDaemonManagementStartWorkflow.php b/src/applications/daemon/management/PhabricatorDaemonManagementStartWorkflow.php
index d489dca88b..9a807357a7 100644
--- a/src/applications/daemon/management/PhabricatorDaemonManagementStartWorkflow.php
+++ b/src/applications/daemon/management/PhabricatorDaemonManagementStartWorkflow.php
@@ -9,20 +9,21 @@ final class PhabricatorDaemonManagementStartWorkflow
       ->setSynopsis(
         pht(
           'Start the standard configured collection of Phabricator daemons. '.
-          'This is appropriate for most installs. Use **phd launch** to '.
-          'customize which daemons are launched.'))
+          'This is appropriate for most installs. Use **%s** to '.
+          'customize which daemons are launched.',
+          'phd launch'))
       ->setArguments(
         array(
           array(
             'name' => 'keep-leases',
             'help' => pht(
-              'By default, **phd start** will free all task leases held by '.
-              'the daemons. With this flag, this step will be skipped.'),
+              'By default, **%s** will free all task leases held by '.
+              'the daemons. With this flag, this step will be skipped.',
+              'phd start'),
           ),
           array(
             'name' => 'force',
-            'help' => pht(
-              'Start daemons even if daemons are already running.'),
+            'help' => pht('Start daemons even if daemons are already running.'),
           ),
           $this->getAutoscaleReserveArgument(),
         ));
diff --git a/src/applications/daemon/management/PhabricatorDaemonManagementStatusWorkflow.php b/src/applications/daemon/management/PhabricatorDaemonManagementStatusWorkflow.php
index 9fc3cc016e..343e42ba63 100644
--- a/src/applications/daemon/management/PhabricatorDaemonManagementStatusWorkflow.php
+++ b/src/applications/daemon/management/PhabricatorDaemonManagementStatusWorkflow.php
@@ -75,7 +75,7 @@ final class PhabricatorDaemonManagementStatusWorkflow
         if (!$daemon->isRunning()) {
           $daemon->updateStatus(PhabricatorDaemonLog::STATUS_DEAD);
           $status = 2;
-          $name = '<DEAD> '.$name;
+          $name = pht('<DEAD> %s', $name);
         }
 
         $daemon_log = $daemon->getDaemonLog();
diff --git a/src/applications/daemon/management/PhabricatorDaemonManagementStopWorkflow.php b/src/applications/daemon/management/PhabricatorDaemonManagementStopWorkflow.php
index e57c617c83..c54a7e9fee 100644
--- a/src/applications/daemon/management/PhabricatorDaemonManagementStopWorkflow.php
+++ b/src/applications/daemon/management/PhabricatorDaemonManagementStopWorkflow.php
@@ -9,7 +9,8 @@ final class PhabricatorDaemonManagementStopWorkflow
       ->setSynopsis(
         pht(
           'Stop all running daemons, or specific daemons identified by PIDs. '.
-          'Use **phd status** to find PIDs.'))
+          'Use **%s** to find PIDs.',
+          'phd status'))
       ->setArguments(
         array(
           array(
diff --git a/src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php b/src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php
index def781b4a5..63303d6fb7 100644
--- a/src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php
+++ b/src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php
@@ -28,10 +28,15 @@ abstract class PhabricatorDaemonManagementWorkflow
       list($err) = exec_manual('mkdir -p %s', $path);
       if ($err) {
         throw new Exception(
-          "phd requires the directory '{$path}' to exist, but it does not ".
-          "exist and could not be created. Create this directory or update ".
-          "'phd.pid-directory' / 'phd.log-directory' in your configuration ".
-          "to point to an existing directory.");
+          pht(
+            "%s requires the directory '%s' to exist, but it does not exist ".
+            "and could not be created. Create this directory or update ".
+            "'%s' / '%s' in your configuration to point to an existing ".
+            "directory.",
+            'phd',
+            $path,
+            'phd.pid-directory',
+            'phd.log-directory'));
       }
     }
     return $path;
@@ -95,9 +100,9 @@ abstract class PhabricatorDaemonManagementWorkflow
     if (count($match) == 0) {
       throw new PhutilArgumentUsageException(
         pht(
-          "No daemons match '%s'! Use 'phd list' for a list of available ".
-          "daemons.",
-          $substring));
+          "No daemons match '%s'! Use '%s' for a list of available daemons.",
+          $substring,
+          'phd list'));
     } else if (count($match) > 1) {
       throw new PhutilArgumentUsageException(
         pht(
@@ -130,14 +135,21 @@ abstract class PhabricatorDaemonManagementWorkflow
       $current_user = $current_user['name'];
       if ($phd_user && $phd_user != $current_user) {
         if ($debug) {
-          throw new PhutilArgumentUsageException(pht(
-            'You are trying to run a daemon as a nonstandard user, '.
-            'and `phd` was not able to `sudo` to the correct user. '."\n".
-            'Phabricator is configured to run daemons as "%s", '.
-            'but the current user is "%s". '."\n".
-            'Use `sudo` to run as a different user, pass `--as-current-user` '.
-            'to ignore this warning, or edit `phd.user` '.
-            'to change the configuration.', $phd_user, $current_user));
+          throw new PhutilArgumentUsageException(
+            pht(
+              "You are trying to run a daemon as a nonstandard user, ".
+              "and `%s` was not able to `%s` to the correct user. \n".
+              'Phabricator is configured to run daemons as "%s", '.
+              'but the current user is "%s". '."\n".
+              'Use `%s` to run as a different user, pass `%s` to ignore this '.
+              'warning, or edit `%s` to change the configuration.',
+              'phd',
+              'sudo',
+              $phd_user,
+              $current_user,
+              'sudo',
+              '--as-current-user',
+              'phd.user'));
         } else {
           $this->runDaemonsAsUser = $phd_user;
           $console->writeOut(pht('Starting daemons as %s', $phd_user)."\n");
@@ -213,8 +225,9 @@ abstract class PhabricatorDaemonManagementWorkflow
           $this->runDaemonsAsUser);
       } catch (Exception $e) {
         // Retry without sudo
-        $console->writeOut(pht(
-          "sudo command failed. Starting daemon as current user\n"));
+        $console->writeOut(
+          "%s\n",
+          pht('sudo command failed. Starting daemon as current user.'));
         $this->executeDaemonLaunchCommand(
           $command,
           $daemon_script_dir,
@@ -270,8 +283,10 @@ abstract class PhabricatorDaemonManagementWorkflow
 
   private static function mustHaveExtension($ext) {
     if (!extension_loaded($ext)) {
-      echo "ERROR: The PHP extension '{$ext}' is not installed. You must ".
-           "install it to run daemons on this machine.\n";
+      echo pht(
+        "ERROR: The PHP extension '%s' is not installed. You must ".
+        "install it to run daemons on this machine.\n",
+        $ext);
       exit(1);
     }
 
@@ -279,8 +294,10 @@ abstract class PhabricatorDaemonManagementWorkflow
     foreach ($extension->getFunctions() as $function) {
       $function = $function->name;
       if (!function_exists($function)) {
-        echo "ERROR: The PHP function {$function}() is disabled. You must ".
-             "enable it to run daemons on this machine.\n";
+        echo pht(
+          "ERROR: The PHP function %s is disabled. You must ".
+          "enable it to run daemons on this machine.\n",
+          $function.'()');
         exit(1);
       }
     }
@@ -311,11 +328,15 @@ abstract class PhabricatorDaemonManagementWorkflow
           $message = pht(
             "phd start: Unable to start daemons because daemons are already ".
             "running.\n\n".
-            "You can view running daemons with 'phd status'.\n".
-            "You can stop running daemons with 'phd stop'.\n".
-            "You can use 'phd restart' to stop all daemons before starting ".
+            "You can view running daemons with '%s'.\n".
+            "You can stop running daemons with '%s'.\n".
+            "You can use '%s' to stop all daemons before starting ".
             "new daemons.\n".
-            "You can force daemons to start anyway with --force.");
+            "You can force daemons to start anyway with %s.",
+            'phd status',
+            'phd stop',
+            'phd restart',
+            '--force');
 
           $console->writeErr("%s\n", $message);
           exit(1);
@@ -352,7 +373,7 @@ abstract class PhabricatorDaemonManagementWorkflow
 
     $this->launchDaemons($daemons, $is_debug = false);
 
-    $console->writeErr(pht('Done.')."\n");
+    $console->writeErr("%s\n", pht('Done.'));
     return 0;
   }
 
@@ -369,8 +390,9 @@ abstract class PhabricatorDaemonManagementWorkflow
     if ($gently && $force) {
       throw new PhutilArgumentUsageException(
         pht(
-          'You can not specify conflicting options --gently and --force '.
-          'together.'));
+          'You can not specify conflicting options %s and %s together.',
+          '--gently',
+          '--force'));
     }
 
     $daemons = $this->loadRunningDaemons();
@@ -383,8 +405,9 @@ abstract class PhabricatorDaemonManagementWorkflow
           $force);
       }
       if (!$survivors) {
-        $console->writeErr(pht(
-          'There are no running Phabricator daemons.')."\n");
+        $console->writeErr(
+          "%s\n",
+          pht('There are no running Phabricator daemons.'));
       }
       return 0;
     }
@@ -392,7 +415,7 @@ abstract class PhabricatorDaemonManagementWorkflow
     $stop_pids = $this->selectDaemonPIDs($daemons, $pids);
 
     if (!$stop_pids) {
-      $console->writeErr(pht('No daemons to kill.')."\n");
+      $console->writeErr("%s\n", pht('No daemons to kill.'));
       return 0;
     }
 
@@ -470,12 +493,13 @@ abstract class PhabricatorDaemonManagementWorkflow
         $survivors = $this->sendStopSignals($rogue_pids, $grace_period);
         if ($survivors) {
           $console->writeErr(
+            "%s\n",
             pht(
               'Unable to stop processes running without PID files. '.
-              'Try running this command again with sudo.')."\n");
+              'Try running this command again with sudo.'));
         }
       } else if ($warn) {
-        $console->writeErr($this->getForceStopHint($rogue_daemons)."\n");
+        $console->writeErr("%s\n", $this->getForceStopHint($rogue_daemons));
       }
     }
 
@@ -488,11 +512,11 @@ abstract class PhabricatorDaemonManagementWorkflow
       $debug_output .= $rogue['pid'].' '.$rogue['command']."\n";
     }
     return pht(
-      'There are processes running that look like Phabricator daemons but '.
-      'have no corresponding PID files:'."\n\n".'%s'."\n\n".
-      'Stop these processes by re-running this command with the --force '.
-      'parameter.',
-      $debug_output);
+      "There are processes running that look like Phabricator daemons but ".
+      "have no corresponding PID files:\n\n%s\n\n".
+      "Stop these processes by re-running this command with the %s parameter.",
+      $debug_output,
+      '--force');
   }
 
   private function sendStopSignals($pids, $grace_period) {
diff --git a/src/applications/daemon/view/PhabricatorDaemonLogEventsView.php b/src/applications/daemon/view/PhabricatorDaemonLogEventsView.php
index b06ebdd7d2..4c0caa6fd7 100644
--- a/src/applications/daemon/view/PhabricatorDaemonLogEventsView.php
+++ b/src/applications/daemon/view/PhabricatorDaemonLogEventsView.php
@@ -99,7 +99,7 @@ final class PhabricatorDaemonLogEventsView extends AphrontView {
             array(
               'href' => '/daemon/log/'.$event->getLogID().'/',
             ),
-            'Daemon '.$event->getLogID()));
+            pht('Daemon %s', $event->getLogID())));
       }
 
       $rows[] = $row;
diff --git a/src/applications/dashboard/controller/PhabricatorDashboardEditController.php b/src/applications/dashboard/controller/PhabricatorDashboardEditController.php
index cad74f7a5f..26ddd2870a 100644
--- a/src/applications/dashboard/controller/PhabricatorDashboardEditController.php
+++ b/src/applications/dashboard/controller/PhabricatorDashboardEditController.php
@@ -56,7 +56,7 @@ final class PhabricatorDashboardEditController
       $button = pht('Create Dashboard');
       $cancel_uri = $this->getApplicationURI();
 
-      $crumbs->addTextCrumb('Create Dashboard');
+      $crumbs->addTextCrumb(pht('Create Dashboard'));
     } else {
       $id = $dashboard->getID();
       $cancel_uri = $this->getApplicationURI('manage/'.$id.'/');
@@ -226,11 +226,9 @@ final class PhabricatorDashboardEditController
               "This is a simple template dashboard. You can edit this panel ".
               "to change this text and replace it with a welcome message, or ".
               "leave this placeholder text as-is to give your dashboard a ".
-              "rustic, authentic feel.".
-              "\n\n".
+              "rustic, authentic feel.\n\n".
               "You can drag, remove, add, and edit panels to customize the ".
-              "rest of this dashboard to show the information you want.".
-              "\n\n".
+              "rest of this dashboard to show the information you want.\n\n".
               "To install this dashboard on the home page, use the ".
               "**Install Dashboard** action link above."),
           ));
diff --git a/src/applications/dashboard/layoutconfig/PhabricatorDashboardLayoutConfig.php b/src/applications/dashboard/layoutconfig/PhabricatorDashboardLayoutConfig.php
index af4a947c8e..9909515f06 100644
--- a/src/applications/dashboard/layoutconfig/PhabricatorDashboardLayoutConfig.php
+++ b/src/applications/dashboard/layoutconfig/PhabricatorDashboardLayoutConfig.php
@@ -124,10 +124,10 @@ final class PhabricatorDashboardLayoutConfig {
         );
         break;
       case self::MODE_FULL:
-        throw new Exception('There is only one column in mode full.');
+        throw new Exception(pht('There is only one column in mode full.'));
         break;
       default:
-        throw new Exception('Unknown layout mode!');
+        throw new Exception(pht('Unknown layout mode!'));
         break;
     }
 
diff --git a/src/applications/differential/__tests__/DifferentialParseRenderTestCase.php b/src/applications/differential/__tests__/DifferentialParseRenderTestCase.php
index 9805cc7259..c278ff0c67 100644
--- a/src/applications/differential/__tests__/DifferentialParseRenderTestCase.php
+++ b/src/applications/differential/__tests__/DifferentialParseRenderTestCase.php
@@ -109,8 +109,7 @@ final class DifferentialParseRenderTestCase extends PhabricatorTestCase {
       } else if ($type == 'two') {
         $cparser->setRenderer(new DifferentialChangesetTwoUpTestRenderer());
       } else {
-        throw new Exception(
-          pht('Unknown renderer type "%s"!', $type));
+        throw new Exception(pht('Unknown renderer type "%s"!', $type));
       }
 
       $parsers[] = $cparser;
diff --git a/src/applications/differential/application/PhabricatorDifferentialApplication.php b/src/applications/differential/application/PhabricatorDifferentialApplication.php
index 1aca323457..7bbe133427 100644
--- a/src/applications/differential/application/PhabricatorDifferentialApplication.php
+++ b/src/applications/differential/application/PhabricatorDifferentialApplication.php
@@ -50,11 +50,9 @@ final class PhabricatorDifferentialApplication extends PhabricatorApplication {
   }
 
   public function getOverview() {
-    return pht(<<<EOTEXT
-Differential is a **code review application** which allows engineers to review,
-discuss and approve changes to software.
-EOTEXT
-);
+    return pht(
+      'Differential is a **code review application** which allows '.
+      'engineers to review, discuss and approve changes to software.');
   }
 
   public function getRoutes() {
diff --git a/src/applications/differential/conduit/DifferentialCloseConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialCloseConduitAPIMethod.php
index 58fed6cf6e..bd097c4b2f 100644
--- a/src/applications/differential/conduit/DifferentialCloseConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialCloseConduitAPIMethod.php
@@ -23,7 +23,7 @@ final class DifferentialCloseConduitAPIMethod
 
   protected function defineErrorTypes() {
     return array(
-      'ERR_NOT_FOUND' => 'Revision was not found.',
+      'ERR_NOT_FOUND' => pht('Revision was not found.'),
     );
   }
 
diff --git a/src/applications/differential/conduit/DifferentialCreateCommentConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialCreateCommentConduitAPIMethod.php
index fe1d57857d..c5d2bdb9dc 100644
--- a/src/applications/differential/conduit/DifferentialCreateCommentConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialCreateCommentConduitAPIMethod.php
@@ -27,7 +27,7 @@ final class DifferentialCreateCommentConduitAPIMethod
 
   protected function defineErrorTypes() {
     return array(
-      'ERR_BAD_REVISION' => 'Bad revision ID.',
+      'ERR_BAD_REVISION' => pht('Bad revision ID.'),
     );
   }
 
diff --git a/src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php
index 8839eee6d7..91b5ca8653 100644
--- a/src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php
@@ -8,7 +8,7 @@ final class DifferentialCreateDiffConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Create a new Differential diff.';
+    return pht('Create a new Differential diff.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/differential/conduit/DifferentialCreateInlineConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialCreateInlineConduitAPIMethod.php
index 98a567b0b8..6447385558 100644
--- a/src/applications/differential/conduit/DifferentialCreateInlineConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialCreateInlineConduitAPIMethod.php
@@ -8,7 +8,7 @@ final class DifferentialCreateInlineConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Add an inline comment to a Differential revision.';
+    return pht('Add an inline comment to a Differential revision.');
   }
 
   protected function defineParamTypes() {
@@ -29,11 +29,16 @@ final class DifferentialCreateInlineConduitAPIMethod
 
   protected function defineErrorTypes() {
     return array(
-      'ERR-BAD-REVISION' => 'Bad revision ID.',
-      'ERR-BAD-DIFF'     => 'Bad diff ID, or diff does not belong to revision.',
-      'ERR-NEED-DIFF'    => 'Neither revision ID nor diff ID was provided.',
-      'ERR-NEED-FILE'    => 'A file path was not provided.',
-      'ERR-BAD-FILE'     => "Requested file doesn't exist in this revision.",
+      'ERR-BAD-REVISION' => pht(
+        'Bad revision ID.'),
+      'ERR-BAD-DIFF'     => pht(
+        'Bad diff ID, or diff does not belong to revision.'),
+      'ERR-NEED-DIFF'    => pht(
+        'Neither revision ID nor diff ID was provided.'),
+      'ERR-NEED-FILE'    => pht(
+        'A file path was not provided.'),
+      'ERR-BAD-FILE'     => pht(
+        "Requested file doesn't exist in this revision."),
     );
   }
 
diff --git a/src/applications/differential/conduit/DifferentialCreateRevisionConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialCreateRevisionConduitAPIMethod.php
index de0c3e02d5..95b4309c70 100644
--- a/src/applications/differential/conduit/DifferentialCreateRevisionConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialCreateRevisionConduitAPIMethod.php
@@ -27,7 +27,7 @@ final class DifferentialCreateRevisionConduitAPIMethod
 
   protected function defineErrorTypes() {
     return array(
-      'ERR_BAD_DIFF' => 'Bad diff ID.',
+      'ERR_BAD_DIFF' => pht('Bad diff ID.'),
     );
   }
 
diff --git a/src/applications/differential/conduit/DifferentialFindConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialFindConduitAPIMethod.php
index 56cb0f08da..92dce067fe 100644
--- a/src/applications/differential/conduit/DifferentialFindConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialFindConduitAPIMethod.php
@@ -12,11 +12,11 @@ final class DifferentialFindConduitAPIMethod
   }
 
   public function getMethodStatusDescription() {
-    return "Replaced by 'differential.query'.";
+    return pht("Replaced by '%s'.", 'differential.query');
   }
 
   public function getMethodDescription() {
-    return 'Query Differential revisions which match certain criteria.';
+    return pht('Query Differential revisions which match certain criteria.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/differential/conduit/DifferentialFinishPostponedLintersConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialFinishPostponedLintersConduitAPIMethod.php
index 093f06e117..f53340f06b 100644
--- a/src/applications/differential/conduit/DifferentialFinishPostponedLintersConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialFinishPostponedLintersConduitAPIMethod.php
@@ -8,8 +8,9 @@ final class DifferentialFinishPostponedLintersConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Update diff with new lint messages and mark postponed '.
-           'linters as finished.';
+    return pht(
+      'Update diff with new lint messages and mark postponed '.
+      'linters as finished.');
   }
 
   protected function defineParamTypes() {
@@ -25,14 +26,13 @@ final class DifferentialFinishPostponedLintersConduitAPIMethod
 
   protected function defineErrorTypes() {
     return array(
-      'ERR-BAD-DIFF'   => 'Bad diff ID.',
-      'ERR-BAD-LINTER' => 'No postponed linter by the given name',
-      'ERR-NO-LINT'    => 'No postponed lint field available in diff',
+      'ERR-BAD-DIFF'   => pht('Bad diff ID.'),
+      'ERR-BAD-LINTER' => pht('No postponed linter by the given name.'),
+      'ERR-NO-LINT'    => pht('No postponed lint field available in diff.'),
     );
   }
 
   protected function execute(ConduitAPIRequest $request) {
-
     $diff_id = $request->getValue('diffID');
     $linter_map = $request->getValue('linters');
 
diff --git a/src/applications/differential/conduit/DifferentialGetAllDiffsConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialGetAllDiffsConduitAPIMethod.php
index c4e2d35215..187e1aaaf4 100644
--- a/src/applications/differential/conduit/DifferentialGetAllDiffsConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialGetAllDiffsConduitAPIMethod.php
@@ -13,11 +13,12 @@ final class DifferentialGetAllDiffsConduitAPIMethod
 
   public function getMethodStatusDescription() {
     return pht(
-      'This method has been deprecated in favor of differential.querydiffs.');
+      'This method has been deprecated in favor of %s.',
+      'differential.querydiffs');
   }
 
   public function getMethodDescription() {
-    return 'Load all diffs for given revisions from Differential.';
+    return pht('Load all diffs for given revisions from Differential.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php
index 8d7e71c030..288a8c4ca9 100644
--- a/src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php
@@ -8,7 +8,7 @@ final class DifferentialGetCommitMessageConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Retrieve Differential commit messages or message templates.';
+    return pht('Retrieve Differential commit messages or message templates.');
   }
 
   protected function defineParamTypes() {
@@ -27,7 +27,7 @@ final class DifferentialGetCommitMessageConduitAPIMethod
 
   protected function defineErrorTypes() {
     return array(
-      'ERR_NOT_FOUND' => 'Revision was not found.',
+      'ERR_NOT_FOUND' => pht('Revision was not found.'),
     );
   }
 
diff --git a/src/applications/differential/conduit/DifferentialGetCommitPathsConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialGetCommitPathsConduitAPIMethod.php
index a025cd4983..bdd33b60fd 100644
--- a/src/applications/differential/conduit/DifferentialGetCommitPathsConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialGetCommitPathsConduitAPIMethod.php
@@ -8,8 +8,9 @@ final class DifferentialGetCommitPathsConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Query which paths should be included when committing a '.
-           'Differential revision.';
+    return pht(
+      'Query which paths should be included when committing a '.
+      'Differential revision.');
   }
 
   protected function defineParamTypes() {
@@ -24,7 +25,7 @@ final class DifferentialGetCommitPathsConduitAPIMethod
 
   protected function defineErrorTypes() {
     return array(
-      'ERR_NOT_FOUND' => 'No such revision exists.',
+      'ERR_NOT_FOUND' => pht('No such revision exists.'),
     );
   }
 
diff --git a/src/applications/differential/conduit/DifferentialGetDiffConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialGetDiffConduitAPIMethod.php
index 92d9807dda..a47c9c616b 100644
--- a/src/applications/differential/conduit/DifferentialGetDiffConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialGetDiffConduitAPIMethod.php
@@ -24,8 +24,8 @@ final class DifferentialGetDiffConduitAPIMethod
 
   public function getMethodDescription() {
     return pht(
-      'Load the content of a diff from Differential by revision id '.
-      'or diff id.');
+      'Load the content of a diff from Differential by revision ID '.
+      'or diff ID.');
   }
 
   protected function defineParamTypes() {
@@ -41,7 +41,7 @@ final class DifferentialGetDiffConduitAPIMethod
 
   protected function defineErrorTypes() {
     return array(
-      'ERR_BAD_DIFF'        => 'No such diff exists.',
+      'ERR_BAD_DIFF' => pht('No such diff exists.'),
     );
   }
 
diff --git a/src/applications/differential/conduit/DifferentialGetRevisionCommentsConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialGetRevisionCommentsConduitAPIMethod.php
index 6a6770d3e8..1ea23e33a2 100644
--- a/src/applications/differential/conduit/DifferentialGetRevisionCommentsConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialGetRevisionCommentsConduitAPIMethod.php
@@ -16,7 +16,7 @@ final class DifferentialGetRevisionCommentsConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Retrieve Differential Revision Comments.';
+    return pht('Retrieve Differential Revision Comments.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php
index 305b071be8..2bf43d295e 100644
--- a/src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php
@@ -8,7 +8,7 @@ final class DifferentialQueryConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Query Differential revisions which match certain criteria.';
+    return pht('Query Differential revisions which match certain criteria.');
   }
 
   protected function defineParamTypes() {
@@ -53,7 +53,7 @@ final class DifferentialQueryConduitAPIMethod
 
   protected function defineErrorTypes() {
     return array(
-      'ERR-INVALID-PARAMETER' => 'Missing or malformed parameter.',
+      'ERR-INVALID-PARAMETER' => pht('Missing or malformed parameter.'),
     );
   }
 
@@ -103,7 +103,9 @@ final class DifferentialQueryConduitAPIMethod
         }
         throw id(new ConduitException('ERR-INVALID-PARAMETER'))
           ->setErrorDescription(
-            'Unknown paths: '.implode(', ', $unknown_paths));
+            pht(
+              'Unknown paths: %s',
+              implode(', ', $unknown_paths)));
       }
 
       $repos = array();
@@ -118,7 +120,9 @@ final class DifferentialQueryConduitAPIMethod
           if (!$repos[$callsign]) {
             throw id(new ConduitException('ERR-INVALID-PARAMETER'))
               ->setErrorDescription(
-                'Unknown repo callsign: '.$callsign);
+                pht(
+                  'Unknown repo callsign: %s',
+                  $callsign));
           }
         }
         $repo = $repos[$callsign];
diff --git a/src/applications/differential/conduit/DifferentialSetDiffPropertyConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialSetDiffPropertyConduitAPIMethod.php
index d79be1363d..f9db11e3fb 100644
--- a/src/applications/differential/conduit/DifferentialSetDiffPropertyConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialSetDiffPropertyConduitAPIMethod.php
@@ -8,7 +8,7 @@ final class DifferentialSetDiffPropertyConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Attach properties to Differential diffs.';
+    return pht('Attach properties to Differential diffs.');
   }
 
   protected function defineParamTypes() {
@@ -25,7 +25,7 @@ final class DifferentialSetDiffPropertyConduitAPIMethod
 
   protected function defineErrorTypes() {
     return array(
-      'ERR_NOT_FOUND' => 'Diff was not found.',
+      'ERR_NOT_FOUND' => pht('Diff was not found.'),
     );
   }
 
diff --git a/src/applications/differential/conduit/DifferentialUpdateRevisionConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialUpdateRevisionConduitAPIMethod.php
index e8a34fd133..232dbf79b4 100644
--- a/src/applications/differential/conduit/DifferentialUpdateRevisionConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialUpdateRevisionConduitAPIMethod.php
@@ -26,10 +26,10 @@ final class DifferentialUpdateRevisionConduitAPIMethod
 
   protected function defineErrorTypes() {
     return array(
-      'ERR_BAD_DIFF' => 'Bad diff ID.',
-      'ERR_BAD_REVISION' => 'Bad revision ID.',
-      'ERR_WRONG_USER' => 'You are not the author of this revision.',
-      'ERR_CLOSED' => 'This revision has already been closed.',
+      'ERR_BAD_DIFF'     => pht('Bad diff ID.'),
+      'ERR_BAD_REVISION' => pht('Bad revision ID.'),
+      'ERR_WRONG_USER'   => pht('You are not the author of this revision.'),
+      'ERR_CLOSED'       => pht('This revision has already been closed.'),
     );
   }
 
diff --git a/src/applications/differential/conduit/DifferentialUpdateUnitResultsConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialUpdateUnitResultsConduitAPIMethod.php
index 0f0c14a6b8..7b1a250666 100644
--- a/src/applications/differential/conduit/DifferentialUpdateUnitResultsConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialUpdateUnitResultsConduitAPIMethod.php
@@ -8,7 +8,7 @@ final class DifferentialUpdateUnitResultsConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Update arc unit results for a postponed test.';
+    return pht('Update arc unit results for a postponed test.');
   }
 
   protected function defineParamTypes() {
@@ -29,13 +29,12 @@ final class DifferentialUpdateUnitResultsConduitAPIMethod
 
   protected function defineErrorTypes() {
     return array(
-      'ERR_BAD_DIFF'   => 'Bad diff ID.',
-      'ERR_NO_RESULTS' => 'Could not find the postponed test',
+      'ERR_BAD_DIFF'   => pht('Bad diff ID.'),
+      'ERR_NO_RESULTS' => pht('Could not find the postponed test'),
     );
   }
 
   protected function execute(ConduitAPIRequest $request) {
-
     $diff_id = $request->getValue('diff_id');
     if (!$diff_id) {
       throw new ConduitException('ERR_BAD_DIFF');
diff --git a/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php b/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
index 6169d0df88..2c8f4e0bd9 100644
--- a/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
+++ b/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
@@ -201,11 +201,12 @@ final class PhabricatorDifferentialConfigOptions
           ))
         ->setSummary(pht('Allows any user to reopen a closed revision.'))
         ->setDescription(
-          pht('If you set this to true, any user can reopen a revision so '.
-              'long as it has been closed. This can be useful if a revision '.
-              'is accidentally closed or if a developer changes his or her '.
-              'mind after closing a revision. If it is false, reopening '.
-              'is not allowed.')),
+          pht(
+            'If you set this to true, any user can reopen a revision so '.
+            'long as it has been closed. This can be useful if a revision '.
+            'is accidentally closed or if a developer changes his or her '.
+            'mind after closing a revision. If it is false, reopening '.
+            'is not allowed.')),
       $this->newOption('differential.close-on-accept', 'bool', false)
         ->setBoolOptions(
           array(
@@ -242,8 +243,9 @@ final class PhabricatorDifferentialConfigOptions
           pht("After this many days, a revision will be considered 'stale'."))
         ->setDescription(
           pht(
-            "Similar to `differential.days-fresh` but marks stale revisions. ".
-            "If the revision is even older than it is when marked as 'old'.")),
+            "Similar to `%s` but marks stale revisions. ".
+            "If the revision is even older than it is when marked as 'old'.",
+            'differential.days-fresh')),
       $this->newOption(
         'metamta.differential.subject-prefix',
         'string',
diff --git a/src/applications/differential/constants/DifferentialAction.php b/src/applications/differential/constants/DifferentialAction.php
index 48a263c45a..5b5fa9eb71 100644
--- a/src/applications/differential/constants/DifferentialAction.php
+++ b/src/applications/differential/constants/DifferentialAction.php
@@ -23,71 +23,88 @@ final class DifferentialAction {
   public static function getBasicStoryText($action, $author_name) {
     switch ($action) {
       case self::ACTION_COMMENT:
-        $title = pht('%s commented on this revision.',
+        $title = pht(
+          '%s commented on this revision.',
           $author_name);
         break;
       case self::ACTION_ACCEPT:
-        $title = pht('%s accepted this revision.',
+        $title = pht(
+          '%s accepted this revision.',
           $author_name);
         break;
       case self::ACTION_REJECT:
-        $title = pht('%s requested changes to this revision.',
+        $title = pht(
+          '%s requested changes to this revision.',
           $author_name);
         break;
       case self::ACTION_RETHINK:
-        $title = pht('%s planned changes to this revision.',
+        $title = pht(
+          '%s planned changes to this revision.',
           $author_name);
         break;
       case self::ACTION_ABANDON:
-        $title = pht('%s abandoned this revision.',
+        $title = pht(
+          '%s abandoned this revision.',
           $author_name);
         break;
       case self::ACTION_CLOSE:
-        $title = pht('%s closed this revision.',
+        $title = pht(
+          '%s closed this revision.',
           $author_name);
         break;
       case self::ACTION_REQUEST:
-        $title = pht('%s requested a review of this revision.',
+        $title = pht(
+          '%s requested a review of this revision.',
           $author_name);
         break;
       case self::ACTION_RECLAIM:
-        $title = pht('%s reclaimed this revision.',
+        $title = pht(
+          '%s reclaimed this revision.',
           $author_name);
         break;
       case self::ACTION_UPDATE:
-        $title = pht('%s updated this revision.',
+        $title = pht(
+          '%s updated this revision.',
           $author_name);
         break;
       case self::ACTION_RESIGN:
-        $title = pht('%s resigned from this revision.',
+        $title = pht(
+          '%s resigned from this revision.',
           $author_name);
         break;
       case self::ACTION_SUMMARIZE:
-        $title = pht('%s summarized this revision.',
+        $title = pht(
+          '%s summarized this revision.',
           $author_name);
         break;
       case self::ACTION_TESTPLAN:
-        $title = pht('%s explained the test plan for this revision.',
+        $title = pht(
+          '%s explained the test plan for this revision.',
           $author_name);
         break;
       case self::ACTION_CREATE:
-        $title = pht('%s created this revision.',
+        $title = pht(
+          '%s created this revision.',
           $author_name);
         break;
       case self::ACTION_ADDREVIEWERS:
-        $title = pht('%s added reviewers to this revision.',
+        $title = pht(
+          '%s added reviewers to this revision.',
           $author_name);
         break;
       case self::ACTION_ADDCCS:
-        $title = pht('%s added CCs to this revision.',
+        $title = pht(
+          '%s added CCs to this revision.',
           $author_name);
         break;
       case self::ACTION_CLAIM:
-        $title = pht('%s commandeered this revision.',
+        $title = pht(
+          '%s commandeered this revision.',
           $author_name);
         break;
       case self::ACTION_REOPEN:
-        $title = pht('%s reopened this revision.',
+        $title = pht(
+          '%s reopened this revision.',
           $author_name);
         break;
       case DifferentialTransaction::TYPE_INLINE:
@@ -122,7 +139,7 @@ final class DifferentialAction {
     if (!empty($verbs[$action])) {
       return $verbs[$action];
     } else {
-      return 'brazenly '.$action;
+      return pht('brazenly %s', $action);
     }
   }
 
diff --git a/src/applications/differential/constants/DifferentialChangeType.php b/src/applications/differential/constants/DifferentialChangeType.php
index 2ce5392165..7e037d29b5 100644
--- a/src/applications/differential/constants/DifferentialChangeType.php
+++ b/src/applications/differential/constants/DifferentialChangeType.php
@@ -105,7 +105,7 @@ final class DifferentialChangeType {
       self::TYPE_MESSAGE    => pht('Commit Message'),
       self::TYPE_CHILD      => pht('Contents Modified'),
     );
-    return idx($types, coalesce($type, '?'), 'Unknown');
+    return idx($types, coalesce($type, '?'), pht('Unknown'));
   }
 
 }
diff --git a/src/applications/differential/controller/DifferentialChangesetViewController.php b/src/applications/differential/controller/DifferentialChangesetViewController.php
index abc19ab836..0638578f94 100644
--- a/src/applications/differential/controller/DifferentialChangesetViewController.php
+++ b/src/applications/differential/controller/DifferentialChangesetViewController.php
@@ -372,7 +372,7 @@ final class DifferentialChangesetViewController extends DifferentialController {
       $inline = new DifferentialInlineComment();
       $inline->setChangesetID($changeset->getID());
       $inline->setIsNewFile(1);
-      $inline->setSyntheticAuthor('Lint: '.$msg['name']);
+      $inline->setSyntheticAuthor(pht('Lint: %s', $msg['name']));
       $inline->setLineNumber($msg['line']);
       $inline->setLineLength(0);
 
diff --git a/src/applications/differential/controller/DifferentialDiffCreateController.php b/src/applications/differential/controller/DifferentialDiffCreateController.php
index 7781f22023..1eb4f88b1a 100644
--- a/src/applications/differential/controller/DifferentialDiffCreateController.php
+++ b/src/applications/differential/controller/DifferentialDiffCreateController.php
@@ -89,7 +89,7 @@ final class DifferentialDiffCreateController extends DifferentialController {
         'href' => $arcanist_href,
         'target' => '_blank',
       ),
-      'Learn More');
+      pht('Learn More'));
 
     $cancel_uri = $this->getApplicationURI();
 
diff --git a/src/applications/differential/controller/DifferentialInlineCommentEditController.php b/src/applications/differential/controller/DifferentialInlineCommentEditController.php
index dcb48361dc..13aac1776c 100644
--- a/src/applications/differential/controller/DifferentialInlineCommentEditController.php
+++ b/src/applications/differential/controller/DifferentialInlineCommentEditController.php
@@ -29,7 +29,7 @@ final class DifferentialInlineCommentEditController
     $revision = $this->loadRevision();
 
     if (!id(new DifferentialChangeset())->load($changeset_id)) {
-      throw new Exception('Invalid changeset ID!');
+      throw new Exception(pht('Invalid changeset ID!'));
     }
 
     return id(new DifferentialInlineComment())
@@ -59,7 +59,7 @@ final class DifferentialInlineCommentEditController
 
     $inline = $this->loadComment($id);
     if (!$this->canEditInlineComment($user, $inline)) {
-      throw new Exception('That comment is not editable!');
+      throw new Exception(pht('That comment is not editable!'));
     }
     return $inline;
   }
diff --git a/src/applications/differential/controller/DifferentialRevisionCloseDetailsController.php b/src/applications/differential/controller/DifferentialRevisionCloseDetailsController.php
index 0f797d94d3..25051bcbb5 100644
--- a/src/applications/differential/controller/DifferentialRevisionCloseDetailsController.php
+++ b/src/applications/differential/controller/DifferentialRevisionCloseDetailsController.php
@@ -55,9 +55,10 @@ final class DifferentialRevisionCloseDetailsController
     $body_why = array();
     if ($revision_match_data['usedURI']) {
       return pht(
-        'We found a "Differential Revision" field with value "%s" in the '.
-        'commit message, and the domain on the URI matches this install, so '.
+        'We found a "%s" field with value "%s" in the commit message, '.
+        'and the domain on the URI matches this install, so '.
         'we linked this commit to %s.',
+        'Differential Revision',
         $revision_match_data['foundURI'],
         phutil_tag(
           'a',
@@ -67,16 +68,17 @@ final class DifferentialRevisionCloseDetailsController
           $obj_handle->getName()));
     } else if ($revision_match_data['foundURI']) {
       $body_why[] = pht(
-        'We found a "Differential Revision" field with value "%s" in the '.
-        'commit message, but the domain on this URI did not match the '.
-        'configured domain for this install, "%s", so we ignored it under '.
+        'We found a "%s" field with value "%s" in the commit message, '.
+        'but the domain on this URI did not match the configured '.
+        'domain for this install, "%s", so we ignored it under '.
         'the assumption that it refers to some third-party revision.',
+        'Differential Revision',
         $revision_match_data['foundURI'],
         $revision_match_data['validDomain']);
     } else {
       $body_why[] = pht(
-        'We didn\'t find a "Differential Revision" field in the commit '.
-        'message.');
+        'We didn\'t find a "%s" field in the commit message.',
+        'Differential Revision');
     }
 
     switch ($revision_match_data['matchHashType']) {
diff --git a/src/applications/differential/controller/DifferentialRevisionEditController.php b/src/applications/differential/controller/DifferentialRevisionEditController.php
index ea26693454..1c664f07d2 100644
--- a/src/applications/differential/controller/DifferentialRevisionEditController.php
+++ b/src/applications/differential/controller/DifferentialRevisionEditController.php
@@ -49,7 +49,8 @@ final class DifferentialRevisionEditController
       }
       if ($diff->getRevisionID()) {
         // TODO: Redirect?
-        throw new Exception('This diff is already attached to a revision!');
+        throw new Exception(
+          pht('This diff is already attached to a revision!'));
       }
     } else {
       $diff = null;
diff --git a/src/applications/differential/controller/DifferentialRevisionLandController.php b/src/applications/differential/controller/DifferentialRevisionLandController.php
index 1c8ed0e9d3..e19762b44d 100644
--- a/src/applications/differential/controller/DifferentialRevisionLandController.php
+++ b/src/applications/differential/controller/DifferentialRevisionLandController.php
@@ -29,10 +29,12 @@ final class DifferentialRevisionLandController extends DifferentialController {
       $this->pushStrategy = newv($this->strategyClass, array());
     } else {
       throw new Exception(
-        "Strategy type must be a valid class name and must subclass ".
-        "DifferentialLandingStrategy. ".
-        "'{$this->strategyClass}' is not a subclass of ".
-        "DifferentialLandingStrategy.");
+        pht(
+          "Strategy type must be a valid class name and must subclass ".
+          "%s. '%s' is not a subclass of %s",
+          'DifferentialLandingStrategy',
+          $this->strategyClass,
+          'DifferentialLandingStrategy'));
     }
 
     if ($request->isDialogFormPost()) {
@@ -91,7 +93,7 @@ final class DifferentialRevisionLandController extends DifferentialController {
     $prompt = hsprintf('%s<br><br>%s',
       pht(
         'This will squash and rebase revision %s, and push it to '.
-          'the default / master branch.',
+        'the default / master branch.',
         $revision_id),
       pht('It is an experimental feature and may not work.'));
 
@@ -109,13 +111,13 @@ final class DifferentialRevisionLandController extends DifferentialController {
   private function attemptLand($revision, $request) {
     $status = $revision->getStatus();
     if ($status != ArcanistDifferentialRevisionStatus::ACCEPTED) {
-      throw new Exception('Only Accepted revisions can be landed.');
+      throw new Exception(pht('Only Accepted revisions can be landed.'));
     }
 
     $repository = $revision->getRepository();
 
     if ($repository === null) {
-      throw new Exception('revision is not attached to a repository.');
+      throw new Exception(pht('Revision is not attached to a repository.'));
     }
 
     $can_push = PhabricatorPolicyFilter::hasCapability(
diff --git a/src/applications/differential/controller/DifferentialRevisionViewController.php b/src/applications/differential/controller/DifferentialRevisionViewController.php
index cdefdd65d7..312d4a7f4e 100644
--- a/src/applications/differential/controller/DifferentialRevisionViewController.php
+++ b/src/applications/differential/controller/DifferentialRevisionViewController.php
@@ -38,7 +38,7 @@ final class DifferentialRevisionViewController extends DifferentialController {
 
     if (!$diffs) {
       throw new Exception(
-        'This revision has no diffs. Something has gone quite wrong.');
+        pht('This revision has no diffs. Something has gone quite wrong.'));
     }
 
     $revision->attachActiveDiff(last($diffs));
@@ -151,7 +151,7 @@ final class DifferentialRevisionViewController extends DifferentialController {
     if (count($changesets) > $limit && !$large) {
       $count = count($changesets);
       $warning = new PHUIInfoView();
-      $warning->setTitle('Very Large Diff');
+      $warning->setTitle(pht('Very Large Diff'));
       $warning->setSeverity(PHUIInfoView::SEVERITY_WARNING);
       $warning->appendChild(hsprintf(
         '%s <strong>%s</strong>',
@@ -328,7 +328,7 @@ final class DifferentialRevisionViewController extends DifferentialController {
       $changeset_view->setRepository($repository);
     }
     $changeset_view->setSymbolIndexes($symbol_indexes);
-    $changeset_view->setTitle('Diff '.$target->getID());
+    $changeset_view->setTitle(pht('Diff %s', $target->getID()));
 
     $diff_history = id(new DifferentialRevisionUpdateHistoryView())
       ->setUser($user)
diff --git a/src/applications/differential/customfield/DifferentialBranchField.php b/src/applications/differential/customfield/DifferentialBranchField.php
index 5601d66625..35ed809f12 100644
--- a/src/applications/differential/customfield/DifferentialBranchField.php
+++ b/src/applications/differential/customfield/DifferentialBranchField.php
@@ -45,8 +45,9 @@ final class DifferentialBranchField
   public function getProTips() {
     return array(
       pht(
-        'In Git and Mercurial, use a branch like "T123" to automatically '.
-        'associate changes with the corresponding task.'),
+        'In Git and Mercurial, use a branch like "%s" to automatically '.
+        'associate changes with the corresponding task.',
+        'T123'),
     );
   }
 
diff --git a/src/applications/differential/customfield/DifferentialConflictsField.php b/src/applications/differential/customfield/DifferentialConflictsField.php
index ac5c75326f..590d9fd3a7 100644
--- a/src/applications/differential/customfield/DifferentialConflictsField.php
+++ b/src/applications/differential/customfield/DifferentialConflictsField.php
@@ -22,8 +22,8 @@ final class DifferentialConflictsField
 
   public function getFieldDescription() {
     return pht(
-      'Parses the "Conflicts" field which Git can inject into commit '.
-      'messages.');
+      'Parses the "%s" field which Git can inject into commit messages.',
+      'Conflicts');
   }
 
   public function canDisableField() {
diff --git a/src/applications/differential/customfield/DifferentialDependsOnField.php b/src/applications/differential/customfield/DifferentialDependsOnField.php
index 555cb03688..17156fe240 100644
--- a/src/applications/differential/customfield/DifferentialDependsOnField.php
+++ b/src/applications/differential/customfield/DifferentialDependsOnField.php
@@ -45,7 +45,8 @@ final class DifferentialDependsOnField
     return array(
       pht(
         'Create a dependency between revisions by writing '.
-        '"Depends on D123" in your summary.'),
+        '"%s" in your summary.',
+        'Depends on D123'),
     );
   }
 
diff --git a/src/applications/differential/customfield/DifferentialGitSVNIDField.php b/src/applications/differential/customfield/DifferentialGitSVNIDField.php
index a671e10bd6..de45c54c7f 100644
--- a/src/applications/differential/customfield/DifferentialGitSVNIDField.php
+++ b/src/applications/differential/customfield/DifferentialGitSVNIDField.php
@@ -22,8 +22,8 @@ final class DifferentialGitSVNIDField
 
   public function getFieldDescription() {
     return pht(
-      'Parses the "git-svn-id" field which Git/SVN can inject into commit '.
-      'messages.');
+      'Parses the "%s" field which Git/SVN can inject into commit messages.',
+      'git-svn-id');
   }
 
   public function canDisableField() {
diff --git a/src/applications/differential/customfield/DifferentialLintField.php b/src/applications/differential/customfield/DifferentialLintField.php
index 56b7ec3ae6..c43034dd06 100644
--- a/src/applications/differential/customfield/DifferentialLintField.php
+++ b/src/applications/differential/customfield/DifferentialLintField.php
@@ -83,7 +83,7 @@ final class DifferentialLintField
           $name = idx($message, 'name');
           $description = idx($message, 'description');
 
-          $line_link = 'line '.intval($line);
+          $line_link = pht('line %d', intval($line));
           if (isset($path_changesets[$path])) {
             $href = '#C'.$path_changesets[$path].'NL'.max(1, $line);
 
@@ -130,7 +130,9 @@ final class DifferentialLintField
                 idx($location, 'path', $path).
                 ($other_line ? ":{$other_line}" : '');
             }
-            $description .= "\nOther locations: ".implode(', ', $locations);
+            $description .= "\n".pht(
+              'Other locations: %s',
+              implode(', ', $locations));
           }
 
           if (strlen($description)) {
@@ -231,7 +233,9 @@ final class DifferentialLintField
       }
     }
 
-    return 'Show Full Lint Results ('.implode(', ', $show).')';
+    return pht(
+      'Show Full Lint Results (%s)',
+      implode(', ', $show));
   }
 
   public function getWarningsForDetailView() {
diff --git a/src/applications/differential/customfield/DifferentialManiphestTasksField.php b/src/applications/differential/customfield/DifferentialManiphestTasksField.php
index b13cfcc304..56803f60c3 100644
--- a/src/applications/differential/customfield/DifferentialManiphestTasksField.php
+++ b/src/applications/differential/customfield/DifferentialManiphestTasksField.php
@@ -106,8 +106,9 @@ final class DifferentialManiphestTasksField
   public function getProTips() {
     return array(
       pht(
-        'Write "Fixes T123" in your summary to automatically close the '.
-        'corresponding task when this change lands.'),
+        'Write "%s" in your summary to automatically close the '.
+        'corresponding task when this change lands.',
+        'Fixes T123'),
     );
   }
 
diff --git a/src/applications/differential/customfield/DifferentialProjectReviewersField.php b/src/applications/differential/customfield/DifferentialProjectReviewersField.php
index aff5644a52..1eea4f51b9 100644
--- a/src/applications/differential/customfield/DifferentialProjectReviewersField.php
+++ b/src/applications/differential/customfield/DifferentialProjectReviewersField.php
@@ -61,7 +61,8 @@ final class DifferentialProjectReviewersField
     return array(
       pht(
         'You can add a project as a subscriber or reviewer by writing '.
-        '"#projectname" in the appropriate field.'),
+        '"%s" in the appropriate field.',
+        '#projectname'),
     );
   }
 
diff --git a/src/applications/differential/customfield/DifferentialRepositoryField.php b/src/applications/differential/customfield/DifferentialRepositoryField.php
index 76f40d0957..fc6c88194a 100644
--- a/src/applications/differential/customfield/DifferentialRepositoryField.php
+++ b/src/applications/differential/customfield/DifferentialRepositoryField.php
@@ -155,7 +155,8 @@ final class DifferentialRepositoryField
       return;
     }
 
-    $body->addTextSection(pht('REPOSITORY'),
+    $body->addTextSection(
+      pht('REPOSITORY'),
       $repository->getMonogram().' '.$repository->getName());
   }
 
diff --git a/src/applications/differential/customfield/DifferentialRevisionIDField.php b/src/applications/differential/customfield/DifferentialRevisionIDField.php
index bb54951dc4..9d23cf7658 100644
--- a/src/applications/differential/customfield/DifferentialRevisionIDField.php
+++ b/src/applications/differential/customfield/DifferentialRevisionIDField.php
@@ -19,8 +19,7 @@ final class DifferentialRevisionIDField
 
   public function getFieldDescription() {
     return pht(
-      'Ties commits to revisions and provides a permananent link between '.
-      'them.');
+      'Ties commits to revisions and provides a permanent link between them.');
   }
 
   public function canDisableField() {
diff --git a/src/applications/differential/customfield/DifferentialUnitField.php b/src/applications/differential/customfield/DifferentialUnitField.php
index cf183bf381..2cc86d2660 100644
--- a/src/applications/differential/customfield/DifferentialUnitField.php
+++ b/src/applications/differential/customfield/DifferentialUnitField.php
@@ -49,7 +49,7 @@ final class DifferentialUnitField
     if ($excuse) {
       $rows[] = array(
         'style' => 'excuse',
-        'name'  => 'Excuse',
+        'name'  => pht('Excuse'),
         'value' => phutil_escape_html_newlines($excuse),
         'show'  => true,
       );
@@ -83,8 +83,8 @@ final class DifferentialUnitField
             $userdata = str_replace("\000", '', $userdata);
           }
           $markup_object = id(new PhabricatorMarkupOneOff())
-              ->setContent($userdata)
-              ->setPreserveLinebreaks(true);
+            ->setContent($userdata)
+            ->setPreserveLinebreaks(true);
           $engine->addObject($markup_object, 'default');
           $markup_objects[$key] = $markup_object;
         }
@@ -189,12 +189,12 @@ final class DifferentialUnitField
       )) + $hidden;
 
     $noun = array(
-      ArcanistUnitTestResult::RESULT_BROKEN     => 'Broken',
-      ArcanistUnitTestResult::RESULT_FAIL       => 'Failed',
-      ArcanistUnitTestResult::RESULT_UNSOUND    => 'Unsound',
-      ArcanistUnitTestResult::RESULT_SKIP       => 'Skipped',
-      ArcanistUnitTestResult::RESULT_POSTPONED  => 'Postponed',
-      ArcanistUnitTestResult::RESULT_PASS       => 'Passed',
+      ArcanistUnitTestResult::RESULT_BROKEN     => pht('Broken'),
+      ArcanistUnitTestResult::RESULT_FAIL       => pht('Failed'),
+      ArcanistUnitTestResult::RESULT_UNSOUND    => pht('Unsound'),
+      ArcanistUnitTestResult::RESULT_SKIP       => pht('Skipped'),
+      ArcanistUnitTestResult::RESULT_POSTPONED  => pht('Postponed'),
+      ArcanistUnitTestResult::RESULT_PASS       => pht('Passed'),
     );
 
     $show = array();
@@ -206,7 +206,9 @@ final class DifferentialUnitField
       }
     }
 
-    return 'Show Full Unit Results ('.implode(', ', $show).')';
+    return pht(
+      'Show Full Unit Results (%s)',
+      implode(', ', $show));
   }
 
   public function getWarningsForDetailView() {
diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php
index 0a02dec209..6a43f35d5a 100644
--- a/src/applications/differential/editor/DifferentialTransactionEditor.php
+++ b/src/applications/differential/editor/DifferentialTransactionEditor.php
@@ -908,8 +908,7 @@ final class DifferentialTransactionEditor
 
       case DifferentialAction::ACTION_REJECT:
         if ($actor_is_author) {
-          return pht(
-            'You can not request changes to your own revision.');
+          return pht('You can not request changes to your own revision.');
         }
 
         if ($revision_status == $status_abandoned) {
@@ -1484,13 +1483,14 @@ final class DifferentialTransactionEditor
           $nested_comments = $this->nestCommentHistory(
             $inline->getComment(), $comments_by_line_number, $authors_by_phid);
 
-          $section->addFragment('================')
-                  ->addFragment('Comment at: '.$file.':'.$range)
-                  ->addPlaintextFragment($patch)
-                  ->addHTMLFragment($this->renderPatchHTMLForMail($patch))
-                  ->addFragment('----------------')
-                  ->addFragment($nested_comments)
-                  ->addFragment(null);
+          $section
+            ->addFragment('================')
+            ->addFragment(pht('Comment at: %s:%s', $file, $range))
+            ->addPlaintextFragment($patch)
+            ->addHTMLFragment($this->renderPatchHTMLForMail($patch))
+            ->addFragment('----------------')
+            ->addFragment($nested_comments)
+            ->addFragment(null);
         }
       }
     }
@@ -1569,8 +1569,7 @@ final class DifferentialTransactionEditor
       ->executeOne();
     if (!$revision) {
       throw new Exception(
-        pht(
-          'Failed to load revision for Herald adapter construction!'));
+        pht('Failed to load revision for Herald adapter construction!'));
     }
 
     $adapter = HeraldDifferentialRevisionAdapter::newLegacyAdapter(
diff --git a/src/applications/differential/landing/DifferentialGitHubLandingStrategy.php b/src/applications/differential/landing/DifferentialGitHubLandingStrategy.php
index 7160743bb9..c805083cd4 100644
--- a/src/applications/differential/landing/DifferentialGitHubLandingStrategy.php
+++ b/src/applications/differential/landing/DifferentialGitHubLandingStrategy.php
@@ -20,7 +20,7 @@ final class DifferentialGitHubLandingStrategy
       id(new DifferentialHostedGitLandingStrategy())
         ->commitRevisionToWorkspace($revision, $workspace, $viewer);
     } catch (Exception $e) {
-      throw new PhutilProxyException('Failed to commit patch', $e);
+      throw new PhutilProxyException(pht('Failed to commit patch.'), $e);
     }
 
     try {
@@ -33,7 +33,9 @@ final class DifferentialGitHubLandingStrategy
       }
 
       // Else, throw what git said.
-      throw new PhutilProxyException('Failed to push changes upstream', $e);
+      throw new PhutilProxyException(
+        pht('Failed to push changes upstream.'),
+        $e);
     }
   }
 
@@ -103,13 +105,14 @@ final class DifferentialGitHubLandingStrategy
 
     if (!$this->account) {
       throw new Exception(
-        "No matching GitHub account found for {$repo_domain}.");
+        pht('No matching GitHub account found for %s.', $repo_domain));
     }
 
     $this->provider = PhabricatorAuthProvider::getEnabledProviderByKey(
       $this->account->getProviderKey());
     if (!$this->provider) {
-      throw new Exception("GitHub provider for {$repo_domain} is not enabled.");
+      throw new Exception(
+        pht('GitHub provider for %s is not enabled.', $repo_domain));
     }
   }
 
@@ -152,8 +155,9 @@ final class DifferentialGitHubLandingStrategy
 
     if ($no_permission) {
       throw new Exception(
-        "You don't have permission to push to this repository. \n".
-        "Push permissions for this repository are managed on GitHub.");
+        pht(
+          "You don't have permission to push to this repository. ".
+          "Push permissions for this repository are managed on GitHub."));
     }
 
     $scopes = BaseHTTPFuture::getHeader($headers, 'X-OAuth-Scopes');
@@ -166,8 +170,8 @@ final class DifferentialGitHubLandingStrategy
         ->setUser($viewer)
         ->setTitle(pht('Stronger token needed'))
         ->appendChild(pht(
-            'In order to complete this action, you need a '.
-            'stronger GitHub token.'))
+          'In order to complete this action, you need a '.
+          'stronger GitHub token.'))
         ->setSubmitURI($refresh_token_uri)
         ->addCancelButton('/D'.$revision->getId())
         ->setDisableWorkflowOnSubmit(true)
diff --git a/src/applications/differential/landing/DifferentialHostedGitLandingStrategy.php b/src/applications/differential/landing/DifferentialHostedGitLandingStrategy.php
index 68f0980db1..cc0cf97998 100644
--- a/src/applications/differential/landing/DifferentialHostedGitLandingStrategy.php
+++ b/src/applications/differential/landing/DifferentialHostedGitLandingStrategy.php
@@ -14,13 +14,17 @@ final class DifferentialHostedGitLandingStrategy
     try {
       $this->commitRevisionToWorkspace($revision, $workspace, $viewer);
     } catch (Exception $e) {
-      throw new PhutilProxyException('Failed to commit patch', $e);
+      throw new PhutilProxyException(
+        pht('Failed to commit patch.'),
+        $e);
     }
 
     try {
       $this->pushWorkspaceRepository($repository, $workspace, $viewer);
     } catch (Exception $e) {
-      throw new PhutilProxyException('Failed to push changes upstream', $e);
+      throw new PhutilProxyException(
+        pht('Failed to push changes upstream.'),
+        $e);
     }
   }
 
@@ -45,7 +49,7 @@ final class DifferentialHostedGitLandingStrategy
       ."0000000000000000000000000000000000000000.."
       ."0000000000000000000000000000000000000000\n";
     if (strpos($raw_diff, $missing_binary) !== false) {
-      throw new Exception('Patch is missing content for a binary file');
+      throw new Exception(pht('Patch is missing content for a binary file'));
     }
 
     $future = $workspace->execFutureLocal('apply --index -');
diff --git a/src/applications/differential/landing/DifferentialHostedMercurialLandingStrategy.php b/src/applications/differential/landing/DifferentialHostedMercurialLandingStrategy.php
index 0303be62af..38f7160958 100644
--- a/src/applications/differential/landing/DifferentialHostedMercurialLandingStrategy.php
+++ b/src/applications/differential/landing/DifferentialHostedMercurialLandingStrategy.php
@@ -15,13 +15,15 @@ final class DifferentialHostedMercurialLandingStrategy
     try {
       $this->commitRevisionToWorkspace($revision, $workspace, $viewer);
     } catch (Exception $e) {
-      throw new PhutilProxyException('Failed to commit patch', $e);
+      throw new PhutilProxyException(pht('Failed to commit patch.'), $e);
     }
 
     try {
       $this->pushWorkspaceRepository($repository, $workspace, $viewer);
     } catch (Exception $e) {
-      throw new PhutilProxyException('Failed to push changes upstream', $e);
+      throw new PhutilProxyException(
+        pht('Failed to push changes upstream.'),
+        $e);
     }
   }
 
diff --git a/src/applications/differential/landing/DifferentialLandingStrategy.php b/src/applications/differential/landing/DifferentialLandingStrategy.php
index c62ca2ce23..d404511ed3 100644
--- a/src/applications/differential/landing/DifferentialLandingStrategy.php
+++ b/src/applications/differential/landing/DifferentialLandingStrategy.php
@@ -64,7 +64,9 @@ abstract class DifferentialLandingStrategy {
     try {
       return DifferentialGetWorkingCopy::getCleanGitWorkspace($repository);
     } catch (Exception $e) {
-      throw new PhutilProxyException('Failed to allocate a workspace', $e);
+      throw new PhutilProxyException(
+        pht('Failed to allocate a workspace.'),
+        $e);
     }
   }
 
@@ -76,7 +78,9 @@ abstract class DifferentialLandingStrategy {
       return DifferentialGetWorkingCopy::getCleanMercurialWorkspace(
         $repository);
     } catch (Exception $e) {
-      throw new PhutilProxyException('Failed to allocate a workspace', $e);
+      throw new PhutilProxyException(
+        pht('Failed to allocate a workspace.'),
+        $e);
     }
   }
 
diff --git a/src/applications/differential/lipsum/PhabricatorDifferentialRevisionTestDataGenerator.php b/src/applications/differential/lipsum/PhabricatorDifferentialRevisionTestDataGenerator.php
index db34f18418..ec346f26ae 100644
--- a/src/applications/differential/lipsum/PhabricatorDifferentialRevisionTestDataGenerator.php
+++ b/src/applications/differential/lipsum/PhabricatorDifferentialRevisionTestDataGenerator.php
@@ -53,10 +53,10 @@ final class PhabricatorDifferentialRevisionTestDataGenerator
     $diff = id(new PhabricatorDifferenceEngine())
       ->generateRawDiffFromFileContent($code, $newcode);
      $call = new ConduitCall(
-        'differential.createrawdiff',
-        array(
-          'diff' => $diff,
-        ));
+      'differential.createrawdiff',
+      array(
+        'diff' => $diff,
+      ));
     $call->setUser($author);
     $result = $call->execute();
     $thediff = id(new DifferentialDiff())->load(
diff --git a/src/applications/differential/mail/DifferentialCreateMailReceiver.php b/src/applications/differential/mail/DifferentialCreateMailReceiver.php
index d54faffc40..c3198d3642 100644
--- a/src/applications/differential/mail/DifferentialCreateMailReceiver.php
+++ b/src/applications/differential/mail/DifferentialCreateMailReceiver.php
@@ -3,8 +3,8 @@
 final class DifferentialCreateMailReceiver extends PhabricatorMailReceiver {
 
   public function isEnabled() {
-    $app_class = 'PhabricatorDifferentialApplication';
-    return PhabricatorApplication::isClassInstalled($app_class);
+    return PhabricatorApplication::isClassInstalled(
+      'PhabricatorDifferentialApplication');
   }
 
   public function canAcceptMail(PhabricatorMetaMTAReceivedMail $mail) {
diff --git a/src/applications/differential/mail/DifferentialReplyHandler.php b/src/applications/differential/mail/DifferentialReplyHandler.php
index 660fe7e034..b2d8d05665 100644
--- a/src/applications/differential/mail/DifferentialReplyHandler.php
+++ b/src/applications/differential/mail/DifferentialReplyHandler.php
@@ -5,7 +5,7 @@ final class DifferentialReplyHandler
 
   public function validateMailReceiver($mail_receiver) {
     if (!($mail_receiver instanceof DifferentialRevision)) {
-      throw new Exception('Receiver is not a DifferentialRevision!');
+      throw new Exception(pht('Receiver is not a %s!', 'DifferentialRevision'));
     }
   }
 
diff --git a/src/applications/differential/mail/DifferentialRevisionMailReceiver.php b/src/applications/differential/mail/DifferentialRevisionMailReceiver.php
index b211a89ea9..6b27c5a371 100644
--- a/src/applications/differential/mail/DifferentialRevisionMailReceiver.php
+++ b/src/applications/differential/mail/DifferentialRevisionMailReceiver.php
@@ -4,8 +4,8 @@ final class DifferentialRevisionMailReceiver
   extends PhabricatorObjectMailReceiver {
 
   public function isEnabled() {
-    $app_class = 'PhabricatorDifferentialApplication';
-    return PhabricatorApplication::isClassInstalled($app_class);
+    return PhabricatorApplication::isClassInstalled(
+      'PhabricatorDifferentialApplication');
   }
 
   protected function getObjectPattern() {
diff --git a/src/applications/differential/parser/DifferentialChangesetParser.php b/src/applications/differential/parser/DifferentialChangesetParser.php
index 82c0a47519..bca4098ca1 100644
--- a/src/applications/differential/parser/DifferentialChangesetParser.php
+++ b/src/applications/differential/parser/DifferentialChangesetParser.php
@@ -1154,10 +1154,11 @@ final class DifferentialChangesetParser {
    *
    * @return array($gaps, $mask, $depths)
    */
-  private function calculateGapsMaskAndDepths($mask_force,
-                                              $feedback_mask,
-                                              $range_start,
-                                              $range_len) {
+  private function calculateGapsMaskAndDepths(
+    $mask_force,
+    $feedback_mask,
+    $range_start,
+    $range_len) {
 
     // Calculate gaps and mask first
     $gaps = array();
@@ -1263,7 +1264,7 @@ final class DifferentialChangesetParser {
     PhabricatorInlineCommentInterface $comment) {
 
     if (!$this->isCommentVisibleOnRenderedDiff($comment)) {
-      throw new Exception('Comment is not visible on changeset!');
+      throw new Exception(pht('Comment is not visible on changeset!'));
     }
 
     $changeset_id = $comment->getChangesetID();
diff --git a/src/applications/differential/parser/DifferentialCommitMessageParser.php b/src/applications/differential/parser/DifferentialCommitMessageParser.php
index 5e3c14aa34..00d2fe2c3f 100644
--- a/src/applications/differential/parser/DifferentialCommitMessageParser.php
+++ b/src/applications/differential/parser/DifferentialCommitMessageParser.php
@@ -73,8 +73,10 @@ final class DifferentialCommitMessageParser {
     if (!$key_title || !$key_summary || ($label_map === null)) {
       throw new Exception(
         pht(
-          'Expected labelMap, summaryKey and titleKey to be set before '.
-          'parsing a corpus.'));
+          'Expected %s, %s and %s to be set before parsing a corpus.',
+          'labelMap',
+          'summaryKey',
+          'titleKey'));
     }
 
     $label_regexp = $this->buildLabelRegexp($label_map);
diff --git a/src/applications/differential/parser/DifferentialHunkParser.php b/src/applications/differential/parser/DifferentialHunkParser.php
index e381ca8346..d49f4e1e26 100644
--- a/src/applications/differential/parser/DifferentialHunkParser.php
+++ b/src/applications/differential/parser/DifferentialHunkParser.php
@@ -35,9 +35,7 @@ final class DifferentialHunkParser {
   }
   public function getVisibleLinesMask() {
     if ($this->visibleLinesMask === null) {
-      throw new Exception(
-        'You must generateVisibileLinesMask before accessing this data.'
-      );
+      throw new PhutilInvalidStateException('generateVisibileLinesMask');
     }
     return $this->visibleLinesMask;
   }
@@ -48,9 +46,7 @@ final class DifferentialHunkParser {
   }
   public function getIntraLineDiffs() {
     if ($this->intraLineDiffs === null) {
-      throw new Exception(
-        'You must generateIntraLineDiffs before accessing this data.'
-      );
+      throw new PhutilInvalidStateException('generateIntraLineDiffs');
     }
     return $this->intraLineDiffs;
   }
@@ -61,9 +57,7 @@ final class DifferentialHunkParser {
   }
   public function getNewLines() {
     if ($this->newLines === null) {
-      throw new Exception(
-        'You must parseHunksForLineData before accessing this data.'
-      );
+      throw new PhutilInvalidStateException('parseHunksForLineData');
     }
     return $this->newLines;
   }
@@ -74,9 +68,7 @@ final class DifferentialHunkParser {
   }
   public function getOldLines() {
     if ($this->oldLines === null) {
-      throw new Exception(
-        'You must parseHunksForLineData before accessing this data.'
-      );
+      throw new PhutilInvalidStateException('parseHunksForLineData');
     }
     return $this->oldLines;
   }
@@ -132,8 +124,9 @@ final class DifferentialHunkParser {
   private function getWhitespaceMode() {
     if ($this->whitespaceMode === null) {
       throw new Exception(
-        'You must setWhitespaceMode before accessing this data.'
-      );
+        pht(
+          'You must %s before accessing this data.',
+          'setWhitespaceMode'));
     }
     return $this->whitespaceMode;
   }
@@ -173,7 +166,7 @@ final class DifferentialHunkParser {
 
   private function getHasChanges($filter) {
     if ($filter !== 'any' && $filter !== 'text') {
-      throw new Exception("Unknown change filter '{$filter}'.");
+      throw new Exception(pht("Unknown change filter '%s'.", $filter));
     }
 
     $old = $this->getOldLines();
diff --git a/src/applications/differential/parser/__tests__/DifferentialCommitMessageParserTestCase.php b/src/applications/differential/parser/__tests__/DifferentialCommitMessageParserTestCase.php
index 8396237bc5..669cfed220 100644
--- a/src/applications/differential/parser/__tests__/DifferentialCommitMessageParserTestCase.php
+++ b/src/applications/differential/parser/__tests__/DifferentialCommitMessageParserTestCase.php
@@ -18,8 +18,9 @@ final class DifferentialCommitMessageParserTestCase
         throw new Exception(
           pht(
             'Expected test file "%s" to contain four parts (message, fields, '.
-            'output, errors) divided by "~~~~~~~~~~".',
-            $file));
+            'output, errors) divided by "%s".',
+            $file,
+            '~~~~~~~~~~'));
       }
 
       list($message, $fields, $output, $errors) = $parts;
diff --git a/src/applications/differential/parser/__tests__/DifferentialHunkParserTestCase.php b/src/applications/differential/parser/__tests__/DifferentialHunkParserTestCase.php
index 45c7ac9225..d1d2501b94 100644
--- a/src/applications/differential/parser/__tests__/DifferentialHunkParserTestCase.php
+++ b/src/applications/differential/parser/__tests__/DifferentialHunkParserTestCase.php
@@ -37,7 +37,7 @@ final class DifferentialHunkParserTestCase extends PhabricatorTestCase {
     $parser = new ArcanistDiffParser();
     $changes = $parser->parseDiff($data);
     if (count($changes) !== 1) {
-      throw new Exception("Expected 1 changeset for '{$name}'!");
+      throw new Exception(pht("Expected 1 changeset for '%s'!", $name));
     }
 
     $diff = DifferentialDiff::newFromRawChanges(
@@ -113,10 +113,10 @@ final class DifferentialHunkParserTestCase extends PhabricatorTestCase {
   public function testInclusionOfNewFileInOldCommentFromStart() {
     $parser = new DifferentialHunkParser();
     $hunks = $this->createSingleChange(2, 3,
-         "+n1\n".
-         " e1/2\n".
-         "-o2\n".
-         "+n3\n");
+      "+n1\n".
+      " e1/2\n".
+      "-o2\n".
+      "+n3\n");
     $context = $parser->makeContextDiff(
       $hunks,
       0,
@@ -124,18 +124,18 @@ final class DifferentialHunkParserTestCase extends PhabricatorTestCase {
       1,
       0);
     $this->assertEqual(
-        "@@ -1,2 +2,1 @@\n".
-        " e1/2\n".
-        "-o2", $context);
+      "@@ -1,2 +2,1 @@\n".
+      " e1/2\n".
+      "-o2", $context);
   }
 
   public function testInclusionOfOldFileInNewCommentFromStart() {
     $parser = new DifferentialHunkParser();
     $hunks = $this->createSingleChange(2, 2,
-         "-o1\n".
-         " e2/1\n".
-         "-o3\n".
-         "+n2\n");
+      "-o1\n".
+      " e2/1\n".
+      "-o3\n".
+      "+n2\n");
     $context = $parser->makeContextDiff(
       $hunks,
       1,
@@ -143,16 +143,16 @@ final class DifferentialHunkParserTestCase extends PhabricatorTestCase {
       1,
       0);
     $this->assertEqual(
-        "@@ -2,1 +1,2 @@\n".
-        " e2/1\n".
-        "+n2", $context);
+      "@@ -2,1 +1,2 @@\n".
+      " e2/1\n".
+      "+n2", $context);
   }
 
   public function testNoNewlineAtEndOfFile() {
     $parser = new DifferentialHunkParser();
     $hunks = $this->createSingleChange(0, 1,
-        "+a\n".
-        "\\No newline at end of file");
+      "+a\n".
+      "\\No newline at end of file");
     // Note that this only works with additional context.
     $context = $parser->makeContextDiff(
       $hunks,
@@ -161,23 +161,23 @@ final class DifferentialHunkParserTestCase extends PhabricatorTestCase {
       0,
       1);
     $this->assertEqual(
-        "@@ +1,1 @@\n".
-        "+a\n".
-        "\\No newline at end of file", $context);
+      "@@ +1,1 @@\n".
+      "+a\n".
+      "\\No newline at end of file", $context);
   }
 
   public function testMultiLineNewComment() {
     $parser = new DifferentialHunkParser();
     $hunks = $this->createSingleChange(7, 7,
-        " e1\n".
-        " e2\n".
-        "-o3\n".
-        "-o4\n".
-        "+n3\n".
-        " e5/4\n".
-        " e6/5\n".
-        "+n6\n".
-        " e7\n");
+      " e1\n".
+      " e2\n".
+      "-o3\n".
+      "-o4\n".
+      "+n3\n".
+      " e5/4\n".
+      " e6/5\n".
+      "+n6\n".
+      " e7\n");
     $context = $parser->makeContextDiff(
       $hunks,
       1,
@@ -185,28 +185,28 @@ final class DifferentialHunkParserTestCase extends PhabricatorTestCase {
       4,
       0);
     $this->assertEqual(
-        "@@ -2,5 +2,5 @@\n".
-        " e2\n".
-        "-o3\n".
-        "-o4\n".
-        "+n3\n".
-        " e5/4\n".
-        " e6/5\n".
-        "+n6", $context);
+      "@@ -2,5 +2,5 @@\n".
+      " e2\n".
+      "-o3\n".
+      "-o4\n".
+      "+n3\n".
+      " e5/4\n".
+      " e6/5\n".
+      "+n6", $context);
   }
 
   public function testMultiLineOldComment() {
     $parser = new DifferentialHunkParser();
     $hunks = $this->createSingleChange(7, 7,
-        " e1\n".
-        " e2\n".
-        "-o3\n".
-        "-o4\n".
-        "+n3\n".
-        " e5/4\n".
-        " e6/5\n".
-        "+n6\n".
-        " e7\n");
+      " e1\n".
+      " e2\n".
+      "-o3\n".
+      "-o4\n".
+      "+n3\n".
+      " e5/4\n".
+      " e6/5\n".
+      "+n6\n".
+      " e7\n");
     $context = $parser->makeContextDiff(
       $hunks,
       0,
@@ -214,22 +214,22 @@ final class DifferentialHunkParserTestCase extends PhabricatorTestCase {
       4,
       0);
     $this->assertEqual(
-        "@@ -2,5 +2,4 @@\n".
-        " e2\n".
-        "-o3\n".
-        "-o4\n".
-        "+n3\n".
-        " e5/4\n".
-        " e6/5", $context);
+      "@@ -2,5 +2,4 @@\n".
+      " e2\n".
+      "-o3\n".
+      "-o4\n".
+      "+n3\n".
+      " e5/4\n".
+      " e6/5", $context);
   }
 
   public function testInclusionOfNewFileInOldCommentFromStartWithContext() {
     $parser = new DifferentialHunkParser();
     $hunks = $this->createSingleChange(2, 3,
-         "+n1\n".
-         " e1/2\n".
-         "-o2\n".
-         "+n3\n");
+      "+n1\n".
+      " e1/2\n".
+      "-o2\n".
+      "+n3\n");
     $context = $parser->makeContextDiff(
       $hunks,
       0,
@@ -237,19 +237,19 @@ final class DifferentialHunkParserTestCase extends PhabricatorTestCase {
       1,
       1);
     $this->assertEqual(
-        "@@ -1,2 +1,2 @@\n".
-        "+n1\n".
-        " e1/2\n".
-        "-o2", $context);
+      "@@ -1,2 +1,2 @@\n".
+      "+n1\n".
+      " e1/2\n".
+      "-o2", $context);
   }
 
   public function testInclusionOfOldFileInNewCommentFromStartWithContext() {
     $parser = new DifferentialHunkParser();
     $hunks = $this->createSingleChange(2, 2,
-         "-o1\n".
-         " e2/1\n".
-         "-o3\n".
-         "+n2\n");
+      "-o1\n".
+      " e2/1\n".
+      "-o3\n".
+      "+n2\n");
     $context = $parser->makeContextDiff(
       $hunks,
       1,
@@ -257,11 +257,11 @@ final class DifferentialHunkParserTestCase extends PhabricatorTestCase {
       1,
       1);
     $this->assertEqual(
-        "@@ -1,3 +1,2 @@\n".
-        "-o1\n".
-        " e2/1\n".
-        "-o3\n".
-        "+n2", $context);
+      "@@ -1,3 +1,2 @@\n".
+      "-o1\n".
+      " e2/1\n".
+      "-o3\n".
+      "+n2", $context);
   }
 
   public function testMissingContext() {
diff --git a/src/applications/differential/query/DifferentialHunkQuery.php b/src/applications/differential/query/DifferentialHunkQuery.php
index 3c9f898810..09beb0b6f7 100644
--- a/src/applications/differential/query/DifferentialHunkQuery.php
+++ b/src/applications/differential/query/DifferentialHunkQuery.php
@@ -95,7 +95,9 @@ final class DifferentialHunkQuery
 
     if (!$this->changesets) {
       throw new Exception(
-        pht('You must load hunks via changesets, with withChangesets()!'));
+        pht(
+          'You must load hunks via changesets, with %s!',
+          'withChangesets()'));
     }
 
     $where[] = qsprintf(
diff --git a/src/applications/differential/query/DifferentialRevisionQuery.php b/src/applications/differential/query/DifferentialRevisionQuery.php
index d49ef34887..69e9477e0d 100644
--- a/src/applications/differential/query/DifferentialRevisionQuery.php
+++ b/src/applications/differential/query/DifferentialRevisionQuery.php
@@ -820,7 +820,7 @@ final class DifferentialRevisionQuery
         break;
       default:
         throw new Exception(
-          "Unknown revision status filter constant '{$this->status}'!");
+          pht("Unknown revision status filter constant '%s'!", $this->status));
     }
 
     $where[] = $this->buildWhereClauseParts($conn_r);
@@ -1035,7 +1035,7 @@ final class DifferentialRevisionQuery
             // The author can never have authority unless we allow self-accept.
             $has_authority = false;
           } else {
-            // Otherwise, look up whether th viewer has authority.
+            // Otherwise, look up whether the viewer has authority.
             $has_authority = isset($authority[$reviewer_phid]);
           }
 
diff --git a/src/applications/differential/render/DifferentialChangesetHTMLRenderer.php b/src/applications/differential/render/DifferentialChangesetHTMLRenderer.php
index ce1a35f365..30acc71c88 100644
--- a/src/applications/differential/render/DifferentialChangesetHTMLRenderer.php
+++ b/src/applications/differential/render/DifferentialChangesetHTMLRenderer.php
@@ -265,8 +265,7 @@ abstract class DifferentialChangesetHTMLRenderer
             'This file was converted from %s for display.',
             phutil_tag('strong', array(), $encoding));
         } else {
-          $messages[] = pht(
-            'This file uses an unknown character encoding.');
+          $messages[] = pht('This file uses an unknown character encoding.');
         }
       }
     }
@@ -371,7 +370,11 @@ abstract class DifferentialChangesetHTMLRenderer
         $force !== 'whitespace' &&
         $force !== 'none' &&
         $force !== 'default') {
-      throw new Exception("Invalid 'force' parameter '{$force}'!");
+      throw new Exception(
+        pht(
+          "Invalid '%s' parameter '%s'!",
+          'force',
+          $force));
     }
 
     $range = "0-{$end}";
@@ -516,7 +519,7 @@ abstract class DifferentialChangesetHTMLRenderer
       if ($is_last_block) {
         $text = pht('Show Last %d Line(s)', $block_size);
       } else {
-        $text = pht("\xE2\x96\xBC Show %d Line(s)", $block_size);
+        $text = "\xE2\x96\xBC ".pht('Show %d Line(s)', $block_size);
       }
 
       $links[] = $this->renderShowContextLink(
diff --git a/src/applications/differential/render/DifferentialChangesetRenderer.php b/src/applications/differential/render/DifferentialChangesetRenderer.php
index 22255ece7e..461ce668bb 100644
--- a/src/applications/differential/render/DifferentialChangesetRenderer.php
+++ b/src/applications/differential/render/DifferentialChangesetRenderer.php
@@ -599,7 +599,7 @@ abstract class DifferentialChangesetRenderer {
         }
 
       } else {
-        throw new Exception("Unknown primitive type '{$primitive}'!");
+        throw new Exception(pht("Unknown primitive type '%s'!", $primitive));
       }
     }
 
diff --git a/src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php b/src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php
index 3eb0190664..181e3d1306 100644
--- a/src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php
+++ b/src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php
@@ -299,10 +299,12 @@ final class DifferentialChangesetTwoUpRenderer
     return $this->wrapChangeInTable(phutil_implode_html('', $html));
   }
 
-  public function renderFileChange($old_file = null,
-                                   $new_file = null,
-                                   $id = 0,
-                                   $vs = 0) {
+  public function renderFileChange(
+    $old_file = null,
+    $new_file = null,
+    $id = 0,
+    $vs = 0) {
+
     $old = null;
     if ($old_file) {
       $old = $this->renderImageStage($old_file);
diff --git a/src/applications/differential/search/DifferentialSearchIndexer.php b/src/applications/differential/search/DifferentialSearchIndexer.php
index 66a89a6fb9..9976503127 100644
--- a/src/applications/differential/search/DifferentialSearchIndexer.php
+++ b/src/applications/differential/search/DifferentialSearchIndexer.php
@@ -14,7 +14,7 @@ final class DifferentialSearchIndexer
       ->needReviewerStatus(true)
       ->executeOne();
     if (!$object) {
-      throw new Exception("Unable to load object by phid '{$phid}'!");
+      throw new Exception(pht("Unable to load object by PHID '%s'!", $phid));
     }
     return $object;
   }
diff --git a/src/applications/differential/storage/DifferentialReviewer.php b/src/applications/differential/storage/DifferentialReviewer.php
index b5a339efbb..e3b1e0ac20 100644
--- a/src/applications/differential/storage/DifferentialReviewer.php
+++ b/src/applications/differential/storage/DifferentialReviewer.php
@@ -41,7 +41,7 @@ final class DifferentialReviewer {
 
     $viewer_phid = $viewer->getPHID();
     if (!array_key_exists($viewer_phid, $this->authority)) {
-      throw new Exception('You must attachAuthority() first!');
+      throw new Exception(pht('You must %s first!', 'attachAuthority()'));
     }
     return $this->authority[$viewer_phid];
   }
diff --git a/src/applications/differential/storage/DifferentialRevision.php b/src/applications/differential/storage/DifferentialRevision.php
index e6baa678e9..7630814882 100644
--- a/src/applications/differential/storage/DifferentialRevision.php
+++ b/src/applications/differential/storage/DifferentialRevision.php
@@ -316,8 +316,7 @@ final class DifferentialRevision extends DifferentialDAO
 
     switch ($capability) {
       case PhabricatorPolicyCapability::CAN_VIEW:
-        $description[] = pht(
-          "A revision's reviewers can always view it.");
+        $description[] = pht("A revision's reviewers can always view it.");
         $description[] = pht(
           'If a revision belongs to a repository, other users must be able '.
           'to view the repository in order to view the revision.');
diff --git a/src/applications/differential/storage/DifferentialTransaction.php b/src/applications/differential/storage/DifferentialTransaction.php
index 2857d24272..23f6a45c2a 100644
--- a/src/applications/differential/storage/DifferentialTransaction.php
+++ b/src/applications/differential/storage/DifferentialTransaction.php
@@ -274,14 +274,11 @@ final class DifferentialTransaction extends PhabricatorApplicationTransaction {
       case self::TYPE_STATUS:
         switch ($this->getNewValue()) {
           case ArcanistDifferentialRevisionStatus::ACCEPTED:
-            return pht(
-              'This revision is now accepted and ready to land.');
+            return pht('This revision is now accepted and ready to land.');
           case ArcanistDifferentialRevisionStatus::NEEDS_REVISION:
-            return pht(
-              'This revision now requires changes to proceed.');
+            return pht('This revision now requires changes to proceed.');
           case ArcanistDifferentialRevisionStatus::NEEDS_REVIEW:
-            return pht(
-              'This revision now requires review to proceed.');
+            return pht('This revision now requires review to proceed.');
         }
     }
 
@@ -595,11 +592,9 @@ final class DifferentialTransaction extends PhabricatorApplicationTransaction {
               'You can not commandeer this revision because you already own '.
               'it.');
           case DifferentialAction::ACTION_ACCEPT:
-            return pht(
-              'You have already accepted this revision.');
+            return pht('You have already accepted this revision.');
           case DifferentialAction::ACTION_REJECT:
-            return pht(
-              'You have already requested changes to this revision.');
+            return pht('You have already requested changes to this revision.');
         }
         break;
     }
diff --git a/src/applications/differential/view/DifferentialDiffTableOfContentsView.php b/src/applications/differential/view/DifferentialDiffTableOfContentsView.php
index 94b9907ecb..953444a199 100644
--- a/src/applications/differential/view/DifferentialDiffTableOfContentsView.php
+++ b/src/applications/differential/view/DifferentialDiffTableOfContentsView.php
@@ -137,9 +137,9 @@ final class DifferentialDiffTableOfContentsView extends AphrontView {
         ($changeset->getOldProperties() === $changeset->getNewProperties())
           ? ''
           : phutil_tag(
-              'span',
-              array('title' => pht('Properties Changed')),
-              'M');
+            'span',
+            array('title' => pht('Properties Changed')),
+            'M');
 
       $fname = $changeset->getFilename();
       $cov  = $this->renderCoverage($coverage, $fname);
@@ -246,8 +246,8 @@ final class DifferentialDiffTableOfContentsView extends AphrontView {
         false,
       ));
     $anchor = id(new PhabricatorAnchorView())
-        ->setAnchorName('toc')
-        ->setNavigationMarker(true);
+      ->setAnchorName('toc')
+      ->setNavigationMarker(true);
 
     return id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Table of Contents'))
diff --git a/src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php b/src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php
index 4f99c19c7d..6f8ee6db93 100644
--- a/src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php
+++ b/src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php
@@ -365,7 +365,7 @@ final class DifferentialRevisionUpdateHistoryView extends AphrontView {
       case DifferentialLintStatus::LINT_POSTPONED:
         return pht('Lint Postponed');
     }
-    return '???';
+    return pht('Unknown');
   }
 
   public static function getDiffUnitMessage(DifferentialDiff $diff) {
@@ -386,7 +386,7 @@ final class DifferentialRevisionUpdateHistoryView extends AphrontView {
       case DifferentialUnitStatus::UNIT_POSTPONED:
         return pht('Unit Tests Postponed');
     }
-    return '???';
+    return pht('Unknown');
   }
 
   private static function renderDiffStar($star) {
diff --git a/src/applications/differential/view/DifferentialTransactionView.php b/src/applications/differential/view/DifferentialTransactionView.php
index 3312f717c7..ea0b2bb893 100644
--- a/src/applications/differential/view/DifferentialTransactionView.php
+++ b/src/applications/differential/view/DifferentialTransactionView.php
@@ -104,7 +104,7 @@ final class DifferentialTransactionView
           $inlines[] = $xaction;
           break;
         default:
-          throw new Exception('Unknown grouped transaction type!');
+          throw new Exception(pht('Unknown grouped transaction type!'));
       }
     }
 
diff --git a/src/applications/diffusion/DiffusionLintSaveRunner.php b/src/applications/diffusion/DiffusionLintSaveRunner.php
index 629c887924..7b652cf5f0 100644
--- a/src/applications/diffusion/DiffusionLintSaveRunner.php
+++ b/src/applications/diffusion/DiffusionLintSaveRunner.php
@@ -172,7 +172,7 @@ final class DiffusionLintSaveRunner {
         try {
           $paths = phutil_json_decode($json);
         } catch (PhutilJSONParserException $ex) {
-          fprintf(STDERR, pht("Invalid JSON: %s\n", $json));
+          fprintf(STDERR, pht('Invalid JSON: %s', $json)."\n");
           continue;
         }
 
diff --git a/src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php
index f8854ac0f2..e2d3a941bf 100644
--- a/src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php
+++ b/src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php
@@ -8,9 +8,9 @@ final class DiffusionBrowseQueryConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return
+    return pht(
       'File(s) information for a repository at an (optional) path and '.
-      '(optional) commit.';
+      '(optional) commit.');
   }
 
   protected function defineReturnType() {
diff --git a/src/applications/diffusion/conduit/DiffusionCreateCommentConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionCreateCommentConduitAPIMethod.php
index 8d978e3f25..5543b759d0 100644
--- a/src/applications/diffusion/conduit/DiffusionCreateCommentConduitAPIMethod.php
+++ b/src/applications/diffusion/conduit/DiffusionCreateCommentConduitAPIMethod.php
@@ -12,9 +12,15 @@ final class DiffusionCreateCommentConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Add a comment to a Diffusion commit. By specifying an action of '.
-           '"concern", "accept", "resign", or "close", auditing actions can '.
-           'be triggered. Defaults to "comment".';
+    return pht(
+      'Add a comment to a Diffusion commit. By specifying an action '.
+      'of "%s", "%s", "%s", or "%s", auditing actions can '.
+      'be triggered. Defaults to "%s".',
+      'concern',
+      'accept',
+      'resign',
+      'close',
+      'comment');
   }
 
   protected function defineParamTypes() {
@@ -32,9 +38,9 @@ final class DiffusionCreateCommentConduitAPIMethod
 
   protected function defineErrorTypes() {
     return array(
-      'ERR_BAD_COMMIT' => 'No commit found with that PHID',
-      'ERR_BAD_ACTION' => 'Invalid action type',
-      'ERR_MISSING_MESSAGE' => 'Message is required',
+      'ERR_BAD_COMMIT' => pht('No commit found with that PHID.'),
+      'ERR_BAD_ACTION' => pht('Invalid action type.'),
+      'ERR_MISSING_MESSAGE' => pht('Message is required.'),
     );
   }
 
diff --git a/src/applications/diffusion/conduit/DiffusionDiffQueryConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionDiffQueryConduitAPIMethod.php
index 0ec00bc762..19295f2b20 100644
--- a/src/applications/diffusion/conduit/DiffusionDiffQueryConduitAPIMethod.php
+++ b/src/applications/diffusion/conduit/DiffusionDiffQueryConduitAPIMethod.php
@@ -10,9 +10,9 @@ final class DiffusionDiffQueryConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return
+    return pht(
       'Get diff information from a repository for a specific path at an '.
-      '(optional) commit.';
+      '(optional) commit.');
   }
 
   protected function defineReturnType() {
diff --git a/src/applications/diffusion/conduit/DiffusionExistsQueryConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionExistsQueryConduitAPIMethod.php
index d0d5453a34..3c6d09ebda 100644
--- a/src/applications/diffusion/conduit/DiffusionExistsQueryConduitAPIMethod.php
+++ b/src/applications/diffusion/conduit/DiffusionExistsQueryConduitAPIMethod.php
@@ -8,7 +8,7 @@ final class DiffusionExistsQueryConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Determine if code exists in a version control system.';
+    return pht('Determine if code exists in a version control system.');
   }
 
   protected function defineReturnType() {
@@ -51,7 +51,7 @@ final class DiffusionExistsQueryConduitAPIMethod
     list($err, $stdout) = $repository->execLocalCommand(
       'id --rev %s',
       $commit);
-    return  !$err;
+    return !$err;
   }
 
 }
diff --git a/src/applications/diffusion/conduit/DiffusionFileContentQueryConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionFileContentQueryConduitAPIMethod.php
index 9204a84bbc..671ec3ef6f 100644
--- a/src/applications/diffusion/conduit/DiffusionFileContentQueryConduitAPIMethod.php
+++ b/src/applications/diffusion/conduit/DiffusionFileContentQueryConduitAPIMethod.php
@@ -8,7 +8,7 @@ final class DiffusionFileContentQueryConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Retrieve file content from a repository.';
+    return pht('Retrieve file content from a repository.');
   }
 
   protected function defineReturnType() {
diff --git a/src/applications/diffusion/conduit/DiffusionGetCommitsConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionGetCommitsConduitAPIMethod.php
index cdc89807cd..15dd1f53f6 100644
--- a/src/applications/diffusion/conduit/DiffusionGetCommitsConduitAPIMethod.php
+++ b/src/applications/diffusion/conduit/DiffusionGetCommitsConduitAPIMethod.php
@@ -16,7 +16,7 @@ final class DiffusionGetCommitsConduitAPIMethod
   }
 
   public function getMethodStatusDescription() {
-    return pht('Obsoleted by diffusion.querycommits.');
+    return pht('Obsoleted by %s.', 'diffusion.querycommits');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/diffusion/conduit/DiffusionGetRecentCommitsByPathConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionGetRecentCommitsByPathConduitAPIMethod.php
index 89e40c69ba..002805ac4e 100644
--- a/src/applications/diffusion/conduit/DiffusionGetRecentCommitsByPathConduitAPIMethod.php
+++ b/src/applications/diffusion/conduit/DiffusionGetRecentCommitsByPathConduitAPIMethod.php
@@ -10,7 +10,8 @@ final class DiffusionGetRecentCommitsByPathConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Get commit identifiers for recent commits affecting a given path.';
+    return pht(
+      'Get commit identifiers for recent commits affecting a given path.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php
index 939a47ab64..dcc8f56e8f 100644
--- a/src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php
+++ b/src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php
@@ -10,8 +10,9 @@ final class DiffusionHistoryQueryConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Returns history information for a repository at a specific '.
-      'commit and path.';
+    return pht(
+      'Returns history information for a repository at a specific '.
+      'commit and path.');
   }
 
   protected function defineReturnType() {
diff --git a/src/applications/diffusion/conduit/DiffusionMergedCommitsQueryConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionMergedCommitsQueryConduitAPIMethod.php
index fd618a291e..9d2d6caadc 100644
--- a/src/applications/diffusion/conduit/DiffusionMergedCommitsQueryConduitAPIMethod.php
+++ b/src/applications/diffusion/conduit/DiffusionMergedCommitsQueryConduitAPIMethod.php
@@ -8,8 +8,8 @@ final class DiffusionMergedCommitsQueryConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return
-      'Merged commit information for a specific commit in a repository.';
+    return pht(
+      'Merged commit information for a specific commit in a repository.');
   }
 
   protected function defineReturnType() {
diff --git a/src/applications/diffusion/conduit/DiffusionQueryConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionQueryConduitAPIMethod.php
index 22c4adad45..e9f5681f9f 100644
--- a/src/applications/diffusion/conduit/DiffusionQueryConduitAPIMethod.php
+++ b/src/applications/diffusion/conduit/DiffusionQueryConduitAPIMethod.php
@@ -13,7 +13,7 @@ abstract class DiffusionQueryConduitAPIMethod
 
   public function getMethodStatusDescription() {
     return pht(
-      'See T2784 - migrating diffusion working copy calls to conduit methods. '.
+      'See T2784 - migrating Diffusion working copy calls to conduit methods. '.
       'Until that task is completed (and possibly after) these methods are '.
       'unstable.');
   }
diff --git a/src/applications/diffusion/conduit/DiffusionRawDiffQueryConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionRawDiffQueryConduitAPIMethod.php
index a7e217d2aa..282dc7eb9b 100644
--- a/src/applications/diffusion/conduit/DiffusionRawDiffQueryConduitAPIMethod.php
+++ b/src/applications/diffusion/conduit/DiffusionRawDiffQueryConduitAPIMethod.php
@@ -8,9 +8,9 @@ final class DiffusionRawDiffQueryConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return
+    return pht(
       'Get raw diff information from a repository for a specific commit at an '.
-      '(optional) path.';
+      '(optional) path.');
   }
 
   protected function defineReturnType() {
diff --git a/src/applications/diffusion/conduit/DiffusionRefsQueryConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionRefsQueryConduitAPIMethod.php
index 2d025e9d4a..00bb28b385 100644
--- a/src/applications/diffusion/conduit/DiffusionRefsQueryConduitAPIMethod.php
+++ b/src/applications/diffusion/conduit/DiffusionRefsQueryConduitAPIMethod.php
@@ -8,8 +8,8 @@ final class DiffusionRefsQueryConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return
-      'Query a git repository for ref information at a specific commit.';
+    return pht(
+      'Query a git repository for ref information at a specific commit.');
   }
 
   protected function defineReturnType() {
diff --git a/src/applications/diffusion/conduit/DiffusionSearchQueryConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionSearchQueryConduitAPIMethod.php
index 5cf91a10f0..16b9762e1d 100644
--- a/src/applications/diffusion/conduit/DiffusionSearchQueryConduitAPIMethod.php
+++ b/src/applications/diffusion/conduit/DiffusionSearchQueryConduitAPIMethod.php
@@ -8,7 +8,7 @@ final class DiffusionSearchQueryConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Search (grep) a repository at a specific path and commit.';
+    return pht('Search (grep) a repository at a specific path and commit.');
   }
 
   protected function defineReturnType() {
@@ -27,7 +27,7 @@ final class DiffusionSearchQueryConduitAPIMethod
 
   protected function defineCustomErrorTypes() {
     return array(
-      'ERR-GREP-COMMAND' => 'Grep command failed.',
+      'ERR-GREP-COMMAND' => pht('Grep command failed.'),
     );
   }
 
diff --git a/src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php b/src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php
index 644556cd66..28a9e1b670 100644
--- a/src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php
+++ b/src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php
@@ -35,9 +35,10 @@ final class PhabricatorDiffusionConfigOptions
             pht('Attach Patches'),
             pht('Do Not Attach Patches'),
           ))
-        ->setDescription(pht(
-          'Set this to true if you want patches to be attached to commit '.
-          'notifications from Diffusion.')),
+        ->setDescription(
+          pht(
+            'Set this to true if you want patches to be attached to commit '.
+            'notifications from Diffusion.')),
       $this->newOption('metamta.diffusion.inline-patches', 'int', 0)
         ->setSummary(pht('Include patches in Diffusion mail as body text.'))
         ->setDescription(
@@ -63,10 +64,11 @@ final class PhabricatorDiffusionConfigOptions
       $this->newOption('bugtraq.url', 'string', null)
         ->addExample('https://bugs.php.net/%BUGID%', pht('PHP bugs'))
         ->addExample('/%BUGID%', pht('Local Maniphest URL'))
-        ->setDescription(pht(
-          'URL of external bug tracker used by Diffusion. %s will be '.
+        ->setDescription(
+          pht(
+            'URL of external bug tracker used by Diffusion. %s will be '.
             'substituted by the bug ID.',
-          '%BUGID%')),
+            '%BUGID%')),
       $this->newOption('bugtraq.logregex', 'list<regex>', array())
         ->addExample(array('/\B#([1-9]\d*)\b/'), pht('Issue #123'))
         ->addExample(
@@ -74,8 +76,9 @@ final class PhabricatorDiffusionConfigOptions
           pht('Issue #123, #456'))
         ->addExample(array('/(?<!#)\b(T[1-9]\d*)\b/'), pht('Task T123'))
         ->addExample('/[A-Z]{2,}-\d+/', pht('JIRA-1234'))
-        ->setDescription(pht(
-          'Regular expression to link external bug tracker. See '.
+        ->setDescription(
+          pht(
+            'Regular expression to link external bug tracker. See '.
             'http://tortoisesvn.net/docs/release/TortoiseSVN_en/'.
             'tsvn-dug-bugtracker.html for further explanation.')),
       $this->newOption('diffusion.allow-http-auth', 'bool', false)
diff --git a/src/applications/diffusion/controller/DiffusionBrowseDirectoryController.php b/src/applications/diffusion/controller/DiffusionBrowseDirectoryController.php
index 833e108648..0d54aba087 100644
--- a/src/applications/diffusion/controller/DiffusionBrowseDirectoryController.php
+++ b/src/applications/diffusion/controller/DiffusionBrowseDirectoryController.php
@@ -98,7 +98,9 @@ final class DiffusionBrowseDirectoryController
       array(
         'title' => array(
           nonempty(basename($drequest->getPath()), '/'),
-          $drequest->getRepository()->getCallsign().' Repository',
+          pht(
+            '%s Repository',
+            $drequest->getRepository()->getCallsign()),
         ),
       ));
   }
diff --git a/src/applications/diffusion/controller/DiffusionBrowseFileController.php b/src/applications/diffusion/controller/DiffusionBrowseFileController.php
index 6fcda177a5..c55d217bfe 100644
--- a/src/applications/diffusion/controller/DiffusionBrowseFileController.php
+++ b/src/applications/diffusion/controller/DiffusionBrowseFileController.php
@@ -124,13 +124,15 @@ final class DiffusionBrowseFileController extends DiffusionBrowseController {
       switch ($follow) {
         case 'first':
           $notice->appendChild(
-            pht('Unable to continue tracing the history of this file because '.
-            'this commit is the first commit in the repository.'));
+            pht(
+              'Unable to continue tracing the history of this file because '.
+              'this commit is the first commit in the repository.'));
           break;
         case 'created':
           $notice->appendChild(
-            pht('Unable to continue tracing the history of this file because '.
-            'this commit created the file.'));
+            pht(
+              'Unable to continue tracing the history of this file because '.
+              'this commit created the file.'));
           break;
       }
       $content[] = $notice;
@@ -142,7 +144,8 @@ final class DiffusionBrowseFileController extends DiffusionBrowseController {
       $notice->setSeverity(PHUIInfoView::SEVERITY_NOTICE);
       $notice->setTitle(pht('File Renamed'));
       $notice->appendChild(
-        pht("File history passes through a rename from '%s' to '%s'.",
+        pht(
+          "File history passes through a rename from '%s' to '%s'.",
           $drequest->getPath(), $renamed));
       $content[] = $notice;
     }
diff --git a/src/applications/diffusion/controller/DiffusionBrowseSearchController.php b/src/applications/diffusion/controller/DiffusionBrowseSearchController.php
index ac0f74e79e..550fe38773 100644
--- a/src/applications/diffusion/controller/DiffusionBrowseSearchController.php
+++ b/src/applications/diffusion/controller/DiffusionBrowseSearchController.php
@@ -33,7 +33,9 @@ final class DiffusionBrowseSearchController extends DiffusionBrowseController {
       array(
         'title' => array(
           nonempty(basename($drequest->getPath()), '/'),
-          $drequest->getRepository()->getCallsign().' Repository',
+          pht(
+            '%s Repository',
+            $drequest->getRepository()->getCallsign()),
         ),
       ));
   }
diff --git a/src/applications/diffusion/controller/DiffusionCommitBranchesController.php b/src/applications/diffusion/controller/DiffusionCommitBranchesController.php
index 0be218fac8..4f12e17656 100644
--- a/src/applications/diffusion/controller/DiffusionCommitBranchesController.php
+++ b/src/applications/diffusion/controller/DiffusionCommitBranchesController.php
@@ -39,6 +39,6 @@ final class DiffusionCommitBranchesController extends DiffusionController {
     }
 
     return id(new AphrontAjaxResponse())
-      ->setContent($branch_links ? implode(', ', $branch_links) : 'None');
+      ->setContent($branch_links ? implode(', ', $branch_links) : pht('None'));
   }
 }
diff --git a/src/applications/diffusion/controller/DiffusionCommitController.php b/src/applications/diffusion/controller/DiffusionCommitController.php
index 1126cb659d..b30cfb0680 100644
--- a/src/applications/diffusion/controller/DiffusionCommitController.php
+++ b/src/applications/diffusion/controller/DiffusionCommitController.php
@@ -83,10 +83,12 @@ final class DiffusionCommitController extends DiffusionController {
       $error_panel->setTitle(pht('Commit Not Tracked'));
       $error_panel->setSeverity(PHUIInfoView::SEVERITY_WARNING);
       $error_panel->appendChild(
-        pht("This Diffusion repository is configured to track only one ".
-        "subdirectory of the entire Subversion repository, and this commit ".
-        "didn't affect the tracked subdirectory ('%s'), so no ".
-        "information is available.", $subpath));
+        pht(
+          "This Diffusion repository is configured to track only one ".
+          "subdirectory of the entire Subversion repository, and this commit ".
+          "didn't affect the tracked subdirectory ('%s'), so no ".
+          "information is available.",
+          $subpath));
       $content[] = $error_panel;
     } else {
       $engine = PhabricatorMarkupEngine::newDifferentialMarkupEngine();
@@ -238,7 +240,7 @@ final class DiffusionCommitController extends DiffusionController {
 
       $change_panel = new PHUIObjectBoxView();
       $header = new PHUIHeaderView();
-      $header->setHeader('Changes ('.number_format($count).')');
+      $header->setHeader(pht('Changes (%d', number_format($count)));
       $change_panel->setID('toc');
       if ($count > self::CHANGES_LIMIT && !$show_all_details) {
 
@@ -253,7 +255,7 @@ final class DiffusionCommitController extends DiffusionController {
 
         $warning_view = id(new PHUIInfoView())
           ->setSeverity(PHUIInfoView::SEVERITY_WARNING)
-          ->setTitle('Very Large Commit')
+          ->setTitle(pht('Very Large Commit'))
           ->appendChild(
             pht('This commit is very large. Load each file individually.'));
 
@@ -280,7 +282,7 @@ final class DiffusionCommitController extends DiffusionController {
           $vcs_supports_directory_changes = false;
           break;
         default:
-          throw new Exception('Unknown VCS.');
+          throw new Exception(pht('Unknown VCS.'));
       }
 
       $references = array();
@@ -901,8 +903,8 @@ final class DiffusionCommitController extends DiffusionController {
       $caption->setSeverity(PHUIInfoView::SEVERITY_NOTICE);
       $caption->appendChild(
         pht(
-          'This commit merges a very large number of changes. Only the first '.
-          '%s are shown.',
+          'This commit merges a very large number of changes. '.
+          'Only the first %s are shown.',
           new PhutilNumber($limit)));
     }
 
diff --git a/src/applications/diffusion/controller/DiffusionController.php b/src/applications/diffusion/controller/DiffusionController.php
index 0b3e97a097..262223c6f9 100644
--- a/src/applications/diffusion/controller/DiffusionController.php
+++ b/src/applications/diffusion/controller/DiffusionController.php
@@ -11,7 +11,7 @@ abstract class DiffusionController extends PhabricatorController {
 
   protected function getDiffusionRequest() {
     if (!$this->diffusionRequest) {
-      throw new Exception('No Diffusion request object!');
+      throw new Exception(pht('No Diffusion request object!'));
     }
     return $this->diffusionRequest;
   }
diff --git a/src/applications/diffusion/controller/DiffusionExternalController.php b/src/applications/diffusion/controller/DiffusionExternalController.php
index c48553842f..4ab698b07c 100644
--- a/src/applications/diffusion/controller/DiffusionExternalController.php
+++ b/src/applications/diffusion/controller/DiffusionExternalController.php
@@ -75,9 +75,11 @@ final class DiffusionExternalController extends DiffusionController {
         ->appendChild(phutil_tag(
           'p',
           array(),
-          pht('This external (%s) does not appear in any tracked '.
-          'repository. It may exist in an untracked repository that '.
-          'Diffusion does not know about.', $desc)));
+          pht(
+            'This external (%s) does not appear in any tracked '.
+            'repository. It may exist in an untracked repository that '.
+            'Diffusion does not know about.',
+            $desc)));
     } else if (count($commits) == 1) {
       $commit = head($commits);
       $repo = $repositories[$commit->getRepositoryID()];
diff --git a/src/applications/diffusion/controller/DiffusionHistoryController.php b/src/applications/diffusion/controller/DiffusionHistoryController.php
index 36667c5dfe..887e4cbd2e 100644
--- a/src/applications/diffusion/controller/DiffusionHistoryController.php
+++ b/src/applications/diffusion/controller/DiffusionHistoryController.php
@@ -168,6 +168,4 @@ final class DiffusionHistoryController extends DiffusionController {
     return $view;
   }
 
-
-
 }
diff --git a/src/applications/diffusion/controller/DiffusionInlineCommentController.php b/src/applications/diffusion/controller/DiffusionInlineCommentController.php
index fb3d87167f..09f5f06ad5 100644
--- a/src/applications/diffusion/controller/DiffusionInlineCommentController.php
+++ b/src/applications/diffusion/controller/DiffusionInlineCommentController.php
@@ -33,7 +33,7 @@ final class DiffusionInlineCommentController
       PhabricatorRepository::TABLE_PATH,
       $path_id);
     if (!$path) {
-      throw new Exception('Invalid path ID!');
+      throw new Exception(pht('Invalid path ID!'));
     }
 
     return id(new PhabricatorAuditInlineComment())
@@ -55,7 +55,7 @@ final class DiffusionInlineCommentController
 
     $inline = $this->loadComment($id);
     if (!$this->canEditInlineComment($user, $inline)) {
-      throw new Exception('That comment is not editable!');
+      throw new Exception(pht('That comment is not editable!'));
     }
     return $inline;
   }
diff --git a/src/applications/diffusion/controller/DiffusionPathValidateController.php b/src/applications/diffusion/controller/DiffusionPathValidateController.php
index 1b839aab47..d54ddd7af6 100644
--- a/src/applications/diffusion/controller/DiffusionPathValidateController.php
+++ b/src/applications/diffusion/controller/DiffusionPathValidateController.php
@@ -58,7 +58,7 @@ final class DiffusionPathValidateController extends DiffusionController {
       if ($branch) {
         $message = pht('Not found in %s', $branch);
       } else {
-        $message = pht('Not found at HEAD');
+        $message = pht('Not found at %s', 'HEAD');
       }
     } else {
       $message = pht('OK');
diff --git a/src/applications/diffusion/controller/DiffusionRepositoryController.php b/src/applications/diffusion/controller/DiffusionRepositoryController.php
index 7eb99b7096..ff81c02ab4 100644
--- a/src/applications/diffusion/controller/DiffusionRepositoryController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryController.php
@@ -60,8 +60,7 @@ final class DiffusionRepositoryController extends DiffusionController {
         }
       } else {
         $empty_title = pht('Empty Repository');
-        $empty_message = pht(
-          'This repository does not have any commits yet.');
+        $empty_message = pht('This repository does not have any commits yet.');
       }
     }
 
@@ -391,9 +390,9 @@ final class DiffusionRepositoryController extends DiffusionController {
     $button->setTag('a');
     $button->setIcon($icon);
     $button->setHref($drequest->generateURI(
-            array(
-              'action' => 'branches',
-            )));
+      array(
+        'action' => 'branches',
+      )));
 
     $header->addActionLink($button);
     $panel->setHeader($header);
diff --git a/src/applications/diffusion/controller/DiffusionRepositoryCreateController.php b/src/applications/diffusion/controller/DiffusionRepositoryCreateController.php
index d077d031f0..269523915e 100644
--- a/src/applications/diffusion/controller/DiffusionRepositoryCreateController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryCreateController.php
@@ -71,7 +71,7 @@ final class DiffusionRepositoryCreateController
         $cancel_uri = $this->getApplicationURI('new/');
         break;
       default:
-        throw new Exception('Invalid edit operation!');
+        throw new Exception(pht('Invalid edit operation!'));
     }
 
     $form = id(new PHUIPagedFormView())
@@ -483,7 +483,7 @@ final class DiffusionRepositoryCreateController
         $is_mercurial = true;
         break;
       default:
-        throw new Exception('Unsupported VCS!');
+        throw new Exception(pht('Unsupported VCS!'));
     }
 
     $has_local = ($is_git || $is_mercurial);
@@ -527,7 +527,7 @@ final class DiffusionRepositoryCreateController
         "repository, use the //Import Only// option at the end of this ".
         "workflow.)");
     } else {
-      throw new Exception('Unsupported VCS!');
+      throw new Exception(pht('Unsupported VCS!'));
     }
 
     $page->addRemarkupInstructions($instructions, 'remoteURI');
@@ -623,7 +623,7 @@ final class DiffusionRepositoryCreateController
           $remote_uri),
         'credential');
     } else {
-      throw new Exception('Unknown URI protocol!');
+      throw new Exception(pht('Unknown URI protocol!'));
     }
 
     if ($provides_type) {
@@ -734,8 +734,7 @@ final class DiffusionRepositoryCreateController
         ->setAdjustFormPageCallback(array($this, 'adjustPolicyPage'))
         ->setUser($viewer)
         ->addRemarkupInstructions(
-          pht(
-            'Select access policies for this repository.'))
+          pht('Select access policies for this repository.'))
         ->addControl($view_policy)
         ->addControl($edit_policy)
         ->addControl($push_policy);
diff --git a/src/applications/diffusion/controller/DiffusionRepositoryEditActionsController.php b/src/applications/diffusion/controller/DiffusionRepositoryEditActionsController.php
index 3c149e8cea..2b0bc674be 100644
--- a/src/applications/diffusion/controller/DiffusionRepositoryEditActionsController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryEditActionsController.php
@@ -75,8 +75,7 @@ final class DiffusionRepositoryEditActionsController
           "new commits. You can disable publishing for this repository by ".
           "turning off **Notify/Publish**. This will disable notifications, ".
           "feed, and Herald (including audits and build plans) for this ".
-          "repository.".
-          "\n\n".
+          "repository.\n\n".
           "When Phabricator discovers a new commit, it can automatically ".
           "close associated revisions and tasks. If you don't want ".
           "Phabricator to close objects when it discovers new commits in ".
diff --git a/src/applications/diffusion/controller/DiffusionRepositoryEditBasicController.php b/src/applications/diffusion/controller/DiffusionRepositoryEditBasicController.php
index 986f46cec5..80771f65c4 100644
--- a/src/applications/diffusion/controller/DiffusionRepositoryEditBasicController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryEditBasicController.php
@@ -152,19 +152,25 @@ final class DiffusionRepositoryEditBasicController
 
   private function getReadmeInstructions() {
     return pht(<<<EOTEXT
-You can also create a `README` file at the repository root (or in any
+You can also create a `%s` file at the repository root (or in any
 subdirectory) to provide information about the repository. These formats are
 supported:
 
-| File Name       | Rendered As... |
-|-----------------|----------------|
-| `README`          | Plain Text |
-| `README.txt`      | Plain Text |
-| `README.remarkup` | Remarkup |
-| `README.md`       | Remarkup |
-| `README.rainbow`  | \xC2\xA1Fiesta! |
+| File Name | Rendered As...  |
+|-----------|-----------------|
+| `%s`      | Plain Text      |
+| `%s`      | Plain Text      |
+| `%s`      | Remarkup        |
+| `%s`      | Remarkup        |
+| `%s`      | \xC2\xA1Fiesta! |
 EOTEXT
-);
+  ,
+  'README',
+  'README',
+  'README.txt',
+  'README.remarkup',
+  'README.md',
+  'README.rainbow');
   }
 
 }
diff --git a/src/applications/diffusion/controller/DiffusionRepositoryEditBranchesController.php b/src/applications/diffusion/controller/DiffusionRepositoryEditBranchesController.php
index 2d0a7e53f5..a175fba941 100644
--- a/src/applications/diffusion/controller/DiffusionRepositoryEditBranchesController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryEditBranchesController.php
@@ -126,20 +126,20 @@ final class DiffusionRepositoryEditBranchesController
         'develop',
         'release',
       ),
-      pht('Select master, develop, and release.'),
+      pht('Select %s, %s, and %s.', 'master', 'develop', 'release'),
     );
     $rows[] = array(
       array(
         'master',
         'regexp(/^release-/)',
       ),
-      pht('Select master, and all branches which start with "release-".'),
+      pht('Select master, and all branches which start with "%s".', 'release-'),
     );
     $rows[] = array(
       array(
         'regexp(/^(?!temp-)/)',
       ),
-      pht('Select all branches which do not start with "temp-".'),
+      pht('Select all branches which do not start with "%s".', 'temp-'),
     );
 
     foreach ($rows as $k => $row) {
@@ -167,8 +167,7 @@ final class DiffusionRepositoryEditBranchesController
     $form = id(new AphrontFormView())
       ->setUser($viewer)
       ->appendRemarkupInstructions(
-        pht(
-          'You can choose a **Default Branch** for viewing this repository.'))
+        pht('You can choose a **Default Branch** for viewing this repository.'))
       ->appendChild(
         id(new AphrontFormTextControl())
           ->setName('default')
@@ -196,7 +195,8 @@ final class DiffusionRepositoryEditBranchesController
         pht(
           'When specifying branches, you should enter one branch name per '.
           'line. You can use regular expressions to match branches by '.
-          'wrapping an expression in `regexp(...)`. For example:'))
+          'wrapping an expression in `%s`. For example:',
+          'regexp(...)'))
       ->appendChild(
         id(new AphrontFormMarkupControl())
           ->setValue($example_table))
diff --git a/src/applications/diffusion/controller/DiffusionRepositoryEditDeleteController.php b/src/applications/diffusion/controller/DiffusionRepositoryEditDeleteController.php
index 34a8431651..f39708fe1b 100644
--- a/src/applications/diffusion/controller/DiffusionRepositoryEditDeleteController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryEditDeleteController.php
@@ -30,8 +30,9 @@ final class DiffusionRepositoryEditDeleteController
     $command = csprintf(
       'phabricator/ $ ./bin/remove destroy %R',
       $repository->getMonogram());
-    $text_2 = pht('Repositories touch many objects and as such deletes are '.
-                  'prohibitively expensive to run from the web UI.');
+    $text_2 = pht(
+      'Repositories touch many objects and as such deletes are '.
+      'prohibitively expensive to run from the web UI.');
     $body = phutil_tag(
       'div',
       array(
diff --git a/src/applications/diffusion/controller/DiffusionRepositoryEditEncodingController.php b/src/applications/diffusion/controller/DiffusionRepositoryEditEncodingController.php
index 1abbad6521..f71516e6ca 100644
--- a/src/applications/diffusion/controller/DiffusionRepositoryEditEncodingController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryEditEncodingController.php
@@ -104,8 +104,7 @@ See [[%s | UTF-8 and Character Encoding]] for more information on how
 Phabricator handles text encodings.
 EOT
     ,
-    PhabricatorEnv::getDoclink(
-      'User Guide: UTF-8 and Character Encoding'));
+    PhabricatorEnv::getDoclink('User Guide: UTF-8 and Character Encoding'));
   }
 
 }
diff --git a/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php b/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
index a5ad77f87e..905021ab23 100644
--- a/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
@@ -819,8 +819,9 @@ final class DiffusionRepositoryEditMainController
               ->setTarget(
                 pht('Missing Binary %s', phutil_tag('tt', array(), $binary)))
               ->setNote(pht(
-                  'Unable to find this binary in `environment.append-paths`. '.
+                  'Unable to find this binary in `%s`. '.
                   'You need to configure %s and include %s.',
+                  'environment.append-paths',
                   $this->getEnvConfigLink(),
                   $path)));
           }
diff --git a/src/applications/diffusion/controller/DiffusionRepositoryEditStorageController.php b/src/applications/diffusion/controller/DiffusionRepositoryEditStorageController.php
index 07da9a6442..345464a005 100644
--- a/src/applications/diffusion/controller/DiffusionRepositoryEditStorageController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryEditStorageController.php
@@ -57,10 +57,11 @@ final class DiffusionRepositoryEditStorageController
       ->appendRemarkupInstructions(
         pht(
           "You can not adjust the local path for this repository from the ".
-          "web interface. To edit it, run this command:\n\n".
-          "  phabricator/ $ ./bin/repository edit %s --as %s --local-path ...",
-          $repository->getCallsign(),
-          $user->getUsername()))
+          "web interface. To edit it, run this command:\n\n  %s",
+          sprintf(
+            'phabricator/ $ ./bin/repository edit %s --as %s --local-path ...',
+            $repository->getCallsign(),
+            $user->getUsername())))
       ->appendChild(
         id(new AphrontFormSubmitControl())
           ->addCancelButton($edit_uri, pht('Done')));
diff --git a/src/applications/diffusion/controller/DiffusionRepositoryEditSubversionController.php b/src/applications/diffusion/controller/DiffusionRepositoryEditSubversionController.php
index 83cda151d7..b125f26cae 100644
--- a/src/applications/diffusion/controller/DiffusionRepositoryEditSubversionController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryEditSubversionController.php
@@ -84,11 +84,11 @@ final class DiffusionRepositoryEditSubversionController
         pht(
           "You can set the **Repository UUID**, which will help Phabriactor ".
           "provide better context in some cases. You can find the UUID of a ".
-          "repository by running `svn info`.".
-          "\n\n".
+          "repository by running `%s`.\n\n".
           "If you want to import only part of a repository, like `trunk/`, ".
           "you can set a path in **Import Only**. Phabricator will ignore ".
-          "commits which do not affect this path."))
+          "commits which do not affect this path.",
+          'svn info'))
       ->appendChild(
         id(new AphrontFormTextControl())
           ->setName('uuid')
diff --git a/src/applications/diffusion/controller/DiffusionRepositoryNewController.php b/src/applications/diffusion/controller/DiffusionRepositoryNewController.php
index efab745433..f7fac7b183 100644
--- a/src/applications/diffusion/controller/DiffusionRepositoryNewController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryNewController.php
@@ -53,11 +53,11 @@ final class DiffusionRepositoryNewController extends DiffusionController {
             'import',
             pht('Import an Existing External Repository'),
             pht(
-              'Import a repository hosted somewhere else, like GitHub, '.
-              'Bitbucket, or your organization\'s existing servers. '.
-              'Phabricator will read changes from the repository but will '.
-              'not host or manage it. The authoritative master version of '.
-              'the repository will stay where it is now.')))
+              "Import a repository hosted somewhere else, like GitHub, ".
+              "Bitbucket, or your organization's existing servers. ".
+              "Phabricator will read changes from the repository but will ".
+              "not host or manage it. The authoritative master version of ".
+              "the repository will stay where it is now.")))
       ->appendChild(
         id(new AphrontFormSubmitControl())
           ->setValue(pht('Continue'))
diff --git a/src/applications/diffusion/controller/DiffusionServeController.php b/src/applications/diffusion/controller/DiffusionServeController.php
index 2b82bde43d..a76acd704c 100644
--- a/src/applications/diffusion/controller/DiffusionServeController.php
+++ b/src/applications/diffusion/controller/DiffusionServeController.php
@@ -342,7 +342,11 @@ final class DiffusionServeController extends DiffusionController {
     // resolve the binary first.
     $bin = Filesystem::resolveBinary('git-http-backend');
     if (!$bin) {
-      throw new Exception('Unable to find `git-http-backend` in PATH!');
+      throw new Exception(
+        pht(
+          'Unable to find `%s` in %s!',
+          'git-http-backend',
+          '$PATH'));
     }
 
     $env = array(
@@ -485,7 +489,11 @@ final class DiffusionServeController extends DiffusionController {
 
     $bin = Filesystem::resolveBinary('hg');
     if (!$bin) {
-      throw new Exception('Unable to find `hg` in PATH!');
+      throw new Exception(
+        pht(
+          'Unable to find `%s` in %s!',
+          'hg',
+          '$PATH'));
     }
 
     $env = $this->getCommonEnvironment($viewer);
diff --git a/src/applications/diffusion/data/DiffusionGitBranch.php b/src/applications/diffusion/data/DiffusionGitBranch.php
index 925ede568c..8f69645b73 100644
--- a/src/applications/diffusion/data/DiffusionGitBranch.php
+++ b/src/applications/diffusion/data/DiffusionGitBranch.php
@@ -42,7 +42,10 @@ final class DiffusionGitBranch {
           continue;
       }
       if (!preg_match('/^ *(\S+)\s+([a-z0-9]{40})/', $line, $matches)) {
-        throw new Exception("Failed to parse {$line}!");
+        throw new Exception(
+          pht(
+            'Failed to parse %s!',
+            $line));
       }
 
       $remote_branch = $matches[1];
@@ -57,7 +60,9 @@ final class DiffusionGitBranch {
         $matches = null;
         if (!preg_match('#^([^/]+)/(.*)$#', $remote_branch, $matches)) {
           throw new Exception(
-            "Failed to parse remote branch '{$remote_branch}'!");
+            pht(
+              "Failed to parse remote branch '%s'!",
+              $remote_branch));
         }
         $remote_name = $matches[1];
         $branch_name = $matches[2];
@@ -84,7 +89,10 @@ final class DiffusionGitBranch {
     foreach ($lines as $line) {
       $matches = null;
       if (!preg_match($regex, $line, $matches)) {
-        throw new Exception("Failed to parse {$line}!");
+        throw new Exception(
+          pht(
+            'Failed to parse %s!',
+            $line));
       }
 
       $branch = $matches[1];
diff --git a/src/applications/diffusion/data/DiffusionRepositoryTag.php b/src/applications/diffusion/data/DiffusionRepositoryTag.php
index 12e71185bf..555e082700 100644
--- a/src/applications/diffusion/data/DiffusionRepositoryTag.php
+++ b/src/applications/diffusion/data/DiffusionRepositoryTag.php
@@ -72,7 +72,7 @@ final class DiffusionRepositoryTag {
 
   public function getMessage() {
     if ($this->message === false) {
-      throw new Exception('Message is not attached!');
+      throw new Exception(pht('Message is not attached!'));
     }
     return $this->message;
   }
diff --git a/src/applications/diffusion/engine/DiffusionCommitHookEngine.php b/src/applications/diffusion/engine/DiffusionCommitHookEngine.php
index 13c7127e08..f84eb13bdf 100644
--- a/src/applications/diffusion/engine/DiffusionCommitHookEngine.php
+++ b/src/applications/diffusion/engine/DiffusionCommitHookEngine.php
@@ -697,7 +697,10 @@ final class DiffusionCommitHookEngine extends Phobject {
   private function findMercurialChangegroupRefUpdates() {
     $hg_node = getenv('HG_NODE');
     if (!$hg_node) {
-      throw new Exception(pht('Expected HG_NODE in environment!'));
+      throw new Exception(
+        pht(
+          'Expected %s in environment!',
+          'HG_NODE'));
     }
 
     // NOTE: We need to make sure this is passed to subprocesses, or they won't
diff --git a/src/applications/diffusion/exception/DiffusionSetupException.php b/src/applications/diffusion/exception/DiffusionSetupException.php
index eecf7a81fc..0ce5994b7e 100644
--- a/src/applications/diffusion/exception/DiffusionSetupException.php
+++ b/src/applications/diffusion/exception/DiffusionSetupException.php
@@ -3,7 +3,7 @@
 final class DiffusionSetupException extends AphrontUsageException {
 
   public function __construct($message) {
-    parent::__construct('Diffusion Setup Exception', $message);
+    parent::__construct(pht('Diffusion Setup Exception'), $message);
   }
 
 }
diff --git a/src/applications/diffusion/protocol/DiffusionMercurialWireProtocol.php b/src/applications/diffusion/protocol/DiffusionMercurialWireProtocol.php
index 578196ff69..6d52573656 100644
--- a/src/applications/diffusion/protocol/DiffusionMercurialWireProtocol.php
+++ b/src/applications/diffusion/protocol/DiffusionMercurialWireProtocol.php
@@ -28,7 +28,7 @@ final class DiffusionMercurialWireProtocol {
     );
 
     if (!isset($commands[$command])) {
-      throw new Exception("Unknown Mercurial command '{$command}!");
+      throw new Exception(pht("Unknown Mercurial command '%s!", $command));
     }
 
     return $commands[$command];
@@ -65,7 +65,7 @@ final class DiffusionMercurialWireProtocol {
       // on the side of caution and throw if we don't get any data here. This
       // either indicates a mangled command from the client or a programming
       // error in our code.
-      throw new Exception("Expected nonempty 'cmds' specification!");
+      throw new Exception(pht("Expected nonempty '%s' specification!", 'cmds'));
     }
 
     // For "batch" we get a "cmds" argument like:
diff --git a/src/applications/diffusion/protocol/DiffusionSubversionWireProtocol.php b/src/applications/diffusion/protocol/DiffusionSubversionWireProtocol.php
index e5645859a4..1cb0f107aa 100644
--- a/src/applications/diffusion/protocol/DiffusionSubversionWireProtocol.php
+++ b/src/applications/diffusion/protocol/DiffusionSubversionWireProtocol.php
@@ -93,7 +93,7 @@ final class DiffusionSubversionWireProtocol extends Phobject {
           $this->state = 'item';
         }
       } else {
-        throw new Exception("Invalid state '{$this->state}'!");
+        throw new Exception(pht("Invalid state '%s'!", $this->state));
       }
     }
 
@@ -124,7 +124,10 @@ final class DiffusionSubversionWireProtocol extends Phobject {
           $out[] = self::serializeStruct($value);
           break;
         default:
-          throw new Exception("Unknown SVN wire protocol structure '{$type}'!");
+          throw new Exception(
+            pht(
+              "Unknown SVN wire protocol structure '%s'!",
+              $type));
       }
       if ($type != 'list') {
         $out[] = ' ';
@@ -139,7 +142,9 @@ final class DiffusionSubversionWireProtocol extends Phobject {
     if (empty($struct[0]['type']) || ($struct[0]['type'] != 'word')) {
       // This isn't what we expect; fail defensively.
       throw new Exception(
-        pht("Unexpected command structure, expected '( word ... )'."));
+        pht(
+          "Unexpected command structure, expected '%s'.",
+          '( word ... )'));
     }
 
     switch ($struct[0]['value']) {
diff --git a/src/applications/diffusion/query/DiffusionCachedResolveRefsQuery.php b/src/applications/diffusion/query/DiffusionCachedResolveRefsQuery.php
index 8190a035f2..55e86ce879 100644
--- a/src/applications/diffusion/query/DiffusionCachedResolveRefsQuery.php
+++ b/src/applications/diffusion/query/DiffusionCachedResolveRefsQuery.php
@@ -42,7 +42,7 @@ final class DiffusionCachedResolveRefsQuery
         $result = $this->resolveSubversionRefs();
         break;
       default:
-        throw new Exception('Unsupported repository type!');
+        throw new Exception(pht('Unsupported repository type!'));
     }
 
     if ($this->types !== null) {
diff --git a/src/applications/diffusion/query/DiffusionCommitQuery.php b/src/applications/diffusion/query/DiffusionCommitQuery.php
index 23f886154b..93efb1df12 100644
--- a/src/applications/diffusion/query/DiffusionCommitQuery.php
+++ b/src/applications/diffusion/query/DiffusionCommitQuery.php
@@ -144,7 +144,9 @@ final class DiffusionCommitQuery
   public function getIdentifierMap() {
     if ($this->identifierMap === null) {
       throw new Exception(
-        'You must execute() the query before accessing the identifier map.');
+        pht(
+          'You must %s the query before accessing the identifier map.',
+          'execute()'));
     }
     return $this->identifierMap;
   }
@@ -491,8 +493,10 @@ final class DiffusionCommitQuery
             self::AUDIT_STATUS_PARTIAL,
           );
           throw new Exception(
-            "Unknown audit status '{$status}'! Valid statuses are: ".
-            implode(', ', $valid));
+            pht(
+              "Unknown audit status '%s'! Valid statuses are: %s.",
+              $status,
+              implode(', ', $valid)));
       }
     }
 
diff --git a/src/applications/diffusion/query/DiffusionQuery.php b/src/applications/diffusion/query/DiffusionQuery.php
index 24f58583bf..a180a61f5a 100644
--- a/src/applications/diffusion/query/DiffusionQuery.php
+++ b/src/applications/diffusion/query/DiffusionQuery.php
@@ -32,7 +32,7 @@ abstract class DiffusionQuery extends PhabricatorQuery {
 
     $name = idx($map, $repository->getVersionControlSystem());
     if (!$name) {
-      throw new Exception('Unsupported VCS!');
+      throw new Exception(pht('Unsupported VCS!'));
     }
 
     $class = str_replace('Diffusion', 'Diffusion'.$name, $base_class);
diff --git a/src/applications/diffusion/query/filecontent/DiffusionGitFileContentQuery.php b/src/applications/diffusion/query/filecontent/DiffusionGitFileContentQuery.php
index ec0729d453..67c6369940 100644
--- a/src/applications/diffusion/query/filecontent/DiffusionGitFileContentQuery.php
+++ b/src/applications/diffusion/query/filecontent/DiffusionGitFileContentQuery.php
@@ -45,8 +45,10 @@ final class DiffusionGitFileContentQuery extends DiffusionFileContentQuery {
     // 8220d5d54f6d5d5552a636576cbe9c35f15b65b2
     //                       (Andrew Gallagher       2010-12-03      324)
     //                             // Add the lines for trailing context
-    preg_match('/^\s*?(\S+?)\s*\(\s*(.*?)\s+\d{4}-\d{2}-\d{2}\s+\d+\)(.*)?$/',
-               $line, $m);
+    preg_match(
+      '/^\s*?(\S+?)\s*\(\s*(.*?)\s+\d{4}-\d{2}-\d{2}\s+\d+\)(.*)?$/',
+      $line,
+      $m);
     $rev_id = $m[1];
     $author = $m[2];
     $text = idx($m, 3);
diff --git a/src/applications/diffusion/query/filecontent/DiffusionSvnFileContentQuery.php b/src/applications/diffusion/query/filecontent/DiffusionSvnFileContentQuery.php
index d87db3ec87..be7487969b 100644
--- a/src/applications/diffusion/query/filecontent/DiffusionSvnFileContentQuery.php
+++ b/src/applications/diffusion/query/filecontent/DiffusionSvnFileContentQuery.php
@@ -26,9 +26,10 @@ final class DiffusionSvnFileContentQuery extends DiffusionFileContentQuery {
         // nuked; Diffusion will think it still exists and try to grab content
         // at HEAD.
         throw new Exception(
-          'Failed to retrieve file content from Subversion. The file may '.
-          'have been recently deleted, or the Diffusion cache may be out of '.
-          'date.');
+          pht(
+            'Failed to retrieve file content from Subversion. The file may '.
+            'have been recently deleted, or the Diffusion cache may be out of '.
+            'date.'));
       } else {
         throw $ex;
       }
diff --git a/src/applications/diffusion/query/lowlevel/DiffusionLowLevelCommitQuery.php b/src/applications/diffusion/query/lowlevel/DiffusionLowLevelCommitQuery.php
index 4aaf85d930..43862ce451 100644
--- a/src/applications/diffusion/query/lowlevel/DiffusionLowLevelCommitQuery.php
+++ b/src/applications/diffusion/query/lowlevel/DiffusionLowLevelCommitQuery.php
@@ -17,8 +17,7 @@ final class DiffusionLowLevelCommitQuery
 
   protected function executeQuery() {
     if (!strlen($this->identifier)) {
-      throw new Exception(
-        pht('You must provide an identifier with withIdentifier()!'));
+      throw new PhutilInvalidStateException('withIdentifier');
     }
 
     $type = $this->getRepository()->getVersionControlSystem();
diff --git a/src/applications/diffusion/query/lowlevel/DiffusionLowLevelParentsQuery.php b/src/applications/diffusion/query/lowlevel/DiffusionLowLevelParentsQuery.php
index 2b264bc35c..60ee4b5fe2 100644
--- a/src/applications/diffusion/query/lowlevel/DiffusionLowLevelParentsQuery.php
+++ b/src/applications/diffusion/query/lowlevel/DiffusionLowLevelParentsQuery.php
@@ -12,8 +12,7 @@ final class DiffusionLowLevelParentsQuery
 
   protected function executeQuery() {
     if (!strlen($this->identifier)) {
-      throw new Exception(
-        pht('You must provide an identifier with withIdentifier()!'));
+      throw new PhutilInvalidStateException('withIdentifier');
     }
 
     $type = $this->getRepository()->getVersionControlSystem();
diff --git a/src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php b/src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php
index 3926dbf398..53dc6b30da 100644
--- a/src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php
+++ b/src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php
@@ -42,7 +42,7 @@ final class DiffusionLowLevelResolveRefsQuery
         $result = $this->resolveSubversionRefs();
         break;
       default:
-        throw new Exception('Unsupported repository type!');
+        throw new Exception(pht('Unsupported repository type!'));
     }
 
     if ($this->types !== null) {
@@ -112,7 +112,10 @@ final class DiffusionLowLevelResolveRefsQuery
 
     $lines = explode("\n", rtrim($stdout, "\n"));
     if (count($lines) !== count($unresolved)) {
-      throw new Exception('Unexpected line count from `git cat-file`!');
+      throw new Exception(
+        pht(
+          'Unexpected line count from `%s`!',
+          'git cat-file'));
     }
 
     $hits = array();
@@ -122,7 +125,11 @@ final class DiffusionLowLevelResolveRefsQuery
     foreach ($lines as $ref => $line) {
       $parts = explode(' ', $line);
       if (count($parts) < 2) {
-        throw new Exception("Failed to parse `git cat-file` output: {$line}");
+        throw new Exception(
+          pht(
+            'Failed to parse `%s` output: %s',
+            'git cat-file',
+            $line));
       }
       list($identifier, $type) = $parts;
 
@@ -143,7 +150,10 @@ final class DiffusionLowLevelResolveRefsQuery
           break;
         default:
           throw new Exception(
-            "Unexpected object type from `git cat-file`: {$line}");
+            pht(
+              'Unexpected object type from `%s`: %s',
+              'git cat-file',
+              $line));
       }
 
       $hits[] = array(
@@ -177,7 +187,10 @@ final class DiffusionLowLevelResolveRefsQuery
         $alternate = $identifier;
         $identifier = idx($tag_map, $ref);
         if (!$identifier) {
-          throw new Exception("Failed to look up tag '{$ref}'!");
+          throw new Exception(
+            pht(
+              "Failed to look up tag '%s'!",
+              $ref));
         }
       }
 
diff --git a/src/applications/diffusion/query/pathid/__tests__/DiffusionPathQueryTestCase.php b/src/applications/diffusion/query/pathid/__tests__/DiffusionPathQueryTestCase.php
index b0c6183761..a3ab67e60d 100644
--- a/src/applications/diffusion/query/pathid/__tests__/DiffusionPathQueryTestCase.php
+++ b/src/applications/diffusion/query/pathid/__tests__/DiffusionPathQueryTestCase.php
@@ -6,19 +6,19 @@ final class DiffusionPathQueryTestCase extends PhabricatorTestCase {
     $this->assertEqual(
       '/',
       DiffusionPathIDQuery::getParentPath('/'),
-      'Parent of /');
+      pht('Parent of %s', '/'));
     $this->assertEqual(
       '/',
       DiffusionPathIDQuery::getParentPath('x.txt'),
-      'Parent of x.txt');
+      pht('Parent of %s', 'x.txt'));
     $this->assertEqual(
       '/a',
       DiffusionPathIDQuery::getParentPath('/a/b'),
-      'Parent of /a/b');
+      pht('Parent of %s', '/a/b'));
     $this->assertEqual(
       '/a',
       DiffusionPathIDQuery::getParentPath('/a///b'),
-      'Parent of /a///b');
+      pht('Parent of %s', '/a///b'));
   }
 
   public function testExpandEdgeCases() {
diff --git a/src/applications/diffusion/request/DiffusionGitRequest.php b/src/applications/diffusion/request/DiffusionGitRequest.php
index 48d0761506..6e30886eec 100644
--- a/src/applications/diffusion/request/DiffusionGitRequest.php
+++ b/src/applications/diffusion/request/DiffusionGitRequest.php
@@ -17,7 +17,7 @@ final class DiffusionGitRequest extends DiffusionRequest {
     if ($this->repository) {
       return $this->repository->getDefaultBranch();
     }
-    throw new Exception('Unable to determine branch!');
+    throw new Exception(pht('Unable to determine branch!'));
   }
 
 }
diff --git a/src/applications/diffusion/request/DiffusionMercurialRequest.php b/src/applications/diffusion/request/DiffusionMercurialRequest.php
index 5966ffaaa0..a43cb089dd 100644
--- a/src/applications/diffusion/request/DiffusionMercurialRequest.php
+++ b/src/applications/diffusion/request/DiffusionMercurialRequest.php
@@ -19,7 +19,7 @@ final class DiffusionMercurialRequest extends DiffusionRequest {
       return $this->repository->getDefaultBranch();
     }
 
-    throw new Exception('Unable to determine branch!');
+    throw new Exception(pht('Unable to determine branch!'));
   }
 
 }
diff --git a/src/applications/diffusion/request/DiffusionRequest.php b/src/applications/diffusion/request/DiffusionRequest.php
index e7296e9cc1..2ed8e1f88e 100644
--- a/src/applications/diffusion/request/DiffusionRequest.php
+++ b/src/applications/diffusion/request/DiffusionRequest.php
@@ -62,13 +62,22 @@ abstract class DiffusionRequest {
   final public static function newFromDictionary(array $data) {
     if (isset($data['repository']) && isset($data['callsign'])) {
       throw new Exception(
-        "Specify 'repository' or 'callsign', but not both.");
+        pht(
+          "Specify '%s' or '%s', but not both.",
+          'repository',
+          'callsign'));
     } else if (!isset($data['repository']) && !isset($data['callsign'])) {
       throw new Exception(
-        "One of 'repository' and 'callsign' is required.");
+        pht(
+          "One of '%s' and '%s' is required.",
+          'repository',
+          'callsign'));
     } else if (isset($data['callsign']) && empty($data['user'])) {
       throw new Exception(
-        "Parameter 'user' is required if 'callsign' is provided.");
+        pht(
+          "Parameter '%s' is required if '%s' is provided.",
+          'user',
+          'callsign'));
     }
 
     if (isset($data['repository'])) {
@@ -147,7 +156,7 @@ abstract class DiffusionRequest {
       ->executeOne();
 
     if (!$repository) {
-      throw new Exception("No such repository '{$callsign}'.");
+      throw new Exception(pht("No such repository '%s'.", $callsign));
     }
 
     return self::newFromRepository($repository);
@@ -174,7 +183,7 @@ abstract class DiffusionRequest {
     $class = idx($map, $repository->getVersionControlSystem());
 
     if (!$class) {
-      throw new Exception('Unknown version control system!');
+      throw new Exception(pht('Unknown version control system!'));
     }
 
     $object = new $class();
@@ -207,7 +216,9 @@ abstract class DiffusionRequest {
       $user = idx($data, 'user');
       if (!$user) {
         throw new Exception(
-          'You must provide a PhabricatorUser in the dictionary!');
+          pht(
+            'You must provide a %s in the dictionary!',
+            'PhabricatorUser'));
       }
       $this->setUser($user);
     }
@@ -409,7 +420,7 @@ abstract class DiffusionRequest {
       if (!$data) {
         $data = new PhabricatorRepositoryCommitData();
         $data->setCommitMessage(
-          '(This commit has not been fully parsed yet.)');
+          pht('(This commit has not been fully parsed yet.)'));
       }
       $this->repositoryCommitData = $data;
     }
@@ -533,12 +544,16 @@ abstract class DiffusionRequest {
 
     if ($req_callsign && !strlen($callsign)) {
       throw new Exception(
-        "Diffusion URI action '{$action}' requires callsign!");
+        pht(
+          "Diffusion URI action '%s' requires callsign!",
+          $action));
     }
 
     if ($req_commit && !strlen($commit)) {
       throw new Exception(
-        "Diffusion URI action '{$action}' requires commit!");
+        pht(
+          "Diffusion URI action '%s' requires commit!",
+          $action));
     }
 
     switch ($action) {
@@ -576,7 +591,7 @@ abstract class DiffusionRequest {
         $uri = "/r{$callsign}{$commit}";
         break;
       default:
-        throw new Exception("Unknown Diffusion URI action '{$action}'!");
+        throw new Exception(pht("Unknown Diffusion URI action '%s'!", $action));
     }
 
     if ($action == 'rendering-ref') {
@@ -663,7 +678,7 @@ abstract class DiffusionRequest {
       // Prevent any hyjinx since we're ultimately shipping this to the
       // filesystem under a lot of workflows.
       if ($part == '..') {
-        throw new Exception('Invalid path URI.');
+        throw new Exception(pht('Invalid path URI.'));
       }
     }
 
@@ -689,21 +704,27 @@ abstract class DiffusionRequest {
     $host = php_uname('n');
     $callsign = $this->getRepository()->getCallsign();
     throw new DiffusionSetupException(
-      "The clone of this repository ('{$callsign}') on the local machine ".
-      "('{$host}') could not be read. Ensure that the repository is in a ".
-      "location where the web server has read permissions.");
+      pht(
+        "The clone of this repository ('%s') on the local machine ('%s') ".
+        "could not be read. Ensure that the repository is in a ".
+        "location where the web server has read permissions.",
+        $callsign,
+        $host));
   }
 
   protected function raiseCloneException() {
     $host = php_uname('n');
     $callsign = $this->getRepository()->getCallsign();
     throw new DiffusionSetupException(
-      "The working copy for this repository ('{$callsign}') hasn't been ".
-      "cloned yet on this machine ('{$host}'). Make sure you've started the ".
-      "Phabricator daemons. If this problem persists for longer than a clone ".
-      "should take, check the daemon logs (in the Daemon Console) to see if ".
-      "there were errors cloning the repository. Consult the 'Diffusion User ".
-      "Guide' in the documentation for help setting up repositories.");
+      pht(
+        "The working copy for this repository ('%s') hasn't been cloned yet ".
+        "on this machine ('%s'). Make sure you've started the Phabricator ".
+        "daemons. If this problem persists for longer than a clone should ".
+        "take, check the daemon logs (in the Daemon Console) to see if there ".
+        "were errors cloning the repository. Consult the 'Diffusion User ".
+        "Guide' in the documentation for help setting up repositories.",
+        $callsign,
+        $host));
   }
 
   private function queryStableCommit() {
diff --git a/src/applications/diffusion/request/__tests__/DiffusionURITestCase.php b/src/applications/diffusion/request/__tests__/DiffusionURITestCase.php
index a6c9eeb27d..43a2bd3404 100644
--- a/src/applications/diffusion/request/__tests__/DiffusionURITestCase.php
+++ b/src/applications/diffusion/request/__tests__/DiffusionURITestCase.php
@@ -67,7 +67,7 @@ final class DiffusionURITestCase extends PhutilTestCase {
       $this->assertEqual(
         $expect,
         $actual,
-        "Parsing '{$input}'");
+        pht("Parsing '%s'", $input));
     }
   }
 
diff --git a/src/applications/diffusion/ssh/DiffusionMercurialServeSSHWorkflow.php b/src/applications/diffusion/ssh/DiffusionMercurialServeSSHWorkflow.php
index b6c22b3a7e..51ffdeb3bd 100644
--- a/src/applications/diffusion/ssh/DiffusionMercurialServeSSHWorkflow.php
+++ b/src/applications/diffusion/ssh/DiffusionMercurialServeSSHWorkflow.php
@@ -35,11 +35,11 @@ final class DiffusionMercurialServeSSHWorkflow
     $args = $this->getArgs();
 
     if (!$args->getArg('stdio')) {
-      throw new Exception('Expected `hg ... --stdio`!');
+      throw new Exception(pht('Expected `%s`!', 'hg ... --stdio'));
     }
 
     if ($args->getArg('command') !== array('serve')) {
-      throw new Exception('Expected `hg ... serve`!');
+      throw new Exception(pht('Expected `%s`!', 'hg ... serve'));
     }
 
     if ($this->shouldProxy()) {
diff --git a/src/applications/diffusion/ssh/DiffusionMercurialWireClientSSHProtocolChannel.php b/src/applications/diffusion/ssh/DiffusionMercurialWireClientSSHProtocolChannel.php
index e82a62a251..5150ef9352 100644
--- a/src/applications/diffusion/ssh/DiffusionMercurialWireClientSSHProtocolChannel.php
+++ b/src/applications/diffusion/ssh/DiffusionMercurialWireClientSSHProtocolChannel.php
@@ -207,7 +207,7 @@ final class DiffusionMercurialWireClientSSHProtocolChannel
           break;
         }
       } else {
-        throw new Exception("Bad parser state '{$this->state}'!");
+        throw new Exception(pht("Bad parser state '%s'!", $this->state));
       }
     }
 
diff --git a/src/applications/diffusion/ssh/DiffusionSSHWorkflow.php b/src/applications/diffusion/ssh/DiffusionSSHWorkflow.php
index 5190f8d3d1..2b2c820773 100644
--- a/src/applications/diffusion/ssh/DiffusionSSHWorkflow.php
+++ b/src/applications/diffusion/ssh/DiffusionSSHWorkflow.php
@@ -154,8 +154,7 @@ abstract class DiffusionSSHWorkflow extends PhabricatorSSHWorkflow {
     if (!preg_match($regex, $path, $matches)) {
       throw new Exception(
         pht(
-          'Unrecognized repository path "%s". Expected a path like '.
-          '"%s".',
+          'Unrecognized repository path "%s". Expected a path like "%s".',
           $path,
           '/diffusion/X/'));
     }
diff --git a/src/applications/diffusion/ssh/DiffusionSubversionServeSSHWorkflow.php b/src/applications/diffusion/ssh/DiffusionSubversionServeSSHWorkflow.php
index 4c5fd6740a..4d085302c9 100644
--- a/src/applications/diffusion/ssh/DiffusionSubversionServeSSHWorkflow.php
+++ b/src/applications/diffusion/ssh/DiffusionSubversionServeSSHWorkflow.php
@@ -83,7 +83,8 @@ final class DiffusionSubversionServeSSHWorkflow
       if (!$exec_channel->isOpenForReading()) {
         throw new Exception(
           pht(
-            'svnserve subprocess exited before emitting a protocol frame.'));
+            '%s subprocess exited before emitting a protocol frame.',
+            'svnserve'));
       }
     }
 
@@ -141,7 +142,7 @@ final class DiffusionSubversionServeSSHWorkflow
 
     $args = $this->getArgs();
     if (!$args->getArg('tunnel')) {
-      throw new Exception('Expected `svnserve -t`!');
+      throw new Exception(pht('Expected `%s`!', 'svnserve -t'));
     }
 
     if ($this->shouldProxy()) {
@@ -350,8 +351,9 @@ final class DiffusionSubversionServeSSHWorkflow
     if ($proto !== 'svn+ssh') {
       throw new Exception(
         pht(
-          'Protocol for URI "%s" MUST be "svn+ssh".',
-          $uri_string));
+          'Protocol for URI "%s" MUST be "%s".',
+          $uri_string,
+          'svn+ssh'));
     }
     $path = $uri->getPath();
 
@@ -360,7 +362,8 @@ final class DiffusionSubversionServeSSHWorkflow
     if (preg_match('(/\\.\\./)', $path)) {
       throw new Exception(
         pht(
-          'String "/../" is invalid in path specification "%s".',
+          'String "%s" is invalid in path specification "%s".',
+          '/../',
           $uri_string));
     }
 
diff --git a/src/applications/diffusion/ssh/__tests__/DiffusionMercurialWireSSHTestCase.php b/src/applications/diffusion/ssh/__tests__/DiffusionMercurialWireSSHTestCase.php
index 694f4cd11d..0154805dd3 100644
--- a/src/applications/diffusion/ssh/__tests__/DiffusionMercurialWireSSHTestCase.php
+++ b/src/applications/diffusion/ssh/__tests__/DiffusionMercurialWireSSHTestCase.php
@@ -50,7 +50,7 @@ final class DiffusionMercurialWireSSHTestCase extends PhabricatorTestCase {
 
     $this->assertTrue(
       ($caught instanceof Exception),
-      "No extra messages for '{$file}'.");
+      pht("No extra messages for '%s'.", $file));
   }
 
 }
diff --git a/src/applications/diffusion/view/DiffusionEmptyResultView.php b/src/applications/diffusion/view/DiffusionEmptyResultView.php
index 798fc7cf07..74a131e9d7 100644
--- a/src/applications/diffusion/view/DiffusionEmptyResultView.php
+++ b/src/applications/diffusion/view/DiffusionEmptyResultView.php
@@ -55,7 +55,7 @@ final class DiffusionEmptyResultView extends DiffusionView {
         $title = pht('Path Was Deleted');
         $body = pht(
           'This path does not exist at %s. It was deleted in %s and last %s '.
-            'at %s.',
+          'at %s.',
           $commit,
           self::linkCommit($drequest->getRepository(), $deleted),
           $browse,
@@ -66,14 +66,15 @@ final class DiffusionEmptyResultView extends DiffusionView {
         $subdir = $drequest->getRepository()->getDetail('svn-subpath');
         $title = pht('Directory Not Tracked');
         $body =
-          pht("This repository is configured to track only one subdirectory ".
-          "of the entire repository ('%s'), ".
-          "but you aren't looking at something in that subdirectory, so no ".
-          "information is available.", $subdir);
+          pht(
+            "This repository is configured to track only one subdirectory ".
+            "of the entire repository ('%s'), but you aren't looking at ".
+            "something in that subdirectory, so no information is available.",
+            $subdir);
         $severity = PHUIInfoView::SEVERITY_WARNING;
         break;
       default:
-        throw new Exception("Unknown failure reason: $reason");
+        throw new Exception(pht('Unknown failure reason: %s', $reason));
     }
 
     $error_view = new PHUIInfoView();
diff --git a/src/applications/diffusion/view/DiffusionView.php b/src/applications/diffusion/view/DiffusionView.php
index 44613f05cc..0bc51f8347 100644
--- a/src/applications/diffusion/view/DiffusionView.php
+++ b/src/applications/diffusion/view/DiffusionView.php
@@ -13,8 +13,11 @@ abstract class DiffusionView extends AphrontView {
     return $this->diffusionRequest;
   }
 
-  final public function linkChange($change_type, $file_type, $path = null,
-                                   $commit_identifier = null) {
+  final public function linkChange(
+    $change_type,
+    $file_type,
+    $path = null,
+    $commit_identifier = null) {
 
     $text = DifferentialChangeType::getFullNameForChangeType($change_type);
     if ($change_type == DifferentialChangeType::TYPE_CHILD) {
diff --git a/src/applications/diviner/atom/DivinerAtom.php b/src/applications/diviner/atom/DivinerAtom.php
index ef1a079a41..adeac36808 100644
--- a/src/applications/diviner/atom/DivinerAtom.php
+++ b/src/applications/diviner/atom/DivinerAtom.php
@@ -396,7 +396,7 @@ final class DivinerAtom {
       case self::TYPE_METHOD:
         return pht('This method is not documented.');
       default:
-        phlog("Need translation for '{$type}'.");
+        phlog(pht("Need translation for '%s'.", $type));
         return pht('This %s is not documented.', $type);
     }
   }
@@ -427,7 +427,7 @@ final class DivinerAtom {
       case self::TYPE_METHOD:
         return pht('Method');
       default:
-        phlog("Need translation for '{$type}'.");
+        phlog(pht("Need translation for '%s'.", $type));
         return ucwords($type);
     }
   }
diff --git a/src/applications/diviner/atomizer/DivinerArticleAtomizer.php b/src/applications/diviner/atomizer/DivinerArticleAtomizer.php
index 62f568d3ef..e973a49447 100644
--- a/src/applications/diviner/atomizer/DivinerArticleAtomizer.php
+++ b/src/applications/diviner/atomizer/DivinerArticleAtomizer.php
@@ -16,7 +16,7 @@ final class DivinerArticleAtomizer extends DivinerAtomizer {
     $title = idx($meta, 'title');
     if (!strlen($title)) {
       $title = pht('Untitled Article "%s"', basename($file_name));
-      $atom->addWarning('Article has no @title!');
+      $atom->addWarning(pht('Article has no %s!', '@title'));
       $atom->setDocblockMetaValue('title', $title);
     }
 
diff --git a/src/applications/doorkeeper/worker/DoorkeeperAsanaFeedWorker.php b/src/applications/doorkeeper/worker/DoorkeeperAsanaFeedWorker.php
index 7cd7af0b3f..1d293956b3 100644
--- a/src/applications/doorkeeper/worker/DoorkeeperAsanaFeedWorker.php
+++ b/src/applications/doorkeeper/worker/DoorkeeperAsanaFeedWorker.php
@@ -65,7 +65,7 @@ final class DoorkeeperAsanaFeedWorker extends DoorkeeperFeedWorker {
     $phid_aid_map = $this->lookupAsanaUserIDs($all_phids);
     if (!$phid_aid_map) {
       throw new PhabricatorWorkerPermanentFailureException(
-        'No related users have linked Asana accounts.');
+        pht('No related users have linked Asana accounts.'));
     }
 
     $owner_asana_id = idx($phid_aid_map, $owner_phid);
@@ -86,8 +86,9 @@ final class DoorkeeperAsanaFeedWorker extends DoorkeeperFeedWorker {
 
     if (!$oauth_token) {
       throw new PhabricatorWorkerPermanentFailureException(
-        'Unable to find any Asana user with valid credentials to '.
-        'pull an OAuth token out of.');
+        pht(
+          'Unable to find any Asana user with valid credentials to '.
+          'pull an OAuth token out of.'));
     }
 
     $etype_main = PhabricatorObjectHasAsanaTaskEdgeType::EDGECONST;
@@ -124,21 +125,23 @@ final class DoorkeeperAsanaFeedWorker extends DoorkeeperFeedWorker {
       $parent_ref = head($refs);
       if (!$parent_ref) {
         throw new PhabricatorWorkerPermanentFailureException(
-          'DoorkeeperExternalObject could not be loaded.');
+          pht('%s could not be loaded.', 'DoorkeeperExternalObject'));
       }
 
       if ($parent_ref->getSyncFailed()) {
         throw new Exception(
-          'Synchronization of parent task from Asana failed!');
+          pht('Synchronization of parent task from Asana failed!'));
       } else if (!$parent_ref->getIsVisible()) {
-        $this->log("Skipping main task update, object is no longer visible.\n");
+        $this->log(
+          "%s\n",
+          pht('Skipping main task update, object is no longer visible.'));
         $extra_data['gone'] = true;
       } else {
         $edge_cursor = idx($main_edge['data'], 'cursor', 0);
 
         // TODO: This probably breaks, very rarely, on 32-bit systems.
         if ($edge_cursor <= $story->getChronologicalKey()) {
-          $this->log("Updating main task.\n");
+          $this->log("%s\n", pht('Updating main task.'));
           $task_id = $parent_ref->getObjectID();
 
           $this->makeAsanaAPICall(
@@ -148,7 +151,8 @@ final class DoorkeeperAsanaFeedWorker extends DoorkeeperFeedWorker {
             $main_data);
         } else {
           $this->log(
-            "Skipping main task update, cursor is ahead of the story.\n");
+            "%s\n",
+            pht('Skipping main task update, cursor is ahead of the story.'));
         }
       }
     } else {
@@ -156,7 +160,9 @@ final class DoorkeeperAsanaFeedWorker extends DoorkeeperFeedWorker {
       // (reviewers or auditors), and we haven't synchronized the object before,
       // don't synchronize the object.
       if (!$active_phids && !$passive_phids && !$follow_phids) {
-        $this->log("Object has no followers or active/passive users.\n");
+        $this->log(
+          "%s\n",
+          pht('Object has no followers or active/passive users.'));
         return;
       }
 
@@ -240,8 +246,10 @@ final class DoorkeeperAsanaFeedWorker extends DoorkeeperFeedWorker {
 
     if (!$parent_ref->getIsVisible()) {
       throw new PhabricatorWorkerPermanentFailureException(
-        'DoorkeeperExternalObject has no visible object on the other side; '.
-        'this likely indicates the Asana task has been deleted.');
+        pht(
+          '%s has no visible object on the other side; this '.
+          'likely indicates the Asana task has been deleted.',
+          'DoorkeeperExternalObject'));
     }
 
     // Now, handle the subtasks.
@@ -264,7 +272,7 @@ final class DoorkeeperAsanaFeedWorker extends DoorkeeperFeedWorker {
       foreach ($refs as $ref) {
         if ($ref->getSyncFailed()) {
           throw new Exception(
-            'Synchronization of child task from Asana failed!');
+            pht('Synchronization of child task from Asana failed!'));
         }
         if (!$ref->getIsVisible()) {
           $ref->getExternalObject()->delete();
@@ -283,8 +291,10 @@ final class DoorkeeperAsanaFeedWorker extends DoorkeeperFeedWorker {
       }
 
       $this->log(
-        "Removing subtask edge to %s, foreign object is not visible.\n",
-        $sub_phid);
+        "%s\n",
+        pht(
+          'Removing subtask edge to %s, foreign object is not visible.',
+          $sub_phid));
       $sub_editor->removeEdge($src_phid, $etype_sub, $sub_phid);
       unset($sub_edges[$sub_phid]);
     }
@@ -448,7 +458,7 @@ final class DoorkeeperAsanaFeedWorker extends DoorkeeperFeedWorker {
       $provider = PhabricatorAsanaAuthProvider::getAsanaProvider();
       if (!$provider) {
         throw new PhabricatorWorkerPermanentFailureException(
-          'No Asana provider configured.');
+          pht('No Asana provider configured.'));
       }
       $this->provider = $provider;
     }
@@ -500,11 +510,11 @@ final class DoorkeeperAsanaFeedWorker extends DoorkeeperFeedWorker {
   }
 
   private function getSynchronizationWarning() {
-    return
+    return pht(
       "\xE2\x9A\xA0 DO NOT EDIT THIS TASK \xE2\x9A\xA0\n".
       "\xE2\x98\xA0 Your changes will not be reflected in Phabricator.\n".
       "\xE2\x98\xA0 Your changes will be destroyed the next time state ".
-      "is synchronized.";
+      "is synchronized.");
   }
 
   private function lookupAsanaUserIDs($all_phids) {
diff --git a/src/applications/doorkeeper/worker/DoorkeeperFeedWorker.php b/src/applications/doorkeeper/worker/DoorkeeperFeedWorker.php
index a280e85fbb..d015b19791 100644
--- a/src/applications/doorkeeper/worker/DoorkeeperFeedWorker.php
+++ b/src/applications/doorkeeper/worker/DoorkeeperFeedWorker.php
@@ -158,21 +158,23 @@ abstract class DoorkeeperFeedWorker extends FeedPushWorker {
    */
   final protected function doWork() {
     if (PhabricatorEnv::getEnvConfig('phabricator.silent')) {
-      $this->log(pht('Phabricator is running in silent mode.'));
+      $this->log("%s\n", pht('Phabricator is running in silent mode.'));
       return;
     }
 
     if (!$this->isEnabled()) {
-      $this->log("Doorkeeper worker '%s' is not enabled.\n", get_class($this));
+      $this->log(
+        "%s\n",
+        pht("Doorkeeper worker '%s' is not enabled.", get_class($this)));
       return;
     }
 
     $publisher = $this->loadPublisher();
     if (!$publisher) {
-      $this->log("Story is about an unsupported object type.\n");
+      $this->log("%s\n", pht('Story is about an unsupported object type.'));
       return;
     } else {
-      $this->log("Using publisher '%s'.\n", get_class($publisher));
+      $this->log("%s\n", pht("Using publisher '%s'.", get_class($publisher)));
     }
 
     $this->publishFeedStory();
diff --git a/src/applications/doorkeeper/worker/DoorkeeperJIRAFeedWorker.php b/src/applications/doorkeeper/worker/DoorkeeperJIRAFeedWorker.php
index 3334a3cd7c..7c6f15cf04 100644
--- a/src/applications/doorkeeper/worker/DoorkeeperJIRAFeedWorker.php
+++ b/src/applications/doorkeeper/worker/DoorkeeperJIRAFeedWorker.php
@@ -34,7 +34,9 @@ final class DoorkeeperJIRAFeedWorker extends DoorkeeperFeedWorker {
       $object->getPHID(),
       PhabricatorJiraIssueHasObjectEdgeType::EDGECONST);
     if (!$jira_issue_phids) {
-      $this->log("Story is about an object with no linked JIRA issues.\n");
+      $this->log(
+        "%s\n",
+        pht('Story is about an object with no linked JIRA issues.'));
       return;
     }
 
@@ -44,13 +46,17 @@ final class DoorkeeperJIRAFeedWorker extends DoorkeeperFeedWorker {
       ->execute();
 
     if (!$xobjs) {
-      $this->log("Story object has no corresponding external JIRA objects.\n");
+      $this->log(
+        "%s\n",
+        pht('Story object has no corresponding external JIRA objects.'));
       return;
     }
 
     $try_users = $this->findUsersToPossess();
     if (!$try_users) {
-      $this->log("No users to act on linked JIRA objects.\n");
+      $this->log(
+        "%s\n",
+        pht('No users to act on linked JIRA objects.'));
       return;
     }
 
@@ -89,9 +95,11 @@ final class DoorkeeperJIRAFeedWorker extends DoorkeeperFeedWorker {
           } catch (HTTPFutureResponseStatus $ex) {
             phlog($ex);
             $this->log(
-              "Failed to update object %s using user %s.\n",
-              $xobj->getObjectID(),
-              $account->getUserPHID());
+              "%s\n",
+              pht(
+                'Failed to update object %s using user %s.',
+                $xobj->getObjectID(),
+                $account->getUserPHID()));
           }
         }
       }
@@ -113,7 +121,7 @@ final class DoorkeeperJIRAFeedWorker extends DoorkeeperFeedWorker {
       $provider = PhabricatorJIRAAuthProvider::getJIRAProvider();
       if (!$provider) {
         throw new PhabricatorWorkerPermanentFailureException(
-          'No JIRA provider configured.');
+          pht('No JIRA provider configured.'));
       }
       $this->provider = $provider;
     }
diff --git a/src/applications/drydock/blueprint/DrydockBlueprintImplementation.php b/src/applications/drydock/blueprint/DrydockBlueprintImplementation.php
index 223d974541..226815a642 100644
--- a/src/applications/drydock/blueprint/DrydockBlueprintImplementation.php
+++ b/src/applications/drydock/blueprint/DrydockBlueprintImplementation.php
@@ -36,7 +36,7 @@ abstract class DrydockBlueprintImplementation {
     $lease = idx($query, $lease_id);
 
     if (!$lease) {
-      throw new Exception("No such lease '{$lease_id}'!");
+      throw new Exception(pht("No such lease '%d'!", $lease_id));
     }
 
     return $lease;
@@ -45,7 +45,7 @@ abstract class DrydockBlueprintImplementation {
   protected function getInstance() {
     if (!$this->instance) {
       throw new Exception(
-        'Attach the blueprint instance to the implementation.');
+        pht('Attach the blueprint instance to the implementation.'));
     }
 
     return $this->instance;
@@ -116,7 +116,7 @@ abstract class DrydockBlueprintImplementation {
 
     $scope = $this->pushActiveScope($resource, $lease);
 
-    $this->log('Trying to Allocate Lease');
+    $this->log(pht('Trying to Allocate Lease'));
 
     $lease->setStatus(DrydockLeaseStatus::STATUS_ACQUIRING);
     $lease->setResourceID($resource->getID());
@@ -158,7 +158,7 @@ abstract class DrydockBlueprintImplementation {
       $this->log('Allocated Lease');
     } else {
       $resource->killTransaction();
-      $this->log('Failed to Allocate Lease');
+      $this->log(pht('Failed to Allocate Lease'));
     }
 
     if ($allocation_exception) {
@@ -221,7 +221,7 @@ abstract class DrydockBlueprintImplementation {
 
     $scope = $this->pushActiveScope($resource, $lease);
 
-    $this->log('Acquiring Lease');
+    $this->log(pht('Acquiring Lease'));
     $lease->setStatus(DrydockLeaseStatus::STATUS_ACTIVE);
     $lease->setResourceID($resource->getID());
     $lease->attachResource($resource);
@@ -237,7 +237,7 @@ abstract class DrydockBlueprintImplementation {
 
     $lease->setAttributes($ephemeral_lease->getAttributes());
     $lease->save();
-    $this->log('Acquired Lease');
+    $this->log(pht('Acquired Lease'));
   }
 
 
@@ -287,7 +287,7 @@ abstract class DrydockBlueprintImplementation {
     $lease->saveTransaction();
 
     if (!$released) {
-      throw new Exception('Unable to release lease: lease not active!');
+      throw new Exception(pht('Unable to release lease: lease not active!'));
     }
 
   }
@@ -428,9 +428,12 @@ abstract class DrydockBlueprintImplementation {
 
     if (!($resource instanceof DrydockResource)) {
       throw new Exception(
-        "Blueprint '{$blueprint}' is not properly implemented: ".
-        "executeAllocateResource() must return an object of type ".
-        "DrydockResource or throw, but returned something else.");
+        pht(
+          "Blueprint '%s' is not properly implemented: %s must return an ".
+          "object of type %s or throw, but returned something else.",
+          $blueprint,
+          'executeAllocateResource()',
+          'DrydockResource'));
     }
 
     $current_status = $resource->getStatus();
@@ -439,10 +442,14 @@ abstract class DrydockBlueprintImplementation {
       $current_name = DrydockResourceStatus::getNameForStatus($current_status);
       $req_name = DrydockResourceStatus::getNameForStatus($req_status);
       throw new Exception(
-        "Blueprint '{$blueprint}' is not properly implemented: ".
-        "executeAllocateResource() must return a DrydockResource with ".
-        "status '{$req_name}', but returned one with status ".
-        "'{$current_name}'.");
+        pht(
+          "Blueprint '%s' is not properly implemented: %s must return a %s ".
+          "with status '%s', but returned one with status '%s'.",
+          $blueprint,
+          'executeAllocateResource()',
+          'DrydockResource',
+          $req_name,
+          $current_name));
     }
   }
 
@@ -452,7 +459,7 @@ abstract class DrydockBlueprintImplementation {
 
     if (($this->activeResource !== null) ||
         ($this->activeLease !== null)) {
-      throw new Exception('There is already an active resource or lease!');
+      throw new Exception(pht('There is already an active resource or lease!'));
     }
 
     $this->activeResource = $resource;
diff --git a/src/applications/drydock/blueprint/DrydockPreallocatedHostBlueprintImplementation.php b/src/applications/drydock/blueprint/DrydockPreallocatedHostBlueprintImplementation.php
index e256ed4bb9..af6a9e5f2f 100644
--- a/src/applications/drydock/blueprint/DrydockPreallocatedHostBlueprintImplementation.php
+++ b/src/applications/drydock/blueprint/DrydockPreallocatedHostBlueprintImplementation.php
@@ -20,7 +20,8 @@ final class DrydockPreallocatedHostBlueprintImplementation
   }
 
   protected function executeAllocateResource(DrydockLease $lease) {
-    throw new Exception("Preallocated hosts can't be dynamically allocated.");
+    throw new Exception(
+      pht("Preallocated hosts can't be dynamically allocated."));
   }
 
   protected function canAllocateLease(
@@ -84,7 +85,9 @@ final class DrydockPreallocatedHostBlueprintImplementation
       // inaccurate sanity checking since we can't safely escape the path.
       if (preg_match('/^[A-Z]\\:\\\\[a-zA-Z0-9\\\\\\ ]/', $full_path) === 0) {
         throw new Exception(
-          'Unsafe path detected for Windows platform: "'.$full_path.'".');
+          pht(
+            'Unsafe path detected for Windows platform: "%s".',
+            $full_path));
       }
       $cmd->execx('mkdir %C', $full_path);
     }
@@ -120,7 +123,7 @@ final class DrydockPreallocatedHostBlueprintImplementation
           ));
     }
 
-    throw new Exception("No interface of type '{$type}'.");
+    throw new Exception(pht("No interface of type '%s'.", $type));
   }
 
 }
diff --git a/src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php b/src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php
index 3f6adb19b9..54d2b3b0f0 100644
--- a/src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php
+++ b/src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php
@@ -37,7 +37,9 @@ final class DrydockWorkingCopyBlueprintImplementation
     $repository_id = $lease->getAttribute('repositoryID');
     if (!$repository_id) {
       throw new Exception(
-        "Lease is missing required 'repositoryID' attribute.");
+        pht(
+          "Lease is missing required '%s' attribute.",
+          'repositoryID'));
     }
 
     $repository = id(new PhabricatorRepositoryQuery())
@@ -47,14 +49,16 @@ final class DrydockWorkingCopyBlueprintImplementation
 
     if (!$repository) {
       throw new Exception(
-        "Repository '{$repository_id}' does not exist!");
+        pht(
+          "Repository '%s' does not exist!",
+          $repository_id));
     }
 
     switch ($repository->getVersionControlSystem()) {
       case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
         break;
       default:
-        throw new Exception('Unsupported VCS!');
+        throw new Exception(pht('Unsupported VCS!'));
     }
 
     // TODO: Policy stuff here too.
@@ -108,7 +112,7 @@ final class DrydockWorkingCopyBlueprintImplementation
           ->getInterface($type);
     }
 
-    throw new Exception("No interface of type '{$type}'.");
+    throw new Exception(pht("No interface of type '%s'.", $type));
   }
 
 }
diff --git a/src/applications/drydock/constants/DrydockResourceStatus.php b/src/applications/drydock/constants/DrydockResourceStatus.php
index 7d11d93cba..d653138faf 100644
--- a/src/applications/drydock/constants/DrydockResourceStatus.php
+++ b/src/applications/drydock/constants/DrydockResourceStatus.php
@@ -17,7 +17,7 @@ final class DrydockResourceStatus extends DrydockConstants {
       self::STATUS_DESTROYED    => pht('Destroyed'),
     );
 
-    return idx($map, $status, 'Unknown');
+    return idx($map, $status, pht('Unknown'));
   }
 
   public static function getAllStatuses() {
diff --git a/src/applications/drydock/controller/DrydockConsoleController.php b/src/applications/drydock/controller/DrydockConsoleController.php
index 28647c67a9..923e43a44e 100644
--- a/src/applications/drydock/controller/DrydockConsoleController.php
+++ b/src/applications/drydock/controller/DrydockConsoleController.php
@@ -43,24 +43,19 @@ final class DrydockConsoleController extends DrydockController {
         ->setHeader(pht('Resources'))
         ->setHref($this->getApplicationURI('resource/'))
         ->addAttribute(
-          pht(
-            'View and manage resources Drydock has built, like hosts.')));
+          pht('View and manage resources Drydock has built, like hosts.')));
 
     $menu->addItem(
       id(new PHUIObjectItemView())
         ->setHeader(pht('Leases'))
         ->setHref($this->getApplicationURI('lease/'))
-        ->addAttribute(
-          pht(
-            'Manage leases on resources.')));
+        ->addAttribute(pht('Manage leases on resources.')));
 
     $menu->addItem(
       id(new PHUIObjectItemView())
         ->setHeader(pht('Logs'))
         ->setHref($this->getApplicationURI('log/'))
-        ->addAttribute(
-          pht(
-            'View logs.')));
+        ->addAttribute(pht('View logs.')));
 
 
     $crumbs = $this->buildApplicationCrumbs();
diff --git a/src/applications/drydock/controller/DrydockLeaseReleaseController.php b/src/applications/drydock/controller/DrydockLeaseReleaseController.php
index 580e0660e4..1779edf1b2 100644
--- a/src/applications/drydock/controller/DrydockLeaseReleaseController.php
+++ b/src/applications/drydock/controller/DrydockLeaseReleaseController.php
@@ -27,8 +27,11 @@ final class DrydockLeaseReleaseController extends DrydockLeaseController {
       $dialog = id(new AphrontDialogView())
         ->setUser($user)
         ->setTitle(pht('Lease Not Active'))
-        ->appendChild(phutil_tag('p', array(), pht(
-          'You can only release "active" leases.')))
+        ->appendChild(
+          phutil_tag(
+            'p',
+            array(),
+            pht('You can only release "active" leases.')))
         ->addCancelButton($lease_uri);
 
       return id(new AphrontDialogResponse())->setDialog($dialog);
@@ -38,10 +41,14 @@ final class DrydockLeaseReleaseController extends DrydockLeaseController {
       $dialog = id(new AphrontDialogView())
         ->setUser($user)
         ->setTitle(pht('Really release lease?'))
-        ->appendChild(phutil_tag('p', array(), pht(
-          'Releasing a lease may cause trouble for the lease holder and '.
-          'trigger cleanup of the underlying resource. It can not be '.
-          'undone. Continue?')))
+        ->appendChild(
+          phutil_tag(
+            'p',
+            array(),
+            pht(
+              'Releasing a lease may cause trouble for the lease holder and '.
+              'trigger cleanup of the underlying resource. It can not be '.
+              'undone. Continue?')))
         ->addSubmitButton(pht('Release Lease'))
         ->addCancelButton($lease_uri);
 
diff --git a/src/applications/drydock/controller/DrydockResourceViewController.php b/src/applications/drydock/controller/DrydockResourceViewController.php
index 2a534a4d96..0070b9cf56 100644
--- a/src/applications/drydock/controller/DrydockResourceViewController.php
+++ b/src/applications/drydock/controller/DrydockResourceViewController.php
@@ -20,7 +20,7 @@ final class DrydockResourceViewController extends DrydockResourceController {
       return new Aphront404Response();
     }
 
-    $title = 'Resource '.$resource->getID().' '.$resource->getName();
+    $title = pht('Resource %s %s', $resource->getID(), $resource->getName());
 
     $header = id(new PHUIHeaderView())
       ->setHeader($title);
diff --git a/src/applications/drydock/interface/command/DrydockSSHCommandInterface.php b/src/applications/drydock/interface/command/DrydockSSHCommandInterface.php
index 1ec2c124f5..e691e0ecff 100644
--- a/src/applications/drydock/interface/command/DrydockSSHCommandInterface.php
+++ b/src/applications/drydock/interface/command/DrydockSSHCommandInterface.php
@@ -17,14 +17,15 @@ final class DrydockSSHCommandInterface extends DrydockCommandInterface {
       ->executeOne();
 
     if ($credential === null) {
-      throw new Exception(pht(
-        'There is no credential with ID %d.',
-        $this->getConfig('credential')));
+      throw new Exception(
+        pht(
+          'There is no credential with ID %d.',
+          $this->getConfig('credential')));
     }
 
     if ($credential->getProvidesType() !==
       PassphraseCredentialTypeSSHPrivateKey::PROVIDES_TYPE) {
-      throw new Exception('Only private key credentials are supported.');
+      throw new Exception(pht('Only private key credentials are supported.'));
     }
 
     $this->passphraseSSHKey = PassphraseSSHKey::loadFromPHID(
diff --git a/src/applications/drydock/interface/filesystem/DrydockSFTPFilesystemInterface.php b/src/applications/drydock/interface/filesystem/DrydockSFTPFilesystemInterface.php
index 6d6265ac69..fe7d2d1cd3 100644
--- a/src/applications/drydock/interface/filesystem/DrydockSFTPFilesystemInterface.php
+++ b/src/applications/drydock/interface/filesystem/DrydockSFTPFilesystemInterface.php
@@ -17,7 +17,7 @@ final class DrydockSFTPFilesystemInterface extends DrydockFilesystemInterface {
 
     if ($credential->getProvidesType() !==
       PassphraseCredentialTypeSSHPrivateKey::PROVIDES_TYPE) {
-      throw new Exception('Only private key credentials are supported.');
+      throw new Exception(pht('Only private key credentials are supported.'));
     }
 
     $this->passphraseSSHKey = PassphraseSSHKey::loadFromPHID(
diff --git a/src/applications/drydock/management/DrydockManagementCloseWorkflow.php b/src/applications/drydock/management/DrydockManagementCloseWorkflow.php
index 550b441e85..f20b0e692b 100644
--- a/src/applications/drydock/management/DrydockManagementCloseWorkflow.php
+++ b/src/applications/drydock/management/DrydockManagementCloseWorkflow.php
@@ -6,7 +6,7 @@ final class DrydockManagementCloseWorkflow
   protected function didConstruct() {
     $this
       ->setName('close')
-      ->setSynopsis('Close a resource.')
+      ->setSynopsis(pht('Close a resource.'))
       ->setArguments(
         array(
           array(
@@ -22,7 +22,7 @@ final class DrydockManagementCloseWorkflow
     $ids = $args->getArg('ids');
     if (!$ids) {
       throw new PhutilArgumentUsageException(
-        'Specify one or more resource IDs to close.');
+        pht('Specify one or more resource IDs to close.'));
     }
 
     $viewer = $this->getViewer();
@@ -35,12 +35,12 @@ final class DrydockManagementCloseWorkflow
     foreach ($ids as $id) {
       $resource = idx($resources, $id);
       if (!$resource) {
-        $console->writeErr("Resource %d does not exist!\n", $id);
+        $console->writeErr("%s\n", pht('Resource %d does not exist!', $id));
       } else if ($resource->getStatus() != DrydockResourceStatus::STATUS_OPEN) {
-        $console->writeErr("Resource %d is not 'open'!\n", $id);
+        $console->writeErr("%s\n", pht("Resource %d is not 'open'!", $id));
       } else {
         $resource->closeResource();
-        $console->writeErr("Closed resource %d.\n", $id);
+        $console->writeErr("%s\n", pht('Closed resource %d.', $id));
       }
     }
 
diff --git a/src/applications/drydock/management/DrydockManagementCreateResourceWorkflow.php b/src/applications/drydock/management/DrydockManagementCreateResourceWorkflow.php
index 937a714ea0..8c67aaa908 100644
--- a/src/applications/drydock/management/DrydockManagementCreateResourceWorkflow.php
+++ b/src/applications/drydock/management/DrydockManagementCreateResourceWorkflow.php
@@ -6,23 +6,23 @@ final class DrydockManagementCreateResourceWorkflow
   protected function didConstruct() {
     $this
       ->setName('create-resource')
-      ->setSynopsis('Create a resource manually.')
+      ->setSynopsis(pht('Create a resource manually.'))
       ->setArguments(
         array(
           array(
             'name'      => 'name',
             'param'     => 'resource_name',
-            'help'      => 'Resource name.',
+            'help'      => pht('Resource name.'),
           ),
           array(
             'name'      => 'blueprint',
             'param'     => 'blueprint_id',
-            'help'      => 'Blueprint ID.',
+            'help'      => pht('Blueprint ID.'),
           ),
           array(
             'name'      => 'attributes',
             'param'     => 'name=value,...',
-            'help'      => 'Resource attributes.',
+            'help'      => pht('Resource attributes.'),
           ),
         ));
   }
@@ -33,13 +33,17 @@ final class DrydockManagementCreateResourceWorkflow
     $resource_name = $args->getArg('name');
     if (!$resource_name) {
       throw new PhutilArgumentUsageException(
-        'Specify a resource name with `--name`.');
+        pht(
+          'Specify a resource name with `%s`.',
+          '--name'));
     }
 
     $blueprint_id = $args->getArg('blueprint');
     if (!$blueprint_id) {
       throw new PhutilArgumentUsageException(
-        'Specify a blueprint ID with `--blueprint`.');
+        pht(
+          'Specify a blueprint ID with `%s`.',
+          '--blueprint'));
     }
 
     $attributes = $args->getArg('attributes');
@@ -57,7 +61,7 @@ final class DrydockManagementCreateResourceWorkflow
       ->executeOne();
     if (!$blueprint) {
       throw new PhutilArgumentUsageException(
-        'Specified blueprint does not exist.');
+        pht('Specified blueprint does not exist.'));
     }
 
     $resource = id(new DrydockResource())
@@ -70,7 +74,7 @@ final class DrydockManagementCreateResourceWorkflow
     }
     $resource->save();
 
-    $console->writeOut("Created Resource %s\n", $resource->getID());
+    $console->writeOut("%s\n", pht('Created Resource %s', $resource->getID()));
     return 0;
   }
 
diff --git a/src/applications/drydock/management/DrydockManagementLeaseWorkflow.php b/src/applications/drydock/management/DrydockManagementLeaseWorkflow.php
index 529376fe00..238177ae62 100644
--- a/src/applications/drydock/management/DrydockManagementLeaseWorkflow.php
+++ b/src/applications/drydock/management/DrydockManagementLeaseWorkflow.php
@@ -6,18 +6,18 @@ final class DrydockManagementLeaseWorkflow
   protected function didConstruct() {
     $this
       ->setName('lease')
-      ->setSynopsis('Lease a resource.')
+      ->setSynopsis(pht('Lease a resource.'))
       ->setArguments(
         array(
           array(
             'name'      => 'type',
             'param'     => 'resource_type',
-            'help'      => 'Resource type.',
+            'help'      => pht('Resource type.'),
           ),
           array(
             'name'      => 'attributes',
             'param'     => 'name=value,...',
-            'help'      => 'Resource specficiation.',
+            'help'      => pht('Resource specficiation.'),
           ),
         ));
   }
@@ -28,7 +28,9 @@ final class DrydockManagementLeaseWorkflow
     $resource_type = $args->getArg('type');
     if (!$resource_type) {
       throw new PhutilArgumentUsageException(
-        'Specify a resource type with `--type`.');
+        pht(
+          'Specify a resource type with `%s`.',
+          '--type'));
     }
 
     $attributes = $args->getArg('attributes');
@@ -49,7 +51,7 @@ final class DrydockManagementLeaseWorkflow
       ->queueForActivation()
       ->waitUntilActive();
 
-    $console->writeOut("Acquired Lease %s\n", $lease->getID());
+    $console->writeOut("%s\n", pht('Acquired Lease %s', $lease->getID()));
     return 0;
   }
 
diff --git a/src/applications/drydock/management/DrydockManagementReleaseWorkflow.php b/src/applications/drydock/management/DrydockManagementReleaseWorkflow.php
index b59204695c..616a5deb7b 100644
--- a/src/applications/drydock/management/DrydockManagementReleaseWorkflow.php
+++ b/src/applications/drydock/management/DrydockManagementReleaseWorkflow.php
@@ -6,7 +6,7 @@ final class DrydockManagementReleaseWorkflow
   protected function didConstruct() {
     $this
       ->setName('release')
-      ->setSynopsis('Release a lease.')
+      ->setSynopsis(pht('Release a lease.'))
       ->setArguments(
         array(
           array(
@@ -22,7 +22,7 @@ final class DrydockManagementReleaseWorkflow
     $ids = $args->getArg('ids');
     if (!$ids) {
       throw new PhutilArgumentUsageException(
-        'Specify one or more lease IDs to release.');
+        pht('Specify one or more lease IDs to release.'));
     }
 
     $viewer = $this->getViewer();
@@ -35,15 +35,15 @@ final class DrydockManagementReleaseWorkflow
     foreach ($ids as $id) {
       $lease = idx($leases, $id);
       if (!$lease) {
-        $console->writeErr("Lease %d does not exist!\n", $id);
+        $console->writeErr("%s\n", pht('Lease %d does not exist!', $id));
       } else if ($lease->getStatus() != DrydockLeaseStatus::STATUS_ACTIVE) {
-        $console->writeErr("Lease %d is not 'active'!\n", $id);
+        $console->writeErr("%s\n", pht("Lease %d is not 'active'!", $id));
       } else {
         $resource = $lease->getResource();
         $blueprint = $resource->getBlueprint();
         $blueprint->releaseLease($resource, $lease);
 
-        $console->writeErr("Released lease %d.\n", $id);
+        $console->writeErr("%s\n", pht('Released lease %d.', $id));
       }
     }
 
diff --git a/src/applications/drydock/storage/DrydockBlueprint.php b/src/applications/drydock/storage/DrydockBlueprint.php
index af258e0b1f..bad3f9a2dc 100644
--- a/src/applications/drydock/storage/DrydockBlueprint.php
+++ b/src/applications/drydock/storage/DrydockBlueprint.php
@@ -56,7 +56,9 @@ final class DrydockBlueprint extends DrydockDAO
       DrydockBlueprintImplementation::getAllBlueprintImplementations();
     if (!isset($implementations[$class])) {
       throw new Exception(
-        "Invalid class name for blueprint (got '".$class."')");
+        pht(
+          "Invalid class name for blueprint (got '%s')",
+          $class));
     }
     return id(new $class())->attachInstance($this);
   }
@@ -148,5 +150,4 @@ final class DrydockBlueprint extends DrydockDAO
   }
 
 
-
 }
diff --git a/src/applications/drydock/storage/DrydockLease.php b/src/applications/drydock/storage/DrydockLease.php
index 252c922065..39fa59330c 100644
--- a/src/applications/drydock/storage/DrydockLease.php
+++ b/src/applications/drydock/storage/DrydockLease.php
@@ -100,7 +100,7 @@ final class DrydockLease extends DrydockDAO
   public function queueForActivation() {
     if ($this->getID()) {
       throw new Exception(
-        'Only new leases may be queued for activation!');
+        pht('Only new leases may be queued for activation!'));
     }
 
     $this->setStatus(DrydockLeaseStatus::STATUS_PENDING);
@@ -143,8 +143,9 @@ final class DrydockLease extends DrydockDAO
   private function assertActive() {
     if (!$this->isActive()) {
       throw new Exception(
-        'Lease is not active! You can not interact with resources through '.
-        'an inactive lease.');
+        pht(
+          'Lease is not active! You can not interact with resources through '.
+          'an inactive lease.'));
     }
   }
 
@@ -164,16 +165,16 @@ final class DrydockLease extends DrydockDAO
             unset($unresolved[$key]);
             break;
           case DrydockLeaseStatus::STATUS_RELEASED:
-            throw new Exception('Lease has already been released!');
+            throw new Exception(pht('Lease has already been released!'));
           case DrydockLeaseStatus::STATUS_EXPIRED:
-            throw new Exception('Lease has already expired!');
+            throw new Exception(pht('Lease has already expired!'));
           case DrydockLeaseStatus::STATUS_BROKEN:
-            throw new Exception('Lease has been broken!');
+            throw new Exception(pht('Lease has been broken!'));
           case DrydockLeaseStatus::STATUS_PENDING:
           case DrydockLeaseStatus::STATUS_ACQUIRING:
             break;
           default:
-            throw new Exception('Unknown status??');
+            throw new Exception(pht('Unknown status??'));
         }
       }
 
diff --git a/src/applications/drydock/worker/DrydockAllocatorWorker.php b/src/applications/drydock/worker/DrydockAllocatorWorker.php
index 6d8e740e18..f9a647a3a8 100644
--- a/src/applications/drydock/worker/DrydockAllocatorWorker.php
+++ b/src/applications/drydock/worker/DrydockAllocatorWorker.php
@@ -39,7 +39,7 @@ final class DrydockAllocatorWorker extends PhabricatorWorker {
 
   protected function doWork() {
     $lease = $this->loadLease();
-    $this->logToDrydock('Allocating Lease');
+    $this->logToDrydock(pht('Allocating Lease'));
 
     try {
       $this->allocateLease($lease);
@@ -147,8 +147,10 @@ final class DrydockAllocatorWorker extends PhabricatorWorker {
         $lease->save();
 
         $this->logToDrydock(
-          "There are no resources of type '{$type}' available, and no ".
-          "blueprints which can allocate new ones.");
+          pht(
+            "There are no resources of type '%s' available, and no ".
+            "blueprints which can allocate new ones.",
+            $type));
 
         return;
       }
@@ -174,7 +176,7 @@ final class DrydockAllocatorWorker extends PhabricatorWorker {
         // and then switch them to "OPEN" only after the allocating lease gets
         // its grubby mitts on the resource. This might make more sense but
         // is a bit messy.
-        throw new Exception('Lost an allocation race?');
+        throw new Exception(pht('Lost an allocation race?'));
       }
     }
 
diff --git a/src/applications/fact/controller/PhabricatorFactChartController.php b/src/applications/fact/controller/PhabricatorFactChartController.php
index 9b6a46b327..92718f47f8 100644
--- a/src/applications/fact/controller/PhabricatorFactChartController.php
+++ b/src/applications/fact/controller/PhabricatorFactChartController.php
@@ -32,7 +32,7 @@ final class PhabricatorFactChartController extends PhabricatorFactController {
 
     if (!$points) {
       // NOTE: Raphael crashes Safari if you hand it series with no points.
-      throw new Exception('No data to show!');
+      throw new Exception(pht('No data to show!'));
     }
 
     // Limit amount of data passed to browser.
diff --git a/src/applications/fact/daemon/PhabricatorFactDaemon.php b/src/applications/fact/daemon/PhabricatorFactDaemon.php
index 130bdcde17..d60a77de6a 100644
--- a/src/applications/fact/daemon/PhabricatorFactDaemon.php
+++ b/src/applications/fact/daemon/PhabricatorFactDaemon.php
@@ -15,7 +15,7 @@ final class PhabricatorFactDaemon extends PhabricatorDaemon {
       }
       $this->processAggregates();
 
-      $this->log('Zzz...');
+      $this->log(pht('Zzz...'));
       $this->sleep(60 * 5);
     }
   }
@@ -35,7 +35,7 @@ final class PhabricatorFactDaemon extends PhabricatorDaemon {
   }
 
   public function processIteratorWithCursor($iterator_name, $iterator) {
-    $this->log("Processing cursor '{$iterator_name}'.");
+    $this->log(pht("Processing cursor '%s'.", $iterator_name));
 
     $cursor = id(new PhabricatorFactCursor())->loadOneWhere(
       'name = %s',
@@ -73,7 +73,7 @@ final class PhabricatorFactDaemon extends PhabricatorDaemon {
     $raw_facts = array();
     foreach ($iterator as $key => $object) {
       $phid = $object->getPHID();
-      $this->log("Processing {$phid}...");
+      $this->log(pht('Processing %s...', $phid));
       $raw_facts[$phid] = $this->computeRawFacts($object);
       if (count($raw_facts) > self::RAW_FACT_BUFFER_LIMIT) {
         $this->updateRawFacts($raw_facts);
@@ -91,7 +91,7 @@ final class PhabricatorFactDaemon extends PhabricatorDaemon {
   }
 
   public function processAggregates() {
-    $this->log('Processing aggregates.');
+    $this->log(pht('Processing aggregates.'));
 
     $facts = $this->computeAggregateFacts();
     $this->updateAggregateFacts($facts);
diff --git a/src/applications/fact/engine/PhabricatorFactCountEngine.php b/src/applications/fact/engine/PhabricatorFactCountEngine.php
index 133e499267..f24068646d 100644
--- a/src/applications/fact/engine/PhabricatorFactCountEngine.php
+++ b/src/applications/fact/engine/PhabricatorFactCountEngine.php
@@ -10,9 +10,9 @@ final class PhabricatorFactCountEngine extends PhabricatorFactEngine {
     foreach ($fact_types as $type) {
       if (!strncmp($type, '+N:', 3)) {
         if ($type == '+N:*') {
-          $name = 'Total Objects';
+          $name = pht('Total Objects');
         } else {
-          $name = 'Total Objects of type '.substr($type, 3);
+          $name = pht('Total Objects of type %s', substr($type, 3));
         }
 
         $results[] = id(new PhabricatorFactSimpleSpec($type))
@@ -22,9 +22,9 @@ final class PhabricatorFactCountEngine extends PhabricatorFactEngine {
 
       if (!strncmp($type, 'N:', 2)) {
         if ($type == 'N:*') {
-          $name = 'Objects';
+          $name = pht('Objects');
         } else {
-          $name = 'Objects of type '.substr($type, 2);
+          $name = pht('Objects of type %s', substr($type, 2));
         }
         $results[] = id(new PhabricatorFactSimpleSpec($type))
           ->setName($name)
diff --git a/src/applications/fact/engine/PhabricatorFactLastUpdatedEngine.php b/src/applications/fact/engine/PhabricatorFactLastUpdatedEngine.php
index 39e8781d51..5ea99e6232 100644
--- a/src/applications/fact/engine/PhabricatorFactLastUpdatedEngine.php
+++ b/src/applications/fact/engine/PhabricatorFactLastUpdatedEngine.php
@@ -10,7 +10,7 @@ final class PhabricatorFactLastUpdatedEngine extends PhabricatorFactEngine {
     foreach ($fact_types as $type) {
       if ($type == 'updated') {
         $results[] = id(new PhabricatorFactSimpleSpec($type))
-          ->setName('Facts Last Updated')
+          ->setName(pht('Facts Last Updated'))
           ->setUnit(PhabricatorFactSimpleSpec::UNIT_EPOCH);
       }
     }
diff --git a/src/applications/fact/extract/PhabricatorFactUpdateIterator.php b/src/applications/fact/extract/PhabricatorFactUpdateIterator.php
index 302026098a..df77f4dd33 100644
--- a/src/applications/fact/extract/PhabricatorFactUpdateIterator.php
+++ b/src/applications/fact/extract/PhabricatorFactUpdateIterator.php
@@ -2,7 +2,7 @@
 
 /**
  * Iterate over objects by update time in a stable way. This iterator only works
- * for "normal" Lisk objects: objects with an autoincrement ID and a
+ * for "normal" Lisk objects: objects with an auto-increment ID and a
  * dateModified column.
  */
 final class PhabricatorFactUpdateIterator extends PhutilBufferedIterator {
diff --git a/src/applications/fact/management/PhabricatorFactManagementAnalyzeWorkflow.php b/src/applications/fact/management/PhabricatorFactManagementAnalyzeWorkflow.php
index 461f87379f..6b316f8c75 100644
--- a/src/applications/fact/management/PhabricatorFactManagementAnalyzeWorkflow.php
+++ b/src/applications/fact/management/PhabricatorFactManagementAnalyzeWorkflow.php
@@ -13,15 +13,15 @@ final class PhabricatorFactManagementAnalyzeWorkflow
             'name'    => 'iterator',
             'param'   => 'name',
             'repeat'  => true,
-            'help'    => 'Process only iterator __name__.',
+            'help'    => pht('Process only iterator __name__.'),
           ),
           array(
             'name'    => 'all',
-            'help'    => 'Analyze from the beginning, ignoring cursors.',
+            'help'    => pht('Analyze from the beginning, ignoring cursors.'),
           ),
           array(
             'name'    => 'skip-aggregates',
-            'help'    => 'Skip analysis of aggreate facts.',
+            'help'    => pht('Skip analysis of aggregate facts.'),
           ),
         ));
   }
diff --git a/src/applications/fact/management/PhabricatorFactManagementCursorsWorkflow.php b/src/applications/fact/management/PhabricatorFactManagementCursorsWorkflow.php
index 590967bd32..74f35e3ccc 100644
--- a/src/applications/fact/management/PhabricatorFactManagementCursorsWorkflow.php
+++ b/src/applications/fact/management/PhabricatorFactManagementCursorsWorkflow.php
@@ -16,7 +16,7 @@ final class PhabricatorFactManagementCursorsWorkflow
             'name'    => 'reset',
             'param'   => 'cursor',
             'repeat'  => true,
-            'help'    => 'Reset cursor __cursor__.',
+            'help'    => pht('Reset cursor __cursor__.'),
           ),
         ));
   }
diff --git a/src/applications/fact/spec/PhabricatorFactSpec.php b/src/applications/fact/spec/PhabricatorFactSpec.php
index a0af2420cb..a9646b246a 100644
--- a/src/applications/fact/spec/PhabricatorFactSpec.php
+++ b/src/applications/fact/spec/PhabricatorFactSpec.php
@@ -33,8 +33,9 @@ abstract class PhabricatorFactSpec {
   }
 
   public function getName() {
-    $type = $this->getType();
-    return "Fact ({$type})";
+    return pht(
+      'Fact (%s)',
+      $this->getType());
   }
 
   public function formatValueForDisplay(PhabricatorUser $user, $value) {
diff --git a/src/applications/feed/PhabricatorFeedStoryPublisher.php b/src/applications/feed/PhabricatorFeedStoryPublisher.php
index 79b3b6cd55..4e91be8521 100644
--- a/src/applications/feed/PhabricatorFeedStoryPublisher.php
+++ b/src/applications/feed/PhabricatorFeedStoryPublisher.php
@@ -74,21 +74,29 @@ final class PhabricatorFeedStoryPublisher {
   public function publish() {
     $class = $this->storyType;
     if (!$class) {
-      throw new Exception('Call setStoryType() before publishing!');
+      throw new Exception(
+        pht(
+          'Call %s before publishing!',
+          'setStoryType()'));
     }
 
     if (!class_exists($class)) {
       throw new Exception(
-        "Story type must be a valid class name and must subclass ".
-        "PhabricatorFeedStory. ".
-        "'{$class}' is not a loadable class.");
+        pht(
+          "Story type must be a valid class name and must subclass %s. ".
+          "'%s' is not a loadable class.",
+          'PhabricatorFeedStory',
+          $class));
     }
 
     if (!is_subclass_of($class, 'PhabricatorFeedStory')) {
       throw new Exception(
-        "Story type must be a valid class name and must subclass ".
-        "PhabricatorFeedStory. ".
-        "'{$class}' is not a subclass of PhabricatorFeedStory.");
+        pht(
+          "Story type must be a valid class name and must subclass %s. ".
+          "'%s' is not a subclass of %s.",
+          'PhabricatorFeedStory',
+          $class,
+          'PhabricatorFeedStory'));
     }
 
     $chrono_key = $this->generateChronologicalKey();
@@ -139,7 +147,10 @@ final class PhabricatorFeedStoryPublisher {
   private function insertNotifications($chrono_key, array $subscribed_phids) {
     if (!$this->primaryObjectPHID) {
       throw new Exception(
-        'You must call setPrimaryObjectPHID() if you setSubscribedPHIDs()!');
+        pht(
+          'You must call %s if you %s!',
+          'setPrimaryObjectPHID()',
+          'setSubscribedPHIDs()'));
     }
 
     $notif = new PhabricatorFeedStoryNotification();
diff --git a/src/applications/feed/builder/PhabricatorFeedBuilder.php b/src/applications/feed/builder/PhabricatorFeedBuilder.php
index 6f78b0dcfa..63ec420771 100644
--- a/src/applications/feed/builder/PhabricatorFeedBuilder.php
+++ b/src/applications/feed/builder/PhabricatorFeedBuilder.php
@@ -34,7 +34,7 @@ final class PhabricatorFeedBuilder {
 
   public function buildView() {
     if (!$this->user) {
-      throw new Exception('Call setUser() before buildView()!');
+      throw new PhutilInvalidStateException('setUser');
     }
 
     $user = $this->user;
diff --git a/src/applications/feed/conduit/FeedPublishConduitAPIMethod.php b/src/applications/feed/conduit/FeedPublishConduitAPIMethod.php
index a082e36fea..5f83e73b3d 100644
--- a/src/applications/feed/conduit/FeedPublishConduitAPIMethod.php
+++ b/src/applications/feed/conduit/FeedPublishConduitAPIMethod.php
@@ -11,7 +11,7 @@ final class FeedPublishConduitAPIMethod extends FeedConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Publish a story to the feed.';
+    return pht('Publish a story to the feed.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/feed/conduit/FeedQueryConduitAPIMethod.php b/src/applications/feed/conduit/FeedQueryConduitAPIMethod.php
index 02efb83f73..661b70a7ab 100644
--- a/src/applications/feed/conduit/FeedQueryConduitAPIMethod.php
+++ b/src/applications/feed/conduit/FeedQueryConduitAPIMethod.php
@@ -11,7 +11,7 @@ final class FeedQueryConduitAPIMethod extends FeedConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Query the feed for stories';
+    return pht('Query the feed for stories');
   }
 
   private function getDefaultLimit() {
@@ -30,10 +30,10 @@ final class FeedQueryConduitAPIMethod extends FeedConduitAPIMethod {
 
   private function getSupportedViewTypes() {
     return array(
-      'html' => 'Full HTML presentation of story',
-      'data' => 'Dictionary with various data of the story',
-      'html-summary' => 'Story contains only the title of the story',
-      'text' => 'Simple one-line plain text representation of story',
+      'html' => pht('Full HTML presentation of story'),
+      'data' => pht('Dictionary with various data of the story'),
+      'html-summary' => pht('Story contains only the title of the story'),
+      'text' => pht('Simple one-line plain text representation of story'),
     );
   }
 
@@ -44,7 +44,9 @@ final class FeedQueryConduitAPIMethod extends FeedConduitAPIMethod {
 
     return array(
       'ERR-UNKNOWN-TYPE' =>
-        'Unsupported view type, possibles are: '.$view_types,
+        pht(
+          'Unsupported view type, possibles are: %s',
+          $view_types),
     );
   }
 
diff --git a/src/applications/feed/query/PhabricatorFeedQuery.php b/src/applications/feed/query/PhabricatorFeedQuery.php
index 4ee91859c0..b9c7d099aa 100644
--- a/src/applications/feed/query/PhabricatorFeedQuery.php
+++ b/src/applications/feed/query/PhabricatorFeedQuery.php
@@ -67,7 +67,8 @@ final class PhabricatorFeedQuery
       $keys = $this->chronologicalKeys;
       foreach ($keys as $key) {
         if (!ctype_digit($key)) {
-          throw new Exception("Key '{$key}' is not a valid chronological key!");
+          throw new Exception(
+            pht("Key '%s' is not a valid chronological key!", $key));
         }
       }
 
diff --git a/src/applications/feed/story/PhabricatorFeedStory.php b/src/applications/feed/story/PhabricatorFeedStory.php
index f94c2601e8..253757b8de 100644
--- a/src/applications/feed/story/PhabricatorFeedStory.php
+++ b/src/applications/feed/story/PhabricatorFeedStory.php
@@ -215,7 +215,7 @@ abstract class PhabricatorFeedStory
       case PhabricatorApplicationTransaction::TARGET_TEXT:
         break;
       default:
-        throw new Exception('Unknown rendering target: '.$target);
+        throw new Exception(pht('Unknown rendering target: %s', $target));
         break;
     }
   }
@@ -229,7 +229,9 @@ abstract class PhabricatorFeedStory
     $object = idx($this->objects, $phid);
     if (!$object) {
       throw new Exception(
-        "Story is asking for an object it did not request ('{$phid}')!");
+        pht(
+          "Story is asking for an object it did not request ('%s')!",
+          $phid));
     }
     return $object;
   }
@@ -237,7 +239,7 @@ abstract class PhabricatorFeedStory
   public function getPrimaryObject() {
     $phid = $this->getPrimaryObjectPHID();
     if (!$phid) {
-      throw new Exception('Story has no primary object!');
+      throw new Exception(pht('Story has no primary object!'));
     }
     return $this->getObject($phid);
   }
@@ -308,7 +310,7 @@ abstract class PhabricatorFeedStory
 
     $handle = new PhabricatorObjectHandle();
     $handle->setPHID($phid);
-    $handle->setName("Unloaded Object '{$phid}'");
+    $handle->setName(pht("Unloaded Object '%s'", $phid));
 
     return $handle;
   }
diff --git a/src/applications/feed/worker/FeedPushWorker.php b/src/applications/feed/worker/FeedPushWorker.php
index b406b76ee0..90407f6a75 100644
--- a/src/applications/feed/worker/FeedPushWorker.php
+++ b/src/applications/feed/worker/FeedPushWorker.php
@@ -13,7 +13,7 @@ abstract class FeedPushWorker extends PhabricatorWorker {
 
     if (!$story) {
       throw new PhabricatorWorkerPermanentFailureException(
-        'Feed story does not exist.');
+        pht('Feed story does not exist.'));
     }
 
     return $story;
diff --git a/src/applications/files/application/PhabricatorFilesApplication.php b/src/applications/files/application/PhabricatorFilesApplication.php
index ed4801ace6..b80a8e1ae4 100644
--- a/src/applications/files/application/PhabricatorFilesApplication.php
+++ b/src/applications/files/application/PhabricatorFilesApplication.php
@@ -59,8 +59,7 @@ final class PhabricatorFilesApplication extends PhabricatorApplication {
   protected function getCustomCapabilities() {
     return array(
       FilesDefaultViewCapability::CAPABILITY => array(
-        'caption' => pht(
-          'Default view policy for newly created files.'),
+        'caption' => pht('Default view policy for newly created files.'),
       ),
     );
   }
diff --git a/src/applications/files/conduit/FileConduitAPIMethod.php b/src/applications/files/conduit/FileConduitAPIMethod.php
index 2419303218..420ed65bfb 100644
--- a/src/applications/files/conduit/FileConduitAPIMethod.php
+++ b/src/applications/files/conduit/FileConduitAPIMethod.php
@@ -74,8 +74,7 @@ abstract class FileConduitAPIMethod extends ConduitAPIMethod {
 
     if ($chunk->getDataFilePHID()) {
       throw new Exception(
-        pht(
-          'Chunk has already been uploaded.'));
+        pht('Chunk has already been uploaded.'));
     }
 
     return $chunk;
diff --git a/src/applications/files/conduit/FileDownloadConduitAPIMethod.php b/src/applications/files/conduit/FileDownloadConduitAPIMethod.php
index 67e9d1f25c..3a3867ac9e 100644
--- a/src/applications/files/conduit/FileDownloadConduitAPIMethod.php
+++ b/src/applications/files/conduit/FileDownloadConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class FileDownloadConduitAPIMethod extends FileConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Download a file from the server.';
+    return pht('Download a file from the server.');
   }
 
   protected function defineParamTypes() {
@@ -22,7 +22,7 @@ final class FileDownloadConduitAPIMethod extends FileConduitAPIMethod {
 
   protected function defineErrorTypes() {
     return array(
-      'ERR-BAD-PHID' => 'No such file exists.',
+      'ERR-BAD-PHID' => pht('No such file exists.'),
     );
   }
 
diff --git a/src/applications/files/conduit/FileInfoConduitAPIMethod.php b/src/applications/files/conduit/FileInfoConduitAPIMethod.php
index 7b8cecbdf1..5f1bb6e936 100644
--- a/src/applications/files/conduit/FileInfoConduitAPIMethod.php
+++ b/src/applications/files/conduit/FileInfoConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class FileInfoConduitAPIMethod extends FileConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Get information about a file.';
+    return pht('Get information about a file.');
   }
 
   protected function defineParamTypes() {
@@ -23,7 +23,7 @@ final class FileInfoConduitAPIMethod extends FileConduitAPIMethod {
 
   protected function defineErrorTypes() {
     return array(
-      'ERR-NOT-FOUND'     => 'No such file exists.',
+      'ERR-NOT-FOUND' => pht('No such file exists.'),
     );
   }
 
diff --git a/src/applications/files/conduit/FileUploadConduitAPIMethod.php b/src/applications/files/conduit/FileUploadConduitAPIMethod.php
index 594b53bcce..ac93b7d39a 100644
--- a/src/applications/files/conduit/FileUploadConduitAPIMethod.php
+++ b/src/applications/files/conduit/FileUploadConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class FileUploadConduitAPIMethod extends FileConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Upload a file to the server.';
+    return pht('Upload a file to the server.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/files/conduit/FileUploadHashConduitAPIMethod.php b/src/applications/files/conduit/FileUploadHashConduitAPIMethod.php
index 2ab13dc350..135e018a2f 100644
--- a/src/applications/files/conduit/FileUploadHashConduitAPIMethod.php
+++ b/src/applications/files/conduit/FileUploadHashConduitAPIMethod.php
@@ -8,7 +8,7 @@ final class FileUploadHashConduitAPIMethod extends FileConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Upload a file to the server using content hash.';
+    return pht('Upload a file to the server using content hash.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/files/config/PhabricatorFilesConfigOptions.php b/src/applications/files/config/PhabricatorFilesConfigOptions.php
index ac62d410fe..e9d899f658 100644
--- a/src/applications/files/config/PhabricatorFilesConfigOptions.php
+++ b/src/applications/files/config/PhabricatorFilesConfigOptions.php
@@ -101,35 +101,37 @@ final class PhabricatorFilesConfigOptions
           pht('Configure which MIME types are viewable in the browser.'))
         ->setDescription(
           pht(
-            'Configure which uploaded file types may be viewed directly '.
-            'in the browser. Other file types will be downloaded instead '.
-            'of displayed. This is mainly a usability consideration, since '.
-            'browsers tend to freak out when viewing enormous binary files.'.
+            "Configure which uploaded file types may be viewed directly ".
+            "in the browser. Other file types will be downloaded instead ".
+            "of displayed. This is mainly a usability consideration, since ".
+            "browsers tend to freak out when viewing enormous binary files.".
             "\n\n".
-            'The keys in this map are vieweable MIME types; the values are '.
-            'the MIME types they are delivered as when they are viewed in '.
-            'the browser.')),
+            "The keys in this map are viewable MIME types; the values are ".
+            "the MIME types they are delivered as when they are viewed in ".
+            "the browser.")),
       $this->newOption('files.image-mime-types', 'set', $image_default)
         ->setLocked(true)
         ->setSummary(pht('Configure which MIME types are images.'))
         ->setDescription(
           pht(
-            'List of MIME types which can be used as the `src` for an '.
-            '`<img />` tag.')),
+            'List of MIME types which can be used as the `%s` for an `%s` tag.',
+            'src',
+            '<img />')),
       $this->newOption('files.audio-mime-types', 'set', $audio_default)
         ->setLocked(true)
         ->setSummary(pht('Configure which MIME types are audio.'))
         ->setDescription(
           pht(
-            'List of MIME types which can be used to render an '.
-            '`<audio />` tag.')),
+            'List of MIME types which can be used to render an `%s` tag.',
+            '<audio />')),
       $this->newOption('files.icon-mime-types', 'wild', $icon_default)
         ->setLocked(true)
         ->setSummary(pht('Configure which MIME types map to which icons.'))
         ->setDescription(
           pht(
             'Map of MIME type to icon name. MIME types which can not be '.
-            'found default to icon `doc_files`.')),
+            'found default to icon `%s`.',
+            'doc_files')),
       $this->newOption('storage.mysql-engine.max-size', 'int', 1000000)
         ->setSummary(
           pht(
@@ -171,8 +173,9 @@ final class PhabricatorFilesConfigOptions
           pht(
             'This option will use Imagemagick to rescale images, so animated '.
             'GIFs can be thumbnailed and set as profile pictures. Imagemagick '.
-            'must be installed and the "convert" binary must be available to '.
-            'the webserver for this to work.')),
+            'must be installed and the "%s" binary must be available to '.
+            'the webserver for this to work.',
+            'convert')),
 
     );
   }
diff --git a/src/applications/files/controller/PhabricatorFileDeleteController.php b/src/applications/files/controller/PhabricatorFileDeleteController.php
index 17be9f2ff2..ed245c5cba 100644
--- a/src/applications/files/controller/PhabricatorFileDeleteController.php
+++ b/src/applications/files/controller/PhabricatorFileDeleteController.php
@@ -37,11 +37,13 @@ final class PhabricatorFileDeleteController extends PhabricatorFileController {
 
     $dialog = new AphrontDialogView();
     $dialog->setUser($user);
-    $dialog->setTitle('Really delete file?');
+    $dialog->setTitle(pht('Really delete file?'));
     $dialog->appendChild(hsprintf(
-      "<p>Permanently delete '%s'? This action can not be undone.</p>",
-      $file->getName()));
-    $dialog->addSubmitButton('Delete');
+      '<p>%s</p>',
+      pht(
+        "Permanently delete '%s'? This action can not be undone.",
+        $file->getName())));
+    $dialog->addSubmitButton(pht('Delete'));
     $dialog->addCancelButton($file->getInfoURI());
 
     return id(new AphrontDialogResponse())->setDialog($dialog);
diff --git a/src/applications/files/engine/PhabricatorLocalDiskFileStorageEngine.php b/src/applications/files/engine/PhabricatorLocalDiskFileStorageEngine.php
index 617247bdac..d9f7caf123 100644
--- a/src/applications/files/engine/PhabricatorLocalDiskFileStorageEngine.php
+++ b/src/applications/files/engine/PhabricatorLocalDiskFileStorageEngine.php
@@ -102,8 +102,10 @@ final class PhabricatorLocalDiskFileStorageEngine
 
     if (!$root || $root == '/' || $root[0] != '/') {
       throw new PhabricatorFileStorageConfigurationException(
-        "Malformed local disk storage root. You must provide an absolute ".
-        "path, and can not use '/' as the root.");
+        pht(
+          "Malformed local disk storage root. You must provide an absolute ".
+          "path, and can not use '%s' as the root.",
+          '/'));
     }
 
     return rtrim($root, '/');
@@ -123,7 +125,9 @@ final class PhabricatorLocalDiskFileStorageEngine
     // we're only accessing local storage just in case.
     if (!preg_match('@^[a-f0-9]{2}/[a-f0-9]{2}/[a-f0-9]{28}\z@', $handle)) {
       throw new Exception(
-        "Local disk filesystem handle '{$handle}' is malformed!");
+        pht(
+          "Local disk filesystem handle '%s' is malformed!",
+          $handle));
     }
     $root = $this->getLocalDiskFileStorageRoot();
     return $root.'/'.$handle;
diff --git a/src/applications/files/engine/PhabricatorMySQLFileStorageEngine.php b/src/applications/files/engine/PhabricatorMySQLFileStorageEngine.php
index b4c46702eb..eb49ef78c3 100644
--- a/src/applications/files/engine/PhabricatorMySQLFileStorageEngine.php
+++ b/src/applications/files/engine/PhabricatorMySQLFileStorageEngine.php
@@ -87,7 +87,7 @@ final class PhabricatorMySQLFileStorageEngine
   private function loadFromMySQLFileStorage($handle) {
     $blob = id(new PhabricatorFileStorageBlob())->load($handle);
     if (!$blob) {
-      throw new Exception("Unable to load MySQL blob file '{$handle}'!");
+      throw new Exception(pht("Unable to load MySQL blob file '%s'!", $handle));
     }
     return $blob;
   }
diff --git a/src/applications/files/engine/PhabricatorS3FileStorageEngine.php b/src/applications/files/engine/PhabricatorS3FileStorageEngine.php
index 93ca00c138..59446c2c13 100644
--- a/src/applications/files/engine/PhabricatorS3FileStorageEngine.php
+++ b/src/applications/files/engine/PhabricatorS3FileStorageEngine.php
@@ -136,7 +136,9 @@ final class PhabricatorS3FileStorageEngine
     $bucket = PhabricatorEnv::getEnvConfig('storage.s3.bucket');
     if (!$bucket) {
       throw new PhabricatorFileStorageConfigurationException(
-        "No 'storage.s3.bucket' specified!");
+        pht(
+          "No '%s' specified!",
+          'storage.s3.bucket'));
     }
     return $bucket;
   }
@@ -157,7 +159,10 @@ final class PhabricatorS3FileStorageEngine
 
     if (!$access_key || !$secret_key) {
       throw new PhabricatorFileStorageConfigurationException(
-        "Specify 'amazon-s3.access-key' and 'amazon-s3.secret-key'!");
+        pht(
+          "Specify '%s' and '%s'!",
+          'amazon-s3.access-key',
+          'amazon-s3.secret-key'));
     }
 
     if ($endpoint !== null) {
diff --git a/src/applications/files/engine/PhabricatorTestStorageEngine.php b/src/applications/files/engine/PhabricatorTestStorageEngine.php
index 243d179045..72e68dc7c7 100644
--- a/src/applications/files/engine/PhabricatorTestStorageEngine.php
+++ b/src/applications/files/engine/PhabricatorTestStorageEngine.php
@@ -39,7 +39,7 @@ final class PhabricatorTestStorageEngine
     if (isset(self::$storage[$handle])) {
       return self::$storage[$handle];
     }
-    throw new Exception("No such file with handle '{$handle}'!");
+    throw new Exception(pht("No such file with handle '%s'!", $handle));
   }
 
   public function deleteFile($handle) {
diff --git a/src/applications/files/exception/PhabricatorFileUploadException.php b/src/applications/files/exception/PhabricatorFileUploadException.php
index 59d24ed29c..095565793f 100644
--- a/src/applications/files/exception/PhabricatorFileUploadException.php
+++ b/src/applications/files/exception/PhabricatorFileUploadException.php
@@ -4,25 +4,26 @@ final class PhabricatorFileUploadException extends Exception {
 
   public function __construct($code) {
     $map = array(
-      UPLOAD_ERR_INI_SIZE =>
-        pht("Uploaded file is too large: current limit is %s. To adjust ".
-          "this limit change 'upload_max_filesize' in php.ini.",
-          ini_get('upload_max_filesize')),
-      UPLOAD_ERR_FORM_SIZE =>
-        'File is too large.',
-      UPLOAD_ERR_PARTIAL =>
-        'File was only partially transferred, upload did not complete.',
-      UPLOAD_ERR_NO_FILE =>
-        'No file was uploaded.',
-      UPLOAD_ERR_NO_TMP_DIR =>
-        'Unable to write file: temporary directory does not exist.',
-      UPLOAD_ERR_CANT_WRITE =>
-        'Unable to write file: failed to write to temporary directory.',
-      UPLOAD_ERR_EXTENSION =>
-        'Unable to upload: a PHP extension stopped the upload.',
+      'UPLOAD_ERR_INI_SIZE' => pht(
+        "Uploaded file is too large: current limit is %s. To adjust ".
+        "this limit change '%s' in php.ini.",
+        ini_get('upload_max_filesize'),
+        'upload_max_filesize'),
+      'UPLOAD_ERR_FORM_SIZE' => pht(
+        'File is too large.'),
+      'UPLOAD_ERR_PARTIAL' => pht(
+        'File was only partially transferred, upload did not complete.'),
+      'UPLOAD_ERR_NO_FILE' => pht(
+        'No file was uploaded.'),
+      'UPLOAD_ERR_NO_TMP_DIR' => pht(
+        'Unable to write file: temporary directory does not exist.'),
+      'UPLOAD_ERR_CANT_WRITE' => pht(
+        'Unable to write file: failed to write to temporary directory.'),
+      'UPLOAD_ERR_EXTENSION' => pht(
+        'Unable to upload: a PHP extension stopped the upload.'),
     );
 
-    $message = idx($map, $code, 'Upload failed: unknown error.');
+    $message = idx($map, $code, pht('Upload failed: unknown error.'));
     parent::__construct($message, $code);
   }
 }
diff --git a/src/applications/files/mail/FileCreateMailReceiver.php b/src/applications/files/mail/FileCreateMailReceiver.php
index 9f0fcc157c..fa9c6691e7 100644
--- a/src/applications/files/mail/FileCreateMailReceiver.php
+++ b/src/applications/files/mail/FileCreateMailReceiver.php
@@ -20,7 +20,8 @@ final class FileCreateMailReceiver extends PhabricatorMailReceiver {
     if (empty($attachment_phids)) {
       throw new PhabricatorMetaMTAReceivedMailProcessingException(
         MetaMTAReceivedMailStatus::STATUS_UNHANDLED_EXCEPTION,
-        'Ignoring email to create files that did not include attachments.');
+        pht(
+          'Ignoring email to create files that did not include attachments.'));
     }
     $first_phid = head($attachment_phids);
     $mail->setRelatedPHID($first_phid);
diff --git a/src/applications/files/mail/FileMailReceiver.php b/src/applications/files/mail/FileMailReceiver.php
index 05cb788ef5..cdad22c5ce 100644
--- a/src/applications/files/mail/FileMailReceiver.php
+++ b/src/applications/files/mail/FileMailReceiver.php
@@ -3,8 +3,8 @@
 final class FileMailReceiver extends PhabricatorObjectMailReceiver {
 
   public function isEnabled() {
-    $app_class = 'PhabricatorFilesApplication';
-    return PhabricatorApplication::isClassInstalled($app_class);
+    return PhabricatorApplication::isClassInstalled(
+      'PhabricatorFilesApplication');
   }
 
   protected function getObjectPattern() {
diff --git a/src/applications/files/mail/FileReplyHandler.php b/src/applications/files/mail/FileReplyHandler.php
index b21c487e14..7cdfb886c5 100644
--- a/src/applications/files/mail/FileReplyHandler.php
+++ b/src/applications/files/mail/FileReplyHandler.php
@@ -5,7 +5,7 @@ final class FileReplyHandler
 
   public function validateMailReceiver($mail_receiver) {
     if (!($mail_receiver instanceof PhabricatorFile)) {
-      throw new Exception('Mail receiver is not a PhabricatorFile.');
+      throw new Exception(pht('Mail receiver is not a %s.', 'PhabricatorFile'));
     }
   }
 
diff --git a/src/applications/files/management/PhabricatorFilesManagementCatWorkflow.php b/src/applications/files/management/PhabricatorFilesManagementCatWorkflow.php
index 896165f585..98efd2dee9 100644
--- a/src/applications/files/management/PhabricatorFilesManagementCatWorkflow.php
+++ b/src/applications/files/management/PhabricatorFilesManagementCatWorkflow.php
@@ -6,8 +6,7 @@ final class PhabricatorFilesManagementCatWorkflow
   protected function didConstruct() {
     $this
       ->setName('cat')
-      ->setSynopsis(
-        pht('Print the contents of a file.'))
+      ->setSynopsis(pht('Print the contents of a file.'))
       ->setArguments(
         array(
           array(
@@ -33,10 +32,10 @@ final class PhabricatorFilesManagementCatWorkflow
     $names = $args->getArg('names');
     if (count($names) > 1) {
       throw new PhutilArgumentUsageException(
-        pht('Specify exactly one file to print, like "F123".'));
+        pht('Specify exactly one file to print, like "%s".', 'F123'));
     } else if (!$names) {
       throw new PhutilArgumentUsageException(
-        pht('Specify a file to print, like "F123".'));
+        pht('Specify a file to print, like "%s".', 'F123'));
     }
 
     $file = head($this->loadFilesWithNames($names));
diff --git a/src/applications/files/management/PhabricatorFilesManagementCompactWorkflow.php b/src/applications/files/management/PhabricatorFilesManagementCompactWorkflow.php
index b885f2613b..0c8e7153e5 100644
--- a/src/applications/files/management/PhabricatorFilesManagementCompactWorkflow.php
+++ b/src/applications/files/management/PhabricatorFilesManagementCompactWorkflow.php
@@ -34,8 +34,9 @@ final class PhabricatorFilesManagementCompactWorkflow
     if (!$iterator) {
       throw new PhutilArgumentUsageException(
         pht(
-          'Either specify a list of files to compact, or use `--all` '.
-          'to compact all files.'));
+          'Either specify a list of files to compact, or use `%s` '.
+          'to compact all files.',
+          '--all'));
     }
 
     $is_dry_run = $args->getArg('dry-run');
diff --git a/src/applications/files/management/PhabricatorFilesManagementEnginesWorkflow.php b/src/applications/files/management/PhabricatorFilesManagementEnginesWorkflow.php
index 579fd7e3ba..ede95a1f28 100644
--- a/src/applications/files/management/PhabricatorFilesManagementEnginesWorkflow.php
+++ b/src/applications/files/management/PhabricatorFilesManagementEnginesWorkflow.php
@@ -6,7 +6,7 @@ final class PhabricatorFilesManagementEnginesWorkflow
   protected function didConstruct() {
     $this
       ->setName('engines')
-      ->setSynopsis('List available storage engines.')
+      ->setSynopsis(pht('List available storage engines.'))
       ->setArguments(array());
   }
 
@@ -15,7 +15,7 @@ final class PhabricatorFilesManagementEnginesWorkflow
 
     $engines = PhabricatorFile::buildAllEngines();
     if (!$engines) {
-      throw new Exception('No storage engines are available.');
+      throw new Exception(pht('No storage engines are available.'));
     }
 
     foreach ($engines as $engine) {
diff --git a/src/applications/files/management/PhabricatorFilesManagementMigrateWorkflow.php b/src/applications/files/management/PhabricatorFilesManagementMigrateWorkflow.php
index 5201465be4..ce48d29bb0 100644
--- a/src/applications/files/management/PhabricatorFilesManagementMigrateWorkflow.php
+++ b/src/applications/files/management/PhabricatorFilesManagementMigrateWorkflow.php
@@ -6,21 +6,21 @@ final class PhabricatorFilesManagementMigrateWorkflow
   protected function didConstruct() {
     $this
       ->setName('migrate')
-      ->setSynopsis('Migrate files between storage engines.')
+      ->setSynopsis(pht('Migrate files between storage engines.'))
       ->setArguments(
         array(
           array(
             'name'      => 'engine',
             'param'     => 'storage_engine',
-            'help'      => 'Migrate to the named storage engine.',
+            'help'      => pht('Migrate to the named storage engine.'),
           ),
           array(
             'name'      => 'dry-run',
-            'help'      => 'Show what would be migrated.',
+            'help'      => pht('Show what would be migrated.'),
           ),
           array(
             'name'      => 'all',
-            'help'      => 'Migrate all files.',
+            'help'      => pht('Migrate all files.'),
           ),
           array(
             'name'      => 'names',
@@ -35,8 +35,11 @@ final class PhabricatorFilesManagementMigrateWorkflow
     $engine_id = $args->getArg('engine');
     if (!$engine_id) {
       throw new PhutilArgumentUsageException(
-        'Specify an engine to migrate to with `--engine`. '.
-        'Use `files engines` to get a list of engines.');
+        pht(
+          'Specify an engine to migrate to with `%s`. '.
+          'Use `%s` to get a list of engines.',
+          '--engine',
+          'files engines'));
     }
 
     $engine = PhabricatorFile::buildEngine($engine_id);
@@ -44,8 +47,10 @@ final class PhabricatorFilesManagementMigrateWorkflow
     $iterator = $this->buildIterator($args);
     if (!$iterator) {
       throw new PhutilArgumentUsageException(
-        'Either specify a list of files to migrate, or use `--all` '.
-        'to migrate all files.');
+        pht(
+          'Either specify a list of files to migrate, or use `%s` '.
+          'to migrate all files.',
+          '--all'));
     }
 
     $is_dry_run = $args->getArg('dry-run');
@@ -57,39 +62,45 @@ final class PhabricatorFilesManagementMigrateWorkflow
 
       if ($file->getStorageEngine() == $engine_id) {
         $console->writeOut(
-          "%s: Already stored on '%s'\n",
-          $fid,
-          $engine_id);
+          "%s\n",
+          pht(
+            "%s: Already stored on '%s'",
+            $fid,
+            $engine_id));
         continue;
       }
 
       if ($is_dry_run) {
         $console->writeOut(
-          "%s: Would migrate from '%s' to '%s' (dry run)\n",
-          $fid,
-          $file->getStorageEngine(),
-          $engine_id);
+          "%s\n",
+          pht(
+            "%s: Would migrate from '%s' to '%s' (dry run)",
+            $fid,
+            $file->getStorageEngine(),
+            $engine_id));
         continue;
       }
 
       $console->writeOut(
-        "%s: Migrating from '%s' to '%s'...",
-        $fid,
-        $file->getStorageEngine(),
-        $engine_id);
+        "%s\n",
+        pht(
+          "%s: Migrating from '%s' to '%s'...",
+          $fid,
+          $file->getStorageEngine(),
+          $engine_id));
 
       try {
         $file->migrateToEngine($engine);
-        $console->writeOut("done.\n");
+        $console->writeOut("%s\n", pht('Done.'));
       } catch (Exception $ex) {
-        $console->writeOut("failed!\n");
+        $console->writeOut("%s\n", pht('Failed!'));
         $console->writeErr("%s\n", (string)$ex);
         $failed[] = $file;
       }
     }
 
     if ($failed) {
-      $console->writeOut("**Failures!**\n");
+      $console->writeOut("**%s**\n", pht('Failures!'));
       $ids = array();
       foreach ($failed as $file) {
         $ids[] = 'F'.$file->getID();
@@ -98,7 +109,7 @@ final class PhabricatorFilesManagementMigrateWorkflow
 
       return 1;
     } else {
-      $console->writeOut("**Success!**\n");
+      $console->writeOut("**%s**\n", pht('Success!'));
       return 0;
     }
   }
diff --git a/src/applications/files/management/PhabricatorFilesManagementPurgeWorkflow.php b/src/applications/files/management/PhabricatorFilesManagementPurgeWorkflow.php
index 3f08c76623..bf2c04a584 100644
--- a/src/applications/files/management/PhabricatorFilesManagementPurgeWorkflow.php
+++ b/src/applications/files/management/PhabricatorFilesManagementPurgeWorkflow.php
@@ -6,16 +6,16 @@ final class PhabricatorFilesManagementPurgeWorkflow
   protected function didConstruct() {
     $this
       ->setName('purge')
-      ->setSynopsis('Delete files with missing data.')
+      ->setSynopsis(pht('Delete files with missing data.'))
       ->setArguments(
         array(
           array(
             'name'      => 'all',
-            'help'      => 'Update all files.',
+            'help'      => pht('Update all files.'),
           ),
           array(
             'name'      => 'dry-run',
-            'help'      => 'Show what would be updated.',
+            'help'      => pht('Show what would be updated.'),
           ),
           array(
             'name'      => 'names',
@@ -30,8 +30,10 @@ final class PhabricatorFilesManagementPurgeWorkflow
     $iterator = $this->buildIterator($args);
     if (!$iterator) {
       throw new PhutilArgumentUsageException(
-        'Either specify a list of files to purge, or use `--all` '.
-        'to purge all files.');
+        pht(
+          'Either specify a list of files to purge, or use `%s` '.
+          'to purge all files.',
+          '--all'));
     }
 
     $is_dry_run = $args->getArg('dry-run');
@@ -48,17 +50,17 @@ final class PhabricatorFilesManagementPurgeWorkflow
 
       if ($okay) {
         $console->writeOut(
-          "%s: File data is OK, not purging.\n",
-          $fid);
+          "%s\n",
+          pht('%s: File data is OK, not purging.', $fid));
       } else {
         if ($is_dry_run) {
           $console->writeOut(
-            "%s: Would purge (dry run).\n",
-            $fid);
+            "%s\n",
+            pht('%s: Would purge (dry run).', $fid));
         } else {
           $console->writeOut(
-            "%s: Purging.\n",
-            $fid);
+            "%s\n",
+            pht('%s: Purging.', $fid));
           $file->delete();
         }
       }
diff --git a/src/applications/files/management/PhabricatorFilesManagementRebuildWorkflow.php b/src/applications/files/management/PhabricatorFilesManagementRebuildWorkflow.php
index 95a3ea0567..f7fc890ae4 100644
--- a/src/applications/files/management/PhabricatorFilesManagementRebuildWorkflow.php
+++ b/src/applications/files/management/PhabricatorFilesManagementRebuildWorkflow.php
@@ -6,24 +6,24 @@ final class PhabricatorFilesManagementRebuildWorkflow
   protected function didConstruct() {
     $this
       ->setName('rebuild')
-      ->setSynopsis('Rebuild metadata of old files.')
+      ->setSynopsis(pht('Rebuild metadata of old files.'))
       ->setArguments(
         array(
           array(
             'name'      => 'all',
-            'help'      => 'Update all files.',
+            'help'      => pht('Update all files.'),
           ),
           array(
             'name'      => 'dry-run',
-            'help'      => 'Show what would be updated.',
+            'help'      => pht('Show what would be updated.'),
           ),
           array(
             'name'      => 'rebuild-mime',
-            'help'      => 'Rebuild MIME information.',
+            'help'      => pht('Rebuild MIME information.'),
           ),
           array(
             'name'      => 'rebuild-dimensions',
-            'help'      => 'Rebuild image dimension information.',
+            'help'      => pht('Rebuild image dimension information.'),
           ),
           array(
             'name'      => 'names',
@@ -38,8 +38,10 @@ final class PhabricatorFilesManagementRebuildWorkflow
     $iterator = $this->buildIterator($args);
     if (!$iterator) {
       throw new PhutilArgumentUsageException(
-        'Either specify a list of files to update, or use `--all` '.
-        'to update all files.');
+        pht(
+          'Either specify a list of files to update, or use `%s` '.
+          'to update all files.',
+          '--all'));
     }
 
     $update = array(
@@ -68,22 +70,28 @@ final class PhabricatorFilesManagementRebuildWorkflow
 
         if ($new_type == $file->getMimeType()) {
           $console->writeOut(
-            "%s: Mime type not changed (%s).\n",
-            $fid,
-            $new_type);
+            "%s\n",
+            pht(
+              '%s: Mime type not changed (%s).',
+              $fid,
+              $new_type));
         } else {
           if ($is_dry_run) {
             $console->writeOut(
-              "%s: Would update Mime type: '%s' -> '%s'.\n",
-              $fid,
-              $file->getMimeType(),
-              $new_type);
+              "%s\n",
+              pht(
+                "%s: Would update Mime type: '%s' -> '%s'.",
+                $fid,
+                $file->getMimeType(),
+                $new_type));
           } else {
             $console->writeOut(
-              "%s: Updating Mime type: '%s' -> '%s'.\n",
-              $fid,
-              $file->getMimeType(),
-              $new_type);
+              "%s\n",
+              pht(
+                "%s: Updating Mime type: '%s' -> '%s'.",
+                $fid,
+                $file->getMimeType(),
+                $new_type));
             $file->setMimeType($new_type);
             $file->save();
           }
@@ -93,8 +101,8 @@ final class PhabricatorFilesManagementRebuildWorkflow
       if ($update['dimensions']) {
         if (!$file->isViewableImage()) {
           $console->writeOut(
-            "%s: Not an image file.\n",
-            $fid);
+            "%s\n",
+            pht('%s: Not an image file.', $fid));
           continue;
         }
 
@@ -103,27 +111,26 @@ final class PhabricatorFilesManagementRebuildWorkflow
         $image_height = idx($metadata, PhabricatorFile::METADATA_IMAGE_HEIGHT);
         if ($image_width && $image_height) {
           $console->writeOut(
-            "%s: Image dimensions already exist.\n",
-            $fid);
+            "%s\n",
+            pht('%s: Image dimensions already exist.', $fid));
           continue;
         }
 
         if ($is_dry_run) {
           $console->writeOut(
-            "%s: Would update file dimensions (dry run)\n",
-            $fid);
+            "%s\n",
+            pht('%s: Would update file dimensions (dry run)', $fid));
           continue;
         }
 
         $console->writeOut(
-          '%s: Updating metadata... ',
-          $fid);
+          pht('%s: Updating metadata... ', $fid));
 
         try {
           $file->updateDimensions();
-          $console->writeOut("done.\n");
+          $console->writeOut("%s\n", pht('Done.'));
         } catch (Exception $ex) {
-          $console->writeOut("failed!\n");
+          $console->writeOut("%s\n", pht('Failed!'));
           $console->writeErr("%s\n", (string)$ex);
           $failed[] = $file;
         }
@@ -131,7 +138,7 @@ final class PhabricatorFilesManagementRebuildWorkflow
     }
 
     if ($failed) {
-      $console->writeOut("**Failures!**\n");
+      $console->writeOut("**%s**\n", pht('Failures!'));
       $ids = array();
       foreach ($failed as $file) {
         $ids[] = 'F'.$file->getID();
@@ -140,7 +147,7 @@ final class PhabricatorFilesManagementRebuildWorkflow
 
       return 1;
     } else {
-      $console->writeOut("**Success!**\n");
+      $console->writeOut("**%s**\n", pht('Success!'));
       return 0;
     }
 
diff --git a/src/applications/files/management/PhabricatorFilesManagementWorkflow.php b/src/applications/files/management/PhabricatorFilesManagementWorkflow.php
index d0bff01c7c..e94fa1d96a 100644
--- a/src/applications/files/management/PhabricatorFilesManagementWorkflow.php
+++ b/src/applications/files/management/PhabricatorFilesManagementWorkflow.php
@@ -9,7 +9,9 @@ abstract class PhabricatorFilesManagementWorkflow
     if ($args->getArg('all')) {
       if ($names) {
         throw new PhutilArgumentUsageException(
-          'Specify either a list of files or `--all`, but not both.');
+          pht(
+            'Specify either a list of files or `%s`, but not both.',
+            '--all'));
       }
       return new LiskMigrationIterator(new PhabricatorFile());
     }
@@ -33,7 +35,9 @@ abstract class PhabricatorFilesManagementWorkflow
     foreach ($names as $name) {
       if (empty($files[$name])) {
         throw new PhutilArgumentUsageException(
-          "No file '{$name}' exists!");
+          pht(
+            "No file '%s' exists!",
+            $name));
       }
     }
 
diff --git a/src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php b/src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php
index 5ffb70be7f..138465a633 100644
--- a/src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php
+++ b/src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php
@@ -136,9 +136,9 @@ final class PhabricatorEmbedFileRemarkupRule
         'class'       => $image_class,
         'sigil'       => 'lightboxable',
         'meta'        => array(
-          'phid' => $file->getPHID(),
-          'uri' => $file->getBestURI(),
-          'dUri' => $file->getDownloadURI(),
+          'phid'     => $file->getPHID(),
+          'uri'      => $file->getBestURI(),
+          'dUri'     => $file->getDownloadURI(),
           'viewable' => true,
         ),
       ),
diff --git a/src/applications/files/query/PhabricatorFileQuery.php b/src/applications/files/query/PhabricatorFileQuery.php
index aa4e0be16c..594dd60983 100644
--- a/src/applications/files/query/PhabricatorFileQuery.php
+++ b/src/applications/files/query/PhabricatorFileQuery.php
@@ -84,8 +84,11 @@ final class PhabricatorFileQuery
           empty($spec['originalPHID']) ||
           empty($spec['transform'])) {
         throw new Exception(
-          "Transform specification must be a dictionary with keys ".
-          "'originalPHID' and 'transform'!");
+          pht(
+            "Transform specification must be a dictionary with keys ".
+            "'%s' and '%s'!",
+            'originalPHID',
+            'transform'));
       }
     }
 
diff --git a/src/applications/files/storage/PhabricatorFile.php b/src/applications/files/storage/PhabricatorFile.php
index c236a2368e..d60107ee6d 100644
--- a/src/applications/files/storage/PhabricatorFile.php
+++ b/src/applications/files/storage/PhabricatorFile.php
@@ -142,7 +142,7 @@ final class PhabricatorFile extends PhabricatorFileDAO
 
   public static function readUploadedFileData($spec) {
     if (!$spec) {
-      throw new Exception('No file was uploaded!');
+      throw new Exception(pht('No file was uploaded!'));
     }
 
     $err = idx($spec, 'error');
@@ -153,14 +153,14 @@ final class PhabricatorFile extends PhabricatorFileDAO
     $tmp_name = idx($spec, 'tmp_name');
     $is_valid = @is_uploaded_file($tmp_name);
     if (!$is_valid) {
-      throw new Exception('File is not an uploaded file.');
+      throw new Exception(pht('File is not an uploaded file.'));
     }
 
     $file_data = Filesystem::readFile($tmp_name);
     $file_size = idx($spec, 'size');
 
     if (strlen($file_data) != $file_size) {
-      throw new Exception('File size disagrees with uploaded size.');
+      throw new Exception(pht('File size disagrees with uploaded size.'));
     }
 
     return $file_data;
@@ -347,7 +347,7 @@ final class PhabricatorFile extends PhabricatorFileDAO
 
     if (!$data_handle) {
       throw new PhutilAggregateException(
-        'All storage engines failed to write file:',
+        pht('All storage engines failed to write file:'),
         $exceptions);
     }
 
@@ -394,7 +394,7 @@ final class PhabricatorFile extends PhabricatorFileDAO
   public function migrateToEngine(PhabricatorFileStorageEngine $engine) {
     if (!$this->getID() || !$this->getStorageHandle()) {
       throw new Exception(
-        "You can not migrate a file which hasn't yet been saved.");
+        pht("You can not migrate a file which hasn't yet been saved."));
     }
 
     $data = $this->loadFileData();
@@ -435,17 +435,23 @@ final class PhabricatorFile extends PhabricatorFileDAO
     if (!$data_handle || strlen($data_handle) > 255) {
       // This indicates an improperly implemented storage engine.
       throw new PhabricatorFileStorageConfigurationException(
-        "Storage engine '{$engine_class}' executed writeFile() but did ".
-        "not return a valid handle ('{$data_handle}') to the data: it ".
-        "must be nonempty and no longer than 255 characters.");
+        pht(
+          "Storage engine '%s' executed %s but did not return a valid ".
+          "handle ('%s') to the data: it must be nonempty and no longer ".
+          "than 255 characters.",
+          $engine_class,
+          'writeFile()',
+          $data_handle));
     }
 
     $engine_identifier = $engine->getEngineIdentifier();
     if (!$engine_identifier || strlen($engine_identifier) > 32) {
       throw new PhabricatorFileStorageConfigurationException(
-        "Storage engine '{$engine_class}' returned an improper engine ".
-        "identifier '{$engine_identifier}': it must be nonempty ".
-        "and no longer than 32 characters.");
+        pht(
+          "Storage engine '%s' returned an improper engine identifier '{%s}': ".
+          "it must be nonempty and no longer than 32 characters.",
+          $engine_class,
+          $engine_identifier));
     }
 
     return array($engine_identifier, $data_handle);
@@ -525,8 +531,7 @@ final class PhabricatorFile extends PhabricatorFileDAO
 
           if (isset($redirects[$location])) {
             throw new Exception(
-              pht(
-                'Encountered loop while following redirects.'));
+              pht('Encountered loop while following redirects.'));
           }
 
           $redirects[$location] = $location;
@@ -663,7 +668,7 @@ final class PhabricatorFile extends PhabricatorFileDAO
         $data = $data;
         break;
       default:
-        throw new Exception('Unknown storage format.');
+        throw new Exception(pht('Unknown storage format.'));
     }
 
     return $data;
@@ -686,7 +691,7 @@ final class PhabricatorFile extends PhabricatorFileDAO
   public function getViewURI() {
     if (!$this->getPHID()) {
       throw new Exception(
-        'You must save a file before you can generate a view URI.');
+        pht('You must save a file before you can generate a view URI.'));
     }
 
     return $this->getCDNURI(null);
@@ -736,7 +741,7 @@ final class PhabricatorFile extends PhabricatorFileDAO
   public function getCDNURIWithToken() {
     if (!$this->getPHID()) {
       throw new Exception(
-        'You must save a file before you can generate a CDN URI.');
+        pht('You must save a file before you can generate a CDN URI.'));
     }
 
     return $this->getCDNURI($this->generateOneTimeToken());
@@ -836,7 +841,7 @@ final class PhabricatorFile extends PhabricatorFileDAO
         return function_exists('imagegif');
         break;
       default:
-        throw new Exception('Unknown type matched as image MIME type.');
+        throw new Exception(pht('Unknown type matched as image MIME type.'));
     }
   }
 
@@ -871,7 +876,9 @@ final class PhabricatorFile extends PhabricatorFileDAO
     }
 
     throw new Exception(
-      "Storage engine '{$engine_identifier}' could not be located!");
+      pht(
+        "Storage engine '%s' could not be located!",
+        $engine_identifier));
   }
 
   public static function buildAllEngines() {
@@ -915,21 +922,18 @@ final class PhabricatorFile extends PhabricatorFileDAO
 
   public function updateDimensions($save = true) {
     if (!$this->isViewableImage()) {
-      throw new Exception(
-        'This file is not a viewable image.');
+      throw new Exception(pht('This file is not a viewable image.'));
     }
 
     if (!function_exists('imagecreatefromstring')) {
-      throw new Exception(
-        'Cannot retrieve image information.');
+      throw new Exception(pht('Cannot retrieve image information.'));
     }
 
     $data = $this->loadFileData();
 
     $img = imagecreatefromstring($data);
     if ($img === false) {
-      throw new Exception(
-        'Error when decoding image.');
+      throw new Exception(pht('Error when decoding image.'));
     }
 
     $this->metadata[self::METADATA_IMAGE_WIDTH] = imagesx($img);
@@ -999,13 +1003,13 @@ final class PhabricatorFile extends PhabricatorFileDAO
 
       // This is just a sanity check to prevent loading arbitrary files.
       if (basename($name) != $name) {
-        throw new Exception("Invalid builtin name '{$name}'!");
+        throw new Exception(pht("Invalid builtin name '%s'!", $name));
       }
 
       $path = $root.$name;
 
       if (!Filesystem::pathExists($path)) {
-        throw new Exception("Builtin '{$path}' does not exist!");
+        throw new Exception(pht("Builtin '%s' does not exist!", $path));
       }
 
       $data = Filesystem::readFile($path);
diff --git a/src/applications/files/view/PhabricatorGlobalUploadTargetView.php b/src/applications/files/view/PhabricatorGlobalUploadTargetView.php
index 3624f2a73f..3e0690815c 100644
--- a/src/applications/files/view/PhabricatorGlobalUploadTargetView.php
+++ b/src/applications/files/view/PhabricatorGlobalUploadTargetView.php
@@ -57,6 +57,6 @@ final class PhabricatorGlobalUploadTargetView extends AphrontView {
         'class' => 'phabricator-global-upload-instructions',
         'style' => 'display: none;',
       ),
-      pht("\xE2\x87\xAA Drop Files to Upload"));
+      "\xE2\x87\xAA ".pht('Drop Files to Upload'));
   }
 }
diff --git a/src/applications/flag/conduit/FlagDeleteConduitAPIMethod.php b/src/applications/flag/conduit/FlagDeleteConduitAPIMethod.php
index 6634fa7769..de6d98d7f0 100644
--- a/src/applications/flag/conduit/FlagDeleteConduitAPIMethod.php
+++ b/src/applications/flag/conduit/FlagDeleteConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class FlagDeleteConduitAPIMethod extends FlagConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Clear a flag.';
+    return pht('Clear a flag.');
   }
 
   protected function defineParamTypes() {
@@ -23,9 +23,9 @@ final class FlagDeleteConduitAPIMethod extends FlagConduitAPIMethod {
 
   protected function defineErrorTypes() {
     return array(
-      'ERR_NOT_FOUND'  => 'Bad flag ID.',
-      'ERR_WRONG_USER' => 'You are not the creator of this flag.',
-      'ERR_NEED_PARAM' => 'Must pass an id or an objectPHID.',
+      'ERR_NOT_FOUND'  => pht('Bad flag ID.'),
+      'ERR_WRONG_USER' => pht('You are not the creator of this flag.'),
+      'ERR_NEED_PARAM' => pht('Must pass an id or an objectPHID.'),
     );
   }
 
diff --git a/src/applications/flag/conduit/FlagEditConduitAPIMethod.php b/src/applications/flag/conduit/FlagEditConduitAPIMethod.php
index 5a07cdeb9d..3bc0d7e29e 100644
--- a/src/applications/flag/conduit/FlagEditConduitAPIMethod.php
+++ b/src/applications/flag/conduit/FlagEditConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class FlagEditConduitAPIMethod extends FlagConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Create or modify a flag.';
+    return pht('Create or modify a flag.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/flag/conduit/FlagQueryConduitAPIMethod.php b/src/applications/flag/conduit/FlagQueryConduitAPIMethod.php
index 486a5afa9c..0658093e43 100644
--- a/src/applications/flag/conduit/FlagQueryConduitAPIMethod.php
+++ b/src/applications/flag/conduit/FlagQueryConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class FlagQueryConduitAPIMethod extends FlagConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Query flag markers.';
+    return pht('Query flag markers.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/flag/query/PhabricatorFlagQuery.php b/src/applications/flag/query/PhabricatorFlagQuery.php
index 0b1902f6f1..ff154a512b 100644
--- a/src/applications/flag/query/PhabricatorFlagQuery.php
+++ b/src/applications/flag/query/PhabricatorFlagQuery.php
@@ -115,7 +115,8 @@ final class PhabricatorFlagQuery
       case self::GROUP_NONE:
         break;
       default:
-        throw new Exception("Unknown groupBy parameter: $this->groupBy");
+        throw new Exception(
+          pht('Unknown groupBy parameter: %s', $this->groupBy));
         break;
     }
 
diff --git a/src/applications/fund/editor/FundInitiativeEditor.php b/src/applications/fund/editor/FundInitiativeEditor.php
index 679e1b5771..fc07c472ba 100644
--- a/src/applications/fund/editor/FundInitiativeEditor.php
+++ b/src/applications/fund/editor/FundInitiativeEditor.php
@@ -126,7 +126,7 @@ final class FundInitiativeEditor
           ->withPHIDs(array($xaction->getNewValue()))
           ->executeOne();
         if (!$backer) {
-          throw new Exception(pht('Unable to load FundBacker!'));
+          throw new Exception(pht('Unable to load %s!', 'FundBacker'));
         }
 
         $subx = array();
diff --git a/src/applications/fund/mail/FundInitiativeReplyHandler.php b/src/applications/fund/mail/FundInitiativeReplyHandler.php
index 4ff1816bbd..0c236c239b 100644
--- a/src/applications/fund/mail/FundInitiativeReplyHandler.php
+++ b/src/applications/fund/mail/FundInitiativeReplyHandler.php
@@ -5,7 +5,7 @@ final class FundInitiativeReplyHandler
 
   public function validateMailReceiver($mail_receiver) {
     if (!($mail_receiver instanceof FundInitiative)) {
-      throw new Exception('Mail receiver is not a FundInitiative!');
+      throw new Exception(pht('Mail receiver is not a %s!', 'FundInitiative'));
     }
   }
 
diff --git a/src/applications/fund/phortune/FundBackerProduct.php b/src/applications/fund/phortune/FundBackerProduct.php
index cc13200639..79ffc559bb 100644
--- a/src/applications/fund/phortune/FundBackerProduct.php
+++ b/src/applications/fund/phortune/FundBackerProduct.php
@@ -86,7 +86,7 @@ final class FundBackerProduct extends PhortuneProductImplementation {
       ->withPHIDs(array($purchase->getMetadataValue('backerPHID')))
       ->executeOne();
     if (!$backer) {
-      throw new Exception(pht('Unable to load FundBacker!'));
+      throw new Exception(pht('Unable to load %s!', 'FundBacker'));
     }
 
     // Load the actual backing user -- they may not be the curent viewer if this
@@ -124,7 +124,7 @@ final class FundBackerProduct extends PhortuneProductImplementation {
       ->withPHIDs(array($purchase->getMetadataValue('backerPHID')))
       ->executeOne();
     if (!$backer) {
-      throw new Exception(pht('Unable to load FundBacker!'));
+      throw new Exception(pht('Unable to load %s!', 'FundBacker'));
     }
 
     $xactions = array();
diff --git a/src/applications/fund/search/FundInitiativeIndexer.php b/src/applications/fund/search/FundInitiativeIndexer.php
index a5be183980..7816af04bd 100644
--- a/src/applications/fund/search/FundInitiativeIndexer.php
+++ b/src/applications/fund/search/FundInitiativeIndexer.php
@@ -13,7 +13,10 @@ final class FundInitiativeIndexer
       ->withPHIDs(array($phid))
       ->executeOne();
     if (!$object) {
-      throw new Exception("Unable to load object by phid '{$phid}'!");
+      throw new Exception(
+        pht(
+          "Unable to load object by PHID '%s'!",
+          $phid));
     }
     return $object;
   }
diff --git a/src/applications/fund/storage/FundInitiative.php b/src/applications/fund/storage/FundInitiative.php
index ac73401cff..6acc19f5fc 100644
--- a/src/applications/fund/storage/FundInitiative.php
+++ b/src/applications/fund/storage/FundInitiative.php
@@ -143,8 +143,7 @@ final class FundInitiative extends FundDAO
   }
 
   public function describeAutomaticCapability($capability) {
-    return pht(
-      'The owner of an initiative can always view and edit it.');
+    return pht('The owner of an initiative can always view and edit it.');
   }
 
 
diff --git a/src/applications/harbormaster/controller/HarbormasterBuildActionController.php b/src/applications/harbormaster/controller/HarbormasterBuildActionController.php
index 5b0c84e105..133ba27fa8 100644
--- a/src/applications/harbormaster/controller/HarbormasterBuildActionController.php
+++ b/src/applications/harbormaster/controller/HarbormasterBuildActionController.php
@@ -86,8 +86,7 @@ final class HarbormasterBuildActionController
               'This build is already restarting. You can not reissue a '.
               'restart command to a restarting build.');
           } else {
-            $body = pht(
-              'You can not restart this build.');
+            $body = pht('You can not restart this build.');
           }
         }
         break;
diff --git a/src/applications/harbormaster/controller/HarbormasterBuildViewController.php b/src/applications/harbormaster/controller/HarbormasterBuildViewController.php
index 9fd6b0d2ef..4af1f34276 100644
--- a/src/applications/harbormaster/controller/HarbormasterBuildViewController.php
+++ b/src/applications/harbormaster/controller/HarbormasterBuildViewController.php
@@ -183,7 +183,7 @@ final class HarbormasterBuildViewController
       }
 
       $properties = new PHUIPropertyListView();
-      $properties->addProperty('Build Target ID', $build_target->getID());
+      $properties->addProperty(pht('Build Target ID'), $build_target->getID());
       $target_box->addPropertyList($properties, pht('Metadata'));
 
       $targets[] = $target_box;
@@ -528,6 +528,4 @@ final class HarbormasterBuildViewController
     return $table;
   }
 
-
-
 }
diff --git a/src/applications/harbormaster/controller/HarbormasterPlanEditController.php b/src/applications/harbormaster/controller/HarbormasterPlanEditController.php
index c291f4e678..8679d9ce4c 100644
--- a/src/applications/harbormaster/controller/HarbormasterPlanEditController.php
+++ b/src/applications/harbormaster/controller/HarbormasterPlanEditController.php
@@ -75,7 +75,7 @@ final class HarbormasterPlanEditController extends HarbormasterPlanController {
       ->setUser($viewer)
       ->appendChild(
         id(new AphrontFormTextControl())
-          ->setLabel('Plan Name')
+          ->setLabel(pht('Plan Name'))
           ->setName('name')
           ->setError($e_name)
           ->setValue($v_name));
diff --git a/src/applications/harbormaster/controller/HarbormasterPlanViewController.php b/src/applications/harbormaster/controller/HarbormasterPlanViewController.php
index c6fd4a1155..7447f2ed7b 100644
--- a/src/applications/harbormaster/controller/HarbormasterPlanViewController.php
+++ b/src/applications/harbormaster/controller/HarbormasterPlanViewController.php
@@ -437,7 +437,7 @@ final class HarbormasterPlanViewController extends HarbormasterPlanController {
         $icon_label = pht('Missing Dependency');
         $has_conflicts = true;
         $error = pht(
-          'This dependency specifies a build step which doesn\'t exist.');
+          "This dependency specifies a build step which doesn't exist.");
       } else {
         $bound = phutil_tag(
           'strong',
diff --git a/src/applications/harbormaster/controller/HarbormasterStepDeleteController.php b/src/applications/harbormaster/controller/HarbormasterStepDeleteController.php
index 228304e738..c0df595fad 100644
--- a/src/applications/harbormaster/controller/HarbormasterStepDeleteController.php
+++ b/src/applications/harbormaster/controller/HarbormasterStepDeleteController.php
@@ -22,7 +22,7 @@ final class HarbormasterStepDeleteController extends HarbormasterController {
       ->withIDs(array($id))
       ->executeOne();
     if ($step === null) {
-      throw new Exception('Build step not found!');
+      throw new Exception(pht('Build step not found!'));
     }
 
     $plan_id = $step->getBuildPlan()->getID();
@@ -43,8 +43,8 @@ final class HarbormasterStepDeleteController extends HarbormasterController {
         'p',
         array(),
         pht(
-          'Are you sure you want to delete this '.
-          'step? This can\'t be undone!')));
+          "Are you sure you want to delete this step? ".
+          "This can't be undone!")));
     return id(new AphrontDialogResponse())->setDialog($dialog);
   }
 
diff --git a/src/applications/harbormaster/controller/HarbormasterStepEditController.php b/src/applications/harbormaster/controller/HarbormasterStepEditController.php
index ef9289a7c8..c753bd2181 100644
--- a/src/applications/harbormaster/controller/HarbormasterStepEditController.php
+++ b/src/applications/harbormaster/controller/HarbormasterStepEditController.php
@@ -213,8 +213,9 @@ final class HarbormasterStepEditController extends HarbormasterController {
 
     $rows = array();
     $rows[] = pht(
-      'The following variables can be used in most fields. To reference '.
-      'a variable, use `${name}` in a field.');
+      'The following variables can be used in most fields. '.
+      'To reference a variable, use `%s` in a field.',
+      '${name}');
     $rows[] = pht('| Variable | Description |');
     $rows[] = '|---|---|';
     foreach ($variables as $name => $description) {
diff --git a/src/applications/harbormaster/editor/HarbormasterBuildTransactionEditor.php b/src/applications/harbormaster/editor/HarbormasterBuildTransactionEditor.php
index 0d9d26c6aa..6c59622f90 100644
--- a/src/applications/harbormaster/editor/HarbormasterBuildTransactionEditor.php
+++ b/src/applications/harbormaster/editor/HarbormasterBuildTransactionEditor.php
@@ -78,7 +78,7 @@ final class HarbormasterBuildTransactionEditor
         $issuable = $build->canResumeBuild();
         break;
       default:
-        throw new Exception("Unknown command $command");
+        throw new Exception(pht('Unknown command %s', $command));
     }
 
     if (!$issuable) {
diff --git a/src/applications/harbormaster/management/HarbormasterManagementBuildWorkflow.php b/src/applications/harbormaster/management/HarbormasterManagementBuildWorkflow.php
index e7d6adb54f..86b8596fe3 100644
--- a/src/applications/harbormaster/management/HarbormasterManagementBuildWorkflow.php
+++ b/src/applications/harbormaster/management/HarbormasterManagementBuildWorkflow.php
@@ -11,9 +11,9 @@ final class HarbormasterManagementBuildWorkflow
       ->setArguments(
         array(
           array(
-            'name' => 'plan',
-            'param' => 'id',
-            'help' => pht('ID of build plan to run.'),
+            'name'        => 'plan',
+            'param'       => 'id',
+            'help'        => pht('ID of build plan to run.'),
           ),
           array(
             'name'        => 'buildable',
@@ -50,7 +50,9 @@ final class HarbormasterManagementBuildWorkflow
     $plan_id = $args->getArg('plan');
     if (!$plan_id) {
       throw new PhutilArgumentUsageException(
-        pht('Use --plan to specify a build plan to run.'));
+        pht(
+          'Use %s to specify a build plan to run.',
+          '--plan'));
     }
 
     $plan = id(new HarbormasterBuildPlanQuery())
diff --git a/src/applications/harbormaster/step/HarbormasterCommandBuildStepImplementation.php b/src/applications/harbormaster/step/HarbormasterCommandBuildStepImplementation.php
index 14fc65a76c..5dbfd80262 100644
--- a/src/applications/harbormaster/step/HarbormasterCommandBuildStepImplementation.php
+++ b/src/applications/harbormaster/step/HarbormasterCommandBuildStepImplementation.php
@@ -130,8 +130,8 @@ final class HarbormasterCommandBuildStepImplementation
         'type' => 'text',
         'required' => true,
         'caption' => pht(
-          'Under Windows, this is executed under PowerShell.'.
-          'Under UNIX, this is executed using the user\'s shell.'),
+          "Under Windows, this is executed under PowerShell. ".
+          "Under UNIX, this is executed using the user's shell."),
       ),
       'hostartifact' => array(
         'name' => pht('Host'),
diff --git a/src/applications/harbormaster/step/HarbormasterWaitForPreviousBuildStepImplementation.php b/src/applications/harbormaster/step/HarbormasterWaitForPreviousBuildStepImplementation.php
index d3e4e92525..288cb1b1fa 100644
--- a/src/applications/harbormaster/step/HarbormasterWaitForPreviousBuildStepImplementation.php
+++ b/src/applications/harbormaster/step/HarbormasterWaitForPreviousBuildStepImplementation.php
@@ -42,7 +42,7 @@ final class HarbormasterWaitForPreviousBuildStepImplementation
     $blockers = $this->getBlockers($object, $plan, $build);
     if ($blockers) {
       $log->start();
-      $log->append("Blocked by: ".implode(',', $blockers)."\n");
+      $log->append(pht("Blocked by: %s\n", implode(',', $blockers)));
       $log->finalize();
     }
 
diff --git a/src/applications/harbormaster/storage/build/HarbormasterBuild.php b/src/applications/harbormaster/storage/build/HarbormasterBuild.php
index 38216c5b9b..5ca60bb323 100644
--- a/src/applications/harbormaster/storage/build/HarbormasterBuild.php
+++ b/src/applications/harbormaster/storage/build/HarbormasterBuild.php
@@ -250,7 +250,7 @@ final class HarbormasterBuild extends HarbormasterDAO
         array($name))
       ->executeOne();
     if ($artifact === null) {
-      throw new Exception('Artifact not found!');
+      throw new Exception(pht('Artifact not found!'));
     }
     return $artifact;
   }
diff --git a/src/applications/harbormaster/storage/build/HarbormasterBuildArtifact.php b/src/applications/harbormaster/storage/build/HarbormasterBuildArtifact.php
index e5bcb7c9ba..47df26131c 100644
--- a/src/applications/harbormaster/storage/build/HarbormasterBuildArtifact.php
+++ b/src/applications/harbormaster/storage/build/HarbormasterBuildArtifact.php
@@ -96,7 +96,9 @@ final class HarbormasterBuildArtifact extends HarbormasterDAO
   public function loadDrydockLease() {
     if ($this->getArtifactType() !== self::TYPE_HOST) {
       throw new Exception(
-        '`loadDrydockLease` may only be called on host artifacts.');
+        pht(
+          '`%s` may only be called on host artifacts.',
+          __FUNCTION__));
     }
 
     $data = $this->getArtifactData();
@@ -106,12 +108,12 @@ final class HarbormasterBuildArtifact extends HarbormasterDAO
     $lease = id(new DrydockLease())->load(
       $data['drydock-lease']);
     if ($lease === null) {
-      throw new Exception('Associated Drydock lease not found!');
+      throw new Exception(pht('Associated Drydock lease not found!'));
     }
     $resource = id(new DrydockResource())->load(
       $lease->getResourceID());
     if ($resource === null) {
-      throw new Exception('Associated Drydock resource not found!');
+      throw new Exception(pht('Associated Drydock resource not found!'));
     }
     $lease->attachResource($resource);
 
@@ -121,7 +123,9 @@ final class HarbormasterBuildArtifact extends HarbormasterDAO
   public function loadPhabricatorFile() {
     if ($this->getArtifactType() !== self::TYPE_FILE) {
       throw new Exception(
-        '`loadPhabricatorFile` may only be called on file artifacts.');
+        pht(
+          '`%s` may only be called on file artifacts.',
+          __FUNCTION__));
     }
 
     $data = $this->getArtifactData();
@@ -134,7 +138,7 @@ final class HarbormasterBuildArtifact extends HarbormasterDAO
       ->withPHIDs(array($phid))
       ->executeOne();
     if ($file === null) {
-      throw new Exception('Associated file not found!');
+      throw new Exception(pht('Associated file not found!'));
     }
     return $file;
   }
@@ -178,8 +182,7 @@ final class HarbormasterBuildArtifact extends HarbormasterDAO
   }
 
   public function describeAutomaticCapability($capability) {
-    return pht(
-      'Users must be able to see a buildable to see its artifacts.');
+    return pht('Users must be able to see a buildable to see its artifacts.');
   }
 
 }
diff --git a/src/applications/harbormaster/storage/build/HarbormasterBuildLog.php b/src/applications/harbormaster/storage/build/HarbormasterBuildLog.php
index a40554cbea..d03f588719 100644
--- a/src/applications/harbormaster/storage/build/HarbormasterBuildLog.php
+++ b/src/applications/harbormaster/storage/build/HarbormasterBuildLog.php
@@ -68,7 +68,8 @@ final class HarbormasterBuildLog extends HarbormasterDAO
 
   public function start() {
     if ($this->getLive()) {
-      throw new Exception('Live logging has already started for this log.');
+      throw new Exception(
+        pht('Live logging has already started for this log.'));
     }
 
     $this->setLive(1);
@@ -79,7 +80,8 @@ final class HarbormasterBuildLog extends HarbormasterDAO
 
   public function append($content) {
     if (!$this->getLive()) {
-      throw new Exception('Start logging before appending data to the log.');
+      throw new Exception(
+        pht('Start logging before appending data to the log.'));
     }
     if (strlen($content) === 0) {
       return;
@@ -143,7 +145,7 @@ final class HarbormasterBuildLog extends HarbormasterDAO
 
   public function finalize($start = 0) {
     if (!$this->getLive()) {
-      throw new Exception('Start logging before finalizing it.');
+      throw new Exception(pht('Start logging before finalizing it.'));
     }
 
     // TODO: Encode the log contents in a gzipped format.
@@ -201,7 +203,7 @@ final class HarbormasterBuildLog extends HarbormasterDAO
 
   public function describeAutomaticCapability($capability) {
     return pht(
-      'Users must be able to see a build target to view it\'s build log.');
+      "Users must be able to see a build target to view it's build log.");
   }
 
 
diff --git a/src/applications/herald/adapter/HeraldAdapter.php b/src/applications/herald/adapter/HeraldAdapter.php
index ca52b8da15..300af2c383 100644
--- a/src/applications/herald/adapter/HeraldAdapter.php
+++ b/src/applications/herald/adapter/HeraldAdapter.php
@@ -139,8 +139,10 @@ abstract class HeraldAdapter {
 
         if (array_key_exists($key, $this->customActions)) {
           throw new Exception(
-            'More than one Herald custom action implementation '.
-            'handles the action key: \''.$key.'\'.');
+            pht(
+              "More than one Herald custom action implementation ".
+              "handles the action key: '%s'.",
+              $key));
         }
 
         $this->customActions[$key] = $action;
@@ -163,7 +165,10 @@ abstract class HeraldAdapter {
       return $this->isNewObject;
     }
 
-    throw new Exception(pht('You must setIsNewObject to a boolean first!'));
+    throw new Exception(
+      pht(
+        'You must %s to a boolean first!',
+        'setIsNewObject()'));
   }
   public function setIsNewObject($new) {
     $this->isNewObject = (bool)$new;
@@ -206,8 +211,7 @@ abstract class HeraldAdapter {
           return $this->getCustomFieldValue($field_name);
         }
 
-        throw new Exception(
-          "Unknown field '{$field_name}'!");
+        throw new Exception(pht("Unknown field '%s'!", $field_name));
     }
   }
 
@@ -536,7 +540,9 @@ abstract class HeraldAdapter {
           return $this->getCustomFieldConditions($field);
         }
         throw new Exception(
-          "This adapter does not define conditions for field '{$field}'!");
+          pht(
+            "This adapter does not define conditions for field '%s'!",
+            $field));
     }
   }
 
@@ -572,25 +578,25 @@ abstract class HeraldAdapter {
       case self::CONDITION_IS_ANY:
         if (!is_array($condition_value)) {
           throw new HeraldInvalidConditionException(
-            'Expected condition value to be an array.');
+            pht('Expected condition value to be an array.'));
         }
         $condition_value = array_fuse($condition_value);
         return isset($condition_value[$field_value]);
       case self::CONDITION_IS_NOT_ANY:
         if (!is_array($condition_value)) {
           throw new HeraldInvalidConditionException(
-            'Expected condition value to be an array.');
+            pht('Expected condition value to be an array.'));
         }
         $condition_value = array_fuse($condition_value);
         return !isset($condition_value[$field_value]);
       case self::CONDITION_INCLUDE_ALL:
         if (!is_array($field_value)) {
           throw new HeraldInvalidConditionException(
-            'Object produced non-array value!');
+            pht('Object produced non-array value!'));
         }
         if (!is_array($condition_value)) {
           throw new HeraldInvalidConditionException(
-            'Expected condition value to be an array.');
+            pht('Expected condition value to be an array.'));
         }
 
         $have = array_select_keys(array_fuse($field_value), $condition_value);
@@ -621,7 +627,7 @@ abstract class HeraldAdapter {
           $result = @preg_match($condition_value.'S', $value);
           if ($result === false) {
             throw new HeraldInvalidConditionException(
-              'Regular expression is not valid!');
+              pht('Regular expression is not valid!'));
           }
           if ($result) {
             return true;
@@ -652,13 +658,13 @@ abstract class HeraldAdapter {
           $key_matches = @preg_match($key_regexp, $key);
           if ($key_matches === false) {
             throw new HeraldInvalidConditionException(
-              'First regular expression is invalid!');
+              pht('First regular expression is invalid!'));
           }
           if ($key_matches) {
             $value_matches = @preg_match($value_regexp, $value);
             if ($value_matches === false) {
               throw new HeraldInvalidConditionException(
-                'Second regular expression is invalid!');
+                pht('Second regular expression is invalid!'));
             }
             if ($value_matches) {
               return true;
@@ -671,7 +677,7 @@ abstract class HeraldAdapter {
         $rule = $engine->getRule($condition_value);
         if (!$rule) {
           throw new HeraldInvalidConditionException(
-            'Condition references a rule which does not exist!');
+            pht('Condition references a rule which does not exist!'));
         }
 
         $is_not = ($condition_type == self::CONDITION_NOT_RULE);
@@ -686,7 +692,7 @@ abstract class HeraldAdapter {
         return (($condition_value & $field_value) !== (int)$condition_value);
       default:
         throw new HeraldInvalidConditionException(
-          "Unknown condition '{$condition_type}'.");
+          pht("Unknown condition '%s'.", $condition_type));
     }
   }
 
@@ -846,7 +852,7 @@ abstract class HeraldAdapter {
         );
         break;
       default:
-        throw new Exception("Unknown rule type '{$rule_type}'!");
+        throw new Exception(pht("Unknown rule type '%s'!", $rule_type));
     }
 
     $custom_actions = $this->getCustomActionsForRuleType($rule_type);
@@ -984,7 +990,7 @@ abstract class HeraldAdapter {
       case self::CONDITION_NOT_RULE:
         return self::VALUE_RULE;
       default:
-        throw new Exception("Unknown condition '{$condition}'.");
+        throw new Exception(pht("Unknown condition '%s'.", $condition));
     }
   }
 
@@ -1041,7 +1047,7 @@ abstract class HeraldAdapter {
       return $custom_action->getActionType();
     }
 
-    throw new Exception("Unknown or invalid action '".$action."'.");
+    throw new Exception(pht("Unknown or invalid action '%s'.", $action));
   }
 
 
diff --git a/src/applications/herald/adapter/HeraldCommitAdapter.php b/src/applications/herald/adapter/HeraldCommitAdapter.php
index eeb43c7a95..e26da09ab4 100644
--- a/src/applications/herald/adapter/HeraldCommitAdapter.php
+++ b/src/applications/herald/adapter/HeraldCommitAdapter.php
@@ -387,7 +387,7 @@ final class HeraldCommitAdapter extends HeraldAdapter {
             $lines[] = $hunk->makeChanges();
             break;
           default:
-            throw new Exception("Unknown content selection '{$type}'!");
+            throw new Exception(pht("Unknown content selection '%s'!", $type));
         }
       }
       $result[$change->getFilename()] = implode("\n", $lines);
diff --git a/src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php b/src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php
index 3168b29f66..ff14686636 100644
--- a/src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php
+++ b/src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php
@@ -305,7 +305,8 @@ final class HeraldDifferentialRevisionAdapter
       $effect->setAction(self::ACTION_ADD_CC);
       $effect->setTarget(array_keys($this->explicitCCs));
       $effect->setReason(
-        pht('CCs provided explicitly by revision author or carried over '.
+        pht(
+          'CCs provided explicitly by revision author or carried over '.
         'from a previous version of the revision.'));
       $result[] = new HeraldApplyTranscript(
         $effect,
@@ -346,8 +347,9 @@ final class HeraldDifferentialRevisionAdapter
               $result[] = new HeraldApplyTranscript(
                 $effect,
                 true,
-                pht('Added these addresses to CC list. '.
-                'Others could not be added.'));
+                pht(
+                  'Added these addresses to CC list. '.
+                  'Others could not be added.'));
             }
             $result[] = new HeraldApplyTranscript(
               $failed,
diff --git a/src/applications/herald/controller/HeraldRuleController.php b/src/applications/herald/controller/HeraldRuleController.php
index c290407097..f52a849d1e 100644
--- a/src/applications/herald/controller/HeraldRuleController.php
+++ b/src/applications/herald/controller/HeraldRuleController.php
@@ -270,7 +270,7 @@ final class HeraldRuleController extends HeraldController {
     if (!is_array($data) ||
         !$data['conditions'] ||
         !$data['actions']) {
-      throw new Exception('Failed to decode rule data.');
+      throw new Exception(pht('Failed to decode rule data.'));
     }
 
     $conditions = array();
diff --git a/src/applications/herald/controller/HeraldTestConsoleController.php b/src/applications/herald/controller/HeraldTestConsoleController.php
index 0af51cf672..7cd610f35a 100644
--- a/src/applications/herald/controller/HeraldTestConsoleController.php
+++ b/src/applications/herald/controller/HeraldTestConsoleController.php
@@ -51,7 +51,7 @@ final class HeraldTestConsoleController extends HeraldController {
             $adapter = id(new PhrictionDocumentHeraldAdapter())
               ->setDocument($object);
           } else {
-            throw new Exception('Can not build adapter for object!');
+            throw new Exception(pht('Can not build adapter for object!'));
           }
 
           $adapter->setIsNewObject(false);
diff --git a/src/applications/herald/controller/HeraldTranscriptController.php b/src/applications/herald/controller/HeraldTranscriptController.php
index d1094437dd..f20d620cca 100644
--- a/src/applications/herald/controller/HeraldTranscriptController.php
+++ b/src/applications/herald/controller/HeraldTranscriptController.php
@@ -78,8 +78,10 @@ final class HeraldTranscriptController extends HeraldController {
         $notice = new PHUIInfoView();
         $notice->setSeverity(PHUIInfoView::SEVERITY_NOTICE);
         $notice->setTitle(pht('Dry Run'));
-        $notice->appendChild(pht('This was a dry run to test Herald '.
-          'rules, no actions were executed.'));
+        $notice->appendChild(
+          pht(
+            'This was a dry run to test Herald rules, '.
+            'no actions were executed.'));
         $nav->appendChild($notice);
       }
 
@@ -133,7 +135,7 @@ final class HeraldTranscriptController extends HeraldController {
           // grabbed handles for everything, but be super liberal in what
           // we accept here since we expect all sorts of weird issues as we
           // version the system.
-          $value[$key] = 'Unknown Object #'.$phid;
+          $value[$key] = pht('Unknown Object #%s', $phid);
         }
       }
       sort($value);
@@ -210,7 +212,8 @@ final class HeraldTranscriptController extends HeraldController {
           // TODO: Also total hacks.
           if (is_array($value)) {
             foreach ($value as $phid) {
-              if ($phid) { // TODO: Probably need to make sure this
+              if ($phid) {
+                // TODO: Probably need to make sure this
                 // "looks like" a PHID or decrease the level of hacks here;
                 // this used to be an is_numeric() check in Facebook land.
                 $phids[] = $phid;
diff --git a/src/applications/herald/engine/HeraldEngine.php b/src/applications/herald/engine/HeraldEngine.php
index 9774cb866a..5f1189fff6 100644
--- a/src/applications/herald/engine/HeraldEngine.php
+++ b/src/applications/herald/engine/HeraldEngine.php
@@ -81,8 +81,9 @@ final class HeraldEngine {
             ->setRuleName($rule->getName())
             ->setRuleOwner($rule->getAuthorPHID())
             ->setReason(
-              'This rule is only supposed to be repeated a single time, '.
-              'and it has already been applied.');
+              pht(
+                'This rule is only supposed to be repeated a single time, '.
+                'and it has already been applied.'));
           $this->transcript->addRuleTranscript($xscript);
           $rule_matches = false;
         } else {
@@ -99,9 +100,11 @@ final class HeraldEngine {
           $xscript->setRuleID($rule_id);
           $xscript->setResult(false);
           $xscript->setReason(
-            "Rules {$names} are recursively dependent upon one another! ".
-            "Don't do this! You have formed an unresolvable cycle in the ".
-            "dependency graph!");
+            pht(
+              "Rules %s are recursively dependent upon one another! ".
+              "Don't do this! You have formed an unresolvable cycle in the ".
+              "dependency graph!",
+              $names));
           $xscript->setRuleName($rules[$rule_id]->getName());
           $xscript->setRuleOwner($rules[$rule_id]->getAuthorPHID());
           $this->transcript->addRuleTranscript($xscript);
@@ -272,13 +275,13 @@ final class HeraldEngine {
         $match = $this->doesConditionMatch($rule, $condition, $object);
 
         if (!$all && $match) {
-          $reason = 'Any condition matched.';
+          $reason = pht('Any condition matched.');
           $result = true;
           break;
         }
 
         if ($all && !$match) {
-          $reason = 'Not all conditions matched.';
+          $reason = pht('Not all conditions matched.');
           $result = false;
           break;
         }
@@ -286,10 +289,10 @@ final class HeraldEngine {
 
       if ($result === null) {
         if ($all) {
-          $reason = 'All conditions matched.';
+          $reason = pht('All conditions matched.');
           $result = true;
         } else {
-          $reason = 'No conditions matched.';
+          $reason = pht('No conditions matched.');
           $result = false;
         }
       }
diff --git a/src/applications/herald/query/HeraldTranscriptSearchEngine.php b/src/applications/herald/query/HeraldTranscriptSearchEngine.php
index f6944e1215..1fd01c3e0d 100644
--- a/src/applications/herald/query/HeraldTranscriptSearchEngine.php
+++ b/src/applications/herald/query/HeraldTranscriptSearchEngine.php
@@ -125,7 +125,7 @@ final class HeraldTranscriptSearchEngine
       }
       $item->addAttribute($handles[$xscript->getObjectPHID()]->renderLink());
       $item->addAttribute(
-        number_format((int)(1000 * $xscript->getDuration())).' ms');
+        pht('%d ms', number_format((int)(1000 * $xscript->getDuration()))));
       $item->addIcon(
         'none',
         phabricator_datetime($xscript->getTime(), $viewer));
diff --git a/src/applications/herald/storage/HeraldRule.php b/src/applications/herald/storage/HeraldRule.php
index 2d19bc5356..0600d2570f 100644
--- a/src/applications/herald/storage/HeraldRule.php
+++ b/src/applications/herald/storage/HeraldRule.php
@@ -133,7 +133,7 @@ final class HeraldRule extends HeraldDAO
     assert_instances_of($children, 'HeraldDAO');
 
     if (!$this->getID()) {
-      throw new Exception('Save rule before saving children.');
+      throw new PhutilInvalidStateException('save');
     }
 
     foreach ($children as $child) {
diff --git a/src/applications/home/controller/PhabricatorHomeMainController.php b/src/applications/home/controller/PhabricatorHomeMainController.php
index 2b30770253..3069ccee7d 100644
--- a/src/applications/home/controller/PhabricatorHomeMainController.php
+++ b/src/applications/home/controller/PhabricatorHomeMainController.php
@@ -143,8 +143,8 @@ final class PhabricatorHomeMainController extends PhabricatorHomeController {
 
     if (!$tasks) {
       return $this->renderMiniPanel(
-        'No "Unbreak Now!" Tasks',
-        'Nothing appears to be critically broken right now.');
+        pht('No "Unbreak Now!" Tasks'),
+        pht('Nothing appears to be critically broken right now.'));
     }
 
     $href = urisprintf(
@@ -190,10 +190,8 @@ final class PhabricatorHomeMainController extends PhabricatorHomeController {
 
     if (!$tasks) {
       return $this->renderMiniPanel(
-        'No "Needs Triage" Tasks',
-        hsprintf(
-          'No tasks in <a href="/project/">projects you are a member of</a> '.
-          'need triage.'));
+        pht('No "Needs Triage" Tasks'),
+        pht('No tasks in projects you are a member of need triage.'));
     }
 
     $title = pht('Needs Triage');
@@ -228,8 +226,8 @@ final class PhabricatorHomeMainController extends PhabricatorHomeController {
 
     if (!$blocking && !$active) {
       return $this->renderMiniPanel(
-        'No Waiting Revisions',
-        'No revisions are waiting on you.');
+        pht('No Waiting Revisions'),
+        pht('No revisions are waiting on you.'));
     }
 
     $title = pht('Revisions Waiting on You');
@@ -283,8 +281,8 @@ final class PhabricatorHomeMainController extends PhabricatorHomeController {
 
     if (!$tasks) {
       return $this->renderMiniPanel(
-        'No Assigned Tasks',
-        'You have no assigned tasks.');
+        pht('No Assigned Tasks'),
+        pht('You have no assigned tasks.'));
     }
 
     $title = pht('Assigned Tasks');
@@ -360,8 +358,8 @@ final class PhabricatorHomeMainController extends PhabricatorHomeController {
 
     if (!$commits) {
       return $this->renderMinipanel(
-        'No Audits',
-        'No commits are waiting for you to audit them.');
+        pht('No Audits'),
+        pht('No commits are waiting for you to audit them.'));
     }
 
     $view = id(new PhabricatorAuditListView())
@@ -399,8 +397,8 @@ final class PhabricatorHomeMainController extends PhabricatorHomeController {
 
     if (!$commits) {
       return $this->renderMinipanel(
-        'No Problem Commits',
-        'No one has raised concerns with your commits.');
+        pht('No Problem Commits'),
+        pht('No one has raised concerns with your commits.'));
     }
 
     $view = id(new PhabricatorAuditListView())
diff --git a/src/applications/legalpad/controller/LegalpadDocumentEditController.php b/src/applications/legalpad/controller/LegalpadDocumentEditController.php
index c4bff97f6f..908bf8dd51 100644
--- a/src/applications/legalpad/controller/LegalpadDocumentEditController.php
+++ b/src/applications/legalpad/controller/LegalpadDocumentEditController.php
@@ -167,8 +167,7 @@ final class LegalpadDocumentEditController extends LegalpadController {
           ->addCheckbox(
             'requireSignature',
             'requireSignature',
-            pht(
-              'Should signing this document be required to use Phabricator?'),
+            pht('Should signing this document be required to use Phabricator?'),
             $v_require_signature)
           ->setCaption($caption));
     }
diff --git a/src/applications/legalpad/controller/LegalpadDocumentSignController.php b/src/applications/legalpad/controller/LegalpadDocumentSignController.php
index 4cd2f59b4c..3e65d1de1b 100644
--- a/src/applications/legalpad/controller/LegalpadDocumentSignController.php
+++ b/src/applications/legalpad/controller/LegalpadDocumentSignController.php
@@ -653,25 +653,21 @@ final class LegalpadDocumentSignController extends LegalpadController {
 
     $name = idx($signature_data, 'name');
 
-    $body = <<<EOBODY
-{$name}:
-
-This email address was used to sign a Legalpad document in Phabricator:
-
-  {$doc_name}
-
-Please verify you own this email address and accept the agreement by clicking
-this link:
-
-  {$link}
-
-Your signature is not valid until you complete this verification step.
-
-You can review the document here:
-
-  {$doc_link}
-
-EOBODY;
+    $body = pht(
+      "%s:\n\n".
+      "This email address was used to sign a Legalpad document ".
+      "in Phabricator:\n\n".
+      "  %s\n\n".
+      "Please verify you own this email address and accept the ".
+      "agreement by clicking this link:\n\n".
+      "  %s\n\n".
+      "Your signature is not valid until you complete this ".
+      "verification step.\n\nYou can review the document here:\n\n".
+      "  %s\n",
+      $name,
+      $doc_name,
+      $link,
+      $doc_link);
 
     id(new PhabricatorMetaMTAMail())
       ->addRawTos(array($email->getAddress()))
@@ -684,9 +680,10 @@ EOBODY;
 
   private function signInResponse() {
     return id(new Aphront403Response())
-      ->setForbiddenText(pht(
-        'The email address specified is associated with an account. '.
-        'Please login to that account and sign this document again.'));
+      ->setForbiddenText(
+        pht(
+          'The email address specified is associated with an account. '.
+          'Please login to that account and sign this document again.'));
   }
 
 }
diff --git a/src/applications/legalpad/controller/LegalpadDocumentSignatureVerificationController.php b/src/applications/legalpad/controller/LegalpadDocumentSignatureVerificationController.php
index 7ad5d13946..a940eb646f 100644
--- a/src/applications/legalpad/controller/LegalpadDocumentSignatureVerificationController.php
+++ b/src/applications/legalpad/controller/LegalpadDocumentSignatureVerificationController.php
@@ -38,9 +38,7 @@ final class LegalpadDocumentSignatureVerificationController
     if ($signature->isVerified()) {
       return $this->newDialog()
         ->setTitle(pht('Signature Already Verified'))
-        ->appendParagraph(
-          pht(
-            'This signature has already been verified.'))
+        ->appendParagraph(pht('This signature has already been verified.'))
         ->addCancelButton('/', pht('Okay'));
     }
 
diff --git a/src/applications/legalpad/mail/LegalpadMailReceiver.php b/src/applications/legalpad/mail/LegalpadMailReceiver.php
index 20296372ed..5fe0dfd4e8 100644
--- a/src/applications/legalpad/mail/LegalpadMailReceiver.php
+++ b/src/applications/legalpad/mail/LegalpadMailReceiver.php
@@ -3,8 +3,8 @@
 final class LegalpadMailReceiver extends PhabricatorObjectMailReceiver {
 
   public function isEnabled() {
-    $app_class = 'PhabricatorLegalpadApplication';
-    return PhabricatorApplication::isClassInstalled($app_class);
+    return PhabricatorApplication::isClassInstalled(
+      'PhabricatorLegalpadApplication');
   }
 
   protected function getObjectPattern() {
diff --git a/src/applications/legalpad/mail/LegalpadReplyHandler.php b/src/applications/legalpad/mail/LegalpadReplyHandler.php
index 8063d4ec2e..103f5a6cbb 100644
--- a/src/applications/legalpad/mail/LegalpadReplyHandler.php
+++ b/src/applications/legalpad/mail/LegalpadReplyHandler.php
@@ -5,7 +5,7 @@ final class LegalpadReplyHandler
 
   public function validateMailReceiver($mail_receiver) {
     if (!($mail_receiver instanceof LegalpadDocument)) {
-      throw new Exception('Mail receiver is not a LegalpadDocument!');
+      throw new Exception(pht('Mail receiver is not a LegalpadDocument!'));
     }
   }
 
diff --git a/src/applications/legalpad/query/LegalpadDocumentSearchEngine.php b/src/applications/legalpad/query/LegalpadDocumentSearchEngine.php
index 84abe3fdd1..9f404515be 100644
--- a/src/applications/legalpad/query/LegalpadDocumentSearchEngine.php
+++ b/src/applications/legalpad/query/LegalpadDocumentSearchEngine.php
@@ -108,7 +108,6 @@ final class LegalpadDocumentSearchEngine
       pht('Created After'),
       'createdEnd',
       pht('Created Before'));
-
   }
 
   protected function getURI($path) {
diff --git a/src/applications/legalpad/storage/LegalpadDocument.php b/src/applications/legalpad/storage/LegalpadDocument.php
index d750c3689b..4c6e04a26a 100644
--- a/src/applications/legalpad/storage/LegalpadDocument.php
+++ b/src/applications/legalpad/storage/LegalpadDocument.php
@@ -202,8 +202,7 @@ final class LegalpadDocument extends LegalpadDAO
   }
 
   public function describeAutomaticCapability($capability) {
-    return pht(
-      'The author of a document can always view and edit it.');
+    return pht('The author of a document can always view and edit it.');
   }
 
 
diff --git a/src/applications/legalpad/storage/LegalpadDocumentBody.php b/src/applications/legalpad/storage/LegalpadDocumentBody.php
index 1533f4165f..a55583428c 100644
--- a/src/applications/legalpad/storage/LegalpadDocumentBody.php
+++ b/src/applications/legalpad/storage/LegalpadDocumentBody.php
@@ -56,7 +56,7 @@ final class LegalpadDocumentBody extends LegalpadDAO
         $text = $this->getTitle();
         break;
       default:
-        throw new Exception('Unknown field: '.$field);
+        throw new Exception(pht('Unknown field: %s', $field));
         break;
     }
 
diff --git a/src/applications/lipsum/generator/PhabricatorTestDataGenerator.php b/src/applications/lipsum/generator/PhabricatorTestDataGenerator.php
index 45eca56c7c..9adf6fca70 100644
--- a/src/applications/lipsum/generator/PhabricatorTestDataGenerator.php
+++ b/src/applications/lipsum/generator/PhabricatorTestDataGenerator.php
@@ -12,7 +12,9 @@ abstract class PhabricatorTestDataGenerator {
         ->loadOneWhere('1 = 1 ORDER BY RAND() LIMIT 1');
     } catch (PhutilMissingSymbolException $ex) {
       throw new PhutilMissingSymbolException(
-        'Unable to load symbol '.$classname.': this class does not exit.');
+        pht(
+          'Unable to load symbol %s: this class does not exit.',
+          $classname));
     }
   }
 
diff --git a/src/applications/macro/conduit/MacroCreateMemeConduitAPIMethod.php b/src/applications/macro/conduit/MacroCreateMemeConduitAPIMethod.php
index 308f1c3b3a..e63d831a70 100644
--- a/src/applications/macro/conduit/MacroCreateMemeConduitAPIMethod.php
+++ b/src/applications/macro/conduit/MacroCreateMemeConduitAPIMethod.php
@@ -28,7 +28,7 @@ final class MacroCreateMemeConduitAPIMethod extends MacroConduitAPIMethod {
 
   protected function defineErrorTypes() {
     return array(
-      'ERR-NOT-FOUND' => 'Macro was not found.',
+      'ERR-NOT-FOUND' => pht('Macro was not found.'),
     );
   }
 
diff --git a/src/applications/macro/conduit/MacroQueryConduitAPIMethod.php b/src/applications/macro/conduit/MacroQueryConduitAPIMethod.php
index 66cdedeebc..44f54a3c8f 100644
--- a/src/applications/macro/conduit/MacroQueryConduitAPIMethod.php
+++ b/src/applications/macro/conduit/MacroQueryConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class MacroQueryConduitAPIMethod extends MacroConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Retrieve image macro information.';
+    return pht('Retrieve image macro information.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/macro/controller/PhabricatorMacroDisableController.php b/src/applications/macro/controller/PhabricatorMacroDisableController.php
index 8afc89df9b..b75e67e1f8 100644
--- a/src/applications/macro/controller/PhabricatorMacroDisableController.php
+++ b/src/applications/macro/controller/PhabricatorMacroDisableController.php
@@ -44,10 +44,14 @@ final class PhabricatorMacroDisableController
     $dialog
       ->setUser($request->getUser())
       ->setTitle(pht('Really disable macro?'))
-      ->appendChild(phutil_tag('p', array(), pht(
-        'Really disable the much-beloved image macro %s? '.
-          'It will be sorely missed.',
-        $macro->getName())))
+      ->appendChild(
+        phutil_tag(
+          'p',
+          array(),
+          pht(
+            'Really disable the much-beloved image macro %s? '.
+            'It will be sorely missed.',
+          $macro->getName())))
       ->setSubmitURI($this->getApplicationURI('/disable/'.$this->id.'/'))
       ->addSubmitButton(pht('Disable'))
       ->addCancelButton($view_uri);
diff --git a/src/applications/macro/mail/PhabricatorMacroMailReceiver.php b/src/applications/macro/mail/PhabricatorMacroMailReceiver.php
index 30f562e4b2..222524a377 100644
--- a/src/applications/macro/mail/PhabricatorMacroMailReceiver.php
+++ b/src/applications/macro/mail/PhabricatorMacroMailReceiver.php
@@ -3,8 +3,8 @@
 final class PhabricatorMacroMailReceiver extends PhabricatorObjectMailReceiver {
 
   public function isEnabled() {
-    $app_class = 'PhabricatorManiphestApplication';
-    return PhabricatorApplication::isClassInstalled($app_class);
+    return PhabricatorApplication::isClassInstalled(
+      'PhabricatorManiphestApplication');
   }
 
   protected function getObjectPattern() {
diff --git a/src/applications/macro/mail/PhabricatorMacroReplyHandler.php b/src/applications/macro/mail/PhabricatorMacroReplyHandler.php
index 5b0d9ce8a8..83b5d0a930 100644
--- a/src/applications/macro/mail/PhabricatorMacroReplyHandler.php
+++ b/src/applications/macro/mail/PhabricatorMacroReplyHandler.php
@@ -5,7 +5,8 @@ final class PhabricatorMacroReplyHandler
 
   public function validateMailReceiver($mail_receiver) {
     if (!($mail_receiver instanceof PhabricatorFileImageMacro)) {
-      throw new Exception('Mail receiver is not a PhabricatorFileImageMacro!');
+      throw new Exception(
+        pht('Mail receiver is not a %s!', 'PhabricatorFileImageMacro'));
     }
   }
 
diff --git a/src/applications/macro/query/PhabricatorMacroQuery.php b/src/applications/macro/query/PhabricatorMacroQuery.php
index 7c70746644..d4ffe46107 100644
--- a/src/applications/macro/query/PhabricatorMacroQuery.php
+++ b/src/applications/macro/query/PhabricatorMacroQuery.php
@@ -170,7 +170,7 @@ final class PhabricatorMacroQuery
       case self::STATUS_ANY:
         break;
       default:
-        throw new Exception("Unknown status '{$this->status}'!");
+        throw new Exception(pht("Unknown status '%s'!", $this->status));
     }
 
     if ($this->dateCreatedAfter) {
@@ -201,7 +201,7 @@ final class PhabricatorMacroQuery
         ->execute();
 
       if (empty($flags)) {
-        throw new PhabricatorEmptyQueryException('No matching flags.');
+        throw new PhabricatorEmptyQueryException(pht('No matching flags.'));
       } else {
         $where[] = qsprintf(
           $conn,
diff --git a/src/applications/mailinglists/application/PhabricatorMailingListsApplication.php b/src/applications/mailinglists/application/PhabricatorMailingListsApplication.php
index bd134933b2..cf62321996 100644
--- a/src/applications/mailinglists/application/PhabricatorMailingListsApplication.php
+++ b/src/applications/mailinglists/application/PhabricatorMailingListsApplication.php
@@ -3,7 +3,7 @@
 final class PhabricatorMailingListsApplication extends PhabricatorApplication {
 
   public function getName() {
-    return 'Mailing Lists';
+    return pht('Mailing Lists');
   }
 
   public function getBaseURI() {
@@ -11,7 +11,7 @@ final class PhabricatorMailingListsApplication extends PhabricatorApplication {
   }
 
   public function getShortDescription() {
-    return 'Manage External Lists';
+    return pht('Manage External Lists');
   }
 
   public function getFontIcon() {
diff --git a/src/applications/maniphest/__tests__/ManiphestTaskTestCase.php b/src/applications/maniphest/__tests__/ManiphestTaskTestCase.php
index fc9aa17381..b7fafa83ff 100644
--- a/src/applications/maniphest/__tests__/ManiphestTaskTestCase.php
+++ b/src/applications/maniphest/__tests__/ManiphestTaskTestCase.php
@@ -11,9 +11,9 @@ final class ManiphestTaskTestCase extends PhabricatorTestCase {
   public function testTaskReordering() {
     $viewer = $this->generateNewTestUser();
 
-    $t1 = $this->newTask($viewer, 'Task 1');
-    $t2 = $this->newTask($viewer, 'Task 2');
-    $t3 = $this->newTask($viewer, 'Task 3');
+    $t1 = $this->newTask($viewer, pht('Task 1'));
+    $t2 = $this->newTask($viewer, pht('Task 2'));
+    $t3 = $this->newTask($viewer, pht('Task 3'));
 
     $auto_base = min(mpull(array($t1, $t2, $t3), 'getID'));
 
@@ -95,7 +95,7 @@ final class ManiphestTaskTestCase extends PhabricatorTestCase {
 
     $t = array();
     for ($ii = 1; $ii < 10; $ii++) {
-      $t[$ii] = $this->newTask($viewer, "Task Block {$ii}");
+      $t[$ii] = $this->newTask($viewer, pht('Task Block %d', $ii));
 
       // This makes sure this test remains meaningful if we begin assigning
       // subpriorities when tasks are created.
@@ -124,7 +124,7 @@ final class ManiphestTaskTestCase extends PhabricatorTestCase {
     $this->assertEqual(
       9,
       count($subpri),
-      'Expected subpriorities to be distributed.');
+      pht('Expected subpriorities to be distributed.'));
   }
 
   private function newTask(PhabricatorUser $viewer, $title) {
diff --git a/src/applications/maniphest/command/ManiphestAssignEmailCommand.php b/src/applications/maniphest/command/ManiphestAssignEmailCommand.php
index 7d98bb003f..9d2a51b107 100644
--- a/src/applications/maniphest/command/ManiphestAssignEmailCommand.php
+++ b/src/applications/maniphest/command/ManiphestAssignEmailCommand.php
@@ -17,11 +17,13 @@ final class ManiphestAssignEmailCommand
 
   public function getCommandDescription() {
     return pht(
-      'To assign a task to another user, provide their username. For example, '.
-      'to assign a task to `alincoln`, write `!assign alincoln`.'.
-      "\n\n".
-      'If you omit the username or the username is not valid, this behaves '.
-      'like `!claim` and assigns the task to you instead.');
+      "To assign a task to another user, provide their username. For example, ".
+      "to assign a task to `%s`, write `%s`.\n\n".
+      "If you omit the username or the username is not valid, this behaves ".
+      "like `%s` and assigns the task to you instead.",
+      'alincoln',
+      '!assign alincoln',
+      '!claim');
   }
 
   public function buildTransactions(
diff --git a/src/applications/maniphest/command/ManiphestPriorityEmailCommand.php b/src/applications/maniphest/command/ManiphestPriorityEmailCommand.php
index 04fdc7399f..85ed148db7 100644
--- a/src/applications/maniphest/command/ManiphestPriorityEmailCommand.php
+++ b/src/applications/maniphest/command/ManiphestPriorityEmailCommand.php
@@ -29,12 +29,12 @@ final class ManiphestPriorityEmailCommand
     $table = implode("\n", $table);
 
     return pht(
-      'To change the priority of a task, specify the desired priority, like '.
-      '`!priority high`. This table shows the configured names for priority '.
-      'levels.'.
+      "To change the priority of a task, specify the desired priority, like ".
+      "`%s`. This table shows the configured names for priority levels.".
       "\n\n%s\n\n".
-      'If you specify an invalid priority, the command is ignored. This '.
-      'command has no effect if you do not specify a priority.',
+      "If you specify an invalid priority, the command is ignored. This ".
+      "command has no effect if you do not specify a priority.",
+      '!priority high',
       $table);
   }
 
diff --git a/src/applications/maniphest/command/ManiphestStatusEmailCommand.php b/src/applications/maniphest/command/ManiphestStatusEmailCommand.php
index 0e2ebbba76..c9fa07494f 100644
--- a/src/applications/maniphest/command/ManiphestStatusEmailCommand.php
+++ b/src/applications/maniphest/command/ManiphestStatusEmailCommand.php
@@ -29,11 +29,11 @@ final class ManiphestStatusEmailCommand
     $table = implode("\n", $table);
 
     return pht(
-      'To change the status of a task, specify the desired status, like '.
-      '`!status invalid`. This table shows the configured names for statuses.'.
-      "\n\n%s\n\n".
-      'If you specify an invalid status, the command is ignored. This '.
-      'command has no effect if you do not specify a status.',
+      "To change the status of a task, specify the desired status, like ".
+      "`%s`. This table shows the configured names for statuses.\n\n%s\n\n".
+      "If you specify an invalid status, the command is ignored. This ".
+      "command has no effect if you do not specify a status.",
+      '!status invalid',
       $table);
   }
 
diff --git a/src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php b/src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php
index 39067f7cbd..52257b2cb4 100644
--- a/src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php
+++ b/src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php
@@ -9,7 +9,7 @@ abstract class ManiphestConduitAPIMethod extends ConduitAPIMethod {
 
   protected function defineErrorTypes() {
     return array(
-      'ERR-INVALID-PARAMETER' => 'Missing or malformed parameter.',
+      'ERR-INVALID-PARAMETER' => pht('Missing or malformed parameter.'),
     );
   }
 
@@ -86,7 +86,7 @@ abstract class ManiphestConduitAPIMethod extends ConduitAPIMethod {
         $valid_statuses = ManiphestTaskStatus::getTaskStatusMap();
         if (!isset($valid_statuses[$status])) {
           throw id(new ConduitException('ERR-INVALID-PARAMETER'))
-            ->setErrorDescription('Status set to invalid value.');
+            ->setErrorDescription(pht('Status set to invalid value.'));
         }
         $changes[ManiphestTransaction::TYPE_STATUS] = $status;
       }
@@ -97,7 +97,7 @@ abstract class ManiphestConduitAPIMethod extends ConduitAPIMethod {
       $valid_priorities = ManiphestTaskPriority::getTaskPriorityMap();
       if (!isset($valid_priorities[$priority])) {
         throw id(new ConduitException('ERR-INVALID-PARAMETER'))
-          ->setErrorDescription('Priority set to invalid value.');
+          ->setErrorDescription(pht('Priority set to invalid value.'));
       }
       $changes[ManiphestTransaction::TYPE_PRIORITY] = $priority;
     }
@@ -313,7 +313,10 @@ abstract class ManiphestConduitAPIMethod extends ConduitAPIMethod {
     unset($phid_groups[$phid_type]);
     if (!empty($phid_groups)) {
       throw id(new ConduitException('ERR-INVALID-PARAMETER'))
-        ->setErrorDescription('One or more PHIDs were invalid for '.$field.'.');
+        ->setErrorDescription(
+          pht(
+            'One or more PHIDs were invalid for %s.',
+            $field));
     }
 
     return true;
diff --git a/src/applications/maniphest/conduit/ManiphestCreateTaskConduitAPIMethod.php b/src/applications/maniphest/conduit/ManiphestCreateTaskConduitAPIMethod.php
index ed16f77495..3a404774cf 100644
--- a/src/applications/maniphest/conduit/ManiphestCreateTaskConduitAPIMethod.php
+++ b/src/applications/maniphest/conduit/ManiphestCreateTaskConduitAPIMethod.php
@@ -8,7 +8,7 @@ final class ManiphestCreateTaskConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Create a new Maniphest task.';
+    return pht('Create a new Maniphest task.');
   }
 
   protected function defineParamTypes() {
@@ -21,7 +21,7 @@ final class ManiphestCreateTaskConduitAPIMethod
 
   protected function defineErrorTypes() {
     return array(
-      'ERR-INVALID-PARAMETER' => 'Missing or malformed parameter.',
+      'ERR-INVALID-PARAMETER' => pht('Missing or malformed parameter.'),
     );
   }
 
diff --git a/src/applications/maniphest/conduit/ManiphestGetTaskTransactionsConduitAPIMethod.php b/src/applications/maniphest/conduit/ManiphestGetTaskTransactionsConduitAPIMethod.php
index ff51dafd7d..4c64a56b33 100644
--- a/src/applications/maniphest/conduit/ManiphestGetTaskTransactionsConduitAPIMethod.php
+++ b/src/applications/maniphest/conduit/ManiphestGetTaskTransactionsConduitAPIMethod.php
@@ -8,7 +8,7 @@ final class ManiphestGetTaskTransactionsConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Retrieve Maniphest Task Transactions.';
+    return pht('Retrieve Maniphest task transactions.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/maniphest/conduit/ManiphestInfoConduitAPIMethod.php b/src/applications/maniphest/conduit/ManiphestInfoConduitAPIMethod.php
index 5915e74fb5..367feff41a 100644
--- a/src/applications/maniphest/conduit/ManiphestInfoConduitAPIMethod.php
+++ b/src/applications/maniphest/conduit/ManiphestInfoConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class ManiphestInfoConduitAPIMethod extends ManiphestConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Retrieve information about a Maniphest task, given its id.';
+    return pht('Retrieve information about a Maniphest task, given its ID.');
   }
 
   protected function defineParamTypes() {
@@ -22,7 +22,7 @@ final class ManiphestInfoConduitAPIMethod extends ManiphestConduitAPIMethod {
 
   protected function defineErrorTypes() {
     return array(
-      'ERR_BAD_TASK' => 'No such maniphest task exists',
+      'ERR_BAD_TASK' => pht('No such Maniphest task exists.'),
     );
   }
 
diff --git a/src/applications/maniphest/conduit/ManiphestQueryConduitAPIMethod.php b/src/applications/maniphest/conduit/ManiphestQueryConduitAPIMethod.php
index 0dc26e58ab..8a2321b2d3 100644
--- a/src/applications/maniphest/conduit/ManiphestQueryConduitAPIMethod.php
+++ b/src/applications/maniphest/conduit/ManiphestQueryConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class ManiphestQueryConduitAPIMethod extends ManiphestConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Execute complex searches for Maniphest tasks.';
+    return pht('Execute complex searches for Maniphest tasks.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/maniphest/conduit/ManiphestQueryStatusesConduitAPIMethod.php b/src/applications/maniphest/conduit/ManiphestQueryStatusesConduitAPIMethod.php
index 8255b3474c..971be8820b 100644
--- a/src/applications/maniphest/conduit/ManiphestQueryStatusesConduitAPIMethod.php
+++ b/src/applications/maniphest/conduit/ManiphestQueryStatusesConduitAPIMethod.php
@@ -8,7 +8,8 @@ final class ManiphestQueryStatusesConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Retrieve information about possible Maniphest Task status values.';
+    return pht(
+      'Retrieve information about possible Maniphest task status values.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/maniphest/conduit/ManiphestUpdateConduitAPIMethod.php b/src/applications/maniphest/conduit/ManiphestUpdateConduitAPIMethod.php
index a4a6232679..ad659af259 100644
--- a/src/applications/maniphest/conduit/ManiphestUpdateConduitAPIMethod.php
+++ b/src/applications/maniphest/conduit/ManiphestUpdateConduitAPIMethod.php
@@ -7,14 +7,14 @@ final class ManiphestUpdateConduitAPIMethod extends ManiphestConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Update an existing Maniphest task.';
+    return pht('Update an existing Maniphest task.');
   }
 
   protected function defineErrorTypes() {
     return array(
-      'ERR-BAD-TASK'          => 'No such maniphest task exists.',
-      'ERR-INVALID-PARAMETER' => 'Missing or malformed parameter.',
-      'ERR-NO-EFFECT'         => 'Update has no effect.',
+      'ERR-BAD-TASK'          => pht('No such Maniphest task exists.'),
+      'ERR-INVALID-PARAMETER' => pht('Missing or malformed parameter.'),
+      'ERR-NO-EFFECT'         => pht('Update has no effect.'),
     );
   }
 
@@ -31,7 +31,11 @@ final class ManiphestUpdateConduitAPIMethod extends ManiphestConduitAPIMethod {
     $phid = $request->getValue('phid');
 
     if (($id && $phid) || (!$id && !$phid)) {
-      throw new Exception("Specify exactly one of 'id' and 'phid'.");
+      throw new Exception(
+        pht(
+          "Specify exactly one of '%s' and '%s'.",
+          'id',
+          'phid'));
     }
 
     $query = id (new ManiphestTaskQuery())
diff --git a/src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php b/src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php
index 04d59c9966..a52b84dcbb 100644
--- a/src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php
+++ b/src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php
@@ -278,7 +278,8 @@ EOTEXT
             '     commands in email.'.
             "\n\n".
             'You can choose which priority is the default for newly created '.
-            'tasks with `maniphest.default-priority`.')),
+            'tasks with `%s`.',
+            'maniphest.default-priority')),
       $this->newOption('maniphest.statuses', $status_type, $status_defaults)
         ->setSummary(pht('Configure Maniphest task statuses.'))
         ->setDescription($status_description)
@@ -289,8 +290,9 @@ EOTEXT
           pht(
             'Choose a default priority for newly created tasks. You can '.
             'review and adjust available priorities by using the '.
-            '{{maniphest.priorities}} configuration option. The default value '.
-            '(`90`) corresponds to the default "Needs Triage" priority.')),
+            '%s configuration option. The default value (`90`) '.
+            'corresponds to the default "Needs Triage" priority.',
+            'maniphest.priorities')),
       $this->newOption(
         'metamta.maniphest.subject-prefix',
         'string',
@@ -305,7 +307,8 @@ EOTEXT
           pht(
             'Temporary setting. If set, this priority is used to populate the '.
             '"Unbreak Now" panel on the home page. You should adjust this if '.
-            'you adjust priorities using `maniphest.priorities`.')),
+            'you adjust priorities using `%s`.',
+            'maniphest.priorities')),
       $this->newOption(
         'maniphest.priorities.needs-triage',
         'int',
@@ -315,7 +318,8 @@ EOTEXT
           pht(
             'Temporary setting. If set, this priority is used to populate the '.
             '"Needs Triage" panel on the home page. You should adjust this if '.
-            'you adjust priorities using `maniphest.priorities`.')),
+            'you adjust priorities using `%s`.',
+            'maniphest.priorities')),
 
     );
   }
diff --git a/src/applications/maniphest/controller/ManiphestBatchEditController.php b/src/applications/maniphest/controller/ManiphestBatchEditController.php
index 58c8ffce1c..a4bf77ef14 100644
--- a/src/applications/maniphest/controller/ManiphestBatchEditController.php
+++ b/src/applications/maniphest/controller/ManiphestBatchEditController.php
@@ -213,7 +213,7 @@ final class ManiphestBatchEditController extends ManiphestController {
     $xactions = array();
     foreach ($actions as $action) {
       if (empty($type_map[$action['action']])) {
-        throw new Exception("Unknown batch edit action '{$action}'!");
+        throw new Exception(pht("Unknown batch edit action '%s'!", $action));
       }
 
       $type = $type_map[$action['action']];
diff --git a/src/applications/maniphest/controller/ManiphestExportController.php b/src/applications/maniphest/controller/ManiphestExportController.php
index 9c84c39491..6db04a6e32 100644
--- a/src/applications/maniphest/controller/ManiphestExportController.php
+++ b/src/applications/maniphest/controller/ManiphestExportController.php
@@ -30,8 +30,9 @@ final class ManiphestExportController extends ManiphestController {
         'administrator install it from:');
 
       $inst2 = pht(
-        'Your PHP "include_path" needs to be updated to include the '.
-        'PHPExcel Classes directory.');
+        'Your PHP "%s" needs to be updated to include the '.
+        'PHPExcel Classes directory.',
+        'include_path');
 
       $dialog->setTitle(pht('Excel Export Not Configured'));
       $dialog->appendChild(hsprintf(
@@ -78,8 +79,11 @@ final class ManiphestExportController extends ManiphestController {
       $dialog->setUser($user);
 
       $dialog->setTitle(pht('Export Tasks to Excel'));
-      $dialog->appendChild(phutil_tag('p', array(), pht(
-        'Do you want to export the query results to Excel?')));
+      $dialog->appendChild(
+        phutil_tag(
+          'p',
+          array(),
+          pht('Do you want to export the query results to Excel?')));
 
       $form = id(new PHUIFormLayoutView())
         ->appendChild(
@@ -97,7 +101,7 @@ final class ManiphestExportController extends ManiphestController {
 
     $format = idx($formats, $request->getStr('excel-format'));
     if ($format === null) {
-      throw new Exception('Excel format object not found.');
+      throw new Exception(pht('Excel format object not found.'));
     }
 
     $saved->makeEphemeral();
diff --git a/src/applications/maniphest/controller/ManiphestReportController.php b/src/applications/maniphest/controller/ManiphestReportController.php
index 3c6eca0542..b03caed542 100644
--- a/src/applications/maniphest/controller/ManiphestReportController.php
+++ b/src/applications/maniphest/controller/ManiphestReportController.php
@@ -172,7 +172,7 @@ final class ManiphestReportController extends ManiphestController {
       if ($week_bucket != $last_week) {
         if ($week) {
           $rows[] = $this->formatBurnRow(
-            'Week of '.phabricator_date($last_week_epoch, $user),
+            pht('Week of %s', phabricator_date($last_week_epoch, $user)),
             $week);
           $rowc[] = 'week';
         }
@@ -607,8 +607,8 @@ final class ManiphestReportController extends ManiphestController {
       array(
         'sigil' => 'has-tooltip',
         'meta'  => array(
-          'tip' => pht('Oldest open task, excluding those with Low or '.
-                   'Wishlist priority.'),
+          'tip' => pht(
+            'Oldest open task, excluding those with Low or Wishlist priority.'),
           'size' => 200,
         ),
       ),
diff --git a/src/applications/maniphest/controller/ManiphestTransactionSaveController.php b/src/applications/maniphest/controller/ManiphestTransactionSaveController.php
index f12171a474..f7693d9416 100644
--- a/src/applications/maniphest/controller/ManiphestTransactionSaveController.php
+++ b/src/applications/maniphest/controller/ManiphestTransactionSaveController.php
@@ -68,7 +68,7 @@ final class ManiphestTransactionSaveController extends ManiphestController {
         $transaction = null;
         break;
       default:
-        throw new Exception('unknown action');
+        throw new Exception(pht("Unknown action '%s'!", $action));
     }
 
     if ($transaction) {
diff --git a/src/applications/maniphest/editor/ManiphestTransactionEditor.php b/src/applications/maniphest/editor/ManiphestTransactionEditor.php
index abc83369bf..3609145c78 100644
--- a/src/applications/maniphest/editor/ManiphestTransactionEditor.php
+++ b/src/applications/maniphest/editor/ManiphestTransactionEditor.php
@@ -167,14 +167,18 @@ final class ManiphestTransactionEditor
         $board_phid = idx($xaction->getNewValue(), 'projectPHID');
         if (!$board_phid) {
           throw new Exception(
-            pht("Expected 'projectPHID' in column transaction."));
+            pht(
+              "Expected '%s' in column transaction.",
+              'projectPHID'));
         }
 
         $old_phids = idx($xaction->getOldValue(), 'columnPHIDs', array());
         $new_phids = idx($xaction->getNewValue(), 'columnPHIDs', array());
         if (count($new_phids) !== 1) {
           throw new Exception(
-            pht("Expected exactly one 'columnPHIDs' in column transaction."));
+            pht(
+              "Expected exactly one '%s' in column transaction.",
+              'columnPHIDs'));
         }
 
         $columns = id(new PhabricatorProjectColumnQuery())
diff --git a/src/applications/maniphest/mail/ManiphestCreateMailReceiver.php b/src/applications/maniphest/mail/ManiphestCreateMailReceiver.php
index 2df618c879..0102b1bd7b 100644
--- a/src/applications/maniphest/mail/ManiphestCreateMailReceiver.php
+++ b/src/applications/maniphest/mail/ManiphestCreateMailReceiver.php
@@ -3,8 +3,8 @@
 final class ManiphestCreateMailReceiver extends PhabricatorMailReceiver {
 
   public function isEnabled() {
-    $app_class = 'PhabricatorManiphestApplication';
-    return PhabricatorApplication::isClassInstalled($app_class);
+    return PhabricatorApplication::isClassInstalled(
+      'PhabricatorManiphestApplication');
   }
 
   public function canAcceptMail(PhabricatorMetaMTAReceivedMail $mail) {
diff --git a/src/applications/maniphest/mail/ManiphestReplyHandler.php b/src/applications/maniphest/mail/ManiphestReplyHandler.php
index f95f203112..af96de70da 100644
--- a/src/applications/maniphest/mail/ManiphestReplyHandler.php
+++ b/src/applications/maniphest/mail/ManiphestReplyHandler.php
@@ -5,7 +5,7 @@ final class ManiphestReplyHandler
 
   public function validateMailReceiver($mail_receiver) {
     if (!($mail_receiver instanceof ManiphestTask)) {
-      throw new Exception('Mail receiver is not a ManiphestTask!');
+      throw new Exception(pht('Mail receiver is not a %s!', 'ManiphestTask'));
     }
   }
 
diff --git a/src/applications/maniphest/mail/ManiphestTaskMailReceiver.php b/src/applications/maniphest/mail/ManiphestTaskMailReceiver.php
index 124b5d8dc6..e69ae82938 100644
--- a/src/applications/maniphest/mail/ManiphestTaskMailReceiver.php
+++ b/src/applications/maniphest/mail/ManiphestTaskMailReceiver.php
@@ -3,8 +3,8 @@
 final class ManiphestTaskMailReceiver extends PhabricatorObjectMailReceiver {
 
   public function isEnabled() {
-    $app_class = 'PhabricatorManiphestApplication';
-    return PhabricatorApplication::isClassInstalled($app_class);
+    return PhabricatorApplication::isClassInstalled(
+      'PhabricatorManiphestApplication');
   }
 
   protected function getObjectPattern() {
diff --git a/src/applications/maniphest/query/ManiphestTaskQuery.php b/src/applications/maniphest/query/ManiphestTaskQuery.php
index 4da078c004..09472be2ab 100644
--- a/src/applications/maniphest/query/ManiphestTaskQuery.php
+++ b/src/applications/maniphest/query/ManiphestTaskQuery.php
@@ -487,7 +487,7 @@ final class ManiphestTaskQuery extends PhabricatorCursorPagedPolicyAwareQuery {
       default:
         $constant = idx($map, $this->status);
         if (!$constant) {
-          throw new Exception("Unknown status query '{$this->status}'!");
+          throw new Exception(pht("Unknown status query '%s'!", $this->status));
         }
         return qsprintf(
           $conn,
diff --git a/src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php b/src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php
index c739c3969b..75dffdee31 100644
--- a/src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php
+++ b/src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php
@@ -42,36 +42,21 @@ final class PhabricatorApplicationEmailCommandsController
       "\n\n".
       'In most cases, you can reply to email you receive from Phabricator '.
       'to leave comments. You can also use **mail commands** to take a '.
-      'greater range of actions (like claming a task or requesting changes '.
+      'greater range of actions (like claiming a task or requesting changes '.
       'to a revision) without needing to log in to the web UI.'.
       "\n\n".
       'Mail commands are keywords which start with an exclamation point, '.
       'like `!claim`. Some commands may take parameters, like '.
-      '`!assign alincoln`.'.
-      "\n\n".
+      "`!assign alincoln`.\n\n".
       'To use mail commands, write one command per line at the beginning '.
       'or end of your mail message. For example, you could write this in a '.
       'reply to task email to claim the task:'.
-      "\n\n".
-
-      "```\n".
-      "!claim\n".
-      "\n".
-      "I'll take care of this.\n".
-      "```\n".
-
-      "\n\n".
+      "\n\n```\n!claim\n\nI'll take care of this.\n```\n\n\n".
       "When Phabricator receives your mail, it will process any commands ".
       "first, then post the remaining message body as a comment. You can ".
       "execute multiple commands at once:".
-      "\n\n".
-
-      "```\n".
-      "!assign alincoln\n".
-      "!close\n".
-      "\n".
-      "I just talked to @alincoln, and he showed me that he fixed this.\n".
-      "```\n",
+      "\n\n```\n!assign alincoln\n!close\n\nI just talked to @alincoln, ".
+      "and he showed me that he fixed this.\n```\n",
       PhabricatorEnv::getDoclink('Configuring Inbound Email'));
 
     $content[] = '= '.$spec['header'];
diff --git a/src/applications/meta/controller/PhabricatorApplicationUninstallController.php b/src/applications/meta/controller/PhabricatorApplicationUninstallController.php
index 744e9598f8..eaedb3a069 100644
--- a/src/applications/meta/controller/PhabricatorApplicationUninstallController.php
+++ b/src/applications/meta/controller/PhabricatorApplicationUninstallController.php
@@ -31,8 +31,8 @@ final class PhabricatorApplicationUninstallController
       'phabricator.show-prototypes');
 
     $dialog = id(new AphrontDialogView())
-               ->setUser($user)
-               ->addCancelButton($view_uri);
+      ->setUser($user)
+      ->addCancelButton($view_uri);
 
     if ($selected->isPrototype() && !$prototypes_enabled) {
       $dialog
@@ -52,14 +52,18 @@ final class PhabricatorApplicationUninstallController
 
     if ($this->action == 'install') {
       if ($selected->canUninstall()) {
-        $dialog->setTitle('Confirmation')
-               ->appendChild(
-                 'Install '.$selected->getName().' application?')
-               ->addSubmitButton('Install');
+        $dialog
+          ->setTitle('Confirmation')
+          ->appendChild(
+            pht(
+              'Install %s application?',
+              $selected->getName()))
+          ->addSubmitButton('Install');
 
       } else {
-        $dialog->setTitle('Information')
-               ->appendChild('You cannot install an installed application.');
+        $dialog
+          ->setTitle('Information')
+          ->appendChild(pht('You cannot install an installed application.'));
       }
     } else {
       if ($selected->canUninstall()) {
@@ -86,10 +90,12 @@ final class PhabricatorApplicationUninstallController
             ->addSubmitButton(pht('Uninstall'));
         }
       } else {
-        $dialog->setTitle('Information')
-               ->appendChild(
-                 'This application cannot be uninstalled,
-                 because it is required for Phabricator to work.');
+        $dialog
+          ->setTitle(pht('Information'))
+          ->appendChild(
+            pht(
+              'This application cannot be uninstalled, '.
+              'because it is required for Phabricator to work.'));
       }
     }
     return id(new AphrontDialogResponse())->setDialog($dialog);
diff --git a/src/applications/metamta/adapter/PhabricatorMailImplementationMailgunAdapter.php b/src/applications/metamta/adapter/PhabricatorMailImplementationMailgunAdapter.php
index c812f1ed4a..0890ac3004 100644
--- a/src/applications/metamta/adapter/PhabricatorMailImplementationMailgunAdapter.php
+++ b/src/applications/metamta/adapter/PhabricatorMailImplementationMailgunAdapter.php
@@ -131,7 +131,10 @@ final class PhabricatorMailImplementationMailgunAdapter
 
     if (!idx($response, 'id')) {
       $message = $response['message'];
-      throw new Exception("Request failed with errors: {$message}.");
+      throw new Exception(
+        pht(
+          'Request failed with errors: %s.',
+          $message));
     }
 
     return true;
diff --git a/src/applications/metamta/adapter/PhabricatorMailImplementationTestAdapter.php b/src/applications/metamta/adapter/PhabricatorMailImplementationTestAdapter.php
index 234438698b..0ea2af916f 100644
--- a/src/applications/metamta/adapter/PhabricatorMailImplementationTestAdapter.php
+++ b/src/applications/metamta/adapter/PhabricatorMailImplementationTestAdapter.php
@@ -81,12 +81,12 @@ final class PhabricatorMailImplementationTestAdapter
   public function send() {
     if (!empty($this->guts['fail-permanently'])) {
       throw new PhabricatorMetaMTAPermanentFailureException(
-        'Unit Test (Permanent)');
+        pht('Unit Test (Permanent)'));
     }
 
     if (!empty($this->guts['fail-temporarily'])) {
       throw new Exception(
-        'Unit Test (Temporary)');
+        pht('Unit Test (Temporary)'));
     }
 
     $this->guts['did-send'] = true;
diff --git a/src/applications/metamta/contentsource/PhabricatorContentSourceView.php b/src/applications/metamta/contentsource/PhabricatorContentSourceView.php
index e1a7b8fdaf..f159b2059d 100644
--- a/src/applications/metamta/contentsource/PhabricatorContentSourceView.php
+++ b/src/applications/metamta/contentsource/PhabricatorContentSourceView.php
@@ -26,7 +26,7 @@ final class PhabricatorContentSourceView extends AphrontView {
       array(
         'class' => 'phabricator-content-source-view',
       ),
-      "Via {$type}");
+      pht('Via %s', $type));
   }
 
 }
diff --git a/src/applications/metamta/controller/PhabricatorMetaMTASendGridReceiveController.php b/src/applications/metamta/controller/PhabricatorMetaMTASendGridReceiveController.php
index 11a0184ffd..646d6ef2ae 100644
--- a/src/applications/metamta/controller/PhabricatorMetaMTASendGridReceiveController.php
+++ b/src/applications/metamta/controller/PhabricatorMetaMTASendGridReceiveController.php
@@ -55,7 +55,7 @@ final class PhabricatorMetaMTASendGridReceiveController
     $received->processReceivedMail();
 
     $response = new AphrontWebpageResponse();
-    $response->setContent(pht("Got it! Thanks, SendGrid!\n"));
+    $response->setContent(pht('Got it! Thanks, SendGrid!')."\n");
     return $response;
   }
 
diff --git a/src/applications/metamta/management/PhabricatorMailManagementListInboundWorkflow.php b/src/applications/metamta/management/PhabricatorMailManagementListInboundWorkflow.php
index ed02b49681..02ed82a6b0 100644
--- a/src/applications/metamta/management/PhabricatorMailManagementListInboundWorkflow.php
+++ b/src/applications/metamta/management/PhabricatorMailManagementListInboundWorkflow.php
@@ -6,7 +6,7 @@ final class PhabricatorMailManagementListInboundWorkflow
   protected function didConstruct() {
     $this
       ->setName('list-inbound')
-      ->setSynopsis('List inbound messages received by Phabricator.')
+      ->setSynopsis(pht('List inbound messages received by Phabricator.'))
       ->setExamples(
         '**list-inbound**')
       ->setArguments(
@@ -15,7 +15,8 @@ final class PhabricatorMailManagementListInboundWorkflow
             'name'    => 'limit',
             'param'   => 'N',
             'default' => 100,
-            'help'    => 'Show a specific number of messages (default 100).',
+            'help'    => pht(
+              'Show a specific number of messages (default 100).'),
           ),
         ));
   }
@@ -43,10 +44,10 @@ final class PhabricatorMailManagementListInboundWorkflow
 
     $table = id(new PhutilConsoleTable())
       ->setShowHeader(false)
-      ->addColumn('id',      array('title' => 'ID'))
-      ->addColumn('author',  array('title' => 'Author'))
-      ->addColumn('phid',    array('title' => 'Related PHID'))
-      ->addColumn('subject', array('title' => 'Subject'));
+      ->addColumn('id',      array('title' => pht('ID')))
+      ->addColumn('author',  array('title' => pht('Author')))
+      ->addColumn('phid',    array('title' => pht('Related PHID')))
+      ->addColumn('subject', array('title' => pht('Subject')));
 
     foreach (array_reverse($mails) as $mail) {
       $table->addRow(array(
diff --git a/src/applications/metamta/management/PhabricatorMailManagementListOutboundWorkflow.php b/src/applications/metamta/management/PhabricatorMailManagementListOutboundWorkflow.php
index 7357993df7..366f5bdeca 100644
--- a/src/applications/metamta/management/PhabricatorMailManagementListOutboundWorkflow.php
+++ b/src/applications/metamta/management/PhabricatorMailManagementListOutboundWorkflow.php
@@ -6,7 +6,7 @@ final class PhabricatorMailManagementListOutboundWorkflow
   protected function didConstruct() {
     $this
       ->setName('list-outbound')
-      ->setSynopsis('List outbound messages sent by Phabricator.')
+      ->setSynopsis(pht('List outbound messages sent by Phabricator.'))
       ->setExamples(
         '**list-outbound**')
       ->setArguments(
@@ -15,7 +15,8 @@ final class PhabricatorMailManagementListOutboundWorkflow
             'name'    => 'limit',
             'param'   => 'N',
             'default' => 100,
-            'help'    => 'Show a specific number of messages (default 100).',
+            'help'    => pht(
+              'Show a specific number of messages (default 100).'),
           ),
         ));
   }
@@ -35,9 +36,9 @@ final class PhabricatorMailManagementListOutboundWorkflow
 
     $table = id(new PhutilConsoleTable())
       ->setShowHeader(false)
-      ->addColumn('id',      array('title' => 'ID'))
-      ->addColumn('status',  array('title' => 'Status'))
-      ->addColumn('subject', array('title' => 'Subject'));
+      ->addColumn('id',      array('title' => pht('ID')))
+      ->addColumn('status',  array('title' => pht('Status')))
+      ->addColumn('subject', array('title' => pht('Subject')));
 
     foreach (array_reverse($mails) as $mail) {
       $status = $mail->getStatus();
diff --git a/src/applications/metamta/management/PhabricatorMailManagementReceiveTestWorkflow.php b/src/applications/metamta/management/PhabricatorMailManagementReceiveTestWorkflow.php
index 2ee5fdf886..eb4d05d274 100644
--- a/src/applications/metamta/management/PhabricatorMailManagementReceiveTestWorkflow.php
+++ b/src/applications/metamta/management/PhabricatorMailManagementReceiveTestWorkflow.php
@@ -17,17 +17,17 @@ final class PhabricatorMailManagementReceiveTestWorkflow
           array(
             'name'    => 'as',
             'param'   => 'user',
-            'help'    => 'Act as the specified user.',
+            'help'    => pht('Act as the specified user.'),
           ),
           array(
             'name'    => 'from',
             'param'   => 'email',
-            'help'    => 'Simulate mail delivery "From:" the given user.',
+            'help'    => pht('Simulate mail delivery "From:" the given user.'),
           ),
           array(
             'name'    => 'to',
             'param'   => 'object',
-            'help'    => 'Simulate mail delivery "To:" the given object.',
+            'help'    => pht('Simulate mail delivery "To:" the given object.'),
           ),
         ));
   }
@@ -38,7 +38,9 @@ final class PhabricatorMailManagementReceiveTestWorkflow
     $to = $args->getArg('to');
     if (!$to) {
       throw new PhutilArgumentUsageException(
-        "Use '--to' to specify the receiving object or email address.");
+        pht(
+          "Use '%s' to specify the receiving object or email address.",
+          '--to'));
     }
 
     $to_application_email = id(new PhabricatorMetaMTAApplicationEmailQuery())
@@ -127,10 +129,11 @@ final class PhabricatorMailManagementReceiveTestWorkflow
       if (!($receiver instanceof PhabricatorObjectMailReceiver)) {
         $class = get_class($receiver);
         throw new Exception(
-          "Receiver '%s' accepts mail to '%s', but is not a ".
-          "subclass of PhabricatorObjectMailReceiver.",
-          $class,
-          $to);
+          pht(
+            "Receiver '%s' accepts mail to '%s', but is not a ".
+            "subclass of PhabricatorObjectMailReceiver.",
+            $class,
+            $to));
       }
 
       $object = $receiver->loadMailReceiverObject($to, $user);
diff --git a/src/applications/metamta/management/PhabricatorMailManagementResendWorkflow.php b/src/applications/metamta/management/PhabricatorMailManagementResendWorkflow.php
index c08731efe9..7a09324179 100644
--- a/src/applications/metamta/management/PhabricatorMailManagementResendWorkflow.php
+++ b/src/applications/metamta/management/PhabricatorMailManagementResendWorkflow.php
@@ -6,7 +6,7 @@ final class PhabricatorMailManagementResendWorkflow
   protected function didConstruct() {
     $this
       ->setName('resend')
-      ->setSynopsis('Send mail again.')
+      ->setSynopsis(pht('Send mail again.'))
       ->setExamples(
         '**resend** --id 1 --id 2')
       ->setArguments(
@@ -14,7 +14,7 @@ final class PhabricatorMailManagementResendWorkflow
           array(
             'name'    => 'id',
             'param'   => 'id',
-            'help'    => 'Send mail with a given ID again.',
+            'help'    => pht('Send mail with a given ID again.'),
             'repeat'  => true,
           ),
         ));
@@ -26,7 +26,9 @@ final class PhabricatorMailManagementResendWorkflow
     $ids = $args->getArg('id');
     if (!$ids) {
       throw new PhutilArgumentUsageException(
-        "Use the '--id' flag to specify one or more messages to resend.");
+        pht(
+          "Use the '%s' flag to specify one or more messages to resend.",
+          '--id'));
     }
 
     $messages = id(new PhabricatorMetaMTAMail())->loadAllWhere(
@@ -38,8 +40,9 @@ final class PhabricatorMailManagementResendWorkflow
       $missing = array_diff_key($ids, $messages);
       if ($missing) {
         throw new PhutilArgumentUsageException(
-          'Some specified messages do not exist: '.
-          implode(', ', array_keys($missing)));
+          pht(
+            'Some specified messages do not exist: %s',
+            implode(', ', array_keys($missing))));
       }
     }
 
@@ -55,8 +58,10 @@ final class PhabricatorMailManagementResendWorkflow
         ));
 
       $console->writeOut(
-        "Queued message #%d for resend.\n",
-        $message->getID());
+        "%s\n",
+        pht(
+          'Queued message #%d for resend.',
+          $message->getID()));
     }
   }
 
diff --git a/src/applications/metamta/management/PhabricatorMailManagementSendTestWorkflow.php b/src/applications/metamta/management/PhabricatorMailManagementSendTestWorkflow.php
index d36682e9f8..ca1af3a18b 100644
--- a/src/applications/metamta/management/PhabricatorMailManagementSendTestWorkflow.php
+++ b/src/applications/metamta/management/PhabricatorMailManagementSendTestWorkflow.php
@@ -10,51 +10,50 @@ final class PhabricatorMailManagementSendTestWorkflow
         pht(
           'Simulate sending mail. This may be useful to test your mail '.
           'configuration, or while developing new mail adapters.'))
-      ->setExamples(
-        '**send-test** --to alincoln --subject hi < body.txt')
+      ->setExamples('**send-test** --to alincoln --subject hi < body.txt')
       ->setArguments(
         array(
           array(
             'name'    => 'from',
             'param'   => 'user',
-            'help'    => 'Send mail from the specified user.',
+            'help'    => pht('Send mail from the specified user.'),
           ),
           array(
             'name'    => 'to',
             'param'   => 'user',
-            'help'    => 'Send mail "To:" the specified users.',
+            'help'    => pht('Send mail "To:" the specified users.'),
             'repeat'  => true,
           ),
           array(
             'name'    => 'cc',
             'param'   => 'user',
-            'help'    => 'Send mail which "Cc:"s the specified users.',
+            'help'    => pht('Send mail which "Cc:"s the specified users.'),
             'repeat'  => true,
           ),
           array(
             'name'    => 'subject',
             'param'   => 'text',
-            'help'    => 'Use the provided subject.',
+            'help'    => pht('Use the provided subject.'),
           ),
           array(
             'name'    => 'tag',
             'param'   => 'text',
-            'help'    => 'Add the given mail tags.',
+            'help'    => pht('Add the given mail tags.'),
             'repeat'  => true,
           ),
           array(
             'name'    => 'attach',
             'param'   => 'file',
-            'help'    => 'Attach a file.',
+            'help'    => pht('Attach a file.'),
             'repeat'  => true,
           ),
           array(
             'name'    => 'html',
-            'help'    => 'Send as HTML mail.',
+            'help'    => pht('Send as HTML mail.'),
           ),
           array(
             'name'    => 'bulk',
-            'help'    => 'Send with bulk headers.',
+            'help'    => pht('Send with bulk headers.'),
           ),
         ));
   }
@@ -82,8 +81,9 @@ final class PhabricatorMailManagementSendTestWorkflow
     if (!$tos && !$ccs) {
       throw new PhutilArgumentUsageException(
         pht(
-          'Specify one or more users to send mail to with `--to` and '.
-          '`--cc`.'));
+          'Specify one or more users to send mail to with `%s` and `%s`.',
+          '--to',
+          '--cc'));
     }
 
     $names = array_merge($tos, $ccs);
@@ -131,8 +131,10 @@ final class PhabricatorMailManagementSendTestWorkflow
 
     if ($args->getArg('html')) {
       $mail->setBody(
-        pht('(This is a placeholder plaintext email body for a test message '.
-            'sent with --html.)'));
+        pht(
+          '(This is a placeholder plaintext email body for a test message '.
+          'sent with %s.)',
+          '--html'));
 
       $mail->setHTMLBody($body);
     } else {
diff --git a/src/applications/metamta/management/PhabricatorMailManagementShowInboundWorkflow.php b/src/applications/metamta/management/PhabricatorMailManagementShowInboundWorkflow.php
index 7131187fa7..b9c0cd7d64 100644
--- a/src/applications/metamta/management/PhabricatorMailManagementShowInboundWorkflow.php
+++ b/src/applications/metamta/management/PhabricatorMailManagementShowInboundWorkflow.php
@@ -6,7 +6,7 @@ final class PhabricatorMailManagementShowInboundWorkflow
   protected function didConstruct() {
     $this
       ->setName('show-inbound')
-      ->setSynopsis('Show diagnostic details about inbound mail.')
+      ->setSynopsis(pht('Show diagnostic details about inbound mail.'))
       ->setExamples(
         '**show-inbound** --id 1 --id 2')
       ->setArguments(
@@ -14,7 +14,7 @@ final class PhabricatorMailManagementShowInboundWorkflow
           array(
             'name'    => 'id',
             'param'   => 'id',
-            'help'    => 'Show details about inbound mail with given ID.',
+            'help'    => pht('Show details about inbound mail with given ID.'),
             'repeat'  => true,
           ),
         ));
@@ -26,7 +26,9 @@ final class PhabricatorMailManagementShowInboundWorkflow
     $ids = $args->getArg('id');
     if (!$ids) {
       throw new PhutilArgumentUsageException(
-        "Use the '--id' flag to specify one or more messages to show.");
+        pht(
+          "Use the '%s' flag to specify one or more messages to show.",
+          '--id'));
     }
 
     $messages = id(new PhabricatorMetaMTAReceivedMail())->loadAllWhere(
@@ -38,8 +40,9 @@ final class PhabricatorMailManagementShowInboundWorkflow
       $missing = array_diff_key($ids, $messages);
       if ($missing) {
         throw new PhutilArgumentUsageException(
-          'Some specified messages do not exist: '.
-          implode(', ', array_keys($missing)));
+          pht(
+            'Some specified messages do not exist: %s',
+            implode(', ', array_keys($missing))));
       }
     }
 
diff --git a/src/applications/metamta/management/PhabricatorMailManagementShowOutboundWorkflow.php b/src/applications/metamta/management/PhabricatorMailManagementShowOutboundWorkflow.php
index 3b798259b4..bc8f4ccbaf 100644
--- a/src/applications/metamta/management/PhabricatorMailManagementShowOutboundWorkflow.php
+++ b/src/applications/metamta/management/PhabricatorMailManagementShowOutboundWorkflow.php
@@ -6,7 +6,7 @@ final class PhabricatorMailManagementShowOutboundWorkflow
   protected function didConstruct() {
     $this
       ->setName('show-outbound')
-      ->setSynopsis('Show diagnostic details about outbound mail.')
+      ->setSynopsis(pht('Show diagnostic details about outbound mail.'))
       ->setExamples(
         '**show-outbound** --id 1 --id 2')
       ->setArguments(
@@ -14,7 +14,7 @@ final class PhabricatorMailManagementShowOutboundWorkflow
           array(
             'name'    => 'id',
             'param'   => 'id',
-            'help'    => 'Show details about outbound mail with given ID.',
+            'help'    => pht('Show details about outbound mail with given ID.'),
             'repeat'  => true,
           ),
           array(
@@ -32,7 +32,9 @@ final class PhabricatorMailManagementShowOutboundWorkflow
     $ids = $args->getArg('id');
     if (!$ids) {
       throw new PhutilArgumentUsageException(
-        "Use the '--id' flag to specify one or more messages to show.");
+        pht(
+          "Use the '%s' flag to specify one or more messages to show.",
+          '--id'));
     }
 
     $messages = id(new PhabricatorMetaMTAMail())->loadAllWhere(
@@ -44,8 +46,9 @@ final class PhabricatorMailManagementShowOutboundWorkflow
       $missing = array_diff_key($ids, $messages);
       if ($missing) {
         throw new PhutilArgumentUsageException(
-          'Some specified messages do not exist: '.
-          implode(', ', array_keys($missing)));
+          pht(
+            'Some specified messages do not exist: %s',
+            implode(', ', array_keys($missing))));
       }
     }
 
diff --git a/src/applications/metamta/receiver/__tests__/PhabricatorMailReceiverTestCase.php b/src/applications/metamta/receiver/__tests__/PhabricatorMailReceiverTestCase.php
index ff7647bc17..f5b6ab578a 100644
--- a/src/applications/metamta/receiver/__tests__/PhabricatorMailReceiverTestCase.php
+++ b/src/applications/metamta/receiver/__tests__/PhabricatorMailReceiverTestCase.php
@@ -33,7 +33,7 @@ final class PhabricatorMailReceiverTestCase extends PhabricatorTestCase {
     foreach ($diff as $address) {
       $this->assertFalse(
         PhabricatorMailReceiver::matchAddresses($base, $address),
-        "Address: {$address}");
+        pht('Address: %s', $address));
     }
   }
 
diff --git a/src/applications/metamta/storage/PhabricatorMetaMTAMail.php b/src/applications/metamta/storage/PhabricatorMetaMTAMail.php
index 05a3f6b56e..07129d9e06 100644
--- a/src/applications/metamta/storage/PhabricatorMetaMTAMail.php
+++ b/src/applications/metamta/storage/PhabricatorMetaMTAMail.php
@@ -390,7 +390,7 @@ final class PhabricatorMetaMTAMail extends PhabricatorMetaMTADAO {
 
     if (!$force_send) {
       if ($this->getStatus() != self::STATUS_QUEUE) {
-        throw new Exception('Trying to send an already-sent mail!');
+        throw new Exception(pht('Trying to send an already-sent mail!'));
       }
     }
 
@@ -622,8 +622,9 @@ final class PhabricatorMetaMTAMail extends PhabricatorMetaMTADAO {
       if (!$add_to && !$add_cc) {
         $this->setStatus(self::STATUS_VOID);
         $this->setMessage(
-          'Message has no valid recipients: all To/Cc are disabled, invalid, '.
-          'or configured not to receive this mail.');
+          pht(
+            'Message has no valid recipients: all To/Cc are disabled, '.
+            'invalid, or configured not to receive this mail.'));
         return $this->save();
       }
 
@@ -644,8 +645,9 @@ final class PhabricatorMetaMTAMail extends PhabricatorMetaMTADAO {
         $this->setStatus(self::STATUS_VOID);
         $this->setMessage(
           pht(
-            'Phabricator is running in silent mode. See `phabricator.silent` '.
-            'in the configuration to change this setting.'));
+            'Phabricator is running in silent mode. See `%s` '.
+            'in the configuration to change this setting.',
+            'phabricator.silent'));
         return $this->save();
       }
 
@@ -727,11 +729,11 @@ final class PhabricatorMetaMTAMail extends PhabricatorMetaMTADAO {
   }
 
   public static function getReadableStatus($status_code) {
-    static $readable = array(
-      self::STATUS_QUEUE => 'Queued for Delivery',
-      self::STATUS_FAIL  => 'Delivery Failed',
-      self::STATUS_SENT  => 'Sent',
-      self::STATUS_VOID  => 'Void',
+    $readable = array(
+      self::STATUS_QUEUE => pht('Queued for Delivery'),
+      self::STATUS_FAIL  => pht('Delivery Failed'),
+      self::STATUS_SENT  => pht('Sent'),
+      self::STATUS_VOID  => pht('Void'),
     );
     $status_code = coalesce($status_code, '?');
     return idx($readable, $status_code, $status_code);
diff --git a/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php b/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php
index 91634fe577..0f17f08d53 100644
--- a/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php
+++ b/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php
@@ -220,8 +220,8 @@ final class PhabricatorMetaMTAReceivedMail extends PhabricatorMetaMTADAO {
     throw new PhabricatorMetaMTAReceivedMailProcessingException(
       MetaMTAReceivedMailStatus::STATUS_FROM_PHABRICATOR,
       pht(
-        "Ignoring email with 'X-Phabricator-Sent-This-Message' header to ".
-        "avoid loops."));
+        "Ignoring email with '%s' header to avoid loops.",
+        'X-Phabricator-Sent-This-Message'));
   }
 
   /**
diff --git a/src/applications/metamta/storage/__tests__/PhabricatorMetaMTAMailTestCase.php b/src/applications/metamta/storage/__tests__/PhabricatorMetaMTAMailTestCase.php
index 5822b11a98..97369f054a 100644
--- a/src/applications/metamta/storage/__tests__/PhabricatorMetaMTAMailTestCase.php
+++ b/src/applications/metamta/storage/__tests__/PhabricatorMetaMTAMailTestCase.php
@@ -69,7 +69,7 @@ final class PhabricatorMetaMTAMailTestCase extends PhabricatorTestCase {
 
     $this->assertTrue(
       in_array($phid, $mail->buildRecipientList()),
-      '"To" is a recipient.');
+      pht('"To" is a recipient.'));
 
 
     // Test that the "No Self Mail" and "No Mail" preferences work correctly.
@@ -77,7 +77,7 @@ final class PhabricatorMetaMTAMailTestCase extends PhabricatorTestCase {
 
     $this->assertTrue(
       in_array($phid, $mail->buildRecipientList()),
-      '"From" does not exclude recipients by default.');
+      pht('"From" does not exclude recipients by default.'));
 
     $prefs->setPreference(
       PhabricatorUserPreferences::PREFERENCE_NO_SELF_MAIL,
@@ -86,7 +86,7 @@ final class PhabricatorMetaMTAMailTestCase extends PhabricatorTestCase {
 
     $this->assertFalse(
       in_array($phid, $mail->buildRecipientList()),
-      '"From" excludes recipients with no-self-mail set.');
+      pht('"From" excludes recipients with no-self-mail set.'));
 
     $prefs->unsetPreference(
       PhabricatorUserPreferences::PREFERENCE_NO_SELF_MAIL);
@@ -94,7 +94,7 @@ final class PhabricatorMetaMTAMailTestCase extends PhabricatorTestCase {
 
     $this->assertTrue(
       in_array($phid, $mail->buildRecipientList()),
-      '"From" does not exclude recipients by default.');
+      pht('"From" does not exclude recipients by default.'));
 
     $prefs->setPreference(
       PhabricatorUserPreferences::PREFERENCE_NO_MAIL,
@@ -103,13 +103,13 @@ final class PhabricatorMetaMTAMailTestCase extends PhabricatorTestCase {
 
     $this->assertFalse(
       in_array($phid, $mail->buildRecipientList()),
-      '"From" excludes recipients with no-mail set.');
+      pht('"From" excludes recipients with no-mail set.'));
 
     $mail->setForceDelivery(true);
 
     $this->assertTrue(
       in_array($phid, $mail->buildRecipientList()),
-      '"From" includes no-mail recipients when forced.');
+      pht('"From" includes no-mail recipients when forced.'));
 
     $mail->setForceDelivery(false);
 
@@ -119,7 +119,7 @@ final class PhabricatorMetaMTAMailTestCase extends PhabricatorTestCase {
 
     $this->assertTrue(
       in_array($phid, $mail->buildRecipientList()),
-      '"From" does not exclude recipients by default.');
+      pht('"From" does not exclude recipients by default.'));
 
 
     // Test that explicit exclusion works correctly.
@@ -127,7 +127,7 @@ final class PhabricatorMetaMTAMailTestCase extends PhabricatorTestCase {
 
     $this->assertFalse(
       in_array($phid, $mail->buildRecipientList()),
-      'Explicit exclude excludes recipients.');
+      pht('Explicit exclude excludes recipients.'));
 
     $mail->setExcludeMailRecipientPHIDs(array());
 
@@ -144,7 +144,7 @@ final class PhabricatorMetaMTAMailTestCase extends PhabricatorTestCase {
 
     $this->assertFalse(
       in_array($phid, $mail->buildRecipientList()),
-      'Tag preference excludes recipients.');
+      pht('Tag preference excludes recipients.'));
 
     $prefs->unsetPreference(PhabricatorUserPreferences::PREFERENCE_MAILTAGS);
     $prefs->save();
@@ -194,19 +194,25 @@ final class PhabricatorMetaMTAMailTestCase extends PhabricatorTestCase {
 
     $this->assertTrue(
       isset($dict['Thread-Index']),
-      "Expect Thread-Index header for case {$case}.");
+      pht('Expect Thread-Index header for case %s.', $case));
     $this->assertEqual(
       $expect_message_id,
       isset($dict['Message-ID']),
-      "Expectation about existence of Message-ID header for case {$case}.");
+      pht(
+        'Expectation about existence of Message-ID header for case %s.',
+        $case));
     $this->assertEqual(
       $expect_in_reply_to,
       isset($dict['In-Reply-To']),
-      "Expectation about existence of In-Reply-To header for case {$case}.");
+      pht(
+        'Expectation about existence of In-Reply-To header for case %s.',
+        $case));
     $this->assertEqual(
       $expect_references,
       isset($dict['References']),
-      "Expectation about existence of References header for case {$case}.");
+      pht(
+        'Expectation about existence of References header for case %s.',
+        $case));
   }
 
 }
diff --git a/src/applications/notification/controller/PhabricatorNotificationClearController.php b/src/applications/notification/controller/PhabricatorNotificationClearController.php
index 94ee8aa0f3..ba781234e7 100644
--- a/src/applications/notification/controller/PhabricatorNotificationClearController.php
+++ b/src/applications/notification/controller/PhabricatorNotificationClearController.php
@@ -27,7 +27,7 @@ final class PhabricatorNotificationClearController
     $dialog->setUser($user);
     $dialog->addCancelButton('/notification/');
     if ($chrono_key) {
-      $dialog->setTitle('Really mark all notifications as read?');
+      $dialog->setTitle(pht('Really mark all notifications as read?'));
       $dialog->addHiddenInput('chronoKey', $chrono_key);
 
       $is_serious =
@@ -45,9 +45,8 @@ final class PhabricatorNotificationClearController
 
       $dialog->addSubmitButton(pht('Mark All Read'));
     } else {
-      $dialog->setTitle('No notifications to mark as read.');
-      $dialog->appendChild(pht(
-        'You have no unread notifications.'));
+      $dialog->setTitle(pht('No notifications to mark as read.'));
+      $dialog->appendChild(pht('You have no unread notifications.'));
     }
 
     return id(new AphrontDialogResponse())->setDialog($dialog);
diff --git a/src/applications/notification/controller/PhabricatorNotificationStatusController.php b/src/applications/notification/controller/PhabricatorNotificationStatusController.php
index 398586e59e..2c9e308985 100644
--- a/src/applications/notification/controller/PhabricatorNotificationStatusController.php
+++ b/src/applications/notification/controller/PhabricatorNotificationStatusController.php
@@ -9,13 +9,13 @@ final class PhabricatorNotificationStatusController
       $status = $this->renderServerStatus($status);
     } catch (Exception $ex) {
       $status = new PHUIInfoView();
-      $status->setTitle('Notification Server Issue');
+      $status->setTitle(pht('Notification Server Issue'));
       $status->appendChild(hsprintf(
-        'Unable to determine server status. This probably means the server '.
-        'is not in great shape. The specific issue encountered was:'.
-        '<br />'.
-        '<br />'.
+        '%s<br /><br />'.
         '<strong>%s</strong> %s',
+        pht(
+          'Unable to determine server status. This probably means the server '.
+          'is not in great shape. The specific issue encountered was:'),
         get_class($ex),
         phutil_escape_html_newlines($ex->getMessage())));
     }
diff --git a/src/applications/notification/setup/PhabricatorAphlictSetupCheck.php b/src/applications/notification/setup/PhabricatorAphlictSetupCheck.php
index 91096c8240..99dba45ec4 100644
--- a/src/applications/notification/setup/PhabricatorAphlictSetupCheck.php
+++ b/src/applications/notification/setup/PhabricatorAphlictSetupCheck.php
@@ -13,12 +13,10 @@ final class PhabricatorAphlictSetupCheck extends PhabricatorSetupCheck {
       $status = PhabricatorNotificationClient::getServerStatus();
     } catch (Exception $ex) {
       $message = pht(
-        'Phabricator is configured to use a notification server, but '.
-        'is unable to connect to it. You should resolve this issue or '.
-        'disable the notification server. It may be helpful to double check '.
-        'your configuration or restart the server using the command below.'.
-        "\n\n".
-        "%s",
+        "Phabricator is configured to use a notification server, but is ".
+        "unable to connect to it. You should resolve this issue or disable ".
+        "the notification server. It may be helpful to double check your ".
+        "configuration or restart the server using the command below.\n\n%s",
         phutil_tag(
           'pre',
           array(),
diff --git a/src/applications/nuance/controller/NuanceQueueViewController.php b/src/applications/nuance/controller/NuanceQueueViewController.php
index d863cda0ed..261b528193 100644
--- a/src/applications/nuance/controller/NuanceQueueViewController.php
+++ b/src/applications/nuance/controller/NuanceQueueViewController.php
@@ -31,7 +31,7 @@ final class NuanceQueueViewController extends NuanceController {
     }
 
     $crumbs = $this->buildApplicationCrumbs();
-    $title = 'TODO';
+    $title = pht('TODO');
 
     return $this->buildApplicationPage(
       $crumbs,
diff --git a/src/applications/nuance/controller/NuanceRequestorEditController.php b/src/applications/nuance/controller/NuanceRequestorEditController.php
index 1938655474..42405a227f 100644
--- a/src/applications/nuance/controller/NuanceRequestorEditController.php
+++ b/src/applications/nuance/controller/NuanceRequestorEditController.php
@@ -38,7 +38,7 @@ final class NuanceRequestorEditController extends NuanceController {
     }
 
     $crumbs = $this->buildApplicationCrumbs();
-    $title = 'TODO';
+    $title = pht('TODO');
 
     return $this->buildApplicationPage(
       $crumbs,
diff --git a/src/applications/nuance/source/NuancePhabricatorFormSourceDefinition.php b/src/applications/nuance/source/NuancePhabricatorFormSourceDefinition.php
index 6ebb07d0fb..1d49b17c55 100644
--- a/src/applications/nuance/source/NuancePhabricatorFormSourceDefinition.php
+++ b/src/applications/nuance/source/NuancePhabricatorFormSourceDefinition.php
@@ -20,7 +20,7 @@ final class NuancePhabricatorFormSourceDefinition
     PhabricatorApplicationTransactionValidationException $ex = null) {
 
     /* TODO - add a box to allow for custom fields to be defined here, so that
-     * these NuanceSource objects made from this defintion can be used to
+     * these NuanceSource objects made from this definition can be used to
      * capture arbitrary data */
 
     return $form;
diff --git a/src/applications/nuance/source/NuanceSourceDefinition.php b/src/applications/nuance/source/NuanceSourceDefinition.php
index e643daa0b1..b2092dfdff 100644
--- a/src/applications/nuance/source/NuanceSourceDefinition.php
+++ b/src/applications/nuance/source/NuanceSourceDefinition.php
@@ -15,7 +15,7 @@ abstract class NuanceSourceDefinition extends Phobject {
   public function requireActor() {
     $actor = $this->getActor();
     if (!$actor) {
-      throw new Exception('You must "setActor()" first!');
+      throw new PhutilInvalidStateException('setActor');
     }
     return $actor;
   }
@@ -31,7 +31,7 @@ abstract class NuanceSourceDefinition extends Phobject {
   public function requireSourceObject() {
     $source = $this->getSourceObject();
     if (!$source) {
-      throw new Exception('You must "setSourceObject()" first!');
+      throw new PhutilInvalidStateException('setSourceObject');
     }
     return $source;
   }
@@ -75,11 +75,12 @@ abstract class NuanceSourceDefinition extends Phobject {
         $name = $definition->getName();
         if (isset($definitions[$key])) {
           $conflict = $definitions[$key];
-          throw new Exception(sprintf(
-            'Defintion %s conflicts with definition %s. This is a programming '.
-            'error.',
-            $conflict,
-            $name));
+          throw new Exception(
+            pht(
+              'Definition %s conflicts with definition %s. This is a '.
+              'programming error.',
+              $conflict,
+              $name));
         }
       }
       $definitions = $objects;
diff --git a/src/applications/oauthserver/PhabricatorOAuthServer.php b/src/applications/oauthserver/PhabricatorOAuthServer.php
index b7dc0d6301..5f75083c89 100644
--- a/src/applications/oauthserver/PhabricatorOAuthServer.php
+++ b/src/applications/oauthserver/PhabricatorOAuthServer.php
@@ -36,7 +36,7 @@ final class PhabricatorOAuthServer {
 
   private function getUser() {
     if (!$this->user) {
-      throw new Exception('You must setUser before you can getUser!');
+      throw new PhutilInvalidStateException('setUser');
     }
     return $this->user;
   }
@@ -48,7 +48,7 @@ final class PhabricatorOAuthServer {
 
   private function getClient() {
     if (!$this->client) {
-      throw new Exception('You must setClient before you can getClient!');
+      throw new PhutilInvalidStateException('setClient');
     }
     return $this->client;
   }
@@ -65,16 +65,16 @@ final class PhabricatorOAuthServer {
   public function userHasAuthorizedClient(array $scope) {
 
     $authorization = id(new PhabricatorOAuthClientAuthorization())->
-      loadOneWhere('userPHID = %s AND clientPHID = %s',
-                   $this->getUser()->getPHID(),
-                   $this->getClient()->getPHID());
+      loadOneWhere(
+        'userPHID = %s AND clientPHID = %s',
+        $this->getUser()->getPHID(),
+        $this->getClient()->getPHID());
     if (empty($authorization)) {
       return array(false, null);
     }
 
     if ($scope) {
-      $missing_scope = array_diff_key($scope,
-                                      $authorization->getScope());
+      $missing_scope = array_diff_key($scope, $authorization->getScope());
     } else {
       $missing_scope = false;
     }
@@ -166,10 +166,10 @@ final class PhabricatorOAuthServer {
     $must_be_used_by = $created_time + self::ACCESS_TOKEN_TIMEOUT;
     $expired         = time() > $must_be_used_by;
     $authorization   = id(new PhabricatorOAuthClientAuthorization())
-                         ->loadOneWhere(
-                           'userPHID = %s AND clientPHID = %s',
-                           $token->getUserPHID(),
-                           $token->getClientPHID());
+      ->loadOneWhere(
+        'userPHID = %s AND clientPHID = %s',
+        $token->getUserPHID(),
+        $token->getClientPHID());
 
     if (!$authorization) {
       return false;
diff --git a/src/applications/oauthserver/PhabricatorOAuthServerScope.php b/src/applications/oauthserver/PhabricatorOAuthServerScope.php
index 38707fa3c3..dcba6b6234 100644
--- a/src/applications/oauthserver/PhabricatorOAuthServerScope.php
+++ b/src/applications/oauthserver/PhabricatorOAuthServerScope.php
@@ -60,10 +60,10 @@ final class PhabricatorOAuthServerScope {
     $label = null;
     switch ($scope) {
       case self::SCOPE_OFFLINE_ACCESS:
-        $label = 'Make access tokens granted to this client never expire.';
+        $label = pht('Make access tokens granted to this client never expire.');
         break;
       case self::SCOPE_WHOAMI:
-        $label = 'Read access to Conduit method user.whoami.';
+        $label = pht('Read access to Conduit method %s.', 'user.whoami');
         break;
     }
 
diff --git a/src/applications/oauthserver/__tests__/PhabricatorOAuthServerTestCase.php b/src/applications/oauthserver/__tests__/PhabricatorOAuthServerTestCase.php
index 30fea69a94..2fa1778f51 100644
--- a/src/applications/oauthserver/__tests__/PhabricatorOAuthServerTestCase.php
+++ b/src/applications/oauthserver/__tests__/PhabricatorOAuthServerTestCase.php
@@ -18,7 +18,7 @@ final class PhabricatorOAuthServerTestCase
       $this->assertEqual(
         $expected,
         $result,
-        "Validation of redirect URI '{$input}'");
+        pht("Validation of redirect URI '%s'", $input));
     }
   }
 
@@ -39,8 +39,10 @@ final class PhabricatorOAuthServerTestCase
       $this->assertEqual(
         $expected,
         $server->validateSecondaryRedirectURI($uri, $primary_uri),
-        "Validation of redirect URI '{$input}' ".
-        "relative to '{$primary_uri}'");
+        pht(
+          "Validation of redirect URI '%s' relative to '%s'",
+          $input,
+          $primary_uri));
     }
 
     $primary_uri = new PhutilURI('http://www.google.com/?auth');
@@ -57,8 +59,10 @@ final class PhabricatorOAuthServerTestCase
       $this->assertEqual(
         $expected,
         $server->validateSecondaryRedirectURI($uri, $primary_uri),
-        "Validation of secondary redirect URI '{$input}' ".
-        "relative to '{$primary_uri}'");
+        pht(
+          "Validation of secondary redirect URI '%s' relative to '%s'",
+          $input,
+          $primary_uri));
     }
 
     $primary_uri = new PhutilURI('https://secure.example.com/');
@@ -71,7 +75,7 @@ final class PhabricatorOAuthServerTestCase
       $this->assertEqual(
         $expected,
         $server->validateSecondaryRedirectURI($uri, $primary_uri),
-        "Validation (https): {$input}");
+        pht('Validation (https): %s', $input));
     }
 
     $primary_uri = new PhutilURI('http://example.com/?z=2&y=3');
@@ -88,7 +92,7 @@ final class PhabricatorOAuthServerTestCase
       $this->assertEqual(
         $expected,
         $server->validateSecondaryRedirectURI($uri, $primary_uri),
-        "Validation (params): {$input}");
+        pht('Validation (params): %s', $input));
     }
 
   }
diff --git a/src/applications/oauthserver/controller/PhabricatorOAuthServerController.php b/src/applications/oauthserver/controller/PhabricatorOAuthServerController.php
index 1c0dc588ba..22388c8766 100644
--- a/src/applications/oauthserver/controller/PhabricatorOAuthServerController.php
+++ b/src/applications/oauthserver/controller/PhabricatorOAuthServerController.php
@@ -6,23 +6,19 @@ abstract class PhabricatorOAuthServerController
   public function buildStandardPageResponse($view, array $data) {
     $user = $this->getRequest()->getUser();
     $page = $this->buildStandardPageView();
-    $page->setApplicationName('OAuth Server');
+    $page->setApplicationName(pht('OAuth Server'));
     $page->setBaseURI('/oauthserver/');
     $page->setTitle(idx($data, 'title'));
 
     $nav = new AphrontSideNavFilterView();
     $nav->setBaseURI(new PhutilURI('/oauthserver/'));
-    $nav->addLabel('Clients');
-    $nav->addFilter('client/create',
-                    'Create Client');
+    $nav->addLabel(pht('Clients'));
+    $nav->addFilter('client/create', pht('Create Client'));
     foreach ($this->getExtraClientFilters() as $filter) {
-      $nav->addFilter($filter['url'],
-                      $filter['label']);
+      $nav->addFilter($filter['url'], $filter['label']);
     }
-    $nav->addFilter('client',
-                    'My Clients');
-    $nav->selectFilter($this->getFilter(),
-                       'clientauthorization');
+    $nav->addFilter('client', pht('My Clients'));
+    $nav->selectFilter($this->getFilter(), 'clientauthorization');
 
     $nav->appendChild($view);
 
diff --git a/src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php b/src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php
index 5b3db13fb9..aa9b8f71a0 100644
--- a/src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php
+++ b/src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php
@@ -26,25 +26,31 @@ final class PhabricatorOAuthServerTokenController
     if ($grant_type != 'authorization_code') {
       $response->setError('unsupported_grant_type');
       $response->setErrorDescription(
-        'Only grant_type authorization_code is supported.');
+        pht(
+          'Only %s %s is supported.',
+          'grant_type',
+          'authorization_code'));
       return $response;
     }
     if (!$code) {
       $response->setError('invalid_request');
-      $response->setErrorDescription(
-        'Required parameter code missing.');
+      $response->setErrorDescription(pht('Required parameter code missing.'));
       return $response;
     }
     if (!$client_phid) {
       $response->setError('invalid_request');
       $response->setErrorDescription(
-        'Required parameter client_id missing.');
+        pht(
+          'Required parameter %s missing.',
+          'client_id'));
       return $response;
     }
     if (!$client_secret) {
       $response->setError('invalid_request');
       $response->setErrorDescription(
-        'Required parameter client_secret missing.');
+        pht(
+          'Required parameter %s missing.',
+          'client_secret'));
       return $response;
     }
     // one giant try / catch around all the exciting database stuff so we
@@ -56,7 +62,9 @@ final class PhabricatorOAuthServerTokenController
       if (!$auth_code) {
         $response->setError('invalid_grant');
         $response->setErrorDescription(
-          'Authorization code '.$code.' not found.');
+          pht(
+            'Authorization code %d not found.',
+            $code));
         return $response;
       }
 
@@ -70,25 +78,29 @@ final class PhabricatorOAuthServerTokenController
              $redirect_uri != $auth_code_redirect_uri) {
           $response->setError('invalid_grant');
           $response->setErrorDescription(
-            'Redirect uri in request must exactly match redirect uri '.
-            'from authorization code.');
+            pht(
+              'Redirect URI in request must exactly match redirect URI '.
+              'from authorization code.'));
           return $response;
         }
       } else if ($redirect_uri) {
         $response->setError('invalid_grant');
         $response->setErrorDescription(
-          'Redirect uri in request and no redirect uri in authorization '.
-          'code. The two must exactly match.');
+          pht(
+            'Redirect URI in request and no redirect URI in authorization '.
+            'code. The two must exactly match.'));
         return $response;
       }
 
       $client = id(new PhabricatorOAuthServerClient())
-        ->loadOneWhere('phid = %s',
-                       $client_phid);
+        ->loadOneWhere('phid = %s', $client_phid);
       if (!$client) {
         $response->setError('invalid_client');
         $response->setErrorDescription(
-          'Client with client_id '.$client_phid.' not found.');
+          pht(
+            'Client with %s %d not found.',
+            'client_id',
+            $client_phid));
         return $response;
       }
       $server->setClient($client);
@@ -99,7 +111,9 @@ final class PhabricatorOAuthServerTokenController
       if (!$user) {
         $response->setError('invalid_grant');
         $response->setErrorDescription(
-          'User with phid '.$user_phid.' not found.');
+          pht(
+            'User with PHID %d not found.',
+            $user_phid));
         return $response;
       }
       $server->setUser($user);
@@ -107,12 +121,15 @@ final class PhabricatorOAuthServerTokenController
       $test_code = new PhabricatorOAuthServerAuthorizationCode();
       $test_code->setClientSecret($client_secret);
       $test_code->setClientPHID($client_phid);
-      $is_good_code = $server->validateAuthorizationCode($auth_code,
-                                                         $test_code);
+      $is_good_code = $server->validateAuthorizationCode(
+        $auth_code,
+        $test_code);
       if (!$is_good_code) {
         $response->setError('invalid_grant');
         $response->setErrorDescription(
-          'Invalid authorization code '.$code.'.');
+          pht(
+            'Invalid authorization code %d.',
+            $code));
         return $response;
       }
 
@@ -129,8 +146,9 @@ final class PhabricatorOAuthServerTokenController
     } catch (Exception $e) {
       $response->setError('server_error');
       $response->setErrorDescription(
-        'The authorization server encountered an unexpected condition '.
-        'which prevented it from fulfilling the request.');
+        pht(
+          'The authorization server encountered an unexpected condition '.
+          'which prevented it from fulfilling the request.'));
       return $response;
     }
   }
diff --git a/src/applications/oauthserver/controller/client/PhabricatorOAuthClientEditController.php b/src/applications/oauthserver/controller/client/PhabricatorOAuthClientEditController.php
index 1f1b0e387b..cd194aa74b 100644
--- a/src/applications/oauthserver/controller/client/PhabricatorOAuthClientEditController.php
+++ b/src/applications/oauthserver/controller/client/PhabricatorOAuthClientEditController.php
@@ -82,13 +82,13 @@ final class PhabricatorOAuthClientEditController
       ->setUser($viewer)
       ->appendChild(
         id(new AphrontFormTextControl())
-          ->setLabel('Name')
+          ->setLabel(pht('Name'))
           ->setName('name')
           ->setValue($client->getName())
           ->setError($e_name))
       ->appendChild(
         id(new AphrontFormTextControl())
-          ->setLabel('Redirect URI')
+          ->setLabel(pht('Redirect URI'))
           ->setName('redirect_uri')
           ->setValue($client->getRedirectURI())
           ->setError($e_redirect))
diff --git a/src/applications/oauthserver/controller/client/PhabricatorOAuthClientSecretController.php b/src/applications/oauthserver/controller/client/PhabricatorOAuthClientSecretController.php
index cdfc53e5b4..ceb1379b7a 100644
--- a/src/applications/oauthserver/controller/client/PhabricatorOAuthClientSecretController.php
+++ b/src/applications/oauthserver/controller/client/PhabricatorOAuthClientSecretController.php
@@ -50,11 +50,11 @@ final class PhabricatorOAuthClientSecretController
 
     if ($is_serious) {
       $body = pht(
-        'The secret associated with this oauth application will be shown in '.
+        'The secret associated with this OAuth application will be shown in '.
         'plain text on your screen.');
     } else {
       $body = pht(
-        'The secret associated with this oauth application will be shown in '.
+        'The secret associated with this OAuth application will be shown in '.
         'plain text on your screen. Before continuing, wrap your arms around '.
         'your monitor to create a human shield, keeping it safe from prying '.
         'eyes. Protect company secrets!');
diff --git a/src/applications/oauthserver/panel/PhabricatorOAuthServerAuthorizationsSettingsPanel.php b/src/applications/oauthserver/panel/PhabricatorOAuthServerAuthorizationsSettingsPanel.php
index 8504c97ce1..2e2cff1742 100644
--- a/src/applications/oauthserver/panel/PhabricatorOAuthServerAuthorizationsSettingsPanel.php
+++ b/src/applications/oauthserver/panel/PhabricatorOAuthServerAuthorizationsSettingsPanel.php
@@ -16,8 +16,8 @@ final class PhabricatorOAuthServerAuthorizationsSettingsPanel
   }
 
   public function isEnabled() {
-    $app_name = 'PhabricatorOAuthServerApplication';
-    return PhabricatorApplication::isClassInstalled($app_name);
+    return PhabricatorApplication::isClassInstalled(
+      'PhabricatorOAuthServerApplication');
   }
 
   public function processRequest(AphrontRequest $request) {
@@ -108,8 +108,7 @@ final class PhabricatorOAuthServerAuthorizationsSettingsPanel
 
     $table = new AphrontTableView($rows);
     $table->setNoDataString(
-      pht(
-        "You haven't authorized any OAuth applications."));
+      pht("You haven't authorized any OAuth applications."));
 
     $table->setRowClasses($rowc);
     $table->setHeaders(
diff --git a/src/applications/owners/conduit/OwnersQueryConduitAPIMethod.php b/src/applications/owners/conduit/OwnersQueryConduitAPIMethod.php
index f62c456283..5473ec6e00 100644
--- a/src/applications/owners/conduit/OwnersQueryConduitAPIMethod.php
+++ b/src/applications/owners/conduit/OwnersQueryConduitAPIMethod.php
@@ -7,10 +7,11 @@ final class OwnersQueryConduitAPIMethod extends OwnersConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Query for packages by one of the following: repository/path, '.
+    return pht(
+      'Query for packages by one of the following: repository/path, '.
       'packages with a given user or project owner, or packages affiliated '.
       'with a user (owned by either the user or a project they are a member '.
-      'of.) You should only provide at most one search query.';
+      'of.) You should only provide at most one search query.');
   }
 
   protected function defineParamTypes() {
@@ -29,11 +30,11 @@ final class OwnersQueryConduitAPIMethod extends OwnersConduitAPIMethod {
 
   protected function defineErrorTypes() {
     return array(
-      'ERR-INVALID-USAGE' =>
+      'ERR-INVALID-USAGE' => pht(
         'Provide one of a single owner phid (user/project), a single '.
-        'affiliated user phid (user), or a repository/path.',
-      'ERR-INVALID-PARAMETER' => 'parameter should be a phid',
-      'ERR_REP_NOT_FOUND'  => 'The repository callsign is not recognized',
+        'affiliated user phid (user), or a repository/path.'),
+      'ERR-INVALID-PARAMETER' => pht('Parameter should be a phid.'),
+      'ERR_REP_NOT_FOUND'  => pht('The repository callsign is not recognized.'),
     );
   }
 
@@ -49,7 +50,9 @@ final class OwnersQueryConduitAPIMethod extends OwnersConduitAPIMethod {
     if (!$is_valid_phid) {
       throw id(new ConduitException('ERR-INVALID-PARAMETER'))
         ->setErrorDescription(
-          'Expected user/project PHID for owner, got '.$owner);
+          pht(
+            'Expected user/project PHID for owner, got %s.',
+            $owner));
     }
 
     $owners = id(new PhabricatorOwnersOwner())->loadAllWhere(
@@ -77,7 +80,9 @@ final class OwnersQueryConduitAPIMethod extends OwnersConduitAPIMethod {
     if (!$repository) {
       throw id(new ConduitException('ERR_REP_NOT_FOUND'))
         ->setErrorDescription(
-          'Repository callsign '.$repo_callsign.' not recognized');
+          pht(
+            'Repository callsign %s not recognized',
+            $repo_callsign));
     }
     if ($path == null) {
       return PhabricatorOwnersPackage::loadPackagesForRepository($repository);
diff --git a/src/applications/owners/controller/PhabricatorOwnersDeleteController.php b/src/applications/owners/controller/PhabricatorOwnersDeleteController.php
index 4f14ddf66a..7b275b7407 100644
--- a/src/applications/owners/controller/PhabricatorOwnersDeleteController.php
+++ b/src/applications/owners/controller/PhabricatorOwnersDeleteController.php
@@ -26,11 +26,13 @@ final class PhabricatorOwnersDeleteController
       return id(new AphrontRedirectResponse())->setURI('/owners/');
     }
 
-    $text = pht('Are you sure you want to delete the "%s" package? This '.
-          'operation can not be undone.', $package->getName());
+    $text = pht(
+      'Are you sure you want to delete the "%s" package? This '.
+      'operation can not be undone.',
+      $package->getName());
     $dialog = id(new AphrontDialogView())
       ->setUser($user)
-      ->setTitle('Really delete this package?')
+      ->setTitle(pht('Really delete this package?'))
       ->appendChild(phutil_tag('p', array(), $text))
       ->addSubmitButton(pht('Delete'))
       ->addCancelButton('/owners/package/'.$package->getID().'/')
diff --git a/src/applications/owners/controller/PhabricatorOwnersEditController.php b/src/applications/owners/controller/PhabricatorOwnersEditController.php
index 34bf513737..3a0baaa06e 100644
--- a/src/applications/owners/controller/PhabricatorOwnersEditController.php
+++ b/src/applications/owners/controller/PhabricatorOwnersEditController.php
@@ -197,10 +197,11 @@ final class PhabricatorOwnersEditController
           ->setName('auditing')
           ->setLabel(pht('Auditing'))
           ->setCaption(
-            pht('With auditing enabled, all future commits that touch '.
-                'this package will be reviewed to make sure an owner '.
-                'of the package is involved and the commit message has '.
-                'a valid revision, reviewed by, and author.'))
+            pht(
+              'With auditing enabled, all future commits that touch '.
+              'this package will be reviewed to make sure an owner '.
+              'of the package is involved and the commit message has '.
+              'a valid revision, reviewed by, and author.'))
           ->setOptions(array(
             'disabled'  => pht('Disabled'),
             'enabled'   => pht('Enabled'),
@@ -223,8 +224,9 @@ final class PhabricatorOwnersEditController
               ),
               pht('Add New Path')))
           ->setDescription(
-            pht('Specify the files and directories which comprise '.
-                'this package.'))
+            pht(
+              'Specify the files and directories which comprise '.
+              'this package.'))
           ->setContent(javelin_tag(
               'table',
               array(
diff --git a/src/applications/owners/mail/OwnersPackageReplyHandler.php b/src/applications/owners/mail/OwnersPackageReplyHandler.php
index b0f397249e..0e28ff12b1 100644
--- a/src/applications/owners/mail/OwnersPackageReplyHandler.php
+++ b/src/applications/owners/mail/OwnersPackageReplyHandler.php
@@ -3,7 +3,10 @@
 final class OwnersPackageReplyHandler extends PhabricatorMailReplyHandler {
   public function validateMailReceiver($mail_receiver) {
     if (!($mail_receiver instanceof PhabricatorOwnersPackage)) {
-      throw new Exception('Receiver is not a PhabricatorOwnersPackage!');
+      throw new Exception(
+        pht(
+          'Receiver is not a %s!',
+          'PhabricatorOwnersPackage'));
     }
   }
 
diff --git a/src/applications/owners/mail/PackageCreateMail.php b/src/applications/owners/mail/PackageCreateMail.php
index 486704afd8..7f447d7d88 100644
--- a/src/applications/owners/mail/PackageCreateMail.php
+++ b/src/applications/owners/mail/PackageCreateMail.php
@@ -7,6 +7,6 @@ final class PackageCreateMail extends PackageMail {
   }
 
   protected function getVerb() {
-    return 'Created';
+    return pht('Created');
   }
 }
diff --git a/src/applications/owners/mail/PackageDeleteMail.php b/src/applications/owners/mail/PackageDeleteMail.php
index 8d992b3fb8..002fa04981 100644
--- a/src/applications/owners/mail/PackageDeleteMail.php
+++ b/src/applications/owners/mail/PackageDeleteMail.php
@@ -3,7 +3,7 @@
 final class PackageDeleteMail extends PackageMail {
 
   protected function getVerb() {
-    return 'Deleted';
+    return pht('Deleted');
   }
 
   protected function isNewThread() {
diff --git a/src/applications/owners/mail/PackageMail.php b/src/applications/owners/mail/PackageMail.php
index 00a8b196f6..683f608128 100644
--- a/src/applications/owners/mail/PackageMail.php
+++ b/src/applications/owners/mail/PackageMail.php
@@ -43,11 +43,13 @@ abstract class PackageMail extends PhabricatorMail {
   final protected function renderRepoSubSection($repository_phid, $paths) {
     $handles = $this->getHandles();
     $section = array();
-    $section[] = '  In repository '.$handles[$repository_phid]->getName().
+    $section[] = '  '.
+      pht('In repository %s', $handles[$repository_phid]->getName()).
       ' - '.PhabricatorEnv::getProductionURI($handles[$repository_phid]
       ->getURI());
     foreach ($paths as $path => $excluded) {
-      $section[] = '    '.($excluded ? 'Excluded' : 'Included').' '.$path;
+      $section[] = '    '.
+        ($excluded ? pht('Excluded') : pht('Included')).' '.$path;
     }
 
     return implode("\n", $section);
@@ -94,7 +96,7 @@ abstract class PackageMail extends PhabricatorMail {
       strtolower($this->getVerb()).' '.$this->renderPackageTitle().'.';
     $section[] = '';
 
-    $section[] = 'PACKAGE DETAIL';
+    $section[] = pht('PACKAGE DETAIL');
     $section[] = '  '.PhabricatorEnv::getProductionURI(
       '/owners/package/'.$package->getID().'/');
 
@@ -102,14 +104,14 @@ abstract class PackageMail extends PhabricatorMail {
   }
 
   protected function renderDescriptionSection() {
-    return "PACKAGE DESCRIPTION\n".
-      '  '.$this->getPackage()->getDescription();
+    return pht('PACKAGE DESCRIPTION')."\n  ".
+      $this->getPackage()->getDescription();
   }
 
   protected function renderPrimaryOwnerSection() {
     $handles = $this->getHandles();
-    return "PRIMARY OWNER\n".
-      '  '.$handles[$this->getPackage()->getPrimaryOwnerPHID()]->getName();
+    return pht('PRIMARY OWNER')."\n  ".
+      $handles[$this->getPackage()->getPrimaryOwnerPHID()]->getName();
   }
 
   protected function renderOwnersSection() {
@@ -122,18 +124,19 @@ abstract class PackageMail extends PhabricatorMail {
     $owners = mpull($owners, 'getUserPHID');
     $owners = array_select_keys($handles, $owners);
     $owners = mpull($owners, 'getName');
-    return "OWNERS\n".
-      '  '.implode(', ', $owners);
+    return pht('OWNERS')."\n  ".implode(', ', $owners);
   }
 
   protected function renderAuditingEnabledSection() {
-    return "AUDITING ENABLED STATUS\n".
-      '  '.($this->getPackage()->getAuditingEnabled() ? 'Enabled' : 'Disabled');
+    return pht('AUDITING ENABLED STATUS')."\n  ".
+      ($this->getPackage()->getAuditingEnabled()
+        ? pht('Enabled')
+        : pht('Disabled'));
   }
 
   protected function renderPathsSection() {
     $section = array();
-    $section[] = 'PATHS';
+    $section[] = pht('PATHS');
     foreach ($this->paths as $repository_phid => $paths) {
       $section[] = $this->renderRepoSubSection($repository_phid, $paths);
     }
diff --git a/src/applications/owners/mail/PackageModifyMail.php b/src/applications/owners/mail/PackageModifyMail.php
index 206fece688..cd96fb0c70 100644
--- a/src/applications/owners/mail/PackageModifyMail.php
+++ b/src/applications/owners/mail/PackageModifyMail.php
@@ -29,7 +29,7 @@ final class PackageModifyMail extends PackageMail {
   }
 
   protected function getVerb() {
-    return 'Modified';
+    return pht('Modified');
   }
 
   protected function isNewThread() {
@@ -80,10 +80,10 @@ final class PackageModifyMail extends PackageMail {
     }
 
     $section = array();
-    $section[] = 'PRIMARY OWNER CHANGE';
-    $section[] = '  Old owner: '.
+    $section[] = pht('PRIMARY OWNER CHANGE');
+    $section[] = '  '.pht('Old owner:').' '.
       $handles[$old_primary_owner_phid]->getName();
-    $section[] = '  New owner: '.
+    $section[] = '  '.pht('New owner:').' '.
       $handles[$primary_owner_phid]->getName();
 
     return implode("\n", $section);
@@ -98,7 +98,7 @@ final class PackageModifyMail extends PackageMail {
     if ($add_owners) {
       $add_owners = array_select_keys($handles, $add_owners);
       $add_owners = mpull($add_owners, 'getName');
-      $section[] = 'ADDED OWNERS';
+      $section[] = pht('ADDED OWNERS');
       $section[] = '  '.implode(', ', $add_owners);
     }
 
@@ -108,7 +108,7 @@ final class PackageModifyMail extends PackageMail {
       }
       $remove_owners = array_select_keys($handles, $remove_owners);
       $remove_owners = mpull($remove_owners, 'getName');
-      $section[] = 'REMOVED OWNERS';
+      $section[] = pht('REMOVED OWNERS');
       $section[] = '  '.implode(', ', $remove_owners);
     }
 
@@ -128,18 +128,18 @@ final class PackageModifyMail extends PackageMail {
     }
 
     $section = array();
-    $section[] = 'AUDITING ENABLED STATUS CHANGE';
-    $section[] = '  Old value: '.
-      ($old_auditing_enabled ? 'Enabled' : 'Disabled');
-    $section[] = '  New value: '.
-      ($auditing_enabled ? 'Enabled' : 'Disabled');
+    $section[] = pht('AUDITING ENABLED STATUS CHANGE');
+    $section[] = '  '.pht('Old value:').' '.
+      ($old_auditing_enabled ? pht('Enabled') : pht('Disabled'));
+    $section[] = '  '.pht('New value:').' '.
+      ($auditing_enabled ? pht('Enabled') : pht('Disabled'));
     return implode("\n", $section);
   }
 
   protected function renderPathsSection() {
     $section = array();
     if ($this->addPaths) {
-      $section[] = 'ADDED PATHS';
+      $section[] = pht('ADDED PATHS');
       foreach ($this->addPaths as $repository_phid => $paths) {
         $section[] = $this->renderRepoSubSection($repository_phid, $paths);
       }
@@ -149,7 +149,7 @@ final class PackageModifyMail extends PackageMail {
       if ($this->addPaths) {
         $section[] = '';
       }
-      $section[] = 'REMOVED PATHS';
+      $section[] = pht('REMOVED PATHS');
       foreach ($this->removePaths as $repository_phid => $paths) {
         $section[] = $this->renderRepoSubSection($repository_phid, $paths);
       }
diff --git a/src/applications/passphrase/controller/PassphraseCredentialConduitController.php b/src/applications/passphrase/controller/PassphraseCredentialConduitController.php
index cea1aeac6a..4c65b5d07d 100644
--- a/src/applications/passphrase/controller/PassphraseCredentialConduitController.php
+++ b/src/applications/passphrase/controller/PassphraseCredentialConduitController.php
@@ -60,8 +60,8 @@ final class PassphraseCredentialConduitController
         ->appendChild(
           pht(
             'This credential and its secret will no longer be able '.
-            'to be retrieved using the `passphrase.query` method '.
-            'in Conduit.'))
+            'to be retrieved using the `%s` method in Conduit.',
+            'passphrase.query'))
         ->addSubmitButton(pht('Prevent Conduit Access'))
         ->addCancelButton($view_uri);
     } else {
@@ -70,7 +70,7 @@ final class PassphraseCredentialConduitController
         ->appendChild(
           pht(
             'This credential will be able to be retrieved via the Conduit '.
-            'API by users who have access to this credential.  You should '.
+            'API by users who have access to this credential. You should '.
             'only enable this for credentials which need to be accessed '.
             'programmatically (such as from build agents).'))
         ->addSubmitButton(pht('Allow Conduit Access'))
diff --git a/src/applications/passphrase/credentialtype/PassphraseCredentialTypeSSHPrivateKeyText.php b/src/applications/passphrase/credentialtype/PassphraseCredentialTypeSSHPrivateKeyText.php
index dc2b80a857..c197d7eae0 100644
--- a/src/applications/passphrase/credentialtype/PassphraseCredentialTypeSSHPrivateKeyText.php
+++ b/src/applications/passphrase/credentialtype/PassphraseCredentialTypeSSHPrivateKeyText.php
@@ -45,9 +45,11 @@ final class PassphraseCredentialTypeSSHPrivateKeyText
     if (!Filesystem::binaryExists('ssh-keygen')) {
       throw new Exception(
         pht(
-          'Decrypting SSH keys requires the `ssh-keygen` binary, but it '.
-          'is not available in PATH. Either make it available or strip the '.
-          'password fromt his SSH key manually before uploading it.'));
+          'Decrypting SSH keys requires the `%s` binary, but it '.
+          'is not available in %s. Either make it available or strip the '.
+          'password fromt his SSH key manually before uploading it.',
+          'ssh-keygen',
+          '$PATH'));
     }
 
     list($err, $stdout, $stderr) = exec_manual(
diff --git a/src/applications/paste/conduit/PasteCreateConduitAPIMethod.php b/src/applications/paste/conduit/PasteCreateConduitAPIMethod.php
index 0c09109a2c..379f5b6e8d 100644
--- a/src/applications/paste/conduit/PasteCreateConduitAPIMethod.php
+++ b/src/applications/paste/conduit/PasteCreateConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class PasteCreateConduitAPIMethod extends PasteConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Create a new paste.';
+    return pht('Create a new paste.');
   }
 
   protected function defineParamTypes() {
@@ -24,7 +24,7 @@ final class PasteCreateConduitAPIMethod extends PasteConduitAPIMethod {
 
   protected function defineErrorTypes() {
     return array(
-      'ERR-NO-PASTE' => 'Paste may not be empty.',
+      'ERR-NO-PASTE' => pht('Paste may not be empty.'),
     );
   }
 
@@ -37,7 +37,7 @@ final class PasteCreateConduitAPIMethod extends PasteConduitAPIMethod {
       throw new ConduitException('ERR-NO-PASTE');
     }
 
-    $title = nonempty($title, 'Masterwork From Distant Lands');
+    $title = nonempty($title, pht('Masterwork From Distant Lands'));
     $language = nonempty($language, '');
 
     $viewer = $request->getUser();
diff --git a/src/applications/paste/conduit/PasteInfoConduitAPIMethod.php b/src/applications/paste/conduit/PasteInfoConduitAPIMethod.php
index ea39b9c18c..e34583e76a 100644
--- a/src/applications/paste/conduit/PasteInfoConduitAPIMethod.php
+++ b/src/applications/paste/conduit/PasteInfoConduitAPIMethod.php
@@ -11,11 +11,11 @@ final class PasteInfoConduitAPIMethod extends PasteConduitAPIMethod {
   }
 
   public function getMethodStatusDescription() {
-    return "Replaced by 'paste.query'.";
+    return pht("Replaced by '%s'.", 'paste.query');
   }
 
   public function getMethodDescription() {
-    return 'Retrieve an array of information about a paste.';
+    return pht('Retrieve an array of information about a paste.');
   }
 
   protected function defineParamTypes() {
@@ -30,7 +30,7 @@ final class PasteInfoConduitAPIMethod extends PasteConduitAPIMethod {
 
   protected function defineErrorTypes() {
     return array(
-      'ERR_BAD_PASTE' => 'No such paste exists',
+      'ERR_BAD_PASTE' => pht('No such paste exists.'),
     );
   }
 
diff --git a/src/applications/paste/conduit/PasteQueryConduitAPIMethod.php b/src/applications/paste/conduit/PasteQueryConduitAPIMethod.php
index b03079245a..6f3f87acf2 100644
--- a/src/applications/paste/conduit/PasteQueryConduitAPIMethod.php
+++ b/src/applications/paste/conduit/PasteQueryConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class PasteQueryConduitAPIMethod extends PasteConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Query Pastes.';
+    return pht('Query Pastes.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/paste/mail/PasteReplyHandler.php b/src/applications/paste/mail/PasteReplyHandler.php
index b8c498b76e..6a58eb64e6 100644
--- a/src/applications/paste/mail/PasteReplyHandler.php
+++ b/src/applications/paste/mail/PasteReplyHandler.php
@@ -5,7 +5,8 @@ final class PasteReplyHandler
 
   public function validateMailReceiver($mail_receiver) {
     if (!($mail_receiver instanceof PhabricatorPaste)) {
-      throw new Exception('Mail receiver is not a PhabricatorPaste.');
+      throw new Exception(
+        pht('Mail receiver is not a %s.', 'PhabricatorPaste'));
     }
   }
 
diff --git a/src/applications/people/conduit/UserDisableConduitAPIMethod.php b/src/applications/people/conduit/UserDisableConduitAPIMethod.php
index 6d9850a8ab..3512d3f742 100644
--- a/src/applications/people/conduit/UserDisableConduitAPIMethod.php
+++ b/src/applications/people/conduit/UserDisableConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class UserDisableConduitAPIMethod extends UserConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Permanently disable specified users (admin only).';
+    return pht('Permanently disable specified users (admin only).');
   }
 
   protected function defineParamTypes() {
@@ -22,8 +22,8 @@ final class UserDisableConduitAPIMethod extends UserConduitAPIMethod {
 
   protected function defineErrorTypes() {
     return array(
-      'ERR-PERMISSIONS' => 'Only admins can call this method.',
-      'ERR-BAD-PHID' => 'Non existent user PHID.',
+      'ERR-PERMISSIONS' => pht('Only admins can call this method.'),
+      'ERR-BAD-PHID' => pht('Non existent user PHID.'),
     );
   }
 
diff --git a/src/applications/people/conduit/UserEnableConduitAPIMethod.php b/src/applications/people/conduit/UserEnableConduitAPIMethod.php
index e29ce3ca61..f7cb117df6 100644
--- a/src/applications/people/conduit/UserEnableConduitAPIMethod.php
+++ b/src/applications/people/conduit/UserEnableConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class UserEnableConduitAPIMethod extends UserConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Re-enable specified users (admin only).';
+    return pht('Re-enable specified users (admin only).');
   }
 
   protected function defineParamTypes() {
@@ -22,8 +22,8 @@ final class UserEnableConduitAPIMethod extends UserConduitAPIMethod {
 
   protected function defineErrorTypes() {
     return array(
-      'ERR-PERMISSIONS' => 'Only admins can call this method.',
-      'ERR-BAD-PHID' => 'Non existent user PHID.',
+      'ERR-PERMISSIONS' => pht('Only admins can call this method.'),
+      'ERR-BAD-PHID' => pht('Non existent user PHID.'),
     );
   }
 
diff --git a/src/applications/people/conduit/UserFindConduitAPIMethod.php b/src/applications/people/conduit/UserFindConduitAPIMethod.php
index 06f124d3a3..2390abad06 100644
--- a/src/applications/people/conduit/UserFindConduitAPIMethod.php
+++ b/src/applications/people/conduit/UserFindConduitAPIMethod.php
@@ -11,11 +11,11 @@ final class UserFindConduitAPIMethod extends UserConduitAPIMethod {
   }
 
   public function getMethodStatusDescription() {
-    return pht('Obsoleted by "user.query".');
+    return pht('Obsoleted by "%s".', 'user.query');
   }
 
   public function getMethodDescription() {
-    return pht('Lookup PHIDs by username. Obsoleted by "user.query".');
+    return pht('Lookup PHIDs by username. Obsoleted by "%s".', 'user.query');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/people/conduit/UserQueryConduitAPIMethod.php b/src/applications/people/conduit/UserQueryConduitAPIMethod.php
index 4a567a0158..c42414a6be 100644
--- a/src/applications/people/conduit/UserQueryConduitAPIMethod.php
+++ b/src/applications/people/conduit/UserQueryConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class UserQueryConduitAPIMethod extends UserConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Query users.';
+    return pht('Query users.');
   }
 
   protected function defineParamTypes() {
@@ -28,7 +28,7 @@ final class UserQueryConduitAPIMethod extends UserConduitAPIMethod {
 
   protected function defineErrorTypes() {
     return array(
-      'ERR-INVALID-PARAMETER' => 'Missing or malformed parameter.',
+      'ERR-INVALID-PARAMETER' => pht('Missing or malformed parameter.'),
     );
   }
 
diff --git a/src/applications/people/conduit/UserWhoAmIConduitAPIMethod.php b/src/applications/people/conduit/UserWhoAmIConduitAPIMethod.php
index b646246c5d..13884e1e83 100644
--- a/src/applications/people/conduit/UserWhoAmIConduitAPIMethod.php
+++ b/src/applications/people/conduit/UserWhoAmIConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class UserWhoAmIConduitAPIMethod extends UserConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Retrieve information about the logged-in user.';
+    return pht('Retrieve information about the logged-in user.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/people/controller/PhabricatorPeopleApproveController.php b/src/applications/people/controller/PhabricatorPeopleApproveController.php
index bbf69f23f8..a906b15655 100644
--- a/src/applications/people/controller/PhabricatorPeopleApproveController.php
+++ b/src/applications/people/controller/PhabricatorPeopleApproveController.php
@@ -33,11 +33,13 @@ final class PhabricatorPeopleApproveController
         'Phabricator Account "%s" Approved',
         $user->getUsername());
 
-      $body = pht(
-        "Your Phabricator account (%s) has been approved by %s. You can ".
-        "login here:\n\n  %s\n\n",
-        $user->getUsername(),
-        $admin->getUsername(),
+      $body = sprintf(
+        "%s\n\n  %s\n\n",
+        pht(
+          'Your Phabricator account (%s) has been approved by %s. You can '.
+          'login here:',
+          $user->getUsername(),
+          $admin->getUsername()),
         PhabricatorEnv::getProductionURI('/'));
 
       $mail = id(new PhabricatorMetaMTAMail())
diff --git a/src/applications/people/controller/PhabricatorPeopleDeleteController.php b/src/applications/people/controller/PhabricatorPeopleDeleteController.php
index fcd819e06b..e95dd4c646 100644
--- a/src/applications/people/controller/PhabricatorPeopleDeleteController.php
+++ b/src/applications/people/controller/PhabricatorPeopleDeleteController.php
@@ -44,8 +44,7 @@ final class PhabricatorPeopleDeleteController
       'so on), but less safe to delete established users. If possible, '.
       'disable them instead.');
 
-    $str4 = pht(
-      'To permanently destroy this user, run this command:');
+    $str4 = pht('To permanently destroy this user, run this command:');
 
     $form = id(new AphrontFormView())
       ->setUser($admin)
@@ -73,9 +72,7 @@ final class PhabricatorPeopleDeleteController
         pht(
           'As you stare into the gaping maw of the abyss, something '.
           'holds you back.'))
-      ->appendParagraph(
-        pht(
-          'You can not delete your own account.'))
+      ->appendParagraph(pht('You can not delete your own account.'))
       ->addCancelButton($profile_uri, pht('Turn Back'));
   }
 
diff --git a/src/applications/people/controller/PhabricatorPeopleDisableController.php b/src/applications/people/controller/PhabricatorPeopleDisableController.php
index a1715dffda..7ef4099709 100644
--- a/src/applications/people/controller/PhabricatorPeopleDisableController.php
+++ b/src/applications/people/controller/PhabricatorPeopleDisableController.php
@@ -41,8 +41,7 @@ final class PhabricatorPeopleDisableController
         ->setTitle(pht('Something Stays Your Hand'))
         ->appendParagraph(
           pht(
-            'Try as you might, you find you can not disable your '.
-            'own account.'))
+            'Try as you might, you find you can not disable your own account.'))
         ->addCancelButton($done_uri, pht('Curses!'));
     }
 
diff --git a/src/applications/people/controller/PhabricatorPeopleFeedController.php b/src/applications/people/controller/PhabricatorPeopleFeedController.php
index 5907ae4a1e..64a443cabe 100644
--- a/src/applications/people/controller/PhabricatorPeopleFeedController.php
+++ b/src/applications/people/controller/PhabricatorPeopleFeedController.php
@@ -38,8 +38,9 @@ final class PhabricatorPeopleFeedController
     $builder = new PhabricatorFeedBuilder($stories);
     $builder->setUser($viewer);
     $builder->setShowHovercards(true);
-    $builder->setNoDataString(pht('To begin on such a grand journey, '.
-      'requires but just a single step.'));
+    $builder->setNoDataString(
+      pht(
+        'To begin on such a grand journey, requires but just a single step.'));
     $view = $builder->buildView();
 
     $feed = phutil_tag_div(
diff --git a/src/applications/people/controller/PhabricatorPeopleLdapController.php b/src/applications/people/controller/PhabricatorPeopleLdapController.php
index 22cb29be02..6f5fa09f3f 100644
--- a/src/applications/people/controller/PhabricatorPeopleLdapController.php
+++ b/src/applications/people/controller/PhabricatorPeopleLdapController.php
@@ -26,7 +26,7 @@ final class PhabricatorPeopleLdapController
       ->appendChild(
         id(new AphrontFormTextControl())
           ->setLabel(pht('LDAP query'))
-          ->setCaption(pht('A filter such as (objectClass=*)'))
+          ->setCaption(pht('A filter such as %s.', '(objectClass=*)'))
           ->setName('query'))
       ->appendChild(
         id(new AphrontFormSubmitControl())
@@ -131,7 +131,7 @@ final class PhabricatorPeopleLdapController
 
     $ldap_provider = PhabricatorLDAPAuthProvider::getLDAPProvider();
     if (!$ldap_provider) {
-      throw new Exception('No LDAP provider enabled!');
+      throw new Exception(pht('No LDAP provider enabled!'));
     }
 
     $ldap_adapter = $ldap_provider->getAdapter();
diff --git a/src/applications/people/controller/PhabricatorPeopleNewController.php b/src/applications/people/controller/PhabricatorPeopleNewController.php
index 21dce04192..93f9c42faa 100644
--- a/src/applications/people/controller/PhabricatorPeopleNewController.php
+++ b/src/applications/people/controller/PhabricatorPeopleNewController.php
@@ -123,12 +123,10 @@ final class PhabricatorPeopleNewController
 
     if ($is_bot) {
       $form->appendRemarkupInstructions(
-        pht(
-          'You are creating a new **bot/script** user account.'));
+        pht('You are creating a new **bot/script** user account.'));
     } else {
       $form->appendRemarkupInstructions(
-        pht(
-          'You are creating a new **standard** user account.'));
+        pht('You are creating a new **standard** user account.'));
     }
 
     $form
diff --git a/src/applications/people/controller/PhabricatorPeopleWelcomeController.php b/src/applications/people/controller/PhabricatorPeopleWelcomeController.php
index 7b0131a4b5..b3762e67c9 100644
--- a/src/applications/people/controller/PhabricatorPeopleWelcomeController.php
+++ b/src/applications/people/controller/PhabricatorPeopleWelcomeController.php
@@ -40,9 +40,7 @@ final class PhabricatorPeopleWelcomeController
           'The email contains a link to log in to their account. Sending '.
           'another copy of the email can be useful if the original was lost '.
           'or never sent.'))
-      ->appendParagraph(
-        pht(
-          'The email will identify you as the sender.'))
+      ->appendParagraph(pht('The email will identify you as the sender.'))
       ->addSubmitButton(pht('Send Email'))
       ->addCancelButton($profile_uri);
   }
diff --git a/src/applications/people/editor/PhabricatorUserEditor.php b/src/applications/people/editor/PhabricatorUserEditor.php
index 3a3ccdc351..cc34696f2d 100644
--- a/src/applications/people/editor/PhabricatorUserEditor.php
+++ b/src/applications/people/editor/PhabricatorUserEditor.php
@@ -27,7 +27,7 @@ final class PhabricatorUserEditor extends PhabricatorEditor {
     $allow_reassign = false) {
 
     if ($user->getID()) {
-      throw new Exception('User has already been created!');
+      throw new Exception(pht('User has already been created!'));
     }
 
     $is_reassign = false;
@@ -35,18 +35,17 @@ final class PhabricatorUserEditor extends PhabricatorEditor {
       if ($allow_reassign) {
         if ($email->getIsPrimary()) {
           throw new Exception(
-            pht(
-              'Primary email addresses can not be reassigned.'));
+            pht('Primary email addresses can not be reassigned.'));
         }
         $is_reassign = true;
       } else {
-        throw new Exception('Email has already been created!');
+        throw new Exception(pht('Email has already been created!'));
       }
     }
 
     if (!PhabricatorUser::validateUsername($user->getUsername())) {
       $valid = PhabricatorUser::describeValidUsername();
-      throw new Exception("Username is invalid! {$valid}");
+      throw new Exception(pht('Username is invalid! %s', $valid));
     }
 
     // Always set a new user's email address to primary.
@@ -107,8 +106,9 @@ final class PhabricatorUserEditor extends PhabricatorEditor {
   public function updateUser(
     PhabricatorUser $user,
     PhabricatorUserEmail $email = null) {
+
     if (!$user->getID()) {
-      throw new Exception('User has not been created yet!');
+      throw new Exception(pht('User has not been created yet!'));
     }
 
     $user->openTransaction();
@@ -137,7 +137,7 @@ final class PhabricatorUserEditor extends PhabricatorEditor {
     PhutilOpaqueEnvelope $envelope) {
 
     if (!$user->getID()) {
-      throw new Exception('User has not been created yet!');
+      throw new Exception(pht('User has not been created yet!'));
     }
 
     $user->openTransaction();
@@ -163,12 +163,12 @@ final class PhabricatorUserEditor extends PhabricatorEditor {
     $actor = $this->requireActor();
 
     if (!$user->getID()) {
-      throw new Exception('User has not been created yet!');
+      throw new Exception(pht('User has not been created yet!'));
     }
 
     if (!PhabricatorUser::validateUsername($username)) {
       $valid = PhabricatorUser::describeValidUsername();
-      throw new Exception("Username is invalid! {$valid}");
+      throw new Exception(pht('Username is invalid! %s', $valid));
     }
 
     $old_username = $user->getUsername();
@@ -209,7 +209,7 @@ final class PhabricatorUserEditor extends PhabricatorEditor {
     $actor = $this->requireActor();
 
     if (!$user->getID()) {
-      throw new Exception('User has not been created yet!');
+      throw new Exception(pht('User has not been created yet!'));
     }
 
     $user->openTransaction();
@@ -247,7 +247,7 @@ final class PhabricatorUserEditor extends PhabricatorEditor {
     $actor = $this->requireActor();
 
     if (!$user->getID()) {
-      throw new Exception('User has not been created yet!');
+      throw new Exception(pht('User has not been created yet!'));
     }
 
     $user->openTransaction();
@@ -286,7 +286,7 @@ final class PhabricatorUserEditor extends PhabricatorEditor {
     $actor = $this->requireActor();
 
     if (!$user->getID()) {
-      throw new Exception('User has not been created yet!');
+      throw new Exception(pht('User has not been created yet!'));
     }
 
     $user->openTransaction();
@@ -325,7 +325,7 @@ final class PhabricatorUserEditor extends PhabricatorEditor {
     $actor = $this->requireActor();
 
     if (!$user->getID()) {
-      throw new Exception('User has not been created yet!');
+      throw new Exception(pht('User has not been created yet!'));
     }
 
     $user->openTransaction();
@@ -370,10 +370,10 @@ final class PhabricatorUserEditor extends PhabricatorEditor {
     $actor = $this->requireActor();
 
     if (!$user->getID()) {
-      throw new Exception('User has not been created yet!');
+      throw new Exception(pht('User has not been created yet!'));
     }
     if ($email->getID()) {
-      throw new Exception('Email has already been created!');
+      throw new Exception(pht('Email has already been created!'));
     }
 
     // Use changePrimaryEmail() to change primary email.
@@ -420,10 +420,10 @@ final class PhabricatorUserEditor extends PhabricatorEditor {
     $actor = $this->requireActor();
 
     if (!$user->getID()) {
-      throw new Exception('User has not been created yet!');
+      throw new Exception(pht('User has not been created yet!'));
     }
     if (!$email->getID()) {
-      throw new Exception('Email has not been created yet!');
+      throw new Exception(pht('Email has not been created yet!'));
     }
 
     $user->openTransaction();
@@ -433,10 +433,10 @@ final class PhabricatorUserEditor extends PhabricatorEditor {
         $email->reload();
 
         if ($email->getIsPrimary()) {
-          throw new Exception("Can't remove primary email!");
+          throw new Exception(pht("Can't remove primary email!"));
         }
         if ($email->getUserPHID() != $user->getPHID()) {
-          throw new Exception('Email not owned by user!');
+          throw new Exception(pht('Email not owned by user!'));
         }
 
         $email->delete();
@@ -466,10 +466,10 @@ final class PhabricatorUserEditor extends PhabricatorEditor {
     $actor = $this->requireActor();
 
     if (!$user->getID()) {
-      throw new Exception('User has not been created yet!');
+      throw new Exception(pht('User has not been created yet!'));
     }
     if (!$email->getID()) {
-      throw new Exception('Email has not been created yet!');
+      throw new Exception(pht('Email has not been created yet!'));
     }
 
     $user->openTransaction();
@@ -479,15 +479,15 @@ final class PhabricatorUserEditor extends PhabricatorEditor {
         $email->reload();
 
         if ($email->getUserPHID() != $user->getPHID()) {
-          throw new Exception('User does not own email!');
+          throw new Exception(pht('User does not own email!'));
         }
 
         if ($email->getIsPrimary()) {
-          throw new Exception('Email is already primary!');
+          throw new Exception(pht('Email is already primary!'));
         }
 
         if (!$email->getIsVerified()) {
-          throw new Exception('Email is not verified!');
+          throw new Exception(pht('Email is not verified!'));
         }
 
         $old_primary = $user->loadPrimaryEmail();
@@ -538,10 +538,10 @@ final class PhabricatorUserEditor extends PhabricatorEditor {
     $actor = $this->requireActor();
 
     if (!$user->getID()) {
-      throw new Exception('User has not been created yet!');
+      throw new Exception(pht('User has not been created yet!'));
     }
     if (!$email->getID()) {
-      throw new Exception('Email has not been created yet!');
+      throw new Exception(pht('Email has not been created yet!'));
     }
 
     $user->openTransaction();
@@ -610,13 +610,11 @@ final class PhabricatorUserEditor extends PhabricatorEditor {
         if ($old_user != $user->getPHID()) {
           if ($email->getIsVerified()) {
             throw new Exception(
-              pht(
-                'Verified email addresses can not be reassigned.'));
+              pht('Verified email addresses can not be reassigned.'));
           }
           if ($email->getIsPrimary()) {
             throw new Exception(
-              pht(
-                'Primary email addresses can not be reassigned.'));
+              pht('Primary email addresses can not be reassigned.'));
           }
 
           $email->setUserPHID($user->getPHID());
diff --git a/src/applications/people/editor/__tests__/PhabricatorUserEditorTestCase.php b/src/applications/people/editor/__tests__/PhabricatorUserEditorTestCase.php
index 6cc6abf37b..ef0c58060a 100644
--- a/src/applications/people/editor/__tests__/PhabricatorUserEditorTestCase.php
+++ b/src/applications/people/editor/__tests__/PhabricatorUserEditorTestCase.php
@@ -27,9 +27,7 @@ final class PhabricatorUserEditorTestCase extends PhabricatorTestCase {
     $email = $prefix.'@evil.com@example.com';
 
     try {
-      $this->registerUser(
-        'PhabricatorUserEditorTestCaseInvalid',
-        $email);
+      $this->registerUser('PhabricatorUserEditorTestCaseInvalid', $email);
     } catch (Exception $ex) {
       $caught = $ex;
     }
diff --git a/src/applications/people/storage/PhabricatorUser.php b/src/applications/people/storage/PhabricatorUser.php
index e66a34d9a1..d69fa146d1 100644
--- a/src/applications/people/storage/PhabricatorUser.php
+++ b/src/applications/people/storage/PhabricatorUser.php
@@ -184,8 +184,9 @@ final class PhabricatorUser
   public function setPassword(PhutilOpaqueEnvelope $envelope) {
     if (!$this->getPHID()) {
       throw new Exception(
-        'You can not set a password for an unsaved user because their PHID '.
-        'is a salt component in the password hash.');
+        pht(
+          'You can not set a password for an unsaved user because their PHID '.
+          'is a salt component in the password hash.'));
     }
 
     if (!strlen($envelope->openEnvelope())) {
@@ -372,7 +373,7 @@ final class PhabricatorUser
           }
           break;
         default:
-          throw new Exception('Unknown CSRF token format!');
+          throw new Exception(pht('Unknown CSRF token format!'));
       }
     }
 
@@ -425,7 +426,7 @@ final class PhabricatorUser
   public function loadPrimaryEmailAddress() {
     $email = $this->loadPrimaryEmail();
     if (!$email) {
-      throw new Exception('User has no primary email address!');
+      throw new Exception(pht('User has no primary email address!'));
     }
     return $email->getAddress();
   }
@@ -564,36 +565,31 @@ final class PhabricatorUser
       $this->loadPrimaryEmail(),
       PhabricatorAuthSessionEngine::ONETIME_WELCOME);
 
-    $body = <<<EOBODY
-Welcome to Phabricator!
-
-{$admin_username} ({$admin_realname}) has created an account for you.
-
-  Username: {$user_username}
-
-To login to Phabricator, follow this link and set a password:
-
-  {$uri}
-
-After you have set a password, you can login in the future by going here:
-
-  {$base_uri}
-
-EOBODY;
+    $body = pht(
+      "Welcome to Phabricator!\n\n".
+      "%s (%s) has created an account for you.\n\n".
+      "  Username: %s\n\n".
+      "To login to Phabricator, follow this link and set a password:\n\n".
+      "  %s\n\n".
+      "After you have set a password, you can login in the future by ".
+      "going here:\n\n".
+      "  %s\n",
+      $admin_username,
+      $admin_realname,
+      $user_username,
+      $uri,
+      $base_uri);
 
     if (!$is_serious) {
-      $body .= <<<EOBODY
-
-Love,
-Phabricator
-
-EOBODY;
+      $body .= sprintf(
+        "\n%s\n",
+        pht("Love,\nPhabricator"));
     }
 
     $mail = id(new PhabricatorMetaMTAMail())
       ->addTos(array($this->getPHID()))
       ->setForceDelivery(true)
-      ->setSubject('[Phabricator] Welcome to Phabricator')
+      ->setSubject(pht('[Phabricator] Welcome to Phabricator'))
       ->setBody($body)
       ->saveAndSend();
   }
@@ -613,31 +609,36 @@ EOBODY;
         $this,
         null,
         PhabricatorAuthSessionEngine::ONETIME_USERNAME);
-      $password_instructions = <<<EOTXT
-If you use a password to login, you'll need to reset it before you can login
-again. You can reset your password by following this link:
-
-  {$uri}
-
-And, of course, you'll need to use your new username to login from now on. If
-you use OAuth to login, nothing should change.
-
-EOTXT;
+      $password_instructions = sprintf(
+        "%s\n\n  %s\n\n%s\n",
+        pht(
+          "If you use a password to login, you'll need to reset it ".
+          "before you can login again. You can reset your password by ".
+          "following this link:"),
+        $uri,
+        pht(
+          "And, of course, you'll need to use your new username to login ".
+          "from now on. If you use OAuth to login, nothing should change."));
     }
 
-    $body = <<<EOBODY
-{$admin_username} ({$admin_realname}) has changed your Phabricator username.
-
-  Old Username: {$old_username}
-  New Username: {$new_username}
-
-{$password_instructions}
-EOBODY;
+    $body = sprintf(
+      "%s\n\n  %s\n  %s\n\n%s",
+      pht(
+        '%s (%s) has changed your Phabricator username.',
+        $admin_username,
+        $admin_realname),
+      pht(
+        'Old Username: %s',
+        $old_username),
+      pht(
+        'New Username: %s',
+        $new_username),
+      $password_instructions);
 
     $mail = id(new PhabricatorMetaMTAMail())
       ->addTos(array($this->getPHID()))
       ->setForceDelivery(true)
-      ->setSubject('[Phabricator] Username Changed')
+      ->setSubject(pht('[Phabricator] Username Changed'))
       ->setBody($body)
       ->saveAndSend();
   }
diff --git a/src/applications/people/storage/PhabricatorUserEmail.php b/src/applications/people/storage/PhabricatorUserEmail.php
index 4ae58130a2..42946015de 100644
--- a/src/applications/people/storage/PhabricatorUserEmail.php
+++ b/src/applications/people/storage/PhabricatorUserEmail.php
@@ -83,8 +83,9 @@ final class PhabricatorUserEmail extends PhabricatorUserDAO {
    */
   public static function describeValidAddresses() {
     return pht(
-      "Email addresses should be in the form 'user@domain.com'. The maximum ".
-      "length of an email address is %d character(s).",
+      "Email addresses should be in the form '%s'. The maximum ".
+      "length of an email address is %s character(s).",
+      'user@domain.com',
       new PhutilNumber(self::MAX_ADDRESS_LENGTH));
   }
 
@@ -131,10 +132,11 @@ final class PhabricatorUserEmail extends PhabricatorUserDAO {
     }
 
     if (count($domains) == 1) {
-      return 'Email address must be @'.head($domains);
+      return pht('Email address must be @%s', head($domains));
     } else {
-      return 'Email address must be at one of: '.
-        implode(', ', $domains);
+      return pht(
+        'Email address must be at one of: %s',
+        implode(', ', $domains));
     }
   }
 
@@ -174,27 +176,23 @@ final class PhabricatorUserEmail extends PhabricatorUserDAO {
 
     $signature = null;
     if (!$is_serious) {
-      $signature = <<<EOSIGNATURE
-Get Well Soon,
-Phabricator
-EOSIGNATURE;
+      $signature = pht("Get Well Soon,\nPhabricator");
     }
 
-    $body = <<<EOBODY
-Hi {$username},
-
-Please verify that you own this email address ({$address}) by clicking this
-link:
-
-  {$link}
-
-{$signature}
-EOBODY;
+    $body = sprintf(
+      "%s\n\n%s\n\n  %s\n\n%s",
+      pht('Hi %s', $username),
+      pht(
+        'Please verify that you own this email address (%s) by '.
+        'clicking this link:',
+        $address),
+      $link,
+      $signature);
 
     id(new PhabricatorMetaMTAMail())
       ->addRawTos(array($address))
       ->setForceDelivery(true)
-      ->setSubject('[Phabricator] Email Verification')
+      ->setSubject(pht('[Phabricator] Email Verification'))
       ->setBody($body)
       ->setRelatedPHID($user->getPHID())
       ->saveAndSend();
@@ -220,19 +218,20 @@ EOBODY;
     $old_address = $this->getAddress();
     $new_address = $new->getAddress();
 
-    $body = <<<EOBODY
-Hi {$username},
-
-This email address ({$old_address}) is no longer your primary email address.
-Going forward, Phabricator will send all email to your new primary email
-address ({$new_address}).
-
-EOBODY;
+    $body = sprintf(
+      "%s\n\n%s\n",
+      pht('Hi %s', $username),
+      pht(
+        'This email address (%s) is no longer your primary email address. '.
+        'Going forward, Phabricator will send all email to your new primary '.
+        'email address (%s).',
+        $old_address,
+        $new_address));
 
     id(new PhabricatorMetaMTAMail())
       ->addRawTos(array($old_address))
       ->setForceDelivery(true)
-      ->setSubject('[Phabricator] Primary Address Changed')
+      ->setSubject(pht('[Phabricator] Primary Address Changed'))
       ->setBody($body)
       ->setFrom($user->getPHID())
       ->setRelatedPHID($user->getPHID())
@@ -253,18 +252,18 @@ EOBODY;
 
     $new_address = $this->getAddress();
 
-    $body = <<<EOBODY
-Hi {$username},
-
-This is now your primary email address ({$new_address}). Going forward,
-Phabricator will send all email here.
-
-EOBODY;
+    $body = sprintf(
+      "%s\n\n%s\n",
+      pht('Hi %s', $username),
+      pht(
+        'This is now your primary email address (%s). Going forward, '.
+        'Phabricator will send all email here.',
+        $new_address));
 
     id(new PhabricatorMetaMTAMail())
       ->addRawTos(array($new_address))
       ->setForceDelivery(true)
-      ->setSubject('[Phabricator] Primary Address Changed')
+      ->setSubject(pht('[Phabricator] Primary Address Changed'))
       ->setBody($body)
       ->setFrom($user->getPHID())
       ->setRelatedPHID($user->getPHID())
diff --git a/src/applications/people/storage/__tests__/PhabricatorUserTestCase.php b/src/applications/people/storage/__tests__/PhabricatorUserTestCase.php
index 561bcb2d63..a29dd4f20c 100644
--- a/src/applications/people/storage/__tests__/PhabricatorUserTestCase.php
+++ b/src/applications/people/storage/__tests__/PhabricatorUserTestCase.php
@@ -49,7 +49,7 @@ final class PhabricatorUserTestCase extends PhabricatorTestCase {
       $this->assertEqual(
         $expect,
         PhabricatorUser::validateUsername($name),
-        "Validity of '{$name}'.");
+        pht("Validity of '%s'.", $name));
     }
   }
 
diff --git a/src/applications/people/typeahead/PhabricatorPeopleNoOwnerDatasource.php b/src/applications/people/typeahead/PhabricatorPeopleNoOwnerDatasource.php
index 90c887ac06..35f62e31dc 100644
--- a/src/applications/people/typeahead/PhabricatorPeopleNoOwnerDatasource.php
+++ b/src/applications/people/typeahead/PhabricatorPeopleNoOwnerDatasource.php
@@ -23,16 +23,14 @@ final class PhabricatorPeopleNoOwnerDatasource
         'name' => pht('No Owner'),
         'summary' => pht('Find results which are not assigned.'),
         'description' => pht(
-          'This function includes results which have no owner. Use a query '.
-          'like this to find unassigned results:'.
-          "\n\n".
-          '> none()'.
-          "\n\n".
-          'If you combine this function with other functions, the query will '.
-          'return results which match the other selectors //or// have no '.
-          'owner. For example, this query will find results which are owned '.
-          'by `alincoln`, and will also find results which have no owner:'.
-          "\n\n".
+          "This function includes results which have no owner. Use a query ".
+          "like this to find unassigned results:\n\n%s\n\n".
+          "If you combine this function with other functions, the query will ".
+          "return results which match the other selectors //or// have no ".
+          "owner. For example, this query will find results which are owned ".
+          "by `alincoln`, and will also find results which have no owner:".
+          "\n\n%s",
+          '> none()',
           '> alincoln, none()'),
       ),
     );
diff --git a/src/applications/people/typeahead/PhabricatorViewerDatasource.php b/src/applications/people/typeahead/PhabricatorViewerDatasource.php
index 5e08a7e702..1c9276ae8d 100644
--- a/src/applications/people/typeahead/PhabricatorViewerDatasource.php
+++ b/src/applications/people/typeahead/PhabricatorViewerDatasource.php
@@ -21,16 +21,15 @@ final class PhabricatorViewerDatasource
         'name' => pht('Current Viewer'),
         'summary' => pht('Use the current viewing user.'),
         'description' => pht(
-          'This function allows you to change the behavior of a query '.
-          'based on who is running it. When you use this function, you will '.
-          'be the current viewer, so it works like you typed your own '.
-          'username.'.
-          "\n\n".
-          'However, if you save a query using this function and send it '.
-          'to someone else, it will work like //their// username was the '.
-          'one that was typed. This can be useful for building dashboard '.
-          'panels that always show relevant information to the user who '.
-          'is looking at them.'),
+          "This function allows you to change the behavior of a query ".
+          "based on who is running it. When you use this function, you will ".
+          "be the current viewer, so it works like you typed your own ".
+          "username.\n\n".
+          "However, if you save a query using this function and send it ".
+          "to someone else, it will work like //their// username was the ".
+          "one that was typed. This can be useful for building dashboard ".
+          "panels that always show relevant information to the user who ".
+          "is looking at them."),
       ),
     );
   }
diff --git a/src/applications/phame/conduit/PhameQueryConduitAPIMethod.php b/src/applications/phame/conduit/PhameQueryConduitAPIMethod.php
index 8b882674a3..d82afc2faf 100644
--- a/src/applications/phame/conduit/PhameQueryConduitAPIMethod.php
+++ b/src/applications/phame/conduit/PhameQueryConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class PhameQueryConduitAPIMethod extends PhameConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Query phame blogs.';
+    return pht('Query phame blogs.');
   }
 
   public function getMethodStatus() {
diff --git a/src/applications/phame/conduit/PhameQueryPostsConduitAPIMethod.php b/src/applications/phame/conduit/PhameQueryPostsConduitAPIMethod.php
index 822c32a8da..06c20c7720 100644
--- a/src/applications/phame/conduit/PhameQueryPostsConduitAPIMethod.php
+++ b/src/applications/phame/conduit/PhameQueryPostsConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class PhameQueryPostsConduitAPIMethod extends PhameConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Query phame posts.';
+    return pht('Query phame posts.');
   }
 
   public function getMethodStatus() {
diff --git a/src/applications/phame/controller/PhameController.php b/src/applications/phame/controller/PhameController.php
index a9ede96133..5e786e9d41 100644
--- a/src/applications/phame/controller/PhameController.php
+++ b/src/applications/phame/controller/PhameController.php
@@ -64,12 +64,16 @@ abstract class PhameController extends PhabricatorController {
 
       $blogger = phutil_tag('strong', array(), $blogger);
       if ($post->isDraft()) {
-        $title = pht('%s drafted a blog post on %s.',
-          $blogger, $blog);
+        $title = pht(
+          '%s drafted a blog post on %s.',
+          $blogger,
+          $blog);
         $title = phutil_tag('em', array(), $title);
       } else {
-        $title = pht('%s wrote a blog post on %s.',
-          $blogger, $blog);
+        $title = pht(
+          '%s wrote a blog post on %s.',
+          $blogger,
+          $blog);
       }
 
       $item = id(new PHUIObjectItemView())
diff --git a/src/applications/phame/controller/blog/PhameBlogEditController.php b/src/applications/phame/controller/blog/PhameBlogEditController.php
index 8b1b3b81e1..65eabeb055 100644
--- a/src/applications/phame/controller/blog/PhameBlogEditController.php
+++ b/src/applications/phame/controller/blog/PhameBlogEditController.php
@@ -153,7 +153,7 @@ final class PhameBlogEditController
         ->setName('custom_domain')
         ->setValue($custom_domain)
         ->setCaption(
-          pht('Must include at least one dot (.), e.g. blog.example.com'))
+          pht('Must include at least one dot (.), e.g. %s', 'blog.example.com'))
         ->setError($e_custom_domain))
       ->appendChild(
         id(new AphrontFormSelectControl())
diff --git a/src/applications/phame/controller/blog/PhameBlogListController.php b/src/applications/phame/controller/blog/PhameBlogListController.php
index f9a4aeb2d9..9b16203170 100644
--- a/src/applications/phame/controller/blog/PhameBlogListController.php
+++ b/src/applications/phame/controller/blog/PhameBlogListController.php
@@ -26,7 +26,7 @@ final class PhameBlogListController extends PhameController {
           ));
         break;
       default:
-        throw new Exception("Unknown filter '{$filter}'!");
+        throw new Exception(pht("Unknown filter '%s'!", $filter));
     }
 
     $pager = id(new AphrontPagerView())
diff --git a/src/applications/phame/controller/blog/PhameBlogViewController.php b/src/applications/phame/controller/blog/PhameBlogViewController.php
index 76491278b5..a9fb9d73a7 100644
--- a/src/applications/phame/controller/blog/PhameBlogViewController.php
+++ b/src/applications/phame/controller/blog/PhameBlogViewController.php
@@ -161,7 +161,7 @@ final class PhameBlogViewController extends PhameController {
       id(new PhabricatorActionView())
         ->setIcon('fa-pencil')
         ->setHref($this->getApplicationURI('blog/edit/'.$blog->getID().'/'))
-        ->setName('Edit Blog')
+        ->setName(pht('Edit Blog'))
         ->setDisabled(!$can_edit)
         ->setWorkflow(!$can_edit));
 
@@ -169,7 +169,7 @@ final class PhameBlogViewController extends PhameController {
       id(new PhabricatorActionView())
         ->setIcon('fa-times')
         ->setHref($this->getApplicationURI('blog/delete/'.$blog->getID().'/'))
-        ->setName('Delete Blog')
+        ->setName(pht('Delete Blog'))
         ->setDisabled(!$can_edit)
         ->setWorkflow(true));
 
diff --git a/src/applications/phame/controller/post/PhamePostListController.php b/src/applications/phame/controller/post/PhamePostListController.php
index 23e9c985f1..7c82319158 100644
--- a/src/applications/phame/controller/post/PhamePostListController.php
+++ b/src/applications/phame/controller/post/PhamePostListController.php
@@ -54,7 +54,7 @@ final class PhamePostListController extends PhameController {
         $nav->selectFilter('post/all');
         break;
       default:
-        throw new Exception("Unknown filter '{$this->filter}'!");
+        throw new Exception(pht("Unknown filter '%s'!", $this->filter));
     }
 
     $pager = id(new AphrontCursorPagerView())
diff --git a/src/applications/phame/controller/post/PhamePostViewController.php b/src/applications/phame/controller/post/PhamePostViewController.php
index c1f6405377..1b2b8c1a3c 100644
--- a/src/applications/phame/controller/post/PhamePostViewController.php
+++ b/src/applications/phame/controller/post/PhamePostViewController.php
@@ -41,8 +41,9 @@ final class PhamePostViewController extends PhameController {
           ->setSeverity(PHUIInfoView::SEVERITY_NOTICE)
           ->setTitle(pht('Draft Post'))
           ->appendChild(
-            pht('Only you can see this draft until you publish it. '.
-                'Use "Preview / Publish" to publish this post.')));
+            pht(
+              'Only you can see this draft until you publish it. '.
+              'Use "Preview / Publish" to publish this post.')));
     }
 
     if (!$post->getBlog()) {
@@ -51,8 +52,9 @@ final class PhamePostViewController extends PhameController {
           ->setSeverity(PHUIInfoView::SEVERITY_WARNING)
           ->setTitle(pht('Not On A Blog'))
           ->appendChild(
-            pht('This post is not associated with a blog (the blog may have '.
-                'been deleted). Use "Move Post" to move it to a new blog.')));
+            pht(
+              'This post is not associated with a blog (the blog may have '.
+              'been deleted). Use "Move Post" to move it to a new blog.')));
     }
 
     $nav->appendChild(
diff --git a/src/applications/phame/skins/PhameSkinSpecification.php b/src/applications/phame/skins/PhameSkinSpecification.php
index 506f89a811..7dedf8ab4b 100644
--- a/src/applications/phame/skins/PhameSkinSpecification.php
+++ b/src/applications/phame/skins/PhameSkinSpecification.php
@@ -42,9 +42,13 @@ final class PhameSkinSpecification {
             $that_dir = $specs[$name]->getRootDirectory();
             $this_dir = $spec->getRootDirectory();
             throw new Exception(
-              "Two skins have the same name ('{$name}'), in '{$this_dir}' and ".
-              "'{$that_dir}'. Rename one or adjust your 'phame.skins' ".
-              "configuration.");
+              pht(
+                "Two skins have the same name ('%s'), in '%s' and '%s'. ".
+                "Rename one or adjust your '%s' configuration.",
+                $name,
+                $this_dir,
+                $that_dir,
+                'phame.skins'));
           }
 
           $specs[$name] = $spec;
@@ -124,7 +128,7 @@ final class PhameSkinSpecification {
         $spec->addPhutilLibrary($path.DIRECTORY_SEPARATOR.'src');
         break;
       default:
-        throw new Exception('Unknown skin type!');
+        throw new Exception(pht('Unknown skin type!'));
     }
 
     $spec->setType($type);
diff --git a/src/applications/phame/storage/PhameBlog.php b/src/applications/phame/storage/PhameBlog.php
index 1c4017fbd1..349d40d773 100644
--- a/src/applications/phame/storage/PhameBlog.php
+++ b/src/applications/phame/storage/PhameBlog.php
@@ -74,8 +74,9 @@ final class PhameBlog extends PhameDAO
 
     if (!$spec) {
       throw new Exception(
-        'This blog has an invalid skin, and the default skin failed to '.
-        'load.');
+        pht(
+          'This blog has an invalid skin, and the default skin failed to '.
+          'load.'));
     }
 
     $skin = newv($spec->getSkinClass(), array());
diff --git a/src/applications/phame/storage/PhamePost.php b/src/applications/phame/storage/PhamePost.php
index 8a02a7c564..e44e9615d3 100644
--- a/src/applications/phame/storage/PhamePost.php
+++ b/src/applications/phame/storage/PhamePost.php
@@ -155,8 +155,9 @@ final class PhamePost extends PhameDAO
 
   public static function getVisibilityOptionsForSelect() {
     return array(
-      self::VISIBILITY_DRAFT     => 'Draft: visible only to me.',
-      self::VISIBILITY_PUBLISHED => 'Published: visible to the whole world.',
+      self::VISIBILITY_DRAFT     => pht('Draft: visible only to me.'),
+      self::VISIBILITY_PUBLISHED => pht(
+        'Published: visible to the whole world.'),
     );
   }
 
@@ -217,8 +218,7 @@ final class PhamePost extends PhameDAO
   }
 
   public function describeAutomaticCapability($capability) {
-    return pht(
-      'The author of a blog post can always view and edit it.');
+    return pht('The author of a blog post can always view and edit it.');
   }
 
 
diff --git a/src/applications/phid/conduit/PHIDInfoConduitAPIMethod.php b/src/applications/phid/conduit/PHIDInfoConduitAPIMethod.php
index 465697c60e..76afb1ef54 100644
--- a/src/applications/phid/conduit/PHIDInfoConduitAPIMethod.php
+++ b/src/applications/phid/conduit/PHIDInfoConduitAPIMethod.php
@@ -11,11 +11,11 @@ final class PHIDInfoConduitAPIMethod extends PHIDConduitAPIMethod {
   }
 
   public function getMethodStatusDescription() {
-    return "Replaced by 'phid.query'.";
+    return pht("Replaced by 'phid.query'.");
   }
 
   public function getMethodDescription() {
-    return 'Retrieve information about an arbitrary PHID.';
+    return pht('Retrieve information about an arbitrary PHID.');
   }
 
   protected function defineParamTypes() {
@@ -30,7 +30,7 @@ final class PHIDInfoConduitAPIMethod extends PHIDConduitAPIMethod {
 
   protected function defineErrorTypes() {
     return array(
-      'ERR-BAD-PHID' => 'No such object exists.',
+      'ERR-BAD-PHID' => pht('No such object exists.'),
     );
   }
 
diff --git a/src/applications/phid/conduit/PHIDLookupConduitAPIMethod.php b/src/applications/phid/conduit/PHIDLookupConduitAPIMethod.php
index 73196daaff..f70afb9931 100644
--- a/src/applications/phid/conduit/PHIDLookupConduitAPIMethod.php
+++ b/src/applications/phid/conduit/PHIDLookupConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class PHIDLookupConduitAPIMethod extends PHIDConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Look up objects by name.';
+    return pht('Look up objects by name.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/phid/conduit/PHIDQueryConduitAPIMethod.php b/src/applications/phid/conduit/PHIDQueryConduitAPIMethod.php
index 69b6fe0acb..420d6a2f92 100644
--- a/src/applications/phid/conduit/PHIDQueryConduitAPIMethod.php
+++ b/src/applications/phid/conduit/PHIDQueryConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class PHIDQueryConduitAPIMethod extends PHIDConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Retrieve information about arbitrary PHIDs.';
+    return pht('Retrieve information about arbitrary PHIDs.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/phid/storage/PhabricatorPHID.php b/src/applications/phid/storage/PhabricatorPHID.php
index 43896045b9..d3c43bfc47 100644
--- a/src/applications/phid/storage/PhabricatorPHID.php
+++ b/src/applications/phid/storage/PhabricatorPHID.php
@@ -9,7 +9,7 @@ final class PhabricatorPHID {
 
   public static function generateNewPHID($type, $subtype = null) {
     if (!$type) {
-      throw new Exception('Can not generate PHID with no type.');
+      throw new Exception(pht('Can not generate PHID with no type.'));
     }
 
     if ($subtype === null) {
diff --git a/src/applications/phid/type/PhabricatorPHIDType.php b/src/applications/phid/type/PhabricatorPHIDType.php
index fd64ab7bd1..62107233e1 100644
--- a/src/applications/phid/type/PhabricatorPHIDType.php
+++ b/src/applications/phid/type/PhabricatorPHIDType.php
@@ -9,16 +9,20 @@ abstract class PhabricatorPHIDType {
     if ($const === false) {
       throw new Exception(
         pht(
-          'PHIDType class "%s" must define an TYPECONST property.',
-          get_class($this)));
+          '%s class "%s" must define a %s property.',
+          __CLASS__,
+          get_class($this),
+          'TYPECONST'));
     }
 
     if (!is_string($const) || !preg_match('/^[A-Z]{4}$/', $const)) {
       throw new Exception(
         pht(
-          'PHIDType class "%s" has an invalid TYPECONST property. PHID '.
+          '%s class "%s" has an invalid %s property. PHID '.
           'constants must be a four character uppercase string.',
-          get_class($this)));
+          __CLASS__,
+          get_class($this),
+          'TYPECONST'));
     }
 
     return $const;
diff --git a/src/applications/pholio/controller/PholioInlineController.php b/src/applications/pholio/controller/PholioInlineController.php
index 782383cdb8..4cc5510b99 100644
--- a/src/applications/pholio/controller/PholioInlineController.php
+++ b/src/applications/pholio/controller/PholioInlineController.php
@@ -70,7 +70,7 @@ final class PholioInlineController extends PholioController {
 
       $file = $image->getFile();
       if (!$file->isViewableImage()) {
-        throw new Exception('File is not viewable.');
+        throw new Exception(pht('File is not viewable.'));
       }
 
       $image_uri = $file->getBestURI();
diff --git a/src/applications/pholio/controller/PholioMockEditController.php b/src/applications/pholio/controller/PholioMockEditController.php
index 7cfa0b35b4..17abba6e60 100644
--- a/src/applications/pholio/controller/PholioMockEditController.php
+++ b/src/applications/pholio/controller/PholioMockEditController.php
@@ -276,7 +276,7 @@ final class PholioMockEditController extends PholioController {
         'id' => $drop_id,
         'class' => 'pholio-edit-drop',
       ),
-      'Drag and drop images here to add them to the mock.');
+      pht('Drag and drop images here to add them to the mock.'));
 
     $order_control = phutil_tag(
       'input',
diff --git a/src/applications/pholio/mail/PholioReplyHandler.php b/src/applications/pholio/mail/PholioReplyHandler.php
index 3f20ea6371..1109d901f0 100644
--- a/src/applications/pholio/mail/PholioReplyHandler.php
+++ b/src/applications/pholio/mail/PholioReplyHandler.php
@@ -5,7 +5,7 @@ final class PholioReplyHandler
 
   public function validateMailReceiver($mail_receiver) {
     if (!($mail_receiver instanceof PholioMock)) {
-      throw new Exception('Mail receiver is not a PholioMock!');
+      throw new Exception(pht('Mail receiver is not a %s!', 'PholioMock'));
     }
   }
 
diff --git a/src/applications/pholio/view/PholioMockImagesView.php b/src/applications/pholio/view/PholioMockImagesView.php
index c1bcb46230..cf8d0c6143 100644
--- a/src/applications/pholio/view/PholioMockImagesView.php
+++ b/src/applications/pholio/view/PholioMockImagesView.php
@@ -54,7 +54,7 @@ final class PholioMockImagesView extends AphrontView {
 
   public function getBehaviorConfig() {
     if (!$this->getMock()) {
-      throw new Exception('Call setMock() before getBehaviorConfig()!');
+      throw new PhutilInvalidStateException('setMock');
     }
 
     if ($this->behaviorConfig === null) {
@@ -158,7 +158,7 @@ final class PholioMockImagesView extends AphrontView {
 
   public function render() {
     if (!$this->getMock()) {
-      throw new Exception('Call setMock() before render()!');
+      throw new PhutilInvalidStateException('setMock');
     }
     $mock = $this->getMock();
 
diff --git a/src/applications/pholio/view/PholioTransactionView.php b/src/applications/pholio/view/PholioTransactionView.php
index 50d764910d..cf2f44a3aa 100644
--- a/src/applications/pholio/view/PholioTransactionView.php
+++ b/src/applications/pholio/view/PholioTransactionView.php
@@ -67,7 +67,7 @@ final class PholioTransactionView
           $inlines[] = $xaction;
           break;
         default:
-          throw new Exception('Unknown grouped transaction type!');
+          throw new Exception(pht('Unknown grouped transaction type!'));
       }
     }
 
@@ -101,12 +101,12 @@ final class PholioTransactionView
 
     $image = idx($images, $comment->getImageID());
     if (!$image) {
-      throw new Exception('No image attached!');
+      throw new Exception(pht('No image attached!'));
     }
 
     $file = $image->getFile();
     if (!$file->isViewableImage()) {
-      throw new Exception('File is not viewable.');
+      throw new Exception(pht('File is not viewable.'));
     }
 
     $image_uri = $file->getBestURI();
diff --git a/src/applications/phortune/control/PhortuneMonthYearExpiryControl.php b/src/applications/phortune/control/PhortuneMonthYearExpiryControl.php
index b9c48cd595..73f26bc26d 100644
--- a/src/applications/phortune/control/PhortuneMonthYearExpiryControl.php
+++ b/src/applications/phortune/control/PhortuneMonthYearExpiryControl.php
@@ -38,7 +38,7 @@ final class PhortuneMonthYearExpiryControl extends AphrontFormControl {
 
   protected function renderInput() {
     if (!$this->getUser()) {
-      throw new Exception('You must setUser() before render()!');
+      throw new PhutilInvalidStateException('setUser');
     }
 
     // represent months like a credit card does
diff --git a/src/applications/phortune/controller/PhortuneCartCancelController.php b/src/applications/phortune/controller/PhortuneCartCancelController.php
index b7415c5211..3aedceb6b0 100644
--- a/src/applications/phortune/controller/PhortuneCartCancelController.php
+++ b/src/applications/phortune/controller/PhortuneCartCancelController.php
@@ -175,8 +175,7 @@ final class PhortuneCartCancelController
 
     if ($is_refund) {
       $title = pht('Refund Order?');
-      $body = pht(
-        'Really refund this order?');
+      $body = pht('Really refund this order?');
       $button = pht('Refund Order');
       $cancel_text = pht('Cancel');
 
@@ -193,8 +192,7 @@ final class PhortuneCartCancelController
 
     } else {
       $title = pht('Cancel Order?');
-      $body = pht(
-        'Really cancel this order? Any payment will be refunded.');
+      $body = pht('Really cancel this order? Any payment will be refunded.');
       $button = pht('Cancel Order');
 
       // Don't give the user a "Cancel" button in response to a "Cancel?"
diff --git a/src/applications/phortune/controller/PhortuneCartCheckoutController.php b/src/applications/phortune/controller/PhortuneCartCheckoutController.php
index b6b9287104..2d6ff2342a 100644
--- a/src/applications/phortune/controller/PhortuneCartCheckoutController.php
+++ b/src/applications/phortune/controller/PhortuneCartCheckoutController.php
@@ -200,7 +200,7 @@ final class PhortuneCartCheckoutController
       $provider_form = new PHUIFormLayoutView();
       $provider_form->appendChild(
         id(new AphrontFormMarkupControl())
-          ->setLabel('Pay With')
+          ->setLabel(pht('Pay With'))
           ->setValue($one_time_options));
     }
 
diff --git a/src/applications/phortune/controller/PhortuneMerchantViewController.php b/src/applications/phortune/controller/PhortuneMerchantViewController.php
index c1512e9d32..5026597121 100644
--- a/src/applications/phortune/controller/PhortuneMerchantViewController.php
+++ b/src/applications/phortune/controller/PhortuneMerchantViewController.php
@@ -297,5 +297,4 @@ final class PhortuneMerchantViewController
   }
 
 
-
 }
diff --git a/src/applications/phortune/controller/PhortunePaymentMethodCreateController.php b/src/applications/phortune/controller/PhortunePaymentMethodCreateController.php
index 844dd2ed5e..6b7e55bb54 100644
--- a/src/applications/phortune/controller/PhortunePaymentMethodCreateController.php
+++ b/src/applications/phortune/controller/PhortunePaymentMethodCreateController.php
@@ -44,8 +44,9 @@ final class PhortunePaymentMethodCreateController
     $providers = $this->loadCreatePaymentMethodProvidersForMerchant($merchant);
     if (!$providers) {
       throw new Exception(
-        'There are no payment providers enabled that can add payment '.
-        'methods.');
+        pht(
+          'There are no payment providers enabled that can add payment '.
+          'methods.'));
     }
 
     if (count($providers) == 1) {
diff --git a/src/applications/phortune/controller/PhortuneProviderEditController.php b/src/applications/phortune/controller/PhortuneProviderEditController.php
index da18fdbb45..3ed97b5a4b 100644
--- a/src/applications/phortune/controller/PhortuneProviderEditController.php
+++ b/src/applications/phortune/controller/PhortuneProviderEditController.php
@@ -260,8 +260,7 @@ final class PhortuneProviderEditController
       ->setUser($viewer)
       ->addHiddenInput('merchantID', $merchant->getID())
       ->appendRemarkupInstructions(
-        pht(
-          'Choose the type of payment provider to add:'))
+        pht('Choose the type of payment provider to add:'))
       ->appendChild($panel_classes)
       ->appendChild(
         id(new AphrontFormSubmitControl())
diff --git a/src/applications/phortune/currency/PhortuneCurrency.php b/src/applications/phortune/currency/PhortuneCurrency.php
index b59d9b144a..f69dd362fe 100644
--- a/src/applications/phortune/currency/PhortuneCurrency.php
+++ b/src/applications/phortune/currency/PhortuneCurrency.php
@@ -52,7 +52,7 @@ final class PhortuneCurrency extends Phobject {
       case 'USD':
         break;
       default:
-        throw new Exception("Unsupported currency '{$currency}'!");
+        throw new Exception(pht("Unsupported currency '%s'!", $currency));
     }
 
     return self::newFromValueAndCurrency($value, $currency);
@@ -121,7 +121,7 @@ final class PhortuneCurrency extends Phobject {
   }
 
   private static function throwFormatException($string) {
-    throw new Exception("Invalid currency format ('{$string}').");
+    throw new Exception(pht("Invalid currency format ('%s').", $string));
   }
 
   private function throwUnlikeCurrenciesException(PhortuneCurrency $other) {
diff --git a/src/applications/phortune/currency/PhortuneCurrencySerializer.php b/src/applications/phortune/currency/PhortuneCurrencySerializer.php
index affcb77517..b5f7560443 100644
--- a/src/applications/phortune/currency/PhortuneCurrencySerializer.php
+++ b/src/applications/phortune/currency/PhortuneCurrencySerializer.php
@@ -11,7 +11,8 @@ final class PhortuneCurrencySerializer extends PhabricatorLiskSerializer {
       throw new Exception(
         pht(
           'Trying to save object with a currency column, but the column '.
-          'value is not a PhortuneCurrency object.'));
+          'value is not a %s object.',
+          'PhortuneCurrency'));
     }
 
     return $value->serializeForStorage();
diff --git a/src/applications/phortune/exception/PhortuneNotImplementedException.php b/src/applications/phortune/exception/PhortuneNotImplementedException.php
index 7912ab30f2..eac3b3b7a8 100644
--- a/src/applications/phortune/exception/PhortuneNotImplementedException.php
+++ b/src/applications/phortune/exception/PhortuneNotImplementedException.php
@@ -3,9 +3,10 @@
 final class PhortuneNotImplementedException extends Exception {
 
   public function __construct(PhortunePaymentProvider $provider) {
-    $class = get_class($provider);
     return parent::__construct(
-      "Provider '{$class}' does not implement this method.");
+      pht(
+        "Provider '%s' does not implement this method.",
+        get_class($provider)));
   }
 
 }
diff --git a/src/applications/phortune/mail/PhortuneCartReplyHandler.php b/src/applications/phortune/mail/PhortuneCartReplyHandler.php
index 4f333d8301..9c781fc900 100644
--- a/src/applications/phortune/mail/PhortuneCartReplyHandler.php
+++ b/src/applications/phortune/mail/PhortuneCartReplyHandler.php
@@ -5,7 +5,7 @@ final class PhortuneCartReplyHandler
 
   public function validateMailReceiver($mail_receiver) {
     if (!($mail_receiver instanceof PhortuneCart)) {
-      throw new Exception('Mail receiver is not a PhortuneCart!');
+      throw new Exception(pht('Mail receiver is not a %s!', 'PhortuneCart'));
     }
   }
 
diff --git a/src/applications/phortune/management/PhabricatorPhortuneManagementInvoiceWorkflow.php b/src/applications/phortune/management/PhabricatorPhortuneManagementInvoiceWorkflow.php
index e1053e74a1..673bf812d7 100644
--- a/src/applications/phortune/management/PhabricatorPhortuneManagementInvoiceWorkflow.php
+++ b/src/applications/phortune/management/PhabricatorPhortuneManagementInvoiceWorkflow.php
@@ -54,7 +54,8 @@ final class PhabricatorPhortuneManagementInvoiceWorkflow
     if (!$subscription_phid) {
       throw new PhutilArgumentUsageException(
         pht(
-          'Specify which subscription to invoice with --subscription.'));
+          'Specify which subscription to invoice with %s.',
+          '--subscription'));
     }
 
     $subscription = id(new PhortuneSubscriptionQuery())
@@ -90,30 +91,38 @@ final class PhabricatorPhortuneManagementInvoiceWorkflow
     if (!$auto_range && !$last_arg && !$next_arg) {
       throw new PhutilArgumentUsageException(
         pht(
-          'Specify a billing range with --last and --next, or use '.
-          '--auto-range.'));
+          'Specify a billing range with %s and %s, or use %s.',
+          '--last',
+          '--next',
+          '--auto-range'));
     } else if (!$auto_range & (!$last_arg || !$next_arg)) {
       throw new PhutilArgumentUsageException(
         pht(
-          'When specifying --last or --next, you must specify both arguments '.
-          'to define the beginning and end of the billing range.'));
+          'When specifying %s or %s, you must specify both arguments '.
+          'to define the beginning and end of the billing range.',
+          '--last',
+          '--next'));
     } else if (!$auto_range && ($last_arg && $next_arg)) {
       $last_time = $this->parseTimeArgument($args->getArg('last'));
       $next_time = $this->parseTimeArgument($args->getArg('next'));
     } else if ($auto_range && ($last_arg || $next_arg)) {
       throw new PhutilArgumentUsageException(
         pht(
-          'Use either --auto-range or --last and --next to specify the '.
-          'billing range, but not both.'));
+          'Use either %s or %s and %s to specify the '.
+          'billing range, but not both.',
+          '--auto-range',
+          '--last',
+          '--next'));
     } else {
       $trigger = $subscription->getTrigger();
       $event = $trigger->getEvent();
       if (!$event) {
         throw new PhutilArgumentUsageException(
           pht(
-            'Unable to calculate --auto-range, this subscription has not been '.
+            'Unable to calculate %s, this subscription has not been '.
             'scheduled for billing yet. Wait for the trigger daemon to '.
-            'schedule the subscription.'));
+            'schedule the subscription.',
+            '--auto-range'));
       }
       $last_time = $event->getLastEventEpoch();
       $next_time = $event->getNextEventEpoch();
diff --git a/src/applications/phortune/provider/PhortunePayPalPaymentProvider.php b/src/applications/phortune/provider/PhortunePayPalPaymentProvider.php
index fcc0d12bf4..078141f8a1 100644
--- a/src/applications/phortune/provider/PhortunePayPalPaymentProvider.php
+++ b/src/applications/phortune/provider/PhortunePayPalPaymentProvider.php
@@ -27,8 +27,7 @@ final class PhortunePayPalPaymentProvider extends PhortunePaymentProvider {
   }
 
   public function getConfigureProvidesDescription() {
-    return pht(
-      'This merchant accepts payments via PayPal.');
+    return pht('This merchant accepts payments via PayPal.');
   }
 
   public function getConfigureInstructions() {
diff --git a/src/applications/phortune/provider/PhortuneStripePaymentProvider.php b/src/applications/phortune/provider/PhortuneStripePaymentProvider.php
index f751e3cbc5..1e7c348297 100644
--- a/src/applications/phortune/provider/PhortuneStripePaymentProvider.php
+++ b/src/applications/phortune/provider/PhortuneStripePaymentProvider.php
@@ -24,8 +24,7 @@ final class PhortuneStripePaymentProvider extends PhortunePaymentProvider {
   }
 
   public function getConfigureProvidesDescription() {
-    return pht(
-      'This merchant accepts credit and debit cards via Stripe.');
+    return pht('This merchant accepts credit and debit cards via Stripe.');
   }
 
   public function getPaymentMethodDescription() {
@@ -147,7 +146,7 @@ final class PhortuneStripePaymentProvider extends PhortunePaymentProvider {
 
     $id = $stripe_charge->id;
     if (!$id) {
-      throw new Exception('Stripe charge call did not return an ID!');
+      throw new Exception(pht('Stripe charge call did not return an ID!'));
     }
 
     $charge->setMetadataValue('stripe.chargeID', $id);
diff --git a/src/applications/phortune/storage/PhortuneCart.php b/src/applications/phortune/storage/PhortuneCart.php
index 70ecbb21c9..22dc27a9ed 100644
--- a/src/applications/phortune/storage/PhortuneCart.php
+++ b/src/applications/phortune/storage/PhortuneCart.php
@@ -87,8 +87,9 @@ final class PhortuneCart extends PhortuneDAO
         if ($copy->getStatus() !== self::STATUS_BUILDING) {
           throw new Exception(
             pht(
-              'Cart has wrong status ("%s") to call willApplyCharge().',
-              $copy->getStatus()));
+              'Cart has wrong status ("%s") to call %s.',
+              $copy->getStatus(),
+              'willApplyCharge()'));
         }
 
         $this->setStatus(self::STATUS_READY)->save();
@@ -129,9 +130,9 @@ final class PhortuneCart extends PhortuneDAO
         if ($copy->getStatus() !== self::STATUS_READY) {
           throw new Exception(
             pht(
-              'Cart has wrong status ("%s") to call willApplyCharge(), '.
-              'expected "%s".',
+              'Cart has wrong status ("%s") to call %s, expected "%s".',
               $copy->getStatus(),
+              'willApplyCharge()',
               self::STATUS_READY));
         }
 
@@ -156,9 +157,9 @@ final class PhortuneCart extends PhortuneDAO
         if ($copy->getStatus() !== self::STATUS_PURCHASING) {
           throw new Exception(
             pht(
-              'Cart has wrong status ("%s") to call didHoldCharge(), '.
-              'expected "%s".',
+              'Cart has wrong status ("%s") to call %s, expected "%s".',
               $copy->getStatus(),
+              'didHoldCharge()',
               self::STATUS_PURCHASING));
         }
 
@@ -184,8 +185,9 @@ final class PhortuneCart extends PhortuneDAO
             ($copy->getStatus() !== self::STATUS_HOLD)) {
           throw new Exception(
             pht(
-              'Cart has wrong status ("%s") to call didApplyCharge().',
-              $copy->getStatus()));
+              'Cart has wrong status ("%s") to call %s.',
+              $copy->getStatus(),
+              'didApplyCharge()'));
         }
 
         $charge->save();
@@ -219,8 +221,9 @@ final class PhortuneCart extends PhortuneDAO
         if (($copy->getStatus() !== self::STATUS_CHARGED)) {
           throw new Exception(
             pht(
-              'Cart has wrong status ("%s") to call willReviewCart()!',
-              $copy->getStatus()));
+              'Cart has wrong status ("%s") to call %s!',
+              $copy->getStatus(),
+              'willReviewCart()'));
         }
 
         $this->setStatus(self::STATUS_REVIEW)->save();
@@ -244,8 +247,9 @@ final class PhortuneCart extends PhortuneDAO
             ($copy->getStatus() !== self::STATUS_REVIEW)) {
           throw new Exception(
             pht(
-              'Cart has wrong status ("%s") to call didReviewCart()!',
-              $copy->getStatus()));
+              'Cart has wrong status ("%s") to call %s!',
+              $copy->getStatus(),
+              'didReviewCart()'));
         }
 
         foreach ($this->purchases as $purchase) {
@@ -275,8 +279,9 @@ final class PhortuneCart extends PhortuneDAO
             ($copy->getStatus() !== self::STATUS_HOLD)) {
           throw new Exception(
             pht(
-              'Cart has wrong status ("%s") to call didFailCharge().',
-              $copy->getStatus()));
+              'Cart has wrong status ("%s") to call %s.',
+              $copy->getStatus(),
+              'didFailCharge()'));
         }
 
         $charge->save();
@@ -300,7 +305,7 @@ final class PhortuneCart extends PhortuneDAO
 
     if (!$amount->isPositive()) {
       throw new Exception(
-        pht('Trying to refund nonpositive amount of money!'));
+        pht('Trying to refund non-positive amount of money!'));
     }
 
     if ($amount->isGreaterThan($charge->getAmountRefundableAsCurrency())) {
diff --git a/src/applications/phortune/view/PhortuneCreditCardForm.php b/src/applications/phortune/view/PhortuneCreditCardForm.php
index 58bf4cda0c..956e14499c 100644
--- a/src/applications/phortune/view/PhortuneCreditCardForm.php
+++ b/src/applications/phortune/view/PhortuneCreditCardForm.php
@@ -81,20 +81,20 @@ final class PhortuneCreditCardForm {
       ->setID($form_id)
       ->appendChild(
         id(new AphrontFormTextControl())
-          ->setLabel('Card Number')
+          ->setLabel(pht('Card Number'))
           ->setDisableAutocomplete(true)
           ->setSigil('number-input')
           ->setError($e_number))
       ->appendChild(
         id(new AphrontFormTextControl())
-          ->setLabel('CVC')
+          ->setLabel(pht('CVC'))
           ->setDisableAutocomplete(true)
           ->addClass('aphront-form-cvc-input')
           ->setSigil('cvc-input')
           ->setError($e_cvc))
       ->appendChild(
         id(new PhortuneMonthYearExpiryControl())
-          ->setLabel('Expiration')
+          ->setLabel(pht('Expiration'))
           ->setUser($this->user)
           ->setError($e_expiry));
 
diff --git a/src/applications/phortune/worker/PhortuneSubscriptionWorker.php b/src/applications/phortune/worker/PhortuneSubscriptionWorker.php
index 747b4b3889..96f1948528 100644
--- a/src/applications/phortune/worker/PhortuneSubscriptionWorker.php
+++ b/src/applications/phortune/worker/PhortuneSubscriptionWorker.php
@@ -198,8 +198,7 @@ final class PhortuneSubscriptionWorker extends PhabricatorWorker {
 
     if (!$last_epoch || !$this_epoch) {
       throw new PhabricatorWorkerPermanentFailureException(
-        pht(
-          'Subscription is missing billing period information.'));
+        pht('Subscription is missing billing period information.'));
     }
 
     $period_length = ($this_epoch - $last_epoch);
diff --git a/src/applications/phpast/application/PhabricatorPHPASTApplication.php b/src/applications/phpast/application/PhabricatorPHPASTApplication.php
index 8a9efa5a99..3118ed68c9 100644
--- a/src/applications/phpast/application/PhabricatorPHPASTApplication.php
+++ b/src/applications/phpast/application/PhabricatorPHPASTApplication.php
@@ -15,7 +15,7 @@ final class PhabricatorPHPASTApplication extends PhabricatorApplication {
   }
 
   public function getShortDescription() {
-    return 'Visual PHP Parser';
+    return pht('Visual PHP Parser');
   }
 
   public function getTitleGlyph() {
diff --git a/src/applications/phpast/controller/PhabricatorXHPASTViewFrameController.php b/src/applications/phpast/controller/PhabricatorXHPASTViewFrameController.php
index 65ec7731f1..8d6e690205 100644
--- a/src/applications/phpast/controller/PhabricatorXHPASTViewFrameController.php
+++ b/src/applications/phpast/controller/PhabricatorXHPASTViewFrameController.php
@@ -22,7 +22,7 @@ final class PhabricatorXHPASTViewFrameController
         '',
       )),
       array(
-        'title' => 'XHPAST View',
+        'title' => pht('XHPAST View'),
       ));
   }
 }
diff --git a/src/applications/phpast/controller/PhabricatorXHPASTViewPanelController.php b/src/applications/phpast/controller/PhabricatorXHPASTViewPanelController.php
index 53a93b1382..ab68948af3 100644
--- a/src/applications/phpast/controller/PhabricatorXHPASTViewPanelController.php
+++ b/src/applications/phpast/controller/PhabricatorXHPASTViewPanelController.php
@@ -11,7 +11,7 @@ abstract class PhabricatorXHPASTViewPanelController
     $this->storageTree = id(new PhabricatorXHPASTViewParseTree())
       ->load($this->id);
     if (!$this->storageTree) {
-      throw new Exception('No such AST!');
+      throw new Exception(pht('No such AST!'));
     }
   }
 
diff --git a/src/applications/phpast/controller/PhabricatorXHPASTViewRunController.php b/src/applications/phpast/controller/PhabricatorXHPASTViewRunController.php
index 3e6e2b3fb1..b235f5b842 100644
--- a/src/applications/phpast/controller/PhabricatorXHPASTViewRunController.php
+++ b/src/applications/phpast/controller/PhabricatorXHPASTViewRunController.php
@@ -35,7 +35,7 @@ final class PhabricatorXHPASTViewRunController
       ->setUser($user)
       ->appendChild(
         id(new AphrontFormTextAreaControl())
-          ->setLabel('Source')
+          ->setLabel(pht('Source'))
           ->setName('source')
           ->setValue("<?php\n\n")
           ->setHeight(AphrontFormTextAreaControl::HEIGHT_VERY_TALL))
diff --git a/src/applications/phpast/controller/PhabricatorXHPASTViewStreamController.php b/src/applications/phpast/controller/PhabricatorXHPASTViewStreamController.php
index 4931ab29e3..4a098f1591 100644
--- a/src/applications/phpast/controller/PhabricatorXHPASTViewStreamController.php
+++ b/src/applications/phpast/controller/PhabricatorXHPASTViewStreamController.php
@@ -16,7 +16,7 @@ final class PhabricatorXHPASTViewStreamController
     foreach ($tree->getRawTokenStream() as $id => $token) {
       $seq = $id;
       $name = $token->getTypeName();
-      $title = "Token {$seq}: {$name}";
+      $title = pht('Token %s: %s', $seq, $name);
 
       $tokens[] = phutil_tag(
         'span',
diff --git a/src/applications/phragment/conduit/PhragmentGetPatchConduitAPIMethod.php b/src/applications/phragment/conduit/PhragmentGetPatchConduitAPIMethod.php
index dedf00e1eb..aa9e008007 100644
--- a/src/applications/phragment/conduit/PhragmentGetPatchConduitAPIMethod.php
+++ b/src/applications/phragment/conduit/PhragmentGetPatchConduitAPIMethod.php
@@ -28,7 +28,7 @@ final class PhragmentGetPatchConduitAPIMethod
 
   protected function defineErrorTypes() {
     return array(
-      'ERR_BAD_FRAGMENT' => 'No such fragment exists',
+      'ERR_BAD_FRAGMENT' => pht('No such fragment exists.'),
     );
   }
 
diff --git a/src/applications/phragment/conduit/PhragmentQueryFragmentsConduitAPIMethod.php b/src/applications/phragment/conduit/PhragmentQueryFragmentsConduitAPIMethod.php
index 27ddac1d36..08a1bcba49 100644
--- a/src/applications/phragment/conduit/PhragmentQueryFragmentsConduitAPIMethod.php
+++ b/src/applications/phragment/conduit/PhragmentQueryFragmentsConduitAPIMethod.php
@@ -27,7 +27,7 @@ final class PhragmentQueryFragmentsConduitAPIMethod
 
   protected function defineErrorTypes() {
     return array(
-      'ERR_BAD_FRAGMENT' => 'No such fragment exists',
+      'ERR_BAD_FRAGMENT' => pht('No such fragment exists.'),
     );
   }
 
diff --git a/src/applications/phragment/controller/PhragmentController.php b/src/applications/phragment/controller/PhragmentController.php
index 096ee21a1f..a96c25878e 100644
--- a/src/applications/phragment/controller/PhragmentController.php
+++ b/src/applications/phragment/controller/PhragmentController.php
@@ -201,12 +201,16 @@ abstract class PhragmentController extends PhabricatorController {
       return id(new PHUIInfoView())
         ->setTitle(pht('security.alternate-file-domain must be configured!'))
         ->setSeverity(PHUIInfoView::SEVERITY_ERROR)
-        ->appendChild(phutil_tag('p', array(), pht(
-          'Because Phragment generates files (such as ZIP archives and '.
-          'patches) as they are requested, it requires that you configure '.
-          'the `security.alternate-file-domain` option. This option on it\'s '.
-          'own will also provide additional security when serving files '.
-          'across Phabricator.')));
+        ->appendChild(
+          phutil_tag(
+            'p',
+            array(),
+            pht(
+              "Because Phragment generates files (such as ZIP archives and ".
+              "patches) as they are requested, it requires that you configure ".
+              "the `%s` option. This option on it's own will also provide ".
+              "additional security when serving files across Phabricator.",
+              'security.alternate-file-domain')));
     }
     return null;
   }
diff --git a/src/applications/phragment/controller/PhragmentCreateController.php b/src/applications/phragment/controller/PhragmentCreateController.php
index d899754a1c..2a5b54538c 100644
--- a/src/applications/phragment/controller/PhragmentCreateController.php
+++ b/src/applications/phragment/controller/PhragmentCreateController.php
@@ -40,7 +40,7 @@ final class PhragmentCreateController extends PhragmentController {
       $v_editpolicy = $request->getStr('editPolicy');
 
       if (strpos($v_name, '/') !== false) {
-        $errors[] = pht('The fragment name can not contain \'/\'.');
+        $errors[] = pht("The fragment name can not contain '/'.");
       }
 
       $file = id(new PhabricatorFileQuery())
@@ -48,7 +48,7 @@ final class PhragmentCreateController extends PhragmentController {
         ->withIDs(array($v_fileid))
         ->executeOne();
       if (!$file) {
-        $errors[] = pht('The specified file doesn\'t exist.');
+        $errors[] = pht("The specified file doesn't exist.");
       }
 
       if (!count($errors)) {
@@ -117,7 +117,7 @@ final class PhragmentCreateController extends PhragmentController {
     $crumbs->addTextCrumb(pht('Create Fragment'));
 
     $box = id(new PHUIObjectBoxView())
-      ->setHeaderText('Create Fragment')
+      ->setHeaderText(pht('Create Fragment'))
       ->setForm($form);
 
     if ($error_view) {
diff --git a/src/applications/phragment/controller/PhragmentHistoryController.php b/src/applications/phragment/controller/PhragmentHistoryController.php
index 3df7095c9d..cb84fd819f 100644
--- a/src/applications/phragment/controller/PhragmentHistoryController.php
+++ b/src/applications/phragment/controller/PhragmentHistoryController.php
@@ -59,7 +59,7 @@ final class PhragmentHistoryController extends PhragmentController {
     $first = true;
     foreach ($versions as $version) {
       $item = id(new PHUIObjectItemView());
-      $item->setHeader('Version '.$version->getSequence());
+      $item->setHeader(pht('Version %s', $version->getSequence()));
       $item->setHref($version->getURI());
       $item->addAttribute(phabricator_datetime(
         $version->getDateCreated(),
diff --git a/src/applications/phragment/controller/PhragmentRevertController.php b/src/applications/phragment/controller/PhragmentRevertController.php
index 84e8cbb71e..92da1f27a3 100644
--- a/src/applications/phragment/controller/PhragmentRevertController.php
+++ b/src/applications/phragment/controller/PhragmentRevertController.php
@@ -47,7 +47,7 @@ final class PhragmentRevertController extends PhragmentController {
           ->executeOne();
         if ($file === null) {
           throw new Exception(
-            'The file associated with this version was not found.');
+            pht('The file associated with this version was not found.'));
         }
       }
 
diff --git a/src/applications/phragment/controller/PhragmentVersionController.php b/src/applications/phragment/controller/PhragmentVersionController.php
index 9267fdc5b1..e2906a7454 100644
--- a/src/applications/phragment/controller/PhragmentVersionController.php
+++ b/src/applications/phragment/controller/PhragmentVersionController.php
@@ -101,7 +101,7 @@ final class PhragmentVersionController extends PhragmentController {
 
     foreach ($previous_versions as $previous_version) {
       $item = id(new PHUIObjectItemView());
-      $item->setHeader('Version '.$previous_version->getSequence());
+      $item->setHeader(pht('Version %s', $previous_version->getSequence()));
       $item->setHref($previous_version->getURI());
       $item->addAttribute(phabricator_datetime(
         $previous_version->getDateCreated(),
@@ -117,8 +117,8 @@ final class PhragmentVersionController extends PhragmentController {
     }
 
     $item = id(new PHUIObjectItemView());
-    $item->setHeader('Prior to Version 0');
-    $item->addAttribute('Prior to any content (empty file)');
+    $item->setHeader(pht('Prior to Version 0'));
+    $item->addAttribute(pht('Prior to any content (empty file)'));
     $item->addAction(id(new PHUIListItemView())
       ->setIcon('fa-file-o')
       ->setName(pht('Get Patch'))
diff --git a/src/applications/phragment/storage/PhragmentFragment.php b/src/applications/phragment/storage/PhragmentFragment.php
index d58be033c0..1ab156e60f 100644
--- a/src/applications/phragment/storage/PhragmentFragment.php
+++ b/src/applications/phragment/storage/PhragmentFragment.php
@@ -142,7 +142,8 @@ final class PhragmentFragment extends PhragmentDAO
     PhabricatorFile $file) {
 
     if ($file->getMimeType() !== 'application/zip') {
-      throw new Exception("File must have mimetype 'application/zip'");
+      throw new Exception(
+        pht("File must have mimetype '%s'.", 'application/zip'));
     }
 
     // First apply the ZIP as normal.
@@ -160,7 +161,7 @@ final class PhragmentFragment extends PhragmentDAO
     $temp = new TempFile();
     Filesystem::writeFile($temp, $file->loadFileData());
     if (!$zip->open($temp)) {
-      throw new Exception('Unable to open ZIP');
+      throw new Exception(pht('Unable to open ZIP.'));
     }
 
     // Get all of the paths and their data from the ZIP.
diff --git a/src/applications/phrequent/conduit/PhrequentTrackingConduitAPIMethod.php b/src/applications/phrequent/conduit/PhrequentTrackingConduitAPIMethod.php
index f5391a56fb..4f73019544 100644
--- a/src/applications/phrequent/conduit/PhrequentTrackingConduitAPIMethod.php
+++ b/src/applications/phrequent/conduit/PhrequentTrackingConduitAPIMethod.php
@@ -8,8 +8,7 @@ final class PhrequentTrackingConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return pht(
-      'Returns current objects being tracked in Phrequent.');
+    return pht('Returns current objects being tracked in Phrequent.');
   }
 
   public function getMethodStatus() {
diff --git a/src/applications/phrequent/controller/PhrequentTrackController.php b/src/applications/phrequent/controller/PhrequentTrackController.php
index fd52bcea16..de0b75324c 100644
--- a/src/applications/phrequent/controller/PhrequentTrackController.php
+++ b/src/applications/phrequent/controller/PhrequentTrackController.php
@@ -49,8 +49,7 @@ final class PhrequentTrackController
           return $this->newDialog()
             ->setTitle(pht('Not Tracking Time'))
             ->appendParagraph(
-              pht(
-                'You are not currently tracking time on this object.'))
+              pht('You are not currently tracking time on this object.'))
             ->addCancelButton($done_uri);
         }
         break;
@@ -93,8 +92,7 @@ final class PhrequentTrackController
         if ($this->isStoppingTracking()) {
           $min_time = $current_timer->getDateStarted();
           if ($min_time > $timestamp->getEpoch()) {
-            $errors[] = pht(
-              'Stop time must be after start time.');
+            $errors[] = pht('Stop time must be after start time.');
             $e_date = pht('Invalid');
           }
         }
diff --git a/src/applications/phrequent/query/PhrequentUserTimeQuery.php b/src/applications/phrequent/query/PhrequentUserTimeQuery.php
index 61fa978165..d0d1160df0 100644
--- a/src/applications/phrequent/query/PhrequentUserTimeQuery.php
+++ b/src/applications/phrequent/query/PhrequentUserTimeQuery.php
@@ -111,7 +111,7 @@ final class PhrequentUserTimeQuery
           'dateEnded IS NULL');
         break;
       default:
-        throw new Exception("Unknown ended '{$this->ended}'!");
+        throw new Exception(pht("Unknown ended '%s'!", $this->ended));
     }
 
     $where[] = $this->buildPagingClause($conn);
diff --git a/src/applications/phriction/conduit/PhrictionHistoryConduitAPIMethod.php b/src/applications/phriction/conduit/PhrictionHistoryConduitAPIMethod.php
index 9a4098b5bd..454af2934a 100644
--- a/src/applications/phriction/conduit/PhrictionHistoryConduitAPIMethod.php
+++ b/src/applications/phriction/conduit/PhrictionHistoryConduitAPIMethod.php
@@ -22,7 +22,7 @@ final class PhrictionHistoryConduitAPIMethod extends PhrictionConduitAPIMethod {
 
   protected function defineErrorTypes() {
     return array(
-      'ERR-BAD-DOCUMENT' => 'No such document exists.',
+      'ERR-BAD-DOCUMENT' => pht('No such document exists.'),
     );
   }
 
diff --git a/src/applications/phriction/conduit/PhrictionInfoConduitAPIMethod.php b/src/applications/phriction/conduit/PhrictionInfoConduitAPIMethod.php
index 14e424e83c..60d9ece734 100644
--- a/src/applications/phriction/conduit/PhrictionInfoConduitAPIMethod.php
+++ b/src/applications/phriction/conduit/PhrictionInfoConduitAPIMethod.php
@@ -22,7 +22,7 @@ final class PhrictionInfoConduitAPIMethod extends PhrictionConduitAPIMethod {
 
   protected function defineErrorTypes() {
     return array(
-      'ERR-BAD-DOCUMENT' => 'No such document exists.',
+      'ERR-BAD-DOCUMENT' => pht('No such document exists.'),
     );
   }
 
diff --git a/src/applications/phriction/constants/PhrictionActionConstants.php b/src/applications/phriction/constants/PhrictionActionConstants.php
index 842962ca99..f39691181e 100644
--- a/src/applications/phriction/constants/PhrictionActionConstants.php
+++ b/src/applications/phriction/constants/PhrictionActionConstants.php
@@ -9,15 +9,15 @@ final class PhrictionActionConstants extends PhrictionConstants {
   const ACTION_MOVE_HERE = 'move here';
 
   public static function getActionPastTenseVerb($action) {
-    static $map = array(
-      self::ACTION_CREATE   => 'created',
-      self::ACTION_EDIT     => 'edited',
-      self::ACTION_DELETE   => 'deleted',
-      self::ACTION_MOVE_AWAY => 'moved',
-      self::ACTION_MOVE_HERE => 'moved',
+    $map = array(
+      self::ACTION_CREATE   => pht('created'),
+      self::ACTION_EDIT     => pht('edited'),
+      self::ACTION_DELETE   => pht('deleted'),
+      self::ACTION_MOVE_AWAY => pht('moved'),
+      self::ACTION_MOVE_HERE => pht('moved'),
     );
 
-    return idx($map, $action, "brazenly {$action}'d");
+    return idx($map, $action, pht("brazenly %s'd", $action));
   }
 
 }
diff --git a/src/applications/phriction/constants/PhrictionChangeType.php b/src/applications/phriction/constants/PhrictionChangeType.php
index 127c3e049f..1adf9ea6a4 100644
--- a/src/applications/phriction/constants/PhrictionChangeType.php
+++ b/src/applications/phriction/constants/PhrictionChangeType.php
@@ -9,15 +9,15 @@ final class PhrictionChangeType extends PhrictionConstants {
   const CHANGE_STUB       = 4;
 
   public static function getChangeTypeLabel($const) {
-    static $map = array(
-      self::CHANGE_EDIT       => 'Edit',
-      self::CHANGE_DELETE     => 'Delete',
-      self::CHANGE_MOVE_HERE  => 'Move Here',
-      self::CHANGE_MOVE_AWAY  => 'Move Away',
-      self::CHANGE_STUB       => 'Created through child',
+    $map = array(
+      self::CHANGE_EDIT       => pht('Edit'),
+      self::CHANGE_DELETE     => pht('Delete'),
+      self::CHANGE_MOVE_HERE  => pht('Move Here'),
+      self::CHANGE_MOVE_AWAY  => pht('Move Away'),
+      self::CHANGE_STUB       => pht('Created through child'),
     );
 
-    return idx($map, $const, '???');
+    return idx($map, $const, pht('Unknown'));
   }
 
 }
diff --git a/src/applications/phriction/controller/PhrictionDocumentController.php b/src/applications/phriction/controller/PhrictionDocumentController.php
index 1031a2a059..c96cbc57f8 100644
--- a/src/applications/phriction/controller/PhrictionDocumentController.php
+++ b/src/applications/phriction/controller/PhrictionDocumentController.php
@@ -146,7 +146,7 @@ final class PhrictionDocumentController
 
         $core_content = $notice->render();
       } else {
-        throw new Exception("Unknown document status '{$doc_status}'!");
+        throw new Exception(pht("Unknown document status '%s'!", $doc_status));
       }
 
       $move_notice = null;
diff --git a/src/applications/phriction/controller/PhrictionEditController.php b/src/applications/phriction/controller/PhrictionEditController.php
index d09afb9746..7ee98120b1 100644
--- a/src/applications/phriction/controller/PhrictionEditController.php
+++ b/src/applications/phriction/controller/PhrictionEditController.php
@@ -96,10 +96,13 @@ final class PhrictionEditController
 
       $draft_note = new PHUIInfoView();
       $draft_note->setSeverity(PHUIInfoView::SEVERITY_NOTICE);
-      $draft_note->setTitle('Recovered Draft');
-      $draft_note->appendChild(hsprintf(
-        '<p>Showing a saved draft of your edits, you can %s.</p>',
-        $discard));
+      $draft_note->setTitle(pht('Recovered Draft'));
+      $draft_note->appendChild(
+        hsprintf(
+          '<p>%s</p>',
+          pht(
+            'Showing a saved draft of your edits, you can %s.',
+            $discard)));
     } else {
       $content_text = $content->getContent();
       $draft_note = null;
diff --git a/src/applications/phriction/controller/PhrictionHistoryController.php b/src/applications/phriction/controller/PhrictionHistoryController.php
index e9daa2be41..ef30382b76 100644
--- a/src/applications/phriction/controller/PhrictionHistoryController.php
+++ b/src/applications/phriction/controller/PhrictionHistoryController.php
@@ -87,7 +87,7 @@ final class PhrictionHistoryController
           $color = 'green';
           break;
         default:
-          throw new Exception('Unknown change type!');
+          throw new Exception(pht('Unknown change type!'));
           break;
       }
 
diff --git a/src/applications/phriction/mail/PhrictionReplyHandler.php b/src/applications/phriction/mail/PhrictionReplyHandler.php
index 0cb9e8f79c..7929349e6d 100644
--- a/src/applications/phriction/mail/PhrictionReplyHandler.php
+++ b/src/applications/phriction/mail/PhrictionReplyHandler.php
@@ -5,7 +5,8 @@ final class PhrictionReplyHandler
 
   public function validateMailReceiver($mail_receiver) {
     if (!($mail_receiver instanceof PhrictionDocument)) {
-      throw new Exception('Mail receiver is not a PhrictionDocument!');
+      throw new Exception(
+        pht('Mail receiver is not a %s!', 'PhrictionDocument'));
     }
   }
 
diff --git a/src/applications/phriction/query/PhrictionDocumentQuery.php b/src/applications/phriction/query/PhrictionDocumentQuery.php
index b4e80af936..63d1764a9a 100644
--- a/src/applications/phriction/query/PhrictionDocumentQuery.php
+++ b/src/applications/phriction/query/PhrictionDocumentQuery.php
@@ -271,7 +271,7 @@ final class PhrictionDocumentQuery
       case self::STATUS_ANY:
         break;
       default:
-        throw new Exception("Unknown status '{$this->status}'!");
+        throw new Exception(pht("Unknown status '%s'!", $this->status));
     }
 
     $where[] = $this->buildPagingClause($conn);
diff --git a/src/applications/phriction/storage/PhrictionDocument.php b/src/applications/phriction/storage/PhrictionDocument.php
index 34b3bf6eca..f274d87ad4 100644
--- a/src/applications/phriction/storage/PhrictionDocument.php
+++ b/src/applications/phriction/storage/PhrictionDocument.php
@@ -101,7 +101,7 @@ final class PhrictionDocument extends PhrictionDAO
     );
 
     if (empty($types[$type])) {
-      throw new Exception("Unknown URI type '{$type}'!");
+      throw new Exception(pht("Unknown URI type '%s'!", $type));
     }
 
     $prefix = $types[$type];
diff --git a/src/applications/policy/__tests__/PhabricatorPolicyTestCase.php b/src/applications/policy/__tests__/PhabricatorPolicyTestCase.php
index dca7711566..327c8a2856 100644
--- a/src/applications/policy/__tests__/PhabricatorPolicyTestCase.php
+++ b/src/applications/policy/__tests__/PhabricatorPolicyTestCase.php
@@ -16,7 +16,7 @@ final class PhabricatorPolicyTestCase extends PhabricatorTestCase {
         'user'    => true,
         'admin'   => true,
       ),
-      'Public Policy (Enabled in Config)');
+      pht('Public Policy (Enabled in Config)'));
   }
 
 
@@ -35,7 +35,7 @@ final class PhabricatorPolicyTestCase extends PhabricatorTestCase {
         'user'    => true,
         'admin'   => true,
       ),
-      'Public Policy (Disabled in Config)');
+      pht('Public Policy (Disabled in Config)'));
   }
 
 
@@ -51,7 +51,7 @@ final class PhabricatorPolicyTestCase extends PhabricatorTestCase {
         'user'    => true,
         'admin'   => true,
       ),
-      'User Policy');
+      pht('User Policy'));
   }
 
 
@@ -66,7 +66,7 @@ final class PhabricatorPolicyTestCase extends PhabricatorTestCase {
         'user'    => false,
         'admin'   => true,
       ),
-      'Admin Policy');
+      pht('Admin Policy'));
   }
 
 
@@ -81,7 +81,7 @@ final class PhabricatorPolicyTestCase extends PhabricatorTestCase {
         'user'    => false,
         'admin'   => false,
       ),
-      'No One Policy');
+      pht('No One Policy'));
   }
 
 
@@ -105,22 +105,22 @@ final class PhabricatorPolicyTestCase extends PhabricatorTestCase {
     $this->assertEqual(
       3,
       count($query->setLimit(3)->setOffset(0)->execute()),
-      'Invisible objects are ignored.');
+      pht('Invisible objects are ignored.'));
 
     $this->assertEqual(
       0,
       count($query->setLimit(3)->setOffset(3)->execute()),
-      'Offset pages through visible objects only.');
+      pht('Offset pages through visible objects only.'));
 
     $this->assertEqual(
       2,
       count($query->setLimit(3)->setOffset(1)->execute()),
-      'Offsets work correctly.');
+      pht('Offsets work correctly.'));
 
     $this->assertEqual(
       2,
       count($query->setLimit(0)->setOffset(1)->execute()),
-      'Offset with no limit works.');
+      pht('Offset with no limit works.'));
   }
 
 
@@ -144,12 +144,12 @@ final class PhabricatorPolicyTestCase extends PhabricatorTestCase {
     $this->assertEqual(
       3,
       count($query->setLimit(3)->setOffset(0)->execute()),
-      'Limits work.');
+      pht('Limits work.'));
 
     $this->assertEqual(
       2,
       count($query->setLimit(3)->setOffset(4)->execute()),
-      'Limit + offset work.');
+      pht('Limit + offset work.'));
   }
 
 
@@ -185,7 +185,7 @@ final class PhabricatorPolicyTestCase extends PhabricatorTestCase {
         'user'    => false,
         'admin'   => false,
       ),
-      'Invalid Policy');
+      pht('Invalid Policy'));
   }
 
 
@@ -222,7 +222,10 @@ final class PhabricatorPolicyTestCase extends PhabricatorTestCase {
       }
       $this->assertTrue(
         (bool)PhabricatorApplication::getByClass($class),
-        "Application class '{$class}' for query '{$qclass}'");
+        pht(
+          "Application class '%s' for query '%s'.",
+          $class,
+          $qclass));
     }
   }
 
@@ -281,11 +284,11 @@ final class PhabricatorPolicyTestCase extends PhabricatorTestCase {
         $this->assertEqual(
           $object,
           $result,
-          "{$description} with user {$spec} should succeed.");
+          pht('%s with user %s should succeed.', $description, $spec));
       } else {
         $this->assertTrue(
           $caught instanceof PhabricatorPolicyException,
-          "{$description} with user {$spec} should fail.");
+          pht('%s with user %s should fail.', $description, $spec));
       }
     }
   }
@@ -326,7 +329,7 @@ final class PhabricatorPolicyTestCase extends PhabricatorTestCase {
         $user->setIsAdmin(true);
         break;
       default:
-        throw new Exception("Unknown user spec '{$spec}'.");
+        throw new Exception(pht("Unknown user spec '%s'.", $spec));
     }
 
     return $user;
diff --git a/src/applications/policy/capability/PhabricatorPolicyCapability.php b/src/applications/policy/capability/PhabricatorPolicyCapability.php
index 346a6fb4e1..a9af1fa00c 100644
--- a/src/applications/policy/capability/PhabricatorPolicyCapability.php
+++ b/src/applications/policy/capability/PhabricatorPolicyCapability.php
@@ -21,16 +21,20 @@ abstract class PhabricatorPolicyCapability extends Phobject {
     if ($const === false) {
       throw new Exception(
         pht(
-          'PolicyCapability class "%s" must define an CAPABILITY property.',
-          get_class($this)));
+          '%s class "%s" must define a %s property.',
+          __CLASS__,
+          get_class($this),
+          'CAPABILITY'));
     }
 
     if (!is_string($const)) {
       throw new Exception(
         pht(
-          'PolicyCapability class "%s" has an invalid CAPABILITY '.
-          'property. Capability constants must be a string.',
-          get_class($this)));
+          '%s class "%s" has an invalid %s property. '.
+          'Capability constants must be a string.',
+          __CLASS__,
+          get_class($this),
+          'CAPABILITY'));
     }
 
     return $const;
diff --git a/src/applications/policy/config/PhabricatorPolicyConfigOptions.php b/src/applications/policy/config/PhabricatorPolicyConfigOptions.php
index 2b47ae8d80..1c3698c4cd 100644
--- a/src/applications/policy/config/PhabricatorPolicyConfigOptions.php
+++ b/src/applications/policy/config/PhabricatorPolicyConfigOptions.php
@@ -63,8 +63,9 @@ final class PhabricatorPolicyConfigOptions
           'users can take certain actions, such as creating new users. '."\n\n".
           'This setting allows for "locking" these policies such that no '.
           'further edits can be made on a per-policy basis.'))
-          ->addExample($policy_locked_example,
-                       pht('Lock Create User Policy To Admins')),
+          ->addExample(
+            $policy_locked_example,
+            pht('Lock Create User Policy To Admins')),
     );
   }
 
diff --git a/src/applications/policy/config/PolicyLockOptionType.php b/src/applications/policy/config/PolicyLockOptionType.php
index 3198a927c2..e9a51d706c 100644
--- a/src/applications/policy/config/PolicyLockOptionType.php
+++ b/src/applications/policy/config/PolicyLockOptionType.php
@@ -13,8 +13,10 @@ final class PolicyLockOptionType
     foreach ($value as $capability_key => $policy) {
       $capability = idx($capabilities, $capability_key);
       if (!$capability) {
-        throw new Exception(pht(
-          'Capability "%s" does not exist.', $capability_key));
+        throw new Exception(
+          pht(
+            'Capability "%s" does not exist.',
+            $capability_key));
       }
       if (phid_get_type($policy) !=
           PhabricatorPHIDConstants::PHID_TYPE_UNKNOWN) {
@@ -25,18 +27,20 @@ final class PolicyLockOptionType
         // this exception is not helpful here as its about global policy;
         // throw a better exception
         } catch (Exception $ex) {
-          throw new Exception(pht(
-            'Capability "%s" has invalid policy "%s".',
-            $capability_key,
-            $policy));
+          throw new Exception(
+            pht(
+              'Capability "%s" has invalid policy "%s".',
+              $capability_key,
+              $policy));
         }
       }
 
       if ($policy == PhabricatorPolicies::POLICY_PUBLIC) {
         if (!$capability->shouldAllowPublicPolicySetting()) {
-          throw new Exception(pht(
-            'Capability "%s" does not support public policy.',
-            $capability_key));
+          throw new Exception(
+            pht(
+              'Capability "%s" does not support public policy.',
+              $capability_key));
         }
       }
     }
@@ -50,11 +54,12 @@ final class PolicyLockOptionType
       foreach ($value as $capability_key => $policy) {
         $handle = $handles[$policy];
         if (!$handle->isComplete()) {
-          throw new Exception(pht(
-            'Capability "%s" has invalid policy "%s"; "%s" does not exist.',
-            $capability_key,
-            $policy,
-            $policy));
+          throw new Exception(
+            pht(
+              'Capability "%s" has invalid policy "%s"; "%s" does not exist.',
+              $capability_key,
+              $policy,
+              $policy));
         }
       }
     }
diff --git a/src/applications/policy/controller/PhabricatorPolicyEditController.php b/src/applications/policy/controller/PhabricatorPolicyEditController.php
index 4c044a6dc7..80b04e4ea7 100644
--- a/src/applications/policy/controller/PhabricatorPolicyEditController.php
+++ b/src/applications/policy/controller/PhabricatorPolicyEditController.php
@@ -63,12 +63,12 @@ final class PhabricatorPolicyEditController
           case 'deny':
             break;
           default:
-            throw new Exception("Invalid action '{$action}'!");
+            throw new Exception(pht("Invalid action '%s'!", $action));
         }
 
         $rule_class = idx($rule, 'rule');
         if (empty($rules[$rule_class])) {
-          throw new Exception("Invalid rule class '{$rule_class}'!");
+          throw new Exception(pht("Invalid rule class '%s'!", $rule_class));
         }
 
         $rule_obj = $rules[$rule_class];
@@ -163,8 +163,7 @@ final class PhabricatorPolicyEditController
                 'mustcapture' => true,
               ),
               pht('New Rule')))
-          ->setDescription(
-            pht('These rules are processed in order.'))
+          ->setDescription(pht('These rules are processed in order.'))
           ->setContent(javelin_tag(
             'table',
             array(
diff --git a/src/applications/policy/filter/PhabricatorPolicyFilter.php b/src/applications/policy/filter/PhabricatorPolicyFilter.php
index 7373991fd8..8d52ddc044 100644
--- a/src/applications/policy/filter/PhabricatorPolicyFilter.php
+++ b/src/applications/policy/filter/PhabricatorPolicyFilter.php
@@ -17,8 +17,10 @@ final class PhabricatorPolicyFilter {
 
     if (!self::hasCapability($user, $object, $capability)) {
       throw new Exception(
-        "You can not make that edit, because it would remove your ability ".
-        "to '{$capability}' the object.");
+        pht(
+          "You can not make that edit, because it would remove your ability ".
+          "to '%s' the object.",
+          $capability));
     }
   }
 
@@ -110,8 +112,7 @@ final class PhabricatorPolicyFilter {
     $capabilities = $this->capabilities;
 
     if (!$viewer || !$capabilities) {
-      throw new Exception(
-        'Call setViewer() and requireCapabilities() before apply()!');
+      throw new PhutilInvalidStateException('setViewer', 'requireCapabilities');
     }
 
     // If the viewer is omnipotent, short circuit all the checks and just
@@ -135,8 +136,10 @@ final class PhabricatorPolicyFilter {
       foreach ($capabilities as $capability) {
         if (!in_array($capability, $object_capabilities)) {
           throw new Exception(
-            "Testing for capability '{$capability}' on an object which does ".
-            "not have that capability!");
+            pht(
+              "Testing for capability '%s' on an object which does ".
+              "not have that capability!",
+              $capability));
         }
 
         $policy = $this->getObjectPolicy($object, $capability);
diff --git a/src/applications/policy/management/PhabricatorPolicyManagementShowWorkflow.php b/src/applications/policy/management/PhabricatorPolicyManagementShowWorkflow.php
index e6d2741bfa..1529d4904c 100644
--- a/src/applications/policy/management/PhabricatorPolicyManagementShowWorkflow.php
+++ b/src/applications/policy/management/PhabricatorPolicyManagementShowWorkflow.php
@@ -6,9 +6,8 @@ final class PhabricatorPolicyManagementShowWorkflow
   protected function didConstruct() {
     $this
       ->setName('show')
-      ->setSynopsis('Show policy information about an object.')
-      ->setExamples(
-        '**show** D123')
+      ->setSynopsis(pht('Show policy information about an object.'))
+      ->setExamples('**show** D123')
       ->setArguments(
         array(
           array(
@@ -25,8 +24,7 @@ final class PhabricatorPolicyManagementShowWorkflow
     $obj_names = $args->getArg('objects');
     if (!$obj_names) {
       throw new PhutilArgumentUsageException(
-        pht(
-          'Specify the name of an object to show policy information for.'));
+        pht('Specify the name of an object to show policy information for.'));
     } else if (count($obj_names) > 1) {
       throw new PhutilArgumentUsageException(
         pht(
diff --git a/src/applications/policy/management/PhabricatorPolicyManagementUnlockWorkflow.php b/src/applications/policy/management/PhabricatorPolicyManagementUnlockWorkflow.php
index 22e4984528..33f7e209c2 100644
--- a/src/applications/policy/management/PhabricatorPolicyManagementUnlockWorkflow.php
+++ b/src/applications/policy/management/PhabricatorPolicyManagementUnlockWorkflow.php
@@ -7,10 +7,10 @@ final class PhabricatorPolicyManagementUnlockWorkflow
     $this
       ->setName('unlock')
       ->setSynopsis(
-        'Unlock an object by setting its policies to allow anyone to view '.
-        'and edit it.')
-      ->setExamples(
-        '**unlock** D123')
+        pht(
+          'Unlock an object by setting its policies to allow anyone to view '.
+          'and edit it.'))
+      ->setExamples('**unlock** D123')
       ->setArguments(
         array(
           array(
@@ -27,12 +27,10 @@ final class PhabricatorPolicyManagementUnlockWorkflow
     $obj_names = $args->getArg('objects');
     if (!$obj_names) {
       throw new PhutilArgumentUsageException(
-        pht(
-          'Specify the name of an object to unlock.'));
+        pht('Specify the name of an object to unlock.'));
     } else if (count($obj_names) > 1) {
       throw new PhutilArgumentUsageException(
-        pht(
-          'Specify the name of exactly one object to unlock.'));
+        pht('Specify the name of exactly one object to unlock.'));
     }
 
     $object = id(new PhabricatorObjectQuery())
@@ -43,9 +41,7 @@ final class PhabricatorPolicyManagementUnlockWorkflow
     if (!$object) {
       $name = head($obj_names);
       throw new PhutilArgumentUsageException(
-        pht(
-          "No such object '%s'!",
-          $name));
+        pht("No such object '%s'!", $name));
     }
 
     $handle = id(new PhabricatorHandleQuery())
diff --git a/src/applications/policy/query/PhabricatorPolicyQuery.php b/src/applications/policy/query/PhabricatorPolicyQuery.php
index 01e2e2beab..6a5c2219df 100644
--- a/src/applications/policy/query/PhabricatorPolicyQuery.php
+++ b/src/applications/policy/query/PhabricatorPolicyQuery.php
@@ -56,8 +56,10 @@ final class PhabricatorPolicyQuery
   protected function loadPage() {
     if ($this->object && $this->phids) {
       throw new Exception(
-        'You can not issue a policy query with both setObject() and '.
-        'setPHIDs().');
+        pht(
+          'You can not issue a policy query with both %s and %s.',
+          'setObject()',
+          'setPHIDs()'));
     } else if ($this->object) {
       $phids = $this->loadObjectPolicyPHIDs();
     } else {
@@ -128,7 +130,7 @@ final class PhabricatorPolicyQuery
 
   public static function getGlobalPolicy($policy) {
     if (!self::isGlobalPolicy($policy)) {
-      throw new Exception("Policy '{$policy}' is not a global policy!");
+      throw new Exception(pht("Policy '%s' is not a global policy!", $policy));
     }
     return idx(self::getGlobalPolicies(), $policy);
   }
diff --git a/src/applications/policy/storage/PhabricatorPolicy.php b/src/applications/policy/storage/PhabricatorPolicy.php
index 7c8186124e..c83d09ab5d 100644
--- a/src/applications/policy/storage/PhabricatorPolicy.php
+++ b/src/applications/policy/storage/PhabricatorPolicy.php
@@ -56,17 +56,21 @@ final class PhabricatorPolicy
 
     if (!$handle) {
       throw new Exception(
-        "Policy identifier is an object PHID ('{$policy_identifier}'), but no ".
-        "object handle was provided. A handle must be provided for object ".
-        "policies.");
+        pht(
+          "Policy identifier is an object PHID ('%s'), but no object handle ".
+          "was provided. A handle must be provided for object policies.",
+          $policy_identifier));
     }
 
     $handle_phid = $handle->getPHID();
     if ($policy_identifier != $handle_phid) {
       throw new Exception(
-        "Policy identifier is an object PHID ('{$policy_identifier}'), but ".
-        "the provided handle has a different PHID ('{$handle_phid}'). The ".
-        "handle must correspond to the policy identifier.");
+        pht(
+          "Policy identifier is an object PHID ('%s'), but the provided ".
+          "handle has a different PHID ('%s'). The handle must correspond ".
+          "to the policy identifier.",
+          $policy_identifier,
+          $handle_phid));
     }
 
     $policy = id(new PhabricatorPolicy())
diff --git a/src/applications/ponder/application/PhabricatorPonderApplication.php b/src/applications/ponder/application/PhabricatorPonderApplication.php
index e21660301c..999580e90b 100644
--- a/src/applications/ponder/application/PhabricatorPonderApplication.php
+++ b/src/applications/ponder/application/PhabricatorPonderApplication.php
@@ -29,8 +29,8 @@ final class PhabricatorPonderApplication extends PhabricatorApplication {
   }
 
   public function loadStatus(PhabricatorUser $user) {
-    // replace with "x new unanswered questions" or some such
-    // make sure to use self::formatStatusCount and friends...!
+    // Replace with "x new unanswered questions" or some such
+    // make sure to use `self::formatStatusCount` and friends...!
     $status = array();
 
     return $status;
diff --git a/src/applications/ponder/constants/PonderQuestionStatus.php b/src/applications/ponder/constants/PonderQuestionStatus.php
index 8d2a878234..3877380b30 100644
--- a/src/applications/ponder/constants/PonderQuestionStatus.php
+++ b/src/applications/ponder/constants/PonderQuestionStatus.php
@@ -17,7 +17,7 @@ final class PonderQuestionStatus extends PonderConstants {
       self::STATUS_OPEN     => pht('Open'),
       self::STATUS_CLOSED   => pht('Closed by author'),
     );
-    return idx($map, $status, '???');
+    return idx($map, $status, pht('Unknown'));
   }
 
   public static function getQuestionStatusTagColor($status) {
diff --git a/src/applications/ponder/controller/PonderAnswerSaveController.php b/src/applications/ponder/controller/PonderAnswerSaveController.php
index b720015ff0..53e9367edd 100644
--- a/src/applications/ponder/controller/PonderAnswerSaveController.php
+++ b/src/applications/ponder/controller/PonderAnswerSaveController.php
@@ -27,8 +27,7 @@ final class PonderAnswerSaveController extends PonderController {
         ->setUser($viewer)
         ->setTitle(pht('Empty Answer'))
         ->appendChild(
-          phutil_tag('p', array(), pht(
-          'Your answer must not be empty.')))
+          phutil_tag('p', array(), pht('Your answer must not be empty.')))
         ->addCancelButton('/Q'.$question_id);
 
       return id(new AphrontDialogResponse())->setDialog($dialog);
diff --git a/src/applications/ponder/editor/PonderVoteEditor.php b/src/applications/ponder/editor/PonderVoteEditor.php
index cc9f89d9fe..2edb186787 100644
--- a/src/applications/ponder/editor/PonderVoteEditor.php
+++ b/src/applications/ponder/editor/PonderVoteEditor.php
@@ -25,7 +25,7 @@ final class PonderVoteEditor extends PhabricatorEditor {
   public function saveVote() {
     $actor = $this->requireActor();
     if (!$this->votable) {
-      throw new Exception('Must set votable before saving vote');
+      throw new Exception(pht('Must set votable before saving vote.'));
     }
 
     $votable = $this->votable;
@@ -58,7 +58,7 @@ final class PonderVoteEditor extends PhabricatorEditor {
         $curvote = PonderVote::VOTE_NONE;
       }
 
-      // adjust votable's score by this much
+      // Adjust votable's score by this much.
       $delta = $newvote - $curvote;
 
       queryfx($conn,
diff --git a/src/applications/ponder/mail/PonderQuestionReplyHandler.php b/src/applications/ponder/mail/PonderQuestionReplyHandler.php
index 699d7cd79d..5d39782209 100644
--- a/src/applications/ponder/mail/PonderQuestionReplyHandler.php
+++ b/src/applications/ponder/mail/PonderQuestionReplyHandler.php
@@ -5,7 +5,7 @@ final class PonderQuestionReplyHandler
 
   public function validateMailReceiver($mail_receiver) {
     if (!($mail_receiver instanceof PonderQuestion)) {
-      throw new Exception('Mail receiver is not a PonderQuestion!');
+      throw new Exception(pht('Mail receiver is not a %s!', 'PonderQuestion'));
     }
   }
 
diff --git a/src/applications/ponder/phid/PonderAnswerPHIDType.php b/src/applications/ponder/phid/PonderAnswerPHIDType.php
index c292b10b87..0bb0596737 100644
--- a/src/applications/ponder/phid/PonderAnswerPHIDType.php
+++ b/src/applications/ponder/phid/PonderAnswerPHIDType.php
@@ -32,7 +32,7 @@ final class PonderAnswerPHIDType extends PhabricatorPHIDType {
       $question = $answer->getQuestion();
       $question_title = $question->getFullTitle();
 
-      $handle->setName("{$question_title} (Answer {$id})");
+      $handle->setName(pht('%s (Answer %s)', $question_title, $id));
       $handle->setURI($answer->getURI());
     }
   }
diff --git a/src/applications/ponder/query/PonderQuestionQuery.php b/src/applications/ponder/query/PonderQuestionQuery.php
index 51081b3203..b63ba60def 100644
--- a/src/applications/ponder/query/PonderQuestionQuery.php
+++ b/src/applications/ponder/query/PonderQuestionQuery.php
@@ -92,7 +92,7 @@ final class PonderQuestionQuery
             PonderQuestionStatus::STATUS_CLOSED);
           break;
         default:
-          throw new Exception("Unknown status query '{$this->status}'!");
+          throw new Exception(pht("Unknown status query '%s'!", $this->status));
       }
     }
 
diff --git a/src/applications/ponder/storage/PonderQuestion.php b/src/applications/ponder/storage/PonderQuestion.php
index 8c8dab3f44..1568c59245 100644
--- a/src/applications/ponder/storage/PonderQuestion.php
+++ b/src/applications/ponder/storage/PonderQuestion.php
@@ -251,8 +251,7 @@ final class PonderQuestion extends PonderDAO
 
 
   public function describeAutomaticCapability($capability) {
-    return pht(
-      'The user who asked a question can always view and edit it.');
+    return pht('The user who asked a question can always view and edit it.');
   }
 
 
diff --git a/src/applications/ponder/storage/PonderQuestionTransaction.php b/src/applications/ponder/storage/PonderQuestionTransaction.php
index 5fe3bc266a..0e4d07b150 100644
--- a/src/applications/ponder/storage/PonderQuestionTransaction.php
+++ b/src/applications/ponder/storage/PonderQuestionTransaction.php
@@ -295,7 +295,7 @@ final class PonderQuestionTransaction
 
     if (count($add) != 1) {
       throw new Exception(
-        'There should be only one answer added at a time.');
+        pht('There should be only one answer added at a time.'));
     }
 
     return reset($add);
@@ -303,7 +303,7 @@ final class PonderQuestionTransaction
 
   /**
    * Generally, the answer object is only available if the transaction
-   * type is self::TYPE_ANSWERS.
+   * type is `self::TYPE_ANSWERS`.
    *
    * Some stories - notably ones made before D7027 - will be of the more
    * generic @{class:PhabricatorApplicationTransactionFeedStory}. These
diff --git a/src/applications/project/conduit/ProjectQueryConduitAPIMethod.php b/src/applications/project/conduit/ProjectQueryConduitAPIMethod.php
index 1f2078ff67..f65578e349 100644
--- a/src/applications/project/conduit/ProjectQueryConduitAPIMethod.php
+++ b/src/applications/project/conduit/ProjectQueryConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class ProjectQueryConduitAPIMethod extends ProjectConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Execute searches for Projects.';
+    return pht('Execute searches for Projects.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/project/editor/__tests__/PhabricatorProjectEditorTestCase.php b/src/applications/project/editor/__tests__/PhabricatorProjectEditorTestCase.php
index 3af09a4547..876ed9d0d7 100644
--- a/src/applications/project/editor/__tests__/PhabricatorProjectEditorTestCase.php
+++ b/src/applications/project/editor/__tests__/PhabricatorProjectEditorTestCase.php
@@ -100,11 +100,13 @@ final class PhabricatorProjectEditorTestCase extends PhabricatorTestCase {
     $proj = $this->refreshProject($proj, $user, true);
     $this->assertTrue(
       (bool)$proj,
-      'Assumption that projects are default visible to any user when created.');
+      pht(
+        'Assumption that projects are default visible '.
+        'to any user when created.'));
 
     $this->assertFalse(
       $proj->isUserMember($user->getPHID()),
-      'Arbitrary user not member of project.');
+      pht('Arbitrary user not member of project.'));
 
     // Join the project.
     $this->joinProject($proj, $user);
@@ -114,7 +116,7 @@ final class PhabricatorProjectEditorTestCase extends PhabricatorTestCase {
 
     $this->assertTrue(
       $proj->isUserMember($user->getPHID()),
-      'Join works.');
+      pht('Join works.'));
 
 
     // Join the project again.
@@ -125,7 +127,7 @@ final class PhabricatorProjectEditorTestCase extends PhabricatorTestCase {
 
     $this->assertTrue(
       $proj->isUserMember($user->getPHID()),
-      'Joining an already-joined project is a no-op.');
+      pht('Joining an already-joined project is a no-op.'));
 
 
     // Leave the project.
@@ -136,7 +138,7 @@ final class PhabricatorProjectEditorTestCase extends PhabricatorTestCase {
 
     $this->assertFalse(
       $proj->isUserMember($user->getPHID()),
-      'Leave works.');
+      pht('Leave works.'));
 
 
     // Leave the project again.
@@ -147,7 +149,7 @@ final class PhabricatorProjectEditorTestCase extends PhabricatorTestCase {
 
     $this->assertFalse(
       $proj->isUserMember($user->getPHID()),
-      'Leaving an already-left project is a no-op.');
+      pht('Leaving an already-left project is a no-op.'));
 
 
     // If a user can't edit or join a project, joining fails.
@@ -175,7 +177,7 @@ final class PhabricatorProjectEditorTestCase extends PhabricatorTestCase {
     $proj = $this->refreshProject($proj, $user, true);
     $this->assertTrue(
       $proj->isUserMember($user->getPHID()),
-      'Join allowed with edit permission.');
+      pht('Join allowed with edit permission.'));
     $this->leaveProject($proj, $user);
 
 
@@ -189,7 +191,7 @@ final class PhabricatorProjectEditorTestCase extends PhabricatorTestCase {
     $proj = $this->refreshProject($proj, $user, true);
     $this->assertTrue(
       $proj->isUserMember($user->getPHID()),
-      'Join allowed with join permission.');
+      pht('Join allowed with join permission.'));
 
 
     // A user can leave a project even if they can't edit it or join.
@@ -202,7 +204,7 @@ final class PhabricatorProjectEditorTestCase extends PhabricatorTestCase {
     $proj = $this->refreshProject($proj, $user, true);
     $this->assertFalse(
       $proj->isUserMember($user->getPHID()),
-      'Leave allowed without any permission.');
+      pht('Leave allowed without any permission.'));
   }
 
   private function refreshProject(
diff --git a/src/applications/project/mail/ProjectReplyHandler.php b/src/applications/project/mail/ProjectReplyHandler.php
index ac2cf2b6eb..7358a36072 100644
--- a/src/applications/project/mail/ProjectReplyHandler.php
+++ b/src/applications/project/mail/ProjectReplyHandler.php
@@ -5,7 +5,8 @@ final class ProjectReplyHandler
 
   public function validateMailReceiver($mail_receiver) {
     if (!($mail_receiver instanceof PhabricatorProject)) {
-      throw new Exception('Mail receiver is not a PhabricatorProject.');
+      throw new Exception(
+        pht('Mail receiver is not a %s.', 'PhabricatorProject'));
     }
   }
 
diff --git a/src/applications/project/query/PhabricatorProjectQuery.php b/src/applications/project/query/PhabricatorProjectQuery.php
index ff35837078..a393130221 100644
--- a/src/applications/project/query/PhabricatorProjectQuery.php
+++ b/src/applications/project/query/PhabricatorProjectQuery.php
@@ -259,7 +259,9 @@ final class PhabricatorProjectQuery
           break;
         default:
           throw new Exception(
-            "Unknown project status '{$this->status}'!");
+            pht(
+              "Unknown project status '%s'!",
+              $this->status));
       }
       $where[] = qsprintf(
         $conn_r,
diff --git a/src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php b/src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php
index 437b025491..80e809aba9 100644
--- a/src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php
+++ b/src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php
@@ -101,7 +101,7 @@ final class ProjectRemarkupRuleTestCase extends PhabricatorTestCase {
         ),
       ),
 
-      'This is \'#urgent\'.' => array(
+      "This is '#urgent'." => array(
         'embed' => array(),
         'ref' => array(
           array(
diff --git a/src/applications/project/storage/PhabricatorProjectTransaction.php b/src/applications/project/storage/PhabricatorProjectTransaction.php
index 692c41d736..c8698dbe6b 100644
--- a/src/applications/project/storage/PhabricatorProjectTransaction.php
+++ b/src/applications/project/storage/PhabricatorProjectTransaction.php
@@ -129,16 +129,16 @@ final class PhabricatorProjectTransaction
         // TODO: Some day, it would be nice to show the images.
         if (!$old) {
           return pht(
-            '%s set this project\'s image to %s.',
+            "%s set this project's image to %s.",
             $author_handle,
             $this->renderHandleLink($new));
         } else if (!$new) {
           return pht(
-            '%s removed this project\'s image.',
+            "%s removed this project's image.",
             $author_handle);
         } else {
           return pht(
-            '%s updated this project\'s image from %s to %s.',
+            "%s updated this project's image from %s to %s.",
             $author_handle,
             $this->renderHandleLink($old),
             $this->renderHandleLink($new));
@@ -147,14 +147,14 @@ final class PhabricatorProjectTransaction
 
       case self::TYPE_ICON:
         return pht(
-          '%s set this project\'s icon to %s.',
+          "%s set this project's icon to %s.",
           $author_handle,
           PhabricatorProjectIcon::getLabel($new));
         break;
 
       case self::TYPE_COLOR:
         return pht(
-          '%s set this project\'s color to %s.',
+          "%s set this project's color to %s.",
           $author_handle,
           PHUITagView::getShadeName($new));
         break;
@@ -162,11 +162,11 @@ final class PhabricatorProjectTransaction
       case self::TYPE_LOCKED:
         if ($new) {
           return pht(
-            '%s locked this project\'s membership.',
+            "%s locked this project's membership.",
             $author_handle);
         } else {
           return pht(
-            '%s unlocked this project\'s membership.',
+            "%s unlocked this project's membership.",
             $author_handle);
         }
         break;
diff --git a/src/applications/project/typeahead/PhabricatorProjectLogicalUserDatasource.php b/src/applications/project/typeahead/PhabricatorProjectLogicalUserDatasource.php
index d2cb58a7ee..3b02195c25 100644
--- a/src/applications/project/typeahead/PhabricatorProjectLogicalUserDatasource.php
+++ b/src/applications/project/typeahead/PhabricatorProjectLogicalUserDatasource.php
@@ -28,13 +28,12 @@ final class PhabricatorProjectLogicalUserDatasource
         'arguments' => pht('username'),
         'summary' => pht("Find results in any of a user's projects."),
         'description' => pht(
-          'This function allows you to find results associated with any '.
-          'of the projects a specified user is a member of. For example, '.
-          'this will find results associated with all of the projects '.
-          '`alincoln` is a member of:'.
-          "\n\n".
-          '> projects(alincoln)'.
-          "\n\n"),
+          "This function allows you to find results associated with any ".
+          "of the projects a specified user is a member of. For example, ".
+          "this will find results associated with all of the projects ".
+          "`%s` is a member of:\n\n%s\n\n",
+          'alincoln',
+          '> projects(alincoln)'),
       ),
     );
   }
diff --git a/src/applications/project/typeahead/PhabricatorProjectNoProjectsDatasource.php b/src/applications/project/typeahead/PhabricatorProjectNoProjectsDatasource.php
index 731f39efd0..156f04605f 100644
--- a/src/applications/project/typeahead/PhabricatorProjectNoProjectsDatasource.php
+++ b/src/applications/project/typeahead/PhabricatorProjectNoProjectsDatasource.php
@@ -21,12 +21,11 @@ final class PhabricatorProjectNoProjectsDatasource
         'name' => pht('Not In Any Projects'),
         'summary' => pht('Find results which are not in any projects.'),
         'description' => pht(
-          'This function matches results which are not associated with any '.
-          'projects. It is usually most often used to find objects which '.
-          'might have slipped through the cracks and not been organized '.
-          'properly.'.
-          "\n\n".
-          "> null()"),
+          "This function matches results which are not associated with any ".
+          "projects. It is usually most often used to find objects which ".
+          "might have slipped through the cracks and not been organized ".
+          "properly.\n\n%s",
+          '> null()'),
       ),
     );
   }
diff --git a/src/applications/releeph/commitfinder/ReleephCommitFinder.php b/src/applications/releeph/commitfinder/ReleephCommitFinder.php
index 7b017f0287..89fd84e196 100644
--- a/src/applications/releeph/commitfinder/ReleephCommitFinder.php
+++ b/src/applications/releeph/commitfinder/ReleephCommitFinder.php
@@ -37,13 +37,17 @@ final class ReleephCommitFinder {
         ->executeOne();
       if (!$diff_rev) {
         throw new ReleephCommitFinderException(
-          "{$partial_string} does not refer to an existing diff.");
+          pht(
+            '%s does not refer to an existing diff.',
+            $partial_string));
       }
       $commit_phids = $diff_rev->getCommitPHIDs();
 
       if (!$commit_phids) {
         throw new ReleephCommitFinderException(
-          "{$partial_string} has no commits associated with it yet.");
+          pht(
+            '%s has no commits associated with it yet.',
+            $partial_string));
       }
 
       $this->objectPHID = $diff_rev->getPHID();
@@ -64,10 +68,11 @@ final class ReleephCommitFinder {
       $partial_string, $matches)) {
       $callsign = $matches['callsign'];
       if ($callsign != $repository->getCallsign()) {
-        throw new ReleephCommitFinderException(sprintf(
-          '%s is in a different repository to this Releeph project (%s).',
-          $partial_string,
-          $repository->getCallsign()));
+        throw new ReleephCommitFinderException(
+          pht(
+            '%s is in a different repository to this Releeph project (%s).',
+            $partial_string,
+            $repository->getCallsign()));
       } else {
         $dr_data = $matches;
       }
@@ -82,7 +87,10 @@ final class ReleephCommitFinder {
       $dr_data['user'] = $this->getUser();
       $dr = DiffusionRequest::newFromDictionary($dr_data);
     } catch (Exception $ex) {
-      $message = "No commit matches {$partial_string}: ".$ex->getMessage();
+      $message = pht(
+        'No commit matches %s: %s',
+        $partial_string,
+        $ex->getMessage());
       throw new ReleephCommitFinderException($message);
     }
 
@@ -90,7 +98,9 @@ final class ReleephCommitFinder {
 
     if (!$phabricator_repository_commit) {
       throw new ReleephCommitFinderException(
-        "The commit {$partial_string} doesn't exist in this repository.");
+        pht(
+          "The commit %s doesn't exist in this repository.",
+          $partial_string));
     }
 
     // When requesting a single commit, if it has an associated review we
diff --git a/src/applications/releeph/conduit/ReleephGetBranchesConduitAPIMethod.php b/src/applications/releeph/conduit/ReleephGetBranchesConduitAPIMethod.php
index 59e8900108..6e225ec8e3 100644
--- a/src/applications/releeph/conduit/ReleephGetBranchesConduitAPIMethod.php
+++ b/src/applications/releeph/conduit/ReleephGetBranchesConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class ReleephGetBranchesConduitAPIMethod extends ReleephConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Return information about all active Releeph branches.';
+    return pht('Return information about all active Releeph branches.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/releeph/conduit/ReleephProjectInfoConduitAPIMethod.php b/src/applications/releeph/conduit/ReleephProjectInfoConduitAPIMethod.php
index f30d1070c4..0dc45391cd 100644
--- a/src/applications/releeph/conduit/ReleephProjectInfoConduitAPIMethod.php
+++ b/src/applications/releeph/conduit/ReleephProjectInfoConduitAPIMethod.php
@@ -7,9 +7,9 @@ final class ReleephProjectInfoConduitAPIMethod extends ReleephConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return
+    return pht(
       'Fetch information about all Releeph projects '.
-      'for a given Arcanist project.';
+      'for a given Arcanist project.');
   }
 
   protected function defineParamTypes() {
@@ -24,9 +24,9 @@ final class ReleephProjectInfoConduitAPIMethod extends ReleephConduitAPIMethod {
 
   protected function defineErrorTypes() {
     return array(
-      'ERR_UNKNOWN_ARC' =>
+      'ERR_UNKNOWN_ARC' => pht(
         "The given Arcanist project name doesn't exist in the ".
-        "installation of Phabricator you are accessing.",
+        "installation of Phabricator you are accessing."),
     );
   }
 
@@ -38,8 +38,10 @@ final class ReleephProjectInfoConduitAPIMethod extends ReleephConduitAPIMethod {
       if (!$arc_project) {
         throw id(new ConduitException('ERR_UNKNOWN_ARC'))
           ->setErrorDescription(
-            "Unknown Arcanist project '{$arc_project_name}': ".
-            "are you using the correct Conduit URI?");
+            pht(
+              "Unknown Arcanist project '%s': ".
+              "are you using the correct Conduit URI?",
+              $arc_project_name));
       }
 
       $releeph_projects = id(new ReleephProject())
diff --git a/src/applications/releeph/conduit/ReleephQueryRequestsConduitAPIMethod.php b/src/applications/releeph/conduit/ReleephQueryRequestsConduitAPIMethod.php
index 5ccc8a967d..5cd5032c2a 100644
--- a/src/applications/releeph/conduit/ReleephQueryRequestsConduitAPIMethod.php
+++ b/src/applications/releeph/conduit/ReleephQueryRequestsConduitAPIMethod.php
@@ -8,8 +8,8 @@ final class ReleephQueryRequestsConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return
-      'Return information about all Releeph requests linked to the given ids.';
+    return pht(
+      'Return information about all Releeph requests linked to the given ids.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/releeph/conduit/ReleephRequestConduitAPIMethod.php b/src/applications/releeph/conduit/ReleephRequestConduitAPIMethod.php
index f60e40894b..8473c0c7b5 100644
--- a/src/applications/releeph/conduit/ReleephRequestConduitAPIMethod.php
+++ b/src/applications/releeph/conduit/ReleephRequestConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class ReleephRequestConduitAPIMethod extends ReleephConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Request a commit or diff to be picked to a branch.';
+    return pht('Request a commit or diff to be picked to a branch.');
   }
 
   protected function defineParamTypes() {
@@ -24,8 +24,8 @@ final class ReleephRequestConduitAPIMethod extends ReleephConduitAPIMethod {
 
   protected function defineErrorTypes() {
     return array(
-      'ERR_BRANCH'      => 'Unknown Releeph branch.',
-      'ERR_FIELD_PARSE' => 'Unable to parse a Releeph field.',
+      'ERR_BRANCH'      => pht('Unknown Releeph branch.'),
+      'ERR_FIELD_PARSE' => pht('Unable to parse a Releeph field.'),
     );
   }
 
@@ -45,7 +45,10 @@ final class ReleephRequestConduitAPIMethod extends ReleephConduitAPIMethod {
 
     if (!$releeph_branch) {
       throw id(new ConduitException('ERR_BRANCH'))->setErrorDescription(
-        "No ReleephBranch found with PHID {$branch_phid}!");
+        pht(
+          'No %s found with PHID %s!',
+          'ReleephBranch',
+          $branch_phid));
     }
 
     $releeph_project = $releeph_branch->getProduct();
diff --git a/src/applications/releeph/conduit/work/ReleephWorkCanPushConduitAPIMethod.php b/src/applications/releeph/conduit/work/ReleephWorkCanPushConduitAPIMethod.php
index 339f0ac5eb..0086209575 100644
--- a/src/applications/releeph/conduit/work/ReleephWorkCanPushConduitAPIMethod.php
+++ b/src/applications/releeph/conduit/work/ReleephWorkCanPushConduitAPIMethod.php
@@ -11,7 +11,7 @@ final class ReleephWorkCanPushConduitAPIMethod extends ReleephConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Return whether the conduit user is allowed to push.';
+    return pht('Return whether the conduit user is allowed to push.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/releeph/conduit/work/ReleephWorkGetAuthorInfoConduitAPIMethod.php b/src/applications/releeph/conduit/work/ReleephWorkGetAuthorInfoConduitAPIMethod.php
index 08381befb7..6db9fd76ee 100644
--- a/src/applications/releeph/conduit/work/ReleephWorkGetAuthorInfoConduitAPIMethod.php
+++ b/src/applications/releeph/conduit/work/ReleephWorkGetAuthorInfoConduitAPIMethod.php
@@ -12,7 +12,7 @@ final class ReleephWorkGetAuthorInfoConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Return a string to use as the VCS author.';
+    return pht('Return a string to use as the VCS author.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/releeph/conduit/work/ReleephWorkGetBranchCommitMessageConduitAPIMethod.php b/src/applications/releeph/conduit/work/ReleephWorkGetBranchCommitMessageConduitAPIMethod.php
index 20d86a003a..43bdd04161 100644
--- a/src/applications/releeph/conduit/work/ReleephWorkGetBranchCommitMessageConduitAPIMethod.php
+++ b/src/applications/releeph/conduit/work/ReleephWorkGetBranchCommitMessageConduitAPIMethod.php
@@ -12,7 +12,7 @@ final class ReleephWorkGetBranchCommitMessageConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Get a commit message for committing a Releeph branch.';
+    return pht('Get a commit message for committing a Releeph branch.');
   }
 
   protected function defineParamTypes() {
@@ -60,19 +60,23 @@ final class ReleephWorkGetBranchCommitMessageConduitAPIMethod
     $commit_message[] = $h_branch->getFullName();
     $commit_message[] = $h_branch->getURI();
 
-    $commit_message[] = 'Cut Point: '.$handles[$cut_phid]->getName();
+    $commit_message[] = pht('Cut Point: %s', $handles[$cut_phid]->getName());
 
     $cut_point_pr_commit = id(new PhabricatorRepositoryCommit())
       ->loadOneWhere('phid = %s', $cut_phid);
     $cut_point_commit_date = strftime(
       '%Y-%m-%d %H:%M:%S%z',
       $cut_point_pr_commit->getEpoch());
-    $commit_message[] = "Cut Point Date: {$cut_point_commit_date}";
+    $commit_message[] = pht('Cut Point Date: %s', $cut_point_commit_date);
 
-    $commit_message[] = 'Created By: '.$handles[$creator_phid]->getName();
+    $commit_message[] = pht(
+      'Created By: %s',
+      $handles[$creator_phid]->getName());
 
     $project_uri = $project->getURI();
-    $commit_message[] = 'Project: '.$h_project->getName().' '.$project_uri;
+    $commit_message[] = pht(
+      'Project: %s',
+      $h_project->getName().' '.$project_uri);
 
     /**
      * Required for 090-limit_new_branch_creations.sh in
diff --git a/src/applications/releeph/conduit/work/ReleephWorkGetBranchConduitAPIMethod.php b/src/applications/releeph/conduit/work/ReleephWorkGetBranchConduitAPIMethod.php
index 5f6f82b17d..7941710528 100644
--- a/src/applications/releeph/conduit/work/ReleephWorkGetBranchConduitAPIMethod.php
+++ b/src/applications/releeph/conduit/work/ReleephWorkGetBranchConduitAPIMethod.php
@@ -12,7 +12,7 @@ final class ReleephWorkGetBranchConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Return information to help checkout / cut a Releeph branch.';
+    return pht('Return information to help checkout / cut a Releeph branch.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/releeph/conduit/work/ReleephWorkGetCommitMessageConduitAPIMethod.php b/src/applications/releeph/conduit/work/ReleephWorkGetCommitMessageConduitAPIMethod.php
index 398f37e7a0..7f645c4be8 100644
--- a/src/applications/releeph/conduit/work/ReleephWorkGetCommitMessageConduitAPIMethod.php
+++ b/src/applications/releeph/conduit/work/ReleephWorkGetCommitMessageConduitAPIMethod.php
@@ -12,9 +12,9 @@ final class ReleephWorkGetCommitMessageConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return
-      'Get commit message components for building '.
-      'a ReleephRequest commit message.';
+    return pht(
+      'Get commit message components for building a %s commit message.',
+      'ReleephRequest');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/releeph/conduit/work/ReleephWorkNextRequestConduitAPIMethod.php b/src/applications/releeph/conduit/work/ReleephWorkNextRequestConduitAPIMethod.php
index e161faf082..fb8a8ad0dc 100644
--- a/src/applications/releeph/conduit/work/ReleephWorkNextRequestConduitAPIMethod.php
+++ b/src/applications/releeph/conduit/work/ReleephWorkNextRequestConduitAPIMethod.php
@@ -15,9 +15,9 @@ final class ReleephWorkNextRequestConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return
-      'Return info required to cut a branch, '.
-      'and pick and revert ReleephRequests';
+    return pht(
+      'Return info required to cut a branch, and pick and revert %s.',
+      'ReleephRequests');
   }
 
   protected function defineParamTypes() {
@@ -33,8 +33,8 @@ final class ReleephWorkNextRequestConduitAPIMethod
 
   protected function defineErrorTypes() {
     return array(
-      'ERR-NOT-PUSHER' =>
-        'You are not listed as a pusher for thie Releeph project!',
+      'ERR-NOT-PUSHER' => pht(
+        'You are not listed as a pusher for the Releeph project!'),
     );
   }
 
diff --git a/src/applications/releeph/conduit/work/ReleephWorkRecordConduitAPIMethod.php b/src/applications/releeph/conduit/work/ReleephWorkRecordConduitAPIMethod.php
index 43e26f2f4d..d32249fe65 100644
--- a/src/applications/releeph/conduit/work/ReleephWorkRecordConduitAPIMethod.php
+++ b/src/applications/releeph/conduit/work/ReleephWorkRecordConduitAPIMethod.php
@@ -25,8 +25,9 @@ final class ReleephWorkRecordConduitAPIMethod
    * reverted.
    */
   public function getMethodDescription() {
-    return 'Record whether we committed a pick or revert '.
-      'to the upstream repository.';
+    return pht(
+      'Record whether we committed a pick or revert '.
+      'to the upstream repository.');
   }
 
   protected function defineParamTypes() {
diff --git a/src/applications/releeph/conduit/work/ReleephWorkRecordPickStatusConduitAPIMethod.php b/src/applications/releeph/conduit/work/ReleephWorkRecordPickStatusConduitAPIMethod.php
index f9434ab48c..ead3d9dd2a 100644
--- a/src/applications/releeph/conduit/work/ReleephWorkRecordPickStatusConduitAPIMethod.php
+++ b/src/applications/releeph/conduit/work/ReleephWorkRecordPickStatusConduitAPIMethod.php
@@ -12,7 +12,7 @@ final class ReleephWorkRecordPickStatusConduitAPIMethod
   }
 
   public function getMethodDescription() {
-    return 'Record whether a pick or revert was successful or not.';
+    return pht('Record whether a pick or revert was successful or not.');
   }
 
   protected function defineParamTypes() {
@@ -55,7 +55,7 @@ final class ReleephWorkRecordPickStatusConduitAPIMethod
         break;
 
       default:
-        throw new Exception("Unknown action {$action}!");
+        throw new Exception(pht('Unknown action %s!', $action));
     }
 
     $releeph_request = id(new ReleephRequest())
diff --git a/src/applications/releeph/controller/branch/ReleephBranchCreateController.php b/src/applications/releeph/controller/branch/ReleephBranchCreateController.php
index 11b2e746aa..851724c6d9 100644
--- a/src/applications/releeph/controller/branch/ReleephBranchCreateController.php
+++ b/src/applications/releeph/controller/branch/ReleephBranchCreateController.php
@@ -94,17 +94,16 @@ final class ReleephBranchCreateController extends ReleephProductController {
           ->setLabel(pht('Symbolic Name'))
           ->setName('symbolicName')
           ->setValue($symbolic_name)
-          ->setCaption(pht('Mutable alternate name, for easy reference, '.
-              '(e.g. "LATEST")')))
+          ->setCaption(pht(
+            'Mutable alternate name, for easy reference, (e.g. "LATEST")')))
       ->appendChild(
         id(new AphrontFormTextControl())
           ->setLabel(pht('Cut point'))
           ->setName('cutPoint')
           ->setValue($cut_point)
           ->setError($e_cut)
-          ->setCaption(
-              pht('A commit ID for your repo type, or a '.
-              'Diffusion ID like "rE123"')))
+          ->setCaption(pht(
+            'A commit ID for your repo type, or a Diffusion ID like "rE123"')))
       ->appendChild($branch_date_control)
       ->appendChild(
         id(new AphrontFormSubmitControl())
diff --git a/src/applications/releeph/controller/branch/ReleephBranchEditController.php b/src/applications/releeph/controller/branch/ReleephBranchEditController.php
index 2e1e4ccda8..000e9535bf 100644
--- a/src/applications/releeph/controller/branch/ReleephBranchEditController.php
+++ b/src/applications/releeph/controller/branch/ReleephBranchEditController.php
@@ -85,8 +85,8 @@ final class ReleephBranchEditController extends ReleephBranchController {
           ->setLabel(pht('Symbolic Name'))
           ->setName('symbolicName')
           ->setValue($symbolic_name)
-          ->setCaption(pht('Mutable alternate name, for easy reference, '.
-              '(e.g. "LATEST")')))
+          ->setCaption(pht(
+            'Mutable alternate name, for easy reference, (e.g. "LATEST")')))
       ->appendChild(
         id(new AphrontFormSubmitControl())
           ->addCancelButton($this->getBranchViewURI($branch))
diff --git a/src/applications/releeph/controller/product/ReleephProductCreateController.php b/src/applications/releeph/controller/product/ReleephProductCreateController.php
index 801ec7fe48..9412f292ed 100644
--- a/src/applications/releeph/controller/product/ReleephProductCreateController.php
+++ b/src/applications/releeph/controller/product/ReleephProductCreateController.php
@@ -73,7 +73,7 @@ final class ReleephProductCreateController extends ReleephProductController {
       ->setName('arcPrID')
       ->setValue($arc_pr_id)
       ->setCaption(pht(
-        'If your Arc project isn\'t listed, associate it with a repository %s',
+        "If your Arc project isn't listed, associate it with a repository %s.",
         phutil_tag(
           'a',
           array(
@@ -100,8 +100,8 @@ final class ReleephProductCreateController extends ReleephProductController {
           ->setName('trunkBranch')
           ->setValue($trunk_branch)
           ->setError($e_trunk_branch)
-          ->setCaption(pht('The development branch, '.
-              'from which requests will be picked.')))
+          ->setCaption(pht(
+            'The development branch, from which requests will be picked.')))
       ->appendChild($branch_name_preview)
       ->appendChild(
         id(new AphrontFormSubmitControl())
diff --git a/src/applications/releeph/controller/product/ReleephProductEditController.php b/src/applications/releeph/controller/product/ReleephProductEditController.php
index 926f813db0..41b405030d 100644
--- a/src/applications/releeph/controller/product/ReleephProductEditController.php
+++ b/src/applications/releeph/controller/product/ReleephProductEditController.php
@@ -104,7 +104,7 @@ final class ReleephProductEditController extends ReleephProductController {
         if ($template_errors) {
           $e_branch_template = pht('Whoopsies!');
           foreach ($template_errors as $template_error) {
-            $errors[] = "Template error: {$template_error}";
+            $errors[] = pht('Template error: %s', $template_error);
           }
         }
       }
@@ -171,7 +171,7 @@ final class ReleephProductEditController extends ReleephProductController {
     $branch_template_input = id(new AphrontFormTextControl())
       ->setName('branchTemplate')
       ->setValue($branch_template)
-      ->setLabel('Branch Template')
+      ->setLabel(pht('Branch Template'))
       ->setError($e_branch_template)
       ->setCaption(
         pht("Leave this blank to use your installation's default."));
diff --git a/src/applications/releeph/controller/request/ReleephRequestActionController.php b/src/applications/releeph/controller/request/ReleephRequestActionController.php
index 64125db5ff..bbcc1df2bb 100644
--- a/src/applications/releeph/controller/request/ReleephRequestActionController.php
+++ b/src/applications/releeph/controller/request/ReleephRequestActionController.php
@@ -64,8 +64,9 @@ final class ReleephRequestActionController
           // We're all good!
         } else {
           throw new Exception(
-            "Bug!  Only pushers or the requestor can manually change a ".
-            "request's in-branch status!");
+            pht(
+              "Bug! Only pushers or the requestor can manually change a ".
+              "request's in-branch status!"));
         }
 
         if ($action === 'mark-manually-picked') {
@@ -89,7 +90,8 @@ final class ReleephRequestActionController
         break;
 
       default:
-        throw new Exception("unknown or unimplemented action {$action}");
+        throw new Exception(
+          pht('Unknown or unimplemented action %s.', $action));
     }
 
     $editor->applyTransactions($pull, $xactions);
diff --git a/src/applications/releeph/controller/request/ReleephRequestDifferentialCreateController.php b/src/applications/releeph/controller/request/ReleephRequestDifferentialCreateController.php
index 8d27ef028d..e938fda6c3 100644
--- a/src/applications/releeph/controller/request/ReleephRequestDifferentialCreateController.php
+++ b/src/applications/releeph/controller/request/ReleephRequestDifferentialCreateController.php
@@ -32,21 +32,22 @@ final class ReleephRequestDifferentialCreateController
       'arcanistProjectID = %d AND isActive = 1',
       $arc_project->getID());
     if (!$projects) {
-      throw new Exception(sprintf(
-        "D%d belongs to the '%s' Arcanist project, ".
-        "which is not part of any Releeph project!",
-        $this->revision->getID(),
-        $arc_project->getName()));
+      throw new Exception(
+        pht(
+          "%s belongs to the '%s' Arcanist project, ".
+          "which is not part of any Releeph project!",
+          'D'.$this->revision->getID(),
+          $arc_project->getName()));
     }
 
     $branches = id(new ReleephBranch())->loadAllWhere(
       'releephProjectID IN (%Ld) AND isActive = 1',
       mpull($projects, 'getID'));
     if (!$branches) {
-      throw new Exception(sprintf(
-        'D%d could be in the Releeph project(s) %s, '.
+      throw new Exception(pht(
+        '%s could be in the Releeph project(s) %s, '.
         'but this project / none of these projects have open branches.',
-        $this->revision->getID(),
+        'D'.$this->revision->getID(),
         implode(', ', mpull($projects, 'getName'))));
     }
 
@@ -69,9 +70,10 @@ final class ReleephRequestDifferentialCreateController
       ->addCancelButton('/D'.$request->getStr('D'));
 
     $dialog->appendChild(
-      pht('This differential revision changes code that is associated '.
-      'with multiple Releeph branches. '.
-      'Please select the branch where you would like this code to be picked.'));
+      pht(
+        'This differential revision changes code that is associated '.
+        'with multiple Releeph branches. Please select the branch '.
+        'where you would like this code to be picked.'));
 
     foreach ($branch_groups as $project_id => $branches) {
       $project = idx($projects, $project_id);
diff --git a/src/applications/releeph/controller/request/ReleephRequestEditController.php b/src/applications/releeph/controller/request/ReleephRequestEditController.php
index 3c5a80bd99..8888a01070 100644
--- a/src/applications/releeph/controller/request/ReleephRequestEditController.php
+++ b/src/applications/releeph/controller/request/ReleephRequestEditController.php
@@ -93,8 +93,8 @@ final class ReleephRequestEditController extends ReleephBranchController {
         if ($request_identifier ===
           ReleephRequestTypeaheadControl::PLACEHOLDER) {
 
-          $errors[] = 'No commit ID was provided.';
-          $e_request_identifier = 'Required';
+          $errors[] = pht('No commit ID was provided.');
+          $e_request_identifier = pht('Required');
         } else {
           $pr_commit = null;
           $finder = id(new ReleephCommitFinder())
@@ -103,9 +103,10 @@ final class ReleephRequestEditController extends ReleephBranchController {
           try {
             $pr_commit = $finder->fromPartial($request_identifier);
           } catch (Exception $e) {
-            $e_request_identifier = 'Invalid';
-            $errors[] =
-              "Request {$request_identifier} is probably not a valid commit";
+            $e_request_identifier = pht('Invalid');
+            $errors[] = pht(
+              'Request %s is probably not a valid commit.',
+              $request_identifier);
             $errors[] = $e->getMessage();
           }
 
@@ -126,7 +127,7 @@ final class ReleephRequestEditController extends ReleephBranchController {
           if ($existing) {
             return id(new AphrontRedirectResponse())
               ->setURI('/releeph/request/edit/'.$existing->getID().
-                       '?existing=1');
+                '?existing=1');
           }
 
           $xactions[] = id(new ReleephRequestTransaction())
@@ -204,8 +205,8 @@ final class ReleephRequestEditController extends ReleephBranchController {
     $notice_view = null;
     if ($request->getInt('existing')) {
       $notice_messages = array(
-        'You are editing an existing pick request!',
-        hsprintf(
+        pht('You are editing an existing pick request!'),
+        pht(
           'Requested %s by %s',
           $age_string,
           $handles[$pull->getRequestUserPHID()]->renderLink()),
@@ -222,12 +223,12 @@ final class ReleephRequestEditController extends ReleephBranchController {
       $form
         ->appendChild(
           id(new AphrontFormMarkupControl())
-            ->setLabel('Original Commit')
+            ->setLabel(pht('Original Commit'))
             ->setValue(
               $handles[$pull->getRequestCommitPHID()]->renderLink()))
         ->appendChild(
           id(new AphrontFormMarkupControl())
-            ->setLabel('Requestor')
+            ->setLabel(pht('Requestor'))
             ->setValue(hsprintf(
               '%s %s',
               $handles[$pull->getRequestUserPHID()]->renderLink(),
@@ -261,14 +262,15 @@ final class ReleephRequestEditController extends ReleephBranchController {
         $form->appendChild(
           id(new ReleephRequestTypeaheadControl())
             ->setName('requestIdentifierRaw')
-            ->setLabel('Commit ID')
+            ->setLabel(pht('Commit ID'))
             ->setRepo($repo)
             ->setValue($request_identifier)
             ->setError($e_request_identifier)
             ->setStartTime($branch_cut_point->getEpoch())
             ->setCaption(
-              'Start typing to autocomplete on commit title, '.
-              'or give a Phabricator commit identifier like rFOO1234'));
+              pht(
+                'Start typing to autocomplete on commit title, '.
+                'or give a Phabricator commit identifier like rFOO1234.')));
       }
     }
 
@@ -291,7 +293,7 @@ final class ReleephRequestEditController extends ReleephBranchController {
 
     $form->appendChild(
       id(new AphrontFormSubmitControl())
-        ->addCancelButton($cancel_uri, 'Cancel')
+        ->addCancelButton($cancel_uri, pht('Cancel'))
         ->setValue($submit_name));
 
     $box = id(new PHUIObjectBoxView())
diff --git a/src/applications/releeph/differential/DifferentialReleephRequestFieldSpecification.php b/src/applications/releeph/differential/DifferentialReleephRequestFieldSpecification.php
index 6e635ee4b3..33ae0acc96 100644
--- a/src/applications/releeph/differential/DifferentialReleephRequestFieldSpecification.php
+++ b/src/applications/releeph/differential/DifferentialReleephRequestFieldSpecification.php
@@ -59,16 +59,20 @@ final class DifferentialReleephRequestFieldSpecification {
   }
 
   public function renderValueForRevisionView() {
-    static $tense = array(
-      self::ACTION_PICKS => array(
-        'future'  => 'Will pick',
-        'past'    => 'Picked',
-      ),
-      self::ACTION_REVERTS => array(
-        'future'  => 'Will revert',
-        'past'    => 'Reverted',
-      ),
-    );
+    static $tense;
+
+    if ($tense === null) {
+      $tense = array(
+        self::ACTION_PICKS => array(
+          'future'  => pht('Will pick'),
+          'past'    => pht('Picked'),
+        ),
+        self::ACTION_REVERTS => array(
+          'future'  => pht('Will revert'),
+          'past'    => pht('Reverted'),
+        ),
+      );
+    }
 
     $releeph_requests = $this->loadReleephRequests();
     if (!$releeph_requests) {
@@ -166,7 +170,9 @@ final class DifferentialReleephRequestFieldSpecification {
 
       default:
         throw new DifferentialFieldParseException(
-          "Commit message contains unknown Releeph action '{$raw_action}'!");
+          pht(
+            "Commit message contains unknown Releeph action '%s'!",
+            $raw_action));
         break;
     }
 
@@ -176,8 +182,10 @@ final class DifferentialReleephRequestFieldSpecification {
       if (!preg_match('/^(?:RQ)?(\d+)$/i', $token, $match)) {
         $label = $this->renderLabelForCommitMessage();
         throw new DifferentialFieldParseException(
-          "Commit message contains unparseable ".
-          "Releeph request token '{$token}'!");
+          pht(
+            "Commit message contains unparseable ".
+            "Releeph request token '%s'!",
+            $token));
       }
 
       $id = (int)$match[1];
@@ -185,7 +193,9 @@ final class DifferentialReleephRequestFieldSpecification {
 
       if (!$releeph_request) {
         throw new DifferentialFieldParseException(
-          "Commit message references non existent releeph request: {$value}!");
+          pht(
+            'Commit message references non existent Releeph request: %s!',
+            $value));
       }
 
       $releeph_requests[] = $releeph_request;
@@ -201,7 +211,9 @@ final class DifferentialReleephRequestFieldSpecification {
 
         if (idx($rqs_seen, $rq_id)) {
           throw new DifferentialFieldParseException(
-            "Commit message refers to {$rq_id} multiple times!");
+            pht(
+              'Commit message refers to %s multiple times!',
+              $rq_id));
         }
         $rqs_seen[$rq_id] = true;
 
@@ -217,9 +229,10 @@ final class DifferentialReleephRequestFieldSpecification {
           $lists[] = implode(', ', $rq_ids).' in '.$branch_name;
         }
         throw new DifferentialFieldParseException(
-          'Commit message references multiple Releeph requests, '.
-          'but the requests are in different branches: '.
-          implode('; ', $lists));
+          pht(
+            'Commit message references multiple Releeph requests, '.
+            'but the requests are in different branches: %s',
+            implode('; ', $lists)));
       }
     }
 
@@ -240,9 +253,10 @@ final class DifferentialReleephRequestFieldSpecification {
     return false;
   }
 
-  public function didParseCommit(PhabricatorRepository $repo,
-                                 PhabricatorRepositoryCommit $commit,
-                                 PhabricatorRepositoryCommitData $data) {
+  public function didParseCommit(
+    PhabricatorRepository $repo,
+    PhabricatorRepositoryCommit $commit,
+    PhabricatorRepositoryCommitData $data) {
 
     // NOTE: This is currently dead code. See T2222.
 
@@ -305,9 +319,10 @@ final class DifferentialReleephRequestFieldSpecification {
       ->execute();
   }
 
-  private function isCommitOnBranch(PhabricatorRepository $repo,
-                                    PhabricatorRepositoryCommit $commit,
-                                    ReleephBranch $releeph_branch) {
+  private function isCommitOnBranch(
+    PhabricatorRepository $repo,
+    PhabricatorRepositoryCommit $commit,
+    ReleephBranch $releeph_branch) {
 
     switch ($repo->getVersionControlSystem()) {
       case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
@@ -352,7 +367,7 @@ final class DifferentialReleephRequestFieldSpecification {
         }
 
         if ($in_branch && $ex_branch) {
-          $error = sprintf(
+          $error = pht(
             'CONFUSION: commit %s in %s contains %d path change(s) that were '.
             'part of a Releeph branch, but also has %d path change(s) not '.
             'part of a Releeph branch!',
diff --git a/src/applications/releeph/editor/ReleephBranchEditor.php b/src/applications/releeph/editor/ReleephBranchEditor.php
index e2cb81ce7e..0bc084223b 100644
--- a/src/applications/releeph/editor/ReleephBranchEditor.php
+++ b/src/applications/releeph/editor/ReleephBranchEditor.php
@@ -15,9 +15,10 @@ final class ReleephBranchEditor extends PhabricatorEditor {
     return $this;
   }
 
-  public function newBranchFromCommit(PhabricatorRepositoryCommit $cut_point,
-                                      $branch_date,
-                                      $symbolic_name = null) {
+  public function newBranchFromCommit(
+    PhabricatorRepositoryCommit $cut_point,
+    $branch_date,
+    $symbolic_name = null) {
 
     $template = $this->releephProject->getDetail('branchTemplate');
     if (!$template) {
diff --git a/src/applications/releeph/editor/ReleephRequestTransactionalEditor.php b/src/applications/releeph/editor/ReleephRequestTransactionalEditor.php
index 993079c506..8f6805e661 100644
--- a/src/applications/releeph/editor/ReleephRequestTransactionalEditor.php
+++ b/src/applications/releeph/editor/ReleephRequestTransactionalEditor.php
@@ -299,10 +299,13 @@ final class ReleephRequestTransactionalEditor
         $type = $xaction->getTransactionType();
         $new = $xaction->getNewValue();
         phlog(
-          "Unknown discovery action '{$action}' ".
-          "for xaction of type {$type} ".
-          "with new value {$new} ".
-          "mentioning RQ{$id}!");
+          pht(
+            "Unknown discovery action '%s' for xaction of type %s ".
+            "with new value %s mentioning %s!",
+            $action,
+            $type,
+            $new,
+            'RQ'.$id));
         break;
     }
   }
diff --git a/src/applications/releeph/field/selector/ReleephFieldSelector.php b/src/applications/releeph/field/selector/ReleephFieldSelector.php
index 68a9f4d74d..95f22d0fe1 100644
--- a/src/applications/releeph/field/selector/ReleephFieldSelector.php
+++ b/src/applications/releeph/field/selector/ReleephFieldSelector.php
@@ -26,14 +26,17 @@ abstract class ReleephFieldSelector {
       $field = idx($map, $class);
       if (!$field) {
         throw new Exception(
-          "Tried to select a in instance of '{$class}' but that field ".
-          "is not configured for this project!");
+          pht(
+            "Tried to select a in instance of '%s' but that field ".
+            "is not configured for this project!",
+            $class));
       }
 
       if (idx($result, $class)) {
         throw new Exception(
-          "You have asked to select the field '{$class}' ".
-          "more than once!");
+          pht(
+            "You have asked to select the field '%s' more than once!",
+            $class));
       }
 
       $result[$class] = $field;
diff --git a/src/applications/releeph/field/specification/ReleephDependsOnFieldSpecification.php b/src/applications/releeph/field/specification/ReleephDependsOnFieldSpecification.php
index 8321203688..acb5d7d11d 100644
--- a/src/applications/releeph/field/specification/ReleephDependsOnFieldSpecification.php
+++ b/src/applications/releeph/field/specification/ReleephDependsOnFieldSpecification.php
@@ -2,6 +2,7 @@
 
 final class ReleephDependsOnFieldSpecification
   extends ReleephFieldSpecification {
+
   public function getFieldKey() {
     return 'dependsOn';
   }
diff --git a/src/applications/releeph/field/specification/ReleephDiffChurnFieldSpecification.php b/src/applications/releeph/field/specification/ReleephDiffChurnFieldSpecification.php
index 026392a1bc..18c3c78c87 100644
--- a/src/applications/releeph/field/specification/ReleephDiffChurnFieldSpecification.php
+++ b/src/applications/releeph/field/specification/ReleephDiffChurnFieldSpecification.php
@@ -13,7 +13,7 @@ final class ReleephDiffChurnFieldSpecification
   }
 
   public function getName() {
-    return 'Churn';
+    return pht('Churn');
   }
 
   public function renderPropertyViewValue(array $handles) {
@@ -56,7 +56,7 @@ final class ReleephDiffChurnFieldSpecification
 
     if ($points === 0) {
       $points = 0.15 * self::MAX_POINTS;
-      $blurb = 'Silent diff';
+      $blurb = pht('Silent diff');
     } else {
       $parts = array();
       if ($rejections) {
@@ -75,7 +75,7 @@ final class ReleephDiffChurnFieldSpecification
         $blurb = head($parts);
       } else {
         $last = array_pop($parts);
-        $blurb = implode(', ', $parts).' and '.$last;
+        $blurb = pht('%s and %s', implode(', ', $parts), $last);
       }
     }
 
diff --git a/src/applications/releeph/field/specification/ReleephDiffSizeFieldSpecification.php b/src/applications/releeph/field/specification/ReleephDiffSizeFieldSpecification.php
index 671511deb0..fe1a39277c 100644
--- a/src/applications/releeph/field/specification/ReleephDiffSizeFieldSpecification.php
+++ b/src/applications/releeph/field/specification/ReleephDiffSizeFieldSpecification.php
@@ -12,7 +12,7 @@ final class ReleephDiffSizeFieldSpecification
   }
 
   public function getName() {
-    return 'Size';
+    return pht('Size');
   }
 
   public function renderPropertyViewValue(array $handles) {
@@ -50,10 +50,10 @@ final class ReleephDiffSizeFieldSpecification
       Javelin::initBehavior('phabricator-tooltips');
       require_celerity_resource('aphront-tooltip-css');
 
-      $test_blurb =
-        pht('%d line(s)', $mr_changes['tests']['lines']).' and '.
-        pht('%d path(s)', count($mr_changes['tests']['paths'])).
-        " contain changes to test code:\n";
+      $test_blurb = pht(
+        "%d line(s) and %d path(s) contain changes to test code:\n",
+        $mr_changes['tests']['lines'],
+        count($mr_changes['tests']['paths']));
       foreach ($mr_changes['tests']['paths'] as $mr_test_path) {
         $test_blurb .= pht("%s\n", $mr_test_path);
       }
@@ -73,9 +73,11 @@ final class ReleephDiffSizeFieldSpecification
     }
 
     $blurb = hsprintf('%s%s.',
-      pht('%d line(s)', $mr_changes['code']['lines']).' and '.
-      pht('%d path(s)', count($mr_changes['code']['paths'])).' over '.
-      pht('%d diff(s)', count($diffs)),
+      pht(
+        '%d line(s) and %d path(s) over %d diff(s)',
+        $mr_changes['code']['lines'],
+        $mr_changes['code']['paths'],
+        count($diffs)),
       $test_tag);
 
     return id(new AphrontProgressBarView())
diff --git a/src/applications/releeph/field/specification/ReleephFieldSpecification.php b/src/applications/releeph/field/specification/ReleephFieldSpecification.php
index b0017f1b40..c0cb64b05d 100644
--- a/src/applications/releeph/field/specification/ReleephFieldSpecification.php
+++ b/src/applications/releeph/field/specification/ReleephFieldSpecification.php
@@ -48,8 +48,7 @@ abstract class ReleephFieldSpecification
        * Storage keys are reused for form controls, and periods in form control
        * names break HTML forms.
        */
-      throw new Exception(
-        "You can't use '.' in storage keys!");
+      throw new Exception(pht("You can't use '%s' in storage keys!", '.'));
     }
     return $key;
   }
diff --git a/src/applications/releeph/field/specification/ReleephIntentFieldSpecification.php b/src/applications/releeph/field/specification/ReleephIntentFieldSpecification.php
index bae7da14c2..4d199f26cc 100644
--- a/src/applications/releeph/field/specification/ReleephIntentFieldSpecification.php
+++ b/src/applications/releeph/field/specification/ReleephIntentFieldSpecification.php
@@ -83,11 +83,11 @@ final class ReleephIntentFieldSpecification
   }
 
   public function renderLabelForCommitMessage() {
-    return 'Approved By';
+    return pht('Approved By');
   }
 
   public function renderLabelForRevertMessage() {
-    return 'Rejected By';
+    return pht('Rejected By');
   }
 
   public function renderValueForCommitMessage() {
@@ -120,13 +120,13 @@ final class ReleephIntentFieldSpecification
 
         if ($is_pusher) {
           if ($is_requestor) {
-            $token = "{$name} (pusher and requestor)";
+            $token = pht('%s (pusher and requestor)', $name);
           } else {
             $token = "{$name} (pusher)";
           }
         } else {
           if ($is_requestor) {
-            $token = "{$name} (requestor)";
+            $token = pht('%s (requestor)', $name);
           } else {
             $token = $name;
           }
diff --git a/src/applications/releeph/field/specification/ReleephLevelFieldSpecification.php b/src/applications/releeph/field/specification/ReleephLevelFieldSpecification.php
index 70ae446f95..a686eb15c4 100644
--- a/src/applications/releeph/field/specification/ReleephLevelFieldSpecification.php
+++ b/src/applications/releeph/field/specification/ReleephLevelFieldSpecification.php
@@ -79,7 +79,7 @@ abstract class ReleephLevelFieldSpecification
       $label = $this->getName();
       throw new ReleephFieldParseException(
         $this,
-        "You must provide a {$label} level");
+        pht('You must provide a %s level.', $label));
     }
 
     $levels = $this->getLevels();
@@ -87,7 +87,10 @@ abstract class ReleephLevelFieldSpecification
       $label = $this->getName();
       throw new ReleephFieldParseException(
         $this,
-        "Level '{$value}' is not a valid {$label} level in this project.");
+        pht(
+          "Level '%s' is not a valid %s level in this project.",
+          $value,
+          $label));
     }
   }
 
@@ -101,8 +104,9 @@ abstract class ReleephLevelFieldSpecification
       if (!$level) {
         throw new ReleephFieldParseException(
           $this,
-          "No value given for {$label}, ".
-          "and no default is given for this level!");
+          pht(
+            'No value given for %s, and no default is given for this level!',
+            $label));
       }
     } else {
       $level = $this->getLevelByName($name);
@@ -111,7 +115,7 @@ abstract class ReleephLevelFieldSpecification
     if (!$level) {
       throw new ReleephFieldParseException(
         $this,
-        "Unknown {$label} level name '{$name}'");
+        pht("Unknown %s level name '%s'", $label, $name));
     }
     $this->setValue($level);
   }
diff --git a/src/applications/releeph/field/specification/ReleephReasonFieldSpecification.php b/src/applications/releeph/field/specification/ReleephReasonFieldSpecification.php
index d8312283ce..831e1d60a3 100644
--- a/src/applications/releeph/field/specification/ReleephReasonFieldSpecification.php
+++ b/src/applications/releeph/field/specification/ReleephReasonFieldSpecification.php
@@ -8,7 +8,7 @@ final class ReleephReasonFieldSpecification
   }
 
   public function getName() {
-    return 'Reason';
+    return pht('Reason');
   }
 
   public function getStorageKey() {
@@ -36,7 +36,7 @@ final class ReleephReasonFieldSpecification
 
   public function renderEditControl(array $handles) {
     return id(new AphrontFormTextAreaControl())
-      ->setLabel('Reason')
+      ->setLabel(pht('Reason'))
       ->setName('reason')
       ->setError($this->error)
       ->setValue($this->getValue());
@@ -47,14 +47,14 @@ final class ReleephReasonFieldSpecification
       $this->error = 'Required';
       throw new ReleephFieldParseException(
         $this,
-        'You must give a reason for your request.');
+        pht('You must give a reason for your request.'));
     }
   }
 
   public function renderHelpForArcanist() {
-    $text =
+    $text = pht(
       "Fully explain why you are requesting this code be included ".
-      "in the next release.\n";
+      "in the next release.\n");
     return phutil_console_wrap($text, 8);
   }
 
@@ -63,7 +63,7 @@ final class ReleephReasonFieldSpecification
   }
 
   public function renderLabelForCommitMessage() {
-    return 'Request Reason';
+    return pht('Request Reason');
   }
 
   public function renderValueForCommitMessage() {
diff --git a/src/applications/releeph/field/specification/ReleephRequestorFieldSpecification.php b/src/applications/releeph/field/specification/ReleephRequestorFieldSpecification.php
index 03fb88e955..d479bb8020 100644
--- a/src/applications/releeph/field/specification/ReleephRequestorFieldSpecification.php
+++ b/src/applications/releeph/field/specification/ReleephRequestorFieldSpecification.php
@@ -8,7 +8,7 @@ final class ReleephRequestorFieldSpecification
   }
 
   public function getName() {
-    return 'Requestor';
+    return pht('Requestor');
   }
 
   public function getRequiredHandlePHIDsForPropertyView() {
@@ -35,7 +35,7 @@ final class ReleephRequestorFieldSpecification
   }
 
   public function renderLabelForCommitMessage() {
-    return 'Requested By';
+    return pht('Requested By');
   }
 
   public function renderValueForCommitMessage() {
diff --git a/src/applications/releeph/field/specification/ReleephRevisionFieldSpecification.php b/src/applications/releeph/field/specification/ReleephRevisionFieldSpecification.php
index f9aa6fd2a1..45f6bdd7e1 100644
--- a/src/applications/releeph/field/specification/ReleephRevisionFieldSpecification.php
+++ b/src/applications/releeph/field/specification/ReleephRevisionFieldSpecification.php
@@ -8,7 +8,7 @@ final class ReleephRevisionFieldSpecification
   }
 
   public function getName() {
-    return 'Revision';
+    return pht('Revision');
   }
 
   public function getRequiredHandlePHIDsForPropertyView() {
diff --git a/src/applications/releeph/field/specification/ReleephSeverityFieldSpecification.php b/src/applications/releeph/field/specification/ReleephSeverityFieldSpecification.php
index 07fa55de65..18beb35a10 100644
--- a/src/applications/releeph/field/specification/ReleephSeverityFieldSpecification.php
+++ b/src/applications/releeph/field/specification/ReleephSeverityFieldSpecification.php
@@ -38,12 +38,15 @@ final class ReleephSeverityFieldSpecification
   }
 
   public function getDescriptionForLevel($level) {
-    static $descriptions = array(
-      self::HOTFIX =>
-        'Needs merging and fixing right now.',
-      self::RELEASE =>
-        'Required for the currently rolling release.',
-    );
+    static $descriptions;
+
+    if ($descriptions === null) {
+      $descriptions = array(
+        self::HOTFIX => pht('Needs merging and fixing right now.'),
+        self::RELEASE => pht('Required for the currently rolling release.'),
+      );
+    }
+
     return idx($descriptions, $level);
   }
 
diff --git a/src/applications/releeph/field/specification/ReleephSummaryFieldSpecification.php b/src/applications/releeph/field/specification/ReleephSummaryFieldSpecification.php
index a4f1e1bdd3..84767bcf6b 100644
--- a/src/applications/releeph/field/specification/ReleephSummaryFieldSpecification.php
+++ b/src/applications/releeph/field/specification/ReleephSummaryFieldSpecification.php
@@ -29,22 +29,22 @@ final class ReleephSummaryFieldSpecification
       ->setName('summary')
       ->setError($this->error)
       ->setValue($this->getValue())
-      ->setCaption(
-        'Leave this blank to use the original commit title');
+      ->setCaption(pht('Leave this blank to use the original commit title'));
   }
 
   public function renderHelpForArcanist() {
-    $text =
+    $text = pht(
       "A one-line title summarizing this request. ".
-      "Leave blank to use the original commit title.\n";
+      'Leave blank to use the original commit title.')."\n";
     return phutil_console_wrap($text, 8);
   }
 
   public function validate($summary) {
     if ($summary && strlen($summary) > self::MAX_SUMMARY_LENGTH) {
-      $this->error = 'Too long!';
+      $this->error = pht('Too long!');
       throw new ReleephFieldParseException(
-        $this, sprintf(
+        $this,
+        pht(
           'Please keep your summary to under %d characters.',
           self::MAX_SUMMARY_LENGTH));
     }
diff --git a/src/applications/releeph/mail/ReleephRequestReplyHandler.php b/src/applications/releeph/mail/ReleephRequestReplyHandler.php
index a0a049379d..9648941941 100644
--- a/src/applications/releeph/mail/ReleephRequestReplyHandler.php
+++ b/src/applications/releeph/mail/ReleephRequestReplyHandler.php
@@ -5,7 +5,7 @@ final class ReleephRequestReplyHandler
 
   public function validateMailReceiver($mail_receiver) {
     if (!($mail_receiver instanceof ReleephRequest)) {
-      throw new Exception('Mail receiver is not a ReleephRequest!');
+      throw new Exception(pht('Mail receiver is not a %s!', 'ReleephRequest'));
     }
   }
 
diff --git a/src/applications/releeph/query/ReleephBranchQuery.php b/src/applications/releeph/query/ReleephBranchQuery.php
index 201c2653d0..9d7c884012 100644
--- a/src/applications/releeph/query/ReleephBranchQuery.php
+++ b/src/applications/releeph/query/ReleephBranchQuery.php
@@ -137,7 +137,7 @@ final class ReleephBranchQuery
           'isActive = 1');
         break;
       default:
-        throw new Exception("Unknown status constant '{$status}'!");
+        throw new Exception(pht("Unknown status constant '%s'!", $status));
     }
 
     $where[] = $this->buildPagingClause($conn_r);
diff --git a/src/applications/releeph/query/ReleephRequestQuery.php b/src/applications/releeph/query/ReleephRequestQuery.php
index 1a5965ad43..363a3b05d6 100644
--- a/src/applications/releeph/query/ReleephRequestQuery.php
+++ b/src/applications/releeph/query/ReleephRequestQuery.php
@@ -236,7 +236,7 @@ final class ReleephRequestQuery
           ReleephRequestStatus::REVERTED,
         );
       default:
-        throw new Exception("Unknown status '{$this->status}'!");
+        throw new Exception(pht("Unknown status '%s'!", $this->status));
     }
   }
 
diff --git a/src/applications/releeph/storage/ReleephRequest.php b/src/applications/releeph/storage/ReleephRequest.php
index f2b51b6d89..c071600ec7 100644
--- a/src/applications/releeph/storage/ReleephRequest.php
+++ b/src/applications/releeph/storage/ReleephRequest.php
@@ -290,7 +290,7 @@ final class ReleephRequest extends ReleephDAO
   }
 
   public function setStatus($value) {
-    throw new Exception('`status` is now deprecated!');
+    throw new Exception(pht('`%s` is now deprecated!', 'status'));
   }
 
 /* -(  PhabricatorApplicationTransactionInterface  )------------------------- */
diff --git a/src/applications/releeph/view/branch/ReleephBranchPreviewView.php b/src/applications/releeph/view/branch/ReleephBranchPreviewView.php
index d81f1f5d01..afb3dffd4c 100644
--- a/src/applications/releeph/view/branch/ReleephBranchPreviewView.php
+++ b/src/applications/releeph/view/branch/ReleephBranchPreviewView.php
@@ -34,7 +34,9 @@ final class ReleephBranchPreviewView extends AphrontFormControl {
     foreach ($required_params as $param_name) {
       if (idx($all_params, $param_name) === null) {
         throw new Exception(
-          "'{$param_name}' is not set as either a static or dynamic!");
+          pht(
+            "'%s' is not set as either a static or dynamic!",
+            $param_name));
       }
     }
 
diff --git a/src/applications/releeph/view/branch/ReleephBranchTemplate.php b/src/applications/releeph/view/branch/ReleephBranchTemplate.php
index 030c70f8e9..79d19b8589 100644
--- a/src/applications/releeph/view/branch/ReleephBranchTemplate.php
+++ b/src/applications/releeph/view/branch/ReleephBranchTemplate.php
@@ -11,7 +11,7 @@ final class ReleephBranchTemplate {
   public static function getRequiredDefaultTemplate() {
     $template = self::getDefaultTemplate();
     if (!$template) {
-      throw new Exception(sprintf(
+      throw new Exception(pht(
         "Config setting '%s' must be set, ".
         "or you must provide a branch-template for each project!",
         self::KEY));
@@ -27,7 +27,9 @@ final class ReleephBranchTemplate {
       ->load($arc_project_id);
     if (!$arc_project) {
       throw new Exception(
-        "No Arc project found with id '{$arc_project_id}'!");
+        pht(
+          "No Arc project found with id '%s'!",
+          $arc_project_id));
     }
 
     $repository = null;
@@ -165,7 +167,7 @@ final class ReleephBranchTemplate {
     }
 
     if (!$is_symbolic && !$variable_interpolations) {
-      $errors[] = "Include additional interpolations that aren't static!";
+      $errors[] = pht("Include additional interpolations that aren't static!");
     }
 
     return array($name, $errors);
@@ -175,24 +177,27 @@ final class ReleephBranchTemplate {
     $errors = array();
 
     if (preg_match('{^/}', $name) || preg_match('{/$}', $name)) {
-      $errors[] = "Branches cannot begin or end with '/'";
+      $errors[] = pht("Branches cannot begin or end with '%s'", '/');
     }
 
     if (preg_match('{//+}', $name)) {
-      $errors[] = "Branches cannot contain multiple consective '/'";
+      $errors[] = pht("Branches cannot contain multiple consecutive '%s'", '/');
     }
 
     $parts = array_filter(explode('/', $name));
     foreach ($parts as $index => $part) {
       $part_error = null;
       if (preg_match('{^\.}', $part) || preg_match('{\.$}', $part)) {
-        $errors[] = "Path components cannot begin or end with '.'";
+        $errors[] = pht("Path components cannot begin or end with '%s'", '.');
       } else if (preg_match('{^(?!\w)}', $part)) {
-        $errors[] = 'Path components must begin with an alphanumeric';
+        $errors[] = pht('Path components must begin with an alphanumeric.');
       } else if (!preg_match('{^\w ([\w-_%\.]* [\w-_%])?$}x', $part)) {
-        $errors[] =
+        $errors[] = pht(
           "Path components may only contain alphanumerics ".
-          "or '-', '_', or '.'";
+          "or '%s', '%s' or '%s'.",
+          '-',
+          '_',
+          '.');
       }
     }
 
diff --git a/src/applications/remarkup/conduit/RemarkupProcessConduitAPIMethod.php b/src/applications/remarkup/conduit/RemarkupProcessConduitAPIMethod.php
index d6c0554234..f9169cd08c 100644
--- a/src/applications/remarkup/conduit/RemarkupProcessConduitAPIMethod.php
+++ b/src/applications/remarkup/conduit/RemarkupProcessConduitAPIMethod.php
@@ -11,7 +11,7 @@ final class RemarkupProcessConduitAPIMethod extends ConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Process text through remarkup in phabricator context.';
+    return pht('Process text through remarkup in Phabricator context.');
   }
 
   protected function defineReturnType() {
@@ -20,8 +20,8 @@ final class RemarkupProcessConduitAPIMethod extends ConduitAPIMethod {
 
   protected function defineErrorTypes() {
     return array(
-      'ERR-NO-CONTENT' => 'Content may not be empty.',
-      'ERR-INVALID-ENGINE' => 'Invalid markup engine.',
+      'ERR-NO-CONTENT' => pht('Content may not be empty.'),
+      'ERR-INVALID-ENGINE' => pht('Invalid markup engine.'),
     );
   }
 
diff --git a/src/applications/repository/conduit/RepositoryCreateConduitAPIMethod.php b/src/applications/repository/conduit/RepositoryCreateConduitAPIMethod.php
index 42df1b6d46..ad4b62104e 100644
--- a/src/applications/repository/conduit/RepositoryCreateConduitAPIMethod.php
+++ b/src/applications/repository/conduit/RepositoryCreateConduitAPIMethod.php
@@ -12,7 +12,7 @@ final class RepositoryCreateConduitAPIMethod
   }
 
   public function getMethodStatusDescription() {
-    return 'Repository methods are new and subject to change.';
+    return pht('Repository methods are new and subject to change.');
   }
 
   public function getMethodDescription() {
@@ -48,12 +48,10 @@ final class RepositoryCreateConduitAPIMethod
 
   protected function defineErrorTypes() {
     return array(
-      'ERR-DUPLICATE'   =>
-        'Duplicate repository callsign.',
-      'ERR-BAD-CALLSIGN' =>
-        'Callsign is required and must be ALL UPPERCASE LETTERS.',
-      'ERR-UNKNOWN-REPOSITORY-VCS' =>
-        'Unknown repository VCS type.',
+      'ERR-DUPLICATE' => pht('Duplicate repository callsign.'),
+      'ERR-BAD-CALLSIGN' => pht(
+        'Callsign is required and must be ALL UPPERCASE LETTERS.'),
+      'ERR-UNKNOWN-REPOSITORY-VCS' => pht('Unknown repository VCS type.'),
     );
   }
 
diff --git a/src/applications/repository/controller/PhabricatorRepositoryArcanistProjectDeleteController.php b/src/applications/repository/controller/PhabricatorRepositoryArcanistProjectDeleteController.php
index 4be5e1bfe4..04c2008897 100644
--- a/src/applications/repository/controller/PhabricatorRepositoryArcanistProjectDeleteController.php
+++ b/src/applications/repository/controller/PhabricatorRepositoryArcanistProjectDeleteController.php
@@ -28,10 +28,11 @@ final class PhabricatorRepositoryArcanistProjectDeleteController
     $dialog
       ->setUser($request->getUser())
       ->setTitle(pht('Really delete this arcanist project?'))
-      ->appendChild(pht(
-        'Really delete the "%s" arcanist project? '.
+      ->appendChild(
+        pht(
+          'Really delete the "%s" arcanist project? '.
           'This operation can not be undone.',
-        $arc_project->getName()))
+          $arc_project->getName()))
       ->setSubmitURI('/repository/project/delete/'.$this->id.'/')
       ->addSubmitButton(pht('Delete Arcanist Project'))
       ->addCancelButton('/repository/');
diff --git a/src/applications/repository/controller/PhabricatorRepositoryArcanistProjectEditController.php b/src/applications/repository/controller/PhabricatorRepositoryArcanistProjectEditController.php
index a439179034..c453ebb057 100644
--- a/src/applications/repository/controller/PhabricatorRepositoryArcanistProjectEditController.php
+++ b/src/applications/repository/controller/PhabricatorRepositoryArcanistProjectEditController.php
@@ -63,7 +63,7 @@ final class PhabricatorRepositoryArcanistProjectEditController
       ->appendChild(
         id(new AphrontFormSubmitControl())
           ->addCancelButton('/repository/')
-          ->setValue('Save'));
+          ->setValue(pht('Save')));
 
     $panel = new PHUIObjectBoxView();
     $panel->setHeaderText(pht('Edit Arcanist Project'));
diff --git a/src/applications/repository/controller/PhabricatorRepositoryListController.php b/src/applications/repository/controller/PhabricatorRepositoryListController.php
index 56e8dc37d8..89d068e283 100644
--- a/src/applications/repository/controller/PhabricatorRepositoryListController.php
+++ b/src/applications/repository/controller/PhabricatorRepositoryListController.php
@@ -25,7 +25,7 @@ final class PhabricatorRepositoryListController
           ),
           pht('View in Diffusion'));
       } else {
-        $diffusion_link = phutil_tag('em', array(), 'Not Tracked');
+        $diffusion_link = phutil_tag('em', array(), pht('Not Tracked'));
       }
 
       $rows[] = array(
diff --git a/src/applications/repository/daemon/PhabricatorGitGraphStream.php b/src/applications/repository/daemon/PhabricatorGitGraphStream.php
index 911e30cb52..334213048e 100644
--- a/src/applications/repository/daemon/PhabricatorGitGraphStream.php
+++ b/src/applications/repository/daemon/PhabricatorGitGraphStream.php
@@ -76,7 +76,10 @@ final class PhabricatorGitGraphStream
       }
     }
 
-    throw new Exception("No such commit '{$commit}' in repository!");
+    throw new Exception(
+      pht(
+        "No such commit '%s' in repository!",
+        $commit));
   }
 
   private function isParsed($commit) {
diff --git a/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php b/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php
index ff96dced3c..e2895972dd 100644
--- a/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php
+++ b/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php
@@ -43,18 +43,18 @@ final class PhabricatorRepositoryPullLocalDaemon
       array(
         array(
           'name'      => 'no-discovery',
-          'help'      => 'Pull only, without discovering commits.',
+          'help'      => pht('Pull only, without discovering commits.'),
         ),
         array(
           'name'      => 'not',
           'param'     => 'repository',
           'repeat'    => true,
-          'help'      => 'Do not pull __repository__.',
+          'help'      => pht('Do not pull __repository__.'),
         ),
         array(
           'name'      => 'repositories',
           'wildcard'  => true,
-          'help'      => 'Pull specific __repositories__ instead of all.',
+          'help'      => pht('Pull specific __repositories__ instead of all.'),
         ),
       ));
 
@@ -312,7 +312,9 @@ final class PhabricatorRepositoryPullLocalDaemon
       foreach ($include as $name) {
         if (empty($by_callsign[$name])) {
           throw new Exception(
-            "No repository exists with callsign '{$name}'!");
+            pht(
+              "No repository exists with callsign '%s'!",
+              $name));
         }
       }
     }
diff --git a/src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php b/src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php
index f404f9c8a4..407940e474 100644
--- a/src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php
+++ b/src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php
@@ -49,7 +49,7 @@ final class PhabricatorRepositoryDiscoveryEngine
         $refs = $this->discoverGitCommits();
         break;
       default:
-        throw new Exception("Unknown VCS '{$vcs}'!");
+        throw new Exception(pht("Unknown VCS '%s'!", $vcs));
     }
 
     // Clear the working set cache.
@@ -571,7 +571,7 @@ final class PhabricatorRepositoryDiscoveryEngine
         $class = 'PhabricatorRepositoryMercurialCommitMessageParserWorker';
         break;
       default:
-        throw new Exception("Unknown repository type '{$vcs}'!");
+        throw new Exception(pht("Unknown repository type '%s'!", $vcs));
     }
 
     $data['commitID'] = $commit->getID();
diff --git a/src/applications/repository/engine/PhabricatorRepositoryEngine.php b/src/applications/repository/engine/PhabricatorRepositoryEngine.php
index 300fde13e0..8d858a3d89 100644
--- a/src/applications/repository/engine/PhabricatorRepositoryEngine.php
+++ b/src/applications/repository/engine/PhabricatorRepositoryEngine.php
@@ -23,7 +23,7 @@ abstract class PhabricatorRepositoryEngine {
    */
   protected function getRepository() {
     if ($this->repository === null) {
-      throw new Exception('Call setRepository() to provide a repository!');
+      throw new PhutilInvalidStateException('setRepository');
     }
 
     return $this->repository;
diff --git a/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php b/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
index ffbbc7034b..d725148771 100644
--- a/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
+++ b/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
@@ -245,26 +245,31 @@ final class PhabricatorRepositoryPullEngine
       if (is_dir($path)) {
         $files = Filesystem::listDirectory($path, $include_hidden = true);
         if (!$files) {
-          $message =
-            "Expected to find a git repository at '{$path}', but there ".
+          $message = pht(
+            "Expected to find a git repository at '%s', but there ".
             "is an empty directory there. Remove the directory: the daemon ".
-            "will run 'git clone' for you.";
+            "will run '%s' for you.",
+            $path,
+            'git clone');
         } else {
-          $message =
-            "Expected to find a git repository at '{$path}', but there is ".
+          $message = pht(
+            "Expected to find a git repository at '%s', but there is ".
             "a non-repository directory (with other stuff in it) there. Move ".
             "or remove this directory (or reconfigure the repository to use a ".
             "different directory), and then either clone a repository ".
-            "yourself or let the daemon do it.";
+            "yourself or let the daemon do it.",
+            $path);
         }
       } else if (is_file($path)) {
-        $message =
-          "Expected to find a git repository at '{$path}', but there is a ".
+        $message = pht(
+          "Expected to find a git repository at '%s', but there is a ".
           "file there instead. Remove it and let the daemon clone a ".
-          "repository for you.";
+          "repository for you.",
+          $path);
       } else {
-        $message =
-          "Expected to find a git repository at '{$path}', but did not.";
+        $message = pht(
+          "Expected to find a git repository at '%s', but did not.",
+          $path);
       }
     } else {
       $repo_path = rtrim($stdout, "\n");
@@ -277,18 +282,24 @@ final class PhabricatorRepositoryPullEngine
         // we're OK.
       } else if (!Filesystem::pathsAreEquivalent($repo_path, $path)) {
         $err = true;
-        $message =
-          "Expected to find repo at '{$path}', but the actual ".
-          "git repository root for this directory is '{$repo_path}'. ".
-          "Something is misconfigured. The repository's 'Local Path' should ".
-          "be set to some place where the daemon can check out a working ".
-          "copy, and should not be inside another git repository.";
+        $message = pht(
+          "Expected to find repo at '%s', but the actual git repository root ".
+          "for this directory is '%s'. Something is misconfigured. ".
+          "The repository's 'Local Path' should be set to some place where ".
+          "the daemon can check out a working copy, ".
+          "and should not be inside another git repository.",
+          $path,
+          $repo_path);
       }
     }
 
     if ($err && $repository->canDestroyWorkingCopy()) {
-      phlog("Repository working copy at '{$path}' failed sanity check; ".
-            "destroying and re-cloning. {$message}");
+      phlog(
+        pht(
+          "Repository working copy at '%s' failed sanity check; ".
+          "destroying and re-cloning. %s",
+          $path,
+          $message));
       Filesystem::remove($path);
       $this->executeGitCreate();
     } else if ($err) {
@@ -324,9 +335,11 @@ final class PhabricatorRepositoryPullEngine
         }
       } else if ($err) {
         throw new Exception(
-          "git fetch failed with error #{$err}:\n".
-          "stdout:{$stdout}\n\n".
-          "stderr:{$stderr}\n");
+          pht(
+            "git fetch failed with error #%d:\nstdout:%s\n\nstderr:%s\n",
+            $err,
+            $stdout,
+            $stderr));
       } else {
         $retry = false;
       }
diff --git a/src/applications/repository/engine/PhabricatorRepositoryRefEngine.php b/src/applications/repository/engine/PhabricatorRepositoryRefEngine.php
index a393a6be69..0eab00b5c9 100644
--- a/src/applications/repository/engine/PhabricatorRepositoryRefEngine.php
+++ b/src/applications/repository/engine/PhabricatorRepositoryRefEngine.php
@@ -397,7 +397,7 @@ final class PhabricatorRepositoryRefEngine
         $class = 'PhabricatorRepositoryMercurialCommitMessageParserWorker';
         break;
       default:
-        throw new Exception("Unknown repository type '{$vcs}'!");
+        throw new Exception(pht("Unknown repository type '%s'!", $vcs));
     }
 
     $all_commits = queryfx_all(
diff --git a/src/applications/repository/engine/__tests__/PhabricatorWorkingCopyDiscoveryTestCase.php b/src/applications/repository/engine/__tests__/PhabricatorWorkingCopyDiscoveryTestCase.php
index 1e9c83da26..f912a551c5 100644
--- a/src/applications/repository/engine/__tests__/PhabricatorWorkingCopyDiscoveryTestCase.php
+++ b/src/applications/repository/engine/__tests__/PhabricatorWorkingCopyDiscoveryTestCase.php
@@ -11,7 +11,7 @@ final class PhabricatorWorkingCopyDiscoveryTestCase
         1368319448,
       ),
       mpull($refs, 'getEpoch'),
-      'Commit Epochs');
+      pht('Commit Epochs'));
   }
 
   public function testMercurialCommitDiscovery() {
diff --git a/src/applications/repository/engine/__tests__/PhabricatorWorkingCopyTestCase.php b/src/applications/repository/engine/__tests__/PhabricatorWorkingCopyTestCase.php
index 40412e45d0..5a9be99212 100644
--- a/src/applications/repository/engine/__tests__/PhabricatorWorkingCopyTestCase.php
+++ b/src/applications/repository/engine/__tests__/PhabricatorWorkingCopyTestCase.php
@@ -37,14 +37,21 @@ abstract class PhabricatorWorkingCopyTestCase extends PhabricatorTestCase {
 
     if (!$hits) {
       throw new Exception(
-        "No test data for callsign '{$callsign}'. Expected an archive ".
-        "like '{$callsign}.git.tgz' in '{$data_dir}'.");
+        pht(
+          "No test data for callsign '%s'. Expected an archive ".
+          "like '%s' in '%s'.",
+          $callsign,
+          "{$callsign}.git.tgz",
+          $data_dir));
     }
 
     if (count($hits) > 1) {
       throw new Exception(
-        "Expected exactly one archive matching callsign '{$callsign}', ".
-        "found too many: ".implode(', ', $hits));
+        pht(
+          "Expected exactly one archive matching callsign '%s', ".
+          "found too many: %s",
+          $callsign,
+          implode(', ', $hits)));
     }
 
     $path = head($hits);
diff --git a/src/applications/repository/graphcache/PhabricatorRepositoryGraphCache.php b/src/applications/repository/graphcache/PhabricatorRepositoryGraphCache.php
index f1e5aff4ef..5c3081a7b7 100644
--- a/src/applications/repository/graphcache/PhabricatorRepositoryGraphCache.php
+++ b/src/applications/repository/graphcache/PhabricatorRepositoryGraphCache.php
@@ -106,7 +106,7 @@ final class PhabricatorRepositoryGraphCache {
 
       // Sanity check so we can survive and recover from bad data.
       if (isset($seen[$commit_id])) {
-        phlog(pht('Unexpected infinite loop in RepositoryGraphCache!'));
+        phlog(pht('Unexpected infinite loop in %s!', __CLASS__));
         return false;
       } else {
         $seen[$commit_id] = true;
diff --git a/src/applications/repository/management/PhabricatorRepositoryManagementCacheWorkflow.php b/src/applications/repository/management/PhabricatorRepositoryManagementCacheWorkflow.php
index b34e430ff4..a78dff1a73 100644
--- a/src/applications/repository/management/PhabricatorRepositoryManagementCacheWorkflow.php
+++ b/src/applications/repository/management/PhabricatorRepositoryManagementCacheWorkflow.php
@@ -29,14 +29,18 @@ final class PhabricatorRepositoryManagementCacheWorkflow
     $commit_name = $args->getArg('commit');
     if ($commit_name === null) {
       throw new PhutilArgumentUsageException(
-        pht('Specify a commit to look up with `--commit`.'));
+        pht(
+          'Specify a commit to look up with `%s`.',
+          '--commit'));
     }
     $commit = $this->loadNamedCommit($commit_name);
 
     $path_name = $args->getArg('path');
     if ($path_name === null) {
       throw new PhutilArgumentUsageException(
-        pht('Specify a path to look up with `--path`.'));
+        pht(
+          'Specify a path to look up with `%s`.',
+          '--path'));
     }
 
     $path_map = id(new DiffusionPathIDQuery(array($path_name)))
@@ -62,9 +66,7 @@ final class PhabricatorRepositoryManagementCacheWorkflow
       pht('Query took %s ms.', new PhutilNumber(1000 * ($t_end - $t_start))));
 
     if ($cache_result === false) {
-      $console->writeOut(
-        "%s\n",
-        pht('Not found in graph cache.'));
+      $console->writeOut("%s\n", pht('Not found in graph cache.'));
     } else if ($cache_result === null) {
       $console->writeOut(
         "%s\n",
diff --git a/src/applications/repository/management/PhabricatorRepositoryManagementDiscoverWorkflow.php b/src/applications/repository/management/PhabricatorRepositoryManagementDiscoverWorkflow.php
index 66d9a22fec..526348d150 100644
--- a/src/applications/repository/management/PhabricatorRepositoryManagementDiscoverWorkflow.php
+++ b/src/applications/repository/management/PhabricatorRepositoryManagementDiscoverWorkflow.php
@@ -7,17 +7,17 @@ final class PhabricatorRepositoryManagementDiscoverWorkflow
     $this
       ->setName('discover')
       ->setExamples('**discover** [__options__] __repository__ ...')
-      ->setSynopsis('Discover __repository__, named by callsign.')
+      ->setSynopsis(pht('Discover __repository__, named by callsign.'))
       ->setArguments(
         array(
           array(
             'name'        => 'verbose',
-            'help'        => 'Show additional debugging information.',
+            'help'        => pht('Show additional debugging information.'),
           ),
           array(
             'name'        => 'repair',
-            'help'        => 'Repair a repository with gaps in commit '.
-                             'history.',
+            'help'        => pht(
+              'Repair a repository with gaps in commit history.'),
           ),
           array(
             'name'        => 'repos',
@@ -31,12 +31,14 @@ final class PhabricatorRepositoryManagementDiscoverWorkflow
 
     if (!$repos) {
       throw new PhutilArgumentUsageException(
-        'Specify one or more repositories to discover, by callsign.');
+        pht('Specify one or more repositories to discover, by callsign.'));
     }
 
     $console = PhutilConsole::getConsole();
     foreach ($repos as $repo) {
-      $console->writeOut("Discovering '%s'...\n", $repo->getCallsign());
+      $console->writeOut(
+        "%s\n",
+        pht("Discovering '%s'...", $repo->getCallsign()));
 
       id(new PhabricatorRepositoryDiscoveryEngine())
         ->setRepository($repo)
@@ -45,7 +47,7 @@ final class PhabricatorRepositoryManagementDiscoverWorkflow
         ->discoverCommits();
     }
 
-    $console->writeOut("Done.\n");
+    $console->writeOut("%s\n", pht('Done.'));
 
     return 0;
   }
diff --git a/src/applications/repository/management/PhabricatorRepositoryManagementEditWorkflow.php b/src/applications/repository/management/PhabricatorRepositoryManagementEditWorkflow.php
index ac7a7c6b07..d42ecf9526 100644
--- a/src/applications/repository/management/PhabricatorRepositoryManagementEditWorkflow.php
+++ b/src/applications/repository/management/PhabricatorRepositoryManagementEditWorkflow.php
@@ -7,7 +7,7 @@ final class PhabricatorRepositoryManagementEditWorkflow
     $this
       ->setName('edit')
       ->setExamples('**edit** --as __username__ __repository__ ...')
-      ->setSynopsis('Edit __repository__, named by callsign.')
+      ->setSynopsis(pht('Edit __repository__, named by callsign.'))
       ->setArguments(
         array(
           array(
@@ -17,12 +17,12 @@ final class PhabricatorRepositoryManagementEditWorkflow
           array(
             'name' => 'as',
             'param' => 'user',
-            'help' => 'Edit as user.',
+            'help' => pht('Edit as user.'),
           ),
           array(
             'name' => 'local-path',
             'param' => 'path',
-            'help' => 'Edit the local path.',
+            'help' => pht('Edit the local path.'),
           ),
         ));
   }
@@ -32,7 +32,7 @@ final class PhabricatorRepositoryManagementEditWorkflow
 
     if (!$repos) {
       throw new PhutilArgumentUsageException(
-        'Specify one or more repositories to edit, by callsign.');
+        pht('Specify one or more repositories to edit, by callsign.'));
     }
 
     $console = PhutilConsole::getConsole();
@@ -47,7 +47,9 @@ final class PhabricatorRepositoryManagementEditWorkflow
     $username = $args->getArg('as');
     if (!$username) {
       throw new PhutilArgumentUsageException(
-        pht('Specify a user to edit as with --as <username>.'));
+        pht(
+          'Specify a user to edit as with %s.',
+          '--as <username>'));
     }
 
     $actor = id(new PhabricatorPeopleQuery())
@@ -61,7 +63,7 @@ final class PhabricatorRepositoryManagementEditWorkflow
     }
 
     foreach ($repos as $repo) {
-      $console->writeOut("Editing '%s'...\n", $repo->getCallsign());
+      $console->writeOut("%s\n", pht("Editing '%s'...", $repo->getCallsign()));
 
       $xactions = array();
 
@@ -88,7 +90,7 @@ final class PhabricatorRepositoryManagementEditWorkflow
         ->applyTransactions($repo, $xactions);
     }
 
-    $console->writeOut("Done.\n");
+    $console->writeOut("%s\n", pht('Done.'));
 
     return 0;
   }
diff --git a/src/applications/repository/management/PhabricatorRepositoryManagementImportingWorkflow.php b/src/applications/repository/management/PhabricatorRepositoryManagementImportingWorkflow.php
index d895b07ae6..7fabffe7bd 100644
--- a/src/applications/repository/management/PhabricatorRepositoryManagementImportingWorkflow.php
+++ b/src/applications/repository/management/PhabricatorRepositoryManagementImportingWorkflow.php
@@ -8,13 +8,14 @@ final class PhabricatorRepositoryManagementImportingWorkflow
       ->setName('importing')
       ->setExamples('**importing** __repository__ ...')
       ->setSynopsis(
-        'Show commits in __repository__, named by callsign, which are still '.
-        'importing.')
+        pht(
+          'Show commits in __repository__, named by callsign, which are '.
+          'still importing.'))
       ->setArguments(
         array(
           array(
             'name'        => 'simple',
-            'help'        => 'Show simpler output.',
+            'help'        => pht('Show simpler output.'),
           ),
           array(
             'name'        => 'repos',
@@ -28,8 +29,9 @@ final class PhabricatorRepositoryManagementImportingWorkflow
 
     if (!$repos) {
       throw new PhutilArgumentUsageException(
-        'Specify one or more repositories to find importing commits for, '.
-        'by callsign.');
+        pht(
+          'Specify one or more repositories to find importing commits for, '.
+          'by callsign.'));
     }
 
     $repos = mpull($repos, null, 'getID');
diff --git a/src/applications/repository/management/PhabricatorRepositoryManagementListWorkflow.php b/src/applications/repository/management/PhabricatorRepositoryManagementListWorkflow.php
index 9d584af738..a663142987 100644
--- a/src/applications/repository/management/PhabricatorRepositoryManagementListWorkflow.php
+++ b/src/applications/repository/management/PhabricatorRepositoryManagementListWorkflow.php
@@ -6,7 +6,7 @@ final class PhabricatorRepositoryManagementListWorkflow
   protected function didConstruct() {
     $this
       ->setName('list')
-      ->setSynopsis('Show a list of repositories.')
+      ->setSynopsis(pht('Show a list of repositories.'))
       ->setArguments(array());
   }
 
@@ -21,7 +21,7 @@ final class PhabricatorRepositoryManagementListWorkflow
         $console->writeOut("%s\n", $repo->getCallsign());
       }
     } else {
-      $console->writeErr("%s\n", 'There are no repositories.');
+      $console->writeErr("%s\n", pht('There are no repositories.'));
     }
 
     return 0;
diff --git a/src/applications/repository/management/PhabricatorRepositoryManagementLookupUsersWorkflow.php b/src/applications/repository/management/PhabricatorRepositoryManagementLookupUsersWorkflow.php
index e4f03a4d1b..949fd96141 100644
--- a/src/applications/repository/management/PhabricatorRepositoryManagementLookupUsersWorkflow.php
+++ b/src/applications/repository/management/PhabricatorRepositoryManagementLookupUsersWorkflow.php
@@ -7,7 +7,8 @@ final class PhabricatorRepositoryManagementLookupUsersWorkflow
     $this
       ->setName('lookup-users')
       ->setExamples('**lookup-users** __commit__ ...')
-      ->setSynopsis('Resolve user accounts for users attached to __commit__.')
+      ->setSynopsis(
+        pht('Resolve user accounts for users attached to __commit__.'))
       ->setArguments(
         array(
           array(
@@ -21,7 +22,7 @@ final class PhabricatorRepositoryManagementLookupUsersWorkflow
     $commits = $this->loadCommits($args, 'commits');
     if (!$commits) {
       throw new PhutilArgumentUsageException(
-        'Specify one or more commits to resolve users for.');
+        pht('Specify one or more commits to resolve users for.'));
     }
 
     $console = PhutilConsole::getConsole();
diff --git a/src/applications/repository/management/PhabricatorRepositoryManagementMarkImportedWorkflow.php b/src/applications/repository/management/PhabricatorRepositoryManagementMarkImportedWorkflow.php
index 411a3e10c1..fb14261df0 100644
--- a/src/applications/repository/management/PhabricatorRepositoryManagementMarkImportedWorkflow.php
+++ b/src/applications/repository/management/PhabricatorRepositoryManagementMarkImportedWorkflow.php
@@ -7,12 +7,12 @@ final class PhabricatorRepositoryManagementMarkImportedWorkflow
     $this
       ->setName('mark-imported')
       ->setExamples('**mark-imported** __repository__ ...')
-      ->setSynopsis('Mark __repository__, named by callsign, as imported.')
+      ->setSynopsis(pht('Mark __repository__, named by callsign, as imported.'))
       ->setArguments(
         array(
           array(
             'name'        => 'mark-not-imported',
-            'help'        => 'Instead, mark repositories as NOT imported.',
+            'help'        => pht('Instead, mark repositories as NOT imported.'),
           ),
           array(
             'name'        => 'repos',
@@ -26,7 +26,7 @@ final class PhabricatorRepositoryManagementMarkImportedWorkflow
 
     if (!$repos) {
       throw new PhutilArgumentUsageException(
-        'Specify one or more repositories to mark imported, by callsign.');
+        pht('Specify one or more repositories to mark imported, by callsign.'));
     }
 
     $new_importing_value = (bool)$args->getArg('mark-not-imported');
@@ -59,7 +59,7 @@ final class PhabricatorRepositoryManagementMarkImportedWorkflow
       }
     }
 
-    $console->writeOut("Done.\n");
+    $console->writeOut("%s\n", pht('Done.'));
 
     return 0;
   }
diff --git a/src/applications/repository/management/PhabricatorRepositoryManagementMirrorWorkflow.php b/src/applications/repository/management/PhabricatorRepositoryManagementMirrorWorkflow.php
index 243ae640a8..4a4c732558 100644
--- a/src/applications/repository/management/PhabricatorRepositoryManagementMirrorWorkflow.php
+++ b/src/applications/repository/management/PhabricatorRepositoryManagementMirrorWorkflow.php
@@ -28,8 +28,7 @@ final class PhabricatorRepositoryManagementMirrorWorkflow
     if (!$repos) {
       throw new PhutilArgumentUsageException(
         pht(
-          'Specify one or more repositories to push to mirrors, by '.
-          'callsign.'));
+          'Specify one or more repositories to push to mirrors, by callsign.'));
     }
 
     $console = PhutilConsole::getConsole();
@@ -44,7 +43,7 @@ final class PhabricatorRepositoryManagementMirrorWorkflow
         ->pushToMirrors();
     }
 
-    $console->writeOut("Done.\n");
+    $console->writeOut('%s\b', pht('Done.'));
 
     return 0;
   }
diff --git a/src/applications/repository/management/PhabricatorRepositoryManagementPullWorkflow.php b/src/applications/repository/management/PhabricatorRepositoryManagementPullWorkflow.php
index 4cc7605610..b58c56d46b 100644
--- a/src/applications/repository/management/PhabricatorRepositoryManagementPullWorkflow.php
+++ b/src/applications/repository/management/PhabricatorRepositoryManagementPullWorkflow.php
@@ -7,16 +7,16 @@ final class PhabricatorRepositoryManagementPullWorkflow
     $this
       ->setName('pull')
       ->setExamples('**pull** __repository__ ...')
-      ->setSynopsis('Pull __repository__, named by callsign.')
+      ->setSynopsis(pht('Pull __repository__, named by callsign.'))
       ->setArguments(
         array(
           array(
-            'name'        => 'verbose',
-            'help'        => 'Show additional debugging information.',
+            'name'      => 'verbose',
+            'help'      => pht('Show additional debugging information.'),
           ),
           array(
-            'name'        => 'repos',
-            'wildcard'    => true,
+            'name'      => 'repos',
+            'wildcard'  => true,
           ),
         ));
   }
@@ -26,12 +26,12 @@ final class PhabricatorRepositoryManagementPullWorkflow
 
     if (!$repos) {
       throw new PhutilArgumentUsageException(
-        'Specify one or more repositories to pull, by callsign.');
+        pht('Specify one or more repositories to pull, by callsign.'));
     }
 
     $console = PhutilConsole::getConsole();
     foreach ($repos as $repo) {
-      $console->writeOut("Pulling '%s'...\n", $repo->getCallsign());
+      $console->writeOut("%s\n", pht("Pulling '%s'...", $repo->getCallsign()));
 
       id(new PhabricatorRepositoryPullEngine())
         ->setRepository($repo)
@@ -39,7 +39,7 @@ final class PhabricatorRepositoryManagementPullWorkflow
         ->pullRepository();
     }
 
-    $console->writeOut("Done.\n");
+    $console->writeOut("%s\n", pht('Done.'));
 
     return 0;
   }
diff --git a/src/applications/repository/management/PhabricatorRepositoryManagementRefsWorkflow.php b/src/applications/repository/management/PhabricatorRepositoryManagementRefsWorkflow.php
index 77eb9608f2..5d5dd169e8 100644
--- a/src/applications/repository/management/PhabricatorRepositoryManagementRefsWorkflow.php
+++ b/src/applications/repository/management/PhabricatorRepositoryManagementRefsWorkflow.php
@@ -7,12 +7,12 @@ final class PhabricatorRepositoryManagementRefsWorkflow
     $this
       ->setName('refs')
       ->setExamples('**refs** [__options__] __repository__ ...')
-      ->setSynopsis('Update refs in __repository__, named by callsign.')
+      ->setSynopsis(pht('Update refs in __repository__, named by callsign.'))
       ->setArguments(
         array(
           array(
             'name'        => 'verbose',
-            'help'        => 'Show additional debugging information.',
+            'help'        => pht('Show additional debugging information.'),
           ),
           array(
             'name'        => 'repos',
@@ -33,7 +33,9 @@ final class PhabricatorRepositoryManagementRefsWorkflow
 
     $console = PhutilConsole::getConsole();
     foreach ($repos as $repo) {
-      $console->writeOut("Updating refs in '%s'...\n", $repo->getCallsign());
+      $console->writeOut(
+        "%s\n",
+        pht("Updating refs in '%s'...", $repo->getCallsign()));
 
       $engine = id(new PhabricatorRepositoryRefEngine())
         ->setRepository($repo)
@@ -41,7 +43,7 @@ final class PhabricatorRepositoryManagementRefsWorkflow
         ->updateRefs();
     }
 
-    $console->writeOut("Done.\n");
+    $console->writeOut("%s\n", pht('Done.'));
 
     return 0;
   }
diff --git a/src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php b/src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php
index 9f3aa2715c..275577ea33 100644
--- a/src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php
+++ b/src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php
@@ -7,18 +7,19 @@ final class PhabricatorRepositoryManagementReparseWorkflow
     $this
       ->setName('reparse')
       ->setExamples('**reparse** [options] __repository__')
-      ->setSynopsis(pht(
-        '**reparse** __what__ __which_parts__ [--trace] [--force]'."\n\n".
-        'Rerun the Diffusion parser on specific commits and repositories. '.
-        'Mostly useful for debugging changes to Diffusion.'."\n\n".
-        'e.g. enqueue reparse owners in the TEST repo for all commits:'."\n".
-        'repository reparse --all TEST --owners'."\n\n".
-        'e.g. do same but exclude before yesterday (local time):'."\n".
-        'repository reparse --all TEST --owners --min-date yesterday'."\n".
-        'repository reparse --all TEST --owners --min-date "today -1 day".'.
-        "\n\n".
-        'e.g. do same but exclude before 03/31/2013 (local time):'."\n".
-        'repository reparse --all TEST --owners --min-date "03/31/2013"'))
+      ->setSynopsis(
+        pht(
+          '**reparse** __what__ __which_parts__ [--trace] [--force]'."\n\n".
+          'Rerun the Diffusion parser on specific commits and repositories. '.
+          'Mostly useful for debugging changes to Diffusion.'."\n\n".
+          'e.g. enqueue reparse owners in the TEST repo for all commits:'."\n".
+          'repository reparse --all TEST --owners'."\n\n".
+          'e.g. do same but exclude before yesterday (local time):'."\n".
+          'repository reparse --all TEST --owners --min-date yesterday'."\n".
+          'repository reparse --all TEST --owners --min-date "today -1 day".'.
+          "\n\n".
+          'e.g. do same but exclude before 03/31/2013 (local time):'."\n".
+          'repository reparse --all TEST --owners --min-date "03/31/2013"'))
       ->setArguments(
         array(
           array(
@@ -31,22 +32,24 @@ final class PhabricatorRepositoryManagementReparseWorkflow
             'help'     => pht(
               'Reparse all commits in the specified repository. This mode '.
               'queues parsers into the task queue; you must run taskmasters '.
-              'to actually do the parses. Use with __--force-local__ to run '.
-              'the tasks locally instead of with taskmasters.'),
+              'to actually do the parses. Use with __%s__ to run '.
+              'the tasks locally instead of with taskmasters.',
+              '--force-local'),
           ),
           array(
             'name'     => 'min-date',
             'param'    => 'date',
             'help'     => pht(
-              'Must be used with __--all__, this will exclude commits which '.
-              'are earlier than __date__.'."\n".
+              "Must be used with __%s__, this will exclude commits which ".
+              "are earlier than __date__.\n".
               "Valid examples:\n".
               "  'today', 'today 2pm', '-1 hour', '-2 hours', '-24 hours',\n".
               "  'yesterday', 'today -1 day', 'yesterday 2pm', '2pm -1 day',\n".
               "  'last Monday', 'last Monday 14:00', 'last Monday 2pm',\n".
               "  '31 March 2013', '31 Mar', '03/31', '03/31/2013',\n".
-              'See __http://www.php.net/manual/en/datetime.formats.php__ for '.
-              'more.'),
+              "See __%s__ for more.",
+              '--all',
+              'http://www.php.net/manual/en/datetime.formats.php'),
           ),
           array(
             'name'     => 'message',
@@ -76,14 +79,16 @@ final class PhabricatorRepositoryManagementReparseWorkflow
           array(
             'name'     => 'force-local',
             'help'     => pht(
-              'Only used with __--all__, use this to run the tasks locally '.
-              'instead of deferring them to taskmaster daemons.'),
+              'Only used with __%s__, use this to run the tasks locally '.
+              'instead of deferring them to taskmaster daemons.',
+              '--all'),
           ),
           array(
             'name'    => 'force-autoclose',
             'help'    => pht(
-              'Only used with __--message__, use this to make sure any '.
-              'pertinent diffs are closed regardless of configuration.'),
+              'Only used with __%s, use this to make sure any '.
+              'pertinent diffs are closed regardless of configuration.',
+              '--message__'),
           ),
         ));
 
@@ -121,8 +126,12 @@ final class PhabricatorRepositoryManagementReparseWorkflow
     if (!$reparse_message && !$reparse_change && !$reparse_herald &&
       !$reparse_owners) {
       throw new PhutilArgumentUsageException(
-        pht('Specify what information to reparse with --message, --change,  '.
-            '--herald, and/or --owners'));
+        pht(
+          'Specify what information to reparse with %s, %s, %s, and/or %s.',
+          '--message',
+          '--change',
+          '--herald',
+          '--owners'));
       }
 
     $min_timestamp = false;
@@ -148,12 +157,14 @@ final class PhabricatorRepositoryManagementReparseWorkflow
     }
 
     if ($reparse_owners && !$force) {
-      $console->writeOut("%s\n", pht(
-        'You are about to recreate the relationship entries between the '.
-        'commits and the packages they touch. This might delete some existing '.
-        'relationship entries for some old commits.'));
+      $console->writeOut(
+        "%s\n",
+        pht(
+          'You are about to recreate the relationship entries between the '.
+          'commits and the packages they touch. This might delete some '.
+          'existing relationship entries for some old commits.'));
 
-      if (!phutil_console_confirm('Are you ready to continue?')) {
+      if (!phutil_console_confirm(pht('Are you ready to continue?'))) {
         throw new PhutilArgumentUsageException(pht('Cancelled.'));
       }
     }
diff --git a/src/applications/repository/management/PhabricatorRepositoryManagementUpdateWorkflow.php b/src/applications/repository/management/PhabricatorRepositoryManagementUpdateWorkflow.php
index afe8b9e5d5..99b4a3adc6 100644
--- a/src/applications/repository/management/PhabricatorRepositoryManagementUpdateWorkflow.php
+++ b/src/applications/repository/management/PhabricatorRepositoryManagementUpdateWorkflow.php
@@ -27,11 +27,11 @@ final class PhabricatorRepositoryManagementUpdateWorkflow
         array(
           array(
             'name'        => 'verbose',
-            'help'        => 'Show additional debugging information.',
+            'help'        => pht('Show additional debugging information.'),
           ),
           array(
             'name'        => 'no-discovery',
-            'help'        => 'Do not perform discovery.',
+            'help'        => pht('Do not perform discovery.'),
           ),
           array(
             'name'        => 'repos',
diff --git a/src/applications/repository/management/PhabricatorRepositoryManagementWorkflow.php b/src/applications/repository/management/PhabricatorRepositoryManagementWorkflow.php
index 504772dcb2..26ab7c315e 100644
--- a/src/applications/repository/management/PhabricatorRepositoryManagementWorkflow.php
+++ b/src/applications/repository/management/PhabricatorRepositoryManagementWorkflow.php
@@ -19,7 +19,7 @@ abstract class PhabricatorRepositoryManagementWorkflow
     foreach ($callsigns as $callsign) {
       if (empty($repos[$callsign])) {
         throw new PhutilArgumentUsageException(
-          "No repository with callsign '{$callsign}' exists!");
+          pht("No repository with callsign '%s' exists!", $callsign));
       }
     }
 
diff --git a/src/applications/repository/query/PhabricatorRepositoryQuery.php b/src/applications/repository/query/PhabricatorRepositoryQuery.php
index eea20780bc..9a056b202a 100644
--- a/src/applications/repository/query/PhabricatorRepositoryQuery.php
+++ b/src/applications/repository/query/PhabricatorRepositoryQuery.php
@@ -141,8 +141,7 @@ final class PhabricatorRepositoryQuery
 
   public function getIdentifierMap() {
     if ($this->identifierMap === null) {
-      throw new Exception(
-        'You must execute() the query before accessing the identifier map.');
+      throw new PhutilInvalidStateException('execute');
     }
     return $this->identifierMap;
   }
@@ -239,7 +238,7 @@ final class PhabricatorRepositoryQuery
         case self::HOSTED_ALL:
           break;
         default:
-          throw new Exception("Uknown hosted failed '${hosted}'!");
+          throw new Exception(pht("Unknown hosted failed '%s'!", $hosted));
       }
     }
 
diff --git a/src/applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php b/src/applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php
index 1c17e39af9..9565bf7638 100644
--- a/src/applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php
+++ b/src/applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php
@@ -22,7 +22,7 @@ final class PhabricatorRepositoryCommitSearchIndexer
       ->withIDs(array($commit->getRepositoryID()))
       ->executeOne();
     if (!$repository) {
-      throw new Exception('No such repository!');
+      throw new Exception(pht('No such repository!'));
     }
 
     $title = 'r'.$repository->getCallsign().$commit->getCommitIdentifier().
diff --git a/src/applications/repository/storage/PhabricatorRepository.php b/src/applications/repository/storage/PhabricatorRepository.php
index 70387edec8..547fdb484d 100644
--- a/src/applications/repository/storage/PhabricatorRepository.php
+++ b/src/applications/repository/storage/PhabricatorRepository.php
@@ -220,7 +220,7 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
   public function getSubversionPathURI($path = null, $commit = null) {
     $vcs = $this->getVersionControlSystem();
     if ($vcs != PhabricatorRepositoryType::REPOSITORY_TYPE_SVN) {
-      throw new Exception('Not a subversion repository!');
+      throw new Exception(pht('Not a subversion repository!'));
     }
 
     if ($this->isHosted()) {
@@ -416,7 +416,7 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
         $env['HGPLAIN'] = 1;
         break;
       default:
-        throw new Exception('Unrecognized version control system.');
+        throw new Exception(pht('Unrecognized version control system.'));
     }
 
     return $env;
@@ -447,7 +447,7 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
           // command-line flag instead of an environmental variable.
           break;
         default:
-          throw new Exception('Unrecognized version control system.');
+          throw new Exception(pht('Unrecognized version control system.'));
       }
     }
 
@@ -501,7 +501,7 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
         }
         break;
       default:
-        throw new Exception('Unrecognized version control system.');
+        throw new Exception(pht('Unrecognized version control system.'));
     }
 
     array_unshift($args, $pattern);
@@ -524,7 +524,7 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
         $pattern = "hg {$pattern}";
         break;
       default:
-        throw new Exception('Unrecognized version control system.');
+        throw new Exception(pht('Unrecognized version control system.'));
     }
 
     array_unshift($args, $pattern);
@@ -592,7 +592,7 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
           $uri);
         break;
       default:
-        throw new Exception('Unrecognized version control system.');
+        throw new Exception(pht('Unrecognized version control system.'));
     }
 
     return $normalized_uri->getNormalizedPath();
@@ -799,7 +799,7 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
       case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
         break;
       default:
-        throw new Exception('Unrecognized version control system.');
+        throw new Exception(pht('Unrecognized version control system.'));
     }
 
     $closeable_flag = PhabricatorRepositoryCommit::IMPORTED_CLOSEABLE;
@@ -955,7 +955,7 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
       return $uri;
     }
 
-    throw new Exception("Remote URI '{$raw_uri}' could not be parsed!");
+    throw new Exception(pht("Remote URI '%s' could not be parsed!", $raw_uri));
   }
 
 
@@ -1457,8 +1457,7 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
   public static function assertValidRemoteURI($uri) {
     if (trim($uri) != $uri) {
       throw new Exception(
-        pht(
-          'The remote URI has leading or trailing whitespace.'));
+        pht('The remote URI has leading or trailing whitespace.'));
     }
 
     $protocol = self::getRemoteURIProtocol($uri);
@@ -1472,8 +1471,10 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
           pht(
             "The remote URI is not formatted correctly. Remote URIs ".
             "with an explicit protocol should be in the form ".
-            "'proto://domain/path', not 'proto://domain:/path'. ".
-            "The ':/path' syntax is only valid in SCP-style URIs."));
+            "'%s', not '%s'. The '%s' syntax is only valid in SCP-style URIs.",
+            'proto://domain/path',
+            'proto://domain:/path',
+            ':/path'));
       }
     }
 
@@ -1493,8 +1494,14 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
         throw new Exception(
           pht(
             "The URI protocol is unrecognized. It should begin ".
-            "'ssh://', 'http://', 'https://', 'git://', 'svn://', ".
-            "'svn+ssh://', or be in the form 'git@domain.com:path'."));
+            "'%s', '%s', '%s', '%s', '%s', '%s', or be in the form '%s'.",
+            'ssh://',
+            'http://',
+            'https://',
+            'git://',
+            'svn://',
+            'svn+ssh://',
+            'git@domain.com:path'));
     }
 
     return true;
@@ -1595,7 +1602,7 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
     if (!$service) {
       throw new Exception(
         pht(
-          'The Alamnac service for this repository is invalid or could not '.
+          'The Almanac service for this repository is invalid or could not '.
           'be loaded.'));
     }
 
@@ -1603,7 +1610,7 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
     if (!($service_type instanceof AlmanacClusterRepositoryServiceType)) {
       throw new Exception(
         pht(
-          'The Alamnac service for this repository does not have the correct '.
+          'The Almanac service for this repository does not have the correct '.
           'service type.'));
     }
 
@@ -1611,7 +1618,7 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
     if (!$bindings) {
       throw new Exception(
         pht(
-          'The Alamanc service for this repository is not bound to any '.
+          'The Almanac service for this repository is not bound to any '.
           'interfaces.'));
     }
 
@@ -1742,8 +1749,8 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
           pht(
             'Unable to read device public key while attempting to make '.
             'authenticated method call within the Phabricator cluster. '.
-            'Use `bin/almanac register` to register keys for this device. '.
-            'Exception: %s',
+            'Use `%s` to register keys for this device. Exception: %s',
+            'bin/almanac register',
             $ex->getMessage()),
           array($ex));
       }
@@ -1757,8 +1764,8 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
           pht(
             'Unable to read device private key while attempting to make '.
             'authenticated method call within the Phabricator cluster. '.
-            'Use `bin/almanac register` to register keys for this device. '.
-            'Exception: %s',
+            'Use `%s` to register keys for this device. Exception: %s',
+            'bin/almanac register',
             $ex->getMessage()),
           array($ex));
       }
diff --git a/src/applications/repository/storage/PhabricatorRepositoryVCSPassword.php b/src/applications/repository/storage/PhabricatorRepositoryVCSPassword.php
index f9cbb69a03..2f5c20cf7e 100644
--- a/src/applications/repository/storage/PhabricatorRepositoryVCSPassword.php
+++ b/src/applications/repository/storage/PhabricatorRepositoryVCSPassword.php
@@ -40,7 +40,7 @@ final class PhabricatorRepositoryVCSPassword extends PhabricatorRepositoryDAO {
     PhutilOpaqueEnvelope $password,
     PhabricatorUser $user) {
     if ($user->getPHID() != $this->getUserPHID()) {
-      throw new Exception('User does not match password user PHID!');
+      throw new Exception(pht('User does not match password user PHID!'));
     }
 
     $raw_input = PhabricatorHash::digestPassword($password, $user->getPHID());
diff --git a/src/applications/repository/storage/__tests__/PhabricatorRepositoryTestCase.php b/src/applications/repository/storage/__tests__/PhabricatorRepositoryTestCase.php
index 8e308ed602..7e71efe755 100644
--- a/src/applications/repository/storage/__tests__/PhabricatorRepositoryTestCase.php
+++ b/src/applications/repository/storage/__tests__/PhabricatorRepositoryTestCase.php
@@ -23,7 +23,7 @@ final class PhabricatorRepositoryTestCase
       $this->assertEqual(
         $expect,
         $repository->getRemoteProtocol(),
-        "Protocol for '{$uri}'.");
+        pht("Protocol for '%s'.", $uri));
     }
   }
 
@@ -35,7 +35,7 @@ final class PhabricatorRepositoryTestCase
 
     $this->assertTrue(
       $repo->shouldTrackBranch('imaginary'),
-      'Track all branches by default.');
+      pht('Track all branches by default.'));
 
     $repo->setDetail(
       'branch-filter',
@@ -45,11 +45,11 @@ final class PhabricatorRepositoryTestCase
 
     $this->assertTrue(
       $repo->shouldTrackBranch('master'),
-      'Track listed branches.');
+      pht('Track listed branches.'));
 
     $this->assertFalse(
       $repo->shouldTrackBranch('imaginary'),
-      'Do not track unlisted branches.');
+      pht('Do not track unlisted branches.'));
   }
 
   public function testSubversionPathInfo() {
diff --git a/src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php b/src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php
index 9866273886..5756c4e880 100644
--- a/src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php
+++ b/src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php
@@ -92,12 +92,12 @@ final class PhabricatorRepositoryCommitOwnersWorker
     $reasons = array();
 
     if ($data->getCommitDetail('vsDiff')) {
-      $reasons[] = 'Changed After Revision Was Accepted';
+      $reasons[] = pht('Changed After Revision Was Accepted');
     }
 
     $commit_author_phid = $data->getCommitDetail('authorPHID');
     if (!$commit_author_phid) {
-      $reasons[] = 'Commit Author Not Recognized';
+      $reasons[] = pht('Commit Author Not Recognized');
     }
 
     $revision_id = $data->getCommitDetail('differential.revisionID');
@@ -114,14 +114,14 @@ final class PhabricatorRepositoryCommitOwnersWorker
         $revision_author_phid = $revision->getAuthorPHID();
         $commit_reviewedby_phid = $data->getCommitDetail('reviewerPHID');
         if ($revision_author_phid !== $commit_author_phid) {
-          $reasons[] = 'Author Not Matching with Revision';
+          $reasons[] = pht('Author Not Matching with Revision');
         }
       } else {
-        $reasons[] = 'Revision Not Found';
+        $reasons[] = pht('Revision Not Found');
       }
 
     } else {
-      $reasons[] = 'No Revision Specified';
+      $reasons[] = pht('No Revision Specified');
     }
 
     $owners_phids = PhabricatorOwnersOwner::loadAffiliatedUserPHIDs(
@@ -130,7 +130,7 @@ final class PhabricatorRepositoryCommitOwnersWorker
     if (!($commit_author_phid && in_array($commit_author_phid, $owners_phids) ||
         $commit_reviewedby_phid && in_array($commit_reviewedby_phid,
           $owners_phids))) {
-      $reasons[] = 'Owners Not Involved';
+      $reasons[] = pht('Owners Not Involved');
     }
 
     return $reasons;
diff --git a/src/applications/repository/worker/__tests__/PhabricatorChangeParserTestCase.php b/src/applications/repository/worker/__tests__/PhabricatorChangeParserTestCase.php
index 7efc3a4a18..4925c9dbea 100644
--- a/src/applications/repository/worker/__tests__/PhabricatorChangeParserTestCase.php
+++ b/src/applications/repository/worker/__tests__/PhabricatorChangeParserTestCase.php
@@ -1138,7 +1138,7 @@ final class PhabricatorChangeParserTestCase
 
     $this->assertTrue(
       isset($commits['2']),
-      'Expect rCHE2 to exist as a foreign stub.');
+      pht('Expect %s to exist as a foreign stub.', 'rCHE2'));
 
     // The foreign stub should be marked imported.
 
diff --git a/src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryCommitChangeParserWorker.php b/src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryCommitChangeParserWorker.php
index ffcb78435e..92ba0d8c5b 100644
--- a/src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryCommitChangeParserWorker.php
+++ b/src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryCommitChangeParserWorker.php
@@ -21,9 +21,9 @@ abstract class PhabricatorRepositoryCommitChangeParserWorker
     $callsign = $repository->getCallsign();
     $full_name = 'r'.$callsign.$identifier;
 
-    $this->log("Parsing %s...\n", $full_name);
+    $this->log("%s\n", pht('Parsing %s...', $full_name));
     if ($this->isBadCommit($full_name)) {
-      $this->log('This commit is marked bad!');
+      $this->log(pht('This commit is marked bad!'));
       return;
     }
 
diff --git a/src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryGitCommitChangeParserWorker.php b/src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryGitCommitChangeParserWorker.php
index fb191631b9..4ab6f03f32 100644
--- a/src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryGitCommitChangeParserWorker.php
+++ b/src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryGitCommitChangeParserWorker.php
@@ -127,7 +127,7 @@ final class PhabricatorRepositoryGitCommitChangeParserWorker
         // NOTE: "U" (unmerged) and "X" (unknown) statuses are also possible
         // in theory but shouldn't appear here.
         default:
-          throw new Exception("Failed to parse line '{$line}'.");
+          throw new Exception(pht("Failed to parse line '%s'.", $line));
       }
 
       $changes[$change_path] = array(
diff --git a/src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php b/src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php
index e65905b986..6725ddb1d1 100644
--- a/src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php
+++ b/src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php
@@ -201,7 +201,7 @@ final class PhabricatorRepositorySvnCommitChangeParserWorker
 
               if ($source_file_type == DifferentialChangeType::FILE_DELETED) {
                 throw new Exception(
-                  'Something is wrong; source of a copy must exist.');
+                  pht('Something is wrong; source of a copy must exist.'));
               }
 
               if ($source_file_type != DifferentialChangeType::FILE_DIRECTORY) {
@@ -504,10 +504,11 @@ final class PhabricatorRepositorySvnCommitChangeParserWorker
     if ($need) {
       $subpath = $repository->getDetail('svn-subpath');
       if (!$subpath) {
-        $commits = implode(', ', $need);
         throw new Exception(
-          "Missing commits ({$need}) in a SVN repository which is not ".
-          "configured for subdirectory-only parsing!");
+          pht(
+            'Missing commits (%s) in a SVN repository which is not '.
+            'configured for subdirectory-only parsing!',
+            implode(', ', $need)));
       }
 
       foreach ($need as $foreign_commit) {
@@ -631,7 +632,7 @@ final class PhabricatorRepositorySvnCommitChangeParserWorker
       case 'dir':   return DifferentialChangeType::FILE_DIRECTORY;
       case 'file':  return DifferentialChangeType::FILE_NORMAL;
       default:
-        throw new Exception("Unknown SVN file kind '{$kind}'.");
+        throw new Exception(pht("Unknown SVN file kind '%s'.", $kind));
     }
   }
 
@@ -687,7 +688,7 @@ final class PhabricatorRepositorySvnCommitChangeParserWorker
                        '(<size>(.*?)</size>)?@';
             $matches = null;
             if (!preg_match($pattern, $entry, $matches)) {
-              throw new Exception('Unable to parse entry!');
+              throw new Exception(pht('Unable to parse entry!'));
             }
             $map[html_entity_decode($matches[2])] =
               $this->getFileTypeFromSVNKind($matches[1]);
@@ -704,40 +705,61 @@ final class PhabricatorRepositorySvnCommitChangeParserWorker
             $mode = 'entry';
             $entry = array();
           } else {
-            throw new Exception("Expected </list> or <entry, got {$line}.");
+            throw new Exception(
+              pht(
+                'Expected %s or %s, got %s.',
+                '</list>',
+                '<entry',
+                $line));
           }
           break;
         case 'xml':
           $expect = '/<?xml version="1.0".*?>/';
           if (!preg_match($expect, $line)) {
-            throw new Exception("Expected '{$expect}', got {$line}.");
+            throw new Exception(
+              pht(
+                "Expected '%s', got %s.",
+                $expect,
+                $line));
           }
           $mode = 'list';
           break;
         case 'list':
           $expect = '<lists>';
           if ($line !== $expect) {
-            throw new Exception("Expected '{$expect}', got {$line}.");
+            throw new Exception(
+              pht(
+                "Expected '%s', got %s.",
+                $expect,
+                $line));
           }
           $mode = 'list1';
           break;
         case 'list1':
           $expect = '<list';
           if ($line !== $expect) {
-            throw new Exception("Expected '{$expect}', got {$line}.");
+            throw new Exception(
+              pht(
+                "Expected '%s', got %s.",
+                $expect,
+                $line));
           }
           $mode = 'list2';
           break;
         case 'list2':
           if (!preg_match('/^\s+path="/', $line)) {
-            throw new Exception("Expected '   path=...', got {$line}.");
+            throw new Exception(
+              pht(
+                "Expected '%s', got %s.",
+                '   path=...',
+                $line));
           }
           $mode = 'entry-or-end';
           break;
       }
     }
     if (!$done) {
-      throw new Exception('Unexpected end of file.');
+      throw new Exception(pht('Unexpected end of file.'));
     }
 
     return $map;
diff --git a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
index 89fa5f34f4..c93810cb0c 100644
--- a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
+++ b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
@@ -317,9 +317,10 @@ abstract class PhabricatorRepositoryCommitMessageParserWorker
       ->setUnitStatus(DifferentialUnitStatus::UNIT_AUTO_SKIP)
       ->setDateCreated($this->commit->getEpoch())
       ->setDescription(
-        'Commit r'.
-        $this->repository->getCallsign().
-        $this->commit->getCommitIdentifier());
+        pht(
+          'Commit %s',
+          'r'.$this->repository->getCallsign().
+          $this->commit->getCommitIdentifier()));
 
     $parents = DiffusionQuery::callConduitWithDiffusionRequest(
       $viewer,
diff --git a/src/applications/search/controller/PhabricatorSearchAttachController.php b/src/applications/search/controller/PhabricatorSearchAttachController.php
index b2e0a92b9d..2d00ac8bda 100644
--- a/src/applications/search/controller/PhabricatorSearchAttachController.php
+++ b/src/applications/search/controller/PhabricatorSearchAttachController.php
@@ -200,43 +200,43 @@ final class PhabricatorSearchAttachController
   private function getStrings($attach_type, $action) {
     switch ($attach_type) {
       case DifferentialRevisionPHIDType::TYPECONST:
-        $noun = 'Revisions';
-        $selected = 'created';
+        $noun = pht('Revisions');
+        $selected = pht('created');
         break;
       case ManiphestTaskPHIDType::TYPECONST:
-        $noun = 'Tasks';
-        $selected = 'assigned';
+        $noun = pht('Tasks');
+        $selected = pht('assigned');
         break;
       case PhabricatorRepositoryCommitPHIDType::TYPECONST:
-        $noun = 'Commits';
-        $selected = 'created';
+        $noun = pht('Commits');
+        $selected = pht('created');
         break;
       case PholioMockPHIDType::TYPECONST:
-        $noun = 'Mocks';
-        $selected = 'created';
+        $noun = pht('Mocks');
+        $selected = pht('created');
         break;
     }
 
     switch ($action) {
       case self::ACTION_EDGE:
       case self::ACTION_ATTACH:
-        $dialog_title = "Manage Attached {$noun}";
-        $header_text = "Currently Attached {$noun}";
-        $button_text = "Save {$noun}";
+        $dialog_title = pht('Manage Attached %s', $noun);
+        $header_text = pht('Currently Attached %s', $noun);
+        $button_text = pht('Save %s', $noun);
         $instructions = null;
         break;
       case self::ACTION_MERGE:
-        $dialog_title = 'Merge Duplicate Tasks';
-        $header_text = 'Tasks To Merge';
-        $button_text = "Merge {$noun}";
-        $instructions =
+        $dialog_title = pht('Merge Duplicate Tasks');
+        $header_text = pht('Tasks To Merge');
+        $button_text = pht('Merge %s', $noun);
+        $instructions = pht(
           'These tasks will be merged into the current task and then closed. '.
-          'The current task will grow stronger.';
+          'The current task will grow stronger.');
         break;
       case self::ACTION_DEPENDENCIES:
-        $dialog_title = 'Edit Dependencies';
-        $header_text = 'Current Dependencies';
-        $button_text = 'Save Dependencies';
+        $dialog_title = pht('Edit Dependencies');
+        $header_text = pht('Current Dependencies');
+        $button_text = pht('Save Dependencies');
         $instructions = null;
         break;
       case self::ACTION_BLOCKS:
@@ -260,15 +260,15 @@ final class PhabricatorSearchAttachController
   private function getFilters(array $strings, $attach_type) {
     if ($attach_type == PholioMockPHIDType::TYPECONST) {
       $filters = array(
-        'created' => 'Created By Me',
-        'all' => 'All '.$strings['target_plural_noun'],
+        'created' => pht('Created By Me'),
+        'all' => pht('All %s', $strings['target_plural_noun']),
       );
     } else {
       $filters = array(
-        'assigned' => 'Assigned to Me',
-        'created' => 'Created By Me',
-        'open' => 'All Open '.$strings['target_plural_noun'],
-        'all' => 'All '.$strings['target_plural_noun'],
+        'assigned' => pht('Assigned to Me'),
+        'created' => pht('Created By Me'),
+        'open' => pht('All Open %s', $strings['target_plural_noun']),
+        'all' => pht('All %s', $strings['target_plural_noun']),
       );
     }
 
@@ -315,10 +315,11 @@ final class PhabricatorSearchAttachController
     foreach ($cycle as $cycle_phid) {
       $names[] = $handles[$cycle_phid]->getFullName();
     }
-    $names = implode(" \xE2\x86\x92 ", $names);
     throw new Exception(
-      "You can not create that dependency, because it would create a ".
-      "circular dependency: {$names}.");
+      pht(
+        'You can not create that dependency, because it would create a '.
+        'circular dependency: %s.',
+        implode(" \xE2\x86\x92 ", $names)));
   }
 
 }
diff --git a/src/applications/search/engine/PhabricatorApplicationSearchEngine.php b/src/applications/search/engine/PhabricatorApplicationSearchEngine.php
index cd0a9655fa..e89e82afd3 100644
--- a/src/applications/search/engine/PhabricatorApplicationSearchEngine.php
+++ b/src/applications/search/engine/PhabricatorApplicationSearchEngine.php
@@ -328,7 +328,7 @@ abstract class PhabricatorApplicationSearchEngine {
    */
   public function getBuiltinQuery($query_key) {
     if (!$this->isBuiltinQuery($query_key)) {
-      throw new Exception("'{$query_key}' is not a builtin!");
+      throw new Exception(pht("'%s' is not a builtin!", $query_key));
     }
     return idx($this->getBuiltinQueries(), $query_key);
   }
@@ -355,7 +355,7 @@ abstract class PhabricatorApplicationSearchEngine {
    * @task builtin
    */
   public function buildSavedQueryFromBuiltin($query_key) {
-    throw new Exception("Builtin '{$query_key}' is not supported!");
+    throw new Exception(pht("Builtin '%s' is not supported!", $query_key));
   }
 
 
diff --git a/src/applications/search/engine/PhabricatorJumpNavHandler.php b/src/applications/search/engine/PhabricatorJumpNavHandler.php
index 53e92b6e58..7a340a7e8f 100644
--- a/src/applications/search/engine/PhabricatorJumpNavHandler.php
+++ b/src/applications/search/engine/PhabricatorJumpNavHandler.php
@@ -69,7 +69,7 @@ final class PhabricatorJumpNavHandler {
                 ->setURI('/maniphest/task/create/?title='
                   .phutil_escape_uri($matches[1]));
             default:
-              throw new Exception("Unknown jump effect '{$effect}'!");
+              throw new Exception(pht("Unknown jump effect '%s'!", $effect));
           }
         }
       }
diff --git a/src/applications/search/index/PhabricatorSearchDocumentIndexer.php b/src/applications/search/index/PhabricatorSearchDocumentIndexer.php
index 18d07765ad..b3e90148ca 100644
--- a/src/applications/search/index/PhabricatorSearchDocumentIndexer.php
+++ b/src/applications/search/index/PhabricatorSearchDocumentIndexer.php
@@ -36,7 +36,7 @@ abstract class PhabricatorSearchDocumentIndexer extends Phobject {
       ->withPHIDs(array($phid))
       ->executeOne();
     if (!$object) {
-      throw new Exception("Unable to load object by phid '{$phid}'!");
+      throw new Exception(pht("Unable to load object by PHID '%s'!", $phid));
     }
     return $object;
   }
@@ -73,17 +73,21 @@ abstract class PhabricatorSearchDocumentIndexer extends Phobject {
       try {
         $engine->reindexAbstractDocument($document);
       } catch (Exception $ex) {
-        $phid = $document->getPHID();
-        $class = get_class($engine);
-
-        phlog("Unable to index document {$phid} with engine {$class}.");
+        phlog(
+          pht(
+            'Unable to index document %s with engine %s.',
+            $document->getPHID(),
+            get_class($engine)));
         phlog($ex);
       }
 
       $this->dispatchDidUpdateIndexEvent($phid, $document);
     } catch (Exception $ex) {
-      $class = get_class($this);
-      phlog("Unable to build document {$phid} with indexer {$class}.");
+      phlog(
+        pht(
+          'Unable to build document %s with indexer %s.',
+          $phid,
+          get_class($this)));
       phlog($ex);
     }
 
diff --git a/src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php b/src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php
index fea5817de1..f7c679782e 100644
--- a/src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php
+++ b/src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php
@@ -6,7 +6,7 @@ final class PhabricatorSearchManagementIndexWorkflow
   protected function didConstruct() {
     $this
       ->setName('index')
-      ->setSynopsis('Build or rebuild search indexes.')
+      ->setSynopsis(pht('Build or rebuild search indexes.'))
       ->setExamples(
         "**index** D123\n".
         "**index** --type DREV\n".
@@ -15,18 +15,19 @@ final class PhabricatorSearchManagementIndexWorkflow
         array(
           array(
             'name' => 'all',
-            'help' => 'Reindex all documents.',
+            'help' => pht('Reindex all documents.'),
           ),
           array(
             'name'  => 'type',
             'param' => 'TYPE',
-            'help'  => 'PHID type to reindex, like "TASK" or "DREV".',
+            'help'  => pht('PHID type to reindex, like "TASK" or "DREV".'),
           ),
           array(
             'name' => 'background',
-            'help' => 'Instead of indexing in this process, queue tasks for '.
-                      'the daemons. This can improve performance, but makes '.
-                      'it more difficult to debug search indexing.',
+            'help' => pht(
+              'Instead of indexing in this process, queue tasks for '.
+              'the daemons. This can improve performance, but makes '.
+              'it more difficult to debug search indexing.'),
           ),
           array(
             'name'      => 'objects',
@@ -45,11 +46,16 @@ final class PhabricatorSearchManagementIndexWorkflow
 
     if ($obj_names && ($is_all || $is_type)) {
       throw new PhutilArgumentUsageException(
-        "You can not name objects to index alongside the '--all' or '--type' ".
-        "flags.");
+        pht(
+          "You can not name objects to index alongside the '%s' or '%s' flags.",
+          '--all',
+          '--type'));
     } else if (!$obj_names && !($is_all || $is_type)) {
       throw new PhutilArgumentUsageException(
-        "Provide one of '--all', '--type' or a list of object names.");
+        pht(
+          "Provide one of '%s', '%s' or a list of object names.",
+          '--all',
+          '--type'));
     }
 
     if ($obj_names) {
@@ -59,7 +65,7 @@ final class PhabricatorSearchManagementIndexWorkflow
     }
 
     if (!$phids) {
-      throw new PhutilArgumentUsageException('Nothing to index!');
+      throw new PhutilArgumentUsageException(pht('Nothing to index!'));
     }
 
     if ($args->getArg('background')) {
@@ -73,8 +79,8 @@ final class PhabricatorSearchManagementIndexWorkflow
       $console->writeOut(
         "%s\n",
         pht(
-          'Run this workflow with "--background" to queue tasks for the '.
-          'daemon workers.'));
+          'Run this workflow with "%s" to queue tasks for the daemon workers.',
+          '--background'));
     }
 
     $groups = phid_group_by_type($phids);
@@ -106,7 +112,9 @@ final class PhabricatorSearchManagementIndexWorkflow
     foreach ($names as $name) {
       if (empty($objects[$name])) {
         throw new PhutilArgumentUsageException(
-          "'{$name}' is not the name of a known object.");
+          pht(
+            "'%s' is not the name of a known object.",
+            $name));
       }
     }
 
diff --git a/src/applications/search/management/PhabricatorSearchManagementInitWorkflow.php b/src/applications/search/management/PhabricatorSearchManagementInitWorkflow.php
index e4a8ddb693..56a5b33352 100644
--- a/src/applications/search/management/PhabricatorSearchManagementInitWorkflow.php
+++ b/src/applications/search/management/PhabricatorSearchManagementInitWorkflow.php
@@ -6,7 +6,7 @@ final class PhabricatorSearchManagementInitWorkflow
   protected function didConstruct() {
     $this
       ->setName('init')
-      ->setSynopsis('Initialize or repair an index.')
+      ->setSynopsis(pht('Initialize or repair an index.'))
       ->setExamples('**init**');
   }
 
@@ -28,7 +28,7 @@ final class PhabricatorSearchManagementInitWorkflow
     } else if (!$engine->indexIsSane()) {
       $console->writeOut(
         '%s',
-          pht('Index exists but is incorrect, fixing...'));
+        pht('Index exists but is incorrect, fixing...'));
       $engine->initIndex();
       $console->writeOut(
         "%s\n",
@@ -39,8 +39,9 @@ final class PhabricatorSearchManagementInitWorkflow
     if ($work_done) {
       $console->writeOut(
         "%s\n",
-        pht('Index maintenance complete. Run `./bin/search index` to '.
-            'reindex documents'));
+        pht(
+          'Index maintenance complete. Run `%s` to reindex documents',
+          './bin/search index'));
     } else {
       $console->writeOut(
         "%s\n",
diff --git a/src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php b/src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php
index 1ca6b109d3..092f758f3b 100644
--- a/src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php
+++ b/src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php
@@ -137,7 +137,7 @@ final class PhabricatorSearchApplicationSearchEngine
           )))
       ->appendChild(
         id(new AphrontFormTextControl())
-          ->setLabel('Query')
+          ->setLabel(pht('Query'))
           ->setName('query')
           ->setValue($saved->getParameter('query')))
       ->appendChild($status_control)
@@ -145,25 +145,25 @@ final class PhabricatorSearchApplicationSearchEngine
       ->appendControl(
         id(new AphrontFormTokenizerControl())
           ->setName('authorPHIDs')
-          ->setLabel('Authors')
+          ->setLabel(pht('Authors'))
           ->setDatasource(new PhabricatorPeopleUserFunctionDatasource())
           ->setValue($author_phids))
       ->appendControl(
         id(new AphrontFormTokenizerControl())
           ->setName('ownerPHIDs')
-          ->setLabel('Owners')
+          ->setLabel(pht('Owners'))
           ->setDatasource(new PhabricatorPeopleOwnerDatasource())
           ->setValue($owner_phids))
       ->appendControl(
         id(new AphrontFormTokenizerControl())
           ->setName('subscriberPHIDs')
-          ->setLabel('Subscribers')
+          ->setLabel(pht('Subscribers'))
           ->setDatasource(new PhabricatorMetaMTAMailableFunctionDatasource())
           ->setValue($subscriber_phids))
       ->appendControl(
         id(new AphrontFormTokenizerControl())
           ->setName('projectPHIDs')
-          ->setLabel('In Any Project')
+          ->setLabel(pht('In Any Project'))
           ->setDatasource(new PhabricatorProjectDatasource())
           ->setValue($project_phids));
   }
diff --git a/src/applications/search/query/PhabricatorSearchDocumentQuery.php b/src/applications/search/query/PhabricatorSearchDocumentQuery.php
index 1770f4b046..4928ee6a63 100644
--- a/src/applications/search/query/PhabricatorSearchDocumentQuery.php
+++ b/src/applications/search/query/PhabricatorSearchDocumentQuery.php
@@ -86,8 +86,7 @@ final class PhabricatorSearchDocumentQuery
   protected function getResultCursor($result) {
     throw new Exception(
       pht(
-        'This query does not support cursor paging; it must be offset '.
-        'paged.'));
+        'This query does not support cursor paging; it must be offset paged.'));
   }
 
   protected function nextPage(array $page) {
diff --git a/src/applications/settings/panel/PhabricatorConduitCertificateSettingsPanel.php b/src/applications/settings/panel/PhabricatorConduitCertificateSettingsPanel.php
index 5ffc536fad..d7210a3c8f 100644
--- a/src/applications/settings/panel/PhabricatorConduitCertificateSettingsPanel.php
+++ b/src/applications/settings/panel/PhabricatorConduitCertificateSettingsPanel.php
@@ -67,7 +67,8 @@ final class PhabricatorConduitCertificateSettingsPanel
       $notice->appendChild(phutil_tag(
         'p',
         array(),
-        pht('Your old certificate has been destroyed and you have been issued '.
+        pht(
+          'Your old certificate has been destroyed and you have been issued '.
         'a new certificate. Sessions established under the old certificate '.
         'are no longer valid.')));
       $notice = $notice->render();
@@ -83,7 +84,8 @@ final class PhabricatorConduitCertificateSettingsPanel
       ->appendChild(phutil_tag(
         'p',
         array('class' => 'aphront-form-instructions'),
-        pht('This certificate allows you to authenticate over Conduit, '.
+        pht(
+          'This certificate allows you to authenticate over Conduit, '.
           'the Phabricator API. Normally, you just run %s to install it.',
           phutil_tag('tt', array(), 'arc install-certificate'))))
       ->appendChild(
@@ -98,7 +100,8 @@ final class PhabricatorConduitCertificateSettingsPanel
       ->setHeaderText(pht('Arcanist Certificate'))
       ->setForm($cert_form);
 
-    $regen_instruction = pht('You can regenerate this certificate, which '.
+    $regen_instruction = pht(
+      'You can regenerate this certificate, which '.
       'will invalidate the old certificate and create a new one.');
 
     $regen_form = new AphrontFormView();
diff --git a/src/applications/settings/panel/PhabricatorConpherencePreferencesSettingsPanel.php b/src/applications/settings/panel/PhabricatorConpherencePreferencesSettingsPanel.php
index c9383f4176..69f84f16a1 100644
--- a/src/applications/settings/panel/PhabricatorConpherencePreferencesSettingsPanel.php
+++ b/src/applications/settings/panel/PhabricatorConpherencePreferencesSettingsPanel.php
@@ -49,9 +49,10 @@ final class PhabricatorConpherencePreferencesSettingsPanel
                 => pht('Notifications Only'),
             ))
           ->setCaption(
-            pht('Should Conpherence send emails for updates or '.
-                'notifications only? This global setting can be overridden '.
-                'on a per-thread basis within Conpherence.')))
+            pht(
+              'Should Conpherence send emails for updates or '.
+              'notifications only? This global setting can be overridden '.
+              'on a per-thread basis within Conpherence.')))
       ->appendChild(
         id(new AphrontFormSubmitControl())
           ->setValue(pht('Save Preferences')));
diff --git a/src/applications/settings/panel/PhabricatorDeveloperPreferencesSettingsPanel.php b/src/applications/settings/panel/PhabricatorDeveloperPreferencesSettingsPanel.php
index 4d59d19414..1d81cc67b2 100644
--- a/src/applications/settings/panel/PhabricatorDeveloperPreferencesSettingsPanel.php
+++ b/src/applications/settings/panel/PhabricatorDeveloperPreferencesSettingsPanel.php
@@ -43,10 +43,10 @@ final class PhabricatorDeveloperPreferencesSettingsPanel
     $is_console_enabled = PhabricatorEnv::getEnvConfig('darkconsole.enabled');
 
     $preamble = pht(
-      '**DarkConsole** is a developer console which can help build and '.
-      'debug Phabricator applications. It includes tools for understanding '.
-      'errors, performance, service calls, and other low-level aspects of '.
-      'Phabricator\'s inner workings.');
+      "**DarkConsole** is a developer console which can help build and ".
+      "debug Phabricator applications. It includes tools for understanding ".
+      "errors, performance, service calls, and other low-level aspects of ".
+      "Phabricator's inner workings.");
 
     if ($is_console_enabled) {
       $instructions = pht(
@@ -56,15 +56,17 @@ final class PhabricatorDeveloperPreferencesSettingsPanel
         'tools. You may want to disable it again later if you only need it '.
         'temporarily.'.
         "\n\n".
-        'NOTE: After enabling DarkConsole, **press the ##`## key on your '.
+        'NOTE: After enabling DarkConsole, **press the ##%s## key on your '.
         'keyboard** to show or hide it.',
-        $preamble);
+        $preamble,
+        '`');
     } else {
       $instructions = pht(
         "%s\n\n".
         'Before you can turn on DarkConsole, it needs to be enabled in '.
-        'the configuration for this install (`darkconsole.enabled`).',
-        $preamble);
+        'the configuration for this install (`%s`).',
+        $preamble,
+        'darkconsole.enabled');
     }
 
     $form = id(new AphrontFormView())
diff --git a/src/applications/settings/panel/PhabricatorDiffPreferencesSettingsPanel.php b/src/applications/settings/panel/PhabricatorDiffPreferencesSettingsPanel.php
index cc6a4e91e6..72fca5e879 100644
--- a/src/applications/settings/panel/PhabricatorDiffPreferencesSettingsPanel.php
+++ b/src/applications/settings/panel/PhabricatorDiffPreferencesSettingsPanel.php
@@ -85,10 +85,11 @@ final class PhabricatorDiffPreferencesSettingsPanel
               1 => pht('Enable Filetree'),
             ))
           ->setCaption(
-            pht('When looking at a revision or commit, enable a sidebar '.
-                'showing affected files. You can press %s to show or hide '.
-                'the sidebar.',
-                phutil_tag('tt', array(), 'f'))))
+            pht(
+              'When looking at a revision or commit, enable a sidebar '.
+              'showing affected files. You can press %s to show or hide '.
+              'the sidebar.',
+              phutil_tag('tt', array(), 'f'))))
       ->appendChild(
         id(new AphrontFormSubmitControl())
           ->setValue(pht('Save Preferences')));
diff --git a/src/applications/settings/panel/PhabricatorDisplayPreferencesSettingsPanel.php b/src/applications/settings/panel/PhabricatorDisplayPreferencesSettingsPanel.php
index 71f533dcdb..c2dcc36e66 100644
--- a/src/applications/settings/panel/PhabricatorDisplayPreferencesSettingsPanel.php
+++ b/src/applications/settings/panel/PhabricatorDisplayPreferencesSettingsPanel.php
@@ -95,13 +95,15 @@ EXAMPLE;
       $pref_monospaced_textareas_value = 'disabled';
     }
 
-    $editor_instructions = pht('Link to edit files in external editor. '.
+    $editor_instructions = pht(
+      'Link to edit files in external editor. '.
       '%%f is replaced by filename, %%l by line number, %%r by repository '.
       'callsign, %%%% by literal %%. For documentation, see: %s',
       $editor_doc_link);
 
-    $font_instructions = pht('Overrides default fonts in tools like '.
-      'Differential. Input should be valid CSS "font" declaration, such as '.
+    $font_instructions = pht(
+      'Overrides default fonts in tools like Differential. '.
+      'Input should be valid CSS "font" declaration, such as '.
       '"13px Consolas"');
 
     $form = id(new AphrontFormView())
@@ -114,10 +116,12 @@ EXAMPLE;
           ->setOptions(
             array(
               'glyph' =>
-              pht("In page titles, show Tool names as unicode glyphs: ".
+              pht(
+                'In page titles, show Tool names as unicode glyphs: %s',
                 "\xE2\x9A\x99"),
               'text' =>
-              pht('In page titles, show Tool names as plain text: '.
+              pht(
+                'In page titles, show Tool names as plain text: '.
                 '[Differential]'),
             )))
       ->appendChild(
diff --git a/src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php b/src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php
index 7ad59d4d37..21ccd38302 100644
--- a/src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php
+++ b/src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php
@@ -289,7 +289,7 @@ final class PhabricatorEmailAddressesSettingsPanel
       ->appendParagraph(
         pht(
           'Are you sure you want to delete this address? You will no '.
-            'longer be able to use it to login.'))
+          'longer be able to use it to login.'))
       ->appendParagraph(
         pht(
           'Note: Removing an email address from your account will invalidate '.
diff --git a/src/applications/settings/panel/PhabricatorEmailFormatSettingsPanel.php b/src/applications/settings/panel/PhabricatorEmailFormatSettingsPanel.php
index a2b040aabd..f7dd7909ed 100644
--- a/src/applications/settings/panel/PhabricatorEmailFormatSettingsPanel.php
+++ b/src/applications/settings/panel/PhabricatorEmailFormatSettingsPanel.php
@@ -67,7 +67,7 @@ final class PhabricatorEmailFormatSettingsPanel
       ? pht('Vary')
       : pht('Do Not Vary');
 
-    $html_emails_default = 'Plain Text';
+    $html_emails_default = pht('Plain Text');
 
     $re_prefix_value = $preferences->getPreference($pref_re_prefix);
     if ($re_prefix_value === null) {
@@ -132,13 +132,13 @@ final class PhabricatorEmailFormatSettingsPanel
         ->setValue($vary_value);
     } else {
       $html_email_control = id(new AphrontFormStaticControl())
-        ->setValue('Server Default ('.$html_emails_default.')');
+        ->setValue(pht('Server Default (%s)', $html_emails_default));
 
       $re_control = id(new AphrontFormStaticControl())
-        ->setValue('Server Default ('.$re_prefix_default.')');
+        ->setValue(pht('Server Default (%s)', $re_prefix_default));
 
       $vary_control = id(new AphrontFormStaticControl())
-        ->setValue('Server Default ('.$vary_default.')');
+        ->setValue(pht('Server Default (%s)', $vary_default));
     }
 
     $form
diff --git a/src/applications/settings/panel/PhabricatorSSHKeysSettingsPanel.php b/src/applications/settings/panel/PhabricatorSSHKeysSettingsPanel.php
index 2749e7147f..288552fd44 100644
--- a/src/applications/settings/panel/PhabricatorSSHKeysSettingsPanel.php
+++ b/src/applications/settings/panel/PhabricatorSSHKeysSettingsPanel.php
@@ -35,7 +35,7 @@ final class PhabricatorSSHKeysSettingsPanel extends PhabricatorSettingsPanel {
       ->setUser($viewer)
       ->setKeys($keys)
       ->setCanEdit(true)
-      ->setNoDataString("You haven't added any SSH Public Keys.");
+      ->setNoDataString(pht("You haven't added any SSH Public Keys."));
 
     $panel = new PHUIObjectBoxView();
     $header = new PHUIHeaderView();
diff --git a/src/applications/settings/panel/PhabricatorSearchPreferencesSettingsPanel.php b/src/applications/settings/panel/PhabricatorSearchPreferencesSettingsPanel.php
index 496aed67ec..f05a5dd9f9 100644
--- a/src/applications/settings/panel/PhabricatorSearchPreferencesSettingsPanel.php
+++ b/src/applications/settings/panel/PhabricatorSearchPreferencesSettingsPanel.php
@@ -44,7 +44,7 @@ final class PhabricatorSearchPreferencesSettingsPanel
             $preferences->getPreference($pref_jump, 1))
           ->addCheckbox($pref_shortcut,
             1,
-            pht("Press '/' to focus the search input."),
+            pht("Press '%s' to focus the search input.", '/'),
             $preferences->getPreference($pref_shortcut, 1)))
       ->appendChild(
         id(new AphrontFormSubmitControl())
diff --git a/src/applications/settings/storage/PhabricatorUserPreferences.php b/src/applications/settings/storage/PhabricatorUserPreferences.php
index 7732df5568..d54cf6cb46 100644
--- a/src/applications/settings/storage/PhabricatorUserPreferences.php
+++ b/src/applications/settings/storage/PhabricatorUserPreferences.php
@@ -20,7 +20,7 @@ final class PhabricatorUserPreferences extends PhabricatorUserDAO {
 
   const PREFERENCE_SEARCHBAR_JUMP       = 'searchbar-jump';
   const PREFERENCE_SEARCH_SHORTCUT      = 'search-shortcut';
-  const PREFERENCE_SEARCH_SCOPE = 'search-scope';
+  const PREFERENCE_SEARCH_SCOPE         = 'search-scope';
 
   const PREFERENCE_DIFFUSION_BLAME      = 'diffusion-blame';
   const PREFERENCE_DIFFUSION_COLOR      = 'diffusion-color';
@@ -32,10 +32,10 @@ final class PhabricatorUserPreferences extends PhabricatorUserDAO {
 
   const PREFERENCE_DIFF_UNIFIED         = 'diff-unified';
   const PREFERENCE_DIFF_FILETREE        = 'diff-filetree';
-  const PREFERENCE_DIFF_GHOSTS = 'diff-ghosts';
+  const PREFERENCE_DIFF_GHOSTS          = 'diff-ghosts';
 
   const PREFERENCE_CONPH_NOTIFICATIONS = 'conph-notifications';
-  const PREFERENCE_CONPHERENCE_COLUMN = 'conpherence-column';
+  const PREFERENCE_CONPHERENCE_COLUMN  = 'conpherence-column';
 
   // These are in an unusual order for historic reasons.
   const MAILTAG_PREFERENCE_NOTIFY       = 0;
diff --git a/src/applications/slowvote/conduit/SlowvoteInfoConduitAPIMethod.php b/src/applications/slowvote/conduit/SlowvoteInfoConduitAPIMethod.php
index 50478abc0c..cecd799ad0 100644
--- a/src/applications/slowvote/conduit/SlowvoteInfoConduitAPIMethod.php
+++ b/src/applications/slowvote/conduit/SlowvoteInfoConduitAPIMethod.php
@@ -7,7 +7,7 @@ final class SlowvoteInfoConduitAPIMethod extends SlowvoteConduitAPIMethod {
   }
 
   public function getMethodDescription() {
-    return 'Retrieve an array of information about a poll.';
+    return pht('Retrieve an array of information about a poll.');
   }
 
   protected function defineParamTypes() {
@@ -22,7 +22,7 @@ final class SlowvoteInfoConduitAPIMethod extends SlowvoteConduitAPIMethod {
 
   protected function defineErrorTypes() {
     return array(
-      'ERR_BAD_POLL' => 'No such poll exists',
+      'ERR_BAD_POLL' => pht('No such poll exists.'),
     );
   }
 
diff --git a/src/applications/subscriptions/command/PhabricatorSubscriptionsSubscribeEmailCommand.php b/src/applications/subscriptions/command/PhabricatorSubscriptionsSubscribeEmailCommand.php
index a20da47c4e..0c361ad2c6 100644
--- a/src/applications/subscriptions/command/PhabricatorSubscriptionsSubscribeEmailCommand.php
+++ b/src/applications/subscriptions/command/PhabricatorSubscriptionsSubscribeEmailCommand.php
@@ -17,17 +17,18 @@ final class PhabricatorSubscriptionsSubscribeEmailCommand
 
   public function getCommandDescription() {
     return pht(
-      'Add one or more subscribers to the object. You can add users '.
-      'by providing their usernames, or add projects by adding their '.
-      'hashtags. For example, use `!subscribe alincoln #ios` to add the '.
-      'user `alincoln` and the project with hashtag `#ios` as subscribers.'.
+      'Add one or more subscribers to the object. You can add users by '.
+      'providing their usernames, or add projects by adding their hashtags. '.
+      'For example, use `%s` to add the user `alincoln` and the project with '.
+      'hashtag `#ios` as subscribers.'.
       "\n\n".
       'Subscribers which are invalid or unrecognized will be ignored. This '.
       'command has no effect if you do not specify any subscribers.'.
       "\n\n".
       'Users who are CC\'d on the email itself are also automatically '.
       'subscribed if Phabricator knows which accounts are linked to their '.
-      'email addresses.');
+      'email addresses.',
+      '!subscribe alincoln #ios');
   }
 
   public function getCommandAliases() {
diff --git a/src/applications/system/controller/PhabricatorSystemSelectEncodingController.php b/src/applications/system/controller/PhabricatorSystemSelectEncodingController.php
index 4392f53ada..efbe67882a 100644
--- a/src/applications/system/controller/PhabricatorSystemSelectEncodingController.php
+++ b/src/applications/system/controller/PhabricatorSystemSelectEncodingController.php
@@ -15,9 +15,11 @@ final class PhabricatorSystemSelectEncodingController
         ->setTitle(pht('No Encoding Support'))
         ->appendParagraph(
           pht(
-            'This system does not have the "mbstring" extension installed, '.
-            'so character encodings are not supported. Install "mbstring" to '.
-            'enable support.'))
+            'This system does not have the "%s" extension installed, '.
+            'so character encodings are not supported. Install "%s" to '.
+            'enable support.',
+            'mbstring',
+            'mbstring'))
         ->addCancelButton('/');
     }
 
diff --git a/src/applications/tokens/phid/PhabricatorTokenTokenPHIDType.php b/src/applications/tokens/phid/PhabricatorTokenTokenPHIDType.php
index c458c52fbd..1791cc88c7 100644
--- a/src/applications/tokens/phid/PhabricatorTokenTokenPHIDType.php
+++ b/src/applications/tokens/phid/PhabricatorTokenTokenPHIDType.php
@@ -30,7 +30,7 @@ final class PhabricatorTokenTokenPHIDType extends PhabricatorPHIDType {
 
       $name = $token->getName();
 
-      $handle->setName("{$name} Token");
+      $handle->setName(pht('%s Token', $name));
     }
   }
 
diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php
index 23b77fbd1b..94a1cdaa3b 100644
--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php
+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php
@@ -121,14 +121,16 @@ final class PhabricatorApplicationTransactionCommentEditor
 
     if (!$xaction->getPHID()) {
       throw new Exception(
-        'Transaction must have a PHID before calling applyEdit()!');
+        pht(
+          'Transaction must have a PHID before calling %s!',
+          'applyEdit()'));
     }
 
     $type_comment = PhabricatorTransactions::TYPE_COMMENT;
     if ($xaction->getTransactionType() == $type_comment) {
       if ($comment->getPHID()) {
         throw new Exception(
-          'Transaction comment must not yet have a PHID!');
+          pht('Transaction comment must not yet have a PHID!'));
       }
     }
 
diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
index 57a3e4bde8..7c8a1cff42 100644
--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
@@ -257,7 +257,10 @@ abstract class PhabricatorApplicationTransactionEditor
       case PhabricatorTransactions::TYPE_EDGE:
         $edge_type = $xaction->getMetadataValue('edge:type');
         if (!$edge_type) {
-          throw new Exception("Edge transaction has no 'edge:type'!");
+          throw new Exception(
+            pht(
+              "Edge transaction has no '%s'!",
+              'edge:type'));
         }
 
         $old_edges = array();
@@ -312,13 +315,13 @@ abstract class PhabricatorApplicationTransactionEditor
   protected function getCustomTransactionOldValue(
     PhabricatorLiskDAO $object,
     PhabricatorApplicationTransaction $xaction) {
-    throw new Exception('Capability not supported!');
+    throw new Exception(pht('Capability not supported!'));
   }
 
   protected function getCustomTransactionNewValue(
     PhabricatorLiskDAO $object,
     PhabricatorApplicationTransaction $xaction) {
-    throw new Exception('Capability not supported!');
+    throw new Exception(pht('Capability not supported!'));
   }
 
   protected function transactionHasEffect(
@@ -456,8 +459,9 @@ abstract class PhabricatorApplicationTransactionEditor
     PhabricatorApplicationTransaction $xaction) {
     $type = $xaction->getTransactionType();
     throw new Exception(
-      "Transaction type '{$type}' is missing an internal apply ".
-      "implementation!");
+      pht(
+        "Transaction type '%s' is missing an internal apply implementation!",
+        $type));
   }
 
   protected function applyCustomExternalTransaction(
@@ -465,8 +469,9 @@ abstract class PhabricatorApplicationTransactionEditor
     PhabricatorApplicationTransaction $xaction) {
     $type = $xaction->getTransactionType();
     throw new Exception(
-      "Transaction type '{$type}' is missing an external apply ".
-      "implementation!");
+      pht(
+        "Transaction type '%s' is missing an external apply implementation!",
+        $type));
   }
 
   /**
@@ -1013,27 +1018,28 @@ abstract class PhabricatorApplicationTransactionEditor
       if ($xaction->getPHID() || $xaction->getID()) {
         throw new PhabricatorApplicationTransactionStructureException(
           $xaction,
-          pht(
-            'You can not apply transactions which already have IDs/PHIDs!'));
+          pht('You can not apply transactions which already have IDs/PHIDs!'));
       }
       if ($xaction->getObjectPHID()) {
         throw new PhabricatorApplicationTransactionStructureException(
           $xaction,
           pht(
-            'You can not apply transactions which already have objectPHIDs!'));
+            'You can not apply transactions which already have %s!',
+            'objectPHIDs'));
       }
       if ($xaction->getAuthorPHID()) {
         throw new PhabricatorApplicationTransactionStructureException(
           $xaction,
           pht(
-            'You can not apply transactions which already have authorPHIDs!'));
+            'You can not apply transactions which already have %s!',
+            'authorPHIDs'));
       }
       if ($xaction->getCommentPHID()) {
         throw new PhabricatorApplicationTransactionStructureException(
           $xaction,
           pht(
-            'You can not apply transactions which already have '.
-            'commentPHIDs!'));
+            'You can not apply transactions which already have %s!',
+            'commentPHIDs'));
       }
       if ($xaction->getCommentVersion() !== 0) {
         throw new PhabricatorApplicationTransactionStructureException(
@@ -1050,16 +1056,17 @@ abstract class PhabricatorApplicationTransactionEditor
         throw new PhabricatorApplicationTransactionStructureException(
           $xaction,
           pht(
-            'This transaction is supposed to have an oldValue set, but '.
-            'it does not!'));
+            'This transaction is supposed to have an %s set, but it does not!',
+            'oldValue'));
       }
 
       if ($has_value && !$expect_value) {
         throw new PhabricatorApplicationTransactionStructureException(
           $xaction,
           pht(
-            'This transaction should generate its oldValue automatically, '.
-            'but has already had one set!'));
+            'This transaction should generate its %s automatically, '.
+            'but has already had one set!',
+            'oldValue'));
       }
 
       $type = $xaction->getTransactionType();
@@ -1497,8 +1504,13 @@ abstract class PhabricatorApplicationTransactionEditor
 
     if ($new) {
       throw new Exception(
-        "Invalid 'new' value for PHID transaction. Value should contain only ".
-        "keys '+' (add PHIDs), '-' (remove PHIDs) and '=' (set PHIDS).");
+        pht(
+          "Invalid '%s' value for PHID transaction. Value should contain only ".
+          "keys '%s' (add PHIDs), '%' (remove PHIDs) and '%s' (set PHIDS).",
+          'new',
+          '+',
+          '-',
+          '='));
     }
 
     $result = array();
@@ -1540,8 +1552,13 @@ abstract class PhabricatorApplicationTransactionEditor
 
     if ($new) {
       throw new Exception(
-        "Invalid 'new' value for Edge transaction. Value should contain only ".
-        "keys '+' (add edges), '-' (remove edges) and '=' (set edges).");
+        pht(
+          "Invalid '%s' value for Edge transaction. Value should contain only ".
+          "keys '%s' (add edges), '%s' (remove edges) and '%s' (set edges).",
+          'new',
+          '+',
+          '-',
+          '='));
     }
 
     $old = $xaction->getOldValue();
@@ -1592,13 +1609,17 @@ abstract class PhabricatorApplicationTransactionEditor
     foreach ($list as $key => $item) {
       if (phid_get_type($key) === PhabricatorPHIDConstants::PHID_TYPE_UNKNOWN) {
         throw new Exception(
-          "Edge transactions must have destination PHIDs as in edge ".
-          "lists (found key '{$key}').");
+          pht(
+            "Edge transactions must have destination PHIDs as in edge ".
+            "lists (found key '%s').",
+            $key));
       }
       if (!is_array($item) && $item !== $key) {
         throw new Exception(
-          "Edge transactions must have PHIDs or edge specs as values ".
-          "(found value '{$item}').");
+          pht(
+            "Edge transactions must have PHIDs or edge specs as values ".
+            "(found value '%s').",
+            $item));
       }
     }
   }
@@ -1631,8 +1652,7 @@ abstract class PhabricatorApplicationTransactionEditor
           default:
             throw new Exception(
               pht(
-                'Transaction edge specification contains unexpected key '.
-                '"%s".',
+                'Transaction edge specification contains unexpected key "%s".',
                 $key));
         }
       }
@@ -1647,9 +1667,12 @@ abstract class PhabricatorApplicationTransactionEditor
       if ($edge['type'] != $edge_type) {
         $this_type = $edge['type'];
         throw new Exception(
-          "Edge transaction includes edge of type '{$this_type}', but ".
-          "transaction is of type '{$edge_type}'. Each edge transaction must ".
-          "alter edges of only one type.");
+          pht(
+            "Edge transaction includes edge of type '%s', but ".
+            "transaction is of type '%s'. Each edge transaction ".
+            "must alter edges of only one type.",
+            $this_type,
+            $edge_type));
       }
     }
 
@@ -1841,11 +1864,12 @@ abstract class PhabricatorApplicationTransactionEditor
           $errors[] = new PhabricatorApplicationTransactionValidationError(
             $transaction_type,
             pht('Invalid'),
-            pht('The selected %s policy excludes you. Choose a %s policy '.
-                'which allows you to %s the object.',
-            $capability,
-            $capability,
-            $capability));
+            pht(
+              'The selected %s policy excludes you. Choose a %s policy '.
+              'which allows you to %s the object.',
+              $capability,
+              $capability,
+              $capability));
         }
       }
     }
@@ -2148,14 +2172,14 @@ abstract class PhabricatorApplicationTransactionEditor
    * @task mail
    */
   protected function buildReplyHandler(PhabricatorLiskDAO $object) {
-    throw new Exception('Capability not supported.');
+    throw new Exception(pht('Capability not supported.'));
   }
 
   /**
    * @task mail
    */
   protected function getMailSubjectPrefix() {
-    throw new Exception('Capability not supported.');
+    throw new Exception(pht('Capability not supported.'));
   }
 
 
@@ -2197,7 +2221,7 @@ abstract class PhabricatorApplicationTransactionEditor
    * @task mail
    */
   protected function buildMailTemplate(PhabricatorLiskDAO $object) {
-    throw new Exception('Capability not supported.');
+    throw new Exception(pht('Capability not supported.'));
   }
 
 
@@ -2205,7 +2229,7 @@ abstract class PhabricatorApplicationTransactionEditor
    * @task mail
    */
   protected function getMailTo(PhabricatorLiskDAO $object) {
-    throw new Exception('Capability not supported.');
+    throw new Exception(pht('Capability not supported.'));
   }
 
 
@@ -2262,7 +2286,7 @@ abstract class PhabricatorApplicationTransactionEditor
     }
 
     if (!$has_support) {
-      throw new Exception('Capability not supported.');
+      throw new Exception(pht('Capability not supported.'));
     }
 
     return array_mergev($phids);
@@ -2484,7 +2508,7 @@ abstract class PhabricatorApplicationTransactionEditor
   protected function buildHeraldAdapter(
     PhabricatorLiskDAO $object,
     array $xactions) {
-    throw new Exception('No herald adapter specified.');
+    throw new Exception(pht('No herald adapter specified.'));
   }
 
   private function setHeraldAdapter(HeraldAdapter $adapter) {
@@ -2546,7 +2570,9 @@ abstract class PhabricatorApplicationTransactionEditor
     $field_key = $xaction->getMetadataValue('customfield:key');
     if (!$field_key) {
       throw new Exception(
-        "Custom field transaction has no 'customfield:key'!");
+        pht(
+        "Custom field transaction has no '%s'!",
+        'customfield:key'));
     }
 
     $field = PhabricatorCustomField::getObjectField(
@@ -2556,14 +2582,20 @@ abstract class PhabricatorApplicationTransactionEditor
 
     if (!$field) {
       throw new Exception(
-        "Custom field transaction has invalid 'customfield:key'; field ".
-        "'{$field_key}' is disabled or does not exist.");
+        pht(
+          "Custom field transaction has invalid '%s'; field '%s' ".
+          "is disabled or does not exist.",
+          'customfield:key',
+          $field_key));
     }
 
     if (!$field->shouldAppearInApplicationTransactions()) {
       throw new Exception(
-        "Custom field transaction '{$field_key}' does not implement ".
-        "integration for ApplicationTransactions.");
+        pht(
+          "Custom field transaction '%s' does not implement ".
+          "integration for %s.",
+          $field_key,
+          'ApplicationTransactions'));
     }
 
     $field->setViewer($this->getActor());
diff --git a/src/applications/transactions/exception/PhabricatorApplicationTransactionValidationException.php b/src/applications/transactions/exception/PhabricatorApplicationTransactionValidationException.php
index edc8d97985..2ed1f54feb 100644
--- a/src/applications/transactions/exception/PhabricatorApplicationTransactionValidationException.php
+++ b/src/applications/transactions/exception/PhabricatorApplicationTransactionValidationException.php
@@ -13,7 +13,7 @@ final class PhabricatorApplicationTransactionValidationException
     $this->errors = $errors;
 
     $message = array();
-    $message[] = 'Validation errors:';
+    $message[] = pht('Validation errors:');
     foreach ($this->errors as $error) {
       $message[] = '  - '.$error->getMessage();
     }
diff --git a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
index 355f15c2a7..a6c1715115 100644
--- a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
+++ b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
@@ -137,7 +137,7 @@ abstract class PhabricatorApplicationTransaction
 
   public function getComment() {
     if ($this->commentNotLoaded) {
-      throw new Exception('Comment for this transaction was not loaded.');
+      throw new Exception(pht('Comment for this transaction was not loaded.'));
     }
     return $this->comment;
   }
@@ -292,8 +292,7 @@ abstract class PhabricatorApplicationTransaction
   public function getHandles() {
     if ($this->handles === null) {
       throw new Exception(
-        'Transaction requires handles and it did not load them.'
-      );
+        pht('Transaction requires handles and it did not load them.'));
     }
     return $this->handles;
   }
diff --git a/src/applications/transactions/view/PhabricatorApplicationTransactionView.php b/src/applications/transactions/view/PhabricatorApplicationTransactionView.php
index 2a8575e3c3..021abfb91b 100644
--- a/src/applications/transactions/view/PhabricatorApplicationTransactionView.php
+++ b/src/applications/transactions/view/PhabricatorApplicationTransactionView.php
@@ -194,7 +194,7 @@ class PhabricatorApplicationTransactionView extends AphrontView {
 
   public function render() {
     if (!$this->getObjectPHID()) {
-      throw new Exception('Call setObjectPHID() before render()!');
+      throw new PhutilInvalidStateException('setObjectPHID');
     }
 
     $view = $this->buildPHUITimelineView();
@@ -208,8 +208,7 @@ class PhabricatorApplicationTransactionView extends AphrontView {
 
   public function buildPHUITimelineView($with_hiding = true) {
     if (!$this->getObjectPHID()) {
-      throw new Exception(
-        'Call setObjectPHID() before buildPHUITimelineView()!');
+      throw new PhutilInvalidStateException('setObjectPHID');
     }
 
     $view = new PHUITimelineView();
diff --git a/src/applications/typeahead/controller/PhabricatorTypeaheadFunctionHelpController.php b/src/applications/typeahead/controller/PhabricatorTypeaheadFunctionHelpController.php
index dd29069ee5..851551d77f 100644
--- a/src/applications/typeahead/controller/PhabricatorTypeaheadFunctionHelpController.php
+++ b/src/applications/typeahead/controller/PhabricatorTypeaheadFunctionHelpController.php
@@ -93,25 +93,21 @@ final class PhabricatorTypeaheadFunctionHelpController
 
     $content[] = '= '.pht('Using Typeahead Functions');
     $content[] = pht(
-      'In addition to typing user and project names to build queries, you can '.
-      'also type the names of special functions which give you more options '.
-      'and the ability to express more complex queries.'.
-      "\n\n".
-      'Functions have an internal name (like `viewer()`) and a '.
-      'human-readable name, like `Current Viewer`. In general, you can type '.
-      'either one to select the function. You can also click the '.
-      '{nav icon=search} button on any typeahead control to browse available '.
-      'functions and find this documentation.'.
-      "\n\n".
-      'This documentation uses the internal names to make it clear where '.
-      'tokens begin and end. Specifically, you will find queries written '.
-      'out like this in the documentation: '.
-      "\n\n".
-      '> viewer(), alincoln'.
-      "\n\n".
-      'When this query is actually shown in the control, it will look more '.
-      'like this:'.
-      "\n\n".
+      "In addition to typing user and project names to build queries, you can ".
+      "also type the names of special functions which give you more options ".
+      "and the ability to express more complex queries.\n\n".
+      "Functions have an internal name (like `%s`) and a human-readable name, ".
+      "like `Current Viewer`. In general, you can type either one to select ".
+      "the function. You can also click the {nav icon=search} button on any ".
+      "typeahead control to browse available functions and find this ".
+      "documentation.\n\n".
+      "This documentation uses the internal names to make it clear where ".
+      "tokens begin and end. Specifically, you will find queries written ".
+      "out like this in the documentation:\n\n%s\n\n".
+      "When this query is actually shown in the control, it will look more ".
+      "like this:\n\n%s",
+      'viewer()',
+      '> viewer(), alincoln',
       '> {nav Current Viewer} {nav alincoln (Abraham Lincoln)}');
 
 
diff --git a/src/applications/uiexample/examples/JavelinReactorUIExample.php b/src/applications/uiexample/examples/JavelinReactorUIExample.php
index 9104c84c27..9e47545072 100644
--- a/src/applications/uiexample/examples/JavelinReactorUIExample.php
+++ b/src/applications/uiexample/examples/JavelinReactorUIExample.php
@@ -3,11 +3,11 @@
 final class JavelinReactorUIExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Javelin Reactor';
+    return pht('Javelin Reactor');
   }
 
   public function getDescription() {
-    return 'Lots of code';
+    return pht('Lots of code');
   }
 
   public function renderExample() {
@@ -15,55 +15,59 @@ final class JavelinReactorUIExample extends PhabricatorUIExample {
 
     $examples = array(
       array(
-        'Reactive button only generates a stream of events',
+        pht('Reactive button only generates a stream of events'),
         'ReactorButtonExample',
         'phabricator-uiexample-reactor-button',
         array(),
       ),
       array(
-        'Reactive checkbox generates a boolean dynamic value',
+        pht('Reactive checkbox generates a boolean dynamic value'),
         'ReactorCheckboxExample',
         'phabricator-uiexample-reactor-checkbox',
         array('checked' => true),
       ),
       array(
-        'Reactive focus detector generates a boolean dynamic value',
+        pht('Reactive focus detector generates a boolean dynamic value'),
         'ReactorFocusExample',
         'phabricator-uiexample-reactor-focus',
         array(),
       ),
       array(
-        'Reactive input box, with normal and calmed output',
+        pht('Reactive input box, with normal and calmed output'),
         'ReactorInputExample',
         'phabricator-uiexample-reactor-input',
         array('init' => 'Initial value'),
       ),
       array(
-        'Reactive mouseover detector generates a boolean dynamic value',
+        pht('Reactive mouseover detector generates a boolean dynamic value'),
         'ReactorMouseoverExample',
         'phabricator-uiexample-reactor-mouseover',
         array(),
       ),
       array(
-        'Reactive radio buttons generate a string dynamic value',
+        pht('Reactive radio buttons generate a string dynamic value'),
         'ReactorRadioExample',
         'phabricator-uiexample-reactor-radio',
         array(),
       ),
       array(
-        'Reactive select box generates a string dynamic value',
+        pht('Reactive select box generates a string dynamic value'),
         'ReactorSelectExample',
         'phabricator-uiexample-reactor-select',
         array(),
       ),
       array(
-        'sendclass makes the class of an element a string dynamic value',
+        pht(
+          '%s makes the class of an element a string dynamic value',
+          'sendclass'),
         'ReactorSendClassExample',
         'phabricator-uiexample-reactor-sendclass',
         array(),
       ),
       array(
-        'sendproperties makes some properties of an object into dynamic values',
+        pht(
+          '%s makes some properties of an object into dynamic values',
+          'sendproperties'),
         'ReactorSendPropertiesExample',
         'phabricator-uiexample-reactor-sendproperties',
         array(),
diff --git a/src/applications/uiexample/examples/JavelinUIExample.php b/src/applications/uiexample/examples/JavelinUIExample.php
index 5976066bd2..c85a2d4cde 100644
--- a/src/applications/uiexample/examples/JavelinUIExample.php
+++ b/src/applications/uiexample/examples/JavelinUIExample.php
@@ -3,11 +3,11 @@
 final class JavelinUIExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Javelin UI';
+    return pht('Javelin UI');
   }
 
   public function getDescription() {
-    return 'Here are some Javelin UI elements that you could use.';
+    return pht('Here are some Javelin UI elements that you could use.');
   }
 
   public function renderExample() {
@@ -34,7 +34,7 @@ final class JavelinUIExample extends PhabricatorUIExample {
           ),
         ),
       ),
-      'Toggle Red Border');
+      pht('Toggle Red Border'));
 
     $button_blue = javelin_tag(
       'a',
@@ -51,7 +51,7 @@ final class JavelinUIExample extends PhabricatorUIExample {
           ),
         ),
       ),
-      'Toggle Blue Background');
+      pht('Toggle Blue Background'));
 
     $div = phutil_tag(
       'div',
diff --git a/src/applications/uiexample/examples/JavelinViewUIExample.php b/src/applications/uiexample/examples/JavelinViewUIExample.php
index 73389475a7..f7df1749b4 100644
--- a/src/applications/uiexample/examples/JavelinViewUIExample.php
+++ b/src/applications/uiexample/examples/JavelinViewUIExample.php
@@ -3,11 +3,11 @@
 final class JavelinViewUIExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Javelin Views';
+    return pht('Javelin Views');
   }
 
   public function getDescription() {
-    return 'Mix and match client and server views.';
+    return pht('Mix and match client and server views.');
   }
 
   public function renderExample() {
@@ -33,7 +33,7 @@ final class JavelinViewUIExample extends PhabricatorUIExample {
     $parent_server_template->appendChild($parent_client_template);
     $parent_client_template->appendChild($child_server_template);
     $child_server_template->appendChild($child_client_template);
-    $child_client_template->appendChild('Hey, it worked.');
+    $child_client_template->appendChild(pht('Hey, it worked.'));
 
     $panel = new PHUIObjectBoxView();
     $panel->setHeaderText(pht('Example'));
diff --git a/src/applications/uiexample/examples/PHUIActionHeaderExample.php b/src/applications/uiexample/examples/PHUIActionHeaderExample.php
index 5962871f63..57a9435a94 100644
--- a/src/applications/uiexample/examples/PHUIActionHeaderExample.php
+++ b/src/applications/uiexample/examples/PHUIActionHeaderExample.php
@@ -3,11 +3,11 @@
 final class PHUIActionHeaderExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Action Headers';
+    return pht('Action Headers');
   }
 
   public function getDescription() {
-    return 'Various header layouts with and without icons';
+    return pht('Various header layouts with and without icons');
   }
 
   public function renderExample() {
@@ -17,26 +17,26 @@ final class PHUIActionHeaderExample extends PhabricatorUIExample {
       ->setHeader(pht('Header Plain'));
 
     $header1 = id(new PHUIActionHeaderView())
-      ->setHeaderTitle('Colorless');
+      ->setHeaderTitle(pht('Colorless'));
 
     $header2 = id(new PHUIActionHeaderView())
-      ->setHeaderTitle('Light Grey')
+      ->setHeaderTitle(pht('Light Grey'))
       ->setHeaderColor(PHUIActionHeaderView::HEADER_GREY);
 
     $header3 = id(new PHUIActionHeaderView())
-      ->setHeaderTitle('Light Blue')
+      ->setHeaderTitle(pht('Light Blue'))
       ->setHeaderColor(PHUIActionHeaderView::HEADER_LIGHTBLUE);
 
     $header4 = id(new PHUIActionHeaderView())
-      ->setHeaderTitle('Light Green')
+      ->setHeaderTitle(pht('Light Green'))
       ->setHeaderColor(PHUIActionHeaderView::HEADER_LIGHTGREEN);
 
     $header5 = id(new PHUIActionHeaderView())
-      ->setHeaderTitle('Light Red')
+      ->setHeaderTitle(pht('Light Red'))
       ->setHeaderColor(PHUIActionHeaderView::HEADER_LIGHTRED);
 
     $header6 = id(new PHUIActionHeaderView())
-      ->setHeaderTitle('Light Violet')
+      ->setHeaderTitle(pht('Light Violet'))
       ->setHeaderColor(PHUIActionHeaderView::HEADER_LIGHTVIOLET);
 
     $layout1 = id(new AphrontMultiColumnView())
@@ -53,7 +53,7 @@ final class PHUIActionHeaderExample extends PhabricatorUIExample {
       ->appendChild($layout1)
       ->addMargin(PHUI::MARGIN_LARGE);
 
-/* Policy Icons */
+    // Policy Icons
     $title2 = id(new PHUIHeaderView())
       ->setHeader(pht('With Icons'));
 
@@ -113,7 +113,7 @@ final class PHUIActionHeaderExample extends PhabricatorUIExample {
       ->addMargin(PHUI::MARGIN_LARGE);
 
 
-/* Action Icons */
+    // Action Icons
     $title3 = id(new PHUIHeaderView())
       ->setHeader(pht('With Action Icons'));
 
@@ -142,18 +142,18 @@ final class PHUIActionHeaderExample extends PhabricatorUIExample {
     $action6->setHref('#');
 
     $header1 = id(new PHUIActionHeaderView())
-      ->setHeaderTitle('Company')
+      ->setHeaderTitle(pht('Company'))
       ->setHeaderHref('http://example.com/')
       ->addAction($action1);
 
     $header2 = id(new PHUIActionHeaderView())
-      ->setHeaderTitle('Public')
+      ->setHeaderTitle(pht('Public'))
       ->setHeaderHref('http://example.com/')
       ->setHeaderColor(PHUIActionHeaderView::HEADER_GREY)
       ->addAction($action1);
 
     $header3 = id(new PHUIActionHeaderView())
-      ->setHeaderTitle('Restricted')
+      ->setHeaderTitle(pht('Restricted'))
       ->setHeaderHref('http://example.com/')
       ->setHeaderColor(PHUIActionHeaderView::HEADER_LIGHTBLUE)
       ->addAction($action2);
@@ -191,51 +191,51 @@ final class PHUIActionHeaderExample extends PhabricatorUIExample {
       ->appendChild($layout3)
       ->addMargin(PHUI::MARGIN_LARGE);
 
-/* Action Icons */
+    // Action Icons
     $title4 = id(new PHUIHeaderView())
       ->setHeader(pht('With Tags'));
 
     $tag1 = id(new PHUITagView())
       ->setType(PHUITagView::TYPE_STATE)
       ->setBackgroundColor(PHUITagView::COLOR_RED)
-      ->setName('Open');
+      ->setName(pht('Open'));
 
     $tag2 = id(new PHUITagView())
       ->setType(PHUITagView::TYPE_STATE)
       ->setBackgroundColor(PHUITagView::COLOR_BLUE)
-      ->setName('Closed');
+      ->setName(pht('Closed'));
 
     $action1 = new PHUIIconView();
     $action1->setIconFont('fa-flag');
     $action1->setHref('#');
 
     $header1 = id(new PHUIActionHeaderView())
-      ->setHeaderTitle('Company')
+      ->setHeaderTitle(pht('Company'))
       ->setTag($tag2);
 
     $header2 = id(new PHUIActionHeaderView())
-      ->setHeaderTitle('Public')
+      ->setHeaderTitle(pht('Public'))
       ->setHeaderColor(PHUIActionHeaderView::HEADER_GREY)
       ->addAction($action1)
       ->setTag($tag1);
 
     $header3 = id(new PHUIActionHeaderView())
-      ->setHeaderTitle('Restricted')
+      ->setHeaderTitle(pht('Restricted'))
       ->setHeaderColor(PHUIActionHeaderView::HEADER_LIGHTBLUE)
       ->setTag($tag2);
 
     $header4 = id(new PHUIActionHeaderView())
-      ->setHeaderTitle('Company')
+      ->setHeaderTitle(pht('Company'))
       ->setHeaderColor(PHUIActionHeaderView::HEADER_LIGHTGREEN)
       ->setTag($tag1);
 
     $header5 = id(new PHUIActionHeaderView())
-      ->setHeaderTitle('Public')
+      ->setHeaderTitle(pht('Public'))
       ->setHeaderColor(PHUIActionHeaderView::HEADER_LIGHTRED)
       ->setTag($tag2);
 
     $header6 = id(new PHUIActionHeaderView())
-      ->setHeaderTitle('Restricted')
+      ->setHeaderTitle(pht('Restricted'))
       ->setHeaderColor(PHUIActionHeaderView::HEADER_LIGHTVIOLET)
       ->setTag($tag1);
 
diff --git a/src/applications/uiexample/examples/PHUIActionPanelExample.php b/src/applications/uiexample/examples/PHUIActionPanelExample.php
index 229cfec4be..cbffbf6124 100644
--- a/src/applications/uiexample/examples/PHUIActionPanelExample.php
+++ b/src/applications/uiexample/examples/PHUIActionPanelExample.php
@@ -3,11 +3,11 @@
 final class PHUIActionPanelExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Action Panel';
+    return pht('Action Panel');
   }
 
   public function getDescription() {
-    return 'A panel with strong tendencies for inciting ACTION!';
+    return pht('A panel with strong tendencies for inciting ACTION!');
   }
 
   public function renderExample() {
@@ -30,7 +30,7 @@ final class PHUIActionPanelExample extends PhabricatorUIExample {
       ->setFontIcon('fa-server')
       ->setHeader(pht('Launch Instance'))
       ->setHref('#')
-      ->setSubHeader(pht('Maybe this is what you\'re likely here for.'))
+      ->setSubHeader(pht("Maybe this is what you're likely here for."))
       ->setStatus(pht('You have no instances.'))
       ->setState(PHUIActionPanelView::STATE_ERROR);
     $view->addColumn($panel2);
diff --git a/src/applications/uiexample/examples/PHUIBoxExample.php b/src/applications/uiexample/examples/PHUIBoxExample.php
index a8999f5cf9..1f372c4cd6 100644
--- a/src/applications/uiexample/examples/PHUIBoxExample.php
+++ b/src/applications/uiexample/examples/PHUIBoxExample.php
@@ -3,18 +3,18 @@
 final class PHUIBoxExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Box';
+    return pht('Box');
   }
 
   public function getDescription() {
-    return 'It\'s a fancy or non-fancy box. Put stuff in it.';
+    return pht("It's a fancy or non-fancy box. Put stuff in it.");
   }
 
   public function renderExample() {
 
     $content1 = 'Asmund and Signy';
     $content2 = 'The Cottager and his Cat';
-    $content3 = 'Geirlug The King\'s Daughter';
+    $content3 = "Geirlug The King's Daughter";
 
     $layout1 =
       array(
@@ -67,18 +67,18 @@ final class PHUIBoxExample extends PhabricatorUIExample {
         ->setTag('a')
         ->setColor(PHUIButtonView::SIMPLE)
         ->setIcon($image)
-        ->setText('Such Wow')
+        ->setText(pht('Such Wow'))
         ->addClass(PHUI::MARGIN_SMALL_RIGHT);
 
     $header = id(new PHUIHeaderView())
-      ->setHeader('Fancy Box')
+      ->setHeader(pht('Fancy Box'))
       ->addActionLink($button);
 
     $obj4 = id(new PHUIObjectBoxView())
       ->setHeader($header)
       ->appendChild(id(new PHUIBoxView())
         ->addPadding(PHUI::PADDING_MEDIUM)
-        ->appendChild('Such Fancy, Nice Box, Many Corners.'));
+        ->appendChild(pht('Such Fancy, Nice Box, Many Corners.')));
 
     $head1 = id(new PHUIHeaderView())
       ->setHeader(pht('Plain Box'));
diff --git a/src/applications/uiexample/examples/PHUIButtonBarExample.php b/src/applications/uiexample/examples/PHUIButtonBarExample.php
index 293cd2336a..8e00a99436 100644
--- a/src/applications/uiexample/examples/PHUIButtonBarExample.php
+++ b/src/applications/uiexample/examples/PHUIButtonBarExample.php
@@ -74,7 +74,7 @@ final class PHUIButtonBarExample extends PhabricatorUIExample {
       ->addClass('mlr mll mlb');
 
     $wrap1 = id(new PHUIObjectBoxView())
-      ->setHeaderText('Button Bar Example')
+      ->setHeaderText(pht('Button Bar Example'))
       ->appendChild($layout1)
       ->appendChild($layout2)
       ->appendChild($layout3);
diff --git a/src/applications/uiexample/examples/PHUIButtonExample.php b/src/applications/uiexample/examples/PHUIButtonExample.php
index 218e97e958..216a4a4406 100644
--- a/src/applications/uiexample/examples/PHUIButtonExample.php
+++ b/src/applications/uiexample/examples/PHUIButtonExample.php
@@ -3,11 +3,13 @@
 final class PHUIButtonExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Buttons';
+    return pht('Buttons');
   }
 
   public function getDescription() {
-    return hsprintf('Use <tt>&lt;button&gt;</tt> to render buttons.');
+    return pht(
+      'Use %s to render buttons.',
+      phutil_tag('tt', array(), '&lt;button&gt;'));
   }
 
   public function renderExample() {
@@ -79,7 +81,7 @@ final class PHUIButtonExample extends PhabricatorUIExample {
         ->setColor($color)
         ->setSize($size)
         ->setTag('a')
-        ->setText('Clicky');
+        ->setText(pht('Clicky'));
       $column[$key][] = hsprintf('<br /><br />');
      }
    }
@@ -87,7 +89,7 @@ final class PHUIButtonExample extends PhabricatorUIExample {
      $column[2][] = id(new PHUIButtonView())
         ->setColor($color)
         ->setTag('button')
-        ->setText('Button')
+        ->setText(pht('Button'))
         ->setDropdown(true);
       $column[2][] = hsprintf('<br /><br />');
    }
@@ -110,7 +112,7 @@ final class PHUIButtonExample extends PhabricatorUIExample {
     );
     foreach ($icons as $text => $icon) {
       $image = id(new PHUIIconView())
-          ->setIconFont($icon);
+        ->setIconFont($icon);
       $column[] = id(new PHUIButtonView())
         ->setTag('a')
         ->setColor(PHUIButtonView::GREY)
@@ -160,14 +162,14 @@ final class PHUIButtonExample extends PhabricatorUIExample {
     $icons = array('Asana', 'Github', 'Facebook', 'Google', 'LDAP');
     foreach ($icons as $icon) {
       $image = id(new PHUIIconView())
-          ->setSpriteSheet(PHUIIconView::SPRITE_LOGIN)
-          ->setSpriteIcon($icon);
+        ->setSpriteSheet(PHUIIconView::SPRITE_LOGIN)
+        ->setSpriteIcon($icon);
       $column[] = id(new PHUIButtonView())
         ->setTag('a')
         ->setSize(PHUIButtonView::BIG)
         ->setColor(PHUIButtonView::GREY)
         ->setIcon($image)
-        ->setText('Login or Register')
+        ->setText(pht('Login or Register'))
         ->setSubtext($icon)
         ->addClass(PHUI::MARGIN_MEDIUM_RIGHT);
     }
@@ -187,13 +189,13 @@ final class PHUIButtonExample extends PhabricatorUIExample {
       ->setHeader('PHUIButtonView');
 
     $head3 = id(new PHUIHeaderView())
-      ->setHeader('Icon Buttons');
+      ->setHeader(pht('Icon Buttons'));
 
     $head4 = id(new PHUIHeaderView())
-      ->setHeader('Simple Buttons');
+      ->setHeader(pht('Simple Buttons'));
 
     $head5 = id(new PHUIHeaderView())
-      ->setHeader('Big Icon Buttons');
+      ->setHeader(pht('Big Icon Buttons'));
 
     $wrap1 = id(new PHUIBoxView())
       ->appendChild($layout1)
@@ -215,8 +217,17 @@ final class PHUIButtonExample extends PhabricatorUIExample {
       ->appendChild($layout5)
       ->addMargin(PHUI::MARGIN_LARGE);
 
-    return array($head1, $wrap1, $head2, $wrap2, $head3, $wrap3,
-      $head4, $wrap4, $head5, $wrap5,
+    return array(
+      $head1,
+      $wrap1,
+      $head2,
+      $wrap2,
+      $head3,
+      $wrap3,
+      $head4,
+      $wrap4,
+      $head5,
+      $wrap5,
     );
   }
 }
diff --git a/src/applications/uiexample/examples/PHUIColorPalletteExample.php b/src/applications/uiexample/examples/PHUIColorPalletteExample.php
index 08459d60b5..0e3193d24d 100644
--- a/src/applications/uiexample/examples/PHUIColorPalletteExample.php
+++ b/src/applications/uiexample/examples/PHUIColorPalletteExample.php
@@ -3,11 +3,11 @@
 final class PHUIColorPalletteExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Colors';
+    return pht('Colors');
   }
 
   public function getDescription() {
-    return 'A Standard Palette of Colors for use.';
+    return pht('A Standard Palette of Colors for use.');
   }
 
   public function renderExample() {
@@ -99,7 +99,7 @@ final class PHUIColorPalletteExample extends PhabricatorUIExample {
         'href' => 'http://color.hailpixel.com/#'.implode(',', $url),
         'class' => 'button grey mlb',
       ),
-      'Color Palette');
+      pht('Color Palette'));
 
     $wrap1 = id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Greys'))
diff --git a/src/applications/uiexample/examples/PHUIDocumentExample.php b/src/applications/uiexample/examples/PHUIDocumentExample.php
index f0a77e354f..6fc6560734 100644
--- a/src/applications/uiexample/examples/PHUIDocumentExample.php
+++ b/src/applications/uiexample/examples/PHUIDocumentExample.php
@@ -15,35 +15,35 @@ final class PHUIDocumentExample extends PhabricatorUIExample {
     $user = $request->getUser();
 
     $action = id(new PHUIListItemView())
-      ->setName('Actions')
+      ->setName(pht('Actions'))
       ->setType(PHUIListItemView::TYPE_LABEL);
 
     $action1 = id(new PHUIListItemView())
-      ->setName('Edit Document')
+      ->setName(pht('Edit Document'))
       ->setHref('#')
       ->setIcon('fa-edit')
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $action2 = id(new PHUIListItemView())
-      ->setName('Move Document')
+      ->setName(pht('Move Document'))
       ->setHref('#')
       ->setIcon('fa-arrows')
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $action3 = id(new PHUIListItemView())
-      ->setName('Delete Document')
+      ->setName(pht('Delete Document'))
       ->setHref('#')
       ->setIcon('fa-times')
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $action4 = id(new PHUIListItemView())
-      ->setName('View History')
+      ->setName(pht('View History'))
       ->setHref('#')
       ->setIcon('fa-list')
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $action5 = id(new PHUIListItemView())
-      ->setName('Subscribe')
+      ->setName(pht('Subscribe'))
       ->setHref('#')
       ->setIcon('fa-plus-circle')
       ->setType(PHUIListItemView::TYPE_LINK);
@@ -52,33 +52,33 @@ final class PHUIDocumentExample extends PhabricatorUIExample {
       ->setType(PHUIListItemView::TYPE_DIVIDER);
 
     $header = id(new PHUIHeaderView())
-      ->setHeader('Installation');
+      ->setHeader(pht('Installation'));
 
     $label1 = id(new PHUIListItemView())
-      ->setName('Getting Started')
+      ->setName(pht('Getting Started'))
       ->setType(PHUIListItemView::TYPE_LABEL);
 
     $label2 = id(new PHUIListItemView())
-      ->setName('Documentation')
+      ->setName(pht('Documentation'))
       ->setType(PHUIListItemView::TYPE_LABEL);
 
     $item1 = id(new PHUIListItemView())
-      ->setName('Installation')
+      ->setName(pht('Installation'))
       ->setHref('#')
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $item2 = id(new PHUIListItemView())
-      ->setName('Webserver Config')
+      ->setName(pht('Webserver Config'))
       ->setHref('#')
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $item3 = id(new PHUIListItemView())
-      ->setName('Adding Users')
+      ->setName(pht('Adding Users'))
       ->setHref('#')
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $item4 = id(new PHUIListItemView())
-      ->setName('Debugging')
+      ->setName(pht('Debugging'))
       ->setHref('#')
       ->setType(PHUIListItemView::TYPE_LINK);
 
@@ -108,23 +108,23 @@ final class PHUIDocumentExample extends PhabricatorUIExample {
       ->setType(PHUIListItemView::TYPE_ICON);
 
     $item1 = id(new PHUIListItemView())
-      ->setName('Installation')
+      ->setName(pht('Installation'))
       ->setHref('#')
       ->setSelected(true)
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $item2 = id(new PHUIListItemView())
-      ->setName('Webserver Config')
+      ->setName(pht('Webserver Config'))
       ->setHref('#')
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $item3 = id(new PHUIListItemView())
-      ->setName('Adding Users')
+      ->setName(pht('Adding Users'))
       ->setHref('#')
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $item4 = id(new PHUIListItemView())
-      ->setName('Debugging')
+      ->setName(pht('Debugging'))
       ->setHref('#')
       ->setType(PHUIListItemView::TYPE_LINK);
 
@@ -187,7 +187,7 @@ final class PHUIDocumentExample extends PhabricatorUIExample {
       'mollit anim id est laborum.</p>');
 
      $content = new PHUIDocumentView();
-     $content->setBook('Book or Project Name', 'Article');
+     $content->setBook(pht('Book or Project Name'), pht('Article'));
      $content->setHeader($header);
      $content->setFluid(true);
      $content->setTopNav($topnav);
diff --git a/src/applications/uiexample/examples/PHUIFeedStoryExample.php b/src/applications/uiexample/examples/PHUIFeedStoryExample.php
index 2a896ec09e..6731f1ce1f 100644
--- a/src/applications/uiexample/examples/PHUIFeedStoryExample.php
+++ b/src/applications/uiexample/examples/PHUIFeedStoryExample.php
@@ -3,12 +3,12 @@
 final class PHUIFeedStoryExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Feed Story';
+    return pht('Feed Story');
   }
 
   public function getDescription() {
-    return 'An outlandish exaggeration of intricate tales from '.
-      'around the realm';
+    return pht(
+      'An outlandish exaggeration of intricate tales from around the realm');
   }
 
   public function renderExample() {
@@ -41,7 +41,8 @@ final class PHUIFeedStoryExample extends PhabricatorUIExample {
           ->setSpriteSheet(PHUIIconView::SPRITE_TOKENS)
           ->setSpriteIcon($token);
     }
-    $text = hsprintf('<strong><a>lincoln (Honest Abe)</a></strong> wrote a '.
+    $text = hsprintf(
+      '<strong><a>lincoln (Honest Abe)</a></strong> wrote a '.
       'new blog post.');
     $story2 = id(new PHUIFeedStoryView())
       ->setTitle($text)
@@ -51,7 +52,8 @@ final class PHUIFeedStoryExample extends PhabricatorUIExample {
       ->setAppIcon('fa-star')
       ->setUser($user)
       ->setTokenBar($tokenview)
-      ->setPontification('Four score and seven years ago our fathers brought '.
+      ->setPontification(
+        'Four score and seven years ago our fathers brought '.
         'forth on this continent, a new nation, conceived in Liberty, and '.
         'dedicated to the proposition that all men are created equal. '.
         'Now we are engaged in a great civil war, testing whether that '.
@@ -64,7 +66,8 @@ final class PHUIFeedStoryExample extends PhabricatorUIExample {
 
     /* Action Story, let's give people tokens! */
 
-    $text = hsprintf('<strong><a>harding (Tom Harding)</a></strong> awarded '.
+    $text = hsprintf(
+      '<strong><a>harding (Tom Harding)</a></strong> awarded '.
       '<a>M10: Workboards</a> a token.');
     $action1 = id(new PHUIIconView())
       ->setIconFont('fa-trophy bluegrey')
@@ -84,7 +87,8 @@ final class PHUIFeedStoryExample extends PhabricatorUIExample {
       ->setUser($user);
 
     /* Image Story, used in Pholio, Macro */
-    $text = hsprintf('<strong><a>wgharding (Warren Harding)</a></strong> '.
+    $text = hsprintf(
+      '<strong><a>wgharding (Warren Harding)</a></strong> '.
       'asked a new question.');
     $action1 = id(new PHUIIconView())
       ->setIconFont('fa-chevron-up bluegrey')
@@ -98,14 +102,15 @@ final class PHUIFeedStoryExample extends PhabricatorUIExample {
       ->setImageHref('http://en.wikipedia.org/wiki/Warren_G._Harding')
       ->setEpoch(1)
       ->setAppIcon('fa-cogs')
-      ->setPontification('Why does inline-block add space under my spans and '.
-        'anchors?')
+      ->setPontification(
+        'Why does inline-block add space under my spans and anchors?')
       ->addAction($action1)
       ->addAction($action2)
       ->setUser($user);
 
     /* Text Story, useful in Blogs, Ponders, Status */
-    $text = hsprintf('<strong><a>lincoln (Honest Abe)</a></strong> updated '.
+    $text = hsprintf(
+      '<strong><a>lincoln (Honest Abe)</a></strong> updated '.
       'his status.');
     $story5 = id(new PHUIFeedStoryView())
       ->setTitle($text)
@@ -114,8 +119,9 @@ final class PHUIFeedStoryExample extends PhabricatorUIExample {
       ->setEpoch(strtotime('November 19, 1863'))
       ->setAppIcon('fa-rocket')
       ->setUser($user)
-      ->setPontification('If we ever create a lightweight status app '.
-      'this story would be how that would be displayed.');
+      ->setPontification(
+        'If we ever create a lightweight status app '.
+        'this story would be how that would be displayed.');
 
     /* Basic "One Line" Story */
     $text = hsprintf(
diff --git a/src/applications/uiexample/examples/PHUIIconExample.php b/src/applications/uiexample/examples/PHUIIconExample.php
index 32259c1ce3..2644672a1b 100644
--- a/src/applications/uiexample/examples/PHUIIconExample.php
+++ b/src/applications/uiexample/examples/PHUIIconExample.php
@@ -3,11 +3,11 @@
 final class PHUIIconExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Icons and Images';
+    return pht('Icons and Images');
   }
 
   public function getDescription() {
-    return 'Easily render icons or images with links and sprites.';
+    return pht('Easily render icons or images with links and sprites.');
   }
 
   private function listTransforms() {
diff --git a/src/applications/uiexample/examples/PHUIImageMaskExample.php b/src/applications/uiexample/examples/PHUIImageMaskExample.php
index c43da63028..8238230387 100644
--- a/src/applications/uiexample/examples/PHUIImageMaskExample.php
+++ b/src/applications/uiexample/examples/PHUIImageMaskExample.php
@@ -3,15 +3,14 @@
 final class PHUIImageMaskExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Image Masks';
+    return pht('Image Masks');
   }
 
   public function getDescription() {
-    return 'Display images with crops.';
+    return pht('Display images with crops.');
   }
 
   public function renderExample() {
-
     $image = celerity_get_resource_uri('/rsrc/image/examples/hero.png');
     $display_height = 100;
     $display_width = 200;
diff --git a/src/applications/uiexample/examples/PHUIInfoExample.php b/src/applications/uiexample/examples/PHUIInfoExample.php
index 012494f0eb..29a4e661a2 100644
--- a/src/applications/uiexample/examples/PHUIInfoExample.php
+++ b/src/applications/uiexample/examples/PHUIInfoExample.php
@@ -3,12 +3,13 @@
 final class PHUIInfoExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Info View';
+    return pht('Info View');
   }
 
   public function getDescription() {
-    return hsprintf(
-      'Use <tt>PHUIInfoView</tt> to render errors, warnings and notices.');
+    return pht(
+      'Use %s to render errors, warnings and notices.',
+      phutil_tag('tt', array(), 'PHUIInfoView'));
   }
 
   public function renderExample() {
@@ -16,16 +17,16 @@ final class PHUIInfoExample extends PhabricatorUIExample {
     $user = $request->getUser();
 
     $sevs = array(
-      PHUIInfoView::SEVERITY_ERROR    => 'Error',
-      PHUIInfoView::SEVERITY_WARNING  => 'Warning',
-      PHUIInfoView::SEVERITY_NODATA   => 'No Data',
-      PHUIInfoView::SEVERITY_NOTICE   => 'Notice',
-      PHUIInfoView::SEVERITY_SUCCESS   => 'Success',
+      PHUIInfoView::SEVERITY_ERROR    => pht('Error'),
+      PHUIInfoView::SEVERITY_WARNING  => pht('Warning'),
+      PHUIInfoView::SEVERITY_NODATA   => pht('No Data'),
+      PHUIInfoView::SEVERITY_NOTICE   => pht('Notice'),
+      PHUIInfoView::SEVERITY_SUCCESS  => pht('Success'),
     );
 
     $button = id(new PHUIButtonView())
         ->setTag('a')
-        ->setText('Resolve Issue')
+        ->setText(pht('Resolve Issue'))
         ->setHref('#');
 
     $views = array();
@@ -42,7 +43,7 @@ final class PHUIInfoExample extends PhabricatorUIExample {
     foreach ($sevs as $sev => $title) {
       $view = new PHUIInfoView();
       $view->setSeverity($sev);
-      $view->appendChild('Several issues were encountered.');
+      $view->appendChild(pht('Several issues were encountered.'));
       $view->addButton($button);
       $views[] = $view;
     }
@@ -54,9 +55,9 @@ final class PHUIInfoExample extends PhabricatorUIExample {
       $view->setSeverity($sev);
       $view->setErrors(
         array(
-          'Overcooked.',
-          'Too much salt.',
-          'Full of sand.',
+          pht('Overcooked.'),
+          pht('Too much salt.'),
+          pht('Full of sand.'),
         ));
       $views[] = $view;
     }
@@ -67,12 +68,12 @@ final class PHUIInfoExample extends PhabricatorUIExample {
       $view = new PHUIInfoView();
       $view->setSeverity($sev);
       $view->setTitle($title);
-      $view->appendChild('Several issues were encountered.');
+      $view->appendChild(pht('Several issues were encountered.'));
       $view->setErrors(
         array(
-          'Overcooked.',
-          'Too much salt.',
-          'Full of sand.',
+          pht('Overcooked.'),
+          pht('Too much salt.'),
+          pht('Full of sand.'),
         ));
       $views[] = $view;
     }
diff --git a/src/applications/uiexample/examples/PHUIInfoPanelExample.php b/src/applications/uiexample/examples/PHUIInfoPanelExample.php
index 7f75656b37..74ed18f37c 100644
--- a/src/applications/uiexample/examples/PHUIInfoPanelExample.php
+++ b/src/applications/uiexample/examples/PHUIInfoPanelExample.php
@@ -3,15 +3,14 @@
 final class PHUIInfoPanelExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Info Panel';
+    return pht('Info Panel');
   }
 
   public function getDescription() {
-    return 'A medium sized box with bits of gooey information.';
+    return pht('A medium sized box with bits of gooey information.');
   }
 
   public function renderExample() {
-
     $header1 = id(new PHUIHeaderView())
       ->setHeader(pht('Conpherence'));
 
@@ -42,60 +41,60 @@ final class PHUIInfoPanelExample extends PhabricatorUIExample {
     $column1 = id(new PHUIInfoPanelView())
       ->setHeader($header1)
       ->setColumns(3)
-      ->addInfoBlock(3, 'Needs Triage')
-      ->addInfoBlock(5, 'Unbreak Now')
-      ->addInfoBlock(0, 'High')
-      ->addInfoBlock(0, 'Normal')
-      ->addInfoBlock(12, 'Low')
-      ->addInfoBlock(123, 'Wishlist');
+      ->addInfoBlock(3, pht('Needs Triage'))
+      ->addInfoBlock(5, pht('Unbreak Now'))
+      ->addInfoBlock(0, pht('High'))
+      ->addInfoBlock(0, pht('Normal'))
+      ->addInfoBlock(12, pht('Low'))
+      ->addInfoBlock(123, pht('Wishlist'));
 
     $column2 = id(new PHUIInfoPanelView())
       ->setHeader($header2)
       ->setColumns(3)
-      ->addInfoBlock(3, 'Needs Triage')
-      ->addInfoBlock(5, 'Unbreak Now')
-      ->addInfoBlock(0, 'High')
-      ->addInfoBlock(0, 'Normal')
-      ->addInfoBlock(12, 'Low')
-      ->addInfoBlock(123, 'Wishlist');
+      ->addInfoBlock(3, pht('Needs Triage'))
+      ->addInfoBlock(5, pht('Unbreak Now'))
+      ->addInfoBlock(0, pht('High'))
+      ->addInfoBlock(0, pht('Normal'))
+      ->addInfoBlock(12, pht('Low'))
+      ->addInfoBlock(123, pht('Wishlist'));
 
     $column3 = id(new PHUIInfoPanelView())
       ->setHeader($header3)
       ->setColumns(3)
-      ->addInfoBlock(3, 'Needs Triage')
-      ->addInfoBlock(5, 'Unbreak Now')
-      ->addInfoBlock(0, 'High')
-      ->addInfoBlock(0, 'Normal')
-      ->addInfoBlock(12, 'Low')
-      ->addInfoBlock(123, 'Wishlist');
+      ->addInfoBlock(3, pht('Needs Triage'))
+      ->addInfoBlock(5, pht('Unbreak Now'))
+      ->addInfoBlock(0, pht('High'))
+      ->addInfoBlock(0, pht('Normal'))
+      ->addInfoBlock(12, pht('Low'))
+      ->addInfoBlock(123, pht('Wishlist'));
 
     $column4 = id(new PHUIInfoPanelView())
       ->setHeader($header4)
       ->setColumns(3)
       ->setProgress(90)
-      ->addInfoBlock(3, 'Needs Triage')
-      ->addInfoBlock(5, 'Unbreak Now')
-      ->addInfoBlock(0, 'High')
-      ->addInfoBlock(0, 'Normal')
-      ->addInfoBlock(0, 'Wishlist');
+      ->addInfoBlock(3, pht('Needs Triage'))
+      ->addInfoBlock(5, pht('Unbreak Now'))
+      ->addInfoBlock(0, pht('High'))
+      ->addInfoBlock(0, pht('Normal'))
+      ->addInfoBlock(0, pht('Wishlist'));
 
     $column5 = id(new PHUIInfoPanelView())
       ->setHeader($header5)
       ->setColumns(2)
       ->setProgress(25)
-      ->addInfoBlock(3, 'Needs Triage')
-      ->addInfoBlock(5, 'Unbreak Now')
-      ->addInfoBlock(0, 'High')
-      ->addInfoBlock(0, 'Normal');
+      ->addInfoBlock(3, pht('Needs Triage'))
+      ->addInfoBlock(5, pht('Unbreak Now'))
+      ->addInfoBlock(0, pht('High'))
+      ->addInfoBlock(0, pht('Normal'));
 
     $column6 = id(new PHUIInfoPanelView())
       ->setHeader($header6)
       ->setColumns(2)
       ->setProgress(50)
-      ->addInfoBlock(3, 'Needs Triage')
-      ->addInfoBlock(5, 'Unbreak Now')
-      ->addInfoBlock(0, 'High')
-      ->addInfoBlock(0, 'Normal');
+      ->addInfoBlock(3, pht('Needs Triage'))
+      ->addInfoBlock(5, pht('Unbreak Now'))
+      ->addInfoBlock(0, pht('High'))
+      ->addInfoBlock(0, pht('Normal'));
 
     $layout1 = id(new AphrontMultiColumnView())
       ->addColumn($column1)
diff --git a/src/applications/uiexample/examples/PHUIListExample.php b/src/applications/uiexample/examples/PHUIListExample.php
index bda1e1a2ba..eb4882b1d0 100644
--- a/src/applications/uiexample/examples/PHUIListExample.php
+++ b/src/applications/uiexample/examples/PHUIListExample.php
@@ -3,44 +3,42 @@
 final class PHUIListExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Lists';
+    return pht('Lists');
   }
 
   public function getDescription() {
-    return 'Create a fanciful list of objects and prismatic donuts.';
+    return pht('Create a fanciful list of objects and prismatic donuts.');
   }
 
   public function renderExample() {
-
-
     /* Action Menu */
 
     $action1 = id(new PHUIListItemView())
-      ->setName('Edit Document')
+      ->setName(pht('Edit Document'))
       ->setHref('#')
       ->setIcon('fa-pencil')
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $action2 = id(new PHUIListItemView())
-      ->setName('Move Document')
+      ->setName(pht('Move Document'))
       ->setHref('#')
       ->setIcon('fa-arrows')
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $action3 = id(new PHUIListItemView())
-      ->setName('Delete Document')
+      ->setName(pht('Delete Document'))
       ->setHref('#')
       ->setIcon('fa-times')
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $action4 = id(new PHUIListItemView())
-      ->setName('View History')
+      ->setName(pht('View History'))
       ->setHref('#')
       ->setIcon('fa-list')
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $action5 = id(new PHUIListItemView())
-      ->setName('Subscribe')
+      ->setName(pht('Subscribe'))
       ->setHref('#')
       ->setIcon('fa-plus-circle')
       ->setType(PHUIListItemView::TYPE_LINK);
@@ -57,30 +55,30 @@ final class PHUIListExample extends PhabricatorUIExample {
     /* Side Navigation */
 
     $label1 = id(new PHUIListItemView())
-      ->setName('Getting Started')
+      ->setName(pht('Getting Started'))
       ->setType(PHUIListItemView::TYPE_LABEL);
 
     $label2 = id(new PHUIListItemView())
-      ->setName('Documentation')
+      ->setName(pht('Documentation'))
       ->setType(PHUIListItemView::TYPE_LABEL);
 
     $item1 = id(new PHUIListItemView())
-      ->setName('Installation')
+      ->setName(pht('Installation'))
       ->setHref('#')
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $item2 = id(new PHUIListItemView())
-      ->setName('Webserver Config')
+      ->setName(pht('Webserver Config'))
       ->setHref('#')
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $item3 = id(new PHUIListItemView())
-      ->setName('Adding Users')
+      ->setName(pht('Adding Users'))
       ->setHref('#')
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $item4 = id(new PHUIListItemView())
-      ->setName('Debugging')
+      ->setName(pht('Debugging'))
       ->setHref('#')
       ->setType(PHUIListItemView::TYPE_LINK);
 
@@ -105,16 +103,16 @@ final class PHUIListExample extends PhabricatorUIExample {
     /* Unstyled */
 
     $item1 = id(new PHUIListItemView())
-      ->setName('Rain');
+      ->setName(pht('Rain'));
 
     $item2 = id(new PHUIListItemView())
-      ->setName('Spain');
+      ->setName(pht('Spain'));
 
     $item3 = id(new PHUIListItemView())
-      ->setName('Mainly');
+      ->setName(pht('Mainly'));
 
     $item4 = id(new PHUIListItemView())
-      ->setName('Plains');
+      ->setName(pht('Plains'));
 
     $unstyled = id(new PHUIListView())
       ->addMenuItem($item1)
@@ -130,61 +128,61 @@ final class PHUIListExample extends PhabricatorUIExample {
       ->setType(PHUIListItemView::TYPE_ICON);
 
     $item1 = id(new PHUIListItemView())
-      ->setName('Installation')
+      ->setName(pht('Installation'))
       ->setHref('#')
       ->setSelected(true)
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $item2 = id(new PHUIListItemView())
-      ->setName('Webserver Config')
+      ->setName(pht('Webserver Config'))
       ->setHref('#')
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $item3 = id(new PHUIListItemView())
-      ->setName('Adding Users')
+      ->setName(pht('Adding Users'))
       ->setHref('#')
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $item4 = id(new PHUIListItemView())
-      ->setName('Debugging')
+      ->setName(pht('Debugging'))
       ->setHref('#')
       ->setType(PHUIListItemView::TYPE_LINK);
 
         $item1 = id(new PHUIListItemView())
-      ->setName('Installation')
+      ->setName(pht('Installation'))
       ->setHref('#')
       ->setSelected(true)
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $item2 = id(new PHUIListItemView())
-      ->setName('Webserver Config')
+      ->setName(pht('Webserver Config'))
       ->setHref('#')
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $details1 = id(new PHUIListItemView())
-      ->setName('Details')
+      ->setName(pht('Details'))
       ->setHref('#')
       ->setSelected(true)
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $details2 = id(new PHUIListItemView())
-      ->setName('Lint (OK)')
+      ->setName(pht('Lint (OK)'))
       ->setHref('#')
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $details3 = id(new PHUIListItemView())
-      ->setName('Unit (5/5)')
+      ->setName(pht('Unit (5/5)'))
       ->setHref('#')
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $details4 = id(new PHUIListItemView())
-      ->setName('Lint (Warn)')
+      ->setName(pht('Lint (Warn)'))
       ->setHref('#')
       ->setStatusColor(PHUIListItemView::STATUS_WARN)
       ->setType(PHUIListItemView::TYPE_LINK);
 
     $details5 = id(new PHUIListItemView())
-      ->setName('Unit (3/5)')
+      ->setName(pht('Unit (3/5)'))
       ->setHref('#')
       ->setStatusColor(PHUIListItemView::STATUS_FAIL)
       ->setType(PHUIListItemView::TYPE_LINK);
diff --git a/src/applications/uiexample/examples/PHUIObjectItemListExample.php b/src/applications/uiexample/examples/PHUIObjectItemListExample.php
index 370276eaa6..10f9474f2b 100644
--- a/src/applications/uiexample/examples/PHUIObjectItemListExample.php
+++ b/src/applications/uiexample/examples/PHUIObjectItemListExample.php
@@ -3,12 +3,13 @@
 final class PHUIObjectItemListExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Object Item List';
+    return pht('Object Item List');
   }
 
   public function getDescription() {
-    return hsprintf(
-      'Use <tt>PHUIObjectItemListView</tt> to render lists of objects.');
+    return pht(
+      'Use %s to render lists of objects.',
+      hsprintf('<tt>PHUIObjectItemListView</tt>'));
   }
 
   public function renderExample() {
@@ -146,9 +147,10 @@ final class PHUIObjectItemListExample extends PhabricatorUIExample {
         ->setBarColor('blue'));
     $list->addItem(
       id(new PHUIObjectItemView())
-        ->setHeader(pht(
-          'The human cardiovascular system includes the heart, lungs, and '.
-          'some other parts; most of these parts are pretty squishy'))
+        ->setHeader(
+          pht(
+            'The human cardiovascular system includes the heart, lungs, and '.
+            'some other parts; most of these parts are pretty squishy'))
         ->addFootIcon('fa-search white', pht('Respiration!'))
         ->addHandleIcon($handle, pht('You have a cardiovascular system!'))
         ->setBarColor('indigo'));
@@ -405,7 +407,7 @@ final class PHUIObjectItemListExample extends PhabricatorUIExample {
         ->setState(PHUIObjectItemView::STATE_BUILD));
 
     $box = id(new PHUIObjectBoxView())
-      ->setHeaderText('Test Things')
+      ->setHeaderText(pht('Test Things'))
       ->appendChild($list);
 
     $out[] = array($head, $box);
diff --git a/src/applications/uiexample/examples/PHUIPropertyListExample.php b/src/applications/uiexample/examples/PHUIPropertyListExample.php
index 6438f31e65..76a39774b6 100644
--- a/src/applications/uiexample/examples/PHUIPropertyListExample.php
+++ b/src/applications/uiexample/examples/PHUIPropertyListExample.php
@@ -3,12 +3,13 @@
 final class PHUIPropertyListExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Property List';
+    return pht('Property List');
   }
 
   public function getDescription() {
-    return hsprintf(
-      'Use <tt>PHUIPropertyListView</tt> to render object properties.');
+    return pht(
+      'Use %s to render object properties.',
+      phutil_tag('tt', array(), 'PHUIPropertyListView'));
   }
 
   public function renderExample() {
@@ -16,15 +17,15 @@ final class PHUIPropertyListExample extends PhabricatorUIExample {
     $user = $request->getUser();
 
     $details1 = id(new PHUIListItemView())
-      ->setName('Details')
+      ->setName(pht('Details'))
       ->setSelected(true);
 
     $details2 = id(new PHUIListItemView())
-      ->setName('Rainbow Info')
+      ->setName(pht('Rainbow Info'))
       ->setStatusColor(PHUIListItemView::STATUS_WARN);
 
     $details3 = id(new PHUIListItemView())
-      ->setName('Pasta Haiku')
+      ->setName(pht('Pasta Haiku'))
       ->setStatusColor(PHUIListItemView::STATUS_FAIL);
 
     $statustabs = id(new PHUIListView())
@@ -55,28 +56,29 @@ final class PHUIPropertyListExample extends PhabricatorUIExample {
 
 
     $view2 = new PHUIPropertyListView();
-    $view2->addSectionHeader('Colors of the Rainbow');
+    $view2->addSectionHeader(pht('Colors of the Rainbow'));
 
-    $view2->addProperty('R', 'Red');
-    $view2->addProperty('O', 'Orange');
-    $view2->addProperty('Y', 'Yellow');
-    $view2->addProperty('G', 'Green');
-    $view2->addProperty('B', 'Blue');
-    $view2->addProperty('I', 'Indigo');
-    $view2->addProperty('V', 'Violet');
+    $view2->addProperty('R', pht('Red'));
+    $view2->addProperty('O', pht('Orange'));
+    $view2->addProperty('Y', pht('Yellow'));
+    $view2->addProperty('G', pht('Green'));
+    $view2->addProperty('B', pht('Blue'));
+    $view2->addProperty('I', pht('Indigo'));
+    $view2->addProperty('V', pht('Violet'));
 
 
     $view3 = new PHUIPropertyListView();
-    $view3->addSectionHeader('Haiku About Pasta');
+    $view3->addSectionHeader(pht('Haiku About Pasta'));
 
     $view3->addTextContent(
       hsprintf(
-        'this is a pasta<br />'.
-        'haiku. it is very bad.<br />'.
-        'what did you expect?'));
+        '%s<br />%s<br />%s',
+        pht('this is a pasta'),
+        pht('haiku. it is very bad.'),
+        pht('what did you expect?')));
 
     $object_box1 = id(new PHUIObjectBoxView())
-      ->setHeaderText('PHUIPropertyListView Stackered')
+      ->setHeaderText(pht('%s Stackered', 'PHUIPropertyListView'))
       ->addPropertyList($view, $details1)
       ->addPropertyList($view2, $details2)
       ->addPropertyList($view3, $details3);
@@ -85,20 +87,23 @@ final class PHUIPropertyListExample extends PhabricatorUIExample {
 
     $edge_cases_view->addProperty(
       pht('Description'),
-      pht('These layouts test UI edge cases in the element. This block '.
-          'tests wrapping and overflow behavior.'));
+      pht(
+        'These layouts test UI edge cases in the element. This block '.
+        'tests wrapping and overflow behavior.'));
 
     $edge_cases_view->addProperty(
       pht('A Very Very Very Very Very Very Very Very Very Long Property Label'),
-      pht('This property label and property value are quite long. They '.
-          'demonstrate the wrapping behavior of the element, or lack thereof '.
-          'if something terrible has happened.'));
+      pht(
+        'This property label and property value are quite long. They '.
+        'demonstrate the wrapping behavior of the element, or lack thereof '.
+        'if something terrible has happened.'));
 
     $edge_cases_view->addProperty(
       pht('AVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongUnbrokenPropertyLabel'),
-      pht('Thispropertylabelandpropertyvaluearequitelongandhave'.
-          'nospacestheydemonstratetheoverflowbehavioroftheelement'.
-          'orlackthereof.'));
+      pht(
+        'Thispropertylabelandpropertyvaluearequitelongandhave'.
+        'nospacestheydemonstratetheoverflowbehavioroftheelement'.
+        'orlackthereof.'));
 
 
     $edge_cases_view->addProperty(
@@ -122,7 +127,7 @@ final class PHUIPropertyListExample extends PhabricatorUIExample {
       pht('Smith'));
 
     $object_box2 = id(new PHUIObjectBoxView())
-      ->setHeaderText('Some Bad Examples')
+      ->setHeaderText(pht('Some Bad Examples'))
       ->addPropertyList($edge_cases_view);
 
     return array(
diff --git a/src/applications/uiexample/examples/PHUITagExample.php b/src/applications/uiexample/examples/PHUITagExample.php
index 8b96480075..155fe4e9da 100644
--- a/src/applications/uiexample/examples/PHUITagExample.php
+++ b/src/applications/uiexample/examples/PHUITagExample.php
@@ -3,11 +3,13 @@
 final class PHUITagExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Tags';
+    return pht('Tags');
   }
 
   public function getDescription() {
-    return hsprintf('Use <tt>PHUITagView</tt> to render various tags.');
+    return pht(
+      'Use %s to render various tags.',
+      phutil_tag('tt', array(), 'PHUITagView'));
   }
 
   public function renderExample() {
@@ -103,19 +105,19 @@ final class PHUITagExample extends PhabricatorUIExample {
       ->setType(PHUITagView::TYPE_STATE)
       ->setBackgroundColor(PHUITagView::COLOR_GREEN)
       ->setDotColor(PHUITagView::COLOR_RED)
-      ->setName('Christmas');
+      ->setName(pht('Christmas'));
     $tags[] = hsprintf('<br /><br />');
     $tags[] = id(new PHUITagView())
       ->setType(PHUITagView::TYPE_OBJECT)
       ->setBackgroundColor(PHUITagView::COLOR_ORANGE)
       ->setDotColor(PHUITagView::COLOR_BLACK)
-      ->setName('Halloween');
+      ->setName(pht('Halloween'));
     $tags[] = hsprintf('<br /><br />');
     $tags[] = id(new PHUITagView())
       ->setType(PHUITagView::TYPE_STATE)
       ->setBackgroundColor(PHUITagView::COLOR_INDIGO)
       ->setDotColor(PHUITagView::COLOR_YELLOW)
-      ->setName('Easter');
+      ->setName(pht('Easter'));
 
     $content2 = id(new PHUIBoxView())
       ->appendChild($tags)
@@ -126,31 +128,31 @@ final class PHUITagExample extends PhabricatorUIExample {
       ->setType(PHUITagView::TYPE_STATE)
       ->setBackgroundColor(PHUITagView::COLOR_GREEN)
       ->setIcon('fa-check white')
-      ->setName('Passed');
+      ->setName(pht('Passed'));
     $icons[] = hsprintf('<br /><br />');
     $icons[] = id(new PHUITagView())
       ->setType(PHUITagView::TYPE_STATE)
       ->setBackgroundColor(PHUITagView::COLOR_RED)
       ->setIcon('fa-times white')
-      ->setName('Failed');
+      ->setName(pht('Failed'));
     $icons[] = hsprintf('<br /><br />');
     $icons[] = id(new PHUITagView())
       ->setType(PHUITagView::TYPE_STATE)
       ->setBackgroundColor(PHUITagView::COLOR_BLUE)
       ->setIcon('fa-refresh white')
-      ->setName('Running');
+      ->setName(pht('Running'));
     $icons[] = hsprintf('<br /><br />');
     $icons[] = id(new PHUITagView())
       ->setType(PHUITagView::TYPE_STATE)
       ->setBackgroundColor(PHUITagView::COLOR_GREY)
       ->setIcon('fa-pause white')
-      ->setName('Paused');
+      ->setName(pht('Paused'));
     $icons[] = hsprintf('<br /><br />');
     $icons[] = id(new PHUITagView())
       ->setType(PHUITagView::TYPE_STATE)
       ->setBackgroundColor(PHUITagView::COLOR_BLACK)
       ->setIcon('fa-stop white')
-      ->setName('Stopped');
+      ->setName(pht('Stopped'));
 
     $content3 = id(new PHUIBoxView())
       ->appendChild($icons)
@@ -181,23 +183,23 @@ final class PHUITagExample extends PhabricatorUIExample {
       ->addPadding(PHUI::PADDING_LARGE);
 
     $box = id(new PHUIObjectBoxView())
-      ->setHeaderText('Inline')
+      ->setHeaderText(pht('Inline'))
       ->appendChild($intro);
 
     $box1 = id(new PHUIObjectBoxView())
-      ->setHeaderText('Colors')
+      ->setHeaderText(pht('Colors'))
       ->appendChild($content1);
 
     $box2 = id(new PHUIObjectBoxView())
-      ->setHeaderText('Holidays')
+      ->setHeaderText(pht('Holidays'))
       ->appendChild($content2);
 
     $box3 = id(new PHUIObjectBoxView())
-      ->setHeaderText('Icons')
+      ->setHeaderText(pht('Icons'))
       ->appendChild($content3);
 
     $box4 = id(new PHUIObjectBoxView())
-      ->setHeaderText('Shades')
+      ->setHeaderText(pht('Shades'))
       ->appendChild($content4);
 
     return array($box, $box1, $box2, $box3, $box4);
diff --git a/src/applications/uiexample/examples/PHUITextExample.php b/src/applications/uiexample/examples/PHUITextExample.php
index d61c7b9ceb..6ab69b22b6 100644
--- a/src/applications/uiexample/examples/PHUITextExample.php
+++ b/src/applications/uiexample/examples/PHUITextExample.php
@@ -3,28 +3,28 @@
 final class PHUITextExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Text';
+    return pht('Text');
   }
 
   public function getDescription() {
-    return 'Simple styles for displaying text.';
+    return pht('Simple styles for displaying text.');
   }
 
   public function renderExample() {
 
-    $color1 = 'This is RED. ';
-    $color2 = 'This is ORANGE. ';
-    $color3 = 'This is YELLOW. ';
-    $color4 = 'This is GREEN. ';
-    $color5 = 'This is BLUE. ';
-    $color6 = 'This is INDIGO. ';
-    $color7 = 'This is VIOLET. ';
-    $color8 = 'This is WHITE. ';
-    $color9 = 'This is BLACK. ';
+    $color1 = pht('This is RED.');
+    $color2 = pht('This is ORANGE.');
+    $color3 = pht('This is YELLOW.');
+    $color4 = pht('This is GREEN.');
+    $color5 = pht('This is BLUE.');
+    $color6 = pht('This is INDIGO.');
+    $color7 = pht('This is VIOLET.');
+    $color8 = pht('This is WHITE.');
+    $color9 = pht('This is BLACK.');
 
-    $text1 = 'This is BOLD. ';
-    $text2 = 'This is Uppercase. ';
-    $text3 = 'This is Stricken.';
+    $text1 = pht('This is BOLD.');
+    $text2 = pht('This is Uppercase.');
+    $text3 = pht('This is Stricken.');
 
     $content =
       array(
@@ -72,7 +72,7 @@ final class PHUITextExample extends PhabricatorUIExample {
 
     $layout1 = id(new PHUIBoxView())
       ->appendChild($content)
-            ->setBorder(true)
+      ->setBorder(true)
       ->addPadding(PHUI::PADDING_MEDIUM);
 
     $head1 = id(new PHUIHeaderView())
diff --git a/src/applications/uiexample/examples/PHUITimelineExample.php b/src/applications/uiexample/examples/PHUITimelineExample.php
index 0ed81b01a3..33b4fe9752 100644
--- a/src/applications/uiexample/examples/PHUITimelineExample.php
+++ b/src/applications/uiexample/examples/PHUITimelineExample.php
@@ -3,12 +3,13 @@
 final class PHUITimelineExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Timeline View';
+    return pht('Timeline View');
   }
 
   public function getDescription() {
-    return hsprintf(
-      'Use <tt>PHUITimelineView</tt> to comments and transactions.');
+    return pht(
+      'Use %s to comments and transactions.',
+      hsprintf('<tt>PHUITimelineView</tt>'));
   }
 
   public function renderExample() {
@@ -24,23 +25,23 @@ final class PHUITimelineExample extends PhabricatorUIExample {
 
     $events[] = id(new PHUITimelineEventView())
       ->setUserHandle($handle)
-      ->setTitle('A major event.')
-      ->appendChild('This is a major timeline event.');
+      ->setTitle(pht('A major event.'))
+      ->appendChild(pht('This is a major timeline event.'));
 
     $events[] = id(new PHUITimelineEventView())
       ->setUserHandle($handle)
       ->setIcon('fa-heart')
-      ->setTitle('A minor event.');
+      ->setTitle(pht('A minor event.'));
 
     $events[] = id(new PHUITimelineEventView())
       ->setUserHandle($handle)
       ->setIcon('fa-comment')
-      ->appendChild('A major event with no title.');
+      ->appendChild(pht('A major event with no title.'));
 
     $events[] = id(new PHUITimelineEventView())
       ->setUserHandle($handle)
       ->setIcon('fa-star')
-      ->setTitle('Another minor event.');
+      ->setTitle(pht('Another minor event.'));
 
     $events[] = id(new PHUITimelineEventView())
       ->setIcon('fa-trophy')
@@ -54,33 +55,33 @@ final class PHUITimelineExample extends PhabricatorUIExample {
 
     $events[] = id(new PHUITimelineEventView())
       ->setUserHandle($handle)
-      ->setTitle('Major Red Event')
+      ->setTitle(pht('Major Red Event'))
       ->setIcon('fa-heart-o')
-      ->appendChild('This event is red!')
+      ->appendChild(pht('This event is red!'))
       ->setColor(PhabricatorTransactions::COLOR_RED);
 
     $events[] = id(new PHUITimelineEventView())
       ->setUserHandle($handle)
       ->setIcon('fa-female')
-      ->setTitle('Minor Red Event')
+      ->setTitle(pht('Minor Red Event'))
       ->setColor(PhabricatorTransactions::COLOR_RED);
 
     $events[] = id(new PHUITimelineEventView())
       ->setIcon('fa-refresh')
       ->setUserHandle($handle)
-      ->setTitle('Minor Not-Red Event')
+      ->setTitle(pht('Minor Not-Red Event'))
       ->setColor(PhabricatorTransactions::COLOR_GREEN);
 
     $events[] = id(new PHUITimelineEventView())
       ->setUserHandle($handle)
       ->setIcon('fa-calendar-o')
-      ->setTitle('Minor Red Event')
+      ->setTitle(pht('Minor Red Event'))
       ->setColor(PhabricatorTransactions::COLOR_RED);
 
     $events[] = id(new PHUITimelineEventView())
       ->setUserHandle($handle)
       ->setIcon('fa-check')
-      ->setTitle('Historically Important Action')
+      ->setTitle(pht('Historically Important Action'))
       ->setColor(PhabricatorTransactions::COLOR_BLACK)
       ->setReallyMajorEvent(true);
 
@@ -88,8 +89,8 @@ final class PHUITimelineExample extends PhabricatorUIExample {
     $events[] = id(new PHUITimelineEventView())
       ->setUserHandle($handle)
       ->setIcon('fa-circle-o')
-      ->setTitle('Major Green Disagreement Action')
-      ->appendChild('This event is green!')
+      ->setTitle(pht('Major Green Disagreement Action'))
+      ->appendChild(pht('This event is green!'))
       ->setColor(PhabricatorTransactions::COLOR_GREEN);
 
     $events[] = id(new PHUITimelineEventView())
@@ -120,13 +121,13 @@ final class PHUITimelineExample extends PhabricatorUIExample {
 
     $events[] = id(new PHUITimelineEventView())
       ->setUserHandle($handle)
-      ->setTitle('Colorless')
+      ->setTitle(pht('Colorless'))
       ->setIcon('fa-lock');
 
     foreach ($colors as $color) {
       $events[] = id(new PHUITimelineEventView())
         ->setUserHandle($handle)
-        ->setTitle("Color '{$color}'")
+        ->setTitle(pht("Color '%s'", $color))
         ->setIcon('fa-paw')
         ->setColor($color);
     }
diff --git a/src/applications/uiexample/examples/PHUITypeaheadExample.php b/src/applications/uiexample/examples/PHUITypeaheadExample.php
index 810a6cc15e..79f0ed5ea8 100644
--- a/src/applications/uiexample/examples/PHUITypeaheadExample.php
+++ b/src/applications/uiexample/examples/PHUITypeaheadExample.php
@@ -3,7 +3,7 @@
 final class PHUITypeaheadExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Typeaheads';
+    return pht('Typeaheads');
   }
 
   public function getDescription() {
@@ -50,7 +50,7 @@ final class PHUITypeaheadExample extends PhabricatorUIExample {
     $output = array();
 
     $output[] = id(new PHUIObjectBoxView())
-      ->setHeaderText('Tokens')
+      ->setHeaderText(pht('Tokens'))
       ->appendChild($token_list);
 
     return $output;
diff --git a/src/applications/uiexample/examples/PhabricatorAphrontBarUIExample.php b/src/applications/uiexample/examples/PhabricatorAphrontBarUIExample.php
index 6520aab0cf..d28d145ec6 100644
--- a/src/applications/uiexample/examples/PhabricatorAphrontBarUIExample.php
+++ b/src/applications/uiexample/examples/PhabricatorAphrontBarUIExample.php
@@ -3,11 +3,11 @@
 final class PhabricatorAphrontBarUIExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Bars';
+    return pht('Bars');
   }
 
   public function getDescription() {
-    return 'Like fractions, but more horizontal.';
+    return pht('Like fractions, but more horizontal.');
   }
 
   public function renderExample() {
diff --git a/src/applications/uiexample/examples/PhabricatorBarePageUIExample.php b/src/applications/uiexample/examples/PhabricatorBarePageUIExample.php
index d9fe54ddb9..3f377edadd 100644
--- a/src/applications/uiexample/examples/PhabricatorBarePageUIExample.php
+++ b/src/applications/uiexample/examples/PhabricatorBarePageUIExample.php
@@ -3,11 +3,11 @@
 final class PhabricatorBarePageUIExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Bare Page';
+    return pht('Bare Page');
   }
 
   public function getDescription() {
-    return 'This is a bare page.';
+    return pht('This is a bare page.');
   }
 
   public function renderExample() {
diff --git a/src/applications/uiexample/examples/PhabricatorBusyUIExample.php b/src/applications/uiexample/examples/PhabricatorBusyUIExample.php
index bfafe28c89..ab23e5cf79 100644
--- a/src/applications/uiexample/examples/PhabricatorBusyUIExample.php
+++ b/src/applications/uiexample/examples/PhabricatorBusyUIExample.php
@@ -3,11 +3,11 @@
 final class PhabricatorBusyUIExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Busy';
+    return pht('Busy');
   }
 
   public function getDescription() {
-    return 'Busy.';
+    return pht('Busy.');
   }
 
   public function renderExample() {
diff --git a/src/applications/uiexample/examples/PhabricatorGestureUIExample.php b/src/applications/uiexample/examples/PhabricatorGestureUIExample.php
index 4047277159..1adb7dee16 100644
--- a/src/applications/uiexample/examples/PhabricatorGestureUIExample.php
+++ b/src/applications/uiexample/examples/PhabricatorGestureUIExample.php
@@ -3,18 +3,18 @@
 final class PhabricatorGestureUIExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Gestures';
+    return pht('Gestures');
   }
 
   public function getDescription() {
-    return hsprintf(
-      'Use <tt>touchable</tt> to listen for gesture events. Note that you '.
+    return pht(
+      'Use %s to listen for gesture events. Note that you '.
       'must be in device mode for this to work (you can narrow your browser '.
-      'window if you are on a desktop).');
+      'window if you are on a desktop).',
+      phutil_tag('tt', array(), 'touchable'));
   }
 
   public function renderExample() {
-
     $id = celerity_generate_unique_node_id();
 
     Javelin::initBehavior(
diff --git a/src/applications/uiexample/examples/PhabricatorHovercardUIExample.php b/src/applications/uiexample/examples/PhabricatorHovercardUIExample.php
index 0223072399..2f841cdda4 100644
--- a/src/applications/uiexample/examples/PhabricatorHovercardUIExample.php
+++ b/src/applications/uiexample/examples/PhabricatorHovercardUIExample.php
@@ -3,12 +3,13 @@
 final class PhabricatorHovercardUIExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Hovercard';
+    return pht('Hovercard');
   }
 
   public function getDescription() {
-    return hsprintf('Use <tt>PhabricatorHovercardView</tt> to render '.
-      'hovercards. Aren\'t I genius?');
+    return pht(
+      "Use %s to render hovercards. Aren't I genius?",
+      phutil_tag('tt', array(), 'PhabricatorHovercardView'));
   }
 
   public function renderExample() {
@@ -20,9 +21,9 @@ final class PhabricatorHovercardUIExample extends PhabricatorUIExample {
     $diff_handle = $this->createBasicDummyHandle(
       'D123',
       DifferentialRevisionPHIDType::TYPECONST,
-      'Introduce cooler Differential Revisions');
+      pht('Introduce cooler Differential Revisions'));
 
-    $panel = $this->createPanel('Differential Hovercard');
+    $panel = $this->createPanel(pht('Differential Hovercard'));
     $panel->appendChild(id(new PhabricatorHovercardView())
       ->setObjectHandle($diff_handle)
       ->addField(pht('Author'), $user->getUsername())
@@ -34,12 +35,12 @@ final class PhabricatorHovercardUIExample extends PhabricatorUIExample {
     $task_handle = $this->createBasicDummyHandle(
       'T123',
       ManiphestTaskPHIDType::TYPECONST,
-      'Improve Mobile Experience for Phabricator');
+      pht('Improve Mobile Experience for Phabricator'));
 
     $tag = id(new PHUITagView())
       ->setType(PHUITagView::TYPE_STATE)
-      ->setName('Closed, Resolved');
-    $panel = $this->createPanel('Maniphest Hovercard');
+      ->setName(pht('Closed, Resolved'));
+    $panel = $this->createPanel(pht('Maniphest Hovercard'));
     $panel->appendChild(id(new PhabricatorHovercardView())
       ->setObjectHandle($task_handle)
       ->setUser($user)
@@ -56,10 +57,10 @@ final class PhabricatorHovercardUIExample extends PhabricatorUIExample {
       'George Washington');
     $user_handle->setImageURI(
       celerity_get_resource_uri('/rsrc/image/people/washington.png'));
-    $panel = $this->createPanel('Whatevery Hovercard');
+    $panel = $this->createPanel(pht('Whatevery Hovercard'));
     $panel->appendChild(id(new PhabricatorHovercardView())
       ->setObjectHandle($user_handle)
-      ->addField(pht('Status'), 'Available')
+      ->addField(pht('Status'), pht('Available'))
       ->addField(pht('Member since'), '30. February 1750')
       ->addAction(pht('Send a Message'), '/dev/null')
       ->setUser($user));
diff --git a/src/applications/uiexample/examples/PhabricatorListFilterUIExample.php b/src/applications/uiexample/examples/PhabricatorListFilterUIExample.php
index f346baf99b..6c934a3e47 100644
--- a/src/applications/uiexample/examples/PhabricatorListFilterUIExample.php
+++ b/src/applications/uiexample/examples/PhabricatorListFilterUIExample.php
@@ -3,13 +3,14 @@
 final class PhabricatorListFilterUIExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'ListFilter';
+    return pht('ListFilter');
   }
 
   public function getDescription() {
-    return hsprintf(
-      'Use <tt>AphrontListFilterView</tt> to layout controls for filtering '.
-      'and manipulating lists of objects.');
+    return pht(
+      'Use %s to layout controls for filtering '.
+      'and manipulating lists of objects.',
+      phutil_tag('tt', array(), 'AphrontListFilterView'));
   }
 
   public function renderExample() {
@@ -21,10 +22,10 @@ final class PhabricatorListFilterUIExample extends PhabricatorUIExample {
     $form
       ->appendChild(
         id(new AphrontFormTextControl())
-          ->setLabel('Query'))
+          ->setLabel(pht('Query')))
       ->appendChild(
         id(new AphrontFormSubmitControl())
-          ->setValue('Search'));
+          ->setValue(pht('Search')));
 
     $filter->appendChild($form);
 
diff --git a/src/applications/uiexample/examples/PhabricatorMultiColumnUIExample.php b/src/applications/uiexample/examples/PhabricatorMultiColumnUIExample.php
index 53c847d31d..c34eb90289 100644
--- a/src/applications/uiexample/examples/PhabricatorMultiColumnUIExample.php
+++ b/src/applications/uiexample/examples/PhabricatorMultiColumnUIExample.php
@@ -3,12 +3,13 @@
 final class PhabricatorMultiColumnUIExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Multiple Column Layouts';
+    return pht('Multiple Column Layouts');
   }
 
   public function getDescription() {
-    return 'A container good for 1-7 equally spaced columns. '.
-      'Fixed and Fluid layouts.';
+    return pht(
+      'A container good for 1-7 equally spaced columns. '.
+      'Fixed and Fluid layouts.');
   }
 
   public function renderExample() {
@@ -104,27 +105,27 @@ final class PhabricatorMultiColumnUIExample extends PhabricatorUIExample {
       ->setFullWidth(true)
       ->appendChild(
         id(new AphrontFormTextControl())
-        ->setLabel('Name')
-        ->setDisableAutocomplete(true)
+        ->setLabel(pht('Name'))
+        ->setDisableAu4tocomplete(true)
         ->setSigil('name-input'))
       ->appendChild(
         id(new AphrontFormTextControl())
-        ->setLabel('Address')
+        ->setLabel(pht('Address'))
         ->setDisableAutocomplete(true)
         ->setSigil('address-input'))
       ->appendChild(
         id(new AphrontFormTextControl())
-        ->setLabel('City/State')
+        ->setLabel(pht('City/State'))
         ->setDisableAutocomplete(true)
         ->setSigil('city-input'))
       ->appendChild(
         id(new AphrontFormTextControl())
-        ->setLabel('Country')
+        ->setLabel(pht('Country'))
         ->setDisableAutocomplete(true)
         ->setSigil('country-input'))
       ->appendChild(
         id(new AphrontFormTextControl())
-        ->setLabel('Postal Code')
+        ->setLabel(pht('Postal Code'))
         ->setDisableAutocomplete(true)
         ->setSigil('postal-input'));
 
@@ -133,19 +134,19 @@ final class PhabricatorMultiColumnUIExample extends PhabricatorUIExample {
       ->setFullWidth(true)
       ->appendChild(
         id(new AphrontFormTextControl())
-        ->setLabel('Card Number')
+        ->setLabel(pht('Card Number'))
         ->setDisableAutocomplete(true)
         ->setSigil('number-input')
         ->setError(''))
       ->appendChild(
         id(new AphrontFormTextControl())
-        ->setLabel('CVC')
+        ->setLabel(pht('CVC'))
         ->setDisableAutocomplete(true)
         ->setSigil('cvc-input')
         ->setError(''))
       ->appendChild(
         id(new PhortuneMonthYearExpiryControl())
-        ->setLabel('Expiration')
+        ->setLabel(pht('Expiration'))
         ->setUser($user)
         ->setError(''));
 
@@ -154,7 +155,7 @@ final class PhabricatorMultiColumnUIExample extends PhabricatorUIExample {
     $cc_title = pht('Payment Information');
 
     $head6 = id(new PHUIHeaderView())
-      ->setHeader(pht('Let\'s Go Shopping'));
+      ->setHeader(pht("Let's Go Shopping"));
     $layout6 = id(new AphrontMultiColumnView())
       ->addColumn(hsprintf('<h1>%s</h1>%s', $shipping_title, $shipping))
       ->addColumn(hsprintf('<h1>%s</h1>%s', $billing_title, $shipping))
diff --git a/src/applications/uiexample/examples/PhabricatorNotificationUIExample.php b/src/applications/uiexample/examples/PhabricatorNotificationUIExample.php
index c9d0d85e53..1b825693fa 100644
--- a/src/applications/uiexample/examples/PhabricatorNotificationUIExample.php
+++ b/src/applications/uiexample/examples/PhabricatorNotificationUIExample.php
@@ -3,15 +3,16 @@
 final class PhabricatorNotificationUIExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Notifications';
+    return pht('Notifications');
   }
 
   public function getDescription() {
-    return hsprintf('Use <tt>JX.Notification</tt> to create notifications.');
+    return pht(
+      'Use %s to create notifications.',
+      phutil_tag('tt', array(), 'JX.Notification'));
   }
 
   public function renderExample() {
-
     require_celerity_resource('phabricator-notification-css');
     Javelin::initBehavior('phabricator-notification-example');
 
@@ -21,7 +22,7 @@ final class PhabricatorNotificationUIExample extends PhabricatorUIExample {
         'sigil' => 'notification-example',
         'class' => 'button green',
       ),
-      'Show Notification');
+      pht('Show Notification'));
 
     $content = hsprintf('<div style="padding: 1em 3em;">%s</div>', $content);
 
diff --git a/src/applications/uiexample/examples/PhabricatorPagerUIExample.php b/src/applications/uiexample/examples/PhabricatorPagerUIExample.php
index cb5212d046..e2e938a302 100644
--- a/src/applications/uiexample/examples/PhabricatorPagerUIExample.php
+++ b/src/applications/uiexample/examples/PhabricatorPagerUIExample.php
@@ -3,17 +3,17 @@
 final class PhabricatorPagerUIExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Pager';
+    return pht('Pager');
   }
 
   public function getDescription() {
-    return hsprintf(
-      'Use <tt>AphrontPagerView</tt> to create a control which allows '.
-      'users to paginate through large amounts of content.');
+    return pht(
+      'Use %s to create a control which allows '.
+      'users to paginate through large amounts of content.',
+      phutil_tag('tt', array(), 'AphrontPagerView'));
   }
 
   public function renderExample() {
-
     $request = $this->getRequest();
 
     $offset = (int)$request->getInt('offset');
@@ -37,9 +37,10 @@ final class PhabricatorPagerUIExample extends PhabricatorUIExample {
     $panel->appendChild($table);
 
     $panel->appendChild(hsprintf(
-      '<p class="phabricator-ui-example-note">'.
-        'Use <tt>AphrontPagerView</tt> to render a pager element.'.
-      '</p>'));
+      '<p class="phabricator-ui-example-note">%s</p>',
+      pht(
+        'Use %s to render a pager element.',
+        phutil_tag('tt', array(), 'AphrontPagerView'))));
 
     $pager = new AphrontPagerView();
     $pager->setPageSize($page_size);
@@ -49,9 +50,8 @@ final class PhabricatorPagerUIExample extends PhabricatorUIExample {
     $panel->appendChild($pager);
 
     $panel->appendChild(hsprintf(
-      '<p class="phabricator-ui-example-note">'.
-        'You can show more or fewer pages of surrounding context.'.
-      '</p>'));
+      '<p class="phabricator-ui-example-note">%s</p>',
+      pht('You can show more or fewer pages of surrounding context.')));
 
     $many_pages_pager = new AphrontPagerView();
     $many_pages_pager->setPageSize($page_size);
@@ -62,11 +62,12 @@ final class PhabricatorPagerUIExample extends PhabricatorUIExample {
     $panel->appendChild($many_pages_pager);
 
     $panel->appendChild(hsprintf(
-      '<p class="phabricator-ui-example-note">'.
+      '<p class="phabricator-ui-example-note">%s</p>',
+      pht(
         'When it is prohibitively expensive or complex to attain a complete '.
         'count of the items, you can select one extra item and set '.
-        '<tt>hasMorePages(true)</tt> if it exists, creating an inexact pager.'.
-      '</p>'));
+        '%s if it exists, creating an inexact pager.',
+        phutil_tag('tt', array(), 'hasMorePages(true)'))));
 
     $inexact_pager = new AphrontPagerView();
     $inexact_pager->setPageSize($page_size);
diff --git a/src/applications/uiexample/examples/PhabricatorSetupIssueUIExample.php b/src/applications/uiexample/examples/PhabricatorSetupIssueUIExample.php
index a166a3dc8a..e5370d30cf 100644
--- a/src/applications/uiexample/examples/PhabricatorSetupIssueUIExample.php
+++ b/src/applications/uiexample/examples/PhabricatorSetupIssueUIExample.php
@@ -3,11 +3,11 @@
 final class PhabricatorSetupIssueUIExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Setup Issue';
+    return pht('Setup Issue');
   }
 
   public function getDescription() {
-    return 'Setup errors and warnings.';
+    return pht('Setup errors and warnings.');
   }
 
   public function renderExample() {
diff --git a/src/applications/uiexample/examples/PhabricatorSortTableUIExample.php b/src/applications/uiexample/examples/PhabricatorSortTableUIExample.php
index 7ed2cdce2b..7911710815 100644
--- a/src/applications/uiexample/examples/PhabricatorSortTableUIExample.php
+++ b/src/applications/uiexample/examples/PhabricatorSortTableUIExample.php
@@ -3,11 +3,11 @@
 final class PhabricatorSortTableUIExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Sortable Tables';
+    return pht('Sortable Tables');
   }
 
   public function getDescription() {
-    return 'Using sortable tables.';
+    return pht('Using sortable tables.');
   }
 
   public function renderExample() {
@@ -66,11 +66,11 @@ final class PhabricatorSortTableUIExample extends PhabricatorUIExample {
     $table = new AphrontTableView($rows);
     $table->setHeaders(
       array(
-        'Make',
-        'Model',
-        'Year',
-        'Price',
-        'Color',
+        pht('Make'),
+        pht('Model'),
+        pht('Year'),
+        pht('Price'),
+        pht('Color'),
       ));
     $table->setColumnClasses(
       array(
@@ -88,7 +88,7 @@ final class PhabricatorSortTableUIExample extends PhabricatorUIExample {
       $orders);
 
     $panel = new PHUIObjectBoxView();
-    $panel->setHeaderText('Sortable Table of Vehicles');
+    $panel->setHeaderText(pht('Sortable Table of Vehicles'));
     $panel->appendChild($table);
 
     return $panel;
diff --git a/src/applications/uiexample/examples/PhabricatorStatusUIExample.php b/src/applications/uiexample/examples/PhabricatorStatusUIExample.php
index 16961885be..6583bc5848 100644
--- a/src/applications/uiexample/examples/PhabricatorStatusUIExample.php
+++ b/src/applications/uiexample/examples/PhabricatorStatusUIExample.php
@@ -3,16 +3,16 @@
 final class PhabricatorStatusUIExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Status List';
+    return pht('Status List');
   }
 
   public function getDescription() {
-    return hsprintf(
-      'Use <tt>PHUIStatusListView</tt> to show relationships with objects.');
+    return pht(
+      'Use %s to show relationships with objects.',
+      phutil_tag('tt', array(), 'PHUIStatusListView'));
   }
 
   public function renderExample() {
-
     $out = array();
 
     $view = new PHUIStatusListView();
diff --git a/src/applications/uiexample/examples/PhabricatorTooltipUIExample.php b/src/applications/uiexample/examples/PhabricatorTooltipUIExample.php
index d93aa3a094..373161612a 100644
--- a/src/applications/uiexample/examples/PhabricatorTooltipUIExample.php
+++ b/src/applications/uiexample/examples/PhabricatorTooltipUIExample.php
@@ -3,11 +3,13 @@
 final class PhabricatorTooltipUIExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Tooltips';
+    return pht('Tooltips');
   }
 
   public function getDescription() {
-    return hsprintf('Use <tt>JX.Tooltip</tt> to create tooltips.');
+    return pht(
+      'Use %s to create tooltips.',
+      phutil_tag('tt', array(), 'JX.Tooltip'));
   }
 
   public function renderExample() {
diff --git a/src/applications/uiexample/examples/PhabricatorTwoColumnUIExample.php b/src/applications/uiexample/examples/PhabricatorTwoColumnUIExample.php
index a77b068705..fd9b422a26 100644
--- a/src/applications/uiexample/examples/PhabricatorTwoColumnUIExample.php
+++ b/src/applications/uiexample/examples/PhabricatorTwoColumnUIExample.php
@@ -3,11 +3,11 @@
 final class PhabricatorTwoColumnUIExample extends PhabricatorUIExample {
 
   public function getName() {
-    return 'Two Column Layout';
+    return pht('Two Column Layout');
   }
 
   public function getDescription() {
-    return 'Two Column mobile friendly layout';
+    return pht('Two Column mobile friendly layout');
   }
 
   public function renderExample() {
diff --git a/src/applications/uiexample/examples/PhabricatorUIExample.php b/src/applications/uiexample/examples/PhabricatorUIExample.php
index 0afe5447a2..2f2ffe0b55 100644
--- a/src/applications/uiexample/examples/PhabricatorUIExample.php
+++ b/src/applications/uiexample/examples/PhabricatorUIExample.php
@@ -29,10 +29,11 @@ abstract class PhabricatorUIExample {
     if ($fullname) {
       $handle->setFullName($fullname);
     } else {
-      $handle->setFullName(sprintf('%s%d: %s',
-        substr($type, 0, 1),
-        $id,
-        $name));
+      $handle->setFullName(
+        sprintf('%s%d: %s',
+          substr($type, 0, 1),
+          $id,
+          $name));
     }
 
     if ($uri) {
diff --git a/src/applications/xhprof/view/PhabricatorXHProfProfileTopLevelView.php b/src/applications/xhprof/view/PhabricatorXHProfProfileTopLevelView.php
index e332ca4d2f..172e4d3447 100644
--- a/src/applications/xhprof/view/PhabricatorXHProfProfileTopLevelView.php
+++ b/src/applications/xhprof/view/PhabricatorXHProfProfileTopLevelView.php
@@ -89,26 +89,28 @@ final class PhabricatorXHProfProfileTopLevelView
           array(
             'sigil' => 'has-tooltip',
             'meta'  => array(
-              'tip' => pht('Total wall time spent in this function and all of '.
-                       'its children (children are other functions it called '.
-                       'while executing).'),
+              'tip' => pht(
+                'Total wall time spent in this function and all of '.
+                'its children (children are other functions it called '.
+                'while executing).'),
               'size' => 200,
             ),
           ),
-          'Wall Time (Inclusive)'),
+          pht('Wall Time (Inclusive)')),
         '%',
         javelin_tag(
           'span',
           array(
             'sigil' => 'has-tooltip',
             'meta'  => array(
-              'tip' => pht('Wall time spent in this function, excluding time '.
-                       'spent in children (children are other functions it '.
-                       'called while executing).'),
+              'tip' => pht(
+                'Wall time spent in this function, excluding time '.
+                'spent in children (children are other functions it '.
+                'called while executing).'),
               'size' => 200,
             ),
           ),
-          'Wall Time (Exclusive)'),
+          pht('Wall Time (Exclusive)')),
         '%',
       ));
     $table->setColumnClasses(
@@ -128,7 +130,7 @@ final class PhabricatorXHProfProfileTopLevelView
     if ($this->file) {
       $button = id(new PHUIButtonView())
         ->setHref($this->file->getBestURI())
-        ->setText(pht('Download .xhprof Profile'))
+        ->setText(pht('Download %s Profile', '.xhprof'))
         ->setTag('a');
       $header->addActionLink($button);
     }
diff --git a/src/infrastructure/customfield/exception/PhabricatorCustomFieldDataNotAvailableException.php b/src/infrastructure/customfield/exception/PhabricatorCustomFieldDataNotAvailableException.php
index 26141dc506..c1bc74d366 100644
--- a/src/infrastructure/customfield/exception/PhabricatorCustomFieldDataNotAvailableException.php
+++ b/src/infrastructure/customfield/exception/PhabricatorCustomFieldDataNotAvailableException.php
@@ -1,16 +1,15 @@
 <?php
 
-final class PhabricatorCustomFieldDataNotAvailableException
-  extends Exception {
+final class PhabricatorCustomFieldDataNotAvailableException extends Exception {
 
   public function __construct(PhabricatorCustomField $field) {
-    $key = $field->getFieldKey();
-    $name = $field->getFieldName();
-    $class = get_class($field);
-
     parent::__construct(
-      "Custom field '{$name}' (with key '{$key}', of class '{$class}') is ".
-      "attempting to access data which is not available in this context.");
+      pht(
+        "Custom field '%s' (with key '%s', of class '%s') is attempting ".
+        "to access data which is not available in this context.",
+        $field->getFieldName(),
+        $field->getFieldKey(),
+        get_class($field)));
   }
 
 }
diff --git a/src/infrastructure/customfield/exception/PhabricatorCustomFieldNotProxyException.php b/src/infrastructure/customfield/exception/PhabricatorCustomFieldNotProxyException.php
index 585f31c41b..6fd2f93be6 100644
--- a/src/infrastructure/customfield/exception/PhabricatorCustomFieldNotProxyException.php
+++ b/src/infrastructure/customfield/exception/PhabricatorCustomFieldNotProxyException.php
@@ -1,17 +1,18 @@
 <?php
 
-final class PhabricatorCustomFieldNotProxyException
-  extends Exception {
+final class PhabricatorCustomFieldNotProxyException extends Exception {
 
   public function __construct(PhabricatorCustomField $field) {
-    $key = $field->getFieldKey();
-    $name = $field->getFieldName();
-    $class = get_class($field);
-
     parent::__construct(
-      "Custom field '{$name}' (with key '{$key}', of class '{$class}') can ".
-      "not have a proxy set with setProxy(), because it returned false from ".
-      "canSetProxy().");
+      pht(
+        "Custom field '%s' (with key '%s', of class '%s') can not have a ".
+        "proxy set with %s, because it returned %s from %s.",
+        $field->getFieldName(),
+        $field->getFieldKey(),
+        get_class($field),
+        'setProxy()',
+        'false',
+        'canSetProxy()'));
   }
 
 }
diff --git a/src/infrastructure/customfield/field/PhabricatorCustomFieldList.php b/src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
index 15b83928e1..160a618397 100644
--- a/src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
+++ b/src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
@@ -147,8 +147,12 @@ final class PhabricatorCustomFieldList extends Phobject {
           break;
         default:
           throw new Exception(
-            "Unknown field property view style '{$style}'; valid styles are ".
-            "'block' and 'property'.");
+            pht(
+              "Unknown field property view style '%s'; valid styles are ".
+              "'%s' and '%s'.",
+              $style,
+              'block',
+              'property'));
       }
     }
     $fields = $head + $tail;
diff --git a/src/infrastructure/customfield/storage/PhabricatorCustomFieldIndexStorage.php b/src/infrastructure/customfield/storage/PhabricatorCustomFieldIndexStorage.php
index 18024ec175..d16be819f4 100644
--- a/src/infrastructure/customfield/storage/PhabricatorCustomFieldIndexStorage.php
+++ b/src/infrastructure/customfield/storage/PhabricatorCustomFieldIndexStorage.php
@@ -1,7 +1,6 @@
 <?php
 
-abstract class PhabricatorCustomFieldIndexStorage
-  extends PhabricatorLiskDAO {
+abstract class PhabricatorCustomFieldIndexStorage extends PhabricatorLiskDAO {
 
   protected $objectPHID;
   protected $indexKey;
diff --git a/src/infrastructure/daemon/bot/PhabricatorBot.php b/src/infrastructure/daemon/bot/PhabricatorBot.php
index ef949cb9ff..b797677777 100644
--- a/src/infrastructure/daemon/bot/PhabricatorBot.php
+++ b/src/infrastructure/daemon/bot/PhabricatorBot.php
@@ -155,8 +155,12 @@ final class PhabricatorBot extends PhabricatorDaemon {
   public function getConduit() {
     if (empty($this->conduit)) {
       throw new Exception(
-        "This bot is not configured with a Conduit uplink. Set 'conduit.uri', ".
-        "'conduit.user' and 'conduit.cert' in the configuration to connect.");
+        pht(
+          "This bot is not configured with a Conduit uplink. Set '%s', ".
+          "'%s' and '%s' in the configuration to connect.",
+          'conduit.uri',
+          'conduit.user',
+          'conduit.cert'));
     }
     return $this->conduit;
   }
diff --git a/src/infrastructure/daemon/bot/adapter/PhabricatorIRCProtocolAdapter.php b/src/infrastructure/daemon/bot/adapter/PhabricatorIRCProtocolAdapter.php
index eab9c4b8fa..eee4974877 100644
--- a/src/infrastructure/daemon/bot/adapter/PhabricatorIRCProtocolAdapter.php
+++ b/src/infrastructure/daemon/bot/adapter/PhabricatorIRCProtocolAdapter.php
@@ -32,7 +32,9 @@ final class PhabricatorIRCProtocolAdapter extends PhabricatorProtocolAdapter {
 
     if (!preg_match('/^[A-Za-z0-9_`[{}^|\]\\-]+$/', $nick)) {
       throw new Exception(
-        "Nickname '{$nick}' is invalid!");
+        pht(
+          "Nickname '%s' is invalid!",
+          $nick));
     }
 
     $errno = null;
@@ -43,11 +45,11 @@ final class PhabricatorIRCProtocolAdapter extends PhabricatorProtocolAdapter {
       $socket = fsockopen('ssl://'.$server, $port, $errno, $error);
     }
     if (!$socket) {
-      throw new Exception("Failed to connect, #{$errno}: {$error}");
+      throw new Exception(pht('Failed to connect, #%d: %s', $errno, $error));
     }
     $ok = stream_set_blocking($socket, false);
     if (!$ok) {
-      throw new Exception('Failed to set stream nonblocking.');
+      throw new Exception(pht('Failed to set stream nonblocking.'));
     }
 
     $this->socket = $socket;
@@ -76,7 +78,7 @@ final class PhabricatorIRCProtocolAdapter extends PhabricatorProtocolAdapter {
       // was most likely because we were signaled.
       $ok = @stream_select($read, $write, $except, $timeout_sec = 0);
       if ($ok === false) {
-        throw new Exception('stream_select() failed!');
+        throw new Exception(pht('%s failed!', 'stream_select()'));
       }
     }
 
@@ -87,12 +89,12 @@ final class PhabricatorIRCProtocolAdapter extends PhabricatorProtocolAdapter {
         // This indicates the connection was terminated on the other side,
         // just exit via exception and let the overseer restart us after a
         // delay so we can reconnect.
-        throw new Exception('Remote host closed connection.');
+        throw new Exception(pht('Remote host closed connection.'));
       }
       do {
         $data = fread($this->socket, 4096);
         if ($data === false) {
-          throw new Exception('fread() failed!');
+          throw new Exception(pht('%s failed!', 'fread()'));
         } else {
           $messages[] = id(new PhabricatorBotMessage())
             ->setCommand('LOG')
@@ -106,7 +108,7 @@ final class PhabricatorIRCProtocolAdapter extends PhabricatorProtocolAdapter {
       do {
         $len = fwrite($this->socket, $this->writeBuffer);
         if ($len === false) {
-          throw new Exception('fwrite() failed!');
+          throw new Exception(pht('%s failed!', 'fwrite()'));
         } else if ($len === 0) {
           break;
         } else {
@@ -206,7 +208,7 @@ final class PhabricatorIRCProtocolAdapter extends PhabricatorProtocolAdapter {
         }
         $join = $this->getConfig('join');
         if (!$join) {
-          throw new Exception('Not configured to join any channels!');
+          throw new Exception(pht('Not configured to join any channels!'));
         }
         foreach ($join as $channel) {
           $this->write("JOIN {$channel}");
diff --git a/src/infrastructure/daemon/bot/adapter/PhabricatorStreamingProtocolAdapter.php b/src/infrastructure/daemon/bot/adapter/PhabricatorStreamingProtocolAdapter.php
index 6863880c54..52707b1a03 100644
--- a/src/infrastructure/daemon/bot/adapter/PhabricatorStreamingProtocolAdapter.php
+++ b/src/infrastructure/daemon/bot/adapter/PhabricatorStreamingProtocolAdapter.php
@@ -24,7 +24,7 @@ abstract class PhabricatorStreamingProtocolAdapter
 
     // First, join the room
     if (!$rooms) {
-      throw new Exception('Not configured to join any rooms!');
+      throw new Exception(pht('Not configured to join any rooms!'));
     }
 
     $this->readBuffers = array();
@@ -91,7 +91,7 @@ abstract class PhabricatorStreamingProtocolAdapter
     // Check for errors
     if ($status != CURLM_OK) {
       throw new Exception(
-        'Phabricator Bot had a problem reading from stream.');
+        pht('Phabricator Bot had a problem reading from stream.'));
     }
   }
 
@@ -99,7 +99,7 @@ abstract class PhabricatorStreamingProtocolAdapter
     $messages = array();
 
     if (!$this->active) {
-      throw new Exception('Phabricator Bot stopped reading from stream.');
+      throw new Exception(pht('Phabricator Bot stopped reading from stream.'));
     }
 
     // Prod our http request
diff --git a/src/infrastructure/daemon/bot/handler/PhabricatorBotDebugLogHandler.php b/src/infrastructure/daemon/bot/handler/PhabricatorBotDebugLogHandler.php
index 7c2d0b57cb..eb4f9b24a9 100644
--- a/src/infrastructure/daemon/bot/handler/PhabricatorBotDebugLogHandler.php
+++ b/src/infrastructure/daemon/bot/handler/PhabricatorBotDebugLogHandler.php
@@ -1,7 +1,7 @@
 <?php
 
 /**
- * Logs messages to stdout
+ * Logs messages to stdout.
  */
 final class PhabricatorBotDebugLogHandler extends PhabricatorBotHandler {
   public function receiveMessage(PhabricatorBotMessage $message) {
diff --git a/src/infrastructure/daemon/bot/handler/PhabricatorBotHandler.php b/src/infrastructure/daemon/bot/handler/PhabricatorBotHandler.php
index b649d33619..2b41cb63f8 100644
--- a/src/infrastructure/daemon/bot/handler/PhabricatorBotHandler.php
+++ b/src/infrastructure/daemon/bot/handler/PhabricatorBotHandler.php
@@ -48,7 +48,7 @@ abstract class PhabricatorBotHandler {
   public function replyTo(PhabricatorBotMessage $original_message, $body) {
     if ($original_message->getCommand() != 'MESSAGE') {
       throw new Exception(
-        'Handler is trying to reply to something which is not a message!');
+        pht('Handler is trying to reply to something which is not a message!'));
     }
 
     $reply = id(new PhabricatorBotMessage())
diff --git a/src/infrastructure/daemon/bot/handler/PhabricatorBotSymbolHandler.php b/src/infrastructure/daemon/bot/handler/PhabricatorBotSymbolHandler.php
index 48734af94a..2e7ff01bef 100644
--- a/src/infrastructure/daemon/bot/handler/PhabricatorBotSymbolHandler.php
+++ b/src/infrastructure/daemon/bot/handler/PhabricatorBotSymbolHandler.php
@@ -26,7 +26,10 @@ final class PhabricatorBotSymbolHandler extends PhabricatorBotHandler {
         $default_uri = $this->getURI('/diffusion/symbol/'.$symbol.'/');
 
         if (count($results) > 1) {
-          $response = "Multiple symbols named '{$symbol}': {$default_uri}";
+          $response = pht(
+            "Multiple symbols named '%s': %s",
+            $symbol,
+            $default_uri);
         } else if (count($results) == 1) {
           $result = head($results);
           $response =
@@ -35,7 +38,7 @@ final class PhabricatorBotSymbolHandler extends PhabricatorBotHandler {
             '('.$result['language'].'): '.
             nonempty($result['uri'], $default_uri);
         } else {
-          $response = "No symbol '{$symbol}' found anywhere.";
+          $response = pht("No symbol '%s' found anywhere.", $symbol);
         }
 
         $this->replyTo($message, $response);
diff --git a/src/infrastructure/daemon/bot/handler/PhabricatorBotWhatsNewHandler.php b/src/infrastructure/daemon/bot/handler/PhabricatorBotWhatsNewHandler.php
index cc1cda2f77..a7d7ad9051 100644
--- a/src/infrastructure/daemon/bot/handler/PhabricatorBotWhatsNewHandler.php
+++ b/src/infrastructure/daemon/bot/handler/PhabricatorBotWhatsNewHandler.php
@@ -1,7 +1,7 @@
 <?php
 
 /**
- * Responds to "Whats new?" with some recent feed content
+ * Responds to "Whats new?" with some recent feed content.
  */
 final class PhabricatorBotWhatsNewHandler extends PhabricatorBotHandler {
 
diff --git a/src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php b/src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php
index f85f230c95..46027814d2 100644
--- a/src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php
+++ b/src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php
@@ -15,7 +15,7 @@ final class PhabricatorTaskmasterDaemon extends PhabricatorDaemon {
           $id = $task->getID();
           $class = $task->getTaskClass();
 
-          $this->log("Working on task {$id} ({$class})...");
+          $this->log(pht('Working on task %d (%s)...', $id, $class));
 
           $task = $task->executeTask();
           $ex = $task->getExecutionException();
@@ -33,7 +33,7 @@ final class PhabricatorTaskmasterDaemon extends PhabricatorDaemon {
                 $ex);
             }
           } else {
-            $this->log("Task {$id} complete! Moved to archive.");
+            $this->log(pht('Task %s complete! Moved to archive.', $id));
           }
         }
 
diff --git a/src/infrastructure/daemon/workers/__tests__/PhabricatorTestWorker.php b/src/infrastructure/daemon/workers/__tests__/PhabricatorTestWorker.php
index 1b4788a513..86e83acb82 100644
--- a/src/infrastructure/daemon/workers/__tests__/PhabricatorTestWorker.php
+++ b/src/infrastructure/daemon/workers/__tests__/PhabricatorTestWorker.php
@@ -26,10 +26,10 @@ final class PhabricatorTestWorker extends PhabricatorWorker {
   protected function doWork() {
     switch (idx($this->getTaskData(), 'doWork')) {
       case 'fail-temporary':
-        throw new Exception('Temporary failure!');
+        throw new Exception(pht('Temporary failure!'));
       case 'fail-permanent':
         throw new PhabricatorWorkerPermanentFailureException(
-          'Permanent failure!');
+          pht('Permanent failure!'));
       default:
         return;
     }
diff --git a/src/infrastructure/daemon/workers/__tests__/PhabricatorWorkerTestCase.php b/src/infrastructure/daemon/workers/__tests__/PhabricatorWorkerTestCase.php
index 739d135f81..83d2585e18 100644
--- a/src/infrastructure/daemon/workers/__tests__/PhabricatorWorkerTestCase.php
+++ b/src/infrastructure/daemon/workers/__tests__/PhabricatorWorkerTestCase.php
@@ -10,7 +10,7 @@ final class PhabricatorWorkerTestCase extends PhabricatorTestCase {
 
   public function testLeaseTask() {
     $task = $this->scheduleTask();
-    $this->expectNextLease($task, 'Leasing should work.');
+    $this->expectNextLease($task, pht('Leasing should work.'));
   }
 
   public function testMultipleLease() {
@@ -19,7 +19,7 @@ final class PhabricatorWorkerTestCase extends PhabricatorTestCase {
     $this->expectNextLease($task);
     $this->expectNextLease(
       null,
-      'We should not be able to lease a task multiple times.');
+      pht('We should not be able to lease a task multiple times.'));
   }
 
   public function testOldestFirst() {
@@ -28,7 +28,7 @@ final class PhabricatorWorkerTestCase extends PhabricatorTestCase {
 
     $this->expectNextLease(
       $task1,
-      'Older tasks should lease first, all else being equal.');
+      pht('Older tasks should lease first, all else being equal.'));
     $this->expectNextLease($task2);
   }
 
@@ -42,8 +42,9 @@ final class PhabricatorWorkerTestCase extends PhabricatorTestCase {
 
     $this->expectNextLease(
       $task2,
-      'Tasks not previously leased should lease before previously '.
-      'leased tasks.');
+      pht(
+        'Tasks not previously leased should lease before previously '.
+        'leased tasks.'));
     $this->expectNextLease($task1);
   }
 
@@ -156,7 +157,9 @@ final class PhabricatorWorkerTestCase extends PhabricatorTestCase {
 
     $this->expectNextLease(
       $task2,
-      'Tasks which expired earlier should lease first, all else being equal.');
+      pht(
+        'Tasks which expired earlier should lease first, '.
+        'all else being equal.'));
     $this->expectNextLease($task1);
   }
 
@@ -167,10 +170,10 @@ final class PhabricatorWorkerTestCase extends PhabricatorTestCase {
 
     $this->expectNextLease(
       $task3,
-      'Tasks with a lower priority should be scheduled first.');
+      pht('Tasks with a lower priority should be scheduled first.'));
     $this->expectNextLease(
       $task1,
-      'Tasks with the same priority should be FIFO.');
+      pht('Tasks with the same priority should be FIFO.'));
     $this->expectNextLease($task2);
   }
 
diff --git a/src/infrastructure/daemon/workers/clock/PhabricatorMetronomicTriggerClock.php b/src/infrastructure/daemon/workers/clock/PhabricatorMetronomicTriggerClock.php
index 99a7080869..d704211388 100644
--- a/src/infrastructure/daemon/workers/clock/PhabricatorMetronomicTriggerClock.php
+++ b/src/infrastructure/daemon/workers/clock/PhabricatorMetronomicTriggerClock.php
@@ -6,8 +6,7 @@
  *
  * For example, this clock can trigger an event every 30 seconds.
  */
-final class PhabricatorMetronomicTriggerClock
-  extends PhabricatorTriggerClock {
+final class PhabricatorMetronomicTriggerClock extends PhabricatorTriggerClock {
 
   public function validateProperties(array $properties) {
     PhutilTypeSpec::checkMap(
diff --git a/src/infrastructure/daemon/workers/clock/PhabricatorNeverTriggerClock.php b/src/infrastructure/daemon/workers/clock/PhabricatorNeverTriggerClock.php
index 3f809c961e..cbf5be2861 100644
--- a/src/infrastructure/daemon/workers/clock/PhabricatorNeverTriggerClock.php
+++ b/src/infrastructure/daemon/workers/clock/PhabricatorNeverTriggerClock.php
@@ -5,8 +5,7 @@
  *
  * This clock can be used for testing, or to cancel events.
  */
-final class PhabricatorNeverTriggerClock
-  extends PhabricatorTriggerClock {
+final class PhabricatorNeverTriggerClock extends PhabricatorTriggerClock {
 
   public function validateProperties(array $properties) {
     PhutilTypeSpec::checkMap(
diff --git a/src/infrastructure/daemon/workers/management/PhabricatorWorkerTriggerManagementWorkflow.php b/src/infrastructure/daemon/workers/management/PhabricatorWorkerTriggerManagementWorkflow.php
index 6251a8af3f..05eefdd91c 100644
--- a/src/infrastructure/daemon/workers/management/PhabricatorWorkerTriggerManagementWorkflow.php
+++ b/src/infrastructure/daemon/workers/management/PhabricatorWorkerTriggerManagementWorkflow.php
@@ -18,7 +18,7 @@ abstract class PhabricatorWorkerTriggerManagementWorkflow
     $ids = $args->getArg('id');
     if (!$ids) {
       throw new PhutilArgumentUsageException(
-        pht('Use --id to select triggers by ID.'));
+        pht('Use %s to select triggers by ID.', '--id'));
     }
 
     $triggers = id(new PhabricatorWorkerTriggerQuery())
diff --git a/src/infrastructure/daemon/workers/query/PhabricatorWorkerLeaseQuery.php b/src/infrastructure/daemon/workers/query/PhabricatorWorkerLeaseQuery.php
index 07c3460494..bb70f03d88 100644
--- a/src/infrastructure/daemon/workers/query/PhabricatorWorkerLeaseQuery.php
+++ b/src/infrastructure/daemon/workers/query/PhabricatorWorkerLeaseQuery.php
@@ -75,15 +75,17 @@ final class PhabricatorWorkerLeaseQuery extends PhabricatorQuery {
   public function execute() {
     if (!$this->limit) {
       throw new Exception(
-        pht('You must setLimit() when leasing tasks.'));
+        pht('You must %s when leasing tasks.', 'setLimit()'));
     }
 
     if ($this->leased !== false) {
       if (!$this->skipLease) {
         throw new Exception(
           pht(
-            'If you potentially select leased tasks using withLeasedTasks(), '.
-            'you MUST disable lease acquisition by calling setSkipLease().'));
+            'If you potentially select leased tasks using %s, '.
+            'you MUST disable lease acquisition by calling %s.',
+            'withLeasedTasks()',
+            'setSkipLease()'));
       }
     }
 
@@ -224,7 +226,7 @@ final class PhabricatorWorkerLeaseQuery extends PhabricatorQuery {
         $where[] = 'leaseExpires < UNIX_TIMESTAMP()';
         break;
       default:
-        throw new Exception("Unknown phase '{$phase}'!");
+        throw new Exception(pht("Unknown phase '%s'!", $phase));
     }
 
     if ($this->ids !== null) {
@@ -253,7 +255,7 @@ final class PhabricatorWorkerLeaseQuery extends PhabricatorQuery {
         throw new Exception(
           pht(
             'Trying to lease tasks selected in the leased phase! This is '.
-            'intended to be imposssible.'));
+            'intended to be impossible.'));
       case self::PHASE_UNLEASED:
         $where[] = qsprintf($conn_w, 'leaseOwner IS NULL');
         $where[] = qsprintf($conn_w, 'id IN (%Ld)', ipull($rows, 'id'));
@@ -270,7 +272,7 @@ final class PhabricatorWorkerLeaseQuery extends PhabricatorQuery {
         $where[] = qsprintf($conn_w, '(%Q)', implode(' OR ', $in));
         break;
       default:
-        throw new Exception("Unknown phase '{$phase}'!");
+        throw new Exception(pht('Unknown phase "%s"!', $phase));
     }
 
     return $this->formatWhereClause($where);
diff --git a/src/infrastructure/daemon/workers/storage/PhabricatorWorkerActiveTask.php b/src/infrastructure/daemon/workers/storage/PhabricatorWorkerActiveTask.php
index 36ada93a13..0705a27780 100644
--- a/src/infrastructure/daemon/workers/storage/PhabricatorWorkerActiveTask.php
+++ b/src/infrastructure/daemon/workers/storage/PhabricatorWorkerActiveTask.php
@@ -89,24 +89,27 @@ final class PhabricatorWorkerActiveTask extends PhabricatorWorkerTask {
     if ($this->leaseOwner) {
       $current_server_time = $this->serverTime + (time() - $this->localTime);
       if ($current_server_time >= $this->leaseExpires) {
-        $id = $this->getID();
-        $class = $this->getTaskClass();
         throw new Exception(
-          "Trying to update Task {$id} ({$class}) after lease expiration!");
+          pht(
+            'Trying to update Task %d (%s) after lease expiration!',
+            $this->getID(),
+            $this->getTaskClass()));
       }
     }
   }
 
   public function delete() {
     throw new Exception(
-      'Active tasks can not be deleted directly. '.
-      'Use archiveTask() to move tasks to the archive.');
+      pht(
+        'Active tasks can not be deleted directly. '.
+        'Use %s to move tasks to the archive.',
+        'archiveTask()'));
   }
 
   public function archiveTask($result, $duration) {
     if ($this->getID() === null) {
       throw new Exception(
-        "Attempting to archive a task which hasn't been save()d!");
+        pht("Attempting to archive a task which hasn't been saved!"));
     }
 
     $this->checkLease();
@@ -142,10 +145,11 @@ final class PhabricatorWorkerActiveTask extends PhabricatorWorkerTask {
       $maximum_failures = $worker->getMaximumRetryCount();
       if ($maximum_failures !== null) {
         if ($this->getFailureCount() > $maximum_failures) {
-          $id = $this->getID();
           throw new PhabricatorWorkerPermanentFailureException(
-            "Task {$id} has exceeded the maximum number of failures ".
-            "({$maximum_failures}).");
+            pht(
+              'Task % has exceeded the maximum number of failures (%d).',
+              $this->getID(),
+              $maximum_failures));
         }
       }
 
diff --git a/src/infrastructure/daemon/workers/storage/PhabricatorWorkerArchiveTask.php b/src/infrastructure/daemon/workers/storage/PhabricatorWorkerArchiveTask.php
index 5186a005c4..9797373eb7 100644
--- a/src/infrastructure/daemon/workers/storage/PhabricatorWorkerArchiveTask.php
+++ b/src/infrastructure/daemon/workers/storage/PhabricatorWorkerArchiveTask.php
@@ -38,7 +38,7 @@ final class PhabricatorWorkerArchiveTask extends PhabricatorWorkerTask {
 
   public function save() {
     if ($this->getID() === null) {
-      throw new Exception('Trying to archive a task with no ID.');
+      throw new Exception(pht('Trying to archive a task with no ID.'));
     }
 
     $other = new PhabricatorWorkerActiveTask();
diff --git a/src/infrastructure/daemon/workers/storage/PhabricatorWorkerTask.php b/src/infrastructure/daemon/workers/storage/PhabricatorWorkerTask.php
index 77543befb9..3d8c6887c6 100644
--- a/src/infrastructure/daemon/workers/storage/PhabricatorWorkerTask.php
+++ b/src/infrastructure/daemon/workers/storage/PhabricatorWorkerTask.php
@@ -62,12 +62,17 @@ abstract class PhabricatorWorkerTask extends PhabricatorWorkerDAO {
 
     if (!class_exists($class)) {
       throw new PhabricatorWorkerPermanentFailureException(
-        "Task class '{$class}' does not exist!");
+        pht(
+          "Task class '%s' does not exist!",
+          $class));
     }
 
     if (!is_subclass_of($class, 'PhabricatorWorker')) {
       throw new PhabricatorWorkerPermanentFailureException(
-        "Task class '{$class}' does not extend PhabricatorWorker.");
+        pht(
+          "Task class '%s' does not extend %s.",
+          $class,
+          'PhabricatorWorker'));
     }
 
     return newv($class, array($this->getData()));
diff --git a/src/infrastructure/diff/view/PHUIDiffInlineCommentUndoView.php b/src/infrastructure/diff/view/PHUIDiffInlineCommentUndoView.php
index 4d398ca0ce..c4bdd65bf8 100644
--- a/src/infrastructure/diff/view/PHUIDiffInlineCommentUndoView.php
+++ b/src/infrastructure/diff/view/PHUIDiffInlineCommentUndoView.php
@@ -23,7 +23,7 @@ final class PHUIDiffInlineCommentUndoView
       array(
         'class' => 'differential-inline-undo',
       ),
-      array('Changes discarded. ', $link));
+      array(pht('Changes discarded. '), $link));
   }
 
 }
diff --git a/src/infrastructure/edges/constants/PhabricatorEdgeConfig.php b/src/infrastructure/edges/constants/PhabricatorEdgeConfig.php
index b7662353bc..4e256dd5ca 100644
--- a/src/infrastructure/edges/constants/PhabricatorEdgeConfig.php
+++ b/src/infrastructure/edges/constants/PhabricatorEdgeConfig.php
@@ -24,7 +24,9 @@ final class PhabricatorEdgeConfig extends PhabricatorEdgeConstants {
 
     if (!$class) {
       throw new Exception(
-        "Edges are not available for objects of type '{$phid_type}'!");
+        pht(
+          "Edges are not available for objects of type '%s'!",
+          $phid_type));
     }
 
     return newv($class, array())->establishConnection($conn_type);
diff --git a/src/infrastructure/edges/exception/PhabricatorEdgeCycleException.php b/src/infrastructure/edges/exception/PhabricatorEdgeCycleException.php
index 7556405b0e..87ece77e83 100644
--- a/src/infrastructure/edges/exception/PhabricatorEdgeCycleException.php
+++ b/src/infrastructure/edges/exception/PhabricatorEdgeCycleException.php
@@ -12,7 +12,10 @@ final class PhabricatorEdgeCycleException extends Exception {
     $cycle_list = implode(', ', $cycle);
 
     parent::__construct(
-      "Graph cycle detected (type={$cycle_edge_type}, cycle={$cycle_list}).");
+      pht(
+        'Graph cycle detected (type=%s, cycle=%s).',
+        $cycle_edge_type,
+        $cycle_list));
   }
 
   public function getCycle() {
diff --git a/src/infrastructure/edges/query/PhabricatorEdgeQuery.php b/src/infrastructure/edges/query/PhabricatorEdgeQuery.php
index 1323d42e3e..2dfceb7fbc 100644
--- a/src/infrastructure/edges/query/PhabricatorEdgeQuery.php
+++ b/src/infrastructure/edges/query/PhabricatorEdgeQuery.php
@@ -160,7 +160,9 @@ final class PhabricatorEdgeQuery extends PhabricatorQuery {
   public function execute() {
     if (!$this->sourcePHIDs) {
       throw new Exception(
-      'You must use withSourcePHIDs() to query edges.');
+        pht(
+          'You must use %s to query edges.',
+          'withSourcePHIDs()'));
     }
 
     $sources = phid_group_by_type($this->sourcePHIDs);
@@ -256,8 +258,7 @@ final class PhabricatorEdgeQuery extends PhabricatorQuery {
     array $src_phids = array(),
     array $types = array()) {
     if ($this->resultSet === null) {
-      throw new Exception(
-        'You must execute() a query before you you can getDestinationPHIDs().');
+      throw new PhutilInvalidStateException('execute');
     }
 
     $result_phids = array();
diff --git a/src/infrastructure/edges/type/PhabricatorEdgeType.php b/src/infrastructure/edges/type/PhabricatorEdgeType.php
index c485efd987..d62c5a9670 100644
--- a/src/infrastructure/edges/type/PhabricatorEdgeType.php
+++ b/src/infrastructure/edges/type/PhabricatorEdgeType.php
@@ -18,16 +18,20 @@ abstract class PhabricatorEdgeType extends Phobject {
     if ($const === false) {
       throw new Exception(
         pht(
-          'EdgeType class "%s" must define an EDGECONST property.',
-          get_class($this)));
+          '%s class "%s" must define an %s property.',
+          __CLASS__,
+          get_class($this),
+          'EDGECONST'));
     }
 
     if (!is_int($const) || ($const <= 0)) {
       throw new Exception(
         pht(
-          'EdgeType class "%s" has an invalid EDGECONST property. Edge '.
-          'constants must be positive integers.',
-          get_class($this)));
+          '%s class "%s" has an invalid %s property. '.
+          'Edge constants must be positive integers.',
+          __CLASS__,
+          get_class($this),
+          'EDGECONST'));
     }
 
     return $const;
diff --git a/src/infrastructure/edges/util/PhabricatorEdgeGraph.php b/src/infrastructure/edges/util/PhabricatorEdgeGraph.php
index 57b422328e..457b9ec70e 100644
--- a/src/infrastructure/edges/util/PhabricatorEdgeGraph.php
+++ b/src/infrastructure/edges/util/PhabricatorEdgeGraph.php
@@ -11,7 +11,7 @@ final class PhabricatorEdgeGraph extends AbstractDirectedGraph {
 
   protected function loadEdges(array $nodes) {
     if (!$this->edgeType) {
-      throw new Exception('Set edge type before loading graph!');
+      throw new Exception(pht('Set edge type before loading graph!'));
     }
 
     $edges = id(new PhabricatorEdgeQuery())
diff --git a/src/infrastructure/env/PhabricatorConfigFileSource.php b/src/infrastructure/env/PhabricatorConfigFileSource.php
index fa02040c3e..6855a9f0b3 100644
--- a/src/infrastructure/env/PhabricatorConfigFileSource.php
+++ b/src/infrastructure/env/PhabricatorConfigFileSource.php
@@ -2,10 +2,9 @@
 
 /**
  * Configuration source which reads from a configuration file on disk (a
- * PHP file in the conf/ directory). This source
+ * PHP file in the `conf/` directory).
  */
-final class PhabricatorConfigFileSource
-  extends PhabricatorConfigProxySource {
+final class PhabricatorConfigFileSource extends PhabricatorConfigProxySource {
 
   /**
    * @phutil-external-symbol function phabricator_read_config_file
diff --git a/src/infrastructure/env/PhabricatorConfigLocalSource.php b/src/infrastructure/env/PhabricatorConfigLocalSource.php
index 8e3c524061..3a2295eb5e 100644
--- a/src/infrastructure/env/PhabricatorConfigLocalSource.php
+++ b/src/infrastructure/env/PhabricatorConfigLocalSource.php
@@ -1,7 +1,6 @@
 <?php
 
-final class PhabricatorConfigLocalSource
-  extends PhabricatorConfigProxySource {
+final class PhabricatorConfigLocalSource extends PhabricatorConfigProxySource {
 
   public function __construct() {
     $config = $this->loadConfig();
diff --git a/src/infrastructure/env/PhabricatorConfigProxySource.php b/src/infrastructure/env/PhabricatorConfigProxySource.php
index 818b55452b..23e4d0a228 100644
--- a/src/infrastructure/env/PhabricatorConfigProxySource.php
+++ b/src/infrastructure/env/PhabricatorConfigProxySource.php
@@ -10,7 +10,7 @@ abstract class PhabricatorConfigProxySource
 
   final protected function getSource() {
     if (!$this->source) {
-      throw new Exception('No configuration source set!');
+      throw new Exception(pht('No configuration source set!'));
     }
     return $this->source;
   }
diff --git a/src/infrastructure/env/PhabricatorConfigSource.php b/src/infrastructure/env/PhabricatorConfigSource.php
index dd52a18c72..1fbdf2f209 100644
--- a/src/infrastructure/env/PhabricatorConfigSource.php
+++ b/src/infrastructure/env/PhabricatorConfigSource.php
@@ -21,11 +21,13 @@ abstract class PhabricatorConfigSource {
   }
 
   public function setKeys(array $keys) {
-    throw new Exception('This configuration source does not support writes.');
+    throw new Exception(
+      pht('This configuration source does not support writes.'));
   }
 
   public function deleteKeys(array $keys) {
-    throw new Exception('This configuration source does not support writes.');
+    throw new Exception(
+      pht('This configuration source does not support writes.'));
   }
 
 }
diff --git a/src/infrastructure/env/PhabricatorConfigStackSource.php b/src/infrastructure/env/PhabricatorConfigStackSource.php
index a118cf01b8..a8c5113f15 100644
--- a/src/infrastructure/env/PhabricatorConfigStackSource.php
+++ b/src/infrastructure/env/PhabricatorConfigStackSource.php
@@ -19,7 +19,7 @@ final class PhabricatorConfigStackSource
 
   public function popSource() {
     if (empty($this->stack)) {
-      throw new Exception('Popping an empty config stack!');
+      throw new Exception(pht('Popping an empty %s!', __CLASS__));
     }
     return array_shift($this->stack);
   }
diff --git a/src/infrastructure/env/PhabricatorEnv.php b/src/infrastructure/env/PhabricatorEnv.php
index 39f911e3c5..4d1f8ad4a2 100644
--- a/src/infrastructure/env/PhabricatorEnv.php
+++ b/src/infrastructure/env/PhabricatorEnv.php
@@ -389,7 +389,10 @@ final class PhabricatorEnv {
       self::$cache[$key] = $result[$key];
       return $result[$key];
     } else {
-      throw new Exception("No config value specified for key '{$key}'.");
+      throw new Exception(
+        pht(
+          "No config value specified for key '%s'.",
+          $key));
     }
   }
 
@@ -507,7 +510,9 @@ final class PhabricatorEnv {
 
     if (!$base_uri) {
       throw new Exception(
-        "Define 'phabricator.base-uri' in your configuration to continue.");
+        pht(
+          "Define '%s' in your configuration to continue.",
+          'phabricator.base-uri'));
     }
 
     return $base_uri;
@@ -553,8 +558,9 @@ final class PhabricatorEnv {
     if ($stack_key !== $key) {
       self::$sourceStack->pushSource($source);
       throw new Exception(
-        'Scoped environments were destroyed in a diffent order than they '.
-        'were initialized.');
+        pht(
+          'Scoped environments were destroyed in a different order than they '.
+          'were initialized.'));
     }
   }
 
diff --git a/src/infrastructure/env/__tests__/PhabricatorEnvTestCase.php b/src/infrastructure/env/__tests__/PhabricatorEnvTestCase.php
index e363cf2fb1..d47258822b 100644
--- a/src/infrastructure/env/__tests__/PhabricatorEnvTestCase.php
+++ b/src/infrastructure/env/__tests__/PhabricatorEnvTestCase.php
@@ -20,7 +20,7 @@ final class PhabricatorEnvTestCase extends PhabricatorTestCase {
       $this->assertEqual(
         $expect,
         PhabricatorEnv::isValidLocalURIForLink($uri),
-        "Valid local resource: {$uri}");
+        pht('Valid local resource: %s', $uri));
     }
   }
 
@@ -37,7 +37,7 @@ final class PhabricatorEnvTestCase extends PhabricatorTestCase {
       $this->assertEqual(
         $expect,
         PhabricatorEnv::isValidRemoteURIForLink($uri),
-        "Valid linkable remote URI: {$uri}");
+        pht('Valid linkable remote URI: %s', $uri));
     }
   }
 
@@ -78,7 +78,7 @@ final class PhabricatorEnvTestCase extends PhabricatorTestCase {
       $this->assertEqual(
         $expect,
         PhabricatorEnv::isValidRemoteURIForFetch($uri, $protocols),
-        "Valid fetchable remote URI: {$uri}");
+        pht('Valid fetchable remote URI: %s', $uri));
     }
   }
 
@@ -185,8 +185,9 @@ final class PhabricatorEnvTestCase extends PhabricatorTestCase {
 
     $this->assertTrue(
       $caught instanceof Exception,
-      'Destroying a scoped environment which is not on the top of the stack '.
-      'should throw.');
+      pht(
+        'Destroying a scoped environment which is not on the top of the '.
+        'stack should throw.'));
 
     if (phutil_is_hiphop_runtime()) {
       $inner->__destruct();
diff --git a/src/infrastructure/events/PhabricatorEventEngine.php b/src/infrastructure/events/PhabricatorEventEngine.php
index 67807317c6..0cbeb478ac 100644
--- a/src/infrastructure/events/PhabricatorEventEngine.php
+++ b/src/infrastructure/events/PhabricatorEventEngine.php
@@ -23,7 +23,7 @@ final class PhabricatorEventEngine {
       }
     }
 
-    // Add builtin listeners.
+    // Add built-in listeners.
     $listeners[] = new DarkConsoleEventPluginAPI();
 
     // Add application listeners.
diff --git a/src/infrastructure/events/PhabricatorEventListener.php b/src/infrastructure/events/PhabricatorEventListener.php
index abaad375e6..be07500163 100644
--- a/src/infrastructure/events/PhabricatorEventListener.php
+++ b/src/infrastructure/events/PhabricatorEventListener.php
@@ -30,7 +30,7 @@ abstract class PhabricatorEventListener extends PhutilEventListener {
 
   protected function addActionMenuItems(PhutilEvent $event, $items) {
     if ($event->getType() !== PhabricatorEventType::TYPE_UI_DIDRENDERACTIONS) {
-      throw new Exception('Not an action menu event!');
+      throw new Exception(pht('Not an action menu event!'));
     }
 
     if (!$items) {
diff --git a/src/infrastructure/events/PhabricatorExampleEventListener.php b/src/infrastructure/events/PhabricatorExampleEventListener.php
index fb85678da1..3e3353f376 100644
--- a/src/infrastructure/events/PhabricatorExampleEventListener.php
+++ b/src/infrastructure/events/PhabricatorExampleEventListener.php
@@ -23,7 +23,7 @@ final class PhabricatorExampleEventListener extends PhabricatorEventListener {
     $console->writeOut(
       "%s\n",
       pht(
-        '% got test event at %d',
+        '%s got test event at %d',
         __CLASS__,
         $event->getValue('time')));
   }
diff --git a/src/infrastructure/internationalization/translation/PhabricatorBritishEnglishTranslation.php b/src/infrastructure/internationalization/translation/PhabricatorBritishEnglishTranslation.php
index 3361b963b9..530b3aac14 100644
--- a/src/infrastructure/internationalization/translation/PhabricatorBritishEnglishTranslation.php
+++ b/src/infrastructure/internationalization/translation/PhabricatorBritishEnglishTranslation.php
@@ -9,8 +9,8 @@ final class PhabricatorBritishEnglishTranslation
 
   protected function getTranslations() {
     return array(
-      '%s set this project\'s color to %s.' =>
-        '%s set this project\'s colour to %s.',
+      "%s set this project's color to %s." =>
+        "%s set this project's colour to %s.",
       'Basic Colors' =>
         'Basic Colours',
       'Choose Icon and Color...' =>
diff --git a/src/infrastructure/lint/linter/PhabricatorJavelinLinter.php b/src/infrastructure/lint/linter/PhabricatorJavelinLinter.php
index 2cca2030af..d235dc889a 100644
--- a/src/infrastructure/lint/linter/PhabricatorJavelinLinter.php
+++ b/src/infrastructure/lint/linter/PhabricatorJavelinLinter.php
@@ -14,7 +14,7 @@ final class PhabricatorJavelinLinter extends ArcanistLinter {
   const LINT_MISSING_BINARY = 5;
 
   public function getInfoName() {
-    return 'Javelin Linter';
+    return pht('Javelin Linter');
   }
 
   public function getInfoDescription() {
@@ -71,11 +71,16 @@ final class PhabricatorJavelinLinter extends ArcanistLinter {
 
   public function getLintNameMap() {
     return array(
-      self::LINT_PRIVATE_ACCESS => 'Private Method/Member Access',
-      self::LINT_MISSING_DEPENDENCY => 'Missing Javelin Dependency',
-      self::LINT_UNNECESSARY_DEPENDENCY => 'Unnecessary Javelin Dependency',
-      self::LINT_UNKNOWN_DEPENDENCY => 'Unknown Javelin Dependency',
-      self::LINT_MISSING_BINARY => '`javelinsymbols` Not In Path',
+      self::LINT_PRIVATE_ACCESS =>
+        pht('Private Method/Member Access'),
+      self::LINT_MISSING_DEPENDENCY =>
+        pht('Missing Javelin Dependency'),
+      self::LINT_UNNECESSARY_DEPENDENCY =>
+        pht('Unnecessary Javelin Dependency'),
+      self::LINT_UNKNOWN_DEPENDENCY =>
+        pht('Unknown Javelin Dependency'),
+      self::LINT_MISSING_BINARY =>
+        pht('`%s` Not In Path', 'javelinsymbols'),
     );
   }
 
@@ -110,10 +115,12 @@ final class PhabricatorJavelinLinter extends ArcanistLinter {
           1,
           0,
           self::LINT_MISSING_BINARY,
-          "The 'javelinsymbols' binary in the Javelin project is not ".
-          "available in \$PATH, so the Javelin linter can't run. This ".
-          "isn't a big concern, but means some Javelin problems can't be ".
-          "automatically detected.");
+          pht(
+            "The '%s' binary in the Javelin project is not available in %s, ".
+            "so the Javelin linter can't run. This isn't a big concern, ".
+            "but means some Javelin problems can't be automatically detected.",
+            'javelinsymbols',
+            '$PATH'));
       }
       return;
     }
@@ -129,9 +136,11 @@ final class PhabricatorJavelinLinter extends ArcanistLinter {
               $line,
               0,
               self::LINT_PRIVATE_ACCESS,
-              "This file accesses private symbol '{$symbol}' across file ".
-              "boundaries. You may only access private members and methods ".
-              "from the file where they are defined.");
+              pht(
+                "This file accesses private symbol '%s' across file ".
+                "boundaries. You may only access private members and methods ".
+                "from the file where they are defined.",
+                $symbol));
           }
           break;
         }
@@ -169,8 +178,11 @@ final class PhabricatorJavelinLinter extends ArcanistLinter {
           0,
           0,
           self::LINT_UNKNOWN_DEPENDENCY,
-          "This file @requires component '{$requires_symbol}', but it does ".
-          "not exist. You may need to rebuild the Celerity map.");
+          pht(
+            "This file %s component '%s', but it does not exist. ".
+            "You may need to rebuild the Celerity map.",
+            '@requires',
+            $requires_symbol));
         unset($requires[$key]);
         continue;
       }
@@ -194,8 +206,10 @@ final class PhabricatorJavelinLinter extends ArcanistLinter {
         $line,
         0,
         self::LINT_MISSING_DEPENDENCY,
-        "This file uses '{$class}' but does not @requires the component ".
-        "which installs it. You may need to rebuild the Celerity map.");
+        pht(
+          "This file uses '%s' but does not @requires the component ".
+          "which installs it. You may need to rebuild the Celerity map.",
+          $class));
     }
 
     foreach ($requires as $component) {
@@ -203,8 +217,10 @@ final class PhabricatorJavelinLinter extends ArcanistLinter {
         0,
         0,
         self::LINT_UNNECESSARY_DEPENDENCY,
-        "This file @requires component '{$component}' but does not use ".
-        "anything it provides.");
+        pht(
+          "This file %s component '%s' but does not use anything it provides.",
+          '@requires',
+          $component));
     }
   }
 
@@ -237,7 +253,7 @@ final class PhabricatorJavelinLinter extends ArcanistLinter {
       $matches = null;
       if (!preg_match('/^([?+\*])([^:]*):(\d+)$/', $line, $matches)) {
         throw new Exception(
-          'Received malformed output from `javelinsymbols`.');
+          pht('Received malformed output from `%s`.', 'javelinsymbols'));
       }
       $type = $matches[1];
       $symbol = $matches[2];
diff --git a/src/infrastructure/markup/PhabricatorMarkupEngine.php b/src/infrastructure/markup/PhabricatorMarkupEngine.php
index c29dddd821..7083a69738 100644
--- a/src/infrastructure/markup/PhabricatorMarkupEngine.php
+++ b/src/infrastructure/markup/PhabricatorMarkupEngine.php
@@ -190,12 +190,17 @@ final class PhabricatorMarkupEngine {
   private function requireKeyProcessed($key) {
     if (empty($this->objects[$key])) {
       throw new Exception(
-        "Call addObject() before using results (key = '{$key}').");
+        pht(
+          "Call %s before using results (key = '%s').",
+          'addObject()',
+          $key));
     }
 
     if (!isset($this->objects[$key]['output'])) {
       throw new Exception(
-        'Call process() before using results.');
+        pht(
+          'Call %s before using results.',
+          'process()'));
     }
   }
 
@@ -417,7 +422,7 @@ final class PhabricatorMarkupEngine {
         $engine->setConfig('pygments.enabled', false);
         break;
       default:
-        throw new Exception("Unknown engine ruleset: {$ruleset}!");
+        throw new Exception(pht('Unknown engine ruleset: %s!', $ruleset));
     }
 
     $engines[$ruleset] = $engine;
@@ -449,7 +454,6 @@ final class PhabricatorMarkupEngine {
    * @task engine
    */
   public static function newMarkupEngine(array $options) {
-
     $options += self::getMarkupEngineDefaultConfiguration();
 
     $engine = new PhutilRemarkupEngine();
diff --git a/src/infrastructure/markup/interpreter/PhabricatorRemarkupCowsayBlockInterpreter.php b/src/infrastructure/markup/interpreter/PhabricatorRemarkupCowsayBlockInterpreter.php
index 8f3cd3552c..d1c4de1154 100644
--- a/src/infrastructure/markup/interpreter/PhabricatorRemarkupCowsayBlockInterpreter.php
+++ b/src/infrastructure/markup/interpreter/PhabricatorRemarkupCowsayBlockInterpreter.php
@@ -10,7 +10,9 @@ final class PhabricatorRemarkupCowsayBlockInterpreter
   public function markupContent($content, array $argv) {
     if (!Filesystem::binaryExists('cowsay')) {
       return $this->markupError(
-        pht('Unable to locate the `cowsay` binary. Install cowsay.'));
+        pht(
+          'Unable to locate the `%s` binary. Install cowsay.',
+          'cowsay'));
     }
 
     $bin = idx($argv, 'think') ? 'cowthink' : 'cowsay';
diff --git a/src/infrastructure/query/order/PhabricatorQueryOrderItem.php b/src/infrastructure/query/order/PhabricatorQueryOrderItem.php
index a37cb92e04..474b495e48 100644
--- a/src/infrastructure/query/order/PhabricatorQueryOrderItem.php
+++ b/src/infrastructure/query/order/PhabricatorQueryOrderItem.php
@@ -15,8 +15,7 @@
  * This class is primarily internal to the query infrastructure, and most
  * application code should not need to interact with it directly.
  */
-final class PhabricatorQueryOrderItem
-  extends Phobject {
+final class PhabricatorQueryOrderItem extends Phobject {
 
   private $orderKey;
   private $isReversed;
diff --git a/src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php b/src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php
index e1b2028a19..1d8f10b916 100644
--- a/src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php
+++ b/src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php
@@ -172,7 +172,7 @@ abstract class PhabricatorPolicyAwareQuery extends PhabricatorOffsetPagedQuery {
     }
 
     if (count($results) > 1) {
-      throw new Exception('Expected a single result!');
+      throw new Exception(pht('Expected a single result!'));
     }
 
     if (!$results) {
@@ -191,7 +191,7 @@ abstract class PhabricatorPolicyAwareQuery extends PhabricatorOffsetPagedQuery {
    */
   final public function execute() {
     if (!$this->viewer) {
-      throw new Exception('Call setViewer() before execute()!');
+      throw new PhutilInvalidStateException('setViewer');
     }
 
     $parent_query = $this->getParentQuery();
diff --git a/src/infrastructure/sms/management/PhabricatorSMSManagementListOutboundWorkflow.php b/src/infrastructure/sms/management/PhabricatorSMSManagementListOutboundWorkflow.php
index 1597ba928c..5766201667 100644
--- a/src/infrastructure/sms/management/PhabricatorSMSManagementListOutboundWorkflow.php
+++ b/src/infrastructure/sms/management/PhabricatorSMSManagementListOutboundWorkflow.php
@@ -6,17 +6,16 @@ final class PhabricatorSMSManagementListOutboundWorkflow
   protected function didConstruct() {
     $this
       ->setName('list-outbound')
-      ->setSynopsis('List outbound sms messages sent by Phabricator.')
-      ->setExamples(
-        '**list-outbound**')
+      ->setSynopsis(pht('List outbound SMS messages sent by Phabricator.'))
+      ->setExamples('**list-outbound**')
       ->setArguments(
         array(
           array(
             'name'    => 'limit',
             'param'   => 'N',
             'default' => 100,
-            'help'    =>
-              'Show a specific number of sms messages (default 100).',
+            'help'    => pht(
+              'Show a specific number of SMS messages (default 100).'),
           ),
         ));
   }
@@ -30,15 +29,15 @@ final class PhabricatorSMSManagementListOutboundWorkflow
       $args->getArg('limit'));
 
     if (!$sms_messages) {
-      $console->writeErr("%s\n", pht('No sent sms.'));
+      $console->writeErr("%s\n", pht('No sent SMS.'));
       return 0;
     }
 
     $table = id(new PhutilConsoleTable())
       ->setShowHeader(false)
-      ->addColumn('id',     array('title' => 'ID'))
-      ->addColumn('status', array('title' => 'Status'))
-      ->addColumn('recv',   array('title' => 'Recipient'));
+      ->addColumn('id',     array('title' => pht('ID')))
+      ->addColumn('status', array('title' => pht('Status')))
+      ->addColumn('recv',   array('title' => pht('Recipient')));
 
     foreach (array_reverse($sms_messages) as $sms) {
       $table->addRow(array(
diff --git a/src/infrastructure/sms/management/PhabricatorSMSManagementSendTestWorkflow.php b/src/infrastructure/sms/management/PhabricatorSMSManagementSendTestWorkflow.php
index c49f9443a6..7bb4573099 100644
--- a/src/infrastructure/sms/management/PhabricatorSMSManagementSendTestWorkflow.php
+++ b/src/infrastructure/sms/management/PhabricatorSMSManagementSendTestWorkflow.php
@@ -8,22 +8,21 @@ final class PhabricatorSMSManagementSendTestWorkflow
       ->setName('send-test')
       ->setSynopsis(
         pht(
-          'Simulate sending an sms. This may be useful to test your sms '.
-          'configuration, or while developing new sms adapters.'))
-      ->setExamples(
-        "**send-test** --to 12345678 --body 'pizza time yet?'")
+          'Simulate sending an SMS. This may be useful to test your SMS '.
+          'configuration, or while developing new SMS adapters.'))
+      ->setExamples("**send-test** --to 12345678 --body 'pizza time yet?'")
       ->setArguments(
         array(
           array(
             'name'    => 'to',
             'param'   => 'number',
-            'help'    => 'Send sms "To:" the specified number.',
+            'help'    => pht('Send SMS "To:" the specified number.'),
             'repeat'  => true,
           ),
           array(
             'name'    => 'body',
             'param'   => 'text',
-            'help'    => 'Send sms with the specified body.',
+            'help'    => pht('Send SMS with the specified body.'),
           ),
         ));
   }
diff --git a/src/infrastructure/sms/management/PhabricatorSMSManagementShowOutboundWorkflow.php b/src/infrastructure/sms/management/PhabricatorSMSManagementShowOutboundWorkflow.php
index d9bd7e65a0..19a306b6da 100644
--- a/src/infrastructure/sms/management/PhabricatorSMSManagementShowOutboundWorkflow.php
+++ b/src/infrastructure/sms/management/PhabricatorSMSManagementShowOutboundWorkflow.php
@@ -6,7 +6,7 @@ final class PhabricatorSMSManagementShowOutboundWorkflow
   protected function didConstruct() {
     $this
       ->setName('show-outbound')
-      ->setSynopsis('Show diagnostic details about outbound sms.')
+      ->setSynopsis(pht('Show diagnostic details about outbound SMS.'))
       ->setExamples(
         '**show-outbound** --id 1 --id 2')
       ->setArguments(
@@ -14,7 +14,7 @@ final class PhabricatorSMSManagementShowOutboundWorkflow
           array(
             'name'    => 'id',
             'param'   => 'id',
-            'help'    => 'Show details about outbound sms with given ID.',
+            'help'    => pht('Show details about outbound SMS with given ID.'),
             'repeat'  => true,
           ),
         ));
@@ -26,7 +26,9 @@ final class PhabricatorSMSManagementShowOutboundWorkflow
     $ids = $args->getArg('id');
     if (!$ids) {
       throw new PhutilArgumentUsageException(
-        "Use the '--id' flag to specify one or more sms messages to show.");
+        pht(
+          "Use the '%s' flag to specify one or more SMS messages to show.",
+          '--id'));
     }
 
     $messages = id(new PhabricatorSMS())->loadAllWhere(
@@ -38,8 +40,9 @@ final class PhabricatorSMSManagementShowOutboundWorkflow
       $missing = array_diff_key($ids, $messages);
       if ($missing) {
         throw new PhutilArgumentUsageException(
-          'Some specified sms messages do not exist: '.
-          implode(', ', array_keys($missing)));
+          pht(
+            'Some specified SMS messages do not exist: %s',
+            implode(', ', array_keys($missing))));
       }
     }
 
diff --git a/src/infrastructure/sms/worker/PhabricatorSMSDemultiplexWorker.php b/src/infrastructure/sms/worker/PhabricatorSMSDemultiplexWorker.php
index daa5244a10..60baa0dbd8 100644
--- a/src/infrastructure/sms/worker/PhabricatorSMSDemultiplexWorker.php
+++ b/src/infrastructure/sms/worker/PhabricatorSMSDemultiplexWorker.php
@@ -1,7 +1,6 @@
 <?php
 
-final class PhabricatorSMSDemultiplexWorker
-  extends PhabricatorSMSWorker {
+final class PhabricatorSMSDemultiplexWorker extends PhabricatorSMSWorker {
 
   protected function doWork() {
     $viewer = PhabricatorUser::getOmnipotentUser();
diff --git a/src/infrastructure/sms/worker/PhabricatorSMSSendWorker.php b/src/infrastructure/sms/worker/PhabricatorSMSSendWorker.php
index 0ee9aebb77..d7fefe25d0 100644
--- a/src/infrastructure/sms/worker/PhabricatorSMSSendWorker.php
+++ b/src/infrastructure/sms/worker/PhabricatorSMSSendWorker.php
@@ -1,7 +1,6 @@
 <?php
 
-final class PhabricatorSMSSendWorker
-  extends PhabricatorSMSWorker {
+final class PhabricatorSMSSendWorker extends PhabricatorSMSWorker {
 
   public function getMaximumRetryCount() {
     return PhabricatorSMS::MAXIMUM_SEND_TRIES;
@@ -60,8 +59,9 @@ final class PhabricatorSMSSendWorker
       $sms->save();
       throw new PhabricatorWorkerPermanentFailureException(
         pht(
-          'Phabricator is running in silent mode. See `phabricator.silent` '.
-          'in the configuration to change this setting.'));
+          'Phabricator is running in silent mode. See `%s` '.
+          'in the configuration to change this setting.',
+          'phabricator.silent'));
     }
 
     try {
diff --git a/src/infrastructure/ssh/PhabricatorSSHPassthruCommand.php b/src/infrastructure/ssh/PhabricatorSSHPassthruCommand.php
index f27d44660d..9cd9614880 100644
--- a/src/infrastructure/ssh/PhabricatorSSHPassthruCommand.php
+++ b/src/infrastructure/ssh/PhabricatorSSHPassthruCommand.php
@@ -90,15 +90,24 @@ final class PhabricatorSSHPassthruCommand extends Phobject {
     $error_channel = $this->errorChannel;
 
     if (!$command_channel) {
-      throw new Exception('Set a command channel before calling execute()!');
+      throw new Exception(
+        pht(
+          'Set a command channel before calling %s!',
+          __FUNCTION__.'()'));
     }
 
     if (!$io_channel) {
-      throw new Exception('Set an IO channel before calling execute()!');
+      throw new Exception(
+        pht(
+          'Set an IO channel before calling %s!',
+          __FUNCTION__.'()'));
     }
 
     if (!$error_channel) {
-      throw new Exception('Set an error channel before calling execute()!');
+      throw new Exception(
+        pht(
+          'Set an error channel before calling %s!',
+          __FUNCTION__.'()'));
     }
 
     $channels = array($command_channel, $io_channel, $error_channel);
diff --git a/src/infrastructure/storage/__tests__/AphrontIsolatedDatabaseConnectionTestCase.php b/src/infrastructure/storage/__tests__/AphrontIsolatedDatabaseConnectionTestCase.php
index ed3c8560d5..a0a64481bd 100644
--- a/src/infrastructure/storage/__tests__/AphrontIsolatedDatabaseConnectionTestCase.php
+++ b/src/infrastructure/storage/__tests__/AphrontIsolatedDatabaseConnectionTestCase.php
@@ -30,11 +30,11 @@ final class AphrontIsolatedDatabaseConnectionTestCase
     queryfx($conn, 'INSERT');
     $id2 = $conn->getInsertID();
 
-    $this->assertTrue((bool)$id1, 'ID1 exists.');
-    $this->assertTrue((bool)$id2, 'ID2 exists.');
+    $this->assertTrue((bool)$id1, pht('ID1 exists.'));
+    $this->assertTrue((bool)$id2, pht('ID2 exists.'));
     $this->assertTrue(
       $id1 != $id2,
-      "IDs '{$id1}' and '{$id2}' are distinct.");
+      pht("IDs '%s' and '%s' are distinct.", $id1, $id2));
   }
 
   public function testDeletePermitted() {
@@ -133,7 +133,7 @@ final class AphrontIsolatedDatabaseConnectionTestCase
       $this->assertEqual(
         null,
         $row,
-        'Expect fake row to exist only in isolation.');
+        pht('Expect fake row to exist only in isolation.'));
     } catch (AphrontConnectionQueryException $ex) {
       // If we can't connect to the database, conclude that the isolated
       // connection actually is isolated. Philosophically, this perhaps allows
diff --git a/src/infrastructure/storage/__tests__/QueryFormattingTestCase.php b/src/infrastructure/storage/__tests__/QueryFormattingTestCase.php
index 1e2955bbbc..6bd0eeedaf 100644
--- a/src/infrastructure/storage/__tests__/QueryFormattingTestCase.php
+++ b/src/infrastructure/storage/__tests__/QueryFormattingTestCase.php
@@ -25,7 +25,7 @@ final class QueryFormattingTestCase extends PhabricatorTestCase {
     }
     $this->assertTrue(
       (bool)$raised,
-      'qsprintf should raise exception for invalid %d conversion.');
+      pht('%s should raise exception for invalid %%d conversion.', 'qsprintf'));
 
     $this->assertEqual(
       "'<S>'",
diff --git a/src/infrastructure/storage/lisk/LiskDAO.php b/src/infrastructure/storage/lisk/LiskDAO.php
index d21001c0a3..9d8172e02a 100644
--- a/src/infrastructure/storage/lisk/LiskDAO.php
+++ b/src/infrastructure/storage/lisk/LiskDAO.php
@@ -498,7 +498,9 @@ abstract class LiskDAO {
 
     if (count($data) > 1) {
       throw new AphrontCountQueryException(
-        'More than 1 result from loadOneWhere()!');
+        pht(
+          'More than one result from %s!',
+          __FUNCTION__.'()'));
     }
 
     $data = reset($data);
@@ -545,7 +547,8 @@ abstract class LiskDAO {
    */
   public function reload() {
     if (!$this->getID()) {
-      throw new Exception("Unable to reload object that hasn't been loaded!");
+      throw new Exception(
+        pht("Unable to reload object that hasn't been loaded!"));
     }
 
     $result = $this->loadOneWhere(
@@ -809,7 +812,9 @@ abstract class LiskDAO {
 
     if (count($relatives) > 1) {
       throw new AphrontCountQueryException(
-        'More than 1 result from loadOneRelative()!');
+        pht(
+          'More than one result from %s!',
+          __FUNCTION__.'()'));
     }
 
     return reset($relatives);
@@ -954,7 +959,10 @@ abstract class LiskDAO {
    */
   public function establishConnection($mode, $force_new = false) {
     if ($mode != 'r' && $mode != 'w') {
-      throw new Exception("Unknown mode '{$mode}', should be 'r' or 'w'.");
+      throw new Exception(
+        pht(
+          "Unknown mode '%s', should be 'r' or 'w'.",
+          $mode));
     }
 
     if ($this->forcedConnection) {
@@ -1218,7 +1226,7 @@ abstract class LiskDAO {
       case self::IDS_MANUAL:
         break;
       default:
-        throw new Exception('Unknown CONFIG_IDs mechanism!');
+        throw new Exception(pht('Unknown %s mechanism!', 'CONFIG_IDs'));
     }
 
     $this->willWriteData($data);
@@ -1237,7 +1245,7 @@ abstract class LiskDAO {
         throw new PhutilProxyException(
           pht(
             "Unable to insert or update object of class %s, field '%s' ".
-            "has a nonscalar value.",
+            "has a non-scalar value.",
             get_class($this),
             $key),
           $parameter_exception);
@@ -1273,9 +1281,10 @@ abstract class LiskDAO {
 
     if ($key_type == self::IDS_MANUAL) {
       throw new Exception(
-        'You are using manual IDs. You must override the '.
-        'shouldInsertWhenSaved() method to properly detect '.
-        'when to insert a new record.');
+        pht(
+          'You are using manual IDs. You must override the %s method '.
+          'to properly detect when to insert a new record.',
+          __FUNCTION__.'()'));
     } else {
       return !$this->getID();
     }
@@ -1314,8 +1323,9 @@ abstract class LiskDAO {
     $id_key = $this->getIDKey();
     if (!$id_key) {
       throw new Exception(
-        'This DAO does not have a single-part primary key. The method you '.
-        'called requires a single-part primary key.');
+        pht(
+          'This DAO does not have a single-part primary key. The method you '.
+          'called requires a single-part primary key.'));
     }
     return $id_key;
   }
@@ -1330,8 +1340,10 @@ abstract class LiskDAO {
    */
   public function generatePHID() {
     throw new Exception(
-      'To use CONFIG_AUX_PHID, you need to overload '.
-      'generatePHID() to perform PHID generation.');
+      pht(
+        'To use %s, you need to overload %s to perform PHID generation.',
+        'CONFIG_AUX_PHID',
+        'generatePHID()'));
   }
 
 
@@ -1555,7 +1567,7 @@ abstract class LiskDAO {
     self::$processIsolationLevel--;
     if (self::$processIsolationLevel < 0) {
       throw new Exception(
-        'Lisk process isolation level was reduced below 0.');
+        pht('Lisk process isolation level was reduced below 0.'));
     }
   }
 
@@ -1591,7 +1603,7 @@ abstract class LiskDAO {
     self::$transactionIsolationLevel--;
     if (self::$transactionIsolationLevel < 0) {
       throw new Exception(
-        'Lisk transaction isolation level was reduced below 0.');
+        pht('Lisk transaction isolation level was reduced below 0.'));
     } else if (self::$transactionIsolationLevel == 0) {
       foreach (self::$connections as $key => $conn) {
         if ($conn) {
@@ -1643,7 +1655,8 @@ abstract class LiskDAO {
             }
             break;
           default:
-            throw new Exception("Unknown serialization format '{$format}'.");
+            throw new Exception(
+              pht("Unknown serialization format '%s'.", $format));
         }
       }
     }
@@ -1680,11 +1693,11 @@ abstract class LiskDAO {
         $property = $dispatch_map[$method];
       } else {
         if (substr($method, 0, 3) !== 'get') {
-          throw new Exception("Unable to resolve method '{$method}'!");
+          throw new Exception(pht("Unable to resolve method '%s'!", $method));
         }
         $property = substr($method, 3);
         if (!($property = $this->checkProperty($property))) {
-          throw new Exception("Bad getter call: {$method}");
+          throw new Exception(pht('Bad getter call: %s', $method));
         }
         $dispatch_map[$method] = $property;
       }
@@ -1697,12 +1710,12 @@ abstract class LiskDAO {
         $property = $dispatch_map[$method];
       } else {
         if (substr($method, 0, 3) !== 'set') {
-          throw new Exception("Unable to resolve method '{$method}'!");
+          throw new Exception(pht("Unable to resolve method '%s'!", $method));
         }
         $property = substr($method, 3);
         $property = $this->checkProperty($property);
         if (!$property) {
-          throw new Exception("Bad setter call: {$method}");
+          throw new Exception(pht('Bad setter call: %s', $method));
         }
         $dispatch_map[$method] = $property;
       }
@@ -1712,7 +1725,7 @@ abstract class LiskDAO {
       return $this;
     }
 
-    throw new Exception("Unable to resolve method '{$method}'.");
+    throw new Exception(pht("Unable to resolve method '%s'.", $method));
   }
 
   /**
@@ -1721,7 +1734,10 @@ abstract class LiskDAO {
    * @task   util
    */
   public function __set($name, $value) {
-    phlog('Wrote to undeclared property '.get_class($this).'::$'.$name.'.');
+    phlog(
+      pht(
+        'Wrote to undeclared property %s.',
+        get_class($this).'::$'.$name));
     $this->$name = $value;
   }
 
diff --git a/src/infrastructure/storage/lisk/LiskDAOSet.php b/src/infrastructure/storage/lisk/LiskDAOSet.php
index 399aef3687..f81f54f9c9 100644
--- a/src/infrastructure/storage/lisk/LiskDAOSet.php
+++ b/src/infrastructure/storage/lisk/LiskDAOSet.php
@@ -27,7 +27,10 @@ final class LiskDAOSet {
 
   public function addToSet(LiskDAO $dao) {
     if ($this->relatives) {
-      throw new Exception("Don't call addToSet() after loading data!");
+      throw new Exception(
+        pht(
+          "Don't call %s after loading data!",
+          __FUNCTION__.'()'));
     }
     $this->daos[] = $dao;
     $dao->putInSet($this);
diff --git a/src/infrastructure/storage/lisk/PhabricatorDataNotAttachedException.php b/src/infrastructure/storage/lisk/PhabricatorDataNotAttachedException.php
index 7e32428b5e..6f25c4d553 100644
--- a/src/infrastructure/storage/lisk/PhabricatorDataNotAttachedException.php
+++ b/src/infrastructure/storage/lisk/PhabricatorDataNotAttachedException.php
@@ -15,21 +15,21 @@ final class PhabricatorDataNotAttachedException extends Exception {
     if (is_array($frame)) {
       $method = idx($frame, 'function');
       if (preg_match('/^get[A-Z]/', $method)) {
-        $via = " (via {$method}())";
+        $via = ' '.pht('(via %s)', "{$method}()");
       }
     }
 
-    $class = get_class($object);
-
-    $message =
-      "Attempting to access attached data on {$class}{$via}, but the data is ".
-      "not actually attached. Before accessing attachable data on an object, ".
-      "you must load and attach it.\n\n".
-      "Data is normally attached by calling the corresponding needX() ".
-      "method on the Query class when the object is loaded. You can also ".
-      "call the corresponding attachX() method explicitly.";
-
-    parent::__construct($message);
+    parent::__construct(
+      pht(
+        "Attempting to access attached data on %s, but the data is not ".
+        "actually attached. Before accessing attachable data on an object, ".
+        "you must load and attach it.\n\n".
+        "Data is normally attached by calling the corresponding %s method on ".
+        "the Query class when the object is loaded. You can also call the ".
+        "corresponding %s method explicitly.",
+        get_class($object).$via,
+        'needX()',
+        'attachX()'));
   }
 
 }
diff --git a/src/infrastructure/storage/lisk/PhabricatorLiskDAO.php b/src/infrastructure/storage/lisk/PhabricatorLiskDAO.php
index f233fe25e7..534c38b7dc 100644
--- a/src/infrastructure/storage/lisk/PhabricatorLiskDAO.php
+++ b/src/infrastructure/storage/lisk/PhabricatorLiskDAO.php
@@ -42,7 +42,7 @@ abstract class PhabricatorLiskDAO extends LiskDAO {
       $namespace = self::getDefaultStorageNamespace();
     }
     if (!strlen($namespace)) {
-      throw new Exception('No storage namespace configured!');
+      throw new Exception(pht('No storage namespace configured!'));
     }
     return $namespace;
   }
diff --git a/src/infrastructure/storage/lisk/__tests__/LiskFixtureTestCase.php b/src/infrastructure/storage/lisk/__tests__/LiskFixtureTestCase.php
index c4bd744abc..065c23e2ff 100644
--- a/src/infrastructure/storage/lisk/__tests__/LiskFixtureTestCase.php
+++ b/src/infrastructure/storage/lisk/__tests__/LiskFixtureTestCase.php
@@ -67,7 +67,7 @@ final class LiskFixtureTestCase extends PhabricatorTestCase {
 
       $this->assertTrue(
         ($loaded !== null),
-        'Reads inside transactions should have transaction visibility.');
+        pht('Reads inside transactions should have transaction visibility.'));
 
       LiskDAO::beginIsolateAllLiskEffectsToTransactions();
     } catch (Exception $ex) {
diff --git a/src/infrastructure/storage/lisk/__tests__/LiskIsolationTestCase.php b/src/infrastructure/storage/lisk/__tests__/LiskIsolationTestCase.php
index 848dfe7b67..8ff5068505 100644
--- a/src/infrastructure/storage/lisk/__tests__/LiskIsolationTestCase.php
+++ b/src/infrastructure/storage/lisk/__tests__/LiskIsolationTestCase.php
@@ -5,21 +5,21 @@ final class LiskIsolationTestCase extends PhabricatorTestCase {
   public function testIsolatedWrites() {
     $dao = new LiskIsolationTestDAO();
 
-    $this->assertEqual(null, $dao->getID(), 'Expect no ID.');
-    $this->assertEqual(null, $dao->getPHID(), 'Expect no PHID.');
+    $this->assertEqual(null, $dao->getID(), pht('Expect no ID.'));
+    $this->assertEqual(null, $dao->getPHID(), pht('Expect no PHID.'));
 
     $dao->save(); // Effects insert
 
     $id = $dao->getID();
     $phid = $dao->getPHID();
 
-    $this->assertTrue((bool)$id, 'Expect ID generated.');
-    $this->assertTrue((bool)$phid, 'Expect PHID generated.');
+    $this->assertTrue((bool)$id, pht('Expect ID generated.'));
+    $this->assertTrue((bool)$phid, pht('Expect PHID generated.'));
 
     $dao->save(); // Effects update
 
-    $this->assertEqual($id, $dao->getID(), 'Expect ID unchanged.');
-    $this->assertEqual($phid, $dao->getPHID(), 'Expect PHID unchanged.');
+    $this->assertEqual($id, $dao->getID(), pht('Expect ID unchanged.'));
+    $this->assertEqual($phid, $dao->getPHID(), pht('Expect PHID unchanged.'));
   }
 
   public function testEphemeral() {
@@ -50,8 +50,10 @@ final class LiskIsolationTestCase extends PhabricatorTestCase {
       $method->invoke($dao, 'r');
 
       $this->assertFailure(
-        'LiskIsolationTestDAO did not throw an exception when instructed to '.
-        'explicitly connect to an external database.');
+        pht(
+          '%s did not throw an exception when instructed to '.
+          'explicitly connect to an external database.',
+          'LiskIsolationTestDAO'));
     } catch (LiskIsolationTestDAOException $ex) {
       // Expected, pass.
     }
@@ -66,17 +68,17 @@ final class LiskIsolationTestCase extends PhabricatorTestCase {
     $this->assertEqual(
       null,
       $dao->getName(),
-      'getName() on empty object');
+      pht('%s on empty object', 'getName()'));
 
     $this->assertEqual(
       $dao,
       $dao->setName('x'),
-      'setName() returns $this');
+      pht('%s returns %s', 'setName()', '$this'));
 
     $this->assertEqual(
       'y',
       $dao->setName('y')->getName(),
-      'setName() has an effect');
+      pht('%s has an effect', 'setName()'));
 
     $ex = null;
     try {
@@ -86,7 +88,7 @@ final class LiskIsolationTestCase extends PhabricatorTestCase {
     }
     $this->assertTrue(
       (bool)$ex,
-      'Typoing "get" should throw.');
+      pht('Typoing "%s" should throw.', 'get'));
 
     $ex = null;
     try {
@@ -96,7 +98,7 @@ final class LiskIsolationTestCase extends PhabricatorTestCase {
     }
     $this->assertTrue(
       (bool)$ex,
-      'Typoing "set" should throw.');
+      pht('Typoing "%s" should throw.', 'set'));
 
     $ex = null;
     try {
@@ -106,7 +108,7 @@ final class LiskIsolationTestCase extends PhabricatorTestCase {
     }
     $this->assertTrue(
       (bool)$ex,
-      'Made up method should throw.');
+      pht('Made up method should throw.'));
   }
 
 }
diff --git a/src/infrastructure/storage/lisk/__tests__/LiskIsolationTestDAO.php b/src/infrastructure/storage/lisk/__tests__/LiskIsolationTestDAO.php
index 7d5a5d6021..d9070753f8 100644
--- a/src/infrastructure/storage/lisk/__tests__/LiskIsolationTestDAO.php
+++ b/src/infrastructure/storage/lisk/__tests__/LiskIsolationTestDAO.php
@@ -17,8 +17,9 @@ final class LiskIsolationTestDAO extends LiskDAO {
 
   protected function establishLiveConnection($mode) {
     throw new LiskIsolationTestDAOException(
-      'Isolation failure! DAO is attempting to connect to an external '.
-      'resource!');
+      pht(
+        'Isolation failure! DAO is attempting to connect to an external '.
+        'resource!'));
   }
 
   protected function getConnectionNamespace() {
diff --git a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementAdjustWorkflow.php b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementAdjustWorkflow.php
index 8800bfb0e1..e7437a30b9 100644
--- a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementAdjustWorkflow.php
+++ b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementAdjustWorkflow.php
@@ -41,8 +41,9 @@ final class PhabricatorStorageManagementAdjustWorkflow
       throw new PhutilArgumentUsageException(
         pht(
           'You have not initialized the database yet. You must initialize '.
-          'the database before you can adjust schemata. Run `storage upgrade` '.
-          'to initialize the database.'));
+          'the database before you can adjust schemata. Run `%s` '.
+          'to initialize the database.',
+          'storage upgrade'));
     }
 
     $applied = array_fuse($applied);
@@ -56,8 +57,9 @@ final class PhabricatorStorageManagementAdjustWorkflow
         pht(
           'You have not applied all available storage patches yet. You must '.
           'apply all available patches before you can adjust schemata. '.
-          'Run `storage status` to show patch status, and `storage upgrade` '.
-          'to apply missing patches.'));
+          'Run `%s` to show patch status, and `%s` to apply missing patches.',
+          'storage status',
+          'storage upgrade'));
     }
   }
 
diff --git a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDatabasesWorkflow.php b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDatabasesWorkflow.php
index 085ba1c877..5509a32d73 100644
--- a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDatabasesWorkflow.php
+++ b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDatabasesWorkflow.php
@@ -7,7 +7,7 @@ final class PhabricatorStorageManagementDatabasesWorkflow
     $this
       ->setName('databases')
       ->setExamples('**databases** [__options__]')
-      ->setSynopsis('List Phabricator databases.');
+      ->setSynopsis(pht('List Phabricator databases.'));
   }
 
   public function execute(PhutilArgumentParser $args) {
diff --git a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDestroyWorkflow.php b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDestroyWorkflow.php
index 4666494e55..6c1c216359 100644
--- a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDestroyWorkflow.php
+++ b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDestroyWorkflow.php
@@ -7,13 +7,15 @@ final class PhabricatorStorageManagementDestroyWorkflow
     $this
       ->setName('destroy')
       ->setExamples('**destroy** [__options__]')
-      ->setSynopsis('Permanently destroy all storage and data.')
+      ->setSynopsis(pht('Permanently destroy all storage and data.'))
       ->setArguments(
         array(
           array(
             'name'  => 'unittest-fixtures',
-            'help'  => 'Restrict **destroy** operations to databases created '.
-                       'by PhabricatorTestCase test fixtures.',
+            'help'  => pht(
+              'Restrict **destroy** operations to databases created '.
+              'by %s test fixtures.',
+              'PhabricatorTestCase'),
           ),
         ));
   }
@@ -24,17 +26,18 @@ final class PhabricatorStorageManagementDestroyWorkflow
 
     if (!$is_dry && !$is_force) {
       echo phutil_console_wrap(
-        'Are you completely sure you really want to permanently destroy all '.
-        'storage for Phabricator data? This operation can not be undone and '.
-        'your data will not be recoverable if you proceed.');
+        pht(
+          'Are you completely sure you really want to permanently destroy all '.
+          'storage for Phabricator data? This operation can not be undone and '.
+          'your data will not be recoverable if you proceed.'));
 
-      if (!phutil_console_confirm('Permanently destroy all data?')) {
-        echo "Cancelled.\n";
+      if (!phutil_console_confirm(pht('Permanently destroy all data?'))) {
+        echo pht('Cancelled.')."\n";
         exit(1);
       }
 
-      if (!phutil_console_confirm('Really destroy all data forever?')) {
-        echo "Cancelled.\n";
+      if (!phutil_console_confirm(pht('Really destroy all data forever?'))) {
+        echo pht('Cancelled.')."\n";
         exit(1);
       }
     }
@@ -61,9 +64,9 @@ final class PhabricatorStorageManagementDestroyWorkflow
 
     foreach ($databases as $database) {
       if ($is_dry) {
-        echo "DRYRUN: Would drop database '{$database}'.\n";
+        echo pht("DRYRUN: Would drop database '%s'.", $database)."\n";
       } else {
-        echo "Dropping database '{$database}'...\n";
+        echo pht("Dropping database '%s'...", $database)."\n";
         queryfx(
           $api->getConn(null),
           'DROP DATABASE IF EXISTS %T',
@@ -72,7 +75,7 @@ final class PhabricatorStorageManagementDestroyWorkflow
     }
 
     if (!$is_dry) {
-      echo "Storage was destroyed.\n";
+      echo pht('Storage was destroyed.')."\n";
     }
 
     return 0;
diff --git a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php
index 2c975bdece..e9a09bccd1 100644
--- a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php
+++ b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php
@@ -7,7 +7,7 @@ final class PhabricatorStorageManagementDumpWorkflow
     $this
       ->setName('dump')
       ->setExamples('**dump** [__options__]')
-      ->setSynopsis('Dump all data in storage to stdout.');
+      ->setSynopsis(pht('Dump all data in storage to stdout.'));
   }
 
   public function execute(PhutilArgumentParser $args) {
@@ -22,8 +22,9 @@ final class PhabricatorStorageManagementDumpWorkflow
         pht(
           '**Storage Not Initialized**: There is no database storage '.
           'initialized in this storage namespace ("%s"). Use '.
-          '**storage upgrade** to initialize storage.',
-          $namespace));
+          '**%s** to initialize storage.',
+          $namespace,
+          'storage upgrade'));
       return 1;
     }
 
diff --git a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementProbeWorkflow.php b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementProbeWorkflow.php
index 00492f68ac..a4ef562c37 100644
--- a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementProbeWorkflow.php
+++ b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementProbeWorkflow.php
@@ -7,7 +7,7 @@ final class PhabricatorStorageManagementProbeWorkflow
     $this
       ->setName('probe')
       ->setExamples('**probe**')
-      ->setSynopsis('Show approximate table sizes.');
+      ->setSynopsis(pht('Show approximate table sizes.'));
   }
 
   public function execute(PhutilArgumentParser $args) {
diff --git a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementQuickstartWorkflow.php b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementQuickstartWorkflow.php
index b20787c05f..561e01cedd 100644
--- a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementQuickstartWorkflow.php
+++ b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementQuickstartWorkflow.php
@@ -26,7 +26,8 @@ final class PhabricatorStorageManagementQuickstartWorkflow
     if (!$output) {
       throw new PhutilArgumentUsageException(
         pht(
-          'Specify a file to write with `--output`.'));
+          'Specify a file to write with `%s`.',
+          '--output'));
     }
 
     $namespace = 'phabricator_quickstart_'.Filesystem::readRandomCharacters(8);
@@ -95,7 +96,9 @@ final class PhabricatorStorageManagementQuickstartWorkflow
       // If we didn't make any changes, yell about it. We'll produce an invalid
       // dump otherwise.
       throw new PhutilArgumentUsageException(
-        pht('Failed to apply hack to adjust FULLTEXT search column!'));
+        pht(
+          'Failed to apply hack to adjust %s search column!',
+          'FULLTEXT'));
     }
 
     $dump = str_replace(
diff --git a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementShellWorkflow.php b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementShellWorkflow.php
index ffbb018687..58a7c072a3 100644
--- a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementShellWorkflow.php
+++ b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementShellWorkflow.php
@@ -7,7 +7,7 @@ final class PhabricatorStorageManagementShellWorkflow
     $this
       ->setName('shell')
       ->setExamples('**shell** [__options__]')
-      ->setSynopsis('Launch an interactive shell.');
+      ->setSynopsis(pht('Launch an interactive shell.'));
   }
 
   public function execute(PhutilArgumentParser $args) {
diff --git a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementStatusWorkflow.php b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementStatusWorkflow.php
index 8ab341996a..ebff080bd4 100644
--- a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementStatusWorkflow.php
+++ b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementStatusWorkflow.php
@@ -7,7 +7,7 @@ final class PhabricatorStorageManagementStatusWorkflow
     $this
       ->setName('status')
       ->setExamples('**status** [__options__]')
-      ->setSynopsis('Show patch application status.');
+      ->setSynopsis(pht('Show patch application status.'));
   }
 
   public function execute(PhutilArgumentParser $args) {
@@ -18,25 +18,26 @@ final class PhabricatorStorageManagementStatusWorkflow
 
     if ($applied === null) {
       echo phutil_console_format(
-        "**Database Not Initialized**: Run **storage upgrade** to ".
-        "initialize.\n");
+        "**%s**: %s\n",
+        pht('Database Not Initialized'),
+        pht('Run **%s** to initialize.', 'storage upgrade'));
 
       return 1;
     }
 
     $table = id(new PhutilConsoleTable())
       ->setShowHeader(false)
-      ->addColumn('id',     array('title' => 'ID'))
-      ->addColumn('status', array('title' => 'Status'))
-      ->addColumn('type',   array('title' => 'Type'))
-      ->addColumn('name',   array('title' => 'Name'));
+      ->addColumn('id',     array('title' => pht('ID')))
+      ->addColumn('status', array('title' => pht('Status')))
+      ->addColumn('type',   array('title' => pht('Type')))
+      ->addColumn('name',   array('title' => pht('Name')));
 
     foreach ($patches as $patch) {
       $table->addRow(array(
         'id' => $patch->getFullKey(),
         'status' => in_array($patch->getFullKey(), $applied)
-          ? 'Applied'
-          : 'Not Applied',
+          ? pht('Applied')
+          : pht('Not Applied'),
         'type' => $patch->getType(),
         'name' => $patch->getName(),
       ));
diff --git a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementUpgradeWorkflow.php b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementUpgradeWorkflow.php
index 3ce0891315..f6cf6ad473 100644
--- a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementUpgradeWorkflow.php
+++ b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementUpgradeWorkflow.php
@@ -7,7 +7,7 @@ final class PhabricatorStorageManagementUpgradeWorkflow
     $this
       ->setName('upgrade')
       ->setExamples('**upgrade** [__options__]')
-      ->setSynopsis('Upgrade database schemata.')
+      ->setSynopsis(pht('Upgrade database schemata.'))
       ->setArguments(
         array(
           array(
@@ -46,12 +46,14 @@ final class PhabricatorStorageManagementUpgradeWorkflow
 
     if (!$is_dry && !$is_force) {
       echo phutil_console_wrap(
-        'Before running storage upgrades, you should take down the '.
-        'Phabricator web interface and stop any running Phabricator '.
-        'daemons (you can disable this warning with --force).');
+        pht(
+          'Before running storage upgrades, you should take down the '.
+          'Phabricator web interface and stop any running Phabricator '.
+          'daemons (you can disable this warning with %s).',
+          '--force'));
 
-      if (!phutil_console_confirm('Are you ready to continue?')) {
-        echo "Cancelled.\n";
+      if (!phutil_console_confirm(pht('Are you ready to continue?'))) {
+        echo pht('Cancelled.')."\n";
         return 1;
       }
     }
@@ -60,8 +62,12 @@ final class PhabricatorStorageManagementUpgradeWorkflow
     if ($apply_only) {
       if (empty($patches[$apply_only])) {
         throw new PhutilArgumentUsageException(
-          "--apply argument '{$apply_only}' is not a valid patch. Use ".
-          "'storage status' to show patch status.");
+          pht(
+            "%s argument '%s' is not a valid patch. ".
+            "Use '%s' to show patch status.",
+            '--apply',
+            $apply_only,
+            'storage status'));
       }
     }
 
@@ -73,15 +79,17 @@ final class PhabricatorStorageManagementUpgradeWorkflow
     if ($applied === null) {
 
       if ($is_dry) {
-        echo "DRYRUN: Patch metadata storage doesn't exist yet, it would ".
-             "be created.\n";
+        echo pht(
+          "DRYRUN: Patch metadata storage doesn't exist yet, ".
+          "it would be created.\n");
         return 0;
       }
 
       if ($apply_only) {
         throw new PhutilArgumentUsageException(
-          'Storage has not been initialized yet, you must initialize storage '.
-          'before selectively applying patches.');
+          pht(
+            'Storage has not been initialized yet, you must initialize '.
+            'storage before selectively applying patches.'));
         return 1;
       }
 
@@ -103,7 +111,7 @@ final class PhabricatorStorageManagementUpgradeWorkflow
           $api->markPatchApplied($patch);
         }
       } else {
-        echo "Loading quickstart template...\n";
+        echo pht('Loading quickstart template...')."\n";
         $root = dirname(phutil_get_library_root('phabricator'));
         $sql  = $root.'/resources/sql/quickstart.sql';
         $api->applyPatchSQL($sql);
@@ -111,7 +119,7 @@ final class PhabricatorStorageManagementUpgradeWorkflow
     }
 
     if ($init_only) {
-      echo "Storage initialized.\n";
+      echo pht('Storage initialized.')."\n";
       return 0;
     }
 
@@ -127,11 +135,13 @@ final class PhabricatorStorageManagementUpgradeWorkflow
 
         if (!$is_force && !$is_dry) {
           echo phutil_console_wrap(
-            "Patch '{$apply_only}' has already been applied. Are you sure ".
-            "you want to apply it again? This may put your storage in a state ".
-            "that the upgrade scripts can not automatically manage.");
-          if (!phutil_console_confirm('Apply patch again?')) {
-            echo "Cancelled.\n";
+            pht(
+              "Patch '%s' has already been applied. Are you sure you want ".
+              "to apply it again? This may put your storage in a state ".
+              "that the upgrade scripts can not automatically manage.",
+              $apply_only));
+          if (!phutil_console_confirm(pht('Apply patch again?'))) {
+            echo pht('Cancelled.')."\n";
             return 1;
           }
         }
@@ -155,8 +165,11 @@ final class PhabricatorStorageManagementUpgradeWorkflow
         foreach ($patch->getAfter() as $after) {
           if (empty($applied[$after])) {
             if ($apply_only) {
-              echo "Unable to apply patch '{$apply_only}' because it depends ".
-                   "on patch '{$after}', which has not been applied.\n";
+              echo pht(
+                "Unable to apply patch '%s' because it depends ".
+                "on patch '%s', which has not been applied.\n",
+                $apply_only,
+                $after);
               return 1;
             }
             $can_apply = false;
@@ -171,9 +184,9 @@ final class PhabricatorStorageManagementUpgradeWorkflow
         $applied_something = true;
 
         if ($is_dry) {
-          echo "DRYRUN: Would apply patch '{$key}'.\n";
+          echo pht("DRYRUN: Would apply patch '%s'.", $key)."\n";
         } else {
-          echo "Applying patch '{$key}'...\n";
+          echo pht("Applying patch '%s'...", $key)."\n";
           $api->applyPatch($patch);
           if (!$skip_mark) {
             $api->markPatchApplied($key);
@@ -190,7 +203,9 @@ final class PhabricatorStorageManagementUpgradeWorkflow
             'Some patches could not be applied: '.
             implode(', ', array_keys($patches)));
         } else if (!$is_dry && !$apply_only) {
-          echo "Storage is up to date. Use 'storage status' for details.\n";
+          echo pht(
+            "Storage is up to date. Use '%s' for details.\n",
+            'storage status');
         }
         break;
       }
diff --git a/src/infrastructure/storage/patch/PhabricatorSQLPatchList.php b/src/infrastructure/storage/patch/PhabricatorSQLPatchList.php
index 390d591a07..2ab9d528c3 100644
--- a/src/infrastructure/storage/patch/PhabricatorSQLPatchList.php
+++ b/src/infrastructure/storage/patch/PhabricatorSQLPatchList.php
@@ -53,17 +53,24 @@ abstract class PhabricatorSQLPatchList {
       if (isset($seen_namespaces[$namespace])) {
         $prior = $seen_namespaces[$namespace];
         throw new Exception(
-          "PatchList '{$patch_class}' has the same namespace, '{$namespace}', ".
-          "as another patch list class, '{$prior}'. Each patch list MUST have ".
-          "a unique namespace.");
+          pht(
+            "%s '%s' has the same namespace, '%s', as another patch list ".
+            "class, '%s'. Each patch list MUST have a unique namespace.",
+            __CLASS__,
+            $patch_class,
+            $namespace,
+            $prior));
       }
 
       $last_key = null;
       foreach ($patch_list->getPatches() as $key => $patch) {
         if (!is_array($patch)) {
           throw new Exception(
-            "PatchList '{$patch_class}' has a patch '{$key}' which is not ".
-            "an array.");
+            pht(
+              "%s '%s' has a patch '%s' which is not an array.",
+              __CLASS__,
+              $patch_class,
+              $key));
         }
 
         $valid = array(
@@ -77,30 +84,47 @@ abstract class PhabricatorSQLPatchList {
         foreach ($patch as $pkey => $pval) {
           if (empty($valid[$pkey])) {
             throw new Exception(
-              "PatchList '{$patch_class}' has a patch, '{$key}', with an ".
-              "unknown property, '{$pkey}'. Patches must have only valid ".
-              "keys: ".implode(', ', array_keys($valid)).'.');
+              pht(
+                "%s '%s' has a patch, '%s', with an unknown property, '%s'.".
+                "Patches must have only valid keys: %s.",
+                __CLASS__,
+                $patch_class,
+                $key,
+                $pkey,
+                implode(', ', array_keys($valid))));
           }
         }
 
         if (is_numeric($key)) {
           throw new Exception(
-            "PatchList '{$patch_class}' has a patch with a numeric key, ".
-            "'{$key}'. Patches must use string keys.");
+            pht(
+              "%s '%s' has a patch with a numeric key, '%s'. ".
+              "Patches must use string keys.",
+              __CLASS__,
+              $patch_class,
+              $key));
         }
 
         if (strpos($key, ':') !== false) {
           throw new Exception(
-            "PatchList '{$patch_class}' has a patch with a colon in the ".
-            "key name, '{$key}'. Patch keys may not contain colons.");
+            pht(
+              "%s '%s' has a patch with a colon in the key name, '%s'. ".
+              "Patch keys may not contain colons.",
+              __CLASS__,
+              $patch_class,
+              $key));
         }
 
         $full_key = "{$namespace}:{$key}";
 
         if (isset($specs[$full_key])) {
           throw new Exception(
-            "PatchList '{$patch_class}' has a patch '{$key}' which ".
-            "duplicates an existing patch key.");
+            pht(
+              "%s '%s' has a patch '%s' which duplicates an ".
+              "existing patch key.",
+              __CLASS__,
+              $patch_class,
+              $key));
         }
 
         $patch['key']     = $key;
@@ -110,8 +134,10 @@ abstract class PhabricatorSQLPatchList {
         if (isset($patch['legacy'])) {
           if ($namespace != 'phabricator') {
             throw new Exception(
-              "Only patches in the 'phabricator' namespace may contain ".
-              "'legacy' keys.");
+              pht(
+                "Only patches in the '%s' namespace may contain '%s' keys.",
+                'phabricator',
+                'legacy'));
           }
         } else {
           $patch['legacy'] = false;
@@ -120,11 +146,13 @@ abstract class PhabricatorSQLPatchList {
         if (!array_key_exists('after', $patch)) {
           if ($last_key === null) {
             throw new Exception(
-              "Patch '{$full_key}' is missing key 'after', and is the first ".
-              "patch in the patch list '{$patch_class}', so its application ".
-              "order can not be determined implicitly. The first patch in a ".
-              "patch list must list the patch or patches it depends on ".
-              "explicitly.");
+              pht(
+                "Patch '%s' is missing key 'after', and is the first patch ".
+                "in the patch list '%s', so its application order can not be ".
+                "determined implicitly. The first patch in a patch list must ".
+                "list the patch or patches it depends on explicitly.",
+                $full_key,
+                $patch_class));
           } else {
             $patch['after'] = array($last_key);
           }
@@ -140,8 +168,10 @@ abstract class PhabricatorSQLPatchList {
         $type = idx($patch, 'type');
         if (!$type) {
           throw new Exception(
-            "Patch '{$namespace}:{$key}' is missing key 'type'. Every patch ".
-            "must have a type.");
+            pht(
+              "Patch '%s' is missing key '%s'. Every patch must have a type.",
+              "{$namespace}:{$key}",
+              'type'));
         }
 
         switch ($type) {
@@ -151,7 +181,10 @@ abstract class PhabricatorSQLPatchList {
             break;
           default:
             throw new Exception(
-              "Patch '{$namespace}:{$key}' has unknown patch type '{$type}'.");
+              pht(
+                "Patch '%s' has unknown patch type '%s'.",
+                "{$namespace}:{$key}",
+                $type));
         }
 
         $specs[$full_key] = $patch;
@@ -162,8 +195,11 @@ abstract class PhabricatorSQLPatchList {
       foreach ($patch['after'] as $after) {
         if (empty($specs[$after])) {
           throw new Exception(
-            "Patch '{$key}' references nonexistent dependency, '{$after}'. ".
-            "Patches may only depend on patches which actually exist.");
+            pht(
+              "Patch '%s' references nonexistent dependency, '%s'. ".
+              "Patches may only depend on patches which actually exist.",
+              $key,
+              $after));
         }
       }
     }
diff --git a/src/infrastructure/testing/PhabricatorTestCase.php b/src/infrastructure/testing/PhabricatorTestCase.php
index 2545413de9..ad88ca360f 100644
--- a/src/infrastructure/testing/PhabricatorTestCase.php
+++ b/src/infrastructure/testing/PhabricatorTestCase.php
@@ -138,8 +138,10 @@ abstract class PhabricatorTestCase extends PhutilTestCase {
       unset($this->env);
     } catch (Exception $ex) {
       throw new Exception(
-        'Some test called PhabricatorEnv::beginScopedEnv(), but is still '.
-        'holding a reference to the scoped environment!');
+        pht(
+          'Some test called %s, but is still holding '.
+          'a reference to the scoped environment!',
+          'PhabricatorEnv::beginScopedEnv()'));
     }
   }
 
@@ -208,8 +210,9 @@ abstract class PhabricatorTestCase extends PhutilTestCase {
   public static function assertExecutingUnitTests() {
     if (!self::$testsAreRunning) {
       throw new Exception(
-        'Executing test code outside of test execution! This code path can '.
-        'only be run during unit tests.');
+        pht(
+          'Executing test code outside of test execution! This code path can '.
+          'only be run during unit tests.'));
     }
   }
 
diff --git a/src/infrastructure/time/PhabricatorTime.php b/src/infrastructure/time/PhabricatorTime.php
index 03495d8412..e31222cf76 100644
--- a/src/infrastructure/time/PhabricatorTime.php
+++ b/src/infrastructure/time/PhabricatorTime.php
@@ -12,7 +12,7 @@ final class PhabricatorTime {
 
     $ok = date_default_timezone_set($timezone);
     if (!$ok) {
-      throw new Exception("Invalid timezone '{$timezone}'!");
+      throw new Exception(pht("Invalid timezone '%s'!", $timezone));
     }
 
     self::$stack[] = array(
diff --git a/src/infrastructure/util/PhabricatorHash.php b/src/infrastructure/util/PhabricatorHash.php
index df1fbfa08b..00d7cca63c 100644
--- a/src/infrastructure/util/PhabricatorHash.php
+++ b/src/infrastructure/util/PhabricatorHash.php
@@ -17,7 +17,9 @@ final class PhabricatorHash extends Phobject {
 
     if (!$key) {
       throw new Exception(
-        "Set a 'security.hmac-key' in your Phabricator configuration!");
+        pht(
+          "Set a '%s' in your Phabricator configuration!",
+          'security.hmac-key'));
     }
 
     return hash_hmac('sha1', $string, $key);
@@ -31,7 +33,7 @@ final class PhabricatorHash extends Phobject {
   public static function digestPassword(PhutilOpaqueEnvelope $envelope, $salt) {
     $result = $envelope->openEnvelope();
     if (!$result) {
-      throw new Exception('Trying to digest empty password!');
+      throw new Exception(pht('Trying to digest empty password!'));
     }
 
     for ($ii = 0; $ii < 1000; $ii++) {
@@ -100,8 +102,9 @@ final class PhabricatorHash extends Phobject {
     if ($length < $min_length) {
       throw new Exception(
         pht(
-          'Length parameter in digestToLength() must be at least %s, '.
+          'Length parameter in %s must be at least %s, '.
           'but %s was provided.',
+          'digestToLength()',
           new PhutilNumber($min_length),
           new PhutilNumber($length)));
     }
diff --git a/src/infrastructure/util/__tests__/PhabricatorHashTestCase.php b/src/infrastructure/util/__tests__/PhabricatorHashTestCase.php
index 8b33d22f5d..c6839dae09 100644
--- a/src/infrastructure/util/__tests__/PhabricatorHashTestCase.php
+++ b/src/infrastructure/util/__tests__/PhabricatorHashTestCase.php
@@ -14,7 +14,7 @@ final class PhabricatorHashTestCase extends PhabricatorTestCase {
       $this->assertEqual(
         $expect,
         PhabricatorHash::digestForIndex($input),
-        "Input: {$input}");
+        pht('Input: %s', $input));
     }
 
     // Test that the encoding produces 6 bits of entropy per byte.
@@ -35,7 +35,7 @@ final class PhabricatorHashTestCase extends PhabricatorTestCase {
     $this->assertEqual(
       (1 << 6),
       count($seen),
-      "Distinct characters in hash of: {$input}");
+      pht('Distinct characters in hash of: %s', $input));
   }
 
 }
diff --git a/src/infrastructure/util/__tests__/PhabricatorSlugTestCase.php b/src/infrastructure/util/__tests__/PhabricatorSlugTestCase.php
index 3c820a085e..0f96a735e6 100644
--- a/src/infrastructure/util/__tests__/PhabricatorSlugTestCase.php
+++ b/src/infrastructure/util/__tests__/PhabricatorSlugTestCase.php
@@ -40,7 +40,7 @@ final class PhabricatorSlugTestCase extends PhabricatorTestCase {
       $this->assertEqual(
         $normal,
         PhabricatorSlug::normalize($slug),
-        "Normalization of '{$slug}'");
+        pht("Normalization of '%s'", $slug));
     }
   }
 
@@ -55,7 +55,7 @@ final class PhabricatorSlugTestCase extends PhabricatorTestCase {
       $this->assertEqual(
         $ancestry,
         PhabricatorSlug::getAncestry($slug),
-        "Ancestry of '{$slug}'");
+        pht("Ancestry of '%s'", $slug));
     }
   }
 
@@ -71,7 +71,7 @@ final class PhabricatorSlugTestCase extends PhabricatorTestCase {
       $this->assertEqual(
         $depth,
         PhabricatorSlug::getDepth($slug),
-        "Depth of '{$slug}'");
+        pht("Depth of '%s'", $slug));
     }
   }
 }
diff --git a/src/view/__tests__/PhabricatorLocalTimeTestCase.php b/src/view/__tests__/PhabricatorLocalTimeTestCase.php
index 609f725ec2..f9fd31ad9a 100644
--- a/src/view/__tests__/PhabricatorLocalTimeTestCase.php
+++ b/src/view/__tests__/PhabricatorLocalTimeTestCase.php
@@ -12,25 +12,25 @@ final class PhabricatorLocalTimeTestCase extends PhabricatorTestCase {
     $this->assertEqual(
       'Jan 1 2000, 12:00 AM',
       phabricator_datetime(946684800, $utc),
-      'Datetime formatting');
+      pht('Datetime formatting'));
     $this->assertEqual(
       'Jan 1 2000',
       phabricator_date(946684800, $utc),
-      'Date formatting');
+      pht('Date formatting'));
     $this->assertEqual(
       '12:00 AM',
       phabricator_time(946684800, $utc),
-      'Time formatting');
+      pht('Time formatting'));
 
     $this->assertEqual(
       'Dec 31 1999, 4:00 PM',
       phabricator_datetime(946684800, $user),
-      'Localization');
+      pht('Localization'));
 
     $this->assertEqual(
       '',
       phabricator_datetime(0, $user),
-      'Missing epoch should fail gracefully');
+      pht('Missing epoch should fail gracefully'));
   }
 
 }
diff --git a/src/view/form/PHUIFormPageView.php b/src/view/form/PHUIFormPageView.php
index 7b45edb255..cb62d33127 100644
--- a/src/view/form/PHUIFormPageView.php
+++ b/src/view/form/PHUIFormPageView.php
@@ -85,12 +85,12 @@ class PHUIFormPageView extends AphrontView {
     $name = $control->getName();
 
     if (!strlen($name)) {
-      throw new Exception('Form control has no name!');
+      throw new Exception(pht('Form control has no name!'));
     }
 
     if (isset($this->controls[$name])) {
       throw new Exception(
-        "Form page contains duplicate control with name '{$name}'!");
+        pht("Form page contains duplicate control with name '%s'!", $name));
     }
 
     $this->controls[$name] = $control;
@@ -106,7 +106,7 @@ class PHUIFormPageView extends AphrontView {
 
   public function getControl($name) {
     if (empty($this->controls[$name])) {
-      throw new Exception("No page control '{$name}'!");
+      throw new Exception(pht("No page control '%s'!", $name));
     }
     return $this->controls[$name];
   }
@@ -117,7 +117,7 @@ class PHUIFormPageView extends AphrontView {
 
   public function setPagedFormView(PHUIPagedFormView $view, $key) {
     if ($this->key) {
-      throw new Exception('This page is already part of a form!');
+      throw new Exception(pht('This page is already part of a form!'));
     }
     $this->form = $view;
     $this->key = $key;
diff --git a/src/view/form/PHUIPagedFormView.php b/src/view/form/PHUIPagedFormView.php
index ff72f67ca0..b5f6ad7066 100644
--- a/src/view/form/PHUIPagedFormView.php
+++ b/src/view/form/PHUIPagedFormView.php
@@ -27,7 +27,7 @@ final class PHUIPagedFormView extends AphrontView {
    */
   public function addPage($key, PHUIFormPageView $page) {
     if (isset($this->pages[$key])) {
-      throw new Exception("Duplicate page with key '{$key}'!");
+      throw new Exception(pht("Duplicate page with key '%s'!", $key));
     }
     $this->pages[$key] = $page;
     $page->setPagedFormView($this, $key);
@@ -44,7 +44,7 @@ final class PHUIPagedFormView extends AphrontView {
    */
   public function getPage($key) {
     if (!$this->pageExists($key)) {
-      throw new Exception("No page '{$key}' exists!");
+      throw new Exception(pht("No page '%s' exists!", $key));
     }
     return $this->pages[$key];
   }
@@ -87,7 +87,7 @@ final class PHUIPagedFormView extends AphrontView {
       $index--;
     }
 
-    throw new Exception("Requesting out-of-bounds page '{$index}'.");
+    throw new Exception(pht("Requesting out-of-bounds page '%s'.", $index));
   }
 
   protected function getLastIndex() {
@@ -226,7 +226,7 @@ final class PHUIPagedFormView extends AphrontView {
 
     $selected_page = $this->getSelectedPage();
     if (!$selected_page) {
-      throw new Exception('No selected page!');
+      throw new Exception(pht('No selected page!'));
     }
 
     $form->addHiddenInput(
@@ -256,7 +256,7 @@ final class PHUIPagedFormView extends AphrontView {
     if ($this->isLastPage($selected_page)) {
       $submit->addSubmitButton(pht('Save'));
     } else {
-      $submit->addSubmitButton(pht("Continue \xC2\xBB"));
+      $submit->addSubmitButton(pht('Continue')." \xC2\xBB");
     }
 
     $form->appendChild($selected_page);
diff --git a/src/view/form/control/AphrontFormCheckboxControl.php b/src/view/form/control/AphrontFormCheckboxControl.php
index 0d89e0a6ad..69be93ab9f 100644
--- a/src/view/form/control/AphrontFormCheckboxControl.php
+++ b/src/view/form/control/AphrontFormCheckboxControl.php
@@ -15,7 +15,7 @@ final class AphrontFormCheckboxControl extends AphrontFormControl {
       'value'   => $value,
       'label'   => $label,
       'checked' => $checked,
-      'id' => $id,
+      'id'      => $id,
     );
     return $this;
   }
diff --git a/src/view/form/control/AphrontFormControl.php b/src/view/form/control/AphrontFormControl.php
index 4118d9ad4e..16e36be663 100644
--- a/src/view/form/control/AphrontFormControl.php
+++ b/src/view/form/control/AphrontFormControl.php
@@ -134,7 +134,7 @@ abstract class AphrontFormControl extends AphrontView {
 
   public function setFormPage(PHUIFormPageView $page) {
     if ($this->formPage) {
-      throw new Exception('This control is already a member of a page!');
+      throw new Exception(pht('This control is already a member of a page!'));
     }
     $this->formPage = $page;
     return $this;
@@ -142,7 +142,7 @@ abstract class AphrontFormControl extends AphrontView {
 
   public function getFormPage() {
     if ($this->formPage === null) {
-      throw new Exception('This control does not have a page!');
+      throw new Exception(pht('This control does not have a page!'));
     }
     return $this->formPage;
   }
diff --git a/src/view/form/control/AphrontFormDateControl.php b/src/view/form/control/AphrontFormDateControl.php
index 2615c1c5ee..d829a29093 100644
--- a/src/view/form/control/AphrontFormDateControl.php
+++ b/src/view/form/control/AphrontFormDateControl.php
@@ -344,7 +344,7 @@ final class AphrontFormDateControl extends AphrontFormControl {
 
     $user = $this->getUser();
     if (!$this->getUser()) {
-      throw new Exception('Call setUser() before getTimezone()!');
+      throw new PhutilInvalidStateException('setUser');
     }
 
     $user_zone = $user->getTimezoneIdentifier();
diff --git a/src/view/form/control/AphrontFormPasswordControl.php b/src/view/form/control/AphrontFormPasswordControl.php
index 9e37d7aa20..081628c332 100644
--- a/src/view/form/control/AphrontFormPasswordControl.php
+++ b/src/view/form/control/AphrontFormPasswordControl.php
@@ -17,12 +17,12 @@ final class AphrontFormPasswordControl extends AphrontFormControl {
     return phutil_tag(
       'input',
       array(
-        'type'      => 'password',
-        'name'      => $this->getName(),
-        'value'     => $this->getValue(),
-        'disabled'  => $this->getDisabled() ? 'disabled' : null,
+        'type'         => 'password',
+        'name'         => $this->getName(),
+        'value'        => $this->getValue(),
+        'disabled'     => $this->getDisabled() ? 'disabled' : null,
         'autocomplete' => ($this->disableAutocomplete ? 'off' : null),
-        'id'        => $this->getID(),
+        'id'           => $this->getID(),
       ));
   }
 
diff --git a/src/view/form/control/PHUIFormMultiSubmitControl.php b/src/view/form/control/PHUIFormMultiSubmitControl.php
index af234919d8..4c7454bd6d 100644
--- a/src/view/form/control/PHUIFormMultiSubmitControl.php
+++ b/src/view/form/control/PHUIFormMultiSubmitControl.php
@@ -6,7 +6,7 @@ final class PHUIFormMultiSubmitControl extends AphrontFormControl {
 
   public function addBackButton($label = null) {
     if ($label === null) {
-      $label = pht("\xC2\xAB Back");
+      $label = "\xC2\xAB ".pht('Back');
     }
     return $this->addButton('__back__', $label, 'grey');
   }
diff --git a/src/view/layout/AphrontMoreView.php b/src/view/layout/AphrontMoreView.php
index 0bd1b82d80..9fe9389ed5 100644
--- a/src/view/layout/AphrontMoreView.php
+++ b/src/view/layout/AphrontMoreView.php
@@ -27,7 +27,7 @@ final class AphrontMoreView extends AphrontView {
     $content[] = $this->some;
 
     if ($this->more && $this->more != $this->some) {
-      $text = "(Show More\xE2\x80\xA6)";
+      $text = "(".pht('Show More')."\xE2\x80\xA6)";
       if ($this->expandtext !== null) {
         $text = $this->expandtext;
       }
diff --git a/src/view/layout/AphrontMultiColumnView.php b/src/view/layout/AphrontMultiColumnView.php
index 6705b89126..dfd5f81764 100644
--- a/src/view/layout/AphrontMultiColumnView.php
+++ b/src/view/layout/AphrontMultiColumnView.php
@@ -67,7 +67,7 @@ final class AphrontMultiColumnView extends AphrontView {
     if ($this->fluidishLayout || $this->fluidLayout) {
       // we only support seven columns for now for fluid views; see T4054
       if (count($this->columns) > 7) {
-        throw new Exception('No more than 7 columns per view.');
+        throw new Exception(pht('No more than 7 columns per view.'));
       }
     }
 
diff --git a/src/view/layout/PhabricatorActionView.php b/src/view/layout/PhabricatorActionView.php
index 65dd5f146f..43f84495c7 100644
--- a/src/view/layout/PhabricatorActionView.php
+++ b/src/view/layout/PhabricatorActionView.php
@@ -139,7 +139,9 @@ final class PhabricatorActionView extends AphrontView {
       if ($this->renderAsForm) {
         if (!$this->user) {
           throw new Exception(
-            'Call setUser() when rendering an action as a form.');
+            pht(
+              'Call %s when rendering an action as a form.',
+              'setUser()'));
         }
 
         $item = javelin_tag(
@@ -155,7 +157,7 @@ final class PhabricatorActionView extends AphrontView {
             'action'    => $this->getHref(),
             'method'    => 'POST',
             'sigil'     => $sigils,
-            'meta' => $this->metadata,
+            'meta'      => $this->metadata,
           ),
           $item);
       } else {
diff --git a/src/view/page/PhabricatorStandardPageView.php b/src/view/page/PhabricatorStandardPageView.php
index 7c5dcaf1cb..8033ef3c72 100644
--- a/src/view/page/PhabricatorStandardPageView.php
+++ b/src/view/page/PhabricatorStandardPageView.php
@@ -159,7 +159,8 @@ final class PhabricatorStandardPageView extends PhabricatorBarePageView {
     if (!$this->getRequest()) {
       throw new Exception(
         pht(
-          'You must set the Request to render a %s.',
+          'You must set the %s to render a %s.',
+          'Request',
           __CLASS__));
     }
 
diff --git a/src/view/phui/PHUIHeaderView.php b/src/view/phui/PHUIHeaderView.php
index 14159e500c..c87f1c4868 100644
--- a/src/view/phui/PHUIHeaderView.php
+++ b/src/view/phui/PHUIHeaderView.php
@@ -239,7 +239,7 @@ final class PHUIHeaderView extends AphrontTagView {
             $property_list[] = $property;
           break;
           default:
-            throw new Exception('Incorrect Property Passed');
+            throw new Exception(pht('Incorrect Property Passed'));
           break;
         }
       }
diff --git a/src/view/phui/PHUIObjectItemView.php b/src/view/phui/PHUIObjectItemView.php
index cc2753e26c..812fa993c2 100644
--- a/src/view/phui/PHUIObjectItemView.php
+++ b/src/view/phui/PHUIObjectItemView.php
@@ -189,7 +189,7 @@ final class PHUIObjectItemView extends AphrontTagView {
         $this->addIcon('fa-clock-o red', $date, $attr);
         break;
       default:
-        throw new Exception("Unknown age '{$age}'!");
+        throw new Exception(pht("Unknown age '%s'!", $age));
     }
 
     return $this;
@@ -197,7 +197,7 @@ final class PHUIObjectItemView extends AphrontTagView {
 
   public function addAction(PHUIListItemView $action) {
     if (count($this->actions) >= 3) {
-      throw new Exception('Limit 3 actions per item.');
+      throw new Exception(pht('Limit 3 actions per item.'));
     }
     $this->actions[] = $action;
     return $this;
@@ -686,6 +686,4 @@ final class PHUIObjectItemView extends AphrontTagView {
       '');
   }
 
-
-
 }
diff --git a/src/view/widget/hovercard/PhabricatorHovercardView.php b/src/view/widget/hovercard/PhabricatorHovercardView.php
index 58131a6a6b..e342feccee 100644
--- a/src/view/widget/hovercard/PhabricatorHovercardView.php
+++ b/src/view/widget/hovercard/PhabricatorHovercardView.php
@@ -2,7 +2,7 @@
 
 /**
  * The default one-for-all hovercard. We may derive from this one to create
- * more specialized ones
+ * more specialized ones.
  */
 final class PhabricatorHovercardView extends AphrontView {
 
diff --git a/support/aphlict/server/aphlict_launcher.php b/support/aphlict/server/aphlict_launcher.php
index 4af50a778b..8a550265bf 100755
--- a/support/aphlict/server/aphlict_launcher.php
+++ b/support/aphlict/server/aphlict_launcher.php
@@ -7,7 +7,7 @@ require_once $root.'/scripts/__init_script__.php';
 PhabricatorAphlictManagementWorkflow::requireExtensions();
 
 $args = new PhutilArgumentParser($argv);
-$args->setTagline('manage Aphlict notification server');
+$args->setTagline(pht('manage Aphlict notification server'));
 $args->setSynopsis(<<<EOSYNOPSIS
 **aphlict** __command__ [__options__]
     Manage the Aphlict server.
diff --git a/webroot/index.php b/webroot/index.php
index 7c417194a4..6bdcf51478 100644
--- a/webroot/index.php
+++ b/webroot/index.php
@@ -31,7 +31,6 @@ try {
       throw $ex;
     }
   }
-
 } catch (Exception $ex) {
   PhabricatorStartup::didEncounterFatalException('Core Exception', $ex, false);
 }