From 934246675ec28cdc76461e3c7d09de9070c0207d Mon Sep 17 00:00:00 2001 From: KorvinSzanto Date: Mon, 4 Jun 2012 20:05:46 -0700 Subject: [PATCH] Quick ircbot differential Summary: replace differential.find with differential.query and display in requested order Test Plan: say D444 D222 D443 D442 and ensure they are in the correct order Reviewers: epriestley Reviewed By: epriestley CC: Mnkras, aran Differential Revision: https://secure.phabricator.com/D2656 --- .../irc/handler/PhabricatorIRCObjectNameHandler.php | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/infrastructure/daemon/irc/handler/PhabricatorIRCObjectNameHandler.php b/src/infrastructure/daemon/irc/handler/PhabricatorIRCObjectNameHandler.php index ac6d6ab358..c78492f81a 100644 --- a/src/infrastructure/daemon/irc/handler/PhabricatorIRCObjectNameHandler.php +++ b/src/infrastructure/daemon/irc/handler/PhabricatorIRCObjectNameHandler.php @@ -100,11 +100,15 @@ final class PhabricatorIRCObjectNameHandler extends PhabricatorIRCHandler { if ($revision_ids) { $revisions = $this->getConduit()->callMethodSynchronous( - 'differential.find', + 'differential.query', array( 'query' => 'revision-ids', - 'guids' => $revision_ids, + 'ids' => $revision_ids, )); + $revisions = array_select_keys( + ipull($revisions, null, 'id'), + $revision_ids + ); foreach ($revisions as $revision) { $output[$revision['phid']] = 'D'.$revision['id'].' '.$revision['name'].' - '.