From c178f29cdb8be86686fe471e0aedbd541023a056 Mon Sep 17 00:00:00 2001 From: epriestley Date: Sun, 10 Apr 2016 03:54:12 -0700 Subject: [PATCH] Use new first-class MySQL timeout support in Phabricator Summary: Fixes T6710. After D15669, we support a proper timeout parameter, so we don't need this hack anymore. Test Plan: See D15669: forced a MySQL connector, set a low timeout, set a bad database, saw fast failures. Reviewers: chad Reviewed By: chad Maniphest Tasks: T6710 Differential Revision: https://secure.phabricator.com/D15670 --- src/infrastructure/cluster/PhabricatorDatabaseRef.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/infrastructure/cluster/PhabricatorDatabaseRef.php b/src/infrastructure/cluster/PhabricatorDatabaseRef.php index ef805f3f28..8e434e67f4 100644 --- a/src/infrastructure/cluster/PhabricatorDatabaseRef.php +++ b/src/infrastructure/cluster/PhabricatorDatabaseRef.php @@ -358,10 +358,6 @@ final class PhabricatorDatabaseRef 'timeout' => 15, ); - // TODO: Remove this once the MySQL connector has proper support - // for it, see T6710. - ini_set('mysql.connect_timeout', $spec['timeout']); - return PhabricatorEnv::newObjectFromConfig( 'mysql.implementation', array(