From c2b4ed1f7eaf8c3e51eeea1b3974e87a162d6bf1 Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@joshuaspence.com>
Date: Wed, 7 Jan 2015 07:38:08 +1100
Subject: [PATCH] Use `PhutilLibraryTestCase`

Summary: Depends on D11231.

Test Plan: `arc unit`

Reviewers: btrahan, #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11233
---
 src/__phutil_library_map__.php                |  2 ++
 .../PhabricatorInfrastructureTestCase.php     | 32 -------------------
 src/__tests__/PhabricatorLibraryTestCase.php  |  3 ++
 3 files changed, 5 insertions(+), 32 deletions(-)
 create mode 100644 src/__tests__/PhabricatorLibraryTestCase.php

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index 14bb3b4667..f2bb7a52e6 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -1861,6 +1861,7 @@ phutil_register_library_map(array(
     'PhabricatorLegalpadConfigOptions' => 'applications/legalpad/config/PhabricatorLegalpadConfigOptions.php',
     'PhabricatorLegalpadDocumentPHIDType' => 'applications/legalpad/phid/PhabricatorLegalpadDocumentPHIDType.php',
     'PhabricatorLegalpadSignaturePolicyRule' => 'applications/policy/rule/PhabricatorLegalpadSignaturePolicyRule.php',
+    'PhabricatorLibraryTestCase' => '__tests__/PhabricatorLibraryTestCase.php',
     'PhabricatorLipsumArtist' => 'applications/lipsum/image/PhabricatorLipsumArtist.php',
     'PhabricatorLipsumGenerateWorkflow' => 'applications/lipsum/management/PhabricatorLipsumGenerateWorkflow.php',
     'PhabricatorLipsumManagementWorkflow' => 'applications/lipsum/management/PhabricatorLipsumManagementWorkflow.php',
@@ -5062,6 +5063,7 @@ phutil_register_library_map(array(
     'PhabricatorLegalpadConfigOptions' => 'PhabricatorApplicationConfigOptions',
     'PhabricatorLegalpadDocumentPHIDType' => 'PhabricatorPHIDType',
     'PhabricatorLegalpadSignaturePolicyRule' => 'PhabricatorPolicyRule',
+    'PhabricatorLibraryTestCase' => 'PhutilLibraryTestCase',
     'PhabricatorLipsumGenerateWorkflow' => 'PhabricatorLipsumManagementWorkflow',
     'PhabricatorLipsumManagementWorkflow' => 'PhabricatorManagementWorkflow',
     'PhabricatorLipsumMondrianArtist' => 'PhabricatorLipsumArtist',
diff --git a/src/__tests__/PhabricatorInfrastructureTestCase.php b/src/__tests__/PhabricatorInfrastructureTestCase.php
index 88c7b07418..896a506ed3 100644
--- a/src/__tests__/PhabricatorInfrastructureTestCase.php
+++ b/src/__tests__/PhabricatorInfrastructureTestCase.php
@@ -8,38 +8,6 @@ final class PhabricatorInfrastructureTestCase extends PhabricatorTestCase {
     );
   }
 
-  /**
-   * This is more of an acceptance test case instead of a unit test. It verifies
-   * that all symbols can be loaded correctly. It can catch problems like
-   * missing methods in descendants of abstract base classes.
-   */
-  public function testEverythingImplemented() {
-    id(new PhutilSymbolLoader())->selectAndLoadSymbols();
-    $this->assertTrue(true);
-  }
-
-  /**
-   * This is more of an acceptance test case instead of a unit test. It verifies
-   * that all the library map is up-to-date.
-   */
-  public function testLibraryMap() {
-    $library = phutil_get_current_library_name();
-    $root = phutil_get_library_root($library);
-
-    $new_library_map = id(new PhutilLibraryMapBuilder($root))
-      ->buildMap();
-
-    $bootloader = PhutilBootloader::getInstance();
-    $old_library_map = $bootloader->getLibraryMapWithoutExtensions($library);
-    unset($old_library_map[PhutilLibraryMapBuilder::LIBRARY_MAP_VERSION_KEY]);
-
-    $this->assertEqual(
-      $new_library_map,
-      $old_library_map,
-      'The library map does not appear to be up-to-date. Try '.
-      'rebuilding the map with `arc liberate`.');
-  }
-
   public function testApplicationsInstalled() {
     $all = PhabricatorApplication::getAllApplications();
     $installed = PhabricatorApplication::getAllInstalledApplications();
diff --git a/src/__tests__/PhabricatorLibraryTestCase.php b/src/__tests__/PhabricatorLibraryTestCase.php
new file mode 100644
index 0000000000..61ffdb00a5
--- /dev/null
+++ b/src/__tests__/PhabricatorLibraryTestCase.php
@@ -0,0 +1,3 @@
+<?php
+
+final class PhabricatorLibraryTestCase extends PhutilLibraryTestCase {}