From c509e80a74f1af230dcafff7e600c87c9f5d09dd Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 21 Apr 2015 15:38:52 -0700 Subject: [PATCH] Fix an issue where versus diffs tried to load invalid changeset IDs Auditors: btrahan --- .../differential/storage/DifferentialRevision.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/applications/differential/storage/DifferentialRevision.php b/src/applications/differential/storage/DifferentialRevision.php index de8e08dcdc..77afebd278 100644 --- a/src/applications/differential/storage/DifferentialRevision.php +++ b/src/applications/differential/storage/DifferentialRevision.php @@ -494,8 +494,8 @@ final class DifferentialRevision extends DifferentialDAO $old_ids = $request->getStr('old', idx($render_data, 'old')); $new_ids = $request->getStr('new', idx($render_data, 'new')); - $old_ids = explode(',', $old_ids); - $new_ids = explode(',', $new_ids); + $old_ids = array_filter(explode(',', $old_ids)); + $new_ids = array_filter(explode(',', $new_ids)); $type_inline = DifferentialTransaction::TYPE_INLINE; $changeset_ids = array_merge($old_ids, $new_ids);