diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php index afcd2fd02a..9cc36962a7 100644 --- a/src/__phutil_library_map__.php +++ b/src/__phutil_library_map__.php @@ -238,6 +238,7 @@ phutil_register_library_map(array( 'DifferentialDateModifiedFieldSpecification' => 'applications/differential/field/specification/DifferentialDateModifiedFieldSpecification.php', 'DifferentialDefaultFieldSelector' => 'applications/differential/field/selector/DifferentialDefaultFieldSelector.php', 'DifferentialDependenciesFieldSpecification' => 'applications/differential/field/specification/DifferentialDependenciesFieldSpecification.php', + 'DifferentialDependsOnFieldSpecification' => 'applications/differential/field/specification/DifferentialDependsOnFieldSpecification.php', 'DifferentialDiff' => 'applications/differential/storage/DifferentialDiff.php', 'DifferentialDiffContentMail' => 'applications/differential/mail/DifferentialDiffContentMail.php', 'DifferentialDiffCreateController' => 'applications/differential/controller/DifferentialDiffCreateController.php', @@ -1420,6 +1421,7 @@ phutil_register_library_map(array( 'DifferentialDateModifiedFieldSpecification' => 'DifferentialFieldSpecification', 'DifferentialDefaultFieldSelector' => 'DifferentialFieldSelector', 'DifferentialDependenciesFieldSpecification' => 'DifferentialFieldSpecification', + 'DifferentialDependsOnFieldSpecification' => 'DifferentialFieldSpecification', 'DifferentialDiff' => 'DifferentialDAO', 'DifferentialDiffContentMail' => 'DifferentialMail', 'DifferentialDiffCreateController' => 'DifferentialController', diff --git a/src/applications/differential/field/selector/DifferentialDefaultFieldSelector.php b/src/applications/differential/field/selector/DifferentialDefaultFieldSelector.php index 5a7a937e9e..c0117a17c4 100644 --- a/src/applications/differential/field/selector/DifferentialDefaultFieldSelector.php +++ b/src/applications/differential/field/selector/DifferentialDefaultFieldSelector.php @@ -32,6 +32,7 @@ final class DifferentialDefaultFieldSelector new DifferentialLintFieldSpecification(), new DifferentialUnitFieldSpecification(), new DifferentialCommitsFieldSpecification(), + new DifferentialDependsOnFieldSpecification(), new DifferentialDependenciesFieldSpecification(), new DifferentialManiphestTasksFieldSpecification(), new DifferentialHostFieldSpecification(), diff --git a/src/applications/differential/field/specification/DifferentialDependenciesFieldSpecification.php b/src/applications/differential/field/specification/DifferentialDependenciesFieldSpecification.php index 2987533226..731d6c3ac1 100644 --- a/src/applications/differential/field/specification/DifferentialDependenciesFieldSpecification.php +++ b/src/applications/differential/field/specification/DifferentialDependenciesFieldSpecification.php @@ -28,7 +28,7 @@ final class DifferentialDependenciesFieldSpecification } public function renderLabelForRevisionView() { - return 'Depends On:'; + return 'Dependents:'; } public function renderValueForRevisionView() { @@ -48,7 +48,7 @@ final class DifferentialDependenciesFieldSpecification private function getDependentRevisionPHIDs() { return PhabricatorEdgeQuery::loadDestinationPHIDs( $this->getRevision()->getPHID(), - PhabricatorEdgeConfig::TYPE_DREV_DEPENDS_ON_DREV); + PhabricatorEdgeConfig::TYPE_DREV_DEPENDED_ON_BY_DREV); } } diff --git a/src/applications/differential/field/specification/DifferentialDependsOnFieldSpecification.php b/src/applications/differential/field/specification/DifferentialDependsOnFieldSpecification.php new file mode 100644 index 0000000000..1f0b7299b1 --- /dev/null +++ b/src/applications/differential/field/specification/DifferentialDependsOnFieldSpecification.php @@ -0,0 +1,54 @@ +getDependentRevisionPHIDs(); + } + + public function renderLabelForRevisionView() { + return 'Depends On:'; + } + + public function renderValueForRevisionView() { + $revision_phids = $this->getDependentRevisionPHIDs(); + if (!$revision_phids) { + return null; + } + + $links = array(); + foreach ($revision_phids as $revision_phids) { + $links[] = $this->getHandle($revision_phids)->renderLink(); + } + + return implode('
', $links); + } + + private function getDependentRevisionPHIDs() { + return PhabricatorEdgeQuery::loadDestinationPHIDs( + $this->getRevision()->getPHID(), + PhabricatorEdgeConfig::TYPE_DREV_DEPENDS_ON_DREV); + } + +}