From c71873ed7b31438a4585c5516a259a2d2a89651f Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 11 Jun 2015 10:23:20 -0700 Subject: [PATCH] Fix feed query cursor-based pagination on 32-bit systems Summary: Fixes T8503. On 32-bit systems, these 64-bit integers will be mangled by the '%d' conversion implied by the 'int' type. Test Plan: Somewhat guessing here since I don't have a 32-bit system handy, but this strongly echoes similar issues in the past. Feed works fine locally. Looked at the generated queries. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T8503 Differential Revision: https://secure.phabricator.com/D13250 --- src/applications/feed/query/PhabricatorFeedQuery.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/feed/query/PhabricatorFeedQuery.php b/src/applications/feed/query/PhabricatorFeedQuery.php index b9c7d099aa..13cfb266ed 100644 --- a/src/applications/feed/query/PhabricatorFeedQuery.php +++ b/src/applications/feed/query/PhabricatorFeedQuery.php @@ -101,7 +101,7 @@ final class PhabricatorFeedQuery 'key' => array( 'table' => $table, 'column' => 'chronologicalKey', - 'type' => 'int', + 'type' => 'string', 'unique' => true, ), );