archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Display Show Raw File links in Differential only if the file exists

Browse Source 
Test Plan:
Open menu for added file
Open menu for deleted file
Open menu for changed file

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1410
This commit is contained in:
vrana
2012-01-15 21:18:07 -08:00
parent 025cc1376e
commit c7997e0a7c
4 changed files with 47 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/applications/differential/view/changesetlistview/DifferentialChangesetListView.php
View File

@@ -118,17 +118,25 @@ class DifferentialChangesetListView extends AphrontView {
$changeset->getAbsoluteRepositoryPath($this->diff, $repository));
}
$meta = array(
'detailURI' => (string)$detail_uri,
'diffusionURI' => $diffusion_uri,
'containerID' => $detail->getID(),
);
$change = $changeset->getChangeType();
if ($change != DifferentialChangeType::TYPE_ADD) {
$meta['leftURI'] = (string)$detail_uri->alter('view', 'old');
}
if ($change != DifferentialChangeType::TYPE_DELETE &&
$change != DifferentialChangeType::TYPE_MULTICOPY) {
$meta['rightURI'] = (string)$detail_uri->alter('view', 'new');
}
$detail_button = javelin_render_tag(
'a',
array(
'class' => 'button small grey',
'meta' => array(
'detailURI' => (string)$detail_uri,
'leftURI' => (string)$detail_uri->alter('view', 'old'),
'rightURI' => (string)$detail_uri->alter('view', 'new'),
'diffusionURI' => $diffusion_uri,
'containerID' => $detail->getID(),
),
'meta' => $meta,
'href' => $detail_uri,
'target' => '_blank',
'sigil' => 'differential-view-options',