From c86604bad853d72a3ee6c22d9b80f7b531a24fa7 Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@joshuaspence.com>
Date: Tue, 3 Jun 2014 11:46:43 -0700
Subject: [PATCH] Reduce the verbosity of the `./bin/search index` script.

Summary: Currently, the `./bin/search index` script produces a lot of output (one line for every indexed object). Instead, use a `PhutilConsoleProgressBar` to indicate progress. This is much less verbose and gives a real indication of how long the script should take to complete.

Test Plan: Ran `./bin/search index` and verified that a progress bar was output.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9364
---
 ...abricatorSearchManagementIndexWorkflow.php | 27 ++++++++++---------
 1 file changed, 15 insertions(+), 12 deletions(-)

diff --git a/src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php b/src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php
index dd608cd444..63df499bc5 100644
--- a/src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php
+++ b/src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php
@@ -62,8 +62,7 @@ final class PhabricatorSearchManagementIndexWorkflow
     }
 
     if (!$phids) {
-      throw new PhutilArgumentUsageException(
-        "Nothing to index!");
+      throw new PhutilArgumentUsageException('Nothing to index!');
     }
 
     if ($args->getArg('background')) {
@@ -73,27 +72,31 @@ final class PhabricatorSearchManagementIndexWorkflow
       $is_background = false;
     }
 
+    if (!$is_background) {
+      $console->writeOut(
+        "%s\n",
+        pht(
+          'Run this workflow with "--background" to queue tasks for the '.
+          'daemon workers.'));
+    }
+
     $groups = phid_group_by_type($phids);
     foreach ($groups as $group_type => $group) {
       $console->writeOut(
         "%s\n",
-        pht(
-          "Indexing %d object(s) of type %s.",
-          count($group),
-          $group_type));
+        pht('Indexing %d object(s) of type %s.', count($group), $group_type));
     }
 
+    $bar = id(new PhutilConsoleProgressBar())
+      ->setTotal(count($phids));
+
     $indexer = new PhabricatorSearchIndexer();
     foreach ($phids as $phid) {
-      if ($is_background) {
-        $console->writeOut("%s\n", pht("Queueing '%s'...", $phid));
-      } else {
-        $console->writeOut("%s\n", pht("Indexing '%s'...", $phid));
-      }
       $indexer->queueDocumentForIndexing($phid);
+      $bar->update(1);
     }
 
-    $console->writeOut("Done.\n");
+    $bar->done();
   }
 
   private function loadPHIDsByNames(array $names) {