Remove viewPolicy from Badges

Summary: Drops the sql column.

Test Plan: View logged in and logged out badges, edited some too.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D13715

resources/sql/autopatches/20150725.badges.viewpolicy.3.sql

@@ -0,0 +1,2 @@
+ALTER TABLE {$NAMESPACE}_badges.badges_badge
+  DROP COLUMN viewPolicy;

src/applications/badges/storage/PhabricatorBadgesBadge.php

@@ -14,7 +14,6 @@ final class PhabricatorBadgesBadge extends PhabricatorBadgesDAO
   protected $icon;
   protected $quality;
   protected $mailKey;
-  protected $viewPolicy;
   protected $editPolicy;
   protected $status;
   protected $creatorPHID;
@@ -73,7 +72,6 @@ final class PhabricatorBadgesBadge extends PhabricatorBadgesDAO
       ->setIcon(self::DEFAULT_ICON)
       ->setQuality(self::DEFAULT_QUALITY)
       ->setCreatorPHID($actor->getPHID())
-      ->setViewPolicy($view_policy)
       ->setEditPolicy($edit_policy)
       ->setStatus(self::STATUS_OPEN);
   }