From ca042df6deace3b38a8ffa4fa1e4406f3393eb45 Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@joshuaspence.com>
Date: Tue, 17 Mar 2015 22:19:02 +1100
Subject: [PATCH] Minor change to suppress linter warning

Summary: Rewrite this expression so that the second parameter to `qsprintf` is a scalar.

Test Plan: `arc lint`

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11913
---
 src/applications/feed/query/PhabricatorFeedQuery.php | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/applications/feed/query/PhabricatorFeedQuery.php b/src/applications/feed/query/PhabricatorFeedQuery.php
index 1d88d4e980..7e610e4483 100644
--- a/src/applications/feed/query/PhabricatorFeedQuery.php
+++ b/src/applications/feed/query/PhabricatorFeedQuery.php
@@ -83,11 +83,11 @@ final class PhabricatorFeedQuery
   }
 
   private function buildGroupClause(AphrontDatabaseConnection $conn_r) {
-    return qsprintf(
-      $conn_r,
-      'GROUP BY '.($this->filterPHIDs
-        ? 'ref.chronologicalKey'
-        : 'story.chronologicalKey'));
+    if ($this->filterPHIDs) {
+      return qsprintf($conn_r, 'GROUP BY ref.chronologicalKey');
+    } else {
+      return qsprintf($conn_r, 'GROUP BY story.chronologicalKey');
+    }
   }
 
   protected function getPagingColumn() {