From ccbb8afe97153949deb8d8e96ce1c793d02bab34 Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 24 Jul 2013 10:47:30 -0700 Subject: [PATCH] Bucket Asana parent tasks by "assignee_status" Summary: Ref T2852. When the parent task is actionable (needs revision, accepted) give it an "Upcoming" status; otherwise give it a "Later" status. Test Plan: Sync'd "Needs Revision" and "Needs Review" tasks and saw them both bucket correctly Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2852 Differential Revision: https://secure.phabricator.com/D6551 --- .../doorkeeper/worker/DoorkeeperFeedWorkerAsana.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/applications/doorkeeper/worker/DoorkeeperFeedWorkerAsana.php b/src/applications/doorkeeper/worker/DoorkeeperFeedWorkerAsana.php index 4049ae727f..afc0b8e3a4 100644 --- a/src/applications/doorkeeper/worker/DoorkeeperFeedWorkerAsana.php +++ b/src/applications/doorkeeper/worker/DoorkeeperFeedWorkerAsana.php @@ -306,6 +306,12 @@ final class DoorkeeperFeedWorkerAsana extends FeedPushWorker { 'POST', array( 'workspace' => $workspace_id, + // NOTE: We initially create parent tasks in the "Later" state but + // don't update it afterward, even if the corresponding object + // becomes actionable. The expectation is that users will prioritize + // tasks in responses to notifications of state changes, and that + // we should not overwrite their choices. + 'assignee_status' => 'later', ) + $main_data); $parent_ref = $this->newRefFromResult( DoorkeeperBridgeAsana::OBJTYPE_TASK,